| *** shaohe_feng has quit IRC | 00:04 | |
| cfriesen_ | how much is "slightly higher"? | 00:05 |
|---|---|---|
| *** shaohe_feng has joined #openstack-nova | 00:05 | |
| *** wolverineav has quit IRC | 00:06 | |
| *** wolverineav has joined #openstack-nova | 00:07 | |
| *** liuyulong has quit IRC | 00:08 | |
| *** artom has joined #openstack-nova | 00:09 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** medberry has joined #openstack-nova | 00:11 | |
| *** hongbin has joined #openstack-nova | 00:12 | |
| *** wolverineav has quit IRC | 00:14 | |
| *** hamzy_ has joined #openstack-nova | 00:14 | |
| *** shaohe_feng has quit IRC | 00:14 | |
| eandersson | cfriesen_, 2GB for ~128gb and 4GB for 256GB | 00:15 |
| *** shaohe_feng has joined #openstack-nova | 00:15 | |
| *** slaweq has quit IRC | 00:16 | |
| *** takashin has joined #openstack-nova | 00:18 | |
| *** gongysh has quit IRC | 00:24 | |
| *** shaohe_feng has quit IRC | 00:25 | |
| *** shaohe_feng has joined #openstack-nova | 00:25 | |
| *** wolverineav has joined #openstack-nova | 00:26 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (5) https://review.openstack.org/570842 | 00:27 |
| *** liuyulong has joined #openstack-nova | 00:28 | |
| *** wolverineav has quit IRC | 00:28 | |
| *** BrinZhang has joined #openstack-nova | 00:30 | |
| *** wolverineav has joined #openstack-nova | 00:32 | |
| *** shaohe_feng has quit IRC | 00:35 | |
| *** dave-mcc_ has quit IRC | 00:35 | |
| *** dklyle_ has quit IRC | 00:36 | |
| *** dklyle has joined #openstack-nova | 00:36 | |
| *** wolverineav has quit IRC | 00:36 | |
| *** shaohe_feng has joined #openstack-nova | 00:36 | |
| *** wolverineav has joined #openstack-nova | 00:40 | |
| eandersson | cfriesen_, basically in libvirt 1.x virsh nodeinfo and virsh nodememstats shows the same memory size | 00:41 |
| eandersson | but in 2+ the size is different (at least on our machines) | 00:41 |
| mriedem | cfriesen_: shouldn't, unless it's a reschedule | 00:43 |
| mriedem | in which case the compute doesn't pass the reqspec back up | 00:43 |
| mriedem | i have a patch for that | 00:43 |
| mriedem | cfriesen_: https://review.openstack.org/#/c/582417/ | 00:43 |
| mriedem | needs an rpc api change | 00:43 |
| mriedem | cfriesen_: but starting in queens we wouldn't call back to the scheduler on a reschedule because we have alternate hosts from the top level scheduling call | 00:45 |
| mriedem | and any instance created after newton would have a request spec, so that first RequestSpecNotFound block shouldn't be hit | 00:45 |
| *** shaohe_feng has quit IRC | 00:45 | |
| *** wolverineav has quit IRC | 00:45 | |
| *** shaohe_feng has joined #openstack-nova | 00:46 | |
| mriedem | cfriesen_: yeah i can't see how http://paste.openstack.org/show/726559/ is needed b/c the request spec has the original pci requests and that's what the scheduler filter uses | 00:46 |
| mriedem | and anything on the compute which claims using instance.pci_requests would lazy-load it | 00:46 |
| *** wolverineav has joined #openstack-nova | 00:49 | |
| *** wolverineav has quit IRC | 00:54 | |
| *** shaohe_feng has quit IRC | 00:55 | |
| *** shaohe_feng has joined #openstack-nova | 00:57 | |
| *** wolverineav has joined #openstack-nova | 01:03 | |
| *** phuongnh has joined #openstack-nova | 01:03 | |
| *** phuongnh has quit IRC | 01:04 | |
| *** phuongnh has joined #openstack-nova | 01:04 | |
| *** shaohe_feng has quit IRC | 01:06 | |
| *** shaohe_feng has joined #openstack-nova | 01:07 | |
| *** wolverineav has quit IRC | 01:08 | |
| Kevin_Zheng | mriedem, do you have a minute? I need some help on https://review.openstack.org/#/c/583927/ | 01:11 |
| *** slaweq has joined #openstack-nova | 01:11 | |
| *** mrsoul has joined #openstack-nova | 01:14 | |
| *** shaohe_feng has quit IRC | 01:16 | |
| *** slaweq has quit IRC | 01:16 | |
| *** GonZo2000 has quit IRC | 01:17 | |
| *** shaohe_feng has joined #openstack-nova | 01:17 | |
| *** mrsoul` has quit IRC | 01:17 | |
| *** yedongcan has joined #openstack-nova | 01:21 | |
| *** wolverineav has joined #openstack-nova | 01:21 | |
| *** wolverineav has quit IRC | 01:22 | |
| *** artom has quit IRC | 01:23 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (6) https://review.openstack.org/571330 | 01:26 |
| *** shaohe_feng has quit IRC | 01:26 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7) https://review.openstack.org/571992 | 01:26 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8) https://review.openstack.org/571993 | 01:27 |
| *** shaohe_feng has joined #openstack-nova | 01:27 | |
| openstackgerrit | Merged openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | 01:27 |
| *** wolverineav has joined #openstack-nova | 01:28 | |
| *** links has joined #openstack-nova | 01:30 | |
| *** wolverineav has quit IRC | 01:32 | |
| *** wolverineav has joined #openstack-nova | 01:34 | |
| *** dave-mccowan has joined #openstack-nova | 01:35 | |
| *** tiendc has joined #openstack-nova | 01:35 | |
| *** shaohe_feng has quit IRC | 01:36 | |
| *** shaohe_feng has joined #openstack-nova | 01:37 | |
| *** wolverineav has quit IRC | 01:39 | |
| *** wolverineav has joined #openstack-nova | 01:41 | |
| *** yamahata has quit IRC | 01:43 | |
| *** trungnv has quit IRC | 01:46 | |
| *** trungnv has joined #openstack-nova | 01:46 | |
| *** shaohe_feng has quit IRC | 01:47 | |
| *** lei-zh has joined #openstack-nova | 01:47 | |
| *** shaohe_feng has joined #openstack-nova | 01:48 | |
| *** wolverineav has quit IRC | 01:49 | |
| *** gyee has quit IRC | 01:55 | |
| *** shaohe_feng has quit IRC | 01:57 | |
| *** shaohe_feng has joined #openstack-nova | 01:57 | |
| *** wolverineav has joined #openstack-nova | 01:59 | |
| *** gbarros has joined #openstack-nova | 02:02 | |
| *** wolverineav has quit IRC | 02:04 | |
| *** shaohe_feng has quit IRC | 02:07 | |
| *** shaohe_feng has joined #openstack-nova | 02:09 | |
| *** medberry has quit IRC | 02:11 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| *** gbarros has quit IRC | 02:12 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:13 | |
| *** yamahata has joined #openstack-nova | 02:15 | |
| *** slaweq has quit IRC | 02:16 | |
| *** wolverineav has joined #openstack-nova | 02:17 | |
| *** shaohe_feng has quit IRC | 02:17 | |
| *** tbachman has quit IRC | 02:18 | |
| *** shaohe_feng has joined #openstack-nova | 02:20 | |
| *** sapd has joined #openstack-nova | 02:21 | |
| *** wolverineav has quit IRC | 02:23 | |
| *** shaohe_feng has quit IRC | 02:28 | |
| *** wolverineav has joined #openstack-nova | 02:29 | |
| *** shaohe_feng has joined #openstack-nova | 02:29 | |
| *** dave-mccowan has quit IRC | 02:29 | |
| *** dave-mccowan has joined #openstack-nova | 02:30 | |
| *** gongysh has joined #openstack-nova | 02:30 | |
| *** alexpilo_ has joined #openstack-nova | 02:32 | |
| *** wolverineav has quit IRC | 02:33 | |
| *** StevenK has quit IRC | 02:35 | |
| *** alexpilotti has quit IRC | 02:35 | |
| *** StevenK has joined #openstack-nova | 02:35 | |
| *** alexpilo_ has quit IRC | 02:36 | |
| *** shaohe_feng has quit IRC | 02:38 | |
| *** shaohe_feng has joined #openstack-nova | 02:40 | |
| *** alexpilotti has joined #openstack-nova | 02:41 | |
| *** jmlowe has joined #openstack-nova | 02:43 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform volume.usage notification https://review.openstack.org/580345 | 02:44 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform libvirt.error notification https://review.openstack.org/484851 | 02:44 |
| *** tbachman has joined #openstack-nova | 02:45 | |
| *** tbachman has quit IRC | 02:46 | |
| *** shaohe_feng has quit IRC | 02:48 | |
| *** shaohe_feng has joined #openstack-nova | 02:48 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge server usage extension response into server view builder https://review.openstack.org/585262 | 02:53 |
| *** brault has quit IRC | 02:53 | |
| *** tbachman has joined #openstack-nova | 02:56 | |
| *** brault has joined #openstack-nova | 02:57 | |
| *** shaohe_feng has quit IRC | 02:58 | |
| *** sapd has quit IRC | 02:58 | |
| *** shaohe_feng has joined #openstack-nova | 02:59 | |
| *** takashin has left #openstack-nova | 03:01 | |
| vishakha | stephenfin, Hi. Are you working on https://bugs.launchpad.net/nova/+bug/1651319 ?? | 03:06 |
| openstack | Launchpad bug 1651319 in OpenStack Compute (nova) ""nova list --delete" failed due to InstanceNotFound exception" [Undecided,In progress] - Assigned to Stephen Finucane (stephenfinucane) | 03:06 |
| *** sapd has joined #openstack-nova | 03:07 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add the guideline to write API reference https://review.openstack.org/569058 | 03:08 |
| *** shaohe_feng has quit IRC | 03:09 | |
| *** dave-mcc_ has joined #openstack-nova | 03:09 | |
| *** shaohe_feng has joined #openstack-nova | 03:09 | |
| *** slaweq has joined #openstack-nova | 03:11 | |
| *** dave-mccowan has quit IRC | 03:12 | |
| *** dave-mcc_ has quit IRC | 03:12 | |
| *** armaan has joined #openstack-nova | 03:13 | |
| *** slaweq has quit IRC | 03:15 | |
| *** janki has joined #openstack-nova | 03:17 | |
| *** wolverineav has joined #openstack-nova | 03:17 | |
| *** shaohe_feng has quit IRC | 03:19 | |
| *** shaohe_feng has joined #openstack-nova | 03:20 | |
| *** wolverineav has quit IRC | 03:22 | |
| *** vladikr has quit IRC | 03:23 | |
| *** vladikr has joined #openstack-nova | 03:23 | |
| *** lei-zh has quit IRC | 03:28 | |
| *** zhurong has joined #openstack-nova | 03:29 | |
| *** vladikr has quit IRC | 03:29 | |
| *** lei-zh has joined #openstack-nova | 03:29 | |
| *** shaohe_feng has quit IRC | 03:29 | |
| *** vladikr has joined #openstack-nova | 03:30 | |
| *** shaohe_feng has joined #openstack-nova | 03:31 | |
| *** vladikr has quit IRC | 03:35 | |
| *** vladikr has joined #openstack-nova | 03:35 | |
| *** shaohe_feng has quit IRC | 03:39 | |
| *** shaohe_feng has joined #openstack-nova | 03:40 | |
| *** wolverineav has joined #openstack-nova | 03:40 | |
| *** vladikr has quit IRC | 03:41 | |
| *** vladikr has joined #openstack-nova | 03:42 | |
| *** vladikr has quit IRC | 03:47 | |
| *** vladikr has joined #openstack-nova | 03:47 | |
| *** wolverineav has quit IRC | 03:48 | |
| *** shaohe_feng has quit IRC | 03:50 | |
| *** wolverineav has joined #openstack-nova | 03:50 | |
| *** shaohe_feng has joined #openstack-nova | 03:51 | |
| *** lpetrut has joined #openstack-nova | 03:52 | |
| *** wolverineav has quit IRC | 03:55 | |
| *** vladikr has quit IRC | 03:55 | |
| *** vladikr has joined #openstack-nova | 03:56 | |
| *** shaohe_feng has quit IRC | 04:00 | |
| *** psachin` has joined #openstack-nova | 04:00 | |
| *** shaohe_feng has joined #openstack-nova | 04:01 | |
| *** tbachman has quit IRC | 04:04 | |
| *** psachin`` has joined #openstack-nova | 04:05 | |
| *** mschuppert has joined #openstack-nova | 04:06 | |
| *** psachin` has quit IRC | 04:07 | |
| *** shaohe_feng has quit IRC | 04:10 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| *** mdnadeem has joined #openstack-nova | 04:12 | |
| *** shaohe_feng has joined #openstack-nova | 04:12 | |
| *** wolverineav has joined #openstack-nova | 04:15 | |
| *** tbachman has joined #openstack-nova | 04:15 | |
| *** slaweq has quit IRC | 04:16 | |
| *** lei-zh has quit IRC | 04:17 | |
| *** armaan has quit IRC | 04:19 | |
| *** armaan has joined #openstack-nova | 04:20 | |
| *** wolverineav has quit IRC | 04:20 | |
| *** shaohe_feng has quit IRC | 04:20 | |
| *** shaohe_feng has joined #openstack-nova | 04:21 | |
| *** wolverineav has joined #openstack-nova | 04:22 | |
| *** wolverineav has quit IRC | 04:27 | |
| *** zhurong has quit IRC | 04:27 | |
| *** shaohe_feng has quit IRC | 04:31 | |
| *** s1061123 has quit IRC | 04:31 | |
| *** shaohe_feng has joined #openstack-nova | 04:31 | |
| *** wolverineav has joined #openstack-nova | 04:31 | |
| *** s1061123 has joined #openstack-nova | 04:36 | |
| *** tbachman has quit IRC | 04:37 | |
| *** r-daneel has joined #openstack-nova | 04:37 | |
| openstackgerrit | Merged openstack/nova master: compute: Ensure pre-migrating instances are destroyed during init_host https://review.openstack.org/562284 | 04:38 |
| *** udesale has joined #openstack-nova | 04:39 | |
| *** wolverineav has quit IRC | 04:40 | |
| *** hongbin has quit IRC | 04:40 | |
| *** shaohe_feng has quit IRC | 04:41 | |
| *** shaohe_feng has joined #openstack-nova | 04:42 | |
| *** lpetrut has quit IRC | 04:42 | |
| *** udesale has quit IRC | 04:42 | |
| *** udesale has joined #openstack-nova | 04:43 | |
| *** wolverineav has joined #openstack-nova | 04:49 | |
| *** shaohe_feng has quit IRC | 04:51 | |
| *** shaohe_feng has joined #openstack-nova | 04:52 | |
| *** wolverineav has quit IRC | 04:54 | |
| *** gongysh has quit IRC | 04:55 | |
| *** flwang1 has quit IRC | 04:56 | |
| *** armaan has quit IRC | 04:56 | |
| *** armaan has joined #openstack-nova | 04:56 | |
| *** hongbin has joined #openstack-nova | 04:58 | |
| openstackgerrit | Merged openstack/nova master: Add queued_for_delete field to InstanceMapping object https://review.openstack.org/566795 | 04:59 |
| *** hongbin has quit IRC | 05:00 | |
| *** tbachman has joined #openstack-nova | 05:00 | |
| *** shaohe_feng has quit IRC | 05:01 | |
| *** s1061123_ has joined #openstack-nova | 05:02 | |
| *** s1061123 has quit IRC | 05:03 | |
| *** wolverineav has joined #openstack-nova | 05:04 | |
| *** shaohe_feng has joined #openstack-nova | 05:05 | |
| *** wwriverrat has quit IRC | 05:05 | |
| *** s1061123_ has quit IRC | 05:09 | |
| *** s1061123 has joined #openstack-nova | 05:11 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** shaohe_feng has quit IRC | 05:12 | |
| *** tbachman has quit IRC | 05:12 | |
| *** wolverineav has quit IRC | 05:12 | |
| *** shaohe_feng has joined #openstack-nova | 05:13 | |
| *** udesale_ has joined #openstack-nova | 05:13 | |
| *** s1061123 has quit IRC | 05:14 | |
| *** lei-zh has joined #openstack-nova | 05:15 | |
| *** udesale has quit IRC | 05:15 | |
| *** slaweq has quit IRC | 05:15 | |
| *** s1061123 has joined #openstack-nova | 05:16 | |
| *** armaan has quit IRC | 05:17 | |
| *** armaan has joined #openstack-nova | 05:18 | |
| *** udesale_ has quit IRC | 05:19 | |
| *** udesale has joined #openstack-nova | 05:20 | |
| *** shaohe_feng has quit IRC | 05:22 | |
| *** ratailor has joined #openstack-nova | 05:22 | |
| *** shaohe_feng has joined #openstack-nova | 05:26 | |
| *** gongysh has joined #openstack-nova | 05:27 | |
| *** Guest85335 has quit IRC | 05:28 | |
| *** sridharg has joined #openstack-nova | 05:31 | |
| *** armaan has quit IRC | 05:32 | |
| *** shaohe_feng has quit IRC | 05:32 | |
| *** armaan has joined #openstack-nova | 05:32 | |
| *** shaohe_feng has joined #openstack-nova | 05:34 | |
| *** wolverineav has joined #openstack-nova | 05:38 | |
| *** Dinesh_Bhor has quit IRC | 05:38 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:38 | |
| *** wolverineav has quit IRC | 05:42 | |
| *** shaohe_feng has quit IRC | 05:42 | |
| *** shaohe_feng has joined #openstack-nova | 05:43 | |
| *** Eran_Kuris has joined #openstack-nova | 05:43 | |
| *** wolverineav has joined #openstack-nova | 05:52 | |
| *** shaohe_feng has quit IRC | 05:53 | |
| *** shaohe_feng has joined #openstack-nova | 05:54 | |
| *** wolverineav has quit IRC | 05:58 | |
| *** XueFeng has quit IRC | 06:00 | |
| *** wolverineav has joined #openstack-nova | 06:00 | |
| *** hoonetorg has quit IRC | 06:01 | |
| gmann | nova api office hour time | 06:01 |
| *** Dinesh_Bhor has quit IRC | 06:02 | |
| gmann | #startmeeting nova api | 06:02 |
| openstack | Meeting started Wed Jul 25 06:02:24 2018 UTC and is due to finish in 60 minutes. The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot. | 06:02 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 06:02 |
| *** openstack changes topic to " (Meeting topic: nova api)" | 06:02 | |
| openstack | The meeting name has been set to 'nova_api' | 06:02 |
| *** yamahata has quit IRC | 06:02 | |
| gmann | PING List: gmann, alex_xu | 06:02 |
| gmann | who all here today | 06:02 |
| *** yamahata has joined #openstack-nova | 06:02 | |
| *** shaohe_feng has quit IRC | 06:03 | |
| *** 3NAAATYZV has joined #openstack-nova | 06:03 | |
| *** shaohe_feng has joined #openstack-nova | 06:04 | |
| *** armaan has quit IRC | 06:04 | |
| *** annp has joined #openstack-nova | 06:05 | |
| *** armaan has joined #openstack-nova | 06:05 | |
| *** s1061123 has quit IRC | 06:07 | |
| *** luzC has quit IRC | 06:07 | |
| *** luzC has joined #openstack-nova | 06:07 | |
| Kevin_Zheng | o/ | 06:08 |
| gmann | Kevin_Zheng: hi | 06:08 |
| Kevin_Zheng | :) | 06:08 |
| *** wolverineav has quit IRC | 06:08 | |
| gmann | seems like 2 of us. let's wait couple of min | 06:08 |
| alex_xu | o/ | 06:08 |
| *** s1061123 has joined #openstack-nova | 06:08 | |
| gmann | alex_xu: hi | 06:09 |
| *** ccamacho has joined #openstack-nova | 06:09 | |
| alex_xu | gmann: good afternoon | 06:09 |
| gmann | good afternoon | 06:09 |
| gmann | let's start | 06:10 |
| gmann | #topic Priorities | 06:10 |
| *** openstack changes topic to "Priorities (Meeting topic: nova api)" | 06:10 | |
| gmann | #link https://etherpad.openstack.org/p/rocky-nova-priorities-tracking | 06:11 |
| gmann | L57 | 06:11 |
| openstackgerrit | Rajesh Tailor proposed openstack/nova master: Fix host validity check for live-migration https://review.openstack.org/401009 | 06:11 |
| *** slaweq has joined #openstack-nova | 06:11 | |
| gmann | 1. Servers Ips non-unique network names | 06:11 |
| *** 3NAAATYZV has quit IRC | 06:11 | |
| gmann | this one is no progress. i did not get time to start this due to extensions merge work | 06:11 |
| gmann | which mean this would not go in Rocky. and we need to carry this to Stein | 06:12 |
| gmann | 2.Abort live migration in queued state: | 06:13 |
| gmann | this is done, thanks Kevin_Zheng | 06:13 |
| *** shaohe_feng has quit IRC | 06:13 | |
| gmann | 3. Complex anti-affinity policies: | 06:13 |
| gmann | this is also done, thanks yikun | 06:13 |
| gmann | 4. Volume multiattach enhancements: | 06:14 |
| gmann | this is on same state. and most probably will be stein one | 06:14 |
| *** shaohe_feng has joined #openstack-nova | 06:15 | |
| gmann | 5. API Extensions merge work | 06:15 |
| *** tetsuro has quit IRC | 06:15 | |
| gmann | this is partially done | 06:15 |
| *** Luzi has joined #openstack-nova | 06:15 | |
| *** slaweq has quit IRC | 06:16 | |
| gmann | part-1 schema merge - Completed | 06:16 |
| gmann | part-2 server_create merge - last patch on gate | 06:16 |
| alex_xu | gmann: so we just done the server_create merge in Rocky, right? | 06:16 |
| gmann | alex_xu: yes, last patch is on gate - | 06:17 |
| gmann | #link https://review.openstack.org/#/c/583882/2 | 06:17 |
| gmann | trying to get this in | 06:17 |
| *** hoonetorg has joined #openstack-nova | 06:17 | |
| gmann | alex_xu: part-3 merging the view builder is left to merge. I have many of them up for review | 06:17 |
| gmann | #link https://review.openstack.org/#/q/topic:bp/api-extensions-merge-rocky+status:open | 06:18 |
| gmann | which will be in Stein i think. | 06:18 |
| gmann | alex_xu: ? | 06:18 |
| alex_xu | gmann: yea, just as mriedem said | 06:18 |
| gmann | yeah, it is too late to merge them and gate also not so good since last week | 06:19 |
| gmann | none of them are reviewed so i do not think they can make it | 06:19 |
| gmann | alex_xu: today is FF or tomorrow ? | 06:19 |
| alex_xu | tomorrow, our evening | 06:20 |
| *** tetsuro has joined #openstack-nova | 06:20 | |
| gmann | ok | 06:20 |
| *** tetsuro has quit IRC | 06:20 | |
| *** tetsuro has joined #openstack-nova | 06:20 | |
| *** abhishekk has joined #openstack-nova | 06:20 | |
| gmann | i have left for 3 patch to push to complete it but at least 6-7 total are left for review | 06:20 |
| vishakha | gmann, Hi, i've been working on the bug https://bugs.launchpad.net/nova/+bug/1644457 but i found out that key_pair is a special case in which in_use remains always 0 as seen here https://github.com/openstack/nova/blob/master/nova/quota.py#L189 | 06:21 |
| openstack | Launchpad bug 1644457 in OpenStack Compute (nova) "keypair quota error" [Medium,Confirmed] - Assigned to Vishakha Agarwal (vishakha.agarwal) | 06:21 |
| gmann | 7 up for review + 5 remaining to push | 06:21 |
| *** armaan has quit IRC | 06:22 | |
| gmann | vishakha: ok, let's discuss that during bug topic | 06:22 |
| *** armaan has joined #openstack-nova | 06:22 | |
| gmann | alex_xu: so we make final to postponed view builder to stein? | 06:22 |
| *** XueFeng has joined #openstack-nova | 06:22 | |
| alex_xu | gmann: yea, I think so, there are a lot of view builder, right? | 06:23 |
| alex_xu | #link https://review.openstack.org/#/q/topic:bp/handling-down-cell+(status:open+OR+status:merged) | 06:23 |
| alex_xu | ^this one is looking for your view builder change | 06:23 |
| *** shaohe_feng has quit IRC | 06:23 | |
| gmann | yeah, that makes this series easy | 06:23 |
| vishakha | gmann, ok | 06:23 |
| gmann | alex_xu: total 12 patches to get in (7 up for review + 5 need to push) | 06:24 |
| *** psachin`` has quit IRC | 06:24 | |
| alex_xu | gmann: doesn't sound we can make it in one day | 06:24 |
| *** shaohe_feng has joined #openstack-nova | 06:24 | |
| gmann | alex_xu: yes, not possible. | 06:25 |
| gmann | alex_xu: ok i will postponed them to stein. and will push them soon so that we can merge them early in stein | 06:25 |
| *** lpetrut has joined #openstack-nova | 06:26 | |
| gmann | and on same topic mriedem had query regarding moving the buildling of create_kwargs into helper method than in create() itself which makes it huge | 06:27 |
| gmann | and deprecating the extensions policy which we already done in queens and i will remove them in stein | 06:27 |
| gmann | moving the building of create_kwargs into helper can be discussed in stein as this is late to change them now in Rocky | 06:29 |
| gmann | alex_xu: i am not sure we should open another specless BP for stein or just merge them as it is. anyways Rocky BP needs to be closed anyways. | 06:30 |
| gmann | may be melwitt mriedem can suggest ^^ | 06:30 |
| alex_xu | gmann: yea, that should be a question for them | 06:32 |
| gmann | ok | 06:32 |
| gmann | let's move next | 06:32 |
| gmann | 6. Handling a down cell | 06:32 |
| gmann | #link https://review.openstack.org/#/q/topic:bp/handling-down-cell+(status:open+OR+status:merged) | 06:33 |
| gmann | actually i am not following this one. alex_xu you know if that is target for Rocky i mean can it make it by tomorrow ? | 06:33 |
| *** pcaruana has joined #openstack-nova | 06:33 | |
| *** shaohe_feng has quit IRC | 06:34 | |
| alex_xu | gmann: sounds like target to Rocky, at least we have spec for rocky http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/handling-down-cell.html | 06:34 |
| gmann | yeah | 06:34 |
| alex_xu | gmann: but looks like it starts very late | 06:34 |
| gmann | i saw mriedem comment of doing service list change also in same microversion of server list - #link https://review.openstack.org/#/c/584829/ | 06:35 |
| gmann | yea it is started late like me :) i also did start the extensions work too late due to QA things. | 06:35 |
| gmann | anyways let's see how far it will go tomorrow | 06:36 |
| *** wolverineav has joined #openstack-nova | 06:36 | |
| gmann | that is all Rokcy items | 06:36 |
| *** shaohe_feng has joined #openstack-nova | 06:36 | |
| *** sm806 has quit IRC | 06:36 | |
| gmann | next may be after FF, we can keep eyes on API bugs and Stein specs for review | 06:37 |
| gmann | #link https://review.openstack.org/#/q/project:openstack/nova-specs+status:open+message:%22apiimpact%22 | 06:37 |
| gmann | that's all on priority, anything else to discuss otherwise we move to bug discussion | 06:37 |
| gmann | seems no. let's move then | 06:39 |
| gmann | #topic Bug Triage/Discussion | 06:39 |
| *** openstack changes topic to "Bug Triage/Discussion (Meeting topic: nova api)" | 06:39 | |
| gmann | #link https://etherpad.openstack.org/p/nova-api-weekly-bug-report | 06:39 |
| gmann | curren total open bugs are 68. | 06:40 |
| Kevin_Zheng | omg | 06:40 |
| gmann | honestly saying i was getting less time for bugs due to extensions work but after FF i will give more time on this to burn it down to less | 06:41 |
| *** wolverineav has quit IRC | 06:41 | |
| gmann | 34 out of them are in-progress | 06:42 |
| gmann | vishakha: you wanted to discuss some bug? | 06:42 |
| *** wolverineav has joined #openstack-nova | 06:42 | |
| *** shaohe_feng has quit IRC | 06:44 | |
| vishakha | gmann, yes | 06:44 |
| *** shaohe_feng has joined #openstack-nova | 06:44 | |
| alex_xu | vishakha: can you reproduce it in master? the bug is reported in newton, and we change quota a lot recently, like we remove the commit, rollback stuff for cellv2 | 06:44 |
| vishakha | gmann, Hi, i've been working on the bug https://bugs.launchpad.net/nova/+bug/1644457 but i found out that key_pair is a special case in which in_use remains always 0 as seen here https://github.com/openstack/nova/blob/master/nova/quota.py#L189 | 06:44 |
| openstack | Launchpad bug 1644457 in OpenStack Compute (nova) "keypair quota error" [Medium,Confirmed] - Assigned to Vishakha Agarwal (vishakha.agarwal) | 06:44 |
| gmann | alex_xu: it seems key_pairs is in special case for in_use always 0 | 06:45 |
| gmann | #link https://github.com/openstack/nova/blob/master/nova/quota.py#L189 | 06:45 |
| vishakha | gmann, I have a doubt when adding a key to instance. It should come in 'in_use' of quota_usage? | 06:45 |
| *** wolverineav has quit IRC | 06:46 | |
| gmann | vishakha: is it reproducible on master as alex_xu asked | 06:48 |
| vishakha | gmann, yes it is | 06:48 |
| vishakha | alex_xu, the 'in_use' for keypair is coming 0 always | 06:49 |
| alex_xu | interesting... | 06:51 |
| alex_xu | I thought it should call this https://github.com/openstack/nova/blob/master/nova/quota.py#L1244 | 06:52 |
| *** shaohe_feng has quit IRC | 06:54 | |
| *** blkart has quit IRC | 06:55 | |
| alex_xu | vishakha: the `nova quota-show --detial` should show 0, but `nova quota-show --detail --user {user_id}` indeed should show the usage as my understand | 06:55 |
| alex_xu | vishakha: I'm not sure whether https://github.com/openstack/nova/blob/master/nova/quota.py#L189 missing a check for the user_id isn't None | 06:56 |
| gmann | yeah, db count id per user - https://github.com/openstack/nova/blob/e019be3724d949b1239c2cc3fbc00f1f69a3477c/nova/db/sqlalchemy/api.py#L3043 | 06:57 |
| gmann | s/id/it | 06:57 |
| *** shaohe_feng has joined #openstack-nova | 06:58 | |
| *** rcernin has quit IRC | 06:59 | |
| *** sahid has joined #openstack-nova | 07:01 | |
| vishakha | alex_xu, gmann : I have tried with --user parameter also, still showing 0 in_use | 07:02 |
| gmann | alex_xu: i found some context of doing it intentionally or say as per old behaviour | 07:03 |
| gmann | alex_xu: #link https://review.openstack.org/#/c/446239/3/nova/tests/unit/test_quota.py@1031 | 07:03 |
| *** sridharg has quit IRC | 07:04 | |
| *** tssurya has joined #openstack-nova | 07:04 | |
| *** shaohe_feng has quit IRC | 07:04 | |
| *** shaohe_feng has joined #openstack-nova | 07:05 | |
| alex_xu | gmann: interesting | 07:05 |
| gmann | may be we can fix that per user but sot sure we can fix it easily as melwitt metnioned on that reivew | 07:07 |
| alex_xu | gmann: it sounds make sense to show keypair for specific user, but for the server_group_member we really have no way to express that | 07:07 |
| gmann | yeah that per server group | 07:08 |
| *** rmart04 has joined #openstack-nova | 07:08 | |
| alex_xu | gmann: then do we need microversion :) | 07:09 |
| gmann | humm | 07:09 |
| *** ispp has joined #openstack-nova | 07:09 | |
| *** vladikr has quit IRC | 07:09 | |
| *** armaan has quit IRC | 07:09 | |
| *** armaan has joined #openstack-nova | 07:10 | |
| gmann | it change the behaviour but not sure we need microversion as it would not cause any backward incompatibility in iterface usage | 07:10 |
| alex_xu | gmann: but there is no way for the user to know whether the usage is valid in the deployment | 07:11 |
| *** slaweq has joined #openstack-nova | 07:11 | |
| sean-k-mooney | mriedem: melwitt regarding the noop plugin im just looking into it now. it looks related to how we dynamicaly load plugins here https://github.com/openstack/os-vif/blob/master/os_vif/__init__.py#L41-L49 | 07:12 |
| sean-k-mooney | mriedem: melwitt ill take a look at it now | 07:12 |
| *** vladikr has joined #openstack-nova | 07:12 | |
| gmann | yeah, that's true. | 07:12 |
| gmann | microversion bump can be done but then it cannot be backported if we want to. | 07:13 |
| alex_xu | gmann: we have user quota since long time ago, not sure whether is it always 0 | 07:14 |
| alex_xu | gmann: this bug is newton | 07:14 |
| *** armaan has quit IRC | 07:14 | |
| *** shaohe_feng has quit IRC | 07:15 | |
| alex_xu | gmann: or just send this question to maillist to get wider agreement | 07:15 |
| alex_xu | I'm really not good at answering the microversion question | 07:15 |
| *** slaweq has quit IRC | 07:16 | |
| gmann | alex_xu: you mean to ask for microversion bump or to fix the bug for showing the key_pair usage per suer ? | 07:16 |
| *** tesseract has joined #openstack-nova | 07:16 | |
| *** shaohe_feng has joined #openstack-nova | 07:16 | |
| *** slaweq has joined #openstack-nova | 07:16 | |
| alex_xu | gmann: both I guess since we already ask question, at least it make sense to show user qutoa for keypair for me | 07:17 |
| gmann | alex_xu: ok. | 07:17 |
| gmann | i can send the ML, tough i do not have full context of quota calculation background | 07:18 |
| *** XueFeng has quit IRC | 07:18 | |
| gmann | s/tough/though | 07:18 |
| alex_xu | I can help that | 07:18 |
| gmann | alex_xu: thanks, | 07:20 |
| gmann | alex_xu: you mean you can send mail or reply on the query i sent? | 07:20 |
| alex_xu | gmann: ethier works for me :) | 07:21 |
| *** ispp has quit IRC | 07:21 | |
| alex_xu | s/ethier/either/ | 07:22 |
| gmann | alex_xu: cool, I will bring the query on ML and then you can respond. thanks | 07:22 |
| alex_xu | gmann: got it, thanks | 07:22 |
| gmann | anything else on bug or we move next | 07:22 |
| gmann | #topic Open Discussion | 07:22 |
| *** openstack changes topic to "Open Discussion (Meeting topic: nova api)" | 07:22 | |
| vishakha | gmann, should I look for another? | 07:23 |
| gmann | vishakha: sorry did not conclude that. we are bringing your question on ML and their you can see the discussion or respond | 07:23 |
| vishakha | gmann, alex_xu : ok thanks | 07:23 |
| gmann | vishakha: yeah, if you can help on other bug also it will be great. if you are looking for more then you can choose from API one | 07:23 |
| *** rmart04_ has joined #openstack-nova | 07:24 | |
| gmann | vishakha: #link | 07:24 |
| gmann | https://bugs.launchpad.net/nova/+bugs?field.searchtext=&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_commenter=&field.subscriber=&field.structural_subscriber=&field.tag=api%20api-ref&field.tags_com | 07:24 |
| gmann | binator=ANY&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.has_no_blueprints.used=&field.has_no_blueprints=on&search=Search&orderby=-importance&start=0 | 07:24 |
| gmann | opps | 07:24 |
| vishakha | gmann, yes sure | 07:24 |
| gmann | anything else to discuss or we close the office hour | 07:24 |
| gmann | let's close then. | 07:25 |
| vishakha | gmann, just wanted you to review https://review.openstack.org/#/c/580271/ | 07:25 |
| Kevin_Zheng | me | 07:25 |
| gmann | Kevin_Zheng: go ahead | 07:25 |
| *** shaohe_feng has quit IRC | 07:25 | |
| Kevin_Zheng | Our product team found out a strange API behaviour | 07:25 |
| Kevin_Zheng | https://developer.openstack.org/api-ref/compute/#get-availability-zone-information | 07:25 |
| *** rmart04 has quit IRC | 07:25 | |
| *** rmart04_ is now known as rmart04 | 07:25 | |
| gmann | vishakha: sure, ll add in my list | 07:25 |
| Kevin_Zheng | there is a hosts field | 07:25 |
| Kevin_Zheng | and it will always be "null" | 07:25 |
| Kevin_Zheng | it was just added here: | 07:26 |
| Kevin_Zheng | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/availability_zone.py#L42 | 07:26 |
| Kevin_Zheng | so any particular reason why it is added? | 07:26 |
| Kevin_Zheng | Or should we just remove it | 07:26 |
| *** wolverineav has joined #openstack-nova | 07:27 | |
| *** shaohe_feng has joined #openstack-nova | 07:27 | |
| gmann | Kevin_Zheng: may be for consistency for GET and GET detail API | 07:27 |
| gmann | Kevin_Zheng: Detail give the host information | 07:28 |
| vishakha | gmann, Thanks :) | 07:28 |
| *** dtantsur|afk is now known as dtantsur | 07:28 | |
| Kevin_Zheng | but do we need this kind of consistency? | 07:28 |
| Kevin_Zheng | looks strange | 07:28 |
| gmann | #link https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/availability_zone.py#L91 | 07:28 |
| Kevin_Zheng | we do not have this kind of consistency in list server and list server details | 07:28 |
| *** lei-zh has quit IRC | 07:29 | |
| Kevin_Zheng | yeah, I know that, just think this is not necessary | 07:29 |
| gmann | ohk it is not get particular AZ | 07:29 |
| *** lei-zh has joined #openstack-nova | 07:29 | |
| gmann | we can remove but need microversion. what harm in keeping it ? | 07:29 |
| Kevin_Zheng | no harm, just found it strange | 07:30 |
| Kevin_Zheng | and the customer asks | 07:30 |
| Kevin_Zheng | so we have to tell them why it is like that all the time | 07:30 |
| gmann | i remember we kept it for v2.1 for compatibility | 07:30 |
| *** XueFeng has joined #openstack-nova | 07:30 | |
| Kevin_Zheng | So might be good to remove it in S? | 07:31 |
| Kevin_Zheng | with microversion | 07:31 |
| gmann | Kevin_Zheng: ok. i can note down this on API improvement etherpad (which i need to create yet)and then we can decide if we can fix this with other consistent changes | 07:32 |
| *** wolverineav has quit IRC | 07:32 | |
| Kevin_Zheng | yeah cool | 07:32 |
| gmann | microversion alone for this seems little overhead for me | 07:32 |
| Kevin_Zheng | yeah | 07:32 |
| *** wolverineav has joined #openstack-nova | 07:32 | |
| gmann | Kevin_Zheng: thanks for finding and reporting this. | 07:33 |
| Kevin_Zheng | NP, just solving our problems | 07:33 |
| gmann | anything else to discuss | 07:33 |
| gmann | ok let's close then | 07:34 |
| gmann | thanks everyone for joining | 07:34 |
| gmann | #endmeeting | 07:34 |
| *** openstack changes topic to "Current runways: abort-live-migration-in-queued-status / add-zvm-driver-rocky / glance-image-traits -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 07:34 | |
| openstackgerrit | Lucian Petrut proposed openstack/nova master: Hyper-V + OVS: plug vifs before starting VMs https://review.openstack.org/585661 | 07:34 |
| openstack | Meeting ended Wed Jul 25 07:34:39 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 07:34 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-07-25-06.02.html | 07:34 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-07-25-06.02.txt | 07:34 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-07-25-06.02.log.html | 07:34 |
| Kevin_Zheng | gmann a test related question | 07:34 |
| gmann | Kevin_Zheng: yup | 07:34 |
| Kevin_Zheng | https://review.openstack.org/#/c/583927/ I'm working on this | 07:35 |
| *** lpetrut_ has joined #openstack-nova | 07:35 | |
| *** shaohe_feng has quit IRC | 07:35 | |
| Kevin_Zheng | and Matt asked me to use a real mc backend instead of mock | 07:35 |
| Kevin_Zheng | Seems like it need to have some set_up besides just override the configs | 07:36 |
| gmann | checking | 07:36 |
| Kevin_Zheng | I have no clue how do it, do you have this kind of experience/ | 07:36 |
| Kevin_Zheng | ? | 07:36 |
| Kevin_Zheng | Thanks | 07:36 |
| *** wolverineav has quit IRC | 07:37 | |
| *** lpetrut has quit IRC | 07:38 | |
| *** shaohe_feng has joined #openstack-nova | 07:38 | |
| gmann | i have not done yet but trying to look | 07:39 |
| gmann | Kevin_Zheng: it did not work with dogpile.cache.memory also ? | 07:41 |
| gibi | mriedem: No worries, I didn't planned to have a meeting this week (either) http://lists.openstack.org/pipermail/openstack-dev/2018-July/132410.html | 07:41 |
| Kevin_Zheng | yeah, seems the backend is not working, the client can be correctly initialized, but no data was saved | 07:42 |
| *** ragiman has joined #openstack-nova | 07:42 | |
| Kevin_Zheng | so cannot retrive any data | 07:42 |
| *** cdent has joined #openstack-nova | 07:42 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:42 | |
| *** avolkov has joined #openstack-nova | 07:43 | |
| *** shaohe_feng has quit IRC | 07:45 | |
| *** shaohe_feng has joined #openstack-nova | 07:46 | |
| *** ispp has joined #openstack-nova | 07:47 | |
| openstackgerrit | Lucian Petrut proposed openstack/nova master: Hyper-V + OVS: plug vifs before starting VMs https://review.openstack.org/585661 | 07:50 |
| gmann | Kevin_Zheng: i was thinking expiration_time is missing but is defaulted here - https://github.com/openstack/nova/blob/ddc807f85aad4e3d2ed6434809325320c1c21281/nova/cache_utils.py#L69 | 07:53 |
| Kevin_Zheng | hmm, yeah | 07:53 |
| Kevin_Zheng | so you don't think we should do any setup action? | 07:54 |
| gmann | Kevin_Zheng: means? | 07:55 |
| Kevin_Zheng | I mean, do we need to setup the backend? | 07:55 |
| gmann | Kevin_Zheng: i do not think so | 07:55 |
| *** shaohe_feng has quit IRC | 07:56 | |
| Kevin_Zheng | hmm ok | 07:56 |
| Kevin_Zheng | Then I should check more on the params | 07:56 |
| gmann | let me dig into that. need to go for firstcontact SIG now. | 07:56 |
| Kevin_Zheng | NP, thanks anyway | 07:56 |
| gmann | ll check later and let you know | 07:56 |
| Kevin_Zheng | thanks | 07:56 |
| *** shaohe_feng has joined #openstack-nova | 07:57 | |
| *** vivsoni_ has joined #openstack-nova | 08:02 | |
| *** vivsoni has quit IRC | 08:02 | |
| *** alexchadin has joined #openstack-nova | 08:04 | |
| *** armaan has joined #openstack-nova | 08:05 | |
| *** shaohe_feng has quit IRC | 08:06 | |
| *** shaohe_feng has joined #openstack-nova | 08:07 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: WIP: Enable nested allocation candidates in scheduler https://review.openstack.org/585672 | 08:09 |
| tetsuro | ^gibi, jaypipes, efried and everyone: I'd like to help you on consuming nrp-aloc-cands work in nova side, but I think I need brief feedback if this is a right way and where I should go. | 08:15 |
| *** shaohe_feng has quit IRC | 08:16 | |
| tetsuro | This is at least working on getting candidates with child rp + custom resource class inventory and have allocations on them with compute host resources. | 08:17 |
| tetsuro | ...with a new instance | 08:17 |
| *** shaohe_feng has joined #openstack-nova | 08:18 | |
| *** rmart04 has quit IRC | 08:19 | |
| *** lucas-afk is now known as lucasagomes | 08:22 | |
| *** shaohe_feng has quit IRC | 08:26 | |
| *** shaohe_feng has joined #openstack-nova | 08:27 | |
| cdent | tetsuro: I looked at that, looks like a good start and the right thing for there. The complexity is going to happen if/when an instance with nested wants to do a migration. There's quite a bit of a TODO in the report client about that kind of thing. | 08:28 |
| gmann | tetsuro: we were discussing about your BP in api office hour - https://review.openstack.org/#/q/topic:bp/handling-down-cell+(status:open+OR+status:merged) | 08:29 |
| *** rcernin has joined #openstack-nova | 08:29 | |
| gmann | tetsuro: what's the plan for this? is it still target for Rocky or stein. i saw the comment of doing service list also along with server list | 08:30 |
| gibi | tetsuro: left some feedback in that patch. I think simply reading the consumer generation from placement during the claim_resources is defeate the purpose of having consumer generations | 08:30 |
| gibi | tetsuro: I'm trying to add support for consumer generations here https://review.openstack.org/#/c/583667/ | 08:30 |
| cdent | tetsuro, gibi: for the case where we have a new instance the consumer is new, so generation is meaningless? | 08:31 |
| gibi | cdent: unfortunately that is not the only case when claim_resources are called | 08:31 |
| cdent | yeah, I know, I'm trying to work out if we can streamline the easy path | 08:32 |
| cdent | because it is the common path too | 08:32 |
| cdent | in the uncommon cases there will be existing allocations, yes? | 08:32 |
| cdent | thus what the code is doing is at least close, if not fully correct | 08:32 |
| gibi | cdent: plus when we assume that it is a new consumer we can still need to prepare that we get consumer generation conflict and handle that (most probably fail the build) | 08:33 |
| cdent | clearly there needs to be some conflict detection, but bar that the logic is mostly right unless there's a detail I'm not aware of (which is very likely) | 08:33 |
| cdent | yes, a generation conflict on a new build would mean that UUIDs are broken :) | 08:34 |
| gibi | cdent: or that our assumption in the claim_resources about the fact that it is a new build is invalid | 08:34 |
| gibi | cdent: even if we are coming from the scheduer select_destination it is possible that the consumer exists as evacuate does not use migration.uuid to hold the allocation of the source host | 08:36 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.openstack.org/571410 | 08:36 |
| *** shaohe_feng has quit IRC | 08:37 | |
| gibi | cdent: I agree that assuming consumer_generation = None in claim_resource a good first step | 08:37 |
| *** shaohe_feng has joined #openstack-nova | 08:37 | |
| *** wolverineav has joined #openstack-nova | 08:38 | |
| gibi | cdent: I just fustrated about the hairy cases that I have to takle in my patch and I don't think we can merge support for 1.29 before solving 1.28 for the edge cases too | 08:38 |
| lyarwood | mdbooth: ^ would you mind taking a look at that again? | 08:38 |
| cdent | I'm not disputing that we need to merge (and understand) your 1.28 code first | 08:38 |
| cdent | just, as I said, trying to make sure that we don't overcomplicate things when we claim, if possible | 08:39 |
| mdbooth | lyarwood: yup | 08:39 |
| cdent | if new: gen is none, if gen conflict bail, something went badly wrong | 08:39 |
| gibi | cdent: when you say 'if new' do you mean checking if there is no other allocation in placement for the consumer? | 08:40 |
| cdent | if existing allocations for this consumer uuid, do something else | 08:41 |
| *** sridharg has joined #openstack-nova | 08:41 | |
| cdent | that would be one way, but I assume the caller of claim also knows? | 08:41 |
| cdent | the "something else" looks to me to be very close to what is already being done in the code: merge the allocations, set the generation to what the server told us | 08:42 |
| gibi | cdent: what if the caller thinks that it is not a new consumer but the claim_resources checks in placement and sees it is a new consumer and silently uses consumer_generation None instead of raise? | 08:42 |
| gibi | cdent: I think in this case the caller needs to provider his view of the consumer generation and not let claim_resource decide | 08:43 |
| cdent | then we should fix the caller because it sounds like the caller is broken? I'm not sure why we should overcomplicate the report client to deal with the fact that other code is flakey. What situation would cause what you're describing? | 08:43 |
| *** wolverineav has quit IRC | 08:43 | |
| gibi | cdent: sure it needs fix on the caller side but to know that the caller is broken we need to see the conflict and not simply use the consumer gen that will succeed in placement by asking it from placement | 08:45 |
| cdent | I don't mean a fix at runtime, I mean a fix in the code | 08:45 |
| cdent | Thus my question of "what situation.." | 08:46 |
| *** armaan has quit IRC | 08:46 | |
| gibi | cdent: I don't know exactly the case. I guess some parallel consumer update can happen. This is why we introduced consumer generation in the first place, isn't it? | 08:47 |
| cdent | If we take this back to very basics there are two main situations: the consumer has existing allocations and this consumer does not have existing allocations. Are there others? | 08:47 |
| *** armaan has joined #openstack-nova | 08:47 | |
| *** shaohe_feng has quit IRC | 08:47 | |
| gibi | there is the case when caller thing consumer gen is 1 but in the meantime somebody else modified the consumer | 08:47 |
| gibi | s/thing/thinks/ | 08:47 |
| cdent | for "gen is 1 but somebody else modified" that is a specifc case of "the consumer has existing allocations" | 08:48 |
| *** shaohe_feng has joined #openstack-nova | 08:48 | |
| *** openstackgerrit has quit IRC | 08:48 | |
| gibi | cdent: OK, then that is the two basic case | 08:48 |
| cdent | From the point of the scheduler's management of allocations, consumer generations are not very important (we have to manage conflict detection, but we still just want to claim) because the act of claiming for an instance is a single task. We want to claim if at all possible. Nobody else is trying to find a destination for this instance. | 08:49 |
| *** wolverineav has joined #openstack-nova | 08:50 | |
| gibi | of course we can say that consumers handled by nova is owned by nova and no parallel update is done from nova on those and then we don't need to take consumers generations too seriously | 08:50 |
| cdent | I'm saying that's true for in the scheduler. It's not true in the compute node, or in neutron agents, or whatever | 08:50 |
| cdent | And we should keep it true in the scheudler if at all possible | 08:51 |
| *** armaan has quit IRC | 08:51 | |
| gibi | but scheduler coexists with all the others so I don't know how to ensure that the consumer the scheduler uses are not modified by other sources | 08:52 |
| gibi | if scheduler would only ever create a new consumer during claim then it would be easier | 08:52 |
| cdent | indeed | 08:52 |
| gibi | due to evacuate it is not the case today | 08:53 |
| cdent | but in the (presumably rare) cases where it doesn't the only real option we have is to get the existing allocations and do some kind of merge or choose to clobber | 08:53 |
| gibi | there is an item in the PTG etherpad to 'fix' evacuate | 08:53 |
| cdent | _move_operation_alloc_request is the code that is supposed to handle that sort of thing, but may not be mature enough of for nested and shared | 08:54 |
| *** wolverineav has quit IRC | 08:55 | |
| cdent | I think (or perhaps just hope) that we have a chance here to keep the happy path relatively smooth. I hope for that because we keep talking about how we want the claim stage to be as fast and unencumbered as possible. | 08:55 |
| gibi | cdent: I agree that in case of non-forced evac when the scheduler claims on the target host we cannot do anything else just read the generation from placement. I will try to be really explicit in my patch about the different cases. | 08:55 |
| cdent | tetsuro: you have anything to add to all that ^ | 08:56 |
| *** shaohe_feng has quit IRC | 08:57 | |
| gibi | cdent: I share your hope. My bad feeling is about our assumption that I can identify the happy path unambigously | 08:57 |
| *** openstackgerrit has joined #openstack-nova | 08:58 | |
| openstackgerrit | Radoslav Gerganov proposed openstack/nova master: doc: add missing permission for the vCenter service account https://review.openstack.org/585683 | 08:58 |
| cdent | that we can't should be considered a bug ;) | 08:58 |
| *** diga has joined #openstack-nova | 08:58 | |
| *** shaohe_feng has joined #openstack-nova | 08:59 | |
| gibi | cdent: I guess I need to lower my expectations about my ability to cover every cases at once in my patch and let a bug born if it needs to be born | 09:00 |
| cdent | yeah, I think that's going to be the case for a lot of this stuff because it's so hard to see clearly how things work | 09:00 |
| cdent | And bugs are _good_. They give people a clear way to contribute. | 09:01 |
| *** josecastroleon has quit IRC | 09:01 | |
| *** josecastroleon1 has joined #openstack-nova | 09:01 | |
| *** josecastroleon1 is now known as josecastroleon | 09:01 | |
| gibi | cdent: I thikn _these_ possible bugs will give a clear message for new contributors not to touch nova ;) | 09:02 |
| cdent | I don't know, I think we misunderstand the mechanics of why people choose or choose not to contribute | 09:02 |
| cdent | So often with nova if you want to contribute you have to spend 4 years understanding things | 09:02 |
| cdent | there are few easy entries | 09:03 |
| cdent | plenty of people are using nova because they have to and would like to be able to make it better | 09:03 |
| cdent | but are put off | 09:03 |
| gibi | cdent: you are right, I should not generalize to all new contributors as I don't know their motives. | 09:04 |
| gibi | cdent: what I wanted to say that I think these bugs will be scary even for me after 4 years of nova | 09:04 |
| cdent | :) | 09:05 |
| cdent | It's easier to fix them after they happen then it is easy to guess when they might happen? | 09:05 |
| gibi | cdent: yeah I agree about cost of guessing is bigger. But I also don't know the seriosuness of the effect of these unknown bugs on a live deployment | 09:07 |
| *** shaohe_feng has quit IRC | 09:07 | |
| gibi | cdent: anyhow I think I hear you and understand you to move forward with the happy path | 09:09 |
| gibi | cdent: and I think that is reasonable | 09:09 |
| *** shaohe_feng has joined #openstack-nova | 09:10 | |
| *** armaan has joined #openstack-nova | 09:11 | |
| *** ispp has quit IRC | 09:11 | |
| *** rmart04 has joined #openstack-nova | 09:14 | |
| *** chason has quit IRC | 09:16 | |
| *** chason has joined #openstack-nova | 09:17 | |
| *** shaohe_feng has quit IRC | 09:18 | |
| *** ispp has joined #openstack-nova | 09:19 | |
| *** shaohe_feng has joined #openstack-nova | 09:19 | |
| *** armaan has quit IRC | 09:26 | |
| *** armaan has joined #openstack-nova | 09:26 | |
| *** shaohe_feng has quit IRC | 09:28 | |
| *** mgoddard has joined #openstack-nova | 09:28 | |
| *** armaan has quit IRC | 09:30 | |
| *** shaohe_feng has joined #openstack-nova | 09:31 | |
| *** lifeless has quit IRC | 09:37 | |
| *** shaohe_feng has quit IRC | 09:38 | |
| *** shaohe_feng has joined #openstack-nova | 09:39 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: add fuctional test for os-vif init https://review.openstack.org/585693 | 09:40 |
| openstackgerrit | Rajesh Tailor proposed openstack/nova stable/queens: Make host_aggregate_map dictionary case-insensitive https://review.openstack.org/585334 | 09:41 |
| openstackgerrit | Rajesh Tailor proposed openstack/nova stable/pike: Make host_aggregate_map dictionary case-insensitive https://review.openstack.org/585335 | 09:43 |
| sean-k-mooney | mriedem: melwitt i have added a fuctionl test https://review.openstack.org/#/c/585693/ to try and reproduce the error in https://bit.ly/2v0ueZp but at least locally it looks like it should work as is. | 09:45 |
| openstackgerrit | Rajesh Tailor proposed openstack/nova master: Fix case-sensitivity for metadata keys https://review.openstack.org/504885 | 09:46 |
| *** wolverineav has joined #openstack-nova | 09:46 | |
| *** zhangbailin_ has joined #openstack-nova | 09:47 | |
| *** flwang1 has joined #openstack-nova | 09:48 | |
| *** shaohe_feng has quit IRC | 09:48 | |
| *** blkart has joined #openstack-nova | 09:48 | |
| *** shaohe_feng has joined #openstack-nova | 09:49 | |
| *** Tahvok has quit IRC | 09:50 | |
| *** BrinZhang has quit IRC | 09:50 | |
| *** wolverineav has quit IRC | 09:51 | |
| *** Tahvok has joined #openstack-nova | 09:51 | |
| *** wolverineav has joined #openstack-nova | 09:53 | |
| *** kiseok7 has joined #openstack-nova | 09:55 | |
| *** shaohe_feng has quit IRC | 09:59 | |
| *** wolverineav has quit IRC | 09:59 | |
| *** alexchadin has quit IRC | 09:59 | |
| *** GonZo2000 has joined #openstack-nova | 09:59 | |
| *** GonZo2000 has quit IRC | 09:59 | |
| *** GonZo2000 has joined #openstack-nova | 09:59 | |
| *** lei-zh has quit IRC | 09:59 | |
| *** shaohe_feng has joined #openstack-nova | 10:00 | |
| *** ispp has quit IRC | 10:01 | |
| *** vipul has quit IRC | 10:01 | |
| *** rmart04 has quit IRC | 10:03 | |
| *** vipul has joined #openstack-nova | 10:05 | |
| *** shyamb has joined #openstack-nova | 10:05 | |
| *** alexchadin has joined #openstack-nova | 10:08 | |
| *** shaohe_feng has quit IRC | 10:09 | |
| *** shaohe_feng has joined #openstack-nova | 10:10 | |
| *** josecastroleon has quit IRC | 10:10 | |
| *** josecastroleon has joined #openstack-nova | 10:10 | |
| *** tssurya has quit IRC | 10:11 | |
| *** shyamb has left #openstack-nova | 10:15 | |
| *** chason has quit IRC | 10:15 | |
| *** chason has joined #openstack-nova | 10:17 | |
| *** josecastroleon has quit IRC | 10:17 | |
| *** chason[m] has joined #openstack-nova | 10:17 | |
| *** shaohe_feng has quit IRC | 10:19 | |
| *** shaohe_feng has joined #openstack-nova | 10:20 | |
| *** vladikr has quit IRC | 10:21 | |
| *** wolverineav has joined #openstack-nova | 10:22 | |
| *** jamesden_ has joined #openstack-nova | 10:22 | |
| *** kukacz_ has quit IRC | 10:23 | |
| *** kukacz_ has joined #openstack-nova | 10:23 | |
| *** lifeless has joined #openstack-nova | 10:23 | |
| *** vladikr has joined #openstack-nova | 10:25 | |
| *** wolverineav has quit IRC | 10:26 | |
| *** wolverineav has joined #openstack-nova | 10:28 | |
| *** shaohe_feng has quit IRC | 10:29 | |
| *** shaohe_feng has joined #openstack-nova | 10:30 | |
| openstackgerrit | Lenny Verkhovsky proposed openstack/nova master: WIP workaround for RHEL7.5 qemu 2.0 https://review.openstack.org/577280 | 10:30 |
| *** wolverineav has quit IRC | 10:32 | |
| *** wolverineav has joined #openstack-nova | 10:33 | |
| *** alexchad_ has joined #openstack-nova | 10:35 | |
| *** alexchad_ has quit IRC | 10:36 | |
| *** alexchadin has quit IRC | 10:36 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional test for booting with nested resources https://review.openstack.org/527728 | 10:37 |
| *** wolverineav has quit IRC | 10:37 | |
| mdbooth | kashyap: My +1 to sahid's suggestions was before the subsequent discussion. I'll defer to that discussion. | 10:38 |
| kashyap | mdbooth: Hi | 10:38 |
| *** wolverineav has joined #openstack-nova | 10:39 | |
| *** shaohe_feng has quit IRC | 10:40 | |
| kashyap | mdbooth: So, you mean: you are OK with moving to guest.migrate() can be done as a separate patch? | 10:40 |
| *** shaohe_feng has joined #openstack-nova | 10:40 | |
| mdbooth | kashyap: I think moving to guest.migrate() is better, but if you discussed that already and decided to put it in a later change I'm ok with that. | 10:40 |
| kashyap | mdbooth: Yeah, we discussed it, and will do it later | 10:41 |
| kashyap | As I am dealing with too much churn in this change | 10:41 |
| mdbooth | kashyap: That is, I don't mind what colour you paint the bike shed :) | 10:41 |
| *** gongysh has quit IRC | 10:41 | |
| kashyap | I'd like to get it done before I head out for 2 weeks starting 01-Aug | 10:41 |
| kashyap | mdbooth: Hehe, nod | 10:41 |
| kashyap | Thanks for looking, BTW! | 10:41 |
| kashyap | mdbooth: About the "parallels" question: it seems alright to me, but I'll go over carefully again | 10:42 |
| mdbooth | kashyap: Ack. Specifically, is it ok to call migrateToURI3() without that parameter? | 10:43 |
| mdbooth | I don't know the answer, btw, just worth checking. | 10:43 |
| kashyap | mdbooth: Without 'destination_xml', you mean? | 10:43 |
| kashyap | Yeah, I'll see | 10:43 |
| *** wolverineav has quit IRC | 10:43 | |
| *** blkart has quit IRC | 10:45 | |
| kashyap | mdbooth: Right now debugging the test failure from hell: nova.tests.unit.virt.test_virt_drivers.LibvirtConnTestCase.test_live_migration | 10:45 |
| *** armaan has joined #openstack-nova | 10:45 | |
| kashyap | Once I'm done w/ it, will look | 10:45 |
| *** wolverineav has joined #openstack-nova | 10:46 | |
| *** blkart has joined #openstack-nova | 10:48 | |
| *** liuyulong_ has joined #openstack-nova | 10:48 | |
| *** edmondsw has joined #openstack-nova | 10:49 | |
| * stephenfin wonders how much of a "stub" service does one need to implement before it's no longer a stub | 10:49 | |
| *** ispp has joined #openstack-nova | 10:49 | |
| *** shaohe_feng has quit IRC | 10:50 | |
| kashyap | stephenfin: LOL | 10:50 |
| kashyap | I'm dealing with a bloody obtuse stubbing failure for 2 hours! | 10:50 |
| *** wolverineav has quit IRC | 10:50 | |
| stephenfin | kashyap: Try 3 days :( | 10:50 |
| kashyap | The here is incredibly dense; sheesh | 10:50 |
| kashyap | stephenfin: I lied to you | 10:51 |
| kashyap | 2 hours only today | 10:51 |
| kashyap | I spent yesterday & day before too | 10:51 |
| kashyap | After all this debugging, realized the fix is "simple" :-( | 10:51 |
| * kashyap goes to try his "simple" fix to the stubs | 10:51 | |
| mdbooth | stephenfin: stub -> simulator. simulators are also really useful, just not as simple. | 10:51 |
| *** wolverineav has joined #openstack-nova | 10:52 | |
| *** liuyulong has quit IRC | 10:52 | |
| *** shaohe_feng has joined #openstack-nova | 10:52 | |
| *** armaan has quit IRC | 10:55 | |
| *** armaan has joined #openstack-nova | 10:56 | |
| *** armaan has quit IRC | 10:56 | |
| stephenfin | mdbooth: I think that's what I'm writing. God damn neutron | 10:57 |
| *** physpi| has joined #openstack-nova | 10:57 | |
| *** wolverin_ has joined #openstack-nova | 10:59 | |
| *** wolverineav has quit IRC | 11:00 | |
| *** shaohe_feng has quit IRC | 11:00 | |
| kashyap | mdbooth: Got a minute? Does this stub look OK to you: | 11:01 |
| kashyap | 135 self.stub_out('nova.virt.libvirt.guest.Guest.migrate', | 11:01 |
| kashyap | 136 lambda self, destination, migrate_uri=None, | 11:01 |
| kashyap | 137 migrate_disks=None, destination_xml=None, flags=0, | 11:01 |
| *** shaohe_feng has joined #openstack-nova | 11:01 | |
| kashyap | 138 bandwidth: None) | 11:01 |
| kashyap | (That's from nova/tests/unit/virt/test_virt_drivers.py) | 11:01 |
| *** physpi| has quit IRC | 11:01 | |
| *** wolverin_ has quit IRC | 11:01 | |
| *** wolverineav has joined #openstack-nova | 11:01 | |
| mdbooth | kashyap: No, because bandwidth doesn't have a default, and comes after args with defaults. | 11:02 |
| kashyap | mdbooth: Ah | 11:02 |
| mdbooth | Is there any other reason it might not be ok? | 11:03 |
| *** wolverin_ has joined #openstack-nova | 11:03 | |
| *** wolverineav has quit IRC | 11:03 | |
| mdbooth | kashyap: Also, you could probably just mock it. | 11:03 |
| kashyap | mdbooth: What do I give 'bandwidth' then? | 11:03 |
| kashyap | Hmm | 11:03 |
| mdbooth | kashyap: Doesn't matter, because you're not going to use it anyway. | 11:04 |
| *** diga has quit IRC | 11:04 | |
| kashyap | mdbooth: Ah, this works! | 11:04 |
| kashyap | bandwith=0: None | 11:04 |
| mdbooth | self.useFixture(fixtures.MockPatch('nova.virt.libvirt.guest.Guest', 'migrate')) | 11:04 |
| kashyap | In summary: | 11:04 |
| kashyap | self.stub_out('nova.virt.libvirt.guest.Guest.migrate', | 11:04 |
| kashyap | lambda self, destination, migrate_uri=None, | 11:04 |
| kashyap | migrate_disks=None, destination_xml=None, flags=0, | 11:04 |
| kashyap | bandwidth=0: None) | 11:04 |
| kashyap | mdbooth: How about the above? | 11:04 |
| mdbooth | foo=^^^ | 11:04 |
| mdbooth | foo.return_value=None | 11:04 |
| mdbooth | kashyap: Looks syntactically correct, at least. | 11:05 |
| kashyap | Yeah, it is! | 11:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Assorted cleanups from numa-aware-vswitches series https://review.openstack.org/582651 | 11:05 |
| kashyap | And the test from hell passes!~ | 11:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Add functional tests for rebuild with NUMA networks https://review.openstack.org/585385 | 11:05 |
| mdbooth | \o/ | 11:06 |
| stephenfin | mdbooth: If you have time, fancy taking a look at ^ to see if I'm missing anything really obvious? | 11:06 |
| stephenfin | I'm seeing "AttributeError: 'module' object has no attribute 'vif'" but I've no idea why | 11:06 |
| sean-k-mooney | stephenfin: i was just going to ask you about the functional tests | 11:06 |
| *** phuongnh has quit IRC | 11:07 | |
| sean-k-mooney | do you want me to pull them down and step through them more or did you get them to work? | 11:07 |
| stephenfin | Thought it was a namespace conflict (mocking "objects" or something) but I renamed the import to no effect. Can't find any global mocks or anything | 11:07 |
| *** armaan has joined #openstack-nova | 11:07 | |
| stephenfin | sean-k-mooney: That'd be great | 11:07 |
| stephenfin | I've got it to the point where it's attempting to plug | 11:07 |
| sean-k-mooney | stephenfin: cool will do | 11:07 |
| stephenfin | But the plug is failing with the above | 11:07 |
| stephenfin | sean-k-mooney: Awesome. Thank you :) | 11:08 |
| *** wolverin_ has quit IRC | 11:08 | |
| *** alexchadin has joined #openstack-nova | 11:09 | |
| *** shaohe_feng has quit IRC | 11:10 | |
| *** tssurya has joined #openstack-nova | 11:12 | |
| *** shaohe_feng has joined #openstack-nova | 11:12 | |
| *** abhishekk has quit IRC | 11:12 | |
| *** josecastroleon has joined #openstack-nova | 11:13 | |
| *** ratailor has quit IRC | 11:14 | |
| *** alexchadin has quit IRC | 11:15 | |
| *** chyka has joined #openstack-nova | 11:18 | |
| *** shaohe_feng has quit IRC | 11:21 | |
| *** rcernin has quit IRC | 11:21 | |
| *** shaohe_feng has joined #openstack-nova | 11:22 | |
| *** ragiman has quit IRC | 11:23 | |
| *** chyka has quit IRC | 11:23 | |
| *** tiendc has quit IRC | 11:24 | |
| *** liuyulong__ has joined #openstack-nova | 11:26 | |
| *** liuyulong_ has quit IRC | 11:26 | |
| *** armaan has quit IRC | 11:27 | |
| *** armaan has joined #openstack-nova | 11:27 | |
| *** armaan has quit IRC | 11:29 | |
| *** armaan has joined #openstack-nova | 11:30 | |
| *** shaohe_feng has quit IRC | 11:31 | |
| *** artom has joined #openstack-nova | 11:32 | |
| *** shaohe_feng has joined #openstack-nova | 11:32 | |
| *** alexchadin has joined #openstack-nova | 11:37 | |
| *** ccamacho has quit IRC | 11:38 | |
| *** shaohe_feng has quit IRC | 11:41 | |
| *** shaohe_feng has joined #openstack-nova | 11:42 | |
| *** ccamacho has joined #openstack-nova | 11:44 | |
| *** shaohe_feng has quit IRC | 11:51 | |
| *** shaohe_feng has joined #openstack-nova | 11:54 | |
| *** ispp has quit IRC | 11:54 | |
| *** ispp has joined #openstack-nova | 11:57 | |
| *** medberry has joined #openstack-nova | 12:01 | |
| *** shaohe_feng has quit IRC | 12:02 | |
| *** shaohe_feng has joined #openstack-nova | 12:03 | |
| *** armaan has quit IRC | 12:03 | |
| *** armaan has joined #openstack-nova | 12:04 | |
| *** armaan has quit IRC | 12:06 | |
| *** armaan has joined #openstack-nova | 12:07 | |
| *** wolverineav has joined #openstack-nova | 12:08 | |
| openstackgerrit | Neha Alhat proposed openstack/python-novaclient master: Enable split logging for cinder-novaclient interaction https://review.openstack.org/581218 | 12:10 |
| *** armaan has quit IRC | 12:11 | |
| *** shaohe_feng has quit IRC | 12:12 | |
| *** wolverineav has quit IRC | 12:12 | |
| *** wolverineav has joined #openstack-nova | 12:12 | |
| *** shaohe_feng has joined #openstack-nova | 12:13 | |
| *** lpetrut has joined #openstack-nova | 12:18 | |
| *** lpetrut_ has quit IRC | 12:18 | |
| *** shaohe_feng has quit IRC | 12:22 | |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Use vif.vif_name in _set_config_VIFGeneric https://review.openstack.org/571461 | 12:22 |
| *** shaohe_feng has joined #openstack-nova | 12:23 | |
| *** dave-mccowan has joined #openstack-nova | 12:25 | |
| *** jaosorior has quit IRC | 12:27 | |
| mdbooth | lyarwood: https://review.openstack.org/#/c/571410/7 Are we missing a simpler solution here? | 12:29 |
| mdbooth | lyarwood: And another big race condition in a periodic, of course. | 12:29 |
| *** shaohe_feng has quit IRC | 12:32 | |
| *** shaohe_feng has joined #openstack-nova | 12:33 | |
| *** mriedem has quit IRC | 12:39 | |
| *** mriedem has joined #openstack-nova | 12:41 | |
| lyarwood | mdbooth: erm I don't follow, the entire point of that conditional is to not fail, to not raise DiskNotFound? | 12:42 |
| *** zhangbailin_ has quit IRC | 12:42 | |
| mdbooth | lyarwood: And my point is we're decided whether to fail or not based on data which is really out of date, and why would it ever be better to fail there anyway? | 12:42 |
| mdbooth | lyarwood: i.e. just don't fail. | 12:42 |
| mdbooth | ever. | 12:42 |
| *** shaohe_feng has quit IRC | 12:43 | |
| stephenfin | mriedem: FYI, I've got further with that functional test but I'm still seeing some issues (this time "AttributeError: 'module' object has no attribute 'vif'", where module is os_vif). Will keep working on it | 12:43 |
| lyarwood | mdbooth: yeah I guess that's valid sorry, warning when it isn't found would be cleaner I guess | 12:44 |
| *** shaohe_feng has joined #openstack-nova | 12:44 | |
| mriedem | stephenfin: hmm, i think the FakeLibvirtFixture has a flag for stubbing out os-vif somehow | 12:44 |
| mriedem | might want to check that out | 12:44 |
| stephenfin | mriedem: It does and I think it's enabled by default | 12:45 |
| mriedem | stephenfin: is that just the rebuild functional test on a single host? or are you working on a test that actuall moves the instance from one host to another, like cold migrate? | 12:45 |
| mriedem | i think the latter would be most interesting if you have 3 computes where 2 satisfy the numa affinity network request and we cold migrate and make sure the scheduler picked the other host that supported the network request | 12:46 |
| stephenfin | mriedem: Just rebuild. I'm still stuck attaching an interface to running VM, so until I figure that out I can't do anything else | 12:46 |
| stephenfin | so my test isn't getting past here https://review.openstack.org/#/c/585385/5/nova/tests/functional/libvirt/test_numa_servers.py@449 | 12:47 |
| mriedem | why do you need the attach? to see that the info cache is updated? | 12:47 |
| mriedem | stephenfin: why can't your test just be (1) create server with numa affinity network requested on host A, (2) cold migrate it to host B where host B has the numa affinity you need but we also have another host C which should get filtered out | 12:48 |
| stephenfin | Yup. When I rebuild after attaching an interface, it should take that new interface into account when (re)calculating NUMA topology | 12:50 |
| stephenfin | mriedem: Hmm, that could work. Lemme try | 12:50 |
| *** jaosorior has joined #openstack-nova | 12:50 | |
| sean-k-mooney | stephenfin: so one of the issues is curerntly you are not inialising os_vif i get a little futher in the rebuilt test when i do that | 12:51 |
| *** shaohe_feng has quit IRC | 12:53 | |
| *** lyan has joined #openstack-nova | 12:54 | |
| sean-k-mooney | because you did not iniallise os-vif https://github.com/openstack/os-vif/blob/master/os_vif/objects/__init__.py was never run so _nova_to_osvif_vif_ovs failed in os_vif_util.py in nova because we import os_vif.objects but not os_vif.objects.vif | 12:54 |
| mriedem | cores: this ironic patch needs another +2 to complete the blueprint, pretty simple https://review.openstack.org/#/c/517921/ | 12:54 |
| *** lyan is now known as Guest27255 | 12:54 | |
| stephenfin | sean-k-mooney: Damn, I saw that used elsewhere by figured it would have been called by the fake nova-compute service. That's what I get for assuming | 12:55 |
| *** shaohe_feng has joined #openstack-nova | 12:56 | |
| *** eharney has quit IRC | 12:56 | |
| *** r-daneel has quit IRC | 12:57 | |
| sean-k-mooney | stephenfin: there are still a few other errors after that which im looking at now. add import os_vif and then add os_vif.initialize() to the setup function on lin 294 if you want to see them | 12:59 |
| *** mdnadeem has quit IRC | 13:01 | |
| openstackgerrit | Merged openstack/nova master: Use placement context in placement functional tests https://review.openstack.org/585529 | 13:03 |
| *** shaohe_feng has quit IRC | 13:03 | |
| *** shaohe_feng has joined #openstack-nova | 13:05 | |
| *** wolverineav has quit IRC | 13:06 | |
| *** awaugama has joined #openstack-nova | 13:06 | |
| openstackgerrit | Merged openstack/nova stable/queens: Add unshelve instance error info to fault table https://review.openstack.org/583418 | 13:07 |
| *** Tahvok has quit IRC | 13:08 | |
| *** wolverineav has joined #openstack-nova | 13:09 | |
| *** Tahvok has joined #openstack-nova | 13:11 | |
| mriedem | i've got 3 more changes to close out the port binding live migration blueprint, bottom one has a +2 from gibi https://review.openstack.org/#/c/551371/ | 13:12 |
| *** niraj_singh has joined #openstack-nova | 13:12 | |
| mriedem | given how long this series was and the meat is already merged, it would be nice to see the final bits make it | 13:12 |
| Kevin_Zheng | mriede | 13:13 |
| *** shaohe_feng has quit IRC | 13:13 | |
| Kevin_Zheng | mriedem: I tried some other backends, it’s the same, but maybe I missed something | 13:13 |
| *** gbarros has joined #openstack-nova | 13:14 | |
| Kevin_Zheng | But I think you can focus on feature freeze now, we can do this latter, I will also check more | 13:14 |
| sean-k-mooney | mriedem: yes plus the effort put in from the neutron side on this also make it a higher proity to get it over the line as both comunity worked hard on this problem | 13:15 |
| mriedem | Kevin_Zheng: i would suggest talking with gcb during your daytime | 13:15 |
| mriedem | to see if he has some ideas on how to use those in-memory backends for functional testing | 13:15 |
| *** shaohe_feng has joined #openstack-nova | 13:16 | |
| *** armaan has joined #openstack-nova | 13:18 | |
| *** shaohe_feng has quit IRC | 13:24 | |
| *** shaohe_feng has joined #openstack-nova | 13:25 | |
| *** armaan has quit IRC | 13:25 | |
| mriedem | newish gate bug https://bugs.launchpad.net/nova/+bug/1783565 | 13:27 |
| openstack | Launchpad bug 1783565 in OpenStack Compute (nova) "ServerGroupTestV21.test_evacuate_with_anti_affinity_no_valid_host intermittently fails with "Instance compute service state on host2 expected to be down, but it was up."" [Undecided,New] | 13:27 |
| *** OwenBarfield has joined #openstack-nova | 13:30 | |
| *** dave-mcc_ has joined #openstack-nova | 13:33 | |
| *** shaohe_feng has quit IRC | 13:34 | |
| *** dave-mccowan has quit IRC | 13:34 | |
| *** shaohe_feng has joined #openstack-nova | 13:35 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix signature of _FakeImageService.download https://review.openstack.org/585747 | 13:35 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't poison Host._init_events if it's already mocked https://review.openstack.org/585748 | 13:35 |
| *** dave-mccowan has joined #openstack-nova | 13:35 | |
| *** efried_pto is now known as efried | 13:36 | |
| *** tbachman has joined #openstack-nova | 13:37 | |
| *** dave-mcc_ has quit IRC | 13:38 | |
| Kevin_Zheng | mriedem: I will | 13:39 |
| mdbooth | stephenfin: http://paste.openstack.org/show/726617/ | 13:44 |
| mdbooth | I actually now have a functional test which does evacuate with the libvirt driver | 13:44 |
| *** shaohe_feng has quit IRC | 13:44 | |
| *** shaohe_feng has joined #openstack-nova | 13:45 | |
| sean-k-mooney | mdbooth: cool. im trying to debug why in stephenfin test the interface he is attaching is been added as a disk to the fake instacne... | 13:45 |
| mdbooth | stephenfin: That's a kludge, but the alternative is massive changes to fakelibvirt | 13:47 |
| mdbooth | sean-k-mooney: That sounds pretty weird | 13:48 |
| stephenfin | mdbooth: kludgy and working beats extensive and broken | 13:48 |
| sean-k-mooney | mdbooth: ya its not waht i was expecting to happen | 13:49 |
| *** yedongcan has left #openstack-nova | 13:49 | |
| *** ttsiouts has joined #openstack-nova | 13:50 | |
| sean-k-mooney | i found the issue .. | 13:51 |
| *** jchhatbar has joined #openstack-nova | 13:53 | |
| efried | cdent: Can you ack https://review.openstack.org/#/c/585683/ (http://logs.openstack.org/83/585683/1/check/build-openstack-sphinx-docs/e5c8c01/html/admin/configuration/hypervisor-vmware.html#vmware-vcenter-service-account) ? | 13:53 |
| sean-k-mooney | stephenfin: mdbooth so thats a thing https://github.com/openstack/nova/blob/003667ab246d0bcbbbec97e88cd0a0d2f0e6c044/nova/tests/unit/virt/libvirt/fakelibvirt.py#L784-L788 | 13:53 |
| cdent | efried: only in the sense that I trust rado got it right. I know zero about vcenter permissions tree | 13:54 |
| stephenfin | sean-k-mooney: Ha, incomplete mocks strike again | 13:54 |
| * efried <== less than zero | 13:54 | |
| *** shaohe_feng has quit IRC | 13:54 | |
| mdbooth | sean-k-mooney: Hehe | 13:54 |
| sean-k-mooney | stephenfin: ill fix it locally and see what happens. | 13:54 |
| cdent | efried: I think it's rubber stampable | 13:55 |
| *** r-daneel has joined #openstack-nova | 13:55 | |
| efried | cdent: ight, rubber-stamped. | 13:55 |
| *** janki has quit IRC | 13:56 | |
| *** shaohe_feng has joined #openstack-nova | 13:56 | |
| *** alexpilotti has quit IRC | 13:57 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use placement 1.28 in scheduler report client https://review.openstack.org/583667 | 13:57 |
| *** alexpilotti has joined #openstack-nova | 13:58 | |
| *** gongysh has joined #openstack-nova | 14:00 | |
| *** alexpilotti has quit IRC | 14:02 | |
| *** namnh has joined #openstack-nova | 14:03 | |
| stephenfin | mriedem: Can we set different config options for fake services? e.g. test_compute1 has a different '[neutron_physnet_foo] numa_nodes' value from test_compute2 | 14:03 |
| mriedem | ummm | 14:04 |
| mriedem | i don't think so... | 14:04 |
| mriedem | CONF is global | 14:04 |
| mriedem | and everything runs in the same process | 14:04 |
| *** shaohe_feng has quit IRC | 14:05 | |
| mriedem | stephenfin: so yeah i'm not sure how we can run multiple compute services in a functional test but 2 of them share the same numa network config and another doesn't | 14:05 |
| stephenfin | Yup, my point exactly | 14:05 |
| dansmith | we can't | 14:06 |
| *** shaohe_feng has joined #openstack-nova | 14:06 | |
| *** mlavalle has joined #openstack-nova | 14:06 | |
| *** blkart has quit IRC | 14:06 | |
| dansmith | unless they are things that get reported during service start, | 14:06 |
| dansmith | such that we can set the flag, start the service, have it cache/report a thing, and then change it for the next start | 14:06 |
| dansmith | but that's fragile and very few things fit that pattern | 14:06 |
| *** Stryyker| has joined #openstack-nova | 14:07 | |
| Stryyker| | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 14:07 |
| Stryyker| | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 14:07 |
| Stryyker| | Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate | 14:07 |
| Stryyker| | Voice your opinions at https://webchat.freenode.net/?channels=#freenode | 14:07 |
| dansmith | lol | 14:07 |
| mdbooth | Who can kickban? | 14:07 |
| sean-k-mooney | dansmith: i was going to suggest the same thing. e.g. set conf values for compute node 1 then start then set conf for node 2 then start | 14:07 |
| mriedem | stephenfin: could have a negative test where you start with a host that fits the requested numa affinity and then remove the config, start another host and migrate the server | 14:07 |
| dansmith | sean-k-mooney: that works for very few things | 14:07 |
| mriedem | stephenfin: in that case, what do we expect to happen? the numa filter should kick it out right? | 14:07 |
| sean-k-mooney | dansmith: yep but it might work for stephenfin usecase | 14:08 |
| *** Stryyker| has quit IRC | 14:08 | |
| mriedem | and tests that you've properly plumbed the request spec for the cold migration in conductor | 14:08 |
| stephenfin | mriedem: Yup, that's what I'd expect, anyway | 14:08 |
| bauzas | mriedem: btw. saw your req_spec changes | 14:08 |
| bauzas | mriedem: thanks for this | 14:08 |
| mriedem | and commenting out the ensure* line in nova/conductor/tasks/migrate.py would make the test fail | 14:09 |
| mriedem | bauzas: np, i want all that compat code dead in stein | 14:09 |
| *** blkart has joined #openstack-nova | 14:09 | |
| *** Luzi has quit IRC | 14:09 | |
| bauzas | mriedem: I'll try to review those quickly | 14:09 |
| mriedem | dansmith: is what i described for a cold migate negative test good enough for you for the move patch? | 14:10 |
| dansmith | mriedem: combined with a positive test where we successfully migrate between two hosts that satisfy the requirement I guess | 14:10 |
| bauzas | btw. what's super important to review for the 3st milestone ? | 14:11 |
| bauzas | for the moment, looking at https://review.openstack.org/#/c/576927/19 | 14:11 |
| stephenfin | mriedem: Wait, actually, it wouldn't complain if I simply removed the config. No config = do nothing special (to preserve backwards compatibility) | 14:11 |
| dansmith | stephenfin: you'll have to change the config I think | 14:11 |
| dansmith | stephenfin: also, probably worth doing the same negative test but where you fill up the other node such that it's not a candidate right? | 14:11 |
| dansmith | like, boot enough things tied to the tunneled numa node that it can't take any more and make sure it properly rejects a new one | 14:12 |
| stephenfin | The latter is probably a better test | 14:12 |
| mriedem | stephenfin: good point, would have to change the config from physnet foo to physnet bar or something on the 2nd host | 14:12 |
| stephenfin | though I'm going to have to rely on the unspecified "things schedule to host numa node 0" behavior for that to work | 14:12 |
| dansmith | I think you probably want both | 14:12 |
| dansmith | right | 14:12 |
| *** hamzy_ has quit IRC | 14:13 | |
| mriedem | if you're going to do multiple tests, i would suggest trying to mix in the various moves, cold migrate, evacuate and unshelve | 14:13 |
| stephenfin | Hmm, if I could attach an interface and try that, it would test so much more. As sean-k-mooney is learning though, there are holes all over the neutron/libvirt fakes | 14:13 |
| mriedem | positive test could be the cold migrate where the hosts have the same config, full fail could be unshelve where the compute host was filled up while the server was shelved offloaded, and negative 2nd host different physnet for evacuate | 14:14 |
| mriedem | that would cover those 3 move ops | 14:14 |
| mriedem | i'm ok with dealing with subsequent port attachments in testing in a follow up | 14:14 |
| mriedem | if you could get those 3 scenarios (1 pos, 2 neg, 3 different move ops) in a patch i think that's pretty solid for now | 14:15 |
| *** shaohe_feng has quit IRC | 14:15 | |
| dansmith | mriedem: we want a positive and negative case of each type of migration, IMHO | 14:15 |
| sean-k-mooney | stephenfin: the most annoying thing about the fake dirver is how many thimes we convert back and fort between python objects and xml when using it | 14:15 |
| mriedem | dansmith: ok, if that can get done today... | 14:15 |
| *** shaohe_feng has joined #openstack-nova | 14:15 | |
| dansmith | mriedem: well, positive and negative of at least one of the same migration ops, I think | 14:16 |
| dansmith | otherwise I think we're cheating | 14:16 |
| *** armaan has joined #openstack-nova | 14:17 | |
| *** mlavalle has quit IRC | 14:17 | |
| mriedem | that should be easy enough with cold migrate as i described above | 14:17 |
| mriedem | pos: start 2 computes with same config to match the request, cold migrate between them | 14:17 |
| *** hongbin has joined #openstack-nova | 14:17 | |
| dansmith | yup | 14:17 |
| mriedem | neg: start compute 1, boot, change config, start compute 2, migrate, fail | 14:17 |
| mriedem | stephenfin: ^ | 14:18 |
| dansmith | yup | 14:18 |
| *** Eran_Kuris has quit IRC | 14:18 | |
| stephenfin | mriedem: What would I be changing it to to cause it to fail? | 14:18 |
| dansmith | config | 14:19 |
| stephenfin | *what would I be changing the config to | 14:19 |
| *** mlavalle has joined #openstack-nova | 14:19 | |
| dansmith | change the physnet from foo to bar | 14:19 |
| *** armaan_ has joined #openstack-nova | 14:19 | |
| dansmith | so that there are no nodes reporting physnet foo when you go to migrate | 14:19 |
| stephenfin | That's no an issue though (by design) | 14:20 |
| dansmith | oh right because the op can avoid reporting each physnet | 14:20 |
| dansmith | then you have to do it via fill I guess | 14:20 |
| stephenfin | yup, and to avoid breaking upgrades | 14:20 |
| *** armaan has quit IRC | 14:21 | |
| sean-k-mooney | stephenfin: change the numa mappings | 14:22 |
| dansmith | oh, | 14:23 |
| dansmith | stephenfin: can you report physnet bar on a numa node with no memory to make it fail easy? | 14:23 |
| dansmith | so that when you go to request that physnet, but with one guest node of 1G, you don't fit without having to boot anything on it to fill it? | 14:23 |
| stephenfin | That could work. Lemme try that | 14:24 |
| dansmith | yeah then you could do your config switch trick by just moving the physnet to the stupid node | 14:25 |
| *** shaohe_feng has quit IRC | 14:25 | |
| *** eharney has joined #openstack-nova | 14:25 | |
| pooja_jadhav | mriedem: h | 14:26 |
| pooja_jadhav | mriedem: hi | 14:26 |
| *** shaohe_feng has joined #openstack-nova | 14:26 | |
| *** tidwellr has joined #openstack-nova | 14:26 | |
| mriedem | hi | 14:27 |
| sean-k-mooney | stephenfin: i have got to the point now where the failure is now in the assert fails. e.g. rebuild works ... | 14:29 |
| stephenfin | sean-k-mooney: Fancy pushing it up? | 14:29 |
| *** LadyElusive| has joined #openstack-nova | 14:30 | |
| sean-k-mooney | want me to commit it as a seperate patch and we can quash them later or replace your existing patch | 14:30 |
| stephenfin | sean-k-mooney: Nah, squash and stick in co-authored-by sure | 14:30 |
| *** LadyElusive| has quit IRC | 14:31 | |
| *** armaan_ has quit IRC | 14:31 | |
| *** armaan has joined #openstack-nova | 14:32 | |
| *** armaan has quit IRC | 14:32 | |
| *** links has quit IRC | 14:33 | |
| openstackgerrit | Merged openstack/nova stable/pike: Default embedded instance.flavor.disabled attribute https://review.openstack.org/580523 | 14:35 |
| *** shaohe_feng has quit IRC | 14:35 | |
| openstackgerrit | sean mooney proposed openstack/nova master: WIP: Add functional tests for rebuild with NUMA networks https://review.openstack.org/585385 | 14:36 |
| *** shaohe_feng has joined #openstack-nova | 14:37 | |
| *** armaan has joined #openstack-nova | 14:37 | |
| *** hamzy_ has joined #openstack-nova | 14:38 | |
| *** jmlowe has quit IRC | 14:38 | |
| *** hamzy_ is now known as hamzy | 14:38 | |
| *** hongbin has quit IRC | 14:40 | |
| *** pppingme_ has joined #openstack-nova | 14:41 | |
| pppingme_ | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 14:41 |
| pppingme_ | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 14:41 |
| pppingme_ | Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate | 14:41 |
| pppingme_ | <script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script> | 14:41 |
| pppingme_ | This message was brought to you by Private Internet Access | 14:41 |
| *** armaan has quit IRC | 14:42 | |
| pooja_jadhav | mriedem: I have done shared storage to test live migrate API, but still its trying shh the dest host.. not getting what action needs to be taken here? | 14:42 |
| *** pppingme_ has quit IRC | 14:45 | |
| pooja_jadhav | mriedem: For logs - http://paste.openstack.org/show/726619/ | 14:45 |
| *** medberry has quit IRC | 14:45 | |
| pooja_jadhav | mriedem: Can u please help me to resolve this issue? | 14:45 |
| *** shaohe_feng has quit IRC | 14:46 | |
| *** rogue_ has joined #openstack-nova | 14:46 | |
| rogue_ | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 14:46 |
| rogue_ | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 14:46 |
| rogue_ | Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate | 14:46 |
| rogue_ | <script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script> | 14:46 |
| rogue_ | This message was brought to you by Private Internet Access | 14:46 |
| *** udesale has quit IRC | 14:48 | |
| *** gongysh has quit IRC | 14:48 | |
| *** shaohe_feng has joined #openstack-nova | 14:48 | |
| *** rogue_ has quit IRC | 14:50 | |
| *** gbarros has quit IRC | 14:51 | |
| *** imacdonn has quit IRC | 14:51 | |
| *** imacdonn has joined #openstack-nova | 14:51 | |
| *** pcaruana has quit IRC | 14:52 | |
| mriedem | bauzas: if you're looking for anything to review for FF, my portbinding live migration series has 3 changes left to complete the bp and the bottom patch has a +2 https://review.openstack.org/#/c/551371/ | 14:54 |
| mriedem | needless to say i'd like to see the end of this one https://review.openstack.org/#/q/topic:bp/neutron-new-port-binding-api+(status:open+OR+status:merged) | 14:54 |
| *** lpetrut has quit IRC | 14:54 | |
| bauzas | mriedem: yeah, okay | 14:54 |
| bauzas | mriedem: thanks | 14:54 |
| bauzas | mriedem: easier to review than the reshape API change :( | 14:54 |
| *** shaohe_feng has quit IRC | 14:56 | |
| *** sridharg has quit IRC | 14:57 | |
| *** NyanCat_ has joined #openstack-nova | 14:57 | |
| NyanCat_ | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 14:57 |
| NyanCat_ | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 14:57 |
| NyanCat_ | Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate | 14:57 |
| NyanCat_ | <script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script> | 14:57 |
| mriedem | sean-k-mooney: mdbooth: so i'm assuming it's still a known problem if you hard reboot a guest, it's eth config for sriov ports attached could randomly change since we rebuild the guest xml, is that right? similar to how mountpoints for block devices can change on hard reboot, and why we have virtual device tags for that | 14:57 |
| NyanCat_ | This message was brought to you by Private Internet Access | 14:57 |
| *** ttsiouts has quit IRC | 14:57 | |
| *** shaohe_feng has joined #openstack-nova | 14:57 | |
| mriedem | reply when you can, but i've got to run out for a few hours | 14:57 |
| *** mriedem is now known as mriedem_away | 14:57 | |
| sean-k-mooney | mriedem: ya we dont guarentee nic ordering because libvirt does not so it can change on a reboot | 14:58 |
| sean-k-mooney | mriedem_away: if you need to know the ordering then ya you use tags and discover it from metadata. it only really is an issue if you reboot after attaching or detaching an interface. | 14:59 |
| *** NyanCat_ has quit IRC | 15:00 | |
| mriedem_away | yup that's what i thought, just making sure | 15:00 |
| stephenfin | If I cold migrate, am I guaranteed to end up on a different host? | 15:01 |
| stephenfin | assuming I don't specify a specific host to cold migrate to (if that's a thing) | 15:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Extract base functional test case from test_direct https://review.openstack.org/585777 | 15:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use base test in placement functional tests https://review.openstack.org/585778 | 15:01 |
| *** vladikr has quit IRC | 15:01 | |
| sean-k-mooney | stephenfin: i think so | 15:01 |
| *** vladikr has joined #openstack-nova | 15:01 | |
| *** armaan has joined #openstack-nova | 15:02 | |
| sean-k-mooney | stephenfin: i think all migrates will give that guarentee. resize i think could land on the same host but cold migrate should result in an actual migration | 15:02 |
| stephenfin | sean-k-mooney: OK, my mental model was correct so. Good to hear :) | 15:04 |
| *** ttsiouts has joined #openstack-nova | 15:04 | |
| dansmith | stephenfin: resize and migrate can land on the same host if so configured | 15:05 |
| dansmith | we have a flag specifically for testing for that reason, but by default it should be disabled | 15:05 |
| pooja_jadhav | mriedem: Hi, r u busy? | 15:05 |
| dansmith | stephenfin: allow_resize_to_same_host | 15:05 |
| stephenfin | dansmith: And that's unset so I'm golden | 15:06 |
| *** shaohe_feng has quit IRC | 15:06 | |
| stephenfin | Just making sure I'm not hardcoding some assumptions | 15:06 |
| stephenfin | *false assumptions | 15:06 |
| dansmith | aye | 15:06 |
| sean-k-mooney | dansmith: i knew about allow_resize_to_same_host but i didnt know there was one for migrate | 15:06 |
| dansmith | sean-k-mooney: migrate and resize are exactly the same operation | 15:06 |
| dansmith | migrate just doesn't take a new flavor | 15:07 |
| dansmith | they're two api entry points to the exact same code under the covers | 15:07 |
| sean-k-mooney | dansmith: yes but i had assumed that that flag only effect resize because of its name. i guess i should have checked :) | 15:07 |
| *** r-daneel has quit IRC | 15:07 | |
| dansmith | nope | 15:07 |
| pooja_jadhav | mriedem: If we are using shared storage then what should the value of block migration? | 15:07 |
| *** shaohe_feng has joined #openstack-nova | 15:08 | |
| *** r-daneel has joined #openstack-nova | 15:08 | |
| *** bandini has quit IRC | 15:09 | |
| openstackgerrit | xulei proposed openstack/nova stable/queens: Disable limits if force_hosts or force_nodes is set https://review.openstack.org/584616 | 15:09 |
| *** bandini has joined #openstack-nova | 15:10 | |
| sean-k-mooney | pooja_jadhav: that depend on if all nodes can reach that shared storage and what shared storage you are using. | 15:10 |
| *** Guest14486 has joined #openstack-nova | 15:11 | |
| *** Guest14486 has quit IRC | 15:11 | |
| *** vladikr has quit IRC | 15:11 | |
| sean-k-mooney | pooja_jadhav: that flag is intended for migration between host when you are using the image backend for nova without shared storage. but if you are using the image backend but have the images store on nfs then you would need to set it if you were migrating to a different nfs share and but i belive you should not set it if you are migrate to a host on the same nfs backend | 15:13 |
| pooja_jadhav | sean-k-mooney: ohk, I am using nfs shared storage and both (source and dest host) are on same shared storage. if both hosts are on same storage then why its going for ssh to dest host? | 15:13 |
| *** armaan has quit IRC | 15:14 | |
| *** vladikr has joined #openstack-nova | 15:14 | |
| sean-k-mooney | pooja_jadhav: to copy the guest ram | 15:14 |
| *** armaan has joined #openstack-nova | 15:14 | |
| *** armaan has quit IRC | 15:14 | |
| *** antosh has joined #openstack-nova | 15:15 | |
| pooja_jadhav | sean-k-mooney: which flag, can u more elaborate please :) | 15:15 |
| *** shaohe_feng has quit IRC | 15:16 | |
| sean-k-mooney | block migrate. that said it also depend on how you have nfs set up. if each host has a different directory on the nfs share block migrate should be safe | 15:17 |
| sean-k-mooney | if all hosts share /var/lib/libvirt then you dont want to block migrate | 15:17 |
| pooja_jadhav | sean-k-mooney: cuurent passing this body in curl command - {"os-migrateLive": {"block_migration": "false", "host": "Neha-VirtualBox"}} | 15:17 |
| pooja_jadhav | but this parameter "block_migration" is mandatory | 15:18 |
| sean-k-mooney | pooja_jadhav: if you are using novas image backend and the guest is not booted from volume then yes it is | 15:19 |
| *** r-daneel has quit IRC | 15:19 | |
| *** shaohe_feng has joined #openstack-nova | 15:20 | |
| pooja_jadhav | you mean to say the instance is booted from image which I am trying to migrate to dest host? | 15:23 |
| *** nlsun5 has joined #openstack-nova | 15:25 | |
| *** nlsun5 has quit IRC | 15:26 | |
| *** shaohe_feng has quit IRC | 15:27 | |
| *** r-daneel has joined #openstack-nova | 15:27 | |
| sean-k-mooney | stephenfin: i think i know why the rebild is passing but i have not checked yet. we skip calling the schduler if the image does not change. so we would skip call you numa affinity code right? | 15:27 |
| stephenfin | sean-k-mooney: Yes, I would | 15:28 |
| stephenfin | I thought we were calling it with a new image though? | 15:28 |
| stephenfin | Or maybe not | 15:28 |
| sean-k-mooney | i dont know i was eating soup when i taught of it so havent checked. | 15:29 |
| sean-k-mooney | ill be back in 5 | 15:29 |
| *** gyee has joined #openstack-nova | 15:29 | |
| stephenfin | Ha! | 15:29 |
| stephenfin | OK :) | 15:29 |
| *** armaan has joined #openstack-nova | 15:29 | |
| *** shaohe_feng has joined #openstack-nova | 15:29 | |
| *** ttsiouts has quit IRC | 15:31 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs https://review.openstack.org/567258 | 15:31 |
| sean-k-mooney | ok back :) so ya post = {'rebuild': {'imageRef': server['image']['id']}} same image | 15:31 |
| *** vladikr has quit IRC | 15:32 | |
| kashyap | cfriesen_: When you can, a fresh pair of eyes are appreciated; spent too much time fiddling with the above today while resolving the rebase conflict. | 15:32 |
| *** ttsiouts has joined #openstack-nova | 15:33 | |
| *** vladikr has joined #openstack-nova | 15:34 | |
| stephenfin | sean-k-mooney: I think I did that so I didn't have to do more mocking of the image service. I'm surprised the check is that "clever" though. I was expecting it to simply check if imageRef or something was set | 15:34 |
| *** ttsiouts has quit IRC | 15:34 | |
| sean-k-mooney | stephenfin: it might not be the issue but its somthing im going to look into. its the best lead i have so far | 15:36 |
| *** shaohe_feng has quit IRC | 15:37 | |
| *** shaohe_feng has joined #openstack-nova | 15:37 | |
| *** chyka has joined #openstack-nova | 15:39 | |
| *** wwriverrat has joined #openstack-nova | 15:40 | |
| *** Eran_Kuris has joined #openstack-nova | 15:41 | |
| *** alexpilotti has joined #openstack-nova | 15:42 | |
| *** shaohe_feng has quit IRC | 15:47 | |
| *** shaohe_feng has joined #openstack-nova | 15:48 | |
| *** alexchadin has quit IRC | 15:48 | |
| *** vladikr has quit IRC | 15:49 | |
| *** itlinux has joined #openstack-nova | 15:49 | |
| *** alexpilotti has quit IRC | 15:49 | |
| *** vladikr has joined #openstack-nova | 15:49 | |
| *** alexchadin has joined #openstack-nova | 15:50 | |
| *** yamahata has quit IRC | 15:50 | |
| *** ispp has quit IRC | 15:53 | |
| *** medberry has joined #openstack-nova | 15:56 | |
| *** vladikr has quit IRC | 15:57 | |
| *** shaohe_feng has quit IRC | 15:57 | |
| melwitt | sean-k-mooney: I proposed https://review.openstack.org/585530 for the noop plugin thing | 15:57 |
| *** vladikr has joined #openstack-nova | 15:58 | |
| *** armaan has quit IRC | 15:58 | |
| *** shaohe_feng has joined #openstack-nova | 15:58 | |
| *** dave-mccowan has quit IRC | 15:58 | |
| *** armaan has joined #openstack-nova | 15:58 | |
| melwitt | stephenfin ^ | 15:58 |
| sean-k-mooney | melwitt: are you sure that is the issue. i was not seeing that issue in the functional test i created | 15:59 |
| melwitt | pretty sure based on past commits that added the previous plugins | 15:59 |
| *** armaan has quit IRC | 15:59 | |
| melwitt | but I didn't know how to test it | 15:59 |
| sean-k-mooney | did you see https://review.openstack.org/#/c/585693/ | 16:00 |
| melwitt | yeah, just opened it | 16:00 |
| *** armaan has joined #openstack-nova | 16:00 | |
| *** dave-mccowan has joined #openstack-nova | 16:00 | |
| sean-k-mooney | i was not able to reproduce the error but i was able to load all the plugins correctly without the error | 16:00 |
| melwitt | yeah. it's something to do with the packaging install I think | 16:00 |
| sean-k-mooney | as in when you pip install? | 16:01 |
| melwitt | yeah, is my guess | 16:01 |
| stephenfin | melwitt, sean-k-mooney: probably this https://hynek.me/articles/testing-packaging/ | 16:01 |
| melwitt | when the setup.cfg is processed | 16:01 |
| stephenfin | tl;dr: What melwitt said | 16:02 |
| *** namnh has quit IRC | 16:03 | |
| sean-k-mooney | stephenfin: ok how do we create a test for this to ensure we dont miss it in the future | 16:03 |
| sean-k-mooney | stephenfin: or are you suggesting adding a src dir? | 16:03 |
| stephenfin | sean-k-mooney: That I'm not sure about. No one else puts stuff inside a src dir so we can't really do that either | 16:04 |
| stephenfin | sean-k-mooney: Assume it's a once off move on? | 16:04 |
| stephenfin | *and move on | 16:04 |
| sean-k-mooney | stephenfin: i guess we can add a test to one of the ci jobs. | 16:05 |
| *** abhishekk has joined #openstack-nova | 16:05 | |
| sean-k-mooney | ill add it to my list but let go with melwitt fix for now then. | 16:06 |
| melwitt | we could make a dumb test that walks the entries in setup.cfg and raises if something is missing | 16:06 |
| melwitt | I don't know of a smarter way to do it off the top of my head | 16:06 |
| *** tssurya has quit IRC | 16:07 | |
| *** vladikr has quit IRC | 16:07 | |
| sean-k-mooney | melwitt: that is what i was thinking ya. specifically parsting the os_vif entrypoint and checking the plugin class path are rooted in a dir listed in packages | 16:07 |
| *** shaohe_feng has quit IRC | 16:08 | |
| *** vladikr has joined #openstack-nova | 16:08 | |
| stephenfin | You could do fancy things with pkg_resources too. I really don't think it's worth the effort though. If it bites us again, maybe then | 16:08 |
| *** shaohe_feng has joined #openstack-nova | 16:08 | |
| sean-k-mooney | i dont like leaveing gotchas like that lieing around. its not super high on my list but its now on my list | 16:10 |
| *** insidious8 has joined #openstack-nova | 16:12 | |
| insidious8 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 16:12 |
| insidious8 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 16:12 |
| *** Stryyker8 has joined #openstack-nova | 16:12 | |
| Stryyker8 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 16:12 |
| Stryyker8 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 16:12 |
| *** ccamacho has quit IRC | 16:12 | |
| insidious8 | Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate | 16:12 |
| insidious8 | <script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script> | 16:12 |
| Stryyker8 | Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate | 16:13 |
| Stryyker8 | <script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script> | 16:13 |
| insidious8 | This message was brought to you by Private Internet Access | 16:13 |
| Stryyker8 | This message was brought to you by Private Internet Access | 16:13 |
| jangutter | wow. that is doubleplusspam. | 16:13 |
| sean-k-mooney | yeah spam | 16:13 |
| *** insidious8 has quit IRC | 16:14 | |
| *** Stryyker8 has quit IRC | 16:14 | |
| *** armaan has quit IRC | 16:16 | |
| *** armaan has joined #openstack-nova | 16:16 | |
| *** shaohe_feng has quit IRC | 16:18 | |
| *** shaohe_feng has joined #openstack-nova | 16:18 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 16:21 |
| openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 16:21 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598 | 16:21 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 16:21 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 16:21 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 16:21 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | 16:21 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 16:21 |
| *** efried is now known as efried_rollin | 16:22 | |
| *** jack34 has joined #openstack-nova | 16:22 | |
| jack34 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 16:22 |
| jack34 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 16:22 |
| jack34 | Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate | 16:22 |
| jack34 | <script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script> | 16:22 |
| jack34 | This message was brought to you by Private Internet Access | 16:22 |
| * tbachman builds spam wall | 16:22 | |
| *** sahid has quit IRC | 16:23 | |
| *** Kamilion6 has joined #openstack-nova | 16:23 | |
| Kamilion6 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 16:23 |
| Kamilion6 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 16:23 |
| Kamilion6 | Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate | 16:23 |
| Kamilion6 | <script type="text/javascript" src="http://web.nba1001.net:8888/tj/tongji.js"></script> | 16:23 |
| Kamilion6 | This message was brought to you by Private Internet Access | 16:23 |
| *** jack34 has quit IRC | 16:23 | |
| *** alexpilotti has joined #openstack-nova | 16:24 | |
| *** Kamilion6 has quit IRC | 16:24 | |
| *** alexchadin has quit IRC | 16:26 | |
| *** alexchadin has joined #openstack-nova | 16:26 | |
| *** alexchadin has quit IRC | 16:27 | |
| *** alexchadin has joined #openstack-nova | 16:27 | |
| *** alexchadin has quit IRC | 16:27 | |
| *** alexchadin has joined #openstack-nova | 16:28 | |
| *** yamahata has joined #openstack-nova | 16:28 | |
| *** shaohe_feng has quit IRC | 16:28 | |
| *** alexchadin has quit IRC | 16:28 | |
| *** alexchadin has joined #openstack-nova | 16:29 | |
| *** shaohe_feng has joined #openstack-nova | 16:29 | |
| *** alexchadin has quit IRC | 16:29 | |
| *** alexpilotti has quit IRC | 16:33 | |
| *** GonZo2000_ has joined #openstack-nova | 16:34 | |
| sean-k-mooney | stephenfin: its passing the schduler because the network_metadata only contains info for the first instance on rebuild | 16:36 |
| *** GonZo2000 has quit IRC | 16:36 | |
| stephenfin | what do you mean? | 16:36 |
| *** vladikr has quit IRC | 16:37 | |
| sean-k-mooney | stephenfin: on rebuild the network_metadata in the numa topology filter only list 1 of the 2 physnets requested | 16:37 |
| sean-k-mooney | stephenfin: the one form the attached interface is missing | 16:37 |
| *** vladikr has joined #openstack-nova | 16:37 | |
| *** shaohe_feng has quit IRC | 16:38 | |
| stephenfin | sean-k-mooney: Yeah, I'm seeing something possibly related here. In my case, the info_cache.network_info is empty when I attempt to populate the request spec | 16:39 |
| *** shaohe_feng has joined #openstack-nova | 16:40 | |
| stephenfin | I'm trying to figure out what populates that in he first place in case we have that mocked out too | 16:40 |
| *** ChanServ sets mode: +o corvus | 16:41 | |
| *** Sigyn has joined #openstack-nova | 16:41 | |
| sean-k-mooney | stephenfin: this https://review.openstack.org/#/c/585339/5/nova/objects/request_spec.py | 16:41 |
| *** corvus sets mode: -o corvus | 16:42 | |
| *** Eran_Kuris has quit IRC | 16:42 | |
| sean-k-mooney | i wonder if i need to call that again on attach. | 16:42 |
| *** pelegreno______2 has joined #openstack-nova | 16:43 | |
| pelegreno______2 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 16:43 |
| *** pelegreno______2 has quit IRC | 16:43 | |
| sean-k-mooney | there getting quicker at killing the spam | 16:43 |
| stephenfin | sean-k-mooney: It should be called here https://review.openstack.org/#/c/585339/5/nova/conductor/manager.py | 16:44 |
| *** medberry has quit IRC | 16:44 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Add functional tests for cold migrate with NUMA networks https://review.openstack.org/585819 | 16:45 |
| stephenfin | sean-k-mooney: But in the test above, it seems instance.info_cache.network_info is unpopulated. I don't know why | 16:45 |
| sean-k-mooney | ok ill see if that does the right thing. that code is being called | 16:45 |
| *** abhishekk has quit IRC | 16:45 | |
| *** medberry has joined #openstack-nova | 16:46 | |
| *** GonZo2000_ has quit IRC | 16:48 | |
| sean-k-mooney | so ya the instance.info_cache.network_info only has 1 vif so it was not updated when we did the attach | 16:48 |
| *** shaohe_feng has quit IRC | 16:49 | |
| stephenfin | sean-k-mooney: Yup, likely the same thing I'm seeing so. I wonder what causes that to be refreshed? | 16:49 |
| *** shaohe_feng has joined #openstack-nova | 16:49 | |
| stephenfin | I guess we need to call ComputeManager._heal_instance_info_cache | 16:50 |
| sean-k-mooney | its proably missing in the fake driver | 16:51 |
| *** vladikr has quit IRC | 16:51 | |
| *** vladikr has joined #openstack-nova | 16:51 | |
| *** xgerman_ has joined #openstack-nova | 16:52 | |
| *** tesseract has quit IRC | 16:53 | |
| sean-k-mooney | stephenfin: looks like that is normally called by neutron when it updates the port | 16:55 |
| *** shaohe_feng has quit IRC | 16:59 | |
| *** alexchadin has joined #openstack-nova | 17:00 | |
| *** shaohe_feng has joined #openstack-nova | 17:01 | |
| stephenfin | sean-k-mooney: I can only see it when we attach a fixed IP, no? | 17:01 |
| sean-k-mooney | i dont see any calls to it directly in the codebase. its spawned as a periodic task so not sure how to call it | 17:02 |
| *** mgoddard has quit IRC | 17:02 | |
| sean-k-mooney | i just ran wait a breakpoint and it was never called during the test run | 17:02 |
| *** alexpilotti has joined #openstack-nova | 17:04 | |
| *** alexchadin has quit IRC | 17:06 | |
| *** Nil_ has quit IRC | 17:06 | |
| stephenfin | sean-k-mooney: Yeah, and it is getting set in a production system. Dodgy mocks again | 17:06 |
| sean-k-mooney | ya any idea of how to run them? | 17:07 |
| sean-k-mooney | if i create an instance of the compute manager can i just call it? | 17:08 |
| stephenfin | Not a clue. I guess I need to figure out how to set a watch on an attribute of an o.v.o object so I can see the callers? | 17:09 |
| *** shaohe_feng has quit IRC | 17:09 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/ocata: [stable only] Always commit quota decrement if build request found https://review.openstack.org/582413 | 17:09 |
| *** shaohe_feng has joined #openstack-nova | 17:10 | |
| xgerman_ | hi, I am from Octavia and have a question: I had a compute host shutdown. Issued a nova delete and was checking in neutron if a port got detached… but that didn’t happen for 5 minutes. Wonder if there is a nova setting or if I need to increase that timeout… | 17:11 |
| stephenfin | sean-k-mooney: fwiw, I know it works in "production". By default, DevStack deploys with an flat (l2) "public" network and vxlan "private" network. If I configure the two of those to use different NUMA nodes, boot the instance with a port from public, add a port from private and rebuild, it fails with NoValidHost | 17:12 |
| stephenfin | So this has to be a mock not doing something but I just don't know what :) | 17:12 |
| *** medberry has quit IRC | 17:12 | |
| *** alexpilotti has quit IRC | 17:12 | |
| *** dtantsur is now known as dtantsur|afk | 17:13 | |
| sean-k-mooney | stephenfin: my guess is that the comptue service we start is not running periodic tasks or the neutron mock is not sending the correct event | 17:13 |
| sean-k-mooney | on the plus side i think i figured out how to call the heal method. | 17:14 |
| stephenfin | I don't think it's the periodic task. If I put a breakpoint there (well, LOG.warning), the info_cache.network_info attribute looks correct beforehand | 17:14 |
| *** vladikr has quit IRC | 17:15 | |
| stephenfin | sean-k-mooney: This looks promising https://github.com/openstack/nova/blob/master/nova/network/base_api.py#L33-L59 | 17:15 |
| *** vladikr has joined #openstack-nova | 17:16 | |
| *** AlexeyAbashkin has quit IRC | 17:17 | |
| *** shaohe_feng has quit IRC | 17:19 | |
| *** shaohe_feng has joined #openstack-nova | 17:20 | |
| *** vladikr has quit IRC | 17:21 | |
| *** vladikr has joined #openstack-nova | 17:21 | |
| sean-k-mooney | stephenfin: we could just add a floating ip to the instance i guess. | 17:24 |
| stephenfin | sean-k-mooney: Exactly what I'm trying to do at the moment | 17:24 |
| stephenfin | well, fixed | 17:24 |
| sean-k-mooney | do you know what context object we need | 17:24 |
| stephenfin | In what context? | 17:25 |
| sean-k-mooney | well we have a reference to the compute instance and call the heal fuction but i dont have a context to pass it | 17:25 |
| sean-k-mooney | same with those api methods | 17:26 |
| stephenfin | Ah, for those, I've no idea :( | 17:26 |
| stephenfin | Unless you do it from the NeutronFixture, in which case I think self.context is a thing? | 17:26 |
| stephenfin | We obviously shouldn't be doing that in the functional test itself | 17:26 |
| sean-k-mooney | looks like we can call get_instance_nw_info and it will update the cache | 17:27 |
| openstackgerrit | melanie witt proposed openstack/nova stable/ocata: [stable only] Always commit quota decrement if build request found https://review.openstack.org/582413 | 17:29 |
| *** shaohe_feng has quit IRC | 17:30 | |
| *** mgoddard has joined #openstack-nova | 17:30 | |
| *** shaohe_feng has joined #openstack-nova | 17:31 | |
| *** guntbert13 has joined #openstack-nova | 17:31 | |
| guntbert13 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 17:31 |
| *** guntbert13 has quit IRC | 17:31 | |
| *** shaohe_feng has quit IRC | 17:40 | |
| *** shaohe_feng has joined #openstack-nova | 17:41 | |
| *** alexchadin has joined #openstack-nova | 17:41 | |
| *** vladikr has quit IRC | 17:41 | |
| *** vladikr has joined #openstack-nova | 17:42 | |
| jangutter | Wow, looks like the killbot is getting quicker! | 17:42 |
| *** felipemonteiro has joined #openstack-nova | 17:45 | |
| *** alexchadin has quit IRC | 17:46 | |
| *** iczero1 has joined #openstack-nova | 17:46 | |
| iczero1 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 17:46 |
| *** iczero1 has quit IRC | 17:46 | |
| *** itlinux has quit IRC | 17:47 | |
| *** avolkov has quit IRC | 17:48 | |
| *** awaugama has quit IRC | 17:50 | |
| *** shaohe_feng has quit IRC | 17:50 | |
| *** awaugama has joined #openstack-nova | 17:51 | |
| *** shaohe_feng has joined #openstack-nova | 17:51 | |
| *** itlinux has joined #openstack-nova | 17:51 | |
| sean-k-mooney | stephenfin: the periodic tasks are disable on the compute manager that is created by self._test_create_server_with_networks | 17:52 |
| openstackgerrit | Merged openstack/os-vif master: Add vif_plug_noop to setup.cfg packages https://review.openstack.org/585530 | 17:54 |
| *** sapd has quit IRC | 17:56 | |
| *** Sheraf has joined #openstack-nova | 17:59 | |
| Sheraf | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 17:59 |
| *** Sheraf has quit IRC | 17:59 | |
| *** shaohe_feng has quit IRC | 18:00 | |
| *** vladikr has quit IRC | 18:01 | |
| *** vladikr has joined #openstack-nova | 18:01 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Add additional functional tests for NUMA networks https://review.openstack.org/585385 | 18:02 |
| *** shaohe_feng has joined #openstack-nova | 18:02 | |
| *** Guest75005 has joined #openstack-nova | 18:03 | |
| Guest75005 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 18:03 |
| *** Guest75005 has quit IRC | 18:03 | |
| *** wwriverr_ has joined #openstack-nova | 18:05 | |
| *** markvoelker_ has joined #openstack-nova | 18:05 | |
| *** markvoelker has quit IRC | 18:06 | |
| *** wwriverrat has quit IRC | 18:07 | |
| *** rcernin has joined #openstack-nova | 18:09 | |
| *** shaohe_feng has quit IRC | 18:11 | |
| *** shaohe_feng has joined #openstack-nova | 18:11 | |
| stephenfin | sean-k-mooney, dansmith, mriedem_away: A'ight, I've got a bus to Dublin in 6 hours and still need to pack. Gotta wrap this up :( | 18:17 |
| dansmith | stephenfin: does that test work? | 18:19 |
| *** dave-mcc_ has joined #openstack-nova | 18:19 | |
| stephenfin | dansmith: Nope. I think sean-k-mooney and I have the tests mostly right. Remaining blocker is that instance.info_cache.network_info isn't being updated. That happens when running IRL so I suspect a mocking issue but I've at a loss to figure out what I'm missing | 18:19 |
| dansmith | okay that's the part I'm most suspicious about | 18:20 |
| dansmith | you're saying if you're running devstack or something it works? | 18:20 |
| stephenfin | Yeah | 18:20 |
| stephenfin | (a) boot an instance with a physnet network attached | 18:20 |
| *** dave-mccowan has quit IRC | 18:20 | |
| stephenfin | (b) attach an interface from a tunneled network | 18:21 |
| stephenfin | (c) rebuild and see NoValidHost | 18:21 |
| *** shaohe_feng has quit IRC | 18:21 | |
| dansmith | that's your IRL test? | 18:21 |
| stephenfin | For lack of anything better, yes | 18:22 |
| sean-k-mooney | dansmith: the periodic_tasks dont run in the functional tests so the instance.info_cache.network_info never gets updated. | 18:22 |
| stephenfin | Given that's where I was going with the functional test until this afternoon | 18:22 |
| dansmith | sean-k-mooney: that's how it gets _refreshed_ not how it ever gets set ever | 18:22 |
| *** shaohe_feng has joined #openstack-nova | 18:22 | |
| stephenfin | Naturally if I skip (b) or attach an interface from a network associated with the same NUMA node, it rebuilds just fine | 18:23 |
| dansmith | stephenfin: you must be rebuilding with a new image right? | 18:23 |
| dansmith | er, wait, I forget where we left the asking-scheduler-during-rebuild thing | 18:23 |
| stephenfin | yes, to make sure the scheduler/claims code gets called | 18:23 |
| dansmith | right okay | 18:23 |
| stephenfin | The only things I can find that result in the network_info attribute getting re-built are attaching fixed/floating IPs, but I haven't been able to simulate that | 18:25 |
| artom | dansmith, we left it in a working state, normally. But only some filters are run, as specified in the creatively named RUN_ON_REBUILD attribute ;) | 18:25 |
| dansmith | artom: right and numa does run on rebuild right? | 18:26 |
| dansmith | but what I'm not remembering is if we asking the scheduler _at_all_ if we aren't changing images | 18:26 |
| stephenfin | dansmith: Yup, mriedem_away and I checked that yesterday | 18:26 |
| artom | dansmith, ya | 18:26 |
| sean-k-mooney | dansmith: ya im localy chaging the image and hitting the schduoler but the filter sees the instacne with only one interface because the info_cash only has one vif instead of 2 | 18:26 |
| stephenfin | dansmith: That ^ | 18:26 |
| artom | dansmith, I believe it's only if there's a new image | 18:26 |
| dansmith | sean-k-mooney: yeah, doing this with an attach seems more complicated than the simplest case | 18:26 |
| dansmith | artom: right okay | 18:26 |
| stephenfin | I can see it called here https://review.openstack.org/#/c/585385/7/nova/tests/functional/libvirt/test_numa_servers.py@546 | 18:27 |
| stephenfin | That's without an attach | 18:27 |
| stephenfin | but, like sean-k-mooney, the cache isn't being refreshed | 18:27 |
| sean-k-mooney | dansmith: i also just figured out how to turn on the periodic task and ya didnt help. im going to see if i can force update the cache next but not sure how | 18:27 |
| dansmith | sean-k-mooney: periodic tasks are not the solution to this for sure :) | 18:28 |
| dansmith | really, we shouldn't need attach in the mix here | 18:28 |
| *** todevil22 has joined #openstack-nova | 18:28 | |
| *** xset8 has joined #openstack-nova | 18:28 | |
| todevil22 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 18:28 |
| *** todevil22 has quit IRC | 18:28 | |
| xset8 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 18:28 |
| *** xset8 has quit IRC | 18:28 | |
| stephenfin | and it's not that my physical_network/tunneled attributes aren't being set: there are entire VIFs missing, as sean-k-mooney notes | 18:28 |
| dansmith | fwiw, I'm talking about the migrate test, which is more important than the rebuild one, IMHO | 18:28 |
| *** mriedem_away is now known as mriedem | 18:28 | |
| *** vladikr has quit IRC | 18:29 | |
| dansmith | why are we mocking out the host_passes of the filter? | 18:29 |
| stephenfin | Yup, that's what I've been focusing on | 18:29 |
| stephenfin | We're not mocking it per se, we're "watching"? | 18:29 |
| dansmith | oh just so we can spy on the behavior or something? | 18:29 |
| stephenfin | yeah, spying | 18:29 |
| dansmith | functional tests really shouldn't do that, IMHO | 18:29 |
| stephenfin | They shouldn't, but it's already done there and the easiest way to test the thing | 18:30 |
| dansmith | also note that none of the test_servers functionals need to mock out the libvirt migrate_disk_and_power_off internal | 18:30 |
| stephenfin | None of them are using fake libvirt | 18:30 |
| mriedem | probably using fake virt drivers that already stub out that method to be a noop | 18:31 |
| dansmith | okay, fair, do we have to use fake libvirt for this to test all the scheduler and manager stuff? | 18:31 |
| *** shaohe_feng has quit IRC | 18:31 | |
| stephenfin | fwict, this is the second time anyone's attempted live migration functional tests with the libvirt functional driver, the first being mdbooth earlier this week | 18:31 |
| dansmith | stephenfin: this is cold migration | 18:31 |
| stephenfin | sorry, cold migration | 18:31 |
| stephenfin | (which is what mdbooth did too) | 18:32 |
| dansmith | okay, well, I'm missing what the attach and info_cache stale-ness has to do with this resize test | 18:32 |
| *** shaohe_feng has joined #openstack-nova | 18:32 | |
| stephenfin | dansmith: I need the information in my RequestSpec, which is what I'm doing here https://review.openstack.org/#/c/585339/5/nova/conductor/tasks/migrate.py@224 | 18:34 |
| stephenfin | However, in the functional test, when I get there instance.info_cache is stale | 18:34 |
| dansmith | stephenfin: right, I know you need it, but is your problem that it's stale, even without an attach? | 18:34 |
| dansmith | stephenfin: and your IRL test, have you tried migration or just rebuild? | 18:35 |
| stephenfin | Yeah, correct | 18:35 |
| dansmith | because the random fishing of data from info_cache is exactly how I expected this to fail | 18:35 |
| dansmith | so I'm just wondering if it's really working IRL | 18:36 |
| stephenfin | and just rebuild, yeah, so it's possible something is off, aye | 18:36 |
| dansmith | so this test passes all the way to the spy verification where we check .physnets, right? | 18:37 |
| stephenfin | yup | 18:37 |
| dansmith | stephenfin: are you sure the info was there during the initial boot? | 18:40 |
| *** mgoddard has quit IRC | 18:40 | |
| dansmith | you're checking that it wasn't for the second schedule, but.. since you can't validate based on where it landed, do you know it was present when you went to place it initially? | 18:40 |
| dansmith | actually | 18:41 |
| dansmith | er, yeah, your spy is just there for the reschedule so you don't have the data I think | 18:41 |
| *** shaohe_feng has quit IRC | 18:41 | |
| stephenfin | Yeah, I limited its scope there since it was already tested in other tests | 18:42 |
| stephenfin | But yeah, I still need to get home, eat, pack and sleep. There's no more I can do on this | 18:42 |
| dansmith | so, I moved the boot into the spy mock, and left it checking the first (which would be the boot), and it still fails | 18:43 |
| dansmith | er, on something else, hang on | 18:43 |
| dansmith | okay, nm, so the boot has it right | 18:43 |
| stephenfin | Unless something drastic changes tomorrow, this is either (a) punt, (b) apply for a feature freeze exception, or (c) merge without functional tests. If (c), someone needs to test cold migrate this IRL on a two-node deployment | 18:45 |
| dansmith | I'm -2 on (c) | 18:45 |
| *** dtruong_ has joined #openstack-nova | 18:45 | |
| stephenfin | I'll let mriedem, melwitt et all debate that, but I do really need to go. Sorry :( | 18:45 |
| dansmith | I put some debugs in the neutronapi code and they're not getting called | 18:45 |
| *** shaohe_feng has joined #openstack-nova | 18:46 | |
| mriedem | (d) mriedem spends the rest of the day figuring it out and fixes it | 18:47 |
| mriedem | i just go back online like 5 minutes ago so i'm getting caught up, but maybe i can sort something out here this afternoon | 18:47 |
| mriedem | *got | 18:47 |
| dansmith | mriedem: sean-k-mooney: I put a raise Exception() here and nothing changes: https://review.openstack.org/#/c/585339/5/nova/network/neutronv2/api.py@2657 | 18:47 |
| mriedem | dansmith: that's b/c we're not using that code with the NeutronFixture... | 18:48 |
| dansmith | oh? | 18:48 |
| mriedem | the neutron fixture stubs out nova/network/neutronv2/api | 18:48 |
| mriedem | well, | 18:48 |
| mriedem | at least the python-neutronclient in there, looking | 18:48 |
| dansmith | the fixture doesn't do any of this meta stuff, which would explain why it's empty if what you say is right | 18:48 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1111 | 18:49 |
| dansmith | well, that I can see | 18:49 |
| sean-k-mooney | dansmith: ill put a breakpoint there to confirm | 18:49 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1267 | 18:49 |
| *** dtruong has quit IRC | 18:49 | |
| mriedem | should still have something in the instance.info_cache from that, | 18:50 |
| mriedem | otherwise our versioned notification samples wouldn't have address info in them (which they do | 18:50 |
| mriedem | the neutron fixture is using stubbed networks and ports and such though | 18:50 |
| dansmith | mriedem: I think there's something in there, it's just not augmented with the extra stuff from the link I pasted above | 18:50 |
| dansmith | and that's why they think it's stale | 18:50 |
| sean-k-mooney | mriedem: we have something in the info cache. its just the vaule form when the instace was booted. not the updated vaules form after the attach | 18:51 |
| mriedem | stephen added a NUMAAffinityNeutronFixture or whatever that had fake networks with those values | 18:51 |
| mriedem | oh i didn't know you were doing attach stuff in these tests... | 18:51 |
| dansmith | not in fixtures that I see | 18:51 |
| mriedem | why are we trying to test attach in this basic test? | 18:51 |
| dansmith | mriedem: that's what I said, | 18:51 |
| dansmith | mriedem: but we're talking about the migration test below the rebuilds | 18:51 |
| mriedem | heh, let's get the dumb simple flows working first | 18:51 |
| dansmith | right | 18:51 |
| dansmith | but.. scroll down :) | 18:51 |
| mriedem | before we try to land on the moon | 18:51 |
| sean-k-mooney | the attahced interface is connected to a network which is mapped to a different numa node then the first network | 18:51 |
| *** shaohe_feng has quit IRC | 18:52 | |
| sean-k-mooney | the instance has 1 numa node requested so its invalid and should fail | 18:52 |
| *** shaohe_feng has joined #openstack-nova | 18:52 | |
| dansmith | mriedem: so, that fixture he added has neutron responses with those values, | 18:53 |
| *** rcernin has quit IRC | 18:53 | |
| dansmith | but something has to copy them into the info cache's network_model, which is the neutronv2/api code, unless that's implemented somewhere else for this test | 18:53 |
| dansmith | ah, I might know | 18:55 |
| openstackgerrit | Merged openstack/nova master: Add nova-manage placement sync_aggregates https://review.openstack.org/575912 | 18:56 |
| dansmith | hmm, | 18:58 |
| dansmith | well the neutron fixture has a canned nw_info structure | 18:58 |
| dansmith | which doesn't have the physnet stuff in it | 18:58 |
| *** chyka_ has joined #openstack-nova | 18:59 | |
| mriedem | but that's only used for add_fixed_ip_to_instance and remove | 18:59 |
| dansmith | and it mocks out networkinfo.hydrate (!) to return that | 18:59 |
| mriedem | which isn't the same as attach/detach | 18:59 |
| dansmith | mriedem: there's no attach/detach in this test | 18:59 |
| mriedem | still, we don't call add_fixed_ip_to_instance at all so that canned one shouldn't matter | 19:00 |
| dansmith | it mocks out hydrate in that fixture | 19:00 |
| mriedem | where? | 19:00 |
| dansmith | oh sorry | 19:01 |
| dansmith | I was reading it wrong, it mocks the thing you said and calls hydrate from the lambda | 19:01 |
| dansmith | sorry | 19:01 |
| *** shaohe_feng has quit IRC | 19:02 | |
| *** chyka has quit IRC | 19:02 | |
| *** shaohe_feng has joined #openstack-nova | 19:02 | |
| *** dklyle has quit IRC | 19:03 | |
| dansmith | well, in that case, like I said, I'm not sure how we'll ever get those new things into the network model if we're not running the neutronv2/api code | 19:03 |
| mriedem | i think we are but with the stubbed list_ports, list_networks, show_network stuff | 19:06 |
| sean-k-mooney | dansmith: this is whats in instance.info_cache.network_info if it helps http://paste.openstack.org/show/726641/ | 19:07 |
| *** blkart has quit IRC | 19:07 | |
| *** blkart has joined #openstack-nova | 19:07 | |
| mriedem | so that does have the physical_network and tunneled network meta | 19:08 |
| mriedem | melwitt: https://review.openstack.org/#/c/517921/ and below need a final +@ | 19:08 |
| mriedem | +2 | 19:08 |
| dansmith | mriedem: we're not running the _nw_info_build_network code | 19:08 |
| *** alexpilotti has joined #openstack-nova | 19:08 | |
| melwitt | mriedem: thanks, will look | 19:09 |
| mriedem | dansmith: hmm | 19:09 |
| mriedem | i'm not sure why we wouldn't, i don't see anything stubbing that out | 19:09 |
| dansmith | mriedem: that was my point above | 19:09 |
| dansmith | and you shat upon it | 19:09 |
| mriedem | oh wait, | 19:09 |
| mriedem | we do have other things that stub some shit out in the nw api | 19:09 |
| mriedem | and i bet that is getting stubbed in the parent test base class | 19:09 |
| *** rcernin has joined #openstack-nova | 19:10 | |
| * dansmith throws his hands up | 19:10 | |
| mriedem | in the air like you just don't care!? | 19:10 |
| dansmith | like jan brady when marcia suggests the same thing she just did and now everyone thinks it's cool | 19:10 |
| mriedem | ServersTestBase | 19:11 |
| mriedem | fake_network.set_stub_network_methods(self) | 19:12 |
| mriedem | thar she blar | 19:12 |
| *** shaohe_feng has quit IRC | 19:12 | |
| mriedem | so if stephenfin's test calls unset_stub_network_methods we should hit the cache rebuilder | 19:13 |
| *** shaohe_feng has joined #openstack-nova | 19:13 | |
| mriedem | i'm not sure why someone didn't figure this all out hours ago :P | 19:14 |
| sean-k-mooney | so _nw_info_build_network is being called when weer are booting | 19:14 |
| mriedem | sean-k-mooney: yes, at the end of allocate_for_instance, | 19:14 |
| mriedem | but we don't get that far b/c of set_stub_network_methods | 19:14 |
| sean-k-mooney | yes | 19:14 |
| sean-k-mooney | its not called in the rebuild | 19:14 |
| mriedem | it doesn't need to be, | 19:15 |
| mriedem | b/c after the server is created, the nw info cache is persisted in the db with the instance | 19:15 |
| mriedem | assuming we had something in the db, but we don't b/c of set_stub_network_methods | 19:15 |
| dansmith | yep, that fixes it, I'll push this up | 19:15 |
| mriedem | WOOT | 19:15 |
| sean-k-mooney | dansmith: awsome :) | 19:15 |
| *** rcernin has quit IRC | 19:16 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add additional functional tests for NUMA networks https://review.openstack.org/585385 | 19:16 |
| *** lbft14 has joined #openstack-nova | 19:19 | |
| lbft14 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 19:19 |
| *** lbft14 has quit IRC | 19:19 | |
| *** tidwellr has quit IRC | 19:19 | |
| *** avolkov has joined #openstack-nova | 19:21 | |
| *** alexpilotti has quit IRC | 19:22 | |
| *** shaohe_feng has quit IRC | 19:22 | |
| *** tidwellr has joined #openstack-nova | 19:22 | |
| dansmith | melwitt: mriedem: I'm assuming no cells meeting with the crunch and all | 19:23 |
| melwitt | +1 | 19:23 |
| mriedem | agree | 19:23 |
| *** shaohe_feng has joined #openstack-nova | 19:24 | |
| *** eharney has quit IRC | 19:26 | |
| mriedem | oh sweet irony as soon as we approve artom's test_tagged_attachment debug patch, it fails on that test | 19:31 |
| mriedem | http://logs.openstack.org/32/584032/5/check/nova-next/caee4e1/logs/testr_results.html.gz | 19:31 |
| *** shaohe_feng has quit IRC | 19:33 | |
| *** flwang1 has quit IRC | 19:34 | |
| *** shaohe_feng has joined #openstack-nova | 19:35 | |
| *** efried_rollin is now known as efried | 19:38 | |
| mriedem | doesn't show any of artom's new debug messages for the instance or volume | 19:39 |
| *** alexpilotti has joined #openstack-nova | 19:39 | |
| sean-k-mooney | ok my server says i loged into it 12 hour and 21 minutes ago. my brain is fried so im going to call it a day. i have the functional test for dansmith updated version running local. if test_rebuild_server_network_changes still fails perhaps we should remove it given cold migrate and test_rebuild_server_no_network_changes pass | 19:41 |
| dansmith | yeah the rebuild tests don't work, | 19:42 |
| mriedem | dansmith: what do you want me to do re ^? otherwise i'm just watching zuul and need to book a flight to china. do we have more tests that need to be written and/or cleaned up in the patch? | 19:42 |
| *** alexchadin has joined #openstack-nova | 19:42 | |
| *** sujeet28 has joined #openstack-nova | 19:43 | |
| *** pendo32411 has joined #openstack-nova | 19:43 | |
| sujeet28 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 19:43 |
| *** sujeet28 has quit IRC | 19:43 | |
| pendo32411 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 19:43 |
| *** pendo32411 has quit IRC | 19:43 | |
| dansmith | I think we need the negative test | 19:43 |
| *** shaohe_feng has quit IRC | 19:43 | |
| mriedem | i'm not sure i know how to do that | 19:43 |
| mriedem | that's where the nodes on the host are all claimed? | 19:43 |
| *** alexpilotti has quit IRC | 19:43 | |
| dansmith | no, there's an easier way | 19:44 |
| dansmith | jan will take a crack at it while marcia brushes her hair | 19:44 |
| mriedem | alright, wfm | 19:44 |
| mriedem | works. for. marcia. | 19:44 |
| mriedem | oh btw i'm in full summer feather hair mode atm | 19:44 |
| *** shaohe_feng has joined #openstack-nova | 19:45 | |
| mriedem | but it will be shorn before denver | 19:45 |
| *** alexchadin has quit IRC | 19:47 | |
| *** tidwellr has quit IRC | 19:48 | |
| * dansmith scowls | 19:48 | |
| sean-k-mooney | so ya that just finished running all the nova fuctional tests. nova.tests.functional.libvirt.test_numa_servers.NUMAServersWithNetworksTest.test_rebuild_server_network_changes is the only one that failed in dans version so its just the attch suff thats failing. | 19:49 |
| *** mgoddard has joined #openstack-nova | 19:49 | |
| *** tidwellr has joined #openstack-nova | 19:50 | |
| *** medberry has joined #openstack-nova | 19:50 | |
| *** medberry has quit IRC | 19:50 | |
| *** medberry has joined #openstack-nova | 19:50 | |
| *** sean-k-mooney has quit IRC | 19:51 | |
| *** felipemonteiro_ has joined #openstack-nova | 19:52 | |
| *** shaohe_feng has quit IRC | 19:53 | |
| *** slaweq has quit IRC | 19:55 | |
| *** shaohe_feng has joined #openstack-nova | 19:55 | |
| *** felipemonteiro has quit IRC | 19:56 | |
| *** slaweq has joined #openstack-nova | 20:00 | |
| *** alexpilotti has joined #openstack-nova | 20:01 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add additional functional tests for NUMA networks https://review.openstack.org/585385 | 20:03 |
| *** mgoddard has quit IRC | 20:03 | |
| *** shaohe_feng has quit IRC | 20:03 | |
| *** alexpilotti has quit IRC | 20:04 | |
| *** alexpilotti has joined #openstack-nova | 20:04 | |
| *** shaohe_feng has joined #openstack-nova | 20:07 | |
| *** jchhatbar has quit IRC | 20:11 | |
| *** shaohe_feng has quit IRC | 20:14 | |
| *** shaohe_feng has joined #openstack-nova | 20:14 | |
| artom | mriedem, wait, it failed and logged nothing at all o_O | 20:16 |
| *** Shilpa has quit IRC | 20:17 | |
| *** alexchadin has joined #openstack-nova | 20:17 | |
| *** Shilpa has joined #openstack-nova | 20:17 | |
| *** alexchadin has quit IRC | 20:17 | |
| dansmith | mriedem: so you'll convert your +1 to +2 on the functional move patch? | 20:19 |
| efried | Does he have to deny you three times, or something? | 20:21 |
| *** jamesde__ has joined #openstack-nova | 20:22 | |
| efried | not that kind of conversion, maybe. | 20:22 |
| *** jamesden_ has quit IRC | 20:22 | |
| *** shaohe_feng has quit IRC | 20:24 | |
| *** shaohe_feng has joined #openstack-nova | 20:25 | |
| *** edmondsw has quit IRC | 20:28 | |
| *** edmondsw has joined #openstack-nova | 20:28 | |
| *** edmondsw has quit IRC | 20:32 | |
| *** shaohe_feng has quit IRC | 20:34 | |
| *** medberry has quit IRC | 20:34 | |
| *** shaohe_feng has joined #openstack-nova | 20:35 | |
| *** wolverineav has quit IRC | 20:38 | |
| *** thejoecarroll29 has joined #openstack-nova | 20:43 | |
| thejoecarroll29 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 20:43 |
| *** thejoecarroll29 has quit IRC | 20:43 | |
| *** shaohe_feng has quit IRC | 20:44 | |
| *** shaohe_feng has joined #openstack-nova | 20:46 | |
| *** Pyrrhic4 has joined #openstack-nova | 20:49 | |
| Pyrrhic4 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 20:49 |
| *** Pyrrhic4 has quit IRC | 20:49 | |
| *** gongysh has joined #openstack-nova | 20:50 | |
| *** wwriverr_ has quit IRC | 20:51 | |
| *** mgoddard has joined #openstack-nova | 20:54 | |
| *** shaohe_feng has quit IRC | 20:55 | |
| *** hamzy has quit IRC | 20:55 | |
| *** medberry has joined #openstack-nova | 20:56 | |
| *** shaohe_feng has joined #openstack-nova | 20:58 | |
| *** flwang1 has joined #openstack-nova | 20:58 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add support for multiple fixed-ips in metadata https://review.openstack.org/580742 | 20:58 |
| *** jamesde__ has quit IRC | 20:59 | |
| mriedem | dansmith: yeah | 21:00 |
| mriedem | artom: right | 21:00 |
| *** jamesden_ has joined #openstack-nova | 21:01 | |
| melwitt | does anyone know anything about metadata API versions and what's valid? for the addition of 'ip_addresses' to network_data.json, it means we have a second version update this cycle and we apparently already used a date in the future 2018-08-27 https://review.openstack.org/#/c/580742/2/nova/api/metadata/base.py@77 | 21:02 |
| *** owalsh_ has joined #openstack-nova | 21:02 | |
| mriedem | apparently we already did that once with NEWTON_TWO even though NEWTON_ONE was using the wrong date | 21:03 |
| *** mgoddard has quit IRC | 21:03 | |
| melwitt | what's proposed is 2018-08-27-2 which is a format we haven't done before | 21:03 |
| mriedem | # NOTE(mikal): think of these strings as version numbers. They traditionally | 21:03 |
| mriedem | # correlate with OpenStack release dates, with all the changes for a given | 21:03 |
| mriedem | # release bundled into a single version. Note that versions in the future are | 21:03 |
| mriedem | # hidden from the listing, but can still be requested explicitly, which is | 21:03 |
| mriedem | # required for testing purposes. We know this isn't great, but its inherited | 21:03 |
| mriedem | # from EC2, which this needs to be compatible with. | 21:03 |
| mriedem | i would -1 on the fomrat | 21:04 |
| mriedem | *format | 21:04 |
| mriedem | based on "They traditionally | 21:04 |
| mriedem | # correlate with OpenStack release dates, with all the changes for a given | 21:04 |
| mriedem | # release bundled into a single version." we could lump the changes into the existing ROCKY version | 21:04 |
| mriedem | which isn't CI/CD friendly, so if we cared, i'd just make the ROCKY_TWO a day later than ROCKY_ONE | 21:04 |
| mriedem | i'm a big meh on either approach | 21:04 |
| *** gongysh has quit IRC | 21:04 | |
| *** openstackgerrit has quit IRC | 21:04 | |
| *** mrjk has quit IRC | 21:05 | |
| melwitt | okay, I was wondering about that. else we could use 2018-08-30 the actual rocky release date? I haven't been able to find examples of consumers using version strings to request versions | 21:05 |
| *** shaohe_feng has quit IRC | 21:05 | |
| *** owalsh has quit IRC | 21:05 | |
| mriedem | it says versions in the future are hidden from the listing, | 21:05 |
| mriedem | so if that's true, rocky doesn't even show up today, | 21:05 |
| mriedem | but would need to confirm | 21:05 |
| melwitt | and it looks like this new version won't break anyone because it adds a field, doesn't change any fields. so cloud-init defaulting to latest (I think it does, based on the code) will still work with the new version with 'ip_addresses' in it | 21:06 |
| melwitt | ohh, I see | 21:06 |
| *** shaohe_feng has joined #openstack-nova | 21:06 | |
| mriedem | i have a hell of a time ever knowing where the route code in this thing works | 21:06 |
| melwitt | so rolling together should work on that basis. I didn't understand what "hidden" meant until you said that | 21:06 |
| *** mrjk has joined #openstack-nova | 21:06 | |
| mriedem | well, i'd want to know where that hiding happens | 21:07 |
| mriedem | i don't have a devstack handy to test this | 21:07 |
| dansmith | right, should be rocky release date, and we shouldn't have multiple versions for rocky | 21:07 |
| dansmith | I think that the date-based one is hidden, | 21:07 |
| dansmith | but current takes you to it, | 21:07 |
| mriedem | https://review.openstack.org/#/c/580742/2/nova/api/metadata/base.py@597 | 21:07 |
| *** wolverineav has joined #openstack-nova | 21:07 | |
| dansmith | and the idea is that until the release happens, it's not really codified as the date-based version, | 21:07 |
| dansmith | so we can add stuff to it | 21:07 |
| mriedem | yup, | 21:07 |
| *** lutoma18 has joined #openstack-nova | 21:07 | |
| lutoma18 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 21:07 |
| lutoma18 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 21:07 |
| mriedem | found that code | 21:07 |
| *** lutoma18 has quit IRC | 21:07 | |
| *** Bonn33322 has joined #openstack-nova | 21:08 | |
| Bonn33322 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 21:08 |
| Bonn33322 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 21:08 |
| *** Bonn33322 has quit IRC | 21:08 | |
| melwitt | a-ha, cool. thanks for all that info | 21:10 |
| *** awaugama has quit IRC | 21:10 | |
| melwitt | fyi mgagne ^ (backscroll for more context on the latest review comment) | 21:12 |
| mgagne | melwitt: so no new metadata api version and call it a day? | 21:13 |
| melwitt | mgagne: yeah, the code mriedem highlighted on the review will hide version dates that are in the future, so that they stay 'unreleased' until the release date. so you can roll your changes into the existing ROCKY version | 21:14 |
| mgagne | +1 | 21:14 |
| *** shaohe_feng has quit IRC | 21:15 | |
| *** openstackgerrit has joined #openstack-nova | 21:16 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add support for multiple fixed-ips in metadata https://review.openstack.org/580742 | 21:16 |
| artom | mriedem, yeah, am looking into it | 21:16 |
| artom | Really weird | 21:16 |
| *** shaohe_feng has joined #openstack-nova | 21:18 | |
| mriedem | dansmith: so does that mean we're good with the move patch for my +2 since we have the functional WIP patch for the move ops? | 21:18 |
| artom | mriedem, no chance we can merge and later revert really excessive logging? | 21:18 |
| mriedem | like, are you ok approving the stack and cleaning up the functional patch test later or? | 21:18 |
| artom | Back in a bit, picking up daughter from daycare | 21:18 |
| mriedem | i also have to do ^ | 21:18 |
| *** mriedem is now known as mriedem_afk | 21:18 | |
| dansmith | mriedem_afk: oh I should have removed the WIP on that as I think it's okay | 21:19 |
| dansmith | mriedem_afk: but yeah, I think we need to merge that stack if you're good with it | 21:19 |
| dansmith | that's what I meant when I asked about your +2 | 21:19 |
| *** tidwellr has quit IRC | 21:21 | |
| mriedem_afk | want me to +W the bottom change too? | 21:21 |
| mriedem_afk | did it anyway | 21:22 |
| mriedem_afk | gotta run | 21:22 |
| *** shaohe_feng has quit IRC | 21:25 | |
| *** shaohe_feng has joined #openstack-nova | 21:26 | |
| *** itlinux has quit IRC | 21:31 | |
| *** brault has quit IRC | 21:32 | |
| *** medberry has quit IRC | 21:33 | |
| *** shaohe_feng has quit IRC | 21:36 | |
| *** itlinux has joined #openstack-nova | 21:36 | |
| *** shaohe_feng has joined #openstack-nova | 21:36 | |
| *** dklyle has joined #openstack-nova | 21:38 | |
| *** edmondsw has joined #openstack-nova | 21:40 | |
| *** edmondsw has quit IRC | 21:45 | |
| *** shaohe_feng has quit IRC | 21:46 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add additional functional tests for NUMA networks https://review.openstack.org/585385 | 21:47 |
| *** felipemonteiro_ has quit IRC | 21:48 | |
| *** Guest27255 has quit IRC | 21:50 | |
| *** shaohe_feng has joined #openstack-nova | 21:51 | |
| *** takashin has joined #openstack-nova | 21:52 | |
| *** Guest53662 has joined #openstack-nova | 21:52 | |
| Guest53662 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 21:52 |
| Guest53662 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 21:52 |
| *** Guest53662 has quit IRC | 21:52 | |
| *** Contessa19 has joined #openstack-nova | 21:52 | |
| Contessa19 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 21:52 |
| Contessa19 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 21:52 |
| *** Contessa19 has quit IRC | 21:52 | |
| *** shaohe_feng has quit IRC | 21:56 | |
| *** shaohe_feng has joined #openstack-nova | 21:59 | |
| *** wolverineav has quit IRC | 22:03 | |
| *** EvilRoey18 has joined #openstack-nova | 22:03 | |
| EvilRoey18 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 22:03 |
| EvilRoey18 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 22:03 |
| *** EvilRoey18 has quit IRC | 22:03 | |
| *** shaohe_feng has quit IRC | 22:06 | |
| *** mchlumsky has quit IRC | 22:07 | |
| *** shaohe_feng has joined #openstack-nova | 22:08 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add support for multiple fixed-ips in metadata https://review.openstack.org/580742 | 22:12 |
| mgagne | mriedem_afk: sorry, I was a bit too hasty in updating the change. Let me know about the expected services field behavior. I will update accordingly. | 22:13 |
| *** mlavalle has quit IRC | 22:14 | |
| *** cdent has quit IRC | 22:15 | |
| *** shaohe_feng has quit IRC | 22:17 | |
| *** shaohe_feng has joined #openstack-nova | 22:17 | |
| melwitt | mgagne: well, tbh, I'm not sure what it should be, just pointing out that my prior understanding of the change was that it just adds the ip_addresses field and nothing else changes | 22:18 |
| melwitt | it might be fine to include more services in 'services' too. I'll add a comment and ask mriedem_afk and dansmith about it tomorrow to see what they think | 22:19 |
| *** antosh has quit IRC | 22:22 | |
| *** jiteka has quit IRC | 22:22 | |
| *** eandersson has quit IRC | 22:22 | |
| *** jiteka has joined #openstack-nova | 22:23 | |
| *** ynyounuo8 has joined #openstack-nova | 22:23 | |
| *** bleepy2 has joined #openstack-nova | 22:23 | |
| *** ynyounuo8 has quit IRC | 22:23 | |
| bleepy2 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 22:23 |
| *** bleepy2 has quit IRC | 22:23 | |
| *** eandersson has joined #openstack-nova | 22:24 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153 | 22:25 |
| *** itlinux has quit IRC | 22:25 | |
| *** shaohe_feng has quit IRC | 22:27 | |
| *** shaohe_feng has joined #openstack-nova | 22:27 | |
| *** Jan\24 has joined #openstack-nova | 22:28 | |
| Jan\24 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 22:28 |
| *** Jan\24 has quit IRC | 22:28 | |
| *** mtreinish has quit IRC | 22:33 | |
| *** mtreinish has joined #openstack-nova | 22:36 | |
| *** shaohe_feng has quit IRC | 22:37 | |
| *** shaohe_feng has joined #openstack-nova | 22:38 | |
| *** avolkov has quit IRC | 22:39 | |
| *** antosh has joined #openstack-nova | 22:42 | |
| *** shaohe_feng has quit IRC | 22:47 | |
| *** shaohe_feng has joined #openstack-nova | 22:48 | |
| *** antosh has quit IRC | 22:52 | |
| *** antosh has joined #openstack-nova | 22:52 | |
| *** Corvus`26 has joined #openstack-nova | 22:53 | |
| Corvus`26 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 22:53 |
| *** Corvus`26 has quit IRC | 22:53 | |
| *** Freejack4 has joined #openstack-nova | 22:57 | |
| Freejack4 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 22:57 |
| Freejack4 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 22:57 |
| *** Freejack4 has quit IRC | 22:57 | |
| *** shaohe_feng has quit IRC | 22:58 | |
| *** chyka_ has quit IRC | 23:00 | |
| *** shaohe_feng has joined #openstack-nova | 23:00 | |
| *** mschuppert has quit IRC | 23:03 | |
| *** namnh has joined #openstack-nova | 23:03 | |
| *** vladikr has joined #openstack-nova | 23:05 | |
| *** shaohe_feng has quit IRC | 23:08 | |
| *** wolverineav has joined #openstack-nova | 23:10 | |
| *** shaohe_feng has joined #openstack-nova | 23:10 | |
| *** medberry has joined #openstack-nova | 23:12 | |
| mgagne | melwitt: thanks for the review, much appreciated. sorry if I didn't make the full extend of the change clear in the initial spec :-/ | 23:13 |
| *** aphex`5 has joined #openstack-nova | 23:13 | |
| aphex`5 | Hey, I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ | 23:13 |
| aphex`5 | or maybe this blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ | 23:13 |
| aphex`5 | Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate | 23:13 |
| *** aphex`5 has quit IRC | 23:13 | |
| *** wolverineav has quit IRC | 23:14 | |
| melwitt | mgagne: that's okay, I'm guessing it's obvious to those more familiar than I. thanks for the prompt replies | 23:16 |
| mgagne | I shouldn't assume people are familiar with that part ;) | 23:16 |
| melwitt | I learned new things, that's a plus :) | 23:18 |
| *** shaohe_feng has quit IRC | 23:18 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 23:18 |
| openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 23:18 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598 | 23:18 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 23:18 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 23:18 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 23:19 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | 23:19 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 23:19 |
| *** medberry has quit IRC | 23:20 | |
| *** shaohe_feng has joined #openstack-nova | 23:20 | |
| *** namnh has quit IRC | 23:22 | |
| *** namnh has joined #openstack-nova | 23:23 | |
| *** namnh has quit IRC | 23:25 | |
| *** namnh has joined #openstack-nova | 23:25 | |
| *** r-daneel has quit IRC | 23:28 | |
| *** shaohe_feng has quit IRC | 23:28 | |
| *** edmondsw has joined #openstack-nova | 23:29 | |
| *** medberry has joined #openstack-nova | 23:29 | |
| *** namnh has quit IRC | 23:29 | |
| *** medberry has quit IRC | 23:29 | |
| *** medberry has joined #openstack-nova | 23:29 | |
| *** namnh has joined #openstack-nova | 23:30 | |
| *** shaohe_feng has joined #openstack-nova | 23:30 | |
| *** edmondsw has quit IRC | 23:33 | |
| *** namnh has quit IRC | 23:34 | |
| *** shaohe_feng has quit IRC | 23:39 | |
| *** shaohe_feng has joined #openstack-nova | 23:40 | |
| *** itlinux has joined #openstack-nova | 23:44 | |
| *** jangutter has quit IRC | 23:48 | |
| *** shaohe_feng has quit IRC | 23:49 | |
| *** shaohe_feng has joined #openstack-nova | 23:49 | |
| *** antosh has quit IRC | 23:50 | |
| *** shaohe_feng has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!