| *** moshele has joined #openstack-nova | 00:05 | |
| *** namnh has joined #openstack-nova | 00:06 | |
| *** gjayavelu has joined #openstack-nova | 00:07 | |
| *** hoonetorg has joined #openstack-nova | 00:09 | |
| *** hoonetorg has quit IRC | 00:14 | |
| *** moshele has quit IRC | 00:15 | |
| *** kaisers has quit IRC | 00:20 | |
| *** gyee has quit IRC | 00:21 | |
| *** sdeath has quit IRC | 00:22 | |
| *** esberglu has quit IRC | 00:27 | |
| *** hshiina|afk is now known as hshiina | 00:31 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:34 | |
| openstackgerrit | Merged openstack/nova master: Remove mox in unit/api/openstack/compute/test_hosts.py https://review.openstack.org/559266 | 00:35 |
|---|---|---|
| *** kaisers has joined #openstack-nova | 00:42 | |
| *** Dinesh_Bhor has quit IRC | 00:58 | |
| *** hiro-kobayashi has joined #openstack-nova | 01:09 | |
| *** hemna_ has quit IRC | 01:15 | |
| *** slaweq has joined #openstack-nova | 01:17 | |
| *** yamahata has quit IRC | 01:18 | |
| *** gjayavelu has quit IRC | 01:21 | |
| *** slaweq has quit IRC | 01:21 | |
| *** moshele has joined #openstack-nova | 01:25 | |
| *** salv-orl_ has joined #openstack-nova | 01:26 | |
| *** hongbin_ has joined #openstack-nova | 01:26 | |
| *** salv-orlando has quit IRC | 01:29 | |
| *** takashin has joined #openstack-nova | 01:30 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Address nits in Iac23a574a05e62a99aab20ffce4265f4fb5a44d9 https://review.openstack.org/563802 | 01:40 |
| *** moshele has quit IRC | 01:49 | |
| *** felipemonteiro__ has joined #openstack-nova | 01:51 | |
| *** fragatina has quit IRC | 01:54 | |
| *** fragatina has joined #openstack-nova | 01:56 | |
| *** yamahata has joined #openstack-nova | 01:58 | |
| *** zhaochao has joined #openstack-nova | 01:59 | |
| *** fragatina has quit IRC | 02:01 | |
| *** vladikr has quit IRC | 02:03 | |
| *** gongysh has joined #openstack-nova | 02:03 | |
| *** vladikr has joined #openstack-nova | 02:03 | |
| openstackgerrit | Leopard Ma proposed openstack/nova master: fix paused instance not support shelve https://review.openstack.org/541660 | 02:05 |
| *** Dinesh_Bhor has joined #openstack-nova | 02:06 | |
| *** Tom-Tom has joined #openstack-nova | 02:07 | |
| *** janki has joined #openstack-nova | 02:09 | |
| *** janki has quit IRC | 02:10 | |
| *** tinwood has quit IRC | 02:10 | |
| *** janki has joined #openstack-nova | 02:11 | |
| *** tinwood has joined #openstack-nova | 02:11 | |
| *** janki has quit IRC | 02:11 | |
| *** janki has joined #openstack-nova | 02:12 | |
| *** janki has quit IRC | 02:13 | |
| *** janki has joined #openstack-nova | 02:14 | |
| *** janki has quit IRC | 02:14 | |
| *** janki has joined #openstack-nova | 02:15 | |
| *** janki has quit IRC | 02:16 | |
| *** janki has joined #openstack-nova | 02:17 | |
| openstackgerrit | Merged openstack/nova master: Use an independent transaction for _trait_sync https://review.openstack.org/558068 | 02:17 |
| *** janki has quit IRC | 02:17 | |
| *** janki has joined #openstack-nova | 02:18 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 02:20 |
| *** jchhatbar has joined #openstack-nova | 02:21 | |
| *** Tom-Tom has quit IRC | 02:21 | |
| *** Tom-Tom has joined #openstack-nova | 02:22 | |
| *** dougshelley66 has quit IRC | 02:22 | |
| *** janki has quit IRC | 02:23 | |
| *** Tom-Tom has quit IRC | 02:26 | |
| *** ssurana has joined #openstack-nova | 02:30 | |
| *** READ10 has quit IRC | 02:31 | |
| *** nicolasbock has quit IRC | 02:32 | |
| *** Tom-Tom has joined #openstack-nova | 02:38 | |
| *** jchhatbar has quit IRC | 02:38 | |
| *** jchhatbar has joined #openstack-nova | 02:40 | |
| *** jchhatbar has quit IRC | 02:40 | |
| *** felipemonteiro__ has quit IRC | 02:41 | |
| *** jchhatbar has joined #openstack-nova | 02:41 | |
| *** jchhatbar has quit IRC | 02:42 | |
| *** jchhatbar has joined #openstack-nova | 02:43 | |
| *** jchhatbar has quit IRC | 02:43 | |
| *** jchhatbar has joined #openstack-nova | 02:44 | |
| *** jchhatbar is now known as janki | 02:45 | |
| *** sdague has quit IRC | 02:49 | |
| *** Zames has joined #openstack-nova | 02:51 | |
| *** ssurana has quit IRC | 02:56 | |
| *** psachin has joined #openstack-nova | 03:03 | |
| *** Zames has quit IRC | 03:12 | |
| *** slaweq has joined #openstack-nova | 03:18 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: WIP https://review.openstack.org/564092 | 03:20 |
| *** slaweq has quit IRC | 03:22 | |
| *** namnh has quit IRC | 03:27 | |
| *** lpetrut has joined #openstack-nova | 03:39 | |
| *** vivsoni__ has joined #openstack-nova | 03:56 | |
| *** hiro-kobayashi has quit IRC | 03:59 | |
| *** vivsoni_ has quit IRC | 03:59 | |
| *** fragatina has joined #openstack-nova | 03:59 | |
| *** fragatin_ has joined #openstack-nova | 04:01 | |
| *** hongbin_ has quit IRC | 04:04 | |
| *** fragatina has quit IRC | 04:05 | |
| *** jchhatbar has joined #openstack-nova | 04:10 | |
| *** lpetrut has quit IRC | 04:12 | |
| *** fragatin_ has quit IRC | 04:13 | |
| *** janki has quit IRC | 04:13 | |
| *** fragatina has joined #openstack-nova | 04:13 | |
| *** lpetrut has joined #openstack-nova | 04:19 | |
| *** jchhatba_ has joined #openstack-nova | 04:19 | |
| *** jchhatbar has quit IRC | 04:21 | |
| *** takashin has quit IRC | 04:22 | |
| *** yamamoto has quit IRC | 04:29 | |
| *** links has joined #openstack-nova | 04:29 | |
| *** ociuhandu has joined #openstack-nova | 04:32 | |
| *** ociuhandu_ has quit IRC | 04:35 | |
| *** lpetrut has quit IRC | 04:39 | |
| *** wolverineav has quit IRC | 04:40 | |
| *** sridharg has joined #openstack-nova | 04:44 | |
| *** yamamoto has joined #openstack-nova | 04:50 | |
| *** wolverineav has joined #openstack-nova | 04:57 | |
| *** felipemonteiro__ has joined #openstack-nova | 04:57 | |
| *** chyka has joined #openstack-nova | 04:58 | |
| *** Dinesh_Bhor has quit IRC | 05:00 | |
| *** ratailor has joined #openstack-nova | 05:00 | |
| *** vladikr has quit IRC | 05:01 | |
| *** vladikr has joined #openstack-nova | 05:01 | |
| *** chyka has quit IRC | 05:02 | |
| *** edmondsw has joined #openstack-nova | 05:02 | |
| *** felipemonteiro__ has quit IRC | 05:04 | |
| *** moshele has joined #openstack-nova | 05:14 | |
| *** lpetrut has joined #openstack-nova | 05:15 | |
| *** tetsuro has quit IRC | 05:17 | |
| *** moshele has quit IRC | 05:19 | |
| *** abhishekk has joined #openstack-nova | 05:20 | |
| *** takashin has joined #openstack-nova | 05:23 | |
| *** lpetrut has quit IRC | 05:25 | |
| openstackgerrit | Arvind Nadendla proposed openstack/nova master: update scheduler to use image-traits https://review.openstack.org/560596 | 05:26 |
| openstackgerrit | Arvind Nadendla proposed openstack/nova master: update scheduler to use image-traits https://review.openstack.org/560596 | 05:32 |
| *** wolverineav has quit IRC | 05:34 | |
| *** edmondsw has quit IRC | 05:36 | |
| *** gjayavelu has joined #openstack-nova | 05:41 | |
| *** liuzz_ has quit IRC | 05:43 | |
| *** liuzz has joined #openstack-nova | 05:44 | |
| TheJulia | jaypipes: w/r/t https://review.openstack.org/#/c/563722/ is your feeling still the same given the discussion yesterday. Curious because it looks like the discussion was winding down around the same time. | 05:45 |
| *** itlinux has joined #openstack-nova | 05:47 | |
| *** itlinux has quit IRC | 05:53 | |
| *** itlinux has joined #openstack-nova | 05:55 | |
| *** liuzz_ has joined #openstack-nova | 05:56 | |
| *** armaan has joined #openstack-nova | 05:57 | |
| *** liuzz has quit IRC | 05:57 | |
| *** kholkina has joined #openstack-nova | 05:59 | |
| *** hiro-kobayashi has joined #openstack-nova | 06:02 | |
| *** kholkina has quit IRC | 06:03 | |
| *** itlinux has quit IRC | 06:06 | |
| *** moshele has joined #openstack-nova | 06:12 | |
| *** lajoskatona has joined #openstack-nova | 06:12 | |
| *** evin has joined #openstack-nova | 06:16 | |
| *** do3meli has joined #openstack-nova | 06:19 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:26 | |
| *** fragatina has quit IRC | 06:29 | |
| *** fragatina has joined #openstack-nova | 06:30 | |
| *** ssurana has joined #openstack-nova | 06:39 | |
| *** ssurana has quit IRC | 06:40 | |
| *** ssurana1 has joined #openstack-nova | 06:40 | |
| *** moshele has quit IRC | 06:40 | |
| *** moshele has joined #openstack-nova | 06:41 | |
| *** ccamacho has quit IRC | 06:42 | |
| *** ccamacho has joined #openstack-nova | 06:43 | |
| *** moshele has quit IRC | 06:44 | |
| *** alexchadin has joined #openstack-nova | 06:44 | |
| *** moshele has joined #openstack-nova | 06:45 | |
| *** lpetrut has joined #openstack-nova | 06:45 | |
| *** udesale has joined #openstack-nova | 06:51 | |
| *** ralonsoh has joined #openstack-nova | 06:52 | |
| *** slaweq has joined #openstack-nova | 06:54 | |
| *** tesseract has joined #openstack-nova | 07:01 | |
| *** kholkina has joined #openstack-nova | 07:01 | |
| *** pcaruana has joined #openstack-nova | 07:06 | |
| *** udesale has quit IRC | 07:09 | |
| *** lpetrut has quit IRC | 07:10 | |
| *** lpetrut has joined #openstack-nova | 07:10 | |
| *** lpetrut has quit IRC | 07:11 | |
| *** lpetrut has joined #openstack-nova | 07:12 | |
| *** sahid has joined #openstack-nova | 07:17 | |
| *** amoralej|off is now known as amoralej | 07:20 | |
| *** lpetrut has quit IRC | 07:20 | |
| *** lpetrut has joined #openstack-nova | 07:21 | |
| *** udesale has joined #openstack-nova | 07:26 | |
| *** tssurya has joined #openstack-nova | 07:26 | |
| openstackgerrit | Arvind Nadendla proposed openstack/nova master: update scheduler to use image-traits https://review.openstack.org/560596 | 07:31 |
| *** dpawlik has joined #openstack-nova | 07:33 | |
| *** udesale has quit IRC | 07:33 | |
| *** itlinux has joined #openstack-nova | 07:33 | |
| *** dpawlik has quit IRC | 07:34 | |
| *** dpawlik has joined #openstack-nova | 07:34 | |
| alex_xu | gmann: for https://review.openstack.org/#/c/563728/1, I did a test, if we don't provide boot index, the boot from volume will fail, that sounds like a bug for API | 07:34 |
| *** damien_r has joined #openstack-nova | 07:35 | |
| gmann | alex_xu: yea, i also tried to test this scenario in tempest test - https://review.openstack.org/#/c/563801/ | 07:36 |
| gmann | alex_xu: it pass in ocata in pike and fail in queens and mastyer | 07:36 |
| *** AlexeyAbashkin has joined #openstack-nova | 07:37 | |
| alex_xu | gmann: cool, sounds like we can revert that patch | 07:37 |
| *** szaher has quit IRC | 07:37 | |
| *** szaher has joined #openstack-nova | 07:38 | |
| gmann | alex_xu: yea that is one option but matt is trying to fix it without revert -https://review.openstack.org/#/c/563732/2 | 07:38 |
| Kevin_Zheng | ping gibi | 07:38 |
| gmann | alex_xu: so either is ok for me revert and revert in queens also or backport the fix till queens | 07:39 |
| gmann | alex_xu: not sure revert is possible for queens as it is bug since queens not just master | 07:39 |
| alex_xu | gmann: got it | 07:39 |
| *** jpena|off is now known as jpena | 07:42 | |
| *** tssurya has quit IRC | 07:44 | |
| *** ragiman has joined #openstack-nova | 07:44 | |
| *** itlinux has quit IRC | 07:44 | |
| openstackgerrit | Arvind Nadendla proposed openstack/nova master: update scheduler to use image-traits https://review.openstack.org/560596 | 07:44 |
| *** tetsuro has joined #openstack-nova | 07:45 | |
| *** gongysh has quit IRC | 07:51 | |
| gibi | Kevin_Zheng: pong | 07:52 |
| Kevin_Zheng | hi, I saw your message today | 07:52 |
| *** lajoskatona has quit IRC | 07:53 | |
| *** lajoskatona has joined #openstack-nova | 07:53 | |
| Kevin_Zheng | I'm willing to do it, I mean the traceback bp | 07:53 |
| Kevin_Zheng | while I'm thinking about it, I found that it might be hard to test | 07:54 |
| gibi | Kevin_Zheng: cool, thanks! Let me assigne the bp to you. | 07:54 |
| *** lajoskatona has left #openstack-nova | 07:54 | |
| Kevin_Zheng | you know, currently we compare samples with ture notify | 07:54 |
| Kevin_Zheng | but for traceback, if the code line changes | 07:54 |
| Kevin_Zheng | the traceback will also change | 07:55 |
| gibi | Kevin_Zheng: true, I think we have to accept that we will only test parts of the traceback field | 07:55 |
| Kevin_Zheng | I think that means changing the current test algorithm right? | 07:56 |
| *** alexchadin has quit IRC | 07:56 | |
| gibi | the current test framework allows overwriting what is in the sample for example in case of uuid we always overwrite what is in the samepl | 07:56 |
| gibi | sample | 07:57 |
| *** alexchadin has joined #openstack-nova | 07:57 | |
| gibi | so we just need to set the replacement for traceback to ANY | 07:57 |
| gibi | and then manually look into the traceback field in a single test and verify that some parts are present | 07:58 |
| gibi | this code https://github.com/openstack/nova/blob/8a6665bc58d53f6ba0346760ba86d97d3437bfc5/nova/tests/functional/notification_sample_tests/test_instance.py#L379 does a lot of replacements | 08:00 |
| kashyap | sean-k-mooney: Thanks for the review: https://review.openstack.org/#/c/563926/. Will address | 08:01 |
| kashyap | Good you didn't catch anything more :-) | 08:01 |
| gibi | Kevin_Zheng: and the test base class allows ANY as a replacement https://github.com/openstack/nova/blob/d4504302c99715508ed8b9822bf50ad485d34c96/nova/tests/functional/notification_sample_tests/notification_sample_base.py#L54 | 08:01 |
| gibi | Kevin_Zheng: and that will match with anything | 08:01 |
| gibi | Kevin_Zheng: https://github.com/openstack/nova/blob/d4504302c99715508ed8b9822bf50ad485d34c96/nova/tests/functional/notification_sample_tests/notification_sample_base.py#L128 | 08:02 |
| Kevin_Zheng | cool， thanks for the info | 08:02 |
| bauzas | morning stackers | 08:06 |
| *** mgoddard has joined #openstack-nova | 08:06 | |
| *** takashin has left #openstack-nova | 08:07 | |
| *** ralonsoh has quit IRC | 08:10 | |
| *** lucas-afk is now known as lucasagomes | 08:16 | |
| *** jaosorior has joined #openstack-nova | 08:16 | |
| *** tssurya has joined #openstack-nova | 08:19 | |
| *** armaan has quit IRC | 08:21 | |
| *** armaan has joined #openstack-nova | 08:22 | |
| *** mdbooth has joined #openstack-nova | 08:26 | |
| gibi | bauzas: morning | 08:26 |
| openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: cold migrate to compute down https://review.openstack.org/496280 | 08:28 |
| *** gjayavelu has quit IRC | 08:29 | |
| *** gongysh has joined #openstack-nova | 08:30 | |
| *** mdnadeem has joined #openstack-nova | 08:36 | |
| *** zz9pzza has quit IRC | 08:36 | |
| *** sambetts|afk is now known as sambetts | 08:37 | |
| *** zz9pzza has joined #openstack-nova | 08:39 | |
| *** itlinux has joined #openstack-nova | 08:39 | |
| *** derekh has joined #openstack-nova | 08:41 | |
| *** ktibi has joined #openstack-nova | 08:43 | |
| *** alexchadin has quit IRC | 08:43 | |
| *** armaan has quit IRC | 08:48 | |
| *** armaan has joined #openstack-nova | 08:48 | |
| *** xinliang has quit IRC | 08:49 | |
| *** sahid has quit IRC | 08:49 | |
| *** sahid has joined #openstack-nova | 08:49 | |
| *** xinliang has joined #openstack-nova | 08:51 | |
| *** hiro-kobayashi has quit IRC | 08:57 | |
| openstackgerrit | Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | 09:00 |
| *** itlinux has quit IRC | 09:13 | |
| *** priteau has joined #openstack-nova | 09:14 | |
| *** ktibi has quit IRC | 09:20 | |
| *** itlinux has joined #openstack-nova | 09:20 | |
| *** ktibi has joined #openstack-nova | 09:21 | |
| *** armaan has quit IRC | 09:26 | |
| *** armaan has joined #openstack-nova | 09:26 | |
| openstackgerrit | zhangyangyang proposed openstack/nova master: Remove ExactCoreFilter ExactDiskFilter ExactRamFilter https://review.openstack.org/508886 | 09:27 |
| openstackgerrit | Michael Still proposed openstack/nova master: Use os.rename, not mv. https://review.openstack.org/562463 | 09:27 |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert fping API to processutils.execute() https://review.openstack.org/564144 | 09:27 |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert xenapi's xvp console to processutils. https://review.openstack.org/564145 | 09:27 |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert certificate generation to processutils. https://review.openstack.org/564146 | 09:27 |
| *** dtantsur|afk is now known as dtantsur | 09:28 | |
| *** ZZelle has joined #openstack-nova | 09:30 | |
| *** Dinesh_Bhor has quit IRC | 09:31 | |
| *** gongysh has quit IRC | 09:35 | |
| *** alexchadin has joined #openstack-nova | 09:39 | |
| *** armaan has quit IRC | 09:40 | |
| *** liuzz has joined #openstack-nova | 09:44 | |
| *** liuzz_ has quit IRC | 09:45 | |
| *** sdague has joined #openstack-nova | 09:49 | |
| *** hoonetorg has joined #openstack-nova | 09:49 | |
| *** ociuhandu has quit IRC | 10:06 | |
| openstackgerrit | MultipleCrashes proposed openstack/nova master: NCP-2367-deallocate-network-retry https://review.openstack.org/563418 | 10:07 |
| *** damien_r has quit IRC | 10:07 | |
| *** damien_r has joined #openstack-nova | 10:10 | |
| *** abhishekk has quit IRC | 10:10 | |
| *** AlexeyAbashkin has quit IRC | 10:10 | |
| *** dougshelley66 has joined #openstack-nova | 10:12 | |
| *** ssurana1 has quit IRC | 10:23 | |
| *** itlinux has quit IRC | 10:23 | |
| *** moshele has quit IRC | 10:29 | |
| *** alexchadin has quit IRC | 10:30 | |
| *** zz9pzza has quit IRC | 10:32 | |
| *** nicolasbock has joined #openstack-nova | 10:33 | |
| *** aloga has quit IRC | 10:37 | |
| *** aloga has joined #openstack-nova | 10:37 | |
| *** liuzz has quit IRC | 10:38 | |
| *** liuzz has joined #openstack-nova | 10:38 | |
| *** yamamoto has quit IRC | 10:40 | |
| *** zz9pzza has joined #openstack-nova | 10:41 | |
| stephenfin | jaypipes, bauzas: Either of you any idea what I'm doing wrong here? https://github.com/stephenfin/nova/commit/73b9d061551067e393eb5bfec296c64623c72b7c | 10:48 |
| *** derekh has quit IRC | 10:48 | |
| stephenfin | jaypipes, bauzas: My migration seems to be working. I ran 'nova-manage db sync' and can see the column in the instance_extra table. However, I'm getting the following exception from the super conductor http://paste.openstack.org/show/719901/ | 10:49 |
| bauzas | stephenfin: heh, welcome to cells v2 | 10:49 |
| bauzas | stephenfin: AFAIR, and if I'm not wrong, superconductor runs on the top API cell | 10:50 |
| bauzas | stephenfin: hence it checking the API DB | 10:50 |
| *** damien_r has quit IRC | 10:50 | |
| *** simondodsley has quit IRC | 10:50 | |
| *** udesale has joined #openstack-nova | 10:51 | |
| *** simondodsley has joined #openstack-nova | 10:51 | |
| *** opetrenko has joined #openstack-nova | 10:51 | |
| stephenfin | bauzas: Right, that's what I was thinking so I ran 'nova-manage api_db sync' too, to be safe. However, there's no 'instance_extra' table in the nova_api database | 10:51 |
| bauzas | stephenfin: are you sure you correctly target a cell ? | 10:51 |
| stephenfin | What do you mean? | 10:52 |
| bauzas | there is a contextmanager | 10:52 |
| stephenfin | bauzas, jaypipes: As an aside, here's my DB schema for the cell0 table http://paste.openstack.org/show/719902/ | 10:52 |
| stephenfin | bauzas: Let me check | 10:52 |
| bauzas | stephenfin: I'll need to go out | 10:53 |
| bauzas | for eating | 10:53 |
| stephenfin | bauzas: No problem. Let's pick this up after lunch | 10:53 |
| bauzas | but lemme find some explanations | 10:53 |
| *** hshiina has quit IRC | 10:53 | |
| *** hshiina has joined #openstack-nova | 10:53 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Lift the restriction of choices for `cpu_model_extra_flags` https://review.openstack.org/563926 | 10:57 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: Do-Not-Merge: Test 1GB Huge Pages https://review.openstack.org/564161 | 10:57 |
| *** auggy has quit IRC | 10:58 | |
| *** udesale has quit IRC | 10:59 | |
| *** auggy has joined #openstack-nova | 10:59 | |
| *** dpawlik has quit IRC | 10:59 | |
| bauzas | stephenfin: in https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#multiple-cells you can see the top-level superconductor using multiple MQs | 10:59 |
| *** dpawlik has joined #openstack-nova | 11:01 | |
| *** sergek_ has quit IRC | 11:01 | |
| *** sergek_ has joined #openstack-nova | 11:01 | |
| *** moshele has joined #openstack-nova | 11:02 | |
| *** ktibi has quit IRC | 11:02 | |
| *** cdent has joined #openstack-nova | 11:04 | |
| *** opetrenko has quit IRC | 11:04 | |
| *** damien_r has joined #openstack-nova | 11:04 | |
| *** dpawlik has quit IRC | 11:05 | |
| *** damien_r has quit IRC | 11:05 | |
| *** itlinux has joined #openstack-nova | 11:06 | |
| *** opetrenko has joined #openstack-nova | 11:06 | |
| *** damien_r has joined #openstack-nova | 11:07 | |
| *** yamamoto has joined #openstack-nova | 11:07 | |
| *** itlinux has quit IRC | 11:07 | |
| *** Tom-Tom has quit IRC | 11:08 | |
| *** Tom-Tom has joined #openstack-nova | 11:09 | |
| kashyap | sean-k-mooney: Respun the patch above, if you get a minute to ACK it today... | 11:09 |
| *** armaan has joined #openstack-nova | 11:10 | |
| *** fmccrthy has quit IRC | 11:11 | |
| *** fmccrthy has joined #openstack-nova | 11:11 | |
| *** Tom-Tom has quit IRC | 11:13 | |
| *** hshiina is now known as hshiina|afk | 11:14 | |
| *** lucasagomes is now known as lucas-hungry | 11:14 | |
| *** tetsuro has quit IRC | 11:20 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:20 | |
| bhagyashris | kashyap: Hi, I am trying to write the functional test for https://review.openstack.org/#/c/560444/ https://review.openstack.org/#/c/560459/ which related to libvirt change so can you guide me how should i write the test for the same. Basically this change is fixing related to scenario: As on current master, if user configured the shared resource provider along with the Compute Node resource providers on libvirt and boot the instance then the | 11:20 |
| bhagyashris | DISK_GB used from the Compute Node resource provider. Expected that it should take the DISK_GB from the Shared Resource Provider and VCPU, MEMORY_MB from Compute Node resource provider. | 11:20 |
| *** maciejjozefczyk has joined #openstack-nova | 11:20 | |
| *** dougshelley66 has quit IRC | 11:21 | |
| *** maciejjozefczyk has left #openstack-nova | 11:21 | |
| *** liuzz_ has joined #openstack-nova | 11:22 | |
| *** liuzz has quit IRC | 11:23 | |
| *** fragatina has quit IRC | 11:24 | |
| *** zhaochao has quit IRC | 11:24 | |
| *** fragatina has joined #openstack-nova | 11:25 | |
| bhagyashris | kashyap: I have checked the existing functional test cases on master under /nova/tests/functional/libvirt/test_pci_sriov_servers.py but there they are directly building the instance using the post call but in my case i will need to resource provider to build the instance | 11:27 |
| *** stakeda has quit IRC | 11:27 | |
| bhagyashris | kashyap: so can you guide? | 11:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 11:29 |
| *** wolsen has quit IRC | 11:30 | |
| *** wolsen has joined #openstack-nova | 11:30 | |
| *** liuzz_ has quit IRC | 11:31 | |
| *** chyka has joined #openstack-nova | 11:31 | |
| *** liuzz has joined #openstack-nova | 11:31 | |
| *** sahid has quit IRC | 11:33 | |
| *** wolverineav has joined #openstack-nova | 11:34 | |
| *** jpena is now known as jpena|lunch | 11:35 | |
| *** chyka has quit IRC | 11:35 | |
| *** damien_r has quit IRC | 11:35 | |
| *** damien_r has joined #openstack-nova | 11:38 | |
| *** moshele has quit IRC | 11:41 | |
| *** damien_r has quit IRC | 11:41 | |
| *** udesale has joined #openstack-nova | 11:42 | |
| *** damien_r has joined #openstack-nova | 11:42 | |
| *** dpawlik has joined #openstack-nova | 11:45 | |
| *** moshele has joined #openstack-nova | 11:48 | |
| *** amoralej is now known as amoralej|lunch | 11:48 | |
| *** armaan has quit IRC | 11:51 | |
| *** zhaochao has joined #openstack-nova | 11:51 | |
| *** armaan has joined #openstack-nova | 11:51 | |
| *** udesale has quit IRC | 11:51 | |
| *** udesale has joined #openstack-nova | 11:52 | |
| *** ratailor has quit IRC | 11:52 | |
| *** jmlowe has joined #openstack-nova | 11:54 | |
| *** dougshelley66 has joined #openstack-nova | 11:59 | |
| *** eharney has quit IRC | 12:01 | |
| *** liuzz has quit IRC | 12:03 | |
| *** liuzz has joined #openstack-nova | 12:04 | |
| openstackgerrit | wanghongtao proposed openstack/nova master: Fix the metadata re to match the unicode https://review.openstack.org/536236 | 12:05 |
| *** yamamoto has quit IRC | 12:08 | |
| kashyap | bhagyashris: Was AFK, reading the scrollback now | 12:09 |
| bhagyashris | kashyap: ok | 12:10 |
| kashyap | bhagyashris: I haven't had a chance yet to use Resource Providers, so wouldn't really have great advice. Still, reading the change | 12:11 |
| kashyap | bhagyashris: I think you wanted to address Eric's feedback: | 12:11 |
| kashyap | "...or even better, don't mock - create an actual ProviderTree instance and assert its actual contents on the other side of the update_provider_tree call." | 12:11 |
| bhagyashris | kashyap: no no Actually I have address the unit test cases related comments | 12:14 |
| bhagyashris | kashyap: now i am talking about the fuctional test case part | 12:15 |
| *** rmk` has joined #openstack-nova | 12:18 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 12:18 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job https://review.openstack.org/564067 | 12:18 |
| kashyap | bhagyashris: Ah, right | 12:18 |
| *** raginbaj- has joined #openstack-nova | 12:18 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | 12:19 |
| kashyap | bhagyashris: So you don't have a precedent for functional test that uses Resource Provider to build an instance | 12:19 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | 12:19 |
| *** sahid has joined #openstack-nova | 12:22 | |
| *** raginbajin has quit IRC | 12:23 | |
| *** rmk has quit IRC | 12:23 | |
| *** dougshelley66 has quit IRC | 12:23 | |
| *** ragiman has quit IRC | 12:23 | |
| *** sridharg has quit IRC | 12:23 | |
| *** dklyle has quit IRC | 12:23 | |
| *** mvk has quit IRC | 12:23 | |
| *** lbragstad has quit IRC | 12:23 | |
| *** gokhan has quit IRC | 12:23 | |
| *** krtaylor has quit IRC | 12:23 | |
| *** edleafe has quit IRC | 12:23 | |
| *** jcosmao has quit IRC | 12:23 | |
| *** frickler has quit IRC | 12:23 | |
| *** fanzhang has quit IRC | 12:23 | |
| *** strigazi has quit IRC | 12:23 | |
| *** Jeffrey4l has quit IRC | 12:23 | |
| *** ingy has quit IRC | 12:23 | |
| *** kuzko has quit IRC | 12:23 | |
| *** SamYaple has quit IRC | 12:23 | |
| *** antonym has quit IRC | 12:23 | |
| *** hemna has quit IRC | 12:23 | |
| *** rmk` is now known as rmk | 12:23 | |
| *** raginbaj- is now known as raginbajin | 12:23 | |
| *** rmk has quit IRC | 12:23 | |
| *** rmk has joined #openstack-nova | 12:23 | |
| *** edmondsw has joined #openstack-nova | 12:24 | |
| bhagyashris | kashyap: yeah as of now I haven't seen the functional like the resource providers are created and that are used to build the instance | 12:24 |
| kashyap | bhagyashris: I'm afraid, I'm not really familiar with that area, so I can't help without extensive trial-and-error myself. Perhaps ask on the mailing list with [nova] tag? | 12:24 |
| *** jpena|lunch is now known as jpena|off | 12:25 | |
| bhagyashris | kashyap: ok | 12:25 |
| *** homeski has quit IRC | 12:25 | |
| *** dougshelley66 has joined #openstack-nova | 12:26 | |
| *** ragiman has joined #openstack-nova | 12:26 | |
| *** sridharg has joined #openstack-nova | 12:26 | |
| *** dklyle has joined #openstack-nova | 12:26 | |
| *** mvk has joined #openstack-nova | 12:26 | |
| *** lbragstad has joined #openstack-nova | 12:26 | |
| *** gokhan has joined #openstack-nova | 12:26 | |
| *** krtaylor has joined #openstack-nova | 12:26 | |
| *** edleafe has joined #openstack-nova | 12:26 | |
| *** jcosmao has joined #openstack-nova | 12:26 | |
| *** frickler has joined #openstack-nova | 12:26 | |
| *** fanzhang has joined #openstack-nova | 12:26 | |
| *** strigazi has joined #openstack-nova | 12:26 | |
| *** Jeffrey4l has joined #openstack-nova | 12:26 | |
| *** ingy has joined #openstack-nova | 12:26 | |
| *** kuzko has joined #openstack-nova | 12:26 | |
| *** SamYaple has joined #openstack-nova | 12:26 | |
| *** antonym has joined #openstack-nova | 12:26 | |
| *** hemna has joined #openstack-nova | 12:26 | |
| *** liuzz has quit IRC | 12:26 | |
| kashyap | bhagyashris: Since people are spread across time zones, you might get delayed (which is normal) responses on IRC. That's why I suggested the list. | 12:27 |
| *** tbachman has joined #openstack-nova | 12:27 | |
| *** liuzz has joined #openstack-nova | 12:27 | |
| *** mtreinish has quit IRC | 12:27 | |
| bhagyashris | kashyap: ok. currently i am struggling to write that so asking on IRC for quick response | 12:28 |
| *** mtreinish has joined #openstack-nova | 12:28 | |
| *** homeski has joined #openstack-nova | 12:28 | |
| kashyap | Yeah, a combination is fine. bhagyashris How about this: | 12:28 |
| *** edmondsw has quit IRC | 12:28 | |
| *** artom_ has quit IRC | 12:28 | |
| kashyap | bhagyashris: Post what you have based on how far you've come, and then point that to a Resource Providers expert (maybe jaypipes) for more guidance? | 12:29 |
| kashyap | Also, Zuul is still failing on your https://review.openstack.org/#/c/560459/. | 12:30 |
| *** sree has joined #openstack-nova | 12:30 | |
| bhagyashris | kashyap: ok waiting for others will see | 12:30 |
| bhagyashris | kashyap: yeah struggling for the same also randomly the tempest test are falling | 12:31 |
| bhagyashris | kashyap: and all are failing with the error as No valid host is found. I have also checked the logs and at n-sch side it's showing that the Placement is returning allocation_candidates | 12:32 |
| *** lucas-hungry is now known as lucasagomes | 12:33 | |
| kashyap | I see | 12:33 |
| bhagyashris | kashyap: I am not getting why the n-sch is not returning the allocation_candicates as my change is at nova compute side | 12:33 |
| bhagyashris | kashyap: and on master evrthing is fine only on patch patches it's failing | 12:34 |
| bhagyashris | kashyap: any idea/ | 12:35 |
| bhagyashris | ? | 12:35 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Escalate UUID validation warning to error in test https://review.openstack.org/540386 | 12:35 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix invalid UUIDs in test https://review.openstack.org/564190 | 12:35 |
| *** burt has joined #openstack-nova | 12:36 | |
| kashyap | bhagyashris: Not without delving too deep. Please go through the traces systematically to find the root cause. I'm a bit buried with a couple of urgent things | 12:37 |
| bhagyashris | kashyap: ok np thank you :) | 12:37 |
| bhagyashris | jaypipes: Hi, | 12:38 |
| *** amoralej|lunch is now known as amoralej | 12:40 | |
| *** jpena|off is now known as jpena | 12:41 | |
| *** edmondsw has joined #openstack-nova | 12:43 | |
| *** edmondsw has quit IRC | 12:46 | |
| *** edmondsw has joined #openstack-nova | 12:47 | |
| *** eharney has joined #openstack-nova | 12:47 | |
| openstackgerrit | Martin Midolesov proposed openstack/nova master: Validating video ram against the max video ram allowed https://review.openstack.org/564193 | 12:47 |
| *** liverpooler has joined #openstack-nova | 12:50 | |
| *** edmondsw has quit IRC | 12:50 | |
| *** esberglu has joined #openstack-nova | 12:56 | |
| *** jamespage has quit IRC | 12:57 | |
| *** jamespage has joined #openstack-nova | 12:57 | |
| *** READ10 has joined #openstack-nova | 12:58 | |
| *** sree has quit IRC | 12:59 | |
| *** QianYu_ has joined #openstack-nova | 12:59 | |
| *** pchavva has joined #openstack-nova | 13:01 | |
| *** lyan has joined #openstack-nova | 13:03 | |
| *** lyan is now known as Guest14047 | 13:04 | |
| *** yamamoto has joined #openstack-nova | 13:04 | |
| *** yamamoto has quit IRC | 13:10 | |
| *** edmondsw has joined #openstack-nova | 13:13 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.openstack.org/512552 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env https://review.openstack.org/512553 | 13:14 |
| openstack | bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer) | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor https://review.openstack.org/512623 | 13:14 |
| *** edmondsw has quit IRC | 13:15 | |
| *** edmondsw has joined #openstack-nova | 13:15 | |
| *** zz9pzza has quit IRC | 13:19 | |
| *** bkopilov has quit IRC | 13:19 | |
| *** udesale has quit IRC | 13:19 | |
| *** liuzz has quit IRC | 13:27 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: mdevs returning parent and vendor PCI info https://review.openstack.org/562304 | 13:29 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: Configure multiple vGPU types https://review.openstack.org/564214 | 13:29 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Get inventories per pGPU https://review.openstack.org/564215 | 13:29 |
| *** psachin has quit IRC | 13:30 | |
| *** zz9pzza has joined #openstack-nova | 13:31 | |
| *** QianYu_ has quit IRC | 13:31 | |
| *** liuzz has joined #openstack-nova | 13:31 | |
| *** dave-mccowan has joined #openstack-nova | 13:34 | |
| *** dougshelley66 has quit IRC | 13:34 | |
| *** dougshelley66 has joined #openstack-nova | 13:36 | |
| *** mdbooth_ has joined #openstack-nova | 13:37 | |
| *** mdbooth has quit IRC | 13:37 | |
| mnaser | super unrelated but i feel like this might be something devs have had to deal with | 13:38 |
| mnaser | is there some sort of 'tcpdump for rabbitmq' toolset available anywhere (or part of rabbitmq) | 13:38 |
| *** QianYu has joined #openstack-nova | 13:42 | |
| *** bkopilov has joined #openstack-nova | 13:42 | |
| *** mriedem has joined #openstack-nova | 13:43 | |
| *** owalsh is now known as owalsh_afk | 13:43 | |
| stephenfin | bauzas: OK, looked at that and it does seem like it's targeted. See line 35 from the paste paste.openstack.org/show/719901/ | 13:43 |
| stephenfin | and compare to https://github.com/stephenfin/nova/blob/bp/numa-aware-vswitches/nova/conductor/manager.py#L1172-L1175 | 13:43 |
| *** QianYu_ has joined #openstack-nova | 13:44 | |
| *** QianYu has quit IRC | 13:44 | |
| stephenfin | But wait - the *cell1* table wasn't migrated. Well that's annoying. I would have expected 'nova-manage sync' to do all cell tables unless I explicitly said otherwise http://paste.openstack.org/show/719912/ | 13:46 |
| openstackgerrit | Hamdy Khader proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640 | 13:46 |
| stephenfin | dansmith: Any reason 'nova-manage db sync' doesn't sync all cell DBs at once? | 13:47 |
| dansmith | stephenfin: yeah, because that would potentially lock down all of them at once (or nearly) and maybe you're upgrading one cell before another | 13:47 |
| dansmith | db sync is/can be run at runtime before upgrading code and has a significant impact on the performance of the db while running | 13:48 |
| dansmith | we have or had a --all-cells flag proposed for it | 13:48 |
| *** dave-mcc_ has joined #openstack-nova | 13:48 | |
| stephenfin | Right, and the non upgraded cell would be using old code so you wouldn't see backtraces like I did above | 13:48 |
| stephenfin | (my next question was going to be "wouldn't the older schema be invalid for newer code") | 13:49 |
| *** efried has joined #openstack-nova | 13:49 | |
| *** dave-mccowan has quit IRC | 13:51 | |
| *** awaugama has joined #openstack-nova | 13:52 | |
| mriedem | stephenfin: if you want to brush this off https://review.openstack.org/#/c/420973/ | 13:53 |
| *** dtantsur is now known as dtantsur|brb | 13:53 | |
| *** evin has quit IRC | 13:54 | |
| stephenfin | Um, so how do I upgrade the schema for the cell1 DB? It's an all-in-one deployment so cell0 and cell1 DB are on the same node | 13:55 |
| stephenfin | The docs say " If --local_cell is specified, then only the main database in the current cell is upgraded." but my main database for an all in one is...both of them? | 13:55 |
| stephenfin | mriedem: I can do that | 13:55 |
| dansmith | use the config that the cell1 services use | 13:55 |
| stephenfin | So change '[database] connection' in nova.conf to the cell1 DB? | 13:58 |
| stephenfin | Wait | 13:58 |
| stephenfin | There's a '--config-file'. That should show up when I do 'nova-manage db sync --help' | 13:58 |
| stephenfin | #usability | 13:58 |
| mriedem | stephenfin: is this devstack? | 13:59 |
| stephenfin | mriedem: It is | 13:59 |
| mriedem | if so, by default, even though it's single node, it's not all in one | 13:59 |
| mriedem | see under /etc/nova | 13:59 |
| mriedem | there should be multiple config files | 13:59 |
| mriedem | nova_cell1.conf is the cell1 conf | 13:59 |
| stephenfin | Sorry, I'm using the wrong terminology so. I meant everything is deployed onto one machine | 14:00 |
| mriedem | nova-cpu.conf is for nova-compute | 14:00 |
| mriedem | nova.conf is used for the controller services and n-super-cond | 14:00 |
| *** dklyle has quit IRC | 14:00 | |
| stephenfin | Yup, just ran this and things are looking good -> $ nova-manage --config-file /etc/nova/nova_cell1.conf db sync | 14:00 |
| bhagyashris | efried: Hi, I am trying to write the functional test for https://review.openstack.org/#/c/560444/ https://review.openstack.org/#/c/560459/ but have some question about that: As of on current master there no as such functional test that is creating the RP providers and used to boot the instance or to build the instance | 14:06 |
| *** yamamoto has joined #openstack-nova | 14:06 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | 14:06 |
| efried | bhagyashris: You may have to piece it together from other bits. | 14:10 |
| *** hemna_ has joined #openstack-nova | 14:11 | |
| *** yamamoto has quit IRC | 14:11 | |
| efried | bhagyashris: Did you figure out the error from yesterday? | 14:11 |
| *** fishbone__ has joined #openstack-nova | 14:12 | |
| bhagyashris | efried: or I can say there is no frame work in fictional test that creates the resource provider and that providers will be used to build the instances | 14:13 |
| bhagyashris | efried: and one more doubt is how that created provider will be pick by sch at the time of build instance | 14:14 |
| bhagyashris | efried: in current functional test cases the create server are created on the single host | 14:15 |
| efried | bhagyashris: You're trying to make a functional test that does exactly what you did in your live environment. That is, you create the provider, mark it as a sharing provider, give it DISK_GB inventory, and associate it via aggregate with the compute node provider. Then the purpose of the patch we're testing is that we fixed it exactly so the scheduler knows to pick that sharing provider for the DISK_GB. | 14:17 |
| fishbone__ | hello all; I am receiving a strange error when launching windows instances: ERROR cloudbaseinit.init pywintypes.com_error: (-2147352567, 'Exception occurred.', (0, 'Session', 'Access is denied. ', None, 0, -2147024891), None) | 14:18 |
| fishbone__ | I believe this is causing an issue that disallows the key to regenerate the password appropriately when rebuilding instances | 14:19 |
| *** mlavalle has joined #openstack-nova | 14:19 | |
| fishbone__ | Is that simply an issue with the cloudbase-init; perhaps a reinstall would fix that? | 14:19 |
| bhagyashris | efried: yeah. but through creating provider and inventory and then association of CN and share provider etc will need in functional test and then while creating the instance how come that request will know that the CN and shared resource provider should pick that providers | 14:20 |
| bhagyashris | becuse as on functional test the only the single provider is used | 14:21 |
| *** artom_ has joined #openstack-nova | 14:21 | |
| *** artom_ is now known as artom | 14:22 | |
| efried | bhagyashris: What do you mean? If the functional test setup is using the "live" placement fixture, it should be behaving just like a real placement database. So if you create new providers in there, they should stick, and they should get picked up by your deploy (in the test). | 14:22 |
| *** felipemonteiro__ has joined #openstack-nova | 14:22 | |
| *** andreas_s has joined #openstack-nova | 14:25 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:26 | |
| *** felipemonteiro__ has quit IRC | 14:30 | |
| bhagyashris | efried: which fixture are you talking there are two fixture one is nova/nova/tests/fixtures.PlacementFixture and other one is nova/tests/functional/api/openstack/placement/fixtures.SharedStorageFixture | 14:31 |
| bhagyashris | efried: so it's little bit confusing. the second fixture is used in gabbit test | 14:32 |
| kashyap | mriedem: When you can, mind having a gander at this, as you have prior context: https://review.openstack.org/#/c/563926/ (Lift the restriction of choices for `cpu_model_extra_flags`) | 14:34 |
| lyarwood | bauzas: you were working on a hard reboot bug in master around _get_all_assigned_mediated_devices right? | 14:35 |
| *** lpetrut has quit IRC | 14:35 | |
| *** lpetrut has joined #openstack-nova | 14:36 | |
| efried | bhagyashris: The SharedStorageFixture is a thing that's setting up macros (and maybe some providers) for use in the gabbits. I'm talking about the first one. Hold on, let me find an example of how it gets used... | 14:36 |
| bhagyashris | ok | 14:37 |
| *** felipemonteiro has joined #openstack-nova | 14:37 | |
| efried | bhagyashris: nova/tests/functional/test_servers.py | 14:38 |
| *** felipemonteiro_ has quit IRC | 14:38 | |
| *** moshele has quit IRC | 14:38 | |
| efried | bhagyashris: That's a good example, the PlacementFixture is instantiated and then saved off to an instance variable, and then it gets used to talk to the placement API in the test cases. | 14:39 |
| bauzas | lyarwood: yup | 14:39 |
| efried | Hey, anyone got their thumb on a nice reference doc for bfv? | 14:39 |
| *** sree has joined #openstack-nova | 14:40 | |
| bauzas | efried: yup, master doc | 14:41 |
| bauzas | efried: BDMs, you mean ? | 14:41 |
| bauzas | efried: https://docs.openstack.org/nova/latest/user/block-device-mapping.html | 14:42 |
| efried | bauzas: boot from volume specifically | 14:43 |
| jaypipes | efried: the "live" PlacementFixture thing is broken by design, IMHO. Try removing @safe_connect and running a functional test case with the PlacementFixture and see what happens. It's basically hiding a bunch of brokenness with @safe_connect | 14:44 |
| efried | jaypipes: But it ought to work to set up providers and stuff, won't it? | 14:45 |
| *** felipemonteiro has quit IRC | 14:45 | |
| jaypipes | efried: and by "brokenness with @safe_connect" I'm referring to any place that calls a method of the reportclient that returns something (because @safe_connect will mask over issues and return a None, meaning anything that calls or depends on the return value from a method in reportclient will be broken) | 14:46 |
| *** Eran_Kuris has quit IRC | 14:46 | |
| efried | jaypipes: Ah, but only if you call a method that's decorated by @safe_connect. So doing primitive get/put/post/delete calls will be fine. | 14:46 |
| jaypipes | efried: are you referring to the nova.tests.fixtures.PlacementFixture, or are you referring to this? https://github.com/openstack/nova/blob/master/nova/tests/functional/api/openstack/placement/fixtures.py#L34 | 14:47 |
| efried | bhagyashris: So note the above, and do your calls in the same fashion that test_servers.py does them. See the helper methods around L1440-1474 | 14:47 |
| jaypipes | efried: because the latter sets up the data fixtures with direct calls to the database, not by the placement API calls. | 14:48 |
| efried | jaypipes: The former. | 14:48 |
| jaypipes | efried: yeah. the former is what I consider to be broken. but whatevs. | 14:49 |
| *** derekh has joined #openstack-nova | 14:51 | |
| bhagyashris | efried: yeah checking the same... | 14:51 |
| *** dtantsur|brb is now known as dtantsur | 14:51 | |
| *** kholkina has quit IRC | 14:56 | |
| *** armaan has quit IRC | 14:57 | |
| mriedem | kashyap: that would be my pleasure | 14:58 |
| stephenfin | dansmith: Any hints about why this could be happening? http://paste.openstack.org/show/719928/ | 14:58 |
| * kashyap waits for some snids remarks in the review :P | 14:58 | |
| *** armaan has joined #openstack-nova | 14:58 | |
| kashyap | s/snids/snide/ | 14:58 |
| stephenfin | It seems to be caused by this line in o.vo https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L65-L66 | 14:58 |
| dansmith | stephenfin: well, it means you don't have a context on that object | 14:58 |
| dansmith | and you're trying to lazy-load .network_requests | 14:58 |
| stephenfin | dansmith: But it doesn't happen for the numa_topology object which is defined the exact same way | 14:59 |
| dansmith | stephenfin: I dunno what to say.. that ^ is the exact reason | 14:59 |
| dansmith | either give it a context if it needs to be able to lazy-load, or make sure .network_requests is set to something | 15:00 |
| *** edmondsw has quit IRC | 15:01 | |
| *** ragiman has quit IRC | 15:01 | |
| *** sridharg has quit IRC | 15:01 | |
| *** mvk has quit IRC | 15:01 | |
| *** lbragstad has quit IRC | 15:01 | |
| *** gokhan has quit IRC | 15:01 | |
| *** krtaylor has quit IRC | 15:01 | |
| *** edleafe has quit IRC | 15:01 | |
| *** jcosmao has quit IRC | 15:01 | |
| *** frickler has quit IRC | 15:01 | |
| *** fanzhang has quit IRC | 15:01 | |
| *** strigazi has quit IRC | 15:01 | |
| *** Jeffrey4l has quit IRC | 15:01 | |
| *** ingy has quit IRC | 15:01 | |
| *** kuzko has quit IRC | 15:01 | |
| *** SamYaple has quit IRC | 15:01 | |
| *** antonym has quit IRC | 15:01 | |
| *** hemna has quit IRC | 15:01 | |
| *** jhesketh has quit IRC | 15:01 | |
| *** swamireddy has quit IRC | 15:01 | |
| *** armaan has quit IRC | 15:01 | |
| *** READ10 has quit IRC | 15:01 | |
| *** esberglu has quit IRC | 15:01 | |
| *** AlexeyAbashkin has quit IRC | 15:01 | |
| *** hoonetorg has quit IRC | 15:01 | |
| *** sdague has quit IRC | 15:01 | |
| *** xinliang has quit IRC | 15:01 | |
| *** jchhatba_ has quit IRC | 15:01 | |
| *** mchlumsky has quit IRC | 15:01 | |
| *** markvoelker has quit IRC | 15:01 | |
| *** tonyb has quit IRC | 15:01 | |
| *** trozet has quit IRC | 15:01 | |
| *** slagle has quit IRC | 15:01 | |
| *** andreykurilin has quit IRC | 15:01 | |
| *** s1061123 has quit IRC | 15:01 | |
| *** Nil_ has quit IRC | 15:01 | |
| *** rubasov has quit IRC | 15:01 | |
| *** toabctl has quit IRC | 15:01 | |
| *** liuzz has quit IRC | 15:01 | |
| *** zz9pzza has quit IRC | 15:01 | |
| *** eharney has quit IRC | 15:01 | |
| *** vivsoni__ has quit IRC | 15:01 | |
| *** jogo has quit IRC | 15:01 | |
| *** Lingwu has quit IRC | 15:01 | |
| *** zigo has quit IRC | 15:01 | |
| *** _pewp_ has quit IRC | 15:01 | |
| *** adreznec has quit IRC | 15:01 | |
| *** johnthetubaguy_ has quit IRC | 15:01 | |
| *** ivve has quit IRC | 15:01 | |
| *** FoXMaN has quit IRC | 15:01 | |
| *** sq4ind has quit IRC | 15:01 | |
| *** ericyoung has quit IRC | 15:01 | |
| *** rybridges has quit IRC | 15:01 | |
| *** slunkad has quit IRC | 15:01 | |
| *** ChanServ has quit IRC | 15:01 | |
| stephenfin | Oh, that latter would do it. numa_topology is defined to something https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_resource_tracker.py#L1853 | 15:01 |
| openstackgerrit | Aditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin https://review.openstack.org/534371 | 15:01 |
| *** liuzz has joined #openstack-nova | 15:01 | |
| *** zz9pzza has joined #openstack-nova | 15:01 | |
| *** eharney has joined #openstack-nova | 15:01 | |
| *** vivsoni__ has joined #openstack-nova | 15:01 | |
| *** jogo has joined #openstack-nova | 15:01 | |
| *** Lingwu has joined #openstack-nova | 15:01 | |
| *** zigo has joined #openstack-nova | 15:01 | |
| *** _pewp_ has joined #openstack-nova | 15:01 | |
| *** adreznec has joined #openstack-nova | 15:01 | |
| *** johnthetubaguy_ has joined #openstack-nova | 15:01 | |
| *** ivve has joined #openstack-nova | 15:01 | |
| *** FoXMaN has joined #openstack-nova | 15:01 | |
| *** sq4ind has joined #openstack-nova | 15:01 | |
| *** ericyoung has joined #openstack-nova | 15:01 | |
| *** rybridges has joined #openstack-nova | 15:01 | |
| *** slunkad has joined #openstack-nova | 15:01 | |
| *** ChanServ has joined #openstack-nova | 15:01 | |
| *** barjavel.freenode.net sets mode: +o ChanServ | 15:01 | |
| *** zhaochao has quit IRC | 15:02 | |
| *** jhesketh has joined #openstack-nova | 15:03 | |
| *** swamireddy has joined #openstack-nova | 15:03 | |
| *** edmondsw has joined #openstack-nova | 15:03 | |
| *** ragiman has joined #openstack-nova | 15:03 | |
| *** sridharg has joined #openstack-nova | 15:03 | |
| *** mvk has joined #openstack-nova | 15:03 | |
| *** lbragstad has joined #openstack-nova | 15:03 | |
| *** gokhan has joined #openstack-nova | 15:03 | |
| *** krtaylor has joined #openstack-nova | 15:03 | |
| *** edleafe has joined #openstack-nova | 15:03 | |
| *** jcosmao has joined #openstack-nova | 15:03 | |
| *** frickler has joined #openstack-nova | 15:03 | |
| *** fanzhang has joined #openstack-nova | 15:03 | |
| *** strigazi has joined #openstack-nova | 15:03 | |
| *** Jeffrey4l has joined #openstack-nova | 15:03 | |
| *** ingy has joined #openstack-nova | 15:03 | |
| *** kuzko has joined #openstack-nova | 15:03 | |
| *** SamYaple has joined #openstack-nova | 15:03 | |
| *** antonym has joined #openstack-nova | 15:03 | |
| *** hemna has joined #openstack-nova | 15:03 | |
| *** bandini has quit IRC | 15:03 | |
| stephenfin | dansmith: Yup, 'instance.network_requests = None' did the job. Thanks :) | 15:04 |
| *** armaan has joined #openstack-nova | 15:04 | |
| *** READ10 has joined #openstack-nova | 15:04 | |
| *** esberglu has joined #openstack-nova | 15:04 | |
| *** AlexeyAbashkin has joined #openstack-nova | 15:04 | |
| *** hoonetorg has joined #openstack-nova | 15:04 | |
| *** sdague has joined #openstack-nova | 15:04 | |
| *** xinliang has joined #openstack-nova | 15:04 | |
| *** jchhatba_ has joined #openstack-nova | 15:04 | |
| *** mchlumsky has joined #openstack-nova | 15:04 | |
| *** markvoelker has joined #openstack-nova | 15:04 | |
| *** tonyb has joined #openstack-nova | 15:04 | |
| *** trozet has joined #openstack-nova | 15:04 | |
| *** slagle has joined #openstack-nova | 15:04 | |
| *** andreykurilin has joined #openstack-nova | 15:04 | |
| *** s1061123 has joined #openstack-nova | 15:04 | |
| *** Nil_ has joined #openstack-nova | 15:04 | |
| *** rubasov has joined #openstack-nova | 15:04 | |
| *** toabctl has joined #openstack-nova | 15:04 | |
| dansmith | stephenfin: cool | 15:04 |
| *** weshay has quit IRC | 15:04 | |
| *** sean-k-mooney[m] has quit IRC | 15:05 | |
| *** bandini has joined #openstack-nova | 15:05 | |
| *** weshay has joined #openstack-nova | 15:06 | |
| kashyap | When someone gets a moment, is there a better / effficient way to test a config in Gate than this DevStack patch: http://paste.openstack.org/show/719929/ | 15:06 |
| *** yamamoto has joined #openstack-nova | 15:08 | |
| * kashyap tries it anyway: https://review.openstack.org/564246 | 15:11 | |
| *** dougshelley66 has quit IRC | 15:11 | |
| *** dougshelley66 has joined #openstack-nova | 15:12 | |
| *** yamamoto has quit IRC | 15:13 | |
| kashyap | So the above should work; the fine folks on #openstack-qa confirmed | 15:13 |
| openstackgerrit | sahid proposed openstack/nova-specs master: fix blueprint related to the spec overhead-pin-set https://review.openstack.org/561916 | 15:14 |
| openstackgerrit | Simon Dodsley proposed openstack/nova master: Add enhanced KVM storage QoS quotas https://review.openstack.org/558530 | 15:15 |
| *** dougshelley66 has quit IRC | 15:19 | |
| *** hemna_ has quit IRC | 15:20 | |
| *** ZZelle has quit IRC | 15:20 | |
| *** andreas_s has quit IRC | 15:21 | |
| *** andreas_s has joined #openstack-nova | 15:21 | |
| *** QianYu_ has quit IRC | 15:22 | |
| *** QianYu has joined #openstack-nova | 15:23 | |
| dansmith | tssurya: mriedem melwitt: do we need a cells meeting today? | 15:24 |
| *** felipemonteiro has joined #openstack-nova | 15:24 | |
| *** belmoreira has joined #openstack-nova | 15:25 | |
| *** dpawlik has quit IRC | 15:25 | |
| mriedem | i don't | 15:25 |
| melwitt | I don't have anything for today | 15:26 |
| tssurya | belmoreira : ^ | 15:26 |
| belmoreira | we are upgrading to cellsV2 today... tomorrow I will have some info about it | 15:27 |
| tssurya | dansmith: yea its okay to skip today then | 15:27 |
| dansmith | wow, that's .. quite a statement :) | 15:27 |
| *** felipemonteiro_ has joined #openstack-nova | 15:28 | |
| *** rajinir has joined #openstack-nova | 15:29 | |
| *** felipemonteiro__ has joined #openstack-nova | 15:29 | |
| *** dougshelley66 has joined #openstack-nova | 15:30 | |
| *** felipemonteiro has quit IRC | 15:31 | |
| *** r-daneel has joined #openstack-nova | 15:31 | |
| *** felipemonteiro_ has quit IRC | 15:33 | |
| *** zz9pzza has quit IRC | 15:33 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Make accept-language tests work with webob 1.8.x https://review.openstack.org/564255 | 15:35 |
| *** andreas_s has quit IRC | 15:36 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: fix hard reboot issue with mdevs https://review.openstack.org/564257 | 15:37 |
| *** gyee has joined #openstack-nova | 15:39 | |
| cdent | melwitt: ^^ is the short term fix to the webob issues. should keep us for a while, but I've noted in the commit and on the bug that there's a long term need too | 15:40 |
| *** felipemonteiro__ has quit IRC | 15:40 | |
| *** felipemonteiro__ has joined #openstack-nova | 15:40 | |
| melwitt | cdent: okay, thanks | 15:41 |
| *** hongbin_ has joined #openstack-nova | 15:43 | |
| melwitt | reminder for the cells subteam, review would be appreciated on this fix for anti/affinity with multiple cells https://review.openstack.org/540258 | 15:43 |
| melwitt | cdent: curiosity question, why does q=1.1 not work if q=0.5 works? https://review.openstack.org/#/c/564255/1/nova/tests/unit/api/openstack/test_wsgi.py@102 | 15:45 |
| *** felipemonteiro__ has quit IRC | 15:45 | |
| cdent | melwitt: oh sorry, the change of 1.1 to 1 was not supposed to be committed | 15:45 |
| *** SamYaple has quit IRC | 15:45 | |
| cdent | will tidy that | 15:45 |
| melwitt | ah k | 15:46 |
| cdent | that was part of several different loops around the problem | 15:46 |
| cdent | the fact that the new invalid header class exists now really makes stuff a lot harder to debug :( | 15:46 |
| melwitt | oh, I see. so it makes everything do an AttributeError instead of complaining about the invalid things | 15:47 |
| bauzas | dansmith: mriedem: stephenfin: others: because of me, hard reboot no longer accepts to recreate a libvirt guest, but I fixed that by https://review.openstack.org/564257 | 15:47 |
| melwitt | (in the test situation) | 15:47 |
| bauzas | throw me tomatoes if you wish | 15:47 |
| cdent | melwitt: the tests all end up getting None instead of the desire result | 15:48 |
| bauzas | dansmith: mriedem: stephenfin: others: it'll also be a backport for Queens | 15:48 |
| *** chyka has joined #openstack-nova | 15:48 | |
| cdent | an invalid header operates as basically a header with no values | 15:48 |
| melwitt | okay. I thought the lack of 'best_match' might have been because an invalid header was created. ignore me | 15:48 |
| *** ragiman has quit IRC | 15:48 | |
| cdent | melwitt: ah, also: 1.1 is invalid too | 15:48 |
| cdent | the valid range is 0 to 1 | 15:49 |
| melwitt | oh, I had no idea | 15:49 |
| cdent | I can update the commit message to make that more clear? | 15:49 |
| *** tbachman has quit IRC | 15:49 | |
| melwitt | meh it's fine. I was just curious when I saw it | 15:49 |
| cdent | ✔ | 15:49 |
| *** test222__ has quit IRC | 15:51 | |
| *** test222__ has joined #openstack-nova | 15:51 | |
| *** munimehan has joined #openstack-nova | 15:52 | |
| *** itlinux has joined #openstack-nova | 15:54 | |
| *** felipemonteiro has joined #openstack-nova | 15:54 | |
| *** lpetrut has quit IRC | 15:55 | |
| *** belmoreira has quit IRC | 15:56 | |
| *** pcaruana has quit IRC | 15:57 | |
| *** tbachman has joined #openstack-nova | 15:57 | |
| *** belmoreira has joined #openstack-nova | 15:58 | |
| *** pcaruana has joined #openstack-nova | 15:59 | |
| *** felipemonteiro_ has joined #openstack-nova | 15:59 | |
| *** belmoreira has quit IRC | 16:02 | |
| *** ildikov_ has joined #openstack-nova | 16:03 | |
| *** khappone_ has joined #openstack-nova | 16:03 | |
| *** felipemonteiro has quit IRC | 16:03 | |
| *** breton__ has joined #openstack-nova | 16:05 | |
| jaypipes | mriedem, cdent: for the api-ref, what's the process for changing the documentation for a particular qstring parameter when that parameter was added in a prior microversion? | 16:06 |
| jaypipes | mriedem, cdent: ref this patch: https://review.openstack.org/#/c/561315/ | 16:07 |
| efried | jaypipes: In this case, I would add to the existing parameter entry. Let me find an example... | 16:08 |
| jaypipes | mriedem, cdent: I see existing things in the api-ref like resource_provider_generation_1_19, etc. but is there a magic incantation to show a different description for a parameter once a specific microversion is reached? | 16:08 |
| *** pcaruana has quit IRC | 16:08 | |
| cdent | min_version | 16:08 |
| efried | jaypipes: What do you mean "reached"? | 16:08 |
| *** andreaf_ has joined #openstack-nova | 16:09 | |
| *** tv1 has joined #openstack-nova | 16:09 | |
| jaypipes | efried: sorry, I'm having trouble explaining this.. | 16:09 |
| efried | jaypipes: But you're talking about member_of behaving differently at version Y than version X | 16:09 |
| *** links has quit IRC | 16:09 | |
| *** kencjohnston has joined #openstack-nova | 16:09 | |
| cdent | but what efried is saying is generally true for cases where the parameter is already around: add to the description "in microversion x you can do y" | 16:09 |
| efried | https://developer.openstack.org/api-ref/placement/#list-allocation-candidates - see the `required` option. | 16:09 |
| jaypipes | efried, cdent: yeah, what you just said eric :) | 16:09 |
| *** jamiec_ has joined #openstack-nova | 16:09 | |
| *** yamamoto has joined #openstack-nova | 16:10 | |
| efried | jaypipes: `required` uses both min_version (1.17) and an inline note about the additional functionality in 1.22. | 16:10 |
| *** SamYaple has joined #openstack-nova | 16:10 | |
| *** andreaf has quit IRC | 16:10 | |
| *** ildikov has quit IRC | 16:10 | |
| *** jamiec has quit IRC | 16:10 | |
| *** kencjohnston_ has quit IRC | 16:10 | |
| *** breton has quit IRC | 16:10 | |
| *** khappone has quit IRC | 16:10 | |
| *** Kvisle has quit IRC | 16:10 | |
| efried | jaypipes: So member_of will be similar. min_version 1.3, then new functionality in 1.2x | 16:10 |
| *** ildikov_ is now known as ildikov | 16:10 | |
| *** SamYaple has quit IRC | 16:10 | |
| jaypipes | efried: gotcha. inline note in the description field, then? | 16:10 |
| efried | jaypipes: Yup | 16:11 |
| *** andreaf_ is now known as andreaf | 16:11 | |
| *** sahid has quit IRC | 16:11 | |
| jaypipes | efried: ok, thank you. | 16:12 |
| mriedem | i've seen it both ways, | 16:12 |
| *** bandini has quit IRC | 16:12 | |
| mriedem | but yeah usually if the type doesn't change, we'd just add something to the parameter description saying, "starting with x, you can do foobars" | 16:13 |
| efried | jaypipes: allocation_candidates_required and resource_provider_required_query are the ones cdent updated for forbidden traits. | 16:13 |
| mriedem | in 2.53 we changed the id field in os-services and os-hypervisors from an integer to a string (uuid) so in that case we have 2 parameters in the table, one capped at 2.52 and one new for 2.53 | 16:13 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: fix hard reboot issue with mdevs https://review.openstack.org/564257 | 16:13 |
| mriedem | https://developer.openstack.org/api-ref/compute/#id377 | 16:14 |
| *** cfriesen has joined #openstack-nova | 16:14 | |
| bauzas | mriedem: thanks for the quick review on https://review.openstack.org/564257, new patch is up | 16:15 |
| *** bandini has joined #openstack-nova | 16:15 | |
| * bauzas goes AWOL for fighting Thanos | 16:15 | |
| *** yamamoto has quit IRC | 16:15 | |
| mriedem | bauzas: i just -1ed it again :) | 16:16 |
| mriedem | i'm going to crack down on your usage of "that" | 16:17 |
| mriedem | it's gotten out of hand | 16:17 |
| jaypipes | mriedem: that is indeed that case. | 16:17 |
| jaypipes | mriedem: and thx for the example on the api-ref. appreciated! | 16:17 |
| *** do3meli has quit IRC | 16:18 | |
| *** sean-k-mooney[m] has joined #openstack-nova | 16:19 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | 16:23 |
| *** jaosorior has quit IRC | 16:25 | |
| *** felipemonteiro_ has quit IRC | 16:27 | |
| *** felipemonteiro_ has joined #openstack-nova | 16:27 | |
| *** damien_r has quit IRC | 16:29 | |
| *** sree has quit IRC | 16:30 | |
| *** lucasagomes is now known as lucas-afk | 16:31 | |
| *** dpawlik has joined #openstack-nova | 16:33 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Bump pypowervm minimum to 1.1.15 https://review.openstack.org/564276 | 16:35 |
| efried | edmondsw, esberglu: ^ | 16:37 |
| *** dpawlik has quit IRC | 16:37 | |
| *** QianYu has quit IRC | 16:38 | |
| *** gjayavelu has joined #openstack-nova | 16:38 | |
| openstackgerrit | Merged openstack/nova-specs master: fix blueprint related to the spec overhead-pin-set https://review.openstack.org/561916 | 16:41 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | 16:46 |
| *** slaweq has quit IRC | 16:48 | |
| *** itlinux has quit IRC | 16:49 | |
| *** amoralej is now known as amoralej|off | 16:51 | |
| *** yamahata has quit IRC | 16:54 | |
| *** coreycb has quit IRC | 16:57 | |
| *** coreycb has joined #openstack-nova | 16:58 | |
| *** slaweq has joined #openstack-nova | 16:58 | |
| openstackgerrit | Merged openstack/nova master: Fix invalid UUIDs in test https://review.openstack.org/564190 | 17:01 |
| *** lpetrut has joined #openstack-nova | 17:02 | |
| *** catmando has quit IRC | 17:02 | |
| *** r-daneel_ has joined #openstack-nova | 17:02 | |
| *** catmando has joined #openstack-nova | 17:03 | |
| *** derekh has quit IRC | 17:03 | |
| *** mdnadeem has quit IRC | 17:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Wait for network-vif-plugged before starting live migration https://review.openstack.org/558001 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | 17:05 |
| *** r-daneel has quit IRC | 17:05 | |
| *** r-daneel_ is now known as r-daneel | 17:05 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 17:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: fix hard reboot issue with mdevs https://review.openstack.org/564257 | 17:06 |
| *** efried has quit IRC | 17:07 | |
| *** links has joined #openstack-nova | 17:08 | |
| *** fragatina has quit IRC | 17:09 | |
| *** links has quit IRC | 17:09 | |
| *** itlinux has joined #openstack-nova | 17:09 | |
| *** itlinux has quit IRC | 17:10 | |
| *** AlexeyAbashkin has quit IRC | 17:11 | |
| *** yamamoto has joined #openstack-nova | 17:11 | |
| *** jpena is now known as jpena|off | 17:12 | |
| *** itlinux has joined #openstack-nova | 17:12 | |
| *** mgoddard has quit IRC | 17:13 | |
| *** edmondsw has quit IRC | 17:15 | |
| *** yamamoto has quit IRC | 17:16 | |
| *** belmoreira has joined #openstack-nova | 17:20 | |
| *** pcaruana has joined #openstack-nova | 17:20 | |
| *** moshele has joined #openstack-nova | 17:26 | |
| *** yamahata has joined #openstack-nova | 17:27 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 17:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | 17:28 |
| *** evin has joined #openstack-nova | 17:34 | |
| *** fragatina has joined #openstack-nova | 17:36 | |
| *** fragatina has quit IRC | 17:36 | |
| *** fragatina has joined #openstack-nova | 17:36 | |
| *** Tom-Tom has joined #openstack-nova | 17:42 | |
| *** sambetts is now known as sambetts|afk | 17:43 | |
| *** itlinux has quit IRC | 17:43 | |
| openstackgerrit | Merged openstack/nova master: Address issues raised in adding member_of to GET /a-c https://review.openstack.org/554357 | 17:43 |
| *** dtantsur is now known as dtantsur|afk | 17:43 | |
| *** ssurana has joined #openstack-nova | 17:47 | |
| esberglu | mriedem: Was working with efried an we aren't sure how this is working for the ironic driver | 17:49 |
| esberglu | https://review.openstack.org/#/c/526094/46/nova/virt/powervm/driver.py@545 | 17:49 |
| *** r-daneel has quit IRC | 17:49 | |
| *** r-daneel has joined #openstack-nova | 17:49 | |
| esberglu | When we get the bdm from the list of bdms it is regular dict | 17:49 |
| esberglu | We are doing the same thing as ironic | 17:50 |
| esberglu | Take the block_device_info (passed into spawn) and run block_device_info_get_mapping to get bdms | 17:50 |
| esberglu | Then loop through them | 17:50 |
| *** edmondsw has joined #openstack-nova | 17:51 | |
| esberglu | Not sure what I'm missing, but I thought the bdm was supposed to be a DriverVolumeBlockDevice there | 17:52 |
| *** hemna_ has joined #openstack-nova | 17:52 | |
| esberglu | Here's what I'm actually seeing for the bdm at that point | 17:53 |
| esberglu | http://paste.openstack.org/show/719946/ | 17:53 |
| *** tssurya has quit IRC | 17:54 | |
| *** mdbooth_ has quit IRC | 17:55 | |
| mriedem | esberglu: you have to rebase on top of efried's patch for the is_volume thing | 17:55 |
| *** edmondsw has quit IRC | 17:55 | |
| mriedem | https://review.openstack.org/#/c/564017/ | 17:55 |
| mriedem | oh nvm i see what you're doing | 17:56 |
| esberglu | mriedem: I've tried both with efrieds patch (bdm.is_volume) and without it (bdm._bdm_obj.is_volume) | 17:56 |
| esberglu | Neither work in my test env. | 17:56 |
| mriedem | are the unit tests using a list of DriverVolumeBlockDevice objects? | 17:57 |
| esberglu | mriedem: yes | 17:57 |
| esberglu | mriedem: https://review.openstack.org/#/c/526094/46/nova/tests/unit/virt/powervm/test_driver.py@487 | 17:57 |
| esberglu | But it seems that we aren't getting a list of DriverVolumeBlockDevice objects live, just a list of dicts | 17:58 |
| mriedem | well DriverVolumeBlockDevice is a dict | 17:58 |
| mriedem | and it proxies through the special attributes for the wrapped bdm object | 17:59 |
| *** edmondsw has joined #openstack-nova | 17:59 | |
| mriedem | i see the unit tests are passing on your change.. | 17:59 |
| *** edmondsw has quit IRC | 18:00 | |
| *** belmoreira has quit IRC | 18:00 | |
| *** priteau has quit IRC | 18:00 | |
| *** itlinux has joined #openstack-nova | 18:00 | |
| esberglu | mriedem: Yeah, which is why it seems that we are getting something other than DriverVolumeBlockDevice live | 18:01 |
| mriedem | you powervm guys need to stop saying "live" | 18:01 |
| esberglu | *in my test environment :) | 18:02 |
| *** edmondsw has joined #openstack-nova | 18:04 | |
| mriedem | if only the 3rd party ci could test volume operations.... | 18:05 |
| *** gjayavelu has quit IRC | 18:07 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | 18:09 |
| mriedem | esberglu: i pulled down efried's change, and then your change on top of it, and changed bdm._bdm_obj.is_volume to bdm.is_volume and the unit tests passed | 18:10 |
| mriedem | so i'm not sure what is different about your test environment | 18:11 |
| mriedem | but either your test env is wrong, or the unit tests aren't actually validating this correctly | 18:11 |
| *** yamamoto has joined #openstack-nova | 18:12 | |
| esberglu | mriedem: It seems to be something with a test env. Otherwise this would be broken for ironic too. | 18:13 |
| esberglu | But like I said, we are running the exact same code to extract the bdm the they are | 18:13 |
| mriedem | yeah i see that | 18:13 |
| esberglu | Is there anything that could cause the block_device_info passed into spawn() to be different | 18:13 |
| *** efried has joined #openstack-nova | 18:13 | |
| *** yamamoto has quit IRC | 18:18 | |
| *** kevinbenton has joined #openstack-nova | 18:18 | |
| *** kevinbenton_ has quit IRC | 18:22 | |
| esberglu | mriedem: ^? | 18:23 |
| mriedem | don't think so | 18:24 |
| esberglu | efried: Yeah waiting for a reply | 18:24 |
| mriedem | esberglu: spawn() gets the result of this https://github.com/openstack/nova/blob/936695221e7c22546cc09f0505a063744c1d38a2/nova/compute/manager.py#L2191 | 18:25 |
| *** gjayavelu has joined #openstack-nova | 18:25 | |
| mriedem | https://github.com/openstack/nova/blob/936695221e7c22546cc09f0505a063744c1d38a2/nova/compute/manager.py#L1563 | 18:25 |
| mriedem | https://github.com/openstack/nova/blob/936695221e7c22546cc09f0505a063744c1d38a2/nova/virt/driver.py#L37 | 18:25 |
| mriedem | ^ takes a BlockDeviceMappingList and transforms the list into DriverVolumeBlockDevice objects | 18:26 |
| *** READ10 has quit IRC | 18:26 | |
| esberglu | efried: You have any ideas here? We're UTing with DriverVolumeBlockDevice objects, which are able to access the necessary fields | 18:27 |
| efried | mriedem: What does "live" mean to you? To me it means "not in a test suite". It doesn't necessarily imply "production". | 18:27 |
| mriedem | beyond that band from the 90s | 18:27 |
| mriedem | ? | 18:27 |
| mriedem | or frampton | 18:27 |
| esberglu | And we should be getting DriverVolumeBlockDevice objects based on the last two links | 18:28 |
| esberglu | In the live environment | 18:28 |
| efried | esberglu: Yes, I agree. | 18:28 |
| esberglu | In the test env :) | 18:28 |
| efried | (including with your use of "live") | 18:28 |
| *** dougshel_ has joined #openstack-nova | 18:30 | |
| *** dougshelley66 has quit IRC | 18:32 | |
| *** tssurya has joined #openstack-nova | 18:34 | |
| *** ttsiouts_ has joined #openstack-nova | 18:35 | |
| *** efried[m] has joined #openstack-nova | 18:35 | |
| *** calebb has quit IRC | 18:37 | |
| mriedem | esberglu: efried: i have no problems with these objects using efried's change http://paste.openstack.org/show/719952/ | 18:37 |
| mriedem | >>> type(bdm_obj) | 18:38 |
| mriedem | <class 'nova.objects.block_device.BlockDeviceMapping'> | 18:38 |
| mriedem | >>> type(virt_bdm) | 18:38 |
| mriedem | <class 'nova.virt.block_device.DriverSnapshotBlockDevice'> | 18:38 |
| *** calebb has joined #openstack-nova | 18:38 | |
| efried | mriedem: What, you're running on a real POWER system with NovaLink? | 18:38 |
| *** arvindn05 has quit IRC | 18:38 | |
| efried | mriedem: This is what we mean by "live" :P | 18:38 |
| efried | I think esberglu's problem was found when running in such an environment. | 18:39 |
| esberglu | efried: mriedem: Correct | 18:39 |
| efried | Though I'm getting skeptical | 18:39 |
| efried | ...that pdb was actually telling you the right thing when you asked it `whatis` | 18:39 |
| cdent | why have a power system when you can have a POWER system? | 18:40 |
| efried | not helping | 18:40 |
| mriedem | efried: yeah i still have a tunnel into ibm | 18:40 |
| edleafe | cdent: STOP SHOUTING | 18:41 |
| mriedem | maybe you've got some stale pyc or pyo files or something, idk how your setup your test environments | 18:41 |
| mriedem | *you setup | 18:41 |
| mriedem | anywho, i don't even know if we should move forward with this if it can't get CI testing | 18:41 |
| mriedem | btw, what is an SSP cinder driver? | 18:42 |
| mriedem | what is SSP again? | 18:42 |
| efried | Shared Storage Pools | 18:42 |
| mriedem | super serious power | 18:42 |
| mriedem | oh | 18:42 |
| efried | (as opposed to shared storage pools, cdent) | 18:42 |
| efried | A VIOS cluster-based distributed storage thing. | 18:43 |
| mriedem | i do remember the shit stain that is trying to do CI with a v7k | 18:43 |
| mriedem | it would brick at least once a week, with synchronous CI job runs no less | 18:43 |
| *** pchavva has quit IRC | 18:43 | |
| mriedem | enterprise! | 18:43 |
| mriedem | so is a SSP cinder driver in the future? | 18:44 |
| efried | Of all the problems we have with our CI, I don't think our SAN bricking is one of them. esberglu True? | 18:44 |
| esberglu | yeah | 18:44 |
| efried | mriedem: SSP cinder is something we've played with and partially proposed in the past, but haven't (yet) followed through with. | 18:44 |
| edmondsw | mriedem ignore the SSP comment... that doesn't really relate here | 18:45 |
| edmondsw | that is a totally different volume driver that would also use vSCSI technology | 18:45 |
| mriedem | let it be known i am getting it from all the IBM e's now | 18:45 |
| edmondsw | but that would be vSCSI SSP, not vSCSI FC, which is this commit | 18:45 |
| edmondsw | lol | 18:45 |
| mriedem | in both situation and build, i think it's fair to say i'm the guy in the middle here http://img.wennermedia.com/social/the-new-day-wwe-smackdown-tag-team-champs-43c77d8f-41a5-43fb-b6c9-9f629a507f3c.jpg | 18:47 |
| *** itlinux has quit IRC | 18:47 | |
| edmondsw | mriedem the resemblance is uncanny | 18:47 |
| smcginnis | Not the ref? | 18:48 |
| *** ttsiouts_ has quit IRC | 18:48 | |
| edmondsw | mriedem we agreed to proceed with vSCSI in nova without CI back in Denver. What changed? | 18:49 |
| *** moshele has quit IRC | 18:50 | |
| mriedem | idk, i'm not ptl anymore so i can push back on stuff now? | 18:50 |
| edmondsw | ha | 18:50 |
| dansmith | I don't remember agreeing to that, | 18:50 |
| dansmith | potentially because I was disinterested in general | 18:50 |
| dansmith | but I think it's kinda crazy to be lacking that | 18:50 |
| *** diga has joined #openstack-nova | 18:51 | |
| dansmith | in case anyone cares what I think :) | 18:51 |
| mriedem | it would be one thing if this was a weird api that is seldom used or weird config to set it up, like nfv stuff, | 18:51 |
| edmondsw | I'll try to dig into what's keeping us from doing vSCSI in CI and pick away at it, but we're at the 11th hour here... seems pretty harsh to hold it up now on that grounds | 18:51 |
| mriedem | but volume attach/detach is pretty basic | 18:51 |
| mriedem | i haven't -2d this | 18:51 |
| mriedem | just raising it | 18:51 |
| edmondsw | fair | 18:51 |
| edmondsw | dansmith you were there, but didn't say anything :) | 18:52 |
| mriedem | also, i'd say we're at the 4pm early bird special hour | 18:52 |
| mriedem | aka jaypipes' dinner time | 18:52 |
| dansmith | edmondsw: any words written down to validate that | 18:52 |
| dansmith | as a formal decision? | 18:52 |
| edmondsw | mriedem this was slated for Queens, only moved to Rocky because it wasn't reviewed in time | 18:52 |
| mriedem | L315 https://etherpad.openstack.org/p/nova-ptg-queens | 18:52 |
| smcginnis | The cinder video recordings have come in handy on more than one occasion for things like this. | 18:52 |
| *** dpawlik has joined #openstack-nova | 18:53 | |
| mriedem | "CI would not be running with this because CI with FC is hard." | 18:53 |
| edmondsw | dansmith I think this was called out in the approved spec, I'll go double check | 18:53 |
| mriedem | i'm kind of hurt that i didn't get any kudos for the jay + FL burn | 18:54 |
| *** sridharg has quit IRC | 18:54 | |
| smcginnis | I laughed. | 18:54 |
| edleafe | *All* of IBM's e's?? [t 2CNr] | 18:54 |
| purplerbot | <mriedem> let it be known i am getting it from all the IBM e's now [2018-04-25 18:45:19.088382] [n 2CNr] | 18:54 |
| edleafe | mriedem: I've been behaving | 18:54 |
| mriedem | edleafe: oh sorry | 18:54 |
| mriedem | IBM (power) e's | 18:55 |
| *** sree has joined #openstack-nova | 18:55 | |
| *** arvindn05 has joined #openstack-nova | 18:55 | |
| jaypipes | mriedem: :) | 18:55 |
| edleafe | mriedem: yeah, I'm not that POWERful at IBM | 18:55 |
| mriedem | edmondsw: anyway, i'll defer to melwitt on the CI situation | 18:56 |
| mriedem | i'm not blocking, but not happy about it either | 18:56 |
| edmondsw | mriedem honestly, I'm not happy about it myself | 18:56 |
| mriedem | i'd be happy to be unhappy together | 18:57 |
| edmondsw | and I will do what I can to see what we can do there | 18:57 |
| edmondsw | wfm :) | 18:57 |
| *** pchavva has joined #openstack-nova | 18:57 | |
| *** dpawlik has quit IRC | 18:57 | |
| *** FL1SK has quit IRC | 18:58 | |
| openstackgerrit | Zack Cornelius proposed openstack/nova-specs master: Libvirt file backed memory https://review.openstack.org/563704 | 18:59 |
| *** moshele has joined #openstack-nova | 18:59 | |
| *** sree has quit IRC | 18:59 | |
| edmondsw | dansmith doesn't look like the approved queens spec called out lack of CI for vSCSI. I know we discussed at the PTG before the spec was approved, but I think it was approved pretty quickly there before we updated it to call that out | 18:59 |
| dansmith | ack | 19:00 |
| mriedem | might it be possible to have an on-demand job for powervm+volume stuff? | 19:01 |
| mriedem | then you can run it on patches when asked at least as a bridge to something more automated? | 19:01 |
| *** moshele has quit IRC | 19:02 | |
| cdent | efried[m]: ping from nova? | 19:02 |
| mriedem | lbragstad: for the policy in code goal, did you have any nice 7 step guides for teams to do that with the latest oslo.policy tricks? or for placement policy-in-code, should i just continue to cludge the existing nova policy code for placement? | 19:02 |
| edmondsw | mriedem worth looking into, sure | 19:02 |
| lbragstad | i laid out some of the steps in the goal | 19:02 |
| lbragstad | but if they aren't clear i can work on another document | 19:03 |
| lbragstad | or clean those up, because that's probably pretty important | 19:03 |
| efried | cdent: Nothing. | 19:03 |
| lbragstad | all i see is the completion criteria https://governance.openstack.org/tc/goals/queens/policy-in-code.html#completion-criteria | 19:03 |
| *** efried[m] has left #openstack-nova | 19:03 | |
| mriedem | lbragstad: yeah just found that | 19:04 |
| mriedem | lbragstad: np, i'll go back to my old patch and see what i was doing wrong | 19:04 |
| lbragstad | mriedem: i can try and propose a patch to oslo.policy that walks through how start fresh with using those objects if that would be helpful | 19:05 |
| mriedem | up to you | 19:05 |
| mriedem | i think we (nova) have to decide some stuff like would we have /etc/nova/policy.yaml include placement stuff, or /etc/placement/policy.yaml | 19:06 |
| mriedem | i'd prefer the latter | 19:06 |
| mriedem | but not sure how possible that is when the code is in the same repo | 19:06 |
| mriedem | should just be extra data files for the setup.cfg so i don't know why it would be a problem | 19:06 |
| *** jchhatba_ has quit IRC | 19:08 | |
| edmondsw | mriedem separate policy.yaml for placement should be doable | 19:10 |
| melwitt | edmondsw, mriedem, dansmith: I think the volume tests should be enabled in CI. is there some reason they aren't? | 19:10 |
| dansmith | melwitt: "it's hard" | 19:10 |
| dansmith | I'll also say I think that tempest validation being disabled is a problem, | 19:10 |
| dansmith | related but not strictly to volume CI | 19:11 |
| melwitt | the ssh validation? that should be enabled too | 19:11 |
| dansmith | no idea how that got ignored | 19:11 |
| dansmith | yeah, ssh validation | 19:11 |
| *** SamYaple has joined #openstack-nova | 19:11 | |
| *** SamYaple has quit IRC | 19:11 | |
| lbragstad | mriedem: i think there is a way to split up policy data across multiple configs | 19:11 |
| dansmith | without ssh validation, I think working CI is mostly a charade | 19:11 |
| dansmith | "oh look, we can create instances that may or may not be steaming piles of unworking sh*t" | 19:12 |
| *** tbachman has quit IRC | 19:12 | |
| edmondsw | melwitt with our current hardware, it just wouldn't work. If we can get more hardware, there are still some technical challenges with the way that hardware works (limited simultaneous connections, how to detect and cleanup stale volumes from previous runs) | 19:12 |
| lbragstad | mriedem: https://bugs.launchpad.net/oslo.policy/+bug/1766953 | 19:12 |
| openstack | Launchpad bug 1766953 in oslo.policy "Lacking documentation for new projects using oslo.policy" [Undecided,New] | 19:12 |
| melwitt | with regard to a virt driver, yeah, lack of ssh validation is just testing that nothing prevents the instance from being built, not whether the instance actually works | 19:12 |
| mriedem | edmondsw: "limited simultaneous connections" can be solved with (1) run tempest tests in serial and (2) limit the set of tests you run and (3) make it an on-demand job to start | 19:13 |
| edmondsw | mriedem I meant across simultaneous CI runs | 19:13 |
| dansmith | nova is about self-service dynamic resources.. if you can't do that, then, uh... | 19:13 |
| edmondsw | but yeah, on-demand job would address that | 19:13 |
| *** imacdonn has quit IRC | 19:14 | |
| *** yamamoto has joined #openstack-nova | 19:14 | |
| *** FL1SK has joined #openstack-nova | 19:14 | |
| edmondsw | going into a mtg... | 19:14 |
| *** imacdonn has joined #openstack-nova | 19:14 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Make sure that we have usable input for graphical console https://review.openstack.org/564320 | 19:14 |
| mriedem | lbragstad: thanks | 19:14 |
| melwitt | yeah, I guess I don't think we should have something in-tree that doesn't have CI covering its basic functionality | 19:15 |
| edmondsw | so esberglu I think we need to rebase the rest of the PowerVM commits, moving vSCSI to the end of the series, so this doesn't block everything | 19:18 |
| edmondsw | efried ^ | 19:18 |
| dansmith | melwitt: agree | 19:18 |
| edmondsw | esberglu and we need to start working on an on-demand CI job for testing vSCSI FC | 19:19 |
| *** diga has quit IRC | 19:19 | |
| esberglu | edmondsw: ok | 19:19 |
| lbragstad | jaypipes: re the oslo.context stuff you reviewed - https://review.openstack.org/#/c/564072/ should make that easier for nova to consume | 19:19 |
| *** yamamoto has quit IRC | 19:20 | |
| melwitt | I think y'all also need to get the CI running with [validation]run_validation = True in tempest.conf, unrelated to the volumes stuff | 19:20 |
| edmondsw | melwitt I'm not sure we can. It will take minutes, probably close to 10, for the VM to ping. | 19:22 |
| melwitt | :\ | 19:23 |
| edmondsw | yeah | 19:23 |
| esberglu | edmondsw: melwitt: Yeah this is something we've discussed for CI many times, but the runtimes will explode | 19:23 |
| dansmith | edmondsw: minutes to bring up an instance to pingable state? | 19:23 |
| edmondsw | dansmith yes | 19:24 |
| dansmith | edmondsw: how is that useful for an elastic sort of situation? :) | 19:24 |
| edmondsw | to Power customers, 10 minutes sounds very fast :) | 19:25 |
| dansmith | edmondsw: hah, yeah, I know about power, remember, but doesn't stop me from making fun | 19:25 |
| edmondsw | sure :) | 19:25 |
| dansmith | especially in an "is this relevant at all" sort of situation | 19:25 |
| edmondsw | again, I don't like it, but... | 19:26 |
| mriedem | again, you could have a separate job that just runs something like scenario tests in serial | 19:26 |
| edmondsw | fair | 19:26 |
| mriedem | i don't think the scenario tests even use the run_validation flag | 19:26 |
| mriedem | they just assume that you can ssh into the guest | 19:26 |
| mriedem | otherwise they aren't useful scenarios | 19:26 |
| edmondsw | I don't know that we've considered on-demand CI jobs before | 19:27 |
| mriedem | the scenario-based one might not need to be on-demand | 19:27 |
| mriedem | you'd have to see which tests make sense, and if you only run like 6 tests, then it's not bad | 19:27 |
| edmondsw | mriedem I'm not quite following... what scenario do you have in mind? | 19:27 |
| mriedem | https://github.com/openstack/tempest/tree/master/tempest/scenario | 19:28 |
| melwitt | this is the basic functionality scenario test that verifies ssh and config drive https://github.com/openstack/tempest/blob/master/tempest/scenario/test_server_basic_ops.py#L51 | 19:28 |
| mriedem | stuff like test_minimum_basic | 19:28 |
| edmondsw | will look | 19:28 |
| mriedem | test_server_basic_ops | 19:28 |
| edmondsw | esberglu fyi ^ | 19:28 |
| mriedem | for stuff in that requires volumes, we could fix those in tempest if the env doesn't have cinder | 19:28 |
| mriedem | actually that's already handled https://github.com/openstack/tempest/blob/master/tempest/scenario/test_minimum_basic.py#L102 | 19:29 |
| mriedem | @utils.services('compute', 'volume', 'image', 'network') | 19:29 |
| mriedem | so if the volume service isn't enabled in tempest.conf, that test is skipped | 19:29 |
| mriedem | should totally be able to do this though https://github.com/openstack/tempest/blob/master/tempest/scenario/test_server_basic_ops.py#L125 | 19:29 |
| mriedem | create a server with a keypair and config drive, ssh into it, done | 19:30 |
| lbragstad | mriedem: was this the policy+placement patch you were talking about? | 19:33 |
| lbragstad | https://review.openstack.org/#/c/524425/ | 19:33 |
| melwitt | yeah. I'd personally want to hold off on merging the new driver patches until test_server_basic_ops is running in CI | 19:34 |
| melwitt | with ssh validation enabled | 19:34 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot https://review.openstack.org/543023 | 19:36 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | 19:36 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 19:36 |
| edmondsw | melwitt even things that wouldn't have anything to do with that, like snapshot? | 19:36 |
| *** lpetrut has quit IRC | 19:36 | |
| melwitt | edmondsw: yeah, it seems like verifying the booted instances was missed for whatever reason in the past, should fix that before adding more stuff I would think | 19:37 |
| dansmith | we hold everyone else to that bar, not sure why it should be a surprise, | 19:37 |
| dansmith | nor why it was skipped | 19:37 |
| *** itlinux has joined #openstack-nova | 19:37 | |
| esberglu | edmondsw: efried: ^ Commit chain is up without vSCSI. You're votes are still on DiskAdapter and Localdisk. Snapshot lost them in a previous manual rebase | 19:37 |
| esberglu | your | 19:37 |
| mriedem | lbragstad: yeah | 19:37 |
| efried | esberglu: snapshot re-reviewed. | 19:43 |
| *** itlinux has quit IRC | 19:47 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:48 | |
| *** sree has joined #openstack-nova | 19:48 | |
| *** AlexeyAbashkin has quit IRC | 19:52 | |
| *** sree has quit IRC | 19:53 | |
| *** pchavva has quit IRC | 19:54 | |
| *** dklyle has joined #openstack-nova | 19:54 | |
| *** gjayavelu has quit IRC | 19:54 | |
| openstackgerrit | Julia Kreger proposed openstack/nova master: ironic: add instance_uuid before any other spawn activity https://review.openstack.org/563722 | 19:55 |
| *** AlexeyAbashkin has joined #openstack-nova | 19:57 | |
| *** shaohe_feng has quit IRC | 19:57 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: resource requests for nested providers https://review.openstack.org/554529 | 19:58 |
| *** hemna_ has quit IRC | 19:58 | |
| *** wolverineav has quit IRC | 20:00 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | 20:00 |
| *** wolverineav has joined #openstack-nova | 20:00 | |
| *** tbachman has joined #openstack-nova | 20:02 | |
| *** moshele has joined #openstack-nova | 20:02 | |
| *** tbachman has quit IRC | 20:03 | |
| *** wolverineav has quit IRC | 20:05 | |
| *** liverpooler has quit IRC | 20:05 | |
| *** moshele has quit IRC | 20:06 | |
| *** dklyle has quit IRC | 20:06 | |
| *** edmondsw has quit IRC | 20:12 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use inspect.signature in nova.utils.expects_func_args https://review.openstack.org/564333 | 20:14 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use inspect.signature in nova.network.base_api.refresh_cache https://review.openstack.org/564334 | 20:14 |
| *** edmondsw has joined #openstack-nova | 20:15 | |
| *** tbachman has joined #openstack-nova | 20:15 | |
| *** yamamoto has joined #openstack-nova | 20:15 | |
| *** FL1SK has quit IRC | 20:16 | |
| *** evin has quit IRC | 20:19 | |
| *** tbachman has quit IRC | 20:20 | |
| *** edmondsw has quit IRC | 20:20 | |
| *** Tom-Tom has quit IRC | 20:20 | |
| *** yamamoto has quit IRC | 20:21 | |
| mriedem | yikun_: at this point, you should probably just incorporate https://review.openstack.org/#/c/563802/ into https://review.openstack.org/#/c/561819/ and https://review.openstack.org/#/c/557145/ respectively | 20:22 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | 20:22 |
| mriedem | rather than a never-ending series of "address nits" patches at the end | 20:22 |
| *** gjayavelu has joined #openstack-nova | 20:23 | |
| openstackgerrit | Merged openstack/nova master: Update docs for [keystone_authtoken] changes since Queens https://review.openstack.org/562812 | 20:25 |
| openstackgerrit | Merged openstack/nova master: Make accept-language tests work with webob 1.8.x https://review.openstack.org/564255 | 20:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Update docs for [keystone_authtoken] changes since Queens https://review.openstack.org/564336 | 20:26 |
| *** AlexeyAbashkin has quit IRC | 20:27 | |
| melwitt | yikun_: seconded, especially the reno update. seems kinda weird to split that up | 20:27 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: resource requests for nested providers https://review.openstack.org/554529 | 20:28 |
| efried | mriedem: Is there a way to elevate the getargspec deprecation warning to error in py3, to prove those two patches you just proposed? | 20:28 |
| *** edmondsw has joined #openstack-nova | 20:28 | |
| mriedem | lbragstad: do you know the answer to this? https://review.openstack.org/#/c/524425/1/nova/api/openstack/placement/policies/base.py | 20:30 |
| mriedem | efried: yeah i think so | 20:31 |
| mriedem | https://docs.python.org/2/library/warnings.html#the-warnings-filter | 20:31 |
| mriedem | https://docs.python.org/2/library/warnings.html#warnings.filterwarnings | 20:33 |
| mriedem | like https://github.com/openstack/nova/blob/6d22567b9445e595f4c55627ea784801585a6e41/nova/tests/fixtures.py#L731 | 20:33 |
| *** edmondsw has quit IRC | 20:33 | |
| mriedem | err the ones below | 20:33 |
| lbragstad | mriedem: i was just digging into that | 20:33 |
| efried | mriedem: Would it be unreasonable to ask you to do that in those? | 20:33 |
| mriedem | efried: i could | 20:33 |
| lbragstad | one sec | 20:34 |
| lbragstad | i want to say the answer is in the NovaKeystoneContext object | 20:34 |
| mriedem | efried: note there is another inspect.getargspec usage in nova/cmd/common.py but it doesn't have any unit testing yet so i haven't tackled that one | 20:34 |
| mriedem | lbragstad: nova.context.RequestContext? | 20:34 |
| *** edmondsw has joined #openstack-nova | 20:34 | |
| *** eharney has quit IRC | 20:34 | |
| mriedem | efried: i'll throw something on top | 20:35 |
| efried | ++ | 20:35 |
| lbragstad | mriedem: first crack at working some documentation into oslo.policy's usage docs for newer services - https://review.openstack.org/#/c/564340/ | 20:36 |
| *** tbachman has joined #openstack-nova | 20:37 | |
| lbragstad | mriedem: maybe - but nova has a special middleware that sits right behind auth_token | 20:37 |
| *** hemna_ has joined #openstack-nova | 20:37 | |
| *** tbachman has quit IRC | 20:37 | |
| lbragstad | it's job is to pull the auth token headers out of the request and generate a context object | 20:37 |
| lbragstad | at least from what i can tell | 20:38 |
| lbragstad | https://github.com/openstack/nova/blob/d124a0ed87cb99a06954ae7f3073cb859aa6808f/etc/nova/api-paste.ini#L80-L81 | 20:38 |
| lbragstad | https://github.com/openstack/nova/blob/d124a0ed87cb99a06954ae7f3073cb859aa6808f/etc/nova/api-paste.ini#L32 | 20:38 |
| *** mgoddard has joined #openstack-nova | 20:38 | |
| *** edmondsw has quit IRC | 20:39 | |
| *** felipemonteiro_ has quit IRC | 20:39 | |
| mriedem | lbragstad: yeah i see it now | 20:40 |
| *** ediardo has joined #openstack-nova | 20:40 | |
| *** tesseract has quit IRC | 20:40 | |
| *** felipemonteiro_ has joined #openstack-nova | 20:40 | |
| mriedem | https://github.com/openstack/nova/blob/d124a0ed87cb99a06954ae7f3073cb859aa6808f/nova/api/auth.py#L72 | 20:40 |
| mriedem | i don't think that has anything to do with rule:admin_api though | 20:41 |
| *** pcaruana has quit IRC | 20:42 | |
| lbragstad | yeah - digging through it and it doesn't look like it | 20:44 |
| lbragstad | my bad | 20:44 |
| lbragstad | it looks like rule:context_is_admin is really just an alias to role:admin | 20:46 |
| lbragstad | https://github.com/openstack/nova/blob/master/nova/policy.py#L173 | 20:47 |
| lbragstad | which is apparently used in nova's RequestContext https://github.com/openstack/nova/blob/d124a0ed87cb99a06954ae7f3073cb859aa6808f/nova/context.py#L151 | 20:49 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add columns for generation to consumers https://review.openstack.org/557958 | 20:53 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add the Consumer object https://review.openstack.org/561406 | 20:53 |
| *** owalsh_afk is now known as owalsh | 20:53 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add Consumer objects to Allocations https://review.openstack.org/561407 | 20:53 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add a microversion for consumer generation https://review.openstack.org/562000 | 20:53 |
| lbragstad | so - i think the TL;DR is that rule:context_is_admin is used | 20:54 |
| *** edmondsw has joined #openstack-nova | 20:54 | |
| *** dougshel_ has quit IRC | 20:55 | |
| lbragstad | specifically when nova's middleware builds a context object, it'll parse the request environment headers, use oslo.context to get an object, then use oslo.policy's authorize methed (without a target?) to determine if context_is_admin is true | 20:56 |
| lbragstad | based on the alias | 20:56 |
| *** Tom-Tom has joined #openstack-nova | 20:56 | |
| lbragstad | and then you set that to the ctx.is_admin attribute | 20:56 |
| openstackgerrit | Merged openstack/nova master: Functional test: cold migrate to compute down https://review.openstack.org/496280 | 20:58 |
| efried | mriedem: I'm not smart enough to understand why this changes anything: https://review.openstack.org/#/c/563732/2/nova/compute/api.py | 20:59 |
| *** edmondsw has quit IRC | 20:59 | |
| *** gjayavelu has quit IRC | 21:00 | |
| *** edmondsw has joined #openstack-nova | 21:00 | |
| *** Tom-Tom has quit IRC | 21:00 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a warnings filter for inspect.getargspec usage https://review.openstack.org/564343 | 21:01 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | 21:02 |
| mriedem | efried: because before it you could specify bdms without a boot_index | 21:03 |
| efried | mriedem: But those would be excluded from the boot_indexes list, nah? | 21:04 |
| mriedem | right | 21:04 |
| mriedem | for context you need to look at what _validate_bdm used to do https://review.openstack.org/#/c/524208/1/nova/compute/api.py | 21:05 |
| mriedem | if 0 not in boot_indexes or not _subsequent_list(boot_indexes): | 21:05 |
| *** edmondsw has quit IRC | 21:05 | |
| mriedem | mdbooth's change was to clean up and prettify the right side of that conditional | 21:05 |
| mriedem | and b/c we had 0 test coverage for the left side, it was dropped mistakenly | 21:05 |
| lbragstad | mriedem: http://paste.openstack.org/raw/719958/ might be an idea of how to get rid of the context_is_admin alias | 21:06 |
| mriedem | rather than revert that outright, i went with the suggestion from stephenfin in that change to keep the pretty right side, but still enforce the left side | 21:06 |
| efried | mriedem: But range(0) is [] | 21:06 |
| *** edmondsw has joined #openstack-nova | 21:06 | |
| lbragstad | by bumping the processing of "is_admin" up in the chain and actually using the constructor of oslo.contexts RequestContext object | 21:06 |
| lbragstad | (since it supports is_admin) | 21:06 |
| *** cdent has quit IRC | 21:08 | |
| efried | mriedem: So was "0 not in boot_indexes or" supposed to be added back in? | 21:08 |
| mriedem | lbragstad: so that probably lets us drop this https://github.com/openstack/nova/blob/6d22567b9445e595f4c55627ea784801585a6e41/nova/tests/fixtures.py#L743 | 21:09 |
| mriedem | efried: that's essentially what i'm adding back in yes | 21:09 |
| mriedem | without a full revert | 21:09 |
| lbragstad | maybe | 21:09 |
| lbragstad | it looks like nova still uses is_admin | 21:09 |
| lbragstad | on the context object | 21:09 |
| lbragstad | my diff would be a way to remove the extra alias between context_is_admin and role:admin | 21:10 |
| efried | mriedem: okay, but I don't think you are. Because if boot_indexes is [], that `any` will fail. | 21:10 |
| efried | mriedem: | 21:10 |
| efried | In [16]: boot_indexes = [] | 21:10 |
| efried | In [17]: any(x != y for x, y in enumerate(boot_indexes)) | 21:10 |
| efried | Out[17]: False | 21:10 |
| lbragstad | instead, if you're hardcoding operations to a role name, you can check for it in the headers that auth_token gives you and then pass values to RequestContext's constructor directly | 21:11 |
| mriedem | efried: and that's ok if you're not using bdms at all | 21:11 |
| *** edmondsw has quit IRC | 21:11 | |
| lbragstad | but you might be able to remove https://github.com/openstack/nova/blob/master/nova/policy.py#L172-L181 | 21:11 |
| lbragstad | and save an enforcer trip | 21:12 |
| efried | mriedem: Then the commit message isn't right. You're not changing anything logically afaict. | 21:12 |
| *** edmondsw has joined #openstack-nova | 21:12 | |
| mriedem | lbragstad: ok that's a bit over my head atm, since i'm doing a couple of things at once - this seems like something we could do separately and then i could build on it when adding the placement policy stuff | 21:13 |
| mriedem | i'm just unsure of the implications of making that change | 21:13 |
| lbragstad | does placement get context objecst from nova/context? | 21:13 |
| lbragstad | or does it build those on it's own? | 21:13 |
| mriedem | nova.context | 21:14 |
| lbragstad | ok | 21:14 |
| lbragstad | let me try something locally and i'll post a review with my thoughts, that might be easier to follow | 21:14 |
| mriedem | efried: looks like in PS2 i changed something to fix one problem but broke what i was trying to do, so looking at it again | 21:16 |
| *** edmondsw has quit IRC | 21:17 | |
| *** yamamoto has joined #openstack-nova | 21:17 | |
| efried | mriedem: PS1 looks samely broken to me. | 21:17 |
| *** edmondsw has joined #openstack-nova | 21:18 | |
| efried | mriedem: but the test failures are weird. Was there a separate fix for that? | 21:18 |
| mriedem | the billions of test failures in PS1 were because it now made bdms required | 21:19 |
| mriedem | i was fixing that in PS2, but apparently broke the test i was adding | 21:19 |
| mriedem | fixing now | 21:19 |
| mriedem | please hold dear caller | 21:20 |
| *** openstackgerrit has quit IRC | 21:20 | |
| *** edmondsw has quit IRC | 21:23 | |
| *** esberglu has quit IRC | 21:23 | |
| *** yamamoto has quit IRC | 21:23 | |
| *** edmondsw has joined #openstack-nova | 21:24 | |
| *** edmondsw has quit IRC | 21:28 | |
| *** edmondsw has joined #openstack-nova | 21:30 | |
| arvindn05 | while you guys are on the topic of testings....are there any guidelines on test cases that they should test only one scenario?\ | 21:31 |
| arvindn05 | if i have a bunch of tests that i can make in the same test method....is that prefered? | 21:31 |
| arvindn05 | obviously only closely related tests | 21:31 |
| *** openstackgerrit has joined #openstack-nova | 21:31 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix dropped check for boot_index 0 in _validate_bdm https://review.openstack.org/563732 | 21:31 |
| mriedem | arvindn05: it's generally best to split them out into separate test cases | 21:32 |
| mriedem | it's fine to use a common method if necessary with param overrides to control behavior | 21:32 |
| mriedem | unless it gets crazy | 21:32 |
| *** esberglu has joined #openstack-nova | 21:33 | |
| arvindn05 | mriedem: cool... i used that approach...number of lines increased though...hopefully wont scare away potential reviewers :) | 21:34 |
| *** edmondsw has quit IRC | 21:35 | |
| *** mgoddard has quit IRC | 21:35 | |
| *** dave-mcc_ has quit IRC | 21:36 | |
| *** edmondsw has joined #openstack-nova | 21:36 | |
| *** esberglu has quit IRC | 21:38 | |
| *** edmondsw has quit IRC | 21:41 | |
| *** liverpooler has joined #openstack-nova | 21:41 | |
| *** mchlumsky has quit IRC | 21:44 | |
| *** cfriesen has quit IRC | 21:44 | |
| openstackgerrit | Lance Bragstad proposed openstack/nova master: Attempt to simplify elevated authorization https://review.openstack.org/564349 | 21:47 |
| lbragstad | mriedem: ^ | 21:47 |
| *** Tom-Tom has joined #openstack-nova | 21:49 | |
| *** edmondsw has joined #openstack-nova | 21:50 | |
| *** dougshelley66 has joined #openstack-nova | 21:50 | |
| mriedem | thanks | 21:54 |
| *** Tom-Tom has quit IRC | 21:54 | |
| *** edmondsw has quit IRC | 21:55 | |
| *** Guest14047 has quit IRC | 21:56 | |
| *** sdague has quit IRC | 21:57 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | 21:58 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: Object changes for granular https://review.openstack.org/564351 | 21:58 |
| *** tssurya has quit IRC | 22:01 | |
| *** edmondsw has joined #openstack-nova | 22:02 | |
| *** tssurya has joined #openstack-nova | 22:02 | |
| *** edmondsw has quit IRC | 22:07 | |
| *** tssurya has quit IRC | 22:07 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: Object changes for granular https://review.openstack.org/564351 | 22:09 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757 | 22:09 |
| *** jmlowe has quit IRC | 22:09 | |
| *** tlb has joined #openstack-nova | 22:10 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | 22:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | 22:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | 22:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 22:11 |
| *** mriedem has quit IRC | 22:11 | |
| *** swamireddy has quit IRC | 22:13 | |
| *** dave-mccowan has joined #openstack-nova | 22:15 | |
| *** gjayavelu has joined #openstack-nova | 22:15 | |
| *** slaweq has quit IRC | 22:17 | |
| *** threestrands has joined #openstack-nova | 22:17 | |
| *** slaweq has joined #openstack-nova | 22:18 | |
| *** yamamoto has joined #openstack-nova | 22:19 | |
| *** mlavalle has quit IRC | 22:20 | |
| *** slaweq has quit IRC | 22:23 | |
| *** yamamoto has quit IRC | 22:24 | |
| *** FL1SK has joined #openstack-nova | 22:26 | |
| *** swamireddy has joined #openstack-nova | 22:29 | |
| *** tbachman has joined #openstack-nova | 22:33 | |
| *** dave-mccowan has quit IRC | 22:36 | |
| *** tbachman has quit IRC | 22:41 | |
| *** hongbin_ has quit IRC | 22:44 | |
| *** kaisers has quit IRC | 22:47 | |
| *** gyee has quit IRC | 22:48 | |
| *** shaohe_feng has joined #openstack-nova | 22:50 | |
| *** rcernin has joined #openstack-nova | 22:52 | |
| *** edmondsw has joined #openstack-nova | 23:01 | |
| *** felipemonteiro_ has quit IRC | 23:03 | |
| *** kaisers has joined #openstack-nova | 23:03 | |
| *** yamamoto has joined #openstack-nova | 23:09 | |
| *** edmondsw has quit IRC | 23:10 | |
| *** jmlowe has joined #openstack-nova | 23:15 | |
| *** ssurana has quit IRC | 23:19 | |
| *** ssurana has joined #openstack-nova | 23:19 | |
| *** chyka has quit IRC | 23:25 | |
| *** threestrands_ has joined #openstack-nova | 23:35 | |
| *** threestrands has quit IRC | 23:38 | |
| *** tbachman has joined #openstack-nova | 23:42 | |
| *** tbachman_ has joined #openstack-nova | 23:45 | |
| *** efried has quit IRC | 23:47 | |
| *** tbachman has quit IRC | 23:47 | |
| *** tbachman_ is now known as tbachman | 23:47 | |
| *** munimehan has quit IRC | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
