Tuesday, 2018-04-24

*** gyee has quit IRC00:02
alex_xumriedem: yes, it is change the API behavior, do you know what happened now if I didn't specific boot_index?00:02
*** hemna_ has quit IRC00:02
alex_xufor now00:02
*** pcaruana has quit IRC00:02
alex_xuor I will check then when I reach to the office00:04
*** chyka has quit IRC00:11
*** artom_ has joined #openstack-nova00:25
*** hoangcx has joined #openstack-nova00:32
*** tonyb has quit IRC00:33
*** artom_ has quit IRC00:34
*** tonyb has joined #openstack-nova00:35
*** tetsuro has joined #openstack-nova00:36
*** Dinesh_Bhor has joined #openstack-nova00:36
mriedemalex_xu: yeah https://review.openstack.org/#/c/563732/ i have to update that, tomorrow00:36
*** mriedem is now known as mriedem_away00:37
*** gjayavelu has quit IRC00:39
*** namnh has joined #openstack-nova00:42
openstackgerritAdam Harwell proposed openstack/nova stable/pike: Add support for listing hosts in cellv2  https://review.openstack.org/56379700:54
*** mriedem_away has quit IRC01:05
*** phuongnh has joined #openstack-nova01:07
*** hiro-kobayashi has joined #openstack-nova01:09
openstackgerritMerged openstack/nova master: Add CPUWeigher  https://review.openstack.org/37952501:09
openstackgerritMerged openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes  https://review.openstack.org/48499701:09
openstackgerritMerged openstack/nova master: Move some tests into nova.tests.unit.notifications.objects.test_instance  https://review.openstack.org/56279301:10
melwittKevin_Zheng: your blueprint was removed from the review runway today because all of the related code merged. please feel free to add comments to the log area at L144 if you have any comments or feedback about your experience with runways https://etherpad.openstack.org/p/nova-runways-rocky01:11
Kevin_Zhengmelwitt cool, I will01:11
*** yikun has joined #openstack-nova01:13
*** MasterofJOKers has quit IRC01:16
*** MasterofJOKers has joined #openstack-nova01:16
*** yamahata has quit IRC01:26
*** salv-orl_ has joined #openstack-nova01:28
*** salv-orlando has quit IRC01:31
*** hongbin_ has joined #openstack-nova01:32
*** tiendc has joined #openstack-nova01:42
gmannalex_xu: testing in tempest too - https://review.openstack.org/#/c/563801/01:44
*** esberglu has joined #openstack-nova01:53
*** artom_ has joined #openstack-nova01:54
*** phuongnh has quit IRC01:55
*** phuongnh has joined #openstack-nova01:56
*** dougshelley66 has quit IRC01:57
*** fragatina has quit IRC02:02
*** zhaochao has joined #openstack-nova02:05
*** Tom-Tom has joined #openstack-nova02:06
*** artom_ has quit IRC02:10
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Address nits in Iac23a574a05e62a99aab20ffce4265f4fb5a44d9  https://review.openstack.org/56380202:22
*** tomtom001 has quit IRC02:27
*** tomtom001 has joined #openstack-nova02:27
*** fragatina has joined #openstack-nova02:39
*** annp has quit IRC02:42
*** blkart_ has joined #openstack-nova02:42
*** blkart has quit IRC02:43
*** gongysh has joined #openstack-nova02:45
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add snapshot function  https://review.openstack.org/53424002:46
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add power actions  https://review.openstack.org/54334002:46
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add get console output  https://review.openstack.org/54334402:46
*** psachin has joined #openstack-nova02:46
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Address nits in Iac23a574a05e62a99aab20ffce4265f4fb5a44d9  https://review.openstack.org/56380202:47
*** jdillaman has quit IRC02:51
*** yamamoto has quit IRC02:53
*** annp has joined #openstack-nova02:54
*** yamamoto has joined #openstack-nova02:54
*** yamamoto has quit IRC02:59
*** esberglu has quit IRC03:01
*** vladikr has quit IRC03:13
*** vladikr has joined #openstack-nova03:13
*** cfriesen has quit IRC03:13
*** cfriesen has joined #openstack-nova03:14
*** vladikr has quit IRC03:19
*** vladikr has joined #openstack-nova03:19
*** takashin has quit IRC03:24
*** nicolasbock has quit IRC03:26
*** hiro-kobayashi has quit IRC03:35
openstackgerritMichael Still proposed openstack/nova master: Use os.rename, not mv.  https://review.openstack.org/56246303:36
*** Tom-Tom has quit IRC03:38
*** Tom-Tom has joined #openstack-nova03:39
*** lpetrut has joined #openstack-nova03:39
*** Tom-Tom has quit IRC03:43
*** janki has joined #openstack-nova03:44
*** sridharg has joined #openstack-nova03:48
*** hongbin_ has quit IRC03:58
*** lpetrut has quit IRC04:11
*** takashin has joined #openstack-nova04:11
*** evrardjp has quit IRC04:15
*** dklyle has joined #openstack-nova04:17
*** ratailor has joined #openstack-nova04:20
*** ratailor has quit IRC04:21
*** yikun_ has joined #openstack-nova04:23
*** yikun has quit IRC04:25
*** markvoelker has quit IRC04:29
*** ratailor has joined #openstack-nova04:35
*** ratailor has quit IRC04:35
*** dklyle has quit IRC04:37
*** slaweq has joined #openstack-nova04:39
*** janki has quit IRC04:39
*** cfriesen has quit IRC04:43
*** edmondsw has joined #openstack-nova04:43
*** edmondsw_ has joined #openstack-nova04:44
openstackgerritJulia Kreger proposed openstack/nova master: Ironic: Lock the instance if early vif plug  https://review.openstack.org/56371404:45
*** slaweq has quit IRC04:47
*** edmondsw has quit IRC04:48
*** lpetrut has joined #openstack-nova04:58
*** sapd has quit IRC04:59
*** sapd_ has joined #openstack-nova04:59
*** edmondsw_ has quit IRC04:59
*** hoangcx has quit IRC05:06
*** hoangcx has joined #openstack-nova05:07
*** sapd_ has quit IRC05:07
*** sapd__ has joined #openstack-nova05:07
*** tomtom001 has quit IRC05:10
*** tomtom001 has joined #openstack-nova05:11
*** gongysh has quit IRC05:11
*** tianhui_ has joined #openstack-nova05:15
*** tianhui has quit IRC05:17
*** rajinir has quit IRC05:18
*** Tom-Tom has joined #openstack-nova05:20
*** evrardjp has joined #openstack-nova05:21
*** abhishekk has joined #openstack-nova05:25
*** lpetrut has quit IRC05:27
*** ccamacho has quit IRC05:37
*** ratailor has joined #openstack-nova05:40
*** edmondsw has joined #openstack-nova05:41
*** edmondsw has quit IRC05:45
*** janki has joined #openstack-nova05:49
*** edmondsw has joined #openstack-nova06:02
*** edmondsw has quit IRC06:06
*** gongysh has joined #openstack-nova06:07
*** pratik has joined #openstack-nova06:12
*** links has joined #openstack-nova06:16
pratikdeletion of snapshot created from volume attached to an instance is getting stuck in 'deleting' state with NFS backend. can anyone help? https://developer.openstack.org/api-ref/compute/#delete-assisted-volume-snapshot this API returns 204 response but not sure why it gets stuck06:16
*** do3meli has joined #openstack-nova06:16
*** sar has joined #openstack-nova06:17
*** armaan has joined #openstack-nova06:24
*** trinaths has joined #openstack-nova06:24
openstackgerritXiaojueGuan proposed openstack/nova master: reduce complex if clause to nice or clause  https://review.openstack.org/56383406:26
*** stakeda has joined #openstack-nova06:26
kashyapstephenfin: Morning06:29
kashyapstephenfin: It's in the commit message :-)06:29
*** artom has quit IRC06:29
*** artom_ has joined #openstack-nova06:29
*** lpetrut has joined #openstack-nova06:29
*** markvoelker has joined #openstack-nova06:30
openstackgerritMerged openstack/nova master: Record the host info in EventReporter  https://review.openstack.org/55674606:30
kashyapstephenfin: IOW:06:31
kashyap[quote]06:31
kashyap    The advertized NEXT_MIN_{LIBVIRT,QEMU} versions during06:31
kashyap    "Pike" release were set to: libvirt 1.3.1 and QEMU 2.5.0 -- but they06:31
kashyap    weren't actually bumped for "Queens".  So let's actually bump them for06:31
kashyap    the "Rocky" release.06:31
kashyap[/quote]06:31
kashyap(From the commit message)06:31
*** slaweq has joined #openstack-nova06:32
*** threestrands has quit IRC06:32
*** moshele has joined #openstack-nova06:39
*** slaweq has quit IRC06:42
*** salv-orl_ has quit IRC06:45
*** salv-orlando has joined #openstack-nova06:46
*** tesseract has joined #openstack-nova06:49
*** threestrands has joined #openstack-nova06:50
*** threestrands has quit IRC06:50
*** threestrands has joined #openstack-nova06:50
*** salv-orlando has quit IRC06:50
*** Tom-Tom has quit IRC06:51
*** Tom-Tom has joined #openstack-nova06:53
*** ccamacho has joined #openstack-nova06:55
*** pcaruana has joined #openstack-nova06:58
*** gongysh has quit IRC06:59
*** lajoskatona has joined #openstack-nova06:59
*** salv-orlando has joined #openstack-nova07:00
*** markvoelker has quit IRC07:04
*** armaan has joined #openstack-nova07:06
*** avolkov has joined #openstack-nova07:07
*** jaosorior has joined #openstack-nova07:08
*** threestrands has quit IRC07:10
alex_xujaypipes, ericyoung, we miss this case in this thread http://lists.openstack.org/pipermail/openstack-dev/2018-April/129763.html07:10
*** amoralej|off is now known as amoralej07:11
kashyapstephenfin: And for "Stein", we've picked the NEXT_MIN versions here (this is merged): https://review.openstack.org/#/c/558171/07:15
*** slaweq has joined #openstack-nova07:16
*** rcernin has quit IRC07:16
*** ragiman has joined #openstack-nova07:18
*** jchhatbar has joined #openstack-nova07:21
*** kholkina has joined #openstack-nova07:21
*** sahid has joined #openstack-nova07:22
*** janki has quit IRC07:23
*** edmondsw has joined #openstack-nova07:24
*** ralonsoh has joined #openstack-nova07:25
*** pratik has quit IRC07:26
*** armaan has quit IRC07:28
*** edmondsw has quit IRC07:28
*** abhishekk has quit IRC07:29
*** rmart04 has joined #openstack-nova07:31
*** avolkov has quit IRC07:34
*** avolkov has joined #openstack-nova07:34
*** dpawlik has joined #openstack-nova07:36
*** damien_r has joined #openstack-nova07:42
*** ygl has joined #openstack-nova07:44
*** edmondsw has joined #openstack-nova07:45
*** tssurya has joined #openstack-nova07:45
*** jpena|off is now known as jpena07:48
*** edmondsw has quit IRC07:49
*** hamzy has quit IRC07:51
*** vivsoni_ has joined #openstack-nova07:51
*** hamzy has joined #openstack-nova07:51
*** vivsoni has quit IRC07:51
yglanyone here can help me with my issue please07:53
ygli have created a vm using a heat stack. when I delete that stack, I want a user script to be trigerred automatically  in the VM before its deltion07:54
yglis that possible in openstack as of now ?07:54
*** gjayavelu has joined #openstack-nova07:54
*** mgoddard has joined #openstack-nova07:57
*** takashin has left #openstack-nova08:00
*** markvoelker has joined #openstack-nova08:01
*** AlexeyAbashkin has joined #openstack-nova08:05
*** edmondsw has joined #openstack-nova08:05
bauzasygl: looks like it's not a Nova feature08:06
bauzasygl: AFAIK08:07
*** armaan has joined #openstack-nova08:08
*** edmondsw has quit IRC08:09
*** ktibi has joined #openstack-nova08:10
*** gongysh has joined #openstack-nova08:15
stephenfinkashyap: Ah, so it was a different commit. That's what caught me out :)08:16
kashyapstephenfin: Maybe I should've mentioned it08:16
kashyapstephenfin: Because it requires discussion on the Operators / Dev list08:16
stephenfinkashyap: Ah, it's fine. +Wd now08:17
kashyapstephenfin: Most excellent.  I can build other clean-up patches on top of it08:18
kashyapThanks08:18
stephenfinkashyap: Cool. Feel free to add me as a reviewer to those when you do08:18
openstackgerritsahid proposed openstack/nova master: hardware: only take into account small pages  https://review.openstack.org/53216808:18
kashyapDefinitely.  But before that I'm trying to get this out of the way: https://bugs.launchpad.net/nova/+bug/176620808:18
openstackLaunchpad bug 1766208 in OpenStack Compute (nova) "Lift the restriction on choices for `cpu_model_extra_flags` config attribute" [Undecided,New] - Assigned to Kashyap Chamarthy (kashyapc)08:18
*** abhishekk has joined #openstack-nova08:19
openstackgerritsahid proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin  https://review.openstack.org/53437108:25
*** priteau has joined #openstack-nova08:25
*** edmondsw has joined #openstack-nova08:26
*** avolkov has quit IRC08:27
*** mvk has quit IRC08:28
*** jistr is now known as jistr|mtgs08:28
*** mdbooth has joined #openstack-nova08:30
*** edmondsw has quit IRC08:30
*** gjayavelu has quit IRC08:31
*** lucas-afk is now known as lucasagomes08:31
*** markvoelker has quit IRC08:34
*** mdnadeem has joined #openstack-nova08:39
*** derekh has joined #openstack-nova08:41
*** hiro-kobayashi has joined #openstack-nova08:42
*** ygl has quit IRC08:49
*** ianw is now known as ianw_pto08:54
*** cdent has joined #openstack-nova08:55
*** bzhao__ has joined #openstack-nova08:56
*** armaan has quit IRC08:58
*** armaan has joined #openstack-nova08:58
*** mvk has joined #openstack-nova08:59
*** armaan has quit IRC09:03
*** dtantsur|afk is now known as dtantsur09:09
*** sridharg has quit IRC09:14
*** sridharg has joined #openstack-nova09:18
*** jaosorior has quit IRC09:18
Kevin_Zhengalex_xu Thanks for the review, but Error instances could also have Ip, so I guess we should not skip cell0?09:19
alex_xuKevin_Zheng: cell0 means the instance didn't get right scheduling, so they shouldn't have IP I think09:28
*** wolverineav has joined #openstack-nova09:29
Kevin_Zhenglet me think09:29
alex_xueven if they go to a cell and fail, the IP should be released?09:29
Kevin_Zhengerror instance will still be cell1?09:29
alex_xuKevin_Zheng: yes09:29
Kevin_ZhengNo, Ip will still be on instances records09:29
alex_xuKevin_Zheng: one of case I'm sure is the pre-created ported09:30
Kevin_Zhengthen you should comment erlier :)09:30
alex_xuKevin_Zheng: if the instance turn to error after booting, they shouldn't be in cell0, and yes they has IP09:30
Kevin_Zhengyeah, I got that09:31
alex_xuKevin_Zheng: yea, but i'm not -1 :)09:31
*** markvoelker has joined #openstack-nova09:31
alex_xuKevin_Zheng: if that makes sense, I still think they should be separated patch09:32
*** FoXMaN_ is now known as FoXMaN09:32
*** FoXMaN has quit IRC09:32
*** FoXMaN has joined #openstack-nova09:32
*** Dinesh_Bhor has quit IRC09:35
*** maciejjozefczyk has joined #openstack-nova09:37
*** maciejjozefczyk has left #openstack-nova09:39
Kevin_Zhengalex_xu I will consider it :)09:40
*** jaosorior has joined #openstack-nova09:44
*** gongysh has quit IRC09:48
*** wolverineav has quit IRC09:49
*** wolverineav has joined #openstack-nova09:49
openstackgerritXiaojueGuan proposed openstack/nova master: change complex if clause to nice or clause  https://review.openstack.org/56387209:50
openstackgerritMerged openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky"  https://review.openstack.org/55878309:53
*** wolverineav has quit IRC09:54
*** namnh has quit IRC09:54
*** hiro-kobayashi has quit IRC10:01
*** armaan has joined #openstack-nova10:02
*** abhishekk has quit IRC10:03
*** hoangcx has quit IRC10:03
*** rmart04_ has joined #openstack-nova10:04
*** markvoelker has quit IRC10:06
*** rmart04 has quit IRC10:06
*** rmart04_ is now known as rmart0410:06
*** sdague has joined #openstack-nova10:09
*** sambetts_ is now known as sambetts10:11
*** priteau has quit IRC10:11
*** priteau has joined #openstack-nova10:11
*** pmannidi has joined #openstack-nova10:11
openstackgerritMerged openstack/nova master: Drop MIN_LIBVIRT_SET_ADMIN_PASSWD  https://review.openstack.org/56231210:17
openstackgerritMerged openstack/nova master: Remove vestigial system_metadata param from info_from_instance()  https://review.openstack.org/56172410:17
*** dougshelley66 has joined #openstack-nova10:17
*** rmart04 has quit IRC10:17
*** wolverineav has joined #openstack-nova10:18
*** armaan has quit IRC10:28
*** armaan has joined #openstack-nova10:29
*** annp has quit IRC10:29
*** tiendc has quit IRC10:29
*** mvk has quit IRC10:29
*** tiendc has joined #openstack-nova10:30
*** annp has joined #openstack-nova10:30
*** armaan has quit IRC10:33
*** rmart04 has joined #openstack-nova10:33
*** armaan has joined #openstack-nova10:33
*** dpawlik has quit IRC10:34
*** dpawlik has joined #openstack-nova10:36
*** mvk has joined #openstack-nova10:42
*** jaosorior has quit IRC10:43
*** sapd__ has quit IRC10:45
*** rmart04 has quit IRC10:46
*** annp has quit IRC10:46
*** pmannidi has quit IRC10:47
*** phuongnh has quit IRC10:49
*** Tom-Tom has quit IRC10:52
*** Tom-Tom has joined #openstack-nova10:52
*** Tom-Tom has quit IRC10:53
*** Tom-Tom has joined #openstack-nova10:53
*** mdnadeem has quit IRC10:53
*** mdnadeem has joined #openstack-nova10:53
*** dougshelley66 has quit IRC10:54
openstackgerritMerged openstack/nova master: Improve performance when list instances with IP filter  https://review.openstack.org/53946910:56
*** markvoelker has joined #openstack-nova11:02
*** nicolasbock has joined #openstack-nova11:05
*** chyka has joined #openstack-nova11:06
*** rmart04 has joined #openstack-nova11:09
*** chyka has quit IRC11:11
*** vladikr has quit IRC11:13
*** vladikr has joined #openstack-nova11:13
*** ktibi has quit IRC11:13
*** trinaths has quit IRC11:14
*** hjensas has quit IRC11:14
*** stakeda has quit IRC11:18
*** dougshelley66 has joined #openstack-nova11:22
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create  https://review.openstack.org/52031311:23
*** armaan has quit IRC11:26
*** armaan has joined #openstack-nova11:26
*** sar has quit IRC11:29
*** evin has joined #openstack-nova11:29
*** armaan has quit IRC11:33
*** armaan has joined #openstack-nova11:33
*** cdent has quit IRC11:34
*** markvoelker has quit IRC11:36
*** cdent has joined #openstack-nova11:40
*** lucasagomes is now known as lucas-hungry11:41
*** ktibi has joined #openstack-nova11:43
*** jaosorior has joined #openstack-nova11:48
*** jpena is now known as jpena|lunch11:50
*** mdbooth has quit IRC11:52
*** liuyulong has joined #openstack-nova11:53
*** tiendc has quit IRC11:57
jaypipesalex_xu: will respond on the ML thread, ok?12:08
*** QianYu has joined #openstack-nova12:09
*** QianYu has quit IRC12:11
*** Kevin_Zheng has quit IRC12:11
kashyapGoddamnit12:12
kashyapThe Gerrit UI12:12
*** Kevin_Zheng has joined #openstack-nova12:12
*** wolverineav has quit IRC12:12
kashyapIt _keeps_ jumping around.12:12
*** wolverineav has joined #openstack-nova12:12
*** Tom-Tom has quit IRC12:13
kashyapNo wonder I still like the blazing fast e-mail workflow.  /me whips up the 'ncurses'-based 'Gertty' tool to see if it has gotten a bit less crashy12:13
sean-k-mooneykashyap: matt found a workaround for that. in your preferences set render mode to slow12:13
*** wolverineav has quit IRC12:13
kashyapsean-k-mooney: Oh really?  /me goes to look12:13
jaypipeskashyap: I know. It's infuriating.12:13
*** wolverineav has joined #openstack-nova12:14
kashyapThis just makes the throw the laptop out the fucking window12:14
*** yamamoto has joined #openstack-nova12:14
*** tbachman has quit IRC12:14
jaypipessean-k-mooney: I have that set in my prefs and still happens occasionally.12:14
cdentsean-k-mooney, kashyap the slow render mode helps some, but not all of it12:14
cdentjinx12:14
*** liverpooler has joined #openstack-nova12:14
sean-k-mooneyjaypipes: ya it seams to depend on gerrit version12:14
sean-k-mooneythere is a new gerrit ui based on javascitp on the latest realease called polygerrit12:15
kashyapsean-k-mooney: Okay, so in Diff Preferences --> Render --> "Slow", yes?12:15
sean-k-mooneykashyap: yes12:15
*** jaosorior has quit IRC12:15
*** jaosorior has joined #openstack-nova12:16
kashyapsean-k-mooney: Any other preferences that you "can't live without"?12:16
*** efried has joined #openstack-nova12:16
*** markvoelker has joined #openstack-nova12:16
kashyapMaybe I'm "missing out" something12:16
kashyapcdent: Noted12:16
sean-k-mooneykashyap: not that come to mind12:16
kashyapCool; thanks12:16
*** Tom-Tom has joined #openstack-nova12:17
sean-k-mooneykashyap: if we ever update the openstack gerrit to support polygerrit ui then that should solve this permently but im sure that has its own bugs12:18
jaypipeskashyap: oh, I'm pretty sure you're missing out on lots of things :P12:18
*** wolverineav has quit IRC12:18
kashyapjaypipes: I just maintain my sanity (from Gerrit) by spending a portion of time on mailing list based projects :P12:18
kashyapsean-k-mooney: What does "polygerrit" do?12:18
jaypipeskashyap: it's gerrit that simply repeats stuff back to you.12:19
jaypipeskashyap: oh wait, no, that's PollyGerrit.12:19
*** tomhambleton_ has quit IRC12:19
*** tomhambleton_ has joined #openstack-nova12:20
* kashyap nods12:20
sean-k-mooneykashyap: its a complete reimplementaiton of the entire gerrit ui in plomer.js and html5 so no more java/gwt12:20
kashyapUnrelated "taste" question -- is it bad taste to write a small clarifying comment in a unit test?12:20
kashyapE.g.:12:20
kashyap+        # For 'host-model', it is now valid to use 'extra_flags';12:20
kashyap+        # so warning should not be thrown12:20
kashyap+        self.assertFalse(mock_warn.called)12:20
jaypipeskashyap: that is good taste, IMHO.12:20
kashyapThere are multiple unit tests, but the "asserts" won't speak for themselves, if you're not reading code carefully around12:20
*** Tom-Tom has quit IRC12:21
kashyapjaypipes: Thanks.  It is subtle, and this helps.  So I'll add it in12:21
kashyapsean-k-mooney: My single biggest feature request is: if I can reply from Gerrit mail, that'll solve "everything" for me with Gerrit12:21
sean-k-mooneykashyap: the only time i would consider that bad taste is if it is done instead of splitting a test that is too complex. adding comments to explain clearly what your testing is good12:21
kashyapAs long as I don't have to deal with the clickety-clicky, RSI-inducing GUI12:21
*** amoralej is now known as amoralej|lunch12:22
kashyapsean-k-mooney: Good point; I did split the test.  I'm lifting the restriction we added here: https://bugs.launchpad.net/nova/+bug/176620812:22
openstackLaunchpad bug 1766208 in OpenStack Compute (nova) "Lift the restriction on choices for `cpu_model_extra_flags` config attribute" [Undecided,New] - Assigned to Kashyap Chamarthy (kashyapc)12:22
sean-k-mooneykashyap: if openstack had an email only interface it would never work on it again. but if email via gerrit work then that would be cool12:22
kashyapIn the earlier patch, for 'host-model' it was invalid to specify 'extra_flags'.   But now we allow it (as it is valid libvirt form)12:23
kashyapsean-k-mooney: s/"it would"/I would/ ?12:23
sean-k-mooneyah the restiction we added for backporting12:23
*** tbachman has joined #openstack-nova12:24
sean-k-mooneyya i think being able to extend host-model makes sense. it was just one extra vairible that we did not want to backport originally so i dont think that bug is controverial12:24
kashyapsean-k-mooney: Yeah, now I'm lifting that12:25
sean-k-mooneykashyap: it is technically a feature not a bug but even a specless blueprint seams to heavy for that so bug makes sense12:26
kashyapgit diff --cached12:26
kashyapWrong window12:26
kashyapsean-k-mooney: Yep12:26
sean-k-mooneykashyap: password:   :)12:26
*** mwhahaha has quit IRC12:26
kashyapHeh12:26
*** mwhahaha has joined #openstack-nova12:27
*** edmondsw has joined #openstack-nova12:28
*** lucas-hungry is now known as lucasagomes12:29
*** lbragstad has joined #openstack-nova12:29
*** edmondsw_ has joined #openstack-nova12:29
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Lift the restriction of choices for `cpu_model_extra_flags`  https://review.openstack.org/56392612:30
kashyapsean-k-mooney: ^ When you can, mind having a gander?12:31
kashyap(Pinged you explicitly as you have context from the prior patch.)12:31
*** jackie-truong has joined #openstack-nova12:31
sean-k-mooneykashyap: ill be away for like 20 mins or so but i have it open in a tab for when i get back12:31
kashyapThanks!12:32
*** mchlumsky has joined #openstack-nova12:33
*** edmondsw has quit IRC12:33
bhagyashrisefried; Hi, I just want to discuss regarding the zuul failure on patches https://review.openstack.org/#/c/560444/ https://review.openstack.org/#/c/560459/ . I have some observations; 1. Yesterday I had list down the test which are failing on both the patches [1][2] and then put the recheck in morning and checked wheather the same test are failing or not but I saw that the different tests are failing12:35
efriedbhagyashris: Unit or functional?12:36
bhagyashrisefried: Most of the test are failing with the error like (No valid host is found and Server <id> failed to build and is in ERROR status) so it seems that the host is not return properly from scheduler side.12:36
efriedoh, tempest12:36
bhagyashrisefried: tempest-full, tempest-full-py3 etc12:36
efriedHave you looked into the compute logs?12:36
*** psachin has quit IRC12:37
bhagyashrisefried: I have checked the n-sch logs #link: http://logs.openstack.org/59/560459/3/check/tempest-full/b9c97a9/controller/logs/screen-n-sch.txt.gz#_Apr_24_06_52_41_19281912:37
bhagyashrisefried: and it shows that the get_alocation_candidates() at https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L148 is returning the empty list12:38
bhagyashrisefried:  As n-sch is not returning the host and our patch has changes at n-cpu side so I am not getting where exactly it's failing?12:41
*** cdent has quit IRC12:42
efriedbhagyashris: http://logs.openstack.org/59/560459/3/check/tempest-full/b9c97a9/controller/logs/screen-placement-api.txt.gz#_Apr_24_06_52_41_19012512:44
*** edmondsw_ has quit IRC12:44
efriedbhagyashris: But requests before that are succeeding.  It's like the host is running out of resources.  This could be an allocation ratio thing.12:44
bhagyashrisefried: I have debug the tempest test tempest.api.compute.servers.test_multiple_create.MultipleCreateTestJSON.test_multiple_create on patch https://review.openstack.org/#/c/560459/ and observed that the allocation_candidates() return at https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L148 is empty list and same test i have ran on master there the  allocation_candidates() return is successfully12:44
*** maciejjozefczyk1 has joined #openstack-nova12:45
bhagyashrisefried: sorry i am getting fully . Means we will need some changes at placement side to fix the failing tests on zuul12:47
*** edmondsw has joined #openstack-nova12:48
efriedbhagyashris: We definitely shouldn't need placement changes, no.12:48
efriedbhagyashris: You say you have a way to step through the tempest test and reproduce the failure?12:49
efriedbhagyashris: And presumably you would be able to step through that same test in an environment that did *not* include the patches in question (i.e. from the tip of the master branch)?12:49
*** cdent has joined #openstack-nova12:49
efriedbhagyashris: So what we should do is query placement for the inventory records right before the meat of the test is run.12:50
efriedbhagyashris: They should be the *same* with or without our patch.12:50
*** felipemonteiro__ has joined #openstack-nova12:52
*** edmondsw has quit IRC12:52
*** jpena|lunch is now known as jpena12:54
bhagyashrisefried: I am not clear what will need to fix this12:54
*** maciejjozefczyk1 has left #openstack-nova12:55
bhagyashrisefried: As the same test are passing on master and our patches are not making any change at placement or n-sch side12:55
*** wolverineav has joined #openstack-nova12:56
efriedbhagyashris: I am also not clear what is needed to fix this, which is why I suggested the above to debug.  If we can demonstrate that the inventories in placement are different between master and our patch, then we've done something wrong with the transition from get_inventory to update_provider_tree.12:56
efriedbhagyashris: But if they're the same... then we need to look somewhere else (not sure where).12:56
bhagyashrisefried: ohh ok12:57
efriedbhagyashris: The tests fail the same way with the bottom patch as with the top, right?12:58
efriedSo the problem isn't with our conditional DISK_GB thing.12:58
*** pchavva has joined #openstack-nova12:58
efriedIt's with the translation from get_inventory to update_provider_tree.12:58
efriedCould be in the resource tracker.12:58
efriedor in the report client.12:58
*** edmondsw has joined #openstack-nova12:59
bhagyashrisefried: just checked on both the patches different test are failing13:00
*** awaugama has joined #openstack-nova13:00
*** lyan has joined #openstack-nova13:01
*** tbachman_ has joined #openstack-nova13:01
*** lyan is now known as Guest4658813:01
efriedbhagyashris: If we're reporting the inventory wrong, it could mean that we're running out of capacity sooner than we used to.  But the tempest tests run in parallel in zuul.  So which test runs out of capacity first could vary from one run to another.13:01
*** edmondsw has quit IRC13:01
bhagyashrison parent patch the tempest-full 2 test are failing and on child patch tempest-full 7 tests are failing13:01
*** tbachman has quit IRC13:02
*** tbachman_ is now known as tbachman13:02
efriedLet's just focus on the first patch compared to master.13:02
*** alexchadin has joined #openstack-nova13:02
efriedbhagyashris: You said you were able to reproduce the failure manually?13:03
bhagyashrisefried: no13:03
bhagyashrisefried: I have debugged  tempest test tempest.api.compute.servers.test_multiple_create.MultipleCreateTestJSON.test_multiple_create on patch https://review.openstack.org/#/c/560459/ and observed that the allocation_candidates() return at https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L148 is empty list and same test i have ran on master there the  allocation_candidates() return is successfully13:04
efriedbhagyashris: What do you mean by "debugged" then - you mean just looking at logs?13:06
bhagyashrisefried: I mean I have put pdb at https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L121 and ran the tempest test using the tox -e py27  tempest test tempest.api.compute.servers.test_multiple_create.MultipleCreateTestJSON.test_multiple_create13:07
efriedbhagyashris: And you were able to reproduce the fact that GET /allocation_candidates returns no results?13:08
efried...with our patch13:08
efried...but on master it returns good results?13:08
bhagyashrisefried: yes13:08
efriedbhagyashris: Okay, so what I'm asking is for you to do the exact same thing, but when you hit your breakpoint, manually query the placement API and pull back the inventories and allocations for the compute host.13:09
efriedbhagyashris: If you do that for both environments - one with our patch and one with master - we should be able to determine whether those inventories/allocations are the same or different.13:10
efriedbhagyashris: I'm especially interested in whether the total, reserved, and allocation ratio match; and whether the allocations match.13:10
*** tbachman_ has joined #openstack-nova13:10
*** armaan has quit IRC13:12
*** tbachman has quit IRC13:13
*** armaan has joined #openstack-nova13:13
*** tbachman has joined #openstack-nova13:14
*** tbachman_ has quit IRC13:16
*** sahid has quit IRC13:17
*** salv-orlando has quit IRC13:18
*** salv-orlando has joined #openstack-nova13:19
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Lift the restriction of choices for `cpu_model_extra_flags`  https://review.openstack.org/56392613:19
openstackgerritKashyap Chamarthy proposed openstack/nova master: Do-Not-Merge: Test multiple CPU flags  https://review.openstack.org/56394813:19
*** armaan has quit IRC13:20
*** armaan has joined #openstack-nova13:21
*** dave-mccowan has joined #openstack-nova13:22
*** salv-orlando has quit IRC13:24
*** abhishekk has joined #openstack-nova13:25
*** edmondsw has joined #openstack-nova13:27
*** jmlowe has quit IRC13:27
*** liuyulong has quit IRC13:27
*** yamamoto has quit IRC13:28
*** yamamoto has joined #openstack-nova13:28
*** edmondsw has quit IRC13:31
*** armaan has quit IRC13:32
*** armaan has joined #openstack-nova13:32
*** cfriesen has joined #openstack-nova13:33
*** sahid has joined #openstack-nova13:33
*** sahid has quit IRC13:34
*** sahid has joined #openstack-nova13:35
*** jbryce has quit IRC13:37
*** jbryce has joined #openstack-nova13:37
*** amoralej|lunch is now known as amoralej13:40
*** esberglu has joined #openstack-nova13:40
*** moshele has quit IRC13:41
openstackgerritJulia Kreger proposed openstack/nova master: Ironic: Lock the instance if early vif plug  https://review.openstack.org/56371413:42
*** artom_ is now known as artom13:43
*** QianYu has joined #openstack-nova13:43
*** zhaochao has quit IRC13:43
*** ragiman has quit IRC13:45
*** abhishekk has quit IRC13:45
*** zul has quit IRC13:48
*** zul has joined #openstack-nova13:48
*** evin has quit IRC13:49
*** alexchadin has quit IRC13:50
*** ratailor has quit IRC13:50
openstackgerritJens Harbott (frickler) proposed openstack/nova master: DNM: Test devstack + ceph plugin patches  https://review.openstack.org/56309713:51
*** armaan has quit IRC13:51
*** tbachman has quit IRC13:51
openstackgerritMatt Riedemann proposed openstack/nova master: Fix dropped check for boot_index 0 in _validate_bdm  https://review.openstack.org/56373213:51
*** armaan has joined #openstack-nova13:51
*** mlavalle has joined #openstack-nova13:53
*** QianYu has quit IRC13:54
*** artom2 has joined #openstack-nova13:54
*** QianYu has joined #openstack-nova13:55
*** pchavva has quit IRC13:55
*** jaosorior has quit IRC13:55
*** jaosorior has joined #openstack-nova13:55
*** felipemonteiro__ has quit IRC13:57
*** felipemonteiro__ has joined #openstack-nova13:57
*** jaypipes has quit IRC13:58
*** jaypipes has joined #openstack-nova13:58
*** artom2 has quit IRC13:59
*** hongbin_ has joined #openstack-nova13:59
*** edmondsw has joined #openstack-nova13:59
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Improve performance when list instances with IP filter  https://review.openstack.org/56397214:01
*** yamahata has joined #openstack-nova14:04
*** edmondsw has quit IRC14:04
*** edmondsw has joined #openstack-nova14:04
*** artom2 has joined #openstack-nova14:05
*** jaosorior has quit IRC14:07
*** edmondsw has quit IRC14:09
*** edmondsw has joined #openstack-nova14:09
*** r-daneel has joined #openstack-nova14:10
*** edmondsw has quit IRC14:14
*** rajinir has joined #openstack-nova14:14
*** wolverineav has quit IRC14:18
*** wolverineav has joined #openstack-nova14:18
*** pchavva has joined #openstack-nova14:20
*** READ10 has joined #openstack-nova14:22
*** wolverineav has quit IRC14:24
*** wolverineav has joined #openstack-nova14:24
*** alexchadin has joined #openstack-nova14:25
*** AlexeyAbashkin has quit IRC14:25
*** mriedem has joined #openstack-nova14:26
mriedemstephenfin: can https://review.openstack.org/#/c/541290/ be updated now?14:26
stephenfinmriedem: Sure. I was working through PoC to make sure the idea worked and it does. I'll update the spec pronto14:27
stephenfin*a PoC14:27
mriedemcool, thanks14:27
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_BLOCK_LM_WITH_VOLUMES_VERSION  https://review.openstack.org/56398414:28
*** wolverineav has quit IRC14:28
*** tomtom001 has quit IRC14:28
*** tomtom001 has joined #openstack-nova14:29
*** cristicalin has joined #openstack-nova14:31
mriedemjohnthetubaguy_: can you go over https://review.openstack.org/#/c/552078/ again since i've updated it?14:33
*** edmondsw has joined #openstack-nova14:35
*** namnh has joined #openstack-nova14:35
esberglumriedem: Thoughts on my last comment here? https://review.openstack.org/#/c/526094/45/nova/virt/powervm/driver.py@55914:37
esbergluIgnore the 1st UT comment, that was some confusion on our end14:38
mriedemso it's a DriverVolumeBlockDevice (which is a dict) rather than a BlockDeviceMapping object14:38
mriedemDriverVolumeBlockDevice wraps BlockDeviceMapping14:38
*** r-daneel has quit IRC14:38
mriedemi think the ironic driver has the same need for the is_volume getting exposed from the internally wrapped bdm14:38
mriedemsec14:38
*** r-daneel has joined #openstack-nova14:39
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L392-L39614:39
*** edmondsw has quit IRC14:40
mriedemso you could do that and then when we handle the ironic driver TODO we can also cleanup the powervm driver14:40
*** hemna_ has joined #openstack-nova14:40
esberglumriedem: Sounds good thanks!14:40
mriedemthat also forces you to use DriverVolumeBlockDevice objects in your unit tests, but i think that's a good thing, given a BDM can be one of at least 3 or 4 things at any given point in the code14:41
*** links has quit IRC14:42
*** edmondsw has joined #openstack-nova14:42
esberglumriedem: We already are using DriverVolumeBlockDevice objects :)14:42
mriedemthen you get a root beer scented scratch-n-sniff14:43
*** moshele has joined #openstack-nova14:43
*** eharney has joined #openstack-nova14:44
stephenfinmriedem, jaypipes, bauzas, gibi: I'm thinking most of the information from here down is too detailed for the spec (it was mostly to help me figure out the problem boundary myself). I think I could drop the whole piece. Thoughts? https://review.openstack.org/#/c/541290/7/specs/rocky/approved/numa-aware-vswitches.rst@3814:45
*** edmondsw has quit IRC14:46
mriedemstephenfin: given my lack of knowledge on numa stuff, i'll likely appreciate details in the problem description14:47
stephenfinmriedem: This is more about OVS-DPDK internals. If you think that's be helpful, I can keep it14:48
stephenfinI'd like to add it to a different section but that upsets pep8 :)14:48
gibistephenfin: I have the same mental debate about the bandwidth spec. It is too detailed for a reader who is familar with the problem and the proposed solution, but it has a lot of nice details and reasoning for a new reader.14:48
*** alexchadin has quit IRC14:48
gibistephenfin: for me it is OK to remove that section from your spec14:48
*** moshele has quit IRC14:48
gibistephenfin: you can add new subsections but you cannot add a new top level section14:49
stephenfinmaybe I can publish it as a separate blog and link to that from there14:49
mriedemstephenfin: i was just thinking that14:49
*** eharney has quit IRC14:49
mriedem'for more information on how this relates to dpdk, see $link'14:49
stephenfinmriedem: Sounds good to me. I'll do that14:50
* stephenfin drags out his blogging tools14:50
jaypipesstephenfin: I don't mind that detail.14:53
*** yamamoto has quit IRC14:58
*** dpawlik has quit IRC15:00
*** rmart04 has quit IRC15:01
*** esberglu has quit IRC15:04
*** jaosorior has joined #openstack-nova15:05
kashyapstephenfin: Yeah, it comes useful for that poor soul who will look at it 5 years down the line15:05
*** esberglu has joined #openstack-nova15:05
*** tesseract has quit IRC15:06
*** tesseract has joined #openstack-nova15:06
*** AlexeyAbashkin has joined #openstack-nova15:08
*** felipemonteiro_ has joined #openstack-nova15:13
*** alexchadin has joined #openstack-nova15:13
melwittlyaaaaaaaaarwood: could you please hit this again? pike change has merged https://review.openstack.org/#/c/561613/15:14
*** armaan has quit IRC15:14
*** armaan has joined #openstack-nova15:14
melwittdansmith: could you please look at this stack of two backports for ocata? these and the one ^ are the last needed for the ocata release https://review.openstack.org/#/c/56016215:15
*** felipemonteiro__ has quit IRC15:16
dansmithack15:17
*** eharney has joined #openstack-nova15:18
openstackgerritJay Pipes proposed openstack/nova-specs master: Support initial allocation ratios  https://review.openstack.org/55210515:19
*** lyaaaaaaaaarwood is now known as lyarwood15:19
lyarwoodmelwitt: done15:19
melwittmriedem: what do you think of this approach for fixing the ceph job? frickler is trying something different to check the target branch to determine "if pike uca" https://review.openstack.org/#/c/56387015:20
melwittthanks lyarwood15:20
*** ccamacho1 has joined #openstack-nova15:21
*** sahid has quit IRC15:21
*** ccamacho has quit IRC15:21
mriedemmelwitt: since stable/pike devstack uses the ocata UCA, and rocky now uses the queens UCA, and devstack-plugin-ceph is branchless, this seems appropriate15:23
melwittmriedem: k, cool. just wanted to make sure stable/queens won't be changing which UCA it uses in the future (makes sense that it wouldn't change)15:24
mriedemit could change, but likely wont15:24
kashyapDoes anyone with Parallels / Virtuozzo experience, do you know if QEMU Guest Agent is required to set password in Nova?15:24
mriedemkashyap: you'd have to reach out to mnestratov15:25
* kashyap checks on OFTC #virt, have seen Virtuozzo folks there a few times15:25
kashyapmriedem: Yep, checking with one of his colleagues15:25
mriedemhttps://wiki.openstack.org/wiki/ThirdPartySystems/Virtuozzo_CI15:25
melwittcool15:25
kashyapAs Maxim normally doesn't seem to hangout here, only occasionally15:25
*** do3meli has quit IRC15:27
kashyapNone of the contacts are on IRC (neither on FN, nor on OFTC), I'll email them probably15:28
*** dklyle has joined #openstack-nova15:29
*** spsurya has quit IRC15:31
*** spsurya has joined #openstack-nova15:32
*** eharney has quit IRC15:32
*** edmondsw has joined #openstack-nova15:33
*** salv-orl_ has joined #openstack-nova15:35
*** moshele has joined #openstack-nova15:35
kashyapSent15:37
*** tbachman has joined #openstack-nova15:37
*** sahid has joined #openstack-nova15:38
openstackgerritMerged openstack/os-vif master: Trivial: Update pypi url to new url  https://review.openstack.org/56324615:38
*** gyee has joined #openstack-nova15:38
*** munimehan has joined #openstack-nova15:38
openstackgerritJay Pipes proposed openstack/nova master: mirror nova host aggregate members to placement  https://review.openstack.org/55359715:39
TheJuliaGreetings nova folk, we're currently looking at an issue with ironic virt driver where due to the need for networking information for block device mappings, we end up getting called for vif attachment actions prior to a node being reserved in the spawn action by our virt driver. We're pondering two options, explicitly check during a vif plugging action, or adding a new virt driver call that would be along the lines of15:40
TheJuliapreparing to spawn in order to facilitate the actual lock of the node resource. Thoughts would be appreciated since we somehow need to flag the node as in use for any other users of ironic's API prior to attaching the vifs.15:40
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI Fibre Channel volume adapter  https://review.openstack.org/52609415:41
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot  https://review.openstack.org/54302315:41
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class  https://review.openstack.org/54905315:41
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk  https://review.openstack.org/54930015:41
melwittjbernard: hi, we're trying to fix the ceph job that's failing 100% on master, would appreciate your review https://review.openstack.org/#/c/56387015:42
jbernardmelwitt: certainly15:43
*** tbachman has quit IRC15:43
melwittthanks!15:43
jaypipesTheJulia: I'm confused why vif setup actions are being called prior to the node being reserved.15:43
*** thorst has joined #openstack-nova15:43
melwittsame15:44
jaypipesTheJulia: I would think that setup_networking_on_host() would only happen after Ironic has notified the Ironic virt driver that the node is ready for provisioining?15:44
*** alexchadin has quit IRC15:46
TheJuliajaypipes: melwitt: let me grab the link for the change so we can discuss this with more information15:47
*** lajoskatona has quit IRC15:47
TheJuliabetween three other conversations :(15:47
*** tbachman has joined #openstack-nova15:48
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_BLOCK_LM_WITH_VOLUMES_VERSION  https://review.openstack.org/56398415:48
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_NUMA_VERSION_PPC  https://review.openstack.org/56401015:48
openstackgerritKashyap Chamarthy proposed openstack/nova master: Drop BAD_LIBVIRT_NUMA_VERSIONS  https://review.openstack.org/56401115:48
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop BAD_LIBVIRT_CPU_POLICY_VERSIONS  https://review.openstack.org/56401215:48
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_PARALLELS_SET_ADMIN_PASSWD  https://review.openstack.org/56401315:48
openstackgerritStephen Finucane proposed openstack/nova-specs master: Add 'numa-aware-vswitches' spec  https://review.openstack.org/54129015:49
kashyap(Damn, missed the 'libivrt' prefix for one of the commits; will fix it after I figure out to fix the 2 failing unit tests.)15:49
*** felipemonteiro_ has quit IRC15:49
*** felipemonteiro_ has joined #openstack-nova15:49
*** damien_r has quit IRC15:50
*** chyka has joined #openstack-nova15:50
TheJuliamelwitt: jaypipes: This is the change that changed the behavior https://github.com/openstack/nova/commit/23d935b3a60741ddb52f076ffeacde9c37f17c8c which should hopefully shed light as to why15:50
*** pcaruana has quit IRC15:51
melwittoh, I remember that now15:52
*** trinaths has joined #openstack-nova15:52
*** moshele has quit IRC15:53
*** chyka_ has joined #openstack-nova15:53
jaypipesTheJulia: gimme a bit to read the original review.15:53
* TheJulia guesses maybe just assert the lock there.... in the ironic virt driver15:54
TheJuliajaypipes: no worries, 2 other conversations and a meeting shortly :(15:54
melwittIP is needed for the volume backend (or some volume backends require it)15:55
*** ccamacho1 has quit IRC15:55
*** jmlowe has joined #openstack-nova15:55
TheJuliaCorrect, as some do IP level filtering on inbound iscsi connections15:55
*** chyka has quit IRC15:56
melwittso the vif plug is the problem right? I would think you could get the IP early but wait to plug the vif until the normal time15:57
melwitt(until after it's reserved) or would that not help?15:57
openstackgerritMerged openstack/nova master: Test case: traits don't sync if first access fails  https://review.openstack.org/55806615:58
*** jmlowe has quit IRC15:59
*** yamamoto has joined #openstack-nova15:59
*** r-daneel_ has joined #openstack-nova15:59
TheJuliaWell, getting the IP earlier would help, I think but there is a caveat there I need to try and remember around vif behavior15:59
*** r-daneel has quit IRC16:00
*** r-daneel_ is now known as r-daneel16:00
openstackgerritEric Fried proposed openstack/nova master: WIP: Proxy is_volume through DriverBlockDevice  https://review.openstack.org/56401716:01
efriedmriedem, esberglu, TheJulia: ^^16:01
melwittwhat I mean is decouple the two (creating port vs plugging vif). because that patch moved both of them earlier, so I was thinking maybe decoupling them to leave the port create earlier but do the vif plug later (back to the original place). I need to look at it more to see if what I'm saying makes sense or not16:02
*** sahid has quit IRC16:03
melwittoh, all prepare_networks_before_block_device_mapping does is plug vifs. it doesn't create the port16:03
*** armaan has quit IRC16:04
melwitthm, I didn't think vif plugging had anything to do with getting an IP address. I thought that was connected to the port creation16:04
*** yamamoto has quit IRC16:04
*** armaan has joined #openstack-nova16:05
*** esberglu has quit IRC16:05
*** esberglu has joined #openstack-nova16:05
*** moshele has joined #openstack-nova16:06
*** lucasagomes is now known as lucas-afk16:06
*** armaan_ has joined #openstack-nova16:07
*** moshele has quit IRC16:07
*** armaan has quit IRC16:08
*** armaan_ has quit IRC16:09
*** esberglu has quit IRC16:10
*** armaan has joined #openstack-nova16:12
*** armaan has quit IRC16:13
*** yamahata has quit IRC16:15
*** cristicalin has quit IRC16:16
TheJuliaefried: I completely forgot about that *blink* *blink*16:16
TheJuliafeels like a lifetime ago16:16
melwittTheJulia: I see that the patch gets the IP address from the attached vif from ironic. is there some reason why we couldn't just use the IP address from the neutron port instead of attaching the vif early? https://developer.openstack.org/api-ref/network/v2/#show-port-details16:17
jaypipesmelwitt: it's not really port creation that is needed. it's IP allocation.16:17
jaypipesmelwitt: but if that's what you mean by port creation, then yes, decoupling those things would be ++16:18
melwittokay, so with ironic driver we don't get an IP when we create a port in neutron? or do we not even create a port in neutron when ironic driver?16:18
jaypipesmelwitt: as with most thing neutron, it depends :)16:18
TheJuliaheh16:19
jaypipesmelwitt: if the subnet upon which the port resides uses DHCP, then the IP is doled out to the port after the port is set up on the host.16:19
TheJuliaI think if we could get the IP address in advance then ++++++ but I'm having strong deja vu, I just can't place it at hte moment16:19
melwittokay. yeah, from what I understand, creating the port in neutron will allocate the IP(s). plugging the vif will just attach the instance to the network. so I was thinking can we decouple that and get the IP from neutron instead of getting it from ironic by way of the vif16:19
TheJuliauhg, yeah16:19
TheJuliawhich means the port has to be plugged to have correct dhcp information16:20
jaypipesmelwitt: in TheJulia's case, I think that basically the only way that it will work is if an IP is statically assigned ahead of time.16:20
jaypipesmelwitt: but I'm definitely no expert in Neutron-isms. Perhaps sean-k-mooney is a good person to ask about this if not mriedem.16:20
melwittjaypipes: oh, I see. I wasn't thinking of DHCP :(16:20
jaypipesmelwitt: in this specific case (the hitachi/fujitsu NFS/SAN thing) I would think that a statically-assigned IP address is really the only way it would work.16:21
jaypipesmelwitt: otherwise, the connector info would need to essentially say "this storage NIC is gonna get some IP address in this CIDR but I don't know what that specific IP address is right now". And I'm pretty sure no such affordance is possible in the volume connector info ;)16:23
*** tssurya has quit IRC16:23
TheJuliajaypipes: as in operator pre-creation of the ports, definition of said vifs upon spawning a node?16:23
melwittyeah. huh. I guess that means that any deployment using DHCP must be creating neutron ports in deferred mode or no IP allocation mode?16:23
*** jdillaman has joined #openstack-nova16:23
jaypipesTheJulia: yes, which is a very common thing already.16:23
jaypipesTheJulia: and passing nova boot --nic port=<UUID> (or whatever the magical incantation is...)16:24
TheJuliajaypipes: that is correct, we can't say "later" for the volume connection info because it gets shipped all the way to the backend storage upfront16:24
TheJuliahshiina|afk: ^^^ thoughts16:24
* TheJulia is sure he is asleep :(16:24
jaypipesTheJulia: although saying "laterz dude" in the connector info would be, well, amaze-balls.16:24
TheJuliajaypipes: totally16:24
jaypipesTheJulia: I think you meant "totes magotes".16:25
melwitthah16:25
melwittjobin16:25
TheJulialol16:25
*** moshele has joined #openstack-nova16:26
melwittgoing down a different thought path, can we not wait until after the node is reserved to attach the block device instead?16:27
TheJuliawe actually should be waiting16:27
TheJuliabut the cinderside of that has to be done first with information about the node too16:28
TheJuliawow, what a fun chicken and the egg16:28
melwittokay, I think I'm confused because the new problem that's happening is vifs are being plugged before the node is reserved. and we need to plug the vifs to get the IP address so we can attach the volume16:28
melwittso I think I don't get why we can do both after the node is reserved16:28
jaypipesmelwitt: we could definitely do that, yes. Though that won't solve the problem if the port has no IP address already, right?16:28
melwitt*can't16:28
melwittlike, why can't we reserve the node, plug vifs, get IP for volume connector, attach volume16:29
*** moshele has quit IRC16:29
TheJuliaIdeally that is what we should be doing in the grand scheme of the universe16:29
TheJuliaideally16:29
melwittthere is something preventing that from being possible?16:30
*** thorst has quit IRC16:30
jaypipesmelwitt: nope16:30
jaypipesmelwitt: nothing preventing that AFAICT16:30
*** mgoddard has quit IRC16:30
TheJuliawhat would be more ideal I guess is the question from a nova point of view, a new pre-spawn virt driver method call or we just quietly check/assert when we get the vif plug call16:30
melwittlet's do that16:30
*** artom2 has quit IRC16:31
*** jchhatbar has quit IRC16:32
melwittoh, so the first step in spawn would not be reserve?16:32
melwitt(I don't know where reserve is currently happening)16:33
TheJuliamelwitt: in spawn when we begin to populate information in ironic about the instance16:33
melwittohhh yeah. sorry16:33
melwittthis network prep thing is called in compute/manager early16:33
TheJuliano worries16:34
TheJuliayeah16:34
melwittlooking in the code for where reserve is currently happening and can't find it16:37
jaypipesmelwitt: yeah, we might want to move the network prep for block devices thing to being a method that is called from the virt driver and not the compute manager16:37
* jroll pokes his head in16:37
jaypipesmelwitt: so that the virt driver can dictate when it is appropriate to do that prep work16:38
* jaypipes hides from jroll 16:38
dansmithmelwitt: are you suggesting plugging vifs before we call virt spawn across the board?16:38
TheJuliamelwitt: instance_uuid being set16:38
jrollI did a poc for the pre-spawn method call TheJulia mentioned, fwiw: https://review.openstack.org/#/c/563722/16:38
jaypipesdansmith: nope, not plugging vifs.16:38
melwittdansmith: no, I mean, where can we do the ironic node reserve call16:38
dansmithjaypipes: okay I see vif plugging discussion above, but wasn't following16:39
melwittbecause ultimately we want to reserve the node before plugging vifs or attaching volumes. I just don't know where that's currently being done16:39
TheJuliamelwitt: let me get you the line, one moment16:39
jrollmelwitt: currently the ironic driver reserves the node within spawn()16:39
jrollby sending instance_uuid in a PUT request16:39
jrollor node.update I guess, in ironicclient terms16:39
melwittokay I see16:39
melwittI mean, the cheat would be move that call to "prepare networking etc" method16:40
TheJuliahttps://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L36016:40
jrollmelwitt: ya, that's the other version: https://review.openstack.org/#/c/563714/16:40
TheJulia:)16:41
jaypipesdansmith: no worries. we were discussing that ironic (actually, some cinder drivers) need to know the IP address of a port up front. and the prep_network_for-blokc_devices() virt driver API method was added in order to address that need. But that method does vif plugging (because that's unfortunately when a port's IP address is guaranteed to be set). We would like to see the IP address allocation decoupled from the vif plugging action.16:41
jrollfeels out of place to me but if the bug gets fixed then ¯\_(ツ)_/¯16:41
melwittjroll: ah, so that's what y'all mean by "lock"16:41
dansmithjaypipes: okay16:41
TheJulias/lock/giant flag saying node is in use/16:41
jrollmelwitt: we also have internal locks which block certain actions on the node, so... sometimes :)16:42
melwittyeah, makes sense16:42
melwittheh16:42
melwittjaypipes, dansmith: but it can't be because DHCP, right?16:42
dansmithmelwitt: hmm?16:43
dansmithmelwitt: once you know the host, you can do the binding and get a port allocation at that point16:43
melwittdansmith: like, I had been thinking up to now that we get an IP allocated when we create the neutron port. but in the case of DHCP being used, that would not be true, right?16:43
dansmither, an address allocation for the port I mean16:43
jaypipesmelwitt: yes, when a port is in a subnet that is DHCP-enabled, the port does not get an IP address until after vif plugging (and the DHCP lease is done)16:43
*** pcaruana has joined #openstack-nova16:43
dansmithjaypipes: I think you get an address when you host-bind it, not exactly plug right?16:44
jrollnote that ironic doesn't bind the host to the port in nova, but later in ironic, because it can't be attached to the tenant network until it's deployed16:44
melwittdansmith: because ultimately what they need is to know the IP before they attach the volume. and so far, they have to plug the vif first in order to get the IP. and the problem that's happening is that the vif plug is happening outside of the node reserve lock, so things are racing16:45
jaypipesdansmith: in the case of DHCP, the VIF needs to be fully set up and then the DHCP request made to the gateway, though, right? only after that will the port get an IP adderess.16:45
dansmithjaypipes: you don't have to hit the dhcp server with a client to get an address16:45
jaypipesdansmith: sorry, I wasn't aware that was possible.16:46
dansmithmelwitt: I'm not positive at which exact step neutron will assign an address I guess (plug vs. bind),16:46
dansmithbut I'm nearly positive it happens before the client is really set up,16:46
dansmithotherwise you wouldn't be able to see what ip your instance is going to have until it has come up enough to have hit the dhcp server16:46
melwittdansmith: plug is just a local thing (os-vif in the case of libvirt) so it must be the bind, I think16:46
*** armaan has joined #openstack-nova16:46
dansmithwhich wouldn't make any sense16:46
melwittsean-k-mooney we need you!16:47
melwitt:)16:47
jrollI feel like IP allocation is done at port create time, but I would need to verify16:47
TheJuliaI'm 95% sure it is16:47
dansmithjroll: exactly16:47
melwittthat's what I said earlier16:47
jrolldansmith: with or without a host binding, to be clear16:47
melwittso I was thinking, why not just ask neutron for the IP instead of doing plug_vifs16:47
melwitt*plug_vifs early16:48
dansmithjroll: I think it depends on how the network is setup whether you get it early or late, IIRC, but I dunno16:48
jaypipesdansmith: by "port creation time" are you referring to when neutron port-create is done? because I'm pretty sure that *isn't* when IP allocation is done.16:48
jrollcould be, neutron is just a framework after all :)16:48
*** salv-orl_ has quit IRC16:48
dansmithI think it can happen at port-create time, and I think it can happen at host bind time16:48
dansmithbut I don't think it happens at vif_plug time16:48
melwittyes it's configurable https://developer.openstack.org/api-ref/network/v2/#ip-allocation-extension16:48
*** ccamacho has joined #openstack-nova16:49
dansmiththink about when you're booting an instance and when you get to see the IP via the api in the scheme of it booting16:49
dansmithusually you see it before it has even finished downloaded the image to the compute node right?16:49
melwittright, that's what I thought16:49
melwittbut I thought is that only for static IPs and not DHCP?16:49
melwittI had thought it didn't matter16:50
dansmithdhcp is just how you communicate the ip to the guest,16:50
dansmithI don't think it changes how/when the port would get assigned an ip16:50
jrollmelwitt: so, ironic does a very late host binding of the port, because at that time it's put onto the tenant network (which we don't want during deployment). our plug_vifs call is the api endpoint for the code that does the host binding in ironic: https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L162016:50
melwittyeah, good point. we use DHCP in the gate and yeah, pretty sure the IP is known once the neutron port is created. but we do know that's configurable, not necessarily true that the IP will be known at port create time depending on how the network is setup in neutron, seems like16:51
jroll(and so during BFV deployment, prepare_networks_before_block_device_mapping is a fine time to put it on the tenant network, since we skip the deployment ramdisk)16:52
melwittjroll: yeah, figured it must be because plug_vifs was needed to get the IP16:52
jrollmelwitt: I assume it's just to hook up the networks, but not sure, I don't know this code well16:53
* jroll looks around16:53
artomWhich one between flavor extra specs and image properties is arbitrary again?16:53
dansmithartom: the former16:53
dansmithmelwitt: maybe mlavalle is around and could answer some questions16:53
artomdansmith, so operators can add a "foo" extra spec, and enable a filter (which one?) that would schedule all those foos to a certain aggregate?16:53
jrollah yes, the IP comes from the BDM info: https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L39916:53
*** trinaths has quit IRC16:54
jrollthe plug_vifs call is just to get networking up16:54
melwittjroll: yeah, so back when we started talking about this today I was saying can we decouple the vif plugging from the IP get query and leave the vif plugging for after the node reserve like it used to be. not sure if the host bind should be behind reserve too though16:54
dansmithartom: I have to go look for the linkage every time I'm asked.. I think there is an AggregateExtraSpecs filter or something that you use16:54
jrollmelwitt: the vif plugging is the host bind for us, but yeah, good question16:54
artomdansmith, aha, thanks, I'll dig in the code then16:55
melwittjroll: this is the change that moved vif plug out from the node reserve in order to get an IP for the volume connector https://review.openstack.org/#/c/468353/19/nova/virt/ironic/driver.py16:55
dansmithsee I think in the late case, the host binding step is when you get your allocation16:55
jrollmelwitt: it feels like we could16:55
*** sambetts is now known as sambetts|afk16:55
melwittdansmith: yeah. so would it be safe to do that outside of node reserve? jroll?16:56
jrolldansmith: melwitt: oh, right, that docstring tells us exactly that16:56
melwittbesides that, wouldn't that require a change to ironic API too?16:56
dansmithmelwitt: you can do host binding before spawn, that should be fine, you just can't do the plug before it16:56
*** itlinux has joined #openstack-nova16:57
melwittk16:57
jrollmelwitt: so, the problem we're seeing is when scheduling races with two instances to a node, they both try to do the plug because we haven't set that reservation. so I'm thinking if we do that reservation first thing, then we never hit this again16:57
melwittso it sounds like we have two options: decouple the host binding and do that in prepare_networks_before_block_device_mapping, get the IP for the volume attach, then reserve, then plug vifs etc16:58
melwittor, add a way to do the reserve first thing16:58
dansmithjroll: why are two things racing to the same node?16:58
dansmithjroll: scheduler should have prevented that already16:58
melwittdansmith: the reserve isn't done until spawn16:58
dansmithmelwitt: doesn't matter16:58
jrolldansmith: not a clue16:58
melwitthm16:58
TheJuliaand there can be multiple consumers of ironic's api16:58
*** felipemonteiro__ has joined #openstack-nova16:59
dansmithmelwitt: we have committed the allocation in scheduler, which means the node isn't a candidate for any other scheduler runs16:59
TheJuliaso we can't rely upon nova's scheduler to be the source of truth on locking16:59
dansmithTheJulia: is that it? nova is racing with something else?16:59
*** fragatina has quit IRC16:59
melwittbut is that what's happening in the environment you're seeing the problem? multiple consumers of ironic API?16:59
TheJuliadansmith: nova can race with something else, nova can also race if resource classes are not used, which is how we first noticed the issue actually16:59
jrolloh my16:59
dansmithwell, "if resource classes are not used" should not be a thing17:00
TheJuliaagreed, totally agreed17:00
dansmithbut if it's the former, then that's fine17:00
jrolldansmith: I wasn't aware the allocation in scheduler landed, my bad17:00
*** yamamoto has joined #openstack-nova17:00
dansmithjroll: yeah, so nova racing with something else is a thing, I guess, but makes it less concerning to me17:01
*** felipemonteiro__ has quit IRC17:01
*** derekh has quit IRC17:01
*** felipemonteiro__ has joined #openstack-nova17:01
*** mgoddard has joined #openstack-nova17:01
*** AlexeyAbashkin has quit IRC17:01
* jroll tends to think if ironic is being used with nova it should only be used with nova, but idk17:01
melwittyeah, I mean really I feel like we could just change this to something more generic, "pre-spawn-prep" kind of method and use that to do a node reserve https://review.openstack.org/#/c/468353/19/nova/virt/driver.py17:02
TheJuliajroll: there are some discussions in the hpc/htc world of central ironic, multiple consumers17:02
jrolldansmith: but anyway, I thought there was still an opportunity for a scheduler race, glad to here that's gone17:02
dansmithmelwitt: gotta make sure you have a post-spawn-failure method to unreserve too17:02
TheJulialike, ironic ends up being a central broker of baremetal across datacenters *blink* *blink*17:02
dansmithjroll: not if you're doing the resource class thang17:02
*** felipemonteiro_ has quit IRC17:02
jrollTheJulia: I'm aware people do crazy things with ironic, like using it to manage VMs, I'm not saying it doesn't happen. I'm just saying I'm not sure we should support nova being used with ironic without owning it :)17:03
melwittdansmith: ah, yeah17:03
*** felipemonteiro has joined #openstack-nova17:03
jrolldansmith: sweet.17:03
*** fragatina has joined #openstack-nova17:03
TheJuliadansmith: I think we already rip the instance_uuid in the cleanup17:03
TheJuliarip it off the node that is17:04
TheJuliaso we should be covered if there is a failure17:04
dansmithTheJulia: not if we fail before we called spawn I imagine17:04
openstackgerritEd Leafe proposed openstack/nova master: Address issues raised in adding member_of to GET /a-c  https://review.openstack.org/55435717:04
jrolldansmith: ++17:04
*** edmondsw has quit IRC17:04
dansmithTheJulia: I'm saying if we do a pre-spawn method that could have allocated resources, and then we fail to talk to glance or neutron, we have to make sure we let the virt driver know we were joking17:04
TheJuliadansmith: that is a good point... I thought it still got called but maybe not17:04
TheJuliaoh jeeze, that is another way we could be orphaning vifs17:04
* TheJulia goes and gets liquor17:04
* TheJulia fails to find anything17:05
*** yamamoto has quit IRC17:06
jrollyeah, it does not, only if we fail spawn(). whomp whomp17:06
TheJulia:(17:06
jrollTheJulia: this ensures we don't orphan vifs: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L219817:06
*** felipemonteiro__ has quit IRC17:06
melwittTheJulia, jroll: so what would y'all rather do? pre-spawn and have to deal with failure cleanup cases or do something to allow the host binding to be done separately from plug_vifs? or another solution I'm not thinking of?17:07
TheJuliajroll: if InstanceDeployFailure is added to https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2192 then that would prevent the case I'm seeing in a couple different cases17:07
*** ralonsoh has quit IRC17:07
*** Tom-Tom has joined #openstack-nova17:07
jrollmelwitt: I don't think we can split the host-binding from the plug_vifs, really. I think either way we have to do a pre-spawn, this started with talking about a new method vs hacking it into plug_vifs :)17:08
*** fragatina has quit IRC17:08
TheJuliawhat jroll said :)17:09
melwittokay17:09
jrollTheJulia: that only comes from spawn(), right?17:09
jrollmaybe not :/17:09
efriedmriedem (or anyone): Are you aware of an recent changes in nova or elsewhere that would make instance.uuid stop responding to isinstance(str)?17:09
melwittyeah, I guess duh, the methods that were added have a cleanup with it already too https://review.openstack.org/#/c/468353/19/nova/virt/driver.py17:10
TheJuliajroll: I just spotted https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L221417:10
*** mvk has quit IRC17:10
mriedemefried: nope17:11
efriedk17:11
jrollefried: uuid.uuid4() or whatever will yield some object rather than a string, we tend to use uuidutils.generate<tab>, could be it17:11
jrollTheJulia: ah, yeah17:11
*** fragatina has joined #openstack-nova17:11
*** QianYu has quit IRC17:11
dansmithjroll: instance.uuid will coerce it to a string thouigh17:11
jrollah ok17:11
efriedyeah, see, that's what seems not to be happening anymore in a certain code path for us.17:12
*** arvindn05 has quit IRC17:12
*** jpena is now known as jpena|off17:12
*** tomtom001 has quit IRC17:13
*** kholkina has quit IRC17:14
openstackgerritmelanie witt proposed openstack/nova stable/queens: DNM: testing the ceph job  https://review.openstack.org/56317517:15
*** udesale has joined #openstack-nova17:15
gibiKevin_Zheng: I have an approved bp that could be interesting for you if you have time: https://blueprints.launchpad.net/nova/+spec/add-full-traceback-to-error-notifications17:16
*** fragatina has quit IRC17:17
gibiKevin_Zheng: it is totally OK if you don't have time either, I just wanted advertise the opportunity17:17
*** dtantsur is now known as dtantsur|afk17:17
*** felipemonteiro_ has joined #openstack-nova17:17
*** gjayavelu has joined #openstack-nova17:18
*** tomtom001 has joined #openstack-nova17:19
*** QianYu has joined #openstack-nova17:19
jrollmelwitt: dansmith: jaypipes: thanks for the help, btw :)17:20
*** Tom-Tom has quit IRC17:20
openstackgerritMerged openstack/nova master: Add periodic task to clean expired console tokens  https://review.openstack.org/32538117:20
*** artom_ has joined #openstack-nova17:20
jaypipesjroll: I feel like I did nothing but add confusion to the situation, honestly.17:20
*** artom has quit IRC17:20
*** felipemonteiro has quit IRC17:20
jrolljaypipes: thanks for trying to help? :P17:21
dansmithjroll: jaypipes needs a hug17:21
jrollor a pug17:21
melwittpug hug17:21
*** namnh has quit IRC17:21
dansmithor a pug hug17:21
*** Tom-Tom has joined #openstack-nova17:21
*** tbachman has quit IRC17:21
TheJuliaPug hugs sound far better than cat cuddles... and walking away bleeding17:22
jrolljaypipes: do aussies also cheer you up? https://i.imgur.com/Yswxtpy.jpg17:24
*** arvindn05 has joined #openstack-nova17:24
melwittheh. not our cat. we think he might be part ragdoll17:24
dansmithjroll: I think he only likes ugly dogs17:24
*** QianYu has quit IRC17:24
jrollha, fair17:24
*** jaosorior has quit IRC17:24
jaypipesjroll: ++ aussie's are a good cheerup.17:25
jroll:)17:25
melwittjroll: that's adorbz17:25
dansmithjaypipes: but. but.. their eyeballs are fully contained within their heads...17:25
jrollmelwitt: thanks, make sure you pass it along to james :)17:25
*** namnh has joined #openstack-nova17:25
TheJuliaIt is side conversations like ^^^ why I love this community17:25
*** mdnadeem has quit IRC17:26
melwittjroll: forwarding it now17:26
jaypipesdansmith: details, details...17:27
*** arvindn05 has quit IRC17:27
jaypipesdansmith: they are furry, fluffy and perfect.17:27
jaypipesdansmith: even if they are missing googly eyes.17:27
* dansmith doesn't understand17:27
jaypipesheh17:27
*** evin has joined #openstack-nova17:30
*** arvindn05 has joined #openstack-nova17:30
*** namnh has quit IRC17:30
*** rmart04 has joined #openstack-nova17:31
*** namnh has joined #openstack-nova17:31
TheJuliajroll: Any thoughts on continuing your poc forward or just rewrite mine?17:32
jrollTheJulia: I could do it, or you could take it over, or you could rewrite yours, whatever you'd like to do :)17:33
*** armaan has quit IRC17:33
*** lpetrut_ has joined #openstack-nova17:34
TheJuliaI've got it on the brain so I'll pickup yours and continue it along17:34
jrollawesome, thanks! happy to review if needed17:36
jrollTheJulia: fyi I probably picked up your bug from patchset 1 where you needed the patch wrapped in []17:36
*** fragatina has joined #openstack-nova17:37
TheJuliamy brain is currently trying to think of any other ways we could be leaking vifs and thus blocking future deploys outside of tearing down an instance and I'm not thinking of any17:37
openstackgerritJay Pipes proposed openstack/os-traits master: Add compute capabilities traits  https://review.openstack.org/54671317:37
TheJuliajroll: easy fix :)17:37
*** lpetrut has quit IRC17:38
jaypipesartom_, gibi, efried: addressed the rewording in https://review.openstack.org/#/c/546713/.17:38
melwittmriedem: why do you think we can't drop the API code until T? I thought once all computes are upgraded to rocky, then things are guaranteed to all be using the database backend, so removal would be in Stein? https://review.openstack.org/#/c/325414/31/nova/compute/api.py@361317:38
jrollTheJulia: yep, just a heads up so you don't wait an hour for CI to find it :)17:38
gibijaypipes: thanks, +217:39
mriedemmelwitt: i might have been overthinking it17:39
melwittk, just trying to make sure there's not something I'm missing17:40
mriedemreplied to clarify17:40
melwittcool thanks17:41
*** abhishekk has joined #openstack-nova17:41
*** jaypipes is now known as jaypipes-lunch17:43
sean-k-mooneymelwitt: sorry i was in meeting for the last 4 hours. did ye resolve the issue ye were having?17:43
melwittsean-k-mooney: yeah, I think so. we were talking about, when is a port guaranteed to have an IP allocated to it? maybe never, but it sounded like after host binding it has to?17:44
*** namnh has quit IRC17:44
*** dpawlik has joined #openstack-nova17:45
openstackgerritMerged openstack/nova master: Extract generate_hostid method into utils.py  https://review.openstack.org/55528217:45
sean-k-mooneymelwitt: right so with multi segment, l3 routed  networks the allocation of the ip happens only when the port is bound to a specific host. for the general case the port will get an ip when it is created but you can have ports that only have mac adresses17:45
*** rmart04 has quit IRC17:45
*** namnh has joined #openstack-nova17:45
*** cristicalin has joined #openstack-nova17:46
*** rmart04 has joined #openstack-nova17:46
melwittsean-k-mooney: gotcha. thanks17:46
sean-k-mooneymelwitt: so after you do port binding it should have an ip if it is connected to a neutron network that has a subnet17:46
*** cristicalin has quit IRC17:47
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Network bandwidth resource provider  https://review.openstack.org/50230617:47
*** tbachman has joined #openstack-nova17:49
melwittsean-k-mooney: okay, so it's not ever necessarily guaranteed (would a neutron network ever not have a subnet?). we were looking at some code in the ironic driver where they need to get the IP in order to hand it to the volume connector (some volume backends require the IP before attaching). and we were wondering, at what point could one reliably query for the IP17:49
*** dpawlik has quit IRC17:50
sean-k-mooneymelwitt: neutron allows your to have interfaces with no ips. nova used to require one for a neutron port to be used with an vm/instance but that requrement was removed.17:50
sean-k-mooneymelwitt: the reason it was removed was to cater for non ip networking e.g. infinaband over ethernet17:51
melwittI see17:51
sean-k-mooneymelwitt: it sound like in the ironic case there is a hard requirement for an ip presuable you are using it to configre iscsi targest for the baremtal not or something like that?17:52
melwittsean-k-mooney: yeah must be a hard requirement. it's already doing it like this https://review.openstack.org/#/c/468353/19/nova/virt/ironic/driver.py but yeah need the IP to set in the volume connector17:53
*** tbachman has quit IRC17:54
*** namnh has quit IRC17:55
sean-k-mooneyin general l2 only connectivity is not common in neutron so this is an extream edgecase.17:55
melwittand the problem was that they have to do their equivalent of "plug_vifs" first in order to get the IP and that's happening outside their node reserve lock and there are races happening. so at first we were talking about "can we get the IP before plugging the vif" but it ended up not mattering and the solution needs to be to reserve the node first before doing anything with the networking17:55
*** edmondsw has joined #openstack-nova17:56
*** udesale has quit IRC17:57
openstackgerritMerged openstack/nova master: Address nits in I00d29e9fd80e6b8f7ba3bbd8e82dde9d4cb1522f  https://review.openstack.org/56149317:58
*** bkopilov has quit IRC17:59
*** namnh has joined #openstack-nova18:00
sean-k-mooneyfrom a ironic perspective i think its prefectly resonable to scope the cinder volume support to jsut  instance with ips at a first pass. volumes attached over infinaband is something in the storage space where we might not have ips but that is less common.18:00
*** tbachman has joined #openstack-nova18:01
melwittyeah, that's what they've done18:01
*** wolverineav has joined #openstack-nova18:01
*** moshele has joined #openstack-nova18:02
*** yamamoto has joined #openstack-nova18:03
*** edmondsw_ has joined #openstack-nova18:03
*** mvk has joined #openstack-nova18:03
openstackgerritMerged openstack/nova stable/ocata: Add regression test for persisted RequestSpec.retry from failed resize  https://review.openstack.org/56016218:05
openstackgerritMerged openstack/nova stable/ocata: Don't persist RequestSpec.retry  https://review.openstack.org/56016718:05
openstackgerritMerged openstack/nova stable/ocata: only increment disk address unit for scsi devices  https://review.openstack.org/56161318:05
*** edmonds__ has joined #openstack-nova18:05
*** edmonds__ is now known as edmondsw__18:06
*** edmondsw__ is now known as edmondsw___18:06
*** edmondsw has quit IRC18:06
*** edmondsw___ is now known as edmondsw18:06
*** wolverineav has quit IRC18:06
*** yamamoto has quit IRC18:08
efriedcdent: yt?18:09
*** edmondsw_ has quit IRC18:09
cdentefried: hi, yup18:09
efriedcdent: Good evening to you.  Do you know of any reason Instance.uuid would or would not respond to isinstance(str) ?18:09
*** namnh has quit IRC18:10
*** moshele has quit IRC18:10
cdentI read you talking about that a bit earlier, but didn't chase it. Is it showing up in a particular piece of code that I can poke at? Have you been able to find out what type it is when that happens? Or is it a racey thing that you've got no easy replication for?18:11
sean-k-mooneyefried: cdent jaypipes-lunch  i need to run very soon but was a decision reached on the mailing list of how to proceed with resouce provider groups?18:13
efriedsean-k-mooney: You mean whether numbered groups are separate by default or unrestricted?18:14
cdentsean-k-mooney: I think you mean this https://review.openstack.org/#/c/562687/18:14
sean-k-mooneyefried: yes. last i read was matt suggesting that its explcit18:14
efriedsean-k-mooney: Yup, what cdent said - that guy has (all the links to) all the info you need.18:14
efriedcdent: This is what I'm chasing down: http://184.172.12.213/58/557958/10/check/nova-out-of-tree-pvm/c1d7e99/logs/n-cpu.txt.gz?#_Apr_20_08_51_16_45265118:15
sean-k-mooneycdent: thanks im out of office tomrow but ill print out the current version and review tomrow.18:15
cdentthanks efried18:15
sean-k-mooneyefried: im glad ye found a path forward18:15
cdentwoah, colors finally merged18:15
efriedcdent: No, I think that's just because it's in our CI env and I have that patched in there (cause that's where I was testing it)18:16
sean-k-mooneycdent: colors?18:16
efriedcdent: But you should definitely tell everybody how much you like it in https://review.openstack.org/524744 so they might merge it.18:17
cdentoh, sorry, didn't recognize that was your ci efried18:17
melwittcdent: I had wanted to bring this bug to your attention, in case you might have some idea why the test_wsgi stuff would fail with webob 1.8.1 https://bugs.launchpad.net/nova/+bug/176574818:17
openstackLaunchpad bug 1765748 in OpenStack Global Requirements "webob-1.8.1 breaks projects" [High,In progress] - Assigned to Matthew Thode (prometheanfire)18:17
*** esberglu has joined #openstack-nova18:17
*** lpetrut_ has quit IRC18:17
*** esberglu has quit IRC18:17
*** esberglu has joined #openstack-nova18:18
efriedcdent: Anyway, the deal here is that powervm has a utility method that accepts either an integer ID or a UUID.  It detects which one it is and then behaves accordingly.  The code that does that hasn't changed in yeeears.18:18
efriedThe code path that calls it is when we're disconnecting a disk, which (I think) also hasn't changed in yeeeears.18:18
sean-k-mooneymelwitt: the stack trace look like one that we get when we need to cap a dependcy in upper constrataint because of an incompatible change18:19
cdentmelwitt: hmmm. webob often breaks such stuff, but that looks like a bad mock? is there an in-nova example?18:19
efriedcdent: But suddenly on Friday afternoon, our CI started failing with that error.  I don't actually know what type it thinks it has in there - just know that isinstance(str) is failing where it didn't before.18:19
mriedemsean-k-mooney: totally unrelated to what you're talking about, but i'm a bit lost in https://review.openstack.org/#/c/551370/16/nova/virt/libvirt/migration.py@229 and looking for some feedback when you get a chance18:19
cdentefried: still parsing18:20
*** bkopilov has joined #openstack-nova18:20
sean-k-mooneymriedem:  in the generation of the updated xml for the vif on the destination node18:21
mriedemsean-k-mooney: yeah, i'm looking at how _update_volume_xml works and it's basically an update of any volume disks on the source using the destination block device config18:21
mriedemit does that by keying off the volume 'serial' which is the volume id18:21
mriedemwe don't have something like that for the interface config in a domain xml18:22
sean-k-mooneymriedem: we could posibly key of the interface mac adress18:22
mriedemi'm not really even sure if i should be updating the interface xml entries, or replacing them18:22
mriedemi.e. i'm trying to handle the case that you're live migrating from a host using ovs to a host using ovn, or linuxbridge, or vhostuser, et al18:23
sean-k-mooneythat said im not sure if we can have a vm with two port with the same mac..18:23
*** jaypipes-lunch is now known as jaypipes18:23
mriedemi've been trying to write a test for this for a couple of hours and it just seems like doing a vif type conversion like this down in the bowels of the xml code is going to be....not reasy18:23
mriedem*easy18:23
sean-k-mooneymriedem: right in that case we are replaceing them but we likely want to keep the guest pci adress the same on both ends18:23
*** amoralej is now known as amoralej|off18:24
mriedemyeah the only thing that _update_volume_xml doesn't change is the address18:24
cdentefried: so "ValueError: invalid literal for int() with base 10: '4E27E1E6-6A24-4F0A-8E7B-2BBE7B4A28BA'" is caused by a conditional faililng somewhere that wasn't before? I'm unable to grep isinstance anywhere in the log?18:25
efriedcdent: It's caused by this: https://github.com/powervm/pypowervm/blob/master/pypowervm/utils/uuid.py#L5018:25
efriedThat isinstance() fails, so we try to int() the UUID on L55, leading to the ValueError.18:26
mriedemefried: have you looked at https://github.com/openstack/oslo.versionedobjects/compare/1.32.0...1.33.1 ?18:26
mriedemhttps://github.com/openstack/oslo.versionedobjects/commit/b1d0b5d886afef8c08330bf3c2291e180aa1f53418:27
efriedcdent: or, shit, I guess it's possible the regex match could be failing.  But when I str(instance.uuid) up the stack, it succeeds.18:27
efriedmriedem: looking...18:27
sean-k-mooneymriedem: so if we can assume that the vm cannont have 2 intefaces with the same mac then i think that is likely the best way to approch. if we had a way to store the neutron port uuid in the xml that would help alot but i dont think we can do that with libvirt18:27
efriedmriedem: Bingo.  When did we subsume that req?18:27
efriedin nova18:27
efriedin queens18:27
efriedcause I looked for that18:28
mriedemefried: upper-constraints on friday for rocky18:28
mriedemhttps://github.com/openstack/requirements/commit/87540884100650cfd1a67f05163a724906efb46f#diff-0bdd949ed8a7fdd4f95240bd951779c818:28
efriedahhhh, upper-constraints.18:28
efriedYup, that'd do it.  Thanks mriedem18:28
efriedI knew you would come through for me.18:28
*** gyee has quit IRC18:28
* cdent is relieved18:28
efriedmriedem: That same thing must have gone into queens somehow.18:30
mriedemor your CI is using the wrong upper-constraints?18:30
mriedemyour queens CI is likely pointing at master18:30
mriedemalthough maybe not https://github.com/openstack/oslo.versionedobjects/commit/e918eb976fb5a6f9fa7b7644d5a10d383fcfcf2118:31
mriedemhttps://review.openstack.org/#/q/Ic6b6308fb1960ec40407e6efde30137b64543e7218:31
mriedemthat's not released yet on stable though18:32
*** pcaruana has quit IRC18:32
*** moshele has joined #openstack-nova18:32
cdentefried: even if that change isn't your problem, it may be the clue. are you in py2?18:33
mriedemsean-k-mooney: so do you think this is safe https://review.openstack.org/#/c/551370/16/nova/virt/libvirt/migration.py@229 where it's basically taking the source vif and just overwriting whatever we got from the dest to get the new config xml?18:33
*** mgoddard has quit IRC18:33
efriedcdent: Probably18:34
cdentso if you've got a unicode there (for whatever random reason)18:34
efriedcdent: Our "official" fix is going to be using is_uuid_like.  But that's going to require changes to pypowervm, which is going to need a requirements bump, which I'm not sure if we can swing in stable.  Because we're going to have the same problem in nova (right esberglu?)18:35
*** moshele has quit IRC18:36
cdentI'm totally riffing at this point (because multitasking), but does six.text_type make a difference?18:36
sean-k-mooneymriedem: my concern is how to you merge the two so that if i have a vm with 2 interfaces of the same type they dont swap places e.g. eth0 becomes eth1 and vice versa.18:36
efriedand pike18:36
esbergluefried: That wasn't hitting queens18:37
esbergluOnly master18:37
efriedesberglu: See email - it is now.18:37
efriedand based on https://review.openstack.org/#/q/Ic6b6308fb1960ec40407e6efde30137b64543e72 it'll hit pike as soon as that percolates down.18:37
cdentmelwitt: okay, I've repeated fhe failures so can look more sensibly now18:37
sean-k-mooneymriedem: i think you will have to loop over each interface element in the original xml and find the corresponding vif based on mac and then update the xml with the new atributes but maintain the order of the interfaces and maintianing the guest pci adress18:38
*** felipemonteiro__ has joined #openstack-nova18:39
*** felipemonteiro_ has quit IRC18:39
mriedemsean-k-mooney: but wouldn't it we be weird to have interface xmls from the guest with certain source bridge and target dev values which are then unchanged on the dest host, but things like the vif type and vnic type could change?18:39
melwittthanks cdent18:39
melwittmriedem: pike https://review.openstack.org/#/c/562879 and ocata https://review.openstack.org/#/c/564044 release reviews for your perusal18:40
sean-k-mooneymriedem: the bridge name might change on the dest as might hte vhost-user socekt path.18:40
sean-k-mooneymriedem: centos use /run/openvswitch/... ubuntu uses /var/run/openvswitch/...18:40
mriedemsean-k-mooney: but we don't have the bridge name in the migrate data object from the dest when we're munging the guest xml on the source18:40
sean-k-mooneymriedem: you should have that as we have already created the binding on the dest host but not activated it18:41
sean-k-mooneymriedem: it will be in the respocne from neutron18:41
mriedemis that in the details or profile dict?18:42
sean-k-mooneyits in the vif binding_details18:42
sean-k-mooneyi belive the key is just bridge_name18:42
sean-k-mooneymriedem: yep https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/portbindings.py#L5318:43
cdentmelwitt: looks like a google summoer of code project totally revamped accept* handling in webob 1.8.*. still digging up details18:43
mriedemis the vhostuser socket patch also in the vif binding details dict?18:43
mriedem*path18:43
sean-k-mooneyyes18:43
mriedemok18:43
sean-k-mooneyget_vif_config(vif=vif) is the same fuction we use when spawning a vm right?18:44
mriedemyes18:44
sean-k-mooneyif so it should be able to extract that info from the vif object18:44
sean-k-mooneyok cool18:44
mriedemsean-k-mooney: when you say "maintain the guest pci address" i don't see anything in the interface elements in the xml, e.g. http://logs.openstack.org/95/563995/1/check/neutron-tempest-linuxbridge/a3015a9/logs/screen-n-cpu.txt#_Apr_24_16_42_59_32734218:46
mriedemoh, is that only for sriov ports?18:46
mriedemlike vnic_type='direct'?18:47
sean-k-mooneyno the libvirt xml for the running vm is not the same as the one we hand to libvirt. it adds pci adress for each device itself18:47
sean-k-mooneyat least i think it does let me dump the xml from a running vm18:48
sean-k-mooneymriedem: so this is a running vm xml http://paste.openstack.org/show/719855/18:51
sean-k-mooneythe interfaces have an addtional <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> element added which is the guest virtual pci adresss18:51
sean-k-mooneywhen we generate the xml fragment using get_vif_config we do not set that18:52
mriedemright18:52
sean-k-mooneyso if you just merged the generated fagment with the exising interface and done touch the adress element it will be fine18:52
mriedemwe can parse it out of the running domain18:52
sean-k-mooneyyep18:52
mriedemso here is another wrinkle wrt merging,18:53
mriedemlet's say i'm starting from a source host with ovs and have an interface element like this http://paste.openstack.org/show/719858/18:53
mriedem<source bridge="qbra188171c-ea"/>18:53
*** rmart04 has quit IRC18:53
mriedemthen i live migrate to a dest host using vhostuser,18:53
mriedemlooking at a dpdk vhostuser CI logs, that is something like http://paste.openstack.org/show/719857/18:53
mriedem<source mode="server" path="/var/run/openvswitch/vhu88445a68-94" type="unix"/>18:53
mriedemif we merge those, we have something like <source bridge="qbra188171c-ea" mode="server" path="/var/run/openvswitch/vhu88445a68-94" type="unix"/>18:54
mriedemi would expect that to totally eff with libvirt/qemu18:54
mriedemunless it's smart enough to only parse out attributes that it knows matter for the given interface type18:54
sean-k-mooneyright so if the vif types change we just want to copy the adress element other wise we replace it with the new vif18:54
sean-k-mooneythat might work in all cases actully18:55
mriedemaddress or mac address?18:55
mriedemget_vif_config doesn't give me the device address18:55
*** ociuhandu has joined #openstack-nova18:55
*** xinliang has quit IRC18:56
sean-k-mooneythe address element e.g. guest pci adress18:56
sean-k-mooneyso we jsut copy the <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> form the runing xml and add it ot what we get form get_vif_config18:57
sean-k-mooneyi think that will always be correct even if the vifs types are the same as i think that is the only thing we dont set18:57
*** suresh12 has joined #openstack-nova18:58
*** suresh12 has quit IRC18:58
mriedemyeah ok18:58
mriedemi knew there was a reason i've been putting off implementing this TODO18:59
*** sridharg has quit IRC18:59
sean-k-mooneymriedem: ya its a bit of a pain but its doable. here is a xml from a running guest with vhost user for reference http://paste.openstack.org/show/719861/19:00
*** gjayavelu has quit IRC19:00
sean-k-mooneyyou should be able to use that to fake out the conversion from http://paste.openstack.org/show/719855/ which is kernel ovs19:00
sean-k-mooneythose are two completely different vms unfortunetly but atleast it has the interface definitions which is what you need19:01
*** gjayavelu has joined #openstack-nova19:02
*** dims has quit IRC19:02
sean-k-mooneyi have a 2 hour drive to my parents to do tonight so i have to run. ill be offline tomrow but feel free to ping me later in the week if you want any more input.19:03
*** abhishekk has quit IRC19:03
*** gjayavelu has quit IRC19:03
*** yamahata has joined #openstack-nova19:04
mriedemack, thanks19:04
*** yamamoto has joined #openstack-nova19:04
*** lpetrut_ has joined #openstack-nova19:04
efriededmondsw, esberglu, mriedem: https://bugs.launchpad.net/pypowervm/+bug/176669219:06
openstackLaunchpad bug 1766692 in pypowervm "instance.uuid no longer being a str breaks powervm scsi disconnect" [Undecided,New]19:06
efriedmriedem: What are the odds of backporting a pypowervm requirements bump to queens & pike?19:07
mriedemnot good19:08
mriedemi don't understand why this is an issue on stable though19:08
*** dims has joined #openstack-nova19:09
*** yamamoto has quit IRC19:10
*** esberglu has quit IRC19:11
*** xinliang has joined #openstack-nova19:11
openstackgerritMerged openstack/os-traits master: Add compute capabilities traits  https://review.openstack.org/54671319:11
*** imacdonn has quit IRC19:14
*** ktibi has quit IRC19:14
edmondswmriedem because https://review.openstack.org/#/q/Ic6b6308fb1960ec40407e6efde30137b64543e72 was backported to pike and queens19:14
*** esberglu has joined #openstack-nova19:14
*** imacdonn has joined #openstack-nova19:14
edmondswI suspect we'll have to do something like https://review.openstack.org/#/c/563314/1/nova_powervm/virt/powervm/vm.py@808 for pike and queens, as much as I hate that, to avoid a pypowervm requirements bump19:15
edmondswbut if we could get a bump, we could avoid that19:15
*** salv-orlando has joined #openstack-nova19:16
*** Tom-Tom has quit IRC19:17
mriedemedmondsw: those aren't released in pike or queens19:18
mriedemupper-constraints depends on released packages on pypi19:18
mriedemare you guys sure that your CI running against stable isn't using upper-constraints from master?19:19
edmondswmriedem yes, we're sure19:19
edmondswbut I'm not following you19:19
mriedemyour CI should not be pulling in those changes from stable19:20
*** abhishekk has joined #openstack-nova19:20
edmondswI don't know that we've seen this in CI for stable... we just saw that it merged in stable19:20
edmondswwe've seen this in CI for master19:20
mriedemthen you revert those changes before they are released19:20
mriedemor, backport whatever the fix ends up being from master19:21
edmondswfor master, we should just fix pypowervm and bump requirements19:21
edmondswhence the question of whether we can backport a requirements bump19:22
edmondswwe could try to get the oslo change reverted19:22
efriedmriedem: We have seen this in queens, live, this morning.19:22
mriedemefried: in CI?19:22
efriedno, live.19:23
mriedemif so, link me to the failed patch19:23
mriedemso someone isn't using upper-constraints in production19:23
efriedesberglu: Can you spin up a queens CI run without the pypowervm patch so we can confirm whether this fails there?19:23
efriedplease and thank you19:23
esbergluefried: Sure19:23
mriedemalso, i don't know what "live" means here, in your internal CI/CD pipeline? in a customer site, in some ibm public cloud service, other?19:24
*** tesseract has quit IRC19:26
*** abhishekk has quit IRC19:26
efriedmriedem: An internal customer, I think.19:32
efriedmriedem: They claim to have installed canonical's nova-compute/Queens and then nova-powervm stable/queens via git clone.19:33
efriedand python setup.py install19:33
mriedemalright, well, they aren't using upper-constraints,19:40
mriedemor testing what they are doing apparently if they are pushing that to production19:40
*** jackie-truong has quit IRC19:44
openstackgerritMerged openstack/nova master: Update os_compute_api:os-flavor-extra-specs:index docs for 2.61  https://review.openstack.org/56140419:50
openstackgerritMerged openstack/nova master: docs: link to volume multi-attach demo recording  https://review.openstack.org/56373419:50
*** READ10 has quit IRC19:58
cdentmelwitt: I dumped a small amount of state on that bug. 1.8.x is way different and my brain has stalled for the day.20:00
*** fragatina has quit IRC20:01
*** cdent has quit IRC20:01
melwittcdent: cool, thanks for looking into it. much appreciated20:01
*** fragatina has joined #openstack-nova20:02
*** weshay has quit IRC20:05
*** yamamoto has joined #openstack-nova20:06
*** lpetrut_ has quit IRC20:07
*** weshay has joined #openstack-nova20:07
*** yamamoto has quit IRC20:11
*** hemna_ has quit IRC20:11
*** itlinux has quit IRC20:13
openstackgerritmelanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations  https://review.openstack.org/32541420:14
openstackgerritmelanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation  https://review.openstack.org/33399020:14
openstackgerritmelanie witt proposed openstack/nova master: Update layout docs for running console proxies  https://review.openstack.org/55748920:14
*** dklyle has quit IRC20:18
*** itlinux has joined #openstack-nova20:19
*** fragatina has quit IRC20:22
*** fragatina has joined #openstack-nova20:22
*** liuzz has quit IRC20:25
*** slaweq has quit IRC20:25
*** slaweq has joined #openstack-nova20:26
*** dougshelley66 has quit IRC20:26
*** Tom-Tom has joined #openstack-nova20:27
*** yamahata has quit IRC20:29
*** liuzz has joined #openstack-nova20:29
*** priteau_ has joined #openstack-nova20:31
*** Tom-Tom has quit IRC20:32
*** evin has quit IRC20:33
*** priteau has quit IRC20:34
*** hemna_ has joined #openstack-nova20:37
*** gouthamr has quit IRC20:38
*** damien_r has joined #openstack-nova20:38
*** alexchadin has joined #openstack-nova20:38
*** alexchadin has quit IRC20:38
*** damien_r has quit IRC20:38
*** damien_r has joined #openstack-nova20:38
openstackgerritEric Fried proposed openstack/nova master: Proxy is_volume through DriverBlockDevice  https://review.openstack.org/56401720:39
efriedmriedem, melwitt, TheJulia: With UT ^20:39
TheJuliaefried: awesome!20:39
*** eharney has joined #openstack-nova20:41
*** gjayavelu has joined #openstack-nova20:41
*** READ10 has joined #openstack-nova20:42
*** gouthamr has joined #openstack-nova20:43
*** damien_r has quit IRC20:44
*** pchavva has quit IRC20:46
*** moshele has joined #openstack-nova20:47
*** moshele has quit IRC20:50
*** jmlowe has joined #openstack-nova20:50
*** jmlowe has quit IRC20:52
*** liuzz_ has joined #openstack-nova20:54
esbergluefried: Queens CI is fine without the pypowervm patch20:54
esbergluMust have been something wrong on the customers end20:55
efriedesberglu: Yeah, what's weird is, I'm talking to Vlad and he's got 1.31.2 installed - which should be fine.20:55
*** liuzz has quit IRC20:55
efriedesberglu: But he may have had some pip weirdness hanging around before.20:55
*** dklyle has joined #openstack-nova20:56
efriedesberglu: so - that's a relief.  We only need to fix this in master.  But also, https://review.openstack.org/#/c/560639/  (edmondsw FYI)20:56
*** dougshelley66 has joined #openstack-nova20:57
edmondswefried well not quite... they haven't cut oslo.versionedobjects releases for stable pike/queens *yet* but that doesn't mean they aren't going to20:57
efriededmondsw: But they *aren't* going to bump upper-constraints for same.20:57
edmondswI fully expect they will, or they wouldn't have backported20:57
efriededmondsw: But also ---^20:58
edmondswefried they won't need to20:58
efriededmondsw: What do you mean?20:58
efriededmondsw: If they don't bump upper-constraints in pike/queens, then it's illegal to use the bad versions of the packages.20:58
efriedillegal => unsupported20:59
edmondswoh, well you're right, they would... I thought u-c was setup differently than it is20:59
edmondswbut why do you think they won't update u-c?20:59
edmondswI fully expect they will20:59
edmondswas they have in the past20:59
efriedWell, they recognize this one is broken, so hopefully they'll wait until the backports of ----^ merge.20:59
edmondswefried ok that I agree with21:00
*** Tom-Tom has joined #openstack-nova21:01
*** Tom-Tom has quit IRC21:05
*** yamamoto has joined #openstack-nova21:08
*** yamahata has joined #openstack-nova21:09
*** edmondsw_ has joined #openstack-nova21:11
*** itlinux has quit IRC21:12
*** rajinir has quit IRC21:12
*** edmondsw has quit IRC21:13
*** yamamoto has quit IRC21:14
*** dklyle has quit IRC21:14
*** slaweq has quit IRC21:14
openstackgerritChris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job  https://review.openstack.org/56406721:15
*** slaweq has joined #openstack-nova21:15
openstackgerritChris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job  https://review.openstack.org/56406721:15
*** slaweq has quit IRC21:20
*** tbachman has quit IRC21:24
*** munimehan has quit IRC21:32
*** priteau_ has quit IRC21:32
*** wolverineav has joined #openstack-nova21:35
*** awaugama has quit IRC21:35
*** namnh has joined #openstack-nova21:37
*** ociuhandu has quit IRC21:39
*** sdague has quit IRC21:42
*** tbachman has joined #openstack-nova21:43
*** dklyle has joined #openstack-nova21:44
*** ociuhandu has joined #openstack-nova21:46
*** gjayavelu has quit IRC21:49
*** tbachman has quit IRC21:49
openstackgerritMatt Riedemann proposed openstack/nova master: Wait for network-vif-plugged before starting live migration  https://review.openstack.org/55800121:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available  https://review.openstack.org/52354821:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method  https://review.openstack.org/52360421:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method  https://review.openstack.org/55217021:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method  https://review.openstack.org/55594721:51
openstackgerritMatt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True  https://review.openstack.org/55633321:51
openstackgerritMatt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron  https://review.openstack.org/55633421:51
openstackgerritMatt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration  https://review.openstack.org/51542321:51
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration  https://review.openstack.org/55137021:51
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration  https://review.openstack.org/55137121:51
openstackgerritMatt Riedemann proposed openstack/nova master: Port binding based on events during live migration  https://review.openstack.org/43487021:51
openstackgerritMatt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate  https://review.openstack.org/52253721:51
*** r-daneel has quit IRC21:52
*** tbachman has joined #openstack-nova21:54
*** edmondsw_ has quit IRC21:55
*** abalutoiu has joined #openstack-nova21:56
*** abalutoiu_ has quit IRC21:57
*** abalutoiu_ has joined #openstack-nova22:02
*** mriedem has quit IRC22:03
*** esberglu has quit IRC22:04
*** edmondsw has joined #openstack-nova22:05
*** edmondsw has quit IRC22:05
*** moshele has joined #openstack-nova22:06
*** burt has quit IRC22:06
*** abalutoiu has quit IRC22:06
*** namnh has quit IRC22:07
*** yamamoto has joined #openstack-nova22:09
*** cfriesen has quit IRC22:11
*** yamamoto has quit IRC22:14
*** dave-mccowan has quit IRC22:15
*** esberglu has joined #openstack-nova22:17
*** gyee has joined #openstack-nova22:23
*** Guest46588 has quit IRC22:32
*** ociuhandu_ has joined #openstack-nova22:32
*** ociuhandu has quit IRC22:33
openstackgerritMichael Still proposed openstack/nova master: Move image conversion to privsep.  https://review.openstack.org/55443722:35
openstackgerritMichael Still proposed openstack/nova master: We don't need utils.trycmd any more.  https://review.openstack.org/55443922:35
openstackgerritMichael Still proposed openstack/nova master: We no longer need rootwrap.  https://review.openstack.org/55443822:35
*** efried has quit IRC22:42
*** moshele has quit IRC22:43
*** liverpooler has quit IRC22:47
openstackgerritArvind Nadendla proposed openstack/nova master: update scheduler to use image-traits  https://review.openstack.org/56059622:54
Kevin_Zhengmriedem I can take the traceback BP, that one seems easy22:56
Kevin_ZhengI already start working on migration one, had some poc in my pc, and setting up multi-node env for further testing last night, since we moved to our public cloud, I have to set up a new one:)22:58
*** dougshelley66 has quit IRC23:02
*** dougshelley66 has joined #openstack-nova23:02
*** yamamoto has joined #openstack-nova23:10
*** felipemonteiro__ has quit IRC23:16
*** yamamoto has quit IRC23:16
*** sdague has joined #openstack-nova23:16
*** tbachman has quit IRC23:17
*** chyka_ has quit IRC23:29
*** hongbin_ has quit IRC23:33
*** mlavalle has quit IRC23:38
*** Tom-Tom has joined #openstack-nova23:40
*** QianYu has joined #openstack-nova23:42
*** Tom-Tom has quit IRC23:45
*** sdeath has joined #openstack-nova23:49
*** sdeath has joined #openstack-nova23:49
*** stakeda has joined #openstack-nova23:49
*** hoonetorg has quit IRC23:52
*** QianYu has quit IRC23:55
*** yamamoto has joined #openstack-nova23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!