| *** salv-orlando has joined #openstack-nova | 00:00 | |
| *** jroll has joined #openstack-nova | 00:00 | |
| *** salv-orlando has quit IRC | 00:05 | |
| *** yamamoto has joined #openstack-nova | 00:06 | |
| *** tssurya has quit IRC | 00:06 | |
| *** liverpooler has joined #openstack-nova | 00:06 | |
| *** fragatina has quit IRC | 00:08 | |
| *** sean-k-mooney[m] has quit IRC | 00:09 | |
| *** yamamoto has quit IRC | 00:11 | |
| *** jroll has quit IRC | 00:16 | |
| *** jroll has joined #openstack-nova | 00:17 | |
| *** slaweq has joined #openstack-nova | 00:17 | |
| *** slaweq has quit IRC | 00:21 | |
| *** Tom-Tom has joined #openstack-nova | 00:22 | |
| *** Tom-Tom has quit IRC | 00:27 | |
| *** yingjun has joined #openstack-nova | 00:30 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:30 | |
| *** yingjun has quit IRC | 00:30 | |
| *** yingjun has joined #openstack-nova | 00:31 | |
| *** yingjun has quit IRC | 00:32 | |
| *** vladikr has quit IRC | 00:36 | |
| *** hiro-kobayashi has joined #openstack-nova | 00:46 | |
| *** yingjun has joined #openstack-nova | 00:48 | |
| *** wolverin_ has quit IRC | 00:48 | |
| *** wolverineav has joined #openstack-nova | 00:48 | |
| *** jichen has joined #openstack-nova | 00:58 | |
| *** Tom-Tom has joined #openstack-nova | 00:59 | |
| *** fabian_ has joined #openstack-nova | 01:00 | |
| *** andreas_s has joined #openstack-nova | 01:00 | |
| *** mriedem has quit IRC | 01:01 | |
| *** Tom-Tom has quit IRC | 01:04 | |
| *** fabian_ is now known as chenyb4 | 01:04 | |
| *** andreas_s has quit IRC | 01:05 | |
| *** tiendc has joined #openstack-nova | 01:06 | |
| *** Tom-Tom has joined #openstack-nova | 01:06 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.61 - support extra_specs in flavor API https://review.openstack.org/561520 | 01:06 |
|---|---|---|
| *** yamamoto has joined #openstack-nova | 01:07 | |
| *** hongbin_ has joined #openstack-nova | 01:12 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.61 - support extra_specs in flavor API https://review.openstack.org/561520 | 01:12 |
| *** yamamoto has quit IRC | 01:13 | |
| *** hoangcx has joined #openstack-nova | 01:13 | |
| *** zhaochao has joined #openstack-nova | 01:13 | |
| *** phuongnh has joined #openstack-nova | 01:15 | |
| *** esberglu has quit IRC | 01:16 | |
| arvindn051 | how do we get host uuid from hostname? | 01:16 |
| arvindn051 | i am trying to get the host uuid for host specified in the request_spec | 01:17 |
| *** gjayavelu has quit IRC | 01:19 | |
| *** liuzz_ has quit IRC | 01:23 | |
| *** xinliang has quit IRC | 01:23 | |
| *** Tom-Tom has quit IRC | 01:25 | |
| *** stakeda has joined #openstack-nova | 01:27 | |
| *** yamahata has quit IRC | 01:29 | |
| *** yikun has joined #openstack-nova | 01:29 | |
| *** yikun_ has quit IRC | 01:31 | |
| *** wolverineav has quit IRC | 01:35 | |
| *** wolverineav has joined #openstack-nova | 01:36 | |
| *** mvk has quit IRC | 01:37 | |
| *** liverpooler has quit IRC | 01:39 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries https://review.openstack.org/558045 | 01:40 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree https://review.openstack.org/559480 | 01:40 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories https://review.openstack.org/559554 | 01:40 |
| *** janki has joined #openstack-nova | 01:42 | |
| *** wolverineav has quit IRC | 01:44 | |
| *** Tom-Tom has joined #openstack-nova | 01:46 | |
| *** mvk has joined #openstack-nova | 01:51 | |
| *** bingqianglin has joined #openstack-nova | 01:54 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.62 - List/Show all server migration types https://review.openstack.org/430839 | 01:54 |
| *** dougshelley66 has quit IRC | 01:55 | |
| *** rnoriega_ has joined #openstack-nova | 02:01 | |
| *** weshay_ has joined #openstack-nova | 02:01 | |
| *** markmc has joined #openstack-nova | 02:01 | |
| *** kashyap` has joined #openstack-nova | 02:02 | |
| *** markmc`` has joined #openstack-nova | 02:02 | |
| *** kashyap`` has joined #openstack-nova | 02:02 | |
| *** kashyap`` has joined #openstack-nova | 02:02 | |
| *** markmc` has quit IRC | 02:03 | |
| *** weshay has quit IRC | 02:03 | |
| *** kashyap has quit IRC | 02:03 | |
| *** wolverineav has joined #openstack-nova | 02:03 | |
| *** weshay has joined #openstack-nova | 02:03 | |
| *** rnoriega- has joined #openstack-nova | 02:04 | |
| *** rnoriega has quit IRC | 02:06 | |
| *** kashyap` has quit IRC | 02:06 | |
| *** markmc has quit IRC | 02:06 | |
| *** weshay_ has quit IRC | 02:06 | |
| *** rnoriega_ has quit IRC | 02:06 | |
| *** wolverineav has quit IRC | 02:08 | |
| *** yamamoto has joined #openstack-nova | 02:09 | |
| *** gjayavelu has joined #openstack-nova | 02:10 | |
| *** Zames has joined #openstack-nova | 02:13 | |
| *** bill1 has joined #openstack-nova | 02:15 | |
| *** yamamoto has quit IRC | 02:15 | |
| *** Zames has quit IRC | 02:19 | |
| *** dpawlik has joined #openstack-nova | 02:24 | |
| *** yingjun has quit IRC | 02:25 | |
| *** yingjun has joined #openstack-nova | 02:28 | |
| *** dpawlik has quit IRC | 02:29 | |
| gmann | alex_xu: ping | 02:29 |
| *** gcb has joined #openstack-nova | 02:33 | |
| *** moshele has quit IRC | 02:33 | |
| openstackgerrit | Dinesh Bhor proposed openstack/nova master: WIP: PCPU: Define numa dedicated CPU resource class https://review.openstack.org/561770 | 02:35 |
| openstackgerrit | Dinesh Bhor proposed openstack/nova master: WIP: PCPU, VCPU: Add respective conf options https://review.openstack.org/561771 | 02:37 |
| *** Guest2631 has quit IRC | 02:37 | |
| *** mvk has quit IRC | 02:39 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix comments in novaclient/tests/unit/fakes.py https://review.openstack.org/561772 | 02:40 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | 02:44 |
| *** dave-mcc_ has quit IRC | 02:45 | |
| *** Nel1x has quit IRC | 02:49 | |
| *** Guest2631 has joined #openstack-nova | 02:49 | |
| *** Nel1x has joined #openstack-nova | 02:49 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466 | 02:52 |
| *** gjayavelu has quit IRC | 02:55 | |
| *** nicolasbock has quit IRC | 02:55 | |
| *** tetsuro has joined #openstack-nova | 03:00 | |
| *** jchhatbar has joined #openstack-nova | 03:00 | |
| *** janki has quit IRC | 03:03 | |
| *** yingjun has quit IRC | 03:03 | |
| *** jchhatbar is now known as janki | 03:07 | |
| *** psachin has joined #openstack-nova | 03:09 | |
| *** yamamoto has joined #openstack-nova | 03:11 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Enhance api-guide general info https://review.openstack.org/561773 | 03:11 |
| *** yamamoto has quit IRC | 03:16 | |
| *** annp has joined #openstack-nova | 03:28 | |
| openstackgerrit | Nguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build https://review.openstack.org/551802 | 03:30 |
| openstackgerrit | Nguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build https://review.openstack.org/551802 | 03:30 |
| *** fragatina has joined #openstack-nova | 03:32 | |
| *** lpetrut has joined #openstack-nova | 03:42 | |
| *** andreas_s has joined #openstack-nova | 03:45 | |
| *** lpetrut has quit IRC | 03:49 | |
| *** lpetrut has joined #openstack-nova | 03:50 | |
| *** andreas_s has quit IRC | 03:50 | |
| *** wolverineav has joined #openstack-nova | 03:55 | |
| *** dklyle has joined #openstack-nova | 03:57 | |
| jichen | melwitt: hi regarding your comments in the ML about z/VM driver | 03:57 |
| *** sridharg has joined #openstack-nova | 03:59 | |
| jichen | melwitt: the z/VM driver behaves unlike any other in-tree driver [0-5] ---> we will make our code exactly as you pointed , we will NOT do anything special | 03:59 |
| *** penick_ has joined #openstack-nova | 04:02 | |
| *** jbryce_ has joined #openstack-nova | 04:03 | |
| *** ildikov has quit IRC | 04:03 | |
| *** jbryce has quit IRC | 04:03 | |
| *** jamiec has quit IRC | 04:03 | |
| *** penick has quit IRC | 04:03 | |
| *** jbryce_ is now known as jbryce | 04:03 | |
| *** jamiec has joined #openstack-nova | 04:03 | |
| *** andymccr has quit IRC | 04:05 | |
| *** andymccr has joined #openstack-nova | 04:05 | |
| *** Guest2631 has quit IRC | 04:07 | |
| *** Dinesh_Bhor has quit IRC | 04:08 | |
| *** phuongnh has quit IRC | 04:09 | |
| *** phuongnh has joined #openstack-nova | 04:10 | |
| *** udesale has joined #openstack-nova | 04:11 | |
| *** lpetrut has quit IRC | 04:12 | |
| *** yamamoto has joined #openstack-nova | 04:13 | |
| openstackgerrit | Nguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build https://review.openstack.org/551802 | 04:14 |
| *** arvindn05 has joined #openstack-nova | 04:14 | |
| *** asettle_ has joined #openstack-nova | 04:14 | |
| *** arvindn051 has quit IRC | 04:16 | |
| *** asettle has quit IRC | 04:16 | |
| *** NostawRm has quit IRC | 04:16 | |
| *** zer0c00l has quit IRC | 04:16 | |
| *** abhishekk has joined #openstack-nova | 04:16 | |
| *** NostawRm has joined #openstack-nova | 04:17 | |
| *** jchhatbar has joined #openstack-nova | 04:18 | |
| *** yamamoto has quit IRC | 04:18 | |
| *** wolverineav has quit IRC | 04:18 | |
| *** sdeath has joined #openstack-nova | 04:18 | |
| *** phuongnh has quit IRC | 04:20 | |
| *** janki has quit IRC | 04:20 | |
| *** annp has quit IRC | 04:21 | |
| *** hongbin_ has quit IRC | 04:21 | |
| *** lpetrut has joined #openstack-nova | 04:21 | |
| *** phuongnh has joined #openstack-nova | 04:21 | |
| *** annp has joined #openstack-nova | 04:21 | |
| *** zer0c00l has joined #openstack-nova | 04:22 | |
| *** Guest2631 has joined #openstack-nova | 04:22 | |
| openstackgerrit | Nguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build https://review.openstack.org/551802 | 04:24 |
| *** gjayavelu has joined #openstack-nova | 04:28 | |
| *** moshele has joined #openstack-nova | 04:29 | |
| *** claudiub|2 has joined #openstack-nova | 04:30 | |
| *** markvoelker has quit IRC | 04:37 | |
| *** moshele has quit IRC | 04:38 | |
| *** lpetrut has quit IRC | 04:40 | |
| *** ratailor has joined #openstack-nova | 04:48 | |
| *** salv-orlando has joined #openstack-nova | 04:55 | |
| *** sridharg has quit IRC | 05:05 | |
| *** sapd_ has quit IRC | 05:07 | |
| *** lpetrut has joined #openstack-nova | 05:08 | |
| *** sapd_ has joined #openstack-nova | 05:08 | |
| *** sridharg has joined #openstack-nova | 05:17 | |
| *** gjayavelu has quit IRC | 05:18 | |
| *** links has joined #openstack-nova | 05:23 | |
| *** vivsoni has quit IRC | 05:27 | |
| *** lpetrut has quit IRC | 05:33 | |
| *** sean-k-mooney[m] has joined #openstack-nova | 05:36 | |
| *** markvoelker has joined #openstack-nova | 05:38 | |
| *** ccamacho has quit IRC | 05:41 | |
| *** gjayavelu has joined #openstack-nova | 05:44 | |
| *** vivsoni has joined #openstack-nova | 05:48 | |
| *** gcb has quit IRC | 05:50 | |
| *** dpawlik has joined #openstack-nova | 05:57 | |
| *** dpawlik has quit IRC | 05:58 | |
| *** takedakn has joined #openstack-nova | 05:58 | |
| *** dpawlik has joined #openstack-nova | 05:59 | |
| *** hoonetorg has quit IRC | 05:59 | |
| *** vivsoni has quit IRC | 06:00 | |
| *** jafeha__ has quit IRC | 06:00 | |
| *** vivsoni has joined #openstack-nova | 06:01 | |
| *** moshele has joined #openstack-nova | 06:01 | |
| *** takedakn has quit IRC | 06:02 | |
| *** kholkina has joined #openstack-nova | 06:10 | |
| *** hemna_ has quit IRC | 06:11 | |
| *** hoonetorg has joined #openstack-nova | 06:12 | |
| *** jchhatbar is now known as janki | 06:12 | |
| *** yamamoto has joined #openstack-nova | 06:16 | |
| *** pcaruana has joined #openstack-nova | 06:16 | |
| *** andreas_s has joined #openstack-nova | 06:17 | |
| *** lpetrut has joined #openstack-nova | 06:19 | |
| openstackgerrit | Merged openstack/nova master: remove ec2 in service and cmd https://review.openstack.org/556778 | 06:20 |
| *** sidx64 has joined #openstack-nova | 06:22 | |
| *** yamamoto has quit IRC | 06:22 | |
| *** priteau has joined #openstack-nova | 06:23 | |
| *** do3meli has joined #openstack-nova | 06:35 | |
| *** alexchadin has joined #openstack-nova | 06:36 | |
| *** gokhan has joined #openstack-nova | 06:38 | |
| *** gokhan has quit IRC | 06:39 | |
| *** gokhan has joined #openstack-nova | 06:46 | |
| *** cfriesen has quit IRC | 06:48 | |
| *** jchhatbar has joined #openstack-nova | 06:50 | |
| *** slaweq has joined #openstack-nova | 06:50 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | 06:53 |
| *** janki has quit IRC | 06:53 | |
| *** chenyb4 has quit IRC | 06:56 | |
| gokhan | hi , I have HA openstack pike environment. for 2 weeks there is not any problem about environment, but for 2 days I am getting rabbitmq timeout errors on some compute nodes. there are errors on nova compute and rabbitmq cluster. on nova compute there are timeouts errors like that : http://paste.openstack.org/show/719338/ and I see on rabbitmq there are error reports like that: http://paste.openstack.org/show/719339/ what can be the reason of this a | 06:57 |
| gokhan | nd how can I solve this problem ? now I can not create multiple instances and some instances are waiting in build statement for hours | 06:57 |
| *** rcernin has quit IRC | 06:57 | |
| *** ccamacho has joined #openstack-nova | 06:58 | |
| *** phuongnh has quit IRC | 06:59 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:00 | |
| *** chenyb4 has joined #openstack-nova | 07:01 | |
| *** ccamacho has quit IRC | 07:04 | |
| *** ccamacho has joined #openstack-nova | 07:05 | |
| *** dpawlik has quit IRC | 07:07 | |
| *** damien_r has joined #openstack-nova | 07:10 | |
| *** damien_r has quit IRC | 07:10 | |
| *** yamamoto has joined #openstack-nova | 07:10 | |
| *** damien_r has joined #openstack-nova | 07:10 | |
| *** sahid has joined #openstack-nova | 07:11 | |
| *** hoangcx_ has joined #openstack-nova | 07:12 | |
| *** hoangcx has quit IRC | 07:13 | |
| *** hoangcx_ is now known as hoangcx | 07:13 | |
| *** yamamoto has quit IRC | 07:14 | |
| *** yamamoto has joined #openstack-nova | 07:14 | |
| *** tesseract has joined #openstack-nova | 07:14 | |
| *** kashyap`` is now known as kashyap | 07:15 | |
| Kevin_Zheng | gibi Hi, could you check this series https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:refactor-notification-samples | 07:16 |
| gibi | Kevin_Zheng: Hi! It is in my queue. Thanks for working on it | 07:17 |
| Kevin_Zheng | gibi, Thanks, it is related to the bp I working on anyway :) | 07:18 |
| *** ralonsoh has joined #openstack-nova | 07:18 | |
| *** ralonsoh has quit IRC | 07:19 | |
| *** trinaths has joined #openstack-nova | 07:20 | |
| *** hoangcx_ has joined #openstack-nova | 07:21 | |
| *** hoangcx has quit IRC | 07:22 | |
| *** hoangcx_ is now known as hoangcx | 07:22 | |
| *** gongysh has joined #openstack-nova | 07:22 | |
| *** phuongnh has joined #openstack-nova | 07:23 | |
| *** salv-orlando has quit IRC | 07:28 | |
| *** salv-orlando has joined #openstack-nova | 07:28 | |
| *** Zames has joined #openstack-nova | 07:30 | |
| *** mgoddard has joined #openstack-nova | 07:30 | |
| *** lpetrut_ has joined #openstack-nova | 07:31 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:31 | |
| *** salv-orlando has quit IRC | 07:32 | |
| *** Zames has quit IRC | 07:33 | |
| *** gjayavelu has quit IRC | 07:33 | |
| *** lpetrut has quit IRC | 07:34 | |
| *** yamamoto_ has joined #openstack-nova | 07:39 | |
| *** tssurya has joined #openstack-nova | 07:41 | |
| *** yamamoto has quit IRC | 07:42 | |
| *** alexchadin has quit IRC | 07:42 | |
| *** alexchadin has joined #openstack-nova | 07:43 | |
| alex_xu | gmann: pong | 07:44 |
| *** salv-orlando has joined #openstack-nova | 07:45 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [WIP] ServerActionsSampleJsonTest refactor https://review.openstack.org/561819 | 07:45 |
| gmann | alex_xu: could not catch you since long. i want to discuss about API meeting or office hour | 07:47 |
| *** jogo has quit IRC | 07:48 | |
| alex_xu | gmann: yea | 07:48 |
| gmann | alex_xu: idea is we continue on that and do mainly 2 things 1. we track priority items mainly for review and 2. do bug triage | 07:48 |
| alex_xu | gmann: I think it is cool | 07:48 |
| alex_xu | gmann: what time we choice? | 07:50 |
| gmann | alex_xu: not decided actually. i feel may be during our day time as not much people attended past API meeting | 07:50 |
| alex_xu | yes | 07:51 |
| alex_xu | gmann: and if there is trouble problem we can bring it to the nova weekly meeting | 07:51 |
| gmann | alex_xu: and i can send a summary of updates every week after that | 07:51 |
| alex_xu | gmann: that will be cool | 07:51 |
| gmann | alex_xu: yes, we give same updated there too | 07:51 |
| *** jpena|off is now known as jpena | 07:52 | |
| alex_xu | gmann: should we start a email to ask abot the idea first? | 07:53 |
| sean-k-mooney | stephenfin: jaypipes sahid i was talking to dansmith about the native vhost-user support in the libvirt driver yesterday, do you have any objection to me moving this to os-vif as an in tree plugin? the impmentation in os-vif will effectivly be an no-op but it means we can remove that code path from nova. the nataiv vhost-user support is used by snab switch, vpp and i belive it was used by contrail at | 07:53 |
| gmann | alex_xu: sure. that will be good and if we get more people join that | 07:53 |
| sean-k-mooney | one point. | 07:53 |
| alex_xu | gmann: yea, can you start a email :) | 07:54 |
| gmann | alex_xu: yea, i will send tomorrow and get the opinion on idea and time also | 07:54 |
| alex_xu | gmann: cool, thanks a lot | 07:54 |
| gmann | alex_xu: thanks :) | 07:54 |
| sean-k-mooney | stephenfin: jaypipes sahid. as the native support is used by multiple drivers and since it is always expected to be present in existing installs keeping it in os-vif makes sense from an upgrade point of view as packagers do not need to include an addtional package to maintain current behavior | 07:59 |
| sean-k-mooney | stephenfin: jaypipes sahid i have created a bug to track this https://bugs.launchpad.net/os-vif/+bug/1764665 but if ye have objections let me know and i can take a different path | 08:02 |
| openstack | Launchpad bug 1764665 in os-vif "Add generic-vhost-user pluging to os-vif" [Wishlist,Triaged] - Assigned to sean mooney (sean-k-mooney) | 08:02 |
| *** gongysh has quit IRC | 08:02 | |
| *** gongysh has joined #openstack-nova | 08:03 | |
| *** gongysh has quit IRC | 08:03 | |
| *** lucas-brb is now known as lucasagomes | 08:04 | |
| *** yingjun has joined #openstack-nova | 08:05 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: ServerActionsSampleJsonTest refactor https://review.openstack.org/561819 | 08:06 |
| *** avolkov has joined #openstack-nova | 08:07 | |
| *** Zames has joined #openstack-nova | 08:07 | |
| *** amoralej|off is now known as amoralej | 08:08 | |
| *** Shilpa has joined #openstack-nova | 08:08 | |
| *** mdnadeem has joined #openstack-nova | 08:10 | |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 08:11 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 08:11 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 08:11 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 08:11 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 08:11 |
| *** jogo has joined #openstack-nova | 08:12 | |
| *** hiro-kobayashi has quit IRC | 08:16 | |
| *** Zames has quit IRC | 08:18 | |
| *** Zames has joined #openstack-nova | 08:20 | |
| *** rnoriega- is now known as rnoriega | 08:23 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997 | 08:26 |
| *** Zames has quit IRC | 08:27 | |
| sahid | sean-k-mooney: i just updated the patch | 08:27 |
| sahid | if you can have a look. I really would like limiting the scope of the change if possible | 08:28 |
| sahid | i added some comments | 08:28 |
| sean-k-mooney | sahid: https://review.openstack.org/#/c/484997 ? | 08:28 |
| sahid | yes | 08:28 |
| sahid | sean-k-mooney: about your ovs-vif asking | 08:29 |
| sahid | so you want to create an other pluging in the tree for vhostuser? | 08:29 |
| sean-k-mooney | sahid: specifically for vhost user when not using ovs | 08:30 |
| sean-k-mooney | the plug an unplug methods will be no ops as in the non ovs case nova/os-vif does not need to plug the vhost-user interface into anything | 08:30 |
| sahid | but we will still have to keep the nova part to generate the native domain xml | 08:31 |
| sean-k-mooney | it will however allow use to remove the fallback code in the nova/virt/libvirt/vif.py | 08:31 |
| sean-k-mooney | sahid: yes just the xml generation but that is comon between ovs and non ovs vhost-user interfaces | 08:31 |
| sahid | right, so i'm cool with you plan :) | 08:32 |
| sean-k-mooney | currently we have that twice in the nova tree but we can converge them | 08:32 |
| *** derekh has joined #openstack-nova | 08:32 | |
| *** udesale_ has joined #openstack-nova | 08:32 | |
| sahid | yes if we can remove 'get_config_vhost' to ony user the ovsvif one that would be perfect | 08:33 |
| sahid | get_config_vhostuser | 08:33 |
| *** TobbeCN has joined #openstack-nova | 08:34 | |
| *** udesale has quit IRC | 08:34 | |
| *** yamamoto_ has quit IRC | 08:36 | |
| sean-k-mooney | sahid: ya we would remove the get_config_vhostuser fucntion and then always use the os-vif version instead. im going to try and set up a vpp test env later this week so i can validate it all still works correctly. | 08:37 |
| *** yamamoto has joined #openstack-nova | 08:37 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | 08:40 |
| *** namnh has joined #openstack-nova | 08:45 | |
| *** yingjun has quit IRC | 08:46 | |
| *** Nisha_Agarwal has joined #openstack-nova | 08:46 | |
| openstackgerrit | Merged openstack/nova master: Document how to disable notifications https://review.openstack.org/561684 | 08:46 |
| *** armaan has joined #openstack-nova | 08:51 | |
| *** yingjun has joined #openstack-nova | 08:53 | |
| *** ralonsoh has joined #openstack-nova | 08:54 | |
| *** Zames has joined #openstack-nova | 08:55 | |
| *** TobbeCN has quit IRC | 08:56 | |
| *** TobbeCN has joined #openstack-nova | 08:56 | |
| *** Nisha_ has joined #openstack-nova | 08:57 | |
| *** edmondsw has joined #openstack-nova | 08:58 | |
| *** hiro-kobayashi has joined #openstack-nova | 08:59 | |
| *** Nisha_Agarwal has quit IRC | 09:00 | |
| *** Nisha_ has quit IRC | 09:00 | |
| *** xinliang has joined #openstack-nova | 09:01 | |
| *** xinliang has quit IRC | 09:01 | |
| *** xinliang has joined #openstack-nova | 09:01 | |
| *** edmondsw has quit IRC | 09:02 | |
| *** cdent has joined #openstack-nova | 09:04 | |
| *** dpawlik has joined #openstack-nova | 09:08 | |
| kholkina | hi! could you please review the spec https://review.openstack.org/#/c/547964/ | 09:09 |
| *** Zames has quit IRC | 09:09 | |
| *** bingqianglin has quit IRC | 09:10 | |
| *** bingqianglin has joined #openstack-nova | 09:10 | |
| *** Zames has joined #openstack-nova | 09:13 | |
| *** bkopilov has quit IRC | 09:13 | |
| naichuans | jaypipes: Hi, Jay. For a resource provider(n-rp enabled) which have alreay allocate some resources to a living VM, can we delete it? I'm considering a case on n-rp for vGPU: 1) vGPU resource provider created 2) create a VM with vGPU 3) disable vGPU support by remove enabled_vgpu_types in nova.conf 4) update host states, then vGPU rp should be deleted(cache on nova side and data in placement database)? 5) enable vGPU support again by | 09:14 |
| naichuans | enabled_vgpu_types. Would the process affect the after going VM schedule? | 09:14 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Consider nested RPs in get_all_with_shared https://review.openstack.org/556450 | 09:18 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates https://review.openstack.org/556514 | 09:18 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support nested alloc cands without shared RPs https://review.openstack.org/561842 | 09:18 |
| *** Zames has quit IRC | 09:20 | |
| *** mvk has joined #openstack-nova | 09:22 | |
| *** gongysh has joined #openstack-nova | 09:26 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vmops.py https://review.openstack.org/561846 | 09:27 |
| *** bkopilov has joined #openstack-nova | 09:29 | |
| *** udesale__ has joined #openstack-nova | 09:32 | |
| *** ratailor_ has joined #openstack-nova | 09:33 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Avoid showing password in log https://review.openstack.org/561850 | 09:33 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: Avoid showing password in log https://review.openstack.org/561851 | 09:34 |
| *** yingjun has quit IRC | 09:34 | |
| *** Dinesh_Bhor has quit IRC | 09:34 | |
| *** udesale_ has quit IRC | 09:35 | |
| *** ratailor has quit IRC | 09:35 | |
| *** Tom-Tom has quit IRC | 09:42 | |
| *** Tom-Tom has joined #openstack-nova | 09:43 | |
| *** mdbooth has joined #openstack-nova | 09:43 | |
| lyarwood | mdbooth: https://review.openstack.org/#/c/561704/ - morning, I dumped this in your review queue btw | 09:44 |
| *** Tom-Tom has quit IRC | 09:47 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Improve performance when list instances with IP filter https://review.openstack.org/539469 | 09:47 |
| *** QianYu has joined #openstack-nova | 09:49 | |
| *** hiro-kobayashi has quit IRC | 09:49 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.61 - support extra_specs in flavor API https://review.openstack.org/561520 | 09:49 |
| openstackgerrit | Elod Illes proposed openstack/nova stable/ocata: Functional test for regression bug #1713783 https://review.openstack.org/505160 | 09:53 |
| openstack | bug 1713783 in OpenStack Compute (nova) ocata "After failed evacuation the recovered source compute tries to delete the instance" [High,In progress] https://launchpad.net/bugs/1713783 - Assigned to Illes Elod (elod-illes) | 09:53 |
| *** mdbooth has quit IRC | 09:53 | |
| *** QianYu_ has joined #openstack-nova | 09:54 | |
| *** QianYu has quit IRC | 09:54 | |
| *** hoangcx has quit IRC | 09:59 | |
| *** ratailor__ has joined #openstack-nova | 10:00 | |
| openstackgerrit | Lei Zhang proposed openstack/nova master: Improve check capacity sql https://review.openstack.org/561862 | 10:01 |
| *** ratailor_ has quit IRC | 10:02 | |
| *** ratailor__ has quit IRC | 10:04 | |
| *** ratailor has joined #openstack-nova | 10:08 | |
| *** jichen has quit IRC | 10:09 | |
| *** namnh has quit IRC | 10:10 | |
| *** cdent has quit IRC | 10:12 | |
| *** zz9pzza has quit IRC | 10:12 | |
| *** zz9pzza has joined #openstack-nova | 10:13 | |
| kashyap | mdbooth, I'm afraid, on that Mox discussion yesterda, I don't see any other choice than replacing the failing Mox test with Mock | 10:14 |
| kashyap | Oh, he's not here | 10:14 |
| *** zz9pzza has quit IRC | 10:17 | |
| *** chenyb4 has quit IRC | 10:19 | |
| *** Zames has joined #openstack-nova | 10:22 | |
| *** Zames has quit IRC | 10:26 | |
| *** dr_gogeta86 has quit IRC | 10:26 | |
| *** eharney has joined #openstack-nova | 10:30 | |
| *** eharney has quit IRC | 10:30 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Skip placement on rebuild in same host https://review.openstack.org/561015 | 10:30 |
| *** eharney has joined #openstack-nova | 10:30 | |
| *** armaan has quit IRC | 10:31 | |
| *** armaan has joined #openstack-nova | 10:31 | |
| *** bingqianglin has quit IRC | 10:31 | |
| *** dpawlik has quit IRC | 10:34 | |
| *** QianYu_ has quit IRC | 10:36 | |
| *** nicolasbock has joined #openstack-nova | 10:37 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997 | 10:38 |
| sahid | sean-k-mooney: ^ I preferd to fix the test | 10:38 |
| sean-k-mooney | sahid: cool :) as i said it was only a minor nit but it nice to use valid values in the tests | 10:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 10:40 |
| sahid | sean-k-mooney: yes yes, just i think we should try to stay coherent even in tests :) | 10:40 |
| sahid | it was a good point | 10:41 |
| kashyap | stephenfin: Hi there. Is it too unreasonable to replace Mox with Mock, while fixing the fallout from libvirt / QEMU version bump: http://kashyapc.fedorapeople.org/0001-tests-unit-Fix-test_live_migration_update_graphics_x.patch | 10:41 |
| *** stakeda has quit IRC | 10:41 | |
| kashyap | stephenfin: When you can, read the commit message, and the first point in the "main changes". | 10:41 |
| *** mvk has quit IRC | 10:41 | |
| sahid | sean-k-mooney: about https://review.openstack.org/#/c/553072/ | 10:42 |
| stephenfin | kashyap: I personally think that's fine, given that the test was having issues as is | 10:42 |
| kashyap | Yeah, thank you! | 10:42 |
| *** mdbooth has joined #openstack-nova | 10:42 | |
| sahid | matt had some questions, i tried to reply but perhaps you want to give more details | 10:42 |
| kashyap | stephenfin: I spent 2 hours fixing two tests. I'm slow as molasses with this stuff | 10:42 |
| kashyap | Thanks | 10:42 |
| *** Zames has joined #openstack-nova | 10:43 | |
| stephenfin | bauzas: Did I hear something about us deprecating AggregateCoreFilter ? | 10:43 |
| *** dpawlik has joined #openstack-nova | 10:43 | |
| bauzas | stephenfin: hola, sorry saw your late ping | 10:43 |
| bauzas | stephenfin: but I was running :p | 10:43 |
| stephenfin | bauzas: All good :) | 10:43 |
| bauzas | stephenfin: the aggregate filters ? well, it's a long story :) | 10:44 |
| *** xinliang has quit IRC | 10:44 | |
| bauzas | stephenfin: AFAIK, the aggregate filters aren't deprecated *yet* | 10:45 |
| bauzas | but there was a discussion about providing that feature by the Placement API | 10:45 |
| *** armaan has quit IRC | 10:46 | |
| *** armaan has joined #openstack-nova | 10:46 | |
| *** Zames has quit IRC | 10:47 | |
| *** armaan has joined #openstack-nova | 10:47 | |
| stephenfin | bauzas: OK, so not gone yet. I'll tackle this issue another way so | 10:47 |
| *** dougshelley66 has joined #openstack-nova | 10:49 | |
| openstackgerrit | Martin Midolesov proposed openstack/nova master: [vmwareapi] Expose cpu model on homogeneous cluster; Reformating code; https://review.openstack.org/561901 | 10:49 |
| *** abhishekk has quit IRC | 10:51 | |
| *** tbachman has quit IRC | 10:51 | |
| *** alexchadin has quit IRC | 10:52 | |
| *** eharney has quit IRC | 10:53 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | 10:53 |
| *** mvk has joined #openstack-nova | 10:54 | |
| *** sdague has joined #openstack-nova | 10:54 | |
| *** Guest2631 has quit IRC | 10:56 | |
| *** xinliang has joined #openstack-nova | 10:57 | |
| openstackgerrit | Merged openstack/nova stable/queens: Skip placement on rebuild in same host https://review.openstack.org/561014 | 10:58 |
| *** alexchadin has joined #openstack-nova | 10:59 | |
| *** yassine has joined #openstack-nova | 11:00 | |
| *** Zames has joined #openstack-nova | 11:00 | |
| *** yassine is now known as Guest4072 | 11:00 | |
| *** Zames has quit IRC | 11:04 | |
| *** AlexeyAbashkin has quit IRC | 11:07 | |
| *** mgariepy has quit IRC | 11:09 | |
| *** cdent has joined #openstack-nova | 11:12 | |
| *** ragiman has joined #openstack-nova | 11:12 | |
| *** zz9pzza has joined #openstack-nova | 11:13 | |
| *** lucasagomes is now known as lucas-hungry | 11:14 | |
| *** TobbeCN has quit IRC | 11:16 | |
| *** alexchadin has quit IRC | 11:17 | |
| *** TobbeCN has joined #openstack-nova | 11:17 | |
| *** alexchadin has joined #openstack-nova | 11:17 | |
| *** TobbeCN has quit IRC | 11:17 | |
| *** TobbeCN has joined #openstack-nova | 11:17 | |
| *** alexchadin has quit IRC | 11:17 | |
| *** alexchadin has joined #openstack-nova | 11:18 | |
| *** alexchadin has quit IRC | 11:18 | |
| *** alexchadin has joined #openstack-nova | 11:19 | |
| *** alexchadin has quit IRC | 11:19 | |
| *** alexchadin has joined #openstack-nova | 11:19 | |
| *** alexchadin has quit IRC | 11:20 | |
| *** alexchadin has joined #openstack-nova | 11:20 | |
| *** alexchadin has quit IRC | 11:20 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 11:21 |
| *** Nel1x has quit IRC | 11:22 | |
| *** mgariepy has joined #openstack-nova | 11:23 | |
| mdbooth | lyarwood: Done | 11:23 |
| *** jaosorior has quit IRC | 11:24 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Improve performance when list instances with IP filter https://review.openstack.org/539469 | 11:25 |
| *** armaan has quit IRC | 11:25 | |
| *** armaan has joined #openstack-nova | 11:25 | |
| *** zz9pzza has quit IRC | 11:25 | |
| lyarwood | mdbooth: thanks | 11:27 |
| mdbooth | lyarwood: Took me a while to re-load the context :) | 11:27 |
| *** jaosorior has joined #openstack-nova | 11:27 | |
| openstackgerrit | Martin Midolesov proposed openstack/nova master: [vmwareapi] Expose cpu model on homogeneous cluster; Refactoring code; https://review.openstack.org/561588 | 11:27 |
| *** AlexeyAbashkin has joined #openstack-nova | 11:28 | |
| lyarwood | mdbooth: yeah, I did come across https://bugs.launchpad.net/nova/+bug/1510328 from danpb btw, might try and follow up with that once this lands | 11:28 |
| openstack | Launchpad bug 1510328 in OpenStack Compute (nova) "Nova pre-allocation of qcow2 is flawed" [Low,Confirmed] | 11:28 |
| mdbooth | lyarwood: IIRC that's a pita to do without refactoring the imagebackend. | 11:29 |
| lyarwood | mdbooth: oh joy, well maybe not then | 11:29 |
| mdbooth | lyarwood: Look into it, though. I'm pretty jaded about most of that code, so I may not be looking at it fresh. | 11:30 |
| *** moshele has quit IRC | 11:30 | |
| *** moshele has joined #openstack-nova | 11:31 | |
| *** mgariepy has quit IRC | 11:31 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: Modify incorrect debug meaasge in _inject_data https://review.openstack.org/519950 | 11:32 |
| *** dougshelley66 has quit IRC | 11:33 | |
| *** udesale__ has quit IRC | 11:34 | |
| *** tetsuro has left #openstack-nova | 11:35 | |
| openstackgerrit | Hamdy Khader proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640 | 11:36 |
| *** TobbeCN has quit IRC | 11:39 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_share_set https://review.openstack.org/510897 | 11:40 |
| openstackgerrit | sahid proposed openstack/nova master: compute: introduce cpu_share_set https://review.openstack.org/561912 | 11:40 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: pass emulator threads policy insteadwhether it's isolated https://review.openstack.org/561913 | 11:40 |
| *** TobbeCN has joined #openstack-nova | 11:40 | |
| sahid | jaypipes: I have introduce the cpu_share_set by this serie ^ you might be interested. I tryed to limit the scope to my spec and I expect you to update the option for usage of cpu-resource spec | 11:41 |
| *** TobbeCN has quit IRC | 11:42 | |
| *** TobbeCN has joined #openstack-nova | 11:43 | |
| *** phuongnh has quit IRC | 11:43 | |
| *** armaan has quit IRC | 11:44 | |
| *** armaan has joined #openstack-nova | 11:45 | |
| *** jpena is now known as jpena|lunch | 11:45 | |
| openstackgerrit | sahid proposed openstack/nova-specs master: fix blueprint related to the spec https://review.openstack.org/561916 | 11:45 |
| *** zz9pzza has joined #openstack-nova | 11:49 | |
| *** alexchadin has joined #openstack-nova | 11:50 | |
| *** jogo has quit IRC | 11:51 | |
| *** amoralej is now known as amoralej|lunch | 11:52 | |
| *** alexchadin has quit IRC | 11:55 | |
| kashyap | mdbooth: Following up from our yesterday's discussion, I fixed the tests | 11:55 |
| kashyap | mdbooth: And I had to use Mock, I'm afraid. The tests were already broken / failing | 11:55 |
| kashyap | mdbooth: You can see in this small commit message: https://kashyapc.fedorapeople.org/0001-tests-unit-Fix-test_live_migration_update_graphics_x.patch | 11:56 |
| *** elmaciej has joined #openstack-nova | 11:57 | |
| jaypipes | sahid: rock on, thank you sir :) | 11:59 |
| *** alexchadin has joined #openstack-nova | 11:59 | |
| *** zz9pzza has quit IRC | 12:00 | |
| *** tbachman has joined #openstack-nova | 12:02 | |
| *** slaweq_ has joined #openstack-nova | 12:03 | |
| *** sidx64 has quit IRC | 12:04 | |
| *** dougshelley66 has joined #openstack-nova | 12:05 | |
| *** slaweq has quit IRC | 12:06 | |
| *** slaweq has joined #openstack-nova | 12:07 | |
| *** pchavva has joined #openstack-nova | 12:07 | |
| *** slaweq_ has quit IRC | 12:08 | |
| *** alexchadin has quit IRC | 12:10 | |
| *** zz9pzza has joined #openstack-nova | 12:11 | |
| *** armaan has quit IRC | 12:14 | |
| *** armaan has joined #openstack-nova | 12:14 | |
| *** tiendc has quit IRC | 12:14 | |
| *** dave-mccowan has joined #openstack-nova | 12:16 | |
| *** jogo has joined #openstack-nova | 12:16 | |
| *** trinaths has quit IRC | 12:18 | |
| *** armaan has quit IRC | 12:19 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748 | 12:19 |
| *** lucas-hungry is now known as lucasagomes | 12:19 | |
| *** ratailor has quit IRC | 12:19 | |
| *** gongysh has quit IRC | 12:20 | |
| *** alexchadin has joined #openstack-nova | 12:21 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova stable/queens: ironic: Get correct inventory for deployed node https://review.openstack.org/561923 | 12:21 |
| *** mgoddard has quit IRC | 12:21 | |
| *** moshele has quit IRC | 12:21 | |
| jaypipes | jianghuaw_: still up? | 12:21 |
| *** chenyb4 has joined #openstack-nova | 12:23 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925 | 12:23 |
| *** avolkov has quit IRC | 12:24 | |
| *** markvoelker has quit IRC | 12:25 | |
| *** yamamoto has quit IRC | 12:25 | |
| *** avolkov has joined #openstack-nova | 12:25 | |
| *** markvoelker has joined #openstack-nova | 12:25 | |
| *** yamamoto has joined #openstack-nova | 12:25 | |
| *** yamamoto has quit IRC | 12:26 | |
| *** QianYu has joined #openstack-nova | 12:26 | |
| *** mgariepy has joined #openstack-nova | 12:26 | |
| *** amoralej|lunch is now known as amoralej | 12:26 | |
| bauzas | stable cores, looks like we break some TripleO CI, and we need https://review.openstack.org/#/q/I6717ce19f6005c8ebb7af75437a72876c5a53f34 to be accepted for helping them | 12:26 |
| *** yamamoto has joined #openstack-nova | 12:26 | |
| bauzas | free beers offered | 12:26 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925 | 12:28 |
| *** Eran_Kuris has quit IRC | 12:28 | |
| *** armaan has joined #openstack-nova | 12:29 | |
| *** QianYu has quit IRC | 12:30 | |
| *** lajoskatona has joined #openstack-nova | 12:34 | |
| *** takashin has left #openstack-nova | 12:35 | |
| *** edmondsw has joined #openstack-nova | 12:37 | |
| openstackgerrit | Merged openstack/nova stable/pike: Fix wrapping of neutron forbidden error https://review.openstack.org/560087 | 12:38 |
| *** avolkov has quit IRC | 12:40 | |
| *** Eran_Kuris has joined #openstack-nova | 12:41 | |
| lyarwood | bauzas: free beer you say? | 12:41 |
| bauzas | yup, free as in 'I pay' | 12:41 |
| bauzas | Vancouver is in 1 month | 12:42 |
| *** chenyb4 has quit IRC | 12:42 | |
| bauzas | and even if I have a gold fish mind, I will still remember :) | 12:42 |
| mdbooth | lyarwood: As long as you meet in person at a specific bar in France, location to be revealed no more than 1 hour in advance. | 12:42 |
| bauzas | well, if in France, no beer | 12:43 |
| bauzas | Chartreuse instead | 12:43 |
| mdbooth | bauzas: I've never had that... | 12:44 |
| bauzas | again, https://en.wikipedia.org/wiki/Chartreuse_(liqueur) | 12:44 |
| mdbooth | bauzas: Next time I'm in France :) | 12:45 |
| bauzas | mdbooth: didn't you tried the Génépi last time you were there ? | 12:46 |
| mdbooth | bauzas: Not that I specifically recall, although there were drinks I drank without necessarily knowing what they were :) | 12:47 |
| *** jpena|lunch is now known as jpena | 12:47 | |
| bauzas | that's sad | 12:47 |
| bauzas | you just had half the experience | 12:47 |
| bauzas | skiing is one thing | 12:47 |
| bauzas | after-skiing is another thing | 12:48 |
| mdbooth | Apres-ski for me is mostly food and bed :( | 12:48 |
| * mdbooth is old | 12:48 | |
| openstackgerrit | Merged openstack/nova stable/queens: only increment disk address unit for scsi devices https://review.openstack.org/561196 | 12:48 |
| bauzas | mdbooth: tss tss, no excuse | 12:49 |
| stephenfin | bauzas: Alternatively, go to 🇦🇹 where the beer is plentiful and the <something decidedly PC about the opposite sex> | 12:49 |
| bauzas | I do ski with 70-yr old people | 12:50 |
| bauzas | actally, skiing on Fridays out of vacation periods make you consider young on the slopes... | 12:50 |
| *** mchlumsky has joined #openstack-nova | 12:50 | |
| *** liverpooler has joined #openstack-nova | 12:50 | |
| mdbooth | bauzas: They've all been skiing since they were 2, though | 12:50 |
| bauzas | nah | 12:51 |
| bauzas | some decided to retire in the mountains | 12:51 |
| bauzas | like new-age monks | 12:51 |
| bauzas | one good way of praying : take a 60% slope | 12:52 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add skip_latest_microversion decorator https://review.openstack.org/433585 | 12:53 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Run api sample tests against 2.latest https://review.openstack.org/430352 | 12:53 |
| *** salv-orlando has quit IRC | 12:53 | |
| *** salv-orlando has joined #openstack-nova | 12:54 | |
| *** mgoddard has joined #openstack-nova | 12:54 | |
| *** mchlumsky has quit IRC | 12:54 | |
| *** mchlumsky has joined #openstack-nova | 12:57 | |
| openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861 | 12:57 |
| *** salv-orlando has quit IRC | 12:58 | |
| *** mriedem has joined #openstack-nova | 12:59 | |
| *** lyan has joined #openstack-nova | 13:02 | |
| *** lyan is now known as Guest34655 | 13:02 | |
| *** armaan has quit IRC | 13:04 | |
| *** armaan has joined #openstack-nova | 13:04 | |
| mriedem | gibi: question in https://review.openstack.org/#/c/460625/ | 13:04 |
| *** damien_r1 has joined #openstack-nova | 13:04 | |
| *** QianYu_ has joined #openstack-nova | 13:06 | |
| *** damien_r has quit IRC | 13:07 | |
| *** QianYu__ has joined #openstack-nova | 13:08 | |
| kosamara | mriedem I fixed the nitpicks and created a blueprint | 13:10 |
| *** QianYu_ has quit IRC | 13:11 | |
| *** awaugama has joined #openstack-nova | 13:11 | |
| Shilpa | stephenfin: hi | 13:12 |
| stephenfin | Shilpa: o/ | 13:13 |
| Shilpa | stephenfin: i was going through temst failure logs for https://review.openstack.org/#/c/550172 | 13:13 |
| Shilpa | stephenfin: Also checked at http://codesearch.openstack.org/?q=vnc_auto.html&i=nope&files=&repos= | 13:14 |
| *** alexchadin has quit IRC | 13:14 | |
| Shilpa | stephenfin: here there are multiple projects referring novncproxy_base_url | 13:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add CPUWeigher https://review.openstack.org/379525 | 13:15 |
| Shilpa | stephenfin: do we need to inform respective projects to modify the same, or what action we need to take here? | 13:15 |
| gibi | mriedem: the versioned notification works based on the values of the Aggregate ovo so if we want to send the update.start notification with the already updated data then we have to update the Aggregate ovo before the start notification. But that would mean the start notification is sent _after_ the actual update so it is not a start notification any more | 13:15 |
| gibi | mriedem: a bit of chicken and egg | 13:16 |
| *** vladikr has joined #openstack-nova | 13:16 | |
| stephenfin | Shilpa: We probably do, yes. However, why does that affect the Tempest job? | 13:17 |
| mriedem | gibi: well, or add a 'new_metadata' field to the aggregate payload, something like that | 13:17 |
| Shilpa | stephenfin: is because of any refrence we are missing and cauing temst failure for https://review.openstack.org/#/c/550172? | 13:17 |
| mriedem | or 'metadata_updates' | 13:17 |
| mriedem | gibi: granted, the legacy notification is a bit dumb in that it sends the start notification with the updates but it also sends the end notification with the same updates, but not the full aggregate meta, so the legacy notification is also arguably incomplete | 13:18 |
| mriedem | since i don't know how these are consumed, i don't want to rathole on it too much and that's why i didn't -1 | 13:19 |
| *** zz9pzza has quit IRC | 13:19 | |
| Shilpa | stephenfin: i am still finding root cause of tempst failure, and it was failed for for patch set 1 too, but missing logs there since got over written because of patch set 2 | 13:19 |
| mriedem | if the consumer wants/needs to know the delta, i guess they can diff the metadata from the start/end notifications | 13:19 |
| stephenfin | Shilpa: That configuration value definitely works if you test manually? | 13:20 |
| *** andreykurilin has joined #openstack-nova | 13:20 | |
| stephenfin | Shilpa: Hmm, looks like we're not passing the token correctly http://logs.openstack.org/72/550172/2/check/tempest-full/f6945b6/controller/logs/screen-n-novnc.txt.gz | 13:20 |
| gibi | mriedem: I would go for the solution where any update.start notification sends information about the state _before_ the update and the update.end sends the new state in the payload. In some cases we deviated from that and added the diff directly to the payload instance.update old_task_sate new_task_state but there we don't have start and end notification to use | 13:22 |
| Shilpa | stephenfin: i have checked these logs and here seems token value is empty | 13:22 |
| *** armaan has quit IRC | 13:24 | |
| Shilpa | stephenfin: from where we can confirm, vnc 1.0.0 get downloaded successfully? i checked http://logs.openstack.org/72/550172/2/check/tempest-full/f6945b6/job-output.json.gz, but how once can confirm downloading of latest VNC version is successful? | 13:24 |
| *** armaan has joined #openstack-nova | 13:24 | |
| mriedem | gibi: yeah, +W | 13:24 |
| *** armaan has quit IRC | 13:25 | |
| *** armaan has joined #openstack-nova | 13:25 | |
| gibi | mriedem: I think the proposed versioned aggregate.update_metadata is a good start. If somebody needs the explicity diff in the payload we can add that later | 13:25 |
| gibi | mriedem: thanks | 13:25 |
| gibi | mriedem: btw, I will have to go offline for a while this afternoon but I will be back for the notification subteam meeting | 13:25 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Rename recreate to evacuate in driver signatures https://review.openstack.org/560900 | 13:26 |
| stephenfin | Shilpa: Not a clue, I'm afriad | 13:26 |
| *** zz9pzza has joined #openstack-nova | 13:26 | |
| *** armaan has quit IRC | 13:27 | |
| *** abhishekk has joined #openstack-nova | 13:28 | |
| *** armaan has joined #openstack-nova | 13:28 | |
| *** avolkov has joined #openstack-nova | 13:30 | |
| sahid | mriedem: still not convinced about https://review.openstack.org/#/c/553072/ ? | 13:32 |
| Shilpa | stephenfin: one more findings, http://logs.openstack.org/72/550172/2/check/tempest-full/f6945b6/controller/logs/screen-n-cond-cell1.txt.gz, here novncproxy_base_url is not reflected what is expected, still referring vvnc_auto.html | 13:33 |
| mriedem | sahid: just forgot about it | 13:34 |
| sahid | mriedem: oh ok no worries | 13:34 |
| *** armaan has quit IRC | 13:36 | |
| *** armaan has joined #openstack-nova | 13:36 | |
| *** esberglu has joined #openstack-nova | 13:36 | |
| Shilpa | stephenfin: i have seen workflow -1, what fix in nova you are expecting here? | 13:37 |
| *** links has quit IRC | 13:38 | |
| stephenfin | Shilpa: I noticed all the existing examples used 'path=websockify/' (i.e. added the '/') | 13:38 |
| stephenfin | Just curious to see if that affects things. Perhaps the urlparse module needs it | 13:38 |
| stephenfin | I'm just poking stuff | 13:38 |
| *** yamamoto has quit IRC | 13:39 | |
| *** yamamoto has joined #openstack-nova | 13:39 | |
| *** psachin has quit IRC | 13:40 | |
| Shilpa | stephenfin: ok, will wiat for Zuul , thank you. | 13:41 |
| *** felipemonteiro has joined #openstack-nova | 13:42 | |
| *** yamamoto has quit IRC | 13:44 | |
| bauzas | mriedem: any help would be appreciated for https://review.openstack.org/#/c/561923/ | 13:44 |
| bauzas | mriedem: looks like it's blocking some internal CI | 13:44 |
| *** felipemonteiro_ has joined #openstack-nova | 13:46 | |
| *** asettle_ is now known as asettle | 13:47 | |
| mriedem | bauzas: want to remove the note from the commit message? https://review.openstack.org/#/c/561925 | 13:50 |
| dansmith | sahid: should these be vhost-user in the config help string as well? https://review.openstack.org/#/c/484997/19/nova/conf/libvirt.py | 13:50 |
| *** felipemonteiro has quit IRC | 13:50 | |
| mriedem | sahid: left comments in https://review.openstack.org/#/c/553072/ | 13:51 |
| *** udesale has joined #openstack-nova | 13:51 | |
| *** sidx64 has joined #openstack-nova | 13:52 | |
| dansmith | sahid: or is driver vhost-user and type is vhostuser? | 13:52 |
| *** andreas_s has quit IRC | 13:52 | |
| bauzas | mriedem: thanks | 13:53 |
| sahid | dansmith: right, in the config doc i'm talking of the backend which is vhost-user. the 'vhostuser' name is for the libvirt interface type only | 13:55 |
| sahid | i will update that point | 13:55 |
| dansmith | sahid: okay, that's terribly confusing, but not your fault | 13:55 |
| dansmith | sahid: also, why did you abandon the bottom patch? | 13:55 |
| *** sidx64_ has joined #openstack-nova | 13:56 | |
| *** abhishekk has quit IRC | 13:56 | |
| dansmith | sahid: I was just saying he noted it should be vhost-user not vhostuser | 13:56 |
| dansmith | but he never commented on it I guess | 13:56 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Rename recreate to evacuate in driver signatures https://review.openstack.org/560900 | 13:56 |
| sahid | because i understood that we want only change the driver name if rx or tx queue size is updated, if not so we keep the old behavior and touch nothing | 13:56 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Remove redundant _do_check_can_live_migrate_destination https://review.openstack.org/561948 | 13:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Don't confuse CPU pinning/NUMA as Hyper-V only https://review.openstack.org/561949 | 13:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Remove 'admin/numa' doc https://review.openstack.org/561950 | 13:56 |
| *** eharney has joined #openstack-nova | 13:57 | |
| *** sidx64 has quit IRC | 13:57 | |
| sahid | hum so i missunderstood | 13:57 |
| dansmith | sahid: okay I think that setting vhost-user when we're sure it's vhost-user is a good cleanup, unrelated to the vhost driver change at the top, which is what I was referring to | 13:58 |
| *** lpetrut_ has quit IRC | 13:58 | |
| dansmith | but it sounds like he's come around on that second bit anyway | 13:58 |
| dansmith | sahid: if you don't mind restoring that bottom patch but s/vhostuser/vhost-user/ I'll be +2 on both | 13:59 |
| dansmith | sahid: and then I'll try to get jaypipes to review it in trade for something else :) | 13:59 |
| sahid | dansmith: yep actually i agreed with you about to fix that point | 13:59 |
| dansmith | *gasp* :) | 14:00 |
| sahid | just not sure i understand what you want with the vhost thing? do you want me to change something? | 14:00 |
| *** yamamoto has joined #openstack-nova | 14:01 | |
| dansmith | the vhost thing is in the second patch, in that you're overriding driver to vhost in more cases today than before the patch, which sean-k-mooney originally said he didn't want to change, but I think he is okay with it now, based on comments, so nothing to change | 14:01 |
| sahid | ok cool but that is said I only update it if rx or tx queue size is asked | 14:02 |
| sahid | anyway let me fix all of that and i will ping you | 14:02 |
| sahid | thanks for your help | 14:02 |
| dansmith | sahid: ah, you're right, that must be why :) | 14:02 |
| *** udesale has quit IRC | 14:02 | |
| sahid | :) | 14:03 |
| sahid | mriedem: ok thanks i will take a look and see whether i can help sean if he does not have time to update the code | 14:03 |
| bhagyashris | efried: Hi, | 14:04 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.61 - support extra_specs in flavor API https://review.openstack.org/561520 | 14:04 |
| efried | bhagyashris: Howdy! | 14:04 |
| *** r-daneel has joined #openstack-nova | 14:04 | |
| *** mlavalle has joined #openstack-nova | 14:06 | |
| mriedem | bauzas: trade for you https://review.openstack.org/#/q/topic:bug/1746483+branch:stable/ocata | 14:07 |
| bauzas | mriedem: roger, ack this | 14:07 |
| bauzas | mriedem: you freed me from some internal blackhole, I can pay you off | 14:07 |
| bauzas | oooooh I remember that nasty bug with IsolatedHosts :) | 14:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Document how to disable notifications https://review.openstack.org/561954 | 14:09 |
| sean-k-mooney | dansmith: ya i would prefer not to set teh driver name element if we dont need too however im fine with it for now | 14:09 |
| *** dougshelley66 has quit IRC | 14:09 | |
| dansmith | sean-k-mooney: yep, thanks for that review | 14:10 |
| *** hongbin_ has joined #openstack-nova | 14:10 | |
| *** johnsom has quit IRC | 14:11 | |
| *** andrewbogott has quit IRC | 14:11 | |
| *** johnsom has joined #openstack-nova | 14:12 | |
| *** ralonsoh has quit IRC | 14:13 | |
| *** kholkina has quit IRC | 14:14 | |
| *** tbachman has quit IRC | 14:14 | |
| *** dougshelley66 has joined #openstack-nova | 14:16 | |
| *** felipemonteiro_ has quit IRC | 14:16 | |
| *** cristicalin has joined #openstack-nova | 14:16 | |
| *** felipemonteiro__ has joined #openstack-nova | 14:16 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: doc: BFV instances and IsolatedHostsFilter https://review.openstack.org/543494 | 14:17 |
| *** andrewbogott has joined #openstack-nova | 14:17 | |
| bauzas | mriedem: FWIW, just made the amendment you asked me 2 months ago https://review.openstack.org/#/c/543494/ | 14:18 |
| *** andrewbogott has quit IRC | 14:18 | |
| *** andrewbogott has joined #openstack-nova | 14:18 | |
| *** slaweq_ has joined #openstack-nova | 14:18 | |
| *** brault_ has quit IRC | 14:18 | |
| *** mikal has quit IRC | 14:19 | |
| *** mikal has joined #openstack-nova | 14:20 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova stable/pike: ironic: Get correct inventory for deployed node https://review.openstack.org/561925 | 14:20 |
| mriedem | ok | 14:21 |
| *** slaweq has quit IRC | 14:21 | |
| mriedem | bauzas: also, gerrit UI won't add the cherry-picked from line in the commit message unless the change you're cherry picking *from* is merged | 14:22 |
| bauzas | I see, in case of a merge commit | 14:22 |
| *** Eran_Kuris has quit IRC | 14:23 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: BFV instances and IsolatedHostsFilter https://review.openstack.org/543494 | 14:25 |
| *** cfriesen has joined #openstack-nova | 14:27 | |
| *** zhaochao has quit IRC | 14:27 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: libvirt: Block swap volume attempts with encrypted volumes prior to Queens https://review.openstack.org/543569 | 14:29 |
| *** hemna_ has joined #openstack-nova | 14:30 | |
| *** eharney has quit IRC | 14:33 | |
| openstackgerrit | Merged openstack/python-novaclient master: Stop printing flavor details on successful flavor-delete https://review.openstack.org/561634 | 14:39 |
| *** lpetrut_ has joined #openstack-nova | 14:41 | |
| kashyap | Folks, when someone gets time, can you beat some sense into my (broken) test and me: http://paste.openstack.org/show/719390/ | 14:43 |
| kashyap | This is the last of the two unit test failures I need to fix for the "first batch" of the version bump clean-ups | 14:44 |
| efried | kashyap: Which line is the exception hitting on? | 14:44 |
| *** tbachman has joined #openstack-nova | 14:44 | |
| kashyap | efried: Line-56, that's what I'm messing up | 14:45 |
| kashyap | efried: For context, this is the original: https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_driver.py#L9171,L9219 | 14:45 |
| *** sidx64 has joined #openstack-nova | 14:45 | |
| kashyap | I am replacing the usage of the migrateToURI2() with migrateToURI3() in that test, as a result of post version bump clean-up. | 14:46 |
| efried | kashyap: Uh, the exception hits when you say | 14:46 |
| efried | mock_updated_guest_xml.return_value = '' | 14:46 |
| efried | ? | 14:46 |
| kashyap | In the original: target_xml is supplied to mock object to validate return value - test_mock.XMLDesc.return_value = target_xml | 14:46 |
| *** eharney has joined #openstack-nova | 14:46 | |
| kashyap | efried: Can't pin-point to that, but I know that's a mistake there. Still haven't ran PDB on that to narrow down, but was duking around other bits | 14:47 |
| * efried downloads... | 14:47 | |
| *** sidx64_ has quit IRC | 14:48 | |
| kashyap | efried: For context, this is the other local change that I've fixed for a different test: https://kashyapc.fedorapeople.org/0001-tests-unit-Fix-test_live_migration_update_graphics_x.patch | 14:48 |
| *** cristicalin has quit IRC | 14:48 | |
| kashyap | It's (the current broken test: 'test_live_migration_with_valid_target_connect_addr') in the same vein | 14:48 |
| efried | kashyap: Is there code change behind this, or are you just tweaking the test case? | 14:48 |
| kashyap | We're not doing any Mox stuff in this current test, though. | 14:48 |
| *** cristicalin has joined #openstack-nova | 14:49 | |
| kashyap | efried: I'm tweaking it as a result of: https://review.openstack.org/#/q/topic:bump_min_libvirt_and_qemu+(status:open+OR+status:merged) | 14:49 |
| efried | kashyap: Just trying to figure out what I need to do to repro it locally, is all. | 14:49 |
| kashyap | efried: You need to apply the above series. And run this: | 14:50 |
| kashyap | nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_live_migration_with_valid_target_connect_addr | 14:50 |
| efried | ... | 14:50 |
| gibi | mlavalle: hi! I'm back. rubasov mentioned that you might be in the process of updating the nova bandwidth spec. I got updated by rubasov about the current issues and I will start shaping up the spec for the next round of discussion but I dont want to conflict with your update | 14:50 |
| kashyap | efried: Feel free to disregard me, as this is a bit time consuming, and needs context | 14:51 |
| *** sidx64 has quit IRC | 14:51 | |
| kashyap | efried: So, if you're in the middle of thing, you can just drop it on the floor. | 14:51 |
| gibi | mlavalle: so I can hold my horses if you have something locally already | 14:51 |
| efried | kashyap: I'm pretty green in a lot of areas, but feel pretty good about my understanding of mocks. If I can't nail it down fairly quickly, I'll leave you to your thrashing, but I gotta have a crack at it. | 14:52 |
| gibi | mlavalle: please not that I will be in and out of connectivity today so I might respond slowly | 14:52 |
| kashyap | efried: Excellent. The context is only around libvirt APIs. I'm horrible with unit tests and Mocks | 14:52 |
| gibi | mlavalle: *note | 14:52 |
| efried | kashyap: Okay, so with the series applied and your test added (I named it with a 2) both tests fail. This is what we expect as a baseline, right? | 14:52 |
| mlavalle | gibi: I've been working heads down on multiple port binding, so please go ahead | 14:52 |
| *** sidx64 has joined #openstack-nova | 14:52 | |
| mlavalle | don't hold for me | 14:53 |
| kashyap | efried: Sure. I'd welcome a different pair of eyes; I'm a bit burned from looking at these the whole day. Thanks for the assist! | 14:53 |
| gibi | mlavalle: OK. thanks for the info | 14:53 |
| mlavalle | gibi: and welcome! | 14:53 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_VIRTUOZZO_VERSION https://review.openstack.org/560365 | 14:53 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: tests: unit: Fix 'test_live_migration_update_serial_console_xml' https://review.openstack.org/561969 | 14:53 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: tests: unit: Fix 'test_live_migration_update_graphics_xml' https://review.openstack.org/561970 | 14:53 |
| mlavalle | I hope you enjoyed your trip | 14:53 |
| mlavalle | and didn't think about us ;-) | 14:53 |
| efried | kashyap: Interestingly, both versions of the test fail the same way. | 14:53 |
| kashyap | efried: You mean, my so-called "updated" and the old one? | 14:54 |
| efried | kashyap: Yes. And there's no trace to actual running code; I suspect it's blowing up at mock time. | 14:54 |
| kashyap | efried: Exactly | 14:54 |
| kashyap | I have no idea, my Mock knowledge is ... mockable | 14:55 |
| efried | kashyap: I mean it's the decorators. | 14:55 |
| stephenfin | mriedem: Is the API in nova/network/base_api.py a contract we need to maintain for external users? | 14:55 |
| stephenfin | i.e. N cycles before we can remove a function | 14:55 |
| *** salv-orlando has joined #openstack-nova | 14:55 | |
| efried | kashyap: which is bizarro because the original don't have no decorators. | 14:55 |
| gibi | mlavalle: yes, It was really nice and I was able to forget about work :) | 14:55 |
| kashyap | efried: Fantastici | 14:55 |
| *** sidx64_ has joined #openstack-nova | 14:55 | |
| kashyap | efried: But you know -- | 14:55 |
| gibi | mlavalle: now I'm trying to catch up | 14:55 |
| mlavalle | :-) | 14:56 |
| efried | kashyap: f me this test suite is huge. | 14:56 |
| kashyap | efried: Tell me all about it | 14:56 |
| kashyap | efried: For context, see this -- "test_live_migration_update_volume_xml", this is almost same as the other one: test_live_migration_with_valid_target_connect_addr | 14:57 |
| *** sidx64 has quit IRC | 14:57 | |
| *** salv-orlando has quit IRC | 15:00 | |
| *** lajoskatona has quit IRC | 15:00 | |
| efried | uh oh, my IRC client is freaking out. Back in a tick... | 15:00 |
| *** efried has quit IRC | 15:00 | |
| *** Nisha_ has joined #openstack-nova | 15:00 | |
| *** efried has joined #openstack-nova | 15:01 | |
| openstackgerrit | Merged openstack/nova master: Transform aggregate.update_metadata notification https://review.openstack.org/460625 | 15:01 |
| kashyap | mriedem: Are such unit test only patches frowned-upon? https://review.openstack.org/#/c/561969/ | 15:01 |
| *** awaugama has quit IRC | 15:01 | |
| kashyap | mriedem: I've only got two of such, though. And two more to go in that vien -- fixing the fallout of migrateToURI{2,3} APIs | 15:02 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 15:02 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | 15:02 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | 15:02 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: fix wrong driver name for vhostuser interface https://review.openstack.org/561562 | 15:03 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997 | 15:03 |
| *** TobbeCN has quit IRC | 15:04 | |
| mriedem | umm | 15:04 |
| *** salv-orlando has joined #openstack-nova | 15:05 | |
| mriedem | kashyap: the commit message doesn't explain to me why we need those changes | 15:05 |
| mriedem | if the tests aren't failing as a result of the version cap changes | 15:05 |
| *** TobbeCN has joined #openstack-nova | 15:05 | |
| *** Nisha_ has quit IRC | 15:05 | |
| *** armaan has quit IRC | 15:05 | |
| mriedem | -1 with words to mull | 15:06 |
| kashyap | mriedem: They are of course failing due to the version cap changes. | 15:06 |
| kashyap | Not fixing them out of giggles | 15:06 |
| kashyap | mriedem: But yes, fair point on the commit message -- I'll write that | 15:06 |
| *** armaan has joined #openstack-nova | 15:06 | |
| mriedem | so these changes are coming before some future patch that changes/removes some version-dependent piece of code? | 15:07 |
| mriedem | rather than just include them in that same change? | 15:07 |
| kashyap | With the version bump, we get the migrateToURI3() API for gratis, and the older one is riddled with problems | 15:07 |
| mriedem | if the tests start to fail b/c you remove x, then include them in the patch that removes x | 15:08 |
| kashyap | mriedem: Yeah. I thought including them all in one big blob is ugly | 15:08 |
| kashyap | But if that's preferred, I can squash them into that change | 15:08 |
| kashyap | Because probably it *belongs* with the bump change, as that is what has caused the problem. | 15:08 |
| mriedem | typically the only test only changes i see are (1) adding more test coverage to existing code or (2) a negative test to recreate a bug which is then followed up by a patch that shows the bug is fixed | 15:09 |
| *** felipemonteiro_ has joined #openstack-nova | 15:10 | |
| kashyap | mriedem: Yeah, I noticed it too, from Git history sleuthing. And it felt "dirty" to just publish a test-only change | 15:10 |
| kashyap | I'll squash them in. Thanks for the comment | 15:10 |
| *** ccamacho has quit IRC | 15:11 | |
| *** TobbeCN has quit IRC | 15:12 | |
| *** felipemonteiro__ has quit IRC | 15:13 | |
| *** QianYu__ has quit IRC | 15:13 | |
| *** cdent has quit IRC | 15:15 | |
| openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861 | 15:15 |
| *** cdent has joined #openstack-nova | 15:16 | |
| *** cdent has left #openstack-nova | 15:16 | |
| *** yamamoto has quit IRC | 15:17 | |
| *** yamamoto has joined #openstack-nova | 15:17 | |
| *** sridharg has quit IRC | 15:17 | |
| openstackgerrit | sahid proposed openstack/nova master: compute: introduce cpu_share_set option https://review.openstack.org/561912 | 15:22 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: pass emulator threads policy instead whether isolated https://review.openstack.org/561913 | 15:22 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_share_set https://review.openstack.org/510897 | 15:22 |
| *** yamahata has joined #openstack-nova | 15:22 | |
| *** Nel1x has joined #openstack-nova | 15:22 | |
| *** Zames has joined #openstack-nova | 15:23 | |
| *** QianYu has joined #openstack-nova | 15:23 | |
| *** tbachman has quit IRC | 15:25 | |
| *** Zames has quit IRC | 15:26 | |
| *** pcaruana has quit IRC | 15:28 | |
| *** lpetrut_ has quit IRC | 15:33 | |
| sean-k-mooney | mriedem: on the topic of test only changes, is nova planning to remove mox this cycle or are we just rewriting the test that use mox as alter the code | 15:38 |
| mriedem | https://blueprints.launchpad.net/nova/+spec/mox-removal | 15:40 |
| sean-k-mooney | mriedem: yet another thing the depens on removal of nova networks to finish :) | 15:40 |
| *** tbachman has joined #openstack-nova | 15:44 | |
| *** mlavalle has quit IRC | 15:45 | |
| *** QianYu has quit IRC | 15:47 | |
| *** sahid has quit IRC | 15:47 | |
| *** cristicalin has quit IRC | 15:50 | |
| *** dougshel_ has joined #openstack-nova | 15:54 | |
| *** mlavalle has joined #openstack-nova | 15:55 | |
| arvindn05 | bauzas: jaypipes: https://review.openstack.org/#/c/560718/ - can we discuss this spec? | 15:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup ugly stub in TestLocalDeleteAllocations https://review.openstack.org/561997 | 15:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup ugly stub in TestLocalDeleteAllocations https://review.openstack.org/561997 | 15:56 |
| *** dougshelley66 has quit IRC | 15:58 | |
| jaypipes | arvindn05: sure | 15:58 |
| *** QianYu has joined #openstack-nova | 15:58 | |
| arvindn05 | jaypipes: ty...its hard to find bauzas in IRC because of timezone...if you know of suggestions for when i can find him in IRC that would help :) | 15:59 |
| bauzas | arvindn05: jaypipes: I'm here but it's 6pm here | 15:59 |
| bauzas | so I'll litterally disappear in like the next mins | 15:59 |
| arvindn05 | ahh...its 9 AM here... | 16:00 |
| * bauzas needs to taxi his wife for a couple of days till she gets her new car | 16:00 | |
| arvindn05 | will try to catch you earlier next time then | 16:00 |
| *** sidx64_ has quit IRC | 16:00 | |
| bauzas | arvindn05: you're US based ? | 16:00 |
| bauzas | West coast I guess | 16:00 |
| arvindn05 | yup...CA | 16:00 |
| openstackgerrit | Merged openstack/nova stable/ocata: Add regression test for BFV+IsolatedHostsFilter failure https://review.openstack.org/543634 | 16:01 |
| *** QianYu_ has joined #openstack-nova | 16:01 | |
| *** QianYu has quit IRC | 16:01 | |
| arvindn05 | bauzas: please do respond to the comment offline if you get a chance....my second patch for the BP depends on this change so it is starting to block progress for me | 16:02 |
| *** takedakn has joined #openstack-nova | 16:02 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add columns for generation to consumers https://review.openstack.org/557958 | 16:02 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add the Consumer object https://review.openstack.org/561406 | 16:02 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add Consumer objects to Allocations https://review.openstack.org/561407 | 16:02 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add generation checking logic to Consumer https://review.openstack.org/561408 | 16:02 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add a microversion for consumer generation https://review.openstack.org/562000 | 16:02 |
| edleafe | jaypipes: efried: cdent: ^^ now with microversion! | 16:03 |
| *** sidx64 has joined #openstack-nova | 16:03 | |
| efried | ack | 16:03 |
| edleafe | jaypipes: efried: cdent: I used microversion 1.99 to avoid having to rebase as things merge. It will be changed to a real version once this gets close | 16:03 |
| bauzas | arvindn05: okay, will try | 16:04 |
| efried | edleafe: You'll still have to rebase, of course. | 16:04 |
| bauzas | it was a busy day for me today | 16:04 |
| arvindn05 | bauzas: ty | 16:04 |
| *** TobbeCN has joined #openstack-nova | 16:04 | |
| bauzas | so hoping tomorrow will be different | 16:04 |
| *** dpawlik has quit IRC | 16:04 | |
| bauzas | for folks wondering, if you see me silent here, that means something else | 16:04 |
| *** sidx64 has quit IRC | 16:04 | |
| openstackgerrit | Merged openstack/nova stable/ocata: Handle volume-backed instances in IsolatedHostsFilter https://review.openstack.org/543635 | 16:05 |
| edleafe | efried: yeah, but just once more | 16:05 |
| openstackgerrit | Merged openstack/nova stable/ocata: Fix docs for IsolatedHostsFilter https://review.openstack.org/543636 | 16:05 |
| *** sidx64 has joined #openstack-nova | 16:06 | |
| *** tianhui_ has quit IRC | 16:06 | |
| *** tianhui has joined #openstack-nova | 16:06 | |
| efried | kashyap: You still around? | 16:07 |
| kashyap | efried: Hi, yeah. But will step out in 10 minutes | 16:07 |
| kashyap | Need to feed self | 16:07 |
| efried | kashyap: Problem in your paste http://paste.openstack.org/show/719390/ is at L3 | 16:07 |
| efried | @mock.patch takes one positional arg. | 16:07 |
| kashyap | efried: Yeah, I forgot to note that, I tried by removing the "return_value" from the @mock.patch | 16:08 |
| efried | kashyap: If you change it to | 16:08 |
| efried | @mock.patch('nova.virt.libvirt.migration.get_updated_guest_xml', | 16:08 |
| efried | return_value='') | 16:08 |
| efried | you get by that error (and on to the next :) | 16:08 |
| kashyap | Right | 16:08 |
| efried | if you wanted to mock.patch.object instead, then the first arg needs to be an object, the second a string naming a symbol. | 16:08 |
| kashyap | I see | 16:09 |
| *** TobbeCN has quit IRC | 16:09 | |
| kashyap | efried: I'm squashing a couple of commits that belong to the same logical change. | 16:09 |
| efried | kashyap: Does this get you unwedged, or did I misunderstand what you were stuck on? | 16:09 |
| kashyap | And then I'll duke it out tomorrow with the rest. I'll let you know | 16:09 |
| kashyap | efried: A bit ago, I was tinkering by removing the return_value'' in the @mock.patch, and that got me somewhere | 16:10 |
| efried | kashyap: The only thing you were probably accomplishing there was making the return value the name of the method you thought you were mocking. | 16:10 |
| kashyap | Hmm | 16:11 |
| kashyap | Let me get the full test, for a quick once over, when you have time | 16:11 |
| *** lpetrut_ has joined #openstack-nova | 16:13 | |
| kashyap | efried: That's the updated test: http://paste.openstack.org/show/719400/ | 16:13 |
| *** vladikr has quit IRC | 16:14 | |
| * kashyap needs to be AFK for a bit; will read scroll when I'm back. | 16:14 | |
| *** vladikr has joined #openstack-nova | 16:14 | |
| *** takedakn has quit IRC | 16:14 | |
| *** links has joined #openstack-nova | 16:14 | |
| efried | kashyap: Change L3 to use a single string: @mock.patch('nova.virt.libvirt.migration.get_updated_guest_xml') | 16:15 |
| openstackgerrit | Merged openstack/nova stable/queens: ironic: Get correct inventory for deployed node https://review.openstack.org/561923 | 16:16 |
| openstackgerrit | Merged openstack/nova stable/ocata: Functional test for regression bug #1713783 https://review.openstack.org/505160 | 16:17 |
| openstack | bug 1713783 in OpenStack Compute (nova) ocata "After failed evacuation the recovered source compute tries to delete the instance" [High,In progress] https://launchpad.net/bugs/1713783 - Assigned to Illes Elod (elod-illes) | 16:17 |
| openstackgerrit | Merged openstack/nova master: Deduplicate notification samples Rocky - 1 https://review.openstack.org/560296 | 16:17 |
| *** pcaruana has joined #openstack-nova | 16:18 | |
| *** gyee has joined #openstack-nova | 16:19 | |
| *** ragiman has quit IRC | 16:20 | |
| *** fragatina has quit IRC | 16:21 | |
| *** QianYu_ has quit IRC | 16:22 | |
| *** harlowja has joined #openstack-nova | 16:23 | |
| *** trinaths has joined #openstack-nova | 16:23 | |
| *** r-daneel_ has joined #openstack-nova | 16:29 | |
| *** r-daneel has quit IRC | 16:30 | |
| *** r-daneel_ is now known as r-daneel | 16:30 | |
| *** yamamoto_ has joined #openstack-nova | 16:30 | |
| *** QianYu has joined #openstack-nova | 16:31 | |
| *** damien_r1 has quit IRC | 16:31 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Pass the correct image to build_request_spec in conductor.rebuild_instance https://review.openstack.org/516404 | 16:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Set error state after failed evacuation https://review.openstack.org/518733 | 16:32 |
| *** yamamoto has quit IRC | 16:33 | |
| *** mdbooth has quit IRC | 16:34 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | 16:42 |
| *** gjayavelu has joined #openstack-nova | 16:43 | |
| *** Nisha_Agarwal has joined #openstack-nova | 16:44 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Parse forbidden in extra_specs https://review.openstack.org/561677 | 16:46 |
| *** yamahata has quit IRC | 16:48 | |
| *** harlowja has quit IRC | 16:52 | |
| mriedem | melwitt: if we can get this novaclient change in https://review.openstack.org/#/c/561520/ we can do a novaclient release to align with rocky-1 | 16:52 |
| mriedem | which we should probably do either way; i think i waited too long in queens to release novaclient and it caused some havoc with OSC and horizon late in queens | 16:52 |
| melwitt | mriedem: okay, yeah I did want to release novaclient for r-1. I'll take a look | 16:53 |
| *** lucasagomes is now known as lucas-afk | 16:57 | |
| *** harlowja has joined #openstack-nova | 16:57 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate notification samples Rocky - 4 https://review.openstack.org/560731 | 16:58 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate notification samples Rocky - 5 https://review.openstack.org/560734 | 16:58 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate notification samples Rocky - 6 https://review.openstack.org/560737 | 16:58 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | 16:58 |
| *** derekh has quit IRC | 16:58 | |
| *** fragatina has joined #openstack-nova | 17:03 | |
| *** mgoddard has quit IRC | 17:05 | |
| *** dklyle has quit IRC | 17:07 | |
| *** trinaths has quit IRC | 17:08 | |
| melwitt | mriedem: why do you think disabling the UCA could cause the ceph job problem again? problems occur when installs by pip get mixed with installs by apt-get. devstack will only pip install over a apt-get installed package if upper-constraints aren't being met | 17:09 |
| melwitt | with the Pike UCA, the version of python-paste installed by apt-get did not meet upper-constraints so devstack pip installed a newer version over it. so the matching python-pastedeploy package installed by apt-get had to be manually pip force installed in order to have paste and pastedeploy both installed by pip so pastedeploy could refer to modules in paste | 17:12 |
| mriedem | melwitt: so that's not a problem if you're just using stock ubuntu 16.04? | 17:13 |
| melwitt | it depends on what versions of python-paste and python-pastedeploy are in the repo for 16.04 and if only *one* of them does not meet upper-constraints | 17:13 |
| *** sidx64_ has joined #openstack-nova | 17:13 | |
| *** yamamoto_ has quit IRC | 17:15 | |
| melwitt | problems occur when only one of them does not meet upper-constraints because then devstack will upgrade only one with pip and then they can't refer to each other anymore. really, the hack probably should have been to pip force install both of the packages to guarantee they will always be able to find each other | 17:16 |
| *** yamamoto has joined #openstack-nova | 17:16 | |
| *** sidx64 has quit IRC | 17:16 | |
| *** yamahata has joined #openstack-nova | 17:16 | |
| *** QianYu has quit IRC | 17:16 | |
| jaypipes | mriedem, melwitt, dansmith: any of you seen "nova.exception.InvalidDiskInfo: Disk info file is invalid: qemu-img failed to execute on /fake/path : Unexpected error while running command." pop up in unit test failures recently? | 17:16 |
| melwitt | jaypipes: I have not | 17:17 |
| mriedem | unit tests? | 17:17 |
| mriedem | i probably know the one that is causing it | 17:17 |
| jaypipes | mriedem: ya. if I run tox -epy27, I get a single failure, always in nova.tests.unit.virt.test_images.QemuTestCase.test_qemu_info_with_errors | 17:18 |
| mriedem | https://review.openstack.org/#/c/553067/ | 17:18 |
| *** gokhan has quit IRC | 17:18 | |
| *** QianYu has joined #openstack-nova | 17:18 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Parse forbidden in extra_specs https://review.openstack.org/561677 | 17:19 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | 17:20 |
| jaypipes | mriedem, melwitt, dansmith: only seems to happen for me locally. so not really concerned about it... | 17:20 |
| *** harlowja has quit IRC | 17:20 | |
| mriedem | probably a bad global mock on os.exists | 17:21 |
| melwitt | do those tests require that you have qemu-img installed maybe? | 17:22 |
| *** mdnadeem has quit IRC | 17:23 | |
| *** jchhatbar has quit IRC | 17:27 | |
| *** gokhan has joined #openstack-nova | 17:28 | |
| jaypipes | melwitt: not sure... I can check | 17:29 |
| *** QianYu has quit IRC | 17:34 | |
| dansmith | sean-k-mooney: if you're still around and can re-apply your +1 to this I think that'd be good: https://review.openstack.org/#/c/484997/20 | 17:35 |
| *** links has quit IRC | 17:35 | |
| *** wolverineav has joined #openstack-nova | 17:36 | |
| *** QianYu_ has joined #openstack-nova | 17:37 | |
| sean-k-mooney | dansmith: done. it looks like v20 is just some pep8 fixs/whitespace clean up for v19 so ya it looks fine to me | 17:37 |
| dansmith | sean-k-mooney: yes, just want your +1 on there :) | 17:38 |
| dansmith | s/just/I just/ | 17:38 |
| *** awaugama has joined #openstack-nova | 17:39 | |
| *** QianYu has joined #openstack-nova | 17:40 | |
| *** QianYu_ has quit IRC | 17:40 | |
| *** r-daneel_ has joined #openstack-nova | 17:42 | |
| *** mgoddard has joined #openstack-nova | 17:42 | |
| *** r-daneel has quit IRC | 17:43 | |
| *** r-daneel_ is now known as r-daneel | 17:43 | |
| *** QianYu has quit IRC | 17:44 | |
| mriedem | melwitt: unit tests should never require that you have native packages installed | 17:44 |
| melwitt | I know, but I've run into issues with that in the past | 17:45 |
| *** links has joined #openstack-nova | 17:47 | |
| *** jpena is now known as jpena|off | 17:49 | |
| *** Tom-Tom has joined #openstack-nova | 17:50 | |
| melwitt | Kevin_Zheng: your blueprint "Add request_id to instance action notifications [END DATE: 2018-05-01]" has been added to a review runway. please let us know if the next two weeks are not a good time for fast iteration on review https://etherpad.openstack.org/p/nova-runways-rocky | 17:52 |
| dansmith | I assume we won't hear back on that until later this afternoon yeah? | 17:53 |
| *** ChanServ sets mode: +o dansmith | 17:53 | |
| melwitt | maybe not. I didn't know what time zone he is | 17:54 |
| *** tssurya_ has joined #openstack-nova | 17:54 | |
| *** dansmith changes topic to "Current runways: add-request-id-to-instance-action-notifications / powervm-vscsi / convert-consoles-to-objects -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 17:55 | |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Update forbidden spec to reflect chosen nova-side format https://review.openstack.org/562012 | 17:55 |
| dansmith | melwitt: china | 17:55 |
| *** ChanServ sets mode: -o dansmith | 17:55 | |
| melwitt | a-ha, cool | 17:55 |
| melwitt | the series is half approved already and currently actively reviewed/responded so I expect it's going to be okay | 17:55 |
| * dansmith nods | 17:56 | |
| *** mgoddard has quit IRC | 17:59 | |
| *** AlexeyAbashkin has quit IRC | 18:02 | |
| *** tbachman has quit IRC | 18:05 | |
| *** tesseract has quit IRC | 18:06 | |
| *** mvk has quit IRC | 18:07 | |
| imacdonn | mriedem dansmith efried: need to decide what to do with https://review.openstack.org/#/c/558089/ - I'm leaning back towards just removing the check in init_host(). If it needs something more than that, I probably need to let it go to someone else | 18:07 |
| openstackgerrit | Merged openstack/python-novaclient master: Fix comments in novaclient/tests/unit/fakes.py https://review.openstack.org/561772 | 18:07 |
| efried | imacdonn: I thought we decided to basically leave the old check as is but switch to checking auth_type instead of region | 18:08 |
| imacdonn | efried: I tried that, but it gets all complicated with unit testing again | 18:09 |
| efried | You can't just replace os_region_name with auth_type throughout? | 18:09 |
| imacdonn | efried: no, because all the tests that create a compute service try to actually use placement if auth_type is set, and we're back to messing around with fixtures (and it needs a valid auth_url, etc.) | 18:10 |
| efried | eek, really? Hum, okay. | 18:10 |
| mriedem | so zvm was moved out of runways? i don't see a log note for it | 18:14 |
| dansmith | mriedem: there was ML traffic about it | 18:14 |
| mriedem | sure but | 18:15 |
| mriedem | sherbit | 18:15 |
| dansmith | not in the lo because it's back in the queue I guess | 18:15 |
| mriedem | sorbet? | 18:15 |
| dansmith | sherbert | 18:15 |
| mriedem | ok, haircut time it is | 18:16 |
| *** mriedem is now known as mriedem_shamwow | 18:16 | |
| *** fragatina has quit IRC | 18:18 | |
| melwitt | yeah, I didn't think to put log notes because it's back in the queue. but I'll add log notes to it now, I think that's a good idea | 18:19 |
| dansmith | I did it | 18:19 |
| dansmith | with a link to the ML | 18:20 |
| melwitt | you rock, thanks | 18:20 |
| *** amoralej is now known as amoralej|off | 18:22 | |
| *** tbachman has joined #openstack-nova | 18:23 | |
| *** tbachman_ has joined #openstack-nova | 18:25 | |
| *** sidx64_ has quit IRC | 18:25 | |
| *** Nisha_Agarwal has quit IRC | 18:25 | |
| *** tbachman has quit IRC | 18:27 | |
| *** tbachman_ is now known as tbachman | 18:27 | |
| *** dklyle has joined #openstack-nova | 18:30 | |
| *** tbachman_ has joined #openstack-nova | 18:30 | |
| *** tbachman has quit IRC | 18:32 | |
| *** tbachman_ is now known as tbachman | 18:32 | |
| *** sdeath has quit IRC | 18:34 | |
| *** wolverineav has quit IRC | 18:35 | |
| *** wolverin_ has joined #openstack-nova | 18:35 | |
| *** wolverin_ has quit IRC | 18:38 | |
| openstackgerrit | Merged openstack/nova-specs master: Update forbidden spec to reflect chosen nova-side format https://review.openstack.org/562012 | 18:38 |
| *** wolverineav has joined #openstack-nova | 18:38 | |
| *** felipemonteiro_ has quit IRC | 18:38 | |
| *** felipemonteiro_ has joined #openstack-nova | 18:39 | |
| *** wolverineav has quit IRC | 18:39 | |
| *** wolverineav has joined #openstack-nova | 18:39 | |
| openstackgerrit | Merged openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299 | 18:40 |
| openstackgerrit | Merged openstack/nova master: Deduplicate notification samples Rocky - 3 https://review.openstack.org/560727 | 18:41 |
| *** hongbin_ has quit IRC | 18:41 | |
| openstackgerrit | Merged openstack/nova master: doc: BFV instances and IsolatedHostsFilter https://review.openstack.org/543494 | 18:41 |
| *** elmaciej has quit IRC | 18:41 | |
| *** hongbin_ has joined #openstack-nova | 18:41 | |
| sean-k-mooney | anyone know where the people that work on diskimage-builder hang out on irc? #openstack-infra? | 18:42 |
| dansmith | probs | 18:42 |
| imacdonn | sean-k-mooney: there's supposed to be a #openstack-dib , according to https://wiki.openstack.org/wiki/IRC | 18:42 |
| sean-k-mooney | imacdonn: ah thanks :) | 18:43 |
| sean-k-mooney | i need to bookmark that wiki | 18:43 |
| *** dklyle has quit IRC | 18:46 | |
| dansmith | lyarwood: on this https://review.openstack.org/#/c/561704 -- are we sure that the bit you're getting from qemu-img is the allocated part and not the would-be-allocated part? | 18:47 |
| *** felipemonteiro has joined #openstack-nova | 18:48 | |
| *** felipemonteiro_ has quit IRC | 18:48 | |
| *** felipemonteiro_ has joined #openstack-nova | 18:49 | |
| *** avolkov has quit IRC | 18:49 | |
| lyarwood | dansmith: it's the allocated part, virtual size is the potential allocation but thats the same for preallocated files like the example in the commit | 18:50 |
| *** dklyle has joined #openstack-nova | 18:51 | |
| dansmith | lyarwood: yeah, I'm poking around with qemu-img right now | 18:51 |
| *** felipemonteiro has quit IRC | 18:53 | |
| dansmith | the fallocate command you have doesn't work for me, | 18:53 |
| dansmith | but the neckbeard way of making a sparse file does show: | 18:53 |
| dansmith | dan@eagle:~$ qemu-img info -f raw testsparse.img | grep size | 18:53 |
| dansmith | virtual size: 1.0G (1074790400 bytes) | 18:53 |
| dansmith | disk size: 1.0M | 18:53 |
| *** elmaciej has joined #openstack-nova | 18:53 | |
| *** elmaciej_ has joined #openstack-nova | 18:54 | |
| lyarwood | dansmith: ah on osx? fallocate -n is odd and tbh I had no idea about it until this came up | 18:55 |
| dansmith | lyarwood: nope, linux | 18:55 |
| dansmith | fallocate: fallocate failed: keep size mode is unsupported | 18:55 |
| lyarwood | dansmith: try -l 1M | 18:55 |
| dansmith | it doesn't matter, I created a sparse file with dd | 18:56 |
| lyarwood | dansmith: but anyway, it's weird as it leaves the EOF at the start of the file but allocates blocks past that. | 18:56 |
| dansmith | because I'm old school cool | 18:56 |
| *** claudiub|2 has quit IRC | 18:56 | |
| dansmith | oh I see, a little different than sparse | 18:56 |
| dansmith | that seems fairly evil | 18:56 |
| *** dklyle has quit IRC | 18:57 | |
| dansmith | but, doesn't matter for what I was looking for | 18:57 |
| lyarwood | kk | 18:57 |
| *** elmaciej has quit IRC | 18:58 | |
| *** r-daneel_ has joined #openstack-nova | 19:01 | |
| dansmith | jaypipes: wanna send that ^ ? | 19:02 |
| dansmith | pretty easy | 19:02 |
| *** damien_r has joined #openstack-nova | 19:02 | |
| *** r-daneel has quit IRC | 19:03 | |
| *** r-daneel_ is now known as r-daneel | 19:03 | |
| openstackgerrit | iain MacDonnell proposed openstack/nova master: Remove placement config check https://review.openstack.org/558089 | 19:03 |
| *** TobbeCN has joined #openstack-nova | 19:09 | |
| jaypipes | dansmith: sorry, send what? | 19:13 |
| dansmith | jaypipes: https://review.openstack.org/#/c/561704 | 19:13 |
| *** TobbeCN has quit IRC | 19:13 | |
| dansmith | quick fix to look at the actual allocated size of a disk instead of just what the dumb ol' operating system thinks | 19:14 |
| dansmith | (i.e. accounting for sparse files) | 19:14 |
| jaypipes | ack. on itr. | 19:14 |
| jaypipes | dansmith: /me wondering what "crudini" is... | 19:23 |
| dansmith | eh? | 19:24 |
| openstackgerrit | Merged openstack/nova master: Remove mox in test_serversV21.py (1) https://review.openstack.org/560821 | 19:24 |
| jaypipes | dansmith: +W'd it. | 19:25 |
| *** AlexeyAbashkin has joined #openstack-nova | 19:25 | |
| lyarwood | jaypipes: ^_^ https://pypi.org/project/crudini/ aka openstack-config | 19:25 |
| lyarwood | well, downstream at least, no idea if that wrapper was upstream at any point | 19:26 |
| dansmith | jaypipes: pre-allocation of an image (even qcow) is for performance | 19:26 |
| jaypipes | lyarwood: ah, cool. thx :) | 19:27 |
| *** tbachman has quit IRC | 19:28 | |
| jaypipes | dansmith: oh? wasn't aware of that. is the performance due to contiguous blocks being grouped together? | 19:28 |
| dansmith | jaypipes: allocation takes time and effort | 19:28 |
| *** r-daneel_ has joined #openstack-nova | 19:29 | |
| dansmith | jaypipes: on a busy system preallocation won't even get you contiguous bits, | 19:29 |
| dansmith | but if you want predictable disk performance, you don't want to write to a hole and take a hit waiting for the allocation and _then_ the write | 19:29 |
| dansmith | and of course, | 19:29 |
| jaypipes | dansmith: so pre-allocating speeds up VM start times? | 19:29 |
| dansmith | no | 19:29 |
| dansmith | this would be performance after it's running | 19:29 |
| jaypipes | ah, ok. | 19:30 |
| jaypipes | sorry, out of my depth with block device stuff :( | 19:30 |
| dansmith | before it has hit every page on its own disk at least once | 19:30 |
| dansmith | s'all good | 19:30 |
| *** r-daneel has quit IRC | 19:30 | |
| *** r-daneel_ is now known as r-daneel | 19:30 | |
| *** tssurya has quit IRC | 19:32 | |
| *** AlexeyAbashkin has quit IRC | 19:34 | |
| *** imacdonn has quit IRC | 19:35 | |
| *** tbachman has joined #openstack-nova | 19:35 | |
| *** imacdonn has joined #openstack-nova | 19:36 | |
| *** xinliang has quit IRC | 19:37 | |
| *** xinliang has joined #openstack-nova | 19:39 | |
| * melwitt is about to use ddt in a unit test | 19:42 | |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.61 - support extra_specs in flavor API https://review.openstack.org/561520 | 19:46 |
| *** Tom-Tom has quit IRC | 19:48 | |
| *** mrjk has quit IRC | 19:49 | |
| *** mriedem_shamwow is now known as mriedem | 19:49 | |
| *** mrjk has joined #openstack-nova | 19:49 | |
| *** harlowja has joined #openstack-nova | 19:50 | |
| *** dklyle has joined #openstack-nova | 19:52 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 19:53 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262 | 19:53 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 19:53 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 19:53 |
| *** damien_r has quit IRC | 19:55 | |
| *** jackie-truong has joined #openstack-nova | 20:01 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | 20:03 |
| melwitt | jackie-truong: hey, just wanted to say please feel free to add notes on how the runway time went for your blueprint in the log area (L123 https://etherpad.openstack.org/p/nova-runways-rocky) | 20:04 |
| jackie-truong | melwitt: Absolutely, will do! | 20:05 |
| *** liverpooler has quit IRC | 20:05 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315 | 20:06 |
| *** awaugama has quit IRC | 20:07 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 20:10 |
| mriedem | GAH | 20:13 |
| mriedem | why does this hard-coded read_deleted='no'? https://github.com/openstack/nova/blob/54dc7048a48799ed980138e3524e4ebfc544eb8c/nova/db/sqlalchemy/api.py#L473 | 20:14 |
| mriedem | *hard-code | 20:14 |
| cfriesen | so do a bunch of the other service_get_by_* routines | 20:15 |
| mriedem | yes | 20:15 |
| mriedem | glad i stepped away for awhile to come back and figure this out | 20:15 |
| melwitt | because no one would ever want to read deleted service records or use context to override read_deleted. duh! | 20:16 |
| * mriedem git blames like a mofo | 20:16 | |
| melwitt | heh | 20:17 |
| mriedem | chances are it was a dan from red hat | 20:17 |
| mriedem | https://github.com/openstack/nova/commit/30159255bf5ec89c9092eb0273c292d44724e1f1 | 20:17 |
| *** fragatina has joined #openstack-nova | 20:18 | |
| *** Tom-Tom has joined #openstack-nova | 20:18 | |
| cfriesen | mriedem: looks like service_get_all_by_topic() and friends ignored deleted records as far back as 2011 | 20:19 |
| mriedem | yeah i'm sure it's just a pattern that all the newer methods followed | 20:19 |
| *** dougshel_ has quit IRC | 20:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add functional recreate test for bug 1764556 https://review.openstack.org/562041 | 20:21 |
| openstack | bug 1764556 in OpenStack Compute (nova) ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Undecided,New] https://launchpad.net/bugs/1764556 | 20:21 |
| mriedem | cfriesen: i can't recreate that bug, but here is my test that tries ^ | 20:21 |
| *** dklyle has quit IRC | 20:21 | |
| *** Tom-Tom has quit IRC | 20:22 | |
| cfriesen | mriedem: does it result in the equivalent DB entries that I did manually? | 20:23 |
| mriedem | how about just looking at the test to see if i'm missing something | 20:24 |
| dansmith | mriedem: yeah, I mean, getting by binary kinda has to ignore deleted | 20:24 |
| cfriesen | looking already | 20:24 |
| mriedem | dansmith: it's redundant with the context.read_deleted which defaults to 'no' | 20:25 |
| mriedem | but in this test i needed to specifically read deleted services | 20:25 |
| mriedem | and that was preventing me from being able to | 20:25 |
| mriedem | hence, "GAH" | 20:26 |
| mriedem | cfriesen: adding more debug, looks like the deleted service does in fact have a uuid | 20:26 |
| arvindn05 | how do we get host uuid from hostname in the scheduler? i am trying to get host uuid for host specified in the request_spec.force_hosts. | 20:26 |
| arvindn05 | Is calling GET /os-hypervisors the only way? Ideally I was hoping the request_spec had the uuid but all I get is the host name | 20:26 |
| arvindn05 | https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L93 | 20:26 |
| arvindn05 | any hints on internal methods i can call from the scheduler to provide the uuid's? | 20:27 |
| mriedem | arvindn05: scheduler doesn't need to call compute REST APIs | 20:28 |
| mriedem | it can use the db | 20:28 |
| *** pchavva has quit IRC | 20:28 | |
| cfriesen | mriedem: I wonder if deleting the service added the uuid back in? | 20:28 |
| mriedem | arvindn05: likely looking at https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L269 | 20:29 |
| mriedem | cfriesen: ah yeah, it probably did b/c the API looks up the service from the db to build the object and then delete it | 20:29 |
| *** yamamoto has quit IRC | 20:29 | |
| mriedem | arvindn05: there is also force_nodes | 20:30 |
| *** yamamoto has joined #openstack-nova | 20:30 | |
| mriedem | ironic nodes are 1:M host:node | 20:30 |
| mriedem | that's why get_first_node_by_host_for_old_compat is semi deprecated | 20:30 |
| arvindn05 | mriedem: thanks. so i need to load compute node using the get_by_host_and_nodename method and get the uuid that way? | 20:30 |
| *** dklyle has joined #openstack-nova | 20:31 | |
| mriedem | this is to get the compute node uuid to find the resource provider for rebuild right? | 20:31 |
| arvindn05 | yup | 20:31 |
| mriedem | arvindn05: yeah then likely just use this https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L262 | 20:32 |
| *** lpetrut_ has quit IRC | 20:32 | |
| arvindn05 | i have both the host and node names...so it looks appropriate | 20:32 |
| mriedem | that's a bit heavy since we don't need the full compute node object, but that should work for starters | 20:32 |
| *** fragatina has quit IRC | 20:32 | |
| arvindn05 | mriedem: thanks. is there any other lightweight mapping other than going to the db? | 20:33 |
| arvindn05 | i saw somewhere that the host id is generated from a combination of something....let me look it up | 20:33 |
| *** yamamoto has quit IRC | 20:34 | |
| arvindn05 | https://ask.openstack.org/en/question/29085/which-api-to-be-used-to-get-uuid-of-compute-host/?answer=29091#post-id-29091 | 20:34 |
| *** burt has joined #openstack-nova | 20:35 | |
| mriedem | no that's not it | 20:35 |
| cfriesen | arvindn05: going to the DB should be relatively cheap | 20:35 |
| mriedem | that's the hashed instance.hostId | 20:35 |
| mriedem | the computenode.host is the hostname of the compute service | 20:35 |
| mriedem | the physical hostname | 20:36 |
| mriedem | the nodename is the same as the host for all virt drivers except ironic | 20:36 |
| arvindn05 | mriedem: cfriesen: thanks...will go to the db then. if there are more effiecint methods, hopefully they will be pointed out in the CR | 20:36 |
| mriedem | in the case of ironic, the computenode.hypervisor_hostname (nodename) is the ironic node uuid | 20:36 |
| mriedem | there are not more efficient methods without writing your own new DB API query method via the ComputeNode object | 20:36 |
| mriedem | like, get_uuid_by_host_and_nodename | 20:36 |
| arvindn05 | ^ was hoping someone already wrote that method :) | 20:37 |
| *** fragatina has joined #openstack-nova | 20:37 | |
| mriedem | i don't think it's a huge issue to lookup the compute node for the rebuild case, it's not like scheduling for that should be very expensive since all we're doing is validating the new image | 20:37 |
| arvindn05 | yup...its not for all rebuild cases either...only rebuild cases where they have traits expressed in image....so its a minor subset | 20:38 |
| *** sapd__ has joined #openstack-nova | 20:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add functional recreate test for bug 1764556 https://review.openstack.org/562041 | 20:42 |
| openstack | bug 1764556 in OpenStack Compute (nova) ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Undecided,New] https://launchpad.net/bugs/1764556 | 20:42 |
| mriedem | cfriesen: getting further but still not failing when listing instances ^ | 20:42 |
| *** links has quit IRC | 20:42 | |
| *** pcaruana has quit IRC | 20:42 | |
| *** sapd_ has quit IRC | 20:43 | |
| efried | imacdonn: Quick delta there and I'm happy | 20:44 |
| imacdonn | efried: Ahh, good catch | 20:45 |
| efried | imacdonn: I checked and that's the only place it was used. | 20:45 |
| imacdonn | yep, I just 'grep -r'ed too ;) | 20:45 |
| * efried used a fancy IDE feature | 20:46 | |
| imacdonn | ooooh | 20:46 |
| efried | ...which is probably less reliable than grep -r | 20:46 |
| imacdonn | heh | 20:46 |
| efried | but way more efficient. | 20:46 |
| efried | You know, as long as you discount all the freaking processing power the IDE had to do up front to indext the whole freaking project. | 20:47 |
| efried | s/indext/index/ | 20:47 |
| imacdonn | yeah | 20:47 |
| mriedem | cfriesen: if i revert this https://review.openstack.org/#/c/543970/ then the test fails with ServiceNotFound | 20:47 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: Revert "Lazy-load instance attributes with read_deleted=yes" https://review.openstack.org/562051 | 20:48 |
| mriedem | but, that basically means it's already fixed | 20:48 |
| cfriesen | mriedem: does host1.stop() delete the entry in the DB? or do we need host1.kill()? | 20:49 |
| cfriesen | I definitely tested it with current stable/pike in devstack | 20:49 |
| mriedem | .stop() doesn't delete the service | 20:49 |
| openstackgerrit | Merged openstack/nova master: Parse forbidden in extra_specs https://review.openstack.org/561677 | 20:50 |
| cfriesen | ah, I see. you're stopping it then deleting it | 20:50 |
| mriedem | besides, yeah | 20:50 |
| mriedem | i stop the service, delete it, and then have to null out the service uuid because as noted, deleting the service via the rest api looks it up and will migrate the uuid if not set | 20:50 |
| cfriesen | let me just double-check my devstack | 20:50 |
| mriedem | cfriesen: did you have https://review.openstack.org/#/c/545988/ in your devstack env? | 20:52 |
| openstackgerrit | Merged openstack/nova stable/pike: libvirt: Block swap volume attempts with encrypted volumes prior to Queens https://review.openstack.org/543569 | 20:52 |
| mriedem | oh you said current stable/pike | 20:52 |
| openstackgerrit | iain MacDonnell proposed openstack/nova master: Remove placement config check https://review.openstack.org/558089 | 20:53 |
| *** Zames has joined #openstack-nova | 20:54 | |
| *** dougshelley66 has joined #openstack-nova | 20:55 | |
| mriedem | well, if anything, i guess i can still leave this test in place for bug 1745977 so we have coverage of the scenario | 20:56 |
| openstack | bug 1745977 in OpenStack Compute (nova) queens "When source compute service up, will not destroy and clean up those instances which be evacuated then be deleted." [Medium,Fix committed] https://launchpad.net/bugs/1745977 - Assigned to Matt Riedemann (mriedem) | 20:56 |
| *** mrjk has quit IRC | 20:56 | |
| cfriesen | mriedem: when you list the servers, are you doing it as an admin user? | 20:57 |
| *** jackie-truong has quit IRC | 20:57 | |
| cfriesen | mriedem: regular user doesn't get the host info | 20:57 |
| cfriesen | mriedem: and so doesn't trigger the bug | 20:57 |
| *** mrjk has joined #openstack-nova | 20:58 | |
| *** Tom-Tom has joined #openstack-nova | 20:58 | |
| cfriesen | I just reproduced in devstack after restarting all the nova services, so should be valid | 20:58 |
| *** Zames has quit IRC | 20:59 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens https://review.openstack.org/325381 | 20:59 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations https://review.openstack.org/325414 | 20:59 |
| openstackgerrit | melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 20:59 |
| openstackgerrit | melanie witt proposed openstack/nova master: Update layout docs for running console proxies https://review.openstack.org/557489 | 20:59 |
| cfriesen | I wonder if you just replaced self.api.get_servers() at the bottom with self.admin_api.get_servers()... | 20:59 |
| mriedem | cfriesen: no, not admin | 20:59 |
| mriedem | i can try that | 21:00 |
| efried | jaypipes: Quick +A on previously +2'd https://review.openstack.org/#/c/558089/ ? | 21:00 |
| *** Tom-Tom has quit IRC | 21:03 | |
| mriedem | there will be an obvious error in the n-cpu logs when placement isn't configured without that? | 21:04 |
| mriedem | or will we just get the safe_connect warnings? | 21:04 |
| mriedem | cfriesen: that doesn't change anything, listing with admin | 21:05 |
| *** gjayavelu has quit IRC | 21:05 | |
| efried | mriedem: We should see MissingAuthPlugin | 21:05 |
| *** gjayavel_ has joined #openstack-nova | 21:05 | |
| efried | mriedem: But IMO safe_connect is still broken. | 21:05 |
| mriedem | so we'll get https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L77 | 21:06 |
| mriedem | and nova-compute will be running and not reporting into placement | 21:06 |
| *** Tom-Tom has joined #openstack-nova | 21:06 | |
| dansmith | we shouldn't warn_limit that I think | 21:06 |
| efried | mriedem: Yup, I believe that's right. You'll get that nag the first ten times (or whatever) and then it'll quit. | 21:07 |
| *** tbachman has quit IRC | 21:07 | |
| efried | It's more broken than warn_limit can fix. | 21:07 |
| efried | What's broken about it is that we don't raise an exception when it happens. We just let the decorated code continue. | 21:07 |
| dansmith | yeah we should explode I think | 21:08 |
| mriedem | well, for nova-compute sure | 21:08 |
| mriedem | but for nova-api in rocky no | 21:08 |
| efried | If safe_connect was used extremely carefully - only in the outermost scope of whatever is calling into placement - then it would be less broken. | 21:08 |
| mriedem | i.e. https://review.openstack.org/#/c/560706/2/releasenotes/notes/bug-1679750-local-delete-allocations-cb7bfbcb6c36b6a2.yaml | 21:08 |
| efried | But as it stands, it is theoretically possible for it to reconnect and then proceed, having skipped the first step of whatever that outer process was. | 21:09 |
| *** tssurya_ has quit IRC | 21:09 | |
| efried | For this patch, it makes no difference - *nothing* will get done to placement. But for random midstream disconnects, it could potentially be disastrous. | 21:09 |
| efried | I guess ^ only applies for the EndpointNotFound branch. | 21:11 |
| efried | cause that's the only place we try to reconnect. | 21:11 |
| *** Tom-Tom has quit IRC | 21:11 | |
| dansmith | safe_connect was to make moving from no-placement to placement very smooth | 21:12 |
| dansmith | it probably needs to change quite a bit in today's world | 21:12 |
| dansmith | logging every single time we fail to talk to placement at least, | 21:12 |
| dansmith | and probably raising a lot more so we don't fail to make changes we think we're making | 21:13 |
| mriedem | so before rocky we never said that nova-api required config to talk to placement, are we now saying it does and if you don't have that config in place things are going to blow up? | 21:14 |
| *** mvk has joined #openstack-nova | 21:14 | |
| mriedem | specifically thinking about https://review.openstack.org/#/q/topic:bug/1756179+(status:open+OR+status:merged) and the mirror aggregates stuff | 21:14 |
| dansmith | personally that doesn't bother me, but api-initiated code can be graceful about it | 21:15 |
| mriedem | the former i care about more b/c i thought we would backport those | 21:15 |
| dansmith | without needing safe_connect hiding everything from us | 21:15 |
| dansmith | IMHO, ultimately the api aggregate mirroring stuff should be strict about not making local changes if it can't tell placement, so it needs good exception handling anyway | 21:16 |
| dansmith | making it graceful now and strict later is easy if it's all up there | 21:16 |
| dansmith | well, not all, but .. the handling of this not-configured case at least | 21:16 |
| mriedem | so basically move safe_connect to api | 21:16 |
| openstackgerrit | Merged openstack/nova master: libvirt: Report the allocated size of preallocated file based disks https://review.openstack.org/561704 | 21:16 |
| mriedem | and drop it in stein | 21:16 |
| dansmith | I dunno that all of safe_connect needs to go away, but I'd have to go look at it | 21:16 |
| dansmith | but yeah, the "tread lightly" function of it makes no sense for compute anymore, but api has the same need compute did | 21:17 |
| efried | I like the idea of nixing safe_connect, at least in its current form. If we get rid of it, then placement connect errors will raise exceptions that will bubble all the way up the stack. Usually (i.e. in _update-land) that'll mean we hit whatever operation again on the next periodic task. | 21:19 |
| efried | If we keep safe_connect, it should have some functionality that... connects... safely. E.g. the current exception clauses should reconnect and then retry the original call (once). | 21:20 |
| efried | That ^ is what I was expecting it to do when I first saw it. | 21:20 |
| efried | ...before I actually read the code. | 21:21 |
| openstackgerrit | Doug Hellmann proposed openstack/os-vif master: Add lower-constraints job https://review.openstack.org/556056 | 21:21 |
| efried | At this point, perhaps certain of those exceptions (like MissingAuthPlugin) should actually disable the compute service. | 21:21 |
| mriedem | i could see adding a kwarg to safe_connect telling it how to behave, so that by default it can now explode on connection failures (nova-compute, scheduler, conductor would want that), but nova-api could tell it to not fail due to those | 21:22 |
| *** priteau has quit IRC | 21:22 | |
| mriedem | efried: well, that was the point of the check on startup region_name | 21:22 |
| mriedem | *using region_name | 21:22 |
| efried | mriedem: Right; so at this point are we ever calling report client from code paths that *don't* require placement to be online? | 21:22 |
| dansmith | he is asserting api | 21:23 |
| mriedem | we have patches up for review which add new requirements to nova-api for placement | 21:23 |
| dansmith | but I personally don't think it's unreasonable to start calling it | 21:23 |
| efried | I'm sayin, are we calling it from API even if we don't require it? | 21:23 |
| mriedem | and i'm trying to make those graceful for upgrades | 21:23 |
| *** claudiub|2 has joined #openstack-nova | 21:23 | |
| dansmith | I feel like we'd start or stop talking to cinder or neutron from api without thinking about it | 21:23 |
| dansmith | but also, | 21:23 |
| dansmith | I don't think we have to have safe_connect at the lowest layer just because api wants it | 21:24 |
| *** edmondsw has quit IRC | 21:24 | |
| mriedem | i agree with the last thing you said | 21:24 |
| dansmith | api can do the placement mirroring stuff and except Exception | 21:24 |
| dansmith | or we can move safe_connect to a context manager and you can do: | 21:24 |
| dansmith | with safe_placement_stuff: do_things; | 21:25 |
| mriedem | ^ is what i'm thinking | 21:25 |
| *** tbachman has joined #openstack-nova | 21:25 | |
| dansmith | and it will catch and ignore or log or whatever is appropriate for up there | 21:25 |
| efried | dansmith: Would you use that context manager from RT or from methods within report client? | 21:26 |
| dansmith | you'd use it in the api methods getting ready to talk to placement | 21:26 |
| dansmith | or anywhere else that still wants safe_connect behavior | 21:26 |
| dansmith | I would expect report client to catch things it needs, bubble unexpected things (like this auth thing) up to the caller | 21:27 |
| dansmith | or translate them into something like PlacementNoWorky or whatever | 21:27 |
| efried | okay. Cause I think the major hole with what we're doing now is that we're calling it from within report client, often in ways that may cause us to be ignoring an exception on step 3 of a 10-step process and then proceeding with the rest. | 21:27 |
| dansmith | right | 21:28 |
| dansmith | which is why we shouldn't have it underneath report client | 21:28 |
| efried | ++ | 21:28 |
| *** tbachman_ has joined #openstack-nova | 21:28 | |
| efried | unless it's doing a reconnect-and-retry thing. | 21:28 |
| dansmith | sure | 21:28 |
| cfriesen | mriedem: I'm confused why it's not failing...it was trivially easy to reproduce in devstack by adding a single row to the services table. | 21:28 |
| efried | In which case it should probably decorate the get/put/post/delete primitives and nothing else. | 21:29 |
| *** tbachman has quit IRC | 21:29 | |
| *** tbachman_ is now known as tbachman | 21:29 | |
| *** wolverineav has quit IRC | 21:31 | |
| *** wolverineav has joined #openstack-nova | 21:31 | |
| *** eharney has quit IRC | 21:31 | |
| *** wolverineav has quit IRC | 21:32 | |
| *** wolverineav has joined #openstack-nova | 21:32 | |
| lyarwood | Does anyone have a simple way to enable debug logging within functional tests? self.flags doesn't appear to work. | 21:33 |
| *** Tom-Tom has joined #openstack-nova | 21:33 | |
| mriedem | OS_DEBUG=True | 21:34 |
| mriedem | https://github.com/openstack/nova/blob/ad249d8994067b1c255823cb7c1ff4c32593e5ef/tox.ini#L24 | 21:35 |
| lyarwood | thanks! :) | 21:35 |
| *** Tom-Tom has quit IRC | 21:38 | |
| *** sdague has quit IRC | 21:41 | |
| *** dklyle has quit IRC | 21:42 | |
| cfriesen | mriedem: when I run your testcase locally it's failing in _migrate_server() | 21:43 |
| cfriesen | http://paste.openstack.org/show/719417/ | 21:44 |
| mriedem | cfriesen: in pike? | 21:45 |
| mriedem | because pike doesn't have 204 in this list https://github.com/openstack/nova/blob/87ea686f9f2cc706205d188922bb14272625e7be/nova/tests/functional/api/client.py#L223 | 21:45 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Make safe_connect retry or raise https://review.openstack.org/562060 | 21:46 |
| efried | dansmith, mriedem: ^ | 21:46 |
| *** dklyle has joined #openstack-nova | 21:46 | |
| *** burt has quit IRC | 21:46 | |
| efried | dansmith, mriedem: There would be a separate, unrelated thingy for the n-api side of the world. | 21:46 |
| cfriesen | mriedem: yes, in pike | 21:46 |
| cfriesen | retrying with that | 21:48 |
| *** slaweq_ has quit IRC | 21:48 | |
| *** slaweq has joined #openstack-nova | 21:48 | |
| cfriesen | is there a way to stick a pdb breakpoint in there right before the last line? | 21:49 |
| *** esberglu has quit IRC | 21:51 | |
| *** yamamoto has joined #openstack-nova | 21:52 | |
| efried | cfriesen: Are you asking how to pdb via stestr? | 21:52 |
| efried | cause I have that answer | 21:52 |
| *** slaweq has quit IRC | 21:53 | |
| cfriesen | efried: I want to pdb in a functional test | 21:53 |
| efried | cfriesen: Same as in a unit test. | 21:53 |
| efried | cfriesen: You have to run stestr directly, and with the -n option and the full name of the test case. | 21:53 |
| efried | or you can use remote_pdb | 21:54 |
| openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.62 - Add trusted_image_certificates https://review.openstack.org/500396 | 21:54 |
| efried | cfriesen: e.g. | 21:55 |
| efried | source .tox/func/bin/activate | 21:55 |
| efried | stestr run -n nova.tests.functional.regressions.test_bug_1746509.InstanceListWithServicesTestCase.test_instance_list_deleted_service_with_no_uuid | 21:55 |
| efried | s/func/functional/ I guess - whatever the venv name is for functional. | 21:56 |
| *** yamamoto has quit IRC | 21:58 | |
| *** Tom-Tom has joined #openstack-nova | 21:59 | |
| cfriesen | efried: thanks, running ostestr directly worked | 21:59 |
| efried | cfriesen: ostestr? Are you not in nova? But cool. | 22:00 |
| *** jmlowe has quit IRC | 22:00 | |
| cfriesen | efried: nova, but stable/pike. it's what tox was using | 22:00 |
| efried | ahh | 22:00 |
| cfriesen | mriedem: running db.service_get_all_by_binary() righte before the call to self.admin_api.get_servers() shows that both services have uuid entries | 22:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix docs for confirmResize action https://review.openstack.org/562062 | 22:01 |
| mriedem | cfriesen: yes, which they both will for the non-deleted services | 22:01 |
| mriedem | because host1.start() creates a new service record with a uuid | 22:02 |
| mriedem | simulating that you've upgraded to pike and started that compute host with pike code | 22:02 |
| mriedem | after deleting the "newton" compute service / node which didn't have the uuid set | 22:02 |
| cfriesen | mriedem: right, I need the mutated context to read the deleted one. | 22:03 |
| openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.62 - Add trusted_image_certificates https://review.openstack.org/500396 | 22:04 |
| *** Tom-Tom has quit IRC | 22:04 | |
| mriedem | cfriesen: only other thing i could think of is like melwitt was saying yesterday and the backref joinedload on the services table is getting lucky and pulling the non-deleted service when listing instances | 22:06 |
| mriedem | this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L103 | 22:06 |
| cfriesen | mriedem: the deleted service in the DB has a uuid | 22:07 |
| melwitt | mriedem, cfriesen: I was wrong about that. the instance.services is all services whose host match the instance, and it will try to add a UUID to both of them, so should reliably fail I think | 22:07 |
| mriedem | cfriesen: ok i don't know how that is per https://review.openstack.org/#/c/562041/2/nova/tests/functional/regressions/test_bug_1764556.py@149 | 22:08 |
| mriedem | cfriesen: i guess there needs to be an assertion after the 2nd _migrate_server that the deleted service still doesn't have a uuid | 22:09 |
| *** felipemonteiro_ has quit IRC | 22:10 | |
| cfriesen | mriedem: if I set the uuid to None right before the final line then it fails | 22:10 |
| melwitt | something in the migrate is loading instance.services and generating UUID I guess? | 22:12 |
| cfriesen | seems like...I'm guessing wait_for_state_change() | 22:12 |
| *** yamamoto has joined #openstack-nova | 22:15 | |
| mriedem | idk, at what point is the test mocked out so hard that it masks whether or not we have a bug? | 22:15 |
| mriedem | or that i trust the recreate of it? | 22:15 |
| *** Tom-Tom has joined #openstack-nova | 22:16 | |
| *** jmlowe has joined #openstack-nova | 22:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add functional recreate test for bug 1764556 https://review.openstack.org/562041 | 22:17 |
| openstack | bug 1764556 in OpenStack Compute (nova) ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Undecided,New] https://launchpad.net/bugs/1764556 | 22:17 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: Revert "Lazy-load instance attributes with read_deleted=yes" https://review.openstack.org/562051 | 22:17 |
| mriedem | here are some updates, but i've got to run - the 2nd migrate is indeed migrating the deleted service record | 22:17 |
| *** mriedem is now known as mriedem_away | 22:17 | |
| melwitt | yeah, wouldn't want to mock it. I guess have to determine what exactly is the func test doing differently than the devstack repro and see if we make it the same as the actions needed with devstack | 22:18 |
| cfriesen | melwitt: I wonder if we need to do the delete/migrate/recreate/migrate first and then do the upgrade to pike | 22:19 |
| cfriesen | so that the migrate happens without uuids on the service | 22:19 |
| *** yamamoto has quit IRC | 22:20 | |
| SamYaple | looking for love in getting the +3 to get this backport merged. https://review.openstack.org/#/c/560088/ | 22:20 |
| *** Tom-Tom has quit IRC | 22:21 | |
| melwitt | looking for love in all the wrong places | 22:21 |
| *** sdeath has joined #openstack-nova | 22:21 | |
| melwitt | dansmith might be able to help you with the backport review ^ | 22:21 |
| SamYaple | story of my life melwitt | 22:21 |
| melwitt | heh | 22:22 |
| cfriesen | melwitt: guess not, my bug report specifically says they added the new compute was added after the upgrade | 22:22 |
| melwitt | cfriesen: yeah, I don't yet understand how we're simulating an upgrade in the func test, that's probably what's messing it up | 22:22 |
| melwitt | (I haven't looked in detail because I'm mired in other stuff right now) | 22:22 |
| cfriesen | melwitt: we're simulating the upgrade by just deleting the uuid on the service | 22:23 |
| melwitt | k, that makes sense | 22:23 |
| cfriesen | melwitt: mriedem_away: I suspect I know what's going on....initially we didn't have the other two fixes from stable/pike so I suspect that the migration after the upgrade wouldn't have updated the UUID, thus leaving the DB in the wonky state. | 22:23 |
| cfriesen | melwitt: mriedem_away: I bet that upgrading to stable/pike probably *would* update the service UUID on the migration. | 22:24 |
| melwitt | cfriesen: but earlier didn't you recreate the bug in devstack with the two fixes already applied? | 22:25 |
| openstackgerrit | Merged openstack/nova master: Remove redundant _do_check_can_live_migrate_destination https://review.openstack.org/561948 | 22:25 |
| cfriesen | melwitt: yes, by manually editing the DB to make an entry without the UUID. and then trying to list servers. I didn't do the migration step. | 22:26 |
| melwitt | ah | 22:26 |
| cfriesen | melwitt: I suspect that the migration step would update the UUID. | 22:26 |
| melwitt | I see | 22:26 |
| cfriesen | if I'm right, then anyone upgrading to current stable/pike wouldn't see this | 22:27 |
| melwitt | yeah | 22:27 |
| *** dklyle has quit IRC | 22:27 | |
| *** dpawlik has joined #openstack-nova | 22:33 | |
| *** salv-orl_ has joined #openstack-nova | 22:33 | |
| dansmith | melwitt: I think SamYaple means "dansmith mergin' my stuff in a timely manner is the story of my life" | 22:34 |
| melwitt | :) | 22:34 |
| *** yamamoto has joined #openstack-nova | 22:35 | |
| *** salv-orlando has quit IRC | 22:36 | |
| SamYaple | dansmith: <3 | 22:37 |
| *** wolverin_ has joined #openstack-nova | 22:39 | |
| *** wolverineav has quit IRC | 22:39 | |
| *** dpawlik has quit IRC | 22:39 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP Add regression test for bug #1764883 https://review.openstack.org/562072 | 22:40 |
| openstack | bug 1764883 in OpenStack Compute (nova) "Evacuation fails if the source host returns while the migration is still in progress" [Undecided,New] https://launchpad.net/bugs/1764883 | 22:40 |
| lyarwood | dansmith / melwitt ^ FYI, hopefully that's somewhere near what we need | 22:41 |
| melwitt | ack | 22:41 |
| *** yamamoto has quit IRC | 22:42 | |
| *** rcernin has joined #openstack-nova | 22:42 | |
| melwitt | lyarwood: also, reminder this thursday is r-1 and we're gonna cut releases for stable branches | 22:42 |
| lyarwood | melwitt: ah cool, thanks for the heads up | 22:45 |
| *** Guest4072 has quit IRC | 22:45 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Report the allocated size of preallocated file based disks https://review.openstack.org/562074 | 22:46 |
| *** r-daneel has quit IRC | 22:46 | |
| openstackgerrit | Merged openstack/nova master: Deduplicate notification samples Rocky - 4 https://review.openstack.org/560731 | 22:51 |
| openstackgerrit | Merged openstack/nova master: Deduplicate notification samples Rocky - 5 https://review.openstack.org/560734 | 22:51 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: libvirt: Report the allocated size of preallocated file based disks https://review.openstack.org/562077 | 22:52 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: libvirt: Report the allocated size of preallocated file based disks https://review.openstack.org/562078 | 22:52 |
| *** r-daneel has joined #openstack-nova | 22:52 | |
| *** tssurya has joined #openstack-nova | 22:54 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: libvirt: Block swap volume attempts with encrypted volumes prior to Queens https://review.openstack.org/561604 | 22:55 |
| *** hongbin_ has quit IRC | 22:58 | |
| *** yamamoto has joined #openstack-nova | 22:58 | |
| *** Guest4072 has joined #openstack-nova | 22:59 | |
| *** yamamoto has quit IRC | 23:03 | |
| *** tssurya has quit IRC | 23:07 | |
| *** TobbeCN has joined #openstack-nova | 23:11 | |
| *** TobbeCN has quit IRC | 23:15 | |
| *** r-daneel has quit IRC | 23:18 | |
| *** tbachman has quit IRC | 23:18 | |
| *** yamamoto has joined #openstack-nova | 23:19 | |
| *** elmaciej_ has quit IRC | 23:20 | |
| *** tbachman has joined #openstack-nova | 23:23 | |
| *** claudiub|2 has quit IRC | 23:24 | |
| *** yamamoto has quit IRC | 23:24 | |
| *** mlavalle has quit IRC | 23:32 | |
| *** sdague has joined #openstack-nova | 23:36 | |
| *** yamamoto has joined #openstack-nova | 23:40 | |
| *** jmlowe_ has joined #openstack-nova | 23:44 | |
| *** mriedem_away has quit IRC | 23:44 | |
| *** yamamoto has quit IRC | 23:46 | |
| *** jmlowe has quit IRC | 23:47 | |
| *** r-daneel has joined #openstack-nova | 23:47 | |
| *** slaweq has joined #openstack-nova | 23:49 | |
| *** gjayavel_ has quit IRC | 23:50 | |
| *** Tom-Tom has joined #openstack-nova | 23:52 | |
| *** slaweq has quit IRC | 23:54 | |
| *** takashin has joined #openstack-nova | 23:55 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.62 - List/Show all server migration types https://review.openstack.org/430839 | 23:55 |
| *** Tom-Tom has quit IRC | 23:57 | |
| *** r-daneel has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!