Monday, 2018-04-16

*** elmaciej has joined #openstack-nova00:17
*** sdague has quit IRC00:19
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060800:20
*** takashin has joined #openstack-nova00:21
*** owalsh_ has joined #openstack-nova00:29
*** dougshel_ has quit IRC00:29
*** owalsh has quit IRC00:31
*** lbragstad has joined #openstack-nova00:34
*** Dinesh__Bhor has joined #openstack-nova00:35
*** Dinesh__Bhor has quit IRC00:36
*** slaweq has joined #openstack-nova00:39
*** dims has quit IRC00:42
*** slaweq has quit IRC00:44
*** liuzz has joined #openstack-nova00:46
*** lbragstad has quit IRC00:49
*** tbachman has joined #openstack-nova00:51
*** edmondsw has joined #openstack-nova00:56
*** sambetts_ has quit IRC00:59
*** lbragstad has joined #openstack-nova00:59
*** sambetts_ has joined #openstack-nova01:00
*** hshiina has joined #openstack-nova01:03
*** salv-orl_ has joined #openstack-nova01:04
*** chenyb4 has joined #openstack-nova01:07
*** salv-orlando has quit IRC01:07
*** mlavalle has joined #openstack-nova01:12
*** lbragstad has quit IRC01:14
*** hongbin_ has joined #openstack-nova01:14
*** zhaochao has joined #openstack-nova01:16
*** sambetts_ has quit IRC01:19
*** sambetts_ has joined #openstack-nova01:21
openstackgerritZhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 1  https://review.openstack.org/56029601:22
*** jichen has joined #openstack-nova01:23
openstackgerritZhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2  https://review.openstack.org/56029901:27
openstackgerritZhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 3  https://review.openstack.org/56072701:28
*** owalsh_ has quit IRC01:29
*** owalsh has joined #openstack-nova01:29
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948301:32
*** edmondsw has quit IRC01:33
*** edmondsw has joined #openstack-nova01:33
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948301:35
*** edmondsw has quit IRC01:38
*** dougshelley66 has joined #openstack-nova01:38
*** hiro-kobayashi has joined #openstack-nova01:45
openstackgerritZhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 4  https://review.openstack.org/56073101:46
*** blkart has joined #openstack-nova01:52
*** masuberu has joined #openstack-nova01:54
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Record the host info in EventReporter  https://review.openstack.org/55674601:56
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Extract generate_hostid method into utils.py  https://review.openstack.org/55528201:56
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API  https://review.openstack.org/55714501:56
*** masber has quit IRC01:58
*** masber has joined #openstack-nova02:00
*** masuberu has quit IRC02:01
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Address nits in I00d29e9fd80e6b8f7ba3bbd8e82dde9d4cb1522f  https://review.openstack.org/56149302:03
*** mlavalle has quit IRC02:03
openstackgerritZhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 5  https://review.openstack.org/56073402:04
openstackgerritZhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 6  https://review.openstack.org/56073702:06
*** gongysh has joined #openstack-nova02:06
*** masber has quit IRC02:13
openstackgerritZhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications  https://review.openstack.org/55328802:17
*** Sukhdev has joined #openstack-nova02:34
*** gaoyan has joined #openstack-nova02:39
*** psachin has joined #openstack-nova02:39
*** gaoyan has quit IRC02:44
*** janki has joined #openstack-nova02:45
*** bingqianglin has joined #openstack-nova02:47
*** edmondsw has joined #openstack-nova02:48
*** edmondsw has quit IRC02:52
*** elmaciej has quit IRC03:01
*** wolverineav has quit IRC03:06
*** wolverineav has joined #openstack-nova03:06
*** wolverineav has quit IRC03:11
*** liuzz_ has joined #openstack-nova03:16
*** dklyle has quit IRC03:18
*** liuzz has quit IRC03:19
openstackgerritjichenjc proposed openstack/nova master: Fix doc link for api  https://review.openstack.org/56149903:25
*** takashin has quit IRC03:27
*** Sukhdev has quit IRC03:33
openstackgerritjichenjc proposed openstack/nova master: Move update_task_state out of try/except  https://review.openstack.org/55715203:34
*** hongbin_ has quit IRC03:35
*** lpetrut has joined #openstack-nova03:36
openstackgerritjichenjc proposed openstack/nova master: Add config drive link to api-guide  https://review.openstack.org/56111303:37
*** wolverineav has joined #openstack-nova03:42
*** lbragstad has joined #openstack-nova03:48
*** masber has joined #openstack-nova03:49
*** bingqianglin has quit IRC03:57
openstackgerritjichenjc proposed openstack/nova master: [Doc]Link policies file into api  https://review.openstack.org/56150304:03
*** lpetrut has quit IRC04:05
*** sridharg has joined #openstack-nova04:18
*** bhagyashris has joined #openstack-nova04:19
*** bkopilov has quit IRC04:22
openstackgerritNguyen Hai proposed openstack/nova-specs master: Enhance nova-specs webpage and clean up repo  https://review.openstack.org/55180204:27
*** udesale has joined #openstack-nova04:28
*** Tom-Tom has joined #openstack-nova04:35
*** edmondsw has joined #openstack-nova04:36
*** edmondsw has quit IRC04:40
*** slaweq has joined #openstack-nova04:41
*** slaweq has quit IRC04:45
*** bingqianglin has joined #openstack-nova04:49
*** ratailor has joined #openstack-nova04:53
*** claudiub|2 has joined #openstack-nova04:55
*** vivsoni has joined #openstack-nova05:00
*** fragatina has quit IRC05:01
*** wolverineav has quit IRC05:01
*** wolverineav has joined #openstack-nova05:01
*** gongysh has quit IRC05:09
*** gongysh has joined #openstack-nova05:12
*** abhishekk has joined #openstack-nova05:20
*** bingqianglin1 has joined #openstack-nova05:21
*** bingqianglin has quit IRC05:23
*** bingqianglin1 is now known as bingqianglin05:23
*** takashin has joined #openstack-nova05:23
*** gongysh has quit IRC05:24
*** sidx64 has joined #openstack-nova05:25
*** dpawlik has joined #openstack-nova05:39
*** dpawlik has quit IRC05:39
*** gongysh has joined #openstack-nova05:45
*** tojuvone has joined #openstack-nova05:50
takashin05:54
*** lajoskatona has joined #openstack-nova05:54
*** sar has quit IRC05:55
*** vivsoni has quit IRC05:56
*** vivsoni has joined #openstack-nova05:57
*** takedakn has joined #openstack-nova05:58
*** liuzz has joined #openstack-nova05:59
*** liuzz has quit IRC05:59
*** liuzz has joined #openstack-nova06:00
*** liuzz_ has quit IRC06:02
*** takedakn has quit IRC06:03
*** wolverineav has quit IRC06:08
*** wolverineav has joined #openstack-nova06:08
*** mvk has quit IRC06:10
*** fragatina has joined #openstack-nova06:10
*** mvk has joined #openstack-nova06:10
*** wolverineav has quit IRC06:12
*** jogo has quit IRC06:18
*** wolverineav has joined #openstack-nova06:20
*** sar has joined #openstack-nova06:23
*** edmondsw has joined #openstack-nova06:24
*** edmondsw has quit IRC06:28
*** lpetrut has joined #openstack-nova06:29
*** jchhatbar has joined #openstack-nova06:29
*** salv-orlando has joined #openstack-nova06:31
*** salv-orl_ has quit IRC06:31
*** janki has quit IRC06:32
*** do3meli has joined #openstack-nova06:33
*** ircuser-1 has joined #openstack-nova06:34
*** udesale_ has joined #openstack-nova06:34
*** udesale_ has quit IRC06:35
*** udesale_ has joined #openstack-nova06:35
openstackgerritHironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue  https://review.openstack.org/41648706:37
*** udesale has quit IRC06:38
*** sambetts_ has quit IRC06:38
*** vivsoni has quit IRC06:39
*** sidx64_ has joined #openstack-nova06:39
*** sambetts_ has joined #openstack-nova06:40
*** sidx64 has quit IRC06:41
*** andreas_s has joined #openstack-nova06:41
*** wolverineav has quit IRC06:41
*** sidx64 has joined #openstack-nova06:43
*** sidx64_ has quit IRC06:44
*** wolverineav has joined #openstack-nova06:48
*** vivsoni has joined #openstack-nova06:48
openstackgerritTetsuro Nakamura proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs  https://review.openstack.org/51960106:50
*** wolverineav has quit IRC06:50
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support relay RP for allocation candidates  https://review.openstack.org/53343706:50
*** slaweq has joined #openstack-nova06:51
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.61 - support extra_specs in flavor API  https://review.openstack.org/56152006:53
*** armaan_ has joined #openstack-nova06:54
*** armaan has quit IRC06:54
*** rcernin has quit IRC06:56
*** moshele has joined #openstack-nova07:00
*** brault has quit IRC07:07
*** fragatina has quit IRC07:08
arvindn05bauzas: wanted to discuss your comments on https://review.openstack.org/#/c/560718/ - Handle rebuild of instance with new image07:11
*** pcaruana has joined #openstack-nova07:13
*** jogo has joined #openstack-nova07:15
*** bkopilov has joined #openstack-nova07:17
*** tesseract has joined #openstack-nova07:21
*** yingjun has joined #openstack-nova07:24
*** gibi_awa1 is now known as gibi07:26
gibigood morning nova07:26
*** Dinesh_Bhor has joined #openstack-nova07:27
* gibi is trying to catch up07:27
*** ccamacho has joined #openstack-nova07:28
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates  https://review.openstack.org/55651407:28
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries  https://review.openstack.org/55804507:28
*** udesale__ has joined #openstack-nova07:32
*** tesseract has quit IRC07:33
*** udesale_ has quit IRC07:35
*** tesseract has joined #openstack-nova07:35
*** sahid has joined #openstack-nova07:36
*** Tom-Tom has quit IRC07:38
*** ragiman has joined #openstack-nova07:41
*** avolkov has joined #openstack-nova07:41
*** amoralej|off is now known as amoralej07:42
*** ralonsoh has joined #openstack-nova07:44
*** mgoddard has joined #openstack-nova07:44
openstackgerritMichael Still proposed openstack/nova master: Move IVS VIF plugging into the new utilities module.  https://review.openstack.org/55755207:45
openstackgerritMichael Still proposed openstack/nova master: Move create_tap_dev to the new utility method.  https://review.openstack.org/55783507:45
openstackgerritMichael Still proposed openstack/nova master: Move set_vf_interface_vlan to the new utility module.  https://review.openstack.org/55848707:45
*** dpawlik has joined #openstack-nova07:47
*** threestrands has quit IRC07:47
*** itlinux has joined #openstack-nova07:47
openstackgerritjichenjc proposed openstack/nova-specs master: Adds spec for instance live resize  https://review.openstack.org/14121907:47
*** lajoskatona has quit IRC07:51
*** jpena|off is now known as jpena07:51
*** evrardjp has joined #openstack-nova07:55
*** ralonsoh_ has joined #openstack-nova07:56
*** ralonsoh has quit IRC07:58
*** AlexeyAbashkin has joined #openstack-nova07:58
*** migi has quit IRC07:59
*** migi has joined #openstack-nova07:59
*** migi has quit IRC08:00
*** itlinux_ has joined #openstack-nova08:02
*** takashin has left #openstack-nova08:02
*** itlinux has quit IRC08:04
*** itlinux_ has quit IRC08:06
*** lajoskatona has joined #openstack-nova08:07
*** Tom-Tom has joined #openstack-nova08:08
*** sambetts_ has quit IRC08:09
*** lucas-afk is now known as lucasagomes08:10
*** jaosorior has joined #openstack-nova08:10
*** sambetts_ has joined #openstack-nova08:13
*** edmondsw has joined #openstack-nova08:13
*** edmondsw has quit IRC08:17
*** mdbooth has joined #openstack-nova08:19
*** mdnadeem has joined #openstack-nova08:19
*** gongysh has quit IRC08:22
*** gongysh has joined #openstack-nova08:25
openstackgerritSilvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver  https://review.openstack.org/55419508:26
*** derekh has joined #openstack-nova08:28
*** tssurya has joined #openstack-nova08:29
*** abhishekk_ has joined #openstack-nova08:31
*** abhishekk has quit IRC08:32
*** armaan has joined #openstack-nova08:34
*** armaan_ has quit IRC08:35
openstackgerritHironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue  https://review.openstack.org/41648708:36
*** brault has joined #openstack-nova08:36
*** yingjun has quit IRC08:37
*** abhishekk_ is now known as abhishekk08:39
*** gongysh has quit IRC08:40
*** gongysh has joined #openstack-nova08:43
openstackgerritSilvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver  https://review.openstack.org/55419508:46
*** lajoskatona has quit IRC08:47
*** itlinux has joined #openstack-nova08:53
*** itlinux has quit IRC08:54
kaisers1Hi! I'm looking for Novas policies on bugfix backports but so far was unable to find documentation on this, can somebody pls drop me a hint where to find this? :)08:57
*** itlinux has joined #openstack-nova08:57
*** brault_ has joined #openstack-nova09:00
bauzaskaisers1: https://docs.openstack.org/project-team-guide/stable-branches.html#proposing-fixes09:01
*** ralonsoh__ has joined #openstack-nova09:02
*** abhishekk has quit IRC09:02
*** brault has quit IRC09:02
*** lajoskatona has joined #openstack-nova09:02
bauzasarvindn05: hola09:03
bauzassure, I'm here now :)09:03
bauzasarvindn05: about the rebuild conditional, I saw it, but I'm not sure I like it, you know :)09:05
*** ralonsoh_ has quit IRC09:05
kaisers1bauzas: thanks!09:10
openstackgerritZhenyu Zheng proposed openstack/nova master: [WIP] Send out notification when instance metadata updated  https://review.openstack.org/55814009:12
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table.  https://review.openstack.org/56083209:16
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: WIP: complex policy  https://review.openstack.org/55377609:16
*** abhishekk has joined #openstack-nova09:19
*** cdent has joined #openstack-nova09:21
*** trinaths has joined #openstack-nova09:26
*** itlinux has quit IRC09:28
openstackgerritsahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes  https://review.openstack.org/48499709:33
openstackgerritsahid proposed openstack/nova master: libvirt: fix wrong driver name for vhostuser interface  https://review.openstack.org/56156209:33
*** hiro-kobayashi has quit IRC09:34
*** bhagyashris has quit IRC09:34
*** dr_gogeta86 has joined #openstack-nova09:34
*** dr_gogeta86 has quit IRC09:34
*** dr_gogeta86 has joined #openstack-nova09:34
*** Dinesh_Bhor has quit IRC09:35
*** armaan has quit IRC09:41
*** lajoskatona has quit IRC09:48
*** elmaciej has joined #openstack-nova09:51
*** gongysh has quit IRC09:51
*** elmaciej has quit IRC09:55
*** ociuhandu has joined #openstack-nova09:56
*** ociuhandu has quit IRC09:58
*** bingqianglin has quit IRC10:03
*** lajoskatona has joined #openstack-nova10:04
*** dpawlik has quit IRC10:05
*** sahid has quit IRC10:05
*** dpawlik has joined #openstack-nova10:05
*** jichen has quit IRC10:08
*** sahid has joined #openstack-nova10:08
*** tianhui has quit IRC10:12
*** tianhui has joined #openstack-nova10:13
*** alexchadin has joined #openstack-nova10:16
*** elmaciej has joined #openstack-nova10:18
*** bhagyashris has joined #openstack-nova10:19
*** cdent has quit IRC10:21
*** tianhui_ has joined #openstack-nova10:24
*** tianhui has quit IRC10:26
*** fragatina has joined #openstack-nova10:32
*** nicolasbock has joined #openstack-nova10:33
*** armaan has joined #openstack-nova10:35
*** chenyb4 has quit IRC10:36
*** nicolasbock has quit IRC10:39
*** sdague has joined #openstack-nova10:40
*** stakeda has quit IRC10:42
*** armaan has quit IRC10:45
*** damien_r has joined #openstack-nova10:45
*** pooja_jadhav has joined #openstack-nova10:49
*** cdent has joined #openstack-nova10:50
*** damien_r has quit IRC10:54
*** tbachman has quit IRC10:56
*** fragatina has quit IRC10:57
*** slagle has joined #openstack-nova10:57
*** abhishekk has quit IRC11:02
*** lucasagomes is now known as lucas-hungry11:04
*** udesale__ has quit IRC11:05
*** sambetts_ is now known as sambetts11:06
openstackgerritMartin Midolesov proposed openstack/nova master: [vmwareapi] Expose cpu model on homogeneous cluster  https://review.openstack.org/56158811:07
*** armaan has joined #openstack-nova11:13
*** bkopilov has quit IRC11:16
*** itlinux has joined #openstack-nova11:16
*** nicolasbock has joined #openstack-nova11:17
*** mdbooth has quit IRC11:18
*** mdbooth has joined #openstack-nova11:19
*** trinaths has quit IRC11:23
openstackgerritMatthew Booth proposed openstack/nova master: Pass disk_info dict to libvirt_info  https://review.openstack.org/52932911:34
openstackgerritMatthew Booth proposed openstack/nova master: Expose volume host type and path independent of libvirt config  https://review.openstack.org/53078611:34
openstackgerritMatthew Booth proposed openstack/nova master: Don't generate fake disk_info in swap_volume  https://review.openstack.org/53078711:34
openstackgerritMatthew Booth proposed openstack/nova master: Local disk serial numbers for the libvirt driver  https://review.openstack.org/52938011:34
*** alexchadin has quit IRC11:37
*** sidx64 has quit IRC11:38
*** sidx64 has joined #openstack-nova11:39
*** hshiina is now known as hshiina|afk11:42
*** armaan has quit IRC11:46
*** armaan has joined #openstack-nova11:47
*** armaan_ has joined #openstack-nova11:50
*** armaan has quit IRC11:50
*** dave-mcc_ has joined #openstack-nova11:59
*** markvoelker has joined #openstack-nova11:59
*** dave-mccowan has quit IRC12:01
*** Tom-Tom has quit IRC12:01
*** Tom-Tom has joined #openstack-nova12:02
*** lucas-hungry is now known as lucasagomes12:02
cdentwelcome back gibi, hope you had a great honeymoon12:04
*** mvk has quit IRC12:05
*** QianYu has joined #openstack-nova12:05
*** Tom-Tom has quit IRC12:06
*** amoralej is now known as amoralej|lunch12:07
*** tbachman has joined #openstack-nova12:08
*** cdent has quit IRC12:08
*** armaan_ has quit IRC12:10
*** QianYu has quit IRC12:10
*** armaan has joined #openstack-nova12:11
*** armaan has quit IRC12:15
*** pchavva has joined #openstack-nova12:20
*** edmondsw has joined #openstack-nova12:21
*** mgoddard has quit IRC12:21
openstackgerritLee Yarwood proposed openstack/nova stable/pike: libvirt: Block swap volume attempts with encrypted volumes prior to Queens  https://review.openstack.org/54356912:22
*** tbachman has quit IRC12:24
*** udesale__ has joined #openstack-nova12:24
*** udesale__ has quit IRC12:26
*** udesale has joined #openstack-nova12:26
*** leakypipes is now known as jaypipes12:27
*** dims has joined #openstack-nova12:30
openstackgerritLee Yarwood proposed openstack/nova stable/ocata: Refactor a test method including 3 test cases  https://review.openstack.org/56160312:30
openstackgerritLee Yarwood proposed openstack/nova stable/ocata: libvirt: Block swap volume attempts with encrypted volumes prior to Queens  https://review.openstack.org/56160412:30
*** tbachman has joined #openstack-nova12:31
*** cdent has joined #openstack-nova12:33
*** alexchadin has joined #openstack-nova12:33
*** owalsh has quit IRC12:34
*** owalsh has joined #openstack-nova12:35
gibicdent: thanks! We had a great honeymoon indeed12:37
cdent\o/12:37
*** liuzz_ has joined #openstack-nova12:37
*** yamamoto has quit IRC12:38
efriedSay, anyone been after the gate yet this morning?  I noticed it started failing pretty consistently on Friday (of course).12:38
* gibi haven't had the chance to look at the gate state yet12:39
efriedcdent: You know things about grenade, yah?12:41
*** amoralej|lunch is now known as amoralej12:41
cdentefried: there's discussion on os-dev related to neutron and requirements handling breaking the gate12:41
cdentso I think it is being worked on already12:41
*** liuzz has quit IRC12:41
efriedoh, okay.12:41
efriedSo it's not nova's fault?12:41
*** owalsh has quit IRC12:42
cdentas far as I was able to discern, no12:42
*** owalsh has joined #openstack-nova12:42
efriedk, I guess I'll just wait, then.12:42
* efried starts deleting zuul failure emails...12:42
*** armaan has joined #openstack-nova12:43
*** kholkina has joined #openstack-nova12:45
*** itlinux has quit IRC12:46
cdentefried: this is at least one of the bugs: https://bugs.launchpad.net/devstack/+bug/176396612:46
openstackLaunchpad bug 1763966 in grenade "python-psutil dependency error on ubuntu 16.04.4" [Undecided,New]12:46
efriedack12:47
*** sidx64 has quit IRC12:47
*** oanson has quit IRC12:49
*** mvk has joined #openstack-nova12:49
bauzasefried: yet again working on my NUMA spec12:51
*** chenyb4 has joined #openstack-nova12:51
efriedmhm12:52
bauzasefried: tbh, I need to look again at your own group spec12:52
* efried provides bauzas helpful link: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/granular-resource-requests.html12:52
bauzasyeah I'm looking at it now12:53
*** sidx64 has joined #openstack-nova12:55
*** armaan has quit IRC12:55
*** armaan has joined #openstack-nova12:56
*** mgoddard has joined #openstack-nova12:56
*** chenyb4 has quit IRC12:56
bauzasefried: /me trying to understand https://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/granular-resource-requests.html#requirement-312:56
*** oanson has joined #openstack-nova12:57
efriedbauzas:  You should note that jaypipes has proposed an amendment which appreciably changes things: https://review.openstack.org/#/c/560974/ -- but if I have my way, that delta will die a fiery death.12:57
efriedbauzas: requirement 3 is saying that we want to be able to land our instance even if it means spreading VCPU resources across multiple NUMA nodes because we're reaching a point where they're getting pretty full and we can't fit all of them on one.12:58
*** sdeath has quit IRC12:58
*** bkopilov has joined #openstack-nova12:59
*** LAKUNI1 has joined #openstack-nova12:59
bauzasefried: what I don't understand is, if I have a tree with for example a RP, and then a child RP passing VGPU resources, would I still have the compute UUID RP being accepted if I'm saying some unnumbered group, like resources:VCPU=1&VGPU=1 ?12:59
*** dklyle has joined #openstack-nova13:00
*** ArchiFleKs has quit IRC13:00
bauzasor do I need to ask for resources1:VCPU=1&resources2:VGPU=1 ?13:00
LAKUNI1ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss13:00
*** armaan has quit IRC13:00
artomsnek!13:00
efriedbauzas: In that situation, either one would be fine.13:01
bauzasefried: because atm, the main RP is having VGPU inventories, but after my implementation, it would have a nested RP which would only pass VGPU13:01
bauzasefried: ok cool then13:01
bauzasefried: then why people should care about numbered req groups ?13:01
*** yamamoto has joined #openstack-nova13:01
* bauzas trying to understand the usecases13:02
efriedbauzas: Because let's say for example you want two VFs on different networks.13:02
efriedNetworks are represented by traits on the PF RPs.13:02
efriedWe don't allow you to say resources=VF:1,VF:113:02
*** vladikr has joined #openstack-nova13:02
bauzasaha, I see it written   The semantic for the (single) un-numbered grouping is unchanged.  That is, it may still return results from different RPs in the same tree (or, when “shared” is fully implemented, the same aggregate). However, a numbered group will always return results from the same RP. This is to satisfy Requirement 2.13:03
*** LAKUNI1 has left #openstack-nova13:04
openstackgerritArtom Lifshitz proposed openstack/nova stable/queens: only increment disk address unit for scsi devices  https://review.openstack.org/56119613:04
bauzasefried: ok, so, resources:VGPU:1,VCPU=1 is identical to resources1:VGPU=1&resources2:VGPU=1 but *not equivalent to* resources1:VGPU=1,VCPU=113:04
bauzasbecause if you're passing multiple resource classes to the same numbered group, then they need to be in the same RP13:04
bauzasright?13:05
efriedbauzas: With the spec as written, that's correct.  With jaypipes' amendment, those would be very different.13:05
bauzasargh13:05
efriedSorry, that was confusing.13:05
bauzasefried: https://review.openstack.org/#/c/560974/1/specs/rocky/approved/granular-resource-requests.rst@34 right?13:05
bauzasthe conf option that would modify the behaviour ?13:05
bauzasI'm not sure I like that13:05
*** armaan has joined #openstack-nova13:07
efriedThe conf option would allow you to specify resource classes in the spec that allow their units to be spread across multiple RPs, when specified in the un-numbered request group.13:07
*** sidx64 has quit IRC13:07
*** trozet has joined #openstack-nova13:07
openstackgerritJay Pipes proposed openstack/nova-specs master: Numbered request groups use different providers  https://review.openstack.org/56097413:08
efriedbauzas: I think jaypipes was trying to satisfy the "spread" use case.  So you would put VCPU in that conf option, and then you could say resources=VCPU:4, and placement would *first* try to fit all the VCPUs on one RP, but if it couldn't, it would then try to do 2 and 2, and then 1,1,1,113:08
bauzasefried: I see13:08
*** dklyle has quit IRC13:09
openstackgerritArtom Lifshitz proposed openstack/nova stable/pike: only increment disk address unit for scsi devices  https://review.openstack.org/56161113:09
jaypipesefried: sorry, just pushed up a new rev on that. didn't change much, though.13:09
*** lyan has joined #openstack-nova13:09
bauzasefried: I'm rushing to upload my spec so we could be discussing about that13:09
*** lyan is now known as Guest9890313:10
efriedjaypipes: ack.  I was just responding to cdent's comments...13:10
jaypipesefried: yup, I responded to both you and cdent on the last revision review.13:10
openstackgerritArtom Lifshitz proposed openstack/nova stable/ocata: only increment disk address unit for scsi devices  https://review.openstack.org/56161313:11
*** awaugama has joined #openstack-nova13:11
*** mriedem has joined #openstack-nova13:13
*** M0z122 has joined #openstack-nova13:17
openstackgerritSylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs  https://review.openstack.org/55292413:19
bauzasefried: jaypipes: you could be interested in ^13:19
jaypipesbauzas: s/could/will/13:20
efriedack13:20
*** ttsiouts_ has joined #openstack-nova13:22
*** fabian_ has joined #openstack-nova13:26
*** jroll has quit IRC13:26
*** QianYu has joined #openstack-nova13:26
*** jroll has joined #openstack-nova13:27
*** zhaochao has quit IRC13:27
M0z122Hi there,13:29
*** mdbooth has quit IRC13:29
M0z122I'm interested in LVM backed instances, But it seems that cold migrate,live-migration,live snapshoting, resize are not implemented  when images_type == lvm. Do you know if there are any onging dev on this, or any plan to dev it ?13:29
* bauzas back to code13:31
*** superdan is now known as dansmith13:35
*** ratailor has quit IRC13:36
*** burt has joined #openstack-nova13:37
*** mgariepy has joined #openstack-nova13:38
openstackgerritLee Yarwood proposed openstack/nova stable/ocata: libvirt: Block swap volume attempts with encrypted volumes prior to Queens  https://review.openstack.org/56160413:40
*** esberglu has joined #openstack-nova13:42
mriedemM0z122: cfriesen has code for that i believe13:43
*** armaan has quit IRC13:45
*** armaan has joined #openstack-nova13:46
*** psachin has quit IRC13:47
*** yingjun has joined #openstack-nova13:47
*** QianYu_ has joined #openstack-nova13:48
*** bhagyashris has quit IRC13:48
*** QianYu has quit IRC13:48
*** jmlowe_ has quit IRC13:49
*** bhagyashris has joined #openstack-nova13:49
*** eharney has joined #openstack-nova13:49
*** awaugama has quit IRC13:50
*** pooja-jadhav has joined #openstack-nova13:51
openstackgerritMerged openstack/nova master: Fix doc link for api  https://review.openstack.org/56149913:51
*** alexchadin has quit IRC13:52
*** pooja_jadhav has quit IRC13:52
dansmithmriedem: should we be holding off on approvals for the current fails? seems to have hit everything I've looked at this morning already13:52
*** sar has quit IRC13:53
efrieddansmith: Doc-only fixes are kosher :)  ---^13:53
*** gongysh has joined #openstack-nova13:53
dansmith...yeah, and/13:53
efrieddansmith: cdent was telling me earlier we think this has something to do with neutron and requirements, with this being one of the culprits: https://bugs.launchpad.net/devstack/+bug/176396613:54
openstackLaunchpad bug 1763966 in devstack "python-psutil dependency error on ubuntu 16.04.4" [Critical,Fix released] - Assigned to hongbin (hongbin034)13:54
*** derekh has quit IRC13:54
*** jmlowe has joined #openstack-nova13:54
dansmithefried: right I know,13:54
efriednot nova-specific, beind discussed in #openstack-dev13:54
dansmithI know13:55
efriedokay.13:55
*** armaan has quit IRC13:55
dansmithI'm asking if it's 100%, because I assume it is,13:55
dansmiththus no reason to send anything into recheck or the gate13:55
efriedIt seems to be.  Except for doc fixes.13:55
efriedRight.13:55
*** alexchadin has joined #openstack-nova13:55
*** armaan has joined #openstack-nova13:55
*** derekh has joined #openstack-nova13:56
mriedemmaster is fine13:56
efrieddansmith: So yeah, you should hold off +A on the zvm series.13:56
efriedbut only til the gate is fixed13:56
mriedemhttps://review.openstack.org/#/q/I8bf80efc04883cd754c19bea0303064080112c6e13:56
dansmithoh as of an hour ago, okay13:56
efriedoh, okay, cool.13:57
dansmithall the ones I'm looking at were before that13:57
*** r-daneel has quit IRC13:57
*** fabian_ has quit IRC13:57
edleafeScheduler subteam meeting in 1 minute in #openstack-meeting-alt13:59
*** takashin has joined #openstack-nova13:59
*** ragiman has quit IRC14:03
*** liverpooler has joined #openstack-nova14:05
*** sar has joined #openstack-nova14:07
*** udesale has quit IRC14:11
*** mlavalle has joined #openstack-nova14:11
*** udesale has joined #openstack-nova14:12
M0z122mriedem: thanks, will ask to cfriesen14:12
*** QianYu has joined #openstack-nova14:13
*** QianYu_ has quit IRC14:13
*** jmlowe has quit IRC14:13
*** felipemonteiro has joined #openstack-nova14:15
*** jmlowe has joined #openstack-nova14:16
*** ragiman has joined #openstack-nova14:18
*** mdbooth has joined #openstack-nova14:24
openstackgerritMerged openstack/nova-specs master: Spec for isolating configuration of placement database  https://review.openstack.org/55292714:26
*** lpetrut_ has joined #openstack-nova14:28
*** pchavva has quit IRC14:29
*** lpetrut has quit IRC14:32
*** jmlowe has quit IRC14:32
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Stop printing flavor details on successful flavor-delete  https://review.openstack.org/56163414:33
*** moshele has quit IRC14:33
*** cdent has quit IRC14:42
*** kosamara has joined #openstack-nova14:42
*** vladikr has quit IRC14:42
*** pchavva has joined #openstack-nova14:43
*** takashin has left #openstack-nova14:44
*** vladikr has joined #openstack-nova14:44
*** sahid has quit IRC14:44
*** QianYu_ has joined #openstack-nova14:46
*** QianYu has quit IRC14:46
*** dpawlik has quit IRC14:46
*** dpawlik has joined #openstack-nova14:48
kosamaraHi mriedem, I've updated https://review.openstack.org/#/c/555861/ Can you take a look if you have the time?14:51
*** sdeath has joined #openstack-nova14:52
mriedemi'll put it in the browser tab queue14:52
*** armaan has quit IRC14:53
*** armaan has joined #openstack-nova14:53
*** alexchadin has quit IRC14:55
*** jmlowe has joined #openstack-nova14:56
*** fabian_ has joined #openstack-nova14:56
*** gcb has joined #openstack-nova14:56
*** namnh has joined #openstack-nova14:57
*** felipemonteiro_ has joined #openstack-nova14:59
*** beekneemech is now known as bnemec14:59
*** rajinir has joined #openstack-nova14:59
*** hongbin_ has joined #openstack-nova14:59
*** felipemonteiro has quit IRC15:02
*** r-daneel has joined #openstack-nova15:03
*** finucannot is now known as stephenfin15:03
*** ttsiouts_ has quit IRC15:05
*** QianYu has joined #openstack-nova15:07
*** QianYu_ has quit IRC15:07
*** cdent has joined #openstack-nova15:08
*** pcaruana has quit IRC15:09
*** kholkina has quit IRC15:10
*** tbachman has quit IRC15:11
*** ragiman has quit IRC15:11
kashyapHi folks, wonder if anyone has time to look at why is 'mox' raising UnexpectedMethodCallError with this unit test: http://paste.openstack.org/show/719304/15:13
kashyapI posted two code fragments the test points to (from guest.py & driver.py in nova/libvirt)15:14
*** sahid has joined #openstack-nova15:15
*** ralonsoh__ has quit IRC15:15
* kashyap has even double-checked the parameters of migrateToURI3() and they definitely didn't change in a while. So, "method is called with incorrect parameters" is definitely not one of the reasons for failure15:16
kashyapmdbooth: Wonder if you have a minute to look at the above (read prior 3 lines of scroll for context)?  Last I recall, you made the change to that surrounding code. :-)15:18
* mdbooth reads back15:18
kashyapmdbooth: So, that UnexpectedMethodCallError is raised when "if a method is called with incorrect parameters, or out of the specified order".15:19
kashyapNeither is the case, from my reading.15:19
mdboothkashyap: What have you changed?15:20
mdboothkashyap: pastebin your local diff15:20
*** armaan has quit IRC15:20
kashyapFixing the fall out of bumping versions: https://review.openstack.org/#/c/558783/15:20
*** armaan has joined #openstack-nova15:21
mdboothkashyap: I'll fire it up locally15:21
* kashyap has fixed the merge conflict locally; the 4 tests that are failing, mostly point to the above usage15:21
kashyapmdbooth: Then, wait -- let me post the merge-conflict fixed series15:21
* mdbooth sighs15:22
mdboothI can't pull it right now15:22
kashyapYeah, it's merge conflict; I fixed it this morning locally.  Pushing the new rev in a couple.  I'll notify15:23
* mdbooth looks for an ethernet cable15:23
efriedkashyap: Note that takashin is doing a whole slew of patches to remove mox.15:23
*** ragiman has joined #openstack-nova15:24
kashyapefried: So, he'll be replacing it w/ Mock, is it?15:24
efriedkashyap: Yes.  There's a bp for that, so I'm sure he would welcome the help if you'd like to propose a "fix" for this problem that happens to swap out mox for mock.15:24
*** tssurya has quit IRC15:24
efriedkashyap: https://review.openstack.org/#/q/project:openstack/nova+branch:master+topic:bp/mox-removal15:25
kashyapefried: I'll see about it.  Python unit tests is one my Python weakness area15:25
kashyapFirst trying to remove all the now-needless compat code due to the version bumps15:25
*** tbachman has joined #openstack-nova15:25
efriedkashyap: No pressure :)15:26
kashyapThanks for the (non-null) pointer15:27
mdboothefried kashyap: I'd recommend against mixing those 2 changes, though.15:28
kashyapmdbooth: Yeah, I'm strictly following the "One logical change per patch"15:28
kashyapNo madness15:28
*** mdbooth_ has joined #openstack-nova15:28
kashyapBut appreciate the reminder :-)15:28
*** awaugama has joined #openstack-nova15:29
mdbooth_kashyap: Don't know if ^^^ sent, but I recommend against mixing those 2 changes.15:29
kashyapmdbooth_: Yep, got sent.  And then I wrote:  < kashyap> mdbooth: Yeah, I'm strictly following the "One logical change per patch" rule15:29
cfriesenmriedem: M0z122: I think this was the last time I tried to push LVM resize/migration upstream: https://review.openstack.org/#/c/337334/15:30
mdbooth_cfriesen: Aside: do you get a performance benefit from lvm?15:31
openstackgerritMerged openstack/nova master: Add config drive link to api-guide  https://review.openstack.org/56111315:32
*** jchhatbar has quit IRC15:32
*** mdbooth has quit IRC15:32
cfriesenmdbooth_: last time we checked, I think there was a difference, but I don't know that we've checked in a while.  Have you seen more recent benchmarks?15:32
mdbooth_cfriesen: No, but I vaguely recall that it was marginal at best.15:33
*** jistr is now known as jistr|mtg15:33
mdbooth_cfriesen: Over raw, that is.15:33
mdbooth_Just wondering if you had data which showed it's worth the bother.15:33
M0z122cfriesen: many thks will have a look on it15:34
openstackgerritArtom Lifshitz proposed openstack/nova master: Add DifferentHostFilter to enabled_filters default  https://review.openstack.org/56165115:35
*** fabian_ has quit IRC15:35
mdbooth_cfriesen: Intuitively, I'd expect that if you fallocate a raw file which isn't fragmented and open it O_DIRECT, all of which I think we do, the performance should be the same as LVM, as the kernel is basically doing the same in both cases.15:37
*** armaan has quit IRC15:38
mdbooth_cfriesen: Numbers beat intuition of course, though :)15:38
*** armaan has joined #openstack-nova15:38
*** felipemonteiro_ has quit IRC15:40
*** jdillaman has joined #openstack-nova15:41
*** andreas_s has quit IRC15:42
*** andreas_s has joined #openstack-nova15:43
*** do3meli has quit IRC15:45
*** Nisha_Agarwal has joined #openstack-nova15:46
*** lucasagomes is now known as lucas-brb15:47
*** jpena is now known as jpena|brb15:47
*** jackie-truong has joined #openstack-nova15:48
*** mgagne_ is now known as mgagne15:50
Nisha_AgarwalHi team, I have 2 stable pike devstack setups- one stacked last week on a freshly imaged system and another stacked around a month ago. When i was trying "nova boot" for ironic nodes on both the setups i land up in this error http://paste.openstack.org/show/719143/ due to which it send the "delete" event to ironic node as soon as it goes to "wait-call-back" state. On debugging we found that it happens because instance's context is set to15:52
Nisha_AgarwalNone at some point. We commented out this line https://github.com/openstack/nova/blob/stable/pike/nova/objects/instance.py#L824 and the deploy goes thru.15:52
*** yingjun has quit IRC15:55
*** QianYu has quit IRC15:55
dansmithmelwitt: did you see my comment on that bottom certs patch? I think she reverted the changes she made for you15:55
openstackgerritArtom Lifshitz proposed openstack/nova master: Add (Same|Different)HostFilter to defaults  https://review.openstack.org/56165115:57
Nisha_Agarwaldansmith, could you help me with above? Should i go ahead and open the defect against Nova for the OrphanedObject error reported on stable/pike?15:57
*** andreas_s has quit IRC15:57
Nisha_Agarwalor there is some configuration in the config file which i should be setting so that the issue is not hit?15:57
*** tbachman has quit IRC15:58
*** namnh has quit IRC16:00
*** mdbooth_ is now known as mdbooth16:01
dansmithNisha_Agarwal: orphaned objects are those without a context set, which prevents them from doing things like loading or saving from the database16:01
dansmithNisha_Agarwal: obviously no config option should cause/prevent that16:02
*** andreas_s has joined #openstack-nova16:02
*** gcb has quit IRC16:02
*** derekh has quit IRC16:03
*** gongysh has quit IRC16:03
cfriesenmriedem: we're running into problems with the code that adds a uuid to services on the fly.  it seems that calling service.save() on a deleted service doesn't work.  it chokes down in service_get()16:03
*** jistr|mtg is now known as jistr16:03
mriedemcfriesen: where do we save() a deleted service?16:04
cfriesenService._from_db_object(), if there's no uuid16:04
mriedemmight be a bug that melwitt has recently fixed16:04
mriedemcfriesen: https://review.openstack.org/#/c/555923/16:05
mriedemis that it?16:05
*** dpawlik has quit IRC16:05
dansmithyeah16:06
dansmithwas going to say16:06
mriedemif it's not that, then i will need to see a stacktrace rather than a dead cat16:06
openstackgerritJackie Truong proposed openstack/nova master: Implement certificate_utils  https://review.openstack.org/47994916:07
openstackgerritJackie Truong proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths  https://review.openstack.org/56126216:07
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API  https://review.openstack.org/48620416:07
openstackgerritJackie Truong proposed openstack/nova master: Add certificate validation docs  https://review.openstack.org/56015816:07
cfriesenmriedem: so previously we were hitting the bug that commit was fixing...so we applied that fix and hit this other problem.  Stacktrace at http://paste.openstack.org/show/719308/16:07
Nisha_Agarwaldansmith, the issue is seen on both the stable pike setups as soon as nova calls this https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1102 which in turn hits https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L45216:08
mriedemgibi: welcome back - you might have an opinion on the last comment i left here about notifications https://review.openstack.org/#/c/486204/16:08
dansmithcfriesen: is that service deleted?16:08
mriedemi'll throw it in the notification meeting16:08
cfriesendansmith: yes16:08
dansmithcfriesen: that's why, but I thought we determined it shouldn't even be processing deleted services.. did you tweak something in there?16:08
*** dpawlik has joined #openstack-nova16:09
cfriesendansmith: the sequence of events was:  boot instance on compute node, migrate instance, delete compute node and service, upgrade to pike, create new compute node with same name, migrate instance back to that compute node.16:09
cfriesendansmith: so now when we look up the service by name, there are two matching entries, one of which is deleted16:09
dansmithcfriesen: but we're using model_query which should filter out the deleted one, IIRC16:10
openstackgerritJay Pipes proposed openstack/nova-specs master: Numbered request groups use different providers  https://review.openstack.org/56097416:10
*** QianYu has joined #openstack-nova16:10
mriedemcfriesen: i need more of the stacktrace16:10
mriedemnot the middle of it16:10
stephenfinbauzas: Want to weigh in on this comment? https://review.openstack.org/#/c/379525/9/nova/scheduler/weights/cpu.py16:11
cfriesenmriedem: will try to get it.16:11
stephenfinbauzas: We don't do this for RAM or disk. Should we?16:11
*** gjayavelu has joined #openstack-nova16:12
mriedemstephenfin: the core filter does16:12
mriedemvcpus_total = host_state.vcpus_total * cpu_allocation_ratio16:12
*** gyee has joined #openstack-nova16:13
mriedemstephenfin: also, it looks like the HostState object takes into account reserved_host_cpus?16:13
*** dpawlik has quit IRC16:14
cfriesenmriedem: I think the core/ram/disk filters account for allocation ratio (though disk is wonky), but maybe the weighers don't?16:14
stephenfinmriedem: *don't take into account?16:15
mriedemyeah doens't take into account16:15
mriedemthe inventory on the resource provider for the compute node in placement accounts for reserved values16:15
mriedembut i don't see that on the HostState object or it's wrapped compute node16:16
stephenfinmriedem: Line 1136 of nova/compute/resource_tracker.py ?16:16
cfriesenlooks like for ram and disk they just weigh them based on the "free" amount16:16
stephenfin(_update_usage_from_instances function)16:16
stephenfinSo I'm guessing it gets it from the ComputeNode object16:16
mriedemstephenfin: hmm, yeah, but that's weird.16:17
mriedemcn.vcpus_used = CONF.reserved_host_cpus16:17
mriedemthat's not accounting for the number of instances running on the ohst16:18
mriedem*host16:18
stephenfinmriedem: We do that at the end of the function with the call to '_update_usage_from_instance', I suspect16:18
stephenfinWhich presumably appends rather than overwrites16:19
stephenfincfriesen: Hmm, so as we don't have a "free"-style attribute for CPUs I guess they're correct and we've to figure that out ourselves16:19
stephenfinOr add such an attribute16:19
*** QianYu has quit IRC16:20
mriedemstephenfin: yeah looks like _update_usage()16:20
*** andreas_s has quit IRC16:20
mriedemwhich also takes into account overhead from the virt driver16:21
mriedemvcpus_usage += overhead.get('vcpus', 0)16:21
mriedemok left some comments in your change for reference16:23
stephenfinmriedem: Excellent. Ta16:23
mriedemi won't profess to know what the right answer is16:23
mriedemit does match this though https://github.com/openstack/nova/blob/fb0b785169e5e422b06e82f2eb58e68f6d2008b3/nova/compute/resource_tracker.py#L78616:23
*** lbragstad has quit IRC16:24
* stephenfin goes to investigate16:24
*** QianYu_ has joined #openstack-nova16:24
mriedemthis is the claim code16:24
mriedemhttps://github.com/openstack/nova/blob/fb0b785169e5e422b06e82f2eb58e68f6d2008b3/nova/compute/claims.py#L18516:24
mriedemwhich is what ultimately matters16:24
*** andreas_s has joined #openstack-nova16:25
*** tbachman has joined #openstack-nova16:26
mriedemthe fun part is,16:26
mriedemif you're using placement, you shouldn't enable the CoreFilter, which means the vcpus limit isn't passed from scheduler to compute, and no vcpus claim is actually done in the resource tracker16:26
*** hemna_ has joined #openstack-nova16:26
cfriesenmriedem: here's the full trace: http://paste.openstack.org/show/719309/16:26
mriedemthe only actual RT claim we should ever have, if you're using placement, right now is for numa16:26
mriedemand maybe pci?16:26
*** ejat has quit IRC16:27
*** ejat has joined #openstack-nova16:27
*** ejat has quit IRC16:27
*** ejat has joined #openstack-nova16:27
mriedemcfriesen: that's the exact same thing that melwitt fixed16:27
cfriesenmriedem: no, melwitt's change was a reader->writer context thing16:27
*** jmlowe has quit IRC16:28
mriedemhmm, so more similar to Ic2f239f634f917a5771b0401a5073546c710c03616:29
mriedemexcept in that case the instance is deleted but the service isn't16:29
*** derekh has joined #openstack-nova16:30
mriedemdansmith: didn't you recently have a read_deleted thing in the Instance object for evacuate?16:30
dansmithmriedem: idk16:30
mriedemhttps://github.com/openstack/nova/commit/619754f5c836ed1b58c807138836e6cf5a4e6904#diff-1b01e8e37be9d889295e5333b785713916:31
*** udesale has quit IRC16:31
mriedemcfriesen: https://review.openstack.org/#/q/Ide6cc5bb1fce2c9aea9fa3efdf940e8308cd9ed016:31
*** QianYu_ has quit IRC16:32
*** jpena|brb is now known as jpena|off16:32
mriedemmaybe you have that already...16:32
*** hemna_ has quit IRC16:32
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky"  https://review.openstack.org/55878316:34
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_{LIBVIRT_KVM,QEMU}_S390_VERSION  https://review.openstack.org/56036316:34
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_KVM_PPC64_VERSION  https://review.openstack.org/56036416:34
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_VIRTUOZZO_VERSION  https://review.openstack.org/56036516:34
cfriesenmriedem: nope, don't have it.  will try it out.  thanks.16:34
kashyapmdbooth: ^ If you want to fetch now.16:34
*** mdbooth has quit IRC16:38
stephenfinmriedem: If I request 30 CPUs and I only have 22 available, I get a negative number for https://github.com/openstack/nova/blob/fb0b785169e5e422b06e82f2eb58e68f6d2008b3/nova/compute/resource_tracker.py#L78616:39
*** ragiman has quit IRC16:39
stephenfinmriedem: Sounds like a bug to me at least16:39
*** jpena|off is now known as jpena16:39
*** lpetrut_ has quit IRC16:39
*** andreas_s has quit IRC16:39
mriedemstephenfin: if you request 30 CPUs and the compute node is reporting it only has 22, then the scheduler should filter out that host and you never hit that compute, right?16:40
cfriesenstephenfin: I think all of those should factor in allocation ratio somehow16:40
cfriesenmriedem: not if  cpu_allocation_ratio is 216:40
stephenfinmriedem: I've 22 * 1616:40
stephenfinAt least, assuming I'm understanding overcommit correctly16:41
stephenfinThe only thing it should fail on is a single instance having > 22 vCPUs16:41
*** yamamoto has quit IRC16:41
stephenfin(No self-overcommit)16:41
mriedemsure, misunderstanding. then i guess that's why the CoreFilter cares about allocation ratio yeah? https://github.com/openstack/nova/blob/fb0b785169e5e422b06e82f2eb58e68f6d2008b3/nova/scheduler/filters/core_filter.py#L4916:42
cfriesenwhen we moved away from per-host-aggregate allocation ratios, it might have made sense to remove all knowledge of allocation ratios from anywhere but the compute node itself and just have it lie about how many it has. :)16:42
mriedemand placement for that matter16:42
stephenfinmriedem: I guess so, yeah. Fair play to Rong Han for spotting it16:42
mriedemmaybe he already has that weighter out of tree and is just comparing :)16:42
stephenfincfriesen: Agreed. Do wonder how that would affect CPU pinning though. Don't we use that?16:43
cfriesenhow do we support disk allocation ratios with network disks, when different compute nodes could have different allocation ratios configured?16:43
cfriesenstephenfin: pinning ignores the ratios, always 1:116:43
stephenfinmriedem: I'd put money on it :)16:43
* mriedem goes to snow blow the driveway16:44
stephenfincfriesen: Not in the ComputeNode was reporting N * ratio free CPUs though, right?16:44
mriedem(again)16:44
stephenfinAlthough that's neither here nor there. I'll fix this up here and then fix up the log16:44
cfriesenstephenfin: pinning doesn't use that count16:44
stephenfinwhich seems broken16:44
stephenfincfriesen: Ah, potential clean up so16:44
*** andreas_s has joined #openstack-nova16:44
cfriesenstephenfin: at least, I'm about 90% sure it doesn't. :)16:44
*** gjayavelu has quit IRC16:45
*** yamamoto has joined #openstack-nova16:46
*** fragatina has joined #openstack-nova16:46
*** sahid has quit IRC16:46
cfriesenjaypipes: do you know how we handle disk_allocation_ratio as a per-compute-node config option when we're using shared disk resource providers?16:48
* stephenfin heads out into the rain16:49
* cfriesen still has snow16:49
*** Nisha_Agarwal has quit IRC16:49
*** hemna_ has joined #openstack-nova16:50
*** yamamoto has quit IRC16:51
*** armaan has quit IRC16:52
*** gjayavelu has joined #openstack-nova16:56
*** andreas_s has quit IRC16:58
*** abhishekk has joined #openstack-nova16:58
*** derekh has quit IRC17:01
*** yamamoto has joined #openstack-nova17:01
*** calebb has quit IRC17:04
*** mgoddard has quit IRC17:05
*** mdnadeem has quit IRC17:05
*** yamamoto has quit IRC17:06
*** moshele has joined #openstack-nova17:09
*** yamamoto has joined #openstack-nova17:11
*** yamamoto has quit IRC17:11
*** mvk has quit IRC17:13
*** calebb has joined #openstack-nova17:15
*** AlexeyAbashkin has quit IRC17:17
*** elmaciej has quit IRC17:17
*** diegows has quit IRC17:18
*** jpena is now known as jpena|off17:19
*** yamahata has quit IRC17:20
*** felipemonteiro has joined #openstack-nova17:21
openstackgerritEric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates  https://review.openstack.org/51775717:22
*** hemna_ has quit IRC17:23
*** gjayavelu has quit IRC17:26
openstackgerritChris Dent proposed openstack/nova master: WIP: Parse forbidden in extra_specs  https://review.openstack.org/56167717:28
*** sridharg has quit IRC17:32
*** r-daneel has quit IRC17:34
*** r-daneel has joined #openstack-nova17:35
jaypipescfriesen: nobody is yet using shared disk resource providers, so I don't know :)17:37
*** mgoddard has joined #openstack-nova17:41
*** jmlowe has joined #openstack-nova17:42
*** elmaciej has joined #openstack-nova17:42
*** lbragstad has joined #openstack-nova17:43
*** felipemonteiro_ has joined #openstack-nova17:45
*** abhishekk has quit IRC17:45
*** lpetrut_ has joined #openstack-nova17:46
*** elmaciej has quit IRC17:48
*** felipemonteiro has quit IRC17:48
*** wolverineav has joined #openstack-nova17:49
*** gjayavelu has joined #openstack-nova17:52
*** yamahata has joined #openstack-nova17:54
*** yamamoto has joined #openstack-nova17:57
*** hemna_ has joined #openstack-nova18:01
*** Tom-Tom has joined #openstack-nova18:01
*** yamamoto has quit IRC18:02
cfriesenjaypipes: seems like we'd need to have the allocation ratio associated with the resource provider itself rather than the compute node18:04
*** hemna_ has quit IRC18:07
cdentcfriesen: yes, that would be the idea. efried has done some preliminary libvirt work, lemme find the link18:07
cdentalso you aware of #openstack-placement18:07
cdentcfriesen: https://review.openstack.org/#/c/560459/18:07
efriedcdent, cfriesen: In case you didn't catch the last nova meeting, bhagyashris agreed to take these patches over and fix up the tests.18:08
openstackgerritJay Pipes proposed openstack/nova master: tests for alloc candidates with nested and traits  https://review.openstack.org/53189918:09
openstackgerritJay Pipes proposed openstack/nova master: placement: resource requests for nested providers  https://review.openstack.org/55452918:09
jaypipescfriesen: see https://review.openstack.org/#/c/544683/18:10
openstackgerritMatt Riedemann proposed openstack/nova master: Document how to disable notifications  https://review.openstack.org/56168418:13
*** arvindn05 has left #openstack-nova18:15
*** arvindn0_ has joined #openstack-nova18:15
*** arvindn0_ has left #openstack-nova18:16
dansmithsean-k-mooney: around?18:16
*** arvindn0_ has joined #openstack-nova18:16
*** arvindn0_ has quit IRC18:18
*** wolverineav has quit IRC18:18
*** arvindn05 has joined #openstack-nova18:18
*** wolverineav has joined #openstack-nova18:18
*** arvindn051 has joined #openstack-nova18:18
mriedemcdent: thanks for https://pypi.org/project/wsgi_intercept/ - i'll see about getting g-r updated18:21
*** arvindn05 has quit IRC18:21
*** arvindn05 has joined #openstack-nova18:21
mriedemalthough i likely can't use that in this change until later since we might backport this patch18:23
cdentyeah, was worth finding anyway18:23
*** liverpooler has quit IRC18:26
*** amoralej is now known as amoralej|off18:28
openstackgerritMerged openstack/nova master: Don't log a warning for InstanceNotFound with deleted VIFs  https://review.openstack.org/55459118:29
*** avolkov has quit IRC18:31
*** eharney has quit IRC18:32
sean-k-mooneydansmith: i was on a call but yes18:33
dansmithsean-k-mooney: hey, so we had a question on friday and I think you're the right person to ask18:33
dansmithsean-k-mooney: we still have non-os_vif handling of vhostuser interfaces in vif.pym18:34
sean-k-mooneysomthing about not implemented error for os-vif18:34
dansmithbut it's not clear to me/us if that is still needed or not18:34
dansmithyeah18:34
sean-k-mooneydansmith: that is used by both vpp and snabswitch18:34
dansmithokay18:34
dansmithwhy?18:34
sean-k-mooneyin both cases vhost-user is not being used with ovs so they dont need to have somting plug it into a vswitch18:35
sean-k-mooneyin the vpp case i belive they have an agent on the plathform that poll for the creation fo the socket and just connects when it shows up18:35
*** Zames has joined #openstack-nova18:36
dansmithso is it always going to be that way?18:36
sean-k-mooneydansmith: we could add a new plugin to os-vif if you want to move it out of tree18:36
*** tesseract has quit IRC18:36
dansmithseems like it would be less confusing18:36
dansmithmaybe a comment about who/what uses that path would be nice18:36
dansmithregardless, can you have a look over https://review.openstack.org/#/c/484997 ?18:37
sean-k-mooneywe didnt to that initally as they are not reference plugings but its basically a noop so i dont really see the harm in a generic_vhost_user pluging in os-vif18:37
*** _pewp_ has quit IRC18:37
sean-k-mooneyoh the queue lenght stuff sure ill take a look now18:38
dansmiththanks18:38
openstackgerritEric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates  https://review.openstack.org/51775718:39
*** harlowja has joined #openstack-nova18:40
*** Zames has quit IRC18:40
*** _pewp_ has joined #openstack-nova18:42
*** AlexeyAbashkin has joined #openstack-nova18:44
*** eharney has joined #openstack-nova18:47
efriedbauzas: still around?18:47
*** tssurya has joined #openstack-nova18:48
*** AlexeyAbashkin has quit IRC18:49
*** AlexeyAbashkin has joined #openstack-nova18:49
openstackgerritsahid proposed openstack/nova master: libvirt: fix wrong driver name for vhostuser interface  https://review.openstack.org/56156218:50
*** mvk has joined #openstack-nova18:52
*** hemna_ has joined #openstack-nova18:53
*** hemna_ has quit IRC18:53
*** hemna_ has joined #openstack-nova18:53
melwittdansmith: yeah, saw your comment and -1ed it earlier this morning to add visibility to the fact that the changes were reverted18:53
*** mgoddard has quit IRC18:53
dansmithmelwitt: ack18:54
*** lajoskatona has quit IRC18:56
*** yamamoto has joined #openstack-nova18:58
*** jmlowe has quit IRC18:58
*** AlexeyAbashkin has quit IRC18:59
mriedemmelwitt: i'm not sure if you want a simple specless blueprint for this or just let it slide as a wishlist bug fix https://review.openstack.org/#/c/555861/ - note we wouldn't backport that either way19:01
*** dpawlik has joined #openstack-nova19:01
*** tbachman has quit IRC19:01
*** yamamoto has quit IRC19:02
melwittcfriesen, mriedem, dansmith: looking at the code, it makes sense what's happening. the service was deleted while the instance still referred to it, then when you list the instance, it tries to generate a UUID for the service (that is deleted) and the service_update method tries to 'get' the service record by id and it gets ServiceNotFound because model_query will automatically filter out deleted things https://github.com/openstack/nova/19:02
melwittblob/master/nova/db/sqlalchemy/api.py#L55419:02
*** tmcm has joined #openstack-nova19:02
melwitthttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L55419:02
tmcmis it possible to run mitaka-based compute nodes with a queens nova-scheduler/placement?19:04
tmcmi'm looking at https://docs.openstack.org/nova/latest/user/placement.html but it's not clear to me from what i read there19:04
melwittI would think if you're deleting services out from under live instances, after you create new services to replace them, wouldn't you have to manually associate the new service with existing instances? else it seems like other bad things could happen19:04
*** openstackgerrit has quit IRC19:05
dansmiththey're only associated by name, right?19:05
melwittthe db api stuff implied the backref is by service id19:05
melwittbut lemme re-look19:06
*** dpawlik has quit IRC19:06
dansmithI don't think we have a service_id on instance,19:06
dansmithI thought I looked19:06
dansmithalthough I was looking at computenode specifically19:06
mriedemi wonder why "from_db_object" is public in their stacktraces....totally unrelated19:06
melwittyeah looks like backref by host and binary19:06
melwittso how did the service_update get the service id ...19:07
dansmithit would be if we read_deleted when we looked it up19:07
dansmithand got the first older deleted one by name19:08
dansmithI haven't looked back into his latest stack trace, fyi19:08
melwittokay. yeah, the stacktrace shows ServiceNotFound being raised from service_update as service_update is trying to update via id and the id is not found because model_query19:08
dansmithright19:09
mriedem"the sequence of events was:  boot instance on compute node, migrate instance, delete compute node and service, upgrade to pike, create new compute node with same name, migrate instance back to that compute node."19:09
*** openstackgerrit has joined #openstack-nova19:10
openstackgerritJay Pipes proposed openstack/nova master: placement: resource requests for nested providers  https://review.openstack.org/55452919:10
melwittI haven't made the connection yet but somehow the service object associated with the instance is the deleted one. which I thought would be expected if you deleted the service out from under the instance. like, what would ever update the instance to point at a new service? I guess you say by name, which would find more than one matching service, and it's happening to find the deleted one first?19:10
dansmithmelwitt: it can't be19:10
dansmithbecause it's only by name19:10
dansmithI didn't see where they ened up starting down this path, I thought it was in the "upgrade to pike" section,19:10
melwittbut two have the same name, the deleted one and the new one19:10
dansmithand that they were implying we were handling deleted services in the migration19:11
dansmithright19:11
mriedemalso waiting to hear if they have this https://review.openstack.org/#/c/545988/19:11
melwittI haven't yet connected where the query is happening that would get the two returned19:11
melwittbecause like you all said earlier, that should be filtering out deleted rows, we would expect19:11
dansmithyeah19:11
mriedemif they have https://review.openstack.org/#/c/545988/ they will query deleted records too19:12
dansmithmriedem: oh I didn't get the connection this morning you were making19:12
*** Tom-Tom has quit IRC19:12
dansmithmriedem: that we're using a read_deleted context to get the instance and thus the service too?19:12
mriedemyes19:12
* dansmith really isn't paying attention19:12
dansmithgotcha that makes sense19:12
melwittmriedem: I think we should probably go with a specless blueprint on that one, so it gets bundled with the other new features19:13
mriedemack19:14
melwittthanks19:14
mriedemtrying to think of a test to recreate cfriesen's issue, could start two compute services, create the instance on one, migrate to the other, delete the old compute service/node, fake the upgrade to pike by deleting the uuid on the 2 services, start a new compute service with the same name as the old one, and then migrate the instance back to the other host19:19
mriedemin his stacktrace, he's not doing a migration, simply listing instances19:19
mriedemwhich unconditionally joins on services https://github.com/openstack/nova/blob/f0400313f30843fba114584f582b93f7cb5e5e48/nova/api/openstack/compute/servers.py#L29519:20
melwittsounds like that should do it19:20
*** moshele has quit IRC19:20
* melwitt wonders if there are any other gotchas to the read_deleted='yes' for lazy-loading instance attributes19:21
mriedemcfriesen: have you reported an upstream bug for this issue?19:21
*** sdeath has quit IRC19:22
*** dpawlik has joined #openstack-nova19:23
*** dpawlik has quit IRC19:23
mriedembauzas: https://bugs.launchpad.net/nova/+bug/176446019:23
openstackLaunchpad bug 1764460 in OpenStack Compute (nova) queens "Cannot hard reboot an instance in error state" [High,Confirmed]19:23
*** dpawlik has joined #openstack-nova19:24
mriedemlooks like a regression in the libvirt driver due to the mdev stuff in queens19:24
mriedemthis is fun https://bugs.launchpad.net/nova/+bug/176438519:25
openstackLaunchpad bug 1764385 in OpenStack Compute (nova) "no intimation to the admin that nova-api is stopped during execution of polling compute" [Undecided,Incomplete]19:25
melwitton the libvirt one, looks like a simple fix at least19:26
*** arvindn05 has quit IRC19:27
melwittI saw this old bug recently, evacuations that failed to schedule end up getting nuked during nova-compute restart https://bugs.launchpad.net/nova/+bug/158350419:27
openstackLaunchpad bug 1583504 in OpenStack Compute (nova) "The instances which didn't be evacuated will be destroyed when the nova-compute service is restarted." [Undecided,Confirmed] - Assigned to Margarita Shakhova (shakhova-margarita)19:27
melwittbecause the logic assumes that 'accepted' migration means it succeeded. I'm not sure what the original reasoning was for including 'accepted' in the logic (along with 'done')19:28
mriedemhmm, is that from before the evac robustification to use migration records?19:28
mriedemoh19:28
mriedemthat recently changed, the logic in the compute i mean,19:29
mriedemit was discussed at the ptg in denver19:29
melwittthis was the proposed fix https://review.openstack.org/#/c/318731/2/nova/compute/manager.py19:29
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API  https://review.openstack.org/48620419:29
openstackgerritJackie Truong proposed openstack/nova master: Add certificate validation docs  https://review.openstack.org/56015819:29
melwittorly19:29
* melwitt looks19:29
mriedemi'm thinking of this i think https://review.openstack.org/#/c/49923719:30
melwittcode looks the same AFAICT https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L64019:30
melwittoh, okay. that should help then19:30
mriedemright, if scheduling fails, set the migration status to 'error'19:31
mriedemso when restarting the compute, the migration is not 'accepted'19:31
mriedemor 'done'19:31
melwittmaybe that bug could be considered closed with that fix, but we'd probably wanna write a test to make sure19:31
melwittyep, gotcha19:31
mriedemi think you'd just have to update this test https://review.openstack.org/#/c/499237/4/nova/tests/functional/regressions/test_bug_1713783.py19:32
mriedemto restart the compute19:32
*** cdent has quit IRC19:32
*** tbachman has joined #openstack-nova19:32
melwittthat would be sweet if that's all it'd take19:33
cfriesenmriedem: I haven't reported an upstream bug yet, was trying to figure out if it was an upstream issue or not.  My coworker reports that with the two fixes from stable/pike it doesn't fix the problem immediately but after some time the record has been updated in the DB.19:33
mriedemafter some time...like running the online data migrations?19:34
mriedemor archiving deleted rows?19:34
cfriesenmelwitt: will the "read_deleted=yes" context change from https://git.openstack.org/cgit/openstack/nova/commit/?id=1407079d4008c6304799dd83f5bf4ba505d8e438 override the default model_query behaviour?19:34
mriedemyes19:34
mriedemcontext.read_deleted defaults to 'no'19:34
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Report the allocated size of preallocated file based disks  https://review.openstack.org/56170419:35
*** imacdonn has quit IRC19:35
*** imacdonn has joined #openstack-nova19:35
*** tbachman_ has joined #openstack-nova19:36
cfriesenmriedem: my coworker says he didn't do any online data migrations or archiving rows or anything "interesting".  He suspects something querying the instances.19:37
*** tbachman has quit IRC19:37
*** tbachman_ is now known as tbachman19:37
cfriesenrunning the online data migration doesn't normally affect deleted services, but applying "with utils.temporary_mutation(self._context, read_deleted='yes'):" to the online migration apparently fixed it all right up.19:38
melwittwell, if the ordering of the returned dupe services (deleted one and the new one) is random, then eventually it would work fine if the non-deleted one was first, right?19:38
mriedemcfriesen: ok so now you're saying that it's fixed?19:38
*** moshele has joined #openstack-nova19:38
mriedemi.e. https://review.openstack.org/#/c/545988/19:39
mriedemsince everything is going to happen to that service with that mutated context, i expect it will update the deleted service with a uuid19:39
melwittyeah like, eventually maybe the non-deleted one is returned "first" in the list and then it goes through with the update and then there won't be a problem from then on19:39
mriedemi just need to know if i should spend time trying to write a recreate test19:40
cfriesenmriedem: that commit did not immediately fix things (he still hit some ServiceNotFound errors after applying it), but eventually the service did get a uuid19:40
melwittI think there's still a bug where for lazy-load of services it needs to not read deleted ones19:40
openstackgerritJackie Truong proposed openstack/nova master: Implement certificate_utils  https://review.openstack.org/47994919:41
openstackgerritJackie Truong proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths  https://review.openstack.org/56126219:41
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API  https://review.openstack.org/48620419:41
openstackgerritJackie Truong proposed openstack/nova master: Add certificate validation docs  https://review.openstack.org/56015819:41
melwittI hope services don't allow dupe by name if they are both non-deleted19:41
cfriesenmelwitt: arguably for the instance->service mapping the bug is that it maps by name19:41
melwittbecause then there would be a problem anyways19:41
mriedemhttps://review.openstack.org/#/c/545988/19:42
melwittcfriesen: yeah, true.19:42
mriedemoops19:42
mriedem        schema.UniqueConstraint("host", "topic", "deleted",19:42
mriedem                                name="uniq_services0host0topic0deleted"),19:42
mriedem        schema.UniqueConstraint("host", "binary", "deleted",19:42
mriedem                                name="uniq_services0host0binary0deleted"),19:42
tmcmsorry to repeat myself, but is it possible to run mitaka-based compute nodes with a queens nova-scheduler/placement?  i'm looking at https://docs.openstack.org/nova/latest/user/placement.html but it's not clear to me from what i read there19:42
mriedemtmcm: no19:42
tmcmok, thanks19:42
mriedemit might work, but not by intention19:42
mriedemwe support n-1 computes19:42
mriedemso controller can be queens and then computes can be pike+19:42
tmcmunderstood, thanks19:43
*** Tom-Tom has joined #openstack-nova19:43
mriedemat certain points we randomly delete compat code that's older than n-119:43
*** moshele has quit IRC19:43
*** awaugama has quit IRC19:43
mriedemtmcm: this should be a bit more clear https://docs.openstack.org/nova/latest/user/upgrade.html#rolling-upgrade-process19:44
cfriesenmriedem: for a recreate test could we add a new DB entry with a deleted service that has the same name as the existing service?19:45
*** cdent has joined #openstack-nova19:45
tmcmmriedem: got it.  i'd actually worked through that document already and my queens controller was happy from a db standpoint, i was just stuck at:19:46
tmcm+-------------------------------------------------------------------+19:46
tmcm| Check: Resource Providers                                         |19:46
tmcm| Result: Warning                                                   |19:46
tmcm| Details: There are no compute resource providers in the Placement |19:46
tmcm|   service but there are 80 compute nodes in the deployment.       |19:46
tmcm|   This means no compute nodes are reporting into the              |19:46
tmcm|   Placement service and need to be upgraded and/or fixed.         |19:46
tmcm|   See                                                             |19:46
tmcm|   https://docs.openstack.org/nova/latest/user/placement.html      |19:46
tmcm|   for more details.                                               |19:46
tmcm+-------------------------------------------------------------------+19:46
tmcmon the compute side19:46
openstackgerritMerged openstack/nova master: List instances performace optimization  https://review.openstack.org/50785419:46
tmcmwell, from the compute standpoint, i mean19:46
tmcmso if there was any way to force the mitaka compute nodes to use the placement service, i might be OK19:47
artomtmcm, there isn't, the code didn't exist in mitaka :)19:47
*** Tom-Tom has quit IRC19:47
tmcmgot it19:47
artom(Err, right?)19:47
tmcmthanks to both of you19:47
tmcmi didn't see it in there19:47
artomThis self-doubt thing is cripling19:48
mriedemartom: yes, new in newton19:49
mriedemoptional in newton, required starting in ocata19:49
cfriesenmriedem: apparently "nova show" on the instance will result in adding the uuid onto the service, but "nova list" hits the ServiceNotFound error19:49
artommriedem, thank you :)19:49
melwittyou'd have to upgrade your compute nodes to at least newton to make them report in to placement. might even be ocata, not sure19:49
mriedemcfriesen: those should both go down the same code path as far as i know, but maybe not19:49
melwittI think it would be random depending on the ordering of the returned dupe services19:50
melwittnevermind, it looks like it should try to generate a UUID for both services that match the instance via host, so it should fail reliably19:54
sean-k-mooneydansmith: just finished looking at the patch. the broad strokes look fine. i left some nits inline. main concern is the name attribute of the driver field. i think we should just not set it for safty across livemirate in the future. anyway i left comments in the patch but over all it looks ok19:54
*** wolverineav has quit IRC19:54
sean-k-mooneydansmith: i might try an apply it locally tomorow and see if i have any issues. anyway im going to head for the evening.19:56
dansmithsean-k-mooney: okay just to be sure, you know we're already setting it to vhost in almost all cases now right?19:57
dansmithsean-k-mooney: it's done in _get_virtio_mq_settings()19:57
sean-k-mooneydansmith: am i dont think we do that for vhost-user ports however19:57
dansmithsean-k-mooney: we do19:57
dansmithsean-k-mooney: even though it is wrong19:57
dansmiththat's the point :)19:57
sean-k-mooneywhen we request vhost multiqueue only right19:58
dansmithno19:58
dansmithif we're in kvm, and MODEL_VIRTIO, we call that method and it sets it to vhost always I think19:58
*** yamamoto has joined #openstack-nova19:58
TheJuliaefried: your python-ironicclient patch, Would you be okay if I updated the commit message?19:58
dansmithsean-k-mooney: oh, actually, I guess you're right19:59
dansmithsean-k-mooney: sahid said the opposite and I looked but didn't see19:59
sean-k-mooneydansmith: oh we did not used too19:59
dansmithsean-k-mooney: so yeah, this does change it to be more often, which is what I was trying to avoid when we talked last week19:59
sean-k-mooneydansmith: ya this is a normal vhost-user xml http://paste.openstack.org/show/719324/19:59
dansmithbut I missed that we only do it for multiqueue19:59
efriedTheJulia: Sure, you can do whatever you like with it.  I would be happy to keep working on it too if you prefer.  (I saw you made a comment, but I haven't gotten to reading it yet.)19:59
dansmithsean-k-mooney: so good call on that, thanks19:59
openstackgerritMatt Riedemann proposed openstack/nova master: Add wrinkle to FailedEvacuateStateTests  https://review.openstack.org/56170720:00
sean-k-mooneydansmith: well i dont think it would break anything today since its ignored but if they ever stop ignoring it i dont know if that would break us20:00
*** cdent has quit IRC20:00
dansmithsean-k-mooney: yeah20:00
*** edmondsw_ has joined #openstack-nova20:00
dansmithsean-k-mooney: I figured since I don't know the details, it'd be better to just avoid changing it20:01
efriedTheJulia: Oh, it was rloo's note.  Anyway, just let me know whatever you want me to do there.20:01
dansmithsean-k-mooney: I was asking him to just set it explicitly where he knows it should be vhost or vhostuser20:01
*** r-daneel has quit IRC20:01
dansmithsean-k-mooney: did you see the cleanup patch below?20:01
efriedTheJulia: Caveat: Never used storyboard before...20:01
dansmiththat was also based on ignoring, but it's vhostuser and you said vhost-user, so is it wrong?20:01
TheJuliaefried: I can create it, its not a big deal20:01
TheJuliaefried: but your welcome to if you want20:02
* TheJulia bets we have at least one other story that this falls under20:02
TheJuliaStory clean-up is taking... many braincells.20:02
efriedTheJulia: Go for it, co-author away.20:02
*** lpetrut_ has quit IRC20:02
sean-k-mooneydansmith: well neighter vhostuser or vhost-user is documented explictly as an allowed value but they used vhost-user when refing to it.20:02
TheJuliaefried: don't need that :) But thanks.20:03
dansmithsean-k-mooney: okay you wanna comment on the patch below with that info then?20:03
sean-k-mooneydansmith: ill try and take a look at the libvirt source code tomorrow and see whent there parse has defiend20:03
*** edmondsw has quit IRC20:03
dansmithsean-k-mooney: okay20:03
*** yamamoto has quit IRC20:04
*** wolverineav has joined #openstack-nova20:05
*** tmcm has quit IRC20:08
openstackgerritArtom Lifshitz proposed openstack/nova master: Add (Same|Different)HostFilter to defaults  https://review.openstack.org/56165120:11
*** eharney has quit IRC20:11
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API  https://review.openstack.org/48620420:13
openstackgerritJackie Truong proposed openstack/nova master: Add certificate validation docs  https://review.openstack.org/56015820:13
openstackgerritLance Bragstad proposed openstack/nova master: Set scope_types for admin password policies  https://review.openstack.org/55361320:18
openstackgerritLance Bragstad proposed openstack/nova master: Add scope_types to server policies  https://review.openstack.org/52577220:18
*** r-daneel has joined #openstack-nova20:19
lbragstadjohnthetubaguy_: jaypipes ^ look another shot at working a rough test structure into those20:19
lbragstadthey will fail, but i'm curious about the approach you'd like me to take with the testing20:20
lbragstador if what's proposed even makes sense20:20
jaypipeslbragstad: cool, thanks20:22
jaypipeslbragstad: will re-review shortly.20:22
lbragstadawesome - ty20:22
*** Tom-Tom has joined #openstack-nova20:22
*** Tom-Tom has quit IRC20:27
*** dklyle has joined #openstack-nova20:28
*** Tom-Tom has joined #openstack-nova20:35
*** hemna_ has quit IRC20:36
*** vladikr has quit IRC20:39
*** Tom-Tom has quit IRC20:40
*** AlexeyAbashkin has joined #openstack-nova20:41
*** wolverineav has quit IRC20:42
*** wolverineav has joined #openstack-nova20:42
*** AlexeyAbashkin has quit IRC20:45
*** vladikr has joined #openstack-nova20:51
*** mtreinish has quit IRC20:51
*** tbachman has quit IRC20:54
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: List instances performace optimization  https://review.openstack.org/56171520:54
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API  https://review.openstack.org/48620420:54
openstackgerritJackie Truong proposed openstack/nova master: Add certificate validation docs  https://review.openstack.org/56015820:54
*** harlowja has quit IRC20:55
*** edmondsw_ has quit IRC20:56
openstackgerritEric Fried proposed openstack/nova-specs master: Support forced separation of providers in granular  https://review.openstack.org/56171720:56
*** mtreinish has joined #openstack-nova20:57
*** esberglu has quit IRC20:58
*** edmondsw has joined #openstack-nova20:59
*** burt has quit IRC20:59
*** fragatina has quit IRC20:59
*** yamamoto has joined #openstack-nova21:00
*** sambetts is now known as sambetts|afk21:03
openstackgerritMatt Riedemann proposed openstack/nova master: Remove vestigial system_metadata param from info_from_instance()  https://review.openstack.org/56172421:03
*** edmondsw has quit IRC21:03
*** pchavva has quit IRC21:03
*** yamamoto has quit IRC21:06
*** Tom-Tom has joined #openstack-nova21:10
*** arvindn05 has joined #openstack-nova21:11
*** dpawlik has quit IRC21:12
*** arvindn05 has quit IRC21:14
*** Tom-Tom has quit IRC21:15
*** wolverineav has quit IRC21:16
*** wolverineav has joined #openstack-nova21:16
*** tbachman has joined #openstack-nova21:17
*** wolverineav has quit IRC21:17
*** wolverin_ has joined #openstack-nova21:17
*** fragatina has joined #openstack-nova21:22
*** dklyle has quit IRC21:22
*** felipemonteiro_ has quit IRC21:23
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API  https://review.openstack.org/48620421:27
openstackgerritJackie Truong proposed openstack/nova master: Add certificate validation docs  https://review.openstack.org/56015821:27
*** mrjk has quit IRC21:28
*** mrjk has joined #openstack-nova21:29
*** tbachman has quit IRC21:31
*** tbachman has joined #openstack-nova21:32
jackie-truongmriedem dansmith jaypipes melwitt johnthetubaguy_: Thanks for reviewing the certificate validation patches. 479949 and 561262 should just need one last look. The API patch is going through Zuul now.21:32
jackie-truonghttps://review.openstack.org/#/c/479949/21:33
jackie-truonghttps://review.openstack.org/#/c/561262/21:33
*** jmlowe has joined #openstack-nova21:36
melwittthanks jackie-truong. I've rechecked the tempest tests so we can look at that too for the latest revision of the series https://review.openstack.org/#/c/51521021:39
*** esberglu has joined #openstack-nova21:42
jackie-truongmelwitt: Awesome, thanks21:42
*** takashin has joined #openstack-nova21:44
*** Tom-Tom has joined #openstack-nova21:46
*** salv-orlando has quit IRC21:50
*** dklyle has joined #openstack-nova21:50
*** Tom-Tom has quit IRC21:50
*** rcernin has joined #openstack-nova21:51
*** dpawlik has joined #openstack-nova21:54
*** dpawlik has quit IRC21:58
*** Tom-Tom has joined #openstack-nova22:02
*** yamamoto has joined #openstack-nova22:02
*** BlackDex has quit IRC22:04
*** BlackDex has joined #openstack-nova22:05
*** david-lyle has joined #openstack-nova22:06
*** Tom-Tom has quit IRC22:06
*** dklyle has quit IRC22:08
*** yamamoto has quit IRC22:08
*** david-lyle has quit IRC22:11
*** Guest98903 has quit IRC22:11
mriedemartom: gotta say, i'm not a fan of this https://review.openstack.org/#/c/561651/22:15
mriedemif there is a problem with tempest, let's fix tempest22:15
cfriesenmriedem: I reproduced the Service UUID issue with vanilla stable/pike devstack.  Writing up a bug now.22:15
mriedemartom: as noted inline, those tempest tests for these filters probably shouldn't even live in tempest22:15
*** slaweq has quit IRC22:16
*** slaweq has joined #openstack-nova22:16
mriedemjackie-truong: besides dumping on artom's patch i'm done for the day, sorry22:18
mriedemcfriesen: ok22:19
jackie-truongmriedem: np, thanks for all of the comments!22:19
*** mlavalle has quit IRC22:20
*** slaweq has quit IRC22:21
melwittjackie-truong: looks like there's a problem :( http://logs.openstack.org/10/515210/31/check/barbican-simple-crypto-devstack-tempest/0ff6bcc/logs/testr_results.html.gz22:21
melwittAdditional properties are not allowed (u'trusted_image_certificates' was unexpected)", u'code': 40022:21
melwittlooks like a schema validation fail?22:21
jackie-truongmelwitt: Saw that. Looking into it22:24
*** dougshelley66 has quit IRC22:27
*** dougshelley66 has joined #openstack-nova22:28
*** Tom-Tom has joined #openstack-nova22:36
*** dklyle has joined #openstack-nova22:40
*** Tom-Tom has quit IRC22:40
*** hemna_ has joined #openstack-nova22:44
*** Nisha_Agarwal has joined #openstack-nova22:45
cfriesenmelwitt: mriedem: here's the Service-without-UUID exception.ServiceNotFound issue:  https://bugs.launchpad.net/nova/+bug/176455622:47
openstackLaunchpad bug 1764556 in OpenStack Compute (nova) ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Undecided,New]22:47
melwittthanks22:48
cfriesenreproducing is straightforward, just needs a fake DB entry in the services table22:48
*** Nisha_Agarwal has quit IRC22:49
*** salv-orlando has joined #openstack-nova22:50
*** Tom-Tom has joined #openstack-nova22:51
*** hongbin_ has quit IRC22:55
*** salv-orlando has quit IRC22:56
*** Tom-Tom has quit IRC22:56
*** claudiub|2 has quit IRC22:57
*** dklyle has quit IRC22:58
*** andreas_s has joined #openstack-nova22:59
cfriesenwhy does "openstack server --live" require a hostname?23:01
cfriesenmake that "openstack server migrate --live"23:02
*** yamamoto has joined #openstack-nova23:04
*** andreas_s has quit IRC23:04
artommriedem, yeah, I get it23:09
*** yamamoto has quit IRC23:09
artomWe were having downstream discussions about it, and the argument that sort of got me was "if every CI has to change it, shouldn't it be in defaults?"23:10
artomDevstack enables it, downstream OSP CI needs to enable it, so...23:11
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_serversV21.py (1)  https://review.openstack.org/56082123:11
artomBut yeah, "CI needs it" isn't a massively compelling argument23:11
*** jackie-truong has quit IRC23:12
artomSo I threw it up, just to see what discussion would come out of it, and to be able to say "upstream said" as opposed to "I said no" :)23:12
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_serversV21.py (2)  https://review.openstack.org/56082923:12
*** yassine has joined #openstack-nova23:13
*** dklyle has joined #openstack-nova23:13
*** yassine is now known as Guest263123:13
melwittartom: I think it makes sense that CIs would enable most, if not all of the filters that exist, to cover the features and make sure they work with their products23:15
*** Tom-Tom has joined #openstack-nova23:16
melwittfor deciding whether to include certain filters in default_filters, I think that would be mostly about whether the filters are used by "most users" or are useful in a typical deployment23:16
artommelwitt, yeah, apparently it's really complicated for them to enabled it in their thousand+ jobs?23:17
artommelwitt, but I agree - CI and users have different needs23:17
* artom is in the weird position of having to "defend" a patch he proposed himself, despite only half-believing in it23:18
*** moshele has joined #openstack-nova23:18
melwittI didn't think it's complicated in that I thought you just set enabled_filters to the filters you want enabled in nova.conf23:19
artommelwitt, yeah, but apparently they need to do that for *every* job? As in, there's no common deployment that covers all jobs?23:19
*** Tom-Tom has quit IRC23:19
melwittthat said, I don't really have an opinion about whether SameHost and DifferentHost belong in default filters because TBH I don't know if those are really commonly used by end users or not23:20
artomhttps://review.gerrithub.io/#/c/407794/ is the infrared change23:20
artomWhich apparently got -2 by Arie? I have no idea what's going on23:20
artommelwitt, heh, don't we have those sosreports we can use for insights? At least for OSP users?23:21
melwittyeah, we could I would think23:21
artomMan, the effort:complexity ratio of this thing is through the roof23:21
artomThere's, like, 5 of us, just to enable a filter23:22
melwittwell, enabling a filter is supposed to be all pluggable, like you can do it in your nova.conf23:22
melwittthis is starting a discussion about "what belongs in defaults?" "should everything be in defaults?" "what's the downside of putting everything in defaults?" and I don't really know the answers to those questions off the top of my head23:23
artomRight, but the original problem is still "a filter that we need isn't enabled"23:24
melwittby default, no. there are a lot of filters we could say that about. so to me, it's more like, should we just add all filters to defaults and is there any reason to not do that? I'd be asking scheduler subteam folk about it23:26
*** jaosorior has quit IRC23:26
*** jaosorior has joined #openstack-nova23:27
*** sdeath has joined #openstack-nova23:27
*** sdague has quit IRC23:28
*** r-daneel has quit IRC23:29
*** jaosorior has quit IRC23:34
*** jaosorior has joined #openstack-nova23:34
*** rajinir has quit IRC23:34
artommelwitt, yeah, it might be better to rephrase this as 2 questions: 1. do we have data that justifies adding same/different hostfilter to the defaults?23:36
artom2. Should we just enable all filters by default?23:36
artomI can poke around our sosreports for 1 tomorrow, for 2... I guess tomorrow as well23:36
cfriesenmelwitt: https://review.openstack.org/#/c/560690/ has been updated to address your final comment23:37
melwittartom: yeah. the point of the default filters is to give someone a config for a typical cloud. if same/different are typically used, then they should be in defaults I think. CI are a different beast IMHO because they're aiming to run and verify as many features and capabilities as possible23:37
melwittso you would expect them to enable everything they possibly could. that said, IIUC there's some mismatch between what tempest defaults to and what nova defaults to and that is what's actually causing this problem23:38
melwittcfriesen: thanks, will take another look23:39
cfriesenmelwitt: the default set of enabled filters is actually pretty small23:40
*** dklyle has quit IRC23:40
melwittcfriesen: yes. I have learned that recently23:40
melwittor re-learned it. I've seen default filter list in the past and eventually forgot it23:41
*** jroll has quit IRC23:42
*** gyee has quit IRC23:43
*** salv-orlando has joined #openstack-nova23:51
*** Tom-Tom has joined #openstack-nova23:52
openstackgerritMerged openstack/nova master: Remove RequestContext.instance_lock_checked  https://review.openstack.org/55437823:55
*** salv-orlando has quit IRC23:56
*** sdeath has quit IRC23:56
*** Tom-Tom has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!