| openstackgerrit | Dan Smith proposed openstack/nova master: Don't persist could-be-stale InstanceGroup fields in RequestSpec https://review.openstack.org/527799 | 00:00 |
|---|---|---|
| *** kumarmn has joined #openstack-nova | 00:03 | |
| *** klindgren_ has quit IRC | 00:05 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 00:15 |
| *** felipemonteiro has joined #openstack-nova | 00:18 | |
| *** felipemonteiro_ has joined #openstack-nova | 00:19 | |
| *** hiro-kobayashi has joined #openstack-nova | 00:21 | |
| *** itlinux has quit IRC | 00:22 | |
| *** felipemonteiro has quit IRC | 00:23 | |
| *** felipemonteiro_ has quit IRC | 00:26 | |
| *** fragatina has quit IRC | 00:28 | |
| *** kumarmn has quit IRC | 00:28 | |
| *** fragatina has joined #openstack-nova | 00:28 | |
| openstackgerrit | Merged openstack/nova master: Update Instance action's updated_at when action event updated. https://review.openstack.org/507473 | 00:29 |
| *** fragatin_ has joined #openstack-nova | 00:33 | |
| *** armax has joined #openstack-nova | 00:33 | |
| *** fragatina has quit IRC | 00:33 | |
| *** fragatin_ has quit IRC | 00:34 | |
| *** Swami has quit IRC | 00:35 | |
| *** prateek_ has quit IRC | 00:37 | |
| *** prateek_ has joined #openstack-nova | 00:38 | |
| *** gouthamr has joined #openstack-nova | 00:42 | |
| *** harlowja has quit IRC | 00:45 | |
| *** sree has joined #openstack-nova | 00:47 | |
| *** fragatina has joined #openstack-nova | 00:49 | |
| *** chyka has quit IRC | 00:51 | |
| *** sree has quit IRC | 00:52 | |
| *** AlexeyAbashkin has joined #openstack-nova | 00:53 | |
| *** fragatina has quit IRC | 00:54 | |
| *** AlexeyAbashkin has quit IRC | 00:57 | |
| *** kumarmn has joined #openstack-nova | 00:58 | |
| openstackgerrit | Merged openstack/nova master: Add instance action db and obj pagination support. https://review.openstack.org/526422 | 00:59 |
| *** kumarmn has quit IRC | 01:01 | |
| *** kumarmn has joined #openstack-nova | 01:01 | |
| *** mriedem has quit IRC | 01:06 | |
| *** phuongnh has joined #openstack-nova | 01:09 | |
| *** mriedem has joined #openstack-nova | 01:10 | |
| *** yangyapeng has joined #openstack-nova | 01:12 | |
| *** psachin has joined #openstack-nova | 01:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass mountpoint to volume attachment_update https://review.openstack.org/527468 | 01:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update and complete volume attachments during resize https://review.openstack.org/527228 | 01:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass bdms to versioned notifications during finish_revert_resize https://review.openstack.org/527446 | 01:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass mountpoint to volume attachment_create with connector https://review.openstack.org/527479 | 01:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unnecessary connector stash in attachment_update https://review.openstack.org/527484 | 01:16 |
| openstackgerrit | Merged openstack/nova master: Raise MarkerNotFound if BuildRequestList.get_by_filters doesn't find marker https://review.openstack.org/527564 | 01:17 |
| *** Apoorva has quit IRC | 01:18 | |
| *** Sukhdev has quit IRC | 01:19 | |
| *** kumarmn has quit IRC | 01:20 | |
| *** kumarmn has joined #openstack-nova | 01:21 | |
| *** kumarmn has quit IRC | 01:22 | |
| *** kumarmn has joined #openstack-nova | 01:22 | |
| *** liverpooler has joined #openstack-nova | 01:23 | |
| *** pramodrj07 has quit IRC | 01:28 | |
| *** kumarmn has quit IRC | 01:36 | |
| *** kumarmn has joined #openstack-nova | 01:36 | |
| *** kumarmn has quit IRC | 01:36 | |
| *** kumarmn has joined #openstack-nova | 01:37 | |
| *** esberglu has joined #openstack-nova | 01:37 | |
| *** namnh has joined #openstack-nova | 01:37 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 01:41 |
| *** esberglu has quit IRC | 01:41 | |
| *** andreas_s has joined #openstack-nova | 01:45 | |
| yikun | ^ rebase 2.57 --> 2.58 | 01:47 |
| *** andreas_s has quit IRC | 01:49 | |
| *** amodi has quit IRC | 01:57 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix missing marker functions https://review.openstack.org/514579 | 01:59 |
| *** kukacz has quit IRC | 02:00 | |
| *** litao__ has joined #openstack-nova | 02:01 | |
| *** kukacz has joined #openstack-nova | 02:01 | |
| mriedem | yikun: on it | 02:02 |
| *** Apoorva has joined #openstack-nova | 02:03 | |
| yikun | mriedem, :), thanks | 02:03 |
| mriedem | yikun: you dropped something from the rest api history doc | 02:05 |
| *** kumarmn has quit IRC | 02:07 | |
| yikun | mr | 02:07 |
| yikun | mriedem, oops, my bad, I will address soon | 02:07 |
| *** Apoorva has quit IRC | 02:09 | |
| mriedem | yikun: i can get it from gerrit | 02:09 |
| *** itlinux has joined #openstack-nova | 02:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 02:10 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 02:10 |
| *** Tom-Tom has joined #openstack-nova | 02:13 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 02:14 |
| *** kumarmn has joined #openstack-nova | 02:15 | |
| yikun | mriedem, another typo fix, so, I update again...now I think it's a final one, ╮(╯▽╰)╭ | 02:19 |
| Kevin_Zheng | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L391 are we ever going to set this to False? | 02:20 |
| *** kumarmn has quit IRC | 02:21 | |
| *** threestrands_ has joined #openstack-nova | 02:22 | |
| *** threestrands_ has quit IRC | 02:22 | |
| *** threestrands_ has joined #openstack-nova | 02:22 | |
| *** kumarmn has joined #openstack-nova | 02:22 | |
| *** threestrands has quit IRC | 02:22 | |
| *** threestrands_ has quit IRC | 02:22 | |
| *** threestrands_ has joined #openstack-nova | 02:23 | |
| *** threestrands_ has quit IRC | 02:23 | |
| *** threestrands_ has joined #openstack-nova | 02:23 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Retry _trait_sync on deadlock https://review.openstack.org/527836 | 02:24 |
| *** kumarmn has quit IRC | 02:26 | |
| *** sree has joined #openstack-nova | 02:27 | |
| mriedem | Kevin_Zheng: we can, but it has to be on a microversion | 02:28 |
| Kevin_Zheng | Yeah, thats what I thought | 02:28 |
| gmann | i feel if we do then we can do all together for query things of all APIs | 02:29 |
| *** hoangcx has quit IRC | 02:29 | |
| *** trungnv has quit IRC | 02:29 | |
| *** moshele has joined #openstack-nova | 02:29 | |
| *** trungnv has joined #openstack-nova | 02:29 | |
| *** salv-orl_ has joined #openstack-nova | 02:29 | |
| *** hoangcx has joined #openstack-nova | 02:29 | |
| mriedem | yikun: got it, thanks | 02:30 |
| Kevin_Zheng | Yeah, so maybe we should add them to all APIs first :) | 02:30 |
| Kevin_Zheng | still alot missing? | 02:30 |
| mriedem | Kevin_Zheng: there is a blacklist of filters that we don't allow | 02:30 |
| Kevin_Zheng | yeah, I know | 02:31 |
| Kevin_Zheng | Just curious :) | 02:31 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L295 | 02:31 |
| mriedem | because those will 500 | 02:31 |
| *** threestrands_ has quit IRC | 02:32 | |
| *** Tom-Tom has quit IRC | 02:32 | |
| *** liverpooler has quit IRC | 02:32 | |
| *** psachin has quit IRC | 02:32 | |
| *** takashin has quit IRC | 02:32 | |
| *** amotoki has quit IRC | 02:32 | |
| *** openstackstatus has quit IRC | 02:32 | |
| *** salv-orlando has quit IRC | 02:32 | |
| *** bkopilov has quit IRC | 02:32 | |
| *** s1061123 has quit IRC | 02:32 | |
| *** purplerbot has quit IRC | 02:32 | |
| *** jose-phillips has quit IRC | 02:32 | |
| *** pooja_jadhav has quit IRC | 02:32 | |
| *** ChanServ has quit IRC | 02:32 | |
| *** rmk has quit IRC | 02:32 | |
| *** sree has quit IRC | 02:32 | |
| mriedem | and this https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L187 | 02:33 |
| mriedem | if you try filtering on private properties in the data model | 02:33 |
| *** ChanServ has joined #openstack-nova | 02:34 | |
| *** barjavel.freenode.net sets mode: +o ChanServ | 02:34 | |
| *** vladikr has quit IRC | 02:34 | |
| *** vladikr has joined #openstack-nova | 02:35 | |
| *** threestrands_ has joined #openstack-nova | 02:36 | |
| *** Tom-Tom has joined #openstack-nova | 02:36 | |
| *** liverpooler has joined #openstack-nova | 02:36 | |
| *** psachin has joined #openstack-nova | 02:36 | |
| *** takashin has joined #openstack-nova | 02:36 | |
| *** amotoki has joined #openstack-nova | 02:36 | |
| *** openstackstatus has joined #openstack-nova | 02:36 | |
| *** bkopilov has joined #openstack-nova | 02:36 | |
| *** s1061123 has joined #openstack-nova | 02:36 | |
| *** purplerbot has joined #openstack-nova | 02:36 | |
| *** jose-phillips has joined #openstack-nova | 02:36 | |
| *** pooja_jadhav has joined #openstack-nova | 02:36 | |
| *** barjavel.freenode.net sets mode: +v openstackstatus | 02:36 | |
| *** rmk has joined #openstack-nova | 02:36 | |
| *** _ix has joined #openstack-nova | 02:37 | |
| mriedem | yikun: looks like http://logs.openstack.org/26/326326/48/check/openstack-tox-functional/496db26/testr_results.html.gz is failing | 02:38 |
| mriedem | i'm guessing it's using an older server create sample which has personality files in it? | 02:39 |
| Kevin_Zheng | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L186 | 02:39 |
| Kevin_Zheng | ^ JOINED_TABLE_QUERY_PARAMS_SERVERS also return 400 | 02:39 |
| Kevin_Zheng | not 500 | 02:39 |
| gmann | mriedem: is this looks fine now (server whitelist doc) - https://review.openstack.org/#/c/527042/3 | 02:39 |
| mriedem | Kevin_Zheng: right, i mean, | 02:39 |
| mriedem | before that blacklist, those would be a 500 | 02:39 |
| Kevin_Zheng | Ah ok | 02:40 |
| *** zhurong has joined #openstack-nova | 02:41 | |
| *** gbarros has joined #openstack-nova | 02:43 | |
| *** liverpooler has quit IRC | 02:48 | |
| *** Daisy_ has joined #openstack-nova | 02:49 | |
| *** lei-zh has joined #openstack-nova | 02:50 | |
| *** Daisy_ has quit IRC | 02:50 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete https://review.openstack.org/525231 | 02:55 |
| *** TuanLA has joined #openstack-nova | 02:55 | |
| *** sree has joined #openstack-nova | 02:58 | |
| *** sree has quit IRC | 03:03 | |
| *** lei-zh has quit IRC | 03:05 | |
| *** lei-zh has joined #openstack-nova | 03:06 | |
| *** Tom-Tom has quit IRC | 03:14 | |
| yikun | mriedem, a bit confusing, we set version=2.58 (https://review.openstack.org/#/c/326326/48/nova/tests/functional/api_sample_tests/test_instance_actions.py@137), why call 2.1 API? | 03:15 |
| mriedem | yikun: it's calling with 2.58 | 03:16 |
| mriedem | but using a 2.1 sample i think | 03:16 |
| Kevin_Zheng | yeah | 03:16 |
| mriedem | and the 2.1 sample has 'personality' files in it, | 03:16 |
| mriedem | which aren't supported past 2.57 | 03:16 |
| Kevin_Zheng | _post_server() reads old samples by default | 03:17 |
| mriedem | i think it's sending this https://github.com/openstack/nova/blob/master/doc/api_samples/servers/server-create-req.json#L13 | 03:17 |
| mriedem | yikun: you need it to send this request https://github.com/openstack/nova/blob/master/doc/api_samples/servers/v2.57/server-create-req.json | 03:17 |
| mriedem | is there a parameter in _post_server() to override the sample to use? | 03:17 |
| *** gouthamr has quit IRC | 03:17 | |
| mriedem | i think it might not work if you override it though if you don't have a server-create-req.json sample in the 2.57 directory | 03:18 |
| mriedem | you'd have to try it | 03:18 |
| mriedem | otherwise, there is an easier way | 03:19 |
| mriedem | don't use a sample to create the server | 03:19 |
| mriedem | just use self.api.post_server(...) | 03:19 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/tests/functional/api/client.py#L271 | 03:19 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add server filters whitelist in server api-ref https://review.openstack.org/527042 | 03:19 |
| Kevin_Zheng | just set use_common_server_api_samples to false | 03:19 |
| *** bkopilov has quit IRC | 03:20 | |
| mriedem | you can build the request using https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L140 | 03:20 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add server filters whitelist in server api-ref https://review.openstack.org/527042 | 03:20 |
| *** amodi has joined #openstack-nova | 03:20 | |
| mriedem | i think use_common_server_api_samples=False might make it look in the 2.57 directory for the sample | 03:20 |
| mriedem | not sure | 03:20 |
| *** armax has quit IRC | 03:21 | |
| Kevin_Zheng | yeah, have to add a new sample file | 03:21 |
| *** markvoelker_ has quit IRC | 03:24 | |
| *** penick has quit IRC | 03:25 | |
| *** esberglu has joined #openstack-nova | 03:26 | |
| gmann | mriedem: yikun : if use_common_server_api_samples=False, it will use 'cls.sample_dir + /microversion' to find sample files. which is all set in https://review.openstack.org/#/c/326326/48/nova/tests/functional/api_sample_tests/test_instance_actions.py@137 | 03:27 |
| gmann | but you need to put server req and res sample in that dir | 03:27 |
| openstackgerrit | Dai Dang Van proposed openstack/nova master: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 03:27 |
| yikun | yes, use_common_server_api_samples=False look in the dir 2.58. :), and not found if we don't add it | 03:27 |
| gmann | current logic does not fallback to previous version directory, it has to be present in all directory you want to tests | 03:27 |
| mriedem | yeah that's why i'm saying, | 03:27 |
| mriedem | don't use a sample, | 03:27 |
| mriedem | just create the server directly | 03:28 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/tests/functional/api/client.py#L271 | 03:28 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L140 | 03:28 |
| mriedem | the test only cares about the actions, not how the server is created | 03:28 |
| gmann | yea, +1 | 03:28 |
| yikun | yea, got it | 03:28 |
| mriedem | can i get a hell yeah?! | 03:28 |
| * mriedem is getting loopy after a long day | 03:28 | |
| Kevin_Zheng | everyday is a long day for mriedem | 03:29 |
| *** esberglu has quit IRC | 03:31 | |
| openstackgerrit | Matthew Oliver proposed openstack/nova master: Update the obs placement-api port https://review.openstack.org/527846 | 03:31 |
| *** Apoorva has joined #openstack-nova | 03:31 | |
| *** annp has joined #openstack-nova | 03:31 | |
| *** gongysh has joined #openstack-nova | 03:34 | |
| *** zhurong has quit IRC | 03:34 | |
| *** andreas_s has joined #openstack-nova | 03:43 | |
| *** lbragstad has quit IRC | 03:44 | |
| *** sridharg has joined #openstack-nova | 03:46 | |
| *** andreas_s has quit IRC | 03:48 | |
| *** gongysh has quit IRC | 03:49 | |
| *** sree has joined #openstack-nova | 03:49 | |
| *** sree has quit IRC | 03:53 | |
| *** moshele has quit IRC | 03:55 | |
| *** armax has joined #openstack-nova | 03:55 | |
| *** moshele has joined #openstack-nova | 03:57 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 04:02 |
| *** udesale has joined #openstack-nova | 04:03 | |
| *** owalsh_ has joined #openstack-nova | 04:04 | |
| *** owalsh has quit IRC | 04:07 | |
| *** kumarmn has joined #openstack-nova | 04:08 | |
| *** lei-zh has quit IRC | 04:11 | |
| *** armax has quit IRC | 04:12 | |
| *** armax has joined #openstack-nova | 04:13 | |
| *** armax has quit IRC | 04:13 | |
| *** kumarmn has quit IRC | 04:13 | |
| *** armax has joined #openstack-nova | 04:14 | |
| *** armax has quit IRC | 04:14 | |
| *** armax has joined #openstack-nova | 04:14 | |
| *** moshele has quit IRC | 04:14 | |
| *** armax has quit IRC | 04:15 | |
| *** diga has joined #openstack-nova | 04:17 | |
| *** karthiks has quit IRC | 04:17 | |
| *** karthiks has joined #openstack-nova | 04:17 | |
| *** yamamoto has joined #openstack-nova | 04:18 | |
| *** vladikr has quit IRC | 04:22 | |
| *** _ix has quit IRC | 04:24 | |
| *** vladikr has joined #openstack-nova | 04:25 | |
| *** sree has joined #openstack-nova | 04:27 | |
| *** kumarmn has joined #openstack-nova | 04:30 | |
| *** sree has quit IRC | 04:31 | |
| *** TuanLA has quit IRC | 04:36 | |
| *** hieulq has quit IRC | 04:36 | |
| *** hieulq has joined #openstack-nova | 04:36 | |
| *** TuanLA has joined #openstack-nova | 04:36 | |
| *** hoangcx has quit IRC | 04:40 | |
| *** namnh has quit IRC | 04:40 | |
| *** phuongnh has quit IRC | 04:40 | |
| *** annp has quit IRC | 04:40 | |
| *** trungnv has quit IRC | 04:40 | |
| *** phuongnh has joined #openstack-nova | 04:40 | |
| *** hoangcx has joined #openstack-nova | 04:40 | |
| *** trungnv has joined #openstack-nova | 04:40 | |
| *** annp has joined #openstack-nova | 04:40 | |
| *** namnh has joined #openstack-nova | 04:40 | |
| *** itlinux has quit IRC | 04:45 | |
| *** sree has joined #openstack-nova | 04:47 | |
| *** bkopilov has joined #openstack-nova | 04:48 | |
| *** mriedem has quit IRC | 04:49 | |
| *** ratailor has joined #openstack-nova | 04:50 | |
| *** sree_ has joined #openstack-nova | 04:51 | |
| *** sree_ is now known as Guest97528 | 04:51 | |
| *** kumarmn has quit IRC | 04:53 | |
| *** kumarmn has joined #openstack-nova | 04:53 | |
| *** sree has quit IRC | 04:55 | |
| *** gbarros has quit IRC | 05:00 | |
| *** lei-zh has joined #openstack-nova | 05:04 | |
| *** adisky__ has joined #openstack-nova | 05:18 | |
| *** s1061123 has quit IRC | 05:20 | |
| *** kumarmn has quit IRC | 05:21 | |
| *** kumarmn has joined #openstack-nova | 05:21 | |
| *** kumarmn has quit IRC | 05:23 | |
| *** kumarmn has joined #openstack-nova | 05:24 | |
| *** markvoelker has joined #openstack-nova | 05:25 | |
| *** s1061123 has joined #openstack-nova | 05:25 | |
| *** kumarmn has quit IRC | 05:29 | |
| openstackgerrit | zhufl proposed openstack/nova master: Fix some typos in nova doc https://review.openstack.org/527856 | 05:31 |
| *** links has joined #openstack-nova | 05:35 | |
| *** sapd has quit IRC | 05:38 | |
| *** sapd_ has joined #openstack-nova | 05:38 | |
| *** Tom-Tom has joined #openstack-nova | 05:44 | |
| *** Tom-Tom_ has joined #openstack-nova | 05:47 | |
| *** eandersson has quit IRC | 05:47 | |
| *** janki has joined #openstack-nova | 05:48 | |
| *** Tom-Tom has quit IRC | 05:48 | |
| *** penick has joined #openstack-nova | 05:48 | |
| *** dtruong_ has quit IRC | 05:49 | |
| *** penick_ has joined #openstack-nova | 05:53 | |
| *** penick has quit IRC | 05:54 | |
| *** udesale__ has joined #openstack-nova | 05:54 | |
| *** amodi has quit IRC | 05:55 | |
| *** udesale has quit IRC | 05:56 | |
| *** udesale has joined #openstack-nova | 05:57 | |
| *** markvoelker has quit IRC | 05:58 | |
| *** udesale__ has quit IRC | 05:59 | |
| *** ratailor has quit IRC | 06:01 | |
| *** ratailor has joined #openstack-nova | 06:03 | |
| *** klindgren has joined #openstack-nova | 06:07 | |
| *** hiro-kobayashi has quit IRC | 06:08 | |
| *** amodi has joined #openstack-nova | 06:12 | |
| *** links has quit IRC | 06:13 | |
| *** links has joined #openstack-nova | 06:21 | |
| *** links has quit IRC | 06:21 | |
| *** lpetrut has joined #openstack-nova | 06:24 | |
| *** edand has joined #openstack-nova | 06:26 | |
| *** esberglu has joined #openstack-nova | 06:26 | |
| *** esberglu has quit IRC | 06:31 | |
| *** Apoorva has quit IRC | 06:31 | |
| *** karthiks has quit IRC | 06:33 | |
| *** hoangcx has quit IRC | 06:41 | |
| *** namnh has quit IRC | 06:41 | |
| *** trungnv has quit IRC | 06:41 | |
| *** annp has quit IRC | 06:41 | |
| *** phuongnh has quit IRC | 06:41 | |
| *** namnh has joined #openstack-nova | 06:41 | |
| *** trungnv has joined #openstack-nova | 06:41 | |
| *** annp has joined #openstack-nova | 06:41 | |
| *** hoangcx has joined #openstack-nova | 06:41 | |
| *** phuongnh has joined #openstack-nova | 06:42 | |
| *** andreas_s has joined #openstack-nova | 06:42 | |
| *** karthiks has joined #openstack-nova | 06:46 | |
| *** andreas_s has quit IRC | 06:47 | |
| *** openstackgerrit has quit IRC | 06:47 | |
| *** TuanLA_ has joined #openstack-nova | 06:48 | |
| *** TuanLA has quit IRC | 06:50 | |
| *** threestrands_ has quit IRC | 06:53 | |
| *** openstackgerrit has joined #openstack-nova | 06:55 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Updated common create server sample request because of microversion 2.57 https://review.openstack.org/527878 | 06:55 |
| *** markvoelker has joined #openstack-nova | 06:55 | |
| *** karthiks has quit IRC | 06:55 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Updated common create server sample request because of microversion 2.57 https://review.openstack.org/527878 | 06:57 |
| *** damien_r has joined #openstack-nova | 07:00 | |
| *** huanxie has quit IRC | 07:02 | |
| *** huanxie has joined #openstack-nova | 07:02 | |
| *** amodi has quit IRC | 07:04 | |
| *** esberglu has joined #openstack-nova | 07:04 | |
| *** sapd__ has joined #openstack-nova | 07:07 | |
| *** sapd_ has quit IRC | 07:07 | |
| *** Tom-Tom_ has quit IRC | 07:07 | |
| *** josecastroleon has joined #openstack-nova | 07:07 | |
| *** esberglu has quit IRC | 07:08 | |
| *** karthiks has joined #openstack-nova | 07:08 | |
| openstackgerrit | Ya Lian Pan proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 07:10 |
| *** hoangcx has quit IRC | 07:14 | |
| *** annp has quit IRC | 07:14 | |
| *** namnh has quit IRC | 07:14 | |
| *** phuongnh has quit IRC | 07:14 | |
| *** trungnv has quit IRC | 07:14 | |
| *** trungnv has joined #openstack-nova | 07:14 | |
| *** annp has joined #openstack-nova | 07:14 | |
| *** namnh has joined #openstack-nova | 07:14 | |
| *** phuongnh has joined #openstack-nova | 07:14 | |
| *** hoangcx has joined #openstack-nova | 07:15 | |
| *** amodi has joined #openstack-nova | 07:15 | |
| *** hieulq has quit IRC | 07:23 | |
| *** damien_r has quit IRC | 07:27 | |
| *** Alex_Staf has joined #openstack-nova | 07:27 | |
| *** lpetrut has quit IRC | 07:28 | |
| *** chyka has joined #openstack-nova | 07:28 | |
| *** markvoelker has quit IRC | 07:30 | |
| *** karthiks has quit IRC | 07:31 | |
| *** felipemonteiro_ has joined #openstack-nova | 07:31 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/524795 | 07:32 |
| *** chyka has quit IRC | 07:33 | |
| *** bkopilov has quit IRC | 07:37 | |
| *** moshele has joined #openstack-nova | 07:38 | |
| *** diga_ has joined #openstack-nova | 07:38 | |
| *** diga has quit IRC | 07:39 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 07:42 |
| *** klindgren has quit IRC | 07:43 | |
| openstackgerrit | Ya Lian Pan proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 07:44 |
| *** vladikr has quit IRC | 07:48 | |
| *** sshwarts has joined #openstack-nova | 07:48 | |
| *** vladikr has joined #openstack-nova | 07:48 | |
| *** karthiks has joined #openstack-nova | 07:49 | |
| *** bkopilov has joined #openstack-nova | 07:53 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 07:59 |
| openstackgerrit | Chason Chan proposed openstack/nova master: Fix the bug report link of API Guide https://review.openstack.org/527660 | 08:01 |
| *** felipemonteiro__ has joined #openstack-nova | 08:03 | |
| *** sahid has joined #openstack-nova | 08:04 | |
| *** felipemonteiro_ has quit IRC | 08:06 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:09 | |
| *** alexchadin has joined #openstack-nova | 08:13 | |
| *** janki has quit IRC | 08:15 | |
| *** rcernin has quit IRC | 08:15 | |
| *** sapcc-bot has quit IRC | 08:18 | |
| *** penick_ has quit IRC | 08:18 | |
| *** sapcc-bot has joined #openstack-nova | 08:18 | |
| *** david_1 has joined #openstack-nova | 08:19 | |
| *** tpatzig_ has joined #openstack-nova | 08:19 | |
| *** mkoderer_ has joined #openstack-nova | 08:19 | |
| *** dgonzalez_ has joined #openstack-nova | 08:19 | |
| *** carthaca_ has joined #openstack-nova | 08:19 | |
| *** amodi has quit IRC | 08:19 | |
| *** amodi has joined #openstack-nova | 08:20 | |
| *** sapcc-bot has quit IRC | 08:21 | |
| *** carthaca_ has quit IRC | 08:21 | |
| *** david_1 has quit IRC | 08:21 | |
| *** tpatzig_ has quit IRC | 08:21 | |
| *** mkoderer_ has quit IRC | 08:21 | |
| *** dgonzalez_ has quit IRC | 08:21 | |
| *** tpatzig_ has joined #openstack-nova | 08:21 | |
| *** sapcc-bot has joined #openstack-nova | 08:21 | |
| *** dgonzalez_ has joined #openstack-nova | 08:21 | |
| *** carthaca_ has joined #openstack-nova | 08:21 | |
| *** tpatzig_1 has joined #openstack-nova | 08:21 | |
| *** mkoderer_ has joined #openstack-nova | 08:21 | |
| *** david_2 has joined #openstack-nova | 08:21 | |
| *** dgonzalez_1 has joined #openstack-nova | 08:21 | |
| *** carthaca_1 has joined #openstack-nova | 08:21 | |
| *** david_1 has joined #openstack-nova | 08:21 | |
| *** mkoderer_1 has joined #openstack-nova | 08:22 | |
| *** dgonzalez_ has quit IRC | 08:23 | |
| *** carthaca_ has quit IRC | 08:23 | |
| *** tpatzig_1 has quit IRC | 08:23 | |
| *** david_1 has quit IRC | 08:23 | |
| *** mkoderer_1 has quit IRC | 08:23 | |
| *** TuanLA__ has joined #openstack-nova | 08:26 | |
| *** markvoelker has joined #openstack-nova | 08:26 | |
| *** tssurya has joined #openstack-nova | 08:27 | |
| *** tesseract has joined #openstack-nova | 08:28 | |
| *** TuanLA_ has quit IRC | 08:28 | |
| *** mdnadeem has joined #openstack-nova | 08:36 | |
| *** hoonetorg has quit IRC | 08:37 | |
| *** zzzeek has quit IRC | 08:43 | |
| *** zzzeek has joined #openstack-nova | 08:45 | |
| *** jpena|off is now known as jpena | 08:46 | |
| *** ralonsoh has joined #openstack-nova | 08:47 | |
| *** links has joined #openstack-nova | 08:52 | |
| *** obre has quit IRC | 08:54 | |
| *** hoonetorg has joined #openstack-nova | 08:54 | |
| *** obre has joined #openstack-nova | 08:56 | |
| *** links has quit IRC | 08:57 | |
| *** Alex_Staf has quit IRC | 08:59 | |
| *** markvoelker has quit IRC | 09:00 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (2) https://review.openstack.org/526263 | 09:00 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (3) https://review.openstack.org/526557 | 09:00 |
| *** ociuhandu has joined #openstack-nova | 09:08 | |
| *** alexchadin has quit IRC | 09:09 | |
| *** alexchadin has joined #openstack-nova | 09:09 | |
| *** links has joined #openstack-nova | 09:10 | |
| *** Alex_Staf has joined #openstack-nova | 09:16 | |
| *** felipemonteiro__ has quit IRC | 09:16 | |
| *** bkopilov has quit IRC | 09:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in post https://review.openstack.org/526823 | 09:17 |
| *** ociuhandu has quit IRC | 09:18 | |
| *** ociuhandu has joined #openstack-nova | 09:22 | |
| *** ociuhandu has quit IRC | 09:22 | |
| *** rcernin has joined #openstack-nova | 09:23 | |
| *** edand_ has joined #openstack-nova | 09:27 | |
| *** owalsh_ is now known as owalsh | 09:28 | |
| *** yangyapeng has quit IRC | 09:29 | |
| openstackgerrit | Dai Dang Van proposed openstack/nova master: WIP: Allow multi-attach in compute api https://review.openstack.org/271047 | 09:30 |
| *** yangyapeng has joined #openstack-nova | 09:30 | |
| *** edand has quit IRC | 09:31 | |
| *** takashin has left #openstack-nova | 09:33 | |
| *** lucas-afk is now known as lucasagomes | 09:33 | |
| openstackgerrit | Ya Lian Pan proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 09:36 |
| *** janki has joined #openstack-nova | 09:36 | |
| *** mkoderer_1 has joined #openstack-nova | 09:37 | |
| *** tpatzig_1 has joined #openstack-nova | 09:37 | |
| *** david_ has joined #openstack-nova | 09:37 | |
| *** dgonzalez_ has joined #openstack-nova | 09:37 | |
| *** david_ has quit IRC | 09:39 | |
| *** dgonzalez_ has quit IRC | 09:39 | |
| *** tpatzig_1 has quit IRC | 09:39 | |
| *** mkoderer_1 has quit IRC | 09:39 | |
| *** lei-zh has quit IRC | 09:41 | |
| *** derekh has joined #openstack-nova | 09:42 | |
| *** yangyapeng has quit IRC | 09:49 | |
| *** ygl has joined #openstack-nova | 09:49 | |
| *** yangyapeng has joined #openstack-nova | 09:49 | |
| *** ygl has left #openstack-nova | 09:52 | |
| *** edand__ has joined #openstack-nova | 09:55 | |
| *** markvoelker has joined #openstack-nova | 09:57 | |
| *** edand_ has quit IRC | 09:59 | |
| *** lpetrut has joined #openstack-nova | 09:59 | |
| *** sdague has joined #openstack-nova | 09:59 | |
| *** gszasz has joined #openstack-nova | 10:00 | |
| *** yangyapeng has quit IRC | 10:00 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Improve error message on invalid BDM fields https://review.openstack.org/527915 | 10:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: DriverBlockDevice: make subclasses inherit _proxy_as_attr https://review.openstack.org/524167 | 10:02 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Give volume DriverBlockDevice classes a common prefix https://review.openstack.org/526346 | 10:02 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347 | 10:02 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Use real block_device_info data in test_blockinfo https://review.openstack.org/527916 | 10:02 |
| *** esberglu has joined #openstack-nova | 10:04 | |
| *** TuanLA__ has quit IRC | 10:05 | |
| *** annp has quit IRC | 10:07 | |
| *** esberglu has quit IRC | 10:08 | |
| *** bkopilov has joined #openstack-nova | 10:09 | |
| *** namnh has quit IRC | 10:09 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix possible TypeError in VIF.fixed_ips https://review.openstack.org/527920 | 10:16 |
| *** mounika has joined #openstack-nova | 10:16 | |
| *** josecastroleon has quit IRC | 10:18 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: handle traits with sharing providers https://review.openstack.org/517119 | 10:21 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380 | 10:21 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617 | 10:21 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633 | 10:21 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | 10:21 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189 | 10:21 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add aggregates check in allocation candidates https://review.openstack.org/522407 | 10:21 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix missing rps in allocation candidates https://review.openstack.org/522409 | 10:21 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737 | 10:21 |
| *** sambetts|afk is now known as sambetts | 10:21 | |
| gibi | jaypipes: ^^ rebased the series as master already has the fix for the frequently failing functional test that prevented these to be merged | 10:23 |
| *** kumarmn has joined #openstack-nova | 10:25 | |
| *** dtantsur|afk is now known as dtantsur | 10:25 | |
| *** edand__ has quit IRC | 10:25 | |
| *** edand__ has joined #openstack-nova | 10:25 | |
| openstackgerrit | rahul bardia proposed openstack/python-novaclient master: nova limits ERROR (Exception): Field names must be unique This happens when 'Others' field is occuring more than once which is not handled in code causing multiple columns having same name. Which throws above exception and does not pretty prints absolute https://review.openstack.org/527922 | 10:26 |
| *** yangyapeng has joined #openstack-nova | 10:28 | |
| *** kumarmn has quit IRC | 10:29 | |
| *** markvoelker has quit IRC | 10:29 | |
| *** damien_r has joined #openstack-nova | 10:30 | |
| *** alexchadin has quit IRC | 10:32 | |
| *** alexchadin has joined #openstack-nova | 10:33 | |
| *** amodi has quit IRC | 10:34 | |
| *** amodi has joined #openstack-nova | 10:35 | |
| *** sapd__ has quit IRC | 10:37 | |
| *** yangyapeng has quit IRC | 10:37 | |
| *** tosky has joined #openstack-nova | 10:37 | |
| *** andreas_s has joined #openstack-nova | 10:38 | |
| *** yangyapeng has joined #openstack-nova | 10:40 | |
| *** udesale has quit IRC | 10:41 | |
| *** udesale has joined #openstack-nova | 10:42 | |
| *** karthiks has quit IRC | 10:42 | |
| *** links has quit IRC | 10:43 | |
| *** andreas_s has quit IRC | 10:43 | |
| *** sapd__ has joined #openstack-nova | 10:51 | |
| *** tssurya has quit IRC | 10:55 | |
| *** alexchadin has quit IRC | 10:55 | |
| *** Alex_Staf has quit IRC | 10:55 | |
| *** Alex_Staf has joined #openstack-nova | 10:55 | |
| *** alexchadin has joined #openstack-nova | 10:55 | |
| *** links has joined #openstack-nova | 10:57 | |
| *** zzzeek has quit IRC | 11:05 | |
| *** trozet has quit IRC | 11:07 | |
| *** _pewp_ has quit IRC | 11:08 | |
| *** trozet has joined #openstack-nova | 11:08 | |
| *** _pewp_ has joined #openstack-nova | 11:09 | |
| *** AlexeyAbashkin has quit IRC | 11:10 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:11 | |
| kashyap | stephenfin: Hi there, when you get a moment, you know why is Zuul complaning here - https://review.openstack.org/#/c/527691/ | 11:11 |
| *** zzzeek has joined #openstack-nova | 11:12 | |
| *** yamamoto has quit IRC | 11:12 | |
| *** syjulian has joined #openstack-nova | 11:13 | |
| *** alexchadin has quit IRC | 11:18 | |
| stephenfin | kashyap: Looking | 11:21 |
| *** gszasz has quit IRC | 11:22 | |
| stephenfin | kashyap: That job's been failing a lot lately, but I don't know why. It's unrelated to this, in any case | 11:22 |
| stephenfin | We should probably investigate that, actually | 11:23 |
| stephenfin | bauzas: Ta for the review :) | 11:24 |
| kashyap | stephenfin: Yeah, noted; right now I need to run an errand. | 11:25 |
| *** markvoelker has joined #openstack-nova | 11:26 | |
| openstackgerrit | Merged openstack/nova stable/ocata: Add regression test for rebuilding a volume-backed server https://review.openstack.org/525664 | 11:34 |
| *** linkmark has joined #openstack-nova | 11:40 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add regression test for bug 1735407 https://review.openstack.org/526095 | 11:41 |
| openstack | bug 1735407 in OpenStack Compute (nova) "[Nova] Evacuation doesn't respect anti-affinity rules" [Medium,In progress] https://launchpad.net/bugs/1735407 - Assigned to Balazs Gibizer (balazs-gibizer) | 11:41 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add late server group policy check to rebuild https://review.openstack.org/525242 | 11:41 |
| *** lucasagomes is now known as lucas-hungry | 11:42 | |
| *** diga_ has quit IRC | 11:43 | |
| *** janki has quit IRC | 11:46 | |
| *** alexchadin has joined #openstack-nova | 11:49 | |
| *** amodi has quit IRC | 11:49 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 11:51 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | 11:51 |
| *** yamamoto has joined #openstack-nova | 11:53 | |
| *** yamamoto has quit IRC | 11:54 | |
| *** yamamoto has joined #openstack-nova | 11:55 | |
| *** jafeha has quit IRC | 11:55 | |
| *** jafeha has joined #openstack-nova | 11:58 | |
| *** sapcc-bot has quit IRC | 11:58 | |
| *** tpatzig_ has quit IRC | 11:58 | |
| *** carthaca_1 has quit IRC | 11:58 | |
| *** mkoderer_ has quit IRC | 11:58 | |
| *** david_2 has quit IRC | 11:58 | |
| *** dgonzalez_1 has quit IRC | 11:58 | |
| *** mkoderer_ has joined #openstack-nova | 11:59 | |
| *** carthaca_ has joined #openstack-nova | 11:59 | |
| *** tpatzig_ has joined #openstack-nova | 11:59 | |
| *** dgonzalez_ has joined #openstack-nova | 11:59 | |
| *** david_3 has joined #openstack-nova | 11:59 | |
| *** sapcc-bot has joined #openstack-nova | 11:59 | |
| *** mkoderer_1 has joined #openstack-nova | 11:59 | |
| *** tpatzig_1 has joined #openstack-nova | 11:59 | |
| *** david_1 has joined #openstack-nova | 11:59 | |
| *** carthaca_1 has joined #openstack-nova | 11:59 | |
| *** dgonzalez_1 has joined #openstack-nova | 11:59 | |
| *** markvoelker has quit IRC | 12:00 | |
| *** cdent has joined #openstack-nova | 12:00 | |
| *** tpatzig_1 has quit IRC | 12:01 | |
| *** david_1 has quit IRC | 12:01 | |
| *** mkoderer_1 has quit IRC | 12:01 | |
| *** carthaca_1 has quit IRC | 12:01 | |
| *** dgonzalez_1 has quit IRC | 12:01 | |
| *** jpena is now known as jpena|lunch | 12:01 | |
| gibi | kashyap, stephenfin: the test_live_migration_actions functional test failure has already been fixed on master so you just have to rebase | 12:01 |
| *** ratailor has quit IRC | 12:02 | |
| stephenfin | gibi: Aha. What patch fixed it, out of curiosity? | 12:02 |
| gibi | kashyap, stephenfin: this was the fix https://review.openstack.org/#/c/527440/ | 12:02 |
| stephenfin | jinx :)_ | 12:02 |
| *** amodi has joined #openstack-nova | 12:02 | |
| stephenfin | Oh, nice | 12:02 |
| gibi | stephenfin: there is one more fix in the pipe that fixes another failure mode of that test here https://review.openstack.org/#/c/527444/ | 12:03 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extract instance allocation removal code https://review.openstack.org/513041 | 12:04 |
| *** gszasz has joined #openstack-nova | 12:04 | |
| *** sahid has quit IRC | 12:09 | |
| *** david_3 has quit IRC | 12:11 | |
| *** sapcc-bot has quit IRC | 12:11 | |
| *** mkoderer_ has quit IRC | 12:11 | |
| *** carthaca_ has quit IRC | 12:11 | |
| *** tpatzig_ has quit IRC | 12:11 | |
| *** dgonzalez_ has quit IRC | 12:11 | |
| *** david_4 has joined #openstack-nova | 12:11 | |
| *** tpatzig_ has joined #openstack-nova | 12:11 | |
| *** dgonzalez_ has joined #openstack-nova | 12:11 | |
| *** mkoderer_ has joined #openstack-nova | 12:11 | |
| *** sapcc-bot has joined #openstack-nova | 12:11 | |
| *** carthaca_ has joined #openstack-nova | 12:11 | |
| *** tpatzig_1 has joined #openstack-nova | 12:11 | |
| *** dgonzalez_1 has joined #openstack-nova | 12:11 | |
| *** david_1 has joined #openstack-nova | 12:11 | |
| *** mkoderer_1 has joined #openstack-nova | 12:11 | |
| *** sapd__ has quit IRC | 12:11 | |
| *** carthaca_1 has joined #openstack-nova | 12:11 | |
| *** sapd__ has joined #openstack-nova | 12:12 | |
| *** tpatzig_1 has quit IRC | 12:13 | |
| *** carthaca_1 has quit IRC | 12:13 | |
| *** mkoderer_1 has quit IRC | 12:13 | |
| *** david_1 has quit IRC | 12:13 | |
| *** dgonzalez_1 has quit IRC | 12:13 | |
| *** smatzek has joined #openstack-nova | 12:15 | |
| *** tssurya has joined #openstack-nova | 12:18 | |
| *** yamamoto has quit IRC | 12:19 | |
| *** gbarros has joined #openstack-nova | 12:20 | |
| *** dave-mccowan has joined #openstack-nova | 12:20 | |
| *** udesale has quit IRC | 12:23 | |
| *** dave-mcc_ has joined #openstack-nova | 12:24 | |
| *** tpatzig_ has quit IRC | 12:25 | |
| *** dave-mccowan has quit IRC | 12:25 | |
| *** dgonzalez_1 has joined #openstack-nova | 12:25 | |
| *** david_1 has joined #openstack-nova | 12:25 | |
| *** carthaca_1 has joined #openstack-nova | 12:25 | |
| *** tpatzig_ has joined #openstack-nova | 12:25 | |
| *** mkoderer_1 has joined #openstack-nova | 12:25 | |
| *** kumarmn has joined #openstack-nova | 12:25 | |
| *** tpatzig_1 has joined #openstack-nova | 12:25 | |
| *** tpatzig_ has quit IRC | 12:27 | |
| *** alexchadin has quit IRC | 12:27 | |
| *** carthaca_1 has quit IRC | 12:27 | |
| *** david_1 has quit IRC | 12:27 | |
| *** dgonzalez_1 has quit IRC | 12:27 | |
| *** mkoderer_1 has quit IRC | 12:27 | |
| *** alexchadin has joined #openstack-nova | 12:28 | |
| *** kumarmn has quit IRC | 12:30 | |
| *** BryanS68 has joined #openstack-nova | 12:30 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Enable limiting GET /allocation_candidates https://review.openstack.org/513526 | 12:35 |
| *** Guest97528 has quit IRC | 12:38 | |
| *** sree has joined #openstack-nova | 12:38 | |
| openstackgerrit | Chason Chan proposed openstack/nova master: Fix the bug report link of API Guide https://review.openstack.org/527660 | 12:40 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add PCI NUMA policies https://review.openstack.org/527472 | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Modify signature of _filter_non_requested_pfs https://review.openstack.org/527473 | 12:43 |
| *** psachin has quit IRC | 12:43 | |
| efried_cya_jan | stephenfin gibi Thanks for looking after those patches! | 12:44 |
| *** Trident has joined #openstack-nova | 12:45 | |
| cdent | efried_cya_jan: since you're here (naughty!) I should report that I've not had a chance to do anything with your stuff: I've got a nasty cold so mostly done nothing for the past couple of days. But when I surface, I will. | 12:45 |
| efried_cya_jan | cdent I somehow caught your cold, which is a sucky way to start a vacation. It looks like stephenfin has been addressing review comments and he & gibi have been rebasing stuff, so I think you're in the clear... for now :) | 12:46 |
| cdent | internet germs are the worst | 12:46 |
| gibi | efried_cya_jan: o/ | 12:46 |
| *** ttsiouts has quit IRC | 12:47 | |
| openstackgerrit | Raghad Qutteneh proposed openstack/nova master: Allow force-delete to delete instance in task_state block_device_mapping https://review.openstack.org/527951 | 12:48 |
| *** catintheroof has joined #openstack-nova | 12:49 | |
| *** mounika has quit IRC | 12:49 | |
| *** lucas-hungry is now known as lucasagomes | 12:50 | |
| *** chyka has joined #openstack-nova | 12:52 | |
| gibi | efried_cya_jan: if you are here I have a question. Do I understand correctly that the GET allocation_candidate API does not handle nested RPs yet? | 12:53 |
| *** tetsuro has quit IRC | 12:53 | |
| efried_cya_jan | gibi That's correct. That's a major piece we need before we can slot in the granular resource requests work. | 12:53 |
| gibi | efried_cya_jan: OK, cool | 12:54 |
| efried_cya_jan | gibi: jaypipes is on the hook for that. | 12:54 |
| gibi | OK | 12:55 |
| *** damien_r has quit IRC | 12:55 | |
| *** markvoelker has joined #openstack-nova | 12:57 | |
| *** chyka has quit IRC | 12:57 | |
| *** jpena|lunch is now known as jpena | 13:00 | |
| *** mvenesio has joined #openstack-nova | 13:01 | |
| *** phuongnh has quit IRC | 13:03 | |
| *** yamamoto has joined #openstack-nova | 13:07 | |
| *** bkopilov has quit IRC | 13:07 | |
| *** damien_r has joined #openstack-nova | 13:08 | |
| *** kaisers has quit IRC | 13:09 | |
| *** artom has joined #openstack-nova | 13:10 | |
| *** kaisers has joined #openstack-nova | 13:15 | |
| *** claudiub has joined #openstack-nova | 13:18 | |
| *** mingyu has joined #openstack-nova | 13:19 | |
| *** damien_r has quit IRC | 13:20 | |
| *** damien_r has joined #openstack-nova | 13:21 | |
| *** liverpooler has joined #openstack-nova | 13:23 | |
| *** esberglu has joined #openstack-nova | 13:23 | |
| *** ralonsoh has quit IRC | 13:25 | |
| *** markvoelker has quit IRC | 13:28 | |
| *** markvoelker has joined #openstack-nova | 13:28 | |
| *** esberglu has quit IRC | 13:28 | |
| *** ralonsoh has joined #openstack-nova | 13:30 | |
| *** liverpooler has quit IRC | 13:35 | |
| *** liverpooler has joined #openstack-nova | 13:35 | |
| *** edmondsw has joined #openstack-nova | 13:37 | |
| *** abhishekk has joined #openstack-nova | 13:37 | |
| *** BryanS68 has quit IRC | 13:37 | |
| *** yamamoto has quit IRC | 13:41 | |
| *** cleong has joined #openstack-nova | 13:41 | |
| kashyap | gibi: Thanks for the (non-null) pointer :-) | 13:48 |
| *** yamamoto has joined #openstack-nova | 13:50 | |
| *** BryanS68 has joined #openstack-nova | 13:51 | |
| *** mriedem has joined #openstack-nova | 13:51 | |
| mriedem | oh crap today is thursday huh | 13:52 |
| mriedem | gibi: can you run the meeting? | 13:52 |
| gibi | mriedem: sure | 13:53 |
| *** takashin has joined #openstack-nova | 13:53 | |
| mriedem | thanks. i'll update the agenda quick. | 13:54 |
| gibi | mriedem: thanks, that helps | 13:54 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Enable limiting GET /allocation_candidates https://review.openstack.org/513526 | 13:54 |
| *** pchavva has joined #openstack-nova | 13:54 | |
| *** yamamoto has quit IRC | 13:54 | |
| *** lyan has joined #openstack-nova | 13:57 | |
| mriedem | done https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 13:57 |
| gibi | cool | 13:58 |
| *** _ix has joined #openstack-nova | 13:58 | |
| *** rcernin has quit IRC | 13:59 | |
| gibi | nova meeting is about to start on @openstack-meeting | 14:00 |
| cdent | mriedem: just wanted to say: thanks for trying to keep it real in the cycle length thread. | 14:00 |
| mriedem | np | 14:00 |
| cdent | I'm trying to gather my thoughts, but not having much success | 14:01 |
| mriedem | i think i will have to move on today from that thread | 14:02 |
| cdent | that would be a bummer, you are uniquely positioned to, uh, keep it real | 14:02 |
| *** _ix has quit IRC | 14:03 | |
| mriedem | i don't have the energy to fight that battle, and it sounds like the majority of people (ops, users?) seem to like the idea. i think it will turn out to be more than what they bargained for (some things they'll lose, some things they won't get out of it) | 14:04 |
| *** dosaboy has quit IRC | 14:04 | |
| mriedem | we'll do what we need to do for nova, if that means intermediate releases just to give us a deadline to work toward even if no one ever consumes it | 14:05 |
| cdent | i definitely think that if it happens hard interediate deadlines will be _very_ important | 14:06 |
| edleafe | so if you don't meet a deadline, would that mean waiting a year? Or what? | 14:07 |
| * cdent hopes not | 14:08 | |
| edleafe | just wondering how "dead" such a deadline would be | 14:09 |
| cdent | as you know, I think all deadlines are made up and thus fungible, but they are useful encouragement tools? | 14:10 |
| *** dosaboy has joined #openstack-nova | 14:10 | |
| edleafe | IMO, deadlines work as sticks, not carrots. | 14:11 |
| cdent | maybe call them boundaries? | 14:12 |
| *** ttsiouts has joined #openstack-nova | 14:13 | |
| mriedem | jaypipes: i put this up for that dbdeadlock issue https://review.openstack.org/#/c/527836/ - not sure that's best, but it's a thing | 14:13 |
| mriedem | edleafe: i think we'd do intermediate releases so we could have more than 1 freeze in a year | 14:13 |
| mriedem | so either 1 or 2 intermediate releases (6 month or 4 month between them), and do our normal spec review, spec freeze, code churn, feature freeze, stability minute, then open up for new specs again | 14:14 |
| mriedem | i don't think we can freeze out specs for an entire year, | 14:14 |
| mriedem | and i don't think we can leave spec reviews open for an entire year and focus on actually getting things done | 14:14 |
| *** yamamoto has joined #openstack-nova | 14:14 | |
| edleafe | mriedem: so would they be Rocky I, Rocky II, ... | 14:14 |
| mriedem | rocky IV is where we fight the mirantis guys | 14:15 |
| mriedem | us guys, | 14:15 |
| mriedem | and yous guys | 14:15 |
| mriedem | having said that, i don't know what we'd do for upgrade testing with intermediate releases | 14:16 |
| mriedem | do you do queens->rocky.1, queens->rocky.2, or queens->rocky.1->rocky.2? | 14:16 |
| mriedem | today it would be the former because of how the CI system works on branches | 14:17 |
| mriedem | i assume we would use minor version bumps for intermediate releases | 14:17 |
| edleafe | yuck | 14:17 |
| cdent | blargh | 14:17 |
| mriedem | so rocky 1 would be 17.1.0 | 14:17 |
| *** erlon has joined #openstack-nova | 14:17 | |
| mriedem | if rocky GA was 18.0.0 | 14:17 |
| mriedem | but, | 14:17 |
| mriedem | that gets tricky if we actually need to backport something to stable/pike which would normally be a minor update | 14:18 |
| mriedem | like a schema migration | 14:18 |
| mriedem | likely a question i'll need to ask about in "the thread" | 14:19 |
| *** yamamoto has quit IRC | 14:19 | |
| *** kumarmn has joined #openstack-nova | 14:19 | |
| stephenfin | efried_cya_jan: See your comments now. I'll address them shortly | 14:20 |
| stephenfin | Fwiw, I'll keep trying to do the minimum possible amount to keep everyone happy and get it in (ignored most of my own comments/preferences for this reason) | 14:20 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Refactor encryptor attach and detach calls https://review.openstack.org/460243 | 14:20 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Introduce disk encryption config classes https://review.openstack.org/464008 | 14:20 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Use QEMU's native LUKS support https://review.openstack.org/523958 | 14:20 |
| *** kumarmn has quit IRC | 14:24 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Use QEMU's native LUKS support https://review.openstack.org/523958 | 14:24 |
| *** kumarmn has joined #openstack-nova | 14:24 | |
| *** gouthamr has joined #openstack-nova | 14:25 | |
| openstackgerrit | Merged openstack/nova master: [placement] add name to resource provider create error https://review.openstack.org/526710 | 14:26 |
| openstackgerrit | Merged openstack/nova master: [placement] Add 'Location' parameters in API ref https://review.openstack.org/521541 | 14:26 |
| openstackgerrit | Merged openstack/nova master: doc: link in some Sydney summit content https://review.openstack.org/526587 | 14:26 |
| dansmith | bauzas: need you to look at https://review.openstack.org/#/c/527799/2 | 14:27 |
| *** mdnadeem has quit IRC | 14:28 | |
| *** kumarmn has quit IRC | 14:29 | |
| takashin | mriedem: The compute API microversion 2.57 was added in "Deprecate file injection" https://review.openstack.org/#/c/522027/ . | 14:30 |
| takashin | mriedem: But I cannot find a patch for microversion 2.57 in python-novaclient. Would you submit the patch? | 14:30 |
| *** smatzek has quit IRC | 14:30 | |
| takashin | mriedem: Are you around? | 14:31 |
| jaypipes | mriedem: ok, looking at it now. | 14:33 |
| *** mlavalle has joined #openstack-nova | 14:34 | |
| *** baoli has joined #openstack-nova | 14:35 | |
| mriedem | takashin: i plan on working on that novaclient patch today | 14:37 |
| mriedem | takashin: didn't get the time yesterday - too much other stuff going on | 14:37 |
| takashin | mriedem: okay. Thanks. | 14:38 |
| *** yangyapeng has quit IRC | 14:38 | |
| *** awaugama has joined #openstack-nova | 14:39 | |
| *** mdnadeem has joined #openstack-nova | 14:41 | |
| *** sapd__ has quit IRC | 14:41 | |
| *** andreas_s has joined #openstack-nova | 14:41 | |
| *** yikun_ has joined #openstack-nova | 14:42 | |
| jroll | mriedem: we should talk about releases/upgrades at PTG if this goes through, ironic has some experience with that | 14:43 |
| *** sapcc-bot has quit IRC | 14:45 | |
| *** mkoderer_ has quit IRC | 14:45 | |
| *** carthaca_ has quit IRC | 14:45 | |
| *** dgonzalez_ has quit IRC | 14:45 | |
| *** tpatzig_1 has quit IRC | 14:45 | |
| *** david_4 has quit IRC | 14:45 | |
| *** dgonzalez_ has joined #openstack-nova | 14:45 | |
| *** mkoderer_ has joined #openstack-nova | 14:45 | |
| *** mkoderer_1 has joined #openstack-nova | 14:45 | |
| *** tpatzig_ has joined #openstack-nova | 14:45 | |
| *** carthaca_ has joined #openstack-nova | 14:45 | |
| *** sapcc-bot has joined #openstack-nova | 14:45 | |
| *** dgonzalez_1 has joined #openstack-nova | 14:45 | |
| *** david_5 has joined #openstack-nova | 14:45 | |
| *** tpatzig_2 has joined #openstack-nova | 14:45 | |
| *** alexchadin has quit IRC | 14:46 | |
| *** andreas_s has quit IRC | 14:46 | |
| cdent | jroll: are you back on the scene? | 14:46 |
| cdent | as in: gonna be in dublin? | 14:46 |
| mriedem | jroll: yeah i was going to ask in the thread to get the experience of other teams already doing it | 14:46 |
| jroll | cdent: waiting for approval but hopefully yes | 14:47 |
| jroll | mriedem: ++ | 14:47 |
| *** david_5 has quit IRC | 14:47 | |
| *** carthaca_ has quit IRC | 14:47 | |
| *** mkoderer_1 has quit IRC | 14:47 | |
| *** dgonzalez_1 has quit IRC | 14:47 | |
| *** sapcc-bot has quit IRC | 14:47 | |
| *** tpatzig_ has quit IRC | 14:47 | |
| *** tpatzig_2 has quit IRC | 14:47 | |
| *** mkoderer_ has quit IRC | 14:47 | |
| *** dgonzalez_ has quit IRC | 14:47 | |
| *** carthaca_ has joined #openstack-nova | 14:48 | |
| *** tpatzig_ has joined #openstack-nova | 14:48 | |
| *** 7ITABX779 has joined #openstack-nova | 14:48 | |
| *** mkoderer_ has joined #openstack-nova | 14:48 | |
| *** sapcc-bot has joined #openstack-nova | 14:48 | |
| *** 18WAABEXO has joined #openstack-nova | 14:48 | |
| *** dgonzalez_2 has joined #openstack-nova | 14:48 | |
| *** tpatzig_1 has joined #openstack-nova | 14:48 | |
| *** tpatzig_3 has joined #openstack-nova | 14:48 | |
| *** mkoderer_1 has joined #openstack-nova | 14:48 | |
| *** david_6 has joined #openstack-nova | 14:48 | |
| *** mkoderer_2 has joined #openstack-nova | 14:48 | |
| mriedem | i didn't want to ask jroll that question | 14:49 |
| *** tpatzig_ has quit IRC | 14:49 | |
| *** mkoderer_ has quit IRC | 14:49 | |
| *** 18WAABEXO has quit IRC | 14:49 | |
| mriedem | something something "don't ask a question you don't already know the answer to" | 14:50 |
| *** lbragstad has joined #openstack-nova | 14:50 | |
| jroll | you don't wanna know anyway | 14:50 |
| *** xyang1 has joined #openstack-nova | 14:50 | |
| *** tpatzig_ has joined #openstack-nova | 14:50 | |
| *** dgonzalez_ has joined #openstack-nova | 14:50 | |
| *** mkoderer_ has joined #openstack-nova | 14:50 | |
| *** mdnadeem has quit IRC | 14:50 | |
| *** burt has joined #openstack-nova | 14:50 | |
| *** mdnadeem has joined #openstack-nova | 14:51 | |
| *** mkoderer_ has quit IRC | 14:52 | |
| *** tpatzig_ has quit IRC | 14:52 | |
| *** dgonzalez_ has quit IRC | 14:52 | |
| *** abhishekk has quit IRC | 14:53 | |
| *** tidwellr has joined #openstack-nova | 14:54 | |
| *** esberglu has joined #openstack-nova | 14:56 | |
| *** yangyapeng has joined #openstack-nova | 14:56 | |
| *** smatzek has joined #openstack-nova | 14:58 | |
| *** smatzek has quit IRC | 14:59 | |
| *** jmlowe_ has joined #openstack-nova | 14:59 | |
| *** smatzek has joined #openstack-nova | 14:59 | |
| *** smatzek has quit IRC | 14:59 | |
| *** smatzek has joined #openstack-nova | 15:00 | |
| *** jmlowe has quit IRC | 15:00 | |
| stephenfin | mdbooth: So if I'm understanding this correctly, this fixes and issue we'd only see when using microversion < 2.25? https://review.openstack.org/#/c/524681/ | 15:01 |
| *** marst has joined #openstack-nova | 15:01 | |
| *** takashin has left #openstack-nova | 15:01 | |
| *** yangyapeng has quit IRC | 15:02 | |
| *** jmlowe has joined #openstack-nova | 15:04 | |
| *** jmlowe_ has quit IRC | 15:06 | |
| *** rodolof has joined #openstack-nova | 15:09 | |
| cdent | zounds, an email thread has drawn dansmith, this is a banner day | 15:09 |
| dansmith | cdent: I really really wanted to ignore this one even more than usual | 15:09 |
| cdent | dansmith: I'm glad you didn't. | 15:10 |
| *** litao__ has quit IRC | 15:10 | |
| *** felipemonteiro__ has joined #openstack-nova | 15:13 | |
| *** yangyapeng has joined #openstack-nova | 15:14 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Separate API schemas (usage) https://review.openstack.org/520603 | 15:15 |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899 | 15:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Separate API schemas (trait) https://review.openstack.org/520605 | 15:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Separate API schemas (aggregate) https://review.openstack.org/520608 | 15:16 |
| *** r-daneel has joined #openstack-nova | 15:16 | |
| dansmith | apparently I'm just replying to edleafe's emails today | 15:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for resource class API https://review.openstack.org/524506 | 15:16 |
| mriedem | sdague: bauzas: can you take a look at these ocata backports? https://review.openstack.org/#/q/topic:bug/1732947+status:open+branch:stable/ocata - holding up newton backports for the same changes which is holding up newton eol | 15:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Separate API schemas (inventory) https://review.openstack.org/520613 | 15:17 |
| bauzas | mriedem: roger, captain | 15:17 |
| mriedem | bauzas: sdague: and this ocata one https://review.openstack.org/#/c/526426/ | 15:17 |
| mriedem | same story | 15:17 |
| *** felipemonteiro__ has quit IRC | 15:17 | |
| mriedem | tonyb: i sent an email to the dev list about what i think needs to happen to get nova to newton-eol | 15:17 |
| *** yangyapeng has quit IRC | 15:18 | |
| jianghuaw_ | hi bauzas, need your help to look at this patch: https://review.openstack.org/#/c/516899/ | 15:19 |
| mriedem | tonyb: http://lists.openstack.org/pipermail/openstack-dev/2017-December/125592.html | 15:19 |
| *** itlinux has joined #openstack-nova | 15:19 | |
| *** itlinux has quit IRC | 15:22 | |
| *** amotoki has quit IRC | 15:22 | |
| lyarwood | mriedem: did we also want to fix https://review.openstack.org/#/c/526426/1 in newton? | 15:24 |
| *** felipemonteiro__ has joined #openstack-nova | 15:25 | |
| *** tosky has left #openstack-nova | 15:25 | |
| lyarwood | mriedem: ah nvm, you listed the stable/newton version in that query, ignore me | 15:25 |
| *** Alex_Staf has quit IRC | 15:26 | |
| *** felipemonteiro_ has joined #openstack-nova | 15:26 | |
| *** links has quit IRC | 15:26 | |
| * edleafe is happy to be the dansmith email lure | 15:28 | |
| cdent | shiny pretty edleafe | 15:29 |
| *** Sanatics has joined #openstack-nova | 15:29 | |
| *** felipemonteiro__ has quit IRC | 15:30 | |
| *** moshele has quit IRC | 15:30 | |
| mriedem | i did think about the impact to the deprecation policy this morning when i got up, glad dan mentioned that | 15:32 |
| mriedem | we will be supporting turds for longer, and hamstrung by said turds potentially | 15:32 |
| mriedem | i'm glad we said rocky is the target to drop nova-net and cellsv1 | 15:32 |
| cdent | the bits with "support both ways of doing this thing" have to stay around longer too, which is icky | 15:33 |
| cdent | but then again, apparently the style is something the ff-upgrade people don't like? | 15:34 |
| *** yangyapeng has joined #openstack-nova | 15:36 | |
| dansmith | mriedem: so my goal on that reqspec fix is to try to converse with bauzas about it today to make sure he's okay with it and/or there's not something huge we're missing on it | 15:39 |
| mriedem | ack | 15:39 |
| dansmith | mriedem: and then hand over the patch and backports to artom, who unfortunately is the recipient of many such turdish patches of mine right before I leave on vacay :P | 15:39 |
| artom | Seriously, I'm like dansmith's crap scapegaot | 15:40 |
| artom | Crapgoat | 15:40 |
| mriedem | dansmith: i'm personally not comfortable with that one going to newton right before we eol | 15:40 |
| dansmith | artom: as you will henceforth be known. | 15:40 |
| mriedem | i think the column alter is fine | 15:40 |
| mriedem | for newton | 15:40 |
| *** yangyapeng has quit IRC | 15:40 | |
| mriedem | i'm worried too much about reqspec/group side effects | 15:40 |
| dansmith | mriedem: well, I'd rather just not backport any of it to newton myself, | 15:40 |
| dansmith | mriedem: and don't really want to backport the migration at all, but that's fine | 15:41 |
| dansmith | we will, of course, but newton needs to go at some point | 15:41 |
| artom | I agree that the migration might have more side effects than the load by UUID patch | 15:41 |
| mriedem | i know but i love it so | 15:41 |
| artom | Er, less | 15:41 |
| dansmith | and this is something that has been this way since the release and which we've only _just_ heard about | 15:41 |
| artom | So if we're going to backport something, it might actually be safer to do just the migration | 15:41 |
| mriedem | yeah, because people are just now upgraded | 15:41 |
| mriedem | *upgrading | 15:41 |
| mriedem | well, people with big ass server groups apparently :) | 15:42 |
| artom | Also good point - there's like a 1-2 year lag between upstream and what's actually running | 15:42 |
| dansmith | well, there are definitely people already on newton and beyond, but I understand that reasoning | 15:42 |
| dansmith | mriedem: fwiw, there were only four such instances in a database of tens of thousands that were affected here | 15:43 |
| dansmith | mriedem: and it seemed like it was a very specific case, which might have been testing and/or a script run amok | 15:43 |
| dansmith | just for the data point | 15:43 |
| mriedem | ok | 15:43 |
| dansmith | the fact that we're crystallizing known-bad server groups in the database at creation time is almost more concerning to me than the overrun case | 15:44 |
| *** edand__ has quit IRC | 15:44 | |
| artom | Known-bad? | 15:44 |
| dansmith | artom: yeah, so we're capturing the server group (and specifically its members) at the time in which we create/write the reqspec for an instance | 15:46 |
| mriedem | i'm fully on board with fixing that | 15:46 |
| dansmith | so lets say you do this: nova boot --group foo; nova boot --group foo | 15:46 |
| artom | Ah, and some of those can get deleted, so we're left with a group with non existing members | 15:46 |
| dansmith | the first one has an InstanceGroup with .members=[justme] | 15:46 |
| dansmith | the second one is complete | 15:46 |
| dansmith | there is no reason we should be persisting that and then ever using it ever, but we are | 15:47 |
| dansmith | artom: either stale members, or incomplete, depending on when you snapshotted it | 15:47 |
| *** armax has joined #openstack-nova | 15:47 | |
| artom | I'm trying to think if anyone could be relying of this behaviour for whatever reason | 15:47 |
| artom | This is used in stuff like the group (anti)affinity filters, right? | 15:48 |
| cfriesen | dansmith: mriedem: for what it's worth, for reliability you have to update the server group members before rescheduling anyways, otherwise you're working off stale data | 15:48 |
| gibi | mriedem: could you check back to https://review.openstack.org/#/c/527444/ I start seeing the related bug appearing more and more on the gate | 15:48 |
| dansmith | cfriesen: right | 15:48 |
| mriedem | gibi: yeah | 15:49 |
| gibi | mriedem: thanks | 15:49 |
| * mriedem is watching the -tc chatter | 15:50 | |
| bauzas | dansmith: hola, what's the point about the request spec ? | 15:51 |
| artom | So are we coming to the consensus that we fix the stale group membership in master, but to play it safe only backport the db migration? | 15:51 |
| dansmith | bauzas: we're persisting InstanceGroup in RequestSpec with stale members for some reason.. why is that? | 15:51 |
| artom | Though I suppose it's conceivable the db migration might not fix stuff either, if mediumtext is too small still | 15:51 |
| dansmith | bauzas: this came because someone with a very large number of members in that group (at the time of that snapshot) can overrun a TEXT field | 15:52 |
| dansmith | artom: mediumtext is very large I think | 15:52 |
| dansmith | like 16mb or something | 15:52 |
| artom | Seriously? | 15:52 |
| dansmith | yup | 15:52 |
| artom | Wait, so if we migrate a DB with like, thousands of rows, we're adding how much space requirement? | 15:52 |
| artom | And how long will such a thing take? | 15:52 |
| dansmith | artom: hence me not wanting to do it unnecessarily :) | 15:53 |
| dansmith | we rewrite that whole table | 15:53 |
| bauzas | dansmith: mmmmm | 15:53 |
| bauzas | dansmith: AFAIK, we lazy-load the members group | 15:53 |
| bauzas | but I could be wrong | 15:53 |
| cfriesen | postgres has unlimited text fields. | 15:53 |
| dansmith | bauzas: no, we write them all into requestspec | 15:53 |
| artom | Yeha, so my SQL knowledge is fuzzy, but if we increase it to 16 MB we're essentially pre-allocating 16 MB for every row, correct? | 15:53 |
| dansmith | bauzas: and explode the database | 15:53 |
| dansmith | artom: yeah | 15:54 |
| dansmith | artom: which is why I'd rather fix the problem, because 64kb should be enough I think | 15:54 |
| bauzas | seriously? :( | 15:54 |
| dansmith | bauzas: https://review.openstack.org/#/c/527799/3 | 15:54 |
| bauzas | looking | 15:54 |
| *** yangyapeng has joined #openstack-nova | 15:56 | |
| cfriesen | dansmith: I'm seeing docs saying that text colums are stored separately from the row, so would it really preallocate 16MB for each row? | 15:56 |
| *** Sanatics has quit IRC | 15:56 | |
| cfriesen | (for mysql) | 15:56 |
| dansmith | cfriesen: oh? I didn't think that's how it worked | 15:57 |
| *** vivsoni__ has joined #openstack-nova | 15:57 | |
| *** Alex_Staf has joined #openstack-nova | 15:57 | |
| cfriesen | I'm *not* a mysql guy, so do your own research | 15:57 |
| artom | Where's Monty when you need him | 15:58 |
| dansmith | it doesn't matter that much anyway, as I think fixing the problem will fix the problem | 15:58 |
| dansmith | artom: jaypipes knows a thing or two :) | 15:58 |
| dansmith | it only adds fuel to the discussion though, we need to fix the real problem | 15:59 |
| artom | I think we're just afraid fixing the problem might create another one | 15:59 |
| artom | Like sending rebuild to the scheduler :) | 15:59 |
| cfriesen | dansmith: agreed...I don't see any reason to persist the group members at time of booting | 15:59 |
| dansmith | artom: well, that's why I want bauzas to look at it closely, but also, I think my fix is pretty straightforward | 16:00 |
| artom | dansmith, yeah | 16:00 |
| *** catintheroof has quit IRC | 16:00 | |
| cfriesen | artom: you need to check the group members right before scheduling. | 16:00 |
| dansmith | it didn't even require functional test change | 16:00 |
| *** catintheroof has joined #openstack-nova | 16:00 | |
| *** yangyapeng has quit IRC | 16:01 | |
| artom | I suppose there's no way for a request_spec to end up with an empty group in code that expects something there | 16:01 |
| mriedem | artom: umm | 16:01 |
| mriedem | it's request spec and groups and scheduler stuff, | 16:01 |
| artom | dansmith, you know objects better than I do, other than _from_db_object we don't generate it in any other way? | 16:01 |
| mriedem | there is totally a way to fuck this up | 16:01 |
| mriedem | w/o knowing it | 16:01 |
| artom | mriedem, oh I agree | 16:02 |
| artom | Which is why I'm thinking about it :) | 16:02 |
| bauzas | mriedem: dansmith: FWIW, just trying to look at earlier code | 16:02 |
| dansmith | mriedem: nobody asserted otherwise I don't think :) | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: SchedulerReportClient._get_providers_in_aggregates https://review.openstack.org/521097 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Traits ops on ProviderTree https://review.openstack.org/521605 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Aggregate ops on ProviderTree https://review.openstack.org/526216 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Move aggregates from report client to ProviderTree https://review.openstack.org/521685 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Track provider traits in report client https://review.openstack.org/521686 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Track associated sharing RPs in report client https://review.openstack.org/526539 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 16:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 16:02 |
| *** tidwellr has quit IRC | 16:02 | |
| mriedem | dansmith: maybe i misinterpreted "i think it basically boils down to (1) foundatoin doesn't want to pay or plan 2 ptgs, (2) people don't want to upgrade, or feel the pressure to upgrade, every 6 months and (3) people that are now going to multiple events (kubecon+) don't want to feel stretched" | 16:02 |
| mriedem | oops | 16:02 |
| mriedem | "artom: I suppose there's no way for a request_spec to end up with an empty group in code that expects something there" | 16:02 |
| artom | mriedem, yeah, "suppose" being the key word there ;) | 16:03 |
| artom | So, what if we move the loading by uuid into instance group? | 16:03 |
| artom | That way there's definitely no way to end up with an empty one | 16:03 |
| dansmith | mriedem: I think that just meant group and members is not always present, can be null, nothing is depending on that being set to something specific that we might mess up | 16:03 |
| dansmith | which is true I think | 16:03 |
| *** alee has joined #openstack-nova | 16:03 | |
| bauzas | dansmith: oh shit, 'members' is not lazy-loadable, 'hosts' is | 16:03 |
| artom | dansmith, yep, you understood that | 16:03 |
| bauzas | hence my confusion | 16:04 |
| *** alee has left #openstack-nova | 16:04 | |
| bauzas | dansmith: and since we persist the group object in the DB, yeah I understand the issue | 16:04 |
| * bauzas facepalms | 16:04 | |
| dansmith | artom: well, not sure what that matters, since you didn't snip it out before we wrote it into reqspec anyway | 16:04 |
| dansmith | but yeah | 16:04 |
| dansmith | er | 16:04 |
| dansmith | that was for bauzas: | 16:04 |
| * dansmith is watching too many convos | 16:04 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540 | 16:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 16:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | 16:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 16:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 16:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 16:05 |
| *** catintheroof has quit IRC | 16:05 | |
| artom | dansmith, so what if we move the loading by uuid down to instance_group? That way we make sure we can never be in a situation with empty members in code that expects them... | 16:06 |
| artom | Right? | 16:06 |
| dansmith | artom: meaning make it lazy-loadable? | 16:06 |
| artom | dansmith, would it make it lazy-loadable? Not necessarily... | 16:07 |
| artom | Actually | 16:07 |
| artom | Yeah it would | 16:07 |
| *** jdillaman has joined #openstack-nova | 16:07 | |
| dansmith | artom: so that won't work if we end up lazy-loading on the compute, because it'll be in a cell and can't get that info later | 16:08 |
| dansmith | artom: we need to pre-load it | 16:08 |
| dansmith | which is kinda the point of reqspec: to pass along everything the stuff downstream needs in order to move the instance | 16:08 |
| *** klindgren has joined #openstack-nova | 16:08 | |
| artom | Oh right, cells | 16:09 |
| cfriesen | dansmith: would your proposed change to update the instance_group when reading the request spec from DB cover the live-migration case as well? We had a local bugfix to cover that case as part of various affinity/antiaffinity race fixes that haven't made it upstream. | 16:10 |
| dansmith | cfriesen: if I know what you're asking, then it should yeah | 16:10 |
| dansmith | cfriesen: when we load the reqspec in the api before kicking off the live migration, it will have a fresh and accurate set of group members passed down to anything that gets the reqspec in the process | 16:11 |
| *** gbarros has quit IRC | 16:11 | |
| cfriesen | dansmith: I'm looking at _find_destination() in live_migrate.py. It calls request_spec = self._get_request_spec_for_select_destinations() | 16:12 |
| cfriesen | dansmith: okay, so looks like that request spec is normally pulled from the DB in compute.api.API.live_migrate(), so we should be good. | 16:15 |
| dansmith | cfriesen: it kinda has to be since it's in the api db | 16:16 |
| *** yangyapeng has joined #openstack-nova | 16:17 | |
| bauzas | dansmith: +2 on the fix | 16:17 |
| artom | Semi-related thought | 16:18 |
| artom | Will the code actually fix existing cases? | 16:18 |
| dansmith | artom: it will, because: | 16:19 |
| bauzas | artom: you mean upstream bugs :p | 16:19 |
| artom | Ah, yeah, it sets members to None when saving | 16:19 |
| dansmith | artom: if you are under the limit now, then you are good.. if you're over, this will make you fit now | 16:19 |
| artom | bauzas, no, I meant our downstream bug | 16:19 |
| bauzas | exactly | 16:19 |
| dansmith | artom: and, the api will immediately stop reading the stale group after this fix, for reqspecs with stale data from before the fix | 16:19 |
| bauzas | artom: I do understand but we're upstream :) | 16:19 |
| * bauzas is schizophrenic | 16:19 | |
| artom | bauzas, well, yes, but it's still relevant to talk about whether we're actually fixing the existing problem, or just preventing it in the future | 16:20 |
| bauzas | it'll pull fresh data indeed | 16:20 |
| dansmith | that's why I did it that way | 16:20 |
| jaypipes | cfriesen, artom: TEXT/MEDIUMTEXT/VARCHAR fields are only pre-allocated at full size when the field is used in a GROUP BY or ORDER BY expression. Otherwise, only a pointer to the data in the data file is used during the projection phase of the SELECT expression (when the rows are actually sent to the client) | 16:20 |
| dansmith | because we have to account for all the broken data in the db now | 16:20 |
| jaypipes | cfriesen, artom: this is for MySQL, not PostgreSQL | 16:21 |
| bauzas | dansmith: and you did it the right way, thanks :) | 16:21 |
| dansmith | jaypipes: we're talking about allocation on disk, not memory | 16:21 |
| *** yangyapeng has quit IRC | 16:21 | |
| *** itlinux has joined #openstack-nova | 16:21 | |
| dansmith | jaypipes: like whether 1 byte in a MEDIUMTEXT takes up 16mb on disk | 16:21 |
| *** klindgren has quit IRC | 16:21 | |
| jaypipes | dansmith: there's almost no difference between a TEXT, MEDIUMTEXT or VARCHAR(8000) w.r.t. on-disk storage requirements or layout. | 16:22 |
| jaypipes | dansmith: for InnoDB that is. | 16:22 |
| bauzas | dansmith: FWIW, I fixed the problem way in the past for hosts https://github.com/openstack/nova/commit/c48c1098cbcd7a9c7980d5fbe4668c38b16767f5 | 16:22 |
| dansmith | jaypipes: okay | 16:22 |
| bauzas | dansmith: but I didn't thought it would be a huge problem for members, given not a lot of operators use a long list of them | 16:22 |
| jaypipes | dansmith: no, for all those field types, InnoDB stores a small amount of data in the data page itself and makes room (when needed) in separate extents by providing a pointer to that extent/page from the main data page. | 16:23 |
| jaypipes | dansmith: the only thing that can be performance-wise a bad thing is if the size of those fields changes often (which isn't the case for these fields in Nova's DB) | 16:23 |
| artom | So for MySQL/InnoDB a migration to mediumtext would actually make sense... | 16:23 |
| jaypipes | artom: for InnoDB, yes. for NDB, no... | 16:23 |
| jaypipes | artom: but that's a different problem entirely :) | 16:24 |
| artom | Do we support NDB? | 16:24 |
| jaypipes | artom: what is the current column type for this field you're talking about? | 16:24 |
| bauzas | mriedem: jaypipes: https://review.openstack.org/#/c/527799/ looks legit to me | 16:24 |
| dansmith | jaypipes: and what is the cost of resizing to medium from text? | 16:24 |
| jaypipes | dansmith: virtually zero. | 16:25 |
| artom | jaypipes, dansmith answered that for me | 16:25 |
| dansmith | jaypipes: awesome, then we should do that too | 16:25 |
| dansmith | artom, mriedem ^ | 16:25 |
| dansmith | still need the real fix, but sounds like a backport is too good to pass up | 16:25 |
| dansmith | of the migration I mean | 16:25 |
| artom | dansmith, that assumes we only support InnoDB | 16:25 |
| jaypipes | dansmith: I don't recommend mediumtext anyway. just set it to TEXT | 16:25 |
| dansmith | jaypipes: text isn't big enough | 16:25 |
| artom | Which... is it the case? | 16:25 |
| artom | Surely some people are running Galera | 16:26 |
| dansmith | artom: I think everyone would be running innodb in prod, AFAIK | 16:26 |
| jaypipes | dansmith: TEXT > MEDIUMTEXT | 16:26 |
| dansmith | jaypipes: um I don't think so | 16:26 |
| jaypipes | sorry, yeah... | 16:26 |
| dansmith | https://stackoverflow.com/questions/13932750/tinytext-text-mediumtext-and-longtext-maximum-storage-sizes | 16:26 |
| jaypipes | was thinking LONGTEXT | 16:26 |
| bauzas | yeah LONGTEXT no ? | 16:27 |
| artom | Oh, Galera uses InnoDB | 16:27 |
| bauzas | TEXT to LONGTEXT I mean | 16:27 |
| jaypipes | dansmith, artom: what is the specific field we are talking about here? | 16:28 |
| mriedem | dansmith: jaypipes: cool - thanks | 16:28 |
| jaypipes | dansmith: is this metadata value? | 16:28 |
| * mriedem is in 4 places at once | 16:28 | |
| *** kumarmn has joined #openstack-nova | 16:28 | |
| dansmith | jaypipes: request_specs.spec | 16:28 |
| jaypipes | hmm. | 16:28 |
| dansmith | jaypipes: it's a text we serialize the object into, and because we store instance_group.members, which can be huge, | 16:28 |
| artom | Err, instance_group surely? | 16:28 |
| dansmith | we can generate more than 64kb of data | 16:28 |
| *** itlinux has quit IRC | 16:28 | |
| dansmith | artom: instance_group is in the spec | 16:28 |
| bauzas | we serialize all at a whole | 16:29 |
| artom | Ah, doh | 16:29 |
| jaypipes | dansmith: k. then I'd recommend changing it to MEDIUMTEXT from TEXT. | 16:29 |
| dansmith | jaypipes: that's what we're doing :) | 16:29 |
| jaypipes | dansmith: ok, sorry for interrupting then :) | 16:29 |
| dansmith | jaypipes: waaaaayyyy ahead of you bro | 16:29 |
| dansmith | jaypipes: and when I say "we" I mean "artom" | 16:29 |
| jaypipes | k | 16:29 |
| artom | I, wha? | 16:30 |
| jaypipes | yet another reason why storing denormalized data in a TEXT-y field is a bad idea... | 16:30 |
| artom | I've barely had breakfast and it's 11:30, I'm not ahead of anything | 16:30 |
| openstackgerrit | Merged openstack/nova master: Fix the bug report link of API Guide https://review.openstack.org/527660 | 16:30 |
| *** gyee has joined #openstack-nova | 16:30 | |
| dansmith | jaypipes: well, it has its place, IMHO, and the complexity required to store a reqspec normalized is not worth it since it's a snapshot | 16:32 |
| bauzas | I remember we had a thought on that with alaski | 16:32 |
| dansmith | reqspec is an archive snapshot really, which is fine for this, we just need to not snapshot an infinite amount of stale data into it ;) | 16:33 |
| bauzas | and we said it was better to just store the whole object so we would totally decouple what we store from what we expose | 16:33 |
| bauzas | dansmith: yeah, I still agree on it tbc | 16:33 |
| jaypipes | dansmith: +W'd that patch | 16:34 |
| bauzas | we just expose the instance UUID for querying reasons that's it | 16:34 |
| dansmith | jaypipes: thanks | 16:34 |
| bauzas | dansmith: is there another patch related to that about a DB schema modification ? | 16:34 |
| dansmith | jaypipes: and thanks for being my fleshy mysql manual :P | 16:34 |
| dansmith | bauzas: young artom will be presenting it forthwith | 16:34 |
| bauzas | cool | 16:35 |
| jaypipes | dansmith: sounds kinky. | 16:35 |
| *** hoonetorg has quit IRC | 16:35 | |
| bauzas | oh man, I wish I could "OK jaypipes" on my phone | 16:35 |
| * dansmith makes bedroom eyes at jaypipes | 16:35 | |
| jaypipes | lol | 16:35 |
| artom | jaypipes, you got off easy, I'm his young turdgoat | 16:35 |
| cdent | "fleshy mysql manual" is way too visual | 16:35 |
| jaypipes | artom: yes, I read that. very flattering indeed. ;) | 16:35 |
| dansmith | cdent: you're welcome | 16:35 |
| cdent | clears my head nicely, thank you dansmith | 16:35 |
| *** Apoorva has joined #openstack-nova | 16:36 | |
| *** Alex_Staf has quit IRC | 16:37 | |
| artom | dansmith, so I'll handle the backports - who's proposing the DB migration? | 16:37 |
| *** yangyapeng has joined #openstack-nova | 16:37 | |
| dansmith | artom: you are | 16:38 |
| artom | Or are we satisfied that the code alone is enough? | 16:38 |
| dansmith | I mean, I can do the migration if you really don't want to, but.. figured you'd want all the glory and praise that will come with it | 16:38 |
| artom | If I want glory and praise I'll become a murderous dictator | 16:39 |
| mriedem | artom: there is a db migratoin for extending the size of build_requests.instance | 16:39 |
| mriedem | artom: just copy ^ | 16:39 |
| mriedem | super easy | 16:39 |
| mriedem | exact same issue | 16:39 |
| dansmith | artom: an important point on the resume of a murderous dictator is "did a schema migration once" | 16:39 |
| *** moshele has joined #openstack-nova | 16:39 | |
| artom | For now I just want to revel turdgoatery | 16:39 |
| mriedem | ffs you should probably give me co-author now because i even told you | 16:39 |
| artom | What's the magic word? | 16:40 |
| mriedem | trump | 16:40 |
| artom | Do we support pgsql as well? | 16:41 |
| *** yangyapeng has quit IRC | 16:41 | |
| artom | I remember there was a whole thing about dropping it from the gate a while back | 16:42 |
| bauzas | I'm a 20% time person this week, funny | 16:42 |
| *** andreas_s has joined #openstack-nova | 16:42 | |
| *** chyka has joined #openstack-nova | 16:43 | |
| dansmith | artom: we don't anymore | 16:43 |
| dansmith | artom: and if you could figure out some way to break pgsql in this process, I'd sure appreciate it | 16:43 |
| dansmith | if for no other reason than just to cause pain for that smug cfriesen guy | 16:43 |
| bauzas | artom: we are not gating pgsql, hence not supporting it | 16:44 |
| bauzas | I don't know if other projects still gate pg, but we very made it clear that pg is not supported anyway in nova | 16:44 |
| *** yamahata has joined #openstack-nova | 16:44 | |
| *** yamamoto has joined #openstack-nova | 16:46 | |
| *** andreas_s has quit IRC | 16:47 | |
| *** _ix has joined #openstack-nova | 16:47 | |
| *** hoonetorg has joined #openstack-nova | 16:48 | |
| *** tbachman has quit IRC | 16:49 | |
| *** slaweq has joined #openstack-nova | 16:51 | |
| *** slaweq has left #openstack-nova | 16:51 | |
| *** edand__ has joined #openstack-nova | 16:51 | |
| *** tssurya has quit IRC | 16:52 | |
| *** kumarmn_ has joined #openstack-nova | 16:53 | |
| *** yamamoto has quit IRC | 16:54 | |
| *** kumarmn has quit IRC | 16:56 | |
| *** xnox has joined #openstack-nova | 16:57 | |
| xnox | Hello! | 16:57 |
| xnox | is there nova quota for CPU cores.... per-arch/per-machinetype? | 16:57 |
| *** yangyapeng has joined #openstack-nova | 16:58 | |
| *** derekh has quit IRC | 16:58 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document PCI NUMA affinity policy https://review.openstack.org/528011 | 16:58 |
| *** sshwarts has quit IRC | 16:59 | |
| *** klindgren has joined #openstack-nova | 16:59 | |
| jaypipes | xnox: no. quota is for VCPU, that's it. | 17:00 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Make request_spec.spec MediumText https://review.openstack.org/528012 | 17:00 |
| artom | mriedem, ^^ there you go | 17:00 |
| mriedem | artom: dansmith: yes we support postgres | 17:01 |
| dansmith | mriedem: we don't test it right? | 17:01 |
| *** tbachman has joined #openstack-nova | 17:01 | |
| mriedem | we don't actively gate on it, we have an experimental job that runs it, | 17:01 |
| xnox | jaypipes, ack, thanks. | 17:01 |
| dansmith | oh I didn't realize we still had that | 17:01 |
| mriedem | but i consider support == if we break it and there is a patch, we don't block it | 17:01 |
| dansmith | meh | 17:01 |
| mriedem | ffs we don't gate on ceph either | 17:01 |
| *** klindgren has quit IRC | 17:01 | |
| dansmith | I call that not supporting it | 17:01 |
| mriedem | so i guess we don't support ceph | 17:01 |
| *** xyang1 has quit IRC | 17:01 | |
| stephenfin | bauzas: Added the docs promised for the PCI NUMA policy https://review.openstack.org/528011 | 17:02 |
| stephenfin | Going to add user docs shortly | 17:02 |
| stephenfin | Though I really should do the real-time ones first. I've them only in blog form right now | 17:02 |
| artom | And I totally forgot tests, didn't I/ | 17:02 |
| *** yangyapeng has quit IRC | 17:03 | |
| artom | And a lot of other stuff, actually:( | 17:03 |
| *** penick has joined #openstack-nova | 17:04 | |
| bauzas | stephenfin: well, the biggest concern I had was indeed https://review.openstack.org/#/c/527472/3/nova/virt/hardware.py@1198 | 17:05 |
| bauzas | I know we already do this | 17:05 |
| bauzas | but looks like an operator pain | 17:05 |
| bauzas | honestly, I need to look at the spec's comments | 17:06 |
| *** edmondsw has quit IRC | 17:06 | |
| stephenfin | If we fix that though, isn't it something we should fix in one fell swoop? | 17:06 |
| stephenfin | i.e. all potential conflicts should throw that the same kind of warning | 17:06 |
| stephenfin | *throw the | 17:06 |
| *** edmondsw has joined #openstack-nova | 17:06 | |
| stephenfin | Yeah, spec discussion would probably be best. /me goes to find relevant comments | 17:06 |
| *** tidwellr has joined #openstack-nova | 17:07 | |
| bauzas | stephenfin: I just found those https://review.openstack.org/#/c/361140/6..7/specs/ocata/approved/share-pci-between-numa-nodes.rst | 17:10 |
| *** fragatin_ has joined #openstack-nova | 17:10 | |
| *** edmondsw_ has joined #openstack-nova | 17:10 | |
| bauzas | stephenfin: oops https://review.openstack.org/#/c/361140/6/specs/ocata/approved/share-pci-between-numa-nodes.rst@69 | 17:10 |
| bauzas | honestly, we're late in the cycle so your concern is valid | 17:10 |
| bauzas | but I do feel it's a PITA for operators | 17:11 |
| stephenfin | bauzas: That's the one. There's also this discussion on the need for both flavor extra spec and image metadata https://review.openstack.org/#/c/361140/19/specs/pike/approved/share-pci-between-numa-nodes.rst@59 | 17:11 |
| *** edmondsw has quit IRC | 17:11 | |
| stephenfin | )note that I mixed up the use of flavors extra specs vs image metadata - it's *operators* that would set the former and not user) | 17:11 |
| stephenfin | bauzas: Would a TODO to resolve that in a future effort be reasonable? I'm pretty sure I can revive the spec I talked about | 17:12 |
| bauzas | stephenfin: well, PS19 convo is strictier than the one I found | 17:12 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505 | 17:12 |
| bauzas | stephenfin: it's more about whether we need to use image metadata | 17:12 |
| stephenfin | Indeed. Different argument but in a similar area | 17:12 |
| bauzas | here, I still think it's understandable to do such things because users need a way to ask for a policy | 17:12 |
| stephenfin | Here's the spec I was talking about https://review.openstack.org/#/c/382382/ | 17:12 |
| stephenfin | We can use that determine what we want to do going forward | 17:13 |
| bauzas | stephenfin: documenting the flaws of using flavor metadata for such things is indeed a necessary thing to do | 17:13 |
| bauzas | I'd recommend operators to *not* use flavor metadata if they don't know their users | 17:14 |
| *** lpetrut has quit IRC | 17:14 | |
| *** edmondsw_ has quit IRC | 17:14 | |
| stephenfin | I'd also like to use something like JSONSchema (though maybe not that) to validate flavour extra specs and determine what things can't be used together | 17:14 |
| stephenfin | ...with exceptions for custom flavour properties | 17:15 |
| bauzas | in my mind, flavors take precedence over images | 17:15 |
| bauzas | because they are admin-driven | 17:15 |
| bauzas | so, your call, man | 17:15 |
| stephenfin | bauzas: Aye, that's how I see them too | 17:15 |
| stephenfin | But I don't want a user to think "I've got a strictly-pinned NUMA device" when they actually don't | 17:16 |
| stephenfin | cos the operator set the policy to 'preferred' | 17:16 |
| bauzas | right | 17:16 |
| stephenfin | for resource usage reasons or whatever | 17:16 |
| bauzas | but users won't know anyway | 17:16 |
| stephenfin | They won't? | 17:17 |
| bauzas | how could they ? | 17:17 |
| openstackgerrit | Merged openstack/nova master: Fix disk size during live migration with disk over-commit https://review.openstack.org/524681 | 17:17 |
| openstackgerrit | Merged openstack/nova stable/ocata: Only query BDMs once in API during rebuild https://review.openstack.org/525665 | 17:17 |
| bauzas | do we expose the topology to the users ? hell no, of course | 17:17 |
| * stephenfin assumed Forbidden-class exceptions would get bubbled up via the API | 17:17 | |
| bauzas | ah, that | 17:17 |
| *** alex_xu has quit IRC | 17:17 | |
| bauzas | well, two cases, and that requires looking at code | 17:18 |
| *** alex_xu has joined #openstack-nova | 17:18 | |
| bauzas | #1 either we fail and we reschedule to another host | 17:18 |
| bauzas | which could eventually fail too | 17:18 |
| bauzas | #2 or we make it full stop | 17:18 |
| bauzas | and then we error out | 17:18 |
| bauzas | either way, the user experience isn't terrible | 17:18 |
| stephenfin | Oh, actually, #1 would actually happen | 17:18 |
| *** yangyapeng has joined #openstack-nova | 17:18 | |
| stephenfin | because the NUMATopologyFilter (eventually) calls those functions | 17:19 |
| bauzas | isn't that called by the compute service? | 17:19 |
| stephenfin | That too, yes | 17:19 |
| stephenfin | It's this call | 17:19 |
| stephenfin | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/numa_topology_filter.py#L94-L98 | 17:20 |
| bauzas | man, I got 3 days of legal and accouting training, but I don't know what hurts more : that or discussing PCI scheduling | 17:20 |
| stephenfin | Hahaha | 17:20 |
| mriedem | jaypipes: is an alter statement on a column type change idempotent? https://review.openstack.org/#/c/528012/1/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/051_request_spec_spec_mediumtext.py | 17:21 |
| mriedem | if it's already that type? | 17:21 |
| stephenfin | Don't worry - jaypipes and co are going to save us with nested-rps | 17:21 |
| stephenfin | And if they don't - guaranteed job security :P | 17:21 |
| bauzas | having a job security doesn't mean brain sanity | 17:21 |
| mriedem | gd 11:30 already | 17:22 |
| bauzas | 11:22 technically | 17:22 |
| mriedem | not in minnesota | 17:22 |
| *** edmondsw has joined #openstack-nova | 17:22 | |
| *** AlexeyAbashkin has quit IRC | 17:23 | |
| bauzas | Minnesota is that better from other states that it saves 8 mins for every worker ? | 17:23 |
| stephenfin | bauzas: But yeah, that call ends up here https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1436 | 17:23 |
| mriedem | bauzas: it is; that's why our taxes are high | 17:23 |
| bauzas | mriedem: I'm sure we beat your state | 17:24 |
| *** yangyapeng has quit IRC | 17:24 | |
| stephenfin | which then calls in here, where we _eventually_ raise the exception https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1513 | 17:24 |
| mriedem | bauzas: sure, but, | 17:24 |
| mriedem | we don't get 50% of the month off for PTO :P | 17:24 |
| bauzas | jeez | 17:25 |
| bauzas | touché | 17:25 |
| *** edmondsw has quit IRC | 17:25 | |
| bauzas | stephenfin: so, give me a sec to rephrase that | 17:25 |
| bauzas | stephenfin: you mean that the policy check will be done primarly by the scheduler then ? | 17:26 |
| bauzas | I need to rereview then the implications | 17:26 |
| stephenfin | It'll be done twice - once by the scheduler and once when we're booting | 17:26 |
| stephenfin | Because races are possible | 17:26 |
| bauzas | yeah, but totally not at the same time :) | 17:26 |
| stephenfin | Indeed :) | 17:26 |
| *** baoli has quit IRC | 17:27 | |
| stephenfin | So, per above, what a user will see is a failure to find suitable hosts | 17:27 |
| bauzas | so, say we raise an exception, all of that stuff if called by the filter, right? | 17:27 |
| bauzas | s/if/is | 17:27 |
| stephenfin | All of what stuff? | 17:27 |
| bauzas | stephenfin: https://review.openstack.org/#/c/527472/4/nova/virt/hardware.py@1197 is called eventually by the filter ? | 17:28 |
| stephenfin | Yes | 17:28 |
| stephenfin | Ditto for https://review.openstack.org/#/c/527472/4/nova/virt/hardware.py@1184 | 17:29 |
| *** klindgren has joined #openstack-nova | 17:29 | |
| *** damien_r has quit IRC | 17:29 | |
| bauzas | stephenfin: so that worst than a reschedule | 17:29 |
| bauzas | that's | 17:29 |
| *** klindgren has quit IRC | 17:29 | |
| bauzas | stephenfin: if the filter raises an exception, the whole scheduling process fails | 17:30 |
| bauzas | I need to test that, but I'm pretty it goes into ERROR/scheduling | 17:30 |
| bauzas | oh man, fat fingers | 17:30 |
| *** fragatin_ has quit IRC | 17:31 | |
| vivsoni__ | mriedem: Hi | 17:31 |
| stephenfin | bauzas: Ack. I'm going to test it now myself with CPU policies | 17:32 |
| bauzas | stephenfin: I need to bail out, family duty | 17:32 |
| bauzas | ++ | 17:32 |
| stephenfin | A-ok. I'm gone tomorrow but I'll be around Monday if you've questions | 17:33 |
| *** mdnadeem has quit IRC | 17:33 | |
| mriedem | vivsoni__: hi | 17:33 |
| bauzas | stephenfin: drop me a note about your findings and if that's not a full scheduling break, then +2 on the last PS | 17:34 |
| stephenfin | bauzas: Spot on. Enjoy family time :) | 17:34 |
| bauzas | if that's a full scheduling stop then I'm pretty -1 on the existing | 17:34 |
| bauzas | or make the filter resilient to errors | 17:34 |
| vivsoni__ | mriedem: Need your input in resolving tempest Test case "tempest.api.compute.volumes.test_attach_volume.AttachVolumeShelveTestJSON.test_detach_volume_shelved_or_offload_server" | 17:35 |
| *** lucasagomes is now known as lucas-afk | 17:35 | |
| vivsoni__ | hpe ci is failing because of that | 17:35 |
| *** tidwellr has quit IRC | 17:36 | |
| *** Apoorva has quit IRC | 17:36 | |
| openstackgerrit | Ade Lee proposed openstack/nova master: Add flag to make glance image verification optional https://review.openstack.org/528017 | 17:37 |
| *** dtruong has joined #openstack-nova | 17:37 | |
| *** mdbooth has quit IRC | 17:37 | |
| *** ansiwen has quit IRC | 17:37 | |
| *** baoli has joined #openstack-nova | 17:38 | |
| vivsoni__ | mriedem: In this TC 'connector', which is passed to cinder vendor driver's 'initialize_connection' & 'terminate_connection' is empty | 17:39 |
| *** edmondsw has joined #openstack-nova | 17:40 | |
| *** mdbooth has joined #openstack-nova | 17:40 | |
| *** ansiwen has joined #openstack-nova | 17:41 | |
| vivsoni__ | basically the driver's 'def initialize_connection' is not called, when 'attach_volume' is called https://github.com/openstack/tempest/blob/master/tempest/api/compute/volumes/test_attach_volume.py#L252 | 17:43 |
| *** felipemonteiro_ has quit IRC | 17:43 | |
| vivsoni__ | its failing here https://github.com/openstack/tempest/blob/master/tempest/api/compute/volumes/test_attach_volume.py#L253 | 17:43 |
| *** klindgren has joined #openstack-nova | 17:44 | |
| *** logan- has quit IRC | 17:44 | |
| *** logan- has joined #openstack-nova | 17:45 | |
| mriedem | vivsoni__: that's because nova doesn't call initialize_connection anymore | 17:46 |
| mriedem | it calls attachment_update | 17:46 |
| vivsoni__ | this detach_volume(), internally calls to 'def terminate_connection()' of cinder driver's and failed when tries to get connector['host'] | 17:47 |
| mriedem | vivsoni__: this would be easier if you could point me at CI job logs | 17:48 |
| mriedem | with an actual failure | 17:48 |
| mriedem | i am woefully behind on my todo list for today | 17:48 |
| openstackgerrit | Merged openstack/nova stable/ocata: Get original image_id from volume for volume-backed instance rebuild https://review.openstack.org/525666 | 17:49 |
| *** sree has quit IRC | 17:49 | |
| *** artom has quit IRC | 17:50 | |
| vivsoni__ | mriedem: request you to please have a look at http://54.201.44.218/38/527338/2/check/3par-fc-driver-master-client-pip-c8k01-dsvm/c156eb1/ | 17:50 |
| *** moshele has quit IRC | 17:50 | |
| *** artom has joined #openstack-nova | 17:51 | |
| *** jmlowe has quit IRC | 17:51 | |
| *** sree has joined #openstack-nova | 17:52 | |
| *** edmondsw has quit IRC | 17:53 | |
| mriedem | vivsoni__: ok so it's attaching a volume to a shelved offloaded server, | 17:53 |
| mriedem | so there is no host connector because there is no compute host for that server, | 17:53 |
| mriedem | and then the test detaches the volume while the server is still shelved offloaded | 17:53 |
| mriedem | and that's where it breaks right? | 17:53 |
| *** tesseract has quit IRC | 17:53 | |
| vivsoni__ | mriedem: yes | 17:53 |
| mriedem | ok that's right here v | 17:54 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1994 | 17:54 |
| mriedem | that's the new call to cinder in this case | 17:54 |
| *** edand__ has quit IRC | 17:54 | |
| vivsoni__ | basically volume is not attach and tries to detaches and failed | 17:54 |
| *** edmondsw has joined #openstack-nova | 17:54 | |
| openstackgerrit | Merged openstack/nova stable/newton: Add regression test for rebuilding a volume-backed server https://review.openstack.org/526542 | 17:54 |
| mriedem | vivsoni__: i'm not sure why this would be any different from a nova perspective - when attaching a volume to a shelved offloaded server, not never calls os-initialize_connection | 17:55 |
| mriedem | *nova never calls | 17:55 |
| mriedem | vivsoni__: so the explosion is likely on the cinder side | 17:55 |
| *** xyang1 has joined #openstack-nova | 17:55 | |
| mriedem | i.e. attachment_delete in cinder is assuming there will be a connector, and there isn't | 17:55 |
| *** READ10 has joined #openstack-nova | 17:56 | |
| *** catintheroof has joined #openstack-nova | 17:57 | |
| mriedem | vivsoni__: where is the error in the c-vol logs? http://54.201.44.218/38/527338/2/check/3par-fc-driver-master-client-pip-c8k01-dsvm/c156eb1/logs/screen-c-vol.txt.gz | 17:57 |
| mriedem | ah here http://paste.openstack.org/show/628980/ | 17:58 |
| *** Alex_Staf has joined #openstack-nova | 17:58 | |
| mriedem | vivsoni__: open a cinder bug | 17:58 |
| smcginnis | vivsoni__: That's a bug in the driver. It should handle that. | 17:59 |
| *** andreas_s has joined #openstack-nova | 17:59 | |
| mriedem | it's confusing how that ever worked | 17:59 |
| *** xyang1 has quit IRC | 17:59 | |
| melwitt | looks like nova.tests.functional.notification_sample_tests.test_instance.TestInstanceNotificationSampleWithMultipleComputeOldAttachFlow is failing intermittently in the gate | 18:00 |
| mriedem | smcginnis: vivsoni_: oh i see | 18:00 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2004 | 18:00 |
| mriedem | in the old flow, if we didn't have a connector, we just didn't call terminate_connection | 18:00 |
| mriedem | melwitt: ok | 18:00 |
| *** dtantsur is now known as dtantsur|afk | 18:01 | |
| mriedem | smcginnis: which means other drivers could blow up | 18:02 |
| mriedem | smcginnis: i'm thinking the volume manager's attachment_delete shouldn't call the driver if there is no connector | 18:02 |
| *** sree has quit IRC | 18:02 | |
| *** klindgren has quit IRC | 18:03 | |
| *** Apoorva has joined #openstack-nova | 18:03 | |
| vivsoni__ | mriedem, smcginnis: many 3dr paty CI has skipped those TCs | 18:03 |
| *** Apoorva has quit IRC | 18:03 | |
| mriedem | ok so i'll push a fix quick | 18:03 |
| *** Swami has joined #openstack-nova | 18:03 | |
| *** Apoorva has joined #openstack-nova | 18:03 | |
| mriedem | vivsoni__: do you have a bug number? | 18:03 |
| vivsoni__ | mriedem: No... not sure whether there is a bug raised | 18:04 |
| *** andreas_s has quit IRC | 18:04 | |
| mriedem | vivsoni__: ok, can you open a cinder bug then? | 18:04 |
| vivsoni__ | sure | 18:04 |
| *** yamamoto has joined #openstack-nova | 18:05 | |
| vivsoni__ | please give a min.. will raised and let you know in a min or two | 18:05 |
| smcginnis | We had discussed this in Cinder several months back. If there are any drivers that are not handling not having a connector, a bug should be filed against those drivers. | 18:05 |
| smcginnis | But most (maybe some) should be handling it correctly. | 18:05 |
| *** penick has quit IRC | 18:06 | |
| *** yamahata has quit IRC | 18:06 | |
| *** sree has joined #openstack-nova | 18:07 | |
| melwitt | I notice a lot of tracing of ComputeHostNotFound in gate n-cpu logs too | 18:07 |
| *** penick has joined #openstack-nova | 18:08 | |
| *** klindgren has joined #openstack-nova | 18:09 | |
| mriedem | melwitt: that's been around for a long time, on startup | 18:09 |
| mriedem | since ocata | 18:09 |
| mriedem | happens when n-cpu starts before the host is discovered i think | 18:09 |
| *** klindgren has quit IRC | 18:10 | |
| melwitt | oh. I thought it used to be a warning but not a backtrace | 18:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Make request_spec.spec MediumText https://review.openstack.org/528012 | 18:10 |
| mriedem | it's a warning + traceback | 18:11 |
| mriedem | because of an oslo.log bug | 18:11 |
| mriedem | see my failed attempts https://review.openstack.org/#/c/517102/ | 18:11 |
| *** sree has quit IRC | 18:11 | |
| * melwitt examines | 18:13 | |
| * mriedem hopes some geddy lee can turn this day around | 18:13 | |
| *** klindgren has joined #openstack-nova | 18:13 | |
| melwitt | looking at the oslo.log patch and trying to figure out, is the fix obvious or not -_- | 18:14 |
| *** edmondsw has quit IRC | 18:14 | |
| *** baoli has quit IRC | 18:14 | |
| vivsoni__ | mriedem: https://bugs.launchpad.net/cinder/+bug/1738254 | 18:15 |
| openstack | Launchpad bug 1738254 in Cinder "TEMPEST test case failed "tempest.api.compute.volumes.test_attach_volume.AttachVolumeShelveTestJSON.test_detach_volume_shelved_or_offload_server"" [Undecided,New] | 18:15 |
| vivsoni__ | mriedem: i have raised a cinder bug against that tempest failure | 18:15 |
| *** jpena is now known as jpena|off | 18:16 | |
| *** baoli has joined #openstack-nova | 18:16 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add PCI NUMA policies https://review.openstack.org/527472 | 18:17 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Modify signature of _filter_non_requested_pfs https://review.openstack.org/527473 | 18:17 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document PCI NUMA affinity policy https://review.openstack.org/528011 | 18:17 |
| melwitt | I think I can propose something | 18:17 |
| stephenfin | bauzas: For when you're back online, that image-flavor conflict exception gets bubbled all the way back to the user's terminal via a HTTP 400. I think we're good | 18:18 |
| *** mingyu has quit IRC | 18:20 | |
| *** mingyu has joined #openstack-nova | 18:21 | |
| *** edmondsw has joined #openstack-nova | 18:21 | |
| *** huanxie has quit IRC | 18:23 | |
| *** sambetts is now known as sambetts|afk | 18:23 | |
| *** gouthamr has quit IRC | 18:24 | |
| *** mingyu has quit IRC | 18:25 | |
| *** edmondsw has quit IRC | 18:25 | |
| *** itlinux has joined #openstack-nova | 18:26 | |
| *** edmondsw has joined #openstack-nova | 18:27 | |
| *** klindgren has quit IRC | 18:28 | |
| *** jafeha__ has joined #openstack-nova | 18:29 | |
| *** mingyu has joined #openstack-nova | 18:29 | |
| stephenfin | melwitt: I'm not about tomorrow but if you have a chance to review [1] before Monday, I'd be eternally grateful [1] https://review.openstack.org/#/q/topic:bp/websocket-proxy-to-host-security+status:open | 18:29 |
| *** harlowja has joined #openstack-nova | 18:29 | |
| stephenfin | melwitt: I think jianghuaw_'s comments are valid but something that can be addressed in a follow-up (I don't know how much work 3.8 -> 3.3 conversion would be) | 18:30 |
| * stephenfin heads home | 18:30 | |
| melwitt | stephenfin: I've been looking at it and it looks overall good to me, but I saw recently someone -1ed it saying it doesn't work with xen? okay | 18:30 |
| *** jafeha has quit IRC | 18:31 | |
| *** edmondsw has quit IRC | 18:32 | |
| *** stvnoyes has joined #openstack-nova | 18:32 | |
| *** edmondsw has joined #openstack-nova | 18:33 | |
| *** mingyu has quit IRC | 18:34 | |
| *** imacdonn_ has quit IRC | 18:35 | |
| *** imacdonn_ has joined #openstack-nova | 18:35 | |
| *** mingyu has joined #openstack-nova | 18:37 | |
| *** gouthamr has joined #openstack-nova | 18:37 | |
| *** edmondsw has quit IRC | 18:37 | |
| *** tidwellr has joined #openstack-nova | 18:38 | |
| *** edmondsw has joined #openstack-nova | 18:39 | |
| *** edmondsw has quit IRC | 18:43 | |
| *** penick has quit IRC | 18:44 | |
| *** edmondsw has joined #openstack-nova | 18:45 | |
| *** penick has joined #openstack-nova | 18:45 | |
| *** clayton has quit IRC | 18:46 | |
| pprokop | 1 | 18:47 |
| *** clayton has joined #openstack-nova | 18:47 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:47 | |
| *** Alex_Staf has quit IRC | 18:49 | |
| *** AlexeyAbashkin has quit IRC | 18:52 | |
| melwitt | mriedem: let's see how this goes https://review.openstack.org/#/c/528036 | 18:55 |
| mriedem | cool | 18:56 |
| *** felipemonteiro_ has joined #openstack-nova | 18:56 | |
| *** andreas_s has joined #openstack-nova | 18:57 | |
| *** itlinux has quit IRC | 18:57 | |
| *** felipemonteiro__ has joined #openstack-nova | 18:58 | |
| *** gszasz has quit IRC | 19:00 | |
| *** mvk has quit IRC | 19:00 | |
| *** mvk has joined #openstack-nova | 19:01 | |
| *** felipemonteiro_ has quit IRC | 19:02 | |
| *** andreas_s has quit IRC | 19:02 | |
| *** ralonsoh has quit IRC | 19:03 | |
| cfriesen | when dealing with quotas, why do we distinguish between "in use" and "reserved"? | 19:05 |
| *** Guest26528 has quit IRC | 19:06 | |
| *** catintheroof has quit IRC | 19:06 | |
| melwitt | because the old system had an initial "reserve" step that happened before switching it from "reserved" -> "in use" | 19:06 |
| melwitt | reserve() reserved it and commit() changed it from reserved to in use | 19:07 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | 19:08 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | 19:08 |
| cfriesen | melwitt: thanks...so in pike would we ever see a nonzero reserved value? | 19:09 |
| melwitt | cfriesen: right, no more reserve step so reserved always zero | 19:11 |
| *** adisky__ has quit IRC | 19:11 | |
| *** jmlowe has joined #openstack-nova | 19:12 | |
| *** edmondsw has quit IRC | 19:12 | |
| cfriesen | melwitt: great, thanks | 19:12 |
| *** edmondsw has joined #openstack-nova | 19:13 | |
| *** vivsoni__ has quit IRC | 19:13 | |
| *** itlinux has joined #openstack-nova | 19:15 | |
| *** openstack has joined #openstack-nova | 20:32 | |
| *** ChanServ sets mode: +o openstack | 20:32 | |
| *** yangyapeng has quit IRC | 20:34 | |
| *** edmondsw has quit IRC | 20:36 | |
| *** pchavva has quit IRC | 20:38 | |
| *** lyan has joined #openstack-nova | 20:38 | |
| *** lpetrut has joined #openstack-nova | 20:38 | |
| *** gbarros has quit IRC | 20:38 | |
| openstackgerrit | melanie witt proposed openstack/nova master: live-mig: keep disk device address same https://review.openstack.org/518022 | 20:45 |
| *** jmlowe has joined #openstack-nova | 20:45 | |
| *** AlexeyAbashkin has joined #openstack-nova | 20:46 | |
| *** gouthamr has quit IRC | 20:47 | |
| *** liverpooler has quit IRC | 20:47 | |
| *** yangyapeng has joined #openstack-nova | 20:50 | |
| *** smatzek has quit IRC | 20:51 | |
| *** AlexeyAbashkin has quit IRC | 20:51 | |
| *** cleong has quit IRC | 20:52 | |
| *** awaugama has quit IRC | 20:52 | |
| *** yangyapeng has quit IRC | 20:55 | |
| *** pchavva has joined #openstack-nova | 20:57 | |
| *** jafeha__ has quit IRC | 20:58 | |
| *** yamamoto has joined #openstack-nova | 21:07 | |
| *** sree has joined #openstack-nova | 21:07 | |
| *** SamYaple has quit IRC | 21:07 | |
| *** SamYaple has joined #openstack-nova | 21:08 | |
| *** pchavva has quit IRC | 21:08 | |
| *** yamahata has joined #openstack-nova | 21:09 | |
| *** openstack has joined #openstack-nova | 21:11 | |
| *** ChanServ sets mode: +o openstack | 21:11 | |
| *** sree has quit IRC | 21:14 | |
| *** yamamoto has quit IRC | 21:15 | |
| *** yangyapeng has quit IRC | 21:15 | |
| *** tidwellr_ has joined #openstack-nova | 21:22 | |
| *** tidwellr has quit IRC | 21:22 | |
| *** SamYaple has quit IRC | 21:22 | |
| *** rodolof has quit IRC | 21:22 | |
| *** rodolof has joined #openstack-nova | 21:22 | |
| *** SamYaple has joined #openstack-nova | 21:23 | |
| mriedem | can someone hit this? https://review.openstack.org/#/c/527878/ - unblocks the 2.58 api change and is needed for the common server create api samples after 2.57 where 'personality' is not an allowed request parameter | 21:27 |
| *** sree has joined #openstack-nova | 21:27 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Implement set_and_clear_allocations in report client https://review.openstack.org/528089 | 21:27 |
| cdent | dansmith. mriedem that ^ is a start on POST to /allocations for migration stuff. It's just a spike at this point but I figured I'd push it up for early "is this what we were thinking style review". Also I needed to do something besides talk. | 21:28 |
| mriedem | heh, cool. thanks. | 21:28 |
| mriedem | that was on my list as well | 21:28 |
| dansmith | sweet | 21:30 |
| *** tidwellr_ has quit IRC | 21:30 | |
| dansmith | I was literally lying in bed last night thinking I needed to ask if you were interested in doing that | 21:30 |
| dansmith | and then forgot | 21:30 |
| cdent | it appears to "work". the test_servers functional tests pass, and I assume it exercised by that | 21:30 |
| *** yangyapeng has joined #openstack-nova | 21:30 | |
| tonyb | mriedem: Thanks for the update. I'll try again to look at thos backports. | 21:31 |
| cdent | actually, dansmith, I was standing in your room last night, watching you sleep | 21:31 |
| *** threestrands has joined #openstack-nova | 21:31 | |
| * dansmith checks his magazine | 21:31 | |
| cdent | heh | 21:31 |
| *** sree has quit IRC | 21:31 | |
| openstackgerrit | Merged openstack/nova master: Fix some typos in nova doc https://review.openstack.org/527856 | 21:31 |
| * mriedem disables zkvm ci again | 21:32 | |
| *** READ10 has quit IRC | 21:34 | |
| *** yangyapeng has quit IRC | 21:35 | |
| mriedem | the live migrate task calls this same code in the migrate module right? | 21:35 |
| mriedem | yup | 21:36 |
| mriedem | ok | 21:36 |
| mriedem | looks like a sane start to me | 21:36 |
| mriedem | not sure we need to handle the 1.13 not being there but it doesn't really hurt either | 21:36 |
| cdent | mriedem: yeah, I responded on that within. I couldn't remember whether we had nailed the 1.14 requirment as for realz or not | 21:37 |
| mriedem | it is | 21:37 |
| mriedem | create resource provider doesn't fallback if it's not there | 21:37 |
| mriedem | https://review.openstack.org/#/c/526505/ | 21:37 |
| cdent | then I suppose may as well remove that fallback | 21:37 |
| cdent | so does that mean we can remove all the fallback code in report client? | 21:38 |
| cdent | as there's some others too | 21:38 |
| *** andreas_s has joined #openstack-nova | 21:40 | |
| mriedem | maybe | 21:40 |
| mriedem | i think we can remove the safe_connect decorator | 21:40 |
| mriedem | that was for placement being optional in newton | 21:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: libvirt: properly decode error message from qemu guest agent https://review.openstack.org/517727 | 21:42 |
| *** gouthamr has joined #openstack-nova | 21:43 | |
| *** andreas_s has quit IRC | 21:44 | |
| cdent | it does other things | 21:45 |
| cdent | including dealing with the fact that placement is not currently up, but might be in a little while | 21:45 |
| cdent | which helps make it resilient across reboots | 21:45 |
| cdent | or during installs where things get out of order | 21:45 |
| *** gouthamr_ has joined #openstack-nova | 21:46 | |
| *** erlon has joined #openstack-nova | 21:46 | |
| mriedem | oh i suppose | 21:46 |
| *** tidwellr has joined #openstack-nova | 21:47 | |
| openstackgerrit | Merged openstack/nova master: XenAPI: Don't use nicira-iface-id for XenServer VIF https://review.openstack.org/451641 | 21:47 |
| openstackgerrit | Merged openstack/nova master: Retry _trait_sync on deadlock https://review.openstack.org/527836 | 21:47 |
| *** penick has quit IRC | 21:48 | |
| *** gouthamr has quit IRC | 21:48 | |
| *** yamamoto has joined #openstack-nova | 21:51 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Retry _trait_sync on deadlock https://review.openstack.org/528094 | 21:51 |
| *** yangyapeng has joined #openstack-nova | 21:52 | |
| *** yangyapeng has quit IRC | 21:57 | |
| *** gbarros has joined #openstack-nova | 21:58 | |
| *** rcernin has joined #openstack-nova | 21:58 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 22:02 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 22:02 |
| *** rodolof has quit IRC | 22:03 | |
| *** eandersson has joined #openstack-nova | 22:03 | |
| *** penick has joined #openstack-nova | 22:04 | |
| mriedem | who wants to delete some stuff? | 22:04 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete the TypeAffinityFilter https://review.openstack.org/528099 | 22:04 |
| mriedem | jogo: i believe this was your baby ^ | 22:04 |
| *** gouthamr_ is now known as gouthamr | 22:04 | |
| *** mvenesio has quit IRC | 22:05 | |
| mriedem | i suppose i should run pep8 | 22:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete the TypeAffinityFilter https://review.openstack.org/528099 | 22:10 |
| *** cdent has quit IRC | 22:12 | |
| cfriesen | mriedem: has anyone ever talked about not overwriting the UEFI variables on every boot? | 22:14 |
| cfriesen | mriedem: I don't see any related nova bug, but we've got a customer saying that instances should preserve UEFI variables over stop/start, for example. | 22:15 |
| mriedem | cfriesen: no one has ever talked about uefi period | 22:15 |
| openstackgerrit | melanie witt proposed openstack/nova master: Enable test_volume_backed_live_migration in tempest https://review.openstack.org/528104 | 22:15 |
| cfriesen | mriedem: heh | 22:15 |
| *** Apoorva has quit IRC | 22:17 | |
| *** ChanServ has quit IRC | 22:17 | |
| *** yangyapeng has joined #openstack-nova | 22:19 | |
| openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.58 - Add trusted_image_certificates https://review.openstack.org/500396 | 22:20 |
| *** kumarmn_ has quit IRC | 22:20 | |
| *** yangyapeng has quit IRC | 22:24 | |
| *** ChanServ has joined #openstack-nova | 22:24 | |
| *** barjavel.freenode.net sets mode: +o ChanServ | 22:24 | |
| *** artom has quit IRC | 22:26 | |
| openstackgerrit | Merged openstack/nova stable/ocata: Fix 'force' parameter in os-quota-sets PUT schema https://review.openstack.org/526426 | 22:26 |
| *** gbarros has quit IRC | 22:27 | |
| *** gouthamr has quit IRC | 22:28 | |
| *** ChanServ has quit IRC | 22:28 | |
| *** moshele has quit IRC | 22:30 | |
| *** esberglu has quit IRC | 22:31 | |
| *** ChanServ has joined #openstack-nova | 22:31 | |
| *** barjavel.freenode.net sets mode: +o ChanServ | 22:31 | |
| *** esberglu_ has joined #openstack-nova | 22:34 | |
| *** esbergl__ has joined #openstack-nova | 22:36 | |
| *** yangyapeng has joined #openstack-nova | 22:37 | |
| *** kumarmn has joined #openstack-nova | 22:39 | |
| *** esberglu_ has quit IRC | 22:39 | |
| mriedem | cfriesen: are you going to be in dublin? | 22:40 |
| mriedem | did you see my query about that old bp of yours about specific numa scheduling? | 22:40 |
| *** esbergl__ has quit IRC | 22:40 | |
| *** kumarmn has quit IRC | 22:41 | |
| *** kumarmn has joined #openstack-nova | 22:41 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 22:41 |
| *** tidwellr has quit IRC | 22:41 | |
| *** yangyapeng has quit IRC | 22:42 | |
| *** sree has joined #openstack-nova | 22:48 | |
| *** esberglu has joined #openstack-nova | 22:49 | |
| *** felipemonteiro_ has joined #openstack-nova | 22:50 | |
| *** BryanS68 has quit IRC | 22:51 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix the formatting for 2.56 in the compute REST API history doc https://review.openstack.org/528114 | 22:52 |
| *** sree has quit IRC | 22:53 | |
| *** felipemonteiro__ has quit IRC | 22:53 | |
| *** esberglu has quit IRC | 22:54 | |
| *** felipemonteiro_ has quit IRC | 22:56 | |
| *** baoli has quit IRC | 22:57 | |
| *** yangyapeng has joined #openstack-nova | 22:59 | |
| *** lyan has quit IRC | 23:01 | |
| *** yangyapeng has quit IRC | 23:04 | |
| *** sree has joined #openstack-nova | 23:07 | |
| *** threestrands_ has joined #openstack-nova | 23:10 | |
| *** sree has quit IRC | 23:12 | |
| *** threestrands has quit IRC | 23:13 | |
| *** felipemonteiro_ has joined #openstack-nova | 23:14 | |
| *** masuberu has quit IRC | 23:15 | |
| *** Sukhdev has joined #openstack-nova | 23:16 | |
| *** weshay is now known as weshay_pto | 23:17 | |
| *** yangyapeng has joined #openstack-nova | 23:19 | |
| *** _ix_ has joined #openstack-nova | 23:21 | |
| *** lpetrut has quit IRC | 23:21 | |
| *** baoli has joined #openstack-nova | 23:23 | |
| *** _ix has quit IRC | 23:24 | |
| *** yangyapeng has quit IRC | 23:24 | |
| *** kumarmn has quit IRC | 23:24 | |
| *** kumarmn has joined #openstack-nova | 23:25 | |
| *** moshele has joined #openstack-nova | 23:27 | |
| *** baoli has quit IRC | 23:28 | |
| *** kumarmn has quit IRC | 23:30 | |
| *** harlowja has quit IRC | 23:32 | |
| *** felipemonteiro_ has quit IRC | 23:35 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: WIP: Add support for the 2.57 microversion https://review.openstack.org/528128 | 23:35 |
| *** dave-mcc_ has quit IRC | 23:37 | |
| *** Apoorva has joined #openstack-nova | 23:38 | |
| *** harlowja has joined #openstack-nova | 23:39 | |
| *** yangyapeng has joined #openstack-nova | 23:40 | |
| *** harlowja has quit IRC | 23:40 | |
| *** harlowja has joined #openstack-nova | 23:42 | |
| *** andreas_s has joined #openstack-nova | 23:44 | |
| *** yangyapeng has quit IRC | 23:44 | |
| *** tetsuro has joined #openstack-nova | 23:47 | |
| *** andreas_s has quit IRC | 23:48 | |
| *** takashin has joined #openstack-nova | 23:49 | |
| *** harlowja has quit IRC | 23:50 | |
| *** lennyb has quit IRC | 23:51 | |
| openstackgerrit | Merged openstack/nova stable/newton: Only query BDMs once in API during rebuild https://review.openstack.org/526543 | 23:54 |
| *** erlon has quit IRC | 23:55 | |
| jogo | mriedem: doesn't sound very backwards compatible to delete it ... but goodbye filter | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!