Wednesday, 2017-12-13

jaypipesmriedem: thanks matt00:00
mriedemnewOpenstacker: is this ocata, pike, queens (master)?00:00
*** tetsuro has joined #openstack-nova00:00
newOpenstackerOh sorry I forgot to mention that. This is on newton currently00:01
*** penick has quit IRC00:02
*** felipemonteiro_ has quit IRC00:02
mriedemwhat happens if you do the same thing with a straight curl request? i wonder if the the CLIs are trying to "help" somehow00:02
newOpenstackerok. i'll try that and get back00:03
*** penick has joined #openstack-nova00:04
mriedemi'd point you at https://developer.openstack.org/api-guide/compute/paginated_collections.html but it's more confusing probably because the description and samples are all effed up00:06
mriedemsaying it's paging over images but it's clearly servers, and the bottom sample has a self link with the wrong id00:06
* mriedem opens bug00:06
mriedemheh, and the bug link on that page doesn't work00:06
mriedemhttps://bugs.launchpad.net/nova/+bug/173785400:10
openstackLaunchpad bug 1737854 in OpenStack Compute (nova) "Wrong content in "paginated collections" API guide page" [High,Confirmed]00:10
newOpenstackeryes, even with curl calls the behavior is the same00:11
mriedemhmm, not sure why with limit=1 and marker=x you'd get back x00:12
mriedemit should be x+1 in the instances table00:12
mriedemsorted on created_at,id in descending order00:12
mriedemi wonder if that instance is a build request or something...00:13
mriedemcan you check if that instance is in the nova.instances table or the nova_api.build_requests table?00:13
mriedembased on the instance uuid00:13
newOpenstackerany particular column that is of interest here?00:14
newOpenstackerThe instance is in nova.instances with vm_state as building and also present in the build_requests table00:15
mriedemok that's likely the problem00:15
mriedemdid that instance fail to build?00:15
newOpenstackerit got stuck in building state...00:15
mriedemi'm guessing the build request didn't get cleaned up00:15
mriedemthe instance failed to build and the build request didn't get cleaned up for some reason00:16
newOpenstackerso if there are instances in building state then paginations don't work?00:16
mriedemdo you have all of the latest newton fixes from stable/newton?00:16
mriedemno00:16
mriedemnot saying that00:16
newOpenstackerchecking the exact version00:16
mriedembut the instance shouldn't be in both the build_requests and instances table permanently00:16
mriedemthe entry in build_requests should be temporary until we find a host for the instance during scheduling00:17
mriedemwhen listing instances, we start with the build_requests table and then move to the instances tables in the nova db00:17
newOpenstackeron newton we are 7 minor releases behind. current tag on nova newton is 14.0.10 while this setup is on 14.0.3.00:19
mriedemok, definitely might have fixed the problem already where the build request should have been deleted00:20
newOpenstackerI'll have to check why the instance is stuck in building state. Its been that way for couple of days.00:20
mriedemlooking at our paging code though, i don't think we're handling the marker properly if we find it in the build_requests table00:20
newOpenstackerAh ok. I'll see if we can move to the latest on newton00:20
newOpenstackerIs there a bug already for this that I can monitor?00:20
mriedemnormally when we find the marker we need to nix it so we don't look for that marker in the instances table if we have more room in our limit, but i don't see that happening00:21
mriedemi've never heard of the marker thing00:21
*** hamzy has joined #openstack-nova00:21
mriedemthese are the fixes you're missing btw http://paste.openstack.org/show/628777/00:22
mriedem608105a Provide an online data migration to cleanup orphaned build requests00:23
mriedemcould be just what you need00:23
mriedemrelease notes for newton if you're going to upgrade https://docs.openstack.org/releasenotes/nova/newton.html00:24
*** brault has joined #openstack-nova00:25
newOpenstackerOK. Thanks @mriedem I'll try to get those fixes00:25
mriedemi think that will fix the marker issue you're seeing too00:26
mriedembecause we should never find the marker in two different places00:26
*** sree has joined #openstack-nova00:27
newOpenstackerUnderstood. So in this case removing those offending records from the database should fix it as well?00:27
mriedemthat's my guess00:27
newOpenstackerCool. Thanks @mriedem00:27
mriedemyw00:27
*** jaypipes has quit IRC00:28
*** yangyapeng has quit IRC00:28
*** yangyapeng has joined #openstack-nova00:29
*** salv-orl_ has quit IRC00:29
mriedemdansmith: melwitt: something to lose sleep over - shouldn't we set the marker to None if we find the marker in the build_requests table? https://github.com/openstack/nova/blob/master/nova/objects/build_request.py#L44700:30
mriedemjust like here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L242600:30
*** brault has quit IRC00:30
dansmithwhy?00:30
dansmithmarker isn't used after that, right?00:31
mriedemyeah after build requests we page into the cells00:31
dansmithback in compute api00:31
*** r-daneel has quit IRC00:31
*** sree has quit IRC00:31
mriedemyeah https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2372-L237800:32
mriedemso i realize setting marker=None in the build request code wouldn't fix that, we'd have to pass a marker variable back00:32
mriedemhere https://github.com/openstack/nova/blob/master/nova/compute/api.py#L235600:32
dansmithif we got anything back from build request list then the marker was in there, yeah?00:32
openstackgerritMerged openstack/nova master: VMware: fix memory stats  https://review.openstack.org/51663400:32
*** openstackgerrit has quit IRC00:33
dansmithwhich I guess we don't check00:33
mriedemi don't think so00:33
mriedemhttps://github.com/openstack/nova/blob/master/nova/objects/build_request.py#L440-L45700:33
mriedemwe happily return what we found00:33
mriedemi.e. we don't raise MarkerNotFound00:33
*** mlavalle has quit IRC00:33
*** yangyapeng has quit IRC00:33
dansmithhmm00:34
mriedemwhich seems buggish...00:34
dansmithyeah00:34
*** chyka_ has quit IRC00:34
*** rocky-shiyan has quit IRC00:34
tetsuromriedem: I responsed to your comment in https://review.openstack.org/#/c/465160/00:36
*** zhurong has joined #openstack-nova00:37
mriedemhttps://bugs.launchpad.net/nova/+bug/173785600:38
openstackLaunchpad bug 1737856 in OpenStack Compute (nova) "Listing instances with a marker doesn't nix the marker if it's found in build_requests" [Undecided,Triaged]00:38
*** jmlowe has quit IRC00:38
mriedemalright my eyes are going to fall out if i don't stop staring at this screen so away i go00:40
*** jmlowe has joined #openstack-nova00:41
*** mvensky has joined #openstack-nova00:42
*** mvensky has quit IRC00:42
*** andreas_s has joined #openstack-nova00:42
*** openstackgerrit has joined #openstack-nova00:43
openstackgerritGhanshyam Mann proposed openstack/python-novaclient master: Optimize jobs run on novaclient  https://review.openstack.org/52755000:43
gmannmriedem: for your morning ^^00:44
gmannits re on your comment  - https://review.openstack.org/#/c/522099/5/playbooks/legacy/novaclient-dsvm-functional-neutron/run.yaml@200:44
*** sree has joined #openstack-nova00:47
*** andreas_s has quit IRC00:48
*** sree has quit IRC00:51
*** masuberu has quit IRC00:59
*** Swami has quit IRC01:01
*** newOpenstacker has quit IRC01:02
*** phuongnh has joined #openstack-nova01:04
*** yamahata has joined #openstack-nova01:15
*** yangyapeng has joined #openstack-nova01:15
*** takashin has quit IRC01:17
*** trungnv has joined #openstack-nova01:19
*** jmlowe has quit IRC01:24
*** sree has joined #openstack-nova01:28
*** hshiina has joined #openstack-nova01:30
*** salv-orlando has joined #openstack-nova01:30
*** jmlowe has joined #openstack-nova01:31
*** lei-zh has joined #openstack-nova01:31
*** sree has quit IRC01:33
*** salv-orlando has quit IRC01:35
*** gyee has quit IRC01:36
*** TuanLA has joined #openstack-nova01:41
*** andreas_s has joined #openstack-nova01:42
*** sree has joined #openstack-nova01:47
*** baoli has joined #openstack-nova01:48
*** baoli_ has joined #openstack-nova01:49
*** sree has quit IRC01:51
*** andreas_s has quit IRC01:52
*** baoli has quit IRC01:53
*** yamahata has quit IRC01:54
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Unmap compute nodes when deleting host mapping  https://review.openstack.org/52756001:54
*** liuyulong has joined #openstack-nova01:54
*** Apoorva_ has quit IRC01:56
openstackgerritJackie Truong proposed openstack/nova master: Implement certificate_utils  https://review.openstack.org/47994901:56
*** Tom-Tom has joined #openstack-nova02:01
*** Tom-Tom has quit IRC02:01
*** Tom-Tom has joined #openstack-nova02:01
*** Tom-Tom has quit IRC02:01
*** takashin has joined #openstack-nova02:04
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete  https://review.openstack.org/52523102:05
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (2)  https://review.openstack.org/52626302:05
*** _ix has quit IRC02:05
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (3)  https://review.openstack.org/52655702:06
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in post  https://review.openstack.org/52682302:06
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix the order of target host checks  https://review.openstack.org/52622502:06
*** chyka has joined #openstack-nova02:06
*** gouthamr has joined #openstack-nova02:07
*** annp has joined #openstack-nova02:07
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060802:07
*** sree has joined #openstack-nova02:07
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948302:07
*** jafeha__ has joined #openstack-nova02:07
openstackgerritTakashi NATSUME proposed openstack/nova master: Add a warning in 'nova-manage cell_v2 delete_cell'  https://review.openstack.org/51377102:08
mriedemgmann: thanks02:10
*** jafeha has quit IRC02:11
*** chyka has quit IRC02:11
*** sree has quit IRC02:12
*** rodolof has quit IRC02:12
*** jmlowe has quit IRC02:13
*** jmlowe has joined #openstack-nova02:15
*** zhurong has quit IRC02:23
*** lbragstad has quit IRC02:25
*** masber has joined #openstack-nova02:27
openstackgerritMatt Riedemann proposed openstack/nova master: Raise MarkerNotFound if BuildRequestList.get_by_filters doesn't find marker  https://review.openstack.org/52756402:32
*** mdnadeem has quit IRC02:32
*** zhurong has joined #openstack-nova02:33
*** lei-zh has quit IRC02:35
*** lei-zh has joined #openstack-nova02:35
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] Add x-openstack-request-id in API ref  https://review.openstack.org/52300702:36
*** tbachman has joined #openstack-nova02:39
*** liverpooler has quit IRC02:41
*** liverpooler has joined #openstack-nova02:42
*** hiro-kobayashi has joined #openstack-nova02:50
*** fragatina has quit IRC02:54
openstackgerritMerged openstack/nova master: Add quiesce and unquiesce in support matrix  https://review.openstack.org/48239002:56
*** moshele has joined #openstack-nova02:59
*** moshele has quit IRC03:09
*** Apoorva has joined #openstack-nova03:12
*** hiro-kobayashi has quit IRC03:22
*** tbachman has quit IRC03:22
mriedemalex_xu: can you get this in? https://review.openstack.org/#/c/527440/ i'm seeing a lot of failed CI jobs from that.03:25
*** mriedem has quit IRC03:28
*** takashin has quit IRC03:28
*** abhishekk has joined #openstack-nova03:29
*** _ix has joined #openstack-nova03:30
*** _ix_ has joined #openstack-nova03:34
*** _ix has quit IRC03:35
*** liuzz has quit IRC03:39
openstackgerritMerged openstack/nova master: SchedulerReportClient._get_providers_in_tree  https://review.openstack.org/52066303:41
*** hshiina has quit IRC03:45
*** penick has quit IRC03:52
*** baoli_ has quit IRC03:53
*** baoli has joined #openstack-nova03:54
*** penick has joined #openstack-nova03:55
*** armax has quit IRC03:57
*** sdague has quit IRC03:59
*** bkopilov has quit IRC04:00
*** hshiina has joined #openstack-nova04:01
*** baoli has quit IRC04:02
*** tbachman has joined #openstack-nova04:05
*** tbachman has quit IRC04:10
*** tbachman has joined #openstack-nova04:11
*** karthiks has joined #openstack-nova04:11
*** threestrands has joined #openstack-nova04:14
*** threestrands has quit IRC04:14
*** threestrands has joined #openstack-nova04:14
*** jappleii__ has quit IRC04:15
*** threestrands has quit IRC04:15
*** threestrands has joined #openstack-nova04:16
*** threestrands has quit IRC04:16
*** threestrands has joined #openstack-nova04:16
*** udesale has joined #openstack-nova04:17
*** openstackgerrit has quit IRC04:18
*** yamahata has joined #openstack-nova04:20
*** tbachman has quit IRC04:20
*** tbachman has joined #openstack-nova04:21
*** _ix_ has quit IRC04:24
*** dave-mcc_ has quit IRC04:25
*** links has joined #openstack-nova04:30
*** openstackgerrit has joined #openstack-nova04:30
openstackgerritMerged openstack/nova stable/pike: Make TestRPC inherit from the base nova TestCase  https://review.openstack.org/51184204:31
openstackgerritMerged openstack/nova master: api-ref: Fix a description for 'guest_format'  https://review.openstack.org/52592804:31
*** links has quit IRC04:32
*** bhagyashri_s is now known as bhagyashris04:34
*** bhagyashris is now known as bhagyashri_s04:34
*** bhagyashri_s is now known as bhagyashris04:34
*** adisky__ has joined #openstack-nova04:35
*** threestrands has quit IRC04:36
*** mdnadeem has joined #openstack-nova04:39
*** threestrands has joined #openstack-nova04:43
*** threestrands has quit IRC04:43
*** threestrands has joined #openstack-nova04:43
*** karthiks has quit IRC04:43
*** threestrands has quit IRC04:44
*** threestrands has joined #openstack-nova04:44
*** threestrands has quit IRC04:44
*** threestrands has joined #openstack-nova04:44
*** threestrands has quit IRC04:45
*** takashin has joined #openstack-nova04:45
*** threestrands has joined #openstack-nova04:46
*** threestrands has quit IRC04:46
*** threestrands has joined #openstack-nova04:46
*** liverpooler has quit IRC04:46
*** threestrands has quit IRC04:47
*** threestrands has joined #openstack-nova04:47
*** threestrands has quit IRC04:47
*** threestrands has joined #openstack-nova04:47
*** sridharg has joined #openstack-nova04:51
*** karthiks has joined #openstack-nova04:55
*** vladikr has quit IRC04:58
*** vladikr has joined #openstack-nova04:59
*** ratailor has joined #openstack-nova04:59
*** jose-phillips has quit IRC05:13
*** jose-phillips has joined #openstack-nova05:21
*** chyka has joined #openstack-nova05:23
*** chyka has quit IRC05:27
*** vladikr has quit IRC05:27
*** vladikr has joined #openstack-nova05:28
openstackgerritMerged openstack/nova master: [placement] Add cache headers to placement api requests  https://review.openstack.org/52164005:30
*** janki has joined #openstack-nova05:32
openstackgerritMerged openstack/nova master: [placement] Add info about last-modified to contrib docs  https://review.openstack.org/52608405:35
*** vladikr has quit IRC05:36
*** vladikr has joined #openstack-nova05:37
*** AlexeyAbashkin has joined #openstack-nova05:43
*** andreas_s has joined #openstack-nova05:43
*** fragatina has joined #openstack-nova05:49
*** andreas_s has quit IRC05:50
*** karthiks has quit IRC05:51
openstackgerritTakashi NATSUME proposed openstack/nova master: Add a warning in 'nova-manage cell_v2 delete_cell'  https://review.openstack.org/51377105:52
*** gongysh has joined #openstack-nova05:52
*** fragatina has quit IRC05:53
*** bkopilov has joined #openstack-nova05:54
*** mdnadeem has quit IRC05:58
*** threestrands has quit IRC06:03
*** Apoorva has quit IRC06:05
*** karthiks has joined #openstack-nova06:05
*** Apoorva has joined #openstack-nova06:05
*** lpetrut has joined #openstack-nova06:05
*** janki has quit IRC06:07
*** lpetrut has quit IRC06:08
*** lpetrut has joined #openstack-nova06:09
*** Apoorva has quit IRC06:10
openstackgerritMerged openstack/nova master: Remove the unused request_id filter from api-paste.ini  https://review.openstack.org/52600106:17
*** vivsoni_ has joined #openstack-nova06:19
*** vivsoni has quit IRC06:19
*** salv-orlando has joined #openstack-nova06:22
*** liuyulong has quit IRC06:24
*** brault has joined #openstack-nova06:26
*** alex_xu has quit IRC06:26
*** janki has joined #openstack-nova06:26
*** alex_xu has joined #openstack-nova06:27
*** moshele has joined #openstack-nova06:29
*** brault has quit IRC06:30
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Some nit fix in multi_cell_list  https://review.openstack.org/52759706:32
*** mdnadeem has joined #openstack-nova06:35
*** sapcc-bot has quit IRC06:40
*** sapcc-bot4 has joined #openstack-nova06:40
*** lajoskatona has joined #openstack-nova06:45
*** gouthamr has quit IRC06:48
*** lpetrut has quit IRC06:52
*** fragatina has joined #openstack-nova06:57
*** fragatin_ has joined #openstack-nova06:57
*** AlexeyAbashkin has quit IRC06:57
*** udesale__ has joined #openstack-nova07:01
*** fragatina has quit IRC07:02
*** damien_r has joined #openstack-nova07:03
*** udesale has quit IRC07:03
*** sree has joined #openstack-nova07:04
*** udesale has joined #openstack-nova07:04
*** udesale__ has quit IRC07:06
openstackgerritMerged openstack/nova master: Refactor placement version check  https://review.openstack.org/51249707:11
*** bkopilov has quit IRC07:11
*** josecastroleon has joined #openstack-nova07:11
*** rcernin has quit IRC07:12
*** andreas_s has joined #openstack-nova07:12
*** gongysh has quit IRC07:16
*** edand has joined #openstack-nova07:17
*** Tom-Tom has joined #openstack-nova07:17
openstackgerritMerged openstack/nova master: trivial: more suitable log in set_admin_password  https://review.openstack.org/52659207:18
*** bkopilov has joined #openstack-nova07:29
*** andreas_s has quit IRC07:31
*** lpetrut has joined #openstack-nova07:31
*** andreas_s has joined #openstack-nova07:32
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.openstack.org/52479507:35
*** andreas_s has quit IRC07:37
*** trungnv has quit IRC07:41
*** phuongnh has quit IRC07:41
*** TuanLA has quit IRC07:41
*** hoangcx has quit IRC07:41
*** Alex_Staf has joined #openstack-nova07:41
*** hiro-kobayashi has joined #openstack-nova07:41
*** trungnv has joined #openstack-nova07:41
*** salv-orlando has quit IRC07:41
*** TuanLA has joined #openstack-nova07:41
*** hoangcx has joined #openstack-nova07:41
*** phuongnh has joined #openstack-nova07:41
*** yamahata has quit IRC07:42
*** udesale__ has joined #openstack-nova07:46
*** udesale has quit IRC07:49
*** salv-orlando has joined #openstack-nova07:50
*** sahid has joined #openstack-nova07:50
*** aloga has quit IRC07:50
*** aloga has joined #openstack-nova07:50
*** lpetrut has quit IRC07:53
*** fragatin_ has quit IRC07:53
*** jmlowe has quit IRC07:55
*** jmlowe has joined #openstack-nova07:56
*** sshwarts has joined #openstack-nova08:01
*** alexchadin has joined #openstack-nova08:01
*** andreas_s has joined #openstack-nova08:03
*** andreas_s has quit IRC08:07
*** takashin has left #openstack-nova08:07
*** jpena|off is now known as jpena08:09
*** jafeha__ has quit IRC08:10
*** damien_r has quit IRC08:13
*** rcernin has joined #openstack-nova08:13
*** ralonsoh has joined #openstack-nova08:16
*** tesseract has joined #openstack-nova08:25
*** AlexeyAbashkin has joined #openstack-nova08:27
*** AlexeyAbashkin has quit IRC08:32
*** salv-orlando has quit IRC08:34
*** xinliang has quit IRC08:35
*** damien_r has joined #openstack-nova08:37
*** AlexeyAbashkin has joined #openstack-nova08:37
*** mdnadeem has quit IRC08:37
openstackgerritTetsuro Nakamura proposed openstack/nova master: [libvirt] Add _set_vcpu_realtime_scheduler()  https://review.openstack.org/52763008:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add _set_vcpu_pinning() and _set_numa_memory()  https://review.openstack.org/52763108:40
*** AlexeyAbashkin has quit IRC08:43
*** annp has quit IRC08:46
*** TuanLA has quit IRC08:46
*** trungnv has quit IRC08:46
*** annp has joined #openstack-nova08:46
*** TuanLA has joined #openstack-nova08:46
*** mdnadeem has joined #openstack-nova08:46
*** trungnv has joined #openstack-nova08:47
*** xinliang has joined #openstack-nova08:48
*** hshiina has quit IRC08:50
*** jafeha__ has joined #openstack-nova08:51
*** salv-orlando has joined #openstack-nova08:52
*** pmannidi has joined #openstack-nova08:52
*** AlexeyAbashkin has joined #openstack-nova08:57
*** jafeha has joined #openstack-nova08:59
*** chyka has joined #openstack-nova08:59
*** jafeha__ has quit IRC09:00
*** links has joined #openstack-nova09:00
*** kumarmn has joined #openstack-nova09:03
*** lpetrut has joined #openstack-nova09:03
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add _set_vcpu_pinning() and _set_numa_memory()  https://review.openstack.org/52763109:03
*** tssurya has joined #openstack-nova09:03
*** chyka has quit IRC09:03
*** pmannidi has quit IRC09:04
*** pmannidi has joined #openstack-nova09:05
*** hiro-kobayashi has quit IRC09:05
*** gcb has joined #openstack-nova09:06
*** kumarmn has quit IRC09:07
*** masber has quit IRC09:09
*** fragatina has joined #openstack-nova09:12
*** vivsoni_ has quit IRC09:13
*** vivsoni_ has joined #openstack-nova09:13
mdboothmnaser: melwitt Reading back scroll. Yes, a per-backend image cache was part of my plans both times I've submitted patches for a massive refactor of the imagebackend code.09:17
mdboothYou'll hit a few architectural issues getting it landed, though.09:18
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions  https://review.openstack.org/32632609:18
*** isq_ has quit IRC09:20
*** dklyle has quit IRC09:20
*** isq_ has joined #openstack-nova09:21
mdboothFirstly, the image cache code is unnecessarily and messily embedded implicitly in each individual imagebackend already. All that code needs to be cleaned up. In itself that's not too hard, but the tests are also hugely problematic. Ultimately, fixing the tests to a point where it was possible to refactor the code sunk me twice. There are a huge number of tests in there, and in general the quality is rock bottom.09:21
*** tetsuro has quit IRC09:22
mdboothHowever, if you get to the point where you've unpicked the imagecache from the imagebackend code, you still have to handle both layouts.09:23
mdboothCurrently, the only source of truth for the layout of an instance is the config of the compute host is resides on.09:23
*** rmart04 has joined #openstack-nova09:24
mdboothSo if we're to have a transitional period where we're altering the on-disk layout, which is what changing the image cache would amount to, we need to have a per-instance datastore for driver-specific data.09:24
mdboothIncidentally, my plan was to add this to the BDM so it could actually be per-disk.09:25
mdboothBut if you can get there, yes the current design of the imagecache makes no sense09:26
mdboothWell, no longer makes any sense09:27
mdboothIt should have been refactored long ago the first time we implemented an alternate backend09:27
*** alexchadin has quit IRC09:30
*** lucas-afk is now known as lucasagomes09:32
*** gongysh has joined #openstack-nova09:33
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions  https://review.openstack.org/32632609:36
*** lei-zh has quit IRC09:37
kashyapmdbooth: You might want to spell that documentation somewhere to whoever that is planning to go that route...09:41
kashyapMaybe you did in all those previous iterations.  In that case, disregard me :-)09:42
mdboothkashyap: I wrote the code :)09:42
mdboothThen I threw it away.09:42
mdboothThe I wrote it again!09:42
kashyapmdbooth: Whoops09:42
mdboothThen I threw that away, too.09:42
*** janki has quit IRC09:42
kashyapHence the "sunk me twice", now that nice expression makes sense09:42
kashyaps/makes sense/makes doubly sense/09:42
mdboothEach one took me a couple of months.09:43
*** janki has joined #openstack-nova09:43
mdboothThrowing away 2 months of effort is good for the soul.09:43
kashyap:-)09:43
kashyapmdbooth: Just out of curiosity, as you meditated on this problem space, how badly does this affect us long-term?09:44
* mdbooth dearly wishes that were true.09:44
*** alexchadin has joined #openstack-nova09:44
mdboothkashyap: The main issue in imagebackend, and the reason it needs a refactor like either of the ones I already did, is that every time somebody comes along and proposes a design change it's basically infeasible.09:45
mdboothRight now we have a big tangled ball of string that works.09:45
mdboothThat's great, but you can't easily make it do anything else without untangling it first.09:45
mdboothSo, a new backend which works substantially differently to the existing ones.09:46
kashyapHmm09:46
mdboothChanging the on-disk layout09:46
gibidansmith: I hit https://review.openstack.org/#/c/517119/ but as I see Jay will respin it one more time so I will hit it with a +2 after that09:47
mdboothe.g. because you want  a more efficient imagecache09:47
mdboothor because you want to use libvirt storage pools09:47
kashyapmdbooth: Changing the on-disk layout to what?09:48
kashyapmdbooth: If I'm asking uproductive questions, ignore me.  I'll do some looking up :-)09:48
mdboothWell the 2 proposals above have both actually been made.09:48
kashyapI know you've written to the list and on changes you proposed with your thoughts on this09:48
openstackgerritLee Yarwood proposed openstack/nova master: conf: Do not inherit image signature props with snapshots  https://review.openstack.org/52704609:48
mdboothChanging the image cache is an on-disk change, because backing images are now in a different place.09:48
kashyapAh, right.09:49
mdboothThe existing code assumes all sorts of things in obtuse ways.09:49
*** janki has quit IRC09:49
kashyapWill this be brought up at the upcoming PTG?09:49
*** janki has joined #openstack-nova09:49
kashyapAssuming you /others still have the appetite for it... :-)09:49
mdboothUsing libvirt storage pools requires an on-disk change, because we don't layout our disks in a way that's easy to manage with storage pools.09:49
mdboothIt's not specifically on my agenda right now. I rehash it from time to time (like this morning) when somebody else brings it up.09:50
mdboothI've done the work twice already.09:50
kashyapNod; thanks for the explanation.09:53
*** gongysh has quit IRC09:54
openstackgerritStephen Finucane proposed openstack/nova master: objects: Add PCI NUMA policy fields  https://review.openstack.org/52747010:03
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Pass InstanceNUMATopology to consume_request  https://review.openstack.org/52747110:03
openstackgerritStephen Finucane proposed openstack/nova master: Add PCI NUMA policies  https://review.openstack.org/52747210:03
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Modify signature of _filter_non_requested_pfs  https://review.openstack.org/52747310:03
*** annp has quit IRC10:05
*** fragatina has quit IRC10:06
*** yangyapeng has quit IRC10:06
*** yangyapeng has joined #openstack-nova10:07
*** yangyapeng has quit IRC10:09
*** sree has quit IRC10:09
*** sree has joined #openstack-nova10:10
openstackgerritYa Lian Pan proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver  https://review.openstack.org/52765810:12
*** yamamoto has quit IRC10:13
openstackgerritChason Chan proposed openstack/nova master: Fix the bug report link of API Guide  https://review.openstack.org/52766010:13
*** TuanLA has quit IRC10:15
*** sdague has joined #openstack-nova10:15
*** sree has quit IRC10:15
*** salv-orlando has quit IRC10:15
*** Tom-Tom has quit IRC10:19
*** Tom-Tom has joined #openstack-nova10:20
*** alexchadin has quit IRC10:23
*** alexchadin has joined #openstack-nova10:24
*** dosaboy has quit IRC10:24
*** Tom-Tom has quit IRC10:24
*** dosaboy has joined #openstack-nova10:25
*** alexchadin has quit IRC10:27
*** alexchadin has joined #openstack-nova10:28
*** penick has quit IRC10:28
*** sapd_ has quit IRC10:28
*** sapd has joined #openstack-nova10:30
*** dosaboy has quit IRC10:31
openstackgerritStephen Finucane proposed openstack/nova master: zuul: Move legacy jobs to project  https://review.openstack.org/51430910:32
openstackgerritStephen Finucane proposed openstack/nova master: zuul: Remove WSGI functional tests  https://review.openstack.org/52714010:32
*** dosaboy has joined #openstack-nova10:37
*** zhurong has quit IRC10:37
*** yamamoto has joined #openstack-nova10:43
*** phuongnh has quit IRC10:44
*** janki has quit IRC10:46
*** dtantsur|afk is now known as dtantsur10:48
*** sambetts|afk is now known as sambetts10:49
*** damien_r has quit IRC10:57
*** mvk has quit IRC10:58
*** tssurya has quit IRC11:01
*** edand has quit IRC11:04
*** pmannidi has quit IRC11:06
*** pmannidi has joined #openstack-nova11:07
*** udesale__ has quit IRC11:08
*** janki has joined #openstack-nova11:08
*** hui has quit IRC11:09
*** abhishekk has quit IRC11:09
*** pmannidi has quit IRC11:13
*** r-daneel has joined #openstack-nova11:14
*** edand has joined #openstack-nova11:18
*** claudiub has joined #openstack-nova11:21
*** mvk has joined #openstack-nova11:23
*** gongysh has joined #openstack-nova11:36
*** vladikr has quit IRC11:36
openstackgerritStephen Finucane proposed openstack/nova master: objects: remove pagesize from __init__ of InstanceNUMATopology  https://review.openstack.org/48555311:38
openstackgerritStephen Finucane proposed openstack/nova master: objects: remove related pinning from __init__ of InstanceNUMATopology  https://review.openstack.org/48555411:38
openstackgerritStephen Finucane proposed openstack/nova master: objects: remove cpuset_reserved from __init__ of InstanceNUMATopology  https://review.openstack.org/46603011:38
*** salv-orlando has joined #openstack-nova11:38
*** gszasz has joined #openstack-nova11:39
stephenfindansmith: When you're about, could you take a punt at https://review.openstack.org/#/q/topic:bug/1636338 Guess you're best placed for them11:39
stephenfindansmith: Or stick em on your list for the new year. Either-or (they're just there a looong time)11:39
*** claudiub has quit IRC11:41
openstackgerritLi Xipeng proposed openstack/nova master: Fix bug case by none token context  https://review.openstack.org/52211211:43
*** gongysh has quit IRC11:45
*** andreas_s has joined #openstack-nova11:45
*** damien_r has joined #openstack-nova11:45
*** gcb has quit IRC11:47
*** gcb has joined #openstack-nova11:48
*** damien_r has quit IRC11:49
*** cdent has joined #openstack-nova11:50
*** sree has joined #openstack-nova11:51
*** gszasz has quit IRC11:51
*** andreas_s has quit IRC11:51
*** sree has quit IRC11:55
*** sahid has quit IRC11:56
*** tbachman has quit IRC11:59
*** sree has joined #openstack-nova12:04
*** janki has quit IRC12:05
*** alexchadin has quit IRC12:06
*** alexchadin has joined #openstack-nova12:06
*** bkopilov has quit IRC12:07
*** sree_ has joined #openstack-nova12:09
*** sree_ is now known as Guest8017612:09
openstackgerritLajos Katona proposed openstack/nova master: Extend ServerMovingTests with custom resources  https://review.openstack.org/49739912:10
*** sree has quit IRC12:12
*** alexchadin has quit IRC12:18
*** purplerbot has joined #openstack-nova12:22
*** dave-mccowan has joined #openstack-nova12:22
*** lpetrut has quit IRC12:22
*** alexchadin has joined #openstack-nova12:23
*** lpetrut has joined #openstack-nova12:23
*** janki has joined #openstack-nova12:31
*** purplerbot has quit IRC12:32
*** purplerbot has joined #openstack-nova12:33
*** masuberu has joined #openstack-nova12:33
*** lucasagomes is now known as lucas-hungry12:35
*** cleong has joined #openstack-nova12:40
*** tssurya has joined #openstack-nova12:40
*** jamesdenton has joined #openstack-nova12:43
*** BryanS68 has joined #openstack-nova12:47
*** smatzek has joined #openstack-nova12:51
*** Tom-Tom has joined #openstack-nova12:51
*** Guest80176 has quit IRC12:53
*** jpena is now known as jpena|lunch12:53
*** sree has joined #openstack-nova12:53
*** ratailor has quit IRC12:54
openstackgerritChris Dent proposed openstack/nova master: [placement] Enable limiting GET /allocation_candidates  https://review.openstack.org/51352612:55
*** sree has quit IRC12:58
gmannnova api meeting in 2 min..12:58
*** udesale has joined #openstack-nova12:58
*** toabctl has quit IRC13:00
*** salv-orl_ has joined #openstack-nova13:02
*** gszasz has joined #openstack-nova13:03
*** mikal_ has quit IRC13:03
*** damien_r has joined #openstack-nova13:03
*** rcernin has quit IRC13:04
*** mikal has joined #openstack-nova13:05
*** salv-orlando has quit IRC13:06
*** vladikr has joined #openstack-nova13:08
*** sree has joined #openstack-nova13:11
*** tbachman has joined #openstack-nova13:12
*** sree has quit IRC13:16
*** BryanS68 has quit IRC13:20
*** BryanS68 has joined #openstack-nova13:24
*** josecastroleon1 has joined #openstack-nova13:26
*** josecastroleon has quit IRC13:26
*** liverpooler has joined #openstack-nova13:26
*** sree has joined #openstack-nova13:28
*** lucas-hungry is now known as lucasagomes13:30
*** sree has quit IRC13:33
*** claudiub has joined #openstack-nova13:34
*** sapcc-bot4 has quit IRC13:36
*** sapcc-bot has joined #openstack-nova13:36
*** dgonzalez_ has joined #openstack-nova13:36
*** mkoderer_ has joined #openstack-nova13:36
*** tpatzig_ has joined #openstack-nova13:36
*** andreas_s has joined #openstack-nova13:36
*** takedakn has joined #openstack-nova13:37
*** mkoderer_ has quit IRC13:38
*** dgonzalez_ has quit IRC13:38
*** tpatzig_ has quit IRC13:38
*** pchavva has joined #openstack-nova13:39
openstackgerritMerged openstack/nova master: Re-use existing ComputeNode on ironic rebalance  https://review.openstack.org/50855513:41
*** andreas_s has quit IRC13:43
openstackgerritBalazs Gibizer proposed openstack/nova master: Transform instance.exists notification  https://review.openstack.org/40366013:46
*** sree has joined #openstack-nova13:47
*** takedakn has quit IRC13:50
*** tesseract has quit IRC13:51
*** Tom-Tom_ has joined #openstack-nova13:51
*** sree has quit IRC13:52
*** Tom-Tom has quit IRC13:55
*** mdnadeem_ has joined #openstack-nova13:56
*** mriedem has joined #openstack-nova13:56
*** jaypipes has joined #openstack-nova13:57
*** mdnadeem has quit IRC13:58
*** jpena|lunch is now known as jpena13:58
*** peter-hamilton has joined #openstack-nova13:58
*** links has quit IRC13:58
*** links has joined #openstack-nova14:00
*** xyang1 has joined #openstack-nova14:00
*** lyan has joined #openstack-nova14:01
openstackgerritChen Hanxiao proposed openstack/nova master: libvirt: guest: introduce blockStats instead of domain.blockStats  https://review.openstack.org/52683314:01
cdentedleafe: are you actually asking for changes on that commit message or just pointing out some potential changes if there's another version. On the random stuff I'm not sure that your version is more clear, at least not to me.14:02
edleafecdent: Well, you *did* push another version :)14:02
*** shaner has quit IRC14:02
cdentyeah, and totally forgot the commit message stuff because I was focused on the merge conflict (and forgot about your suggestions because no vote)14:03
*** salv-orlando has joined #openstack-nova14:03
edleafecdent: The random comment simply seemed to describe the implementation rather than the effect of changing the settings14:03
*** liuyulong has joined #openstack-nova14:04
cdentright, the commit message is for describing the implementation, the conf help and the reno are for describing why/how someone might use the conf setting14:04
*** liusheng has quit IRC14:04
*** links has quit IRC14:05
*** liusheng has joined #openstack-nova14:05
*** BryanS68 has quit IRC14:06
*** salv-orl_ has quit IRC14:06
*** BryanS68 has joined #openstack-nova14:07
*** sree has joined #openstack-nova14:07
*** s1061123 has quit IRC14:09
mriedemgibi: replied to your questions in https://review.openstack.org/#/c/507473/14:10
*** sree has quit IRC14:12
openstackgerritKashyap Chamarthy proposed openstack/nova master: conf: libvirt: Cleanup CPU modelling related options  https://review.openstack.org/52769114:13
stephenfinkashyap: Per ^, you'll probably like this https://review.openstack.org/#/c/526012/14:16
* kashyap clicks14:17
*** smatzek has quit IRC14:19
kashyapstephenfin: OCD: If you have to respin, please captialize the proper noun: s/nova/Nova/ :-)14:21
stephenfinkashyap: Ahem https://docs.openstack.org/doc-contrib-guide/writing-style/openstack-components.html14:21
stephenfinMy OCD trumps yours14:21
kashyapHaha14:22
gibimriedem: thanks for the answers, I'm +2 now14:22
kashyapOkay, my brain just feels a twitch when a sentence starts with a smaller case letter.14:22
mriedemgibi: cool. i'm going to update the nits in the last change in the series too just to get that going14:22
mnasermdbooth: thanks for the informative text. The more I look into this the more I see that it’s too much for me to bite to make that image backend change14:23
mdboothmnaser: Hopefully that's not true. I'd just say don't underestimate the size of the chunk :)14:24
mdboothAnd I completely agree with your initial conclusion.14:24
mnasermdbooth: the thing is we’re fairly pressed on time and a change like this would probably take a long time to get through14:25
kashyapstephenfin: Nice Olso change in that; Zuul seems to complain for tox-py35, must've noticed it14:25
mdboothOh, right.14:25
mdboothYeah, this isn't going to be a quick fix.14:25
stephenfinkashyap: I did indeed. I'll be fixing it shortly14:25
gibimriedem: hit me with the link when you are done and we can push the last patch through as well14:25
mnaserFiguring out how to work with Glance and multiple locations seems far more feasable. I think.14:26
mdboothmnaser: Although, the current state of that code is the sum of a bunch of quick fixes...14:26
kashyapstephenfin: Thanks for the fast +2 on that change!14:26
openstackgerritBalazs Gibizer proposed openstack/nova master: Add sample test for instance audit  https://review.openstack.org/48095514:26
*** baoli has joined #openstack-nova14:26
*** s1061123 has joined #openstack-nova14:26
stephenfinkashyap: np. Doc fixes like that easy-peasy14:26
mnasermdbooth: I think the huge challenge would be maintaining those two formats on disk14:26
mnaserEssentially and possibly forever...14:27
mdboothReliably, and maintainably14:27
mnaserWe can’t assume the instances which are cloned from local cache will eventually disappear because we’d block upgrades.14:27
*** sree has joined #openstack-nova14:27
*** amodi has joined #openstack-nova14:28
*** gmann is now known as gmann_afk14:28
*** _ix has joined #openstack-nova14:28
*** gmann_afk is now known as gmann14:28
openstackgerritStephen Finucane proposed openstack/nova master: Add PCI NUMA policies  https://review.openstack.org/52747214:29
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Modify signature of _filter_non_requested_pfs  https://review.openstack.org/52747314:29
kashyapstephenfin: I'll answer your question on the review14:29
*** sree has quit IRC14:32
openstackgerritBalazs Gibizer proposed openstack/nova master: Wait for live_migration_rollback.end notification  https://review.openstack.org/52744414:34
*** _ix has quit IRC14:34
kashyapstephenfin: Is it just me, or the rendered page looks like full of "alerts" with the red colour -- https://docs.openstack.org/nova/pike/configuration/config.html14:35
kashyapThe whole config page looks like an "exceptions" page14:35
stephenfinkashyap: Are you referring to the titles of each options or the 'warning' admonitions?14:35
*** openstackstatus has quit IRC14:36
kashyapThe 'warning' admonitions, and every option enumerated in red color14:36
stephenfinThe warning options are warranted - we don't want people using those as they're deprecated14:36
kashyap(Looking at that really messing with my briain :-)  I'll just stick to looking at the code.)14:36
kashyapThe warnings are fine14:36
stephenfinand we've been removing deprecated options at a decent clip, though it's low priority14:37
kashyapBut the options should be changed to 'lime green' or something saner14:37
stephenfinThe other stuff is the fault of openstackdocstheme, I'm afraid14:37
*** lbragstad has joined #openstack-nova14:37
*** openstackstatus_ has joined #openstack-nova14:37
kashyapOkido; no worries.14:37
stephenfinI'm not sure what colour I _would_ use though, tbh14:37
*** openstackstatus_ has quit IRC14:37
*** openstack has quit IRC14:39
*** openstack has joined #openstack-nova14:41
*** ChanServ sets mode: +o openstack14:41
mriedemat some point i (or someone) should follow the pattern yikun has here for the 2.57 samples and do those for the 2.1 and 2.51 samples14:42
mriedemand use real operations rather than fakes14:42
mriedemi've always hated that we use fakes for the instance action api samples14:43
*** openstack has quit IRC14:43
*** openstack has joined #openstack-nova14:46
*** ChanServ sets mode: +o openstack14:46
openstackgerritStephen Finucane proposed openstack/nova master: Remove dead parameter from '_create_domain_and_network'  https://review.openstack.org/51235214:46
*** burt has joined #openstack-nova14:46
*** felipemonteiro has joined #openstack-nova14:47
*** sree has joined #openstack-nova14:47
*** felipemonteiro_ has joined #openstack-nova14:48
*** alexchadin has quit IRC14:50
*** kumarmn has joined #openstack-nova14:52
*** felipemonteiro has quit IRC14:52
*** tosky has joined #openstack-nova14:52
*** sree has quit IRC14:53
gibimriedem: indeed it looks a lot cleaner now, I approved it14:53
mriedemgibi: cool, thanks14:54
mriedemone more down14:54
*** pchavva has joined #openstack-nova14:55
*** awaugama has joined #openstack-nova14:55
*** marst has joined #openstack-nova14:56
*** tbachman has quit IRC14:57
*** armax has joined #openstack-nova14:57
*** tbachman has joined #openstack-nova14:58
*** mlavalle has joined #openstack-nova15:01
*** josecastroleon1 has quit IRC15:02
*** sree has joined #openstack-nova15:02
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: see what else is doing useless migration context stuff  https://review.openstack.org/47149115:04
*** janki has quit IRC15:04
*** Tom-Tom_ has quit IRC15:05
*** yamahata has joined #openstack-nova15:06
*** gouthamr has joined #openstack-nova15:06
*** udesale has quit IRC15:07
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Change CONF.my_ip to be IPOpt  https://review.openstack.org/49809515:07
*** sshwarts has quit IRC15:08
*** josecastroleon has joined #openstack-nova15:08
*** bkopilov has joined #openstack-nova15:12
niraj_singhefried_cya_jan: in cinder to nova interaction using service token. I am getting roles': [u'Member'], for service user in nova.15:14
niraj_singhefried_cya_jan: I was logged in as admin. Is there anything need to do to assign role to service user.15:15
jaypipesniraj_singh: Eric is out until January (thus his nick is efried_cya_jan) :)15:17
niraj_singhooh sorry15:17
jaypipesniraj_singh: not a problem. you will likely need more roles than "Member" for the cinder service user.15:17
*** links has joined #openstack-nova15:19
niraj_singhjaypipes: can i assign role to service user explicitlely?15:19
*** smatzek has joined #openstack-nova15:20
*** claudiub has quit IRC15:21
*** salv-orlando has quit IRC15:21
*** edmondsw has joined #openstack-nova15:21
jaypipesniraj_singh: hmm, I *think* you should be able to do that, yes. via Keystone...15:23
jaypipesniraj_singh: you'll want to restart the nova services after that, though, since the token will be cached in the Nova services.15:23
niraj_singhjaypipes: ok. i will try this.15:23
niraj_singhthanks15:23
dansmithjaypipes: you gonna rev that patch that needs the comment added?15:24
dansmithjaypipes: sounds like modulo those nits gibi and I are ready to send it to heaven15:24
*** tidwellr has joined #openstack-nova15:25
*** READ10 has joined #openstack-nova15:26
*** moshele has quit IRC15:26
*** toabctl has joined #openstack-nova15:27
*** dosaboy has quit IRC15:28
mriedemstephenfin: your comment in https://review.openstack.org/#/c/523919/ - i think the code your pointing at has nothing to do with what i'm removing in that patch15:28
*** dosaboy has joined #openstack-nova15:28
*** BryanS68 has quit IRC15:29
*** sapcc-bot has quit IRC15:29
*** dgonzalez_ has joined #openstack-nova15:30
*** tpatzig_ has joined #openstack-nova15:30
*** mkoderer_ has joined #openstack-nova15:30
stephenfinmriedem: It's quite possible. The thing that put me onto that was that we _were_ storing 'self.extra_info' in the line you're removing, but once that's removed we don't appear to use it anywhere15:30
*** sapcc-bot has joined #openstack-nova15:30
stephenfinergo, I figure the storing aspect should be removed to15:30
stephenfinMaybe I missed something though. I'm looking at that commit you referenced now15:30
mriedemstephenfin: it's called from PciDevice.create() https://review.openstack.org/#/c/523919/2/nova/objects/pci_device.py@23415:31
*** tbachman has quit IRC15:31
mriedemwhich will dirty the extra_info field15:31
mriedemso that it gets save()'d later15:31
mriedemupdates = self.obj_get_changes()15:31
mriedemwill contain extra_info15:31
mriedemhence this note in update_device:15:31
mriedem# NOTE(yjiang5): extra_info.update does not update15:31
mriedem                # obj_what_changed, set it explicitly15:31
*** mkoderer_ has quit IRC15:31
*** tpatzig_ has quit IRC15:31
*** dgonzalez_ has quit IRC15:31
*** tbachman has joined #openstack-nova15:32
openstackgerritMerged openstack/nova master: Stabilize test_live_migration_abort func test  https://review.openstack.org/52744015:32
mriedemdansmith: melwitt: here is the marker not found fix for the build_requests thing that came up yesterday https://review.openstack.org/#/c/527564/15:34
openstackgerritBalazs Gibizer proposed openstack/nova master: Transform instance.exists notification  https://review.openstack.org/40366015:35
openstackgerritBalazs Gibizer proposed openstack/nova master: Add sample test for instance audit  https://review.openstack.org/48095515:35
*** edand has quit IRC15:36
openstackgerritBalazs Gibizer proposed openstack/nova master: Add regression test for bug 1735407  https://review.openstack.org/52609515:36
openstackbug 1735407 in OpenStack Compute (nova) "[Nova] Evacuation doesn't respect anti-affinity rules" [Medium,In progress] https://launchpad.net/bugs/1735407 - Assigned to Balazs Gibizer (balazs-gibizer)15:36
dansmithmriedem: ack15:36
openstackgerritBalazs Gibizer proposed openstack/nova master: Add late server group policy check to rebuild  https://review.openstack.org/52524215:36
jaypipesdansmith: ya, lemme do that right quick. thanks for the reminder15:36
mriedemdansmith: left a comment in there about something i was thinking about last night wrt getting the build request via the marker up front and then being smarter about getting the build requests that come *after* that marker, rather than getting all of the build requests first, filtering them and then throwing out a bunch - which seems really inefficient15:37
mriedembut my brain hasn't quite been able to put together how that could work15:37
mriedemdansmith: also, i wonder if some of this is why the build request stuff didn't play so nice with your new instance_list stuff + paging15:38
dansmithwell we have to filter them based on the json property so we kinda have to load them all right?15:38
mriedemwe can find the marker up front but i don't know if that helps us15:38
dansmithmriedem: it's because of ^ that it was less easy to add15:38
dansmithit doesn't because we still have to load them all to figure out where to start after the marker15:38
mriedemsure,15:38
mriedemhow about this as an optimization though,15:39
dansmithso could be one shortcut we could add maybe, but..15:39
*** sree has quit IRC15:39
*** damien_r has quit IRC15:39
mriedemif we have a marker, get the build request up front and if not found, bail early15:39
mriedemthat would avoid the get_all())15:39
*** _ix has joined #openstack-nova15:39
mriedemchances are we aren't going to find a marker in the build request in most cases i wouldn't think15:39
*** sree has joined #openstack-nova15:39
dansmithit's more round trips to the db, and getting the marker ahead of time doesn't really help us select a smaller get_all()15:40
dansmithso I'm not sure it's really worth it, TBH, but.. if you think it's better15:40
dansmithso imagine this scenario:15:40
dansmithnova boot --min-instances=100, followed by a paged list of tens of instances per page15:40
dansmiththat could be a couple minutes where your markers are in the build requests15:40
mriedemtrue15:41
mriedemuntil the public cloud guys tell me in 18 months that we're spending too much time paging over build requests, i'll leave this alone :)15:41
dansmithaye15:42
stephenfinmriedem: OK, I know where I went wrong. Re-reviewed now15:42
*** Sukhdev_ has joined #openstack-nova15:43
stephenfindansmith: Mind reminding me why we don't do stuff like this with o.vo objects? https://review.openstack.org/#/c/523919/2/nova/objects/pci_device.py@17715:43
mriedemstephenfin: cool thanks15:43
*** yamahata has quit IRC15:43
stephenfinIt was the reason for this whole series https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/163633815:43
*** sree has quit IRC15:43
mriedemstephenfin: could just be laziness on the part of the consuming code,15:44
mriedemi.e. instead of the calling code checking "if 'extra_info' in pci_device'"15:44
dansmithstephenfin: it means that objects default to something being set that may not match what is in the database. so, if I wanted to do something like this:15:44
dansmithd = objects.PciDevice(id=123, label="new_label"); d.save(), we would overwrite extra_info in the database with an empty dict15:45
dansmithmay not apply directly to this situation, but that's the pattern we've got elsewhere and it's super confusing to have some of them work like that, and others have silent defaults for some fields15:46
mriedemstephenfin: also without that self.extra_info = {} in __init__, if you called PciDevice.create(), we'd fail here https://review.openstack.org/#/c/523919/2/nova/objects/pci_device.py@16815:46
stephenfinmriedem: yeah, you'd have to harden that to include 'if 'extra_info' in self:' or the likes15:47
*** armax has quit IRC15:47
mriedemthat should really probably be something like, "if 'extra_info' in self: extra_info = self.extra_info else: extra_info = {}"15:48
stephenfinI'd to do sooo much of that in aforementioned series15:48
stephenfinmriedem: ++15:48
*** brault has joined #openstack-nova15:49
*** edmondsw has quit IRC15:50
stephenfinOh, also, thanks for the re-explanation dansmith15:50
dansmithnp15:50
*** edmondsw has joined #openstack-nova15:50
*** udesale has joined #openstack-nova15:51
*** udesale has quit IRC15:51
openstackgerritStephen Finucane proposed openstack/nova master: objects: remove related pinning from __init__ of InstanceNUMATopology  https://review.openstack.org/48555415:52
openstackgerritStephen Finucane proposed openstack/nova master: objects: remove cpuset_reserved from __init__ of InstanceNUMATopology  https://review.openstack.org/46603015:52
*** josecastroleon has quit IRC15:53
dansmith<315:53
*** edmondsw has quit IRC15:54
openstackgerritJay Pipes proposed openstack/nova master: handle traits with sharing providers  https://review.openstack.org/51711915:56
openstackgerritJay Pipes proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs  https://review.openstack.org/51938015:56
openstackgerritJay Pipes proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs  https://review.openstack.org/51961715:56
openstackgerritJay Pipes proposed openstack/nova master: Test allocation candidates: multiple aggregates  https://review.openstack.org/51863315:56
openstackgerritJay Pipes proposed openstack/nova master: Test helper: validate provider summaries  https://review.openstack.org/51898215:56
openstackgerritJay Pipes proposed openstack/nova master: Fix accumulated nits in refactor series  https://review.openstack.org/52118915:56
openstackgerritJay Pipes proposed openstack/nova master: Add aggregates check in allocation candidates  https://review.openstack.org/52240715:56
openstackgerritJay Pipes proposed openstack/nova master: Fix missing rps in allocation candidates  https://review.openstack.org/52240915:56
openstackgerritJay Pipes proposed openstack/nova master: placement: func tests for multiple shared RPs  https://review.openstack.org/49873715:56
jaypipesdansmith, gibi: voila. ^15:56
*** udesale has joined #openstack-nova15:58
*** cdent has quit IRC15:58
*** Sukhdev has joined #openstack-nova16:00
gibijaypipes: looking16:00
*** Alex_Staf has quit IRC16:01
openstackgerritLajos Katona proposed openstack/nova master: WIP: Add nested resources to server moving tests  https://review.openstack.org/52772816:01
*** udesale has quit IRC16:01
*** sapcc-bot has quit IRC16:02
gibijaypipes: +2 from me16:02
*** tpatzig_ has joined #openstack-nova16:02
*** sapcc-bot has joined #openstack-nova16:02
*** dgonzalez_ has joined #openstack-nova16:02
*** mkoderer_ has joined #openstack-nova16:03
*** rmart04 has quit IRC16:04
*** tpatzig_ has quit IRC16:04
*** dgonzalez_ has quit IRC16:04
*** mkoderer_ has quit IRC16:05
*** Apoorva has joined #openstack-nova16:06
*** tbachman has quit IRC16:09
openstackgerritEric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI  https://review.openstack.org/52609416:10
*** jaypipes is now known as jay_tampa16:10
*** edand has joined #openstack-nova16:10
*** dave-mccowan has quit IRC16:11
dansmithjay_tampa: +W on the bottom three.. I had a question on Bottom-4 that you didn't answer16:14
*** erlon has joined #openstack-nova16:17
*** armax has joined #openstack-nova16:18
*** claudiub has joined #openstack-nova16:20
*** armax has quit IRC16:21
*** dklyle has joined #openstack-nova16:21
*** sree has joined #openstack-nova16:27
*** claudiub has quit IRC16:29
*** artom has quit IRC16:31
*** sree has quit IRC16:31
*** moshele has joined #openstack-nova16:36
*** r-daneel has quit IRC16:37
*** lpetrut has quit IRC16:38
*** tssurya has quit IRC16:38
*** salv-orlando has joined #openstack-nova16:40
*** Sukhdev has quit IRC16:40
stephenfinmoshele: Just the man I'm looking for. What's the possibility that you could take a look at https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/share-pci-between-numa-nodes ?16:41
*** BryanS68 has joined #openstack-nova16:43
*** klindgren has joined #openstack-nova16:44
*** AlexeyAbashkin has quit IRC16:47
moshelestephenfin: will do, but tomorrow16:47
stephenfinmoshele: No problem. Thanks :)16:47
*** tosky has quit IRC16:48
*** moshele has quit IRC16:49
*** fragatina has joined #openstack-nova16:49
klindgrenHello, Working on setting up a new pike cloud with cellsv2 running on it.  and trying to get a list of services that need to be ran at each level.  I found https://docs.openstack.org/nova/latest/user/cellsv2-layout.html.  But I just want to confirm.  So at the Top level API cell.  I need to run: nova-api, nova-consoleauth, nova-spicehtml5proxy, nova-conductor, API rabbitmq, API DB, Cell0 DB.  Then in each cell I need to r16:50
klindgrenun: Cell rabbitmq, nova-conductor, nova-computes (attached to the cell rmq), cell DB.  Now in cellv1 we run nova-manage at both the api cell and the child cell level.  I assume the same is required with cellsv2?16:50
dansmithklindgren: ye[16:52
dansmither yup16:52
klindgrenSo all thats need in child cells now is nova-conductor16:52
dansmithand compute :)16:53
mriedemscheduler is top level16:53
mriedemdidn't see that in your list16:53
dansmithoh yeah16:54
dansmithyou will want a scheduler16:54
klindgrenand placement16:54
*** tbachman has joined #openstack-nova16:54
mriedemyes16:54
mriedemplacement is assumed to be global16:54
mriedemcern is doing it per-cell to start16:55
mriedemi think for perf reasons16:55
mriedemif you're not at cern scale, global is your long-term friend16:55
mriedemimo16:55
dansmithyup16:55
cfriesen__Is it possible to reset specific individual tenant quotas back to the default value?  (by writing -1 to them, maybe?)   What about specific user/tenant quotas?  (The code there makes it look like you can't set the max to more than the custom tenant quota.)16:56
melwittexcept for console proxies, after they move (because they'll need cell database access and don't have instance uuid)16:57
mriedemcfriesen__: once you start overriding default quotas for a tenant, you're stuck16:57
mriedemunless you remove those entries from the db16:57
melwittcfriesen__: writing -1 will make them unlimited, so that's not what you want either16:57
mriedemremember that the lookup order for quota is (1) per-project quota table (2) global quota_classes table, (3) config16:58
mriedemso you'd have to remove (1)16:58
klindgrendo you guys have a blog post or something that explains all the nova-manage commands to run now to setup cellsv2?16:58
melwittyup, that16:58
mriedemklindgren: https://docs.openstack.org/nova/latest/user/cells.html16:58
mriedemklindgren: there is basic setup stuff in there and in the install guide16:59
mriedemthe cellsv1->v2 portion is admittedly light16:59
mriedemklindgren: and you know about https://etherpad.openstack.org/p/cellsv1-to-v2-migration16:59
cfriesen__mriedem: so we have a way to remove *all* per-tenant quotas, but no way to remove individual ones?17:00
klindgrenyea - right now just getting a pike cloud with all the new features enabled on it (cellsv2, network aware placement, neutron routed networks, ect ect).  So we can start working on the migration to that.  So not currently concerned with cellsv1 -> cellv217:00
mriedemcfriesen__: this ?https://developer.openstack.org/api-ref/compute/#revert-quotas-to-defaults17:00
mriedemklindgren: ack17:00
cfriesen__mriedem: yeah.  so you can revert all the quotas for a tenant back to defaults, and you can override specific quotas, but you can't revert specific quotas back to defaults17:01
mriedemcfriesen__: yes correct, https://developer.openstack.org/api-ref/compute/#revert-quotas-to-defaults removes all of the per-tenant quota17:01
mriedemcfriesen__: you'd need like a DELETE /os-quota-sets/{tenant_id}/{quota_key} or something17:01
*** chyka has joined #openstack-nova17:01
mriedemwhich we don't have17:01
cfriesen__right.  okay, thanks17:02
klindgrenmriedem, thanks for the link, I thought I looked at this, but I guess I just didn't scroll down enough :-/17:02
mriedemklindgren: that reminds me of something sdague posted recently,17:04
mriedemat this point, we should probably move the 'setup of cellsv2 and faqs' to the top of page17:04
mriedemand the cellsv1/v2 manifesto to the bottom of page17:04
mriedemso people don't glaze over the content looking for install instructions17:04
*** brault has quit IRC17:04
melwittI think that's a good idea17:04
*** jdillaman has quit IRC17:05
mriedemi can take a shot at that re-org in a bit17:05
*** Tom-Tom has joined #openstack-nova17:05
openstackgerritMerged openstack/python-novaclient master: Optimize jobs run on novaclient  https://review.openstack.org/52755017:05
*** Sukhdev has joined #openstack-nova17:06
*** sree has joined #openstack-nova17:07
*** Sukhdev has quit IRC17:08
*** amodi has quit IRC17:09
melwittmriedem: I have a question regarding my consoles series. because console proxies run globally in devstack, the top patch in my series fails and then passes on the devstack Depends-On patch https://review.openstack.org/#/c/484973/ that moves proxies per cell (which is expected). would you recommend I instead make the top patch Depends-On the devstack patch to set things up properly?17:09
*** yangyapeng has joined #openstack-nova17:09
*** xyang1 has quit IRC17:09
*** Tom-Tom has quit IRC17:09
*** r-daneel has joined #openstack-nova17:10
mriedema bit confused,17:11
*** Apoorva has quit IRC17:11
mriedemi'd think we would change devstack to run the console proxy service per-cell if we're in superconductor mode17:11
mriedemelse globally for singleconductor?17:12
*** Apoorva has joined #openstack-nova17:12
melwittyeah, that's what I think I've done in my devstack patch17:12
mriedembut it's a chicken and egg isn't isn't it?17:12
melwittit's just that the current topology is console proxies at the top. my series will make it so console proxies need to be per cell17:12
melwittyeah17:12
mriedemthe per-cell nova patch can't work if devstack is using global17:12
mriedemso what happens if you changed devstack today to run consoleproxy per cell17:12
mriedemw/o a depends-on17:13
mriedemhow does it blow up17:13
melwittright. the current console stuff *might* probably work if deployed per cell because the storage is global17:13
melwittwell, I'm not sure actually17:13
mriedemso you probably need a 2-step dance17:13
*** yangyapeng has quit IRC17:13
melwittyeah, let me try that without a depends-on and see what happens17:13
mriedemif it's like one test in tempest that fails, we could maybe disable the test in tempest via config in devstack until we have the thing that makes it all work with the nova patch17:14
melwittI see. yeah, it is one test, the novnc test17:14
stephenfincfriesen__: This look like something you'd be interested in reviewing? https://review.openstack.org/#/c/527472/17:15
*** sree has quit IRC17:15
melwittmriedem: okay, let me try a run without depends-on in the devstack patch and see what blows up. thanks for the ideas17:15
*** tidwellr has quit IRC17:16
cfriesen__stephenfin: yep, will take a look17:16
*** tidwellr has joined #openstack-nova17:16
*** Apoorva has quit IRC17:16
mriedemmelwitt: ok then you could disable that in devstack/lib/tempest using CONF.compute_feature_enabled.vnc_console=False in tempest.conf17:20
mriedemmelwitt: so maybe disable that with a TODO saying if you're running per-cell console proxy, it won't work until the nova patch which a later devstack patch depends on and removes that tempest conf17:20
melwittaha, cool17:20
mriedemso devstack1->nova->devstack217:20
mriedemis the dep order i think17:20
mriedemif that works, you owe me a cream sodda17:21
mriedem*soda17:21
melwittheh, can do17:21
*** jpena is now known as jpena|brb17:24
*** yangyapeng has joined #openstack-nova17:24
*** andreas_s has joined #openstack-nova17:28
*** yangyapeng has quit IRC17:28
*** xyang1 has joined #openstack-nova17:29
*** armax has joined #openstack-nova17:30
*** mvk has quit IRC17:34
*** Apoorva has joined #openstack-nova17:36
*** dtantsur is now known as dtantsur|afk17:39
*** links has quit IRC17:40
*** archit has joined #openstack-nova17:40
*** lajoskatona has quit IRC17:40
*** archit is now known as amodi17:40
*** tbachman has quit IRC17:41
*** andreas_s has quit IRC17:43
*** jpena|brb is now known as jpena17:43
*** shaner has joined #openstack-nova17:45
*** xyang1 has quit IRC17:45
openstackgerritStephen Finucane proposed openstack/nova master: SchedulerReportClient._get_providers_in_aggregates  https://review.openstack.org/52109717:48
openstackgerritStephen Finucane proposed openstack/nova master: Traits ops on ProviderTree  https://review.openstack.org/52160517:48
openstackgerritStephen Finucane proposed openstack/nova master: Move aggregates from report client to ProviderTree  https://review.openstack.org/52168517:48
openstackgerritStephen Finucane proposed openstack/nova master: Track provider traits in report client  https://review.openstack.org/52168617:48
openstackgerritStephen Finucane proposed openstack/nova master: Track associated sharing RPs in report client  https://review.openstack.org/52653917:48
openstackgerritStephen Finucane proposed openstack/nova master: Raise on API errors getting aggregates/traits  https://review.openstack.org/52654017:48
openstackgerritStephen Finucane proposed openstack/nova master: ProviderTree.populate_from_iterable  https://review.openstack.org/52075617:48
openstackgerritStephen Finucane proposed openstack/nova master: Track tree-associated providers in report client  https://review.openstack.org/52654117:48
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree  https://review.openstack.org/52109817:48
openstackgerritStephen Finucane proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree()  https://review.openstack.org/52118717:48
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker  https://review.openstack.org/52024617:48
cfriesen__stephenfin:  the added comments are helpful17:48
stephenfincfriesen__: Good to hear. I got pretty bogged down in it myself yesterday and decided to add what I learned17:49
*** cfriesen__ is now known as cfriesen17:49
stephenfinI also noticed a fair chunk of duplication and the likes going on, e.g. https://github.com/openstack/nova/blob/master/nova/pci/stats.py#L148-L155 vs https://github.com/openstack/nova/blob/master/nova/pci/stats.py#L242-L24817:51
stephenfinGonna tackle that once this in in, hopefully17:51
*** yumapath has joined #openstack-nova17:53
yumapathhi all, am trying to launch a instance on devstack (queen's) and am getting the following error17:53
yumapathError: Failed to perform requested operation on instance "vm2", the instance has an error status: Please try again later [Error: No sql_connection parameter is established].17:54
yumapathwhat could be the possible reason17:54
*** claudiub has joined #openstack-nova17:54
yumapathgoogling did not yeild any useful results17:54
yumapathcan someone help17:54
*** mdnadeem_ has quit IRC17:54
*** xyang1 has joined #openstack-nova17:54
stephenfinyumapath: Looks like an oslo.db issue. You'd be better off asking about it on #openstack http://codesearch.openstack.org/?q=No%20sql_connection%20parameter%20is%20established&i=nope&files=&repos=17:55
yumapathok17:56
yumapaththanks17:56
*** yumapath has left #openstack-nova17:56
*** andreas_s has joined #openstack-nova17:59
*** claudiub has quit IRC17:59
*** baoli has quit IRC17:59
*** sree has joined #openstack-nova17:59
*** andreas_s has quit IRC17:59
*** baoli has joined #openstack-nova18:00
*** andreas_s has joined #openstack-nova18:00
*** lucasagomes is now known as lucas-afk18:00
*** lyan has quit IRC18:00
*** _ix has quit IRC18:00
*** lyan has joined #openstack-nova18:01
mriedemactually that's probably a superconductor issue18:03
stephenfinmelwitt: This is odd. What's going on here? https://review.openstack.org/#/c/325381/16/nova/tests/unit/compute/test_compute_mgr.py@27918:03
*** felipemonteiro_ has quit IRC18:03
*** derekh has quit IRC18:04
*** _ix has joined #openstack-nova18:04
*** andreas_s has quit IRC18:04
*** sree has quit IRC18:04
*** yangyapeng has joined #openstack-nova18:04
mriedemstephenfin: i sent yumapath here https://github.com/openstack-dev/devstack/blob/master/stackrc#L8018:04
mriedemand here https://docs.openstack.org/nova/latest/user/cellsv2-layout.html18:04
mriedemthey are likely failing on a reschedule18:05
stephenfinI just realized I'm not actually on that channel18:06
mriedemi'm not either usually18:06
*** ralonsoh has quit IRC18:06
mriedemunless someone comes here with a problem and we shoo them off and i think i have an answer18:06
stephenfinHeh, fair. I figured it was a lack of a configuration option that oslo.db cared about18:07
mriedemwith devstack that's pretty hard to screw up18:07
mriedemunless you messed with stuff18:07
*** yangyapeng has quit IRC18:09
*** Swami has joined #openstack-nova18:11
fricklermriedem: stephenfin: https://bugs.launchpad.net/nova/+bug/173393318:11
openstackLaunchpad bug 1733933 in OpenStack Compute (nova) "nova-conductor is masking error when rescheduling" [Undecided,Confirmed]18:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration  https://review.openstack.org/52754118:12
mriedemdtantsur|afk: dansmith: edleafe: ^ now with tests and docsy things18:12
mriedemfrickler: replied in the bug18:14
mriedemfrickler: if you rely on reschedules, you need to modify devstack18:14
*** josecastroleon has joined #openstack-nova18:14
fricklermriedem: I think that answers it only partially. even if the reschedule doesn't work, I want to see the error from n-cpu on the instance and not have it replaced by "No sql_connection parameter is established"18:17
*** AlexeyAbashkin has joined #openstack-nova18:17
*** mvk has joined #openstack-nova18:18
mriedemfrickler: ok fair enough, i re-opened it18:18
mriedembut now i'm off for my pre-holidays haircutting18:19
*** AlexeyAbashkin has quit IRC18:21
*** huanxie has quit IRC18:23
*** huanxie has joined #openstack-nova18:23
*** tbachman has joined #openstack-nova18:27
*** sridharg has quit IRC18:28
*** josecastroleon has quit IRC18:29
*** josecastroleon has joined #openstack-nova18:30
*** r-daneel_ has joined #openstack-nova18:31
*** r-daneel has quit IRC18:31
*** r-daneel_ is now known as r-daneel18:31
*** imacdonn_ has quit IRC18:35
*** imacdonn_ has joined #openstack-nova18:35
*** _ix has quit IRC18:39
*** dave-mccowan has joined #openstack-nova18:44
*** catintheroof has joined #openstack-nova18:44
*** yamamoto has quit IRC18:45
*** sree has joined #openstack-nova18:46
*** lpetrut has joined #openstack-nova18:49
*** jpena is now known as jpena|off18:49
*** sree has quit IRC18:53
*** adisky__ has quit IRC18:53
*** smatzek has quit IRC18:54
openstackgerritIldiko Vancsa proposed openstack/nova master: WIP: libvirt: Allow multiple volume attachments  https://review.openstack.org/26758718:58
openstackgerritIldiko Vancsa proposed openstack/nova master: WIP: Allow multi-attach in compute api  https://review.openstack.org/27104718:58
*** sree has joined #openstack-nova18:58
*** _ix has joined #openstack-nova18:59
*** yamamoto has joined #openstack-nova19:01
*** felipemonteiro has joined #openstack-nova19:02
*** sree has quit IRC19:03
*** felipemonteiro_ has joined #openstack-nova19:04
*** yamamoto has quit IRC19:06
*** sambetts is now known as sambetts|afk19:06
*** edand has quit IRC19:07
*** felipemonteiro has quit IRC19:08
*** edand has joined #openstack-nova19:09
openstackgerritIldiko Vancsa proposed openstack/nova master: WIP: libvirt: Allow multiple volume attachments  https://review.openstack.org/26758719:11
openstackgerritIldiko Vancsa proposed openstack/nova master: WIP: Allow multi-attach in compute api  https://review.openstack.org/27104719:11
*** lpetrut has quit IRC19:11
*** lajoskatona has joined #openstack-nova19:13
*** artom has joined #openstack-nova19:14
*** r-daneel_ has joined #openstack-nova19:15
*** r-daneel has quit IRC19:17
*** r-daneel_ is now known as r-daneel19:17
*** penick has joined #openstack-nova19:17
*** smatzek has joined #openstack-nova19:21
*** lajoskatona has quit IRC19:24
*** lajoskatona has joined #openstack-nova19:25
*** lpetrut has joined #openstack-nova19:25
*** josecastroleon has quit IRC19:26
*** openstackstatus has quit IRC19:27
openstackgerritMerged openstack/nova master: Change RPC for select_destinations()  https://review.openstack.org/51670719:27
openstackgerritMerged openstack/nova master: Move the claim_resources method to scheduler utils  https://review.openstack.org/51135719:27
openstackgerritMerged openstack/nova stable/ocata: fix nova accepting invalid availability zone name with ':'  https://review.openstack.org/50965919:27
*** josecastroleon has joined #openstack-nova19:28
*** Sukhdev has joined #openstack-nova19:28
*** lpetrut has quit IRC19:32
*** lpetrut has joined #openstack-nova19:35
*** gbarros has joined #openstack-nova19:38
mriedemTheJulia: would you happen to know if there is an ironic grenade job that runs with resource classes?19:41
mriedemi'd like to run that against https://review.openstack.org/#/c/527541/19:41
TheJuliaI don't believe so... checking19:42
*** fragatina has quit IRC19:43
mriedemhmm, doesn't look like the ironic grenade job runs the nova-status command anyway19:43
mriedemcompare http://logs.openstack.org/41/527541/1/check/legacy-grenade-dsvm-neutron-multinode/51ed76a/logs/grenade.sh.txt.gz#_2017-12-13_04_12_18_91019:43
mriedemto http://logs.openstack.org/75/527075/1/check/ironic-grenade-dsvm-multinode-multitenant/2db59eb/logs/grenade.sh.txt.gz19:43
mriedemi'll push an ironic patch to test things out19:43
*** fragatina has joined #openstack-nova19:43
TheJuliamriedem: looks like we do set/use the resource class19:46
*** andreas_s has joined #openstack-nova19:46
TheJuliabut we also set the mem/cpu/etc with a value of 0 for the flavor19:46
mriedemyeah that's fine19:47
mriedemthis check would only fail if the node.resource_class isn't set i think19:47
mriedemotherwise we'll migrate that node.resource_class into the instance.flavor.extra_specs19:48
TheJuliawe will likely want to publish a release note on ironic to stress that it MUST be set then19:49
TheJuliaWell, we've done that before, but now we really really mean it19:49
mriedemyou don't have to do that until nova drops the migration code19:49
mriedemand we can't do that until we have at least this nova-status check to tell people if they are done with the migration19:50
mriedembut yeah this is to try and get the ball rolling19:50
mriedemhmm19:51
*** yamahata has joined #openstack-nova19:51
mriedemwhy doesn't this ironic multinode grenade job upgrade nova?19:51
mriedemhttp://logs.openstack.org/75/527075/1/check/ironic-grenade-dsvm-multinode-multitenant/2db59eb/logs/grenade.sh.summary.txt.gz19:51
mriedemthis other one does http://logs.openstack.org/75/527075/1/check/ironic-grenade-dsvm/41ce7b3/logs/grenade.sh.summary.txt.gz so i guess that's the one i care about19:51
mriedemok here we go http://logs.openstack.org/75/527075/1/check/ironic-grenade-dsvm/41ce7b3/logs/grenade.sh.txt.gz#_2017-12-11_22_49_15_16619:52
*** andreas_s has quit IRC19:52
mriedemcool19:52
ildikovmriedem: hi19:52
TheJuliaoh, holdover from the old multinode scenario19:52
ildikovmriedem: just wanted to give a heads up that I did some fix up on the libvirt patch for multi-attach19:52
TheJuliaone node should be getting upgraded if I remember correctly19:52
ildikovmriedem: I will move up the support-matrix changes in the chain19:53
ildikovmriedem: if you could take a look on that patch and see whether it's on the right track that would be great and then I can look into the locking in a follow patch on top of that one19:53
ildikovmriedem: tnx :)19:53
*** edand has quit IRC19:53
*** moshele has joined #openstack-nova19:57
*** shaner has quit IRC19:58
*** shaner has joined #openstack-nova20:07
*** yamamoto has joined #openstack-nova20:09
*** Sukhdev_ has quit IRC20:12
*** liverpooler has quit IRC20:17
*** lajoskatona has quit IRC20:18
*** yamamoto has quit IRC20:18
*** chyka has quit IRC20:21
*** chyka has joined #openstack-nova20:21
*** josecastroleon has quit IRC20:24
mriedemcfriesen: what can you tell me about https://blueprints.launchpad.net/nova/+spec/numa-node-pinning ?20:27
*** openstackstatus has joined #openstack-nova20:28
*** ChanServ sets mode: +v openstackstatus20:28
*** _ix has quit IRC20:28
mriedemcfriesen: are you guys carrying something for that?20:29
mriedemseems like nested resource providers could help here20:29
*** gbarros has quit IRC20:31
*** yamahata has quit IRC20:32
*** vivsoni_ has quit IRC20:40
*** vivsoni_ has joined #openstack-nova20:40
*** amotoki has quit IRC20:43
*** thingee has quit IRC20:43
*** logan- has quit IRC20:43
*** johnthetubaguy has quit IRC20:43
*** logan- has joined #openstack-nova20:43
*** amotoki has joined #openstack-nova20:44
*** thingee has joined #openstack-nova20:44
*** gouthamr has quit IRC20:45
*** johnthetubaguy has joined #openstack-nova20:45
*** ericyoung has quit IRC20:45
*** awaugama has quit IRC20:47
*** gszasz has quit IRC20:47
*** Anticime1 is now known as Anticimex20:48
mriedemcfriesen: our product team is also interested in the use case in ^ - i copied in what my response was to them in the whiteboard20:48
mriedemsounds like red hat is also interested but i don't have membership in the bugzilla ACL20:49
mriedemhttps://bugzilla.redhat.com/show_bug.cgi?id=151962120:49
openstackmriedem: Error: Error getting bugzilla.redhat.com bug #1519621: NotPermitted20:49
*** ericyoung has joined #openstack-nova20:50
openstackgerritMatt Riedemann proposed openstack/nova master: Update nova-status and docs for nova-compute requiring placement 1.14  https://review.openstack.org/52650520:53
*** tssurya has joined #openstack-nova20:54
*** penick has quit IRC21:00
*** fragatina has quit IRC21:01
*** sree has joined #openstack-nova21:07
openstackgerritMerged openstack/nova master: Deprecate file injection  https://review.openstack.org/52202721:08
mriedemooo eff yeah21:10
*** sree has quit IRC21:11
mriedemyikes 500 from placement http://logs.openstack.org/64/527564/1/gate/legacy-tempest-dsvm-py35/7db2d64/logs/screen-n-sch.txt.gz#_Dec_13_17_07_40_97710321:12
*** tssurya has quit IRC21:13
mriedemwth, tracing req-c9d0d841-a466-4b8a-aea1-aae993781b4f we get a NoValidHost,21:13
mriedemhttp://logs.openstack.org/64/527564/1/gate/legacy-tempest-dsvm-py35/7db2d64/logs/screen-n-super-cond.txt.gz#_Dec_13_17_07_41_00739521:13
mriedembut looking at that in the scheduler logs, we don't even hit the filters for that request21:14
mriedemhttp://logs.openstack.org/64/527564/1/gate/legacy-tempest-dsvm-py35/7db2d64/logs/screen-n-sch.txt.gz#_Dec_13_17_07_40_52985521:14
mriedemright around the time that request is starting to run in the scheduler, another one blows up with a 500 response from placement21:14
mriedembut those should be separate threads yeah?21:15
mriedemedleafe: ^ you see anything suspicious in here?21:15
*** catintheroof has quit IRC21:15
*** catintheroof has joined #openstack-nova21:15
mriedemso uh21:16
mriedemhttp://logs.openstack.org/64/527564/1/gate/legacy-tempest-dsvm-py35/7db2d64/logs/screen-placement-api.txt.gz#_Dec_13_17_07_40_96832121:16
mriedemthat doesn't look good21:16
mriedemjay_tampa: ^21:16
*** threestrands has joined #openstack-nova21:18
*** threestrands has quit IRC21:18
*** threestrands has joined #openstack-nova21:18
*** catintheroof has quit IRC21:19
*** smatzek has quit IRC21:20
*** smatzek has joined #openstack-nova21:20
*** smatzek has quit IRC21:20
mriedemsdague: you wanna just push this through? https://review.openstack.org/#/c/519458/21:20
mriedemit sucks not being able to e-r check placement logs21:21
mriedemoh maybe that's not an issue anymore21:21
sdagueit shouldn't impact e-r21:22
*** penick has joined #openstack-nova21:22
sdagueoh, actually maybe it does21:22
sdagueotherwise you get DEBUG logs, which overload it21:22
mriedemlogstash appears to be finding these21:23
mriedemhttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22DBDeadlock%5C%22%20AND%20tags%3A%5C%22screen-placement-api.txt%5C%22%20AND%20voting%3A1&from=7d21:23
mriedemi think the logstash problem with placement logs is multiline21:24
mriedemyeah, i can't do message:"DBDeadlock" AND message:"_trait_sync"21:24
mriedemclarkb: can we get https://review.openstack.org/#/c/519458/ in so i can do multiline queries on placement logs?21:24
*** pramodrj07 has joined #openstack-nova21:24
mriedemor maybe ^ doesn't fix that either...21:25
clarkbmriedem: the filename does have screen in it right?21:29
clarkbmriedem: so thats a valid fix regardless?21:29
clarkbmriedem: as for multiline queries I would guess that is more a failing of the logstash parsing rules particularly for multiline events21:29
mriedemclarkb: i definitely don't get the nice log level filters on the placement logs today21:30
clarkbmriedem: ya thats going to be the chagne you linked then21:30
mriedemi'm unable to live without log level filters21:30
*** cleong has quit IRC21:35
*** moshele has quit IRC21:37
edleafemriedem: no idea what's causing that error21:38
mriedemedleafe: the dbdeadlock error in placement is causing the 500 in the scheduler logs,21:39
mriedemi just can't figure out why that also aborts the other request21:39
mriedemwhich should be on a different thread21:39
mriedemhttps://bugs.launchpad.net/nova/+bug/173808321:39
openstackLaunchpad bug 1738083 in OpenStack Compute (nova) "DBDeadlock when when syncing traits in Placement during list_allocation_candidates" [High,Triaged]21:39
edleafemriedem: yeah, I meant the deadlock21:39
mriedemtraits sync21:39
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI for traits (v1.6)  https://review.openstack.org/51464321:41
openstackgerritAndrey Volkov proposed openstack/osc-placement master: Resource class set (v1.7)  https://review.openstack.org/51464421:41
openstackgerritAndrey Volkov proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9)  https://review.openstack.org/51464621:41
openstackgerritAndrey Volkov proposed openstack/osc-placement master: CLI allocation candidates (v1.10)  https://review.openstack.org/51464721:41
openstackgerritAndrey Volkov proposed openstack/osc-placement master: [WIP] Get resource provider by uuid or name  https://review.openstack.org/52779121:41
*** penick_ has joined #openstack-nova21:41
*** penick has quit IRC21:42
mriedemthis reminds me,21:42
mriedemwe should run multiple scheduler workers (2) in our CI21:42
mriedembecause we said we can since pike21:42
edleafemriedem: since we're only expecting db_exc.DBDuplicateEntry, not a DBDeadlock21:42
*** sree has joined #openstack-nova21:47
*** baoli has quit IRC21:48
*** baoli has joined #openstack-nova21:48
*** artom has quit IRC21:48
*** awaugama has joined #openstack-nova21:50
*** sree has quit IRC21:51
*** AlexeyAbashkin has joined #openstack-nova21:54
*** klindgren_ has joined #openstack-nova21:54
*** klindgren has quit IRC21:57
*** pchavva has quit IRC21:57
*** AlexeyAbashkin has quit IRC21:58
*** takashin has joined #openstack-nova21:58
*** rcernin has joined #openstack-nova22:00
*** fragatina has joined #openstack-nova22:06
*** xyang1 has quit IRC22:08
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration  https://review.openstack.org/52754122:11
*** r-daneel has quit IRC22:13
*** dtruong_ has joined #openstack-nova22:14
*** sapcc-bot has quit IRC22:16
*** tpatzig_ has joined #openstack-nova22:16
*** sapcc-bot has joined #openstack-nova22:16
*** erlon has quit IRC22:17
*** dtruong has quit IRC22:17
*** tpatzig_ has quit IRC22:18
*** BryanS68 has quit IRC22:18
*** BryanS68 has joined #openstack-nova22:19
*** READ10 has quit IRC22:21
*** marst has quit IRC22:24
*** lpetrut has quit IRC22:26
openstackgerritDan Smith proposed openstack/nova master: WIP: Don't persist could-be-stale InstanceGroup fields in RequestSpec  https://review.openstack.org/52779922:26
dansmithmriedem: this is what I'm thinking for the functional change ^22:26
dansmithexcept with less obvious bugs22:31
mriedemone question, but seems ok at first glance22:31
*** peter-hamilton has quit IRC22:37
*** tidwellr has quit IRC22:44
*** BryanS68 has quit IRC22:53
*** harlowja has quit IRC22:54
*** penick has joined #openstack-nova22:54
*** penick_ has quit IRC22:56
*** felipemonteiro_ has quit IRC23:01
*** baoli has quit IRC23:05
*** baoli has joined #openstack-nova23:06
openstackgerritDan Smith proposed openstack/nova master: Don't persist could-be-stale InstanceGroup fields in RequestSpec  https://review.openstack.org/52779923:06
*** takashin has left #openstack-nova23:09
*** lyan has quit IRC23:12
*** baoli has quit IRC23:12
*** takashin has joined #openstack-nova23:13
*** jay_tampa is now known as jaypipes23:13
jaypipesmriedem: that's odd... looks like multiple threads are all trying to insert the standard traits at the same time.23:13
*** burt has quit IRC23:15
*** dave-mccowan has quit IRC23:23
*** mlavalle has quit IRC23:24
*** kumarmn has quit IRC23:25
*** sdague has quit IRC23:27
*** esberglu has quit IRC23:30
*** itlinux has joined #openstack-nova23:35
*** awaugama has quit IRC23:35
*** harlowja has joined #openstack-nova23:42
openstackgerritmelanie witt proposed openstack/nova master: Optionalize instance_uuid in console_auth_token_get_valid()  https://review.openstack.org/48170023:42
openstackgerritmelanie witt proposed openstack/nova master: Add console connection object  https://review.openstack.org/32006323:42
openstackgerritmelanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens  https://review.openstack.org/32538123:42
openstackgerritmelanie witt proposed openstack/nova master: Use ConsoleConnection object to generate authorizations  https://review.openstack.org/32541423:42
openstackgerritmelanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation  https://review.openstack.org/33399023:42
*** esberglu has joined #openstack-nova23:43
*** armax has quit IRC23:44
melwittgrr looks like I did something wrong to set the tempest conf option23:46
*** esberglu has quit IRC23:48
melwittneed dashes instead of underscores ... okay23:48
*** tetsuro has joined #openstack-nova23:49
*** kumarmn has joined #openstack-nova23:51
*** kumarmn has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!