| *** salv-orlando has quit IRC | 00:01 | |
| *** salv-orlando has joined #openstack-nova | 00:02 | |
| *** artom has joined #openstack-nova | 00:03 | |
| *** yangyapeng has quit IRC | 00:05 | |
| *** salv-orlando has quit IRC | 00:06 | |
| *** gouthamr has joined #openstack-nova | 00:08 | |
| *** hongbin has quit IRC | 00:10 | |
| *** yangyapeng has joined #openstack-nova | 00:19 | |
| mriedem | tonyb: got into the tag block http://logs.openstack.org/58/519758/5/check/legacy-tempest-dsvm-neutron-full/f1b5a24/logs/devstacklog.txt.gz | 00:22 |
|---|---|---|
| mriedem | fatal: 'origin' does not appear to be a git repository | 00:22 |
| tonyb | Oh yeah that's a zuulv3 thing | 00:23 |
| mriedem | ah | 00:23 |
| mriedem | git remote set-url origin $git_remote | 00:23 |
| mriedem | ok i'll update | 00:23 |
| *** yangyapeng has quit IRC | 00:23 | |
| mriedem | alright, new version up, see you in an hour ;) | 00:24 |
| *** Tom-Tom has joined #openstack-nova | 00:25 | |
| tonyb | mriedem: :) | 00:25 |
| *** acormier has joined #openstack-nova | 00:26 | |
| *** acormier has quit IRC | 00:27 | |
| *** Tom-Tom has quit IRC | 00:29 | |
| *** mlavalle has quit IRC | 00:33 | |
| *** acormier has joined #openstack-nova | 00:34 | |
| *** markvoelker has quit IRC | 00:37 | |
| *** yangyapeng has joined #openstack-nova | 00:38 | |
| *** chyka has quit IRC | 00:41 | |
| *** qsyqian has joined #openstack-nova | 00:45 | |
| *** yangyapeng has quit IRC | 00:47 | |
| *** priteau has joined #openstack-nova | 00:49 | |
| *** acormier has quit IRC | 00:50 | |
| *** acormier has joined #openstack-nova | 00:51 | |
| *** priteau has quit IRC | 00:54 | |
| *** awaugama has joined #openstack-nova | 01:03 | |
| *** acormier_ has joined #openstack-nova | 01:03 | |
| *** acormier_ has joined #openstack-nova | 01:03 | |
| *** phuongnh has joined #openstack-nova | 01:03 | |
| *** yangyapeng has joined #openstack-nova | 01:05 | |
| *** acormier has quit IRC | 01:05 | |
| *** yangyapeng has quit IRC | 01:06 | |
| *** yangyapeng has joined #openstack-nova | 01:06 | |
| *** gfhellma_ has quit IRC | 01:11 | |
| *** sdague has quit IRC | 01:12 | |
| *** Ankit has quit IRC | 01:12 | |
| *** tetsuro has joined #openstack-nova | 01:15 | |
| *** awaugama has quit IRC | 01:17 | |
| *** takashin has quit IRC | 01:23 | |
| *** gyee_ has quit IRC | 01:23 | |
| *** erlon has quit IRC | 01:24 | |
| openstackgerrit | Merged openstack/nova master: Modify incorrect debug meaasge in _inject_data https://review.openstack.org/517227 | 01:27 |
| *** phuongnh has quit IRC | 01:28 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146 | 01:29 |
| *** hieulq has quit IRC | 01:30 | |
| *** hieulq has joined #openstack-nova | 01:31 | |
| *** phuongnh has joined #openstack-nova | 01:31 | |
| *** naichuans has quit IRC | 01:32 | |
| *** stack has joined #openstack-nova | 01:33 | |
| *** stack is now known as Guest6542 | 01:33 | |
| *** markvoelker has joined #openstack-nova | 01:37 | |
| mriedem | tonyb: damn | 01:39 |
| mriedem | http://logs.openstack.org/58/519758/6/check/legacy-tempest-dsvm-neutron-full/8dd27b1/logs/devstacklog.txt.gz#_2017-11-15_00_40_53_489 | 01:39 |
| mriedem | http://logs.openstack.org/58/519758/6/check/legacy-tempest-dsvm-neutron-full/8dd27b1/logs/devstacklog.txt.gz#_2017-11-15_00_40_53_489 | 01:39 |
| mriedem | oops | 01:39 |
| mriedem | fatal: No such remote 'origin' | 01:39 |
| mriedem | wth, why is it pointing at keystone? | 01:40 |
| mriedem | oh because it's keystone :) | 01:40 |
| mriedem | which is now newton-eol | 01:40 |
| mriedem | i wonder if i should just punt and do git checkout $eol_tag | 01:42 |
| *** cheneydc has joined #openstack-nova | 01:44 | |
| *** Apoorva_ has quit IRC | 01:46 | |
| mriedem | git remote add origin $remote might work | 01:47 |
| mriedem | i copied from the reclone block, but in this case we're not doing a reclone | 01:47 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146 | 01:48 |
| *** yamahata has quit IRC | 01:50 | |
| *** chialiang has joined #openstack-nova | 01:51 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/519806 | 01:53 |
| *** links has joined #openstack-nova | 02:03 | |
| *** salv-orlando has joined #openstack-nova | 02:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add microversion to allow setting flavor description https://review.openstack.org/515213 | 02:06 |
| *** salv-orlando has quit IRC | 02:08 | |
| *** threestrands has joined #openstack-nova | 02:08 | |
| *** chyka has joined #openstack-nova | 02:09 | |
| *** dinesh_ has joined #openstack-nova | 02:11 | |
| *** itlinux has joined #openstack-nova | 02:12 | |
| tonyb | I don't get why git_update_tag $eol_tag was wrong that works for me | 02:12 |
| *** chyka has quit IRC | 02:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix the formatting for the 2.54 microversion REST API version history https://review.openstack.org/519940 | 02:14 |
| tonyb | mriedem: Ahh now I see. I think you just want git checkout -f $eol_tag | 02:14 |
| mriedem | see the latest version | 02:14 |
| mriedem | i was copying from the reclone block but i don't think that's what i want | 02:14 |
| mriedem | i'm honestly not sure how the /opt/stack/new/keystone directory gets created, unless zuulv3 does that here: | 02:15 |
| mriedem | http://logs.openstack.org/58/519758/6/check/legacy-tempest-dsvm-neutron-full/8dd27b1/job-output.txt.gz#_2017-11-15_00_33_31_611200 | 02:15 |
| mriedem | if that's the case, then i don't need to git clone/pull/fetch at all, i can just check if the tag is in the repo and check it out if so | 02:15 |
| tonyb | Yeah but PS 8 is doing git checkout $git_ref which is stable/newton IIUC | 02:16 |
| mriedem | oh gdi | 02:16 |
| mriedem | copy/paste | 02:16 |
| tonyb | okay | 02:16 |
| mriedem | fixed | 02:16 |
| *** itlinux has quit IRC | 02:17 | |
| *** qsyqian_ has joined #openstack-nova | 02:18 | |
| *** qsyqian_ has quit IRC | 02:18 | |
| *** AlexeyAbashkin has joined #openstack-nova | 02:22 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Don't update RT in _allocate_network https://review.openstack.org/519942 | 02:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Don't update RT in _allocate_network https://review.openstack.org/519943 | 02:23 |
| *** AlexeyAbashkin has quit IRC | 02:26 | |
| *** takashin has joined #openstack-nova | 02:27 | |
| *** qsyqian has quit IRC | 02:29 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: unquiesce instance on volume snapshot failure https://review.openstack.org/519464 | 02:31 |
| *** acormier_ has quit IRC | 02:43 | |
| *** qsyqian has joined #openstack-nova | 02:44 | |
| openstackgerrit | guanzuoyu proposed openstack/nova stable/ocata: Modify incorrect debug meaasge in _inject_data https://review.openstack.org/519950 | 02:47 |
| openstackgerrit | guanzuoyu proposed openstack/nova stable/pike: Modify incorrect debug meaasge in _inject_data https://review.openstack.org/519951 | 02:48 |
| *** priteau has joined #openstack-nova | 02:50 | |
| *** Sukhdev has quit IRC | 02:51 | |
| *** gouthamr has quit IRC | 02:52 | |
| *** priteau has quit IRC | 02:55 | |
| *** dinesh_ has quit IRC | 02:55 | |
| *** qsyqian has quit IRC | 02:56 | |
| -openstackstatus- NOTICE: Due to an unexpected outage with Zuul (1 hour), you'll need to recheck any jobs that were in progress. Sorry for the inconvenience. | 02:57 | |
| *** tbachman has quit IRC | 02:58 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.55 - List/Show all server migration types https://review.openstack.org/430839 | 02:59 |
| *** salv-orlando has joined #openstack-nova | 03:04 | |
| openstackgerrit | Li Yingjun proposed openstack/nova master: Versioned notifications for service create and delete https://review.openstack.org/519588 | 03:05 |
| *** qsyqian has joined #openstack-nova | 03:09 | |
| *** salv-orlando has quit IRC | 03:09 | |
| *** dave-mccowan has quit IRC | 03:09 | |
| *** fragatina has quit IRC | 03:10 | |
| *** tbachman has joined #openstack-nova | 03:12 | |
| *** artom has quit IRC | 03:12 | |
| *** artom has joined #openstack-nova | 03:12 | |
| *** fragatina has joined #openstack-nova | 03:13 | |
| *** itlinux has joined #openstack-nova | 03:15 | |
| *** fragatina has quit IRC | 03:17 | |
| *** gbarros has quit IRC | 03:24 | |
| *** akekane has joined #openstack-nova | 03:28 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: vgpu: add enabled white list https://review.openstack.org/512580 | 03:34 |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965 | 03:34 |
| *** rcernin has quit IRC | 03:34 | |
| *** tetsuro has quit IRC | 03:34 | |
| *** rcernin has joined #openstack-nova | 03:36 | |
| *** mdnadeem has joined #openstack-nova | 03:39 | |
| *** artom has quit IRC | 03:39 | |
| mriedem | tonyb: ok i think 9th time is the charm | 03:40 |
| mriedem | tempest is running so it got through stack.sh | 03:40 |
| *** felipemonteiro has joined #openstack-nova | 03:41 | |
| *** udesale has joined #openstack-nova | 03:41 | |
| *** slaweq has joined #openstack-nova | 03:43 | |
| *** diga has joined #openstack-nova | 03:45 | |
| *** slaweq has quit IRC | 03:48 | |
| *** akekane is now known as abhishekk | 03:50 | |
| *** yamahata has joined #openstack-nova | 03:57 | |
| *** qsyqian has quit IRC | 04:01 | |
| *** yamamoto has joined #openstack-nova | 04:04 | |
| *** salv-orlando has joined #openstack-nova | 04:05 | |
| *** Apoorva has joined #openstack-nova | 04:08 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: [WIP] Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 04:09 |
| *** ellioth has joined #openstack-nova | 04:10 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965 | 04:11 |
| *** salv-orlando has quit IRC | 04:11 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node https://review.openstack.org/516217 | 04:11 |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899 | 04:11 |
| *** sridharg has joined #openstack-nova | 04:11 | |
| tonyb | mriedem: yeah I'm watching in the background | 04:12 |
| *** qsyqian has joined #openstack-nova | 04:13 | |
| *** hongbin has joined #openstack-nova | 04:17 | |
| *** felipemonteiro has quit IRC | 04:19 | |
| *** acormier has joined #openstack-nova | 04:20 | |
| *** takashin has quit IRC | 04:22 | |
| mriedem | tonyb: alright, i'm going to bed, | 04:22 |
| mriedem | i guess either push things through or i'll take a look in the morning | 04:22 |
| mriedem | https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton | 04:23 |
| mriedem | https://review.openstack.org/#/c/516119/ has to be re-approved | 04:23 |
| *** acormier has quit IRC | 04:26 | |
| *** psachin has joined #openstack-nova | 04:28 | |
| *** annp has joined #openstack-nova | 04:29 | |
| *** gongysh has joined #openstack-nova | 04:30 | |
| *** andreas_s has joined #openstack-nova | 04:31 | |
| *** andreas_s has quit IRC | 04:35 | |
| *** felipemonteiro has joined #openstack-nova | 04:39 | |
| *** namnh has joined #openstack-nova | 04:41 | |
| *** Apoorva_ has joined #openstack-nova | 04:46 | |
| *** Apoorva has quit IRC | 04:49 | |
| *** priteau has joined #openstack-nova | 04:51 | |
| *** acormier has joined #openstack-nova | 04:53 | |
| *** hongbin has quit IRC | 04:53 | |
| *** priteau has quit IRC | 04:55 | |
| *** claudiub|2 has joined #openstack-nova | 05:01 | |
| *** acormier has quit IRC | 05:01 | |
| *** salv-orlando has joined #openstack-nova | 05:07 | |
| *** salv-orlando has quit IRC | 05:12 | |
| *** AlexeyAbashkin has joined #openstack-nova | 05:22 | |
| *** tetsuro has joined #openstack-nova | 05:22 | |
| *** jaosorior has quit IRC | 05:24 | |
| *** qsyqian has quit IRC | 05:26 | |
| *** AlexeyAbashkin has quit IRC | 05:26 | |
| *** qsyqian has joined #openstack-nova | 05:26 | |
| *** trinaths has joined #openstack-nova | 05:27 | |
| *** qsyqian has quit IRC | 05:27 | |
| *** itlinux has quit IRC | 05:27 | |
| *** chialiang has quit IRC | 05:30 | |
| *** chyka has joined #openstack-nova | 05:30 | |
| *** chialiang_ has joined #openstack-nova | 05:30 | |
| *** chialiang_ has quit IRC | 05:32 | |
| *** chialiang_ has joined #openstack-nova | 05:32 | |
| *** janki has joined #openstack-nova | 05:33 | |
| *** chyka has quit IRC | 05:35 | |
| *** janki has quit IRC | 05:40 | |
| *** Apoorva_ has quit IRC | 05:41 | |
| *** moshele has joined #openstack-nova | 05:43 | |
| *** tbachman_ has joined #openstack-nova | 05:45 | |
| *** tbachman has quit IRC | 05:46 | |
| *** tbachman_ is now known as tbachman | 05:46 | |
| *** hshiina has joined #openstack-nova | 05:48 | |
| *** ellioth has quit IRC | 05:51 | |
| *** felipemonteiro has quit IRC | 06:01 | |
| tonyb | mriedem, dansmith: everything is baacked up behind the devstack change :( | 06:05 |
| *** salv-orlando has joined #openstack-nova | 06:08 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Update Instance action's updated_at when action event updated. https://review.openstack.org/507473 | 06:12 |
| *** janki has joined #openstack-nova | 06:12 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: [WIP] Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 06:12 |
| *** salv-orlando has quit IRC | 06:12 | |
| *** lpetrut_ has joined #openstack-nova | 06:15 | |
| *** yingjun has joined #openstack-nova | 06:20 | |
| *** dikonoo has quit IRC | 06:25 | |
| *** dikonoo has joined #openstack-nova | 06:25 | |
| *** tssurya_ has joined #openstack-nova | 06:26 | |
| *** tssurya has quit IRC | 06:28 | |
| *** diga has quit IRC | 06:29 | |
| *** ttsiouts has quit IRC | 06:30 | |
| *** tssurya has joined #openstack-nova | 06:30 | |
| *** diga has joined #openstack-nova | 06:30 | |
| *** namnh has quit IRC | 06:33 | |
| *** armax has quit IRC | 06:33 | |
| *** armax has joined #openstack-nova | 06:33 | |
| *** armax has quit IRC | 06:34 | |
| *** tssurya_ has quit IRC | 06:34 | |
| *** armax has joined #openstack-nova | 06:34 | |
| *** armax has quit IRC | 06:34 | |
| *** threestrands has quit IRC | 06:34 | |
| *** armax has joined #openstack-nova | 06:35 | |
| *** armax has quit IRC | 06:35 | |
| *** armax has joined #openstack-nova | 06:36 | |
| *** armax has quit IRC | 06:36 | |
| *** salv-orlando has joined #openstack-nova | 06:38 | |
| *** nsingh has joined #openstack-nova | 06:40 | |
| *** lpetrut_ has quit IRC | 06:40 | |
| *** gabor_antal_ has joined #openstack-nova | 06:40 | |
| *** lpetrut_ has joined #openstack-nova | 06:41 | |
| *** gabor_antal has quit IRC | 06:43 | |
| *** niraj_singh has quit IRC | 06:43 | |
| *** dikonoo has quit IRC | 06:46 | |
| *** lajoskatona has joined #openstack-nova | 06:49 | |
| *** slaweq has joined #openstack-nova | 06:51 | |
| *** namnh has joined #openstack-nova | 06:51 | |
| *** moshele has quit IRC | 06:53 | |
| *** slaweq has quit IRC | 06:55 | |
| *** moshele has joined #openstack-nova | 06:55 | |
| *** TuanLA has joined #openstack-nova | 06:55 | |
| *** lpetrut_ has quit IRC | 06:56 | |
| *** jaosorior has joined #openstack-nova | 06:57 | |
| *** acormier has joined #openstack-nova | 07:01 | |
| alex_xu | gmann: are you around? | 07:05 |
| *** acormier has quit IRC | 07:06 | |
| *** slaweq has joined #openstack-nova | 07:07 | |
| *** andreas_s has joined #openstack-nova | 07:07 | |
| *** edand has joined #openstack-nova | 07:08 | |
| openstackgerrit | Spencer Yu proposed openstack/nova master: Use defusedxml.ElementTree function instead of lxml.etree https://review.openstack.org/519291 | 07:09 |
| *** dtantsur|afk is now known as dtantsur | 07:11 | |
| *** spectr has joined #openstack-nova | 07:13 | |
| *** slaweq has quit IRC | 07:15 | |
| *** rcernin has quit IRC | 07:20 | |
| *** mdnadeem has quit IRC | 07:23 | |
| *** Oku_OS-away is now known as Oku_OS | 07:24 | |
| *** lpetrut_ has joined #openstack-nova | 07:24 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add a description of 'key_name' in rebuild https://review.openstack.org/519993 | 07:27 |
| *** hoonetorg has quit IRC | 07:30 | |
| *** sahid has joined #openstack-nova | 07:32 | |
| *** mdnadeem has joined #openstack-nova | 07:33 | |
| openstackgerrit | Li Yingjun proposed openstack/nova master: Versioned notifications for service create and delete https://review.openstack.org/519588 | 07:35 |
| *** priteau has joined #openstack-nova | 07:36 | |
| *** spectr has quit IRC | 07:38 | |
| *** salv-orlando has quit IRC | 07:39 | |
| *** salv-orlando has joined #openstack-nova | 07:39 | |
| *** yamamoto_ has joined #openstack-nova | 07:41 | |
| *** hoonetorg has joined #openstack-nova | 07:43 | |
| *** salv-orlando has quit IRC | 07:43 | |
| *** yamamoto has quit IRC | 07:44 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Remove the objects which related to the old v2 API implementation https://review.openstack.org/519997 | 07:44 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Remove the objects for describing the extension for v2.1 API https://review.openstack.org/519998 | 07:44 |
| *** lpetrut_ has quit IRC | 07:44 | |
| openstackgerrit | Xuanzhou Perry Dong proposed openstack/python-novaclient master: Check for volume size https://review.openstack.org/519999 | 07:45 |
| *** vipul has joined #openstack-nova | 07:47 | |
| *** slaweq has joined #openstack-nova | 07:47 | |
| *** pcaruana has joined #openstack-nova | 07:51 | |
| *** slaweq has quit IRC | 07:52 | |
| *** belmoreira has joined #openstack-nova | 07:53 | |
| *** lpetrut_ has joined #openstack-nova | 07:55 | |
| *** john5223 has quit IRC | 07:58 | |
| *** danpawlik has quit IRC | 07:59 | |
| *** mmedvede has quit IRC | 07:59 | |
| *** smatzek has joined #openstack-nova | 07:59 | |
| *** hemna has quit IRC | 07:59 | |
| *** danpawlik has joined #openstack-nova | 07:59 | |
| *** alexchadin has joined #openstack-nova | 08:00 | |
| *** maciejjozefczyk has quit IRC | 08:00 | |
| *** priteau has quit IRC | 08:00 | |
| *** priteau has joined #openstack-nova | 08:01 | |
| *** sshwarts has joined #openstack-nova | 08:01 | |
| *** smatzek has quit IRC | 08:03 | |
| *** hemna has joined #openstack-nova | 08:04 | |
| *** slaweq has joined #openstack-nova | 08:05 | |
| *** priteau has quit IRC | 08:06 | |
| *** mmedvede has joined #openstack-nova | 08:06 | |
| *** john5223 has joined #openstack-nova | 08:06 | |
| openstackgerrit | licanwei proposed openstack/nova master: cli 'nova-manage db sync' can't upgrade cell1 https://review.openstack.org/519275 | 08:06 |
| *** maciejjozefczyk has joined #openstack-nova | 08:06 | |
| *** slaweq has quit IRC | 08:10 | |
| *** priteau has joined #openstack-nova | 08:11 | |
| *** gongysh has quit IRC | 08:12 | |
| *** gongysh has joined #openstack-nova | 08:14 | |
| *** priteau has quit IRC | 08:15 | |
| *** tesseract has joined #openstack-nova | 08:17 | |
| *** lpetrut_ has quit IRC | 08:20 | |
| *** diga has quit IRC | 08:20 | |
| *** zhurong has joined #openstack-nova | 08:23 | |
| *** alexchadin has quit IRC | 08:27 | |
| *** alexchadin has joined #openstack-nova | 08:27 | |
| *** Jack_Iv has joined #openstack-nova | 08:29 | |
| *** Jack_Iv has quit IRC | 08:33 | |
| *** Jack_Iv has joined #openstack-nova | 08:33 | |
| *** diga has joined #openstack-nova | 08:34 | |
| *** tetsuro has quit IRC | 08:34 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:37 | |
| *** salv-orlando has joined #openstack-nova | 08:40 | |
| *** gongysh has quit IRC | 08:43 | |
| *** salv-orlando has quit IRC | 08:44 | |
| *** cheneydc has quit IRC | 08:47 | |
| *** jpena|off is now known as jpena | 08:52 | |
| *** priteau has joined #openstack-nova | 08:55 | |
| *** salv-orlando has joined #openstack-nova | 08:55 | |
| openstackgerrit | Spencer Yu proposed openstack/nova master: Use subprocess securely https://review.openstack.org/520013 | 08:56 |
| *** cheneydc has joined #openstack-nova | 09:00 | |
| *** priteau has quit IRC | 09:02 | |
| *** priteau has joined #openstack-nova | 09:05 | |
| *** chyka has joined #openstack-nova | 09:06 | |
| *** zenpwner has joined #openstack-nova | 09:08 | |
| *** priteau has quit IRC | 09:10 | |
| *** andreas_s has quit IRC | 09:10 | |
| *** chyka has quit IRC | 09:11 | |
| *** hshiina has quit IRC | 09:11 | |
| *** chialiang_ has quit IRC | 09:13 | |
| *** andreas_s has joined #openstack-nova | 09:14 | |
| openstackgerrit | Spencer Yu proposed openstack/nova master: Use defusedxml.ElementTree function instead of lxml.etree https://review.openstack.org/519291 | 09:16 |
| *** gongysh has joined #openstack-nova | 09:16 | |
| *** lucas-afk is now known as lucasagomes | 09:17 | |
| *** alexchadin has quit IRC | 09:20 | |
| *** lpetrut_ has joined #openstack-nova | 09:20 | |
| *** alexchadin has joined #openstack-nova | 09:21 | |
| *** ralonsoh has joined #openstack-nova | 09:23 | |
| *** chialiang_ has joined #openstack-nova | 09:24 | |
| *** yamamoto_ has quit IRC | 09:28 | |
| *** andreas_s has quit IRC | 09:29 | |
| *** alexchadin has quit IRC | 09:31 | |
| *** alexchadin has joined #openstack-nova | 09:32 | |
| *** derekh has joined #openstack-nova | 09:34 | |
| *** andreas_s has joined #openstack-nova | 09:34 | |
| *** diga has quit IRC | 09:35 | |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Update compute resources only once per update_available_resource() call https://review.openstack.org/520024 | 09:37 |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024 | 09:41 |
| *** hemna_ has quit IRC | 09:43 | |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024 | 09:45 |
| *** yamamoto has joined #openstack-nova | 09:46 | |
| maciejjozefczyk | mriedem: thats what we talked about earlier, https://review.openstack.org/#/c/520024 | 09:47 |
| *** andreas_s has quit IRC | 09:48 | |
| *** mdnadeem has quit IRC | 09:49 | |
| *** andreas_s has joined #openstack-nova | 09:53 | |
| *** yingjun has quit IRC | 09:55 | |
| *** ttsiouts has joined #openstack-nova | 09:56 | |
| *** hemna_ has joined #openstack-nova | 09:58 | |
| *** jpena is now known as jpena|mtg | 09:59 | |
| *** cheneydc has quit IRC | 10:00 | |
| *** belmoreira has quit IRC | 10:01 | |
| *** mdnadeem has joined #openstack-nova | 10:02 | |
| *** andreas_s has quit IRC | 10:02 | |
| *** strigazi has quit IRC | 10:05 | |
| *** belmoreira has joined #openstack-nova | 10:06 | |
| *** diga has joined #openstack-nova | 10:11 | |
| *** gszasz has joined #openstack-nova | 10:11 | |
| *** annp has quit IRC | 10:13 | |
| *** zenpwner has quit IRC | 10:15 | |
| *** phuongnh has quit IRC | 10:17 | |
| *** namnh has quit IRC | 10:17 | |
| *** TuanLA has quit IRC | 10:17 | |
| *** TuanLA has joined #openstack-nova | 10:18 | |
| *** phuongnh has joined #openstack-nova | 10:18 | |
| *** TuanLA has quit IRC | 10:19 | |
| *** yamamoto has quit IRC | 10:21 | |
| *** phuongnh has quit IRC | 10:21 | |
| *** hieulq has quit IRC | 10:24 | |
| *** phuongnh has joined #openstack-nova | 10:29 | |
| *** andreas_s has joined #openstack-nova | 10:31 | |
| *** trinaths has left #openstack-nova | 10:34 | |
| *** andreas_s has quit IRC | 10:35 | |
| *** andreas_s has joined #openstack-nova | 10:36 | |
| *** rmart04 has joined #openstack-nova | 10:40 | |
| *** hieulq has joined #openstack-nova | 10:41 | |
| *** phuongnh has quit IRC | 10:42 | |
| *** andreas_s has quit IRC | 10:45 | |
| *** hieulq has quit IRC | 10:53 | |
| *** abhishekk has quit IRC | 10:54 | |
| *** edand has quit IRC | 10:58 | |
| *** andreas_s has joined #openstack-nova | 11:01 | |
| *** yingjun has joined #openstack-nova | 11:01 | |
| *** yangyapeng has quit IRC | 11:01 | |
| *** yangyapeng has joined #openstack-nova | 11:01 | |
| *** mvk has quit IRC | 11:05 | |
| *** yangyapeng has quit IRC | 11:09 | |
| *** andreas_s has quit IRC | 11:09 | |
| *** hieulq has joined #openstack-nova | 11:09 | |
| *** hieulq has quit IRC | 11:12 | |
| *** gongysh has quit IRC | 11:15 | |
| *** yamamoto has joined #openstack-nova | 11:22 | |
| *** yangyapeng has joined #openstack-nova | 11:22 | |
| *** sdague has joined #openstack-nova | 11:23 | |
| *** sahid has quit IRC | 11:26 | |
| *** chialiang_ has quit IRC | 11:26 | |
| *** hieulq has joined #openstack-nova | 11:27 | |
| *** yamamoto has quit IRC | 11:29 | |
| *** hieulq has quit IRC | 11:30 | |
| *** yamamoto has joined #openstack-nova | 11:31 | |
| *** diga has quit IRC | 11:32 | |
| *** edand has joined #openstack-nova | 11:32 | |
| *** mvk has joined #openstack-nova | 11:32 | |
| *** diga has joined #openstack-nova | 11:33 | |
| *** sahid has joined #openstack-nova | 11:33 | |
| *** andreas_s has joined #openstack-nova | 11:34 | |
| *** rmart04 has quit IRC | 11:36 | |
| *** andreas_s has quit IRC | 11:38 | |
| *** andreas_s has joined #openstack-nova | 11:38 | |
| openstackgerrit | Merged openstack/nova stable/pike: libvirt: bandwidth param should be set in guest migrate https://review.openstack.org/519631 | 11:40 |
| *** rmart04 has joined #openstack-nova | 11:41 | |
| *** Jack_Iv has quit IRC | 11:41 | |
| *** hieulq has joined #openstack-nova | 11:45 | |
| *** tbachman has quit IRC | 11:47 | |
| *** yamamoto has quit IRC | 12:03 | |
| *** yamamoto has joined #openstack-nova | 12:04 | |
| *** diga has quit IRC | 12:05 | |
| *** andreas_s has quit IRC | 12:06 | |
| *** slaweq has joined #openstack-nova | 12:06 | |
| *** lucasagomes is now known as lucas-hungry | 12:06 | |
| *** sahid has quit IRC | 12:10 | |
| *** janki is now known as janki|afk | 12:10 | |
| *** andreas_s has joined #openstack-nova | 12:11 | |
| *** slaweq has quit IRC | 12:11 | |
| *** andreas_s has quit IRC | 12:20 | |
| *** priteau has joined #openstack-nova | 12:21 | |
| *** acormier has joined #openstack-nova | 12:23 | |
| *** sree has joined #openstack-nova | 12:23 | |
| *** alexchadin has quit IRC | 12:24 | |
| *** andreas_s has joined #openstack-nova | 12:25 | |
| *** yingjun has quit IRC | 12:27 | |
| *** acormier has quit IRC | 12:27 | |
| *** janki|afk is now known as janki | 12:27 | |
| *** karthiks has quit IRC | 12:29 | |
| *** gongysh has joined #openstack-nova | 12:33 | |
| *** smatzek has joined #openstack-nova | 12:33 | |
| *** andreas_s has quit IRC | 12:35 | |
| *** andreas_s has joined #openstack-nova | 12:40 | |
| *** yingjun has joined #openstack-nova | 12:42 | |
| *** karthiks has joined #openstack-nova | 12:45 | |
| *** sree has quit IRC | 12:47 | |
| *** sree has joined #openstack-nova | 12:49 | |
| *** takashin has joined #openstack-nova | 12:49 | |
| *** andreas_s has quit IRC | 12:49 | |
| *** edand_ has joined #openstack-nova | 12:52 | |
| *** edand has quit IRC | 12:54 | |
| *** andreas_s has joined #openstack-nova | 12:54 | |
| *** takashin has quit IRC | 12:55 | |
| *** takashin has joined #openstack-nova | 12:56 | |
| *** karthiks has quit IRC | 12:57 | |
| *** acormier has joined #openstack-nova | 12:58 | |
| *** jpena|mtg is now known as jpena|lunch | 13:03 | |
| *** takashin has left #openstack-nova | 13:03 | |
| *** andreas_s has quit IRC | 13:03 | |
| *** tbachman has joined #openstack-nova | 13:04 | |
| *** andreas_s has joined #openstack-nova | 13:06 | |
| *** tbachman_ has joined #openstack-nova | 13:06 | |
| *** lucas-hungry is now known as lucasagomes | 13:07 | |
| *** gongysh has quit IRC | 13:08 | |
| efried | alex_xu yt? | 13:08 |
| *** tbachman has quit IRC | 13:08 | |
| *** tbachman_ is now known as tbachman | 13:08 | |
| *** sshwarts has quit IRC | 13:08 | |
| *** smatzek has quit IRC | 13:09 | |
| *** smatzek has joined #openstack-nova | 13:10 | |
| alex_xu | efried: yea | 13:11 |
| *** artom has joined #openstack-nova | 13:11 | |
| efried | alex_xu Are you okay with https://review.openstack.org/#/c/516778/ at this point? | 13:12 |
| efried | alex_xu We really need to get this series moving. | 13:12 |
| *** karthiks has joined #openstack-nova | 13:13 | |
| efried | alex_xu We can do the sql refactor in a subsequent patch - I'd like to start doing those on the top of the series, since the extra tests will help flush out bugs. | 13:13 |
| alex_xu | efried: i'm ok with sql refactor later | 13:13 |
| efried | alex_xu I removed the comment and the code block that it referenced - seemed to have no effect anyway. | 13:14 |
| *** sree has quit IRC | 13:16 | |
| alex_xu | efried: i'm not sure we should remove that check | 13:16 |
| *** sree has joined #openstack-nova | 13:17 | |
| alex_xu | efried: that check can return faster when there is nothing return from the query | 13:17 |
| alex_xu | right? | 13:17 |
| efried | alex_xu But we actually *want* to support scenarios where we get resources from only sharing RPs. | 13:17 |
| *** edand__ has joined #openstack-nova | 13:17 | |
| alex_xu | efried: yes, but that check is also usefull for fast return? | 13:18 |
| efried | I don't know | 13:18 |
| efried | AFAICT the code *ought* to be doing what the comment said, which is something we don't want. Putting it in is not having the desired effect. | 13:18 |
| *** takashin has joined #openstack-nova | 13:20 | |
| *** edand_ has quit IRC | 13:20 | |
| alex_xu | efried: emm..., I think we should have check like "if not all_rp_ids: return [], []" | 13:20 |
| alex_xu | efried: I think I agree that check should be removed, that isn't totally for fast return | 13:21 |
| *** links has quit IRC | 13:22 | |
| *** sree has quit IRC | 13:22 | |
| efried | alex_xu Where `all_rp_ids` is set(sharing_providers) | non_sharing_rp_ids ? | 13:24 |
| *** links has joined #openstack-nova | 13:24 | |
| efried | alex_xu Oh, never mind, I see it defined below. | 13:24 |
| *** sree has joined #openstack-nova | 13:25 | |
| alex_xu | efried: https://review.openstack.org/#/c/516778/9/nova/objects/resource_provider.py@2616 | 13:26 |
| *** sshwarts has joined #openstack-nova | 13:26 | |
| alex_xu | the last word "this is the list of resource provider IDs that are NOT sharing resource" doesn't sound true also | 13:26 |
| efried | alex_xu How so? | 13:27 |
| alex_xu | if only request shared resources, "non_sharing_rp_ids" includes the RPs with that shared resources | 13:27 |
| *** edmondsw has joined #openstack-nova | 13:28 | |
| efried | Is that why we're passing those test cases when we don't expect to be? :) | 13:28 |
| alex_xu | efried: yes | 13:28 |
| efried | alex_xu I don't think that's for lack of trying. Looking at the if/else above, that comment *should* be true. | 13:29 |
| alex_xu | efried: how about append a word to say "non_sharing_rp_ids" also includes the shared rp when there only request shared resource? | 13:29 |
| *** markvoelker has quit IRC | 13:29 | |
| efried | alex_xu If that were the case, we would want to rename that variable. | 13:29 |
| *** markvoelker has joined #openstack-nova | 13:29 | |
| alex_xu | efried: yea :( | 13:29 |
| alex_xu | non_sharing_rp_ids_but_some_time_not | 13:30 |
| efried | alex_xu The bug must be in one of the helpers - one or both of the following must be true: 1) _get_providers_with_shared_capacity is returning non-sharing RPs; 2) _get_all_with_shared is returning sharing RPs. | 13:31 |
| alex_xu | yes | 13:32 |
| efried | alex_xu I'll go write some functional tests to hit just those helpers and see which is the case. Thanks for talking through it with me. | 13:32 |
| alex_xu | efried: cool | 13:32 |
| *** liverpooler has quit IRC | 13:34 | |
| *** acormier has quit IRC | 13:34 | |
| efried | alex_xu How about this series? https://review.openstack.org/#/c/377138/ | 13:35 |
| alex_xu | efried: I will try to review that seriews tomorrow | 13:36 |
| efried | alex_xu Okay, thanks. | 13:36 |
| *** acormier has joined #openstack-nova | 13:36 | |
| alex_xu | efried: np | 13:36 |
| alex_xu | efried: the next is holiday in US? | 13:36 |
| alex_xu | sorry, next week | 13:36 |
| *** takashin has left #openstack-nova | 13:38 | |
| *** moshele has quit IRC | 13:41 | |
| *** alexchadin has joined #openstack-nova | 13:43 | |
| *** brault has quit IRC | 13:43 | |
| efried | alex_xu Yes. Next Thursday (and many folks get Friday as well). | 13:43 |
| *** smatzek_ has joined #openstack-nova | 13:45 | |
| *** smatzek has quit IRC | 13:45 | |
| *** gouthamr has joined #openstack-nova | 13:46 | |
| *** brault has joined #openstack-nova | 13:49 | |
| *** mdnadeem has quit IRC | 13:52 | |
| efried | alex_xu _get_providers_with_shared_capacity appears to be okay. | 13:52 |
| *** links has quit IRC | 13:53 | |
| alex_xu | efried: what means okay? | 13:53 |
| efried | alex_xu It's working as expected. There was a hole in the test case, but when I fixed it, the test still passed. So I think it's doing what it's supposed to. | 13:53 |
| *** andreas_s has quit IRC | 13:55 | |
| efried | alex_xu I also just looked over the test case for _get_all_with_shared and I'm convinced it's okay too. | 13:55 |
| *** udesale has quit IRC | 13:56 | |
| *** trinaths has joined #openstack-nova | 13:56 | |
| efried | alex_xu How else could we be getting sharing RPs in that var? | 13:56 |
| *** jpena|lunch is now known as jpena | 13:56 | |
| *** udesale has joined #openstack-nova | 13:58 | |
| *** yingjun has quit IRC | 13:59 | |
| alex_xu | efried: I don't another case to getting sharing rps in that var | 13:59 |
| *** andreas_s has joined #openstack-nova | 14:00 | |
| *** slaweq has joined #openstack-nova | 14:00 | |
| efried | alex_xu So how would you like to proceed? We know we have bugs in the stack; are we going to try to fix them in the series, or start merging code and attack them after? | 14:00 |
| *** acormier has quit IRC | 14:01 | |
| *** dave-mccowan has joined #openstack-nova | 14:02 | |
| *** eharney has joined #openstack-nova | 14:02 | |
| *** jaypipes has joined #openstack-nova | 14:04 | |
| *** lyan has joined #openstack-nova | 14:05 | |
| *** tasker has joined #openstack-nova | 14:06 | |
| *** slaweq_ has joined #openstack-nova | 14:08 | |
| *** andreas_s has quit IRC | 14:09 | |
| *** sshwarts has quit IRC | 14:10 | |
| *** fragatina has joined #openstack-nova | 14:11 | |
| alex_xu | efried: which bug you reference? | 14:11 |
| efried | alex_xu There are several. All the test patches on the top of this series. | 14:12 |
| efried | alex_xu The good news is that *somewhere* in the series, we've fixed some of them. | 14:12 |
| *** slaweq_ has quit IRC | 14:12 | |
| efried | At this point I think we have two main ones: One where we're getting candidates that cross aggregates; and one where we're getting duplicate candidates returned. | 14:13 |
| *** dave-mccowan has quit IRC | 14:13 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: begin refactor AllocCandidates._get_by_filters() https://review.openstack.org/516778 | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: build ProviderSummary objects in sep function https://review.openstack.org/516779 | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: build alloc request resources for shared resources https://review.openstack.org/516780 | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: create allocation request for single provider https://review.openstack.org/516781 | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: finish refactor AllocCandidates._get_by_filters() https://review.openstack.org/516782 | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: required traits for no sharing providers https://review.openstack.org/517027 | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add ProviderSummary.resource_class_names @property https://review.openstack.org/517646 | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: handle traits with sharing providers https://review.openstack.org/517119 | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380 | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617 | 14:14 |
| alex_xu | efried: probably we should guarantee the basic use-case works first | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633 | 14:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | 14:14 |
| *** liuyulong has joined #openstack-nova | 14:14 | |
| efried | alex_xu Here it is with that extra short-circuit you suggested, and the enhanced test case, and test fixes for the middle of the series. ^ | 14:14 |
| *** ratailor has joined #openstack-nova | 14:14 | |
| efried | alex_xu Depends what you mean by "basic" :) | 14:14 |
| *** liuyulong has quit IRC | 14:14 | |
| *** andreas_s has joined #openstack-nova | 14:14 | |
| alex_xu | efried: something like, compute node have local and shared storage at sometime, actually doesn't support by the nova | 14:14 |
| efried | alex_xu Right, at the moment we don't even claim support for shared RPs at all. | 14:15 |
| alex_xu | s/sometime/sametime/ | 14:15 |
| alex_xu | efried: yea | 14:15 |
| *** andreas_s has quit IRC | 14:15 | |
| *** andreas_s has joined #openstack-nova | 14:15 | |
| *** liuyulong has joined #openstack-nova | 14:16 | |
| efried | alex_xu Taking that out of the picture - essentially just talking about compute-node-as-single-RP - I believe the code is working as expected. | 14:16 |
| efried | jaypipes Good morning. Hope you didn't have local changes to any of your patches :) | 14:16 |
| *** fragatina has quit IRC | 14:16 | |
| jaypipes | efried: no, had to take the afternoon off yesterday to deal with some family stuff. apologies. | 14:17 |
| efried | jaypipes No worries, just happy I didn't step on your work. Hope everything is okay. | 14:17 |
| *** krtaylor has joined #openstack-nova | 14:19 | |
| *** dave-mccowan has joined #openstack-nova | 14:20 | |
| *** yingjun has joined #openstack-nova | 14:20 | |
| *** belmoreira has quit IRC | 14:23 | |
| *** smatzek_ has quit IRC | 14:24 | |
| *** dave-mcc_ has joined #openstack-nova | 14:25 | |
| *** dave-mccowan has quit IRC | 14:25 | |
| *** slaweq has quit IRC | 14:28 | |
| *** sshwarts has joined #openstack-nova | 14:28 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257 | 14:28 |
| *** awaugama has joined #openstack-nova | 14:29 | |
| *** udesale has quit IRC | 14:29 | |
| *** slaweq has joined #openstack-nova | 14:29 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601 | 14:30 |
| *** READ10 has joined #openstack-nova | 14:32 | |
| efried | gibi Thanks ^ - I wasn't positive where that guy should sit in the pile (though I don't suppose it mattered much). | 14:33 |
| *** sree has quit IRC | 14:35 | |
| *** sree has joined #openstack-nova | 14:35 | |
| gibi | efried: I think it is OK at the end | 14:36 |
| efried | nod | 14:36 |
| *** mpaolino has joined #openstack-nova | 14:36 | |
| *** trinaths has left #openstack-nova | 14:37 | |
| *** liverpooler has joined #openstack-nova | 14:41 | |
| *** ratailor has quit IRC | 14:41 | |
| mriedem | tonyb: yeah i see ianw's -1, so i guess i'll take a look at changing devstack-gate today instead | 14:43 |
| *** sree has quit IRC | 14:43 | |
| *** slaweq has quit IRC | 14:44 | |
| *** sridharg has quit IRC | 14:44 | |
| *** esberglu has quit IRC | 14:44 | |
| *** slaweq has joined #openstack-nova | 14:45 | |
| *** udesale has joined #openstack-nova | 14:45 | |
| *** esberglu has joined #openstack-nova | 14:45 | |
| *** liverpooler has quit IRC | 14:45 | |
| *** liverpooler has joined #openstack-nova | 14:47 | |
| openstackgerrit | Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/519806 | 14:49 |
| *** andreas_s has quit IRC | 14:49 | |
| *** esberglu has quit IRC | 14:49 | |
| *** andreas_s has joined #openstack-nova | 14:50 | |
| *** gbarros has joined #openstack-nova | 14:50 | |
| *** moshele has joined #openstack-nova | 14:52 | |
| *** slaweq has quit IRC | 14:56 | |
| *** tbachman has quit IRC | 14:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/newton: Correct log message when removing a security group https://review.openstack.org/519586 | 14:57 |
| *** alexchadin has quit IRC | 14:59 | |
| *** esberglu has joined #openstack-nova | 15:00 | |
| *** armax has joined #openstack-nova | 15:01 | |
| *** yamamoto has quit IRC | 15:05 | |
| *** yingjun has quit IRC | 15:07 | |
| mriedem | tasker: oh hi | 15:11 |
| *** links has joined #openstack-nova | 15:11 | |
| *** andreas_s has quit IRC | 15:12 | |
| *** gouthamr has quit IRC | 15:12 | |
| tasker | 'allo. | 15:13 |
| *** janki has quit IRC | 15:13 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965 | 15:14 |
| jaypipes | jianghuaw: ^^ just a rebase... | 15:15 |
| *** yamamoto has joined #openstack-nova | 15:16 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node https://review.openstack.org/516217 | 15:16 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899 | 15:16 |
| *** gouthamr has joined #openstack-nova | 15:16 | |
| *** hongbin has joined #openstack-nova | 15:16 | |
| tasker | my application has the potential to frequently trigger snapshots of two instances at the same time. regarding the future of bug#1731986, I'm concerned that checking cinder quota / limits prior to asking it for volume snapshots will casue many problems for me. | 15:16 |
| tasker | i don't know Nova as well as you, and I know less about Cinder. maybe we can schedule some time with a cinder dev to discuss things? I'm hoping that since I'm here helping to implement this, I can guide it a bit to suit my needs. | 15:17 |
| *** acormier has joined #openstack-nova | 15:19 | |
| tasker | I'm in no rush; the major part of unqiescing the instance is done and I can implement some of these safeguards in my code. | 15:19 |
| *** amodi has joined #openstack-nova | 15:20 | |
| *** yamamoto has quit IRC | 15:21 | |
| mriedem | tasker: i'm working a patch for the up-front quota check now, since i think that's sane and easy as a start, and then we can build on the cleanup stuff after that - what you had in your original patch. as noted, my concerns are with volume backends like NFS which call back to nova to complete a snapshot - i don't know how robust cinder handles deleting a snapshot while it's being created | 15:22 |
| mriedem | my guess is there are no guarantees about behavior | 15:22 |
| mriedem | just like deleting an instance in nova - you can do it at any point, but it's hard to test | 15:22 |
| *** moshele has quit IRC | 15:25 | |
| tasker | gotchya. | 15:26 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Document the real behavior of notify_on_state_change https://review.openstack.org/516264 | 15:27 |
| gibi | mriedem: hi! I replied to your comments in https://review.openstack.org/#/c/516264 | 15:31 |
| *** andreas_s has joined #openstack-nova | 15:31 | |
| *** yamamoto has joined #openstack-nova | 15:31 | |
| mriedem | ack | 15:33 |
| *** cfriesen has quit IRC | 15:34 | |
| *** yamamoto has quit IRC | 15:36 | |
| *** udesale has quit IRC | 15:37 | |
| *** dave-mcc_ has quit IRC | 15:38 | |
| *** mlavalle has joined #openstack-nova | 15:39 | |
| *** cfriesen has joined #openstack-nova | 15:42 | |
| *** yamamoto has joined #openstack-nova | 15:46 | |
| *** cfriesen has quit IRC | 15:47 | |
| *** cfriesen has joined #openstack-nova | 15:47 | |
| *** belmoreira has joined #openstack-nova | 15:49 | |
| *** edand__ has quit IRC | 15:49 | |
| *** yamamoto has quit IRC | 15:50 | |
| *** _gryf is now known as gryf | 15:52 | |
| *** andreas_s has quit IRC | 15:53 | |
| efried | jaypipes jianghuaw_ I was thinking to get started on the update_inventory virt driver method. Any concerns with that? (Or anyone already started?) | 15:53 |
| mriedem | sdague: gibi's got a +2 on the flavor description api change - https://review.openstack.org/#/c/515213/ - would be cool if you could peruse that, given your familiarity with the spec | 15:53 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: Use NoDBTestCase for powervm driver tests https://review.openstack.org/520118 | 15:55 |
| *** Tom-Tom has joined #openstack-nova | 15:56 | |
| *** lajoskatona has quit IRC | 15:59 | |
| tasker | mriedem: what's the command to merge your changes to the patchset locally? | 15:59 |
| *** dave-mccowan has joined #openstack-nova | 15:59 | |
| jaypipes | efried: it needs to go at the end of the n-r-p series, but if you want to take that on, I'd be cool with it. | 16:00 |
| mriedem | tasker: like my commit message change? | 16:00 |
| efried | jaypipes Rockin | 16:00 |
| tasker | yeah. minor, but I want to get my code up-to-date with what exists in the review system. | 16:00 |
| *** itlinux has joined #openstack-nova | 16:00 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: unquiesce instance on volume snapshot failure https://review.openstack.org/519464 | 16:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add the ability to get absolute limits from Cinder https://review.openstack.org/520122 | 16:01 |
| *** yamamoto has joined #openstack-nova | 16:01 | |
| mriedem | tasker: i would normally just delete my local branch and use git review -d 519464 to pull the latest patch set from gerrit | 16:01 |
| *** dave-mccowan has quit IRC | 16:02 | |
| *** edand__ has joined #openstack-nova | 16:04 | |
| sdague | mriedem: I can, after lunch. I have to be out the door in a few minutes, and want to be able to give it a good look over | 16:05 |
| mriedem | wfm, thanks | 16:06 |
| *** yamamoto has quit IRC | 16:06 | |
| sdague | starred it so I won't forget | 16:07 |
| *** rmart04 has quit IRC | 16:07 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/newton: Pass requested_destination in filter_properties https://review.openstack.org/516119 | 16:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/newton: Validate new image via scheduler during rebuild https://review.openstack.org/519684 | 16:09 |
| *** acormier has quit IRC | 16:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/newton: Set group_members when converting to legacy request spec https://review.openstack.org/517868 | 16:10 |
| *** smatzek has joined #openstack-nova | 16:12 | |
| *** Oku_OS is now known as Oku_OS-away | 16:13 | |
| efried | mriedem Is there a novaclient patch for the flavor description thing yet? | 16:13 |
| mriedem | efried: no | 16:13 |
| mriedem | but, | 16:14 |
| mriedem | it's not the first microversion in queens, | 16:14 |
| mriedem | the rebuild + keypair one is, 2.54 | 16:14 |
| mriedem | i don't know if there is a patch up for that yet | 16:14 |
| efried | mriedem Okay. Was going through the ol' checklist, and that's the only thing I didn't see covered. | 16:14 |
| *** smatzek_ has joined #openstack-nova | 16:14 | |
| efried | mriedem (Obviously it wouldn't be in this patch) | 16:14 |
| mriedem | i'll get to it, but it's lower priority until the actual microversion change happens | 16:14 |
| mriedem | otherwise i just have to keep rebasing it | 16:15 |
| mriedem | https://review.openstack.org/#/q/python-novaclient | 16:15 |
| mriedem | so someone needs to write 2.54 into novaclient | 16:15 |
| mriedem | it'll be me if liu doesn't get to it | 16:15 |
| *** Tom-Tom has quit IRC | 16:15 | |
| *** yamamoto has joined #openstack-nova | 16:16 | |
| *** smatzek has quit IRC | 16:17 | |
| mriedem | currently working on getting these newton changes out the door so we can eol the branch | 16:17 |
| mriedem | efried: https://review.openstack.org/#/c/520095/ if you didn't see yet | 16:17 |
| *** markvoelker_ has joined #openstack-nova | 16:18 | |
| *** zhurong has quit IRC | 16:18 | |
| *** markvoelker has quit IRC | 16:20 | |
| *** yamamoto has quit IRC | 16:20 | |
| *** acormier_ has joined #openstack-nova | 16:22 | |
| efried | mriedem Anal shell style comments added. | 16:24 |
| *** andreas_s has joined #openstack-nova | 16:25 | |
| efried | mriedem Actually found a functional nit too. Recognizing that the tags you're looking for will usually not be the ones with dots in 'em. | 16:26 |
| efried | but still | 16:26 |
| *** smatzek_ is now known as smatzek | 16:27 | |
| *** yamamoto has joined #openstack-nova | 16:29 | |
| *** yamamoto has quit IRC | 16:29 | |
| *** edand__ has quit IRC | 16:30 | |
| *** gszasz_ has joined #openstack-nova | 16:31 | |
| *** gszasz has quit IRC | 16:32 | |
| *** andreas_s has quit IRC | 16:39 | |
| *** moshele has joined #openstack-nova | 16:45 | |
| *** Apoorva has joined #openstack-nova | 16:45 | |
| *** yamahata has quit IRC | 16:46 | |
| *** jmlowe has joined #openstack-nova | 16:47 | |
| *** gbarros has quit IRC | 16:47 | |
| *** chyka has joined #openstack-nova | 16:52 | |
| *** lucasagomes is now known as lucas-afk | 16:52 | |
| *** belmoreira has quit IRC | 16:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add the ability to get absolute limits from Cinder https://review.openstack.org/520122 | 16:53 |
| *** links has quit IRC | 17:00 | |
| *** dave-mccowan has joined #openstack-nova | 17:00 | |
| *** psachin has quit IRC | 17:02 | |
| *** tesseract has quit IRC | 17:03 | |
| *** gbarros has joined #openstack-nova | 17:05 | |
| *** hemna_ has quit IRC | 17:05 | |
| *** hemna_ has joined #openstack-nova | 17:06 | |
| *** tbachman has joined #openstack-nova | 17:06 | |
| *** jmlowe has quit IRC | 17:09 | |
| *** gfhellma has joined #openstack-nova | 17:09 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380 | 17:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617 | 17:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633 | 17:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | 17:11 |
| *** gszasz_ has quit IRC | 17:12 | |
| *** masber has quit IRC | 17:15 | |
| *** AlexeyAbashkin has quit IRC | 17:29 | |
| *** yamamoto has joined #openstack-nova | 17:29 | |
| *** claudiub|2 has quit IRC | 17:30 | |
| *** gyee_ has joined #openstack-nova | 17:34 | |
| *** rmart04 has joined #openstack-nova | 17:34 | |
| *** gfhellma_ has joined #openstack-nova | 17:34 | |
| *** yamamoto has quit IRC | 17:35 | |
| *** rmart04 has quit IRC | 17:37 | |
| *** moshele has quit IRC | 17:37 | |
| *** gfhellma has quit IRC | 17:37 | |
| openstackgerrit | Merged openstack/nova stable/pike: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/519632 | 17:44 |
| *** tssurya_ has joined #openstack-nova | 17:45 | |
| *** sshwarts has quit IRC | 17:46 | |
| *** dtantsur is now known as dtantsur|afk | 17:46 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Check quota before creating volume snapshots https://review.openstack.org/520158 | 17:48 |
| mriedem | tasker: ^ | 17:48 |
| *** mpaolino has quit IRC | 17:51 | |
| *** lpetrut_ has quit IRC | 17:51 | |
| *** sridharg has joined #openstack-nova | 17:56 | |
| *** derekh has quit IRC | 17:59 | |
| *** fragatina has joined #openstack-nova | 18:01 | |
| *** fragatina has quit IRC | 18:01 | |
| *** ralonsoh has quit IRC | 18:01 | |
| *** fragatina has joined #openstack-nova | 18:02 | |
| *** yamahata has joined #openstack-nova | 18:02 | |
| mriedem | efried: thanks for the review. i'm not too worried about a . being in an eol tag, since i don't think we have those anywhere, ever, but i can make the changes | 18:05 |
| *** Swami has joined #openstack-nova | 18:06 | |
| *** pcaruana has quit IRC | 18:11 | |
| *** sdague has quit IRC | 18:13 | |
| tasker | mriedem: thanks! | 18:14 |
| *** fragatina has quit IRC | 18:15 | |
| *** jpena is now known as jpena|off | 18:16 | |
| *** mvk has quit IRC | 18:17 | |
| *** samueldmq has quit IRC | 18:19 | |
| *** samueldmq has joined #openstack-nova | 18:19 | |
| *** gfhellma__ has joined #openstack-nova | 18:20 | |
| *** gfhellma_ has quit IRC | 18:24 | |
| *** liuyulong has quit IRC | 18:30 | |
| *** yamamoto has joined #openstack-nova | 18:31 | |
| *** fragatina has joined #openstack-nova | 18:34 | |
| *** Dave has quit IRC | 18:36 | |
| *** yamamoto has quit IRC | 18:37 | |
| *** Dave has joined #openstack-nova | 18:38 | |
| *** lpetrut_ has joined #openstack-nova | 18:39 | |
| *** snasir has quit IRC | 18:49 | |
| *** snasir has joined #openstack-nova | 18:50 | |
| *** itlinux has quit IRC | 18:54 | |
| dansmith | mriedem: tssurya: should we do a cells meeting today? melwitt is out and I'm on a wild goose chase at the moment | 19:01 |
| mriedem | skip it | 19:01 |
| dansmith | sweet | 19:02 |
| *** mvk has joined #openstack-nova | 19:06 | |
| *** sridharg has quit IRC | 19:07 | |
| *** rodolof has joined #openstack-nova | 19:12 | |
| *** moshele has joined #openstack-nova | 19:13 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:13 | |
| tssurya_ | dansmith : yea let's skip it :D | 19:14 |
| *** moshele has quit IRC | 19:16 | |
| *** AlexeyAbashkin has quit IRC | 19:17 | |
| *** READ10 has quit IRC | 19:19 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:22 | |
| *** AlexeyAbashkin has quit IRC | 19:26 | |
| *** Sukhdev has joined #openstack-nova | 19:28 | |
| *** itlinux has joined #openstack-nova | 19:30 | |
| *** yamamoto has joined #openstack-nova | 19:33 | |
| *** yamamoto has quit IRC | 19:38 | |
| openstackgerrit | Sen Yang proposed openstack/python-novaclient master: Implement hypervisor hostname exact patten match for server cold migrate https://review.openstack.org/520187 | 19:49 |
| *** salv-orl_ has joined #openstack-nova | 19:55 | |
| *** salv-orlando has quit IRC | 19:55 | |
| *** tbachman has quit IRC | 20:01 | |
| mriedem | edleafe: sorry it's taken so long but i finally went through https://review.openstack.org/#/c/495854/ | 20:09 |
| mriedem | edleafe: i'm mostly concerned about the refactor that went into the filter scheduler code | 20:10 |
| *** slaweq has joined #openstack-nova | 20:10 | |
| edleafe | mriedem: ok, will read your comments soon | 20:13 |
| *** slaweq has quit IRC | 20:15 | |
| *** nsingh has quit IRC | 20:15 | |
| *** bhagyashris has quit IRC | 20:15 | |
| *** bhagyashris has joined #openstack-nova | 20:16 | |
| *** nsingh has joined #openstack-nova | 20:16 | |
| *** slaweq has joined #openstack-nova | 20:18 | |
| *** slaweq has quit IRC | 20:18 | |
| *** itlinux has quit IRC | 20:19 | |
| *** slaweq has joined #openstack-nova | 20:19 | |
| *** slaweq_ has joined #openstack-nova | 20:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Document the real behavior of notify_on_state_change https://review.openstack.org/516264 | 20:24 |
| *** slaweq has quit IRC | 20:25 | |
| *** tssurya_ has quit IRC | 20:29 | |
| openstackgerrit | Merged openstack/nova master: Remove metadata/system_metadata filter handling from get_all https://review.openstack.org/509819 | 20:30 |
| openstackgerrit | Merged openstack/nova master: Fix indent in configuring-migrations.rst https://review.openstack.org/516013 | 20:30 |
| edleafe | mriedem: that rebase failure you noted was because this has been sitting for so long that the code changed from under it. I'll rebase the whole series | 20:34 |
| *** yamamoto has joined #openstack-nova | 20:34 | |
| mriedem | yeah that one is an easy fix | 20:34 |
| *** sdague has joined #openstack-nova | 20:36 | |
| edleafe | So for the chance scheduler, is it worth adding the cell restriction for the alternates? I mean, does anyone really use that? | 20:37 |
| mriedem | no, not for chance, there is a todo in there from dan about restricting by cell, | 20:37 |
| mriedem | i think if we care about that, we handle the todo later separately | 20:38 |
| edleafe | ok, I'll add a note there. | 20:38 |
| *** yamamoto has quit IRC | 20:39 | |
| *** Sukhdev has quit IRC | 20:39 | |
| *** itlinux has joined #openstack-nova | 20:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a note about versioned notification samples being per-release https://review.openstack.org/520193 | 20:41 |
| *** gbarros has quit IRC | 20:42 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a note about versioned notification samples being per-release https://review.openstack.org/520193 | 20:42 |
| *** Apoorva has quit IRC | 20:43 | |
| *** andreas_s has joined #openstack-nova | 20:43 | |
| *** Apoorva has joined #openstack-nova | 20:43 | |
| *** Apoorva has quit IRC | 20:43 | |
| *** andreas_s has quit IRC | 20:47 | |
| edleafe | mriedem: Not sure what the concern about the refactor is. Would it be better to duplicate the code in this patch, and then add a new patch that does the refactor? | 20:48 |
| sdague | mriedem: +A on https://review.openstack.org/#/c/515213/ | 20:49 |
| mriedem | sdague: thanks | 20:49 |
| mriedem | edleafe: well, (1) why is the refactor needed? | 20:49 |
| mriedem | because as i said in my comments, the change, per the commit message, is about returning Selection objects from the driver rather than HostState objects | 20:50 |
| mriedem | but this is doing more | 20:50 |
| mriedem | edleafe: in other words, why is _ensure_sufficient_hosts needed? why move that check from select_destinations? is it because by the time we get to select_destinations to validate, we don't have the correct *type* of object? | 20:51 |
| mriedem | i'm guessing host.updated = None is the issue | 20:51 |
| mriedem | because that is for a HostState object, not a Selection object | 20:51 |
| *** felipemonteiro has joined #openstack-nova | 20:52 | |
| mriedem | edleafe: if _ensure_sufficient_hosts is needed because of $reason_given_by_me_just_now, then i'm requesting that you split that refactor that introduces _ensure_sufficient_hosts into a patch before https://review.openstack.org/#/c/495854/ in the series | 20:53 |
| mriedem | where we're still dealing with HostState objects | 20:53 |
| mriedem | it would just make review easier to know if we are changing any behavior | 20:53 |
| *** gbarros has joined #openstack-nova | 20:54 | |
| edleafe | mriedem: ok, I'll add a patch before this one. | 20:54 |
| mriedem | cool, thanks | 20:55 |
| mriedem | i think eventually that also allows us to just merge the select_destinations and _schedule methods in the FilterScheduler | 20:55 |
| mriedem | collapse them | 20:55 |
| mriedem | but - later | 20:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix docstring for GET /os-migrations and related DB API https://review.openstack.org/520200 | 20:58 |
| *** itlinux has quit IRC | 21:00 | |
| *** smatzek has quit IRC | 21:12 | |
| efried | jaypipes http://paste.openstack.org/raw/626443/ | 21:16 |
| jaypipes | efried: told ya :) big difference. | 21:16 |
| efried | jaypipes ++ | 21:16 |
| *** sree has joined #openstack-nova | 21:16 | |
| *** itlinux has joined #openstack-nova | 21:20 | |
| *** liverpooler has quit IRC | 21:20 | |
| *** sree has quit IRC | 21:21 | |
| *** threestrands has joined #openstack-nova | 21:32 | |
| *** threestrands has quit IRC | 21:32 | |
| *** threestrands has joined #openstack-nova | 21:32 | |
| efried | jaypipes Is it your vision that update_inventory be mutually exclusive with get_inventory? That is, if a virt driver implements the former, the latter is ignored? | 21:35 |
| *** yamamoto has joined #openstack-nova | 21:36 | |
| efried | jaypipes I had thought that implementing get_inventory caused get_available_resource to be ignored, but it kinda looks like that's not the case? | 21:36 |
| jaypipes | efried: unfortunately, we need to continue supporting get_available_resource() until all resource classes are handled by placement. | 21:37 |
| jaypipes | efried: it was my vision that update_inventory() would override get_inventory() when present, yes. | 21:37 |
| efried | jaypipes Okay. | 21:37 |
| *** slaweq_ has quit IRC | 21:40 | |
| *** yamamoto has quit IRC | 21:41 | |
| *** slaweq has joined #openstack-nova | 21:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add migration_get_by_uuid in db api. https://review.openstack.org/511421 | 21:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904 | 21:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement query param schema for migration index https://review.openstack.org/518644 | 21:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871 | 21:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | 21:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 21:41 |
| *** itlinux has quit IRC | 21:42 | |
| *** slaweq_ has joined #openstack-nova | 21:42 | |
| *** slaweq has quit IRC | 21:43 | |
| *** awaugama has quit IRC | 21:49 | |
| *** eandersson has joined #openstack-nova | 21:51 | |
| *** acormier_ has quit IRC | 21:53 | |
| *** lpetrut_ has quit IRC | 21:53 | |
| *** acormier has joined #openstack-nova | 21:54 | |
| *** acormier has quit IRC | 21:58 | |
| *** smatzek has joined #openstack-nova | 22:00 | |
| *** smatzek has quit IRC | 22:04 | |
| openstackgerrit | Merged openstack/nova master: Trivial grammar fix https://review.openstack.org/517283 | 22:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add microversion to allow setting flavor description https://review.openstack.org/515213 | 22:10 |
| mriedem | sdague: ^ i rebased to kick it into the gate, it didn't go through for some reason | 22:10 |
| *** itlinux has joined #openstack-nova | 22:11 | |
| *** slaweq has joined #openstack-nova | 22:11 | |
| *** rodolof has quit IRC | 22:11 | |
| *** liverpooler has joined #openstack-nova | 22:12 | |
| *** slaweq has quit IRC | 22:15 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP(5): PowerVM driver: ovs vif https://review.openstack.org/422512 | 22:17 |
| *** slaweq_ has quit IRC | 22:17 | |
| *** slaweq has joined #openstack-nova | 22:18 | |
| *** AlexeyAbashkin has joined #openstack-nova | 22:21 | |
| *** itlinux has quit IRC | 22:23 | |
| *** rcernin has joined #openstack-nova | 22:23 | |
| *** vladikr has quit IRC | 22:24 | |
| *** AlexeyAbashkin has quit IRC | 22:26 | |
| *** mvk has quit IRC | 22:35 | |
| *** esberglu has quit IRC | 22:36 | |
| *** esberglu has joined #openstack-nova | 22:37 | |
| *** yamamoto has joined #openstack-nova | 22:37 | |
| *** jbernard has quit IRC | 22:38 | |
| *** jbernard has joined #openstack-nova | 22:38 | |
| *** claudiub|2 has joined #openstack-nova | 22:38 | |
| *** esberglu has quit IRC | 22:41 | |
| *** yamamoto has quit IRC | 22:42 | |
| *** itlinux has joined #openstack-nova | 22:43 | |
| *** felipemonteiro has quit IRC | 22:44 | |
| *** ssurana has joined #openstack-nova | 22:45 | |
| *** ssurana has quit IRC | 22:45 | |
| *** edmondsw has quit IRC | 22:46 | |
| *** jdavis has joined #openstack-nova | 22:47 | |
| *** priteau has quit IRC | 22:50 | |
| eandersson | Is there a reason why this flag is always set to False? https://github.com/openstack/nova/blob/mitaka-eol/nova/virt/driver.py#L1249 | 22:54 |
| eandersson | In certain scenarios when nova-compute fails to schedule it does not clean up the network ports | 22:56 |
| eandersson | e.g. when hitting > qemu-kvm: cannot set up guest memory 'pc.ram': Cannot allocate memory | 22:56 |
| mriedem | eandersson: it's apparently specific to baremetal | 22:57 |
| mriedem | in how it's used anyway | 22:57 |
| mriedem | otherwise i think ports created for an instance will go with the instance and be bound on the next host | 22:58 |
| eandersson | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1880 | 22:58 |
| eandersson | It's used in this code path | 22:58 |
| mriedem | yeah i'm looking at it locally | 22:59 |
| eandersson | and basically if this function is called self._cleanup_allocated_networks | 22:59 |
| eandersson | it will clean it up properly | 22:59 |
| mriedem | what do you actually need cleaned up before the reschedule? | 22:59 |
| mriedem | the ports should not be bound to that host at that point | 22:59 |
| eandersson | Well the problem we are hitting is that each time it gets re-scheduled, a new ip is assigned | 22:59 |
| mriedem | is a new port created? | 23:00 |
| eandersson | Yea | 23:00 |
| mriedem | ok, that's a problem, and i think an old one | 23:00 |
| *** vladikr has joined #openstack-nova | 23:00 | |
| mriedem | i'm sure i could find some bugs if i dug for a bit | 23:00 |
| eandersson | I am reproducing it with this http://paste.openstack.org/show/626450/ | 23:00 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1703540 | 23:00 |
| openstack | Launchpad bug 1703540 in OpenStack Compute (nova) "Reschedule with libvirt exception leaves dangling neutron ports" [High,Triaged] | 23:00 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1531022 | 23:01 |
| openstack | Launchpad bug 1531022 in OpenStack Compute (nova) "libvirt driver doesn't cleanup the tap interface on vm re-schedule" [Low,Confirmed] | 23:01 |
| eandersson | oh not sure why I didn't find that one | 23:01 |
| mriedem | yeah see comment #3 on https://bugs.launchpad.net/nova/+bug/1703540 | 23:01 |
| openstack | Launchpad bug 1703540 in OpenStack Compute (nova) "Reschedule with libvirt exception leaves dangling neutron ports" [High,Triaged] | 23:02 |
| eandersson | Yep - perfect | 23:02 |
| eandersson | that is the exact same conclusion I came to | 23:02 |
| mriedem | it would be as easy as calling cleanup_instance_network_on_host to remove any ports we created | 23:02 |
| mriedem | however, doing that for neutron would basically be the same as for _cleanup_allocated_networks i think | 23:03 |
| mriedem | because nova has to be smart about not deleting ports that the user supplied vs ones that nova created | 23:03 |
| eandersson | Is there a reason why we can't just call _cleanup_allocated_networks ? | 23:03 |
| eandersson | I tested that out in my lab and it worked 100% of the time | 23:03 |
| eandersson | but obviously my test case is rather limited | 23:04 |
| mriedem | honestly i'm not sure, and i worry that doing that will break something else, which is probably why we've never just done that | 23:05 |
| mriedem | there was this patch for a related bug long ago https://review.openstack.org/#/c/367316/ | 23:05 |
| mriedem | oh that was a backport | 23:06 |
| mriedem | ok so https://review.openstack.org/#/c/243477/ is a different fix, | 23:07 |
| mriedem | ^ is if all reschedules fail and we've run out of retries i think, so the instance is set to ERROR | 23:07 |
| mriedem | which is different than, | 23:07 |
| mriedem | host A fails, host B works | 23:07 |
| mriedem | you'd have 2 ports | 23:07 |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert ext filesystem resizes to privsep. https://review.openstack.org/517516 | 23:07 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move flushing block devices to privsep. https://review.openstack.org/519010 | 23:07 |
| openstackgerrit | Michael Still proposed openstack/nova master: Start moving users of parted to privsep. https://review.openstack.org/519011 | 23:07 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move remaining uses of parted to privsep. https://review.openstack.org/519483 | 23:07 |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert users of tune2fs to privsep. https://review.openstack.org/519484 | 23:07 |
| eandersson | I see | 23:08 |
| *** imacdonn has quit IRC | 23:09 | |
| *** imacdonn has joined #openstack-nova | 23:09 | |
| *** takashin has joined #openstack-nova | 23:10 | |
| mriedem | i'm also not entirely sure if _cleanup_allocated_networks will do the entire job since it doesn't explicitly unplug vifs via the virt driver, | 23:10 |
| mriedem | i'm not sure if deleting the port will take care of that out of band? | 23:11 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1531022/comments/2 | 23:11 |
| openstack | Launchpad bug 1531022 in OpenStack Compute (nova) "libvirt driver doesn't cleanup the tap interface on vm re-schedule" [Low,Confirmed] | 23:11 |
| efried | jaypipes More sanity check: In order to pass the entire provider tree to update_inventory, I'm going to need to *get* the entire tree. Which entails a new method in report client that calls GET with the new ?tree= deal, then builds up the ProviderTree object accordingly. And then actually returns that guy, which is currently a private _provider_tree attribute and not actually returned anywhere yet. | 23:12 |
| eandersson | I don't see the tap at least on the compute I tested it on | 23:12 |
| eandersson | but this is mitaka, who knows how it would work on other versions of Openstack | 23:12 |
| mriedem | well, does it maybe depend on the type of interface? | 23:13 |
| mriedem | vif type i mean | 23:13 |
| efried | jaypipes Then when I get it back from update_inventory, the driver may have added children and whatnot, so I'm going to have to walk the tree to rearrange the placement db accordingly. | 23:13 |
| *** priteau has joined #openstack-nova | 23:13 | |
| mriedem | eandersson: here is another one https://review.openstack.org/#/c/335788 | 23:14 |
| *** jmlowe has joined #openstack-nova | 23:14 | |
| efried | jaypipes And also call _normalize_inventory_from_cn_obj on every provider in the tree, in case they decided to shove their VCPU/MEMORY_MB/DISK_GB in children instead of leaving them in the root. | 23:14 |
| mriedem | "If I understand the code correctly, the intention of not deleting the port when rescheduling is that it could be reused on the second compute node. But that reuse does not seem to happen, instead nova allocates another port, leaving the first one pending." | 23:14 |
| mriedem | eandersson: it could also totally be some legacy nova-network thing | 23:15 |
| efried | jaypipes That first thing sort of a tree-ified version of _ensure_resource_provider | 23:15 |
| mriedem | like maybe we didn't deallocate networks on reschedule if you were using nova-net? i'm not sure | 23:15 |
| *** itlinux has quit IRC | 23:15 | |
| eandersson | Yea - I have done a lot of testing, but I am hesitant to change this without knowing all potential side-effects (even if only for internal usage) | 23:17 |
| eandersson | but it being a legacy thing would make a lot of sense | 23:17 |
| *** priteau has quit IRC | 23:17 | |
| *** dave-mccowan has quit IRC | 23:19 | |
| *** lyan has quit IRC | 23:20 | |
| *** mlavalle has quit IRC | 23:20 | |
| mriedem | eandersson: ok i'm going to duplicate some of the bugs to just this one https://bugs.launchpad.net/nova/+bug/1597596 | 23:20 |
| openstack | Launchpad bug 1597596 in OpenStack Compute (nova) "network not always cleaned up when spawning VMs" [Medium,Confirmed] | 23:20 |
| mriedem | which had a patch and did a lot of the same investigation | 23:20 |
| *** AlexeyAbashkin has joined #openstack-nova | 23:20 | |
| *** jmlowe has quit IRC | 23:21 | |
| *** cfriesen has quit IRC | 23:24 | |
| mriedem | eandersson: so https://review.openstack.org/#/c/335788/ isn't going to fly, because it's totally relying on 2 out of tree scheduler hints :/ | 23:24 |
| *** cfriesen has joined #openstack-nova | 23:24 | |
| *** AlexeyAbashkin has quit IRC | 23:25 | |
| mriedem | eandersson: part of me just wants to add an "or utils.is_neutron()" to that conditional check on reschedule | 23:25 |
| mriedem | so if there is a legacy case for nova-net, it's not affected here | 23:25 |
| mriedem | and we'll just always remove ports that nova created on reschedule | 23:26 |
| mriedem | dansmith: do you recall any reasons why we don't just always remove ports we created when we reschedule? | 23:26 |
| *** cfriesen has quit IRC | 23:26 | |
| *** cfriesen_ has joined #openstack-nova | 23:26 | |
| eandersson | Yea - I don't like 335788 | 23:26 |
| eandersson | but utils.is_neutron would be awesome for this | 23:26 |
| eandersson | that way if there really is some nova-net edge case we would be covered | 23:27 |
| dansmith | um, I don't remember the exact reason, but I think there is one... like setup time or resources for certain backends maybe? | 23:27 |
| mriedem | the bug reports i've been digging through seem to indicate that certain ML2 backends are cool with us not deallocating ports between reschedules | 23:27 |
| mriedem | however, i think from the nova side, | 23:28 |
| mriedem | we're still creating a port each time we call build_and_run_instance | 23:28 |
| *** gouthamr has quit IRC | 23:28 | |
| mriedem | so even if the underlying network is tying those together somehow, or ignoring them, | 23:28 |
| mriedem | we're at worst eating up port quota for the project | 23:28 |
| mriedem | for ports that we don't use | 23:28 |
| *** tbachman has joined #openstack-nova | 23:28 | |
| mriedem | s/use/bind/ | 23:28 |
| dansmith | tbh, it's been a long time since I looked at that path, probably before the great compute/conductor split for build | 23:28 |
| mriedem | yeah, so, | 23:29 |
| mriedem | in the interest of our "damn the torpedos" pledge from the ptg | 23:29 |
| mriedem | and just break everything | 23:29 |
| mriedem | i say we add an "is_neutron" check in this case and just always deallocate before reschedluing | 23:29 |
| mriedem | if that breaks some unicorn ML2 backend, let them speak up | 23:29 |
| dansmith | we delete ones we create unceremoniously on delete now? | 23:29 |
| dansmith | and what about offload? | 23:30 |
| mriedem | when the instance is deleted yes we cleanup and delete anything nova created | 23:30 |
| gmann | alex_xu: hi, returned back to tokyo today | 23:30 |
| mriedem | well, as you can guess, | 23:30 |
| mriedem | dansmith: shelve offload won't delete or cleanup the ports at all, | 23:30 |
| *** masber has joined #openstack-nova | 23:30 | |
| mriedem | it only unplugs the vifs via driver.destroy() | 23:30 |
| mriedem | the actual port will still show as being bound to the original host, | 23:31 |
| dansmith | and unshelve can continue using those ports? | 23:31 |
| mriedem | until we unshelve the instance and bind it to a new host | 23:31 |
| mriedem | i assume so... | 23:31 |
| dansmith | I guess I would expect reschedule to do the same thing.. unbind/rebind | 23:31 |
| mriedem | i only have a single node devstack atm so can't really test unshelve to another host and ssh into the guest after it's unshelved | 23:31 |
| dansmith | but using shelve as the poster child is probably a weaker argument than delete | 23:31 |
| mriedem | yeah, anything to do with ports and volumes + shelve is a roll of the dice | 23:32 |
| mriedem | given we didn't actually terminate connetions for the last 4 years for volumes on unshelve | 23:32 |
| dansmith | yeah | 23:32 |
| *** esberglu has joined #openstack-nova | 23:32 | |
| dansmith | well, doing the same thing as delete is defensible so if that's the plan it seems reasonable | 23:32 |
| mriedem | alright | 23:32 |
| mriedem | i'll see if can wordsmith a reasonable commit message | 23:33 |
| mriedem | because there is also prior art in this area which always confuses me | 23:33 |
| *** cfriesen_ has quit IRC | 23:33 | |
| *** cfriesen_ has joined #openstack-nova | 23:33 | |
| *** jmlowe has joined #openstack-nova | 23:33 | |
| gmann | yikun: re: on https://review.openstack.org/#/c/518644/11 | 23:35 |
| gmann | yikun: all param in query are as string so we use type as string, if any param is integer then we can use non_integer or positive_integer schema | 23:36 |
| gmann | yikun: and on additionalProperties=True we kept that for backward compatibility but at validation layer all the additional properties will be ignored and stripout | 23:37 |
| gmann | yikun: if you are doing migration pagination with microversion then you can make it False. anyways i will check the patch series today | 23:38 |
| *** jmlowe has quit IRC | 23:38 | |
| mriedem | gmann: i updated that one today | 23:38 |
| mriedem | the schema thing anyway | 23:38 |
| *** yamamoto has joined #openstack-nova | 23:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.54 - Enable reset keypair while rebuild https://review.openstack.org/519572 | 23:39 |
| gmann | mriedem: it is with version bump ? | 23:39 |
| mriedem | no | 23:39 |
| mriedem | it's all backward compatible | 23:39 |
| mriedem | because additionalProperties=True | 23:39 |
| mriedem | i removed cell_name from the list of query parameters in the schema because it's not used anywhere in the actual nova code, | 23:40 |
| mriedem | novaclient sends it, but shouldn't | 23:40 |
| mriedem | so i'm just treating cell_name like additionalProperties | 23:40 |
| mriedem | in a far flung future microversion we can change all of that | 23:40 |
| gmann | mriedem: i see. | 23:42 |
| gmann | got confuse with https://review.openstack.org/#/q/topic:bp/add-pagination-and-change-since-for-migration-list+(status:open+OR+status:merged) | 23:42 |
| gmann | that patch is just putting schema for existing filters. | 23:42 |
| mriedem | yes, | 23:42 |
| gmann | patch topic was new BP | 23:42 |
| mriedem | it was part of https://review.openstack.org/#/c/330406/ originally and i asked that he split it out | 23:42 |
| gmann | ok | 23:42 |
| mriedem | ah yeah https://review.openstack.org/#/c/330406/58/nova/api/openstack/compute/schemas/migrations.py@47 | 23:43 |
| mriedem | so in 2.55 he'd now restrict to the list of known parameters | 23:43 |
| gmann | nice. | 23:44 |
| *** yamamoto has quit IRC | 23:44 | |
| *** edmondsw has joined #openstack-nova | 23:44 | |
| gmann | and all pagination param are single_param.+1 | 23:44 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 23:51 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | 23:51 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159 | 23:51 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | 23:51 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 23:51 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | 23:51 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Refactor the code to check for sufficient hosts https://review.openstack.org/520242 | 23:51 |
| edleafe | mriedem: ^^ refactored | 23:52 |
| efried | jaypipes I find it very confusing that _Provider represents a node in a tree of providers, but ProviderTree actuall represents any number of such trees. | 23:53 |
| efried | Rename ProviderTree to ProviderTrees. Or ProviderBush. | 23:54 |
| *** edmondsw has quit IRC | 23:55 | |
| edleafe | efried: ProviderVine? | 23:56 |
| efried | edleafe ProvideMeVino | 23:57 |
| edleafe | I like the way you think! | 23:57 |
| *** edmondsw has joined #openstack-nova | 23:57 | |
| eandersson | btw does placement take actual resources into account when scheduling vms on overcommited hosts? | 23:57 |
| eandersson | In Mitaka we are hitting this when the compute is out of memory, but the scheduler still thinks there is room available | 23:59 |
| eandersson | > qemu-kvm: cannot set up guest memory 'pc.ram': Cannot allocate memory | 23:59 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Iterator for a provider tree https://review.openstack.org/520243 | 23:59 |
| efried | jaypipes We're gonna need that ^ | 23:59 |
| mriedem | eandersson: are you setting the reserved space config? | 23:59 |
| eandersson | Yea | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!