Wednesday, 2017-07-26

*** esberglu has quit IRC00:04
*** yamamoto has quit IRC00:10
*** yamamoto has joined #openstack-nova00:11
*** acormier has quit IRC00:13
*** gmann has quit IRC00:15
*** gmann has joined #openstack-nova00:15
*** acormier has joined #openstack-nova00:17
*** jackie-truong has quit IRC00:17
*** vishwanathj has quit IRC00:18
*** Apoorva_ has quit IRC00:18
*** vishwanathj has joined #openstack-nova00:18
*** Apoorva has joined #openstack-nova00:19
*** markvoelker has quit IRC00:20
*** edmondsw has joined #openstack-nova00:20
*** randomhack has joined #openstack-nova00:22
*** Apoorva has quit IRC00:23
*** fragatina has quit IRC00:23
*** dtp has quit IRC00:23
mriedemjangutter: question in https://review.openstack.org/#/c/483459/15/nova/network/os_vif_util.py@33300:24
*** edmondsw has quit IRC00:25
*** randomhack has quit IRC00:27
*** psachin has joined #openstack-nova00:28
*** thorst has joined #openstack-nova00:29
*** jwcroppe has joined #openstack-nova00:29
*** claudiub has joined #openstack-nova00:31
*** thorst has quit IRC00:33
*** jwcroppe has quit IRC00:33
*** jwcroppe has joined #openstack-nova00:33
*** markvoelker has joined #openstack-nova00:35
*** tetsuro has joined #openstack-nova00:39
*** kiennt has joined #openstack-nova00:40
*** esberglu has joined #openstack-nova00:40
*** sdague has quit IRC00:41
*** acormier has quit IRC00:42
*** hshiina has joined #openstack-nova00:43
*** esberglu has quit IRC00:45
*** tuanluong has joined #openstack-nova00:50
*** claudiub has quit IRC00:51
*** baoli has joined #openstack-nova00:52
*** thorst has joined #openstack-nova00:59
*** phuongnh has joined #openstack-nova01:02
*** acormier has joined #openstack-nova01:05
alex_xuoomichi: thanks01:06
*** thorst has quit IRC01:07
openstackgerritMatt Riedemann proposed openstack/nova master: Translate the return value of attachment_create and _update  https://review.openstack.org/48619401:16
openstackgerritMatt Riedemann proposed openstack/nova master: Implement new attach Cinder flow  https://review.openstack.org/33028501:16
*** rajathagasthya has quit IRC01:18
*** mdnadeem has joined #openstack-nova01:19
*** moshele has joined #openstack-nova01:20
*** yamahata has quit IRC01:22
*** lucasxu has joined #openstack-nova01:22
*** lucasxu has quit IRC01:24
*** mtanino has joined #openstack-nova01:25
moshelemriedem, jaypipes: hi can you review https://review.openstack.org/#/c/398265/ ?01:26
*** yufei has joined #openstack-nova01:27
*** harlowja has quit IRC01:29
*** mriedem has quit IRC01:29
*** mtanino has quit IRC01:30
*** Shunli has joined #openstack-nova01:32
openstackgerritZhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API  https://review.openstack.org/48685001:33
*** litao__ has joined #openstack-nova01:35
*** Kevin_Zheng has joined #openstack-nova01:42
*** gcb has joined #openstack-nova01:47
*** edmondsw has joined #openstack-nova02:08
openstackgerritMerged openstack/nova master: Add VIFHostDevice support to libvirt driver  https://review.openstack.org/48642602:08
*** acormier has quit IRC02:11
openstackgerritMoshe Levi proposed openstack/nova master: hardware offload support for openvswitch  https://review.openstack.org/39826502:11
*** acormier has joined #openstack-nova02:11
*** jamesden_ has quit IRC02:13
*** edmondsw has quit IRC02:13
*** itlinux_ has quit IRC02:14
*** yamahata has joined #openstack-nova02:15
*** acormier has quit IRC02:16
*** tbachman_ has joined #openstack-nova02:17
*** patriciadomin has quit IRC02:19
*** csuttles has quit IRC02:19
*** beagles has quit IRC02:19
*** csuttles_ has joined #openstack-nova02:19
*** tobasco has quit IRC02:19
*** patriciadomin has joined #openstack-nova02:19
*** doffm has quit IRC02:19
*** tobasco has joined #openstack-nova02:20
*** b3nt_pin has joined #openstack-nova02:20
*** doffm has joined #openstack-nova02:20
*** tbachman has quit IRC02:20
*** tbachman_ is now known as tbachman02:20
*** gaurangt has quit IRC02:22
*** takashin has quit IRC02:22
*** takashin has joined #openstack-nova02:23
*** jamesdenton has joined #openstack-nova02:24
*** jamesdenton has quit IRC02:25
*** gaurangt has joined #openstack-nova02:25
*** jamesdenton has joined #openstack-nova02:26
*** saphi has joined #openstack-nova02:30
*** gouthamr has joined #openstack-nova02:31
*** baoli has quit IRC02:33
saphiHi guys. I'm deploying Openstack Pike on Ubuntu 16.04 use ubuntu archive repository. I have two node controller and compute. nova-compute was installed on both of them. So I have two compute nodes. But When I launch an instance. If the instance go to compute-node, it can't download Image from glance-api. If the instance go to controller node, It run successful.02:33
*** baoli has joined #openstack-nova02:34
saphiOn glance-api.log, the error is timed out.02:35
*** crushil has quit IRC02:36
*** crushil has joined #openstack-nova02:37
saphiOh. the problem is my network configuration02:40
*** jamesdenton has quit IRC02:42
*** baoli has quit IRC02:49
tetsuroreported a bug that you can't use ":" as az name, and proposed 2 solutions. could you advise me which solution is better on https://bugs.launchpad.net/nova/+bug/1695861 ?02:57
openstackLaunchpad bug 1695861 in OpenStack Compute (nova) "Invalid availability zone name with ':' is accepted" [Undecided,Confirmed]02:57
*** takashin has left #openstack-nova03:02
*** vishwanathj has quit IRC03:06
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Add 'Forced down' column in serivce-list  https://review.openstack.org/48726303:07
*** vishwanathj has joined #openstack-nova03:07
*** vishwanathj has quit IRC03:09
*** vishwanathj has joined #openstack-nova03:09
*** zsli_ has joined #openstack-nova03:26
*** Shunli has quit IRC03:28
*** moshele has quit IRC03:28
*** zsli_ has quit IRC03:30
*** links has joined #openstack-nova03:30
*** links has quit IRC03:30
*** mamandle has joined #openstack-nova03:45
*** jamesdenton has joined #openstack-nova03:49
*** edmondsw has joined #openstack-nova03:57
*** mamandle has quit IRC03:57
*** fragatina has joined #openstack-nova03:57
*** fragatina has quit IRC04:00
*** fragatina has joined #openstack-nova04:01
*** edmondsw has quit IRC04:01
*** chyka has quit IRC04:03
*** udesale has joined #openstack-nova04:03
*** _pewp_ has quit IRC04:04
*** nicolasbock has joined #openstack-nova04:04
*** _pewp_ has joined #openstack-nova04:06
*** deep-book-gk_ has joined #openstack-nova04:19
*** jamesdenton has quit IRC04:21
*** deep-book-gk_ has left #openstack-nova04:22
*** rajathagasthya has joined #openstack-nova04:27
*** oomichi has quit IRC04:29
*** oomichi has joined #openstack-nova04:30
*** sree_ has joined #openstack-nova04:32
*** kornicameister has joined #openstack-nova04:32
*** sree_ is now known as Guest6874904:33
*** gongysh has joined #openstack-nova04:34
*** cNilesh has joined #openstack-nova04:36
*** armax has quit IRC04:37
*** armax has joined #openstack-nova04:37
*** armax has quit IRC04:37
*** Guest68749 has quit IRC04:38
*** armax has joined #openstack-nova04:38
*** armax has quit IRC04:38
*** armax has joined #openstack-nova04:39
*** armax has quit IRC04:39
*** armax has joined #openstack-nova04:40
*** harlowja has joined #openstack-nova04:40
*** armax has quit IRC04:40
*** gongysh has quit IRC04:40
*** armax has joined #openstack-nova04:40
*** armax has quit IRC04:41
*** armax has joined #openstack-nova04:41
*** armax has quit IRC04:41
*** armax has joined #openstack-nova04:42
*** armax has quit IRC04:42
*** armax has joined #openstack-nova04:43
*** armax has quit IRC04:43
*** armax has joined #openstack-nova04:44
*** armax has quit IRC04:44
*** armax has joined #openstack-nova04:44
*** armax has quit IRC04:45
*** armax has joined #openstack-nova04:45
*** armax has quit IRC04:45
*** armax has joined #openstack-nova04:46
*** armax has quit IRC04:46
*** armax has joined #openstack-nova04:47
*** armax has quit IRC04:47
*** armax has joined #openstack-nova04:48
*** armax has quit IRC04:48
*** jamesdenton has joined #openstack-nova04:48
*** priteau has joined #openstack-nova04:49
*** esberglu has joined #openstack-nova04:53
*** prateek_ has joined #openstack-nova04:57
*** esberglu has quit IRC04:58
*** jamesdenton has quit IRC04:59
*** kazsh has joined #openstack-nova04:59
*** gouthamr has quit IRC05:00
*** thorst has joined #openstack-nova05:04
*** sree_ has joined #openstack-nova05:05
*** sree_ is now known as Guest6772505:06
*** rajathagasthya has quit IRC05:06
*** vishwana_ has joined #openstack-nova05:08
*** vishwana_ has quit IRC05:09
*** vishwanathj has quit IRC05:09
*** thorst has quit IRC05:10
*** vishwanathj has joined #openstack-nova05:10
*** markvoelker has quit IRC05:13
*** mamandle has joined #openstack-nova05:15
*** mamandle has quit IRC05:22
*** jjung has joined #openstack-nova05:32
*** mamandle has joined #openstack-nova05:37
*** ratailor has joined #openstack-nova05:38
*** harlowja has quit IRC05:39
*** gongysh has joined #openstack-nova05:40
*** vikram has joined #openstack-nova05:41
vikramI have a query about keypair05:41
*** moshele has joined #openstack-nova05:41
vikramCannot find a 'project_id' field in the keypair table then how GET call with a project-id ensures keypair for the queried project is only returned05:42
*** trinaths has joined #openstack-nova05:42
*** kiennt has quit IRC05:42
vikramI can find the GET call is returning all the keypairs05:43
vikramCan someone please help05:43
*** priteau has quit IRC05:44
*** edmondsw has joined #openstack-nova05:45
*** edmondsw has quit IRC05:49
*** moshele has quit IRC05:50
*** Shunli has joined #openstack-nova05:59
*** kiennt has joined #openstack-nova06:00
*** fragatina has quit IRC06:03
*** fragatina has joined #openstack-nova06:05
*** rcernin has joined #openstack-nova06:06
*** fragatina has quit IRC06:08
*** andreas_s has joined #openstack-nova06:09
*** chyka has joined #openstack-nova06:22
*** randomhack has joined #openstack-nova06:23
*** dixiaoli_ has joined #openstack-nova06:25
*** chyka has quit IRC06:27
*** randomhack has quit IRC06:27
*** thorst has joined #openstack-nova06:29
*** thorst has quit IRC06:33
*** sshwarts has joined #openstack-nova06:37
*** litao__ has quit IRC06:39
*** bkopilov_ has quit IRC06:39
*** esberglu has joined #openstack-nova06:41
*** dtantsur|afk is now known as dtantsur06:42
*** sridharg has joined #openstack-nova06:44
gmannvikram, it is associated with user_id06:45
gmannvikram, and if user id is not passed (it is supported from 2.10) it will be fetched from request context06:46
*** esberglu has quit IRC06:46
*** moshele has joined #openstack-nova06:47
*** cfriesen has quit IRC06:49
openstackgerritBéla Vancsics proposed openstack/nova master: Reduced the complexity of the _init_instance method (1)  https://review.openstack.org/37466106:50
*** yamamoto has quit IRC06:54
gmannalex_xu, any issue with this(error) https://review.openstack.org/#/c/485061/306:56
*** jamesdenton has joined #openstack-nova06:56
openstackgerritMerged openstack/nova master: Set IronicNodeState.uuid in _update_from_compute_node  https://review.openstack.org/48722707:00
*** jamesdenton has quit IRC07:00
*** belmoreira has joined #openstack-nova07:05
vikramgmann: ping07:07
gmannvikram, pong07:11
vikramgmann: Why nova GET call expects a project-id then?07:12
gmannvikram, in request body? or url?07:13
*** ralonsoh has joined #openstack-nova07:13
*** markvoelker has joined #openstack-nova07:14
*** markus_z has joined #openstack-nova07:14
vikramgmann: any clue?07:14
alex_xugmann: I guess it is just the gate problem, the patch after that one passed all the tests07:15
gmannvikram, thats for all APIs and it has been removed from microversion 2.18 - https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id1607:16
vikramgmann: ok07:17
gmannalex_xu, ok, i rechecked that07:17
gmannvikram, after 2.18 you can skip the project_id for API request07:17
vikramgmann: thanks07:17
gmannvikram, np!07:18
*** ralonsoh has quit IRC07:21
*** ralonsoh_ has joined #openstack-nova07:21
*** vikram has quit IRC07:23
*** ralonsoh_ is now known as ralonsoh07:23
*** edmondsw has joined #openstack-nova07:33
*** crushil has quit IRC07:33
*** crushil has joined #openstack-nova07:34
*** edmondsw has quit IRC07:37
*** priteau has joined #openstack-nova07:38
*** ratailor is now known as ratailor|Lunch07:40
*** alexchadin has joined #openstack-nova07:43
*** jaosorior has quit IRC07:43
openstackgerritZhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API  https://review.openstack.org/48685007:44
*** crushil has quit IRC07:44
*** claudiub has joined #openstack-nova07:45
*** dims has quit IRC07:45
*** priteau has quit IRC07:46
*** markvoelker has quit IRC07:48
*** dims has joined #openstack-nova07:49
*** damien_r has joined #openstack-nova07:50
openstackgerritBalazs Gibizer proposed openstack/nova master: Dump versioned notifications when sample test fails  https://review.openstack.org/48731407:51
*** yamamoto has joined #openstack-nova07:55
*** jaosorior has joined #openstack-nova07:57
*** jaosorior has quit IRC07:58
*** vishwanathj has quit IRC07:58
*** vishwanathj has joined #openstack-nova07:58
*** jaosorior has joined #openstack-nova07:59
*** zsli_ has joined #openstack-nova08:00
*** ratailor|Lunch is now known as ratailor08:01
*** yamamoto has quit IRC08:02
*** jaosorior has quit IRC08:02
*** Shunli has quit IRC08:03
*** jaosorior has joined #openstack-nova08:03
*** jaosorior has quit IRC08:03
*** jaosorior has joined #openstack-nova08:04
*** zsli__ has joined #openstack-nova08:08
*** derekh has joined #openstack-nova08:08
*** zsli_ has quit IRC08:11
*** mamandle has quit IRC08:12
*** gongysh has quit IRC08:12
*** jaosorior has quit IRC08:13
*** zsli__ has quit IRC08:15
*** lucas-afk is now known as lucasagomes08:15
openstackgerritBéla Vancsics proposed openstack/nova master: Reduced the complexity of the _init_instance method (2)  https://review.openstack.org/42061908:16
*** Shunli has joined #openstack-nova08:18
*** bkopilov_ has joined #openstack-nova08:19
*** priteau has joined #openstack-nova08:20
*** mamandle has joined #openstack-nova08:22
*** efoley has joined #openstack-nova08:23
*** zsli_ has joined #openstack-nova08:23
openstackgerritGábor Antal proposed openstack/nova master: Add helper method for waiting migrations in functional tests  https://review.openstack.org/48653708:23
*** efoley_ has joined #openstack-nova08:24
*** efoley has quit IRC08:24
*** priteau has quit IRC08:24
openstackgerritBalazs Gibizer proposed openstack/nova master: Improve assertJsonEqual error reporting  https://review.openstack.org/42819908:24
*** Shunli has quit IRC08:26
*** esberglu has joined #openstack-nova08:29
*** thorst has joined #openstack-nova08:30
openstackgerritGábor Antal proposed openstack/nova master: Transform instance.live_migration_force_complete notification  https://review.openstack.org/48056108:30
*** esberglu has quit IRC08:34
*** thorst has quit IRC08:34
*** efoley_ is now known as efoley08:35
*** tetsuro has quit IRC08:37
*** dtantsur is now known as dtantsur|bbl08:38
openstackgerritAlex Szarka proposed openstack/nova master: Transform instance.exists notification  https://review.openstack.org/40366008:44
gabor_antalmriedem bauzas: Would you please take a look at https://review.openstack.org/486537 ?08:44
*** markvoelker has joined #openstack-nova08:45
bauzasgabor_antal: ack08:46
*** tbachman has quit IRC08:50
openstackgerritAlex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications  https://review.openstack.org/46552608:51
*** jaosorior has joined #openstack-nova08:53
*** priteau has joined #openstack-nova08:54
*** tbachman has joined #openstack-nova08:54
*** priteau has quit IRC08:58
*** jamesdenton has joined #openstack-nova08:59
*** vishwanathj has quit IRC09:01
*** vishwanathj has joined #openstack-nova09:01
*** jaosorior has quit IRC09:03
*** jamesdenton has quit IRC09:04
openstackgerritAlex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications  https://review.openstack.org/46552609:06
openstackgerritBalazs Gibizer proposed openstack/nova master: do not pass proxy env variables by tox  https://review.openstack.org/48732709:07
*** damien_r1 has joined #openstack-nova09:13
*** dr_gogeta86_ has quit IRC09:15
*** damien_r has quit IRC09:16
*** markvoelker has quit IRC09:19
*** john5223_ has quit IRC09:19
*** rhagarty has quit IRC09:19
*** dr_gogeta86 has joined #openstack-nova09:20
*** jjung has quit IRC09:20
*** jaosorior has joined #openstack-nova09:21
*** gryf has quit IRC09:21
*** dr_gogeta86 has quit IRC09:21
*** dr_gogeta86 has joined #openstack-nova09:21
*** stephenfin has quit IRC09:21
openstackgerritAlex Szarka proposed openstack/nova master: Transform instance-live_migration_abort notification  https://review.openstack.org/42045309:21
*** gongysh has joined #openstack-nova09:21
*** gryf has joined #openstack-nova09:22
*** sfinucan has quit IRC09:22
*** edmondsw has joined #openstack-nova09:22
*** cristicalin has joined #openstack-nova09:22
*** rhagarty has joined #openstack-nova09:23
*** sfinucan has joined #openstack-nova09:23
*** mdrabe has quit IRC09:23
*** ekhugen has quit IRC09:23
*** stephenfin has joined #openstack-nova09:24
*** yamamoto has joined #openstack-nova09:24
*** edmondsw has quit IRC09:25
*** priteau has joined #openstack-nova09:25
*** mdrabe has joined #openstack-nova09:26
*** ekhugen has joined #openstack-nova09:26
*** zsli_ has quit IRC09:28
*** mvk has quit IRC09:31
*** egonzalez has joined #openstack-nova09:31
*** cristicalin has quit IRC09:31
*** iceyao has joined #openstack-nova09:32
*** yamamoto has quit IRC09:35
*** jjung has joined #openstack-nova09:37
*** dixiaoli_ has quit IRC09:37
*** dtantsur|bbl is now known as dtantsur09:37
*** hshiina has quit IRC09:40
*** sambetts|afk is now known as sambetts09:40
*** vishwanathj has quit IRC09:43
*** vishwanathj has joined #openstack-nova09:43
*** yamamoto has joined #openstack-nova09:45
*** yankcrime has quit IRC09:45
*** _nick has joined #openstack-nova09:46
*** alexchadin has quit IRC09:46
openstackgerritAlex Szarka proposed openstack/nova master: Transform instance-live_migration_abort notification  https://review.openstack.org/42045309:49
openstackgerritAlex Szarka proposed openstack/nova master: Transform instance-live_migration_post notification  https://review.openstack.org/48011909:49
*** damien_r has joined #openstack-nova09:52
*** dpawlik has joined #openstack-nova09:52
*** tuanluong has quit IRC09:52
janguttersean-k-mooney, mriedem: sorry for taking so long to respond to your comments, had a priority interrupt this morning.09:54
*** damien_r1 has quit IRC09:54
*** danpawlik has quit IRC09:54
*** yassine has quit IRC09:55
*** cNilesh has quit IRC09:57
janguttersean-k-mooney, mriedem: it looks like _get_vif_name seldom returns things in the nic<xxxx> format, the mechanism driver passes "devname" and seems to be running the show there.09:58
*** thorst has joined #openstack-nova09:58
*** iceyao has quit IRC10:00
*** chyka has joined #openstack-nova10:02
openstackgerritAlex Szarka proposed openstack/nova master: Transform instance-live_migration_post notification  https://review.openstack.org/48011910:03
*** mvk has joined #openstack-nova10:04
*** kiennt has quit IRC10:05
*** thorst has quit IRC10:06
*** chyka has quit IRC10:06
*** thorst has joined #openstack-nova10:07
openstackgerritJan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement  https://review.openstack.org/48345910:09
*** Guest67725 has quit IRC10:09
*** sree_ has joined #openstack-nova10:10
*** sree_ is now known as Guest792710:10
*** thorst has quit IRC10:11
openstackgerritMerged openstack/nova master: Do not import nova.conf into nova/exception.py  https://review.openstack.org/48590710:12
openstackgerrityuanyue proposed openstack/nova master: Add a periodic task to destroy ReqSpecs of deleted instances  https://review.openstack.org/48469410:14
*** Guest7927 has quit IRC10:14
*** markvoelker has joined #openstack-nova10:16
*** iceyao has joined #openstack-nova10:17
*** esberglu has joined #openstack-nova10:17
openstackgerritBéla Vancsics proposed openstack/nova master: Transform instance-live_migration_pre notification  https://review.openstack.org/48207010:20
*** phuongnh has quit IRC10:20
*** iceyao has quit IRC10:21
*** esberglu has quit IRC10:22
*** moshele has quit IRC10:23
*** cdent has joined #openstack-nova10:28
*** iceyao has joined #openstack-nova10:28
*** priteau has quit IRC10:28
*** Sara_ has joined #openstack-nova10:30
*** udesale has quit IRC10:30
Sara_Hello all.. I have launched a VM on libvirt compute host..Then I have removed and added the compute host to the cluster10:31
Sara_After joining the cluster, the Vm which was launched previously on that moves to error state..10:32
Sara_with error: No such file or directory: '/var/lib/nova/instances/2f44884d-9877-4da0-abd2-243979b803b7/disk'", "code": 500, "details": "  File \"/usr/lib/python2.7/dist-packages/nova/compute/manager.py\", line 375, in decorated_function |10:32
Sara_For your info, resume_guest_state_on_host_boot is set to false10:33
openstackgerrityuanyue proposed openstack/nova master: Add a periodic task to destroy ReqSpecs of deleted instances  https://review.openstack.org/48469410:33
Sara_Could someone help me out?10:33
Sara_Thanks in advance10:33
*** iceyao has quit IRC10:33
mamandlebauzas: regarding your comment on https://review.openstack.org/#/c/483911/3, I just responded to that, it was done based on a previous comment from efried. Can you please check?10:35
*** sapcc-bot1 has quit IRC10:36
*** sapcc-bot has joined #openstack-nova10:36
mamandleI can push a new patch for review accordingly.10:37
*** jaosorior has quit IRC10:38
*** baoli has joined #openstack-nova10:38
openstackgerritAlex Szarka proposed openstack/nova master: Raise Exception instead of Exception method call  https://review.openstack.org/48220010:44
*** clarkb has quit IRC10:45
*** clarkb has joined #openstack-nova10:45
*** hferenc has quit IRC10:47
openstackgerritManas Mandlekar proposed openstack/nova master: Instance remains in migrating state forever  https://review.openstack.org/48391110:47
*** markvoelker has quit IRC10:48
*** mtanino has joined #openstack-nova10:53
*** mdnadeem has quit IRC10:53
openstackgerritArtem Tiumentcev proposed openstack/nova master: Add root and ephemeral disk quota  https://review.openstack.org/48439010:55
*** iceyao has joined #openstack-nova10:55
*** roeyc has joined #openstack-nova10:57
*** iceyao has quit IRC11:00
openstackgerritBalazs Gibizer proposed openstack/nova master: Add sample test for instance audit  https://review.openstack.org/48095511:07
Sara_Hello all.. I have launched a VM on libvirt compute host..Then I have removed and added the compute host to the cluster..After joining the cluster, the Vm which was launched previously on that moves to error state..with error: No such file or directory: '/var/lib/nova/instances/2f44884d-9877-4da0-abd2-243979b803b7/disk'", "code": 500, "details": "  File \"/usr/lib/python2.7/dist-packages/nova/compute/manager.py\", line 375, in d11:08
Sara_For your info, resume_guest_state_on_host_boot is set to false.Could someone help me out?11:08
*** edmondsw has joined #openstack-nova11:09
*** acormier has joined #openstack-nova11:12
*** yassine has joined #openstack-nova11:13
*** gszasz has joined #openstack-nova11:13
*** edmondsw has quit IRC11:13
*** iceyao has joined #openstack-nova11:15
*** jamesdenton has joined #openstack-nova11:15
openstackgerritArtem Tiumentcev proposed openstack/nova master: Add root and ephemeral disk quota  https://review.openstack.org/48439011:16
*** acormier has quit IRC11:16
*** yufei has quit IRC11:17
openstackgerritArtem Tiumentcev proposed openstack/python-novaclient master: Add 'local_gb' disk quota support  https://review.openstack.org/48439111:19
*** jjung has quit IRC11:22
*** jamesdenton has quit IRC11:22
*** jamesden_ has joined #openstack-nova11:22
*** sdague has joined #openstack-nova11:25
*** priteau has joined #openstack-nova11:25
*** sree has joined #openstack-nova11:26
*** mamandle has quit IRC11:27
*** saphi has quit IRC11:28
*** acormier has joined #openstack-nova11:28
*** hferenc has joined #openstack-nova11:31
*** sree has quit IRC11:31
openstackgerritAlex Szarka proposed openstack/nova master: Transform instance.exists notification  https://review.openstack.org/40366011:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Add sample test for instance audit  https://review.openstack.org/48095511:34
*** damien_r has quit IRC11:37
*** damien_r has joined #openstack-nova11:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Add sample test for instance audit  https://review.openstack.org/48095511:39
kashyapassert_called_once_with(*args, **kwargs)¶11:44
kashyapEurgh, wrong window11:44
openstackgerritMerged openstack/nova master: Translate the return value of attachment_create and _update  https://review.openstack.org/48619411:44
kashyapWas copy / pasting it in a different buffer11:44
*** vishwanathj has quit IRC11:45
*** moshele has joined #openstack-nova11:45
*** markvoelker has joined #openstack-nova11:45
*** vishwanathj has joined #openstack-nova11:45
*** gongysh has quit IRC11:47
*** smatzek has joined #openstack-nova11:50
*** psachin has quit IRC11:51
*** lucasagomes is now known as lucas-hungry11:52
*** jjung has joined #openstack-nova11:55
openstackgerritAlex Szarka proposed openstack/nova master: fix test_rebuild_server_exc instability  https://review.openstack.org/48738211:56
*** mamandle has joined #openstack-nova11:57
*** yamamoto has quit IRC11:57
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Post-migration, set cache value for Cinder volume(s)  https://review.openstack.org/48575211:59
*** sree has joined #openstack-nova12:00
openstackgerritAlex Szarka proposed openstack/nova master: Transform instance-live_migration_abort notification  https://review.openstack.org/42045312:00
*** trinaths has left #openstack-nova12:01
*** bkopilov_ has quit IRC12:02
*** esberglu has joined #openstack-nova12:05
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.openstack.org/47709112:08
*** Dinesh_Bhor is now known as Dinesh_Bhor|away12:08
openstackgerritRadoslav Gerganov proposed openstack/nova master: Add connection pool size to vSphere settings  https://review.openstack.org/41408512:08
*** esberglu_ has joined #openstack-nova12:08
*** Dinesh_Bhor|away is now known as Dinesh_Bhor12:09
*** klipka has joined #openstack-nova12:09
*** esberglu has quit IRC12:10
*** yamamoto has joined #openstack-nova12:13
*** edmondsw has joined #openstack-nova12:13
*** thorst has joined #openstack-nova12:16
*** markvoelker has quit IRC12:19
*** chyka has joined #openstack-nova12:20
*** catintheroof has joined #openstack-nova12:21
*** jamesden_ has quit IRC12:23
*** jamesdenton has joined #openstack-nova12:23
*** chyka has quit IRC12:26
*** mgiles has joined #openstack-nova12:26
*** markvoelker has joined #openstack-nova12:28
*** liverpooler has joined #openstack-nova12:29
*** iceyao has quit IRC12:32
*** esberglu_ has quit IRC12:32
*** acormier has quit IRC12:39
*** ioggstream has joined #openstack-nova12:39
ioggstreamhi @all12:39
*** mriedem has joined #openstack-nova12:39
mriedemo/12:40
ioggstreamafter a stack update I discovered somebody downsized the flavor disk12:40
openstackgerritBalazs Gibizer proposed openstack/nova master: query instance after save to avoid partial update  https://review.openstack.org/48656112:40
ioggstreamu"Flavor's disk is too small for requested image. Flavor disk is 32212254720 bytes, image is 64424509440 bytes."12:41
ioggstreamI fixed the flavor and re-updated the stack, but it didn't fix12:41
ioggstreamone host is "Unavailable console type serial."12:42
ioggstreamWhat happens when "Flavor disk is to small?" Nova destroys the disk or just stops?12:44
*** tbachman has quit IRC12:44
ioggstreamis there a way to access the root volumes and get the data?12:44
*** randomhack has joined #openstack-nova12:45
alex_xunova api meeting is 14 mins at #openstack-meeting-412:46
openstackgerritChris Dent proposed openstack/nova master: style-only: s/context/ctx/  https://review.openstack.org/48579112:47
*** efoley has quit IRC12:47
openstackgerritChris Dent proposed openstack/nova master: use os_traits.MISC_SHARES_VIA_AGGREGATE  https://review.openstack.org/48579212:47
*** tbachman has joined #openstack-nova12:48
cdentmriedem: those ^ two needed a rebase to be aligned with master (which had introduced more ‘context’. there were previously both +W so could you do the honors?12:49
jangutterJust enough time to watch https://www.youtube.com/watch?v=1g6QJ5TfA7w before the meeting. Voltron! Assemble!12:50
*** efoley has joined #openstack-nova12:50
*** b3nt_pin is now known as beagles12:53
*** pchavva has joined #openstack-nova12:53
*** yamamoto has quit IRC12:54
*** mtanino has quit IRC12:55
*** gmann_ has joined #openstack-nova12:55
*** esberglu_ has joined #openstack-nova12:56
*** ratailor has quit IRC12:57
cdentthank mriedem12:58
openstackgerritGhanshyam Mann proposed openstack/nova master: Move the note about '/os-volume_boot' to the correct place  https://review.openstack.org/48607112:58
*** esberglu_ has quit IRC12:58
*** esberglu_ has joined #openstack-nova12:59
*** udesale has joined #openstack-nova12:59
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: [WIP] Add support for Windows network commands  https://review.openstack.org/48740513:00
alex_xunova api meeting is running at #openstack-meeting-413:01
*** prateek_ has quit IRC13:01
*** iceyao has joined #openstack-nova13:01
*** eharney has joined #openstack-nova13:02
*** moshele has quit IRC13:02
*** moshele has joined #openstack-nova13:02
*** jaypipes has joined #openstack-nova13:03
*** randomhack has quit IRC13:04
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Microversion 2.53 - services and hypervisors using UUIDs  https://review.openstack.org/48543513:04
gibimriedem: hi! I added example error messages to the patch https://review.openstack.org/#/c/428199/ (13:05
gibimriedem: as we agreed13:05
*** randomhack has joined #openstack-nova13:05
*** lucas-hungry is now known as lucasagomes13:05
*** iceyao has quit IRC13:06
*** mamandle has quit IRC13:07
*** hwoarang has quit IRC13:07
moshelejaypipes , mriedem: hi can you review  https://review.openstack.org/#/c/398265/ ?13:08
*** jwcroppe has quit IRC13:08
*** hwoarang has joined #openstack-nova13:08
*** yamamoto has joined #openstack-nova13:09
*** dave-mccowan has joined #openstack-nova13:09
*** awaugama has joined #openstack-nova13:11
*** hwoarang_ has joined #openstack-nova13:12
*** tylerderosagrund has joined #openstack-nova13:12
*** felipemonteiro has joined #openstack-nova13:14
*** tbachman has quit IRC13:14
*** hwoarang has quit IRC13:15
*** dave-mcc_ has joined #openstack-nova13:16
*** lyan has joined #openstack-nova13:17
openstackgerritLIU Yulong proposed openstack/nova master: Enable reset keypair while rebuilding instance  https://review.openstack.org/37912813:18
*** tbachman has joined #openstack-nova13:18
*** dave-mccowan has quit IRC13:19
*** iceyao has joined #openstack-nova13:24
*** jaosorior has joined #openstack-nova13:24
mriedemgmann_: should this be abandoned? https://review.openstack.org/#/c/451331/13:25
mriedemalex_xu: after the meeting, should this be abandoned? https://review.openstack.org/#/c/458004/13:25
*** kylek3h has joined #openstack-nova13:28
sdaguemriedem: can you set up whatever tests you were running yesterday on this - https://review.openstack.org/#/c/487246/13:28
sdaguethat should make things wait for compute service to start correctly13:28
*** saphi has joined #openstack-nova13:29
mriedemsdague: multinode neutron job should be sufficient to test that13:29
sdaguemriedem: ok, is that just in neutron experimental queue?13:30
sdagueor you mean the normal multinode job can see the issue?13:30
dansmithmriedem: are we reverting multicell yet?13:31
mriedemsdague: normal13:31
*** jistr is now known as jistr|mtg13:31
mriedemdansmith: i haven't heard of anything13:31
*** felipemonteiro_ has joined #openstack-nova13:32
dansmithamazing13:32
mriedemgibi: ok looks good, i wanted to show you something else first13:32
sdaguemriedem: ok, I'm not sure what behavior you are looking for, but there are result runs here - https://review.openstack.org/#/c/48724613:32
*** dillaman has joined #openstack-nova13:32
gibimriedem: sure13:32
mriedemsdague: yeah i'll look after the api meeting13:32
*** jjung has quit IRC13:34
*** felipemonteiro has quit IRC13:35
mriedemgibi: i was reminded of this testtools matcher yesterday https://review.openstack.org/#/c/486850/6/nova/tests/unit/api/openstack/compute/test_versions.py@30313:36
mriedemself.assertThat(jsonutils.loads(res.body),13:36
mriedem                        matchers.DictMatches(expected))13:36
mriedemwhich is similar to what you're doin13:36
mriedemif it fails, it tells you what the diff is13:36
mriedemgibi: so i wonder if we could re-use that13:36
gibimriedem: I can check that out13:36
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from ``ip`` commands to ``pyroute2``  https://review.openstack.org/48438613:37
gibimriedem: I will plug that in to the notification sample test to see if it works and then I will check what it prints when something does not match13:38
*** egonzalez has left #openstack-nova13:39
gmann_mriedem: hum, i can do abandon. but i wan to give try to merge schema and code split among files. but for next release13:40
gmann_mriedem: we need to abandon or detach from BP to close BP?13:40
mriedemgmann_: no, i just wanted to clean up the review queue for that bp13:41
*** cleong has joined #openstack-nova13:42
mriedemmoshele: is that building into an existing bp?13:42
mriedemor something else?13:42
*** ekuris has quit IRC13:43
*** chyka has joined #openstack-nova13:43
moshelemriedem: I just opened neutron RFE13:43
*** acormier has joined #openstack-nova13:43
*** hwoarang_ is now known as hwoarang13:44
*** catintheroof has quit IRC13:44
gmann_mriedem: ok, i will detach that from it.13:45
*** catintheroof has joined #openstack-nova13:46
jaypipesmoshele: done.13:46
*** chyka has quit IRC13:47
*** jistr|mtg is now known as jistr13:47
*** catintheroof has quit IRC13:48
*** catintheroof has joined #openstack-nova13:48
*** awaugama has quit IRC13:49
*** catintheroof has quit IRC13:51
*** claudiub has quit IRC13:51
*** awaugama has joined #openstack-nova13:51
*** chyka has joined #openstack-nova13:52
kashyap"recheck pep8" is a thing?13:52
mriedemno13:52
*** catintheroof has joined #openstack-nova13:52
*** jwcroppe has joined #openstack-nova13:52
mriedemcdent: sdague: wording nit in https://review.openstack.org/#/c/486623/3/releasenotes/notes/deprecate_wsgi_log_format-43a10b7a608ea8f3.yaml13:53
cdentyeah, good point, probably “preferred deployment mode"13:53
openstackgerritSean Dague proposed openstack/nova master: deprecate ``wsgi_log_format`` config variable  https://review.openstack.org/48662313:53
sdaguemriedem: done13:54
*** randomhack has quit IRC13:54
*** rcernin has quit IRC13:54
kashyapmriedem: Thanks.  Sigh, I made a silly tabs / spaces mistake, and paying the penalty of not running `pep8` locally first on last iteration13:54
bauzasmriedem: could you please point me out the super etherpad for reviews ?13:55
bauzasI mean, the one for the left BPs13:55
bauzasmriedem: yeah I'm lazy and I can find it by myself but hopefully your tab is still open13:56
*** klipka has quit IRC13:56
jangutterhttps://etherpad.openstack.org/p/nova-pike-feature-freeze-status13:57
*** cfriesen has joined #openstack-nova13:57
*** mamandle has joined #openstack-nova13:58
gmann_bauzas: this one - https://etherpad.openstack.org/p/nova-pike-feature-freeze-status13:58
bauzasthanks13:58
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Post-migration, set cache value for Cinder volume(s)  https://review.openstack.org/48575213:59
*** crushil has joined #openstack-nova13:59
kashyapAnd 'recheck pep8' doesn't fix it, as I botched up indentation.  The above should fix it.13:59
*** armax has joined #openstack-nova14:00
*** jjung has joined #openstack-nova14:00
*** chyka has quit IRC14:00
alex_xumriedem: I think I will continue https://review.openstack.org/#/c/458004 after freeze as a bug fix. it just adds a test, it isn't realy part of no more ext BP.14:02
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge server create schema for availability zone extension  https://review.openstack.org/45133114:03
janguttersean-k-mooney: you perhaps around to do a (hopefully) final eyeball on https://review.openstack.org/#/c/483459/ ?14:04
*** gmann_ has quit IRC14:05
*** dave-mcc_ has quit IRC14:05
vdrokgood morning folks14:05
gibimriedem: it seems replacing JsonEqual with DictMatcher passes the sample tests so this direction looks promising14:05
gibimriedem: I will rework my improvement patch14:05
vdrokmriedem: seeing http://logs.openstack.org/88/473888/12/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-ubuntu-xenial/d56cef7/logs/screen-n-cond-cell1.txt.gz#_Jul_26_11_15_52_052437 again in the multinode job :( I thought the option you've added in the last patchset of devstack change was the workaround for the subnode?14:06
dansmithvdrok: jlvillal said you guys had fixed that14:10
dansmithvdrok: this: https://review.openstack.org/#/c/477313/14:10
dansmithbut I guess that was grenade14:10
vdrokdansmith: we did add the nomulticell for grenade. but for the multinode job I thought the fix was https://review.openstack.org/#/c/477556/4..5/lib/nova14:11
dansmithvdrok: this? http://logs.openstack.org/88/473888/12/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-ubuntu-xenial/d56cef7/logs/screen-n-cond-cell1.txt.gz#_Jul_26_11_15_52_12807914:11
dansmithvdrok: I don't think so14:12
*** gouthamr has joined #openstack-nova14:12
*** xyang1 has joined #openstack-nova14:12
*** mtanino has joined #openstack-nova14:12
dansmithvdrok: you won't get any reschedules with the multicell layout, so if you really hit those in regular gate jobs like this then we need to make you non multicell for now I guess14:13
dansmitheven in the regular ones14:13
janguttermoshel: regarding my comments on https://review.openstack.org/#/c/398265 it's basically nova sending extra data to os-vif, so that in future os-vif can handle representors uniformly.14:14
vdrokdansmith: hrm, so this means we need to add some stuff to devstack to check that if virt driver = ironic add the nomulticell everywhere?14:14
janguttermoshele: ^^ sorry for misspelling your nick.14:15
dansmithvdrok: don't you start nova-compute from your devstack plugin such that you can just set it there?14:15
vdrokdansmith: we restart it :) but if it was already configured for multicell it fails. at least it failed when I tried this way14:16
*** pilgrimstack has joined #openstack-nova14:16
vdroklemme try to find that patch14:16
*** randomhack has joined #openstack-nova14:17
vdrokdansmith: here https://review.openstack.org/481114. was tested at https://review.openstack.org/48159314:17
moshelejangutter: Ok, I will update the representor_address14:18
vdrokn-cond-cell1 log is still there, and is empty http://logs.openstack.org/93/481593/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_snmp-tinyipa-ubuntu-xenial-nv/5972121/logs/screen-n-cond-cell1.txt.gz14:19
dansmithvdrok: yep14:20
dansmithvdrok: give me a sec14:21
vdroksure14:21
*** udesale has quit IRC14:23
*** udesale has joined #openstack-nova14:23
*** yamamoto has quit IRC14:24
*** pchavva has quit IRC14:24
bauzasmriedem: around ? I'm just reading https://review.openstack.org/#/c/485435/6/novaclient/tests/functional/v2/test_os_services.py@74 and I do wonder if we track somewhere the non-possibility to disable/enable a non-compute service14:25
bauzasthat's something I missed14:25
sdaguemriedem: can you check out whatever you were verifying yesterday in https://review.openstack.org/#/c/487246/ ( the wait for service patch ), or at least point me to what I'm looking for14:26
*** marst has quit IRC14:26
bauzasI do remember you modified the REST API to use a PUT /os-services/ instead of an action and you made it cell-aware, but I don't remember we said to not accept enablement/disablement for internal services but computes14:26
bauzasmriedem: nevermind, saw the commit msg in https://review.openstack.org/#/c/464280/14:28
dansmithvdrok: so you can set this variable early enough to make it work right?  https://review.openstack.org/48744314:30
mriedembauzas: https://bugs.launchpad.net/python-novaclient/+bug/1700359/comments/214:30
openstackLaunchpad bug 1700359 in OpenStack Compute (nova) "test_os_service_disable_enable fails with "ERROR (NotFound): Could not find binary nova-scheduler on host"" [Medium,Confirmed]14:30
mriedembauzas: trying to perform actions on non-compute services literally won't work,14:31
mriedembecause we look up the service in the cell via the host mapping, which only exists for compute services14:31
bauzasmriedem: yeah it made sense to me14:31
*** bkopilov_ has joined #openstack-nova14:31
mriedemi just have the todo to put something in the release notes for it14:32
bauzasmriedem: and because we only care about the enable/disable flag by the scheduler only for finding a target14:32
jaypipesjangutter: where are you getting the vif_plug_ovs package here? https://github.com/Netronome/agilio-ovs-openstack-plugin/blob/d3f53fd3e6eaaa3d4b5f98978b2f3aa504a7a8cd/vif_plug_agilio_ovs/agilio_ovs.py#L29-L3114:32
bauzasmriedem: given other services and not targets for instances14:32
jaypipesjangutter: I don't see os-vif in the list of requirements.txt Python packages.14:33
jangutterjaypipes: yep, there's a sizeable set of cleanups still on that repo.14:33
openstackgerritMerged openstack/nova master: Using plain routes for the microversions test  https://review.openstack.org/48506114:33
dansmithjaypipes: we're claiming in the scheduler now right?14:34
dansmithoh no14:35
dansmithnm that one hasn't merged yet14:35
*** marst has joined #openstack-nova14:35
dansmithjaypipes: hopefully after it does, the ironic people won't have reschedules during their test runs :/14:35
jaypipesdansmith: looking at the -1s on that now.14:35
cdentgibi: on https://review.openstack.org/#/c/487327/ I assume the virtenv’s still build correctly before runnin the actual tests? That error message is produced by wsgi-intercept, which gets upset about proxy variables when using the urllib3 interceptor14:35
vdrokdansmith: yup, seems like it should help, thanks! we'll have to add it to our base builder in project-config14:36
dansmithvdrok: okay, you'll work on that/14:37
vdrokyup14:37
vdrokwill propose a project-config patch now14:37
dansmithvdrok: once we merge the scheduler claiming patch, hopefully you won't get any more reschedules during test runs like this, which will probably be faster anyway14:38
dansmithshould make your runs faster I mean14:38
dansmithprobably good to do this devstack variable in the meantime anyway14:38
*** randomhack has quit IRC14:38
vdrok++14:38
*** kristian__ has joined #openstack-nova14:39
mriedemsdague: question in https://review.openstack.org/#/c/486700/2/nova/tests/fixtures.py14:41
mriedemoh dan https://review.openstack.org/#/c/487443/14:44
*** esberglu_ has quit IRC14:44
dansmithmriedem: I was rushing14:44
*** esberglu has joined #openstack-nova14:44
sdaguemriedem: looking14:45
mriedemwhy do we have: local nomulticellflag="$1"14:45
mriedemin start_nova_compute14:45
mriedemnothing passes a variable to that function14:45
dansmithmriedem: yes, grenade does14:46
dansmithmriedem: and ironic's grenade does14:46
sdaguemriedem: so what is your concern there?14:46
mriedemoh grenade14:46
mriedemsdague: was trying to sort out if that's coming from something within nova, since we do use pkg_resources.parse_version, but nowhere near that code14:46
dansmithmriedem: jlvillal was struggling with that in o.vo recently too14:47
sdaguemriedem: stevedore probably14:47
dansmithsomething changed in setuptools I think14:47
sdaguemriedem: actually, I think it's pbr14:50
*** sridharg has quit IRC14:50
*** vishwanathj has quit IRC14:51
*** vishwanathj has joined #openstack-nova14:52
sdaguelet me see if I can trigger a deeper stack warn to figure out exactly where14:52
*** cdelatte has joined #openstack-nova14:52
*** jjung has quit IRC14:56
sdaguedansmith: for https://review.openstack.org/#/c/487443/2/lib/nova why isn't the answer to disable multicell?14:58
dansmithsdague: not sure what you mean.. default=True=do setup multiple tiering.. set to false will not do that14:59
dansmithmaybe my logic needs inverting to make more sense? like disable=True?15:00
*** roeyc has quit IRC15:00
mriedemnote we aren't actually multi-cell yet15:00
mriedemwe're multi-tier15:00
dansmithmriedem: well, you could multi-cell with this, we just don't configure it that way15:00
mriedemdansmith: so i can post a WIP to set NOVA_NUM_CELLS=2 and it should work?15:01
dansmithmriedem: it should configure multiple cells, but not sure it will work :)15:01
*** blake has joined #openstack-nova15:01
dansmithmriedem: you need NUM_CELLS=2 and the CELL_INDEX=2 for the third node15:01
mriedemcould tease out some interesting bugs we don't know about yet15:01
dansmithwell, I didn't know we had three node jobs until you told me yesterday15:02
mriedemwhere is CELL_INDEX?15:02
dansmithI rememberd the name wrong, but it's this: https://github.com/openstack-dev/devstack/blob/master/lib/nova#L66-L6815:02
mriedemcouldn't that just be: NOVA_CPU_CELL=${NOVA_CPU_CELL:-$NOVA_NUM_CELLS} ?15:03
dansmithI just want to say that I wish we had taken my original suggestion to call cellsv2 something other than cells15:03
mriedemare they always the same?15:03
sdagueok, I'm trying to figure out a way to explain this in stackrc that isn't going to require poking people in irc.15:03
dansmithno,15:04
dansmithmriedem: you need it to be different on each node you want to be in a different cell15:04
mriedemah ok15:05
sdagueso, the fleetify patch creates a conductor per compute.15:05
sdagueplus the api conductor15:05
mriedemconductor per node15:05
dansmithcondutor per cell15:05
mriedemwell,15:05
sdagueright, it's good we're all on the same page :)15:05
mriedemnot really15:05
mriedemdansmith: today the multinode job with this change is 1 cell15:05
openstackgerritEric Fried proposed openstack/nova master: Add requirement for os-service-types  https://review.openstack.org/48747115:05
mriedemthere is a cell conductor and super conductor15:06
mriedemyeah,15:06
dansmithmriedem: it's conductor per cell, plus one super conductor15:06
sdaguemriedem: right, so 1 compute conductor + 1 api conductor, right ?15:06
mriedemand the subnodes talk to the cell conductor15:06
mriedemapi talks to super conductor15:06
mriedemfwiw this is why i wrote a todo to doc this in devstack later15:06
mriedembecause we have 3 nova confs now and multiple conductors so debugging it is a challenge at first15:06
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/48747315:06
sdagueso, if we introduced this as CELLSV2_SETUP=allinone15:06
dansmithmriedem: trying to help by starting that nova doc with diagrams of course15:06
mriedemdansmith: yup15:07
mriedemthat's higher priority IMO anyway15:07
sdagueCELLSV2_SETUP=condpercell15:07
sdagueor something, then we could global switch there?15:07
dansmithsdague: if it wasn't for ironic (and grenade) I'd say we don't need a flag15:07
*** pchavva has joined #openstack-nova15:07
sdaguedansmith: sure, ironic is always going to be broken this way?15:07
dansmithsdague: and we really don't want people doing the allinone if possible15:08
dansmithno15:08
dansmithironic will stop being broken when we get the claims patch in,15:08
sdaguewhat's the ironic path fix here?15:08
dansmithand when we have proper reschedules (which we've punted at this point) then double fixed15:08
mriedem1. ironic sets the tiered=False flag temporarily in devstack-plugin-ironic,15:09
mriedem2. we land https://review.openstack.org/#/c/483566/15:09
mriedem3. ironic reverts #115:09
mriedemright?15:09
dansmithtechnically yes15:09
dansmithalthough since we punted on reschedules,15:10
cdentIf any core types have gaps between wtf-ing at cellsv2 and claims in the scheduler, there’s a stack of api-ref stuff for placement where at least the first few are ready to go: https://review.openstack.org/#/c/474550/15:10
dansmithI think it's probably a good idea to let people setup devstack in this older configuration for the time being,15:10
dansmithbecause otherwise they can't reschedule15:10
mriedemare these ironic multi-node jobs?15:10
mriedemor just ironic being multi-node by design15:10
mriedembecause of the 1:M thing15:10
dansmithwell, ironic multinode jobs, but not sure if it's multi-compute or just multi-ironic-node15:10
dansmitheither requires a reschedule, which is the problem15:11
mriedemthat's a good point about reschedules15:11
dansmithmriedem: sdague: you want to hangout to hash this over?15:12
dansmithsdague hasn't said anything in a few minutes, may be very confused15:12
mriedemi just left a comment that it might be good to mention the reschedule thing,15:12
mriedemif you're doing tiered and multiple computes15:12
bauzasmriedem: 11 comments in https://review.openstack.org/#/c/485435/6 but only 2 I care15:14
bauzasmriedem: tl;dr should we mention in the relnote that nova wouldn't support disabling non-compute services, and why should we having two different representative strings for a service object?15:14
sdaguedansmith: sorry, I was writing a patch15:15
sdagueI can do a hangout as well15:15
sdaguedansmith: I was thinking, change the devstack setup to this https://review.openstack.org/48747815:15
*** rajathagasthya has joined #openstack-nova15:15
sdaguebecause as much as I don't like this mode switch, I like it even less if there are 2 different ways to do it15:16
dansmithsdague: we have to fix grenade for that first15:16
sdaguedansmith: yep15:16
sdagueworking on that patch right now15:16
dansmithsdague: agreed about the two ways, I was just trying to unbreak the ironic people quickly15:16
dansmithvdrok: following?15:17
vdrokreading15:17
*** udesale has quit IRC15:17
dansmithvdrok: basically, sdague hates it when I play with his toys15:18
*** acormier has quit IRC15:18
*** acormier has joined #openstack-nova15:18
mriedemhere is the 2-cell goody btw https://review.openstack.org/48747915:19
*** tbachman has quit IRC15:19
dansmithmriedem: that's just going to put all the nodes into the same cell again right?15:19
*** tbachman has joined #openstack-nova15:19
dansmithyou need to set CPU_CELL=$node_number or something15:20
dansmiththis will just end up with an empty cell1, which is cool, but not much different from what we're already doing, AFAICT15:20
*** felipemonteiro_ has quit IRC15:20
vdrokdansmith: so basically CELLSV2_SETUP=singleconductor instead of NOVA_CELLS_TIER=False?15:21
dansmithvdrok: yes15:21
mriedemvdrok: yes15:21
mriedemdansmith: i'd have to set that from like devstack-gate right?15:21
dansmithmriedem: something yeah15:21
mriedemsince devstack doesn't know which subnode it is15:21
mriedemok15:21
dansmithright15:21
*** rcernin has joined #openstack-nova15:21
openstackgerritJay Pipes proposed openstack/nova master: claim resources in placement API during schedule()  https://review.openstack.org/48356615:21
openstackgerritJay Pipes proposed openstack/nova master: add a retry on DBDeadlock to _set_allocations()  https://review.openstack.org/48748315:21
jaypipesalex_xu, cdent, mriedem, dansmith: ok, added protection against DBDeadlock (separate patch) and cleaned up the one conditional with unit tests that alex_xu pointed out. ^^15:21
jaypipesand rebased to master that cdent wanted...15:22
dansmithmriedem: I should have kept quiet and had you be amazed and impressed at no more failures with your patch :P15:22
*** itlinux has joined #openstack-nova15:22
vdrokmriedem: dansmith hrm, so doing it in devstack/settings won't work? OK, will add to devstack-gate15:22
cdentjaypipes: cool, will look asap15:22
vdroksmth like https://review.openstack.org/#/c/487458/1/devstack/settings15:22
*** tbachman_ has joined #openstack-nova15:23
*** mamandle has quit IRC15:24
mriedemjaypipes: questions in the bottom change15:24
*** Sukhdev has joined #openstack-nova15:24
*** yamamoto has joined #openstack-nova15:24
dansmithvdrok: I think what you have will work right?15:24
*** sree has quit IRC15:25
dansmithvdrok: as long as it gets loaded before the other stuff runs15:25
*** crushil has quit IRC15:25
vdrokdansmith: I think so, yes, it should run before nova15:25
mriedemwhat he has should work, unless we don't go with that patch and instead go with seans15:25
*** sree has joined #openstack-nova15:25
jaypipesmriedem: answered.15:26
vdrokok, then I'm waiting for your decision for now15:26
*** gszasz has quit IRC15:26
*** tbachman has quit IRC15:26
*** tbachman_ is now known as tbachman15:26
sdaguemriedem: reved - https://review.openstack.org/48747815:28
mriedemvdrok: like this? http://wac.450f.edgecastcdn.net/80450F/k99.com/files/2013/02/Bachelor-630x419.jpg15:28
vdrok:)15:28
*** jaosorior has quit IRC15:28
sdaguehonestly, this makes the grenade code make more sense as well (assuming it all works)15:29
mriedemso many patches to choose from15:29
sdaguehttps://review.openstack.org/#/c/487485/1/projects/60_nova/from-ocata/upgrade-nova15:29
*** belmoreira has quit IRC15:29
*** sree has quit IRC15:30
mriedemjaypipes: "Jesus, you're quick."15:31
mriedemyou did tell us to review immediately you know :)15:31
*** acormier has quit IRC15:31
*** acormier has joined #openstack-nova15:31
efriedjaypipes mriedem johnthetubaguy (mordred) https://review.openstack.org/487471 is in support of bp/use-service-catalog-for-endpoints.  Should be the last blocker.15:32
mriedemefried: why doesn't that ust go into the change that uses it?15:32
*** rcernin has quit IRC15:34
*** andreas_s has quit IRC15:35
*** markus_z has quit IRC15:35
*** acormier has quit IRC15:36
*** yamamoto has quit IRC15:36
*** claudiub has joined #openstack-nova15:38
dansmithvdrok: we're doing sdague's I just mean that approach will work15:38
openstackgerritJay Pipes proposed openstack/nova master: claim resources in placement API during schedule()  https://review.openstack.org/48356615:39
openstackgerritJay Pipes proposed openstack/nova master: add a retry on DBDeadlock to _set_allocations()  https://review.openstack.org/48748315:39
efriedmriedem Daaahhh, I could do that.15:39
*** iceyao has quit IRC15:39
jaypipescdent, mriedem: fixed docstring. sorry, was a copy-paste from the _check_capacity_exceeded() function15:39
openstackgerritMoshe Levi proposed openstack/nova master: hardware offload support for openvswitch  https://review.openstack.org/39826515:39
jaypipescdent: I'd prefer to not sprinkle the retryondeadlock decorator around willy-nilly. prefer to apply it only where needed.15:40
*** crushil has joined #openstack-nova15:40
cdentjaypipes: that’s the root of my question: how do we know, other than when we get a random boom, that a place needs it?15:41
*** crushil has quit IRC15:41
*** acormier has joined #openstack-nova15:41
*** crushil has joined #openstack-nova15:41
mriedemcdent: we don't15:42
cdentgroovy15:42
mriedembut we've tried not to use it if possible within nova15:42
mriedemas a crux15:42
*** crushil has quit IRC15:42
*** moshele has quit IRC15:43
*** crushil has joined #openstack-nova15:43
*** tbachman_ has joined #openstack-nova15:43
dansmithjaypipes: mriedem: I don't love the "gardening" in that dbdeadlock patch15:44
*** crushil has quit IRC15:44
*** chyka has joined #openstack-nova15:44
*** acormier has quit IRC15:44
*** tbachman has quit IRC15:44
*** tbachman_ has quit IRC15:44
dansmiththe docstring and dead code removal could be separate.. just seems confusing down the road to have something serious like a dbdeadlock mitigation with some random things15:44
jaypipesdansmith: you mean me fixing up the docstring and removing the useless line of code?15:44
*** crushil has joined #openstack-nova15:44
*** chyka has quit IRC15:44
jaypipesdansmith: yeah, I was on the fencer.15:44
*** acormier has joined #openstack-nova15:44
*** tbachman has joined #openstack-nova15:45
dansmithjaypipes: yeah, separate those cleanups from the dbdeadlock thing, IMHO15:45
jaypipesok15:45
mriedembauzas: replied to everything in https://review.openstack.org/#/c/485435/15:45
dansmithjaypipes: I'll oil up my +2ing finger to get ready15:45
*** crushil has quit IRC15:45
mriedemgross15:45
*** chyka has joined #openstack-nova15:46
*** crushil has joined #openstack-nova15:46
*** crushil has quit IRC15:47
*** owalsh has quit IRC15:47
*** crushil has joined #openstack-nova15:47
*** crushil has quit IRC15:48
vdrokdansmith: gotcha, updating15:48
*** efried has quit IRC15:49
*** crushil has joined #openstack-nova15:49
*** mvk has quit IRC15:49
mriedemwow crux?15:50
mriedemcrutch15:50
*** crushil has quit IRC15:50
openstackgerritJay Pipes proposed openstack/nova master: claim resources in placement API during schedule()  https://review.openstack.org/48356615:50
openstackgerritJay Pipes proposed openstack/nova master: add a retry on DBDeadlock to _set_allocations()  https://review.openstack.org/48748315:50
cdentmriedem: I automagically translated that. I have that functionality built in because otherwise I wouldn’t be able to read myself.15:50
openstackgerritJay Pipes proposed openstack/nova master: docstring and unused code removal  https://review.openstack.org/48749215:50
jaypipesmriedem, dansmith: done15:50
*** crushil has joined #openstack-nova15:50
*** crushil has quit IRC15:51
*** yassine has quit IRC15:52
dansmithjaypipes: and done15:52
*** crushil has joined #openstack-nova15:52
*** crushil has quit IRC15:53
*** owalsh has joined #openstack-nova15:53
sdaguemriedem: you probably just typoed horcrux15:53
*** crushil has joined #openstack-nova15:53
jaypipesdansmith: and now I'm all oily. thanks a lot.15:53
dansmithjaypipes: you know you'd prefer that over the alternative15:54
openstackgerritChris Dent proposed openstack/nova master: remove un-necessary update() in _init_compute_node of rt  https://review.openstack.org/48350615:54
openstackgerritChris Friesen proposed openstack/python-novaclient master: match exact hypervisor hostnames where applicable  https://review.openstack.org/48749415:54
*** crushil has quit IRC15:54
sdagueok, I'm about to walk afk for a bit. https://review.openstack.org/#/c/487478/ hasn't blown up yet. I approved the grenade thing it depends on, because that can't hurt anything. But it's going to be another hour + to get results15:55
*** Drankis has joined #openstack-nova15:55
jaypipesdansmith: eww.15:55
jaypipes:)15:55
*** armax has quit IRC15:56
*** armax has joined #openstack-nova15:57
*** iceyao has joined #openstack-nova15:58
*** imacdonn_ has quit IRC15:59
kashyapIf anyone has a few minutes, a self-containted change that fixes a performance issue post-migration: https://review.openstack.org/#/c/485752/ -- "libvirt: Post-migration, set cache value for Cinder volume(s)"15:59
*** imacdonn_ has joined #openstack-nova15:59
openstackgerritMatthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in resize_instance  https://review.openstack.org/48749515:59
kashyapUnit tests -- fixed; Jenkins -- succeeds.  And the reporter has confirmed the fix resolves the I/O latency issue.15:59
*** cNilesh has joined #openstack-nova16:00
*** efried has joined #openstack-nova16:02
bauzasoh man, I totally missed the IronicHostState.uuid thing16:02
bauzasjaypipes: mriedem: I really apologize for having missed ^ that16:02
*** iceyao has quit IRC16:02
*** felipemonteiro has joined #openstack-nova16:03
bauzasand yeah, most of the problems we have with ironic scheduling is because of the fact we have a different hoststate model :(16:03
bauzasI knew that but I forgot to tell you16:03
bauzasgraaah16:03
*** tristanC has quit IRC16:03
*** rcernin has joined #openstack-nova16:03
*** Apoorva has joined #openstack-nova16:06
*** pilgrimstack has quit IRC16:06
jaypipesbauzas: no worries man16:07
bauzasI really loved my vacations16:07
bauzasbut honestly, it threw me out16:07
*** itlinux has quit IRC16:11
*** felipemonteiro_ has joined #openstack-nova16:11
*** felipemonteiro has quit IRC16:14
*** harlowja has joined #openstack-nova16:15
openstackgerritMerged openstack/nova master: style-only: s/context/ctx/  https://review.openstack.org/48579116:15
*** Sukhdev_ has joined #openstack-nova16:15
*** dtp has joined #openstack-nova16:15
openstackgerritMerged openstack/nova master: use os_traits.MISC_SHARES_VIA_AGGREGATE  https://review.openstack.org/48579216:15
openstackgerritMerged openstack/nova master: Use _error_out_instance_on_exception in finish_resize  https://review.openstack.org/48560116:16
*** roeyc has joined #openstack-nova16:16
*** tbachman has quit IRC16:17
*** dtantsur is now known as dtantsur|afk16:17
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Change Service repr to use self.id always  https://review.openstack.org/48750216:17
openstackgerritMerged openstack/nova master: Adjust error msg for ImageNUMATopologyAsymmetric  https://review.openstack.org/48463416:17
mriedembauzas: ^ there you go16:17
bauzasjaypipes: please, tell me my concern in https://review.openstack.org/#/c/483566/14 is not valid and we self-heal allocations on compute nodes16:17
bauzasjaypipes: I know we do this but on a periodic base16:18
bauzasjaypipes: but my question is more about a possible race condition between the time we delete the allocations and the source compute runs again the RT that will self-heal the allocations16:19
*** jwcroppe has quit IRC16:20
jaypipesbauzas: on call16:20
jaypipesgimme few16:20
bauzasmriedem: +2d16:21
bauzasmriedem: just find another peep :p16:21
bauzasoh oops16:21
bauzass/peep/peer16:21
*** lucasagomes is now known as lucas-afk16:23
*** felipemonteiro_ has quit IRC16:23
*** felipemonteiro_ has joined #openstack-nova16:23
*** mvk has joined #openstack-nova16:23
*** Sukhdev_ has quit IRC16:24
*** cNilesh has quit IRC16:24
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2)  https://review.openstack.org/40895516:24
*** lyan has quit IRC16:26
*** felipemonteiro_ has quit IRC16:28
*** trinaths has joined #openstack-nova16:28
*** Sukhdev_ has joined #openstack-nova16:28
bauzasjaypipes: need to go awol for dinner, but you can ping me later or drop a note if you think I scared for nothing16:32
jaypipesbauzas: will do!16:32
*** trinaths has quit IRC16:32
*** armax_ has joined #openstack-nova16:33
*** roeyc has quit IRC16:35
*** roeyc has joined #openstack-nova16:35
*** armax has quit IRC16:36
*** armax_ is now known as armax16:36
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276616:36
*** roeyc has quit IRC16:37
*** damien_r has quit IRC16:42
*** crushil has joined #openstack-nova16:43
*** cdent has quit IRC16:46
*** tbachman has joined #openstack-nova16:46
*** claudiub has quit IRC16:46
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Be clear about hypevisors.search used in a few CLIs  https://review.openstack.org/48751316:47
mriedemcfriesen: dansmith: ^16:47
mriedemthat's backportable to stable16:47
mriedemchanging the behavior of those CLIs is not16:47
*** tristanC has joined #openstack-nova16:48
*** Swami has joined #openstack-nova16:49
openstackgerritMatthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in resize_instance  https://review.openstack.org/48749516:49
openstackgerritMatthew Booth proposed openstack/nova master: Split Compute.errors_out_migration into a separate contextmanager  https://review.openstack.org/48573416:49
openstackgerritMatthew Booth proposed openstack/nova master: Ensure errors_out_migration errors out migration  https://review.openstack.org/47980216:49
openstackgerritMatthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in finish_resize  https://review.openstack.org/48751516:49
*** roeyc has joined #openstack-nova16:49
*** saphi has quit IRC16:51
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2)  https://review.openstack.org/40896416:51
mriedemsdague: grenade exploded http://logs.openstack.org/85/487485/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/7ab03fb/logs/grenade.sh.txt.gz#_2017-07-26_15_59_28_97416:51
mriedembut, that's appropriate for a project called 'grenade' i guess16:52
*** blake has quit IRC16:52
cfriesenmriedem: who approved "host-evacuate-live" anyway? :)16:53
cfriesenmriedem: the suggestion to use an fqdn assumes that you have fqdns in your cluster16:56
mdboothcfriesen: That tool's old as the hills, isn't it?16:56
cfriesenin ours we just have hostnames "compute-1, compute-10, compute-100, etc" so there is no way to run "host-evacuate" on just compute-1 without changing the novaclient code.16:58
cfriesenmdbooth: looks like, yes.  really "evacuate" should have been "resurrect"  :)16:58
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2)  https://review.openstack.org/40896416:59
*** derekh has quit IRC16:59
mdboothcfriesen: I wrote this a while back, btw: https://gist.github.com/mdbooth/163f5fdf47ab45d7addd17:00
mdboothNo idea if it's useful to you, or it still works for that matter :)17:00
mdboothAlthough I'd hope the latter17:00
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action  https://review.openstack.org/41004217:01
*** roeyc has quit IRC17:01
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060817:01
*** yamahata has quit IRC17:01
cfriesenmdbooth: we've got our own management component that does something similar.17:01
mriedemcfriesen: why wouldn't you have fqdns on the compute hosts?17:01
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948317:02
mdboothcfriesen: Not surprised. Seems like a pretty common thing to want.17:02
cfriesenmriedem: no need for them...the computes don't talk to anything outside the cluster and they know the hostname of everything in the cluster.17:03
*** Sukhdev_ has quit IRC17:03
*** ralonsoh has quit IRC17:04
*** roeyc has joined #openstack-nova17:04
*** roeyc has quit IRC17:04
*** itlinux_ has joined #openstack-nova17:04
dansmithcfriesen: except you just said the reason to have them :)17:05
janguttermriedem, jaypipes: sean-k-mooney gave his +1 on https://review.openstack.org/#/c/483459 have I addressed your concerns too?17:05
mriedemjangutter: i'll look again after lunch17:05
cfriesendansmith: heh...I've proposed https://review.openstack.org/#/c/487494 which is the proper fix. (Once I add in the error for hostname not found.)17:05
janguttermriedem: thanks!17:06
dansmithcfriesen: except that breaks the current, legit behavior17:06
cfriesendansmith: we agreed at the last PTG that the current pattern-match behaviour didn't make sense and should be changed.17:07
dansmithwe did?17:07
cfriesenyep17:07
* dansmith wonders who "we" is17:07
dansmithif I have compute0001.cellN.foo.com in each cell, I can evacuate them in parallel with no shared infrastructure between them and have no problems17:08
cfriesendansmith: the help text for the cases in question are written as affecting a single host, but they use a pattern match which could affect multiple hosts accidentally17:08
dansmithI can't imagine why we wouldn't want a --strict flag to enable that new behavior17:08
dansmithbut the behavior wins over incorrect docs right?17:09
*** ftersin has quit IRC17:09
cburgessdansmith I'm not following. I actually didn't know it pattern matches and I'm having a hard time figuring out why you would want that. Can you explain the use case more?17:09
*** itlinux_ has quit IRC17:09
cfriesendansmith: from my notes it was on the Friday session at the PTG17:09
dansmithcburgess: lets say I'm marching through compute nodes to do upgrades, getting all the instances off each one you're going to upgrade first17:10
cfriesenand I think it's counterintuitive that a command called "nova host-evacuate" would affect multiple hosts17:10
dansmithcburgess: and you want to do batches, either in parallel across cells or just the first N nodes at a time17:10
dansmithcfriesen: I'm not saying it wouldn't have made sense to make it behave that way originally, I just don't see why we should change it instead of offering the option for --strict17:11
cburgessdansmith And the argument is the client should enable that rather then the admin just issuing N calls?17:11
*** itlinux has joined #openstack-nova17:11
dansmithcburgess: this is admin only17:11
cfriesendansmith: if you specify "compute-1 it'll affect compute-1, compute-10 to compute-19, compute-100 to compute-199, etc.17:11
dansmithcburgess: you meant the CLI I guess. I'm just saying it _does_17:11
dansmithcfriesen: yeah, I understand how pattern matching works.. hence my example above with not insane compute node hostnames :)17:12
cburgessdansmith I'm with cfriesen on this in that its its extremely counter-intuitive to me. But I get what you are saying about its been that way for a long time so we probably need to be careful changing it now and possible use a flag to do that.17:12
dansmithcburgess: I'm with you too in saying that it probably shouldn't have been done this way in the beginning,17:13
dansmithbut it clearly intended to pattern match, so I'm guessing the intent was, you know, to be able to do that :)17:13
cfriesenI'm not sure it was intentional...I think it was just fallout of the fact that we don't have a way to look up a single hypervisor by name17:14
dansmithand as we always say, the api docs don't matter, the actual behavior is what matters and what people will build dependencies on17:14
cburgessdansmith Granted... we call the API directly for this rather then use the CLI because there are other issues around limiting the number of in-flight migrations etc. So this is partially just me saying "That don't make no sense".17:14
cburgessdansmith I get it... like I said, mostly be saying "That don't make no sense." But hey... its what we ship.17:14
dansmithcburgess: not so much across hosts, which is where the matching is here, and we added the live migration throttle, but yeah agreed17:14
cburgessdansmith live migration throttle?17:15
*** owalsh is now known as owalsh_biab17:15
dansmithcfriesen: if it wasn't intentional, it would have failed if the match was zero or >1, or just taken the first match, but it clearly adds all the resulting hosts, so .. clearly intentional, IMHO17:15
cfriesenif we're going to change the docs per mriedem's patch...is it worth me updating to include the --strict hostname matching mode or just leave it as is?17:15
dansmithcburgess: yeah you can limit how many migrations in parallel a single host will make17:15
cburgessdansmith This is a nova.conf option or API thing... or CLI thing? Sorry a bit slow this morning it seems.17:16
dansmithcfriesen: I'm happy with your patch if you make it only do that thing on --strict17:16
dansmithcfriesen: or if you want to go down the path of requiring either --strict or --loose and do the major version bump dance17:16
dansmithcburgess: yeah, nova-compute conf17:16
dansmithcburgess: hold on17:16
dansmithcburgess: https://github.com/openstack/nova/blob/master/nova/conf/compute.py#L588-L60117:16
dansmithcburgess: you're welcome :)17:16
*** armax has quit IRC17:16
dansmithcburgess: we have a build limit too, in case you hadn't seen it17:17
dansmithcburgess: to avoid building 20 instances in parallel on a single compute node17:17
dansmiths/building/failing to build/ :)17:17
cburgessdansmith Interesting... thanks. I will have to read up on this. I vaguely recall some conversation about this several summits ago.17:18
*** trinaths has joined #openstack-nova17:20
dansmithI feel like this is a 3-coffee day17:21
*** tylerderosagrund has quit IRC17:25
cburgessdansmith So if I'm reading the code right... the max_concurrent_live_migrations option protects the source hypervisor from having more then 1 migrations at a time but the destination isn't protected at all. Does this jive with your understanding?17:30
dansmithcburgess: yep, it's outbound17:30
dansmithcburgess: could do the same for inbound, or obey the build counter for inbounds17:30
dansmiththe reason was,17:31
dansmithon host-evac-live, you're necessarily hitting one compute node for outbound, but scheduler could spread the targets out17:31
dansmithobviously if you're packing and have an empty host, they'll all want to go to the same place17:31
*** Apoorva_ has joined #openstack-nova17:32
cburgessdansmith inbound seems like it would be harder... you would have to modify the flow so that the source makes a call to the dest to try and acquire a migration slot or something like that and then keep retrying to get it before it does the migration. Seems like it would be tough to do right an not end up with deadlocks.17:32
*** sree has joined #openstack-nova17:32
*** sshwarts has quit IRC17:32
*** coreywright has quit IRC17:32
openstackgerritMerged openstack/python-novaclient master: Microversion 2.53 - services and hypervisors using UUIDs  https://review.openstack.org/48543517:33
dansmithcburgess: ah, yeah I guess because we make a blocking call for live migrate but not for build, fair point17:33
cburgessdansmith Yeah... it would be very tricky.. which is a bummer since protecting the dest is something we would want to do as well (we actually try very hard to ensure we never have more then 1 in-coming migration at time in liberty due to some pretty nasty os-brick race conditions).17:34
*** kristian__ has quit IRC17:35
*** Apoorva has quit IRC17:35
*** kristian__ has joined #openstack-nova17:35
cburgessdansmith But its good to know about these 2 options. I think we will tune the max_concurrent_builds down some to help with performance.17:35
dansmithcburgess: donuts appreciated :P17:36
*** sree has quit IRC17:36
cburgessdansmith hehe... yeah I didn't do donuts in Boston because mriedem said we wouldn't really have the right setup. I'll look into the donuts making a return in Denver.17:36
dansmithcburgess: I'm only joking.. you're way over your donuts requirement quota17:37
vdrokdansmith: ouch http://logs.openstack.org/58/487458/2/check/gate-tempest-dsvm-ironic-pxe_ipmitool-postgres-ubuntu-xenial-nv/40fb4fb/logs/devstacklog.txt.gz waiting for hypervisors fail17:38
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/48747317:39
*** trinaths has quit IRC17:39
*** kristian__ has quit IRC17:39
vdrokthe variable picked up by nova http://logs.openstack.org/58/487458/2/check/gate-tempest-dsvm-ironic-pxe_ipmitool-postgres-ubuntu-xenial-nv/40fb4fb/logs/devstacklog.txt.gz#_2017-07-26_16_06_41_21617:40
dansmithvdrok: gdi, nothing but bad news from you ever17:40
vdrok:D17:40
dansmithvdrok: you never just stop by to say hi, always to say someting is broken! :)17:40
vdrokI promise to start the next day with 'good morning' to nova channel :)17:41
cburgessdansmith You have sent me down a rabbit whole here reading all the options with that link to the code. Its nice to have all the options in one place but man its a bit scary reading some of this stuff.17:41
mriedemis there anything i need to care about in the scrollback?17:42
mriedembesides chet letting us down on donuts in boston?17:42
cburgessmriedem donuts17:42
cburgesslol17:42
dansmithvdrok: http://logs.openstack.org/58/487458/2/check/gate-tempest-dsvm-ironic-pxe_ipmitool-postgres-ubuntu-xenial-nv/40fb4fb/logs/screen-n-cpu.txt.gz#_Jul_26_16_08_05_91004417:42
dansmithvdrok: looks like it created the compute node...17:42
vdrokyup, but for some reason it's not picked up by hypervisor-stats17:43
*** ioggstream has quit IRC17:44
dansmithvdrok: and never by discover either17:44
*** coreywright has joined #openstack-nova17:45
*** lyan has joined #openstack-nova17:46
*** acormier_ has joined #openstack-nova17:46
*** harlowja has quit IRC17:46
*** rajathagasthya has quit IRC17:46
*** rajathagasthya has joined #openstack-nova17:47
dansmithvdrok: okay I think this might be because this hack was for grenade and it's not complete enough for a fresh install17:47
dansmithvdrok: I think we're pointing at super-conductor (which we want) but it's configured to point at cell0 (which we do not)17:48
dansmithvdrok: so give me a few to mull this over17:48
openstackgerritJackie Truong proposed openstack/nova master: Add trusted certificates to InstanceExtras  https://review.openstack.org/45771117:49
*** acormier has quit IRC17:49
*** kbaegis has joined #openstack-nova17:50
*** armax has joined #openstack-nova17:52
dansmithvdrok: updated the devstack change17:56
*** sambetts is now known as sambetts|afk17:57
vdrokdansmith: thanks! will come back if it fails again :D17:57
vdrokgood night17:57
dansmithvdrok: o/17:58
*** prateek_ has joined #openstack-nova17:58
*** Apoorva_ has quit IRC18:04
*** cdent has joined #openstack-nova18:04
*** Apoorva has joined #openstack-nova18:04
*** yamamoto has joined #openstack-nova18:09
*** yamamoto has quit IRC18:13
*** kristian__ has joined #openstack-nova18:14
*** sdague has quit IRC18:16
*** cdent has quit IRC18:16
*** acormier_ has quit IRC18:17
*** acormier has joined #openstack-nova18:17
*** yamahata has joined #openstack-nova18:19
*** kristian__ has quit IRC18:19
*** ioggstream has joined #openstack-nova18:19
*** eharney has quit IRC18:23
*** acormier has quit IRC18:25
*** acormier has joined #openstack-nova18:25
*** Sukhdev_ has joined #openstack-nova18:28
*** acormier has quit IRC18:30
*** kristian__ has joined #openstack-nova18:30
mriedemjangutter: really only nits in the release note now https://review.openstack.org/#/c/483459/18:30
mriedembut see what you think18:30
janguttermriedem: I'm working on getting our docs cleared for general release on our support site. Currently customers should have subscriptions, but they should be generally available by the time Pike gets released.18:32
janguttermriedem: should I respin and remove the soon?18:33
*** eharney has joined #openstack-nova18:34
*** sdague has joined #openstack-nova18:37
*** yamahata has quit IRC18:37
*** baoli has quit IRC18:40
*** baoli has joined #openstack-nova18:41
*** sgordon has quit IRC18:41
sdaguedansmith: your cell1 db change didn't work18:47
jaypipesbauzas: answered. sorry, went to lunch18:47
sdaguehttps://review.openstack.org/#/c/48747818:48
sdaguedansmith: is there a reason you changed that?18:49
*** yamahata has joined #openstack-nova18:53
dansmithsdague: didn't work how? but yes, we need to make that change19:01
dansmithsdague: remember this was just a grenade hack, which meant conductor and other services were still configured to point at the cell db, not cell019:01
dansmithon fresh with this they're configured wrong now19:02
bauzasjaypipes: just reading your comment19:02
dansmithsdague: didn't want to ask before pushing over top eh?19:02
bauzasjaypipes: I'm a bit in and out till' 9pm my time but will think of your comment19:02
sdaguedansmith: I did, all the tests failed19:02
*** dave-mccowan has joined #openstack-nova19:02
bauzasoops 9.30pm19:02
sdaguecell1 db does not exist19:02
sdaguedansmith: http://logs.openstack.org/78/487478/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/69e2d2e/19:03
dansmithsdague: nova_cell1 should be created on L69319:03
sdagueso given that jenkins -1ed that version of the patch I figured it was fine to run it the old way19:03
sdaguedansmith: well, it failed pretty hard19:03
openstackgerritJan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement  https://review.openstack.org/48345919:03
dansmithit won't actually work without it, and the ironic people found it before jenkins19:04
sdaguedansmith: ok, but it doesn't pass with it19:04
*** dave-mccowan has quit IRC19:04
dansmithI get it, but we need to make the change19:05
sdaguehttp://logs.openstack.org/78/487478/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/69e2d2e/logs/devstacklog.txt.gz#_2017-07-26_18_12_02_72819:05
sdaguedansmith: that's fine, you need to help me figure out what other thing is also needed for that change to work19:05
dansmithI'm doing it now19:05
*** nicolasbock has quit IRC19:06
dansmithoh it's failing on the sync before we create it.. I wonder why that's different now19:07
sdaguebecause this function is creating the top level nova.conf19:09
sdaguehttps://github.com/openstack-dev/devstack/blob/62edb2f0f64bf4ac2c75e9bbfffbad5aac5ad41c/lib/nova#L671-L68019:10
sdaguethe cell1 db is not created before the sync19:10
sdaguefor the top level19:10
dansmithright, because now that points to cell0 always in the toplevel and it's created already19:11
sdagueyes19:11
dansmithso I switched the order of those things which I think will be fine for both cases19:12
*** jamiec has quit IRC19:12
*** vishwanathj has quit IRC19:14
sdagueok, if that works, good enough19:14
*** vishwanathj has joined #openstack-nova19:14
*** owalsh_biab is now known as owalsh19:19
*** jamiec has joined #openstack-nova19:19
*** acormier has joined #openstack-nova19:20
*** harlowja has joined #openstack-nova19:21
sdaguedansmith: thanks for the grenade patch fix, I should put a safety wrapper around that for things that only need to set variables19:21
dansmithsdague: np19:22
*** acormier has quit IRC19:25
*** harlowja has quit IRC19:25
*** rcernin has quit IRC19:27
*** ioggstream has quit IRC19:29
openstackgerritSean Dague proposed openstack/nova master: Remove the useless fake ExtensionManager from API unittests  https://review.openstack.org/48641619:33
openstackgerritSean Dague proposed openstack/nova master: Move the note about '/os-volume_boot' to the correct place  https://review.openstack.org/48607119:33
*** randomhack has joined #openstack-nova19:35
*** awaugama has quit IRC19:35
mriedemjangutter: +2, just need jaypipes to +W now19:37
janguttermriedem: I sincerely owe you guys. Thanks!19:38
*** acormier has joined #openstack-nova19:39
*** randomhack has quit IRC19:40
*** prateek_ has quit IRC19:40
*** dtp has quit IRC19:52
*** sgordon has joined #openstack-nova19:52
bauzasjaypipes: so I'm back19:52
jaypipesbauzas: from outer space?19:52
bauzasjaypipes: heh, just from my backyard :p19:53
* bauzas was just taking some tomatoes from his garden :p19:53
bauzasanyway19:54
bauzasso I saw your comment19:54
bauzasjaypipes: (and others) https://review.openstack.org/#/c/483566/14/nova/scheduler/filter_scheduler.py@17019:54
bauzasso, yeah, we have a self-heal by the RT.update_available_resource(), sure, agreed19:55
bauzasbut the problem I thought was about the fact that it's only running every 60 secs by default19:55
bauzasso we could be having a race between the time we deleted the allocations from the source host, and when the source RT is again running update_a_r()19:56
bauzaslike, we could possibly accept other instances for this host even if it's not possible19:57
bauzasor we could possibly accept some nested RPs to be used (like SRVIO VFs) meanwhime19:57
bauzasjaypipes: so, I was thinking, should we maybe just get the original allocations from the source host before deleting them, so that if we have problems in the scheduler, we could put them again ?19:58
bauzasjaypipes: something like _cleanup_allocations() would return for example19:59
bauzasthat said, given how we're close to FF, I wonder if it's possible19:59
bauzasthat's it for me.20:00
bauzas:p20:00
bauzasroger, roger.20:00
dansmithbauzas: see my comment in there just now20:00
dansmithmriedem: melwitt: I'm like quad booked for shit all day.. given where we are, do we have things to discuss for cells or should we put the meeting. I think we're down to the devstack stuff and placement related bits at this point20:01
dansmithbut if we have things, we can still do it20:01
melwittdon't think we have to have a meeting but I was just gonna say the console stuff is still up and passing jenkins. I have a devstack change up that Depends-On the stack and runs console proxies per cell and that works too20:02
bauzasdansmith: looking20:02
dansmithmelwitt: orly, okay, I should go look at that20:03
bauzasmelwitt: dansmith: mriedem: if you need me reviewing things before pike-3 for cells v2, just lemme know20:03
dansmithif mriedem agrees, hopefully we just had our meeting20:03
dansmithbauzas: console stuff20:03
bauzasok20:03
*** liverpooler has quit IRC20:03
melwittCONSOLEZ. I'm about to update it to redact tokens in the debug logs but other than that, it's been ready. mostly unchanged from when PaulMurray was working on it20:04
mriedemok to ditch the meeting20:04
*** Sukhdev_ has quit IRC20:05
mriedemwhat do we lose if we don't have the console proxy stuff done?20:05
mriedembecause < 24 hours is tough for something that hasn't had review yet20:05
*** acormier has quit IRC20:05
*** acormier has joined #openstack-nova20:06
melwittmriedem: I think just inability to shard console proxies. current state is the token auth cache and proxies are global. the console stuff moves token auth storage to the cell databases and then shards proxies, one per cell20:07
melwittand starts on the deprecation timer on eliminating the consoleauth service20:07
bauzasdansmith: looks good for me with the plan20:09
dansmithsounds like a good candidate to punt then20:09
dansmithbauzas: ack20:09
*** _pewp_ has quit IRC20:09
bauzasdansmith: I was just thinking of restoring the original allocation but honestly having both allocations for the source and destination hosts make more sense in terms of "resource usage"20:09
bauzasbecause when you wanna move, you need to make sure you have double room20:10
bauzasuntil the move is done20:10
melwittdansmith: yeah. I think the main concern I had was if a change in deployment topology being out-of-sync with the rest of the multicell changes, but I think based on our current state, superconductor isn't going to be a thing yet, right?20:10
*** Sukhdev has quit IRC20:10
*** marst_ has joined #openstack-nova20:10
*** acormier has quit IRC20:10
*** acormier has joined #openstack-nova20:11
*** marst has quit IRC20:11
dansmithmelwitt: it is, merged in devstack now.. not sure I get the relation20:11
dansmithmelwitt: or you mean a change in deployment from pike->queens?20:11
melwittor rather, I don't know what the current state of multicell is in regard to what we will document for users. I think I asked the question on the etherpad, what does multi-tier mean vs multi-cell?20:11
dansmithno difference, I just used the term once to mean something specific and someone started saying it I think20:12
melwittlike, when we will have the communication of "you'll need to change your deployment of services like this" I was thinking it might be less confusing if the console proxy run location changes coincided with that20:12
dansmiththe only people affected by such a change would be people that would split out a cell in pike, and then upgrade to queens I think20:12
melwittinstead of letting someone get started with multicell and global console proxies and then in another release saying, "oh yeah, go back and change what you already deployed"20:13
dansmithand anyone that does that won't have reschedules and affinity checks in pike anyway20:13
*** cfriesen_ has joined #openstack-nova20:13
dansmithyeah, so that'd be the only concern I think20:13
melwittright20:13
dansmithI think that the migration wouldn't be bad though,20:13
*** pchavva has quit IRC20:13
*** _pewp_ has joined #openstack-nova20:14
dansmithbecause you can just start up console in the cell prior to the upgrade and it won't do anything until after things roll20:14
dansmithup to mriedem to decide which he thinks is less problematic/risky20:14
dansmithmerging early, or documenting that change to the people that actually split a cell in pike20:14
melwittyeah, I guess not. it would be like, stand up console proxies per cell and have to leave the global ones running too until no outstanding tokens are using them anymore20:14
dansmithwell, as I've said,20:14
dansmithI don't think that resetting tokens is a big deal20:14
dansmithyou just don't want to have a time where you can't get new tokens20:15
openstackgerritEric Fried proposed openstack/nova master: nova.utils.get_service_url()  https://review.openstack.org/45825720:15
melwittyeah, true20:15
efriedmriedem jaypipes johnthetubaguy (mordred) ^20:15
mordredefried: woot!20:16
efriedMay need a little help making sure I find all the right places that need to be touched for the followup (other places in nova that talk to endpoints)20:16
*** cfriesen has quit IRC20:17
bauzasmriedem: jangutter: I have a concern with https://review.openstack.org/#/c/483459/1720:17
efriedmordred The difference in ksa usage is dissapointingly tiny in proportion to the amount of ksa work done :)20:17
*** acormier has quit IRC20:17
efriedmordred But os-service-types is gold20:17
bauzasmriedem: jangutter: AFAICT, it's depending on an os-vif change, right?20:17
mordredefried: you're setting ks_adapter.interface to a list in utils - isn't there some way to set a conf default or something?20:17
mriedembauzas: which is already merged and released20:17
mordredefried: woot!20:17
jangutterbauzas: correct20:18
*** acormier has joined #openstack-nova20:18
bauzasmriedem: oh nevermind, just saw it20:18
efriedmordred The conf options come directly from ksa.20:18
* mordred doens't know as much about oslo.config so it's also possible that that's not possible20:18
bauzasmriedem: I thought we didn't released it20:18
*** cfriesen_ has quit IRC20:18
mordredyah- I thought there was maybe some way to set/override the deafult value for one of them or something20:18
efriedmordred Mm, not sure about that.  Doug would probably know.20:19
jangutterbauzas: yeah, it snuck in right as the door closed.20:19
efriedmordred Not completely sure we would want to do that, exactly.20:19
mordredefried: nod20:19
bauzasjangutter: happy for you20:19
efriedI guess I can see the advantage for automatic conf generation or something.20:19
*** cdent has joined #openstack-nova20:19
openstackgerritmelanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens  https://review.openstack.org/32538120:20
openstackgerritmelanie witt proposed openstack/nova master: Use ConsoleConnection object to generate authorizations  https://review.openstack.org/32541420:20
openstackgerritmelanie witt proposed openstack/nova master: Add console connection object  https://review.openstack.org/32006320:20
openstackgerritmelanie witt proposed openstack/nova master: Add access_url_base to console_auth_tokens table  https://review.openstack.org/33461420:20
openstackgerritmelanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation  https://review.openstack.org/33399020:20
openstackgerritmelanie witt proposed openstack/nova master: Add console_auth_token_get() method to DB API  https://review.openstack.org/48170020:20
jangutterbauzas: thanks, I owe the gang some serious drinks.20:20
mriedemmelwitt: so i think to summarize the statement for multi-cell in pike, is cern will be ok with it since they don't do build retries anyway, but if you rely on retries then you shouldn't do multi-cell in pike, since we don't have the alternatives stuff done20:21
mriedemor if you rely on server group affinity/anti-affinity since the computes and cell conductors can't hit the scheduler or api db20:22
mriedemdansmith: ^ keep me honest on that 2nd one20:22
melwittyeah, that makes sense. I just wasn't sure what the difference between multi-tier and multi-cell was but if they're synonyms then I think I understand the state20:23
openstackgerritMerged openstack/python-novaclient master: Change Service repr to use self.id always  https://review.openstack.org/48750220:23
bauzasmriedem: dansmith: melwitt: correct me if I'm wrong but you can multi-cell and retry if you are able to upcall ?20:23
bauzasthe only problem is when you usually isolate your MQs20:24
*** armax has quit IRC20:24
mriedemmelwitt: multi-tier to me is superconductor, and it's not really worth doing multi-cell if you can't do multi-tier with superconductor, because then your cells are all going to be blasting to every other cell conductor - which breaks a bunch of stuff20:25
mriedemdan mentioned this on a hangout yesterday with me and jay20:25
*** gouthamr has quit IRC20:26
mriedemwell there is no cell conductor,20:26
mriedemthere is just conductor20:26
melwittokay. does that mean we're going to document a multi-cell deployment with no superconductor? I was thinking not20:26
melwitti.e. multi-cell also means multi-tier to us20:26
mriedemi'm not sure what the advantage of multi-cell w/o superconductor would be if you're sharing MQ everywhere20:27
*** gouthamr has joined #openstack-nova20:27
melwittwhat I'm trying to say is, we're in the position of presenting the deployment options in our docs, so are we going to leave out the "multi-cell w/o superconductor" from that? I was thinking so, else it becomes needlessly confusing20:28
mriedemi think we definitely need to document what we're recommending for the deployment, and what the limitations are in pike20:28
*** gbarros has joined #openstack-nova20:28
mriedemso if you can't live with the limitations in pike, then don't do multi-cell20:28
melwittbecause AFAICT, multi-cell without superconductor isn't really supposed to be a thing20:28
*** sree_ has joined #openstack-nova20:30
cdentedleafe:20:30
mriedemprobably need to hash it out with dan when he's got some time20:30
mriedemsince this always makes me go in circles20:30
*** sree_ is now known as Guest7447220:31
cdentnm20:31
melwittyeah. it just doesn't sound like something we should document and thus recommend20:31
*** raunak has joined #openstack-nova20:31
melwittdocument the recommended deployment alongside its limitations20:31
melwittone for single cell and one for multicell20:32
sdaguejlvillal / vdrok ironic is still failing after the devstack change, on the hypervisor count never exceeding 020:34
sdagueis that the same issue you were dealing with, or a different one20:34
sdaguehttp://logs.openstack.org/58/487458/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial/01e5dfe/20:34
*** Guest74472 has quit IRC20:35
jlvillalsdague: I'll be honest and admit I don't know what exactly is going on. vdrok has been driving this issue.20:36
jlvillalsdague: And it is 23:36 at night where he is...20:37
bauzasjangutter: question, are we 100% sure the VIF object we're getting is always having a profile information if it's an Agilio VNIC type ? https://review.openstack.org/#/c/483459/17/nova/network/os_vif_util.py@31920:37
bauzasjangutter: I think it's a reasonable assumption but I want to be sure we're not getting a stupid KeyError exception20:37
jangutterbauzas: It should, or the claim would fail earlier. The only two VNIC types we use are in the SR-IOV list.20:38
*** randomhack has joined #openstack-nova20:38
*** Drankis has quit IRC20:39
*** smatzek has quit IRC20:40
sdaguejlvillal: ok, the test results hadn't returned yet, so I just figured I'd give an early heads up20:40
jlvillalsdague: Thanks, doesn't look like the test job likes those changes. Based on all the failures20:40
sdaguewe're about 17 minutes away from the devstack patch passing20:40
*** tojuvone__ has quit IRC20:41
jlvillalUgh20:41
sdaguejlvillal: yeh, I don't know what the previous issue was actually20:41
*** tojuvone__ has joined #openstack-nova20:41
*** kristian__ has quit IRC20:41
*** kristian__ has joined #openstack-nova20:42
jlvillalsdague: I'm telling people about it over in #openstack-ironic. Reaction not so good ;)20:42
*** randomhack has quit IRC20:44
*** cfriesen_ has joined #openstack-nova20:44
dansmithsdague: jlvillal that's the one yeah20:44
dansmithjlvillal: for the record, I did ask a week ago and things were good in ironic land dependent on the change :)20:44
jlvillaldansmith: I thought we tested it before and it worked.20:45
* jlvillal confused20:45
sdaguedansmith: http://logs.openstack.org/58/487458/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial/01e5dfe/logs/devstacklog.txt.gz#_2017-07-26_19_51_43_73520:45
dansmithjlvillal: that's what was reported yeah, but it turns out that was only the grenade one not the multinode regular job20:45
sdagueany idea why nova might not register resources in the new patch?20:45
catintheroofHi, does anyone has a good guide on how to configure live migration on ocata ? doing the same that worked as of mitaka, doesnt anymore20:46
dansmithyes, there's a dependent one that you need20:46
dansmithhang on20:46
jlvillalsdague: So what patch is about to land? And is that what will cause ironic to break?20:46
jangutterbauzas: I got this from the scheduler:  Insufficient compute resources: Requested instance NUMA topology together with requested PCI devices cannot fit the given host NUMA topology; Claim pci failed. _phew_20:46
*** kristian__ has quit IRC20:46
*** slagle has quit IRC20:46
dansmithhttps://review.openstack.org/#/c/487458/20:46
openstackgerritEric Fried proposed openstack/nova master: WIP: Set Adapter interface defaults in conf  https://review.openstack.org/48758120:47
dansmithoh20:47
dansmithyour run is from that20:47
jlvillalyeah]20:47
*** slagle has joined #openstack-nova20:47
dansmithyeah let me look through a sec hang on20:47
sdaguehttp://logs.openstack.org/58/487458/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial/01e5dfe/logs/screen-n-cpu.txt.gz#_Jul_26_19_40_24_440198 that doesn't look good20:47
jlvillal+1 on not looking good20:48
mriedemthat's the flavor migrate stuff i think20:49
dansmithnova.conf is still pointing at cell020:49
mriedemhttps://review.openstack.org/#/c/484949/20:49
mriedemyup, also shows up in n-cpu logs in the ironic job on that nova change http://logs.openstack.org/49/484949/14/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/69b18d7/logs/screen-n-cpu.txt.gz?level=TRACE20:50
mriedemedleafe: ^20:50
mriedemso a different problem20:50
*** thorst has quit IRC20:50
dansmithoh,20:50
dansmiththe logic is reversed20:50
sdaguedansmith: oh, ok, that's hopeful20:51
sdagueso it just needs to be the other way around?20:51
dansmithyeah20:52
dansmithpushed a change and rechecked20:52
dansmithyeah20:52
dansmithbecause I was still in inverted flag mode in my brain head20:52
dansmithjlvillal: ^20:52
jlvillaldansmith: Thanks!20:52
mriedemsdague: shouldn't we see https://review.openstack.org/#/c/487458/ pass before approving the devstack change?20:53
sdaguedansmith: ok, I pre +Aed your new change. I'm going to be dropping off shortly for the day20:53
dansmithokay20:54
sdaguemriedem: maybe, the question is whether anyone will be around to do that.20:54
mriedemi guess we can proxy to mtreinish20:54
sdagueso, I can do this thing, and assuming life is good, it goes in.20:54
mriedemyeah otherwise we'll bug mtreinish20:54
sdagueif things suck, just hit the rebase button20:54
sdagueto prevent it from landing20:54
dansmithsdague: you can throw one of us on devstack core and pinky swear not to do anything else20:54
sdagueif anyone else wants to be devstack core, I'll sign you right up :)20:55
dansmithhaha20:55
mriedemnot it20:55
sdaguehonestly mriedem if you want that bit you can have it20:55
sdagueyou poke enough there20:55
dansmithsounds less glamorous when you put it that way20:55
jlvillal+1 for more devstack cores :)20:55
mriedemhere is the bug for the 500 on n-cpu startup with ironic https://bugs.launchpad.net/nova/+bug/170677220:58
openstackLaunchpad bug 1706772 in OpenStack Compute (nova) "InternalServerError: Internal Server Error (HTTP 500) in n-cpu logs on startup with Ironic driver" [High,Confirmed]20:58
*** catintheroof has quit IRC21:01
*** gbarros has quit IRC21:02
openstackgerritJay Pipes proposed openstack/nova master: claim resources in placement API during schedule()  https://review.openstack.org/48356621:03
openstackgerritJay Pipes proposed openstack/nova master: placement: account for move operations in claim  https://review.openstack.org/48758921:03
jaypipesdansmith, bauzas, mriedem: ^^21:04
mriedemlooking21:05
*** esberglu has quit IRC21:05
*** acormier has quit IRC21:05
*** acormier has joined #openstack-nova21:06
mtreinishmriedem: you need me to review something?21:08
melwittmriedem: do we not need a spec for adding new policy rules? I would have thought we do https://review.openstack.org/#/c/44928821:08
mtreinishI was just sitting in a corner inhaling lead fumes, but I can take a break from that21:09
melwittlol21:09
mriedemmtreinish: not yet21:09
*** tojuvone__ has quit IRC21:09
jaypipesmtreinish: nice. :)21:10
mriedemmelwitt: it's not an api change so i don't think a spec is neeed21:10
mriedem*needed21:10
*** tojuvone__ has joined #openstack-nova21:10
mriedemmelwitt: plus i think we did one or more of these same granularity policy things in ocata,21:10
melwittmriedem: okay, cool. thanks, I learned a thing21:10
mriedemthe key is it must be backward compatible with an existing policy json i think21:10
*** acormier has quit IRC21:10
mriedemso an operator would need to opt into the more granular rules21:10
melwittright. I think they are taking care of that in the patch21:11
melwittcool21:11
*** priteau has quit IRC21:15
openstackgerritmelanie witt proposed openstack/nova master: deprecate ``wsgi_log_format`` config variable  https://review.openstack.org/48662321:15
*** yamamoto_ has joined #openstack-nova21:19
*** yamamoto_ has quit IRC21:21
*** efoley has quit IRC21:24
bauzasjaypipes: just a question about https://review.openstack.org/#/c/487589/1/nova/scheduler/client/report.py21:24
*** cdent has quit IRC21:24
bauzasjaypipes: when we self-heal by the RT, we remove allocations that are not related to the existing instances, right?21:25
mriedemjaypipes: issues in https://review.openstack.org/#/c/48758921:25
* mriedem watches jay get blasted21:25
dansmithbauzas: that's what I said in my comment21:27
jaypipesbauzas: when the move_claim() completes on the destination host, it will overwrite the allocations to only be the ones on the destination host, yes. I think that's what you're asking?21:27
jaypipesmriedem: blasted?21:27
dansmithjaypipes: no21:28
dansmithjaypipes: he's asking about regular RT healing on the source node while the migration is going on, erasing the double claim21:28
bauzasdansmith: my question is about if either the source or the target RT removes the allocations for the moving instance given the instance.host is not related to it21:28
dansmithjaypipes: which was in my comment about the plan.. we need to make sure we don't heal over that21:29
openstackgerritEric Fried proposed openstack/nova master: WIP: Set Adapter interface defaults in conf  https://review.openstack.org/48758121:29
*** randomhack has joined #openstack-nova21:29
dansmithbauzas: instance.host will be related to the source until it completes21:29
dansmithbauzas: and it would remove the double claim once it runs21:29
*** esberglu has joined #openstack-nova21:29
bauzasdansmith: that's my question21:29
dansmithright21:29
mriedemjaypipes: with questions21:29
bauzasdansmith: because if instance.host is set to the source host, wouldn't the target RT removing the allocations for the target host ?21:30
dansmithagain, yes21:30
edleafemriedem: regarding https://bugs.launchpad.net/nova/+bug/1706772 - if we catch that and move on, the flavors will never migrate. What's the alternative?21:31
openstackLaunchpad bug 1706772 in OpenStack Compute (nova) "InternalServerError: Internal Server Error (HTTP 500) in n-cpu logs on startup with Ironic driver" [High,Confirmed]21:31
jaypipesdansmith: do you want me to put something in the RT's update_available_resource() method that basically says "oh, this is migrating? fuck it, don't touch placement"?21:31
dansmithjaypipes: we have to do something yeah21:31
mriedemi had a comment in the patch related to this: "when the move_claim() completes on the destination host, it will overwrite the allocations to only be the ones on the destination host, yes. "21:31
bauzasdansmith: sorry, I misunderstood your comment, I thought you were saying it wasn't a problem21:31
jaypipesdansmith: we already jump through a shit-ton of hoops for move operations in the RT...21:31
jaypipeswhat's one more...21:31
dansmithjaypipes: well, it's either correct or it's not...21:32
mriedemis PUT /allocations/<intsance uuid> completely overwriting the allocations for that instance?21:32
dansmithmriedem: yes21:32
bauzasmriedem: that is correct AFAIK21:32
jaypipesdansmith: no, for move operations the definition of "correct" is fuzzy.21:32
*** thorst has joined #openstack-nova21:32
dansmithjaypipes: I disagree :)21:32
mriedemah i see21:33
mriedemso this works the same if you're doing a resize and revert back to the source host i think21:35
jaypipesI'm wondering if instances that are migrating are in RT.tracked_instances...21:36
*** cleong has quit IRC21:36
jaypipesif they aren't, we're good.21:36
dansmithjaypipes: well, the existing RT stuff is not even correct, as you know21:36
*** randomhack has quit IRC21:36
bauzasjaypipes: well, I don't think so21:36
*** thorst has quit IRC21:37
bauzasjaypipes: IIRC, tracked_instances is for existing instances21:37
dansmithjaypipes: if you have the instance, you should be able to check instance.migration_context to know if it's moving21:37
bauzasnot for migrating ones21:37
jaypipesok, guys, I think we're good...21:37
dansmithbauzas: for migrating ones on the source they should be there right?21:37
jaypipeslemme explain.21:37
jaypipespls.21:37
bauzasdansmith: for the source RT, yeah they should be there AFAIK21:37
dansmithbauzas: right, destination node does not matter21:38
jaypipesso, in update_available_resource(), we call _update_usage_from_instance(). this is the "auto-heal" thing.21:38
bauzascorrect21:38
jaypipeswithin that method, we only delete the allocation if the instance is in DELETED or SHELVE_OFFLOADED state21:38
bauzasthe problem is how we could possibly have duplicate allocations for both target and source if source just removes the target allocations ?21:38
jaypipesotherwise we don't touch the allocations.21:38
dansmithjaypipes: eh?21:38
dansmithjaypipes: we compare the generated ones to the ones from placement and re-put them if they differ21:39
dansmiththat's how we get allocations now21:39
bauzasjaypipes: PUT /allocations/<instance_uuid> is cleaning up existing allocs, nope ?21:39
bauzasFWIW, it's becoming late and I could be wrong21:39
dansmithjaypipes: this: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L890-L90421:40
mriedemedleafe: need to find out when the nova-compute service with the ironic driver is able to talk to ironic21:40
*** cfriesen_ has quit IRC21:40
jaypipesdansmith: when does update_instance_allocation() get called though?21:40
dansmithjaypipes: oh, are you looking at the "is new or is old" bit of RT?21:41
*** cfriesen_ has joined #openstack-nova21:41
jaypipesdansmith: CORRECT!21:41
dansmithjaypipes: okay, so that's a problem for the failure case then,21:41
jaypipesdansmith: so we don't actually call that update_instance_allocation() unless it's either a brand new instance or it's DELETED/SHEVE_OFFLOADED21:41
dansmithjaypipes: because that means we'll never heal over the double allocation on the source when the migration is canceled21:41
edleafemriedem: sure, but my point was that since the code runs in init_host, it won't get a second chance to run *after* the ironic service starts up21:42
mriedemedleafe: at some point on startup the compute manager is calling get_inventory which has to refresh the node list21:42
mriedemb/c of the pre_start_hook in the compute manager21:43
*** acormier has joined #openstack-nova21:43
mriedemso does that just not work today? or are we just not waiting long enough?21:43
dansmithmriedem: edleafe: riht, that probably should run when we get a new node21:43
dansmithbecause you can get/lose nodes on ironic at runtime21:43
dansmithbecause we could have started with one node, migrated those, and then gained a couple more nodes later when someone shuts down another ironic compute in the hash ring21:44
edleafedansmith: I thougth a new node would be empty to start21:44
edleafeno instance21:44
dansmithand if that is done during upgrade, which it is, then you need to migrate it21:44
dansmithedleafe: no, because ^21:44
dansmithedleafe: nova-computes shard off the full set of ironic nodes,21:45
*** tbachman has quit IRC21:45
dansmithand if you were to upgrade one ironic compute, then shut down your old one,21:45
dansmithyou'd start with some nodes, and then later get a bunch more when the ring rebalances21:45
dansmithafter init_host(), at runtime, old nodes with instances that you now own and need to migrate21:45
edleafedansmith: so then what IYO would be a better place for this?21:46
dansmithedleafe: I'd have to go dig just like you, but there's a place in there where we rebalance the ring (or balance it for the first time) and get a list of the nodes we own21:46
cfriesen_jaypipes:  back at the last PTG did you arrive at any conclusions on how to handle the Intel CAT stuff?21:46
dansmithedleafe: so .. there. :)21:46
jaypipescfriesen_: bad time to bring that question :)21:47
* edleafe gets out the shovel21:47
jaypipescfriesen_: how about discuss tomorrow?21:47
dansmithedleafe: _refresh_hash_ring() is a good place to start21:48
cfriesen_jaypipes: sure21:48
dansmithafter you get the hash ring you could probably spawn your thread to go examine the instances on what the hash ring says are your nodes21:49
*** vishwana_ has joined #openstack-nova21:49
edleafedansmith: looking at that now...21:49
dansmithedleafe: obviously I wasn't thinking about this possibility either, as I'm used to the world before this was here and there was pretty much only one ironic compute ever21:50
mriedemit's curious that this blows up during init_host in the driver, but not when driver.get_available_nodes is called21:51
mriedemwhich is shortly after21:51
mriedemlike in ocata, this is init_host: http://logs.openstack.org/63/485263/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/de2c924/logs/screen-n-cpu.txt.gz#_2017-07-21_12_07_20_88521:51
mriedemand this is right after http://logs.openstack.org/63/485263/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/de2c924/logs/screen-n-cpu.txt.gz#_2017-07-21_12_07_21_16721:51
*** vishwanathj has quit IRC21:52
*** kylek3h has quit IRC21:54
*** kylek3h has joined #openstack-nova21:55
bauzasfolks it's late, so I'll disappear in a very short few21:55
mriedemo/21:55
bauzasbut like any release, just lemme know which changes I should review ASAP tomorrow morning my time21:56
*** xyang1 has quit IRC21:56
bauzasbefore we call the axe21:56
bauzasand again, sorry for not having been there for half-Pike21:56
bauzas\o21:56
*** Apoorva has quit IRC21:57
*** Apoorva has joined #openstack-nova21:57
*** edmondsw has quit IRC21:58
bauzasmriedem: before I leave, I'm torn by https://review.openstack.org/#/c/408955/21:58
mriedemedleafe: hold the phone, it was happening before the migrate flavors thing http://logs.openstack.org/80/461480/5/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/834477a/logs/screen-n-cpu.txt.gz?level=TRACE#_Jul_19_03_34_01_68729921:59
*** kylek3h has quit IRC21:59
*** harlowja has joined #openstack-nova22:00
mriedemblows up in ironic-api http://logs.openstack.org/80/461480/5/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/834477a/logs/screen-ir-api.txt.gz#_Jul_19_03_34_01_68046022:02
jgriffithmriedem ildikov added a note here https://review.openstack.org/#/c/330285/106 regarding the Trace showing up in the logs22:03
*** kristian__ has joined #openstack-nova22:07
openstackgerritMerged openstack/nova master: Updated from global requirements  https://review.openstack.org/48747322:07
mriedembauzas: torn how22:09
mriedem?22:09
mriedemthere are 3 other patches for that: api, docs and novaclient22:10
mriedemso it's pretty damn late22:10
*** kristian__ has quit IRC22:11
edleafemriedem: ah, so _refresh_cache() is the culprit. The migration change just adds that call a bit earlier22:12
mriedemjgriffith: ack22:13
mriedemedleafe: right, like <1 sec earlier22:13
mriedembut still blowing up22:13
mriedemi've adjusted the bug and routed it to ironic22:13
edleafemriedem: yeah, but we should be more graceful about it22:13
dansmithmriedem: edleafe well, the bug of not migrating nodes we get via hash rebalance is still a thing22:14
edleafedansmith: agreed22:14
openstackgerritEric Fried proposed openstack/nova master: Centralize keystoneauth1 Adapter conf option setup  https://review.openstack.org/48758122:15
*** eharney has quit IRC22:18
openstackgerritJay Pipes proposed openstack/nova master: claim resources in placement API during schedule()  https://review.openstack.org/48356622:19
openstackgerritJay Pipes proposed openstack/nova master: placement: account for move operations in claim  https://review.openstack.org/48758922:19
jaypipesmriedem, bauzas, dansmith: ding ding ding. round 2. ^^22:19
*** cfriesen_ has quit IRC22:19
mriedemheh, can i be glass joe?22:19
openstackgerritNicolas Simonds proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes  https://review.openstack.org/48499722:22
jaypipesmriedem: I'll work on my eye tattoo.22:23
mriedemheh i guess we forgot about safe_connect on claim_resources22:24
openstackgerritMerged openstack/nova master: Remove the code related to extension loading from APIRouterV21  https://review.openstack.org/48641422:24
openstackgerritEric Fried proposed openstack/nova master: nova.utils.get_service_url()  https://review.openstack.org/45825722:25
*** thorst has joined #openstack-nova22:25
*** thorst has quit IRC22:26
*** gouthamr has quit IRC22:28
*** crushil has quit IRC22:28
openstackgerritMatt Riedemann proposed openstack/nova master: Fix example in _serialize_allocations_for_consumer  https://review.openstack.org/48761422:30
mriedemjaypipes: dansmith: so we don't need to handle anything different from the compute RT perspective for a move operation?22:30
*** marst_ has quit IRC22:30
*** Sara_ has quit IRC22:33
*** esberglu has quit IRC22:34
openstackgerritMerged openstack/nova master: Suppress some test warnings  https://review.openstack.org/48670022:36
openstackgerritMerged openstack/nova master: Remove the useless FakeExt  https://review.openstack.org/48641522:37
*** gouthamr has joined #openstack-nova22:42
*** crushil has joined #openstack-nova22:48
openstackgerritNicolas Simonds proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes  https://review.openstack.org/48499722:51
*** crushil has quit IRC22:53
*** lyan has quit IRC22:54
*** acormier has quit IRC22:57
*** acormier has joined #openstack-nova22:57
dansmithmriedem: seems like not22:59
*** acormier has quit IRC23:02
*** acormier has joined #openstack-nova23:03
*** Apoorva_ has joined #openstack-nova23:05
*** acormier_ has joined #openstack-nova23:05
*** edmondsw has joined #openstack-nova23:06
*** acormier has quit IRC23:07
*** acormier_ has quit IRC23:07
*** Apoorva has quit IRC23:08
*** acormier has joined #openstack-nova23:08
*** Apoorva_ has quit IRC23:09
*** yamamoto has joined #openstack-nova23:10
*** edmondsw has quit IRC23:11
*** acormier has quit IRC23:12
mikalmelwitt: you still around?23:14
mikalmelwitt: tonyb and I are talking about making a quick list of things we'd like to see cleaned up in nova, because I keep forgetting things because I am an old man. tonyb suggested you had an etherpad like this already somewhere?23:15
melwittI think you probably mean mriedem :) ^23:17
mikalnah23:17
mikalIts all about you23:17
melwitthaha23:17
mikalWell, it depends if tonyb is lying about you already having an etherpad23:18
melwittyeah, if I ever knew of one in the past, I've forgotten about it. I'm not aware of a general nova todos etherpad23:18
mikalOk, I'll just call tonyb a liar in public then23:19
melwittI wouldn't be surprised if we had one at some point though23:19
mikalI'm ok with that23:19
melwitthaha :)23:19
mikalhttps://etherpad.openstack.org/p/nova-warts is my very long list of things I'd like to potter around fixing now that I am a hobbyist again23:19
melwittcoolness23:19
mikalmelwitt: speaking of which, it would be cool to get https://review.openstack.org/#/c/486831 merged before pike releases too from that series. Its only comments but it gives us a cleanish slate for the cleanup in queens.23:22
openstackgerritJay Pipes proposed openstack/nova master: claim resources in placement API during schedule()  https://review.openstack.org/48356623:22
openstackgerritJay Pipes proposed openstack/nova master: placement: account for move operations in claim  https://review.openstack.org/48758923:22
mikalmelwitt: i.e. please make with the rubber stamping, kthxbye23:22
*** sdague has quit IRC23:23
*** esberglu has joined #openstack-nova23:23
*** raunak_ has joined #openstack-nova23:24
melwittmikal: k, will look23:25
*** raunak has quit IRC23:25
*** raunak_ is now known as raunak23:25
*** thorst has joined #openstack-nova23:27
*** esberglu has quit IRC23:28
jaypipesedleafe: consolidated the dict construction to a single line for you.23:28
mikalmelwitt: ta23:29
*** chyka has quit IRC23:32
*** oomichi has quit IRC23:32
*** thorst has quit IRC23:32
*** acormier has joined #openstack-nova23:32
*** oomichi has joined #openstack-nova23:34
openstackgerritEric Fried proposed openstack/nova master: WIP: Use service catalog (and discovery) for cinder endpoints  https://review.openstack.org/48762123:35
*** acormier has quit IRC23:35
efriedmordred ^^ *very* WIP, but could you look and see if this is a remotely sane approach to the cinder conversion?23:35
efriedmordred thanks in advance.23:35
*** efried is now known as efried_zzz23:35
*** acormier has joined #openstack-nova23:35
*** yamamoto has quit IRC23:37
smcginnisOoh, nice.23:38
openstackgerritMerged openstack/nova master: Netronome SmartNIC Enablement  https://review.openstack.org/48345923:39
openstackgerritMerged openstack/nova master: Remove the useless extension block_device_mapping_v1 object  https://review.openstack.org/48606923:40
openstackgerritMerged openstack/nova master: Remove the useless fake ExtensionManager from API unittests  https://review.openstack.org/48641623:41
*** takashin has joined #openstack-nova23:41
openstackgerritMerged openstack/nova master: Skip boot from encrypted volume on Xen+libvirt  https://review.openstack.org/48162723:42
openstackgerritMerged openstack/nova master: Add helper method for waiting migrations in functional tests  https://review.openstack.org/48653723:43
tonybmelwitt, mikal: let me see if I can find the one I was thinking of.23:43
openstackgerritMerged openstack/nova master: docstring and unused code removal  https://review.openstack.org/48749223:44
openstackgerritMerged openstack/nova master: Move the note about '/os-volume_boot' to the correct place  https://review.openstack.org/48607123:44
*** Apoorva has joined #openstack-nova23:45
*** Apoorva has quit IRC23:46
*** Apoorva has joined #openstack-nova23:49
*** vladikr has quit IRC23:49
melwitttonyb: in rootwrap.d, do the comments do anything to scope the commands or are they just for humans to read?23:49
*** thorst has joined #openstack-nova23:50
*** thorst has quit IRC23:50
tonybmelwitt: just for humans23:51
*** yamamoto has joined #openstack-nova23:51
melwitttonyb: cool, thanks23:51
tonybmelwitt: when doing the privsep stuff in later patches it was annoying to identify things that could be pruned, so I thought I'd mkae it a little easier23:52
melwitttonyb: yeah, I think I understand now23:52
tonybmelwitt: I'll address your review feedback after the last_bytes patch lands to make the rebase slightly easier if that's cool with you23:53
melwitttonyb: okay. if the stuff I mentioned is going to be a later cleanup, that's cool. just wanted to make sure I understood23:54
*** dillaman has quit IRC23:54
*** Sukhdev has joined #openstack-nova23:54
tonybwell one of you comments is taken care of in a later patch the other was on my mental todo list I haven't done more that that.23:55
tonybI'll reply and then you can make a call.23:55
*** yamamoto_ has joined #openstack-nova23:55
*** yamamoto has quit IRC23:56
melwitttonyb: cool thanks23:57
*** Swami has quit IRC23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!