| *** coreywright has joined #openstack-nova | 00:00 | |
| *** chyka has joined #openstack-nova | 00:01 | |
| *** sree__ has joined #openstack-nova | 00:03 | |
| *** thorst_afk has quit IRC | 00:03 | |
| *** rajathagasthya has joined #openstack-nova | 00:04 | |
| *** sree__ has quit IRC | 00:07 | |
| *** chyka has quit IRC | 00:09 | |
| *** jwcroppe has joined #openstack-nova | 00:14 | |
| *** gmann has quit IRC | 00:14 | |
| *** gmann has joined #openstack-nova | 00:14 | |
| *** tbachman has quit IRC | 00:16 | |
| *** tbachman has joined #openstack-nova | 00:20 | |
| *** sdague has quit IRC | 00:21 | |
| *** annegentle has quit IRC | 00:24 | |
| *** acormier has joined #openstack-nova | 00:27 | |
| *** acormier has quit IRC | 00:28 | |
| *** acormier has joined #openstack-nova | 00:29 | |
| *** jwcroppe has quit IRC | 00:32 | |
| *** baoli has joined #openstack-nova | 00:34 | |
| *** mtanino has quit IRC | 00:35 | |
| *** eswenson has joined #openstack-nova | 00:37 | |
| *** eswenson has left #openstack-nova | 00:38 | |
| *** baoli has quit IRC | 00:38 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in cast_as_call.py https://review.openstack.org/477730 | 00:40 |
|---|---|---|
| *** mdnadeem has joined #openstack-nova | 00:41 | |
| *** itlinux has joined #openstack-nova | 00:45 | |
| *** fragatina has quit IRC | 00:45 | |
| *** rajathagasthya has quit IRC | 00:46 | |
| *** fragatina has joined #openstack-nova | 00:46 | |
| *** chyka has joined #openstack-nova | 00:46 | |
| *** catintheroof has joined #openstack-nova | 00:47 | |
| *** fragatin_ has joined #openstack-nova | 00:49 | |
| *** fragatin_ has quit IRC | 00:50 | |
| *** fragatina has quit IRC | 00:50 | |
| *** fragatin_ has joined #openstack-nova | 00:50 | |
| *** chyka has quit IRC | 00:51 | |
| *** fragatin_ has quit IRC | 00:52 | |
| *** fragatina has joined #openstack-nova | 00:52 | |
| *** baoli has joined #openstack-nova | 00:55 | |
| openstackgerrit | Merged openstack/nova master: Add tags to instance.create Notification https://review.openstack.org/459493 | 00:55 |
| *** fragatina has quit IRC | 00:56 | |
| *** baoli has quit IRC | 00:59 | |
| *** tuanluong has joined #openstack-nova | 01:00 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385 | 01:02 |
| *** phuongnh has joined #openstack-nova | 01:02 | |
| openstackgerrit | Merged openstack/nova master: Allow wrapping of closures https://review.openstack.org/479801 | 01:04 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Flush RC_CACHE after each gabbit sequence https://review.openstack.org/486805 | 01:05 |
| *** cdent has joined #openstack-nova | 01:07 | |
| cdent | dansmith: if you’re still around, this is probably a better fix for that 201 204 problem: https://review.openstack.org/#/c/486805/ | 01:08 |
| cdent | (I couldn’t sleep, got bored, read mail…) | 01:08 |
| alex_xu | oomichi: appreciate if you can take a look at https://review.openstack.org/#/c/486414/, that patch is the goal of pike | 01:08 |
| *** Apoorva_ has joined #openstack-nova | 01:13 | |
| *** harlowja has quit IRC | 01:13 | |
| mriedem | cdent: i'll drop mine once yours passes functional tests | 01:15 |
| cdent | mriedem: roger that | 01:15 |
| *** Apoorva has quit IRC | 01:16 | |
| *** Apoorva_ has quit IRC | 01:17 | |
| *** catintheroof has quit IRC | 01:18 | |
| *** fragatina has joined #openstack-nova | 01:25 | |
| *** hshiina has joined #openstack-nova | 01:25 | |
| *** cdent has quit IRC | 01:26 | |
| *** fragatina has quit IRC | 01:29 | |
| *** cdent has joined #openstack-nova | 01:30 | |
| *** yufei has joined #openstack-nova | 01:32 | |
| openstackgerrit | Merged openstack/nova master: Migrate Ironic Flavors https://review.openstack.org/484949 | 01:32 |
| *** lyan has quit IRC | 01:45 | |
| *** litao__ has joined #openstack-nova | 01:48 | |
| *** Shunli has joined #openstack-nova | 01:49 | |
| *** crushil has joined #openstack-nova | 01:50 | |
| *** baoli has joined #openstack-nova | 01:51 | |
| *** baoli has quit IRC | 01:56 | |
| *** dave-mccowan has joined #openstack-nova | 01:57 | |
| *** mamandle has joined #openstack-nova | 01:58 | |
| *** bkopilov_ has quit IRC | 01:59 | |
| *** bkopilov has quit IRC | 01:59 | |
| *** yamahata has quit IRC | 02:00 | |
| *** itlinux has quit IRC | 02:00 | |
| *** itlinux has joined #openstack-nova | 02:00 | |
| *** mamandle has quit IRC | 02:05 | |
| *** jwcroppe has joined #openstack-nova | 02:07 | |
| *** dave-mccowan has quit IRC | 02:07 | |
| openstackgerrit | Merged openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | 02:07 |
| *** jwcroppe has quit IRC | 02:12 | |
| *** fragatina has joined #openstack-nova | 02:16 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Using wsgi-intercept in OSAPIFixture https://review.openstack.org/486825 | 02:28 |
| *** kristian__ has quit IRC | 02:29 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use wsgi_intercept in PlacementFixture https://review.openstack.org/486237 | 02:29 |
| *** kristian__ has joined #openstack-nova | 02:29 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Using wsgi-intercept in OSAPIFixture https://review.openstack.org/486825 | 02:30 |
| *** acormier_ has joined #openstack-nova | 02:33 | |
| *** gbarros has joined #openstack-nova | 02:33 | |
| *** fragatina has quit IRC | 02:34 | |
| *** kristian__ has quit IRC | 02:34 | |
| *** esberglu has joined #openstack-nova | 02:35 | |
| *** acormier has quit IRC | 02:36 | |
| *** baoli has joined #openstack-nova | 02:37 | |
| *** esberglu has quit IRC | 02:40 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Optimize MiniDNS for fewer syscalls https://review.openstack.org/486829 | 02:40 |
| *** baoli has quit IRC | 02:41 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Update the placement deployment instructions https://review.openstack.org/469048 | 02:41 |
| *** marst has joined #openstack-nova | 02:44 | |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229 | 02:44 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: First attempt at adding a privsep user to nova itself. https://review.openstack.org/459166 | 02:44 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt https://review.openstack.org/472228 | 02:44 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py https://review.openstack.org/485907 | 02:44 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep. https://review.openstack.org/471972 | 02:44 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files https://review.openstack.org/486831 | 02:44 |
| *** gouthamr has quit IRC | 02:46 | |
| *** fragatina has joined #openstack-nova | 02:55 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Using wsgi-intercept in OSAPIFixture https://review.openstack.org/486825 | 02:56 |
| *** jwcroppe has joined #openstack-nova | 02:57 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353 | 03:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Optimize MiniDNS for fewer syscalls https://review.openstack.org/486829 | 03:01 |
| *** acormier_ has quit IRC | 03:01 | |
| *** acormier has joined #openstack-nova | 03:02 | |
| *** lbragsta_ has joined #openstack-nova | 03:04 | |
| *** cdent has quit IRC | 03:05 | |
| *** acormier has quit IRC | 03:06 | |
| *** yushb has joined #openstack-nova | 03:07 | |
| *** gbarros has quit IRC | 03:10 | |
| *** fragatina has quit IRC | 03:12 | |
| *** chohoor has quit IRC | 03:13 | |
| *** bkopilov_ has joined #openstack-nova | 03:15 | |
| *** bkopilov has joined #openstack-nova | 03:15 | |
| *** vishwana_ has joined #openstack-nova | 03:19 | |
| *** vishwana_ has quit IRC | 03:19 | |
| *** randomhack has joined #openstack-nova | 03:19 | |
| *** vishwanathj has quit IRC | 03:22 | |
| *** fragatina has joined #openstack-nova | 03:23 | |
| *** kiennt has joined #openstack-nova | 03:24 | |
| *** yushb has quit IRC | 03:25 | |
| *** yushb has joined #openstack-nova | 03:26 | |
| *** randomhack has quit IRC | 03:26 | |
| *** chohoor has joined #openstack-nova | 03:29 | |
| TheJulia | hshiina: looks like https://review.openstack.org/215385 is already in merge conflict again :( | 03:30 |
| *** yushb has quit IRC | 03:30 | |
| *** hshiina has quit IRC | 03:41 | |
| *** yamamoto has quit IRC | 03:45 | |
| *** lbragsta_ has quit IRC | 03:48 | |
| *** armax has quit IRC | 03:52 | |
| openstackgerrit | Julia Kreger proposed openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385 | 03:58 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API https://review.openstack.org/486850 | 03:58 |
| *** yamamoto has joined #openstack-nova | 04:00 | |
| *** hshiina has joined #openstack-nova | 04:01 | |
| *** gbarros has joined #openstack-nova | 04:05 | |
| *** gbarros has quit IRC | 04:13 | |
| *** nicolasbock has joined #openstack-nova | 04:13 | |
| *** markvoelker has quit IRC | 04:14 | |
| openstackgerrit | Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/466995 | 04:17 |
| *** esberglu has joined #openstack-nova | 04:23 | |
| *** esberglu has quit IRC | 04:28 | |
| *** links has joined #openstack-nova | 04:30 | |
| *** dikonoor has joined #openstack-nova | 04:33 | |
| *** thorst_afk has joined #openstack-nova | 04:38 | |
| *** thorst_afk has quit IRC | 04:43 | |
| *** diga has joined #openstack-nova | 04:45 | |
| openstackgerrit | Merged openstack/nova master: request_log addition for running under uwsgi https://review.openstack.org/485602 | 04:47 |
| *** sree_ has joined #openstack-nova | 04:54 | |
| *** sree_ is now known as Guest81381 | 04:54 | |
| *** Guest81381 has quit IRC | 04:55 | |
| *** jaypipes has joined #openstack-nova | 04:56 | |
| *** prateek has joined #openstack-nova | 05:12 | |
| *** dikonoor has quit IRC | 05:16 | |
| openstackgerrit | sudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid() https://review.openstack.org/481007 | 05:17 |
| *** jjung has joined #openstack-nova | 05:18 | |
| *** diga has quit IRC | 05:22 | |
| *** diga has joined #openstack-nova | 05:25 | |
| *** sridharg has joined #openstack-nova | 05:26 | |
| *** ratailor has joined #openstack-nova | 05:29 | |
| *** jwcroppe has quit IRC | 05:30 | |
| *** josecastroleon has joined #openstack-nova | 05:30 | |
| *** josecastroleon1 has quit IRC | 05:30 | |
| *** itlinux has quit IRC | 05:31 | |
| *** dikonoor has joined #openstack-nova | 05:31 | |
| *** josecastroleon has quit IRC | 05:34 | |
| *** kristian__ has joined #openstack-nova | 05:34 | |
| *** psachin has joined #openstack-nova | 05:36 | |
| *** randomhack has joined #openstack-nova | 05:38 | |
| *** ekuris has joined #openstack-nova | 05:38 | |
| *** kristian__ has quit IRC | 05:38 | |
| *** sree_ has joined #openstack-nova | 05:40 | |
| *** sree_ is now known as Guest60018 | 05:41 | |
| *** randomhack has quit IRC | 05:42 | |
| *** yamahata has joined #openstack-nova | 05:42 | |
| *** trinaths has joined #openstack-nova | 05:44 | |
| *** moshele has joined #openstack-nova | 05:46 | |
| *** kiennt has quit IRC | 05:46 | |
| *** josecastroleon has joined #openstack-nova | 05:51 | |
| *** jjung_ has joined #openstack-nova | 05:58 | |
| *** kiennt has joined #openstack-nova | 06:03 | |
| *** rcernin has joined #openstack-nova | 06:10 | |
| *** esberglu has joined #openstack-nova | 06:11 | |
| *** udesale has joined #openstack-nova | 06:13 | |
| *** markvoelker has joined #openstack-nova | 06:15 | |
| *** esberglu has quit IRC | 06:16 | |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229 | 06:17 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: First attempt at adding a privsep user to nova itself. https://review.openstack.org/459166 | 06:17 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt https://review.openstack.org/472228 | 06:17 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py https://review.openstack.org/485907 | 06:17 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep. https://review.openstack.org/471972 | 06:17 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files https://review.openstack.org/486831 | 06:17 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API https://review.openstack.org/486850 | 06:20 |
| *** andreas_s has joined #openstack-nova | 06:22 | |
| *** bkopilov has quit IRC | 06:24 | |
| trinaths | hi, I'm using nova (mitaka) compute. when I spawn a VM, it will auto shutoff after 10 minutes. and at qemu logs, it was the error: 2017-07-25T00:52:49.334691Z qemu-system-aarch64: Failed initializing vhost-user memory map, consider using -object memory-backend-file share=on | 06:30 |
| trinaths | qemu-system-aarch64: /root/qemu/hw/virtio/vhost.c:1186: vhost_virtqueue_mask: Assertion `vdev->use_guest_notifier_mask' failed. Please help me in resolving this issue. | 06:30 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229 | 06:33 |
| *** amuresan has joined #openstack-nova | 06:34 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | 06:37 |
| *** kristian__ has joined #openstack-nova | 06:38 | |
| *** thorst_afk has joined #openstack-nova | 06:39 | |
| *** kiennt has quit IRC | 06:41 | |
| *** belmoreira has joined #openstack-nova | 06:44 | |
| *** thorst_afk has quit IRC | 06:44 | |
| *** jamesden_ has quit IRC | 06:47 | |
| *** kristian__ has quit IRC | 06:48 | |
| *** jamesdenton has joined #openstack-nova | 06:48 | |
| *** kristian__ has joined #openstack-nova | 06:49 | |
| *** markvoelker has quit IRC | 06:49 | |
| *** tiendc has joined #openstack-nova | 06:50 | |
| *** kristian__ has quit IRC | 06:53 | |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229 | 06:54 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: First attempt at adding a privsep user to nova itself. https://review.openstack.org/459166 | 06:54 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt https://review.openstack.org/472228 | 06:54 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py https://review.openstack.org/485907 | 06:54 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep. https://review.openstack.org/471972 | 06:54 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files https://review.openstack.org/486831 | 06:54 |
| *** kristian__ has joined #openstack-nova | 06:57 | |
| *** danpawlik has joined #openstack-nova | 06:58 | |
| *** josecastroleon has quit IRC | 06:58 | |
| *** alexchadin has joined #openstack-nova | 06:59 | |
| *** josecastroleon has joined #openstack-nova | 07:06 | |
| *** sshwarts has joined #openstack-nova | 07:19 | |
| *** hferenc has quit IRC | 07:19 | |
| *** hferenc has joined #openstack-nova | 07:21 | |
| *** kiennt has joined #openstack-nova | 07:23 | |
| *** markus_z has joined #openstack-nova | 07:26 | |
| *** avolkov has quit IRC | 07:31 | |
| *** avolkov has joined #openstack-nova | 07:31 | |
| *** hferenc has quit IRC | 07:32 | |
| *** chohoor has quit IRC | 07:33 | |
| *** hferenc has joined #openstack-nova | 07:38 | |
| *** damien_r has joined #openstack-nova | 07:43 | |
| *** josecastroleon has quit IRC | 07:45 | |
| *** markvoelker has joined #openstack-nova | 07:46 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353 | 07:47 |
| *** josecastroleon has joined #openstack-nova | 07:51 | |
| *** josecastroleon has quit IRC | 07:52 | |
| *** josecastroleon has joined #openstack-nova | 07:54 | |
| *** ralonsoh has joined #openstack-nova | 07:54 | |
| *** claudiub has joined #openstack-nova | 07:55 | |
| *** josecastroleon has quit IRC | 07:56 | |
| *** ralonsoh has quit IRC | 07:59 | |
| *** efoley has joined #openstack-nova | 08:00 | |
| *** josecastroleon1 has joined #openstack-nova | 08:03 | |
| openstackgerrit | Rawan Herzallah proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640 | 08:03 |
| *** aarefiev_afk is now known as aarefiev | 08:05 | |
| *** ralonsoh has joined #openstack-nova | 08:06 | |
| *** josecastroleon has joined #openstack-nova | 08:07 | |
| *** josecastroleon1 has quit IRC | 08:07 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API https://review.openstack.org/486850 | 08:07 |
| *** derekh has joined #openstack-nova | 08:10 | |
| *** josecastroleon has quit IRC | 08:13 | |
| jangutter | Hi, there are two patches left for netronome-smartnic-enablement. Would anyone have cycles to leave comments? 50 lines of code, 300 lines of tests, many litres of blood. https://review.openstack.org/#/c/486426/ and https://review.openstack.org/#/c/483459/ | 08:15 |
| *** jhesketh has joined #openstack-nova | 08:16 | |
| *** ralonsoh has quit IRC | 08:16 | |
| *** ralonsoh has joined #openstack-nova | 08:16 | |
| jangutter | For that matter, Mellanox's got a similar patch: https://review.openstack.org/#/c/398265/ | 08:16 |
| *** randomhack has joined #openstack-nova | 08:19 | |
| *** markvoelker has quit IRC | 08:20 | |
| *** mamandle has joined #openstack-nova | 08:22 | |
| *** jjung has quit IRC | 08:22 | |
| *** jhesketh_ has joined #openstack-nova | 08:22 | |
| *** jjung_ has quit IRC | 08:22 | |
| *** lucas-afk is now known as lucasagomes | 08:23 | |
| *** randomhack has quit IRC | 08:23 | |
| *** josecastroleon has joined #openstack-nova | 08:24 | |
| *** jhesketh has quit IRC | 08:25 | |
| *** johnhaan has joined #openstack-nova | 08:26 | |
| *** josecastroleon has quit IRC | 08:29 | |
| *** jhesketh_ is now known as jhesketh | 08:30 | |
| *** yamamoto has quit IRC | 08:33 | |
| *** roeyc has joined #openstack-nova | 08:35 | |
| *** priteau has joined #openstack-nova | 08:36 | |
| *** jjung_ has joined #openstack-nova | 08:38 | |
| *** jjung has joined #openstack-nova | 08:39 | |
| *** thorst_afk has joined #openstack-nova | 08:40 | |
| *** _pewp_ has quit IRC | 08:40 | |
| openstackgerrit | Artem Tiumentcev proposed openstack/nova-specs master: SPEC: nova disk quota tracking https://review.openstack.org/486947 | 08:42 |
| *** _pewp_ has joined #openstack-nova | 08:44 | |
| *** thorst_afk has quit IRC | 08:45 | |
| *** yamamoto has joined #openstack-nova | 08:46 | |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229 | 08:49 |
| *** yamamoto has quit IRC | 08:50 | |
| *** esberglu has joined #openstack-nova | 08:53 | |
| *** yamamoto has joined #openstack-nova | 08:57 | |
| *** esberglu has quit IRC | 08:57 | |
| *** yamahata has quit IRC | 09:00 | |
| kashyap | mdbooth: Thanks for the review here: https://review.openstack.org/#/c/485752/ | 09:01 |
| kashyap | mdbooth: Test - I will fix, that's also why I -1ed it myself. | 09:01 |
| kashyap | mdbooth: But the core change itself is working; the downstream bug reporter has tested the fix and confirmed that they don't see the perf regression anymore with this fix | 09:01 |
| *** yamamoto has quit IRC | 09:05 | |
| *** yamamoto has joined #openstack-nova | 09:11 | |
| *** markvoelker has joined #openstack-nova | 09:17 | |
| mdbooth | kashyap: Yeah, I said it looked good :) | 09:18 |
| mdbooth | Except for the bits which didn't, but you can sort those easily enough. | 09:18 |
| kashyap | mdbooth: Sure, did notice your remark. :-) | 09:18 |
| kashyap | mdbooth: The bits which didn't are - (a) missing tests; (b) adding in the config line that accidentally removed | 09:19 |
| kashyap | Anything else you noticed? | 09:19 |
| mdbooth | Nope. | 09:19 |
| mdbooth | The code structure is kinda ugly, but sahid already noted that | 09:20 |
| openstackgerrit | Alexandru Muresan proposed openstack/nova master: Ensure that vif ports are unplugged during cold migration https://review.openstack.org/486955 | 09:20 |
| kashyap | mdbooth: There's a comment from Sahid? I don't even see it, /me refreshes the URL | 09:22 |
| mdbooth | Not a review comment | 09:22 |
| kashyap | Maybe you mean in the code | 09:22 |
| kashyap | Yeah, noted. | 09:22 |
| mdbooth | A code comment from the distant past | 09:22 |
| kashyap | Yep | 09:23 |
| *** mvk has quit IRC | 09:25 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add tags fields for server list detail/show api-ref https://review.openstack.org/465842 | 09:25 |
| *** yamamoto has quit IRC | 09:28 | |
| *** Shunli has quit IRC | 09:29 | |
| openstackgerrit | Rikimaru Honjo proposed openstack/nova master: compute: Sweep duplicated bdm records https://review.openstack.org/290793 | 09:31 |
| openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform instance.resize_confirm notification https://review.openstack.org/482557 | 09:32 |
| *** tiendc has quit IRC | 09:32 | |
| bauzas | gabor_antal: gibi: about https://review.openstack.org/#/c/467514/7/nova/compute/api.py@4977 honestly my only concern was that I think "import" is probably not a great RESTful action | 09:36 |
| *** yamamoto has joined #openstack-nova | 09:36 | |
| bauzas | gabor_antal: gibi: cdent reminded me previously that a PUT can create or update with a body so in theory there should only be one notification of creation | 09:37 |
| bauzas | but anyway, seems I'm nitpicking | 09:37 |
| *** yamamoto has quit IRC | 09:40 | |
| *** yamamoto has joined #openstack-nova | 09:44 | |
| *** ralonsoh has quit IRC | 09:45 | |
| *** ralonsoh has joined #openstack-nova | 09:45 | |
| bauzas | gibi: btw. any notifications patches I could help to land before FF ? | 09:45 |
| *** yamamoto has quit IRC | 09:48 | |
| *** _pewp_ has quit IRC | 09:48 | |
| *** markvoelker has quit IRC | 09:49 | |
| *** _pewp_ has joined #openstack-nova | 09:51 | |
| *** mvk has joined #openstack-nova | 09:54 | |
| *** kornicameister has quit IRC | 09:56 | |
| *** Guest60018 has quit IRC | 09:58 | |
| *** Drankis has joined #openstack-nova | 09:59 | |
| *** sdague has joined #openstack-nova | 09:59 | |
| *** kiennt has quit IRC | 10:04 | |
| *** sambetts|afk is now known as sambetts | 10:06 | |
| *** phuongnh has quit IRC | 10:08 | |
| *** konan_abhi has joined #openstack-nova | 10:08 | |
| *** dtantsur|afk is now known as dtantsur | 10:10 | |
| *** abhishek_k has quit IRC | 10:11 | |
| *** yamamoto has joined #openstack-nova | 10:13 | |
| *** konan_abhi has quit IRC | 10:15 | |
| *** rmart04 has joined #openstack-nova | 10:16 | |
| *** abhishekk has joined #openstack-nova | 10:17 | |
| *** openstackgerrit has quit IRC | 10:17 | |
| *** openstackgerrit has joined #openstack-nova | 10:18 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from ``ip`` commands to ``pyroute2`` https://review.openstack.org/484386 | 10:18 |
| *** gszasz has joined #openstack-nova | 10:19 | |
| *** alexchadin has quit IRC | 10:22 | |
| *** cdent has joined #openstack-nova | 10:22 | |
| *** thorst_afk has joined #openstack-nova | 10:24 | |
| gibi | bauzas: hi! thanks for the feedback. I don't have direct user feedback so I cannot say for sure that we need import in the notification but it feels useful for me | 10:29 |
| bauzas | cools | 10:29 |
| gibi | bauzas: for patches to help in, I see on patch that needs a second +2 https://review.openstack.org/#/c/480984/ | 10:31 |
| gibi | bauzas: besides that we have a list of patches that looks good from subteam perspective (and has +1) here https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/versioned-notification-transformation-pike+label:Code-Review%253E%253D%252B1+label:Verified%253E%253D1+AND+NOT+label:Verified%253C0+AND+NOT+label:Code-Review%253C0 | 10:31 |
| * gibi still has to send the weekly notification focus mail | 10:32 | |
| *** dikonoor has quit IRC | 10:33 | |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Transform HostAPI-set_enabled notifications https://review.openstack.org/482622 | 10:34 |
| gibi | bauzas: any help is appreciated | 10:34 |
| *** jjung_ has quit IRC | 10:37 | |
| *** jjung has quit IRC | 10:37 | |
| bauzas | gibi: going out for lunch but will review those afterwards | 10:38 |
| openstackgerrit | Merged openstack/nova master: Remove check_detach https://review.openstack.org/446671 | 10:40 |
| gibi | bauzas: enjoy for lunch, I just brought mine in the meantime | 10:43 |
| *** markvoelker has joined #openstack-nova | 10:46 | |
| gibi | s/for/your/ | 10:49 |
| openstackgerrit | Alexandra Settle proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485 | 10:50 |
| *** jjung has joined #openstack-nova | 10:51 | |
| *** jjung_ has joined #openstack-nova | 10:51 | |
| *** dikonoor has joined #openstack-nova | 10:52 | |
| *** bkopilov_ has quit IRC | 10:55 | |
| *** lucasagomes has quit IRC | 10:55 | |
| *** wachu has quit IRC | 10:58 | |
| *** dikonoor has quit IRC | 10:59 | |
| *** dikonoor has joined #openstack-nova | 11:03 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 11:03 |
| *** dinesh_ has joined #openstack-nova | 11:06 | |
| *** yassine has joined #openstack-nova | 11:06 | |
| *** dinesh_ has left #openstack-nova | 11:06 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 11:09 |
| *** mdnadeem has quit IRC | 11:10 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 11:14 |
| *** dikonoor has quit IRC | 11:15 | |
| *** markvoelker has quit IRC | 11:20 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 11:21 |
| *** mamandle has quit IRC | 11:23 | |
| ildikov | stephenfin: hi | 11:25 |
| ildikov | stephenfin: I just wanted to ask whether you got a chance to check stvnoyes's answers here: https://review.openstack.org/#/c/463987/ to see whether they address your concerns? | 11:26 |
| *** jjung_ has quit IRC | 11:27 | |
| *** jjung has quit IRC | 11:27 | |
| *** smatzek has joined #openstack-nova | 11:27 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 11:28 |
| *** takashin has left #openstack-nova | 11:28 | |
| *** smatzek has quit IRC | 11:29 | |
| *** smatzek has joined #openstack-nova | 11:29 | |
| *** dikonoor has joined #openstack-nova | 11:29 | |
| *** mamandle has joined #openstack-nova | 11:30 | |
| *** baoli has joined #openstack-nova | 11:32 | |
| *** baoli has quit IRC | 11:32 | |
| *** baoli has joined #openstack-nova | 11:33 | |
| *** ralonsoh has quit IRC | 11:33 | |
| *** lucasagomes has joined #openstack-nova | 11:35 | |
| mamandle | bauzas: https://review.openstack.org/#/c/483911/ needs a second +2, can you please take a look? | 11:38 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: WIP: Allow multi-attach in compute api https://review.openstack.org/271047 | 11:43 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 11:43 |
| *** danpawlik has quit IRC | 11:45 | |
| *** danpawlik has joined #openstack-nova | 11:47 | |
| *** alexchadin has joined #openstack-nova | 11:48 | |
| *** lbragsta_ has joined #openstack-nova | 11:51 | |
| *** zz9pzza has quit IRC | 11:53 | |
| *** amuresan has quit IRC | 11:53 | |
| *** zz9pzza has joined #openstack-nova | 11:54 | |
| *** alexchadin has quit IRC | 11:58 | |
| *** dikonoo has joined #openstack-nova | 11:59 | |
| *** pchavva has joined #openstack-nova | 12:00 | |
| *** dikonoor has quit IRC | 12:02 | |
| *** acormier has joined #openstack-nova | 12:04 | |
| *** litao__ has quit IRC | 12:05 | |
| *** tuanluong has quit IRC | 12:06 | |
| *** acormier has quit IRC | 12:08 | |
| *** alexchadin has joined #openstack-nova | 12:10 | |
| *** chohoor has joined #openstack-nova | 12:10 | |
| *** lbragsta_ has quit IRC | 12:12 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | 12:12 |
| mamandle | stephenfin: can you please check https://review.openstack.org/#/c/483911/ , its waiting on another +2. | 12:14 |
| *** markvoelker has joined #openstack-nova | 12:17 | |
| *** yamamoto has quit IRC | 12:18 | |
| *** jjung has joined #openstack-nova | 12:18 | |
| *** jjung_ has joined #openstack-nova | 12:18 | |
| *** tylerderosagrund has joined #openstack-nova | 12:18 | |
| *** tylerderosagrund has quit IRC | 12:19 | |
| *** tylerderosagrund has joined #openstack-nova | 12:19 | |
| *** tylerderosagrund has quit IRC | 12:19 | |
| *** tylerderosagrund has joined #openstack-nova | 12:19 | |
| openstackgerrit | Merged openstack/nova master: [placement] Flush RC_CACHE after each gabbit sequence https://review.openstack.org/486805 | 12:19 |
| mriedem | ildikov: stephenfin is on vacation all week | 12:25 |
| *** jwcroppe has joined #openstack-nova | 12:25 | |
| *** tylerderosagrund has quit IRC | 12:26 | |
| *** markvoelker has quit IRC | 12:26 | |
| *** gouthamr has joined #openstack-nova | 12:26 | |
| *** markvoelker has joined #openstack-nova | 12:26 | |
| *** links has quit IRC | 12:27 | |
| *** trinaths has quit IRC | 12:28 | |
| *** MVenesio has joined #openstack-nova | 12:28 | |
| s-dean | Hi, im a at a loss trying to get this working, this is a RPC problem right ? <class 'oslo_messaging.exceptions.MessagingTimeout'> | 12:30 |
| *** jwcroppe has quit IRC | 12:30 | |
| sdague | cdent: so it looks like you got to the bottom of the fixture issue? | 12:30 |
| sdague | though we seem to be bouncing off a keystone issue | 12:30 |
| cdent | sdague: I _think_ so | 12:30 |
| openstackgerrit | Rawan Herzallah proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640 | 12:32 |
| cdent | I started working on the OSAPIFixture too, but something has introduced some painful slowness. not clear if it is just wsgi intercept itself, or some other weirdness | 12:32 |
| *** lyan has joined #openstack-nova | 12:34 | |
| mriedem | jaypipes: i think i'm going to mark this done for pike https://blueprints.launchpad.net/nova/+spec/placement-allocation-requests | 12:35 |
| *** edmondsw has joined #openstack-nova | 12:36 | |
| *** yamamoto has joined #openstack-nova | 12:36 | |
| jaypipes | mriedem: ack | 12:39 |
| *** catintheroof has joined #openstack-nova | 12:39 | |
| *** catintheroof has quit IRC | 12:39 | |
| jaypipes | mriedem: I'll update the spec | 12:39 |
| *** catintheroof has joined #openstack-nova | 12:39 | |
| mriedem | thank | 12:41 |
| mriedem | s | 12:41 |
| *** links has joined #openstack-nova | 12:43 | |
| *** sree has joined #openstack-nova | 12:43 | |
| *** sree_ has joined #openstack-nova | 12:48 | |
| *** sree_ is now known as Guest21931 | 12:48 | |
| *** mamandle has quit IRC | 12:50 | |
| *** hshiina has quit IRC | 12:50 | |
| *** Guest21931 has quit IRC | 12:51 | |
| *** sree has quit IRC | 12:51 | |
| *** sree has joined #openstack-nova | 12:51 | |
| openstackgerrit | Gábor Antal proposed openstack/nova master: use context mgr in instance.delete https://review.openstack.org/443764 | 12:51 |
| *** yufei has quit IRC | 12:54 | |
| s-dean | Hi, could someone take a look at this log this is really weird. compute01 connects to rabbit, but throws this error. https://pastebin.com/ZbpJtBq8 | 12:55 |
| bauzas | jaypipes: I just thought about a possible problem with https://review.openstack.org/#/c/483566/10 | 12:55 |
| bauzas | jaypipes: tl;dr how can we be sure that the first allocation request node is accepted by the filters ? | 12:55 |
| *** esberglu has joined #openstack-nova | 12:55 | |
| *** abhishekk has quit IRC | 12:55 | |
| openstackgerrit | Alexandra Settle proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485 | 12:56 |
| bauzas | jaypipes: when we're getting a list of hosts after we run filters, we should possibly subset the alloc_reqs list to be only for accepted nodes, nope ? | 12:56 |
| bauzas | jaypipes: unless you're changing it somewhere and I'm blind | 12:56 |
| *** acormier has joined #openstack-nova | 12:56 | |
| *** eharney has joined #openstack-nova | 12:58 | |
| *** ralonsoh has joined #openstack-nova | 12:58 | |
| *** felipemonteiro_ has joined #openstack-nova | 12:59 | |
| *** jwcroppe has joined #openstack-nova | 12:59 | |
| *** acormier has quit IRC | 13:00 | |
| *** acormier has joined #openstack-nova | 13:01 | |
| mriedem | TheJulia: looks like CI for https://review.openstack.org/#/c/215385/ has passed using https://review.openstack.org/#/c/485812/ yes? | 13:02 |
| mriedem | although maybe not on the latest change? | 13:02 |
| *** mgiles has joined #openstack-nova | 13:02 | |
| cdent | sdague: is this nutbar or crazy pants or hmmm? https://review.openstack.org/#/c/486829/ | 13:03 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use wsgi-intercept in OSAPIFixture https://review.openstack.org/486825 | 13:03 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use wsgi_intercept in PlacementFixture https://review.openstack.org/486237 | 13:03 |
| mriedem | TheJulia: or are you testing here now? https://review.openstack.org/#/c/485349/ | 13:04 |
| bauzas | cdent: I'd be okay with wsgi-intercept but my concern goes with how many people are working for it | 13:04 |
| cdent | bauzas: the crazy pants question was about modify MiniDNS not wsgi-intercept. | 13:05 |
| *** ralonsoh has quit IRC | 13:05 | |
| *** ralonsoh has joined #openstack-nova | 13:05 | |
| cdent | on wsgi-intercept: we are already committed to using it because we are committed to using gabbi | 13:05 |
| bauzas | cdent: I'm looking at its github page, and it means nova would have a dependency for a small package | 13:05 |
| *** lucasxu has joined #openstack-nova | 13:05 | |
| cdent | it’s had that dependency for over a year | 13:05 |
| bauzas | cdent: sure, but gabbi looks pretty vibrant and I'm hoping it to have more contributors | 13:05 |
| bauzas | cdent: do we use it elsewhere but in that fixture ? | 13:06 |
| bauzas | if so, nevermind my concern | 13:06 |
| cdent | in gabbi itself | 13:06 |
| *** acormier has quit IRC | 13:06 | |
| sdague | cdent: that's just optimizing for the opens? | 13:06 |
| bauzas | a-ha, so a transitive dependency anyway | 13:06 |
| cdent | sdague: that, and for avoiding on disk files when CONF.log_dir is not set. I was doing an strace and so many lines of open and closing dnstest.txt | 13:07 |
| *** rmart04_ has joined #openstack-nova | 13:07 | |
| openstackgerrit | Alexandra Settle proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485 | 13:07 |
| sdague | yeh, that seems reasonable | 13:07 |
| bauzas | cdent: any plan to push wsgi-intercept to for example openstack ? | 13:07 |
| sdague | cdent: I kind of wonder whether the write to disk path is needed at all | 13:07 |
| TheJulia | mriedem: not ignoring you, presently debating a related grenade issue in another channel | 13:07 |
| cdent | bauzas: neither wsgi-intercept nor gabbi will come to openstack because a few of the other contributors _really_ do not want that | 13:08 |
| *** rmart04 has quit IRC | 13:08 | |
| *** rmart04_ is now known as rmart04 | 13:08 | |
| bauzas | cdent: that's understandable | 13:08 |
| bauzas | well, if we already have that transitive dependency for gabbi, anyway... | 13:08 |
| sdague | cdent: I remember seeing minidns spew a bunch in the past, and was always curious about getting it to stop that | 13:08 |
| cdent | sdague: I tried that, and what I found was there are few different tests where there are more than one dns manager (instance/floating ip) that are sharing the same data file | 13:09 |
| mriedem | TheJulia: np, take your time | 13:09 |
| cdent | sdague: and I didn’t have the horsepower to go digging to see if that could be changed | 13:09 |
| cdent | sdague: for most tests the in-memory thing is used | 13:10 |
| *** prateek has quit IRC | 13:10 | |
| *** acormier has joined #openstack-nova | 13:12 | |
| *** yamamoto has quit IRC | 13:12 | |
| *** thorst_afk is now known as thorst | 13:13 | |
| mriedem | TheJulia: found what i was looking for http://logs.openstack.org/49/485349/4/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial/376d4dd/console.html#_2017-07-25_04_37_15_094371 | 13:13 |
| TheJulia | mriedem: I do love how much faster test runs :) | 13:14 |
| mriedem | 4 minutes is faster? | 13:14 |
| TheJulia | this can cut a reboot out of the process of handing a ready machine off, so naturally much faster :) | 13:15 |
| mriedem | TheJulia: final questions when you get a moment are, i see some patches in flight on the ironic side, should we hold the nova change for those? or make the nova change depends-on them? | 13:16 |
| mriedem | like https://review.openstack.org/#/c/484032/5 | 13:16 |
| *** acormier has quit IRC | 13:16 | |
| *** randomhack has joined #openstack-nova | 13:17 | |
| *** mgiles has quit IRC | 13:19 | |
| dtantsur | if jlvillal agrees, we can merge it now, and address the tests issues in a follow-up | 13:19 |
| *** mgiles has joined #openstack-nova | 13:19 | |
| dtantsur | I suspect this is the only in-flight patch that matters | 13:20 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API https://review.openstack.org/486850 | 13:20 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from ``ip`` commands to ``pyroute2`` https://review.openstack.org/484386 | 13:21 |
| TheJulia | dtantsur: I already got agreement from him to do that last night :) | 13:22 |
| *** mmehan has joined #openstack-nova | 13:22 | |
| *** dikonoo has quit IRC | 13:23 | |
| TheJulia | dtantsur: well, agreement on the ironic patch :) | 13:23 |
| dtantsur | okie, let's wait for Sam's review, and Just Do It (tm) | 13:23 |
| *** acormier_ has joined #openstack-nova | 13:25 | |
| TheJulia | Excellent! | 13:26 |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 13:26 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optimize MiniDNS for fewer syscalls https://review.openstack.org/486829 | 13:26 |
| *** kylek3h has joined #openstack-nova | 13:26 | |
| *** smatzek has quit IRC | 13:29 | |
| *** acormier_ has quit IRC | 13:30 | |
| s-dean | Hi, dont wana be a pest, any of you guys able to help me for 2 seconds ? | 13:31 |
| *** baoli_ has joined #openstack-nova | 13:33 | |
| *** mamandle has joined #openstack-nova | 13:34 | |
| mriedem | dtantsur: TheJulia: so i'm hearing we're good to go on the nova change then | 13:34 |
| mriedem | if so, i will hassle mr dague | 13:34 |
| *** kristia__ has joined #openstack-nova | 13:34 | |
| *** baoli has quit IRC | 13:35 | |
| *** crushil has quit IRC | 13:35 | |
| *** kristian__ has quit IRC | 13:35 | |
| *** crushil has joined #openstack-nova | 13:35 | |
| jaypipes | bauzas: alloc_reqs_by_rp_uuid is a map of compute node UUID to list of allocation requests | 13:36 |
| dtantsur | yeah, I suspect so | 13:36 |
| dtantsur | the final word is for TheJulia though :) | 13:36 |
| TheJulia | I think so | 13:38 |
| *** alexchadin has quit IRC | 13:39 | |
| *** ratailor has quit IRC | 13:40 | |
| bauzas | jaypipes: sure, but what if the first compute node UUID is not corresponding to the first host from the ones given by get_sorted_hosts() ? | 13:40 |
| jaypipes | bauzas: it's a dict... | 13:41 |
| jaypipes | bauzas: not sure what you're asking, sorry... | 13:41 |
| bauzas | jaypipes: oh sorry, just saw edleafe's comment | 13:42 |
| bauzas | https://review.openstack.org/#/c/483566/10/nova/scheduler/filter_scheduler.py@202 | 13:42 |
| *** bkopilov_ has joined #openstack-nova | 13:42 | |
| bauzas | we're getting a list of allocation requests *per* compute node | 13:42 |
| * bauzas facepalms | 13:42 | |
| *** ansiwen[q] has joined #openstack-nova | 13:43 | |
| jaypipes | bauzas: right | 13:43 |
| sdague | mriedem: what's up now? | 13:43 |
| bauzas | jaypipes: I was confused by your TODO in https://review.openstack.org/#/c/483566/10/nova/scheduler/filter_scheduler.py@270 | 13:43 |
| edleafe | bauzas: don't feel bad - I had to read that over several times before it made sense to me, too | 13:43 |
| jaypipes | bauzas: that alloc_reqs_by_rp_uuid is a dict, keyed by compute node UUID, of allocation requests that contain that compute node | 13:44 |
| bauzas | jaypipes: so the same compute node could have more than one allocation request ? | 13:44 |
| bauzas | just tbc | 13:44 |
| edleafe | bauzas: there could be several allocs for a given compute node. The TODO is about being smarter about picking which one to use | 13:44 |
| bauzas | the real problem I had is that allocation_candidates just was discussed when I was in and out, and now I'm paying the price by giving you silly comments :/ | 13:44 |
| jaypipes | bauzas: yep. imagine in the future, nested r-p's there may be dozens of allocation requests that partially allocate resources on the compute node. | 13:44 |
| jaypipes | bauzas: same with things like shared storage | 13:45 |
| jaypipes | bauzas: not a problem, don't worry about it. | 13:45 |
| mriedem | sdague: https://review.openstack.org/#/c/215385/ | 13:45 |
| bauzas | jaypipes: ah, right | 13:45 |
| bauzas | nested RPs is understandable by me | 13:45 |
| bauzas | because you could consume more than one thing for a specific compute node | 13:46 |
| bauzas | ah, and I see your point with shared storage | 13:46 |
| jaypipes | bauzas: so, imagine a compute host with 2 NUMA nodes and 4 PCI devices, affined to the different NUMA cells. We might potentially have a lot of allocation requests (candidates) for those child providers plus resources on the compute host itself (like VCPU, etc) | 13:46 |
| *** rmart04 has quit IRC | 13:46 | |
| bauzas | we could potentially have the compute node having allocation request for local resources + shared resource ? | 13:46 |
| *** rmart04_ has joined #openstack-nova | 13:46 | |
| jaypipes | bauzas: yep | 13:46 |
| bauzas | jaypipes: that, I'm clear for nested RPs | 13:46 |
| bauzas | okay, nevermind all my comments then | 13:46 |
| bauzas | I'm on board now :) | 13:46 |
| jaypipes | bauzas: one alloc request might have local disk, another consuming from shared disk. | 13:46 |
| sdague | mriedem: ah, that one. Approved | 13:47 |
| jaypipes | bauzas: of course, that's not currently possible, but you see the idea | 13:47 |
| bauzas | jaypipes: thanks for explaning it | 13:47 |
| jaypipes | no worries | 13:47 |
| mriedem | dtantsur: TheJulia: what is the story on https://review.openstack.org/#/c/468353/ ? | 13:48 |
| mriedem | required for pike? | 13:48 |
| *** armax has joined #openstack-nova | 13:48 | |
| sdague | melwitt: https://bugs.launchpad.net/nova/+bug/1706310 that's addressed by your new quota counting? | 13:49 |
| openstack | Launchpad bug 1706310 in OpenStack Compute (nova) "Quota usage is not updated if an instance is deleted while booting" [Undecided,New] | 13:49 |
| dtantsur | mriedem: I think this is nice-to-have, but still optional | 13:49 |
| *** crushil has quit IRC | 13:49 | |
| dtantsur | I guess it may cause some longer discussions | 13:49 |
| TheJulia | mriedem: the consensus is not required this cycle, it just allows for greater use case flexibility ultimately shipping a source IP address off to cinder in the event there is firewalling present. | 13:49 |
| bauzas | jaypipes: +2d FTW | 13:50 |
| sdague | mriedem: that one is a little less straight forward, and honestly probably a good ptg conversation | 13:50 |
| sdague | it adds virt driver methods | 13:50 |
| mriedem | right i'd like to defer it | 13:50 |
| sdague | mriedem: agreed | 13:51 |
| TheJulia | sdague: good point | 13:51 |
| mriedem | as something else - ironic bfv + network-managed storage | 13:51 |
| *** ansiwen[q] has quit IRC | 13:51 | |
| jaypipes | edleafe: I can clean those nits up later. at this point, I'm nervous about kicking off another gate recheck odyssey ;) | 13:51 |
| cdent | jaypipes: you might like these then: https://review.openstack.org/#/c/486237/ | 13:52 |
| edleafe | jaypipes: totally agree | 13:52 |
| *** ansiwen[q] has joined #openstack-nova | 13:52 | |
| ildikov | mriedem: oh ok, tnx for the info :) | 13:52 |
| *** annegentle has joined #openstack-nova | 13:53 | |
| *** mgiles has quit IRC | 13:55 | |
| *** mgiles has joined #openstack-nova | 13:56 | |
| mriedem | sdague: about that quota bug, yes counting quotas would address that, but also, it could already be a known issue fixed in ocata, | 13:56 |
| mriedem | the reporter didn't say what version they were using | 13:56 |
| mriedem | i'm leaving comments | 13:56 |
| *** annegentle has quit IRC | 13:59 | |
| *** crushil has joined #openstack-nova | 13:59 | |
| *** ansiwen[q] has quit IRC | 14:00 | |
| *** dtantsur is now known as dtantsur|brb | 14:01 | |
| *** radish_ has joined #openstack-nova | 14:02 | |
| *** radish_ has left #openstack-nova | 14:02 | |
| *** smatzek has joined #openstack-nova | 14:04 | |
| *** smatzek has quit IRC | 14:05 | |
| *** smatzek has joined #openstack-nova | 14:05 | |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426 | 14:06 |
| *** mgiles_ has joined #openstack-nova | 14:09 | |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426 | 14:09 |
| *** awaugama has joined #openstack-nova | 14:09 | |
| *** FL1SK has joined #openstack-nova | 14:10 | |
| *** coreywright has quit IRC | 14:11 | |
| *** diga has quit IRC | 14:11 | |
| mriedem | sdague: the dependencies for the cells fleetify devstack change are all merged https://review.openstack.org/#/c/477556/ | 14:11 |
| mriedem | sdague: thoughts on putting that in right now? | 14:12 |
| *** mgiles has quit IRC | 14:12 | |
| mriedem | or, | 14:12 |
| mriedem | maybe i should run a novaclient change against it quick? | 14:12 |
| dansmith | damn the torpedos | 14:12 |
| mriedem | i think it blew up novaclient functional ci on the first go around | 14:12 |
| mriedem | b/c it wasn't dependent on the quotas stuff | 14:12 |
| mriedem | and that job is single tenant | 14:12 |
| *** acormier has joined #openstack-nova | 14:12 | |
| *** cdent has quit IRC | 14:12 | |
| mriedem | i'll push a novaclient test change quick just to be sure | 14:13 |
| dansmith | cool | 14:14 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: DNM: test conductor fleet with single-tenant job https://review.openstack.org/487091 | 14:15 |
| *** efoley has quit IRC | 14:15 | |
| *** efoley has joined #openstack-nova | 14:16 | |
| *** yamamoto has joined #openstack-nova | 14:17 | |
| *** mgiles_ has quit IRC | 14:20 | |
| *** mgiles has joined #openstack-nova | 14:20 | |
| *** mgiles has quit IRC | 14:22 | |
| *** rmart04_ has quit IRC | 14:22 | |
| *** mgiles has joined #openstack-nova | 14:23 | |
| *** coreywright has joined #openstack-nova | 14:23 | |
| *** mtanino has joined #openstack-nova | 14:24 | |
| *** yamamoto has quit IRC | 14:25 | |
| *** links has quit IRC | 14:26 | |
| *** mgiles has quit IRC | 14:29 | |
| *** mgiles has joined #openstack-nova | 14:29 | |
| *** claudiub has quit IRC | 14:30 | |
| *** marst has quit IRC | 14:32 | |
| *** eharney has quit IRC | 14:32 | |
| *** marst has joined #openstack-nova | 14:32 | |
| *** udesale has quit IRC | 14:33 | |
| *** mgiles has quit IRC | 14:36 | |
| *** mgiles has joined #openstack-nova | 14:36 | |
| *** lucasxu has quit IRC | 14:38 | |
| *** psachin has quit IRC | 14:40 | |
| *** marst has quit IRC | 14:41 | |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459 | 14:43 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Clean up second ephemeral disk https://review.openstack.org/341008 | 14:43 |
| *** marst has joined #openstack-nova | 14:45 | |
| *** jjung has quit IRC | 14:46 | |
| *** jjung_ has quit IRC | 14:46 | |
| *** eharney has joined #openstack-nova | 14:47 | |
| *** marst has quit IRC | 14:48 | |
| *** sree_ has joined #openstack-nova | 14:48 | |
| *** sree_ is now known as Guest35637 | 14:48 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: hardware offload support for openvswitch https://review.openstack.org/398265 | 14:49 |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459 | 14:51 |
| *** sree has quit IRC | 14:51 | |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459 | 14:52 |
| *** Guest35637 has quit IRC | 14:53 | |
| mriedem | jangutter: question in https://review.openstack.org/#/c/486426/3/nova/virt/libvirt/vif.py | 14:54 |
| *** sree has joined #openstack-nova | 14:54 | |
| jangutter | mriedem: let me see if the downstream code checks that. It hadn't occured to me to do input validation there! | 14:55 |
| mriedem | well, one would probably never think to check it if only testing against a single configuratoin | 14:56 |
| mriedem | *configuration | 14:56 |
| sdague | mriedem: we had to revert it once before right? | 14:56 |
| sdague | maybe an ironic issue | 14:56 |
| mriedem | sdague: yes, but for two issues, | 14:57 |
| mriedem | 1. notifications | 14:57 |
| sdague | if you all tell me it's good to go, I'm fine doing it | 14:57 |
| mriedem | 2. it didn't depent on the quotas change | 14:57 |
| mriedem | sdague: i'm just running tests before we do | 14:57 |
| sdague | sfinucan: https://bugs.launchpad.net/nova/+bug/1704458 that bug on your radar? | 14:57 |
| openstack | Launchpad bug 1704458 in OpenStack Compute (nova) "The use_ipv6 flag not only influences nova networking" [Undecided,New] | 14:57 |
| mriedem | sdague: sfinucan is now stephenfin and stephenfin is out this week | 14:58 |
| sdague | ok | 14:58 |
| dansmith | sdague: ironic and notification issues are fixed, and quotas are merged so those are the things we knew about and reverted for before | 14:58 |
| *** tylerderosagrund has joined #openstack-nova | 14:58 | |
| sdague | mriedem: ok, so run the test you want to run, then poke me when it's successful | 14:58 |
| moshele | mriedem: the generic is used in the old way https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L341-L343 so we can skip it for now | 14:58 |
| dansmith | ack, thanks | 14:58 |
| *** sree has quit IRC | 14:58 | |
| mriedem | moshele: what controls that getting called over the other? | 14:59 |
| mriedem | for VIFHostDevice? | 14:59 |
| moshele | mriedem: the vif type that send from neutron | 15:00 |
| jangutter | mriedem, moshele: VIFHostDevice isn't used anywhere _yet_, it's not too difficult to fix though. | 15:00 |
| moshele | mriedem: some code uses os-vif path, but most of it not | 15:00 |
| *** prateek has joined #openstack-nova | 15:00 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: nova.utils.get_service_url() https://review.openstack.org/458257 | 15:00 |
| jangutter | moshele, mriedem: it amounts to adding an if that will prevent future idiots like me to plonk in potholes. | 15:01 |
| mriedem | moshele: ok so a vif with type 'hostdev_physical' would go down that old path, but couldn't something on the neutron side start sending VIFHostDev with dev_type='generic'? | 15:01 |
| mriedem | jangutter: yes that's basically what i'm looking for | 15:01 |
| moshele | mriedem: the nova code create it | 15:02 |
| moshele | mriedem: let me look for it | 15:02 |
| mriedem | moshele: you mean this? https://review.openstack.org/#/c/483459/12/nova/network/os_vif_util.py | 15:02 |
| mriedem | L323 | 15:03 |
| moshele | mriedem: yes | 15:03 |
| jangutter | mriedem: good spot, I had forgotten "GENERIC" even existed. | 15:03 |
| *** eharney has quit IRC | 15:03 | |
| mriedem | ok, i guess we should at least have some if check that raises an exception if dev_type isn't 'ethernet' or something | 15:04 |
| moshele | mriedem: so either the vif type will work with the old way of get config or with the new os-vif | 15:04 |
| mriedem | so this doesn't fail in really weird ways | 15:04 |
| *** jamesdenton has quit IRC | 15:04 | |
| *** jamesden_ has joined #openstack-nova | 15:04 | |
| moshele | mriedem: we can and also a TODO comment to address generic when it will be use by os-vif | 15:05 |
| mriedem | sure | 15:06 |
| mriedem | just something so we don't have to hunt in the weeds later | 15:07 |
| *** sree has joined #openstack-nova | 15:07 | |
| mriedem | jangutter: ^ | 15:07 |
| *** mamandle has quit IRC | 15:07 | |
| jangutter | mriedem: isn't this verified as os-vif level? | 15:07 |
| jangutter | mriedem: https://github.com/openstack/os-vif/blob/master/os_vif/objects/fields.py#L61 | 15:08 |
| mriedem | sdague: dansmith: novaclient functional single tenant job passed on the fleetify conductor patch, i'm just waiting for some experimental queue jobs to pass on it now | 15:08 |
| mriedem | like cells v1 | 15:08 |
| mriedem | jangutter: that's not what i mean | 15:08 |
| mriedem | i meant in https://review.openstack.org/#/c/486426/3/nova/virt/libvirt/vif.py | 15:08 |
| *** baoli_ has quit IRC | 15:09 | |
| mriedem | if vif.dev_type != 'ethernet': raise some error, | 15:09 |
| dansmith | mriedem: swebster | 15:09 |
| dansmith | mriedem: er, sweet :) | 15:09 |
| mriedem | or just add a TODO as moshele said | 15:09 |
| jangutter | mriedem: aaah, but I'm almost done adding the GENERIC! (I think....) | 15:09 |
| mriedem | ok whatever floats your boat | 15:09 |
| *** lifeless has quit IRC | 15:09 | |
| mgiles | lyarwood: It looks like you were the last person working on https://review.openstack.org/#/c/389798 but it's been a couple of months with no activity | 15:10 |
| sdague | mriedem: sounds good | 15:10 |
| mgiles | lyarwood Any objection if I take this over and fix up the tests to work with the latest codebase? | 15:10 |
| mriedem | mgiles: just take it over, lyarwood is on nova sabbatical | 15:10 |
| jangutter | mriedem: GENERIC == designer.set_vif_host_backend_hostdev_pci_config | 15:10 |
| mgiles | mriedem thanks for the info | 15:11 |
| mriedem | jangutter: yeah just like this https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L341-L343 | 15:11 |
| mriedem | jangutter: that's easy then | 15:11 |
| jangutter | mriedem: more effort to write the comment than the code. | 15:11 |
| *** chyka has joined #openstack-nova | 15:12 | |
| *** mgiles has quit IRC | 15:15 | |
| *** mgiles has joined #openstack-nova | 15:15 | |
| *** tbachman has quit IRC | 15:16 | |
| *** yassine has quit IRC | 15:16 | |
| *** tbachman has joined #openstack-nova | 15:17 | |
| *** rcernin has quit IRC | 15:17 | |
| openstackgerrit | Merged openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385 | 15:18 |
| *** eharney has joined #openstack-nova | 15:19 | |
| *** moshele has quit IRC | 15:20 | |
| *** yamahata has joined #openstack-nova | 15:21 | |
| *** lifeless has joined #openstack-nova | 15:22 | |
| *** Drankis has quit IRC | 15:22 | |
| *** vishwanathj has joined #openstack-nova | 15:24 | |
| *** mgiles has quit IRC | 15:26 | |
| *** mgiles has joined #openstack-nova | 15:27 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Trim the fat from InstanceInfo https://review.openstack.org/471146 | 15:27 |
| *** sree has quit IRC | 15:27 | |
| *** sree has joined #openstack-nova | 15:28 | |
| *** smatzek has quit IRC | 15:29 | |
| *** lifeless has quit IRC | 15:29 | |
| *** smatzek has joined #openstack-nova | 15:30 | |
| *** marst has joined #openstack-nova | 15:30 | |
| *** felipemonteiro__ has joined #openstack-nova | 15:31 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use enum value instead of string service name https://review.openstack.org/476538 | 15:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: rename binary to source in versioned notifications https://review.openstack.org/487126 | 15:32 |
| *** andreas_s has quit IRC | 15:32 | |
| *** sree has quit IRC | 15:33 | |
| *** tylerderosagrund has quit IRC | 15:33 | |
| *** felipemonteiro_ has quit IRC | 15:34 | |
| *** jwcroppe has quit IRC | 15:34 | |
| *** tylerderosagrund has joined #openstack-nova | 15:35 | |
| *** lifeless has joined #openstack-nova | 15:36 | |
| *** vishwanathj has quit IRC | 15:36 | |
| *** baoli has joined #openstack-nova | 15:36 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use enum value instead of string service name https://review.openstack.org/476538 | 15:37 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: rename binary to source in versioned notifications https://review.openstack.org/487126 | 15:37 |
| *** vishwanathj has joined #openstack-nova | 15:37 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: deprecate ``wsgi_log_format`` config variable https://review.openstack.org/486623 | 15:38 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Suppress some test warnings https://review.openstack.org/486700 | 15:39 |
| mriedem | sdague: see my questions in https://review.openstack.org/#/c/486623/1/nova/conf/wsgi.py@54 ? | 15:39 |
| *** felipemonteiro__ has quit IRC | 15:39 | |
| openstackgerrit | Robert Ellis proposed openstack/nova master: Clarifying node_uuid usage in ironic driver. https://review.openstack.org/485803 | 15:42 |
| *** MVenesio has quit IRC | 15:42 | |
| *** annegentle has joined #openstack-nova | 15:45 | |
| *** belmoreira has quit IRC | 15:45 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667 | 15:47 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add snapshot id to the snapshot notifications https://review.openstack.org/453077 | 15:47 |
| openstackgerrit | Merged openstack/nova master: Make notification publisher_id consistent https://review.openstack.org/480984 | 15:48 |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | 15:51 |
| *** sshwarts has quit IRC | 15:53 | |
| *** damien_r has quit IRC | 15:54 | |
| jangutter | mriedem: I spoke completely too soon. It looks like implementing that second branch is going to cause a bit of a ripple effect. get_base_config creates an instance of LibvirtConfigGuestInterface, but to get the proper xml rendered we need it to be of class LibvirtConfigGuestHostdevPCI. | 15:55 |
| *** _pewp_ has quit IRC | 15:55 | |
| sdague | mriedem: commented | 15:55 |
| sdague | basically, I don't think it's useful to rollback to oslo.service, because the point is to remove oslo.service from nova-api | 15:55 |
| *** roeyc has quit IRC | 15:56 | |
| *** Apoorva has joined #openstack-nova | 15:57 | |
| *** baoli has quit IRC | 15:57 | |
| *** prateek_ has joined #openstack-nova | 15:57 | |
| *** jistr is now known as jistr|mtg | 15:58 | |
| *** smatzek has quit IRC | 15:58 | |
| *** _pewp_ has joined #openstack-nova | 15:58 | |
| *** prateek has quit IRC | 15:58 | |
| *** imacdonn_ has joined #openstack-nova | 15:59 | |
| jangutter | mriedem: So it looks like the xml renderer in config.LibvirtConfigGuestInterface needs to be extended to support generic devices (basically duping the functionality in LibvirtConfigGuestHostdevPCI) | 15:59 |
| *** smatzek has joined #openstack-nova | 15:59 | |
| *** rajathagasthya has joined #openstack-nova | 15:59 | |
| *** baoli has joined #openstack-nova | 15:59 | |
| *** edmondsw has quit IRC | 15:59 | |
| *** edmondsw has joined #openstack-nova | 16:00 | |
| *** imacdonn has quit IRC | 16:01 | |
| *** shaner_ has joined #openstack-nova | 16:03 | |
| *** edmondsw_ has joined #openstack-nova | 16:03 | |
| *** dr_gogeta86_ has joined #openstack-nova | 16:03 | |
| *** randomhack has quit IRC | 16:03 | |
| *** jwcroppe has joined #openstack-nova | 16:04 | |
| mriedem | sdague: makes sense | 16:04 |
| mriedem | jangutter: ok so let's not try to do that now | 16:04 |
| mriedem | just leave a todo or error or something | 16:04 |
| sdague | mriedem: https://review.openstack.org/#/c/486700/ also, just trying to clean up the test runs to make them easier to read | 16:04 |
| jangutter | mriedem: roger wilco. Not throwing an exception? | 16:04 |
| dansmith | sdague: so we're good on that right? | 16:05 |
| dansmith | sdague: the fleetify patch | 16:05 |
| *** edmondsw has quit IRC | 16:05 | |
| dansmith | sdague: the dependent job passed | 16:05 |
| mriedem | dansmith: sdague: i wanted to go through experimental queue job results | 16:05 |
| sdague | dansmith: mriedem was looking at some experimental bits as well | 16:05 |
| dansmith | oh okay I missed that | 16:05 |
| *** shaner has quit IRC | 16:06 | |
| *** dr_gogeta86 has quit IRC | 16:06 | |
| sdague | I am waiting on mriedem to say go, then I'll +A it. | 16:06 |
| *** edmondsw_ has quit IRC | 16:07 | |
| *** markmc has quit IRC | 16:07 | |
| *** FL1SK has quit IRC | 16:07 | |
| *** mamandle has joined #openstack-nova | 16:07 | |
| *** cburgess has quit IRC | 16:08 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: API ref: associate floating IP requires Active status https://review.openstack.org/363642 | 16:08 |
| *** markmc has joined #openstack-nova | 16:09 | |
| *** markus_z has quit IRC | 16:09 | |
| *** cburgess has joined #openstack-nova | 16:09 | |
| *** s1061123 has quit IRC | 16:10 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: API ref: associate floating IP requires Active status https://review.openstack.org/363642 | 16:11 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Post-migration, set cache value for Cinder volume(s) https://review.openstack.org/485752 | 16:11 |
| *** mamandle has quit IRC | 16:12 | |
| *** sridharg has quit IRC | 16:12 | |
| kashyap | mdbooth: or mriedem: When you get a sec, I fixed the "broken" unit tests the above change brings in. But I'm duking around adding the actual test for test_get_volume_config(), any suggestions welcome. | 16:13 |
| *** s1061123 has joined #openstack-nova | 16:13 | |
| kashyap | The core change is simple and does two things: | 16:14 |
| kashyap | (1) In libvirt/driver.py, call _set_cache_mode() from _get_volume_config() method so that libvirt will set disk cache value for Cinder volumes *after* migration. | 16:14 |
| *** lucasagomes is now known as lucas-hungry | 16:14 | |
| kashyap | (2) Remove duplicate calls to _set_cache_mode() in _get_guest_storage_config() and attach_volume() methods. | 16:14 |
| *** lucas-hungry is now known as lucas-afk | 16:14 | |
| *** rcernin has joined #openstack-nova | 16:14 | |
| kashyap | The reporter has tested the change and confirmed that it removes the perf regression (post migration) on the Cinder volume. | 16:15 |
| *** s1061123 has quit IRC | 16:16 | |
| *** oomichi has quit IRC | 16:16 | |
| *** edmondsw has joined #openstack-nova | 16:18 | |
| *** oomichi has joined #openstack-nova | 16:18 | |
| *** s1061123 has joined #openstack-nova | 16:19 | |
| *** jistr|mtg is now known as jistr | 16:19 | |
| openstackgerrit | Artem Tiumentcev proposed openstack/nova master: Add root and ephemeral disk quota https://review.openstack.org/484390 | 16:22 |
| *** edmondsw has quit IRC | 16:22 | |
| *** edmondsw has joined #openstack-nova | 16:24 | |
| *** dtp has joined #openstack-nova | 16:25 | |
| *** lucasxu has joined #openstack-nova | 16:26 | |
| *** lucasxu has quit IRC | 16:28 | |
| *** edmondsw has quit IRC | 16:28 | |
| *** rgerganov has quit IRC | 16:29 | |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426 | 16:29 |
| *** MikeG451 has quit IRC | 16:30 | |
| *** tobasco has quit IRC | 16:30 | |
| *** derekh has quit IRC | 16:30 | |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426 | 16:31 |
| *** cdent has joined #openstack-nova | 16:31 | |
| jangutter | mriedem: ^^ hope this one has the right idea. | 16:32 |
| *** annegentle has quit IRC | 16:32 | |
| *** mgiles has quit IRC | 16:34 | |
| *** mgiles has joined #openstack-nova | 16:35 | |
| *** rgerganov has joined #openstack-nova | 16:35 | |
| *** tobasco has joined #openstack-nova | 16:36 | |
| *** lyan has quit IRC | 16:38 | |
| *** mgiles has quit IRC | 16:41 | |
| *** mgiles has joined #openstack-nova | 16:42 | |
| *** jmlowe has quit IRC | 16:42 | |
| *** mgiles has quit IRC | 16:44 | |
| *** Swami has joined #openstack-nova | 16:44 | |
| *** mgiles has joined #openstack-nova | 16:45 | |
| *** mgiles has quit IRC | 16:47 | |
| *** mgiles has joined #openstack-nova | 16:47 | |
| *** mgiles has quit IRC | 16:49 | |
| *** mgiles has joined #openstack-nova | 16:50 | |
| mriedem | jbernard: dansmith: ceph job failed on the devstack fleetify change for an unrelated reason but fyi since it looks nasty http://logs.openstack.org/56/477556/5/experimental/gate-tempest-dsvm-py35-full-devstack-plugin-ceph-ubuntu-xenial-nv/6066e44/logs/screen-g-api.txt.gz?level=TRACE#_Jul_25_14_37_19_667434 | 16:51 |
| dansmith | eesh yeah | 16:52 |
| *** edmondsw has joined #openstack-nova | 16:52 | |
| *** mgiles has quit IRC | 16:54 | |
| *** lucasxu has joined #openstack-nova | 16:54 | |
| *** mgiles has joined #openstack-nova | 16:55 | |
| *** links has joined #openstack-nova | 16:55 | |
| *** edmondsw has quit IRC | 16:56 | |
| mriedem | maybe just a py35 thing | 16:57 |
| mriedem | maybe librados doesn't support py35 | 16:57 |
| dansmith | but we get that far only to find radios is None? | 16:58 |
| *** ralonsoh has quit IRC | 16:58 | |
| *** randomhack has joined #openstack-nova | 16:59 | |
| mriedem | yeah | 17:00 |
| mriedem | import error sets that rados package import to None | 17:00 |
| mriedem | https://github.com/openstack/glance_store/blob/0.21.0/glance_store/_drivers/rbd.py#L41 | 17:00 |
| mriedem | and rados isn't in the pip freeze output for py35 but it is for py27 | 17:00 |
| mriedem | https://bugs.launchpad.net/glance-store/+bug/1706405 | 17:00 |
| openstack | Launchpad bug 1706405 in glance_store "ceph jobs failing to upload images in pike due to "AttributeError: 'NoneType' object has no attribute 'Rados'" on py35" [Undecided,New] | 17:00 |
| mriedem | so this is just some py35 package install thing for librados | 17:00 |
| dansmith | no error log when we fail to import? | 17:01 |
| mriedem | eff no | 17:01 |
| mriedem | error logs are in the enterprise edition of glance-store | 17:01 |
| *** mgiles has quit IRC | 17:03 | |
| gibi | mriedem: hi! Do you have time to joint to the notification subteam meeting or we should simply skip that? I'm not against skipping it today. | 17:03 |
| *** mgiles has joined #openstack-nova | 17:04 | |
| sdague | mriedem: ok, how is your look on the experimental job? As I'm going to walk away from the computer for a bit shortly | 17:04 |
| *** annegentle has joined #openstack-nova | 17:04 | |
| openstackgerrit | Merged openstack/nova master: [placement] Use wsgi_intercept in PlacementFixture https://review.openstack.org/486237 | 17:05 |
| *** lyan has joined #openstack-nova | 17:05 | |
| mriedem | sdague: going through results | 17:06 |
| mriedem | but now in the notification meeting | 17:06 |
| mriedem | so you might as well walk | 17:06 |
| *** smatzek has quit IRC | 17:06 | |
| *** randomhack has quit IRC | 17:06 | |
| *** dtantsur|brb is now known as dtantsur | 17:09 | |
| *** mvk has quit IRC | 17:09 | |
| *** sambetts is now known as sambetts|afk | 17:10 | |
| *** MikeG451 has joined #openstack-nova | 17:12 | |
| jangutter | OK, this is a python newbie question (due to lack of caffeine)... Why would vif.get('ovs_interfaceid',"foobar") return None? ( https://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L281 ) | 17:12 |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 17:13 |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | 17:15 |
| edleafe | jangutter: if there is a key named 'ovs_interfaceid' and its value is None | 17:15 |
| edleafe | jangutter: it only returns the default param if the key isn't found | 17:15 |
| mriedem | jangutter: so do vif.get('ovs_interfaceid',"foobar") or 'foobar' | 17:17 |
| *** baoli has quit IRC | 17:17 | |
| jangutter | edleafe: yeah, that makes sense. That's why I see the pattern there. | 17:17 |
| *** baoli has joined #openstack-nova | 17:18 | |
| *** tbachman_ has joined #openstack-nova | 17:19 | |
| sdague | lyarwood: was there any progress on this bug - https://bugs.launchpad.net/nova/+bug/1640506 ? | 17:20 |
| openstack | Launchpad bug 1640506 in OpenStack Compute (nova) "Switch to os-brick encryptor provider implementations" [Wishlist,New] | 17:20 |
| *** tbachman has quit IRC | 17:20 | |
| *** tbachman_ is now known as tbachman | 17:20 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use wsgi-intercept in OSAPIFixture https://review.openstack.org/486825 | 17:20 |
| sdague | mriedem: ok, brain sufficiently fried, so walking away from computer now, but the number of bugs in new is down to 60 - https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New - so it's back on one page now | 17:21 |
| mriedem | yay | 17:22 |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459 | 17:22 |
| mriedem | dansmith: neutron dvr ha job is busted, but that's probably old news http://logs.openstack.org/56/477556/5/experimental/gate-tempest-dsvm-neutron-dvr-ha-multinode-full-ubuntu-xenial-nv/432c235/console.html#_2017-07-25_15_47_52_092840 | 17:23 |
| *** baoli has quit IRC | 17:23 | |
| *** mgiles has quit IRC | 17:26 | |
| *** cdent has quit IRC | 17:26 | |
| *** mgiles has joined #openstack-nova | 17:26 | |
| jaypipes | mriedem, dansmith: if you have a chance to review https://review.openstack.org/#/c/483566/ that would be great. (the final placemnet-claims one) | 17:28 |
| mriedem | jaypipes: yeah i was checking out the ci results before digging into the review | 17:28 |
| jaypipes | k | 17:28 |
| *** baoli has joined #openstack-nova | 17:28 | |
| mriedem | should be done this afternoon | 17:28 |
| *** david-lyle has quit IRC | 17:29 | |
| openstackgerrit | Robert Ellis proposed openstack/nova master: Clarifying node_uuid usage in ironic driver. https://review.openstack.org/485803 | 17:30 |
| *** links has quit IRC | 17:31 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications https://review.openstack.org/475276 | 17:31 |
| gibi | mriedem: rebased the update_at bugfix ^^ | 17:32 |
| gibi | mriedem: I mean I've rebased | 17:33 |
| mriedem | thanks | 17:33 |
| *** randomhack has joined #openstack-nova | 17:36 | |
| *** jwcroppe has quit IRC | 17:38 | |
| *** gszasz has quit IRC | 17:40 | |
| *** mvk has joined #openstack-nova | 17:41 | |
| openstackgerrit | Mark Giles proposed openstack/nova master: Do not attempt volume swap when guest is stopped/suspended https://review.openstack.org/389798 | 17:42 |
| *** yamahata has quit IRC | 17:43 | |
| *** mgiles has quit IRC | 17:46 | |
| *** mgiles has joined #openstack-nova | 17:47 | |
| *** jwcroppe has joined #openstack-nova | 17:48 | |
| *** moshele has joined #openstack-nova | 17:49 | |
| *** mgiles has quit IRC | 17:51 | |
| *** oomichi_ has joined #openstack-nova | 17:51 | |
| *** mgiles has joined #openstack-nova | 17:52 | |
| *** baoli has quit IRC | 17:52 | |
| *** oomichi has quit IRC | 17:52 | |
| *** oomichi_ is now known as oomichi | 17:52 | |
| *** harlowja has joined #openstack-nova | 17:55 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove the code related to extension loading from APIRouterV21 https://review.openstack.org/486414 | 17:58 |
| *** baoli has joined #openstack-nova | 17:58 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove the useless FakeExt https://review.openstack.org/486415 | 17:58 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove the useless extension block_device_mapping_v1 object https://review.openstack.org/486069 | 17:58 |
| *** annegentle has quit IRC | 17:59 | |
| ildikov | mriedem: I added a comment to the translation patch | 17:59 |
| ildikov | mriedem: I think the base for the confusion there is that the namings there are pretty confusing | 18:00 |
| oomichi | alex_xu: re: https://review.openstack.org/#/c/486414/ yeah, that is an important one. +2 | 18:00 |
| ildikov | mriedem: would that be fine to make that human readable or you want the structure change too? | 18:00 |
| *** andreaf has quit IRC | 18:01 | |
| *** david-lyle has joined #openstack-nova | 18:01 | |
| *** annegentle has joined #openstack-nova | 18:02 | |
| melwitt | sdague: yeah, that shouldn't be a thing with counting quotas in Pike. but maybe probably there needs to be a fix on stable only? I can't remember if we ever do that cc mriedem | 18:02 |
| mriedem | ildikov: i said in https://review.openstack.org/#/c/486194/2/nova/volume/cinder.py@218 that we should rename that data_keys variable to connection_info | 18:02 |
| mriedem | ildikov: however, _translate_attachment_ref doesn't return a connection_info dict | 18:02 |
| mriedem | it mangles the attachment dict, | 18:03 |
| mriedem | and adds a ['data'] key in it | 18:03 |
| mriedem | and shoves the attachment['connection_info'] stuff in there | 18:03 |
| mriedem | as far as i can tell | 18:03 |
| ildikov | as connection_info is a free form data structure having stuff under the 'data' key and 'driver_volume_type' on top level with it basically fulfills the criteria as far as I can tell | 18:04 |
| *** ansiwen[q] has joined #openstack-nova | 18:04 | |
| *** penick has joined #openstack-nova | 18:04 | |
| ildikov | but jgriffith is smarter than me on this front | 18:05 |
| *** eharney has quit IRC | 18:05 | |
| *** jmlowe has joined #openstack-nova | 18:05 | |
| mriedem | ewww yeah i don't like that | 18:06 |
| mriedem | and i just got now what it's doing | 18:06 |
| mriedem | it's the attachment ref PLUS all of the crap from the connection_info, mainlined into the attachment ref body resp | 18:06 |
| mriedem | that's super confusing and i don't think we should do that | 18:06 |
| mriedem | let's just translate the connection_info within the attachment ref as i said in there | 18:06 |
| ildikov | well, connection_info goes under 'data' as how it used to be before | 18:07 |
| *** Apoorva_ has joined #openstack-nova | 18:07 | |
| mriedem | thios https://review.openstack.org/#/c/486194/2/nova/volume/cinder.py@220 | 18:07 |
| *** FL1SK has joined #openstack-nova | 18:07 | |
| mriedem | *this | 18:07 |
| mriedem | yes i get that | 18:08 |
| mriedem | but it's also mangled into the attachment response body | 18:08 |
| mriedem | if the cinder API returns attachment: {connection_info: {'foo': 'bar'}} and now we turn that into attachment: {'data': {'foo': 'bar'}} that gets confusing | 18:09 |
| *** andreaf has joined #openstack-nova | 18:09 | |
| mriedem | i'd prefer to just see attachment: {connection_info: 'data': {{'foo': 'bar'}}} at the end | 18:10 |
| mriedem | well ^ is busted, but you know | 18:10 |
| *** Apoorva has quit IRC | 18:10 | |
| jangutter | mriedem, jaypipes: https://review.openstack.org/#/c/486426 got the checkmark from Jenkins.... but did I throw my first exception correctly? | 18:11 |
| *** ansiwen[q] has quit IRC | 18:11 | |
| mriedem | jangutter: omfg you don't throw anything! | 18:11 |
| mriedem | :P | 18:12 |
| jgriffith | mriedem ok, well this is why I dumped all that crap in the first place (which got us to that point) | 18:12 |
| mriedem | you RAISE! | 18:12 |
| jgriffith | mriedem the issue being that in my opinion that original return info was a confusing free form mess | 18:12 |
| jangutter | mriedem: what the heck? is this Poker or Python? | 18:12 |
| jgriffith | but then *we* decided we wanted to keep it consistent | 18:12 |
| mriedem | jangutter: seems ok | 18:12 |
| jgriffith | so that's why it's now stuffing in the way it is | 18:12 |
| mriedem | jgriffith: i'm fine if cinder 3.27 wanted to flatten the connection_info dict and drop the 'data' subkey | 18:13 |
| mriedem | but what i don't like is doing attachment_ref.update(attachment_ref.pop('connection_info', {})) basically | 18:14 |
| mriedem | sans the driver_volume_type key | 18:14 |
| mriedem | er attachment_ref.update(dict(data=attachment_ref.pop('connection_info', {}))) | 18:14 |
| ildikov | mriedem: the removal of the 'data' key on the Nova side is quite an amount of code line change apparently :( | 18:14 |
| mriedem | because then am i dealing with an attachment representation, or a connection_info, or some weird hybrid? | 18:14 |
| ildikov | mriedem: that's why we thought to do that at another time | 18:15 |
| *** ansiwen[q] has joined #openstack-nova | 18:15 | |
| mriedem | ildikov: yes it should be done another time | 18:15 |
| *** nikhil has quit IRC | 18:15 | |
| jgriffith | mriedem so wait... do you have a better idea on how to translate that other than popping it out into a new struct? | 18:15 |
| ildikov | mriedem: ok, at least one thing we agree at :) | 18:15 |
| *** yamahata has joined #openstack-nova | 18:18 | |
| mriedem | jgriffith: i'm fine with popping out the original one and writing it back into attachment_ref['connection_info'] | 18:18 |
| mriedem | i just don't want it munged into attachment_ref itself | 18:18 |
| mriedem | per https://review.openstack.org/#/c/486194/2/nova/volume/cinder.py@220 | 18:18 |
| jgriffith | mriedem that's reasonable | 18:18 |
| jgriffith | mriedem ildikov I think I see the problem here... | 18:20 |
| jgriffith | mriedem ildikov the attachment_create sadly returns a dict, while the attachment_update returns an attachment_ref object | 18:20 |
| *** eharney has joined #openstack-nova | 18:20 | |
| ildikov | jgriffith: don't we "play" with both? | 18:21 |
| jgriffith | ildikov I don't know what you mean, but regardless... | 18:21 |
| mriedem | jgriffith: yes the cinderclient code is confusing as well | 18:21 |
| ildikov | jgriffith: that we translate both after calling to_dict() | 18:21 |
| mriedem | ildikov: i think jgriffith is just talking about the cinderclient attachments code itself | 18:22 |
| jgriffith | ildikov yes | 18:22 |
| jgriffith | mriedem correct | 18:22 |
| mriedem | create returns an object and update returns a dict | 18:22 |
| mriedem | which i got wrong when i originally wrote the nova side code | 18:22 |
| jgriffith | mriedem ildikov and the comment in the review asks "This is a VolumeAttachment object, yes?" | 18:22 |
| jgriffith | I'm answering "no" | 18:22 |
| jgriffith | it's not | 18:22 |
| jgriffith | mriedem you had a 50/50 shot | 18:23 |
| jgriffith | which is sad | 18:23 |
| *** baoli has quit IRC | 18:23 | |
| mriedem | jangutter: small issues inline | 18:24 |
| *** avolkov` has joined #openstack-nova | 18:26 | |
| jangutter | mriedem: I'm running out of 80 characters!!! | 18:26 |
| ildikov | mriedem: jgriffith: ok, so we conclude to the format of: attachment_ref: {connection_info: {'data': {'foo': 'bar'}}} | 18:26 |
| mriedem | jangutter: drop a line | 18:27 |
| *** penick has quit IRC | 18:27 | |
| mriedem | ildikov: yes | 18:27 |
| ildikov | mriedem: jgriffith: I will upload an update hopefully soon | 18:27 |
| jgriffith | ildikov yeah; I think the whole point is to just make it a 1:1 mapping, I can put together the exact structures for you if you like? | 18:27 |
| *** avolkov has quit IRC | 18:27 | |
| ildikov | mriedem: another thing, there's a test failure in the attach patch, which I cannot figure out | 18:27 |
| jgriffith | ildikov I'm also happy to work on the patch if you want, but I'll send you a git-diff because I want nothing to do with your rebase magic :) | 18:28 |
| ildikov | mriedem: if you happen to have a view on what to do that that would be pretty great :) | 18:28 |
| *** fragatina has quit IRC | 18:28 | |
| ildikov | mriedem: otherwise I will duplicate a bit more code for now and optimize later when I learn Python a bit more... | 18:28 |
| ildikov | jgriffith: it's ok if only one of us is messing with rebase, I can do that :) | 18:29 |
| jgriffith | ildikov roger that | 18:29 |
| mriedem | ildikov: this http://logs.openstack.org/85/330285/104/check/gate-nova-tox-functional-ubuntu-xenial/231f3e5/testr_results.html.gz ? | 18:30 |
| ildikov | mriedem: yes | 18:31 |
| mriedem | TestInstanceNotificationSample is using the CinderFixture | 18:31 |
| ildikov | mriedem: it gets the service version mock and I have no idea why | 18:32 |
| ildikov | mriedem: here's the relevant change: https://review.openstack.org/#/c/330285/104/nova/tests/functional/notification_sample_tests/test_instance.py | 18:32 |
| *** baoli has joined #openstack-nova | 18:32 | |
| ildikov | mriedem: I created a new fixture for the new flow and had the TestInstanceNotificationSample class using that one | 18:33 |
| jangutter | mriedem: newbie question: I should check for the exception ... raised ... in the unit test, not trying to go check for the ideal output of the function? | 18:33 |
| ildikov | mriedem: and created another class which uses the old fixture and gets the mock for the service version to switch back to the old flow | 18:33 |
| mriedem | ildikov: we shouldn't have to mess with the notification sample tests at all | 18:33 |
| ildikov | mriedem: you mean then to duplicate them? | 18:33 |
| mriedem | ildikov: really we shouldn't have to mess with anything under nova/tests/functional | 18:33 |
| ildikov | mriedem: why not? | 18:33 |
| mriedem | leave nova/tests/functional for the old flows | 18:34 |
| mriedem | ildikov: we can test the new flows with unit tests | 18:34 |
| mriedem | jangutter: yes, basically the same as the test as you have except dev_type='generic' and then the test uses self.assertRaises | 18:34 |
| ildikov | mriedem: it works nicely except that one test, which I can figure out in another way which means more duplication though | 18:35 |
| jangutter | mriedem: roger | 18:35 |
| ildikov | mriedem: or I can just delete that part and leave the mocks only to switch back to the old flow, that works too | 18:35 |
| ildikov | mriedem: I guess we should run with that for now | 18:35 |
| mriedem | ildikov: sorry i'm in a meeting and doing a few things at once and i don't have all of your changes in my head right now, | 18:36 |
| mriedem | but in general, we shouldn't have to touch nova/tests/functional for the new stuff, | 18:36 |
| mriedem | since that is mostly all for api samples and notification samples, which are stubbing out cinder in specific ways for the old flows | 18:36 |
| mriedem | i mostly care about test coverage for the *new* flows using unit tests | 18:37 |
| mriedem | we can worry about changing the various fixtures and functional tests over when we actually drop the *old* flows | 18:37 |
| mriedem | which is not going to be anytime soon | 18:37 |
| ildikov | mriedem: I figured out the swap stuff already and the rest is simple, the test failure is a mock and inheritance issue, and has nothing to do with Cinder | 18:37 |
| ildikov | mriedem: but anyway, if you don't want changes there I will remove it and I will add mocks to the places which fails due to having the highest service version but no new Cinder calls available to switch back to the old flow and these tests in a follow up patch | 18:38 |
| ildikov | mriedem: anyway, sorry for eating up this much of your time, I will go and do the updates we agreed on and then we can check if there's anything else to fix | 18:39 |
| mriedem | ildikov: just leave the tests you have then in the api change, i can look into them at some point | 18:39 |
| ildikov | mriedem: ok | 18:40 |
| ildikov | mriedem: thanks | 18:40 |
| *** ansiwen[q] has quit IRC | 18:42 | |
| *** kristia__ has quit IRC | 18:43 | |
| *** kristian__ has joined #openstack-nova | 18:43 | |
| *** priteau_ has joined #openstack-nova | 18:44 | |
| *** markmcclain has quit IRC | 18:44 | |
| *** priteau has quit IRC | 18:45 | |
| *** dtantsur is now known as dtantsur|afk | 18:45 | |
| *** itlinux_ has joined #openstack-nova | 18:46 | |
| *** baoli has quit IRC | 18:47 | |
| *** baoli has joined #openstack-nova | 18:47 | |
| *** kristian__ has quit IRC | 18:48 | |
| *** markmcclain has joined #openstack-nova | 18:48 | |
| *** priteau_ has quit IRC | 18:48 | |
| sdague | melwitt: if you could comment on the bug, and move it to Fix Released, that would be cool | 18:50 |
| *** penick has joined #openstack-nova | 18:51 | |
| *** prateek_ has quit IRC | 18:51 | |
| *** fragatina has joined #openstack-nova | 18:51 | |
| *** baoli has quit IRC | 18:52 | |
| sdague | mriedem: back for a bit, you look through those results yet? | 18:53 |
| sdague | also, anyone, this is a pretty easy deprecation of a conf variable - https://review.openstack.org/#/c/486623/ | 18:53 |
| mriedem | sdague: melwitt: the quotas bug for ocata pointed out earlier is not necessarily fix released | 18:54 |
| mriedem | you can't backport counting quotas to ocata | 18:54 |
| mriedem | but the fix might already be available, which i pointd out in the bug report and marked it incomplete since they didn't provide the version | 18:54 |
| sdague | mriedem: sure, but fixed in master does count as fixed | 18:54 |
| sdague | then it's a backport question | 18:54 |
| *** jdillaman has quit IRC | 18:55 | |
| mriedem | it's incomplete either way at this point | 18:55 |
| sdague | but that doesn't make it not fixed | 18:55 |
| sdague | incomplete doesn't mean that | 18:55 |
| *** jdillaman has joined #openstack-nova | 18:55 | |
| *** phealy has quit IRC | 18:55 | |
| sdague | sure, as long as we're talking about incomplete just meaning "question back to reporter that needs an answer" | 18:55 |
| sdague | but if it's fixed in master, then I'd say it's probably correct to comment as such and put Fix Released on it | 18:56 |
| *** penick has quit IRC | 18:58 | |
| *** mgiles has quit IRC | 19:00 | |
| *** mgiles has joined #openstack-nova | 19:00 | |
| *** baoli has joined #openstack-nova | 19:02 | |
| *** claudiub has joined #openstack-nova | 19:04 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add oslo_concurrency=INFO to default log levels for nova-manage https://review.openstack.org/487179 | 19:07 |
| *** mgiles_ has joined #openstack-nova | 19:07 | |
| *** mgiles has quit IRC | 19:08 | |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426 | 19:09 |
| *** mgiles_ has quit IRC | 19:12 | |
| *** penick has joined #openstack-nova | 19:12 | |
| *** mgiles has joined #openstack-nova | 19:13 | |
| *** smatzek has joined #openstack-nova | 19:13 | |
| *** mgiles has quit IRC | 19:15 | |
| *** mgiles has joined #openstack-nova | 19:15 | |
| *** mgiles has quit IRC | 19:17 | |
| mriedem | sdague: dansmith: i've dumped my debug notes in https://review.openstack.org/#/c/477556/ | 19:18 |
| *** mgiles has joined #openstack-nova | 19:18 | |
| mriedem | we discover and map the compute node on the primary host as part of the devstack stack.sh run on the primary host, | 19:18 |
| mriedem | we discover and map the subnodes (2 of them) after the subnodes are stacked | 19:18 |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459 | 19:18 |
| mriedem | but it looks like when discover_hosts runs, we only discover and map the subnode-2, but miss subnode-3 | 19:18 |
| mriedem | so this might just be a latent issue in 3-node jobs | 19:19 |
| mriedem | but makes me wonder why we don't hit this more often in 2-node jobs | 19:19 |
| *** mgiles has quit IRC | 19:22 | |
| *** mgiles has joined #openstack-nova | 19:22 | |
| *** xyang1 has joined #openstack-nova | 19:22 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: [WIP] Add some more cellsv2 doc goodness https://review.openstack.org/487183 | 19:24 |
| *** randomhack has quit IRC | 19:25 | |
| dansmith | mriedem: okay I really hadn't done any 3 node thinking yet | 19:25 |
| mriedem | dansmith: as far as i can tell, the 3rd node is being setup the same as the 2nd node | 19:25 |
| dansmith | mriedem: are there actual production 3-node jobs that we'll break with this? | 19:26 |
| mriedem | i don't know if there are any 3 node voting jobs, but i can dig | 19:26 |
| dansmith | okay | 19:26 |
| mriedem | i think we're basically getting lucky in the 2 node jobs | 19:26 |
| openstackgerrit | Robert Ellis proposed openstack/nova master: Clarifying node_uuid usage in ironic driver. https://review.openstack.org/485803 | 19:26 |
| mriedem | for example, this is a normal 2 node job | 19:27 |
| mriedem | we discover subnode host here | 19:27 |
| mriedem | http://logs.openstack.org/66/483566/10/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/770b47e/console.html#_2017-07-24_16_27_34_062884 | 19:27 |
| dansmith | meaning we're getting the first subnode from the main node? | 19:27 |
| mriedem | 2017-07-24 16:27:34.062884 | + /opt/stack/new/devstack-gate/devstack-vm-gate.sh:main:L777: discover_hosts | 19:27 |
| mriedem | and that subnode compute node was actually created after that | 19:28 |
| mriedem | http://logs.openstack.org/66/483566/10/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/770b47e/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_24_16_27_35_403617 | 19:28 |
| mriedem | Jul 24 16:27:35.403617 ubuntu-xenial-2-node-osic-cloud1-disk-10046822-741313 nova-compute[1379]: INFO nova.compute.resource_tracker [None req-29fd1bd5-8730-42d5-8075-04acacfe704a None None] Compute node record created for ubuntu-xenial-2-node-osic-cloud1-disk-10046822-741313:ubuntu-xenial-2-node-osic-cloud1-disk-10046822-741313 with uuid: d09dec50-566e-41ea-adde-7ff566b63867 | 19:28 |
| mriedem | dansmith: yes the first compute node comes from the primary | 19:28 |
| mriedem | the compute node on the primary host gets discovered as part of the primary host setup https://github.com/openstack-dev/devstack/blob/master/stack.sh#L1448 | 19:28 |
| dansmith | okay | 19:28 |
| mriedem | so our docs say | 19:29 |
| mriedem | "Configure and start your compute hosts. Before step 7, make sure you have compute hosts in the database by running nova service-list --binary nova-compute." | 19:29 |
| mriedem | step 7 is running discover_hosts | 19:29 |
| mriedem | so, | 19:29 |
| mriedem | what we should really probably be doing is passing a variable down from devstack-gate to the tools/discover_hosts.sh script in devstack telling it how many hosts we expect to show up | 19:30 |
| mriedem | before doing discovery | 19:30 |
| dansmith | I thought we were specifically not supposed to do that? | 19:30 |
| dansmith | like, I thought we had an argument about that | 19:30 |
| mriedem | well, if you've got a slow subnode then i'm not sure what the other options are | 19:31 |
| mriedem | we have the periodic task, but that's still a race window | 19:31 |
| dansmith | agreed, I just thought we were told not to | 19:31 |
| mriedem | dansmith: isn't it fun we're having the same conversation we had almost exactly 6 months ago?! | 19:32 |
| mriedem | except i was in cabo san lucas at that time, which was more fun | 19:32 |
| * dansmith isn't amused | 19:32 | |
| mriedem | so, i dont think this is a problem in your fleetify change which is the key point | 19:33 |
| *** rajathagasthya has quit IRC | 19:33 | |
| mriedem | it's just a latent thing we aren't handling well in our infra | 19:34 |
| dansmith | mriedem: do these graphs do anything for you? http://docs-draft.openstack.org/83/487183/1/check/gate-nova-docs-ubuntu-xenial/ef53873//doc/build/html/user/cellsv2_layout.html | 19:34 |
| dansmith | mostly the second one | 19:34 |
| dansmith | okay | 19:34 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Translate the return value of attachment_create and _update https://review.openstack.org/486194 | 19:34 |
| *** gbarros has joined #openstack-nova | 19:34 | |
| mriedem | dansmith: looks pretty good | 19:35 |
| mriedem | the first graph is kind of a webby mess | 19:35 |
| dansmith | wish I could fix a few visual aberrations on it, but it took a lot of screwing around to make it look this good | 19:35 |
| dansmith | I spent less time on the first one I can muck some more | 19:36 |
| *** phealy has joined #openstack-nova | 19:37 | |
| *** fragatin_ has joined #openstack-nova | 19:38 | |
| sdague | mriedem: ok, so have you confirmed if the 3 node is voting yet? | 19:40 |
| openstackgerrit | Moshe Levi proposed openstack/nova master: hardware offload support for openvswitch https://review.openstack.org/398265 | 19:40 |
| sdague | mriedem: I thought we were doing discover hosts at the end of the d-g run? | 19:40 |
| *** fragatina has quit IRC | 19:41 | |
| *** pchavva has quit IRC | 19:41 | |
| mriedem | sdague: we are, | 19:41 |
| mriedem | but the compute node getting created is asynchronous to that | 19:42 |
| mriedem | the 3-node job could be slowing down the controller services just enough to hit the latent window | 19:42 |
| sdague | because the startup of nova-compute takes that long? | 19:42 |
| *** claudiub has quit IRC | 19:42 | |
| *** cdent has joined #openstack-nova | 19:43 | |
| *** gbarros has quit IRC | 19:43 | |
| sdague | so the race is that nova-compute service start doesn't make it to the db before discover hosts runs? | 19:43 |
| *** phealy has quit IRC | 19:43 | |
| mriedem | yes | 19:44 |
| mriedem | +1 on https://review.openstack.org/#/c/477556/ and my debug notes are all in there | 19:45 |
| sdague | so... related, what's the deal with the stack trace here - http://logs.openstack.org/56/477556/5/experimental/gate-tempest-dsvm-neutron-dvr-ha-multinode-full-ubuntu-xenial-nv/432c235/logs/subnode-3/screen-n-cpu.txt.gz#_Jul_25_15_06_55_309283 | 19:46 |
| mriedem | that's the thing where the libvirt starts up and tries to enable itself | 19:47 |
| sdague | ok, so we're going to stacktrace on every clean start | 19:47 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3563 | 19:48 |
| mriedem | sdague: that's been around | 19:48 |
| mriedem | it's not a result of this change | 19:48 |
| *** annegentle has quit IRC | 19:48 | |
| sdague | mriedem: sure | 19:48 |
| sdague | it's just not good | 19:48 |
| mriedem | yeah, i don't like it either | 19:48 |
| sdague | ok, http://logs.openstack.org/56/477556/5/experimental/gate-tempest-dsvm-neutron-dvr-ha-multinode-full-ubuntu-xenial-nv/432c235/logs/subnode-3/screen-n-cpu.txt.gz#_Jul_25_15_07_02_323379 is where the compute node is built, that's about 7 seconds later | 19:48 |
| mriedem | yes | 19:48 |
| mriedem | i'm not sure why these stacktrace | 19:49 |
| mriedem | i guess because of https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3567 ? | 19:50 |
| *** annegentle has joined #openstack-nova | 19:50 | |
| mriedem | so it hits the generic Exception block as ComputeHostNotFound_Remote? | 19:50 |
| openstackgerrit | Dan Smith proposed openstack/nova master: [WIP] Add some more cellsv2 doc goodness https://review.openstack.org/487183 | 19:50 |
| *** nicolasbock has quit IRC | 19:52 | |
| sdague | mriedem: yeh | 19:52 |
| *** mtreinish has quit IRC | 19:55 | |
| *** mgiles has quit IRC | 19:58 | |
| *** mgiles has joined #openstack-nova | 19:58 | |
| *** phealy has joined #openstack-nova | 19:59 | |
| sdague | mriedem: do we have a way of telling that nova-compute is ready. Is that resource tracker at 07_02 the event we need? | 19:59 |
| *** kristian__ has joined #openstack-nova | 20:00 | |
| openstackgerrit | Merged openstack/nova master: API ref: associate floating IP requires Active status https://review.openstack.org/363642 | 20:00 |
| sdague | I'm trying to think about who should wait for what to get us there. Is there something we could tell from the subnode easily about it being ready so we knew we were in the clear when stack.sh finished? | 20:00 |
| mriedem | sdague: our docs tell you to run 'nova service-list --binary nova-compute' and make sure the compute shows up before you run discover_hosts | 20:01 |
| *** Apoorva_ has quit IRC | 20:02 | |
| mriedem | because that API iterates all cells and gathers up the services running in them | 20:02 |
| mriedem | so the host mapping isn't required for that | 20:02 |
| *** Apoorva has joined #openstack-nova | 20:03 | |
| sdague | so we could put a flag in to wait for compute | 20:03 |
| sdague | and run: nova service-list --host `hostname` --binary nova-compute | 20:03 |
| sdague | on the child until it is true? | 20:03 |
| *** kristian__ has quit IRC | 20:05 | |
| *** mgiles has quit IRC | 20:07 | |
| *** mgiles has joined #openstack-nova | 20:07 | |
| dansmith | not on the child, on the main node | 20:08 |
| *** cdent has quit IRC | 20:08 | |
| mriedem | right we run discover_hosts from the primary | 20:08 |
| mriedem | b/c it needs to get to the api db to find the cell mappings | 20:08 |
| mriedem | and the compute nodes don't have access to that | 20:08 |
| dansmith | well and you need the main node to do the waiting | 20:09 |
| dansmith | because it's going to run tests that need to wait until all the nodes are up | 20:09 |
| *** phealy has quit IRC | 20:09 | |
| *** priteau has joined #openstack-nova | 20:09 | |
| *** armax has quit IRC | 20:10 | |
| *** fragatin_ has quit IRC | 20:10 | |
| mriedem | this is what i see for the 'host is not mapped to any cell' failures in voting jobs | 20:10 |
| *** mtreinish has joined #openstack-nova | 20:10 | |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Host%5C%22%20AND%20message%3A%5C%22is%20not%20mapped%20to%20any%20cell%5C%22%20AND%20tags%3A%5C%22console%5C%22%20AND%20voting%3A1%20AND%20build_status%3A%5C%22FAILURE%5C%22&from=7d | 20:10 |
| *** cdent has joined #openstack-nova | 20:10 | |
| mriedem | they are all grenade multinode jobs | 20:11 |
| *** fragatina has joined #openstack-nova | 20:11 | |
| *** fragatina has quit IRC | 20:11 | |
| *** fragatina has joined #openstack-nova | 20:12 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add some more cellsv2 doc goodness https://review.openstack.org/487183 | 20:12 |
| *** mgiles has quit IRC | 20:16 | |
| *** mgiles has joined #openstack-nova | 20:16 | |
| *** kristian__ has joined #openstack-nova | 20:17 | |
| *** mgiles has quit IRC | 20:21 | |
| *** mgiles has joined #openstack-nova | 20:21 | |
| *** mgiles has quit IRC | 20:23 | |
| *** mgiles has joined #openstack-nova | 20:24 | |
| sdague | dansmith: if the child doesn't return until n-cpu has checked in, that also works, right? | 20:26 |
| sdague | basically make stack.sh synchronous on nova-compute being up | 20:26 |
| *** cfriesen has quit IRC | 20:27 | |
| dansmith | sdague: by child you mean the subnode right? | 20:27 |
| *** oomichi has quit IRC | 20:28 | |
| *** oomichi has joined #openstack-nova | 20:28 | |
| *** mgiles has quit IRC | 20:30 | |
| *** mgiles has joined #openstack-nova | 20:31 | |
| *** mgiles has quit IRC | 20:31 | |
| mriedem | right so there are two places you could do that in the ComputeManager, | 20:32 |
| *** kristian__ has quit IRC | 20:32 | |
| mriedem | 1. init_host() | 20:32 |
| mriedem | 2. pre_start_hook() | 20:32 |
| mriedem | the latter already tries to get the compute node | 20:32 |
| mriedem | *post_start_hook() i mean | 20:32 |
| *** moshele has quit IRC | 20:32 | |
| mriedem | damn, sorry, no i meant pre_start_hook | 20:33 |
| mriedem | i did think that pre_start_hook should do it | 20:33 |
| mriedem | because it calls update_available_resource_for_node | 20:34 |
| mriedem | which calls rt.update_available_resource | 20:34 |
| mriedem | which should then do the init compute node stuff | 20:34 |
| sdague | dansmith: yeh | 20:34 |
| mriedem | so i'm not entirely sure why that doesn't happen in the pre_start_hook phase | 20:34 |
| sdague | mriedem: are you sure it didn't? | 20:35 |
| *** phealy has joined #openstack-nova | 20:36 | |
| mriedem | i'm not sure no | 20:37 |
| mriedem | i can dig | 20:37 |
| mriedem | my shovel is going to be pretty gd blunt after the end of this day | 20:38 |
| sdague | mriedem: I was assuming that virt driver init host just took that long to start | 20:38 |
| *** rajathagasthya has joined #openstack-nova | 20:38 | |
| mriedem | the virt driver init_host doesn't do much | 20:38 |
| mriedem | at least for the libvirt driver, it registers event listeners and connects to libvirt | 20:38 |
| mriedem | ok so this is a subnode starting up | 20:39 |
| mriedem | http://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_42_125360 | 20:39 |
| mriedem | Jul 25 19:30:42.125360 ubuntu-xenial-2-node-osic-cloud1-disk-10073644-745537 nova-compute[711]: INFO nova.service [-] Starting compute node (version 16.0.0) | 20:39 |
| mriedem | that's in nova.service.Service.start() | 20:39 |
| mriedem | then you see the libvirt event stuff | 20:40 |
| *** edmondsw has joined #openstack-nova | 20:40 | |
| *** crushil has quit IRC | 20:41 | |
| *** randomhack has joined #openstack-nova | 20:41 | |
| mriedem | then you see this from the libvirt driver http://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_42_150823 | 20:41 |
| mriedem | because the compute node doesn't exist yet | 20:41 |
| mriedem | then you see this in the compute manager http://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_44_394800 | 20:41 |
| mriedem | which is from _get_compute_nodes_in_db | 20:41 |
| mriedem | i'm not sure why that traces | 20:43 |
| mriedem | that warning is here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6627 | 20:43 |
| *** randomhack has quit IRC | 20:45 | |
| *** armax has joined #openstack-nova | 20:47 | |
| mriedem | anyway then we call the resource tracker https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6602 | 20:47 |
| mriedem | http://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_44_399281 | 20:47 |
| mriedem | Jul 25 19:30:44.399281 ubuntu-xenial-2-node-osic-cloud1-disk-10073644-745537 nova-compute[711]: DEBUG nova.compute.resource_tracker [None req-9286123e-31d0-45c4-a951-fe1e3947db00 None None] Auditing locally available compute resources for ubuntu-xenial-2-node-osic-cloud1-disk-10073644-745537 (node: ubuntu-xenial-2-node-osic-cloud1-disk-10073644-745537) {{(pid=711) update_available_resource /opt/stack/new/nova/nova/compute/res | 20:47 |
| mriedem | e_tracker.py:609}} | 20:47 |
| *** cfriesen has joined #openstack-nova | 20:47 | |
| *** priteau has quit IRC | 20:48 | |
| mriedem | then we should get in here https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L488 | 20:49 |
| mriedem | and we'll hit this https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L709 | 20:50 |
| mriedem | http://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_44_441734 | 20:50 |
| *** crushil has joined #openstack-nova | 20:51 | |
| mriedem | and so we'll create the compute node record here https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L531 | 20:51 |
| mriedem | http://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_44_459686 | 20:51 |
| mriedem | sdague: but does systemd wait or does it just launch off the service start and not block on it? | 20:52 |
| sdague | mriedem: define wait | 20:52 |
| sdague | mriedem: we're starting in the foreground, it's tracking the parent process, but the issue is it's much later that things are ready | 20:55 |
| sdague | anyway, I need to work on dinner, I've got this half assed patch running locally, if it works I'll push it | 20:56 |
| mriedem | right when we start the n-cpu service, and the service is launched, that's all async | 20:56 |
| sdague | mriedem: it's not async | 20:56 |
| jangutter | mriedem, jaypipes: should I assert on exception.NovaException or exception.InternalError at https://review.openstack.org/#/c/486426/6/nova/tests/unit/virt/libvirt/test_vif.py@1616 | 20:56 |
| sdague | it's that it's not ready for 25 - 30 seconds after start | 20:56 |
| sdague | and, there is no /health to know that | 20:57 |
| sdague | we poll api processes that we start to know they are ready before we move on | 20:57 |
| *** jmlowe has quit IRC | 20:57 | |
| sdague | but there isn't a direct interface for that | 20:57 |
| mriedem | right i meant https://github.com/openstack/nova/blob/master/nova/service.py#L138 | 20:57 |
| *** tylerderosagrund has quit IRC | 20:57 | |
| mriedem | which is what calls compute manager pre_start_hook that sets this all up | 20:57 |
| *** smatzek has quit IRC | 20:57 | |
| sdague | mriedem: ok, before I leave, I want to make sure we get this question clear :) | 20:58 |
| sdague | systemd is starting things, and it's running as parent process as soon as python exec happens | 20:58 |
| *** cdent has quit IRC | 20:58 | |
| mriedem | i guess i was thinking about like sysv init scripts and services, | 20:59 |
| mriedem | where you can run service nova-compute status | 20:59 |
| mriedem | and see if it's started or not | 20:59 |
| sdague | sure, but all that tells you is if the process is running | 20:59 |
| sdague | the process is running | 20:59 |
| sdague | eventually the process is ready | 20:59 |
| mriedem | but can't the start routine block until it's actually started or crashed? | 20:59 |
| sdague | it is started | 20:59 |
| sdague | the process is running | 20:59 |
| *** priteau has joined #openstack-nova | 20:59 | |
| sdague | how does anything external know if a process is ready other than pid existing? | 21:00 |
| mriedem | ok, well this is all latent stuff and shouldn't block https://review.openstack.org/#/c/477556/ | 21:00 |
| mriedem | so can we get that in? | 21:00 |
| mriedem | like, this behavior goes back to ocata | 21:00 |
| sdague | https://www.freedesktop.org/software/systemd/man/systemd-notify.html if you want deeper state interaction between process and systemd | 21:01 |
| *** awaugama has quit IRC | 21:01 | |
| sdague | mriedem: the neutron folks are currently borked? | 21:01 |
| mriedem | no | 21:01 |
| *** gouthamr has quit IRC | 21:01 | |
| mriedem | the dvr-ha multinode job is non-voting and in the experimental queue | 21:01 |
| sdague | ok | 21:01 |
| mriedem | i've already talked to haleyb about it | 21:01 |
| sdague | if they are cool with it, that's fine | 21:02 |
| sdague | I'll try to get this wait call in place | 21:02 |
| sdague | I just appoved the fleet patch | 21:02 |
| mriedem | ok | 21:03 |
| sdague | this other thing takes a while to run, so off for the night, we'll see what it looks like in the morning | 21:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove redundant free_vcpus logging in _report_hypervisor_resource_view https://review.openstack.org/487216 | 21:06 |
| *** yamamoto_ has joined #openstack-nova | 21:07 | |
| *** lucasxu has quit IRC | 21:09 | |
| jangutter | mriedem, jaypipes: should I assert on exception.NovaException or exception.InternalError at https://review.openstack.org/#/c/486426/6/nova/tests/unit/virt/libvirt/test_vif.py@1616 | 21:11 |
| *** catintheroof has quit IRC | 21:11 | |
| *** jotr has quit IRC | 21:11 | |
| *** jmlowe has joined #openstack-nova | 21:13 | |
| *** priteau has quit IRC | 21:13 | |
| mriedem | internal error | 21:14 |
| *** jotr has joined #openstack-nova | 21:14 | |
| mriedem | you should assert the thing being raised | 21:14 |
| *** efoley has quit IRC | 21:14 | |
| jangutter | roger, tightening the noose. | 21:14 |
| mriedem | try/catch Throwable | 21:14 |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426 | 21:15 |
| jaypipes | mriedem: raisable. :P | 21:17 |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement https://review.openstack.org/483459 | 21:22 |
| *** gouthamr has joined #openstack-nova | 21:23 | |
| mriedem | dansmith: fyi about fleet week to the dev list | 21:26 |
| mriedem | sent | 21:26 |
| *** annegentle has quit IRC | 21:27 | |
| dansmith | mriedem: ack, I'll read when I return in a bit | 21:28 |
| *** eharney has quit IRC | 21:28 | |
| *** esberglu has quit IRC | 21:31 | |
| *** baoli has quit IRC | 21:34 | |
| mriedem | jaypipes: your claims in the scheduler change | 21:35 |
| mriedem | the ironic nv job failed on a scheduling novalidhost | 21:35 |
| mriedem | http://logs.openstack.org/66/483566/10/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/3a475d1/logs/screen-n-sch.txt.gz#_Jul_24_16_26_25_372045 | 21:35 |
| mriedem | Jul 24 16:26:25.372045 ubuntu-xenial-osic-cloud1-disk-10046831 nova-scheduler[11679]: DEBUG nova.scheduler.filter_scheduler [None req-76fb384b-64f6-4ed7-86fd-dbb616497e43 tempest-BaremetalBasicOps-2030059131 tempest-BaremetalBasicOps-2030059131] Found host state None that wasn't in allocation requests. Skipping. {{(pid=11679) _schedule /opt/stack/new/nova/nova/scheduler/filter_scheduler.py:196}} | 21:35 |
| mriedem | aha | 21:38 |
| mriedem | YES! | 21:38 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 21:40 |
| *** mtreinish has quit IRC | 21:42 | |
| ildikov | mriedem: I fixed the translate patch and the attach patch too should have a clean test run now | 21:43 |
| *** penick has quit IRC | 21:44 | |
| ildikov | mriedem: let me know if there's anything else I should do | 21:44 |
| ildikov | mriedem: tnx | 21:44 |
| *** esberglu has joined #openstack-nova | 21:45 | |
| *** mtreinish has joined #openstack-nova | 21:46 | |
| *** rtjure has joined #openstack-nova | 21:47 | |
| *** Apoorva_ has joined #openstack-nova | 21:51 | |
| *** annegentle has joined #openstack-nova | 21:52 | |
| *** rtjure has quit IRC | 21:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566 | 21:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set IronicNodeState.uuid in _update_from_compute_node https://review.openstack.org/487227 | 21:53 |
| mriedem | jaypipes: ^ | 21:53 |
| *** Apoorva has quit IRC | 21:54 | |
| *** avolkov` has quit IRC | 21:54 | |
| *** penick has joined #openstack-nova | 21:57 | |
| *** gouthamr has quit IRC | 21:58 | |
| *** jackie-truong has joined #openstack-nova | 22:01 | |
| jackie-truong | Hi @dansmith, are you available? I have some questions on nova/objects/instance.py that I think you can answer | 22:04 |
| dansmith | jackie-truong: for a few minutes yeah | 22:04 |
| *** yamamoto_ has quit IRC | 22:05 | |
| jackie-truong | dansmith: I'm helping out with this patch https://review.openstack.org/#/c/457711/ | 22:05 |
| jackie-truong | dansmith: And we're having some issues with properly initializing the list of strings (trusted_certs) so that it is actually an Instance field | 22:06 |
| dansmith | jackie-truong: well, it's defined as a field, which means it's actually a field, but go on... | 22:07 |
| jackie-truong | We're seeing the error "Instance object has no attribute 'trusted_cert'" | 22:07 |
| dansmith | jackie-truong: well, it's defined as "trusted_certs" (note the plural), so maybe that's why? | 22:08 |
| jackie-truong | dansmith: Sorry, that was a typo on my part | 22:08 |
| *** xyang1 has quit IRC | 22:08 | |
| jackie-truong | "Instance object has no attribute 'trusted_certs' " | 22:08 |
| dansmith | damn, thought that was going to be quick :P | 22:08 |
| jackie-truong | dansmith: lol | 22:09 |
| dansmith | well, I'd need to see where/how it's used then I guess, | 22:09 |
| jackie-truong | dansmith: If you need to head out, I can hop on later this week | 22:09 |
| *** yamamoto has joined #openstack-nova | 22:09 | |
| jackie-truong | dansmith: We thought this would be sufficient: "instance['trusted_certs'] = db_inst['trusted_certs']" | 22:09 |
| dansmith | but you really shouldn't get an AttributeError the way you have it defined here | 22:09 |
| dansmith | L457? | 22:09 |
| *** acormier has quit IRC | 22:09 | |
| jackie-truong | dansmith: Yes, L457 | 22:10 |
| dansmith | db_inst is an "Instance" as well although it's from the model.. maybe it's actually complaining about that one? | 22:10 |
| jackie-truong | dansmith: Would we need to add some lines to load the trusted_certs attribute in obj_load_attr? | 22:10 |
| dansmith | jackie-truong: I don't see trusted_certs on the db model | 22:11 |
| dansmith | so I expect that's the problem. is there some other patch that is supposed to be under this? | 22:11 |
| jackie-truong | Yes, this is part of the Nova certificate validation blueprint https://blueprints.launchpad.net/openstack/?searchtext=nova-validate-certificates | 22:12 |
| *** kylek3h has quit IRC | 22:12 | |
| jackie-truong | dansmith: But no, we didn't add anything to nova/db/sqlalchemy/models.py | 22:12 |
| dansmith | jackie-truong: well, uh, where do you think it's getting stored then? :P | 22:13 |
| jackie-truong | Good point >< | 22:13 |
| dansmith | jackie-truong: but yeah, I bet that's what you're hitting | 22:13 |
| jackie-truong | Cool, thanks! So there's no need to add anything to instance.py's obj_load_attr? | 22:13 |
| jackie-truong | In other words, once we put trusted_certs in the db models, then L457 should be good? | 22:14 |
| dansmith | L457 will be yeah.. you only need obj_load_attr() changes if you want to be able to lazy-load this field, which I think I said on that review a while back | 22:15 |
| dansmith | you'll need a sql migration to add the column, then support on the model, then this patch and it should load | 22:15 |
| dansmith | although a list is a list, not a column, so you need to figure out how you're going to store that and bring it in as a list of things, but I'm sure you know that | 22:16 |
| jackie-truong | Got it. Thanks a lot, dansmith! | 22:16 |
| *** rtjure has joined #openstack-nova | 22:17 | |
| *** cfriesen has quit IRC | 22:20 | |
| openstackgerrit | Vipin Balachandran proposed openstack/nova master: VMware:Use power_state const for power state check https://review.openstack.org/483122 | 22:24 |
| dansmith | jackie-truong: np | 22:26 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229 | 22:38 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: First attempt at adding a privsep user to nova itself. https://review.openstack.org/459166 | 22:38 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt https://review.openstack.org/472228 | 22:38 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py https://review.openstack.org/485907 | 22:38 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep. https://review.openstack.org/471972 | 22:38 |
| openstackgerrit | Tony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files https://review.openstack.org/486831 | 22:38 |
| *** marst has quit IRC | 22:40 | |
| *** mtanino has quit IRC | 22:41 | |
| openstackgerrit | Nicolas Simonds proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997 | 22:43 |
| *** annegentle has quit IRC | 22:49 | |
| *** xinliang has quit IRC | 22:56 | |
| *** yassine has joined #openstack-nova | 22:56 | |
| *** rcernin has quit IRC | 22:58 | |
| jaypipes | mriedem: sorry, was out back mowing the dirt patch... | 23:00 |
| jaypipes | mriedem: what did you find? | 23:00 |
| jaypipes | mriedem: ah, I read the comments on the patch. nice catch, and thank you sir. | 23:01 |
| *** rajathagasthya has quit IRC | 23:05 | |
| *** thorst has quit IRC | 23:06 | |
| *** sdague has quit IRC | 23:07 | |
| dansmith | wow, big information leak from papa cisco there | 23:07 |
| *** acormier has joined #openstack-nova | 23:07 | |
| *** lyan has quit IRC | 23:10 | |
| *** xinliang has joined #openstack-nova | 23:10 | |
| *** edmondsw has quit IRC | 23:10 | |
| *** edmondsw has joined #openstack-nova | 23:11 | |
| *** cfriesen has joined #openstack-nova | 23:11 | |
| *** acormier has quit IRC | 23:12 | |
| cburgess | dansmith Do what...? | 23:13 |
| *** rtjure has quit IRC | 23:14 | |
| dansmith | cburgess: the forward of the internal cisco "go sway the vote" email that got forwarded to the dev list with a ton of cisco email and mailing lists | 23:14 |
| smcginnis | Someone's probably going to get a sterm talking to. | 23:15 |
| *** edmondsw has quit IRC | 23:15 | |
| * melwitt looks | 23:15 | |
| smcginnis | melwitt: http://lists.openstack.org/pipermail/openstack-dev/2017-July/120115.html | 23:15 |
| melwitt | lol | 23:16 |
| *** chyka has quit IRC | 23:16 | |
| smcginnis | Gah - s/sterm/stern/ | 23:16 |
| *** rtjure has joined #openstack-nova | 23:17 | |
| dansmith | I really really want to go register for some interesting websites with those group addresses | 23:18 |
| dansmith | "Dear openstack summit core, please confirm your registration to Latex Fetish Weekly" | 23:19 |
| smcginnis | lol | 23:19 |
| melwitt | :) | 23:19 |
| melwitt | I assumed it was an accident when I opened it but it looks to be on purpose? | 23:21 |
| dansmith | seems purposeful to me. misguided and naive, but purposeful | 23:22 |
| dansmith | needless to say, I've already voted :) | 23:22 |
| melwitt | yeah | 23:22 |
| melwitt | hah | 23:22 |
| cburgess | So... sorry about that. Someone internal wasn't aware of the proper community norms. Gary, our internal person who owns our summit participation is going to make sure that individual, and everyone internal involved in summit talks understand community norms and adheres to them in the future. | 23:26 |
| *** marst has joined #openstack-nova | 23:28 | |
| *** deep-book-gk_ has joined #openstack-nova | 23:29 | |
| *** deep-book-gk_ has left #openstack-nova | 23:32 | |
| *** Swami has quit IRC | 23:32 | |
| *** takashin has joined #openstack-nova | 23:34 | |
| mtreinish | heh, I'm also pretty sure that voting page isn't ready yet | 23:35 |
| mtreinish | like there's still the deadlines from boston listed | 23:35 |
| *** jwcroppe has quit IRC | 23:36 | |
| mtreinish | and the backend isn't filtering at all. I searched for dansmith's name and it showed all of his proposed talks going back to atl | 23:36 |
| *** jwcroppe has joined #openstack-nova | 23:37 | |
| *** vishwanathj has quit IRC | 23:37 | |
| dansmith | yeah I noticed that too | 23:37 |
| *** vishwanathj has joined #openstack-nova | 23:37 | |
| *** jwcroppe has quit IRC | 23:37 | |
| *** chyka has joined #openstack-nova | 23:38 | |
| *** acormier has joined #openstack-nova | 23:39 | |
| *** penick has quit IRC | 23:39 | |
| *** penick has joined #openstack-nova | 23:40 | |
| jaypipes | cburgess: Gary was the one that sent the internal Cisco email... | 23:42 |
| cburgess | jaypipes I take it by that statement that you are also pointing out that the internal email is somewhat against the community spirit? | 23:44 |
| *** mmehan has quit IRC | 23:45 | |
| jaypipes | cburgess: wasn't it? it's basically the "go vote for all of Cisco's submissions" email. | 23:45 |
| *** penick has quit IRC | 23:45 | |
| *** rajathagasthya has joined #openstack-nova | 23:45 | |
| cburgess | jaypipes I suppose thats a fair statement. There is some desire internally to show our level of involvement and promote our talka. But I agree that it is also a form of vote swaying that is at odds with the community standards. | 23:46 |
| *** acormier has quit IRC | 23:46 | |
| cburgess | I'll discuss it internally, though I'm fairly certain other companies do, or have done similar things in the past. But its a fair point that its not in keeping with the spirit. | 23:47 |
| jaypipes | cburgess: totes | 23:47 |
| jaypipes | cburgess: an email saying "hey everyone, please do your civic duty and go review and vote on summit talk proposals so that the summit schedule has excellent content" would be perfectly fine. | 23:47 |
| cburgess | jaypipes and those do happen as well. Its a fair point. Gary is, in general, very supportive of the community and its standards (he is co-organizer of the LA OpenStack meetup). There is some conflict at times between the community and internal desires. I agree that we could do better and I'll bring those up. | 23:48 |
| jaypipes | cburgess: I'm not bitching about it. :) | 23:49 |
| jaypipes | cburgess: was just pointing out that Gary (the person you mentioned was responsible for adhering to community norms) was the one who sent the email internally at Cisco :) | 23:49 |
| jaypipes | cburgess: I didn't know if you were aware of that. | 23:50 |
| jaypipes | cburgess: trust me, I've bitched about similar emails that Mirantis marketing has sent out internally. | 23:50 |
| *** acormier has joined #openstack-nova | 23:50 | |
| *** sdague has joined #openstack-nova | 23:50 | |
| jaypipes | cburgess: and anyway, there's way more important things for me to bitch about: https://twitter.com/jaypipes/status/889889832025165827 | 23:51 |
| jaypipes | clearly. | 23:51 |
| cburgess | jaypipes Well everyone is responsible for community norms (and yeah I'm aware I saw the thread, internally and on the dev list). Its hard for me to apply more the mild pressure on the internal type comms. But both Gary and I can apply much more preasure as it relates to external community involvement and comms. | 23:51 |
| cburgess | jaypipes LOL.. seen more then a few of those myself. | 23:52 |
| jaypipes | cburgess: hey, if it makes you feel better, I voted up your proposed talk :) | 23:52 |
| cburgess | lol thanks | 23:52 |
| jaypipes | and now.. I'm off. | 23:54 |
| jaypipes | ciao | 23:54 |
| *** jaypipes has quit IRC | 23:54 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted certificates to InstanceExtras https://review.openstack.org/457711 | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!