| *** gyee has joined #openstack-nova | 00:02 | |
| *** marst has joined #openstack-nova | 00:04 | |
| *** kaisers_ has joined #openstack-nova | 00:05 | |
| *** yingjun has joined #openstack-nova | 00:06 | |
| *** mdrabe has quit IRC | 00:08 | |
| *** armax has quit IRC | 00:10 | |
| *** Sukhdev has quit IRC | 00:12 | |
| *** iceyao has joined #openstack-nova | 00:14 | |
| openstackgerrit | christopher.uhler proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale https://review.openstack.org/443951 | 00:15 |
|---|---|---|
| *** zz_dimtruck is now known as dimtruck | 00:20 | |
| *** hoonetorg has quit IRC | 00:22 | |
| *** penick has joined #openstack-nova | 00:23 | |
| *** tbachman has quit IRC | 00:27 | |
| *** rmart04 has joined #openstack-nova | 00:29 | |
| *** r-daneel has quit IRC | 00:30 | |
| *** kaisers_ has quit IRC | 00:31 | |
| *** catintheroof has joined #openstack-nova | 00:32 | |
| *** rmart04 has quit IRC | 00:34 | |
| *** hoonetorg has joined #openstack-nova | 00:35 | |
| *** abalutoiu has quit IRC | 00:40 | |
| mriedem | edleafe: dansmith: on https://review.openstack.org/#/c/441544/7/nova/objects/fields.py did we decide to not check before adding the CUSTOM_ prefix if it were already in the norm_name? | 00:40 |
| *** abalutoiu has joined #openstack-nova | 00:40 | |
| mriedem | i believe that's come up before | 00:41 |
| dansmith | mriedem: we're depending on the drivers to return legit classes, yes | 00:42 |
| *** nic has quit IRC | 00:44 | |
| *** ZZelle has quit IRC | 00:49 | |
| *** armax has joined #openstack-nova | 00:51 | |
| *** iceyao has quit IRC | 00:51 | |
| *** iceyao_ has joined #openstack-nova | 00:51 | |
| mriedem | so, we could still create CUSTOM_CUSTOM_BAREMETAL_GOLD then | 00:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162 | 00:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891 | 00:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | 00:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292 | 00:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487 | 00:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293 | 00:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861 | 00:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | 00:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | 00:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Avoid lazy-loading projects during flavor notification https://review.openstack.org/445697 | 00:52 |
| mriedem | and it wouldn't be the drivers fault, it could be the operator set the node.resource_class value to be 'CUSTOM_BAREMETAL_GOLD' | 00:52 |
| dansmith | right, but that's what we should do, IMHO | 00:53 |
| dansmith | otherwise there's this odd ambiguity, | 00:53 |
| *** zhurong has joined #openstack-nova | 00:53 | |
| *** amotoki has joined #openstack-nova | 00:53 | |
| dansmith | and the node resource class is an ironic construct, not specifically "this is (or may be) the exact resource class in placement" | 00:53 |
| mriedem | so ironic's API should then return a 400 if i try to set node.resource_class to anything with the CUSTOM_ prefix? | 00:54 |
| dansmith | that's up to them, but I'd expect not | 00:55 |
| dansmith | and since they haven't placed those restrictions thus far (any of the ones required to be a resource class in placement), | 00:55 |
| dansmith | we should just treat that as a thing, prefix with CUSTOM_ and normalize as we need) | 00:56 |
| dansmith | like, maybe they let the resource class include spaces, they clearly allow lowercase, maybe punctuation, etc | 00:56 |
| dansmith | and that's cool | 00:56 |
| mriedem | ok so CUSTOM_CUSTOM_BAREMETAL_GOLD just might be a thing you end up with, and if so, oops, but it doesn't break | 01:00 |
| dansmith | right | 01:00 |
| mriedem | not sure i want to start thinking about what it would take to unwind that if you wanted to fix it, | 01:00 |
| mriedem | across both services | 01:01 |
| dansmith | I don't think it's a big deal actually, but, | 01:01 |
| dansmith | when they start reporting into placement, they can generate and handle their classes however they want | 01:01 |
| *** sree has joined #openstack-nova | 01:02 | |
| *** sree has quit IRC | 01:02 | |
| *** sree has joined #openstack-nova | 01:02 | |
| mriedem | ok | 01:03 |
| mriedem | i've left comments in the code parts, will do tests later | 01:03 |
| *** phuongnh has joined #openstack-nova | 01:03 | |
| *** xinliang has joined #openstack-nova | 01:06 | |
| *** xinliang has quit IRC | 01:06 | |
| *** xinliang has joined #openstack-nova | 01:06 | |
| *** crushil has joined #openstack-nova | 01:06 | |
| *** iceyao has joined #openstack-nova | 01:07 | |
| *** iceyao_ has quit IRC | 01:11 | |
| *** hoonetorg has quit IRC | 01:16 | |
| *** awaugama has quit IRC | 01:18 | |
| *** kevinz has joined #openstack-nova | 01:19 | |
| *** unicell has quit IRC | 01:20 | |
| *** Shunli has joined #openstack-nova | 01:21 | |
| *** edmondsw has joined #openstack-nova | 01:21 | |
| *** dimtruck is now known as zz_dimtruck | 01:22 | |
| *** catintheroof has quit IRC | 01:24 | |
| *** kaisers_ has joined #openstack-nova | 01:27 | |
| *** iceyao has quit IRC | 01:28 | |
| *** abalutoiu has quit IRC | 01:28 | |
| *** Shunli has quit IRC | 01:28 | |
| *** abalutoiu has joined #openstack-nova | 01:28 | |
| *** Shunli has joined #openstack-nova | 01:29 | |
| *** rmart04 has joined #openstack-nova | 01:30 | |
| *** hoonetorg has joined #openstack-nova | 01:30 | |
| *** catintheroof has joined #openstack-nova | 01:30 | |
| *** catintheroof has quit IRC | 01:32 | |
| *** rmart04 has quit IRC | 01:34 | |
| *** edmondsw has quit IRC | 01:36 | |
| *** yonglihe has joined #openstack-nova | 01:43 | |
| *** fragatin_ has joined #openstack-nova | 01:44 | |
| *** tbachman has joined #openstack-nova | 01:46 | |
| *** mriedem has quit IRC | 01:48 | |
| *** fragatina has quit IRC | 01:48 | |
| *** fragatin_ has quit IRC | 01:49 | |
| *** raunak has quit IRC | 01:52 | |
| *** iceyao has joined #openstack-nova | 01:53 | |
| *** namnh has joined #openstack-nova | 01:53 | |
| openstackgerrit | Danfly proposed openstack/nova master: Completely remove mox from unit/network/test_linux_net.py https://review.openstack.org/445504 | 01:57 |
| *** rmart04 has joined #openstack-nova | 02:00 | |
| *** wangqun has joined #openstack-nova | 02:00 | |
| *** rmart04 has quit IRC | 02:05 | |
| *** amotoki has quit IRC | 02:05 | |
| *** amotoki has joined #openstack-nova | 02:05 | |
| *** kaisers__ has joined #openstack-nova | 02:08 | |
| *** yamahata has quit IRC | 02:08 | |
| *** fragatina has joined #openstack-nova | 02:11 | |
| *** kaisers_ has quit IRC | 02:12 | |
| *** zsli_ has joined #openstack-nova | 02:14 | |
| *** tanee is now known as tanee_away | 02:14 | |
| *** tanee_away is now known as tanee | 02:14 | |
| *** gongysh has joined #openstack-nova | 02:14 | |
| *** Shunli has quit IRC | 02:16 | |
| *** fragatina has quit IRC | 02:16 | |
| *** sree has quit IRC | 02:17 | |
| *** zsli__ has joined #openstack-nova | 02:18 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Send out notifications when instance tags changed https://review.openstack.org/429569 | 02:19 |
| *** zsli_ has quit IRC | 02:20 | |
| *** ssurana has joined #openstack-nova | 02:22 | |
| *** ssurana has left #openstack-nova | 02:24 | |
| *** gcb has joined #openstack-nova | 02:29 | |
| *** ijw has quit IRC | 02:36 | |
| *** zz_dimtruck is now known as dimtruck | 02:37 | |
| *** ijw has joined #openstack-nova | 02:38 | |
| *** gouthamr has quit IRC | 02:39 | |
| *** ijw has quit IRC | 02:42 | |
| *** sree has joined #openstack-nova | 02:42 | |
| *** raunak has joined #openstack-nova | 02:43 | |
| openstackgerrit | Wei Cao proposed openstack/nova master: vmware: Change the VM Create spec https://review.openstack.org/444119 | 02:47 |
| *** kaisers__ has quit IRC | 02:50 | |
| *** Apoorva has quit IRC | 02:52 | |
| *** hongbin has joined #openstack-nova | 02:56 | |
| *** bkopilov has quit IRC | 02:58 | |
| *** sree has quit IRC | 03:00 | |
| *** gyee has quit IRC | 03:01 | |
| *** rmart04 has joined #openstack-nova | 03:01 | |
| *** rmart04 has quit IRC | 03:06 | |
| *** markvoelker has quit IRC | 03:06 | |
| *** antwash has left #openstack-nova | 03:07 | |
| alex_xu | gmann: johnthetubaguy some test https://review.openstack.org/445361 | 03:09 |
| *** ducnc1 has joined #openstack-nova | 03:13 | |
| *** ducnc has quit IRC | 03:15 | |
| *** ducnc1 is now known as ducnc | 03:15 | |
| *** gyee has joined #openstack-nova | 03:17 | |
| *** browne has quit IRC | 03:18 | |
| *** crushil has quit IRC | 03:19 | |
| *** unicell has joined #openstack-nova | 03:26 | |
| *** Jeffrey4l has quit IRC | 03:28 | |
| *** amotoki has quit IRC | 03:32 | |
| *** tovin07_ has joined #openstack-nova | 03:33 | |
| *** Jeffrey4l has joined #openstack-nova | 03:41 | |
| *** hongbin has quit IRC | 03:42 | |
| *** nicolasbock has quit IRC | 03:42 | |
| *** diga has joined #openstack-nova | 03:44 | |
| *** kaisers_ has joined #openstack-nova | 03:45 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Repropose tag-instance-when-boot https://review.openstack.org/415315 | 03:46 |
| *** amotoki has joined #openstack-nova | 03:49 | |
| *** amotoki has quit IRC | 03:50 | |
| *** amotoki has joined #openstack-nova | 03:52 | |
| *** amotoki has quit IRC | 03:54 | |
| *** links has joined #openstack-nova | 03:56 | |
| *** huangtianhua has quit IRC | 03:57 | |
| *** rmart04 has joined #openstack-nova | 04:02 | |
| *** namnh has quit IRC | 04:05 | |
| *** rmart04 has quit IRC | 04:07 | |
| *** markvoelker has joined #openstack-nova | 04:07 | |
| *** kaisers_ has quit IRC | 04:09 | |
| *** rfolco has quit IRC | 04:10 | |
| *** s1061123_ is now known as s1061123_away | 04:11 | |
| *** s1061123_away is now known as s1061123_afk | 04:11 | |
| *** markvoelker has quit IRC | 04:13 | |
| *** ijw has joined #openstack-nova | 04:13 | |
| *** fragatina has joined #openstack-nova | 04:15 | |
| *** gcb has quit IRC | 04:15 | |
| *** gcb has joined #openstack-nova | 04:16 | |
| *** fragatina has quit IRC | 04:16 | |
| *** fragatina has joined #openstack-nova | 04:17 | |
| *** udesale has joined #openstack-nova | 04:18 | |
| *** psachin has joined #openstack-nova | 04:20 | |
| *** dikonoor has joined #openstack-nova | 04:21 | |
| *** amotoki has joined #openstack-nova | 04:22 | |
| *** fragatina has quit IRC | 04:26 | |
| *** vks1 has joined #openstack-nova | 04:26 | |
| *** adisky_ has joined #openstack-nova | 04:26 | |
| openstackgerrit | Hieu LE proposed openstack/nova master: Completely remove mox from objects/test_instance.py https://review.openstack.org/343465 | 04:28 |
| *** dikonoor has quit IRC | 04:28 | |
| *** Apoorva has joined #openstack-nova | 04:35 | |
| *** zsli_ has joined #openstack-nova | 04:38 | |
| *** gongysh has quit IRC | 04:39 | |
| *** amotoki has quit IRC | 04:39 | |
| *** zsli__ has quit IRC | 04:40 | |
| *** Apoorva has quit IRC | 04:45 | |
| *** psachin has quit IRC | 05:00 | |
| *** zhurong has quit IRC | 05:00 | |
| *** sree has joined #openstack-nova | 05:01 | |
| *** kaisers_ has joined #openstack-nova | 05:02 | |
| *** rmart04 has joined #openstack-nova | 05:03 | |
| *** kaisers_ has quit IRC | 05:04 | |
| *** david-lyle has quit IRC | 05:04 | |
| *** bkopilov has joined #openstack-nova | 05:05 | |
| *** sree has quit IRC | 05:06 | |
| *** wangqun_ has joined #openstack-nova | 05:07 | |
| *** wangqun has quit IRC | 05:07 | |
| *** josecastroleon has quit IRC | 05:07 | |
| *** rmart04 has quit IRC | 05:07 | |
| openstackgerrit | Wei Cao proposed openstack/nova master: vmware: Change the VM Create spec https://review.openstack.org/444119 | 05:08 |
| *** wangqun has joined #openstack-nova | 05:11 | |
| *** wangqun_ has quit IRC | 05:13 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/443357 | 05:16 |
| *** psachin has joined #openstack-nova | 05:17 | |
| *** ratailor has joined #openstack-nova | 05:17 | |
| *** gongysh has joined #openstack-nova | 05:17 | |
| *** udesale__ has joined #openstack-nova | 05:17 | |
| *** ayogi has joined #openstack-nova | 05:18 | |
| *** wangqun has quit IRC | 05:18 | |
| *** wangqun has joined #openstack-nova | 05:18 | |
| *** dikonoor has joined #openstack-nova | 05:19 | |
| *** udesale has quit IRC | 05:21 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add api-ref for filter/sort whitelist https://review.openstack.org/421760 | 05:25 |
| *** faizy has joined #openstack-nova | 05:28 | |
| *** dikonoor has quit IRC | 05:28 | |
| *** dikonoor has joined #openstack-nova | 05:28 | |
| *** amotoki has joined #openstack-nova | 05:30 | |
| *** NikhilS has joined #openstack-nova | 05:30 | |
| *** prateek has joined #openstack-nova | 05:32 | |
| *** prateek has quit IRC | 05:32 | |
| *** prateek has joined #openstack-nova | 05:33 | |
| *** udesale has joined #openstack-nova | 05:35 | |
| *** eliqiao has quit IRC | 05:35 | |
| *** udesale__ has quit IRC | 05:37 | |
| *** bmace has quit IRC | 05:37 | |
| *** zsli_ has quit IRC | 05:39 | |
| *** zsli_ has joined #openstack-nova | 05:40 | |
| *** sandanar has joined #openstack-nova | 05:42 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Permit Live Migration of Rescued Instances https://review.openstack.org/308198 | 05:42 |
| *** claudiub has joined #openstack-nova | 05:44 | |
| *** udesale__ has joined #openstack-nova | 05:44 | |
| *** udesale has quit IRC | 05:46 | |
| *** dikonoor has quit IRC | 05:48 | |
| *** psachin has quit IRC | 05:49 | |
| *** lpetrut has joined #openstack-nova | 05:51 | |
| *** gyee has quit IRC | 05:51 | |
| *** fragatina has joined #openstack-nova | 05:55 | |
| *** psachin has joined #openstack-nova | 05:57 | |
| *** yamahata has joined #openstack-nova | 05:59 | |
| *** amotoki has quit IRC | 06:00 | |
| *** rmart04 has joined #openstack-nova | 06:04 | |
| *** kaisers_ has joined #openstack-nova | 06:04 | |
| *** sridharg has joined #openstack-nova | 06:07 | |
| *** zsli_ has quit IRC | 06:08 | |
| *** rmart04 has quit IRC | 06:08 | |
| *** markvoelker has joined #openstack-nova | 06:09 | |
| *** kaisers_ has quit IRC | 06:09 | |
| *** dikonoor has joined #openstack-nova | 06:11 | |
| *** amotoki has joined #openstack-nova | 06:11 | |
| *** haplo37 has quit IRC | 06:11 | |
| *** raunak has quit IRC | 06:12 | |
| *** markvoelker has quit IRC | 06:13 | |
| *** sree has joined #openstack-nova | 06:18 | |
| *** raghav has quit IRC | 06:18 | |
| *** haplo37 has joined #openstack-nova | 06:20 | |
| *** armax has quit IRC | 06:20 | |
| *** unicell1 has joined #openstack-nova | 06:29 | |
| *** unicell has quit IRC | 06:30 | |
| *** nkrinner_afk is now known as nkrinner | 06:36 | |
| *** lpetrut has quit IRC | 06:40 | |
| *** sandanar has quit IRC | 06:45 | |
| *** moshele has joined #openstack-nova | 06:46 | |
| *** namnh has joined #openstack-nova | 06:48 | |
| *** lpetrut has joined #openstack-nova | 06:49 | |
| *** fragatina has quit IRC | 06:50 | |
| *** ekuris has joined #openstack-nova | 06:52 | |
| *** jaosorior has joined #openstack-nova | 06:52 | |
| *** tuanluong has joined #openstack-nova | 06:54 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | 06:55 |
| *** zhurong has joined #openstack-nova | 06:58 | |
| *** satyar has joined #openstack-nova | 07:01 | |
| *** karthiks_afk is now known as karthiks | 07:01 | |
| *** tuanluong_ has joined #openstack-nova | 07:04 | |
| *** lpetrut has quit IRC | 07:05 | |
| *** kaisers_ has joined #openstack-nova | 07:06 | |
| *** lpetrut has joined #openstack-nova | 07:06 | |
| *** andreas_s has joined #openstack-nova | 07:06 | |
| *** tuanluong has quit IRC | 07:07 | |
| *** josecastroleon has joined #openstack-nova | 07:08 | |
| openstackgerrit | Dinesh Bhor proposed openstack/nova master: Use HostAddressOpt for opts that accept IP and hostnames https://review.openstack.org/445782 | 07:08 |
| *** kaisers_ has quit IRC | 07:10 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova-specs master: Live Migration of Rescued Instances https://review.openstack.org/347161 | 07:11 |
| *** Oku_OS-away is now known as Oku_OS | 07:12 | |
| *** fragatina has joined #openstack-nova | 07:14 | |
| *** unicell1 has quit IRC | 07:21 | |
| *** trinaths has joined #openstack-nova | 07:30 | |
| *** diga has quit IRC | 07:30 | |
| *** gongysh has quit IRC | 07:34 | |
| *** ratailor has quit IRC | 07:36 | |
| *** tesseract has joined #openstack-nova | 07:44 | |
| *** ltomasbo|away is now known as ltomasbo | 07:45 | |
| *** zhangqiankun has quit IRC | 07:49 | |
| *** zhangqiankun has joined #openstack-nova | 07:49 | |
| *** gongysh has joined #openstack-nova | 07:50 | |
| *** tuanluong_ has quit IRC | 07:52 | |
| *** trinaths has quit IRC | 07:52 | |
| *** tuanluong has joined #openstack-nova | 07:55 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-nova | 08:00 | |
| *** VAhl has joined #openstack-nova | 08:02 | |
| *** pcaruana has joined #openstack-nova | 08:05 | |
| *** kaisers_ has joined #openstack-nova | 08:06 | |
| *** jichen has joined #openstack-nova | 08:08 | |
| jichen | alex_xu, hi have time for a quick talk? | 08:10 |
| *** markvoelker has joined #openstack-nova | 08:10 | |
| alex_xu | jichen: yea, sure, please | 08:10 |
| *** ratailor has joined #openstack-nova | 08:10 | |
| jichen | https://bugs.launchpad.net/nova/+bug/1670978, this need a spec ,right? if any changes might need to be done | 08:10 |
| openstack | Launchpad bug 1670978 in OpenStack Compute (nova) "most of extended server attributes returned in 2.3 api versions should not require admin role" [Undecided,New] - Assigned to jichenjc (jichenjc) | 08:10 |
| alex_xu | jichen: 不需要 | 08:11 |
| alex_xu | sorry | 08:11 |
| alex_xu | jichen: it needn't | 08:11 |
| jichen | why ? | 08:11 |
| *** kaisers_ has quit IRC | 08:11 | |
| jichen | API changes no spec needed any more ? | 08:11 |
| alex_xu | jichen: it is only about change a default value of a policy rule from admin-only to owner_or_admin | 08:11 |
| jichen | um... part of the return value affected ,I thought if we affect output format , this is API change? | 08:12 |
| *** udesale has joined #openstack-nova | 08:13 | |
| alex_xu | jichen: yea, that always confuse us, but actually, that can't be resolved by microversion, it should be resolved by capabilities API | 08:13 |
| alex_xu | jichen: here is https://review.openstack.org/#/c/386555/ | 08:14 |
| jichen | alex_xu: so this bug might need the API-WG discussion on cap talk settle down then continue? | 08:14 |
| alex_xu | jichen: i think no... | 08:14 |
| jichen | alex_xu: yeah, I knew this discussion | 08:14 |
| *** markvoelker has quit IRC | 08:14 | |
| jichen | ok, I will give another thought and see how to proceed this | 08:14 |
| alex_xu | johnthetubaguy: ^ I think we needn't waiting for cap API, right? | 08:14 |
| *** udesale__ has quit IRC | 08:14 | |
| alex_xu | jichen: thanks, if johnthetubaguy also ensure this needn't waiting for cap API, then ping me when the patch ready | 08:15 |
| jichen | ok | 08:15 |
| jichen | another question | 08:15 |
| alex_xu | jichen: yea, please | 08:15 |
| jichen | https://review.openstack.org/307675, it's abandoned but this seems discussed before and a potential item? any discussion on PTG about it ? | 08:16 |
| jichen | Change subject: Make API errors conform to API-WG schema | 08:17 |
| alex_xu | jichen: there is no discussion about this in the PTG | 08:17 |
| jichen | ok... I went through the ethpad and didn't find anything.... | 08:17 |
| alex_xu | jichen: yea, I didn't remember we bring that idea into the api meeting before PTG also | 08:17 |
| jichen | so it might be restore back later after P , Q ... :) ? | 08:18 |
| alex_xu | jichen: yea, first ensure someone commit to work on it | 08:18 |
| jichen | I can't remember clearly but seems I saw it's discussed somewhere | 08:18 |
| alex_xu | jichen: there is proposal add that into placement API | 08:18 |
| jichen | ok, can you point me the link? | 08:18 |
| alex_xu | searching the link | 08:19 |
| jichen | ok, thanks~ | 08:19 |
| alex_xu | jichen: https://review.openstack.org/#/c/418393/ | 08:19 |
| alex_xu | maybe co-work with that spec, and migrate the solution into the nova api | 08:19 |
| jichen | alex_xu: great, thanks a lot~ | 08:19 |
| jichen | I will take a look :) | 08:19 |
| alex_xu | jichen: np :) | 08:19 |
| *** abalutoiu has quit IRC | 08:20 | |
| *** efoley__ has joined #openstack-nova | 08:23 | |
| *** diga has joined #openstack-nova | 08:26 | |
| *** zhurong has quit IRC | 08:28 | |
| *** yamahata has quit IRC | 08:31 | |
| *** josecastroleon has quit IRC | 08:33 | |
| *** amotoki has quit IRC | 08:35 | |
| *** abalutoiu has joined #openstack-nova | 08:36 | |
| *** amoralej|off is now known as amoralej | 08:37 | |
| *** Shunli has joined #openstack-nova | 08:39 | |
| *** lpetrut has quit IRC | 08:46 | |
| *** jpena|off is now known as jpena | 08:46 | |
| *** Shunli has quit IRC | 08:53 | |
| *** Shunli has joined #openstack-nova | 08:53 | |
| *** ralonsoh has joined #openstack-nova | 08:55 | |
| *** priteau has joined #openstack-nova | 08:55 | |
| *** abalutoiu has quit IRC | 08:55 | |
| *** haplo37 has quit IRC | 08:58 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: utils.get_disk return the target dev of the root device https://review.openstack.org/402716 | 09:00 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Make guest.BlockDevice only use the target dev of a disk https://review.openstack.org/402163 | 09:00 |
| *** prateek_ has joined #openstack-nova | 09:02 | |
| *** udesale__ has joined #openstack-nova | 09:04 | |
| *** prateek has quit IRC | 09:04 | |
| *** karimb has joined #openstack-nova | 09:05 | |
| *** udesale has quit IRC | 09:06 | |
| *** haplo37 has joined #openstack-nova | 09:07 | |
| *** kaisers_ has joined #openstack-nova | 09:07 | |
| *** VAhl has quit IRC | 09:08 | |
| *** zsli_ has joined #openstack-nova | 09:08 | |
| *** dimtruck is now known as zz_dimtruck | 09:10 | |
| *** Shunli has quit IRC | 09:11 | |
| *** abalutoiu has joined #openstack-nova | 09:11 | |
| *** kaisers_ has quit IRC | 09:12 | |
| *** lucas-afk is now known as lucasagomes | 09:17 | |
| *** liusheng has quit IRC | 09:18 | |
| *** liusheng has joined #openstack-nova | 09:19 | |
| *** priteau has quit IRC | 09:25 | |
| *** zhurong has joined #openstack-nova | 09:28 | |
| *** jaosorior is now known as jaosorior_lunch | 09:28 | |
| *** zioproto has joined #openstack-nova | 09:31 | |
| *** zsli_ has quit IRC | 09:33 | |
| *** zhurong has quit IRC | 09:38 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: allow owner to retrieve some data by default https://review.openstack.org/445844 | 09:39 |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: allow owner to retrieve some data by default https://review.openstack.org/445844 | 09:41 |
| *** zhurong has joined #openstack-nova | 09:42 | |
| *** derekh has joined #openstack-nova | 09:43 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add InstanceList.get_by_instance_mapping_list() https://review.openstack.org/445141 | 09:44 |
| *** ijw has quit IRC | 09:45 | |
| *** josecastroleon has joined #openstack-nova | 09:50 | |
| *** ijw has joined #openstack-nova | 09:50 | |
| mdbooth | lyarwood: Morning. Can you point me at your series again? | 09:51 |
| *** zhurong has quit IRC | 09:53 | |
| lyarwood | mdbooth: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1489581 & https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cinder-new-attach-apis | 09:53 |
| *** dmellado has quit IRC | 09:54 | |
| lyarwood | mdbooth: the first two are just nice to have, we've been trying to get a uuid added for bdms for ages | 09:54 |
| *** amoralej has quit IRC | 09:54 | |
| mdbooth | lyarwood: K. I'll ask a series of dumb questions throughout the morning in all likelihood | 09:54 |
| *** ltomasbo has quit IRC | 09:54 | |
| *** jpena has quit IRC | 09:55 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Make server_external_events use an optimal number of db queries https://review.openstack.org/445142 | 09:55 |
| lyarwood | mdbooth: np and thanks for looking at this | 09:55 |
| *** ijw has quit IRC | 09:57 | |
| *** yingjun has quit IRC | 09:57 | |
| *** gcb has quit IRC | 09:59 | |
| *** jpena|off has joined #openstack-nova | 09:59 | |
| *** ltomasbo|away has joined #openstack-nova | 10:00 | |
| *** amoralej has joined #openstack-nova | 10:00 | |
| *** ijw has joined #openstack-nova | 10:01 | |
| *** s1061123_afk is now known as tohayash | 10:01 | |
| *** dmellado has joined #openstack-nova | 10:02 | |
| *** edmondsw has joined #openstack-nova | 10:02 | |
| *** satyar has quit IRC | 10:03 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova-specs master: TinyFix: Changed type of CPU ID from 'String' to 'Integer' in diagnostics spec https://review.openstack.org/445855 | 10:05 |
| *** tovin07_ has quit IRC | 10:05 | |
| *** wangqun has quit IRC | 10:06 | |
| *** jpena|off is now known as jpena | 10:06 | |
| *** edmondsw has quit IRC | 10:06 | |
| *** kaisers_ has joined #openstack-nova | 10:08 | |
| *** markvoelker has joined #openstack-nova | 10:10 | |
| *** ltomasbo|away is now known as ltomasbo | 10:12 | |
| *** kaisers_ has quit IRC | 10:13 | |
| *** udesale has joined #openstack-nova | 10:14 | |
| *** prateek__ has joined #openstack-nova | 10:15 | |
| *** markvoelker has quit IRC | 10:15 | |
| *** udesale has quit IRC | 10:16 | |
| *** udesale has joined #openstack-nova | 10:16 | |
| *** udesale__ has quit IRC | 10:17 | |
| *** gszasz has joined #openstack-nova | 10:17 | |
| *** prateek_ has quit IRC | 10:18 | |
| *** openstackgerrit has quit IRC | 10:18 | |
| *** kevinz has quit IRC | 10:18 | |
| ildikov | lyarwood: hi | 10:19 |
| *** tuanluong has quit IRC | 10:19 | |
| *** rfolco has joined #openstack-nova | 10:19 | |
| ildikov | lyarwood: are the BDM patches ready for review? | 10:19 |
| lyarwood | ildikov: yes, mdbooth is going over them now | 10:20 |
| ildikov | lyarwood: I saw on the priority etherpad that they are still listed under subteam review, but if you fixed Matt's comments, etc then I'll move them to ready | 10:20 |
| ildikov | lyarwood: great, I'll move them on the etherpad too | 10:20 |
| ildikov | lyarwood: tnx | 10:20 |
| mdbooth | lyarwood: Do you happen to know why we don't refer to bdms by the primary key (id)? | 10:21 |
| mdbooth | We don't do that anywhere, so this isn't an outlier | 10:22 |
| mdbooth | Just wondering if you know why | 10:22 |
| lyarwood | I wasn't aware that we ever did that so no, if we did I don't know why we stopped | 10:23 |
| mdbooth | I suppose the db's primary key isn't universally unique... | 10:24 |
| lyarwood | yeah, as we are moving towards multiple dbs etc I guess we needed uuids | 10:24 |
| *** openstackgerrit has joined #openstack-nova | 10:27 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Deprecate the Cinder API v2 support https://review.openstack.org/444253 | 10:27 |
| *** sdague has joined #openstack-nova | 10:27 | |
| openstackgerrit | jichenjc proposed openstack/nova master: remove keypair server extension https://review.openstack.org/396611 | 10:27 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Another poc for removing stevedore for nova api https://review.openstack.org/445864 | 10:27 |
| *** arslanq has joined #openstack-nova | 10:28 | |
| arslanq | hi guys, i am confused about live migration of VMs. What is the requirement of live migration does it require shared storage ? | 10:29 |
| *** phuongnh has quit IRC | 10:31 | |
| rpodolyaka | arslanq: it does not. libvirt can 'block migrate' the storage for you | 10:32 |
| rpodolyaka | arslanq: that being said, shared storage is highly recommended | 10:32 |
| *** ababich has joined #openstack-nova | 10:32 | |
| *** moshele has quit IRC | 10:33 | |
| MasterofJOKers | https://docs.openstack.org/admin-guide/compute-configuring-migrations.html#block-migration | 10:33 |
| arslanq | rpodolyaka: Thanks, i am facing some errors on block migration. i'll get back to you | 10:37 |
| *** udesale has quit IRC | 10:41 | |
| *** namnh has quit IRC | 10:41 | |
| *** scottda has quit IRC | 10:44 | |
| *** karimb has quit IRC | 10:49 | |
| openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225 | 10:50 |
| *** nicolasbock has joined #openstack-nova | 10:50 | |
| *** lpetrut has joined #openstack-nova | 10:56 | |
| *** dikonoor has quit IRC | 10:58 | |
| *** jichen has quit IRC | 11:00 | |
| *** gongysh has quit IRC | 11:01 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | 11:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | 11:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged volume attachment https://review.openstack.org/418100 | 11:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | 11:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | 11:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | 11:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged nic attachment https://review.openstack.org/415520 | 11:04 |
| *** liverpooler has quit IRC | 11:08 | |
| *** ayogi has quit IRC | 11:08 | |
| *** kaisers_ has joined #openstack-nova | 11:09 | |
| asettle | Morning bauzas and johnthetubaguy - Brian seems to be having issues with his CentOS install (which, he htinks is environment related). Is there anyone in here that could test on CentOS or RHEL for us? | 11:09 |
| asettle | We're 2/3rds there | 11:09 |
| *** ayogi has joined #openstack-nova | 11:10 | |
| *** kaisers_ has quit IRC | 11:13 | |
| *** amotoki has joined #openstack-nova | 11:14 | |
| *** karimb has joined #openstack-nova | 11:15 | |
| *** lucasagomes is now known as lucas-pto | 11:15 | |
| *** bvanhav__ has joined #openstack-nova | 11:15 | |
| openstackgerrit | Maxim Nestratov proposed openstack/nova-specs master: libvirt: reintroduce runtime image type detection https://review.openstack.org/363547 | 11:17 |
| *** smatzek has joined #openstack-nova | 11:17 | |
| *** cdent has joined #openstack-nova | 11:17 | |
| *** ociuhandu has quit IRC | 11:21 | |
| *** amotoki has quit IRC | 11:21 | |
| *** karimb has quit IRC | 11:26 | |
| mnestratov | mdbooth: hi | 11:26 |
| mnestratov | regarding ^^ | 11:27 |
| mdbooth | mnestratov: Yeah, I don't think I'm ever going to like that :( | 11:27 |
| mdbooth | I'm very much in favour of multi-backend support, though. | 11:28 |
| mnestratov | and I repeat what I just aksed in review - how do we change current default behavir? | 11:28 |
| mdbooth | Just not with static config. | 11:28 |
| mnestratov | *behavior | 11:28 |
| *** karimb has joined #openstack-nova | 11:29 | |
| mdbooth | 2 things: associate the backend in use somehow with the bdm, so it lives with the instance not with the host config | 11:29 |
| mnestratov | I'm fine with it | 11:29 |
| *** psachin has quit IRC | 11:30 | |
| mdbooth | Second: configure a *default* somehow, or pass it in the api in a driver-agnostic way | 11:30 |
| *** gouthamr has joined #openstack-nova | 11:30 | |
| *** psachin has joined #openstack-nova | 11:30 | |
| mdbooth | Advantage of doing the former is that you can change your mind about the latter | 11:30 |
| mnestratov | are we going to ignore images_type config parameter? | 11:30 |
| mdbooth | I would love to be able to do that, yes | 11:30 |
| mdbooth | It's a bug | 11:30 |
| mnestratov | me too | 11:31 |
| mnestratov | are we going to do this? | 11:31 |
| mdbooth | Given infinite time I will hopefully get to it eventually :) | 11:31 |
| mdbooth | If you can get it done now I'll definitely support you in that. | 11:32 |
| arslanq | rpodolyaka: i am running block migration and hitting with this issue: Error LiveMigrateException: Live Migration failed: Migration complete but instance did not change host: compute7 | 11:32 |
| mnestratov | it doesn't solve my problems | 11:32 |
| *** ralonsoh has quit IRC | 11:32 | |
| mnestratov | but ok I'll try to figure out how to do this via DBM | 11:33 |
| rpodolyaka | arslanq: are there any additional errors on both source and destination compute nodes? nova-compute / libvirt logs | 11:33 |
| mnestratov | I mean BDM :) | 11:34 |
| arslanq | rpodolyaka: i found this error log in nova logs: Live Migration failure: Operation not supported: qemu does not support drive-mirror command | 11:35 |
| *** diga has quit IRC | 11:35 | |
| johnthetubaguy | asettle: do you have more details on the issue he is hitting at all? | 11:36 |
| asettle | johnthetubaguy: From Brian this morning "And all the steps work correctly on CentOS, I just have communication problems between the compute and the controller nodes. At this point I’m thinking it is a problem with CentOS packages or perhaps my environment." | 11:37 |
| asettle | I don't have much more than that, unfortunately (as in, no error logs) | 11:37 |
| *** amotoki has joined #openstack-nova | 11:38 | |
| mdbooth | mnestratov: Sorry, got disconnected. Scrolling back. | 11:38 |
| rpodolyaka | arslanq: hmm, this sounds similar to https://bugs.launchpad.net/nova/+bug/1441054 | 11:39 |
| openstack | Launchpad bug 1441054 in OpenStack Compute (nova) "live-migration --block-migrate fails with default libvirt flags" [Medium,Invalid] - Assigned to Mathieu Rohon (mathieu-rohon) | 11:39 |
| rpodolyaka | arslanq: I remember there were some issues with block migration on some versions of libvirtd | 11:39 |
| rpodolyaka | arslanq: specifically, we could not block migrate instances with block devices attached (e.g. config drives) | 11:40 |
| mdbooth | mnestratov: Moving this into the BDM makes it unambiguous. It opens up the possibility of safely having a heterogenous storage config. | 11:40 |
| *** hshiina has joined #openstack-nova | 11:40 | |
| *** jaypipes has joined #openstack-nova | 11:40 | |
| rpodolyaka | arslanq: but, unfortunately, I do not remember details :( | 11:40 |
| arslanq | rpodolyaka: Note: i don't have shared storage..... | 11:40 |
| *** yingjun has joined #openstack-nova | 11:40 | |
| mdbooth | It means operators can change storage config after deployment without breaking all their existing instances. | 11:40 |
| rpodolyaka | arslanq: anyway, this must have been fixed in the latest versions of libvirt/qemu | 11:40 |
| mdbooth | It means migrating between hosts with different storage becomes unambiguous. | 11:41 |
| arslanq | rpodolyaka: right now i am on openstack newton branch. Can i get some proper document of this issue? It will be very helpful for me. | 11:41 |
| mdbooth | mnestratov: There are a bunch of advantages beyond just your use case. | 11:42 |
| mdbooth | Whilst also fixing some edge cases where we currently have to skirt around security issues. | 11:42 |
| mnestratov | mdbooth: what would you say if we will not introduce a new config parameter but instead just change the behavior. Like if images_type is none or default then image backend is chosen according to image disk_format metadata and stored in instance' BDM | 11:43 |
| mdbooth | mnestratov: The behaviour should be that if it's present in instance BDM, that should always be used. We should only consult a config/whatever if it's not present, and then we should use that to set it in the bdm. | 11:44 |
| jaypipes | morning folks | 11:44 |
| mdbooth | mnestratov: That gets around the issue of changing config/different config between hosts. | 11:45 |
| mdbooth | jaypipes: morning | 11:45 |
| jaypipes | alex_xu, melwitt, dansmith, Vek: review bait: https://review.openstack.org/399679 | 11:45 |
| *** abalutoiu has quit IRC | 11:45 | |
| mnestratov | mdbooth: it demands changing the way you boot your instances | 11:45 |
| jaypipes | mdbooth: hey, morning. so how's it going with the libvirt storage pools patch series? haven't looked at it in a month or so. Need to get back on that. | 11:46 |
| arslanq | rpodolyaka: i have the following libvirt version: libvirtd (libvirt) 2.0.0 | 11:46 |
| mdbooth | jaypipes: I haven't done anything with it in that time, tbh. | 11:46 |
| jaypipes | mdbooth: you planning to? or other priorities getting in the way? | 11:46 |
| mdbooth | jaypipes: I need to make a new start on it. It's still on my list, though. | 11:46 |
| cdent | I'm not coping well with jaypipes being 4 hours off instead of the usual 5. It's making me all confused and discombobulated. | 11:46 |
| mdbooth | Yeah, just other priorities :( | 11:46 |
| jaypipes | rpodolyaka: so, you finish the placement client plugin in OSC yet? :P | 11:47 |
| jaypipes | cdent: :) | 11:47 |
| *** claudiub has quit IRC | 11:47 | |
| * cdent considers taking PTO until the 26th | 11:47 | |
| *** amotoki has quit IRC | 11:48 | |
| *** ratailor has quit IRC | 11:53 | |
| *** yingjun has quit IRC | 11:53 | |
| *** abalutoiu has joined #openstack-nova | 11:53 | |
| *** karimb has quit IRC | 11:55 | |
| *** karimb has joined #openstack-nova | 11:56 | |
| *** gcb has joined #openstack-nova | 11:57 | |
| *** alexpilo_ has quit IRC | 11:59 | |
| mdbooth | lyarwood: Patch 1 done. I should hopefully pick up the pace a bit with growing context :) | 11:59 |
| *** faizy has quit IRC | 11:59 | |
| *** dikonoor has joined #openstack-nova | 12:00 | |
| *** p01nt3r75 has joined #openstack-nova | 12:01 | |
| *** ociuhandu has joined #openstack-nova | 12:04 | |
| *** kevinz has joined #openstack-nova | 12:06 | |
| mnestratov | mdbooth: one more concern about ignoring images_type parameter. If we implement multibackend support, then it would be hard to report free disk space to scheduler. Is there a way to report free space for all supported backends? | 12:07 |
| *** smatzek has quit IRC | 12:08 | |
| *** kornicameister has quit IRC | 12:09 | |
| *** smatzek has joined #openstack-nova | 12:09 | |
| *** kaisers_ has joined #openstack-nova | 12:09 | |
| *** vks1 has quit IRC | 12:11 | |
| *** kevinz has quit IRC | 12:11 | |
| *** markvoelker has joined #openstack-nova | 12:11 | |
| *** tblakes has joined #openstack-nova | 12:12 | |
| *** kevinz has joined #openstack-nova | 12:12 | |
| *** gongysh has joined #openstack-nova | 12:12 | |
| mdbooth | mnestratov: Free space needs to be reported per backend anyway. | 12:13 |
| *** kaisers_ has quit IRC | 12:14 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Fix formatting errors and warnings https://review.openstack.org/407364 | 12:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Treat doc build warnings as errors https://review.openstack.org/439883 | 12:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: tox: Build docs with Python 2.7 https://review.openstack.org/445906 | 12:14 |
| sfinucan | johnthetubaguy: mriedem had. I've put them in a series now ^ | 12:15 |
| sfinucan | bauzas: Easy +2s for your newfound spec powers above ^ :) | 12:15 |
| *** markvoelker has quit IRC | 12:16 | |
| johnthetubaguy | sfinucan: sweet, I want to see jenkins +2 all that first | 12:17 |
| johnthetubaguy | sfinucan: did that last patch miss a link it your commit message? | 12:17 |
| arslanq | rpodolyaka: I just tries this manually and i came to know that this happens only when i block migrate. "Live Migration failure: Operation not supported: qemu does not support drive-mirror command" | 12:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: tox: Build docs with Python 2.7 https://review.openstack.org/445906 | 12:18 |
| sfinucan | johnthetubaguy: Oops. Fixed | 12:18 |
| arslanq | rpodolyaka: when i just use live migration it says that live migration is not possible without shared storage. | 12:19 |
| *** alexpilotti has joined #openstack-nova | 12:20 | |
| mdbooth | I've stared at this long enough now that I assume I've just become blind to a typo or something. Could any who's got a second tell me what's causing the TypeError here: http://logs.openstack.org/42/445142/3/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/07e282a/logs/screen-n-api.txt.gz?level=ERROR | 12:21 |
| mdbooth | Thank you #openstack-nova for helping me spot that typo | 12:21 |
| mdbooth | You can ignore the above | 12:21 |
| *** jaosorior_lunch is now known as jaosorior | 12:21 | |
| *** karimb has quit IRC | 12:24 | |
| mdbooth | Also, mock-- for hiding an incorrect use of an interface | 12:24 |
| johnthetubaguy | lyarwood: mdbooth: did you see the discussion over here: https://bugs.launchpad.net/nova/+bug/1672624 | 12:24 |
| openstack | Launchpad bug 1672624 in OpenStack Compute (nova) "Ceph volumes attached to local deleted instance could not be correctly handled" [Undecided,New] | 12:24 |
| *** alexpilotti has quit IRC | 12:24 | |
| mdbooth | johnthetubaguy: I didn't. Can look after lunch, though. | 12:25 |
| *** ayogi has quit IRC | 12:25 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Make server_external_events use an optimal number of db queries https://review.openstack.org/445142 | 12:26 |
| *** bkopilov has quit IRC | 12:27 | |
| *** R08209 has joined #openstack-nova | 12:28 | |
| mdbooth | johnthetubaguy: Do we want to have api punt 'local_delete' to conductor and have it be a bit more thorough? | 12:28 |
| mnestratov | mdbooth: yeah I know, but IFAIK it's impossible now | 12:28 |
| *** R08209 has quit IRC | 12:29 | |
| mdbooth | johnthetubaguy: That's very similar to the evacuate use case where you want to cleanup a volume attachment when the compute host isn't available. | 12:29 |
| mdbooth | biab | 12:30 |
| *** edmondsw has joined #openstack-nova | 12:34 | |
| *** artom has quit IRC | 12:34 | |
| *** karimb has joined #openstack-nova | 12:34 | |
| *** NightKhaos has quit IRC | 12:35 | |
| *** NightKhaos has joined #openstack-nova | 12:35 | |
| *** baoli has joined #openstack-nova | 12:36 | |
| *** edmondsw has quit IRC | 12:37 | |
| *** edmondsw has joined #openstack-nova | 12:37 | |
| *** markvoelker has joined #openstack-nova | 12:38 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add extra-specs-image-meta-conflicts spec https://review.openstack.org/382382 | 12:38 |
| *** baoli has quit IRC | 12:39 | |
| *** vladikr has quit IRC | 12:39 | |
| *** vladikr has joined #openstack-nova | 12:40 | |
| *** baoli has joined #openstack-nova | 12:40 | |
| lyarwood | johnthetubaguy: just back from lunch, that isn't a bug for me, more of an operator failure tbh. ./me adds a note to the bug | 12:40 |
| johnthetubaguy | lyarwood: hmm, curious what you mean by that | 12:41 |
| *** moshele has joined #openstack-nova | 12:41 | |
| lyarwood | johnthetubaguy: while the compute service is down the original instance / domain is still active and connected to the backing rbd volume | 12:42 |
| lyarwood | johnthetubaguy: so any attempt to remove the volume from the rbd pool is going to fail | 12:42 |
| johnthetubaguy | lyarwood: ah, yes, it should do, good point | 12:42 |
| johnthetubaguy | lyarwood: you have to wait for clean up on the compute node, which they haven't done | 12:43 |
| *** karimb has quit IRC | 12:43 | |
| lyarwood | johnthetubaguy: that or manually fence it | 12:43 |
| lyarwood | johnthetubaguy: get it into a known state | 12:43 |
| *** baoli has quit IRC | 12:44 | |
| johnthetubaguy | lyarwood: yeah, we might need better tooling for that long term, post cinder API fix ups | 12:45 |
| alex_xu | nova api meeting is 15 mins at openstack-meeting-4 | 12:45 |
| johnthetubaguy | alex_xu: yeah, I should get me some lunch quickly! | 12:45 |
| *** karimb has joined #openstack-nova | 12:46 | |
| alex_xu | johnthetubaguy: :) | 12:46 |
| *** jaosorior has quit IRC | 12:46 | |
| alex_xu | johnthetubaguy: maybe we can move the meeting early 15mins, then you can get a better lunch | 12:47 |
| *** jaosorior has joined #openstack-nova | 12:47 | |
| johnthetubaguy | alex_xu: nah, that just means I am hungry during the meeting | 12:48 |
| alex_xu | :) | 12:49 |
| alex_xu | johnthetubaguy: sdague experiment for removing stevedore https://review.openstack.org/#/c/445864/ | 12:50 |
| *** erhudy has joined #openstack-nova | 12:52 | |
| *** abalutoiu has quit IRC | 12:52 | |
| *** gouthamr has quit IRC | 12:54 | |
| *** efoley_ has joined #openstack-nova | 12:55 | |
| sdague | alex_xu: that looks really neat | 12:55 |
| *** crushil has joined #openstack-nova | 12:55 | |
| *** faizy has joined #openstack-nova | 12:56 | |
| *** mriedem has joined #openstack-nova | 12:57 | |
| alex_xu | sdague: thanks, make me have more confidence | 12:57 |
| sdague | alex_xu: and *so* much more clear | 12:57 |
| *** efoley__ has quit IRC | 12:58 | |
| alex_xu | sdague: just follow the placement api pattern, explicitly list the routes | 12:59 |
| *** catintheroof has joined #openstack-nova | 12:59 | |
| alex_xu | nova api meeting is running | 13:00 |
| *** efoley__ has joined #openstack-nova | 13:01 | |
| *** slaweq__ has quit IRC | 13:01 | |
| *** links has quit IRC | 13:02 | |
| *** efoley__ has quit IRC | 13:02 | |
| *** efoley__ has joined #openstack-nova | 13:03 | |
| *** liverpooler has joined #openstack-nova | 13:03 | |
| *** efoley_ has quit IRC | 13:04 | |
| *** efoley__ has quit IRC | 13:04 | |
| *** efoley_ has joined #openstack-nova | 13:04 | |
| *** esberglu has joined #openstack-nova | 13:04 | |
| *** jed56 has joined #openstack-nova | 13:06 | |
| *** jed56 has quit IRC | 13:06 | |
| *** jed56 has joined #openstack-nova | 13:06 | |
| *** felipemonteiro has joined #openstack-nova | 13:07 | |
| *** eharney has joined #openstack-nova | 13:09 | |
| *** kaisers_ has joined #openstack-nova | 13:10 | |
| *** bvanhav_ has joined #openstack-nova | 13:11 | |
| *** mdrabe has joined #openstack-nova | 13:11 | |
| *** liangy has joined #openstack-nova | 13:11 | |
| *** bvanhav__ has quit IRC | 13:12 | |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova master: Add is_vz_container function https://review.openstack.org/445947 | 13:12 |
| *** annegentle has joined #openstack-nova | 13:12 | |
| *** baoli has joined #openstack-nova | 13:13 | |
| *** claudiub has joined #openstack-nova | 13:14 | |
| *** kaisers_ has quit IRC | 13:15 | |
| *** annegentle has quit IRC | 13:17 | |
| *** stvnoyes1 has joined #openstack-nova | 13:17 | |
| *** lucasxu has quit IRC | 13:18 | |
| *** abalutoiu has joined #openstack-nova | 13:18 | |
| *** kevinz has quit IRC | 13:21 | |
| *** gouthamr has joined #openstack-nova | 13:22 | |
| *** vks1 has joined #openstack-nova | 13:22 | |
| *** prateek__ has quit IRC | 13:22 | |
| *** tongli has joined #openstack-nova | 13:23 | |
| *** xyang1 has joined #openstack-nova | 13:23 | |
| *** psachin has quit IRC | 13:24 | |
| *** slaweq__ has joined #openstack-nova | 13:24 | |
| openstackgerrit | Rafael Folco proposed openstack/nova master: DELETE all inventory for a resource provider https://review.openstack.org/416669 | 13:26 |
| openstackgerrit | Rafael Folco proposed openstack/nova master: [placement] Raising http codes on old microversion https://review.openstack.org/444497 | 13:26 |
| rpodolyaka | jaypipes: heh, you'll be the first one to know, when the placement client plugin is done ;) | 13:28 |
| dansmith | gibi: can you look at this? https://review.openstack.org/#/c/445697/ | 13:29 |
| *** aysyd has joined #openstack-nova | 13:29 | |
| dansmith | gibi: I found another case where we were lazy-loading that from an instance on compute and so I think we probably want to go a little more aggressive on it | 13:30 |
| *** tbachman has quit IRC | 13:32 | |
| jaypipes | rfolco: quick request on https://review.openstack.org/#/c/444497/. if you could handle that, I'll re-review quickly. | 13:32 |
| jaypipes | rfolco: besides that, I think we should be able to merge your two patches in that series today. | 13:33 |
| rfolco | jaypipes.requests --> priority -1 | 13:33 |
| cdent | i concur, dr pipes | 13:33 |
| jaypipes | rfolco: :) | 13:33 |
| stvnoyes1 | i was writing a tempest test for swap disk (update volume attachment). The test runs ok on a running server, but I get a libvirt exception (Domain not found: no domain with matching uuid) when run against a stopped server. Is swap not supported on a stopped server? I didn't see anything in the doc about a restriction like that. thanks... | 13:34 |
| *** amoralej is now known as amoralej|lunch | 13:34 | |
| *** smatzek has quit IRC | 13:35 | |
| *** gcb has quit IRC | 13:35 | |
| mdbooth | stvnoyes1: It is not supported, no. | 13:36 |
| jaypipes | stvnoyes1: when you say "you get a libvirt error", are you saying that that libvirt error is returned to you as a *user*, or that you see that error in the nova-compute log file? | 13:36 |
| stvnoyes1 | in the log | 13:36 |
| *** abalutoiu has quit IRC | 13:37 | |
| mdbooth | johnthetubaguy: ^^^ Incidentally, what stvnoyes1 said is why I was talking about the 'did_copy' response in the swap_volume callback to cinder | 13:37 |
| *** fandi has joined #openstack-nova | 13:37 | |
| *** abalutoiu has joined #openstack-nova | 13:38 | |
| johnthetubaguy | mdbooth: ack, makes sense, but we can't fix everything in one go | 13:38 |
| mdbooth | johnthetubaguy: Yep, but if we could stick it in the api then we can fix it later more easily. | 13:38 |
| mriedem | jaypipes: if you haven't seen yet, i had some questions in your ironic get_inventory patch | 13:38 |
| mriedem | only thing i have left to review there is the RT functional test | 13:38 |
| jaypipes | mriedem: yup, thanks much for your review and questions. answering now. | 13:38 |
| *** penick has quit IRC | 13:39 | |
| mriedem | fwiw dansmith explained a bit of earlier conversations to me last night | 13:39 |
| jaypipes | mriedem: dansmith is good like that. :) | 13:40 |
| *** satyar has joined #openstack-nova | 13:41 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Avoid lazy-loading projects during flavor notification https://review.openstack.org/445697 | 13:43 |
| *** gcb has joined #openstack-nova | 13:46 | |
| mriedem | johnthetubaguy: you were +2 on this before the cleanups https://review.openstack.org/#/c/429569/ | 13:48 |
| *** kylek3h has quit IRC | 13:49 | |
| mriedem | bauzas: unless you have a reason not to, i'm going to open a bug about the fact that we never delete request_specs when we delete an instance, | 13:50 |
| mriedem | i'm not sure if that's by design | 13:50 |
| mriedem | maybe i'll start in the ML | 13:51 |
| mriedem | since we wouldn't want to do this for soft delete | 13:51 |
| *** rmart04 has joined #openstack-nova | 13:52 | |
| dansmith | mriedem: we could also do with a bug to clean up all the conversion back and forth to/from the legacy version that never got cleaned up | 13:53 |
| stvnoyes1 | jaypipes: i was interested to see what would happen doing a swap to a stopped vm with the cli. the cli command returned without an error. The volume status of both vols were unchanged. And there was that Domain not found error in the logs. I found a similar non-error using the API, the test only failed because the new volume never became 'in-use'. | 13:53 |
| bauzas | mriedem: I have a branch for that | 13:53 |
| *** markvoelker_ has joined #openstack-nova | 13:54 | |
| bauzas | mriedem: that's one of the things I have in my plate and never had time for that in Ocata | 13:54 |
| mriedem | dansmith: yeah bauzas has a blueprint for that from ocata, | 13:54 |
| mriedem | i don't remember seeing anything about actually deleting these things though | 13:54 |
| bauzas | mriedem: hence me planning to fix it by Pike | 13:54 |
| mriedem | i'll brain dump in the ML | 13:54 |
| bauzas | mriedem: https://review.openstack.org/#/c/391060/ | 13:54 |
| bauzas | dansmith: ^ | 13:54 |
| mriedem | ah | 13:54 |
| bauzas | it requires a rebase | 13:55 |
| jaypipes | stvnoyes1: gotcha. would you expect instead to have an "unsupported operation on stopped server" error message return instead of no error? | 13:55 |
| *** markvoelker has quit IRC | 13:55 | |
| mriedem | bauzas: left my concern inline, but that potentially cripples a restored soft deleted instance, | 13:56 |
| bauzas | mriedem: cool, thanks | 13:57 |
| mriedem | i'm not sure how we deal with that, since we don't want the compute doing a call back up to the API to delete the request spec when the instance is hard deleted | 13:57 |
| bauzas | mriedem: the problem is that we never agreed on soft-deleting the Spec with alaski | 13:57 |
| dansmith | he means soft delete of the instance | 13:57 |
| dansmith | (right?) | 13:57 |
| bauzas | yeah | 13:57 |
| bauzas | I understand that | 13:57 |
| dansmith | not soft delete of the instance db record | 13:57 |
| bauzas | sure | 13:57 |
| bauzas | but if we trigger the Spec hard deletion on an instance soft-delete | 13:58 |
| *** smatzek has joined #openstack-nova | 13:58 | |
| stvnoyes1 | jaypipes: agree, it would be better to get some kind of error. since a server can stop at any time, doing a check in the API code would help a lot but it wouldn't cover all the cases. | 13:58 |
| *** awaugama has joined #openstack-nova | 13:58 | |
| bauzas | then, how could we restore it if we restore the instance ? | 13:58 |
| dansmith | you don't restore it, | 13:58 |
| dansmith | you have to defer deletion of it until the soft-deleted instance is purged somehow | 13:58 |
| dansmith | although that happens on the compute node | 13:58 |
| *** udesale has joined #openstack-nova | 13:59 | |
| bauzas | yeah, the trigger is then totally different | 13:59 |
| bauzas | we could keep the spec record until the instance is hard-deleted | 13:59 |
| bauzas | but I need to see where we trigger that | 13:59 |
| dansmith | right, so you have to just not delete it in that case, and either leak it (as we do now for everything) or at least delete if you hard-delete | 13:59 |
| bauzas | dansmith: you said we hard-delete on the compute side ? | 14:00 |
| bauzas | a periodic I guess ? | 14:00 |
| *** alexpilotti has joined #openstack-nova | 14:00 | |
| dansmith | compute is what does the purge yeah, in a periodic | 14:00 |
| mriedem | dansmith: right | 14:00 |
| mriedem | well, SOFT_DELETED in the API sense | 14:00 |
| mriedem | not the DB sense | 14:00 |
| bauzas | okay, that would ease my branch :) | 14:00 |
| bauzas | IIRC, we already merged the .delete() method I added in Newton | 14:01 |
| bauzas | the caller of that .delete() never merged in time in Newton | 14:01 |
| mriedem | which delete() method? | 14:01 |
| bauzas | the Spec one | 14:01 |
| *** zz_dimtruck is now known as dimtruck | 14:01 | |
| mriedem | yes RequestSpec.destroy() exists, | 14:01 |
| mriedem | but nothing calls it | 14:01 |
| bauzas | exactly | 14:01 |
| bauzas | because I wrote the destroy() | 14:01 |
| bauzas | it was in the same series | 14:01 |
| mriedem | so i think we're left with leaking request specs for soft-deleted instances for now i guess | 14:01 |
| bauzas | yup | 14:02 |
| bauzas | lemme clarify | 14:02 |
| bauzas | in Newton, I discovered that (because I missed that when I reviewed alaski's persistence series) | 14:02 |
| mriedem | we could provide a nova-manage command to purge those if you wanted... | 14:02 |
| bauzas | so I wrote a series | 14:02 |
| bauzas | .destroy() as a bottom patch | 14:02 |
| bauzas | the bottom merged | 14:02 |
| dansmith | mriedem: we have InstanceMappings to purge in that case as well | 14:02 |
| bauzas | but not the top one | 14:02 |
| mriedem | dansmith: nova-manage api_db purge_zombies | 14:03 |
| bauzas | and in Ocata, I had that in my plate, but the placement things diverted me | 14:03 |
| bauzas | so, we're now in Pike and it's still in my plate :) | 14:03 |
| mriedem | eat faster | 14:03 |
| *** zhurong_ has joined #openstack-nova | 14:03 | |
| dansmith | mriedem: aye | 14:03 |
| bauzas | mriedem: dansmith: I wrote a db online migrations that was creating the spec records for old instances, could we envisage some hack for purging ? | 14:04 |
| bauzas | ie. we trigger deletes on the periodic task | 14:04 |
| bauzas | but we could also write a db online migration script that would do that | 14:04 |
| *** awaugama has quit IRC | 14:05 | |
| dansmith | we shouldn't abuse online migrations for periodic cleanup | 14:05 |
| dansmith | IMHO | 14:05 |
| bauzas | okay | 14:05 |
| bauzas | fine by me | 14:05 |
| bauzas | I'll revisit that change | 14:05 |
| *** links has joined #openstack-nova | 14:05 | |
| bauzas | if we have a periodic, do we still need a purge command ? | 14:06 |
| bauzas | dansmith: mriedem^ | 14:06 |
| dansmith | we can't have a periodic, IMHO | 14:06 |
| *** zhurong_ has quit IRC | 14:06 | |
| dansmith | having all the conductors purging all the time would be bad I think | 14:06 |
| dansmith | apis don't run periodics | 14:06 |
| mriedem | yeah that ^ | 14:06 |
| dansmith | and the compute node can't do it | 14:06 |
| mriedem | computes can't talk to api | 14:06 |
| *** tbachman has joined #openstack-nova | 14:07 | |
| mriedem | so yeah, it's on-demand purge for now it sounds like | 14:07 |
| mriedem | the scheduler has periodics... | 14:07 |
| mriedem | and this is related to scheduling stuff | 14:07 |
| dansmith | it's too heavy for scheduler, IMHO, | 14:07 |
| *** baoli has quit IRC | 14:07 | |
| dansmith | requires hitting cell and api databases, | 14:07 |
| mriedem | true | 14:08 |
| mriedem | just like discover_hosts :) | 14:08 |
| dansmith | and scheduler is supposed to be single-threaded | 14:08 |
| dansmith | yeah, but that is _actually_ scheduling-related and also getting to be nearly zero time :) | 14:09 |
| dansmith | and disabled by default and not required for normal operation | 14:09 |
| bauzas | okay I see | 14:09 |
| bauzas | dansmith: so you propose nova-manage api_db purge_zombies ? fine by me, lemme write it quickly | 14:09 |
| dansmith | and also, remember the suggestion of potentially making the scheduler just a pass-through library call | 14:09 |
| bauzas | yeah I see your point | 14:10 |
| bauzas | and we can't use compute periodic because of the upcall | 14:10 |
| dansmith | it'd be nice if we could just roll this into archive_rows or something | 14:10 |
| *** baoli has joined #openstack-nova | 14:10 | |
| dansmith | archiving rows in the api db is just deleting them | 14:10 |
| bauzas | dansmith: well, it would require some change in .destroy() but nothing really hard :) | 14:10 |
| mriedem | we wouldn't use reqspec.destroy() if it were in the archive method | 14:11 |
| bauzas | FWIW, unrelated I have a concern with https://review.openstack.org/#/c/439754/23 | 14:11 |
| bauzas | dansmith: ^ | 14:11 |
| mriedem | it'd be straight sql | 14:11 |
| *** abalutoiu has quit IRC | 14:11 | |
| mriedem | well, orm | 14:11 |
| bauzas | mriedem: dansmith: well, do you think it could be turnable by opt ? | 14:11 |
| *** kaisers_ has joined #openstack-nova | 14:12 | |
| bauzas | or by command | 14:12 |
| bauzas | like "purge --archive" | 14:12 |
| *** bkopilov has joined #openstack-nova | 14:12 | |
| dansmith | bauzas: I know that's a concern, but unless you have a suggestion going forward I don't see what the options are | 14:12 |
| *** lucasxu has joined #openstack-nova | 14:12 | |
| dansmith | bauzas: just make archive_deleted_rows do it.. no need to overthink it | 14:13 |
| bauzas | dansmith: sorry I could be confused | 14:14 |
| *** irenab_ has joined #openstack-nova | 14:15 | |
| bauzas | dansmith: you mean I should amend the archive_deleted_rows subcommand to delete the spec records ? | 14:16 |
| dansmith | yes | 14:16 |
| bauzas | okay | 14:16 |
| *** kaisers_ has quit IRC | 14:16 | |
| bauzas | lemme write that soon, ideally this week | 14:16 |
| bauzas | mriedem: you said you gonna write a bug report for this ? | 14:16 |
| *** kylek3h has joined #openstack-nova | 14:17 | |
| *** awaugama has joined #openstack-nova | 14:17 | |
| dansmith | bauzas: I'd really appreciate quick follow-up on the az thing with concrete suggestions | 14:17 |
| bauzas | dansmith: for https://review.openstack.org/#/c/439754/23/nova/api/metadata/base.py I don't think we need to change this if we consider looking up the host AZ, nope ? | 14:17 |
| dansmith | bauzas: you mean what was being done before? | 14:18 |
| mriedem | bauzas: i'm working on something related to it | 14:18 |
| bauzas | dansmith: the logic in that method is that we use the instance.az field to match with the host AZ information | 14:18 |
| bauzas | dansmith: yeah, I don't see why we need to make it cellsv2-aware | 14:18 |
| bauzas | if we fix instance.az | 14:18 |
| dansmith | bauzas: because metadata runs in the cell and can't access the api database to look at az stuff | 14:18 |
| bauzas | orly? | 14:19 |
| dansmith | yarly! | 14:19 |
| bauzas | I thought it was on top | 14:20 |
| *** kevinz has joined #openstack-nova | 14:20 | |
| dansmith | bauzas: no, and definitely not if we're just using it to build configdrive | 14:20 |
| bauzas | I see | 14:20 |
| bauzas | lemme reconsider the problem then | 14:20 |
| bauzas | dansmith: what really blocks us is https://github.com/openstack/nova/blob/67af1eefc5c1cf8cde4b4becb933808850acec2d/nova/availability_zones.py#L190 | 14:21 |
| bauzas | dansmith: but conceptually, we need to know where the instance is located, hence why we call the AggregateList object | 14:22 |
| dansmith | why are we doing that late instead of just making sure az gets set properly when the instance gets rescheduled or whatever? | 14:22 |
| dansmith | we're taking this lookup hit every time we build metadata, but we should just make sure that we set the thing properly in the first place right? | 14:23 |
| *** kevinz has quit IRC | 14:24 | |
| dansmith | like in schedule_and_build() and build_and_run(), we should be able to lookup and fix instance.az once so metadata never has to look again, right? | 14:25 |
| dansmith | since we know the host it's going to land on each time | 14:25 |
| *** dane-fichter has joined #openstack-nova | 14:26 | |
| bauzas | dansmith: well, it's something I discussed in the past | 14:27 |
| bauzas | now that we have RequestSpec, I'm in favor of updating instance.az to the right value | 14:27 |
| *** abalutoiu has joined #openstack-nova | 14:27 | |
| bauzas | semantically, we kept that unchanged in the past because we wanted to know what the user originally expressed | 14:27 |
| bauzas | but now we have the Spec object that targets that | 14:27 |
| dansmith | if the user expressed something, then we would be limiting the scheduling to that az anyway, no? | 14:28 |
| bauzas | dansmith: yup, but we default that field for some unknown reason | 14:28 |
| bauzas | we set it anyway | 14:28 |
| dansmith | to nova if it was unset, right? | 14:28 |
| bauzas | well, I actually know | 14:28 |
| bauzas | yeah, if the user didn't ask for an AZ, we set it to a conf opt value | 14:29 |
| *** amotoki has joined #openstack-nova | 14:29 | |
| bauzas | if the user asked for an AZ, then I agree with your statement | 14:29 |
| dansmith | so metadata right now reports the actual az it landed on correct? | 14:29 |
| dansmith | it looks to me like we use instance.az in several other places | 14:30 |
| bauzas | dansmith: for the metadata, yes | 14:31 |
| dansmith | no, for other things too | 14:31 |
| dansmith | nova/network/neutronv2/api.py: zone = 'compute:%s' % instance.availability_zone | 14:31 |
| bauzas | dansmith: for other places, AFAICT, I think we return that too | 14:31 |
| dansmith | nova/virt/block_device.py: return instance.availability_zone | 14:31 |
| dansmith | is having instance.az being incorrect not affecting those places as well? | 14:32 |
| bauzas | yup | 14:32 |
| dansmith | like, shouldn't making it be the actual az the instance is on be better? | 14:32 |
| bauzas | yeah, as I said, I agree, we should update instance.az to the right value | 14:32 |
| *** vks1 has left #openstack-nova | 14:32 | |
| bauzas | and use spec_obj.availability_zone for knowing the original request | 14:32 |
| dansmith | okay | 14:33 |
| dansmith | grim | 14:33 |
| dansmith | oops | 14:33 |
| dane-fichter | mriedem: could you unblock this change, please? https://review.openstack.org/#/c/351232/ | 14:33 |
| jaypipes | mriedem: so, is there anything on the ironic virt driver patch you'd like me to change? | 14:34 |
| openstackgerrit | Rafael Folco proposed openstack/nova master: DELETE all inventory for a resource provider https://review.openstack.org/416669 | 14:35 |
| openstackgerrit | Rafael Folco proposed openstack/nova master: [placement] Raising http codes on old microversion https://review.openstack.org/444497 | 14:35 |
| mriedem | dane-fichter: done, left a comment | 14:35 |
| *** rmart04 has quit IRC | 14:35 | |
| mriedem | jaypipes: let me check your replies | 14:35 |
| *** efoley__ has joined #openstack-nova | 14:35 | |
| *** marst has quit IRC | 14:36 | |
| *** mlavalle has joined #openstack-nova | 14:36 | |
| *** karthiks is now known as karthiks_afk | 14:36 | |
| dansmith | bauzas: do I really need elevated context here/ https://github.com/openstack/nova/blob/67af1eefc5c1cf8cde4b4becb933808850acec2d/nova/availability_zones.py#L190 | 14:37 |
| jaypipes | mriedem: I can add a code comment about raising an exception if resource class is None in Queens, if you'd like. | 14:38 |
| *** dave-mccowan has joined #openstack-nova | 14:38 | |
| mriedem | jaypipes: let me look first, might be just follow up stuff | 14:38 |
| mriedem | doing a few things at once | 14:38 |
| *** fragatina has quit IRC | 14:39 | |
| *** efoley_ has quit IRC | 14:39 | |
| *** fragatina has joined #openstack-nova | 14:40 | |
| bauzas | dansmith: I left a proposal in https://review.openstack.org/#/c/439754/23 by saying we could amend instance.az once we schedule a target | 14:40 |
| bauzas | every time we touch instance.host actually | 14:40 |
| dansmith | bauzas: this is what I'm testing right now: http://pastebin.com/raw/iWBb9wt5 | 14:41 |
| dansmith | bauzas: for the old and new build operations | 14:41 |
| *** NikhilS has quit IRC | 14:41 | |
| bauzas | dansmith: for the elevated context, I think it's a legacy from the past | 14:41 |
| dansmith | bauzas: okay I thought so too just checking | 14:41 |
| bauzas | dansmith: now we use objects, we don't really need elevated | 14:41 |
| *** dikonoor has quit IRC | 14:42 | |
| *** links has quit IRC | 14:42 | |
| *** marst has joined #openstack-nova | 14:42 | |
| *** hongbin has joined #openstack-nova | 14:43 | |
| bauzas | dansmith: hmmpppfff, instance.host isn't set on the conductor after we schedule | 14:44 |
| bauzas | I thought it was the case but no | 14:45 |
| bauzas | dansmith: we just use that for calling the right compute service | 14:45 |
| dansmith | right, I'll change | 14:45 |
| bauzas | dansmith: AFAICS, instance.host is only set when the instance is spawning | 14:45 |
| dansmith | yeah, yeah | 14:45 |
| bauzas | yeah we unfortunately need to do that change at the same time or we would enter the magical world of race conditions | 14:45 |
| bauzas | but but | 14:46 |
| bauzas | wait | 14:46 |
| dansmith | huh? | 14:46 |
| bauzas | if we need to lookup the aggregate for knowing where the host is | 14:46 |
| *** burt has quit IRC | 14:46 | |
| bauzas | and that being in the compute section, it would be an upcall right? | 14:46 |
| dansmith | if we haven't build the instance yet, we can just set it | 14:47 |
| dansmith | we know where we're intending for it to go, and if it reschedules, we change it again | 14:47 |
| bauzas | I'm not opposed to that, I'm just saying there is an amount of time where we could show a result where the instance is part of an AZ while it's not yet having an host | 14:48 |
| dansmith | yeah, so? | 14:48 |
| dansmith | also, can we not use this? https://github.com/openstack/nova/blob/master/nova/objects/service.py#L141-L141 | 14:48 |
| dansmith | the host actually knows what AZ it's in right? | 14:49 |
| *** irenab_ has quit IRC | 14:50 | |
| *** eharney_ has joined #openstack-nova | 14:50 | |
| *** eharney has quit IRC | 14:50 | |
| dansmith | hmm, maybe that's different | 14:51 |
| *** Guest47 has quit IRC | 14:51 | |
| bauzas | mmm | 14:51 |
| *** gongysh has quit IRC | 14:51 | |
| bauzas | I just discover that | 14:51 |
| bauzas | oh wait | 14:52 |
| bauzas | yeah that's because the services are within AZs, not the compute nodes | 14:52 |
| dansmith | but the api hides that az, so it must be different | 14:52 |
| bauzas | so, yeah, service.az should be accurate | 14:52 |
| *** yassine has joined #openstack-nova | 14:52 | |
| *** yassine is now known as Guest15143 | 14:53 | |
| dansmith | would it? I don't actually see where we're setting that on service | 14:53 |
| bauzas | dansmith: lemme rephrase, if binary is nova-compute, then it should be accurate | 14:53 |
| *** Sukhdev_ has joined #openstack-nova | 14:55 | |
| *** yamahata has joined #openstack-nova | 14:55 | |
| bauzas | FWIW, I'm digging that | 14:56 |
| *** eharney__ has joined #openstack-nova | 14:57 | |
| *** eharney_ has quit IRC | 14:57 | |
| *** eharney__ is now known as eharney | 14:57 | |
| *** kevinz has joined #openstack-nova | 14:58 | |
| bauzas | dansmith: so we update the service AZ in the AZ helper module https://github.com/openstack/nova/blob/master/nova/availability_zones.py#L89 | 14:59 |
| bauzas | which is mostly called in two places | 15:00 |
| bauzas | one when you want to get the Service object | 15:00 |
| bauzas | and one in the nova manage command when you list all the hosts | 15:01 |
| *** amoralej|lunch is now known as amoralej | 15:02 | |
| bauzas | the only problem that I see is that we don't persist the Service object which is populated when we call the above | 15:02 |
| bauzas | but if you ServiceList.get_all(), you'll get the right value for the AZ | 15:03 |
| mriedem | jaypipes: replied to the replies, now reviewing the RT tests | 15:03 |
| *** kevinz has quit IRC | 15:03 | |
| *** kevinz has joined #openstack-nova | 15:04 | |
| dansmith | bauzas: that's exactly my point, we can't trust it on Service and we can't get it by get_all() from inside the cell | 15:06 |
| dansmith | bauzas: because it will call out to aggregates | 15:06 |
| *** READ10 has joined #openstack-nova | 15:06 | |
| *** yingjun has joined #openstack-nova | 15:08 | |
| *** dane-fichter has quit IRC | 15:08 | |
| *** Sukhdev_ has quit IRC | 15:10 | |
| *** Sukhdev_ has joined #openstack-nova | 15:11 | |
| *** nic has joined #openstack-nova | 15:12 | |
| bauzas | dansmith: yeah, yet another upcall :( | 15:12 |
| *** kevinz has quit IRC | 15:12 | |
| dansmith | bauzas: it seems to me that this is already partially broken and just making instance.az be correct is the solution | 15:13 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: guest.BlockDevice should only use the target device of a disk https://review.openstack.org/402163 | 15:13 |
| *** tongli has quit IRC | 15:13 | |
| *** kevinz has joined #openstack-nova | 15:13 | |
| cfriesen | question...how is the "task_log" table intended to be pruned? Is this intended to be managed by the cloud operator? | 15:15 |
| *** Sukhdev_ has quit IRC | 15:15 | |
| *** lucasxu has quit IRC | 15:16 | |
| *** efried has quit IRC | 15:17 | |
| bauzas | dansmith: well, it would certainly require more than what I originally thought | 15:17 |
| *** ekuris has quit IRC | 15:17 | |
| bauzas | dansmith: one way could be to set instance.host in the conductor | 15:18 |
| dansmith | bauzas: right that's what I'm doing | 15:18 |
| bauzas | not by the compute | 15:18 |
| dansmith | no, not host | 15:18 |
| dansmith | instance.az | 15:18 |
| dansmith | we don't need to set host in conductor, | 15:18 |
| dansmith | and that breaks all kinds of stuff | 15:18 |
| *** sridharg has quit IRC | 15:19 | |
| bauzas | dansmith: well, it could work given https://github.com/openstack/nova/blob/master/nova/availability_zones.py#L163-L169 | 15:21 |
| cfriesen | another database question....how is stale information in the API DB supposed to be cleaned up to prevent indefinite DB growth? | 15:21 |
| dansmith | bauzas: I'm not sure what that has to do with it, but setting instance.host in conductor breaks everything (else) so not an option | 15:22 |
| bauzas | cfriesen: we just discussed that, and we're trying to identify all stale contents | 15:22 |
| bauzas | dansmith: yeah, lemme rephrase | 15:22 |
| *** nic has quit IRC | 15:23 | |
| bauzas | dansmith: I'm considering the time between when we set instance.az after a schedule, and when we set instance.host as a temporary situation where we return something on the API that could be different | 15:23 |
| bauzas | dansmith: because we only return the "real" AZ where the host is only only when the compute is setting instance.host | 15:24 |
| *** Jinxing has joined #openstack-nova | 15:24 | |
| bauzas | before that, we return the original instance.az | 15:24 |
| bauzas | anywaty | 15:25 |
| bauzas | let's not overthink that | 15:25 |
| bauzas | do your change and I'll weight it | 15:25 |
| dansmith | it's not wrong in that cast anyway | 15:25 |
| dansmith | *case | 15:25 |
| dansmith | yeah | 15:25 |
| *** hshiina has quit IRC | 15:25 | |
| *** tpatzig_ has joined #openstack-nova | 15:26 | |
| *** seife_ has joined #openstack-nova | 15:26 | |
| *** dgonzalez_ has joined #openstack-nova | 15:26 | |
| *** david_1 has joined #openstack-nova | 15:26 | |
| *** kevinz has quit IRC | 15:27 | |
| *** tpatzig_ has quit IRC | 15:27 | |
| *** dgonzalez_ has quit IRC | 15:27 | |
| *** seife_ has quit IRC | 15:27 | |
| *** david_1 has quit IRC | 15:28 | |
| dansmith | gdi, we have too many tests | 15:28 |
| *** voelzmo has joined #openstack-nova | 15:29 | |
| *** xyang1 has quit IRC | 15:29 | |
| *** xyang1 has joined #openstack-nova | 15:29 | |
| *** crushil has quit IRC | 15:30 | |
| *** penick has joined #openstack-nova | 15:31 | |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova master: Add is_vz_container function https://review.openstack.org/445947 | 15:33 |
| *** amotoki has quit IRC | 15:33 | |
| mriedem | jaypipes: jroll: JayF: cdent: edleafe: ok, final comments are in https://review.openstack.org/#/c/441544/ | 15:34 |
| mriedem | i'm -1 for several issues in test_resource_tracker | 15:34 |
| *** moshele has quit IRC | 15:34 | |
| *** fragatina has quit IRC | 15:35 | |
| *** oomichi has quit IRC | 15:36 | |
| *** bvanhav__ has joined #openstack-nova | 15:37 | |
| jroll | mriedem: cool, ty | 15:37 |
| *** armax has joined #openstack-nova | 15:37 | |
| *** unicell has joined #openstack-nova | 15:37 | |
| *** bvanhav_ has quit IRC | 15:38 | |
| *** Jeffrey4l has quit IRC | 15:38 | |
| *** vladikr has quit IRC | 15:38 | |
| *** Jeffrey4l has joined #openstack-nova | 15:39 | |
| *** pabardina has quit IRC | 15:40 | |
| cdent | mriedem: since you're in a reviewing state of mind, getting these from edleafe would clear up some lose ends: https://review.openstack.org/#/c/428800/ https://review.openstack.org/#/c/416752/ https://review.openstack.org/#/c/416751/ (related to inventory handling) | 15:40 |
| *** pabardina has joined #openstack-nova | 15:41 | |
| *** vladikr has joined #openstack-nova | 15:41 | |
| *** sandanar has joined #openstack-nova | 15:41 | |
| *** oomichi has joined #openstack-nova | 15:41 | |
| *** vladikr has quit IRC | 15:41 | |
| *** patriciadomin has quit IRC | 15:42 | |
| mriedem | gonna have to queue up | 15:42 |
| *** vladikr has joined #openstack-nova | 15:42 | |
| *** esberglu has left #openstack-nova | 15:42 | |
| *** esberglu has joined #openstack-nova | 15:43 | |
| * cdent looks to a johnthetubaguy for a use-of-the-word-queue check | 15:43 | |
| *** patriciadomin has joined #openstack-nova | 15:43 | |
| johnthetubaguy | heh, you should ask my wife, she is really picky about queues | 15:43 |
| cdent | my recollection is that the use of "up" there is incorrect and would require a forfeit of some kind. Either running around the quad naked or having to get the next two rounds in, depending on your class. | 15:45 |
| *** penick has quit IRC | 15:46 | |
| dansmith | bauzas: https://github.com/openstack/nova/blob/master/nova/conductor/tasks/migrate.py#L49-L55 | 15:46 |
| dansmith | bauzas: that ignores the stored az I think :) | 15:46 |
| bauzas | FWIW, using "queue" in French has a terrible meaning | 15:46 |
| *** nic has joined #openstack-nova | 15:47 | |
| bauzas | dansmith: yet another reason to fix that then | 15:47 |
| *** patriciadomin has quit IRC | 15:47 | |
| dansmith | yeah | 15:47 |
| *** Jinxing has quit IRC | 15:47 | |
| *** patriciadomin has joined #openstack-nova | 15:47 | |
| bauzas | those AZ issues are so fun | 15:47 |
| bauzas | dansmith: FWIW, the only nova thing which cares about AZs is just the AZ filter | 15:48 |
| mdbooth | lyarwood johnthetubaguy: re https://bugs.launchpad.net/nova/+bug/1672624 if this were BZ I'd close it NOTABUG. | 15:48 |
| openstack | Launchpad bug 1672624 in OpenStack Compute (nova) "Ceph volumes attached to local deleted instance could not be correctly handled" [Undecided,New] | 15:48 |
| bauzas | if you don't use it, that's just a nice but useless metadata | 15:48 |
| *** litao has quit IRC | 15:49 | |
| *** arslanq has quit IRC | 15:49 | |
| mdbooth | But not because it's the operator's fault, just because it's an ephemeral fault outside Nova's control which will eventually resolve itself automatically. | 15:49 |
| bauzas | dansmith: oh wait | 15:50 |
| bauzas | dansmith: we need to keep the original AZ | 15:50 |
| bauzas | for the Spec object | 15:50 |
| *** nic has quit IRC | 15:50 | |
| bauzas | dansmith: ie. not having the Spec.az mentioning the "real" AZ | 15:50 |
| *** nic has joined #openstack-nova | 15:51 | |
| *** lucasxu has joined #openstack-nova | 15:51 | |
| dansmith | I'm not changing that | 15:51 |
| bauzas | dansmith: but if you boot an instance, it will change instance.az | 15:51 |
| dansmith | and when you finish the cleanup of the spec object usage, you'll get the original az at that point | 15:51 |
| bauzas | yeah, we need to lookup the spec | 15:52 |
| bauzas | not hydrating from the instance | 15:52 |
| dansmith | bauzas: which is the cleanup step, no? | 15:52 |
| dansmith | the TODO(bauzas) | 15:52 |
| bauzas | yup | 15:53 |
| *** nkrinner is now known as nkrinner_afk | 15:53 | |
| *** alexpilotti has quit IRC | 15:56 | |
| *** david-lyle has joined #openstack-nova | 15:56 | |
| *** ssurana has joined #openstack-nova | 15:57 | |
| *** fandi has quit IRC | 15:57 | |
| *** Sukhdev_ has joined #openstack-nova | 15:58 | |
| *** arslanq has joined #openstack-nova | 15:58 | |
| *** yingjun has quit IRC | 16:00 | |
| *** artom has joined #openstack-nova | 16:00 | |
| *** vsaienk0 has quit IRC | 16:02 | |
| *** jaosorior has quit IRC | 16:02 | |
| *** vladikr has quit IRC | 16:02 | |
| *** hongbin has quit IRC | 16:05 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove \r\n line endings from JSON sample https://review.openstack.org/446040 | 16:06 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Duplicate JSON line ending check to pep8 https://review.openstack.org/446041 | 16:06 |
| cdent | rfolco: I don't think I'm understanding your question on the DELETE stuff: "Question: Do you think we need a test for 404 and another one for nop (where microversion matches) ?" | 16:07 |
| sfinucan | Could I get someone to look at the above ^ Not possible to build docs locally while things remain this way | 16:09 |
| *** voelzmo has quit IRC | 16:09 | |
| *** raunak has joined #openstack-nova | 16:10 | |
| dansmith | bauzas: explain to me why it makes sense to boot an instance into az foo, land it in az bar, and then resize to foo? | 16:11 |
| bauzas | it's not possible if you specified a AZ | 16:12 |
| bauzas | dansmith: ^ | 16:12 |
| dansmith | bauzas: so the reason to preserve the original request is to know if they didn't request one? | 16:12 |
| bauzas | dansmith: the only case where you can be in foo and then bar is when you did *not* specify an AZ | 16:12 |
| dansmith | right, so, I'm thinking.. | 16:12 |
| *** udesale has quit IRC | 16:12 | |
| dansmith | if I don't ask, I land in bar, | 16:12 |
| dansmith | then I look in metadata, see bar, and boot one in foo to make sure I'm different, | 16:13 |
| *** kaisers_ has joined #openstack-nova | 16:13 | |
| dansmith | making the first one resize and leave bar would be kinda bad no? | 16:13 |
| rfolco | cdent, I actually was referring to 444497, if we needed to handle all possible/existing status_codes there. So, for this one you mean 409 test on gabbi ? | 16:13 |
| cdent | yeah, inventory.yaml needs a test of the 409 cases when trying to delete inventories | 16:13 |
| rfolco | cdent, gotcha, sorry for mixing things. | 16:14 |
| cdent | no problem, the process is working. | 16:14 |
| *** karimb has quit IRC | 16:15 | |
| bauzas | dansmith: that's why when you nova show the instance, you're getting the original expressed AZ | 16:15 |
| dansmith | bauzas: show from where, the rest api? | 16:15 |
| bauzas | yeah | 16:15 |
| dansmith | bauzas: okay but metadata will disagree | 16:16 |
| bauzas | I wrote a stupid disclaimer explaining how I think AZs are currently broken in Nova https://docs.openstack.org/developer/nova/aggregates.html#availability-zones-azs | 16:17 |
| *** kaisers_ has quit IRC | 16:17 | |
| dansmith | well, anyway, my point is, if we honor what the instance is currently in, or what was(n't) requested, I think we're fine | 16:17 |
| bauzas | lemme consider that | 16:18 |
| dansmith | I think if I didn't specify anything, then the cloud deciding to keep it in the same az is fine | 16:18 |
| bauzas | as I said, the real nova thing which cares about AZs is the AZfilter | 16:18 |
| bauzas | so, lemme look at the filter code | 16:18 |
| dansmith | right, but presumably it is looking at what is in the reqspec, | 16:18 |
| dansmith | which right now comes from instance.az | 16:18 |
| bauzas | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/availability_zone_filter.py#L47 | 16:18 |
| bauzas | forget the specific line | 16:19 |
| bauzas | it takes what's in the spec | 16:19 |
| dansmith | right | 16:19 |
| bauzas | and compares with if the host is in an aggregate | 16:19 |
| bauzas | if not, it defaults to the conf opt | 16:19 |
| bauzas | so | 16:20 |
| bauzas | there are two things | 16:20 |
| *** vsaienk0 has joined #openstack-nova | 16:20 | |
| bauzas | which can make you stuck within a specific AZ | 16:20 |
| bauzas | 1/ you specified an AZ in the boot command | 16:20 |
| *** dtp has joined #openstack-nova | 16:20 | |
| bauzas | in that case, we don't care whether instance.az is correct or not | 16:20 |
| *** andreas_s has quit IRC | 16:20 | |
| bauzas | because anyway, there is no way to get out of that AZ | 16:21 |
| bauzas | so, I think it's harmless | 16:21 |
| *** vladikr has joined #openstack-nova | 16:21 | |
| bauzas | now, I'm considering the other option | 16:21 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | 16:21 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | 16:21 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Set instance.availability_zone whenever we schedule https://review.openstack.org/446053 | 16:21 |
| dansmith | bauzas: ^ | 16:21 |
| bauzas | 2/ you did not specify an AZ but the operator modified default_schedule_zone | 16:21 |
| bauzas | in that case, you're stuck within an AZ | 16:22 |
| mdbooth | dansmith: In functional, _do_post seems to create an instance which has an instance mapping with cell_mapping=None. What does that mean? | 16:22 |
| dansmith | bauzas: sure but the default is to schedule into that az anyway right? | 16:22 |
| bauzas | yeah | 16:22 |
| *** sree has quit IRC | 16:22 | |
| * bauzas trying to sort that out in his mind | 16:22 | |
| *** vladikr has quit IRC | 16:23 | |
| dansmith | mdbooth: it means the instance is unscheduled | 16:23 |
| *** vladikr has joined #openstack-nova | 16:23 | |
| *** sree has joined #openstack-nova | 16:23 | |
| mdbooth | So it's not in cell0 | 16:23 |
| mdbooth | It's just not in any cell at all | 16:23 |
| mdbooth | ? | 16:23 |
| dansmith | being in cell0 means you were scheduled there | 16:24 |
| mdbooth | Right, I thought so | 16:24 |
| dansmith | being unscheduled means there is no instance record at all | 16:24 |
| *** unicell has quit IRC | 16:27 | |
| *** sree has quit IRC | 16:27 | |
| *** clayton has quit IRC | 16:28 | |
| *** crushil has joined #openstack-nova | 16:29 | |
| bauzas | dansmith: okay, I'm trying to keep things as simple as I can | 16:29 |
| bauzas | dansmith: I think we're good having instance.az being set in the conductor | 16:30 |
| bauzas | dansmith: but the problem is that we populate the Spec in the migrate method before calling the scheduler | 16:30 |
| dansmith | bauzas: didn't we _just_ discuss why that's okay? | 16:31 |
| dansmith | and the path to get out of that is you finishing your cleanup, if there's some reason for it | 16:31 |
| mriedem | sfinucan: +W on the bottom one, i hit that yesterday | 16:31 |
| mriedem | thanks | 16:31 |
| bauzas | dansmith: well, it would mean that an instance having no AZ would be kept within that AZ | 16:32 |
| dansmith | bauzas: which is by definition the default az anyway | 16:32 |
| sfinucan | mriedem: (y) | 16:32 |
| bauzas | dansmith: well, not exactly | 16:32 |
| bauzas | dansmith: if I have a cloud with 999 nodes not in aggregates and one in one aggregate with metadata AZ foo | 16:32 |
| *** clayton has joined #openstack-nova | 16:33 | |
| bauzas | dansmith: then there are chances that instances can be booted on the single host part of foo | 16:33 |
| bauzas | dansmith: which is okaty | 16:33 |
| *** mdrabe has quit IRC | 16:33 | |
| bauzas | dansmith: but then, a migrate would be only providing this host, compared to previously where it could return other hosts | 16:34 |
| *** david-lyle_ has joined #openstack-nova | 16:34 | |
| *** david-lyle has quit IRC | 16:34 | |
| *** fragatina has joined #openstack-nova | 16:34 | |
| dansmith | bauzas: yeah, but.. again, the fix for that is finishing the reqspec cleanup right? | 16:34 |
| bauzas | yup | 16:34 |
| *** faizy has quit IRC | 16:35 | |
| bauzas | I see your point | 16:35 |
| * bauzas rolling his sleeves | 16:35 | |
| *** alexpilotti has joined #openstack-nova | 16:35 | |
| dansmith | I don't think this is overly harmful if you're going to clean that bit up before the end of pike | 16:36 |
| *** sandanar has quit IRC | 16:36 | |
| *** annegentle has joined #openstack-nova | 16:37 | |
| *** eharney has quit IRC | 16:37 | |
| *** sandanar has joined #openstack-nova | 16:37 | |
| *** vladikr has quit IRC | 16:38 | |
| bauzas | dansmith: anyway, just reviewed your new change, you're updating instance.az after we regenerate the Spec, so it's all good | 16:39 |
| *** alexpilotti has quit IRC | 16:39 | |
| dansmith | bauzas: no because we updated it on boot to the host we got to | 16:39 |
| dansmith | bauzas: so resize will see that az | 16:39 |
| bauzas | correct | 16:39 |
| bauzas | nevermind the previous comment | 16:39 |
| dansmith | bauzas: for this: https://review.openstack.org/#/c/442163/14/nova/availability_zones.py | 16:40 |
| bauzas | yup ? | 16:40 |
| dansmith | bauzas: I think I just want to make sure that the az thing calls the hostapi for listing services, | 16:40 |
| dansmith | and then make sure I cover that method to ensure it iterates cells, okay? | 16:40 |
| bauzas | yeah, like I said, I'm not opposed to merging this | 16:40 |
| bauzas | I was just thinking of our test very not aware of cells | 16:41 |
| bauzas | which could be a problem in the future given it's a DB-backed test case | 16:41 |
| *** Apoorva has joined #openstack-nova | 16:41 | |
| dansmith | I don't think it really needs to be, as long as it's getting the right service list, | 16:41 |
| dansmith | but converting it is going to be somework | 16:42 |
| bauzas | yeah | 16:42 |
| bauzas | I'm turning my vote to +2 | 16:42 |
| bauzas | I'm just reviewing the conductor change | 16:42 |
| dansmith | a functional test might be easier for that anyway, since they already have multiple cells | 16:42 |
| *** mdrabe has joined #openstack-nova | 16:43 | |
| *** kaisers_ has joined #openstack-nova | 16:43 | |
| *** fragatin_ has joined #openstack-nova | 16:44 | |
| *** yamahata has quit IRC | 16:45 | |
| *** lpetrut has quit IRC | 16:45 | |
| *** bmace has joined #openstack-nova | 16:47 | |
| *** fragatina has quit IRC | 16:47 | |
| *** lucasxu has quit IRC | 16:47 | |
| *** lucasxu has joined #openstack-nova | 16:48 | |
| *** Sukhdev_ has quit IRC | 16:48 | |
| *** gyee has joined #openstack-nova | 16:50 | |
| bauzas | dansmith: I agree, most of the AZ unittests could be done in the functional tree even | 16:50 |
| mriedem | dansmith: are we doing a cells pow wow in 10 min? | 16:50 |
| mriedem | i hope so because 3 days in working from home and i'm starting to get lonely | 16:51 |
| dansmith | mriedem: oh yeah | 16:52 |
| bauzas | mriedem: dansmith: I won't be able to attend it | 16:52 |
| dansmith | mriedem: man, you're going to have a hard road ahead then :) | 16:52 |
| dansmith | bauzas: ack | 16:52 |
| * bauzas needs to find a new nanny for his kid | 16:52 | |
| *** tesseract has quit IRC | 16:53 | |
| *** baoli has quit IRC | 16:56 | |
| dansmith | bauzas: hmm, the notification sample test is failing because I end up with None for my az instead of 'nova' | 16:56 |
| *** baoli has joined #openstack-nova | 16:56 | |
| dansmith | so I guess I need to replicate that "or the default" logic in there somehwere | 16:57 |
| *** baoli has quit IRC | 16:58 | |
| dansmith | er, actually it should be in there already | 16:58 |
| dansmith | guh this is ugly | 16:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Fix formatting errors and warnings https://review.openstack.org/407364 | 17:00 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: tox: Build docs with Python 2.7 https://review.openstack.org/445906 | 17:00 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Treat doc build warnings as errors https://review.openstack.org/439883 | 17:00 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add .keep files https://review.openstack.org/446069 | 17:00 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Introduce fast8 tox target https://review.openstack.org/446070 | 17:02 |
| *** vladikr has joined #openstack-nova | 17:02 | |
| mriedem | melwitt: just for you ^ | 17:02 |
| mriedem | (and me) | 17:02 |
| *** p01nt3r75 has quit IRC | 17:03 | |
| *** raunak has quit IRC | 17:03 | |
| openstackgerrit | Kaitlin Farr proposed openstack/nova master: Parse algorithm from cipher for ephemeral disk encryption https://review.openstack.org/446072 | 17:04 |
| *** satyar has quit IRC | 17:04 | |
| *** raunak has joined #openstack-nova | 17:04 | |
| melwitt | mriedem: <3 | 17:05 |
| *** unicell has joined #openstack-nova | 17:05 | |
| *** unicell has quit IRC | 17:05 | |
| *** satyar has joined #openstack-nova | 17:05 | |
| melwitt | fast8, sounds like another fast and the furious movie | 17:05 |
| mdbooth | mriedem: -- -HEAD is hardwired into my fingers now | 17:06 |
| * mdbooth has trouble not typing it when running pep8 | 17:06 | |
| *** satyar has quit IRC | 17:06 | |
| *** baoli has joined #openstack-nova | 17:06 | |
| mriedem | mdbooth: i used to forget it, but yeah i have it like that too now | 17:07 |
| mriedem | but some people didn't even know it existed | 17:07 |
| mriedem | hence this | 17:07 |
| * mdbooth would definitely use fast8 *a lot* | 17:07 | |
| mriedem | melwitt: let's call it tox -e niccage then | 17:07 |
| mriedem | oh wait, wrong movie | 17:07 |
| mdbooth | jason staitham? | 17:07 |
| melwitt | you're probably thinking of xander cage | 17:08 |
| mdbooth | however you spell that | 17:08 |
| * mdbooth assumes this is a F&F reference, but he never really got into that series | 17:08 | |
| *** xinliang has quit IRC | 17:08 | |
| sfinucan | mdbooth is missing out | 17:09 |
| sfinucan | ...and it's a xXx reference (also awesome) | 17:09 |
| jroll | tox -e ludacris, duh | 17:09 |
| kashyap | mdbooth: JSON statham | 17:09 |
| mdbooth | kashyap: hehe | 17:09 |
| jroll | both for the actor in F&F and because ludicrous speed | 17:09 |
| mdbooth | sfinucan: Do you like the Transformers movies? | 17:09 |
| sfinucan | mdbooth: Nope. All them robots fighting sounds too much like nightclub music | 17:10 |
| sfinucan | #dubstep4lyf | 17:10 |
| melwitt | same. I like F&F and xXx but not transformers | 17:10 |
| mdbooth | sfinucan: Ok, we may have some movie taste in common :) | 17:10 |
| mdbooth | Perhaps I'll try it. | 17:10 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add InstanceMappingList.get_by_instance_uuids https://review.openstack.org/445139 | 17:11 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Make server_external_events use an optimal number of db queries https://review.openstack.org/445142 | 17:11 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add RequestContext.for_cell() https://review.openstack.org/445140 | 17:11 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add InstanceList.get_by_instance_mapping_list() https://review.openstack.org/445141 | 17:11 |
| sfinucan | mdbooth: It's all Vin Diesel. He's just ridiculously likeable/charismatic | 17:11 |
| mdbooth | The Groot guy? | 17:11 |
| * mdbooth has probably seen him in something else | 17:11 | |
| sfinucan | The one and only | 17:12 |
| *** lucasxu has quit IRC | 17:12 | |
| *** lucasxu has joined #openstack-nova | 17:13 | |
| *** rtheis has joined #openstack-nova | 17:13 | |
| * mriedem goes to make a sandwich and talk to the cat | 17:14 | |
| *** rtheis has quit IRC | 17:16 | |
| *** erlon has joined #openstack-nova | 17:19 | |
| lyarwood | mdbooth: are you reviewing the rest of the bdm db and object change series btw? The UUID changes aren't that important overall, the attachment_id changes are the real priority | 17:20 |
| *** Swami has joined #openstack-nova | 17:20 | |
| mdbooth | lyarwood: Yes. However I got distracted by a 5 minute job which took rather longer. | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Set instance.availability_zone whenever we schedule https://review.openstack.org/446053 | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | 17:20 |
| lyarwood | mdbooth: np, just got back in from a walk myself | 17:21 |
| rfolco | cdent, I got stuck on 409 conflict test case for delete all inventory. a fake generation number maybe ? | 17:21 |
| *** xinliang has joined #openstack-nova | 17:21 | |
| *** xinliang has joined #openstack-nova | 17:21 | |
| *** alexpilotti has joined #openstack-nova | 17:22 | |
| *** browne has joined #openstack-nova | 17:22 | |
| *** yamahata has joined #openstack-nova | 17:24 | |
| *** satyar has joined #openstack-nova | 17:27 | |
| *** pcaruana has quit IRC | 17:28 | |
| *** bvanhav__ is now known as bvanhav | 17:28 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Re-add templates https://review.openstack.org/446069 | 17:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Fix formatting errors and warnings https://review.openstack.org/407364 | 17:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: tox: Build docs with Python 2.7 https://review.openstack.org/445906 | 17:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Treat doc build warnings as errors https://review.openstack.org/439883 | 17:28 |
| *** unicell has joined #openstack-nova | 17:28 | |
| *** unicell has quit IRC | 17:29 | |
| cdent | rfolco: there are two different cases: one where the generation is wrong (so a fake one would work), one where some of the inventory is in use (make some inventory, make an allocation against that inventory, try to do the DELETE). make sense? | 17:29 |
| *** iceyao has quit IRC | 17:30 | |
| rfolco | cdent, hmm, will try to find the allocation example. thx | 17:31 |
| *** ltomasbo is now known as ltomasbo|away | 17:32 | |
| cdent | rfolco: there are some examples in allocation.yaml and with-allocations.yaml | 17:32 |
| *** bvanhav_ has joined #openstack-nova | 17:32 | |
| cdent | rfolco: in fact you could probably add a DELETE .../inventories in the with-allocations.yaml file and the existing allocations will provide the data for you | 17:33 |
| *** unicell has joined #openstack-nova | 17:33 | |
| *** bvanhav has quit IRC | 17:33 | |
| rfolco | cdent, stop, you're almost writing the test for me :) | 17:34 |
| cdent | :) | 17:34 |
| *** Sukhdev_ has joined #openstack-nova | 17:34 | |
| mdbooth | lyarwood: Given that I'm conflicted myself on bdm.uuid naming issue, I'm going to drop that to bikeshed status and leave it up to you. | 17:35 |
| mdbooth | Either way it's weird. | 17:36 |
| *** moshele has joined #openstack-nova | 17:37 | |
| lyarwood | mdbooth: yeah agreed that it's weird, I assume it's a hangover from copying BDMs the ec2 api | 17:37 |
| lyarwood | from the ec2 api even | 17:38 |
| *** szaher has joined #openstack-nova | 17:39 | |
| *** jed56 has quit IRC | 17:40 | |
| mdbooth | lyarwood: We're absolutely never going to have more than 1 BDM with the same attachment_id, right? Just confirming that makes absolutely no sense. | 17:42 |
| lyarwood | mdbooth: right, it's unique to along with the instance_uuid and volume_id iirc, pretty sure the spec calls that out /me checks | 17:44 |
| mdbooth | lyarwood: I can't think how it would make sense. | 17:44 |
| lyarwood | mdbooth: to have >1 bdms with the same attachment_id? | 17:45 |
| *** rebase has joined #openstack-nova | 17:45 | |
| mdbooth | lyarwood: Yes | 17:45 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | 17:45 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Set instance.availability_zone whenever we schedule https://review.openstack.org/446053 | 17:45 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | 17:45 |
| lyarwood | mdbooth: yeah, I can't think of a use case | 17:46 |
| rebase | /que/close | 17:46 |
| *** rebase has left #openstack-nova | 17:46 | |
| *** derekh has quit IRC | 17:47 | |
| lyarwood | mdbooth: from the spec '* Volume attachment is specific to a host uuid, instance uuid, and volume uuid' | 17:47 |
| mdbooth | lyarwood: Cool, so dup attachment_id would definitely be a bug | 17:48 |
| * mdbooth is asking for a unique constraint on it | 17:48 | |
| lyarwood | mdbooth: yeah mriedem suggested that already but as its nullable some backends might not allow it iirc | 17:49 |
| lyarwood | mdbooth: but ask away and I can take another look | 17:49 |
| mdbooth | lyarwood: ah, good point | 17:49 |
| mriedem | mysql is fine with it a unique constraint over a nullable column | 17:49 |
| *** lpetrut has joined #openstack-nova | 17:50 | |
| mdbooth | mriedem: Does it allow more than 1 null? | 17:50 |
| mriedem | i think postgres is too, but i think both can be configured to be more strict | 17:50 |
| mriedem | mdbooth: not sure about that, i'd hope not | 17:50 |
| mdbooth | In that case it wouldn't work here, which is unfortunate | 17:50 |
| mriedem | to be clear, i was thinking of db2 when i said the constraint thing, because of muscle memory, but i know we don't support or care about db2 | 17:50 |
| * mdbooth would just generally like to see more constraints in our db schema | 17:51 | |
| *** efried has joined #openstack-nova | 17:51 | |
| mdbooth | They make debugging easier | 17:51 |
| mdbooth | lyarwood: Incidentally, on the bdm.uuid thing, couldn't we mass populate that with an online migration? | 17:52 |
| *** unicell has quit IRC | 17:53 | |
| mdbooth | lyarwood: Same for attachment_id now that I think of it, if cinder gives us an api to create an attachment for a legacy-attached volume. | 17:55 |
| *** armax has quit IRC | 17:55 | |
| * mdbooth doesn't even know if that's possible, though | 17:55 | |
| lyarwood | mdbooth: I think that did come up for attachment_id but I don't think there's anything for us to call atm | 17:56 |
| lyarwood | mdbooth: I can't find it at the moment but I'm sure there's also a comment against doing this for uuids btw | 17:57 |
| * lyarwood will look again after dinner brb | 17:57 | |
| *** smatzek_ has joined #openstack-nova | 18:00 | |
| *** smatzek has quit IRC | 18:00 | |
| *** stvnoyes1 has quit IRC | 18:00 | |
| mriedem | johnthetubaguy: i've reviewed the policy doc spec https://review.openstack.org/#/c/433010/ | 18:02 |
| *** burt has joined #openstack-nova | 18:02 | |
| mriedem | johnthetubaguy: some niggles inline | 18:02 |
| *** liangy has quit IRC | 18:03 | |
| mriedem | see what i did there, with your word? | 18:03 |
| johnthetubaguy | mriedem: looking | 18:03 |
| johnthetubaguy | mriedem: I totally did :) | 18:03 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | 18:03 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163 | 18:03 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Set instance.availability_zone whenever we schedule https://review.openstack.org/446053 | 18:03 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | 18:03 |
| *** stvnoyes has joined #openstack-nova | 18:04 | |
| *** efoley_ has joined #openstack-nova | 18:04 | |
| *** marst has quit IRC | 18:05 | |
| *** marst has joined #openstack-nova | 18:05 | |
| *** lpetrut has quit IRC | 18:06 | |
| *** Sukhdev_ has quit IRC | 18:07 | |
| *** efoley__ has quit IRC | 18:08 | |
| mdbooth | lyarwood: Next 3 are the meaty ones. I'll start them in the morning. | 18:09 |
| *** baoli has quit IRC | 18:09 | |
| *** efoley_ has quit IRC | 18:09 | |
| *** baoli has joined #openstack-nova | 18:10 | |
| *** lucasxu has quit IRC | 18:13 | |
| mriedem | cdent: edleafe: has anyone brought up the microversion question in https://review.openstack.org/#/c/433010/ yet? | 18:14 |
| mriedem | or is that restriction already in place in the object code somewhere? | 18:14 |
| *** baoli has quit IRC | 18:14 | |
| * edleafe reads up on that spec | 18:15 | |
| mriedem | sorry wrong link | 18:15 |
| cdent | sorry, mriedem, I'm not sure I've got enough context | 18:15 |
| mriedem | https://review.openstack.org/#/c/416752/ | 18:15 |
| cdent | oh that one | 18:15 |
| mriedem | normally changing the request schema validation is a microversion bump | 18:15 |
| mriedem | does the object code already enforce this? | 18:15 |
| *** sandanar has quit IRC | 18:16 | |
| cdent | mriedem: this is a case of: if you did it wrong then there would be big failures (of the things won't work at all variety) | 18:16 |
| cdent | so this fix is akin to going from 500 to "actually working" | 18:16 |
| *** lucasxu has joined #openstack-nova | 18:16 | |
| cdent | it just so happens that existing client code doesn't tickle these problems | 18:16 |
| edleafe | yeah, I was thinking it's more like a bug fix rather than a straight behavior change | 18:17 |
| mriedem | i'm legally obligated to ask about microversions you know | 18:18 |
| mriedem | certified by the great state of minnesota | 18:18 |
| cdent | mriedem: everyone appreciates your assiduousness | 18:18 |
| *** gyee has quit IRC | 18:18 | |
| edleafe | even non-Minnesotans | 18:19 |
| * cdent got a nice warm hat in minnesota, once upon a time | 18:19 | |
| *** baoli has joined #openstack-nova | 18:22 | |
| mriedem | next question: do we plan on backporting this fix to ocata? | 18:22 |
| *** hshiina has joined #openstack-nova | 18:22 | |
| cdent | mriedem: I'd say it is a nice to have, probably even a good to have, but not a must have? | 18:23 |
| cdent | without these changes it is possible for a careless admin to cause trouble | 18:23 |
| cdent | but they have try hard | 18:24 |
| mriedem | if we want to backport we should tie these to a bug | 18:24 |
| *** lpetrut has joined #openstack-nova | 18:24 | |
| *** moshele has quit IRC | 18:25 | |
| cdent | weird, I thought it already was, but apparently not | 18:25 |
| cdent | edleafe: I'll make a bug and you can update? | 18:25 |
| *** krtaylor has quit IRC | 18:26 | |
| edleafe | cdent: sure thing | 18:26 |
| *** smatzek_ has quit IRC | 18:27 | |
| *** unicell has joined #openstack-nova | 18:27 | |
| *** gszasz has quit IRC | 18:27 | |
| *** marst has quit IRC | 18:28 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add policy-docs spec https://review.openstack.org/433010 | 18:29 |
| *** armax has joined #openstack-nova | 18:30 | |
| *** READ10 has quit IRC | 18:30 | |
| mriedem | cdent: edleafe: i'm also not sure about the default changes in here https://review.openstack.org/#/c/428800/ | 18:30 |
| mriedem | that gets a bit weird with ironic custom resource classes that claim 1 for everything | 18:30 |
| mriedem | has jaypipes taken a look at that? | 18:30 |
| johnthetubaguy | mriedem: added a note about the new oslo thing, and a hacking check to ensure we use the new method that enforces the description is filled | 18:30 |
| mriedem | johnthetubaguy: ok, looking | 18:30 |
| jaypipes | mriedem: not yet | 18:31 |
| cdent | mriedem: those only come into play if the inventory doesn't specify | 18:31 |
| mriedem | cdent: right, and min_unit/max_unit aren't required, | 18:31 |
| cdent | and in their old form it was possible to say a max_unit of zero, which makes no logical sense | 18:31 |
| mriedem | so a lazy client could just not provide them | 18:31 |
| mriedem | yeah | 18:32 |
| cdent | so max int is correct | 18:32 |
| mriedem | i know i'm overthinking this | 18:32 |
| cdent | (even though you probably wouldn't want it to be set that) | 18:32 |
| edleafe | the old default of max_unit=0 was definitely wrong | 18:32 |
| mriedem | so if we shouldn't be guessing, why is max_unit optional? | 18:33 |
| *** marst has joined #openstack-nova | 18:33 | |
| mriedem | oh well, | 18:33 |
| edleafe | mriedem: they should be able to request as much inventory as is available, unless it's been configured to be restricted | 18:33 |
| mriedem | i guess if total is maxint, and stepsize is 1, then by default you can have one unit of maxint | 18:33 |
| *** karimb has joined #openstack-nova | 18:33 | |
| cdent | I'm trying to make sure the bug report covers everything, including some cases not currently covered in ed's changes | 18:34 |
| melwitt | johnthetubaguy: while you're still around, just a reminder that the quota counting patch is ready for review at your convenience. I think I addressed all of your comments. | 18:35 |
| jaypipes | mriedem: I'm good with that patch. | 18:35 |
| jaypipes | mriedem: though the total should have a minimum, as johnthetubaguy mentioned. | 18:36 |
| mriedem | what happens if i don't specify max_unit, and total=1024, then i request an allocation of 2048? | 18:36 |
| cdent | edleafe, jaypipes, mriedem : please review this bug, I _think_ I covered everything (including the thing jay just said): https://bugs.launchpad.net/nova/+bug/1673227 | 18:36 |
| openstack | Launchpad bug 1673227 in OpenStack Compute (nova) "placement apis for inventory and allocations use insufficiently robust jsonschema" [Undecided,Triaged] | 18:36 |
| mriedem | where does that fail? | 18:36 |
| cdent | mriedem: that will fail at the db layer | 18:37 |
| mriedem | max_unit will default to maxint, total will be 1024 and i'll request 2048 | 18:37 |
| jaypipes | cdent: ++ | 18:37 |
| *** unicell has quit IRC | 18:37 | |
| cdent | since 2048 > (total - use * allocation.ratio) FAIL | 18:38 |
| cdent | YPMV | 18:38 |
| mriedem | i think also here right? https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L1043 | 18:38 |
| *** voelzmo has joined #openstack-nova | 18:39 | |
| cdent | mriedem: that's what I'm calling the db layer | 18:39 |
| *** jpena is now known as jpena|off | 18:39 | |
| cdent | mriedem: but that specific line doesn't involve the total | 18:39 |
| cdent | you want 1062 for that | 18:39 |
| mriedem | and that's handled as a 409 in the PUT /allocations handler | 18:40 |
| *** eharney has joined #openstack-nova | 18:40 | |
| mriedem | ok | 18:40 |
| * cdent nods | 18:40 | |
| *** gcb has quit IRC | 18:40 | |
| *** unicell has joined #openstack-nova | 18:41 | |
| edleafe | cdent: the bug lgtm | 18:41 |
| *** bnemec has quit IRC | 18:41 | |
| johnthetubaguy | melwitt: ah, thats going to be tomorrow, but I should make sure I hit that again | 18:41 |
| mriedem | heh, "insufficiently robust" | 18:41 |
| cdent | edleafe: I think it add at least one, and maybe two things for your code | 18:41 |
| *** abalutoiu has quit IRC | 18:41 | |
| edleafe | cdent: yeah, I'll look into that as soon as I can push the functional stuff | 18:42 |
| cdent | ✔ | 18:42 |
| melwitt | johnthetubaguy: it's not urgent, just wanted to remind you about it. thanks :) | 18:42 |
| mriedem | cdent: in the bug report, "* reserved and total need a minimum, probably of 0 and 1 respectively" | 18:42 |
| mriedem | reserved should not be a min of 1 | 18:42 |
| mriedem | oh wait, i see | 18:43 |
| mriedem | "respectively" | 18:43 |
| cdent | I included that "probably" in there because I wasn't sure if there was a use case for total having a min of 0 | 18:43 |
| *** unicell1 has joined #openstack-nova | 18:44 | |
| cdent | I think, however, we decided that anything which is inventory total 0 is inventory that should not be reported | 18:44 |
| mriedem | total nothingness | 18:44 |
| *** unicell has quit IRC | 18:44 | |
| mriedem | i think once you hit 0 you actually get to nirvana | 18:44 |
| *** bnemec has joined #openstack-nova | 18:44 | |
| *** liangy has joined #openstack-nova | 18:45 | |
| cdent | however, now that I think about it: jaypipes: should it be possible to set an existing inventory to 0 capacity for some reason? ("this thing is here but not really") | 18:45 |
| jaypipes | cdent: no | 18:45 |
| cdent | straight answer \o/ | 18:45 |
| jaypipes | :) | 18:45 |
| edleafe | cdent: I have an inventory of 0 Rolls Royces | 18:46 |
| cdent | omg, so do I! | 18:46 |
| mriedem | dansmith frequently claims to have an inventory of 0 fucks | 18:47 |
| *** unicell1 has quit IRC | 18:47 | |
| mriedem | you know placement is getting traction when you can use it in casual conversation | 18:48 |
| mriedem | sdague: i'm +2 on johnthetubaguy's policy docs spec now https://review.openstack.org/#/c/433010/ | 18:48 |
| mriedem | it's pretty straight-forward | 18:48 |
| *** catinthe_ has joined #openstack-nova | 18:48 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: virt: implement get_inventory() for Ironic https://review.openstack.org/441544 | 18:49 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Refactor placement fixtures https://review.openstack.org/446122 | 18:49 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - add some functional tests for placement https://review.openstack.org/446123 | 18:49 |
| * cdent decided not to think too hard about allocating or filtering dan's fucks | 18:49 | |
| edleafe | jaypipes: looks like your ironic inventory patch was rebased | 18:49 |
| edleafe | cdent: the last one above ^^ is the attempt at functional tests for placement | 18:50 |
| *** afazekas_ is now known as afazekas | 18:50 | |
| *** unicell has joined #openstack-nova | 18:50 | |
| cdent | looking edleafe | 18:50 |
| *** raunak has quit IRC | 18:51 | |
| *** smatzek has joined #openstack-nova | 18:51 | |
| *** catintheroof has quit IRC | 18:51 | |
| *** karimb has quit IRC | 18:52 | |
| *** voelzmo has quit IRC | 18:53 | |
| *** gcb has joined #openstack-nova | 18:53 | |
| *** unicell has quit IRC | 18:53 | |
| *** marst has quit IRC | 18:54 | |
| cdent | the other method you want, for inventory setting, is _update() | 18:55 |
| *** hshiina has quit IRC | 18:55 | |
| *** marst has joined #openstack-nova | 18:55 | |
| *** unicell has joined #openstack-nova | 18:56 | |
| cdent | edleafe: of your could kill two birds with update_usage() | 18:56 |
| *** annegentle has quit IRC | 18:58 | |
| edleafe | cdent: stepping into a meeting, but will dig into that after | 18:59 |
| cdent | sorry for your luck | 18:59 |
| edleafe | cdent: hey, only 2 today! | 19:00 |
| cdent | great success? | 19:00 |
| *** JoseMello has joined #openstack-nova | 19:01 | |
| *** fragatin_ has quit IRC | 19:02 | |
| *** fragatina has joined #openstack-nova | 19:02 | |
| *** stvnoyes has quit IRC | 19:08 | |
| *** stvnoyes has joined #openstack-nova | 19:09 | |
| *** nic has quit IRC | 19:14 | |
| * cdent waves goodnight | 19:15 | |
| *** cdent has quit IRC | 19:15 | |
| *** krtaylor has joined #openstack-nova | 19:16 | |
| jaypipes | edleafe: did you change anything in the patch you just rebased? | 19:17 |
| *** nic has joined #openstack-nova | 19:17 | |
| *** zhangqiankun has quit IRC | 19:18 | |
| *** amoralej is now known as amoralej|off | 19:20 | |
| *** marst has quit IRC | 19:22 | |
| *** Sukhdev has joined #openstack-nova | 19:23 | |
| *** smatzek has quit IRC | 19:30 | |
| *** stvnoyes has left #openstack-nova | 19:30 | |
| *** zioproto has quit IRC | 19:31 | |
| *** raunak has joined #openstack-nova | 19:32 | |
| *** bvanhav_ has quit IRC | 19:36 | |
| *** ociuhandu has quit IRC | 19:39 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: virt: implement get_inventory() for Ironic https://review.openstack.org/441544 | 19:40 |
| jaypipes | mriedem: ok, ready for you ^ | 19:40 |
| *** kylek3h has quit IRC | 19:42 | |
| *** tbachman has quit IRC | 19:42 | |
| *** voelzmo has joined #openstack-nova | 19:42 | |
| *** fandi has joined #openstack-nova | 19:43 | |
| edleafe | jaypipes: nope. Mine just built on yours | 19:43 |
| *** vgadiraj has quit IRC | 19:45 | |
| *** aunnam has quit IRC | 19:45 | |
| *** dharinic has quit IRC | 19:45 | |
| *** raj_singh has quit IRC | 19:45 | |
| *** pumaranikar has quit IRC | 19:45 | |
| *** sneti has quit IRC | 19:45 | |
| *** manjeets has quit IRC | 19:45 | |
| *** siva_krishnan has quit IRC | 19:45 | |
| *** tbachman has joined #openstack-nova | 19:48 | |
| mriedem | jaypipes: you missed one little thing https://review.openstack.org/#/c/441544/9 | 19:52 |
| *** whenry has joined #openstack-nova | 19:55 | |
| *** david-lyle_ is now known as david-lyle | 19:57 | |
| *** awaugama has quit IRC | 20:00 | |
| *** Sukhdev has quit IRC | 20:02 | |
| *** voelzmo has quit IRC | 20:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: virt: implement get_inventory() for Ironic https://review.openstack.org/441544 | 20:05 |
| mriedem | jaypipes: nvm, i got it, +2 | 20:06 |
| mriedem | dansmith: ^ it's all yours now | 20:06 |
| *** gus has quit IRC | 20:07 | |
| dansmith | mriedem: k in a sec | 20:07 |
| *** rdo has quit IRC | 20:09 | |
| *** gus has joined #openstack-nova | 20:09 | |
| *** rdo has joined #openstack-nova | 20:11 | |
| efried | jaypipes Before I try to grok your blueprint and the above change set, does there exist a quick-and-dirty guide entitled "How to convert my compute driver from get_available_resource to get_inventory"? | 20:12 |
| *** hongbin has joined #openstack-nova | 20:13 | |
| jaypipes | mriedem: thx | 20:16 |
| *** smatzek has joined #openstack-nova | 20:17 | |
| jaypipes | efried: hi :) no, there's no guide other than looking at the above patch. | 20:17 |
| mriedem | efried: it's probably easiest to just look at that ironic patch | 20:18 |
| mriedem | for get_inventory | 20:18 |
| jaypipes | efried: basically just needs to return a dict of inventory information for each resource class the driver understands. | 20:18 |
| efried | mriedem jaypipes Okay, that's where I was going to go. Guess you guys will be reviewing the change one way or another, so you'll catch me if I eff it up... | 20:19 |
| *** marst has joined #openstack-nova | 20:19 | |
| mriedem | if you eff it up the resource tracker will probably give you a KeyError | 20:19 |
| mriedem | it's all self testing, like most everything in nova, rock solid | 20:19 |
| efried | But of course. | 20:19 |
| mriedem | wtf, why is RequestSpec.forced_hosts a list when you can only provide one value in the API when creating a server? | 20:25 |
| mriedem | bauzas: ^? | 20:25 |
| *** marst_ has joined #openstack-nova | 20:25 | |
| *** smatzek has quit IRC | 20:25 | |
| mriedem | please oh please don't say future proofing | 20:25 |
| *** marst has quit IRC | 20:28 | |
| bauzas | mriedem: because you can provide a list AFAIK | 20:28 |
| bauzas | lemme verify this | 20:28 |
| melwitt | yeah, from what I find I think the scheduler hint is force_hosts as a list? | 20:29 |
| *** dave-mccowan has quit IRC | 20:29 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L579 is not a list | 20:29 |
| mriedem | it's a scheduler hint? | 20:29 |
| bauzas | okay, can't find a reasonable answer | 20:30 |
| melwitt | I'll wait for bauzas to let us know what's the deal | 20:30 |
| mriedem | it's not a scheduler hint that's checked in any in-tree filters | 20:31 |
| melwitt | it seems like it coincides with the scheduler hint, but why it's baked into RequestSpec, I don't know the history on that | 20:31 |
| bauzas | mriedem: melwitt: no, forced_hosts is in the host manager | 20:31 |
| *** READ10 has joined #openstack-nova | 20:31 | |
| mriedem | the scheduler hint for groups? | 20:31 |
| melwitt | yeah, forcing a host isn't part of any specific filter. it happens before filtering and will bypass filtering | 20:31 |
| bauzas | yeah that | 20:31 |
| mriedem | ok but there is also this https://docs.openstack.org/admin-guide/cli-nova-specify-host.html | 20:32 |
| bauzas | mriedem: yeah, because it's a terrible UX | 20:32 |
| mriedem | i know it's not part of a filter, but i'm trying to figure out how it becomes a list, | 20:32 |
| bauzas | forced_hosts is set by the AZ flag | 20:32 |
| mriedem | because the only thing i see that sets forced_hosts in the request spec comes through the REST API using the az parsing in ^ | 20:33 |
| bauzas | mriedem: honestly, I don't remember why, lemme verify the change | 20:33 |
| *** ociuhandu has joined #openstack-nova | 20:33 | |
| mriedem | those docs are also a bit wrong btw, they say "HOST is an optional parameter. In such cases, use the --availability-zone ZONE::NODE." - but they fail to mention that NODE is also an optional parameter | 20:33 |
| *** sneti has joined #openstack-nova | 20:34 | |
| bauzas | node was added later | 20:34 |
| bauzas | because of $ironic :) | 20:34 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add check for invalid inventory amounts https://review.openstack.org/428800 | 20:34 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add check for invalid allocation amounts https://review.openstack.org/416752 | 20:34 |
| edleafe | jaypipes: mriedem: updated ^^ | 20:34 |
| jaypipes | cool | 20:35 |
| *** crushil has quit IRC | 20:35 | |
| *** crushil has joined #openstack-nova | 20:36 | |
| *** marst_ has quit IRC | 20:36 | |
| bauzas | mriedem: so, in between PS7 and PS8, I modified force_hosts to be a list | 20:37 |
| bauzas | https://review.openstack.org/#/c/145528/8..9/nova/objects/request_spec.py | 20:37 |
| bauzas | I'm trying to remember the context why | 20:37 |
| mriedem | 8..9, butok | 20:37 |
| bauzas | mmm | 20:38 |
| mriedem | it's 46 patch sets is hurting my browser | 20:38 |
| bauzas | so, the only reason I see that is because filter_props was having a list | 20:39 |
| bauzas | it's not what I say a reasonable answer, so lemme verify why we have a list for the legacy dict | 20:40 |
| *** gus has quit IRC | 20:40 | |
| mriedem | i smell a rackspace reason here | 20:40 |
| *** raj_singh has joined #openstack-nova | 20:41 | |
| bauzas | at least the host manager waits for a list | 20:41 |
| bauzas | and I haven't changed that | 20:41 |
| bauzas | so somewhere we accepted a list | 20:41 |
| bauzas | yeah... build_filter_properties() in nova.scheduler.utils | 20:42 |
| bauzas | mriedem: ^ | 20:42 |
| *** gus has joined #openstack-nova | 20:42 | |
| *** crushil has quit IRC | 20:42 | |
| mriedem | https://github.com/openstack/nova/commit/90620a27e0831345864f574256b30bac1ced5843 | 20:43 |
| bauzas | mriedem: https://github.com/openstack/nova/commit/9998c51f | 20:43 |
| *** haplo37 has quit IRC | 20:43 | |
| mriedem | https://github.com/openstack/nova/commit/90620a27e0831345864f574256b30bac1ced5843 goes back to havana, | 20:43 |
| bauzas | mriedem: sure, but both don't explain why we want a list | 20:43 |
| mriedem | and appears to introduce the idea that forced_hosts is a list | 20:43 |
| mriedem | could have been a mistake if the key was named "force_hosts" so plural | 20:44 |
| mriedem | https://github.com/openstack/nova/blob/90620a27e0831345864f574256b30bac1ced5843/nova/compute/api.py#L727 | 20:44 |
| bauzas | we should go back where force_hosts was originally created | 20:44 |
| mriedem | i'm going | 20:45 |
| bauzas | yeah, like I said there are a shit ton of places where we expect a list | 20:45 |
| bauzas | so I shamelessly copied that | 20:45 |
| *** satyar has quit IRC | 20:46 | |
| bauzas | although I originally found it was a string like I wrote in my PS8 | 20:46 |
| bauzas | defeated by tech debt | 20:46 |
| mriedem | https://github.com/openstack/nova/commit/7b34a2d767b60e053ac1f49d1cdd8c853b8d9133 | 20:47 |
| mriedem | is about as far back as i see | 20:47 |
| mriedem | oh wait it goes further | 20:48 |
| bauzas | https://github.com/openstack/nova/commit/836ee3f45 | 20:48 |
| jroll | don't you guys know to always blame comstud by now | 20:49 |
| mriedem | https://github.com/openstack/nova/commit/16ea348a1623f055809d0d9b7fe9f046515b5dd1 | 20:51 |
| melwitt | I was seeing some stuff from essex | 20:51 |
| *** voelzmo has joined #openstack-nova | 20:51 | |
| mriedem | ^ is essex | 20:51 |
| bauzas | yeah I was an diablo op and I don't remember that feature | 20:52 |
| melwitt | hah, nice | 20:52 |
| *** haplo37 has joined #openstack-nova | 20:52 | |
| bauzas | I just remember Essex added lots of things like that | 20:52 |
| bauzas | but it's very old stories at the corner of the fireplace | 20:52 |
| *** voelzmo has quit IRC | 20:52 | |
| bauzas | soooo... to answer mriedem's question, I guess that the terrible answer he was afraid was the correct one | 20:53 |
| bauzas | ie. "we planned that for the future" | 20:53 |
| bauzas | just give me a license to kill that AZ hack, and I'll write a specx | 20:54 |
| melwitt | it was maybe mirroring ignore_hosts, which was already there when force_hosts was added | 20:54 |
| bauzas | yeah | 20:55 |
| *** gouthamr has quit IRC | 20:55 | |
| bauzas | anyway, force_hosts is a legacy from the past, and we should get rid of it | 20:55 |
| mriedem | i'm not necessarily saying let's remove it, | 20:55 |
| bauzas | I'm saying it :p | 20:55 |
| *** dimtruck is now known as zz_dimtruck | 20:55 | |
| mriedem | but it sure as shit causes a lot of confusion when you're looking at all of the code that uses it, and the API that provides the value, and you see it's not a list | 20:55 |
| mriedem | and you say, wtf am i missing? | 20:56 |
| bauzas | mriedem: you know that the policy differs for that, right? | 20:56 |
| mriedem | yes | 20:56 |
| melwitt | would have to run that by operators because afaik they use that to test new compute host before making it available for scheduling? | 20:56 |
| mriedem | you mean "create:forced_host" right? | 20:56 |
| bauzas | yup | 20:56 |
| mriedem | yeah i thought operators were pretty keen on this, | 20:56 |
| bauzas | I was | 20:56 |
| mriedem | and we've baked it into the migration APIs right? | 20:57 |
| bauzas | in Essex, it was terribly necessary | 20:57 |
| bauzas | but now, we are in a far better place, but at least we should mimic what we merged for the move operations | 20:57 |
| bauzas | ie. having a possible target with a force flag | 20:57 |
| bauzas | which would then verify the filters if the target is set without force | 20:58 |
| bauzas | or totally bypass the scheduler if force | 20:58 |
| mriedem | so, i'm going to just start with a code comment in the request spec object | 20:58 |
| mriedem | so when i look at this in a year, i won't have to do all of the detective work again | 20:59 |
| bauzas | fine by me | 20:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a note about force_hosts only ever having a single value https://review.openstack.org/446175 | 21:04 |
| mriedem | there you go ^ | 21:04 |
| openstackgerrit | Roman Dobosz proposed openstack/nova-specs master: Provide detailed error information for placement API https://review.openstack.org/418393 | 21:04 |
| *** sneti has quit IRC | 21:05 | |
| mriedem | ok, well, back to figuring out how i can mock the scheduler to send build requests to certain hosts in order | 21:06 |
| *** hongbin has quit IRC | 21:06 | |
| bauzas | melwitt: https://review.openstack.org/#/c/446175/1 could be worth of interest | 21:07 |
| bauzas | mriedem: what's your concern ? | 21:07 |
| mriedem | bauzas: i'm writing a functional test to recreate https://review.openstack.org/#/c/444106/ | 21:08 |
| bauzas | mriedem: you want the scheduler to return you a specific destination ? | 21:08 |
| mriedem | i have 2 hosts, i want the scheduler to send them in order | 21:08 |
| *** zz_dimtruck is now known as dimtruck | 21:08 | |
| *** sdague has quit IRC | 21:09 | |
| mriedem | i think i can just use the disk weigher and fake it out | 21:10 |
| *** vladikr has quit IRC | 21:11 | |
| *** lucasxu has quit IRC | 21:12 | |
| *** lucasxu has joined #openstack-nova | 21:12 | |
| *** lucasxu has quit IRC | 21:12 | |
| mriedem | oh now i see a bug in the docs | 21:13 |
| *** gouthamr has joined #openstack-nova | 21:13 | |
| *** moshele has joined #openstack-nova | 21:14 | |
| *** dave-mccowan has joined #openstack-nova | 21:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix the help for the disk_weight_multiplier option https://review.openstack.org/446177 | 21:15 |
| bauzas | mriedem: the scheduler is only returning one host, so 2 calls one after the other ? | 21:16 |
| mriedem | bauzas: i need the test to make the scheduler put the server on the hosts in order, where the first host will fail during driver.spawn which would normally trigger a retry to the 2nd host | 21:17 |
| mriedem | i've got 2 hosts in the test | 21:17 |
| mriedem | i want to trick the scheduler into picking the hosts in order | 21:17 |
| mriedem | so i really just need it to pick the bad one first | 21:17 |
| *** dave-mcc_ has joined #openstack-nova | 21:17 | |
| mriedem | i guess maybe it doesn't matter which order as long as i can keep track of the first host that's called | 21:18 |
| mriedem | i'll just do that | 21:18 |
| bauzas | I see | 21:19 |
| *** dave-mccowan has quit IRC | 21:19 | |
| *** rloo has joined #openstack-nova | 21:20 | |
| bauzas | mriedem: tbh, just asks the scheduler for one host, kill the spawn and then the reschedule will put that host in the retry list | 21:21 |
| bauzas | in case retry doesn't work, then you'll get the first node | 21:22 |
| mriedem | the scheduler will try to send it back to the same host? | 21:22 |
| bauzas | yup, because the claim will be reversed | 21:22 |
| bauzas | well, there is some random | 21:23 |
| mriedem | ok, so i'm going to try and test this in the non-crazy way | 21:23 |
| mriedem | which is if i have 2 hosts and the first fails, i expect it to go to the 2nd host | 21:24 |
| mriedem | see _add_retry_host in the scheduler utils | 21:24 |
| mriedem | that's why i thought it worked this way | 21:24 |
| bauzas | you can trick the scheduler | 21:24 |
| mriedem | ah RetryFilter | 21:24 |
| bauzas | yeah | 21:24 |
| *** browne has quit IRC | 21:25 | |
| bauzas | that's why we had NoValidHosts for a spawn issue | 21:25 |
| bauzas | now, it's a separate exception | 21:25 |
| bauzas | but yeah, if we retry and we don't have enough computes, then the RetryFilter will return 0 hosts | 21:25 |
| bauzas | as I said, you can trick what the scheduler returns by avoiding random choice if host_subset_size opt is having a 1 value | 21:26 |
| bauzas | which is the default | 21:27 |
| *** krtaylor has quit IRC | 21:27 | |
| bauzas | so, that's why the scheduler always returns the same compute | 21:28 |
| bauzas | mriedem: FWIW, I'm tempted to add a section in https://etherpad.openstack.org/p/BOS-Nova-brainstorming saying 'add your name if you want to go to the Summit but still waits for your management" :p | 21:29 |
| *** sneti has joined #openstack-nova | 21:30 | |
| mriedem | bauzas: that kind of passive aggressiveness is reserved for midwesterners in the US | 21:30 |
| mriedem | i'm also setting host_subset_size=2 | 21:30 |
| mriedem | i'm setting all the things | 21:30 |
| *** moshele has quit IRC | 21:30 | |
| *** sneti has quit IRC | 21:30 | |
| bauzas | if so, you'd random between two hosts | 21:30 |
| mriedem | but the RetryFilter, which is enabled by default, should filter out the first failed host | 21:31 |
| mriedem | anyway, i'll just get this going and see | 21:31 |
| *** tblakes has quit IRC | 21:33 | |
| bauzas | mriedem: sure but if we don't have the retry dict, then you could miss the problem | 21:33 |
| bauzas | what you want to cover | 21:34 |
| *** Jeffrey4l_ has joined #openstack-nova | 21:35 | |
| *** Jeffrey4l has quit IRC | 21:35 | |
| *** edmondsw has quit IRC | 21:36 | |
| *** Sukhdev has joined #openstack-nova | 21:36 | |
| *** edmondsw has joined #openstack-nova | 21:37 | |
| *** ijw has quit IRC | 21:39 | |
| *** Sukhdev has quit IRC | 21:41 | |
| *** edmondsw has quit IRC | 21:41 | |
| *** JoseMello has quit IRC | 21:45 | |
| edleafe | jaypipes: want me to fix the pep8 issue on https://review.openstack.org/441544 ? | 21:47 |
| jaypipes | edleafe: lol, pls do. :) | 21:47 |
| edleafe | k | 21:47 |
| jaypipes | edleafe: serves me right for not tox -epep8'ing. | 21:48 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: virt: implement get_inventory() for Ironic https://review.openstack.org/441544 | 21:49 |
| edleafe | jaypipes: fixed ^^ | 21:49 |
| jaypipes | cheers, I wallaby'd it. | 21:50 |
| *** hshiina has joined #openstack-nova | 21:51 | |
| *** slaweq_ has joined #openstack-nova | 21:52 | |
| *** slaweq__ has quit IRC | 21:52 | |
| *** baoli has quit IRC | 21:54 | |
| *** erlon has quit IRC | 21:55 | |
| *** jamielennox has quit IRC | 21:55 | |
| *** burt has quit IRC | 21:57 | |
| *** Sukhdev has joined #openstack-nova | 21:57 | |
| *** lpetrut has quit IRC | 21:58 | |
| *** tbachman has quit IRC | 21:59 | |
| *** raj_singh has quit IRC | 22:00 | |
| *** esberglu has quit IRC | 22:00 | |
| *** felipemonteiro has quit IRC | 22:00 | |
| *** raj_singh has joined #openstack-nova | 22:00 | |
| *** esberglu has joined #openstack-nova | 22:00 | |
| openstackgerrit | Rafael Folco proposed openstack/nova master: DELETE all inventory for a resource provider https://review.openstack.org/416669 | 22:02 |
| *** esberglu has quit IRC | 22:05 | |
| *** mdrabe has quit IRC | 22:06 | |
| jaypipes | mriedem, dansmith, melwitt: one of you want some review bait? :) https://review.openstack.org/#/c/444497/ | 22:08 |
| *** dimtruck is now known as zz_dimtruck | 22:09 | |
| *** rloo has left #openstack-nova | 22:09 | |
| *** aysyd has quit IRC | 22:09 | |
| *** Yingxin has quit IRC | 22:13 | |
| *** tbachman has joined #openstack-nova | 22:13 | |
| *** Yingxin has joined #openstack-nova | 22:14 | |
| openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_password.py https://review.openstack.org/443957 | 22:14 |
| openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in agents.py https://review.openstack.org/445208 | 22:15 |
| openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in aggregates.py https://review.openstack.org/445230 | 22:15 |
| *** browne has joined #openstack-nova | 22:15 | |
| *** jamielennox has joined #openstack-nova | 22:15 | |
| openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in assisted_volume_snapshots.py https://review.openstack.org/445238 | 22:15 |
| *** mlavalle has quit IRC | 22:16 | |
| *** krtaylor has joined #openstack-nova | 22:17 | |
| *** armax has quit IRC | 22:19 | |
| *** esberglu has joined #openstack-nova | 22:19 | |
| *** hshiina has quit IRC | 22:21 | |
| *** rfolco has quit IRC | 22:23 | |
| *** esberglu has quit IRC | 22:24 | |
| *** slaweq_ has quit IRC | 22:26 | |
| *** slaweq_ has joined #openstack-nova | 22:29 | |
| *** rmart04 has joined #openstack-nova | 22:31 | |
| *** efried has quit IRC | 22:31 | |
| mriedem | jaypipes: no more for me today | 22:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add a functional regression/recreate test for bug 1671648 https://review.openstack.org/446209 | 22:32 |
| openstack | bug 1671648 in OpenStack Compute (nova) "Instances are not rescheduled after deploy fails" [High,In progress] https://launchpad.net/bugs/1671648 - Assigned to Shunli Zhou (shunliz) | 22:32 |
| mriedem | melwitt: here is that functional regression test for the retry bug ^ | 22:32 |
| *** baoli has joined #openstack-nova | 22:34 | |
| melwitt | mriedem: cool, will check it out | 22:35 |
| *** gongysh has joined #openstack-nova | 22:37 | |
| *** baoli has quit IRC | 22:38 | |
| *** claudiub has quit IRC | 22:40 | |
| *** zz_dimtruck is now known as dimtruck | 22:41 | |
| *** abalutoiu has joined #openstack-nova | 22:43 | |
| *** hongbin has joined #openstack-nova | 22:43 | |
| *** mriedem1 has joined #openstack-nova | 22:43 | |
| *** mriedem has quit IRC | 22:44 | |
| melwitt | jaypipes: +W | 22:45 |
| *** tbachman has quit IRC | 22:48 | |
| *** xyang1 has quit IRC | 22:49 | |
| *** rmart04 has quit IRC | 22:49 | |
| *** browne has quit IRC | 22:49 | |
| *** gyee has joined #openstack-nova | 22:52 | |
| *** zioproto has joined #openstack-nova | 22:59 | |
| *** ijw has joined #openstack-nova | 23:02 | |
| *** timello has quit IRC | 23:02 | |
| *** catinthe_ has quit IRC | 23:02 | |
| *** rfolco has joined #openstack-nova | 23:04 | |
| *** ijw has quit IRC | 23:07 | |
| *** jianghuaw-m has joined #openstack-nova | 23:09 | |
| *** timello has joined #openstack-nova | 23:09 | |
| *** alexpilotti has quit IRC | 23:11 | |
| mriedem1 | aha, the chance scheduler doesn't set filter limits | 23:12 |
| mriedem1 | b/c it doesn't do filtering | 23:12 |
| *** mriedem1 is now known as mriedem | 23:12 | |
| mriedem | and the scheduler filter uses RequestSpec.from_primitives which defaults 'limits' to {} | 23:12 |
| melwitt | mriedem: ah, right. need to self.flags for filterscheduler | 23:13 |
| mriedem | i don't want to use the filter scheduler actually, | 23:13 |
| dansmith | melwitt: were you going to split up the third quota patch at all? | 23:13 |
| mriedem | i started with that and the default enabled filters kicked out my hosts | 23:13 |
| *** ijw has joined #openstack-nova | 23:13 | |
| dansmith | I've just been going back and forth between a real file and a test file for a while, | 23:13 |
| dansmith | and I think it should be easy to cleave off some large related chunks purely by tagging files that go together | 23:14 |
| dansmith | is there any reason to keep this monolithic? | 23:14 |
| *** rfolco has quit IRC | 23:14 | |
| melwitt | no, other than I didn't do much thinking about how to logically split it into smaller chunks | 23:14 |
| melwitt | I had a hell of a time just getting it to work, so it stayed monolithic | 23:14 |
| dansmith | lemme see if I can split off some chunks that look obvious to me | 23:15 |
| melwitt | thanks. suggestions on how to split it would be appreciated | 23:16 |
| *** avolkov` has joined #openstack-nova | 23:16 | |
| melwitt | mriedem: I thought I had seen an example of a func test that used filterscheduler but I'm not finding anything so far | 23:17 |
| melwitt | oh, I was grepping for the wrong thing "FilterScheduler". it looks like this to configure self.flags(driver='filter_scheduler', group='scheduler') | 23:17 |
| *** avolkov has quit IRC | 23:18 | |
| melwitt | and I just read back and saw you don't want the filter scheduler. nevermind | 23:20 |
| *** dtp has quit IRC | 23:21 | |
| mriedem | right, filter scheduler is the default | 23:23 |
| mriedem | but it has a bunch of filters enabled by default, so i'd have to wittle that list of filters down to what works for this test, which might just be the RetryFilter, | 23:23 |
| mriedem | i'm just trying to get the base things working | 23:23 |
| *** sree has joined #openstack-nova | 23:24 | |
| melwitt | mriedem: well, you can self.flags the enabled filters too. so maybe just put RetryFilter in there by itself | 23:24 |
| mriedem | yeah i thought about that, | 23:25 |
| melwitt | if the bug is about something that RetryFilter needs to populate, I mean | 23:25 |
| melwitt | if it's unrelated, then you don't need filter scheduler | 23:25 |
| mriedem | RetryFilter doesn't populate the thing, | 23:25 |
| mriedem | it checks the populated value | 23:25 |
| mriedem | anyway, the functional test is now failing and going back and forth between hosts so i'm doing something else wrong here | 23:26 |
| mriedem | with the fix i mean | 23:26 |
| mriedem | so it's retrying, but failing | 23:26 |
| *** dimtruck is now known as zz_dimtruck | 23:26 | |
| *** zz_dimtruck is now known as dimtruck | 23:26 | |
| mriedem | even though i'm using that flag to signal when we should fail and when we shouldn't | 23:27 |
| melwitt | so the RetryFilter is what skips hosts that have already been attempted. so it seems like that would be your problem, right? | 23:27 |
| melwitt | (I'm reading in the filter) | 23:27 |
| *** pumaranikar has joined #openstack-nova | 23:27 | |
| melwitt | but that implies it would go on forever otherwise? that doesn't really make sense | 23:28 |
| *** sree has quit IRC | 23:28 | |
| *** hshiina has joined #openstack-nova | 23:29 | |
| mriedem | i can try self.flags(enabled_filters=['RetryFilter'], group='filter_scheduler') and see what happens | 23:33 |
| *** pumaranikar has quit IRC | 23:35 | |
| *** dimtruck is now known as zz_dimtruck | 23:36 | |
| mriedem | yeah that makes it not attempt at all | 23:36 |
| melwitt | I have a feeling that RetryFilter is required if scheduler_max_attempts > 1, otherwise it wouldn't know how to skip already tried hosts | 23:36 |
| melwitt | and chance scheduler I think can't work with more than one compute host and scheduler_max_attempts > 1 maybe? | 23:37 |
| mriedem | max_attempts defaults to 3 | 23:37 |
| mriedem | throwing the ComputeFilter into the list | 23:37 |
| *** jianghuaw-m has quit IRC | 23:37 | |
| dansmith | melwitt: so, I just split the third patch into these: http://pastebin.com/raw/SXVqNSZm | 23:37 |
| mriedem | since that's a pretty dumb one | 23:37 |
| dansmith | which takes the top patch down from 49 files touched to 32 | 23:38 |
| melwitt | dansmith: you're the best | 23:38 |
| dansmith | totally haven't run unit tests or anything, and there are probably some pieces that I need, like I didn't bring over the object hashes | 23:38 |
| melwitt | dansmith: yeah, if you just wanna dump it like that, I can fix whatever blows up | 23:38 |
| dansmith | but I think it's probably worth trying to pursue that, just to make the last patch (which will be big enough regardless) a little more manageable | 23:38 |
| * melwitt nods | 23:39 | |
| *** jianghuaw-m has joined #openstack-nova | 23:39 | |
| dansmith | let me see how much blowing up there is before I go dumping, but if it's not terribad I will | 23:39 |
| melwitt | k | 23:39 |
| openstackgerrit | Samantha Blanco proposed openstack/nova master: [WIP] Make flavor-rxtx policy more granular https://review.openstack.org/444036 | 23:40 |
| melwitt | mriedem: yeah, I knew max attempts defaults to > 1 but the vast majority of our tests only use one compute service, so this doesn't come up much | 23:42 |
| mriedem | melwitt: ah the other thing, | 23:42 |
| mriedem | filter scheduler uses placement now, | 23:42 |
| melwitt | and chance_scheduler is only used in the tests that derive from the integrated_helpers base test class | 23:42 |
| mriedem | and this isn't setup to report into placement | 23:42 |
| melwitt | hmm | 23:42 |
| mriedem | so back to chance_scheduler it is | 23:43 |
| mriedem | unless i also stub out the placement stuff | 23:43 |
| melwitt | I think chance_scheduler can't retry. you'd have to check | 23:43 |
| melwitt | it has to have some other way to skip hosts it already tried | 23:43 |
| mriedem | i can try using the PlacementFixture | 23:44 |
| melwitt | I had to use that recently. I can't remember the context | 23:44 |
| mriedem | this time i got one attempt, so getting further | 23:48 |
| melwitt | /o/ | 23:49 |
| mriedem | is that the hey ho thing? | 23:50 |
| dansmith | melwitt: hmm, yea, so I think you'll have to make some compatible changes to the quota object (and thus the quota driver) at the bottom of the stack, then use them, and remove the old stuff at the top | 23:52 |
| dansmith | I could split this out in front: https://review.openstack.org/#/c/416521/22/nova/objects/quotas.py | 23:52 |
| dansmith | except that the changes to the quota driver have to go with it, but I think a lot of that has to go nearish to the end? | 23:52 |
| melwitt | mriedem: I was imagining it as cheering you on. I don't know what the hey ho thing is | 23:53 |
| melwitt | dansmith: yeah, the check_deltas thing was a suggestion from johnthetubaguy as a way to put count/limit_check together behind an abstraction, in hopes that later on we could do something to make the count/check atomic | 23:54 |
| melwitt | so it's just grouping thing really | 23:54 |
| mriedem | melwitt: https://www.youtube.com/watch?v=vr-klwxKhow | 23:55 |
| *** zz_dimtruck is now known as dimtruck | 23:55 | |
| melwitt | and it makes the code look a lot nicer and be more clear at the call sites | 23:55 |
| dansmith | melwitt: right but it makes all the things that use that interface depend on the changes to the quota driver | 23:55 |
| dansmith | I mean that's obvious, that they depend on them, | 23:55 |
| dansmith | but it makes it hard to merge any of those things early, which are just setup for the main event at the end | 23:56 |
| melwitt | dansmith: yeah | 23:56 |
| dansmith | if instead of modifying the existing quota limit_check thing, you had a new one that did the new behavior, we could merge that and the things that need it, | 23:56 |
| dansmith | then cut over, then remove the old stuff | 23:56 |
| melwitt | oh, okay, I see what you're saying now | 23:56 |
| dansmith | unless the limit check is still usable by old code in it's modified form, | 23:57 |
| dansmith | but so much change was made and new params and stuff I can't really eyeball it | 23:57 |
| dansmith | like, with proj_values=None is it still compatible with the way it was before? | 23:58 |
| melwitt | lemme see. this has been going on for awhile | 23:58 |
| melwitt | I think so. that was what I was thinking, let limit_check work the way it always did, just that you can add project-scoping if you want. which we need for all the new counting stuff | 23:59 |
| *** jianghuaw-m has quit IRC | 23:59 | |
| melwitt | prior to this patch, all of the limit_checks were user-scoped only | 23:59 |
| *** adisky_ has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!