| *** adrian_otto has quit IRC | 00:00 | |
| *** adrian_otto has joined #openstack-nova | 00:09 | |
| *** gfhellma has joined #openstack-nova | 00:10 | |
| *** mnaser has left #openstack-nova | 00:12 | |
| *** baoli has quit IRC | 00:13 | |
| *** adrian_otto has quit IRC | 00:18 | |
| *** jamielennox is now known as jamielennox|away | 00:20 | |
| *** catintheroof has joined #openstack-nova | 00:26 | |
| *** catintheroof has quit IRC | 00:26 | |
| *** catintheroof has joined #openstack-nova | 00:26 | |
| *** jamielennox|away is now known as jamielennox | 00:27 | |
| *** baoli has joined #openstack-nova | 00:28 | |
| *** baoli has quit IRC | 00:28 | |
| *** yingjun has joined #openstack-nova | 00:31 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: Enable attach traits to ResourceProvider https://review.openstack.org/376201 | 00:31 |
|---|---|---|
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add Traits API to placement service https://review.openstack.org/376200 | 00:31 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add resource provider traits API https://review.openstack.org/376202 | 00:31 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add Trait and TraitList objects https://review.openstack.org/376199 | 00:31 |
| *** raunak has quit IRC | 00:33 | |
| *** yamamoto has joined #openstack-nova | 00:39 | |
| *** namnh has joined #openstack-nova | 00:42 | |
| *** fragatina has joined #openstack-nova | 00:43 | |
| *** dave-mccowan has joined #openstack-nova | 00:59 | |
| *** phuongnh has joined #openstack-nova | 01:06 | |
| *** zhurong has joined #openstack-nova | 01:11 | |
| *** tbachman_ has joined #openstack-nova | 01:12 | |
| *** tbachman has quit IRC | 01:13 | |
| *** tbachman_ is now known as tbachman | 01:13 | |
| *** Shunli has joined #openstack-nova | 01:21 | |
| *** yamamoto has quit IRC | 01:25 | |
| *** baoli has joined #openstack-nova | 01:29 | |
| *** amotoki has quit IRC | 01:30 | |
| *** zz_dimtruck is now known as dimtruck | 01:32 | |
| *** mriedem has quit IRC | 01:33 | |
| *** armax has joined #openstack-nova | 01:34 | |
| *** wangqun has joined #openstack-nova | 01:34 | |
| *** baoli has quit IRC | 01:34 | |
| *** kevinz has joined #openstack-nova | 01:39 | |
| *** mtanino has joined #openstack-nova | 01:40 | |
| *** salv-orlando has joined #openstack-nova | 01:41 | |
| *** Kevin_Zheng has joined #openstack-nova | 01:41 | |
| *** dimtruck is now known as zz_dimtruck | 01:42 | |
| *** amotoki has joined #openstack-nova | 01:43 | |
| *** gcb has joined #openstack-nova | 01:44 | |
| openstackgerrit | Li Yingjun proposed openstack/nova-specs master: Spec for support set vgamem for video https://review.openstack.org/438787 | 01:45 |
| *** salv-orlando has quit IRC | 01:45 | |
| *** yonglihe has joined #openstack-nova | 01:46 | |
| *** amotoki has quit IRC | 01:49 | |
| *** baoli has joined #openstack-nova | 01:50 | |
| *** amotoki has joined #openstack-nova | 01:55 | |
| *** baoli has quit IRC | 01:55 | |
| openstackgerrit | Li Yingjun proposed openstack/nova-specs master: Spec for support set vgamem for video https://review.openstack.org/438787 | 01:56 |
| *** armax has quit IRC | 01:57 | |
| *** youzp has joined #openstack-nova | 01:57 | |
| *** siva_krishnan has left #openstack-nova | 01:57 | |
| *** youzp has quit IRC | 01:58 | |
| *** youzp has joined #openstack-nova | 01:58 | |
| *** yuntongjin has joined #openstack-nova | 01:59 | |
| *** iceyao has joined #openstack-nova | 02:05 | |
| *** yamamoto has joined #openstack-nova | 02:05 | |
| *** kaisers_ has joined #openstack-nova | 02:10 | |
| *** kaisers__ has quit IRC | 02:14 | |
| *** gouthamr has quit IRC | 02:17 | |
| *** catintheroof has quit IRC | 02:18 | |
| *** amotoki has quit IRC | 02:19 | |
| *** amotoki has joined #openstack-nova | 02:29 | |
| *** amotoki has quit IRC | 02:30 | |
| *** amotoki has joined #openstack-nova | 02:30 | |
| *** gongysh has joined #openstack-nova | 02:33 | |
| *** zz_dimtruck is now known as dimtruck | 02:33 | |
| openstackgerrit | Maho Koshiya proposed openstack/nova master: Add interfaces functional negative tests https://review.openstack.org/442892 | 02:38 |
| *** takashin has joined #openstack-nova | 02:41 | |
| *** dimtruck is now known as zz_dimtruck | 02:43 | |
| *** irenab_ is now known as irenab | 02:43 | |
| *** catintheroof has joined #openstack-nova | 02:45 | |
| *** catintheroof has quit IRC | 02:45 | |
| *** catintheroof has joined #openstack-nova | 02:45 | |
| *** baoli has joined #openstack-nova | 02:51 | |
| *** yuntongjin has quit IRC | 02:56 | |
| *** baoli has quit IRC | 02:56 | |
| *** ircuser-1 has joined #openstack-nova | 02:57 | |
| *** carthaca_ has quit IRC | 03:00 | |
| *** sapcc-bot has quit IRC | 03:01 | |
| *** databus23_ has quit IRC | 03:01 | |
| *** sapcc-bot has joined #openstack-nova | 03:01 | |
| *** databus23_ has joined #openstack-nova | 03:01 | |
| *** carthaca_ has joined #openstack-nova | 03:01 | |
| *** tuanluong has joined #openstack-nova | 03:06 | |
| *** carthaca_ has quit IRC | 03:11 | |
| *** sapcc-bot has quit IRC | 03:11 | |
| *** databus23_ has quit IRC | 03:11 | |
| *** carthaca_ has joined #openstack-nova | 03:11 | |
| *** sapcc-bot has joined #openstack-nova | 03:11 | |
| *** databus23_ has joined #openstack-nova | 03:11 | |
| *** raunak has joined #openstack-nova | 03:15 | |
| *** sapcc-bot3 has joined #openstack-nova | 03:17 | |
| *** databus23_ has quit IRC | 03:17 | |
| *** sapcc-bot has quit IRC | 03:17 | |
| *** carthaca_ has quit IRC | 03:17 | |
| *** carthaca_1 has joined #openstack-nova | 03:17 | |
| *** databus23_1 has joined #openstack-nova | 03:17 | |
| *** nicolasbock has quit IRC | 03:21 | |
| *** zz_dimtruck is now known as dimtruck | 03:25 | |
| *** vishwanathj has quit IRC | 03:30 | |
| *** adrian_otto has joined #openstack-nova | 03:31 | |
| *** dave-mccowan has quit IRC | 03:32 | |
| *** bswartz has joined #openstack-nova | 03:32 | |
| *** catintheroof has quit IRC | 03:37 | |
| *** sree has joined #openstack-nova | 03:39 | |
| *** mtanino has quit IRC | 03:40 | |
| *** claudiub has quit IRC | 03:40 | |
| *** adrian_otto has quit IRC | 03:41 | |
| *** salv-orlando has joined #openstack-nova | 03:42 | |
| *** salv-orlando has quit IRC | 03:46 | |
| *** adrian_otto has joined #openstack-nova | 03:50 | |
| *** adrian_otto has quit IRC | 03:55 | |
| *** nmathew has joined #openstack-nova | 03:57 | |
| *** nmathew- has joined #openstack-nova | 03:59 | |
| *** links has joined #openstack-nova | 04:02 | |
| *** nmathew has quit IRC | 04:02 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters and examples in aggregate API https://review.openstack.org/425512 | 04:04 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Avoid forcing translation on logging calls https://review.openstack.org/413876 | 04:04 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444 | 04:05 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration https://review.openstack.org/334732 | 04:05 |
| *** fragatina has quit IRC | 04:10 | |
| *** mdnadeem has joined #openstack-nova | 04:25 | |
| *** psachin has joined #openstack-nova | 04:28 | |
| *** iceyao has quit IRC | 04:29 | |
| *** iceyao has joined #openstack-nova | 04:31 | |
| *** raunak has quit IRC | 04:33 | |
| *** markvoelker has quit IRC | 04:35 | |
| *** raunak has joined #openstack-nova | 04:41 | |
| *** sudipto has joined #openstack-nova | 04:45 | |
| *** nmathew- has quit IRC | 04:49 | |
| *** ayogi has joined #openstack-nova | 04:49 | |
| *** sridharg has joined #openstack-nova | 04:49 | |
| *** baoli has joined #openstack-nova | 04:53 | |
| *** baoli has quit IRC | 04:57 | |
| *** kaisers_ has quit IRC | 04:59 | |
| *** takashin has quit IRC | 05:01 | |
| *** ssurana has joined #openstack-nova | 05:11 | |
| *** kornicameister has joined #openstack-nova | 05:12 | |
| *** lpetrut has joined #openstack-nova | 05:12 | |
| *** crusio has quit IRC | 05:15 | |
| *** nmathew has joined #openstack-nova | 05:15 | |
| *** crusio has joined #openstack-nova | 05:15 | |
| *** jbernard has quit IRC | 05:16 | |
| *** jbernard has joined #openstack-nova | 05:17 | |
| *** sridharg has quit IRC | 05:19 | |
| *** thorst_afk has joined #openstack-nova | 05:19 | |
| *** thorst_afk has quit IRC | 05:19 | |
| *** trinaths has joined #openstack-nova | 05:23 | |
| *** thorst_afk has joined #openstack-nova | 05:28 | |
| *** kaisers_ has joined #openstack-nova | 05:29 | |
| *** thorst_afk has quit IRC | 05:32 | |
| *** kaisers_ has quit IRC | 05:34 | |
| *** markvoelker has joined #openstack-nova | 05:36 | |
| *** markvoelker has quit IRC | 05:41 | |
| *** salv-orlando has joined #openstack-nova | 05:43 | |
| *** thorst_afk has joined #openstack-nova | 05:43 | |
| *** lpetrut has quit IRC | 05:47 | |
| *** salv-orlando has quit IRC | 05:47 | |
| *** thorst_afk has quit IRC | 05:47 | |
| *** baoli has joined #openstack-nova | 05:54 | |
| *** unicell has joined #openstack-nova | 05:57 | |
| *** baoli has quit IRC | 05:58 | |
| *** unicell has quit IRC | 05:59 | |
| *** tovin07 has joined #openstack-nova | 06:00 | |
| *** salv-orlando has joined #openstack-nova | 06:02 | |
| *** unicell has joined #openstack-nova | 06:04 | |
| *** tovin07_ has joined #openstack-nova | 06:13 | |
| *** unicell has quit IRC | 06:20 | |
| *** raunak has quit IRC | 06:25 | |
| *** raunak has joined #openstack-nova | 06:26 | |
| *** raunak has quit IRC | 06:26 | |
| *** raunak has joined #openstack-nova | 06:27 | |
| *** raunak has quit IRC | 06:27 | |
| *** raunak has joined #openstack-nova | 06:27 | |
| *** raunak has quit IRC | 06:28 | |
| *** raunak has joined #openstack-nova | 06:28 | |
| *** raunak has quit IRC | 06:29 | |
| *** raunak has joined #openstack-nova | 06:29 | |
| *** raunak has quit IRC | 06:29 | |
| *** kaisers_ has joined #openstack-nova | 06:31 | |
| *** dimtruck is now known as zz_dimtruck | 06:39 | |
| *** mnestratov has joined #openstack-nova | 06:40 | |
| *** ducnc has joined #openstack-nova | 06:42 | |
| *** sridharg has joined #openstack-nova | 06:42 | |
| *** ekuris has joined #openstack-nova | 06:46 | |
| openstackgerrit | Li Yingjun proposed openstack/nova-specs master: Spec for service create and destroy notification https://review.openstack.org/444731 | 06:47 |
| *** baoli has joined #openstack-nova | 06:54 | |
| openstackgerrit | Li Yingjun proposed openstack/nova-specs master: Spec for service create and destroy notification https://review.openstack.org/444731 | 06:56 |
| *** baoli has quit IRC | 06:59 | |
| *** sree has quit IRC | 07:00 | |
| *** _ioni is now known as ioni | 07:01 | |
| *** Oku_OS-away is now known as Oku_OS | 07:02 | |
| *** kaisers_ has quit IRC | 07:03 | |
| *** Shunli has quit IRC | 07:06 | |
| *** Shunli has joined #openstack-nova | 07:07 | |
| *** nkrinner_afk is now known as nkrinner | 07:08 | |
| *** satyar has joined #openstack-nova | 07:09 | |
| *** markus_z has joined #openstack-nova | 07:14 | |
| *** lpetrut has joined #openstack-nova | 07:15 | |
| *** salv-orl_ has joined #openstack-nova | 07:24 | |
| *** salv-orlando has quit IRC | 07:26 | |
| *** kevinz has quit IRC | 07:30 | |
| *** kevinz has joined #openstack-nova | 07:32 | |
| *** John341_ has quit IRC | 07:32 | |
| *** salv-orl_ has quit IRC | 07:33 | |
| *** andreas_s has joined #openstack-nova | 07:38 | |
| *** karimb has joined #openstack-nova | 07:42 | |
| *** iceyao has quit IRC | 07:47 | |
| *** claudiub has joined #openstack-nova | 07:48 | |
| *** ekuris has quit IRC | 07:50 | |
| *** iceyao has joined #openstack-nova | 07:50 | |
| *** ralonsoh has joined #openstack-nova | 07:51 | |
| *** belmoreira has joined #openstack-nova | 07:54 | |
| *** iceyao has quit IRC | 07:54 | |
| *** kaisers_ has joined #openstack-nova | 07:58 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-nova | 08:00 | |
| *** hshiina has joined #openstack-nova | 08:00 | |
| *** salv-orlando has joined #openstack-nova | 08:04 | |
| *** tovin07 has quit IRC | 08:07 | |
| *** zioproto has joined #openstack-nova | 08:11 | |
| *** ssurana has quit IRC | 08:11 | |
| *** tovin07 has joined #openstack-nova | 08:12 | |
| *** tesseract has joined #openstack-nova | 08:13 | |
| *** tesseract has quit IRC | 08:17 | |
| *** openstackgerrit has quit IRC | 08:18 | |
| *** kaisers_ has quit IRC | 08:25 | |
| *** pcaruana has joined #openstack-nova | 08:25 | |
| Qiming | alex_xu, there? | 08:27 |
| robcresswell | Quick question; someone's added a patch to Horizon that hides the Soft Reboot button if the Instance state is anything other than Active; is this correct? Had a look at the API docs but they only seem to show how to form the request, not any of the conditions around its usage. | 08:28 |
| *** openstackgerrit has joined #openstack-nova | 08:31 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: Replace diagnostics objects with Nova diagnostics objects https://review.openstack.org/394480 | 08:31 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: Added nova objects for intance diagnostics https://review.openstack.org/434745 | 08:31 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | 08:31 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | 08:31 |
| *** tesseract has joined #openstack-nova | 08:32 | |
| *** jpena|off is now known as jpena | 08:38 | |
| *** abalutoiu_ has quit IRC | 08:41 | |
| *** jpena is now known as jpena|off | 08:51 | |
| *** VAhl has joined #openstack-nova | 08:54 | |
| *** jaosorior has joined #openstack-nova | 08:57 | |
| *** abalutoiu_ has joined #openstack-nova | 08:58 | |
| *** jpena|off is now known as jpena | 08:58 | |
| bauzas | good morning Nova | 09:00 |
| alex_xu | Qiming: hi, i'm here | 09:02 |
| *** VAhl has quit IRC | 09:03 | |
| *** ekuris has joined #openstack-nova | 09:04 | |
| *** trinaths1 has joined #openstack-nova | 09:04 | |
| *** trinaths has quit IRC | 09:05 | |
| Qiming | alex_xu, I was checking admin password | 09:08 |
| *** tuanluong has quit IRC | 09:09 | |
| *** yamamoto has quit IRC | 09:10 | |
| Qiming | alex_xu, it turns out that I will need to use "/servers/{server_id}/os-server-password" for password GET, and DELETE, use POST /servers/{server_id}/action for password update, and the password can be created only via POST /servers | 09:11 |
| *** aarefiev_afk is now known as aarefiev | 09:19 | |
| *** lucas-afk is now known as lucasagomes | 09:20 | |
| *** Guest91536 has quit IRC | 09:21 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Typo fix in releasenotes: deprecate network options https://review.openstack.org/444778 | 09:24 |
| *** Guest91536 has joined #openstack-nova | 09:25 | |
| gmann | sfinucan: alex_xu oomichi simple one - https://review.openstack.org/#/c/444778/ | 09:25 |
| *** dakhmetov has joined #openstack-nova | 09:26 | |
| sfinucan | gmann: Done | 09:26 |
| * sfinucan didn't want to lose +2s :) | 09:26 | |
| gmann | sfinucan: :) thanks | 09:27 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Move detach logic from manager into driver BDM https://review.openstack.org/439520 | 09:27 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Use detach_volume during default rebuild https://review.openstack.org/443932 | 09:27 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: objects: Add attachment_id to BlockDeviceMapping https://review.openstack.org/437665 | 09:27 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Only destroy BDMs after successful detach call https://review.openstack.org/440693 | 09:27 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: db: Add attachment_id to block_device_mapping https://review.openstack.org/437597 | 09:27 |
| * alex_xu have same thinking with sfinucan | 09:28 | |
| alex_xu | gmann: done | 09:28 |
| alex_xu | Qiming: i'm thinking whether all of those password are same thing | 09:28 |
| Qiming | alex_xu, they are, IMO | 09:28 |
| *** efoley_ has joined #openstack-nova | 09:29 | |
| gmann | alex_xu: thanks | 09:29 |
| gmann | alex_xu: Qiming admin one is different(updated using changePassword) and os-server-password is metadata one | 09:30 |
| *** efoley__ has joined #openstack-nova | 09:31 | |
| gmann | because delete call just remvoe from metadata which is encrypted one, it does not change in server | 09:31 |
| Qiming | gmann, I'm no nova expert, should I care if the password is stored in metadata or somewhere else? | 09:32 |
| Qiming | gmann, the doc tells me I can specify password for admin, I can change it, I can get it, and I can wipe it out | 09:33 |
| alex_xu | I remember the admin one is for xen driver | 09:33 |
| * gmann checking | 09:33 | |
| *** efoley_ has quit IRC | 09:34 | |
| Qiming | gmann, the strange thing is that they are located in different locations, probably fine for command line tools, but not so good for SDK modeling | 09:34 |
| *** Shunli has quit IRC | 09:35 | |
| lyarwood | mdbooth: morning, https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cinder-new-attach-apis should be ready for reviews once you have time today, the focus is really on the db and object changes first if you wouldn't mind focusing on them. | 09:37 |
| openstackgerrit | Thomas Bechtold proposed openstack/nova master: Log exception when hypervisor version check fails https://review.openstack.org/434927 | 09:38 |
| *** tovin07 has quit IRC | 09:39 | |
| *** derekh has joined #openstack-nova | 09:42 | |
| dakhmetov | Greetings, guys! | 09:45 |
| dakhmetov | Could you please review this patch: https://review.openstack.org/#/c/399679/ | 09:45 |
| *** yingjun has quit IRC | 09:47 | |
| dakhmetov | I know a couple of people who are really affected by the inconsistency in instance's libvirt.xml. It will be great if you help me reviewing it. | 09:50 |
| *** baoli has joined #openstack-nova | 09:52 | |
| *** VAhl has joined #openstack-nova | 09:53 | |
| johnthetubaguy | dakhmetov: so I love half of your change, and worry about the other half | 09:54 |
| johnthetubaguy | dakhmetov: using instance.user_id and instance.project_id totally makes sense, we should have done that for the beginning | 09:54 |
| johnthetubaguy | username and projectname... thats feels wrong, what about we don't add that any more? | 09:55 |
| dakhmetov | 2 johnthetubaguy please share your concern | 09:55 |
| johnthetubaguy | I will add a note on the patch | 09:55 |
| gmann | Qiming: admin pass can be injected while creating server and change password using action API is for xen and libvirt as alex_xu mentioned | 09:55 |
| johnthetubaguy | dakhmetov: a related comment came up on friday at a HPC meetup I went to, so agreed it needs fixing | 09:55 |
| openstackgerrit | Michael Henkel proposed openstack/nova master: Implements: blueprint opencontrail-dpdk-support https://review.openstack.org/441183 | 09:55 |
| *** baoli has quit IRC | 09:56 | |
| gmann | @Qiming not sure about exact SDK requirement on that and if any issue on nova side? | 09:56 |
| *** gszasz has joined #openstack-nova | 09:57 | |
| johnthetubaguy | dakhmetov: I am worried about how usernames and project names change over time in keystone, but we keep those names just matching what they were went the instance booted | 09:58 |
| johnthetubaguy | dakhmetov: maybe thats OK for your use case I guess? | 09:58 |
| dakhmetov | 2 johnthetubaguy: yes, I also thought about it. The only option to avoid this issue is open Keystone session there each time | 10:00 |
| johnthetubaguy | dakhmetov: my idea was to only have the ids in there, from the instance object, and leave the others blank for now? | 10:01 |
| johnthetubaguy | that would ensure they are "correct" in some sense, but I feel bad breaking the folks that want the names there | 10:02 |
| *** satyar has quit IRC | 10:04 | |
| *** andreas_s has quit IRC | 10:04 | |
| dakhmetov | johnthetubaguy: sure, there are a lot of folks who needs names there, as it described in nova xmlns 1.0 | 10:04 |
| dakhmetov | so, what we have in current patch seems to be best solution, despite the fact that the stored user and project names can change | 10:07 |
| mdbooth | dakhmetov: I've reviewed a change related to this recently. Do you have a link? | 10:08 |
| dakhmetov | mdbooth: exactly! https://review.openstack.org/#/c/399679 | 10:08 |
| *** iceyao has joined #openstack-nova | 10:09 | |
| mdbooth | Ah, ok. You fishing for a second +2? | 10:09 |
| dakhmetov | mdbooth: yes, a kind of :) | 10:09 |
| * mdbooth sees comments from johnthetubaguy and reads | 10:09 | |
| *** hshiina has quit IRC | 10:10 | |
| mdbooth | johnthetubaguy: My take on this is that we break things by rebuilding the libvirt xml. We shouldn't be doing that, and this is a necessary workaround. | 10:11 |
| mdbooth | i.e. the conversation isn't so much about what these values mean, whether they're correct, or what they really should be | 10:11 |
| mdbooth | But more: are they the same as before | 10:11 |
| mdbooth | The other conversation is also interesting, though. | 10:12 |
| johnthetubaguy | mdbooth: my worry is the bug that says I updated the project or user name in keystone, and now my lib virt xml is out of sync, for me its either we don't include the names or we do what dakhmetov has proposed | 10:12 |
| johnthetubaguy | totally agreed grabbing it from the context was exactly the wrong thing to do | 10:13 |
| * mdbooth reads the bug again | 10:13 | |
| johnthetubaguy | I was meaning the bug that is raised next time, after we fix this bit | 10:14 |
| mdbooth | Ah, ok. | 10:14 |
| mdbooth | So, that bug was always present | 10:14 |
| johnthetubaguy | yep | 10:15 |
| mdbooth | This information is static, so storing dynamic information there is suspect at best. | 10:15 |
| johnthetubaguy | yeah, thats my take | 10:15 |
| mdbooth | And I agree, and probably that we should remove username and projectname | 10:15 |
| mdbooth | However, that's tangential to this bug, which is that we break our existing contract | 10:15 |
| johnthetubaguy | cool, I was wondering if I was going down a crazy thought path | 10:15 |
| *** rmart04 has joined #openstack-nova | 10:16 | |
| mdbooth | dakhmetov: Incidentally, if you're close to users who are actually relying on this, I'd be interested to know what your take is on how to fix the changing username issue. | 10:17 |
| johnthetubaguy | +1 thats what I was fishing for really | 10:17 |
| *** gszasz has quit IRC | 10:17 | |
| mdbooth | dakhmetov: Is the issue that people have scripted this, and scripts will require updating? | 10:18 |
| johnthetubaguy | FWIW, this change breaks those folks too | 10:19 |
| * mdbooth suspects that nobody actually checks the xml namespace in use, so bumping it would be academic. | 10:19 | |
| *** andreas_s has joined #openstack-nova | 10:19 | |
| mdbooth | johnthetubaguy: Really? I missed that. | 10:19 |
| johnthetubaguy | all existing instance, once modified will now have no username or projectname, we are missing a unit test for that | 10:19 |
| *** kaisers_ has joined #openstack-nova | 10:20 | |
| mdbooth | johnthetubaguy: Ah, yes. It's a fix only for future instances, I'd glossed over that. | 10:20 |
| mdbooth | We could save the info before deleting it... | 10:21 |
| mdbooth | Meh, lets get this done before gold plating it. | 10:21 |
| *** zhurong has quit IRC | 10:21 | |
| *** zhurong has joined #openstack-nova | 10:22 | |
| *** sree has joined #openstack-nova | 10:23 | |
| *** owalsh_ is now known as owalsh | 10:23 | |
| *** nicolasbock has joined #openstack-nova | 10:24 | |
| *** alexpilotti has joined #openstack-nova | 10:24 | |
| johnthetubaguy | dakhmetov: I updated my comments to try summarise what I am thinking now, basically I would split this into two patches, and the second patch needs an extra unit test. | 10:25 |
| mdbooth | dakhmetov: Can you quickly write the test case johnthetubaguy has asked for? Should be simple enough and probably just works, but we should definitely be testing that. | 10:25 |
| *** kaisers has quit IRC | 10:26 | |
| *** kevinz has quit IRC | 10:26 | |
| *** shaohe_feng has quit IRC | 10:26 | |
| *** sree has quit IRC | 10:27 | |
| *** rmart04 has quit IRC | 10:28 | |
| *** phuongnh has quit IRC | 10:29 | |
| *** tovin07_ has quit IRC | 10:29 | |
| alex_xu | Qiming: gmann, yea, i mean it even worse, they have similar name, but doing different thing | 10:32 |
| *** hwoarang_ is now known as hwoarang | 10:33 | |
| *** gongysh has quit IRC | 10:36 | |
| *** lifeless has quit IRC | 10:37 | |
| dakhmetov | mdbooth: johnthetubaguy: reading your comments | 10:40 |
| *** nicolasbock has quit IRC | 10:41 | |
| *** ralonsoh_ has joined #openstack-nova | 10:41 | |
| *** markvoelker has joined #openstack-nova | 10:41 | |
| dakhmetov | as workaround for outdated names in instance's system_metadata: names can be updated in mysql | 10:41 |
| dakhmetov | it's dirty hack, but anyway solves the possible issue | 10:42 |
| mdbooth | dakhmetov: I think the safer option is to test that having nothing there at least doesn't break existing instances. That means that we're not regressing. Saving the info before rewriting the xml is better, but also a game of whack-a-mole, so best be safe first I think. | 10:44 |
| *** ralonsoh has quit IRC | 10:44 | |
| *** lifeless has joined #openstack-nova | 10:45 | |
| *** wangqun has quit IRC | 10:45 | |
| *** ralonsoh_ is now known as ralonsoh | 10:45 | |
| *** iceyao has quit IRC | 10:45 | |
| *** markvoelker has quit IRC | 10:46 | |
| *** namnh has quit IRC | 10:47 | |
| kashyap | lyarwood: Isn't melwitt right here -- https://review.openstack.org/#/c/441204/5/nova/tests/unit/virt/libvirt/test_guest.py | 10:49 |
| dakhmetov | mdbooth: So, what I need is to handle the situation with missing owner_user_name and owner_project_name in instance's metadata, as well as add test for this. Right? | 10:50 |
| kashyap | Specifically her question about 'live=False' | 10:50 |
| *** kaisers has joined #openstack-nova | 10:50 | |
| johnthetubaguy | dakhmetov: as long as we test for that, thats my main worry out the way | 10:50 |
| mdbooth | dakhmetov: I suspect it already handles that, but we should definitely test as johnthetubaguy says. | 10:50 |
| mdbooth | If it doesn't work, that would be a regression. | 10:50 |
| johnthetubaguy | dakhmetov: yeah, I think the get() is OK, but deep down, I would rather we didn't populate the names at all myself, hence me being tempted to do this as two patches, one that just gets user_id and project_id from the instance, sets the others to None, then a second patch that adds in your cache of the names. | 10:52 |
| *** baoli has joined #openstack-nova | 10:53 | |
| *** iceyao has joined #openstack-nova | 10:53 | |
| mdbooth | johnthetubaguy: How about resolving username and projectname from keystone at the time we rewrite the metadata? | 10:54 |
| mdbooth | Rather than storing it in system meta | 10:54 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read NIC features in libvirt https://review.openstack.org/444415 | 10:54 |
| mdbooth | Would that be so bad? | 10:54 |
| *** kaisers_ has quit IRC | 10:56 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Reserve NUMA nodes with PCI devices attached https://review.openstack.org/364468 | 10:56 |
| *** alexpilotti has quit IRC | 10:56 | |
| dakhmetov | mdbooth: if we open Keystone session to resolve ids to names in libvirtxmdriver with token from request context, it may not have permissions to resolve names in keystone | 10:57 |
| dakhmetov | we may not have permissions to resolve IDs to names in keystone even if we always open admin session | 10:57 |
| *** baoli has quit IRC | 10:57 | |
| dakhmetov | it's how I see it | 10:57 |
| *** trinaths1 has quit IRC | 10:57 | |
| mdbooth | dakhmetov: Explain | 10:57 |
| mdbooth | dakhmetov: I'm not being funny, I just don't understand that interaction all that well. | 11:00 |
| *** cdent has joined #openstack-nova | 11:01 | |
| dakhmetov | mdbooth: keystone policies are adjustable in a wide range | 11:01 |
| dakhmetov | https://github.com/openstack/keystone/blob/master/etc/policy.json | 11:01 |
| *** alexpilotti has joined #openstack-nova | 11:01 | |
| mdbooth | dakhmetov: Where did the lookups come from originally? | 11:02 |
| mdbooth | Are you saying that the policy context is different between creation and subsequent lookup, or that somebody might have changed the policy? | 11:02 |
| dakhmetov | mdbooth: so, listing users or projects can even be prohibited | 11:03 |
| mdbooth | dakhmetov: It would be a pretty odd policy which denied an authenticated user permission to lookup their own username though, right? | 11:04 |
| mdbooth | "identity:get_project": "rule:admin_required or project_id:%(target.project.id)s", | 11:05 |
| mdbooth | "identity:get_user": "rule:admin_or_owner", | 11:05 |
| * mdbooth guesses those would be the relevant permissions | 11:05 | |
| johnthetubaguy | dakhmetov: I don't think we should call out to keystone in there | 11:05 |
| mdbooth | johnthetubaguy: I know that came up earlier in the review, but are you thinking of performance or robustness when you say that? | 11:06 |
| johnthetubaguy | dakhmetov: I would rather we get the patch in that uses instance.project_id and instance.user_id first, thats an important fix (we could use the context) | 11:06 |
| *** houming has joined #openstack-nova | 11:07 | |
| johnthetubaguy | mdbooth: a combination of all of those really, plus security around every compute node having those permissions, and setting that up correctly | 11:07 |
| johnthetubaguy | mdbooth: matching uuids to current names feels like something the monitoring systems could do | 11:07 |
| openstackgerrit | jichenjc proposed openstack/nova master: Trivial Fix https://review.openstack.org/442310 | 11:08 |
| openstackgerrit | jichenjc proposed openstack/nova master: Add description for Image location in snapshot https://review.openstack.org/440379 | 11:09 |
| *** nicolasbock has joined #openstack-nova | 11:09 | |
| *** sapcc-bot3 has quit IRC | 11:12 | |
| *** carthaca_1 has quit IRC | 11:12 | |
| *** databus23_1 has quit IRC | 11:12 | |
| *** carthaca_ has joined #openstack-nova | 11:12 | |
| *** sapcc-bot has joined #openstack-nova | 11:12 | |
| *** mkoderer_ has joined #openstack-nova | 11:12 | |
| *** dgonzalez_ has joined #openstack-nova | 11:12 | |
| *** databus23_ has joined #openstack-nova | 11:12 | |
| *** david_1 has joined #openstack-nova | 11:12 | |
| *** tpatzig_ has joined #openstack-nova | 11:12 | |
| *** mkoderer_ has quit IRC | 11:14 | |
| *** dgonzalez_ has quit IRC | 11:14 | |
| *** david_1 has quit IRC | 11:14 | |
| *** tpatzig_ has quit IRC | 11:14 | |
| *** sdague_ has joined #openstack-nova | 11:16 | |
| openstackgerrit | jichenjc proposed openstack/nova master: check hw:mem_page_size when change extra_spec https://review.openstack.org/408610 | 11:16 |
| *** amotoki_ has joined #openstack-nova | 11:16 | |
| *** rodrigods has quit IRC | 11:18 | |
| bauzas | johnthetubaguy: oh, just saw https://review.openstack.org/#/c/442387/1/resolutions/20170307-compute-platform.rst | 11:18 |
| *** smatzek has joined #openstack-nova | 11:18 | |
| bauzas | johnthetubaguy: I haven't seen any ML discussion around this | 11:18 |
| *** rodrigods has joined #openstack-nova | 11:18 | |
| bauzas | johnthetubaguy: is this something you discussed in ATL ? | 11:18 |
| johnthetubaguy | bauzas: I haven't started any, its something I have been wanting to suggest for a while | 11:19 |
| *** amotoki has quit IRC | 11:19 | |
| * bauzas should try to attend TC meetings | 11:19 | |
| bauzas | johnthetubaguy: oh okay | 11:19 |
| *** andreas_s has quit IRC | 11:19 | |
| bauzas | fine by me, just wanted to make sure people were happy with it | 11:19 |
| *** gongysh has joined #openstack-nova | 11:19 | |
| johnthetubaguy | bauzas: I suspect people hate it, but I think its needed | 11:20 |
| cdent | johnthetubaguy: it's gonna rub some people funny, but I agree it is important | 11:20 |
| johnthetubaguy | I think we keep avoiding difficult conversations for two long on this kind of thing | 11:21 |
| bauzas | ++ | 11:22 |
| bauzas | anyway, /me goes offline | 11:22 |
| cdent | johnthetubaguy: hell yes | 11:22 |
| *** rodrigods has quit IRC | 11:23 | |
| *** rodrigods has joined #openstack-nova | 11:23 | |
| johnthetubaguy | cdent: I like your idea, frame the problem, not the people, I am going to go do that now | 11:23 |
| *** gongysh has quit IRC | 11:23 | |
| cdent | that's mostly for conflict avoidance. I think everyone is aware there is a problem... | 11:24 |
| johnthetubaguy | yeha | 11:24 |
| *** mvk has quit IRC | 11:27 | |
| *** moshele has joined #openstack-nova | 11:27 | |
| *** tpatzig_ has joined #openstack-nova | 11:28 | |
| *** sapcc-bot has quit IRC | 11:28 | |
| *** databus23_ has quit IRC | 11:28 | |
| *** carthaca_ has quit IRC | 11:28 | |
| *** dgonzalez_ has joined #openstack-nova | 11:28 | |
| *** david_1 has joined #openstack-nova | 11:28 | |
| *** databus23_2 has joined #openstack-nova | 11:28 | |
| *** sapcc-bot4 has joined #openstack-nova | 11:28 | |
| *** carthaca_2 has joined #openstack-nova | 11:28 | |
| *** tpatzig_ has quit IRC | 11:30 | |
| *** dgonzalez_ has quit IRC | 11:30 | |
| *** david_1 has quit IRC | 11:30 | |
| *** andreas_s has joined #openstack-nova | 11:32 | |
| dakhmetov | johnthetubaguy: mdbooth: guys, thank you for the advice! I'll add unit test for missing keys in system metadata. | 11:32 |
| *** sdague has quit IRC | 11:34 | |
| *** sdague_ is now known as sdague | 11:34 | |
| *** houming has quit IRC | 11:34 | |
| *** bvanhav has joined #openstack-nova | 11:34 | |
| *** gcb has quit IRC | 11:35 | |
| *** bvanhav has quit IRC | 11:35 | |
| *** bvanhav has joined #openstack-nova | 11:35 | |
| VAhl | Openstack [Newton]: When deploying new instance on Nova. I got the following error. Running privsep helper: ['sudo', 'nova-rootwrap', '/etc/nova/rootwrap.conf', 'privsep-helper', '--config-file', '/etc/nova/nova.conf', '--config-file', '/etc/nova/nova-compute.conf', '--privsep_context', 'os_brick.privileged.default', '--privsep_sock_path', '/tmp/tmpcWGEib/privsep.sock'] | 11:35 |
| VAhl | etc/nova/rootwrap.conf is own by root:root. etc/nova/nova.conf + nova-compute.conf is own by nova:nov | 11:35 |
| *** Guest84425 has joined #openstack-nova | 11:36 | |
| *** psachin has quit IRC | 11:36 | |
| *** nmathew has quit IRC | 11:37 | |
| *** dakhmetov has quit IRC | 11:37 | |
| *** nicolasbock has quit IRC | 11:37 | |
| *** hshiina has joined #openstack-nova | 11:39 | |
| *** dakhmetov has joined #openstack-nova | 11:41 | |
| *** trinaths has joined #openstack-nova | 11:41 | |
| *** nicolasbock has joined #openstack-nova | 11:42 | |
| *** markvoelker has joined #openstack-nova | 11:42 | |
| sfinucan | gmann: Comments left on https://review.openstack.org/#/c/431038/ | 11:43 |
| sfinucan | alex_xu: If you're looking for easy config-opt patches to review, you might look this way --> https://review.openstack.org/#/c/431039/ :) | 11:44 |
| * sfinucan has a sudden craving for San Antonio-style breakfast tacos and mourns the sorry state of Mexican cuisine in Ireland | 11:45 | |
| alex_xu | sfinucan: thanks :) | 11:45 |
| *** markvoelker has quit IRC | 11:46 | |
| *** houming has joined #openstack-nova | 11:49 | |
| *** yingjun has joined #openstack-nova | 11:51 | |
| *** erlon has joined #openstack-nova | 11:51 | |
| *** kaisers_ has joined #openstack-nova | 11:52 | |
| *** avolkov has joined #openstack-nova | 11:53 | |
| *** baoli has joined #openstack-nova | 11:53 | |
| *** sudipto has quit IRC | 11:56 | |
| *** CristinaPauna has quit IRC | 11:56 | |
| *** psachin has joined #openstack-nova | 11:57 | |
| *** baoli has quit IRC | 11:58 | |
| *** mvk has joined #openstack-nova | 12:01 | |
| *** gongysh has joined #openstack-nova | 12:03 | |
| *** b3nt_pin has joined #openstack-nova | 12:04 | |
| *** b3nt_pin is now known as Guest71924 | 12:04 | |
| *** rfolco has joined #openstack-nova | 12:06 | |
| *** aysyd has joined #openstack-nova | 12:06 | |
| *** dakhmetov has quit IRC | 12:06 | |
| *** trinaths has quit IRC | 12:06 | |
| *** yingjun has quit IRC | 12:11 | |
| *** markvoelker has joined #openstack-nova | 12:16 | |
| *** Guest71924 is now known as beagles | 12:17 | |
| *** abalutoiu_ has quit IRC | 12:18 | |
| *** figleaf is now known as edleafe | 12:21 | |
| artom | sfinucan, thanks for the tagged attach reviews :) I'll get to websocket proxy security, I promise. In my defense, it's harder to get full context for the latter than the former, and I don't feel like just reviewing patch by patch and writing nits | 12:23 |
| artom | I had an idea about removing the tag=None param to the driver interface, let me respin that first | 12:23 |
| *** kaisers_ has quit IRC | 12:24 | |
| artom | Building device metadata is probably not a huge deal, optimization-wise, but the DB call hidden in instance.save definitely is. So I'm thinking build the new device metadata, compare it to the old one, and only save if there's a difference | 12:25 |
| artom | Get rid of the driver interface change, still no useless DB queries | 12:25 |
| artom | Wait... | 12:26 |
| *** DuncanT has joined #openstack-nova | 12:26 | |
| artom | Doesn't save() call obj_what_changed() or whatever it's called? | 12:26 |
| artom | Does it still call the database if nothing has changed? | 12:26 |
| sfinucan | artom: Yeah, no (immediate) panic :) the websocket proxy stuff /is/ tougher to review than other stuff, seeing as it's not just glue like other nova code | 12:28 |
| sfinucan | I'd be interested in seeing the approach to removing the tag parameter though, if it works out | 12:29 |
| sfinucan | Steadily working through the rest of the series now | 12:29 |
| sfinucan | sahid: RE: https://review.openstack.org/#/c/400875/, this is the issue I have with it https://review.openstack.org/#/c/400875/23/nova/virt/hardware.py@848 | 12:29 |
| artom | Based on ^^^ I think we can just remove with no other changes/repercussions? | 12:29 |
| sfinucan | For N calls of _numa_fit_instance_cell_with_pinning, you will only ever have one where num_cpu_reserved is anything but 0 | 12:29 |
| sfinucan | That, to me, is overloading | 12:30 |
| artom | dansmith can confirm when he wakes up, but if instance.save() is smart about how it calls the database, which I think it is, we're good | 12:30 |
| sfinucan | artom: looking | 12:30 |
| *** edmondsw has joined #openstack-nova | 12:31 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: [WIP] PIC NUMA policy PoC https://review.openstack.org/390520 | 12:32 |
| *** kevinz has joined #openstack-nova | 12:34 | |
| artom | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L721 https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L663 | 12:35 |
| *** liusheng has quit IRC | 12:35 | |
| *** jheroux has joined #openstack-nova | 12:35 | |
| artom | ^^ that pretty conclusively indicates that if device_metadata has not changed, there will be no useless DB calls | 12:36 |
| *** liusheng has joined #openstack-nova | 12:36 | |
| *** houming has quit IRC | 12:38 | |
| *** sree has joined #openstack-nova | 12:38 | |
| *** moshele has quit IRC | 12:42 | |
| sfinucan | artom: That would be reading of it to | 12:42 |
| sfinucan | Good spot | 12:42 |
| sfinucan | So | 12:42 |
| *** sree has quit IRC | 12:43 | |
| sfinucan | We can just call it every single time with negligible performance impact | 12:43 |
| *** esberglu has joined #openstack-nova | 12:44 | |
| *** esberglu has quit IRC | 12:44 | |
| *** esberglu has joined #openstack-nova | 12:45 | |
| artom | sfinucan, pretty sure | 12:46 |
| artom | sfinucan, the little ones are waking up, let me drive them to daycare and I'll continue after | 12:46 |
| sfinucan | artom: (y) | 12:47 |
| * sfinucan requires food anyway | 12:47 | |
| *** esberglu has quit IRC | 12:49 | |
| *** sree has joined #openstack-nova | 12:50 | |
| *** salv-orlando has quit IRC | 12:50 | |
| *** xyang1 has joined #openstack-nova | 12:53 | |
| *** erol has joined #openstack-nova | 12:53 | |
| *** arne_r has joined #openstack-nova | 12:54 | |
| erol | hi everyone, I wonder Is there any way to flush Nova Schedular RetryFilter count? I hit max attempt. What can i do now? | 12:56 |
| sean-k-mooney | sc68cal: if you get a chance can you review https://review.openstack.org/#/c/444788 it will fix our third party ci after https://review.openstack.org/#/c/435575/ added a test requirement that break ovs compilation | 12:56 |
| sean-k-mooney | sc68cal: it should also give a speed up in the ci jobs as less stuff needs to be downloaded which is a nice side effect | 12:57 |
| sean-k-mooney | erol: usually you delete the instance and try again but if you hit max attempts its often because there was a problem with the request | 12:58 |
| sean-k-mooney | erol: either no host satifies the request or you have an infra issue that is stoping the cloud from working correctly | 12:58 |
| *** abalutoiu_ has joined #openstack-nova | 13:00 | |
| *** yingjun has joined #openstack-nova | 13:01 | |
| *** zhurong has quit IRC | 13:01 | |
| *** gszasz has joined #openstack-nova | 13:02 | |
| *** bvanhav has quit IRC | 13:03 | |
| erol | sean-k-mooney: Thanks. I try to run Ironic and have an issue on provisioning. After I attempted several times. I came a cross with these output in schedular log http://paste.openstack.org/show/602488/ | 13:03 |
| *** bvanhav has joined #openstack-nova | 13:03 | |
| *** tblakes has joined #openstack-nova | 13:04 | |
| *** beagles is now known as beagles_mtg | 13:04 | |
| *** nicolasbock has quit IRC | 13:05 | |
| *** Guest84425 has quit IRC | 13:06 | |
| *** nicolasbock has joined #openstack-nova | 13:09 | |
| *** liverpooler has joined #openstack-nova | 13:09 | |
| *** liverpooler has quit IRC | 13:09 | |
| *** liverpooler has joined #openstack-nova | 13:10 | |
| *** youzp has quit IRC | 13:11 | |
| *** youzp has joined #openstack-nova | 13:12 | |
| *** vladikr has joined #openstack-nova | 13:12 | |
| openstackgerrit | Rafael Folco proposed openstack/nova master: DELETE all inventory for a resource provider https://review.openstack.org/416669 | 13:12 |
| openstackgerrit | Rafael Folco proposed openstack/nova master: Raising http codes on old microversion https://review.openstack.org/444497 | 13:12 |
| *** sudipto has joined #openstack-nova | 13:13 | |
| *** eharney has quit IRC | 13:14 | |
| *** gcb has joined #openstack-nova | 13:14 | |
| *** salv-orlando has joined #openstack-nova | 13:15 | |
| *** youzp has quit IRC | 13:16 | |
| *** esberglu has joined #openstack-nova | 13:19 | |
| *** esberglu has quit IRC | 13:19 | |
| *** esberglu has joined #openstack-nova | 13:19 | |
| *** kevinz has quit IRC | 13:20 | |
| *** kevinz has joined #openstack-nova | 13:20 | |
| *** kaisers_ has joined #openstack-nova | 13:20 | |
| *** salv-orl_ has joined #openstack-nova | 13:24 | |
| *** salv-orlando has quit IRC | 13:26 | |
| *** VAhl has quit IRC | 13:27 | |
| *** smatzek has quit IRC | 13:29 | |
| *** lucasagomes is now known as lucas-hungry | 13:35 | |
| *** eharney has joined #openstack-nova | 13:40 | |
| *** felipemonteiro has joined #openstack-nova | 13:41 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: [WIP] PIC NUMA policy PoC https://review.openstack.org/390520 | 13:41 |
| *** hongbin has joined #openstack-nova | 13:45 | |
| *** mdnadeem has quit IRC | 13:46 | |
| *** eharney has quit IRC | 13:47 | |
| *** gouthamr has joined #openstack-nova | 13:47 | |
| *** eharney has joined #openstack-nova | 13:47 | |
| *** ayogi has quit IRC | 13:48 | |
| *** mriedem has joined #openstack-nova | 13:48 | |
| mriedem | o/ | 13:48 |
| *** sudipto has quit IRC | 13:50 | |
| *** salv-orl_ has quit IRC | 13:51 | |
| *** jpena is now known as jpena|lunch | 13:51 | |
| dansmith | alex_xu: you still around? | 13:51 |
| *** baoli has joined #openstack-nova | 13:52 | |
| *** iceyao has quit IRC | 13:52 | |
| *** gcb has quit IRC | 13:52 | |
| *** iceyao has joined #openstack-nova | 13:52 | |
| bauzas | oh, you US folks already had DST shift ? | 13:55 |
| edleafe | Scheduler subteam meeting in 5 minutes in #openstack-meeting-alt | 13:55 |
| leakypipes | rfolco: were you working on adding error codes (in addition to error messages) to the placement API? can't remember if that was you or diga... | 13:55 |
| mriedem | bauzas: that was this weekend | 13:55 |
| edleafe | bauzas: yep - yeaterday | 13:55 |
| mriedem | leakypipes: neither https://review.openstack.org/#/c/418393/ | 13:56 |
| leakypipes | mriedem: ah! | 13:56 |
| leakypipes | it was _gryf | 13:56 |
| *** irenab has quit IRC | 13:56 | |
| bauzas | mriedem: edleafe: cool then, France is now closer to the US :) | 13:57 |
| rfolco | leakypipes, morning. Not me. | 13:58 |
| leakypipes | rfolco: np :) thanks! | 13:59 |
| *** irenab_ has joined #openstack-nova | 13:59 | |
| *** zz_dimtruck is now known as dimtruck | 13:59 | |
| *** lucasxu has joined #openstack-nova | 14:00 | |
| edleafe | leakypipes: time to plug the leak | 14:00 |
| *** leakypipes is now known as jaypipes | 14:00 | |
| jaypipes | :) | 14:00 |
| *** arne_r has quit IRC | 14:00 | |
| *** baoli has quit IRC | 14:01 | |
| *** dnalezyty has joined #openstack-nova | 14:02 | |
| *** baoli has joined #openstack-nova | 14:02 | |
| *** mlavalle has joined #openstack-nova | 14:02 | |
| *** yingjun has quit IRC | 14:02 | |
| *** ltomasboz is now known as ltomasbo | 14:02 | |
| *** amoralej is now known as amoralej|lunch | 14:04 | |
| _gryf | yup, I did that bp | 14:04 |
| *** amotoki_ has quit IRC | 14:05 | |
| markus_z | mriedem: JFYI, the VNC issue we talked about 1w ago will be fixed with: https://review.openstack.org/#/c/444164/ | 14:05 |
| *** awaugama has joined #openstack-nova | 14:05 | |
| *** smatzek has joined #openstack-nova | 14:05 | |
| *** gcb has joined #openstack-nova | 14:07 | |
| markus_z | mriedem: I also have to pester you about: https://review.openstack.org/#/c/406898/ All info you asked for is added to that review. | 14:07 |
| *** baoli has quit IRC | 14:08 | |
| mriedem | ok | 14:08 |
| openstackgerrit | dane-fichter proposed openstack/nova-specs master: Trusted flavors https://review.openstack.org/312225 | 14:09 |
| sfinucan | jaypipes: Might you be so kind as to stick this on your review backlog for this week? https://review.openstack.org/#/c/361140/ | 14:10 |
| *** dane-fichter has joined #openstack-nova | 14:10 | |
| sfinucan | johnthetubaguy too ^, if you could | 14:10 |
| *** sudipto has joined #openstack-nova | 14:10 | |
| *** sree has quit IRC | 14:11 | |
| *** Jeffrey4l has joined #openstack-nova | 14:12 | |
| * johnthetubaguy nods at sfinucan | 14:12 | |
| * sfinucan nods back at johnthetubaguy | 14:12 | |
| dane-fichter | mriedem , sdague : Could you guys take a look at my change adding the security tempest tests as an experimental check in Nova? https://review.openstack.org/#/c/443167/ | 14:12 |
| mriedem | dane-fichter: sure | 14:13 |
| dane-fichter | mriedem: thanks! | 14:14 |
| *** links has quit IRC | 14:16 | |
| *** Jeffrey4l has quit IRC | 14:17 | |
| *** Jeffrey4l has joined #openstack-nova | 14:18 | |
| jaypipes | sfinucan: ya | 14:18 |
| sfinucan | jaypipes: Thank you, sir | 14:19 |
| jaypipes | sfinucan: np. you know I love my numa. :P | 14:19 |
| sfinucan | jaypipes: I saw numa'y stuff and decided to r̶u̶i̶n̶ make your day | 14:20 |
| *** baoli has joined #openstack-nova | 14:22 | |
| *** hshiina has quit IRC | 14:22 | |
| *** baoli has quit IRC | 14:22 | |
| mriedem | markus_z: the multinode vnc fix looks good to me, that's even called out in the devstack multinode docs | 14:22 |
| jaypipes | sfinucan: :) | 14:24 |
| *** burt has joined #openstack-nova | 14:24 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Add a note about 'cells_api' https://review.openstack.org/444926 | 14:25 |
| *** beagles_mtg is now known as beagles | 14:25 | |
| dansmith | johnthetubaguy: alex_xu: I'm totally lost.. where does cachingscheduler override things in HostManager? | 14:26 |
| johnthetubaguy | dansmith: it uses get_all_hosts() basically | 14:26 |
| *** vsaienk0 has joined #openstack-nova | 14:27 | |
| johnthetubaguy | rather than get_by_uuid | 14:27 |
| johnthetubaguy | s | 14:27 |
| *** markus_z has quit IRC | 14:27 | |
| johnthetubaguy | dansmith: https://github.com/openstack/nova/blob/master/nova/scheduler/caching_scheduler.py#L75 | 14:27 |
| johnthetubaguy | dansmith: might be time to deprecate that thing soon, although I was hoping to wait until we do allocations in the conductor really | 14:28 |
| dansmith | johnthetubaguy: okay the main scheduler uses that purely to prime the data structures, but not for an actual schedule.. wouldn't the caching scheduler only cache hosts that are valid for a particular spec_obj if we made that change? | 14:28 |
| johnthetubaguy | dansmith: no, it caches the full list of hosts | 14:28 |
| johnthetubaguy | and bypasses the placement PAI | 14:28 |
| johnthetubaguy | API | 14:28 |
| johnthetubaguy | dansmith: did we have moving allocations into the conductor pencilled in for this cycle yet? | 14:29 |
| dansmith | johnthetubaguy: right, but.. I don't understand what you think needs to change.. the _all_cells method takes a spec_obj only if you want to cause it to limit the host list based on a requested cell, | 14:29 |
| dansmith | which you'd never want to do with that right? | 14:29 |
| johnthetubaguy | dansmith: oh, sorry, I see your point now... it just doesn't work for the caching scheduler | 14:30 |
| *** udesale has joined #openstack-nova | 14:30 | |
| dansmith | right | 14:30 |
| *** kevinz has quit IRC | 14:31 | |
| dansmith | johnthetubaguy: either we'd have to honor the cell request somewhere else, or just not have this happen if you're using cachingscheduler | 14:31 |
| dansmith | I dunno who all uses it, tbh, so I guess I'm not sure the implications of that | 14:31 |
| *** kevinz has joined #openstack-nova | 14:32 | |
| johnthetubaguy | dansmith: large deployments currently suck without using that, like >100 nodes or something like that, so probably only the large ones | 14:32 |
| dansmith | johnthetubaguy: what about large deployments now that we have placement? | 14:32 |
| *** baoli has joined #openstack-nova | 14:32 | |
| dansmith | johnthetubaguy: we should be getting the host list waaayyy faster now as of this cycle | 14:32 |
| johnthetubaguy | dansmith: they are much worse, if I understand it correctly | 14:32 |
| dansmith | WAT | 14:33 |
| johnthetubaguy | yep | 14:33 |
| *** satyar has joined #openstack-nova | 14:33 | |
| dansmith | why? | 14:33 |
| vsaienk0 | mriedem: could you please approve https://blueprints.launchpad.net/nova/+spec/ironic-hotplug-interfaces for Pike, the code is ready on both nova and ironic side, and it is very small change which already covered by CI tests. It would be great to have this implemented in Pike | 14:33 |
| johnthetubaguy | dansmith: we don't do the allocations soon enough | 14:33 |
| dansmith | jaypipes: ^ | 14:33 |
| johnthetubaguy | dansmith: so you quickly hit the three retries, because everyone picks the same host | 14:33 |
| dansmith | johnthetubaguy: placement makes that _worse_ ? | 14:33 |
| dansmith | I thought cachingscheduler was for get_all_hosts() performance... | 14:34 |
| johnthetubaguy | dansmith: worse than using caching scheduler, I mean | 14:34 |
| * jaypipes reads back | 14:34 | |
| johnthetubaguy | dansmith: its performance, and caching of results between API calls | 14:34 |
| *** kaisers_ has quit IRC | 14:34 | |
| dansmith | johnthetubaguy: does cachingscheduler affect allocation timing though? I thought it was just about finding the list of hosts quickly, which placement *should*be improving | 14:34 |
| johnthetubaguy | jaypipes: in my head I had us killing the caching scheduler once allocations are written in the conductor | 14:35 |
| johnthetubaguy | dansmith: no, its also about that cache being updated with the previous results, thats why it only works if you have one nova-scheduler, and fails badly if you have two caching schedulers | 14:35 |
| *** dave-mccowan has joined #openstack-nova | 14:35 | |
| dansmith | johnthetubaguy: ugh, okay | 14:35 |
| johnthetubaguy | dansmith: yeah, its really non-obvious from the code thats how it works | 14:36 |
| *** claudiub has quit IRC | 14:36 | |
| johnthetubaguy | dansmith: that logic that makes when we scheduler a request of 5 builds at once not all pick the same host activates for every request using the same cached list | 14:37 |
| mriedem | vsaienk0: done | 14:37 |
| *** marst has quit IRC | 14:37 | |
| *** lucas-hungry is now known as lucasagomes | 14:37 | |
| vsaienk0 | mriedem: thanks! | 14:37 |
| jaypipes | johnthetubaguy: I'd appreciate a hangout discussion with you about the caching scheduler and the placement service. | 14:38 |
| jaypipes | johnthetubaguy: do you have some time to discuss it now? | 14:38 |
| dansmith | johnthetubaguy: I guess I'm surprised that's a real problem with randomizing the result list and sufficient capacity | 14:38 |
| dansmith | jaypipes: I want in on that | 14:38 |
| dansmith | because cells. | 14:38 |
| mriedem | can't you configure the scheduler to spread rather than pack? or does just no one do that in production? | 14:38 |
| jaypipes | dansmith: I figured as much :) | 14:38 |
| johnthetubaguy | jaypipes: dansmith: I have 20 mins now if you are both free? | 14:38 |
| dansmith | I am | 14:38 |
| jaypipes | me too. | 14:38 |
| mriedem | i'm jumping in too | 14:38 |
| jaypipes | sec, getting link. | 14:38 |
| johnthetubaguy | mriedem: right, no one wants spread, because you run our of large instances | 14:38 |
| jaypipes | https://hangouts.google.com/call/s6p6dqm3dfbyxjwu5ppyhj4y2ae | 14:39 |
| jaypipes | mriedem: ^ | 14:39 |
| mriedem | yeah, damn firefox doesn't support hangouts anymore on the latest version | 14:40 |
| * mriedem switches | 14:40 | |
| dansmith | jaypipes: https://review.openstack.org/#/c/438025/21/nova/scheduler/host_manager.py | 14:41 |
| * alex_xu jump in the hangout to train English listening | 14:43 | |
| *** felipemonteiro has quit IRC | 14:43 | |
| sc68cal | sean-k-mooney: you'll need to reach out to sdague about that issue, I'd like his input | 14:46 |
| *** tonygunk has quit IRC | 14:46 | |
| *** amoralej|lunch is now known as amoralej | 14:46 | |
| jaypipes | johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/scheduler/client/__init__.py#L77 | 14:47 |
| *** marst has joined #openstack-nova | 14:48 | |
| mriedem | pkoniszewski: i'm not totally sure about this backport since no one from the live migration subteam reviewed the change on master, can you take a look at this and see if the change itself (even though already merged on master), is OK? https://review.openstack.org/#/c/441037/ | 14:49 |
| *** marst has quit IRC | 14:53 | |
| *** marst has joined #openstack-nova | 14:53 | |
| *** mkoderer has joined #openstack-nova | 14:53 | |
| *** jpena|lunch is now known as jpena | 14:54 | |
| openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225 | 14:55 |
| *** baoli has quit IRC | 14:55 | |
| *** baoli_ has joined #openstack-nova | 14:55 | |
| *** tonygunk has joined #openstack-nova | 14:56 | |
| *** dimtruck is now known as zz_dimtruck | 14:57 | |
| *** kevinz has quit IRC | 14:57 | |
| *** esberglu has quit IRC | 14:57 | |
| *** kevinz has joined #openstack-nova | 14:57 | |
| *** esberglu has joined #openstack-nova | 14:57 | |
| *** yamahata has joined #openstack-nova | 14:58 | |
| *** gongysh has quit IRC | 14:59 | |
| mriedem | pkoniszewski: nevermind, it's only for resize, and tests there are all OK, so lgtm. | 15:00 |
| mriedem | lyarwood: can you take a look at these ocata backports for a release this week? https://review.openstack.org/#/c/441171/ https://review.openstack.org/#/c/444374/ | 15:01 |
| *** esberglu has quit IRC | 15:02 | |
| mriedem | dansmith: note i haven't posted the pike priorities list to the specs repo yet, but we had a list from the ptg, so this will change that | 15:03 |
| *** raj_singh_ has joined #openstack-nova | 15:03 | |
| dansmith | mriedem: it will a little, but I think it's clear that claims will be a queens thing | 15:03 |
| *** liangy has joined #openstack-nova | 15:04 | |
| mriedem | dansmith: ok that works too - and good to know since at the summit i/we have to present on what's in the works for queens, as annoying as that is to be reporting at this point | 15:04 |
| dansmith | yeah | 15:04 |
| sean-k-mooney | sc68cal: sure will do. thanks for taking a look though | 15:06 |
| artom | johnthetubaguy, heya - sfinucan mentioned that the the SPICE native proxy spec (https://review.openstack.org/#/c/442040/) might be relevant to XVP in Xen - I'm mostly ignorant of what XVP is, but from a quick read I don't *think* there's any potential crossover between a SPICE native proxy, other than both are proxies, but maybe you could take a look? | 15:06 |
| *** adrian_otto has joined #openstack-nova | 15:07 | |
| sean-k-mooney | erol: i dont think you are ment to use the RamFilter with ironic. at least in the past it had its own filter that replaced it | 15:07 |
| *** irenab_ has quit IRC | 15:08 | |
| *** sridharg has quit IRC | 15:08 | |
| *** esberglu has joined #openstack-nova | 15:09 | |
| *** burgerk has joined #openstack-nova | 15:09 | |
| *** moshele has joined #openstack-nova | 15:10 | |
| *** felipemonteiro has joined #openstack-nova | 15:10 | |
| *** kevinz has quit IRC | 15:10 | |
| *** udesale has quit IRC | 15:13 | |
| *** jianghuaw has quit IRC | 15:14 | |
| *** zz_dimtruck is now known as dimtruck | 15:15 | |
| *** dane-fichter has quit IRC | 15:17 | |
| *** yingjun has joined #openstack-nova | 15:17 | |
| BobBall | artom: Does this have to be spice-specific? XenAPI uses vnc consoles and - apart from the references to spice throughout the spec and in the API call - the proxying of the connection in this way should probably work for all console types, not just spice? | 15:19 |
| artom | BobBall, not at all :) | 15:19 |
| *** armax has joined #openstack-nova | 15:20 | |
| artom | The proxy code itself is completely generic, it's just iptables shovelling packets back and forth | 15:20 |
| BobBall | Indeed - the only thing that concerns me ATM is using os-getSPICEConsole spice-native which is clearly spice specific | 15:20 |
| *** mriedem has quit IRC | 15:20 | |
| artom | We started with SPICE because we need a user-facing feature to actually drive it, but we'll be happy to make adjustments of other drivers need it for them as well | 15:20 |
| artom | BobBall, well, that's the API part for the user to get a URL for his native SPICE client | 15:21 |
| *** gfhellma has quit IRC | 15:21 | |
| erol | sean-k-mooney: I am using mirantis openstack with default settings. :( | 15:21 |
| artom | BobBall, if xenapi wants a native proxy for their console an API can be added for that as well | 15:22 |
| BobBall | artom: Understood. I'll comment on the spec. | 15:23 |
| *** beekneemech is now known as bnemec | 15:23 | |
| artom | And it can tell nova-nativeproxy which host/port it should start a proxy instance for | 15:23 |
| artom | The host/port would come from the xenapi hypervisor, presumably | 15:23 |
| artom | But that's your domain ;) | 15:23 |
| BobBall | Indeed. That's how our consoles work with novnc currently. | 15:23 |
| *** mriedem has joined #openstack-nova | 15:25 | |
| *** fragatina has joined #openstack-nova | 15:25 | |
| *** hieulq_ has joined #openstack-nova | 15:26 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Modify PciPassthroughFilter to accept lists https://review.openstack.org/444946 | 15:27 |
| *** baoli_ has quit IRC | 15:27 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Make versioned notifications topics configurable https://review.openstack.org/444947 | 15:28 |
| *** amotoki has joined #openstack-nova | 15:28 | |
| *** bvanhav has quit IRC | 15:28 | |
| *** satyar has quit IRC | 15:28 | |
| *** bvanhav has joined #openstack-nova | 15:29 | |
| sfinucan | artom: Think I've all of https://review.openstack.org/#/q/topic:bp/virt-device-tagged-attach-detach reviewed now | 15:31 |
| sfinucan | Thanks dansmith for the cells v1 clarification. I recorded it in the code itself here https://review.openstack.org/444926 | 15:31 |
| *** armax has quit IRC | 15:31 | |
| *** baoli has joined #openstack-nova | 15:31 | |
| artom | sfinucan, much thanks :) You were responsible for a cute moment this morning. I saw your "oh boy, here we go" email, laughed, daughter asked why I was laughing and wanted to see, I showed her your email, she did a forced laugh as well | 15:32 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read NIC features in libvirt https://review.openstack.org/444415 | 15:32 |
| *** yingjun has quit IRC | 15:33 | |
| BobBall | artom: Just for my understanding, does requesting the spice console generate a unique password per request, or is a fixed password generated and associated with each VM? | 15:34 |
| sfinucan | artom: Ha! cute :D | 15:34 |
| artom | BobBall, the password is set by the libvirt driver on the SPICE console, and returned to the user | 15:35 |
| artom | BobBall, xenapi can do whatever it wants in that regard | 15:35 |
| BobBall | artom: So libvirt assigns a non-predictable password to each console? | 15:35 |
| artom | BobBall, that's the current plan, yeah | 15:36 |
| artom | Libvirt would set a new password on every request | 15:36 |
| BobBall | ok thanks | 15:37 |
| *** bvanhav_ has joined #openstack-nova | 15:37 | |
| *** burgerk_ has joined #openstack-nova | 15:37 | |
| artom | Since this is essentially opening up the host's console socket to the entire world, we need to make it a minimum secure | 15:37 |
| artom | So TLS if possible, and authentication | 15:37 |
| *** smatzek_ has joined #openstack-nova | 15:37 | |
| BobBall | I totally agree. | 15:37 |
| *** bvanhav__ has joined #openstack-nova | 15:37 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova-specs master: Add use-local-scheduler spec https://review.openstack.org/438936 | 15:39 |
| *** bvanhav has quit IRC | 15:40 | |
| *** burgerk has quit IRC | 15:41 | |
| *** smatzek has quit IRC | 15:41 | |
| *** burgerk_ has quit IRC | 15:41 | |
| *** bvanhav_ has quit IRC | 15:41 | |
| *** karthiks is now known as karthiks_afk | 15:43 | |
| *** iceyao has quit IRC | 15:46 | |
| *** snecklifter has quit IRC | 15:47 | |
| mriedem | dansmith: replied in https://review.openstack.org/#/c/443403/ - let me know if i need to change things. starting orientation for the rest of the day in about 10 minutes | 15:48 |
| bauzas | dansmith: jroll: jaypipes: do we have some spec that explains our consensus in L66 https://etherpad.openstack.org/p/nova-ptg-pike-placement | 15:50 |
| bauzas | ? | 15:50 |
| bauzas | tl;dr: ironic flavors need to be updated by adding extra specs | 15:50 |
| bauzas | s/explains/reflects | 15:51 |
| jroll | bauzas: that's on my list for this week | 15:51 |
| jroll | (writing that spec) | 15:51 |
| bauzas | jroll: okay, ping me when it's done, because I'm trying to push it downstream | 15:51 |
| jroll | bauzas: will do, thanks | 15:52 |
| *** psachin has quit IRC | 15:52 | |
| bauzas | jroll: FWIW, operators would need to add a custom resource class in their extra spec per type of flavor they have, correct? | 15:52 |
| openstackgerrit | Cedric Brandily proposed openstack/nova master: Remove VMware driver _get_vm_ref_from_uuid method https://review.openstack.org/444959 | 15:53 |
| dansmith | bauzas: yes | 15:54 |
| jroll | bauzas: yes | 15:54 |
| * jroll throws a coke at dansmith | 15:54 | |
| openstackgerrit | Cedric Brandily proposed openstack/nova master: VMware: use WithRetrieval in get_network_with_the_name https://review.openstack.org/325587 | 15:57 |
| openstackgerrit | Cedric Brandily proposed openstack/nova master: VMware: use WithRetrieval in vm_util module https://review.openstack.org/325608 | 15:59 |
| openstackgerrit | Cedric Brandily proposed openstack/nova master: VMware: use WithRetrieval in ds_util module https://review.openstack.org/325610 | 15:59 |
| erol | sean-k-mooney: Hey, When I added another ironic node, I didt get error from Schedular. I think it is all about RetryFilter. | 15:59 |
| *** crushil has joined #openstack-nova | 15:59 | |
| *** liusheng has quit IRC | 16:00 | |
| *** liusheng has joined #openstack-nova | 16:00 | |
| sean-k-mooney | erol: interesting. though the pastbin was showing that the ram filter was the filter that eliminated all of the host | 16:01 |
| sean-k-mooney | erol: Filter results: ['RetryFilter: (start: 4, end: 3)', 'AvailabilityZoneFilter: (start: 3, end: 3)', 'RamFilter: (start: 3, end: 0)'] | 16:01 |
| sean-k-mooney | erol: the retry filter eliminated 1 host which was the host that was tried first | 16:02 |
| *** marst_ has joined #openstack-nova | 16:03 | |
| erol | sean-k-mooney: all of 3 node is kvm node, there is no enough resource that instance need on them. Sorry for the indicate it. | 16:03 |
| sean-k-mooney | erol: so you have a mixed deployment ironic/kvm? | 16:04 |
| *** nic has joined #openstack-nova | 16:04 | |
| erol | I think Retryfilter eliminate Ironic node, and then When it check ram resource it cant find correct one in kvm nodes. | 16:04 |
| sean-k-mooney | and the ram filter failed on the kvm nodes when trying to select a baremetal flavor | 16:04 |
| erol | sean-k-mooney: yeah. 3 Nova Compute 2 ironic compute for now. | 16:05 |
| sean-k-mooney | erol: the retry filter only filters nodes if it tred to scheduler to it and then failed | 16:05 |
| sean-k-mooney | erol: it previously selected u'ironic-compute', u'f01c9155-7d1e-4351-8225-670e0d48452a' that failed to boot and it retryed the rest - that node | 16:06 |
| *** claudiub has joined #openstack-nova | 16:06 | |
| *** marst has quit IRC | 16:06 | |
| *** moshele has quit IRC | 16:06 | |
| *** belmoreira has quit IRC | 16:06 | |
| erol | sean-k-mooney: I am doing lots of mistake about metadata and resources. Then ironic instances faild on provisioning. Maybe i need the delete ironic-compute history when i reach the max attempt. | 16:07 |
| *** dtp has joined #openstack-nova | 16:07 | |
| *** raghav has joined #openstack-nova | 16:08 | |
| erol | sean-k-mooney: failed* | 16:08 |
| raghav | hi | 16:08 |
| raghav | i am getting error in watcher code..which root causes in nova code | 16:08 |
| sean-k-mooney | erol: perhaps. i have used ironic but only in a limited fashion. one thing that you should be aware of is when deleteing ironic nodes it does not alway delete the neutron port which can cause issues | 16:09 |
| raghav | +----------------+---------------------+-----------------+----------------+-------+ | ID | Hypervisor Hostname | Hypervisor Type | Host IP | State | +----------------+---------------------+-----------------+----------------+-------+ | region!child@1 | praveen-dev | QEMU | 10.223.197.217 | up | +----------------+---------------------+-----------------+----------------+-------+ | 16:09 |
| sean-k-mooney | *used ironic much, only in a limited fashion | 16:09 |
| raghav | here id fiels is non-integer | 16:10 |
| sean-k-mooney | raghav: the id field is a string | 16:10 |
| raghav | my nova-api version is 15.0.1 | 16:10 |
| sean-k-mooney | raghav: infact its usally a uuid | 16:10 |
| raghav | but in doc its integer | 16:10 |
| raghav | https://github.com/openstack/nova/blob/stable/mitaka/nova/objects/compute_node.py#L59 | 16:11 |
| erol | sean-k-mooney: I wish there is a cli command to flush failed attempt for RetryFilter | 16:12 |
| raghav | i am getting parsing error in watcher because of this | 16:12 |
| sean-k-mooney | raghav: so the id field in the db is an int | 16:13 |
| sean-k-mooney | however i belive the ID filed in the api maps to the UUID field in the db as the id filed in the db is not exposed | 16:14 |
| sean-k-mooney | raghav: i could be wrong on that but jaypipes or mriedem shoudl be able to confirm | 16:14 |
| mriedem | which table? | 16:15 |
| mriedem | we expose the compute_nodes.id field out of the API | 16:15 |
| mriedem | b/c we're dumb | 16:15 |
| *** david-lyle has joined #openstack-nova | 16:15 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/hypervisors.py#L52 | 16:16 |
| mriedem | sean-k-mooney: i plan on fixing that | 16:16 |
| mriedem | https://blueprints.launchpad.net/nova/+spec/service-hyper-pci-uuid-in-api | 16:16 |
| sean-k-mooney | raghav: actully i might be getting confused with the flavor sorry ignore what i previously said. | 16:17 |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova master: Cleanup code in create_ploop_image https://review.openstack.org/444970 | 16:17 |
| sean-k-mooney | mriedem: cool | 16:17 |
| mriedem | sean-k-mooney: we expose the flavor.id too out of the API | 16:17 |
| *** Apoorva has joined #openstack-nova | 16:18 | |
| sean-k-mooney | mriedem: yes but for the flavor id that is also user set able as any arbitry string, and i know several people who have reversed the name and id filed on the commandline so that is even more of an issue | 16:18 |
| *** kaisers_ has joined #openstack-nova | 16:19 | |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova master: Cleanup code in create_ploop_image https://review.openstack.org/444970 | 16:19 |
| mriedem | sean-k-mooney: well, there is flavor.id and flavor.flavorid | 16:19 |
| mriedem | flavor.flavorid is user-settable | 16:19 |
| mriedem | flavor.id is the primary key | 16:19 |
| mriedem | i guess we don't expose flavor.id here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/flavors.py#L34 | 16:20 |
| mriedem | it might be the server get | 16:20 |
| *** moshele has joined #openstack-nova | 16:20 | |
| *** raunak has joined #openstack-nova | 16:20 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/servers.py#L259 i guess that's flavorid too | 16:20 |
| *** nicolasbock has quit IRC | 16:21 | |
| sdague | mriedem: we don't expose the .id anywhere iirc | 16:21 |
| mriedem | sdague: ok i thought we did and that was part of what prompted your original spec to nest the flavor details in the server response | 16:21 |
| mriedem | it also came up when moving flavors from the cell to the api db | 16:21 |
| mriedem | i might be misremembering details though, it was a year ago | 16:21 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: SPICE native client support https://review.openstack.org/442040 | 16:23 |
| sdague | mriedem: there were interesting challenges with flavor.id in cells v1, because it is an auto incrementing id | 16:23 |
| sdague | and, thus could be different in the cells | 16:23 |
| sdague | it is used as the join column | 16:24 |
| dansmith | same for cellsv2 of course, | 16:24 |
| dansmith | but I think we've gotten rid of all those things by now | 16:24 |
| *** READ10 has joined #openstack-nova | 16:25 | |
| *** nicolasbock has joined #openstack-nova | 16:25 | |
| raghav | mriedem: so is it bug in nova code? | 16:28 |
| mriedem | raghav: is what a bug in nova code? sorry i'm on a call so i'm not sure what the earlier discussion is about. | 16:28 |
| mriedem | raghav: are you using cellsv1? i see region!child@1 | 16:29 |
| mriedem | that looks like cellsv1 | 16:29 |
| *** kaisers_ has quit IRC | 16:29 | |
| *** kaisers_ has joined #openstack-nova | 16:29 | |
| *** moshele has quit IRC | 16:30 | |
| raghav | mriedem: i have devstack setup | 16:30 |
| mriedem | raghav: note that you don't want to be using cellsv1 | 16:30 |
| raghav | mriedem: with ocata release | 16:30 |
| mriedem | raghav: what's your ENABLED_SERVICES variable? | 16:30 |
| mriedem | you shouldn't have n-cell-region or n-cell-child | 16:30 |
| raghav | mriedem: n-api,n-cpu,n-cond,n-sch,n-novnc,n-cauth | 16:31 |
| mriedem | sorry just n-cell | 16:31 |
| *** gfhellma has joined #openstack-nova | 16:32 | |
| *** salv-orlando has joined #openstack-nova | 16:35 | |
| *** hieulq_ has quit IRC | 16:35 | |
| mriedem | raghav: in general, we don't want int id's exposed out of the API, which is why we have https://blueprints.launchpad.net/nova/+spec/service-hyper-pci-uuid-in-api | 16:36 |
| mriedem | raghav: but that's going to be done in a microversion | 16:36 |
| sdague | raghav: honestly, I think there is a lot of confusion about how you got to that kind of data, and the only way any of us know that to be possible is if you have a cells v1 setup | 16:37 |
| sdague | raghav: so, perhaps a reproduce scenario would be useful | 16:38 |
| mriedem | raghav: for now os-hypervisors will return an int for the id https://developer.openstack.org/api-ref/compute/?expanded=show-hypervisor-statistics-detail,show-hypervisor-details-detail | 16:38 |
| *** pcaruana has quit IRC | 16:38 | |
| mriedem | as shown in the docs | 16:38 |
| mriedem | my blueprint is to change that to return the uuid rather than the int id | 16:38 |
| melwitt | sdague: in cells v1, we don't officially support flavors in cell dbs. users like CERN have their own automation that syncs flavors from the api cell db to the child cell dbs. fwiw | 16:38 |
| mriedem | raghav: as for the hypervisor hostname being "region!child@1" that looks like cellsv1 | 16:39 |
| mriedem | so it seems you have n-cells running somewhere in your devstack setup | 16:39 |
| sdague | melwitt: right, it was definitely a goofy thing | 16:39 |
| raghav | mriedem: yes its running | 16:40 |
| raghav | mriedem: i could see in screen | 16:40 |
| mriedem | raghav: yeah, so you don't want that | 16:40 |
| mriedem | raghav: that's going to cause you all kinds of confusion | 16:41 |
| mriedem | so i'd start over w/o n-cell enabled | 16:41 |
| raghav | mriedem: so what should i do now | 16:41 |
| *** zioproto has quit IRC | 16:41 | |
| mriedem | raghav: restack w/o n-cell for one | 16:41 |
| raghav | mriedem: in local.conf i have not enabled n-cell | 16:41 |
| mriedem | raghav: well, it's not enabled by default, so something is running it in your setup | 16:42 |
| *** hshiina has joined #openstack-nova | 16:42 | |
| *** erol has quit IRC | 16:42 | |
| mriedem | raghav: also, be aware that cells v2, which is required in ocata, is not the same as the nova-cells service, | 16:42 |
| mriedem | or n-cell service in devstack | 16:42 |
| mriedem | i know it's confusing | 16:42 |
| *** yamahata has quit IRC | 16:43 | |
| raghav | mriedem: i have n-cells-region and n-cells-child running | 16:43 |
| raghav | mriedem: if i re-stack again those will get enabled | 16:45 |
| *** mvk has quit IRC | 16:45 | |
| sdague | raghav: why do you have those running? | 16:45 |
| raghav | mriedem: i dont know how they are running, i just stacked without enabling them | 16:46 |
| melwitt | raghav: what's in your stack-screenrc? are there any n-cell* in there? | 16:46 |
| raghav | melwitt: yes n-cell-region and n-cell-chile | 16:47 |
| raghav | melwitt: yes n-cell-region and n-cell-child | 16:47 |
| sdague | raghav: so... step one, please get back to a base clean environment | 16:47 |
| melwitt | raghav: okay. so it looks like you definitely have remnants of an earlier install where n-cell was part of ENABLED_SERVICES | 16:48 |
| mriedem | dansmith: did you still want a specific unit test for https://review.openstack.org/#/c/443403/11/nova/context.py ? | 16:48 |
| openstackgerrit | Maciej Szankin proposed openstack/nova-specs master: Add use-local-scheduler spec https://review.openstack.org/438936 | 16:49 |
| dansmith | mriedem: yes, I'm not sure why we wouldn't | 16:49 |
| raghav | melwitt: how can i remove it | 16:49 |
| dansmith | mriedem: are you doing both of those in a follow-up? | 16:49 |
| mriedem | dansmith: i can do them in this change | 16:50 |
| mriedem | raghav: maybe posting your local.conf in a gist would help us | 16:51 |
| mriedem | raghav: personally i'd re-clone devstack from stable/ocata to make sure it's completely clean | 16:51 |
| mriedem | in a new vm | 16:51 |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Spec to add per instance timeout for LM https://review.openstack.org/442809 | 16:53 |
| melwitt | yeah, I'm not 100% an unstack.sh/stack.sh after killing processes would result in a fresh read of ENABLED_SERVICES | 16:53 |
| mriedem | i would completely start over | 16:53 |
| sdague | that should, but a ./clean.sh is even safer | 16:53 |
| sdague | yeh, completely fresh not a bad idea either | 16:53 |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: WIP: Replace live migration steps and delays with memory iteration logic https://review.openstack.org/443339 | 16:53 |
| sdague | there are clearly bits left over from some past config | 16:54 |
| raghav | ok | 16:56 |
| raghav | thanks | 16:56 |
| *** lucasagomes has quit IRC | 16:59 | |
| *** armax has joined #openstack-nova | 16:59 | |
| *** lucasagomes has joined #openstack-nova | 17:00 | |
| *** efoley_ has joined #openstack-nova | 17:01 | |
| *** liangy has quit IRC | 17:03 | |
| *** lucasxu has quit IRC | 17:03 | |
| *** efoley__ has quit IRC | 17:04 | |
| *** kaisers_ has quit IRC | 17:05 | |
| *** andreas_s has quit IRC | 17:05 | |
| *** nkrinner is now known as nkrinner_afk | 17:05 | |
| *** gszasz has quit IRC | 17:06 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Make versioned notifications topics configurable https://review.openstack.org/444947 | 17:15 |
| *** openstackgerrit has quit IRC | 17:18 | |
| *** sudipto has quit IRC | 17:19 | |
| *** yamahata has joined #openstack-nova | 17:21 | |
| *** gouthamr has quit IRC | 17:21 | |
| *** unicell has joined #openstack-nova | 17:25 | |
| *** unicell has quit IRC | 17:25 | |
| *** unicell has joined #openstack-nova | 17:25 | |
| *** catintheroof has joined #openstack-nova | 17:25 | |
| *** bvanhav_ has joined #openstack-nova | 17:28 | |
| *** ltomasbo is now known as ltomasbo|away | 17:28 | |
| *** bvanhav_ is now known as bvanhav | 17:29 | |
| *** bvanhav__ has quit IRC | 17:29 | |
| *** openstackgerrit has joined #openstack-nova | 17:30 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Count resources to check quota for cells https://review.openstack.org/416521 | 17:30 |
| openstackgerrit | melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945 | 17:30 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | 17:30 |
| *** lucasxu has joined #openstack-nova | 17:30 | |
| mriedem | dansmith: i'm really confused about this test https://github.com/openstack/nova/blob/master/nova/tests/unit/test_context.py#L307-L310 | 17:35 |
| *** kaisers_ has joined #openstack-nova | 17:35 | |
| mriedem | shouldn't the assertion be such that the context db/mq connections within the target_cell context match what's in the mapping? | 17:35 |
| *** browne has joined #openstack-nova | 17:35 | |
| dansmith | mriedem: it does | 17:36 |
| dansmith | mriedem: maybe it should assert that get_context is called with the database url, and same for rpc, but otherwise it's checking that they get switched and restored | 17:36 |
| *** gouthamr has joined #openstack-nova | 17:38 | |
| *** efoley__ has joined #openstack-nova | 17:38 | |
| mriedem | oh nvm | 17:39 |
| mriedem | i was expecting to see it have the fake urls | 17:39 |
| *** efoley_ has quit IRC | 17:41 | |
| *** salv-orlando has quit IRC | 17:43 | |
| *** salv-orlando has joined #openstack-nova | 17:43 | |
| *** fragatina has quit IRC | 17:44 | |
| *** fragatina has joined #openstack-nova | 17:44 | |
| -openstackstatus- NOTICE: restarting gerrit to address performance problems | 17:45 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Decrement quota usage when deleting an instance in cell0 https://review.openstack.org/443395 | 17:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403 | 17:46 |
| *** abalutoiu_ has quit IRC | 17:48 | |
| *** fragatina has quit IRC | 17:49 | |
| *** derekh has quit IRC | 17:49 | |
| *** mdrabe has joined #openstack-nova | 17:51 | |
| *** vladikr has quit IRC | 17:53 | |
| *** jamielennox is now known as jamielennox|away | 17:53 | |
| *** nicolasbock has quit IRC | 17:54 | |
| *** jaosorior has quit IRC | 17:56 | |
| *** adrian_otto has quit IRC | 17:57 | |
| *** nicolasbock has joined #openstack-nova | 17:57 | |
| *** avolkov has quit IRC | 17:58 | |
| *** tesseract has quit IRC | 17:59 | |
| *** ralonsoh has quit IRC | 18:00 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add SameCellFilter https://review.openstack.org/445035 | 18:01 |
| *** aarefiev is now known as aarefiev_afk | 18:01 | |
| *** adrian_otto has joined #openstack-nova | 18:01 | |
| *** lpetrut has quit IRC | 18:03 | |
| *** thorst_afk has joined #openstack-nova | 18:04 | |
| *** thorst_afk has quit IRC | 18:04 | |
| dansmith | johnthetubaguy: have you gone away for the day yet? | 18:05 |
| *** jpena is now known as jpena|off | 18:05 | |
| melwitt | hah, my counting quota patch failed mriedem's recent quota regression functional test (the expected fail part) because I forgot it also fixes the problem | 18:05 |
| johnthetubaguy | dansmith: about to go | 18:06 |
| johnthetubaguy | dansmith: whats up? | 18:06 |
| dansmith | johnthetubaguy: okay well, just heads up on https://review.openstack.org/#/c/445035/ | 18:06 |
| johnthetubaguy | dansmith: ah, cool, I will try go through that chain again tomorrow | 18:08 |
| *** tblakes has quit IRC | 18:08 | |
| johnthetubaguy | dansmith: I forgot we don't get the cell from the host object already, which kinda sucks, but that cache seems like a good stop gap | 18:08 |
| *** raunak has quit IRC | 18:09 | |
| dansmith | johnthetubaguy: it should fill up pretty fast, not require too much memory, and only change when we add a host, so not too bad I think | 18:09 |
| *** raunak has joined #openstack-nova | 18:10 | |
| *** hshiina has quit IRC | 18:10 | |
| *** siva_krishnan has joined #openstack-nova | 18:14 | |
| *** efried has quit IRC | 18:15 | |
| *** tblakes has joined #openstack-nova | 18:16 | |
| siva_krishnan | johnthetubaguy: can you unabandon thhese patches https://review.openstack.org/#/c/308198/ https://review.openstack.org/#/c/328280/ ? | 18:16 |
| *** adrian_otto has quit IRC | 18:17 | |
| *** adrian_otto has joined #openstack-nova | 18:19 | |
| *** raunak has quit IRC | 18:20 | |
| *** slaweq_ has quit IRC | 18:20 | |
| *** mdrabe_ has joined #openstack-nova | 18:27 | |
| *** mdrabe has quit IRC | 18:28 | |
| *** READ10 has quit IRC | 18:29 | |
| *** annegentle has joined #openstack-nova | 18:29 | |
| *** nicolasbock has quit IRC | 18:33 | |
| *** mvk has joined #openstack-nova | 18:33 | |
| *** raunak has joined #openstack-nova | 18:34 | |
| *** ociuhandu has joined #openstack-nova | 18:36 | |
| *** priteau has joined #openstack-nova | 18:38 | |
| *** fragatina has joined #openstack-nova | 18:40 | |
| *** fragatina has quit IRC | 18:40 | |
| *** fragatina has joined #openstack-nova | 18:41 | |
| *** nicolasbock has joined #openstack-nova | 18:41 | |
| *** lpetrut has joined #openstack-nova | 18:46 | |
| *** lucasagomes is now known as lucas-afk | 18:46 | |
| mriedem | rfolco: do you know who juergen leopold at ibm is? running ci on nova. i'm guessing a z person. | 18:52 |
| rfolco | mriedem, hmm let me check, I knew Arne from zKVM CI from Germany these days... | 18:52 |
| rfolco | mriedem, I guess his on the same team. They were having problems with their CI last week. | 18:54 |
| mriedem | ok, i just emailed him and copied markus | 18:54 |
| mriedem | asking to start using a system id rather than his email | 18:55 |
| mriedem | and just asking what he's running | 18:55 |
| *** efoley__ has quit IRC | 18:58 | |
| *** tblakes has quit IRC | 18:59 | |
| *** tblakes has joined #openstack-nova | 19:01 | |
| *** mnestratov has quit IRC | 19:01 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova master: Remove unused columns from BuildRequest table in nova_api db https://review.openstack.org/422259 | 19:01 |
| *** dharinic is now known as dharinic|lunch | 19:02 | |
| *** mdrabe_ has quit IRC | 19:04 | |
| *** Jeffrey4l has quit IRC | 19:05 | |
| *** Jeffrey4l has joined #openstack-nova | 19:05 | |
| *** tblakes has quit IRC | 19:06 | |
| *** kfarr has joined #openstack-nova | 19:10 | |
| openstackgerrit | Sujitha proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228 | 19:13 |
| openstackgerrit | Sujitha proposed openstack/nova master: Change tags to default field in Instance object. https://review.openstack.org/415298 | 19:13 |
| openstackgerrit | Sujitha proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185 | 19:14 |
| openstackgerrit | Sujitha proposed openstack/nova master: Reduce calls to load_tags() to 0 https://review.openstack.org/435146 | 19:14 |
| *** liangy has joined #openstack-nova | 19:14 | |
| *** abalutoiu_ has joined #openstack-nova | 19:17 | |
| *** liusheng has quit IRC | 19:18 | |
| *** liusheng has joined #openstack-nova | 19:19 | |
| *** salv-orl_ has joined #openstack-nova | 19:24 | |
| cfriesen | someone pointed out to me that InstanceActionEvent.pack_action_event_finish() uses a "message" field, but the InstanceActionEvent model in the DB uses "details". Is this a bug? | 19:24 |
| cfriesen | and given that it's been in there since 2014, is anyone actually looking at it? | 19:26 |
| *** salv-orlando has quit IRC | 19:27 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova master: Remove config_drive attribute from build_requests table https://review.openstack.org/432511 | 19:28 |
| *** dharinic|lunch is now known as dharinic | 19:30 | |
| *** jdillaman has quit IRC | 19:33 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/443357 | 19:37 |
| sean-k-mooney | sdague: o/ | 19:39 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/445120 | 19:39 |
| sean-k-mooney | sdague: not sure if your about currently but could you take a look at https://review.openstack.org/#/c/444788/ if you get a chance | 19:39 |
| *** bvanhav has quit IRC | 19:39 | |
| sean-k-mooney | sdague: i asked sc68cal earlier and he said he would like you to take a look at it first. | 19:40 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add InstanceMappingList.get_by_instance_uuids https://review.openstack.org/445139 | 19:40 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add RequestContext.for_cell() https://review.openstack.org/445140 | 19:40 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add InstanceList.get_by_instance_mapping_list() https://review.openstack.org/445141 | 19:40 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Make server_external_events use an optimal number of db queries https://review.openstack.org/445142 | 19:40 |
| mdbooth | dansmith: I was playing with the cell context thing and came up with this series ^^^ | 19:42 |
| sean-k-mooney | sdague: it addresses a sidefect of https://review.openstack.org/#/c/435575/ which due to the fact that devstack installes test-requirements globally effect the test cases of ovs in our ci and any other pep8 tests that are not run in a virtual envirionment | 19:42 |
| mdbooth | dansmith: It only affects server_external_events, but the idea's there. | 19:43 |
| *** salv-orl_ has quit IRC | 19:45 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730 | 19:46 |
| *** rmk has joined #openstack-nova | 19:47 | |
| *** rmk has quit IRC | 19:47 | |
| *** rmk has joined #openstack-nova | 19:47 | |
| *** sgordon` is now known as sgordon | 19:52 | |
| *** amoralej is now known as amoralej|off | 19:57 | |
| *** Jeffrey4l has quit IRC | 20:00 | |
| *** Jeffrey4l has joined #openstack-nova | 20:01 | |
| sdague | sean-k-mooney: wait, this is all to include flake8-import-order? | 20:04 |
| sdague | can we just revert that instead? | 20:04 |
| sdague | sean-k-mooney: or more importantly, please explain to me the actual issue that's currently happening, how we got there, and why this is the fix? | 20:05 |
| *** jheroux has quit IRC | 20:05 | |
| sean-k-mooney | sdague: well the flake8-import-order change is what broke use but if your are running tempest test only there is noe reasong to install all the test requirements | 20:06 |
| sean-k-mooney | sdague: so this change also speed up our test runs | 20:06 |
| sdague | so, why did flake8-import-order break you? | 20:06 |
| sean-k-mooney | sdague: but basically when flake8-import-order was added to the test requirements devstack installes it systemwide. flake8-import-order enables it test by default | 20:07 |
| *** tblakes has joined #openstack-nova | 20:07 | |
| sdague | sean-k-mooney: the thing we've been here before, it used to be conditional | 20:07 |
| sdague | ok, so I think that's actually a really good reason to remove flake8-import-order from global requirements | 20:08 |
| sdague | and not allow it | 20:08 |
| sean-k-mooney | when we build ovs from source to test ovs-dpdk there makefile enable pep testing if flake8 is installed | 20:08 |
| sean-k-mooney | ovs does not enforce ordering so it cause the make command to fail and then we broke | 20:08 |
| sean-k-mooney | sdague: well that is one option | 20:08 |
| sdague | right, flake8-import-order seems to be far more intrusive to everything than previously realized | 20:09 |
| sdague | and I think the answer is just remove it | 20:09 |
| *** mdrabe_ has joined #openstack-nova | 20:09 | |
| sean-k-mooney | but why is devstack installing the test dependecies globally? | 20:09 |
| sdague | because everyone wanted that | 20:09 |
| sean-k-mooney | that seams just wronge | 20:09 |
| sdague | because they wanted devstack to be setting up a dev / test environment | 20:10 |
| sean-k-mooney | what why is that better then leaving tox install them | 20:10 |
| sdague | we can go dig up that change, the code used to be with a conditional here | 20:10 |
| sean-k-mooney | yes and when i use devstack to set up a test environment i always use tox to run my test and i creats a python virtual enve and installs the test requirement in it | 20:10 |
| sdague | yeh, and some of those tox environments use system libs | 20:11 |
| sean-k-mooney | sdague: ok but is there any reson to not make it condional and default to true as we proposed | 20:11 |
| sdague | because it's going to be another odd point of difference here | 20:11 |
| *** crushil has quit IRC | 20:12 | |
| sdague | and every one of these end up causing confusion | 20:12 |
| sean-k-mooney | yes but devstack is breaking the seperation of test and real requirements | 20:12 |
| sdague | sean-k-mooney: there are a bunch of different things that are bleeding across, as far as I can tell | 20:12 |
| *** amotoki has quit IRC | 20:13 | |
| sdague | flake8-import-order enables true by default, which is unexpected | 20:13 |
| *** slaweq_ has joined #openstack-nova | 20:13 | |
| sdague | ovs-dpdk is running pep8 without isolation to a venv, so it gets the impact of systems | 20:13 |
| sdague | system installed packages | 20:13 |
| sdague | devstack is installing test-requirements system level because that is what people previously wanted | 20:14 |
| sdague | sean-k-mooney: you will also find that many projects use test-requirements to specify optional dependencies | 20:14 |
| sean-k-mooney | sdague: yep | 20:15 |
| sdague | like all the db drivers are in the nova test-requirements | 20:15 |
| sean-k-mooney | that is why installing test requiremetns is a bad thing in my view as we neever test without them currently | 20:15 |
| edleafe | bauzas: if a compute node goes offline, where is that caught? Currently we don't have any way of removing its resource provider information in that event. | 20:15 |
| sdague | If you would like to get everything working with test-requirements not installed at all, I'm good with that | 20:15 |
| sdague | I don't want a switch there | 20:15 |
| sdague | because that is just, my 3rd party CI can just barely work based on the contents in different requirements files | 20:16 |
| sdague | and something else will change, and break you | 20:16 |
| sean-k-mooney | well devstack installs fine with the switch set to false and teh tempest squite works. im not sure about none tempets jobs though | 20:17 |
| sean-k-mooney | sdague: well neutron are build ovs from source for their fuctional and fullstak jobs currently. | 20:17 |
| sdague | sean-k-mooney: in some configuration you happen to have | 20:17 |
| sean-k-mooney | sdague: they dont deploy nova for those but it would have broke them if they did when flake8-import-order was introduced in nova | 20:18 |
| sdague | sean-k-mooney: sure, and there are 2 other options here. One is deal with the fact that flake8-import-order is really pretty suplerfuous | 20:18 |
| sdague | the other is get ovs-dpdk to run it's pep8 during build under isolation | 20:18 |
| sean-k-mooney | well that would require chaging upstream ovs makefile which we coudl explore but it would be up to them to accept that change | 20:19 |
| sdague | sean-k-mooney: or create and activate a venv before running it | 20:19 |
| sean-k-mooney | sdague: so activate venv and run make as part of our devstack plugin then deactivte | 20:20 |
| sdague | sean-k-mooney: sure, if that works for the isolation | 20:20 |
| sean-k-mooney | sdague: thats an option that i had not taught of. thats certenly possibel. | 20:21 |
| *** efried has joined #openstack-nova | 20:21 | |
| sdague | I also, honestly think that flake8-import-order being installed globally seems weird just in general due to fallout | 20:21 |
| efried | I just joined, so I don't have the scrollback, but +1 to that. | 20:21 |
| sean-k-mooney | sdague: yes but to me that is a direct resutl of the devstack behavor | 20:21 |
| sdague | and I would tend to pull that from global requirements, as I think that's going to have knock on break effects for lots of people that flake8 from the system (which is not an unreasonable thing to want to do) | 20:21 |
| *** mnestratov has joined #openstack-nova | 20:22 | |
| sean-k-mooney | sdague: generally test-requireemnt.txt are not expected to be installed systemwide or at least i never assume they will be | 20:22 |
| sdague | sean-k-mooney: I accept that if you make it so that we never install them | 20:22 |
| *** 07EAAIRVF has joined #openstack-nova | 20:23 | |
| sdague | I don't want to be in a weird middle ground where we have to explain to devs... "oh, well for that use case you have to set this to TRUE, but to get this other thing to work, it has to be FALSE" | 20:23 |
| sean-k-mooney | sdague: ill look into the vnev to wrap make, but would you be open to a patch to never install test requirement in devstack then without the conditional | 20:24 |
| sdague | sean-k-mooney: yep, if you can validate that it's going to work for people | 20:24 |
| sdague | git log -S TESTONLY | 20:26 |
| sdague | will give you some of the change history about when this was conditional | 20:26 |
| sean-k-mooney | well i can ask on the mailing list if people have objection to that change and we could try running the exsitng gate jobs for several projects with the proposed patch and see if they break? | 20:27 |
| *** adrian_otto has quit IRC | 20:27 | |
| sean-k-mooney | git log -S TESTONLY ? in what repo | 20:27 |
| sdague | sean-k-mooney: well, the issue is also for developer use case, not just the gate case | 20:27 |
| sdague | sean-k-mooney: devstack repo | 20:27 |
| sean-k-mooney | ah yes but again when im doing upstream dev i use devstack to set up my enviornment but i have always used the tox workflow so im not sure how many people expect them to be system wide | 20:28 |
| sean-k-mooney | but that is a vail point | 20:28 |
| sean-k-mooney | it has to work for both usecases | 20:29 |
| *** fragatin_ has joined #openstack-nova | 20:30 | |
| sean-k-mooney | sdague: any thanks for taking a look at this. ill feedback you suggestion to the rest of my team and we will see if the venv change works. if not we will procuse this as an addtional path. as for flake8-import-order are you going to propose a revert or let it stand for now | 20:33 |
| *** smatzek_ has quit IRC | 20:33 | |
| *** fragatina has quit IRC | 20:33 | |
| sean-k-mooney | *anyway | 20:33 |
| openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.resize_revert notification https://review.openstack.org/396811 | 20:34 |
| *** jamielennox|away is now known as jamielennox | 20:37 | |
| rfolco | cdent, around? | 20:39 |
| cdent | yeah rfolco, for a little while longer, what's up? | 20:39 |
| sdague | sean-k-mooney: I'll +2 a removal of it if you put it up | 20:39 |
| sdague | we can leave the import reordering, just pull the install of it | 20:39 |
| rfolco | cdent, quick question: how to make tox -epy27 run my new created lass under test_microversions.py? where am I noob'ing ? | 20:40 |
| sdague | sean-k-mooney: then look at removing it from global-requirements | 20:40 |
| edleafe | rfolco: what command are you running now? | 20:40 |
| cdent | rfolco: you mean running just one test? | 20:40 |
| rfolco | tox -epy27 test_microversion.TestMicroversionUtility | 20:40 |
| rfolco | its ignoring my class | 20:41 |
| sean-k-mooney | sdague: of flake8-import-order, ok i can do that tomorow, i am just wrapping up for the evening so ill add you to the review when its up. | 20:41 |
| sean-k-mooney | sdague: and ya i did not want to revert the whole patch as everything else looked good to me. | 20:41 |
| cdent | rfolco: if you do 'tox -epy27 test_microversion' does it get all the tests in the file? | 20:41 |
| rfolco | all them, except mine :) | 20:42 |
| edleafe | rfolco: did you save your changes? :) | 20:42 |
| cdent | rfolco: what's the name of your test method(s)/ in the class? | 20:42 |
| rfolco | class TestMicroversionUtility(test.NoDBTestCase): .... and def raise_405_out_of_date_version(self): | 20:43 |
| cdent | s/raise/test_raise/ | 20:43 |
| edleafe | rfolco: test names have to start with 'test_' | 20:43 |
| rfolco | oh boy | 20:43 |
| rfolco | cdent, edleafe: thats it. Thx | 20:44 |
| cdent | frustratring isn't it? | 20:44 |
| cdent | wow, it's a bad day for typing. it might be time for me to retire for the day | 20:44 |
| rfolco | cdent, silly mistake :-/ | 20:45 |
| edleafe | cdent: I'll be leaving early to catch this tonight: https://www.tobincenter.org/box-office/2017-03/purple-rain-live | 20:45 |
| cdent | \o/ | 20:46 |
| edleafe | Our daughter is in the philharmonic | 20:46 |
| cdent | that'll be fun | 20:46 |
| cdent | yeah, this cold is killing me, I'm calling it a day | 20:47 |
| * cdent waves | 20:47 | |
| *** cdent has quit IRC | 20:47 | |
| *** 07EAAIRVF has quit IRC | 20:52 | |
| openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.unrescue notifications https://review.openstack.org/388275 | 20:53 |
| mriedem | hmm, functional test in https://review.openstack.org/#/c/443395/ fails in ocata, methinks we need the context untarget thing... | 20:56 |
| *** catinthe_ has joined #openstack-nova | 20:56 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598 | 20:56 |
| *** Sukhdev has joined #openstack-nova | 20:57 | |
| mriedem | hmm, but the context should have a cell set on it in ocata | 20:57 |
| *** catintheroof has quit IRC | 20:58 | |
| *** edmondsw has quit IRC | 20:58 | |
| *** satyar has joined #openstack-nova | 20:59 | |
| *** gfhellma has quit IRC | 21:00 | |
| *** awaugama has quit IRC | 21:02 | |
| satyar | johnthetubaguy: tested the fix https://review.openstack.org/#/c/437222 for bug https://bugs.launchpad.net/nova/+bug/1668267 | 21:03 |
| openstack | Launchpad bug 1668267 in OpenStack Compute (nova) "Nova fails to correctly update the quota when deleting lots of VMs, some of which previously failed due to a quota error" [High,In progress] - Assigned to Pushkar Umaranikar (pushkar-umaranikar) | 21:03 |
| satyar | still able to reproduce the issue | 21:03 |
| dansmith | satyar: that's not the fix | 21:04 |
| dansmith | satyar: this is: https://review.openstack.org/#/c/443395/ | 21:04 |
| mriedem | well, | 21:04 |
| mriedem | on master it's that and https://review.openstack.org/#/c/443403/ | 21:04 |
| mriedem | on ocata it should just be https://review.openstack.org/#/c/443395/ and i'm working on the backport but hitting some issues | 21:05 |
| satyar | ohh ok will be testing it Thanks :) | 21:06 |
| *** aysyd has quit IRC | 21:06 | |
| satyar | thanks dansmith and mriedem | 21:06 |
| *** gouthamr has quit IRC | 21:06 | |
| mriedem | satyar: i've marked the other bug as a duplicate | 21:08 |
| satyar | to? | 21:09 |
| satyar | ok got it | 21:09 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1670627 | 21:09 |
| openstack | Launchpad bug 1670627 in OpenStack Compute (nova) ocata "quota is always in-use after delete the ERROR instances " [Critical,Confirmed] | 21:09 |
| *** youzp has joined #openstack-nova | 21:10 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add SameCellFilter https://review.openstack.org/445035 | 21:10 |
| *** youzp has quit IRC | 21:10 | |
| satyar | ideally it should be opposite that bug should be duplicate of the first one ;) but its fine | 21:11 |
| satyar | aslong as we fix the issue :) | 21:11 |
| mriedem | satyar: yeah, i guess triage failed us, it went under the one it did because someone showed up in the channel last wednesday and brought it up | 21:12 |
| mriedem | right place right time | 21:12 |
| satyar | :P | 21:12 |
| *** dimtruck is now known as zz_dimtruck | 21:13 | |
| *** tbachman has quit IRC | 21:15 | |
| *** penick has joined #openstack-nova | 21:21 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova-specs master: Live Migration of Rescued Instances https://review.openstack.org/347161 | 21:23 |
| openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in agents.py https://review.openstack.org/445208 | 21:28 |
| *** salv-orlando has joined #openstack-nova | 21:30 | |
| *** catintheroof has joined #openstack-nova | 21:31 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Reset instance status on invalid host https://review.openstack.org/401009 | 21:33 |
| *** Jeffrey4l has quit IRC | 21:35 | |
| *** satyar has quit IRC | 21:35 | |
| mriedem | wtf, in ocata, when the instance is in cell0 and i go to delete it, i get a 404, but when i do a GET i get a response | 21:35 |
| *** catinthe_ has quit IRC | 21:35 | |
| *** Jeffrey4l has joined #openstack-nova | 21:35 | |
| *** zz_dimtruck is now known as dimtruck | 21:35 | |
| *** smatzek_ has joined #openstack-nova | 21:43 | |
| *** felipemonteiro has quit IRC | 21:43 | |
| melwitt | mriedem: are you using novaclient to delete it or the REST API directly? because I feel like I have seen that before when I had bugs in my own code because of how novaclient does a GET before doing the delete. I can't remember the details off the top of my head | 21:43 |
| *** eharney has quit IRC | 21:44 | |
| mriedem | melwitt: rest api, this is that functional regression test for the quota patch | 21:46 |
| mriedem | https://review.openstack.org/#/c/443395/ but on ocata | 21:46 |
| mriedem | the functional regression test fails waiting for the server to be gone after the delete request, and it's because the delete request fails with a 404 when looking up the instance.flavor | 21:47 |
| melwitt | oh, hm | 21:47 |
| *** lpetrut has quit IRC | 21:47 | |
| mriedem | https://gist.github.com/mriedem/cece80e5ab375c2fad6d9d599851c2dc | 21:47 |
| mriedem | i think i know why, | 21:48 |
| mriedem | in master the context is targeted when you get the instance | 21:48 |
| mriedem | in ocata it's not, | 21:48 |
| mriedem | so in this change when it's looking up the flavor from the instance, the context isn't targeted to cell0 | 21:48 |
| mriedem | but we want the quotas in the main cell db, | 21:49 |
| mriedem | so i'm going to have to do the same helper method that i had on master for getting the flavor from a targeted context before creating the reservation | 21:49 |
| mriedem | ugh | 21:49 |
| openstackgerrit | Anusha Unnam proposed openstack/nova master: POC: add descriptions to server tags https://review.openstack.org/434842 | 21:50 |
| *** fragatin_ has quit IRC | 21:51 | |
| *** fragatina has joined #openstack-nova | 21:52 | |
| *** annegentle has quit IRC | 21:58 | |
| dansmith | mriedem: how do we not trip over that in tempest? | 21:58 |
| mriedem | dansmith: it's for this patch, | 21:58 |
| mriedem | as a result of this patch i mean | 21:58 |
| mriedem | i've got it sorted out, it's just kind of a mess for the backport, | 21:58 |
| mriedem | since it's a mix of the 2 changes on master | 21:58 |
| mriedem | you'll see shortly | 21:59 |
| dansmith | oh, I see I thought you meant the regression test doesn't run on ocata before the change | 21:59 |
| *** smatzek_ has quit IRC | 21:59 | |
| *** smatzek has joined #openstack-nova | 21:59 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Count resources to check quota for cells https://review.openstack.org/416521 | 22:00 |
| openstackgerrit | melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945 | 22:00 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | 22:00 |
| *** burt has quit IRC | 22:01 | |
| mriedem | i should have probably backported this first to see how it would work | 22:01 |
| *** baoli has quit IRC | 22:01 | |
| *** kaisers_ has quit IRC | 22:02 | |
| *** jamielennox is now known as jamielennox|away | 22:03 | |
| *** smatzek has quit IRC | 22:04 | |
| mriedem | looks like we have another ocata regression https://review.openstack.org/#/c/444106/ | 22:04 |
| *** jamielennox|away is now known as jamielennox | 22:07 | |
| *** xyang1 has quit IRC | 22:07 | |
| *** yonglihe has quit IRC | 22:09 | |
| dansmith | hmm, I thought we did that _on_ retry | 22:10 |
| *** priteau has quit IRC | 22:10 | |
| *** priteau has joined #openstack-nova | 22:10 | |
| dansmith | populate_filter_properties() creates the retry of the selected host | 22:11 |
| dansmith | which we are calling already | 22:12 |
| dansmith | oh | 22:12 |
| dansmith | only if populate_retry has done the initial work first I guess | 22:12 |
| dansmith | huh | 22:12 |
| *** catintheroof has quit IRC | 22:13 | |
| mriedem | gd how many postgres packages do i really need to install just to run pep8 | 22:14 |
| *** catintheroof has joined #openstack-nova | 22:14 | |
| *** catintheroof has quit IRC | 22:14 | |
| *** catintheroof has joined #openstack-nova | 22:15 | |
| mriedem | sudo apt-get install -y (*pg*|*pq*) | 22:15 |
| mriedem | install -y *everything* | 22:15 |
| *** priteau has quit IRC | 22:15 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add SameCellFilter https://review.openstack.org/445035 | 22:16 |
| *** mlavalle has quit IRC | 22:19 | |
| *** rfolco has quit IRC | 22:19 | |
| mriedem | we should have a functional regression test for that retry fix, | 22:20 |
| mriedem | should be relatively simple, run 2 nova-compute services, make the scheduler pick the first one and make that one fail to trigger a retry, and then make sure it's actually retried to the 2nd host | 22:21 |
| dansmith | is that enough? it might do that by itself by chance | 22:21 |
| openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in aggregates.py https://review.openstack.org/445230 | 22:22 |
| *** liangy has quit IRC | 22:23 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova master: POC: add descriptions to server tags https://review.openstack.org/434842 | 22:23 |
| openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in agents.py https://review.openstack.org/445208 | 22:23 |
| mriedem | dansmith: how? | 22:23 |
| mriedem | w/o digging into details i guess i don't know | 22:23 |
| mriedem | i'd also like to be able to force the scheduler to pick a host in the test that we've setup to fail | 22:24 |
| mriedem | i'm not entirely sure how to do that in functional tests w/o stubbing something out | 22:24 |
| dansmith | if you asked the scheduler to pick what would have been its second choice and it retries, it'd choose the other one without this fix | 22:24 |
| dansmith | right exactly | 22:24 |
| mriedem | yeah we have to make the test pick the hosts in the order we need for the recreate | 22:24 |
| mriedem | that's the tricky part, | 22:24 |
| mriedem | but doesn't seem too hard | 22:24 |
| dansmith | don't we shuffle the results? | 22:25 |
| mriedem | i'd think a weigher could be used | 22:25 |
| *** mdrabe_ is now known as mdrabe | 22:25 | |
| dansmith | yeah maybe | 22:25 |
| mriedem | that's scheduler black magic to me though | 22:25 |
| *** Svilen_ has joined #openstack-nova | 22:25 | |
| dansmith | https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L124-L124 | 22:26 |
| mriedem | i don't want to make a big deal out of it, but this is a complicated piece of code and we clearly don't have it covered sufficiently in tests | 22:26 |
| *** Svilen_ has left #openstack-nova | 22:26 | |
| dansmith | you'd have to set the subset size to 1 | 22:26 |
| melwitt | it defaults to 1, so no shuffle by default | 22:26 |
| dansmith | okay | 22:26 |
| mriedem | are either of you interested in writing that functional test? :) | 22:27 |
| dansmith | that seems like an unfortunate default for regular people | 22:27 |
| *** tbachman has joined #openstack-nova | 22:27 | |
| mriedem | it's only random if the weights are equal isn't it? | 22:27 |
| *** dimtruck is now known as zz_dimtruck | 22:27 | |
| dansmith | wait, | 22:28 |
| dansmith | oh, I see | 22:28 |
| dansmith | huh, I never knew this picked a single host by default | 22:28 |
| melwitt | mriedem: I can give it a go. I've written a weird retry test before https://github.com/openstack/nova/blob/master/nova/tests/functional/test_compute_mgr.py#L40 | 22:28 |
| *** gouthamr has joined #openstack-nova | 22:28 | |
| melwitt | I agree with you that we need coverage on this stuff | 22:28 |
| *** mdrabe has quit IRC | 22:29 | |
| melwitt | I think maybe the subset thing is only a problem if you get parallel requests often (tm) that all pick the same host and retry. we did so we increased it from 1 | 22:30 |
| dansmith | sure, but that's a common complaint | 22:31 |
| dansmith | that and running multiple schedulers choosing the same host | 22:31 |
| melwitt | yeah. I guess no one thought of changing the default | 22:32 |
| dansmith | I just can't think of a good reason to have the default be 1 | 22:32 |
| dansmith | if it's larger it doesn't hurt low-traffic clouds, but being =1 does hurt high traffic ones by default | 22:32 |
| mriedem | isn't this exactly what johnthetubaguy was saying this morning, why people don't use the filter scheduler with packing? | 22:32 |
| dansmith | mriedem: yes | 22:32 |
| mriedem | because we don't randomize anything | 22:32 |
| dansmith | mriedem: but remember I said "but we randomize the result" | 22:33 |
| melwitt | mriedem today mentioned a good point in a review somewhere I think (?) that it might be since people want to stack instances rather than spread them usually | 22:33 |
| dansmith | mriedem: and he said "right, but at a certain level it doesn't matter" | 22:33 |
| melwitt | well, I typed that way too slowly | 22:33 |
| mriedem | melwitt: yes because then you can't place large instances | 22:34 |
| dansmith | mriedem: for RAX-level, I can imagine it's not enough, but for medium sizes I would expect this works fine | 22:34 |
| melwitt | yeah. well with subset = 1, that means no randomization. are you saying there's a different randomize somewhere? | 22:34 |
| dansmith | mriedem: but we're not doing anyone favors by defaulting that to 1, IMHO | 22:34 |
| dansmith | melwitt: no, I'm saying even with that on, it's not enough to satisfy rax's need for parallelism | 22:35 |
| melwitt | oh | 22:35 |
| *** dave-mccowan has quit IRC | 22:36 | |
| *** esberglu has quit IRC | 22:36 | |
| *** baoli has joined #openstack-nova | 22:36 | |
| dansmith | if you set it to infinity it defeats all your weighting right? so there's probably some inflection point where it starts hurting you | 22:36 |
| melwitt | yeah, I'm not sure how that randomize plays with the weighing part | 22:37 |
| dansmith | I think we get back an ordered list from the weighers, | 22:38 |
| melwitt | unless it just shuffles the weighed order of N subset | 22:38 |
| dansmith | and that subset size randomizes the N best-weighed hosts | 22:38 |
| *** Swami has joined #openstack-nova | 22:38 | |
| melwitt | yeah | 22:38 |
| dansmith | so if you set it to N=$n_computes, you get no weighing | 22:38 |
| melwitt | right | 22:39 |
| dansmith | which I hear is bad and stuff | 22:39 |
| melwitt | hah | 22:39 |
| *** catintheroof has quit IRC | 22:40 | |
| *** baoli has quit IRC | 22:41 | |
| *** Swami has quit IRC | 22:43 | |
| melwitt | so I guess a good-ish reason to default to 1 is because the actual good default will vary so much from deployment to deployment | 22:44 |
| *** Swami has joined #openstack-nova | 22:44 | |
| *** bmace has joined #openstack-nova | 22:44 | |
| dansmith | I dunno, if people have less than say five candidate machines they're probably running a pretty damned small cloud | 22:44 |
| dansmith | shooting for the middle and tweaking up or down depending on your size seems reasonable, | 22:45 |
| dansmith | but yeah, someone will probably be confused with a two-node test cloud if it's !=1 | 22:45 |
| melwitt | yeah, so I was thinking if you have 10 compute nodes and your subset defaulted to 2, then you could run into problems trying to schedule large instances? | 22:45 |
| dansmith | just unfortunate | 22:45 |
| dansmith | no the weighed hosts are all candidates | 22:45 |
| dansmith | we could make that default to -1 and choose a subset that is like 5% of the node count or something | 22:46 |
| dansmith | but anyway.. | 22:46 |
| dansmith | I just wonder how many people don't realize | 22:46 |
| dansmith | might just be me | 22:46 |
| jroll | that bit our ironic install, fwiw, because the candidate order is always the same as well | 22:47 |
| melwitt | yeah, I was thinking if subset is 2 and you get a random choice of the two highest weights, then that will spread the instances slightly, no? | 22:47 |
| jroll | we had a QE bot building periodically, chewed through the disks on the first few boxes in that list pretty quick | 22:48 |
| melwitt | jroll: ah, that's an interesting point too | 22:49 |
| mriedem | dansmith: melwitt: so here is the quota usage fix backport for ocata, which is a mix of both fixes from pike; i've tried explaining that in the commit message: https://review.openstack.org/#/c/445236/ | 22:50 |
| mriedem | let me know if that's terrible | 22:50 |
| melwitt | mriedem: looks okay to me. commit message explanation is good | 22:54 |
| mriedem | ok. backporting the other change from pike wouldn't help either b/c the functional test on the 1st change still fails without the tweaks i had to make here | 22:57 |
| mriedem | so the only thing you could really do if backporting both changes is to squash them | 22:57 |
| *** smatzek has joined #openstack-nova | 22:58 | |
| dansmith | yeah, I guess if you want pack first, then anything but =1 spreads them | 23:00 |
| dansmith | like pack first above anything else | 23:00 |
| dansmith | which might've been john's point since I think they do care about pack first, and might be why the randomization doesn't help him | 23:01 |
| melwitt | ah, yeah | 23:04 |
| openstackgerrit | Sujitha proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228 | 23:05 |
| *** esberglu has joined #openstack-nova | 23:06 | |
| openstackgerrit | Sujitha proposed openstack/nova master: Change tags to default field in Instance object. https://review.openstack.org/415298 | 23:06 |
| *** iceyao has joined #openstack-nova | 23:06 | |
| openstackgerrit | Sujitha proposed openstack/nova master: Reduce calls to load_tags() to 0 https://review.openstack.org/435146 | 23:06 |
| openstackgerrit | Sujitha proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185 | 23:06 |
| *** smatzek has quit IRC | 23:09 | |
| *** iceyao has quit IRC | 23:10 | |
| *** esberglu has quit IRC | 23:10 | |
| *** hongbin has quit IRC | 23:15 | |
| *** efried has quit IRC | 23:15 | |
| openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in assisted_volume_snapshots.py https://review.openstack.org/445238 | 23:16 |
| *** tbachman has quit IRC | 23:16 | |
| *** lucasxu has quit IRC | 23:19 | |
| *** rfolco has joined #openstack-nova | 23:24 | |
| *** rfolco has quit IRC | 23:24 | |
| *** erlon has quit IRC | 23:25 | |
| *** tbachman has joined #openstack-nova | 23:25 | |
| *** mtanino has joined #openstack-nova | 23:26 | |
| gmann | mriedem: johnthetubaguy sdague alex_xu oomichi api-ref for server sort/filter keys - https://review.openstack.org/#/c/421760/ | 23:27 |
| *** claudiub has quit IRC | 23:39 | |
| *** takashin has joined #openstack-nova | 23:39 | |
| *** karimb has quit IRC | 23:42 | |
| *** tbachman has quit IRC | 23:47 | |
| *** tbachman has joined #openstack-nova | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!