| *** smatzek has joined #openstack-nova | 00:01 | |
| *** smatzek_ has joined #openstack-nova | 00:03 | |
| *** sacharya has joined #openstack-nova | 00:03 | |
| *** crushil has quit IRC | 00:04 | |
| *** salv-orl_ has quit IRC | 00:05 | |
| *** smatzek has quit IRC | 00:06 | |
| *** crushil has joined #openstack-nova | 00:07 | |
| *** sacharya has quit IRC | 00:07 | |
| *** jamesdenton has quit IRC | 00:08 | |
| *** alineb has joined #openstack-nova | 00:08 | |
| *** yingjun has joined #openstack-nova | 00:11 | |
| *** thorst_ has joined #openstack-nova | 00:19 | |
| *** smatzek_ has quit IRC | 00:25 | |
| *** adisky_ has quit IRC | 00:29 | |
| *** hongbin_ has quit IRC | 00:30 | |
| *** iceyao has joined #openstack-nova | 00:31 | |
| *** chyka has quit IRC | 00:32 | |
| *** guchihiro has joined #openstack-nova | 00:33 | |
| *** guchihiro has left #openstack-nova | 00:33 | |
| *** jamesdenton has joined #openstack-nova | 00:35 | |
| *** raunak has joined #openstack-nova | 00:37 | |
| *** zz_dimtruck is now known as dimtruck | 00:40 | |
| *** ducttape_ has joined #openstack-nova | 00:42 | |
| *** zhurong has joined #openstack-nova | 00:44 | |
| *** hoangcx has joined #openstack-nova | 00:49 | |
| *** jamesdenton has quit IRC | 00:51 | |
| *** tuanluong has joined #openstack-nova | 00:55 | |
| *** iceyao_ has joined #openstack-nova | 00:57 | |
| *** phuongnh has joined #openstack-nova | 01:01 | |
| *** iceyao has quit IRC | 01:01 | |
| *** kylek3h_away has joined #openstack-nova | 01:06 | |
| *** david-lyle has quit IRC | 01:06 | |
| *** thorst_ has quit IRC | 01:09 | |
| *** yingjun has quit IRC | 01:11 | |
| *** kevinz has joined #openstack-nova | 01:16 | |
| *** alexpilo_ has quit IRC | 01:16 | |
| *** sacharya has joined #openstack-nova | 01:19 | |
| *** sacharya has quit IRC | 01:24 | |
| *** aweeks has joined #openstack-nova | 01:24 | |
| *** alexpilotti has joined #openstack-nova | 01:27 | |
| *** Apoorva has quit IRC | 01:29 | |
| *** baoli has joined #openstack-nova | 01:31 | |
| *** alexpilotti has quit IRC | 01:31 | |
| *** jose-phillips has quit IRC | 01:31 | |
| *** alexpilotti has joined #openstack-nova | 01:34 | |
| *** alexpilotti has quit IRC | 01:38 | |
| *** mvensky has joined #openstack-nova | 01:38 | |
| *** ducttape_ has quit IRC | 01:39 | |
| *** raunak has quit IRC | 01:56 | |
| *** mvensky has quit IRC | 01:57 | |
| *** sdague_ has quit IRC | 01:57 | |
| *** sacharya has joined #openstack-nova | 01:59 | |
| *** owalsh is now known as owalsh-afk | 02:01 | |
| *** panda|bbl is now known as panda|zZ | 02:03 | |
| *** vsaienko has quit IRC | 02:03 | |
| *** jamesdenton has joined #openstack-nova | 02:05 | |
| *** tanee is now known as tanee_away | 02:07 | |
| *** tanee_away is now known as tanee | 02:07 | |
| *** diga has quit IRC | 02:10 | |
| *** gcb has joined #openstack-nova | 02:12 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova master: Enable more virt.xenapi tests on Python 3 https://review.openstack.org/414421 | 02:18 |
|---|---|---|
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova master: Skip unit tests for SSL + py3 https://review.openstack.org/426505 | 02:18 |
| *** mlavalle has quit IRC | 02:19 | |
| *** unicell1 has quit IRC | 02:19 | |
| *** hfu has joined #openstack-nova | 02:20 | |
| *** gongysh has joined #openstack-nova | 02:31 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: Fix live migrate with XenServer https://review.openstack.org/424428 | 02:32 |
| *** alexpilotti has joined #openstack-nova | 02:32 | |
| *** ducttape_ has joined #openstack-nova | 02:33 | |
| *** jamesdenton has quit IRC | 02:36 | |
| *** alexpilotti has quit IRC | 02:37 | |
| *** ducttape_ has quit IRC | 02:45 | |
| *** thorst_ has joined #openstack-nova | 02:48 | |
| *** thorst_ has quit IRC | 02:48 | |
| alex_xu | oomichi: yea, will check that after meeting | 02:51 |
| *** hongbin has joined #openstack-nova | 02:55 | |
| *** sdague has joined #openstack-nova | 02:55 | |
| *** sudipto_ has joined #openstack-nova | 02:55 | |
| *** sudipto has joined #openstack-nova | 02:55 | |
| *** burgerk has joined #openstack-nova | 03:00 | |
| *** ducttape_ has joined #openstack-nova | 03:02 | |
| *** thorst_ has joined #openstack-nova | 03:04 | |
| *** thorst_ has quit IRC | 03:04 | |
| *** david-lyle has joined #openstack-nova | 03:13 | |
| *** sdague has quit IRC | 03:13 | |
| *** diga has joined #openstack-nova | 03:18 | |
| *** yamahata has quit IRC | 03:22 | |
| *** burgerk has quit IRC | 03:22 | |
| *** gouthamr has quit IRC | 03:26 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova master: neutron: retrieve physical netwrok name from a multi-provider network https://review.openstack.org/430026 | 03:29 |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova master: Use min parameter to restrict live-migration config options https://review.openstack.org/323313 | 03:29 |
| *** alexpilotti has joined #openstack-nova | 03:32 | |
| *** nic has quit IRC | 03:34 | |
| *** owalsh has joined #openstack-nova | 03:35 | |
| *** owalsh-afk has quit IRC | 03:35 | |
| *** edmondsw has joined #openstack-nova | 03:37 | |
| *** alexpilotti has quit IRC | 03:37 | |
| *** ducttape_ has quit IRC | 03:37 | |
| *** links has joined #openstack-nova | 03:41 | |
| *** edmondsw has quit IRC | 03:41 | |
| *** yamahata has joined #openstack-nova | 03:42 | |
| *** ducttape_ has joined #openstack-nova | 03:47 | |
| *** sdague has joined #openstack-nova | 03:54 | |
| *** zhurong has quit IRC | 03:57 | |
| *** ijw has joined #openstack-nova | 03:58 | |
| *** thorst_ has joined #openstack-nova | 03:59 | |
| *** thorst_ has quit IRC | 04:00 | |
| *** nicolasbock has quit IRC | 04:01 | |
| *** ijw has quit IRC | 04:03 | |
| *** ducttape_ has quit IRC | 04:03 | |
| *** ducttape_ has joined #openstack-nova | 04:05 | |
| *** ducttape_ has quit IRC | 04:05 | |
| *** ducttape_ has joined #openstack-nova | 04:06 | |
| *** bkopilov_ has joined #openstack-nova | 04:12 | |
| *** bkopilov has joined #openstack-nova | 04:12 | |
| *** baoli has quit IRC | 04:13 | |
| *** dave-mccowan has quit IRC | 04:14 | |
| *** jose-phillips has joined #openstack-nova | 04:15 | |
| openstackgerrit | Emilien Macchi proposed openstack/nova master: DNM - test tripleo without nova api in WSGI/apache https://review.openstack.org/429008 | 04:15 |
| *** Nakato_ is now known as Nakato | 04:18 | |
| *** thorst_ has joined #openstack-nova | 04:19 | |
| *** thorst_ has quit IRC | 04:19 | |
| *** raunak has joined #openstack-nova | 04:19 | |
| *** armax has quit IRC | 04:21 | |
| *** nmathew has joined #openstack-nova | 04:24 | |
| *** jose-phillips has quit IRC | 04:25 | |
| *** mdnadeem has joined #openstack-nova | 04:25 | |
| *** hongbin has quit IRC | 04:26 | |
| *** ducttape_ has quit IRC | 04:30 | |
| *** takashin has joined #openstack-nova | 04:32 | |
| *** alexpilotti has joined #openstack-nova | 04:35 | |
| *** ducttape_ has joined #openstack-nova | 04:37 | |
| *** unicell has joined #openstack-nova | 04:38 | |
| *** crushil has quit IRC | 04:39 | |
| *** Daisy has joined #openstack-nova | 04:39 | |
| *** jose-phillips has joined #openstack-nova | 04:40 | |
| *** alexpilotti has quit IRC | 04:40 | |
| *** prateek has joined #openstack-nova | 04:41 | |
| *** prateek_ has joined #openstack-nova | 04:43 | |
| *** ducttape_ has quit IRC | 04:44 | |
| *** psachin has joined #openstack-nova | 04:49 | |
| *** dikonoor has joined #openstack-nova | 04:49 | |
| *** sudipto_ has quit IRC | 04:50 | |
| *** sudipto has quit IRC | 04:50 | |
| *** sree has joined #openstack-nova | 04:50 | |
| *** sudipto_ has joined #openstack-nova | 04:51 | |
| *** sudipto has joined #openstack-nova | 04:51 | |
| *** sudipto_ has quit IRC | 04:51 | |
| *** yingjun has joined #openstack-nova | 04:52 | |
| *** alexpilotti has joined #openstack-nova | 04:53 | |
| Kevin_Zheng | oomichi: could you check https://review.openstack.org/#/c/403568/ it is also high bug | 04:55 |
| *** alexpilotti has quit IRC | 04:58 | |
| *** ayogi has joined #openstack-nova | 04:59 | |
| *** ratailor has joined #openstack-nova | 05:01 | |
| *** pbandark has joined #openstack-nova | 05:02 | |
| *** yingjun has quit IRC | 05:03 | |
| *** bswartz has quit IRC | 05:08 | |
| *** Daisy has quit IRC | 05:08 | |
| *** Daisy has joined #openstack-nova | 05:08 | |
| *** Daviey has quit IRC | 05:11 | |
| *** sudipto has joined #openstack-nova | 05:12 | |
| *** sudipto_ has joined #openstack-nova | 05:12 | |
| *** Daisy has quit IRC | 05:13 | |
| *** prateek has quit IRC | 05:20 | |
| *** prateek_ has quit IRC | 05:20 | |
| *** prateek has joined #openstack-nova | 05:22 | |
| *** trinaths has joined #openstack-nova | 05:22 | |
| *** markvoelker_ has quit IRC | 05:28 | |
| *** markvoelker has joined #openstack-nova | 05:28 | |
| *** markvoelker has quit IRC | 05:33 | |
| *** Daisy has joined #openstack-nova | 05:36 | |
| *** yingjun has joined #openstack-nova | 05:38 | |
| *** salv-orlando has joined #openstack-nova | 05:39 | |
| *** david-lyle has quit IRC | 05:40 | |
| *** Daisy has quit IRC | 05:41 | |
| *** salv-orlando has quit IRC | 05:44 | |
| openstackgerrit | Li Yingjun proposed openstack/nova master: libvirt: Enable custom video vgamem setting https://review.openstack.org/411191 | 05:47 |
| *** sacharya has quit IRC | 05:48 | |
| *** links has quit IRC | 05:51 | |
| *** Daisy has joined #openstack-nova | 05:52 | |
| *** lpetrut has joined #openstack-nova | 05:54 | |
| *** liuyulong has quit IRC | 05:59 | |
| *** rcernin has joined #openstack-nova | 06:00 | |
| *** moshele has joined #openstack-nova | 06:00 | |
| *** moshele has quit IRC | 06:03 | |
| *** rcernin has quit IRC | 06:03 | |
| *** rcernin has joined #openstack-nova | 06:04 | |
| *** yingjun has quit IRC | 06:05 | |
| *** links has joined #openstack-nova | 06:07 | |
| *** satyar has joined #openstack-nova | 06:16 | |
| *** thorst_ has joined #openstack-nova | 06:20 | |
| *** links has quit IRC | 06:22 | |
| *** nkrinner_afk is now known as nkrinner | 06:22 | |
| *** jose-phillips has quit IRC | 06:23 | |
| *** zhurong has joined #openstack-nova | 06:23 | |
| *** thorst_ has quit IRC | 06:25 | |
| *** ekuris__ has joined #openstack-nova | 06:28 | |
| *** markvoelker has joined #openstack-nova | 06:28 | |
| *** markvoelker has quit IRC | 06:33 | |
| *** moshele has joined #openstack-nova | 06:34 | |
| *** Hosam has joined #openstack-nova | 06:35 | |
| *** links has joined #openstack-nova | 06:38 | |
| *** Daisy has quit IRC | 06:38 | |
| *** Daisy has joined #openstack-nova | 06:39 | |
| *** salv-orlando has joined #openstack-nova | 06:40 | |
| *** Hosam_ has joined #openstack-nova | 06:41 | |
| *** raunak has quit IRC | 06:42 | |
| *** Hosam has quit IRC | 06:43 | |
| *** salv-orlando has quit IRC | 06:44 | |
| *** Daisy_ has joined #openstack-nova | 06:45 | |
| *** lpetrut has quit IRC | 06:46 | |
| *** Daisy has quit IRC | 06:48 | |
| *** alexpilotti has joined #openstack-nova | 06:55 | |
| *** udesale has joined #openstack-nova | 06:55 | |
| *** avolkov has joined #openstack-nova | 06:56 | |
| *** tovin07_ has joined #openstack-nova | 06:57 | |
| openstackgerrit | MarkMielke proposed openstack/nova master: DiskFilter should only check if sufficient available storage exists, if storage has been requested. https://review.openstack.org/430091 | 06:57 |
| *** alexpilotti has quit IRC | 06:59 | |
| *** dimtruck is now known as zz_dimtruck | 07:06 | |
| *** links has quit IRC | 07:07 | |
| *** nkrinner is now known as nkrinner_afk | 07:08 | |
| *** unicell1 has joined #openstack-nova | 07:10 | |
| *** unicell has quit IRC | 07:10 | |
| *** salv-orlando has joined #openstack-nova | 07:11 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: WIP add FusionCompute driver https://review.openstack.org/430099 | 07:13 |
| *** panda|zZ is now known as panda|sick | 07:14 | |
| *** edmondsw has joined #openstack-nova | 07:15 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: WIP add FusionCompute driver https://review.openstack.org/430099 | 07:16 |
| *** edmondsw has quit IRC | 07:19 | |
| *** links has joined #openstack-nova | 07:19 | |
| *** sridharg has joined #openstack-nova | 07:21 | |
| *** kaisers has joined #openstack-nova | 07:27 | |
| *** markvoelker has joined #openstack-nova | 07:29 | |
| *** trinaths has quit IRC | 07:30 | |
| *** nkrinner_afk is now known as nkrinner | 07:30 | |
| *** links has quit IRC | 07:30 | |
| *** zhurong has quit IRC | 07:31 | |
| *** tesseract has joined #openstack-nova | 07:31 | |
| *** markvoelker has quit IRC | 07:35 | |
| *** zhurong has joined #openstack-nova | 07:35 | |
| *** Hosam_ has quit IRC | 07:38 | |
| *** Hosam has joined #openstack-nova | 07:38 | |
| *** slaweq has joined #openstack-nova | 07:40 | |
| *** Hosam has quit IRC | 07:40 | |
| *** Hosam has joined #openstack-nova | 07:40 | |
| *** andreas_s has joined #openstack-nova | 07:41 | |
| *** links has joined #openstack-nova | 07:42 | |
| *** pcaruana has joined #openstack-nova | 07:46 | |
| *** pcaruana has quit IRC | 07:48 | |
| *** salv-orl_ has joined #openstack-nova | 07:49 | |
| *** salv-orlando has quit IRC | 07:52 | |
| *** trinaths has joined #openstack-nova | 07:53 | |
| *** slaweq has quit IRC | 07:53 | |
| *** pcaruana has joined #openstack-nova | 07:55 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova-specs master: PCI NUMA Policies https://review.openstack.org/361140 | 07:59 |
| *** jamielennox is now known as jamielennox|away | 07:59 | |
| *** takashin has left #openstack-nova | 08:02 | |
| *** Cristina__ is now known as CristinaPauna | 08:02 | |
| *** alexpilotti has joined #openstack-nova | 08:04 | |
| *** jamielennox|away is now known as jamielennox | 08:06 | |
| *** alexpilotti has quit IRC | 08:09 | |
| *** salv-orlando has joined #openstack-nova | 08:15 | |
| *** salv-orl_ has quit IRC | 08:21 | |
| *** thorst_ has joined #openstack-nova | 08:21 | |
| *** thorst_ has quit IRC | 08:26 | |
| *** amoralej|off is now known as amoralej | 08:28 | |
| *** slaweq has joined #openstack-nova | 08:31 | |
| *** markvoelker has joined #openstack-nova | 08:32 | |
| *** lpetrut has joined #openstack-nova | 08:32 | |
| *** alexpilotti has joined #openstack-nova | 08:34 | |
| *** markvoelker has quit IRC | 08:38 | |
| *** alexpilotti has quit IRC | 08:38 | |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Request zero root disk for boot-from-volume instances https://review.openstack.org/428481 | 08:41 |
| openstackgerrit | melanie witt proposed openstack/nova master: Report zero root disk for boot-from-volume instances https://review.openstack.org/428505 | 08:41 |
| *** mjura has joined #openstack-nova | 08:44 | |
| gcb | sfinucan, https://review.openstack.org/#/c/414421/ is ready to merge now. | 08:53 |
| *** dgonzalez_ has joined #openstack-nova | 08:54 | |
| *** sapcc-bot1 has joined #openstack-nova | 08:54 | |
| *** databus23_1 has joined #openstack-nova | 08:54 | |
| *** carthaca_1 has joined #openstack-nova | 08:54 | |
| *** david_1 has joined #openstack-nova | 08:54 | |
| *** mkoderer_ has joined #openstack-nova | 08:54 | |
| *** databus23_ has quit IRC | 08:54 | |
| *** sapcc-bot has quit IRC | 08:54 | |
| *** carthaca_ has quit IRC | 08:54 | |
| *** dgonzalez_ has quit IRC | 08:56 | |
| *** mkoderer_ has quit IRC | 08:56 | |
| *** david_1 has quit IRC | 08:56 | |
| openstackgerrit | xianming.mao proposed openstack/nova-specs master: Add support for volume online-migrate when backend has RBD https://review.openstack.org/430131 | 08:58 |
| *** markus_z has joined #openstack-nova | 08:59 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-nova | 09:00 | |
| *** adisky_ has joined #openstack-nova | 09:03 | |
| *** salv-orlando has quit IRC | 09:04 | |
| *** salv-orlando has joined #openstack-nova | 09:07 | |
| *** kashyap` is now known as kashyap | 09:07 | |
| johnthetubaguy | gcb: do we thing those tests are OK now because mox has been removed? | 09:08 |
| gcb | johnthetubaguy, I don't look too much about mox issue | 09:09 |
| johnthetubaguy | gcb: how did we prove they don't still randomly fail? | 09:09 |
| gcb | johnthetubaguy, we discussed this before and get conclusion: enable one each in one week to make sure we can figure out failure reason. | 09:11 |
| gcb | johnthetubaguy, let me find out the discussion | 09:12 |
| *** Guest35321 has quit IRC | 09:12 | |
| johnthetubaguy | gcb: yeah, I think I remember that now. It would be good to add that context in the git commit message, so others all know why it was done | 09:12 |
| gcb | johnthetubaguy, will update it now | 09:13 |
| johnthetubaguy | gcb: seriously though, we disable them because mox3 was failing randomly, I would rather do the mox conversion before we enabled them | 09:13 |
| gcb | johnthetubaguy, what's the reason ? mox3 or usage of mox3 | 09:16 |
| *** yamahata has quit IRC | 09:17 | |
| johnthetubaguy | gcb: basically mox3 assertions seemed to fail randomly with py3, we never got to the root cause, but we decided to remove all mox from our tests to avoid hitting this issue: https://blueprints.launchpad.net/nova/+spec/remove-mox-pike | 09:18 |
| johnthetubaguy | gcb: I think sdague might remember the details more | 09:18 |
| openstackgerrit | xianming.mao proposed openstack/nova-specs master: Add support for volume online-migrate when backend has RBD https://review.openstack.org/430131 | 09:18 |
| johnthetubaguy | gcb: a tiny bit more context is here: https://blueprints.launchpad.net/nova/+spec/remove-mox | 09:18 |
| gcb | johnthetubaguy, thanks | 09:18 |
| *** Hosam has quit IRC | 09:19 | |
| *** aloga_ has joined #openstack-nova | 09:19 | |
| *** Daviey has joined #openstack-nova | 09:22 | |
| gcb | johnthetubaguy, make removing mox/mox3 as a community goal ? :) | 09:22 |
| johnthetubaguy | gcb: possibly, although all the slots are full for pike right now | 09:23 |
| johnthetubaguy | gcb: not sure how many projects actually use mox, that might be an interesting thing to check (it might just be Nova!) | 09:23 |
| gcb | johnthetubaguy, http://codesearch.openstack.org/?q=mox3&i=nope&files=&repos= Nova and horizon use a lot of them :) | 09:24 |
| johnthetubaguy | its probably an age thing | 09:25 |
| robcresswell | Mox makes us sad :( | 09:25 |
| robcresswell | (Horizon, that is) | 09:25 |
| johnthetubaguy | robcresswell: you are not alone in that | 09:26 |
| gcb | then we can retire mox3 from oslo side | 09:26 |
| johnthetubaguy | I never like the record/reply pattern | 09:26 |
| robcresswell | I've just dealt with far too many cryptic failures. Testing with mox should not be *that* much more difficult than writing your actual logic. | 09:27 |
| *** Daisy_ has quit IRC | 09:27 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Default live_migration_progress_timeout to off https://review.openstack.org/429798 | 09:27 |
| robcresswell | That said, its generally been "good enough" so we've never actually removed it. There's always been higher priority issues. | 09:27 |
| gcb | The third party mock module doesn't seem to be maintained anymore, suggest use unittest.mock on Python 3 | 09:27 |
| gcb | I try to use unittest.mock on Python 3 , there is an example https://review.openstack.org/#/c/429196/ | 09:28 |
| sfinucan | gcb: We do that anyway on Python3, no? | 09:28 |
| sfinucan | ...and fall back to mock from pip for Python2.7 | 09:28 |
| sfinucan | (seeing as Python2.7 doesn't have it) | 09:29 |
| *** lucas-afk is now known as lucasagomes | 09:29 | |
| *** gongysh has quit IRC | 09:29 | |
| gcb | mock works well for python 2.7, just use unittest.mock on Python 3 | 09:29 |
| *** gongysh has joined #openstack-nova | 09:29 | |
| *** jose-phillips has joined #openstack-nova | 09:29 | |
| johnthetubaguy | gcb: I thought thats what we did, but not 100% sure | 09:29 |
| *** gongysh has quit IRC | 09:30 | |
| johnthetubaguy | gcb: it might be that mock got ahead of the py3 lib at one point, but I don't 100% remember now | 09:30 |
| gcb | oslotest add this for six in https://github.com/openstack/oslotest/blob/master/oslotest/__init__.py | 09:31 |
| *** liuyulong has joined #openstack-nova | 09:31 | |
| johnthetubaguy | gcb: ah, so we don't use the standard one, I see now | 09:31 |
| johnthetubaguy | gcb: yeah, thats worth doing then | 09:31 |
| gcb | johnthetubaguy, yeah | 09:31 |
| sfinucan | ah, they're different imports. oops | 09:32 |
| sfinucan | Yeah, definitely worth doing | 09:32 |
| sfinucan | though lower than mox->mock :) | 09:32 |
| johnthetubaguy | gcb: FWIW, its when mock looked like it was getting into python we totally stopped allowing more mox tests | 09:32 |
| johnthetubaguy | sfinucan | 09:32 |
| sfinucan | johnthetubaguy: We're ok to go merge stuff again, right? | 09:32 |
| johnthetubaguy | sfinucan: that was news to me too | 09:33 |
| sfinucan | i.e. trivial mox->mock stuff | 09:33 |
| johnthetubaguy | sfinucan: ish, so the limitation is we don't want to make backports too hard, for the next week or so | 09:33 |
| sfinucan | ah, I'll hold off on those so | 09:33 |
| *** derekh has joined #openstack-nova | 09:33 | |
| sfinucan | lest anyone want to backport tests too | 09:33 |
| *** litao has quit IRC | 09:34 | |
| *** markvoelker has joined #openstack-nova | 09:34 | |
| *** litao has joined #openstack-nova | 09:35 | |
| johnthetubaguy | sfinucan: yeah, its worth waiting a week I think | 09:36 |
| gcb | let me add one item on https://etherpad.openstack.org/p/community-goals later, then we can start to move and set the the target in following cycle | 09:36 |
| *** mnasiadka has joined #openstack-nova | 09:36 | |
| *** yassine has joined #openstack-nova | 09:37 | |
| johnthetubaguy | gcb: it feels like part of the prep for py3, so its probably a good stepping stone I guess | 09:37 |
| *** yassine is now known as Guest58689 | 09:37 | |
| johnthetubaguy | gcb: although I honestly think it would be quicker to get the functional tests passing on py3, before we get all the unit tests passing on py3 | 09:37 |
| johnthetubaguy | for Nova that is | 09:37 |
| *** mariusv has quit IRC | 09:38 | |
| *** mariusv has joined #openstack-nova | 09:39 | |
| *** mariusv has quit IRC | 09:39 | |
| *** mariusv has joined #openstack-nova | 09:39 | |
| gcb | johnthetubaguy, I added gate-nova-tox-db-functional-py35-ubuntu-xenial as non-voting, maybe we can make it votable | 09:40 |
| johnthetubaguy | gcb: I think that would be a good thing to try | 09:40 |
| *** markvoelker has quit IRC | 09:40 | |
| johnthetubaguy | gcb: you can always to a tempest skip list, like we have for cellsv1: https://github.com/openstack/nova/blob/master/devstack/tempest-dsvm-cells-rc | 09:41 |
| johnthetubaguy | i.e. get a job that passes creating at least one instance, then slowly enable more goodness as the fixes go in | 09:41 |
| gcb | I will be back after dinner :) | 09:42 |
| *** zhurong has quit IRC | 09:44 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: WIP: Spec idea on the future of quotas for Nova https://review.openstack.org/429678 | 09:44 |
| *** jose-phillips has quit IRC | 09:46 | |
| *** Dave___ is now known as Dave | 09:52 | |
| *** tovin07_ has quit IRC | 09:55 | |
| *** tovin07 has quit IRC | 09:56 | |
| *** CristinaPauna has quit IRC | 09:57 | |
| *** jschwarz has quit IRC | 10:01 | |
| *** jschwarz has joined #openstack-nova | 10:01 | |
| *** iceyao_ has quit IRC | 10:04 | |
| lyarwood | mdbooth: https://review.openstack.org/#/c/427364/ - I added the comments you requested btw, any chance of a quick review if you have time this morning? | 10:05 |
| mdbooth | lyarwood: Got my head in something right now. Is there a chance of follow-on core review? | 10:05 |
| mdbooth | (iow: will my review achieve anything this morning) | 10:06 |
| *** CristinaPauna has joined #openstack-nova | 10:06 | |
| lyarwood | mdbooth: ah, np, I was going to ask around now that we are past RC but don't go out of your way if you're in the middle of something | 10:07 |
| *** carthaca_1 has quit IRC | 10:07 | |
| *** sapcc-bot1 has quit IRC | 10:07 | |
| *** databus23_1 has quit IRC | 10:07 | |
| *** sapcc-bot has joined #openstack-nova | 10:07 | |
| *** databus23_ has joined #openstack-nova | 10:07 | |
| *** carthaca_ has joined #openstack-nova | 10:07 | |
| *** mkoderer_ has joined #openstack-nova | 10:07 | |
| *** david_1 has joined #openstack-nova | 10:07 | |
| *** dgonzalez_ has joined #openstack-nova | 10:07 | |
| *** hoangcx has quit IRC | 10:08 | |
| *** mkoderer_ has quit IRC | 10:09 | |
| *** david_1 has quit IRC | 10:09 | |
| *** dgonzalez_ has quit IRC | 10:09 | |
| *** mariusv has quit IRC | 10:10 | |
| *** kevinz has quit IRC | 10:17 | |
| *** salv-orl_ has joined #openstack-nova | 10:19 | |
| mdbooth | Should we be logging authentication tokens? | 10:19 |
| mdbooth | e.g.: | 10:19 |
| mdbooth | 2017-02-06 16:37:53.021 [n-api.log] 29609 DEBUG cinderclient.v2.client [req-f47e58e1-65a9-44b3-b9ea-90959d0255ab tempest-TestVolumeSwap-787392718 tempest-TestVolumeSwap-787392718] REQ: curl -g -i -X GET http://10.24.164.111:8776/v2/72077d0aec734621ad21d12d3ffbc0e9/volumes/b4c90b8c-fac7-4bfd-b4be-a641ac137a1c -H "X-Service-Token: {SHA1}161c3fe7af35615c3f7a8136153d893316c4afa5" -H "User-Agent: python-cinderclient" -H "Accept: | 10:20 |
| mdbooth | application/json" -H "X-Auth-Token: {SHA1}dfc5e07945c13b29514dd78d29b374cf2e5d3a1f" _http_log_request /usr/local/lib/python2.7/dist-packages/keystoneauth1/session.py:347 | 10:20 |
| mdbooth | What's the lifetime of one of those tokens? | 10:20 |
| markus_z | bauzas: Do you have a minute? | 10:20 |
| markus_z | bauzas: It's about https://review.openstack.org/#/c/420079/1 | 10:21 |
| bauzas | markus_z: sure, but I'm a bit off this week | 10:21 |
| rpodolyaka | mdbooth: we specifically store a hash of a token, so that it (i.e. a valid token) does not show up in logs, don? | 10:21 |
| rpodolyaka | * don't we | 10:21 |
| *** salv-orlando has quit IRC | 10:21 | |
| bauzas | markus_z: mmm, I should abandon this change | 10:21 |
| mdbooth | rpodolyaka: Well the above it a cut/paste from my logs | 10:21 |
| rpodolyaka | but you still can track usage of a particular token in logs | 10:21 |
| rpodolyaka | but it's a hash | 10:21 |
| rpodolyaka | not a token itself | 10:22 |
| rpodolyaka | or I am missing something obvious? :) | 10:22 |
| markus_z | bauzas: I was wondering about the alternatives to this change. | 10:22 |
| mdbooth | rpodolyaka: I'm wondering the same thing :) | 10:22 |
| *** thorst_ has joined #openstack-nova | 10:22 | |
| mdbooth | If it's the thing we send to cinder, does it matter if it's a hash or not? | 10:22 |
| mdbooth | Does it, eg, include a nonce component so it changes every time? | 10:22 |
| markus_z | bauzas: Our s390 CI is broken because of "No hosts found to map to cell, exiting." and I don't find a solution for that. | 10:22 |
| rpodolyaka | mdbooth: it's not what goes over the wire | 10:22 |
| rpodolyaka | it's just the way it's shown in logs | 10:23 |
| rpodolyaka | i.e. a sha1 hash | 10:23 |
| mdbooth | rpodolyaka: Ah... so that's logging an sha1 of what went over the wire? | 10:23 |
| bauzas | markus_z: see the bug https://bugs.launchpad.net/nova/+bug/1656276 | 10:23 |
| openstack | Launchpad bug 1656276 in OpenStack Compute (nova) "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Undecided,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | 10:23 |
| rpodolyaka | mdbooth: yep | 10:23 |
| bauzas | markus_z: that's the consensus now https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=dc2f3a358663c0fb97795666b16dec63cfcc3872 | 10:24 |
| mdbooth | Are you sure about that? Seems kinda weird we wouldn't just elide it. | 10:24 |
| mdbooth | In other places we replace passwords with *** | 10:24 |
| rpodolyaka | mdbooth: strace of `nova list` http://paste.openstack.org/raw/597914/ | 10:25 |
| rpodolyaka | well, the relevant part of it :) | 10:25 |
| mdbooth | rpodolyaka: Cool, that doesn't look like an sha1 :) | 10:25 |
| mdbooth | rpodolyaka: Thanks | 10:25 |
| rpodolyaka | np! | 10:25 |
| *** Daisy has joined #openstack-nova | 10:26 | |
| *** thorst_ has quit IRC | 10:26 | |
| bauzas | markus_z: also http://docs.openstack.org/developer/nova/cells.html#first-time-setup now differs from http://docs.openstack.org/developer/nova/cells.html#upgrade-minimal | 10:27 |
| markus_z | bauzas: We see that issue when we setup devstack (with devstack-gate). I'm not sure how that change applies to that situation. | 10:27 |
| *** satyar has quit IRC | 10:28 | |
| openstackgerrit | Bob Ball proposed openstack/nova master: XenAPI: fix memory usage miscalculation https://review.openstack.org/394857 | 10:28 |
| bauzas | markus_z: tbc, unless you're upgrading a newton cloud, you now need to stop using single_cell_setup and rather use map_cell0, then discover_hosts() | 10:28 |
| *** Daisy has quit IRC | 10:30 | |
| *** udesale has quit IRC | 10:31 | |
| markus_z | bauzas: Do I need to configure that in Devstacks local.conf? As said, it's for our CI. | 10:31 |
| *** udesale has joined #openstack-nova | 10:31 | |
| bauzas | markus_z: what do you mean by local.conf ? | 10:34 |
| bauzas | markus_z: you don't really need to modify your workflow | 10:35 |
| bauzas | if you're using devstack, it starts n-cpu because running simple_cell_setup AFAIK | 10:35 |
| bauzas | which is then all good | 10:35 |
| bauzas | the problem here is when you start n-cpu after running simple_cell_setup | 10:35 |
| bauzas | then that call considers finding no hosts is an error | 10:36 |
| *** markvoelker has joined #openstack-nova | 10:37 | |
| markus_z | bauzas: To make sure I understand it: This call is the correct one https://github.com/openstack-dev/devstack/blob/bd14f7f23e01968aba70f0025b85dc15f110abc1/lib/nova#L952 | 10:38 |
| markus_z | ? | 10:38 |
| *** sulo_ is now known as sulo | 10:39 | |
| markus_z | And then nova-manage "discover_hosts" is called? https://github.com/openstack/nova/blob/9eb7bcea05ce2447496f6561caa1ae46b800f85d/nova/cmd/manage.py#L1379-L1379 | 10:40 |
| bauzas | discover_hosts is when you add a compute *after* doing the cellsv2 setup | 10:41 |
| bauzas | markus_z: ^ | 10:41 |
| bauzas | for the moment, there is no auto-registration of hosts in the cellsv2 world, but we need their mappings to order to place instances onto them | 10:42 |
| *** markvoelker has quit IRC | 10:43 | |
| *** sambetts_ is now known as sambetts | 10:43 | |
| markus_z | bauzas: I still don't get it :/ At the end of January there has to be a change which introduced something in that area which our CI isn't prepared to deal with. | 10:44 |
| markus_z | bauzas: Do I understand it correctly that "n-cpu" has to run *before* simple_cell_setup is called? | 10:46 |
| bauzas | markus_z: leave me 10 mins and we could hangout if you wish, okay | 10:47 |
| bauzas | ? | 10:47 |
| markus_z | bauzas: Let me dig more into the issue on my side before I'm consuming you time, but thanks a lot for the offer. | 10:49 |
| *** cdent has joined #openstack-nova | 10:51 | |
| *** Guest58689 has quit IRC | 10:51 | |
| *** jkraj has joined #openstack-nova | 10:51 | |
| *** nmathew has quit IRC | 10:51 | |
| *** Guest58689 has joined #openstack-nova | 10:55 | |
| johnthetubaguy | markus_z: did you see the new docs that just merged by the way | 10:56 |
| johnthetubaguy | markus_z: they explain things a lot better | 10:56 |
| johnthetubaguy | markus_z: the thing that confused me is that "db sync" created cell0, only after you first did the create_cell0 thing, it could be a different thing you hit | 10:57 |
| mdbooth | lyarwood: Hey, so detach_volume races with delete() | 10:57 |
| tdurakov | johnthetubaguy: hi, which docs? | 10:57 |
| mdbooth | i.e. if you detach_volume(), delete() really quickly, the delete will do the detach which is already in progress | 10:58 |
| johnthetubaguy | tdurakov: https://github.com/openstack/nova/commit/da591bc543c84fb601e5d832ba6a28e38c036901 | 10:58 |
| mdbooth | lyarwood: Can you think of any bad things this might cause on the cinder side? | 10:58 |
| tdurakov | previous time I've deployed multinode devstack, I need to run nova-manage cell_v2 simple_cell_setup after second compute is deployed | 10:58 |
| mdbooth | johnthetubaguy: Same question ^^^^ ? | 10:58 |
| tdurakov | today I've deployed new one, and it doesn't recognise second compute is added | 10:59 |
| tdurakov | thanks for the link! | 10:59 |
| lyarwood | mdbooth: about to jump on a call | 10:59 |
| johnthetubaguy | tdurakov: markus_z: there is an ordering issue I suspect. You need to have started n-cpu to be able to discover it | 10:59 |
| mdbooth | lyarwood: k | 10:59 |
| lyarwood | mdbooth: I can't think of anything bad on the cinder cide | 10:59 |
| lyarwood | mdbooth: but that is going to screw up host state and leave things hanging around with iSCSI/FC etc | 10:59 |
| lyarwood | mdbooth: ah no wait we have locks around disconnect_volume | 11:00 |
| mdbooth | Well it's going do to do 2 detaches | 11:00 |
| tdurakov | johnthetubaguy: hm... I'm not sure how this should work | 11:00 |
| mdbooth | So it's that going to extra cleanup? | 11:00 |
| johnthetubaguy | mdbooth: lyarwood: unsure on cinder, I suspect its OK | 11:00 |
| tdurakov | local.conf on compute only node already has endpoints of controller node | 11:00 |
| lyarwood | mdbooth: double terminate_connection calls should be fine as long as something has disconnected the volume from the host | 11:00 |
| tdurakov | so how I should reorder them properly | 11:01 |
| *** pbandark has quit IRC | 11:01 | |
| johnthetubaguy | tdurakov: like I say, the docs do try cover that now, including the nova-manage man pages: https://github.com/openstack/nova/blob/5dad7eaef7f8562425cce6b233aed610ca2d3148/doc/source/man/nova-manage.rst | 11:01 |
| mdbooth | lyarwood: Thanks | 11:01 |
| johnthetubaguy | tdurakov: I would talk you through it, but I would like to test the docs :) | 11:01 |
| *** nicolasbock has joined #openstack-nova | 11:01 | |
| tdurakov | johnthetubaguy: that's ok | 11:01 |
| tdurakov | thank you | 11:01 |
| *** pbandark has joined #openstack-nova | 11:01 | |
| johnthetubaguy | tdurakov: now worries, this is the rendered docs: http://docs.openstack.org/developer/nova/cells.html#step-by-step-for-common-use-cases | 11:02 |
| johnthetubaguy | markus_z: http://docs.openstack.org/developer/nova/cells.html#step-by-step-for-common-use-cases and https://github.com/openstack/nova/blob/5dad7eaef7f8562425cce6b233aed610ca2d3148/doc/source/man/nova-manage.rst should be your friend | 11:02 |
| mdbooth | Ah... attach/delete would be worse, which is probably why that takes an instance lock | 11:03 |
| * mdbooth suspects detach should also take the instance lock, but it's 'probably' ok | 11:04 | |
| * mdbooth adds a patch | 11:04 | |
| johnthetubaguy | mdbooth: I am wondering about the end API state vs what we have on the host, its not clear what we end up with | 11:04 |
| *** sudipto has quit IRC | 11:05 | |
| *** sudipto_ has quit IRC | 11:05 | |
| *** rfolco has joined #openstack-nova | 11:06 | |
| *** phuongnh has quit IRC | 11:12 | |
| *** Hosam has joined #openstack-nova | 11:15 | |
| *** owalsh_ has joined #openstack-nova | 11:18 | |
| *** owalsh has quit IRC | 11:18 | |
| *** sree has quit IRC | 11:18 | |
| *** sree has joined #openstack-nova | 11:19 | |
| *** ducttape_ has joined #openstack-nova | 11:20 | |
| *** sree has quit IRC | 11:23 | |
| *** ducttape_ has quit IRC | 11:24 | |
| *** gszasz has joined #openstack-nova | 11:25 | |
| *** liusheng has quit IRC | 11:26 | |
| *** Hosam_ has joined #openstack-nova | 11:26 | |
| *** vi01et03 has joined #openstack-nova | 11:26 | |
| *** liusheng has joined #openstack-nova | 11:26 | |
| *** diga has quit IRC | 11:27 | |
| *** mvk has quit IRC | 11:27 | |
| *** pbandark has quit IRC | 11:27 | |
| *** Hosam has quit IRC | 11:28 | |
| *** edmondsw has joined #openstack-nova | 11:33 | |
| *** edmondsw has quit IRC | 11:37 | |
| *** markvoelker has joined #openstack-nova | 11:39 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix various races with detach_volume https://review.openstack.org/430213 | 11:42 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova master: TrivialFix: replace list comprehension with 'for' https://review.openstack.org/430214 | 11:42 |
| *** owalsh_ is now known as owalsh | 11:43 | |
| *** markvoelker has quit IRC | 11:46 | |
| *** salv-orl_ has quit IRC | 11:47 | |
| *** salv-orlando has joined #openstack-nova | 11:48 | |
| markus_z | johnthetubaguy: thanks, I haven't yet read the new docs, I'll do that today. | 11:51 |
| *** tbachman has quit IRC | 11:52 | |
| johnthetubaguy | markus_z: no worries, hopefully it should help | 11:52 |
| johnthetubaguy | markus_z: if not we should fix the docs :) | 11:52 |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Remove stuck live-migration detection https://review.openstack.org/430218 | 11:58 |
| *** jschwarz has quit IRC | 12:00 | |
| johnthetubaguy | pkoniszewski: kick started the discussion around that bug in the above patch^ | 12:00 |
| mdbooth | johnthetubaguy: Haven't looked at what it does yet, but +87, -163 looks good :) | 12:01 |
| johnthetubaguy | mdbooth: heh :) | 12:01 |
| *** brault is now known as brault|away | 12:06 | |
| *** mvk has joined #openstack-nova | 12:07 | |
| *** tuanluong has quit IRC | 12:07 | |
| *** mnestratov has joined #openstack-nova | 12:08 | |
| *** smatzek_ has joined #openstack-nova | 12:08 | |
| *** purplerbot has quit IRC | 12:15 | |
| *** purplerbot has joined #openstack-nova | 12:15 | |
| *** lucasagomes is now known as lucas-hungry | 12:18 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Remove stuck live-migration detection https://review.openstack.org/430218 | 12:26 |
| *** bkopilov_ has quit IRC | 12:28 | |
| *** bkopilov has quit IRC | 12:28 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Remove stuck live-migration detection https://review.openstack.org/430218 | 12:28 |
| *** mnestratov|2 has joined #openstack-nova | 12:29 | |
| *** cdent has quit IRC | 12:30 | |
| *** mnestratov has quit IRC | 12:32 | |
| *** sdague_ has joined #openstack-nova | 12:32 | |
| *** mnestratov has joined #openstack-nova | 12:34 | |
| *** gcb has quit IRC | 12:36 | |
| *** mnestratov|2 has quit IRC | 12:37 | |
| *** mnestratov has quit IRC | 12:37 | |
| *** mnestratov has joined #openstack-nova | 12:37 | |
| *** gcb has joined #openstack-nova | 12:37 | |
| *** vi01et03 has quit IRC | 12:39 | |
| *** bvanhav__ has joined #openstack-nova | 12:39 | |
| *** kevinz has joined #openstack-nova | 12:39 | |
| *** thorst_ has joined #openstack-nova | 12:39 | |
| *** ratailor has quit IRC | 12:40 | |
| BobBall_AWOL | johnthetubaguy: Could you re-approve https://review.openstack.org/#/c/424428/ pls? :) | 12:40 |
| *** BobBall_AWOL is now known as BobBall | 12:40 | |
| *** markvoelker has joined #openstack-nova | 12:41 | |
| *** sandanar has joined #openstack-nova | 12:43 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova master: neutron: retrieve physical netwrok name from a multi-provider network https://review.openstack.org/430026 | 12:43 |
| *** vsaienko has joined #openstack-nova | 12:43 | |
| mdbooth | vladikr: nit: you have a typo in the title | 12:44 |
| *** gcb has quit IRC | 12:45 | |
| *** trinaths has quit IRC | 12:45 | |
| *** kevinz has quit IRC | 12:46 | |
| vladikr | mdbooth, ah, thanks! :) | 12:46 |
| mdbooth | ;) | 12:47 |
| *** kevinz has joined #openstack-nova | 12:47 | |
| *** markvoelker has quit IRC | 12:48 | |
| *** links has quit IRC | 12:48 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova master: neutron: retrieve physical network name from a multi-provider network https://review.openstack.org/430026 | 12:48 |
| *** mnasiadka has quit IRC | 12:49 | |
| *** aloga_ has quit IRC | 12:49 | |
| *** catintheroof has joined #openstack-nova | 12:50 | |
| *** ducttape_ has joined #openstack-nova | 12:51 | |
| *** sdague has quit IRC | 12:52 | |
| *** gcb has joined #openstack-nova | 12:53 | |
| gcb | sfinucan, can you remove your -2 now ? https://review.openstack.org/#/c/323313/ | 12:53 |
| *** ducttape_ has quit IRC | 12:55 | |
| *** dave-mccowan has joined #openstack-nova | 12:55 | |
| *** kevinz has quit IRC | 12:56 | |
| *** prateek has quit IRC | 12:57 | |
| *** kevinz has joined #openstack-nova | 12:57 | |
| sfinucan | gcb: Sure | 13:02 |
| sfinucan | gcb: Actually, per johnthetubaguy's comments, perhaps we should wait until next week to merge that? | 13:03 |
| gcb | sfinucan, agree | 13:03 |
| sfinucan | gcb: So the reason changes but the -2 remains until then :) | 13:04 |
| gcb | sfinucan, okay | 13:04 |
| gcb | :) | 13:04 |
| sfinucan | but ping me next week and I'll re-review | 13:05 |
| *** ducttape_ has joined #openstack-nova | 13:08 | |
| *** gcb has quit IRC | 13:09 | |
| *** tblakes has joined #openstack-nova | 13:09 | |
| *** salv-orlando has quit IRC | 13:09 | |
| *** liverpooler has quit IRC | 13:10 | |
| *** liverpooler has joined #openstack-nova | 13:10 | |
| *** sudipto has joined #openstack-nova | 13:12 | |
| *** sudipto_ has joined #openstack-nova | 13:12 | |
| *** sree has joined #openstack-nova | 13:14 | |
| *** lucas-hungry is now known as lucasagomes | 13:20 | |
| *** jheroux has joined #openstack-nova | 13:21 | |
| *** tbachman has joined #openstack-nova | 13:21 | |
| *** edmondsw has joined #openstack-nova | 13:23 | |
| *** ralonsoh has joined #openstack-nova | 13:23 | |
| *** s1rp has left #openstack-nova | 13:24 | |
| *** karimb has joined #openstack-nova | 13:25 | |
| *** mptacekx has joined #openstack-nova | 13:26 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Initiate network changes from source during live migration https://review.openstack.org/404607 | 13:28 |
| *** jpena is now known as jpena|lunch | 13:31 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix various races with detach_volume https://review.openstack.org/430213 | 13:35 |
| pumaranikar | johnthetubaguy, cdent can you please check https://review.openstack.org/#/c/395194/ . Placement json formatter change | 13:36 |
| *** hoangcx has joined #openstack-nova | 13:36 | |
| mdbooth | lyarwood: A festival of obscure syntax: https://github.com/mdbooth/openstack-dev-hacks/commit/1e13942134c298dd27af674fdcaf7a5ac72b1e82 :) | 13:39 |
| johnthetubaguy | pumaranikar: whats the plan for all the other handlers? | 13:39 |
| mdbooth | To top it off, here's how I just called it: ci_log_fetch http://logs.openstack.org/09/395709/6/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/f829785/logs/ {c-{api,vol},n-{api,cond,cpu}} | 13:40 |
| pumaranikar | johnthetubaguy, will be addressing in follow up patches | 13:40 |
| *** cdelatte has joined #openstack-nova | 13:43 | |
| johnthetubaguy | pumaranikar: that LOG.error in your handler, did the original bug want that added? | 13:43 |
| tdurakov | pkoniszewski: hi, are you around? | 13:43 |
| *** markvoelker has joined #openstack-nova | 13:44 | |
| pumaranikar | johnthetubaguy, it was not a requirement to add logging here | 13:44 |
| *** sree_ has joined #openstack-nova | 13:44 | |
| *** amotoki has joined #openstack-nova | 13:44 | |
| *** Hosam_ has quit IRC | 13:44 | |
| *** ducttape_ has quit IRC | 13:44 | |
| *** egarbade- has quit IRC | 13:44 | |
| *** sree_ is now known as Guest60723 | 13:45 | |
| *** ekhugen has quit IRC | 13:45 | |
| johnthetubaguy | pumaranikar: have you seen this, its worth a read: https://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html | 13:45 |
| *** sree has quit IRC | 13:45 | |
| *** ekhugen has joined #openstack-nova | 13:47 | |
| pkoniszewski | tdurakov: yes | 13:47 |
| *** mtanino has quit IRC | 13:47 | |
| *** zz_dimtruck is now known as dimtruck | 13:47 | |
| *** egarbade- has joined #openstack-nova | 13:47 | |
| *** baoli has joined #openstack-nova | 13:48 | |
| lyarwood | mdbooth: nice! | 13:48 |
| tdurakov | pkoniszewski: there are some intersections in my schedule today, could you chair l-m meeting? | 13:48 |
| pkoniszewski | i'm afraid i need to skip the meeting today | 13:48 |
| pkoniszewski | leaving office in 10-15 minutes | 13:48 |
| tdurakov | pkoniszewski: ok | 13:49 |
| *** markvoelker has quit IRC | 13:50 | |
| *** udesale__ has joined #openstack-nova | 13:50 | |
| *** salv-orlando has joined #openstack-nova | 13:50 | |
| *** udesale has quit IRC | 13:51 | |
| *** bswartz has joined #openstack-nova | 13:51 | |
| pumaranikar | johnthetubaguy, do you think error log level is not appropriate here ? | 13:51 |
| *** bkopilov_ has joined #openstack-nova | 13:51 | |
| johnthetubaguy | pumaranikar: yeah, added comments | 13:51 |
| tdurakov | mdbooth: hi, are you ok chairing lm meeting today? | 13:52 |
| johnthetubaguy | pumaranikar: "Error: Serious issue with cloud, administrator should be notified immediately via email/pager. On call people expected to respond." | 13:52 |
| *** bkopilov has joined #openstack-nova | 13:52 | |
| mdbooth | tdurakov: Not really, I'm totally not on top of it | 13:52 |
| johnthetubaguy | pumaranikar: sometimes these errors raised by placement are almost expected, like not found error when you check something is deleted, etc | 13:52 |
| mdbooth | tdurakov: If you'd asked me yesterday, maybe :) | 13:52 |
| *** vsaienko has quit IRC | 13:53 | |
| pumaranikar | johnthetubaguy, yes. I thought of error level logging since it is in exception block | 13:53 |
| tdurakov | paul-carlton2 eliqiao shaohe_feng pkoniszewski yuntongjin kashyap kmartin claudiub tobasco abhishekk mrhillsman raj_singh wznoinsk siva_krishnan, folks, let's skip the l-m meeting this week. | 13:53 |
| johnthetubaguy | pumaranikar: yeah, need to think about the consumer of the message, it doesn't rally help them in this case | 13:53 |
| johnthetubaguy | pumaranikar: but a debug log might be a good idea, if we include information on the specific exception | 13:54 |
| johnthetubaguy | tdurakov: did you see this: https://review.openstack.org/#/c/429798/ | 13:55 |
| johnthetubaguy | tdurakov: trying to get it into RC2, if possible | 13:55 |
| *** egonzalez has joined #openstack-nova | 13:56 | |
| pumaranikar | johnthetubaguy, ok. i will have look at your comment and make change accordingly | 13:56 |
| *** skarthik is now known as karthiks | 13:56 | |
| tdurakov | johnthetubaguy: I'll review it in 1.5 hours, or earlier | 13:56 |
| johnthetubaguy | tdurakov: I was wondering if the folks in the meeting agree if we should try get that into RC2 I guess | 13:57 |
| *** vsaienko has joined #openstack-nova | 13:58 | |
| *** baoli has quit IRC | 13:58 | |
| *** baoli has joined #openstack-nova | 13:59 | |
| tdurakov | johnthetubaguy: btw, have you seen this one https://review.openstack.org/#/c/408002 | 13:59 |
| johnthetubaguy | tdurakov: yeah, I need to look at that one again | 14:00 |
| johnthetubaguy | tdurakov: thats a new option though, not suitable past feature freeze, but good for pike | 14:00 |
| *** bvanhav_ has joined #openstack-nova | 14:03 | |
| *** bvanhav_ is now known as bvanhav | 14:03 | |
| *** bvanhav__ has quit IRC | 14:04 | |
| markus_z | Is the placement service mandatory? (I'm still living under a rock :/ ) | 14:05 |
| *** prateek has joined #openstack-nova | 14:06 | |
| johnthetubaguy | markus_z: it is for ocata | 14:07 |
| johnthetubaguy | markus_z: n-cpu should fail to start if its not configured with the placement URL now | 14:07 |
| *** READ10 has joined #openstack-nova | 14:08 | |
| markus_z | johnthetubaguy: Hm, I think that's the issue in our s390 CI. We don't start the placement service (because we have an outdated version of devstack-gate). | 14:08 |
| *** eglynn has joined #openstack-nova | 14:08 | |
| *** claudiub has joined #openstack-nova | 14:10 | |
| markus_z | johnthetubaguy: Even if it is not the root-cause, good to know that we are behind (again). I have to fix that. | 14:10 |
| markus_z | johnthetubaguy: dammit, yeah, that's it | 14:10 |
| markus_z | Thanks! | 14:10 |
| johnthetubaguy | np | 14:10 |
| openstackgerrit | Trevor McCasland proposed openstack/nova-specs master: Add spec for Accelerating SR-IOV with DPDK https://review.openstack.org/429867 | 14:11 |
| *** tbachman_ has joined #openstack-nova | 14:12 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Default live_migration_progress_timeout to off https://review.openstack.org/429798 | 14:13 |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Remove stuck live-migration detection https://review.openstack.org/430218 | 14:13 |
| *** tbachman has quit IRC | 14:14 | |
| *** tbachman_ is now known as tbachman | 14:14 | |
| *** amoralej is now known as amoralej|lunch | 14:14 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova master: Placement api: set custom json_error_formatter in allocations https://review.openstack.org/395194 | 14:14 |
| *** vsaienko has quit IRC | 14:14 | |
| *** mdrabe has joined #openstack-nova | 14:14 | |
| *** breitz has joined #openstack-nova | 14:16 | |
| johnthetubaguy | pumaranikar: thanks | 14:16 |
| *** breitz_ has quit IRC | 14:17 | |
| pumaranikar | johnthetubaguy, thanks for quick review | 14:18 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add check for invalid inventory amounts https://review.openstack.org/428800 | 14:25 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add check for invalid allocation amounts https://review.openstack.org/416752 | 14:25 |
| *** mlavalle has joined #openstack-nova | 14:25 | |
| *** jamesdenton has joined #openstack-nova | 14:26 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate two more nova-net options https://review.openstack.org/412390 | 14:27 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Standardize indentation of test_vif https://review.openstack.org/430271 | 14:27 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Standardize naming of variables https://review.openstack.org/430272 | 14:27 |
| *** mriedem has joined #openstack-nova | 14:27 | |
| *** Daisy has joined #openstack-nova | 14:28 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Removes getfattr from Quobyte Nova driver https://review.openstack.org/428646 | 14:28 |
| *** sree has joined #openstack-nova | 14:30 | |
| *** Guest60723 has quit IRC | 14:31 | |
| *** jamesden_ has joined #openstack-nova | 14:32 | |
| *** Daisy has quit IRC | 14:32 | |
| *** jamesdenton has quit IRC | 14:33 | |
| *** vsaienko has joined #openstack-nova | 14:34 | |
| *** zhurong has joined #openstack-nova | 14:34 | |
| *** smatzek_ has quit IRC | 14:35 | |
| *** aloga_ has joined #openstack-nova | 14:35 | |
| *** kevinz has quit IRC | 14:36 | |
| johnthetubaguy | sfinucan: doesn't allow_same_net_traffic get used by neutron, or do we use a different firewall driver? | 14:38 |
| sfinucan | johnthetubaguy: What's that in context to? | 14:38 |
| *** jpena|lunch is now known as jpena | 14:38 | |
| *** amoralej|lunch is now known as amoralej | 14:39 | |
| sfinucan | johnthetubaguy: I'm pretty sure it's mainly used by nova-network, but libvirt also overloads it for its own firewall | 14:39 |
| johnthetubaguy | sfinucan: https://review.openstack.org/#/c/412390/6/nova/conf/network.py@957 | 14:40 |
| *** nmathew has joined #openstack-nova | 14:40 | |
| *** stvnoyes has quit IRC | 14:40 | |
| sfinucan | johnthetubaguy: Yeah, so my reply to the first option also stands for the second one | 14:40 |
| *** nmathew has quit IRC | 14:41 | |
| sfinucan | We're overloading the value for libvirt's firewall and that option should be either (a) removed altogether or (b) moved to the libvirt group | 14:41 |
| johnthetubaguy | sfinucan: agreed with the first one, but trying to workout what does the neutron firewalling? isn't it using this code too? https://github.com/openstack/nova/blob/d5f113de34589933c23a7cecc25ca0bf5f47207d/nova/virt/libvirt/firewall.py#L165 | 14:41 |
| johnthetubaguy | sfinucan: I think its shared in virt via this one though: https://github.com/openstack/nova/blob/4f91ed3a547965ed96a22520edcfb783e7936e95/nova/virt/firewall.py#L307 | 14:42 |
| johnthetubaguy | sfinucan: I guess the others maybe don't use it for any neutron drivers yet, unsure | 14:42 |
| *** prateek has quit IRC | 14:43 | |
| sfinucan | johnthetubaguy: Hmm, that's a good point | 14:43 |
| *** cdelatte has quit IRC | 14:43 | |
| sfinucan | johnthetubaguy: If we're reading that right, the comments for 'use_ipv6' are also wrong https://github.com/openstack/nova/blob/d5f113de34589933c23a7cecc25ca0bf5f47207d/nova/virt/libvirt/firewall.py#L158 | 14:45 |
| sfinucan | https://github.com/openstack/nova/blob/d5f113de34589933c23a7cecc25ca0bf5f47207d/nova/conf/netconf.py#L68-L70 | 14:45 |
| johnthetubaguy | sfinucan: yeah, it looks that way | 14:45 |
| sfinucan | grr, whoever thought it was a good idea to reuse nova-net options for neutron deserves a smack | 14:46 |
| sfinucan | :) | 14:46 |
| *** markvoelker has joined #openstack-nova | 14:46 | |
| *** gouthamr has joined #openstack-nova | 14:48 | |
| *** sudipto_ has quit IRC | 14:48 | |
| *** sudipto has quit IRC | 14:48 | |
| *** ducttape_ has joined #openstack-nova | 14:49 | |
| *** dimtruck is now known as zz_dimtruck | 14:51 | |
| sfinucan | And use_ipv6 is *also* used for that injected network template (compute.injected_network_template). Ugh... | 14:51 |
| *** markvoelker has quit IRC | 14:52 | |
| *** owalsh is now known as owalsh-brb | 14:53 | |
| *** mtanino has joined #openstack-nova | 14:54 | |
| *** dikonoor has quit IRC | 14:55 | |
| *** jamesden_ has quit IRC | 14:55 | |
| *** smatzek_ has joined #openstack-nova | 14:55 | |
| *** smatzek__ has joined #openstack-nova | 14:56 | |
| *** jamesdenton has joined #openstack-nova | 14:57 | |
| *** owalsh-brb has quit IRC | 14:57 | |
| *** sree has quit IRC | 14:58 | |
| *** vsaienko has quit IRC | 14:58 | |
| *** sree has joined #openstack-nova | 14:58 | |
| lyarwood | https://review.openstack.org/#/c/427364/ - I'd appreciate reviews on this swap_volume bugfix if any cores have time today. sfinucan, mdbooth's NFS fix now depends on this btw. | 15:00 |
| *** smatzek_ has quit IRC | 15:01 | |
| *** owalsh-brb has joined #openstack-nova | 15:01 | |
| *** eharney has joined #openstack-nova | 15:01 | |
| *** smatzek_ has joined #openstack-nova | 15:02 | |
| sfinucan | lyarwood: I'll take a gawk shortly | 15:02 |
| lyarwood | sfinucan: cheers | 15:02 |
| *** sree has quit IRC | 15:03 | |
| *** crushil has joined #openstack-nova | 15:03 | |
| openstackgerrit | Jordan Pittier proposed openstack/nova master: api-ref: document the 'tenant_id' query parameter https://review.openstack.org/430290 | 15:05 |
| *** satyar has joined #openstack-nova | 15:06 | |
| *** smatzek__ has quit IRC | 15:06 | |
| lyarwood | hmmmm there's no #openstack-devstack channel, does anyone know if openstack-infra is the best place to ask for devstack reviews? I'm looking for reviews on https://review.openstack.org/#/c/427602/ so our ceph job can pass again... | 15:06 |
| *** vsaienko has joined #openstack-nova | 15:06 | |
| dansmith | lyarwood: -qa | 15:06 |
| lyarwood | dansmith: thanks | 15:07 |
| *** sree has joined #openstack-nova | 15:08 | |
| *** owalsh-brb is now known as owalsh | 15:08 | |
| *** david-lyle has joined #openstack-nova | 15:08 | |
| *** xinliang has quit IRC | 15:09 | |
| *** david-lyle has quit IRC | 15:10 | |
| *** david-lyle has joined #openstack-nova | 15:11 | |
| *** tbachman has quit IRC | 15:12 | |
| *** mdnadeem has quit IRC | 15:12 | |
| *** tbachman has joined #openstack-nova | 15:13 | |
| *** cdent has joined #openstack-nova | 15:14 | |
| *** david-lyle has quit IRC | 15:16 | |
| *** sdague_ is now known as sdague | 15:17 | |
| *** aloga_ has quit IRC | 15:18 | |
| *** sacharya has joined #openstack-nova | 15:19 | |
| *** bauzas has quit IRC | 15:19 | |
| *** zz_dimtruck is now known as dimtruck | 15:19 | |
| sfinucan | johnthetubaguy: Out of curiosity, what's the finger in the air estimate for cells v1 going bye bye? | 15:20 |
| sfinucan | ...and, in turn, nova-network | 15:21 |
| openstackgerrit | Christopher Martin proposed openstack/nova master: Stop using mox in test_compute_cells.py https://review.openstack.org/389750 | 15:21 |
| *** hongbin has joined #openstack-nova | 15:21 | |
| johnthetubaguy | sfinucan: we need to implement the transition code, then let that cook for a release. | 15:22 |
| *** gouthamr has quit IRC | 15:22 | |
| johnthetubaguy | sfinucan: after we actually support two cells v2 cells | 15:22 |
| *** xinliang has joined #openstack-nova | 15:22 | |
| johnthetubaguy | sfinucan: so another two or three cycles till we delete, maybe :( | 15:22 |
| *** bauzas has joined #openstack-nova | 15:22 | |
| sfinucan | ouch | 15:22 |
| johnthetubaguy | sfinucan: looking after our users is expensive | 15:23 |
| sfinucan | johnthetubaguy: aye, and sadly necessary | 15:23 |
| * johnthetubaguy nods | 15:23 | |
| *** dave-mccowan has quit IRC | 15:24 | |
| *** hoangcx has quit IRC | 15:24 | |
| *** gouthamr has joined #openstack-nova | 15:29 | |
| *** gouthamr has quit IRC | 15:30 | |
| *** MVenesio has joined #openstack-nova | 15:32 | |
| dansmith | sfinucan: but we should only maintain n-net for cellsv1 users with legit bugs I think, not just anyone | 15:32 |
| *** armax has joined #openstack-nova | 15:34 | |
| sfinucan | dansmith: I was hoping for an easy way out of unravelling the nest of conf options that are shared between nova-net and libvirt/Xen/other things | 15:34 |
| sfinucan | namely, wait until nova-net is gone then remove the ones we don't have references for anymore :) | 15:34 |
| dansmith | heh | 15:34 |
| *** armax has quit IRC | 15:34 | |
| *** armax has joined #openstack-nova | 15:35 | |
| sfinucan | johnthetubaguy: So I'm figuring out what nova-network options /have been/ repurposed and duplicate them in other groups with UPGRADE renos | 15:37 |
| sfinucan | then I'm going to mass migrate all nova-net opts to a single conf file which we can leave to d̶i̶e̶ mature | 15:37 |
| sfinucan | Sound fair? | 15:38 |
| johnthetubaguy | that sounds like a good plan | 15:38 |
| *** vsaienko has quit IRC | 15:38 | |
| *** moshele has quit IRC | 15:39 | |
| *** cdelatte has joined #openstack-nova | 15:40 | |
| *** mdrabe has quit IRC | 15:40 | |
| sfinucan | (y) | 15:40 |
| *** coreywright has quit IRC | 15:41 | |
| *** tovin07 has joined #openstack-nova | 15:42 | |
| *** yamahata has joined #openstack-nova | 15:43 | |
| *** dave-mccowan has joined #openstack-nova | 15:43 | |
| *** egarbade- has quit IRC | 15:44 | |
| *** ekhugen has quit IRC | 15:45 | |
| *** coreywright has joined #openstack-nova | 15:45 | |
| BobBall | johnthetubaguy: Thanks for the review - are you +2 on the revision to https://review.openstack.org/#/c/424428/ or are further changes needed? | 15:46 |
| *** larainema has quit IRC | 15:46 | |
| *** salv-orlando has quit IRC | 15:46 | |
| *** egarbade- has joined #openstack-nova | 15:47 | |
| *** ekhugen has joined #openstack-nova | 15:47 | |
| *** mdrabe has joined #openstack-nova | 15:48 | |
| *** markvoelker has joined #openstack-nova | 15:49 | |
| *** mptacekx has quit IRC | 15:52 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: handle uninited fields in notification payload https://review.openstack.org/415857 | 15:52 |
| *** david-lyle has joined #openstack-nova | 15:53 | |
| *** esberglu has joined #openstack-nova | 15:53 | |
| *** markvoelker has quit IRC | 15:55 | |
| *** jdurgin1 has joined #openstack-nova | 15:55 | |
| *** sandanar has quit IRC | 15:56 | |
| *** lpetrut has quit IRC | 15:56 | |
| *** pkovacs has joined #openstack-nova | 15:58 | |
| *** hieulq_ has joined #openstack-nova | 15:58 | |
| *** salv-orlando has joined #openstack-nova | 16:04 | |
| pkholkin | johnthetubaguy: mriedem: jaypipes: baoli | 16:06 |
| pkholkin | oops | 16:07 |
| pkholkin | johnthetubaguy: mriedem: jaypipes: bauzas: dansmith: alex_xu: and all nova folks, I decided to leave OpenStack, thank you for your work in community and your support! maybe we will meet once again, wish you all the best and good luck! :) | 16:08 |
| dansmith | pkholkin: bummer, but good luck on your next adventure! | 16:09 |
| mriedem | pkholkin: thanks for your contributions and good luck in the new position | 16:09 |
| pkholkin | dansmith: sorry) thank you ! | 16:09 |
| pkholkin | mriedem: thanks! it was a great pleasure to work in our community! | 16:10 |
| *** burgerk has joined #openstack-nova | 16:10 | |
| *** mjura has quit IRC | 16:11 | |
| *** tovin07 has left #openstack-nova | 16:11 | |
| *** cdelatte has quit IRC | 16:12 | |
| *** markvoelker has joined #openstack-nova | 16:13 | |
| *** markvoelker has quit IRC | 16:14 | |
| *** ekuris__ has quit IRC | 16:14 | |
| *** markvoelker has joined #openstack-nova | 16:14 | |
| *** stvnoyes has joined #openstack-nova | 16:14 | |
| rpodolyaka | pkholkin: good luck, Pasha! really sad to see you go :( | 16:15 |
| *** rcernin has quit IRC | 16:16 | |
| markus_z | pkholkin: too bad, thanks for your time | 16:16 |
| *** pcaruana has quit IRC | 16:17 | |
| pkholkin | rpodolyaka: me too( thank you very much, Roman ! | 16:17 |
| *** zhurong has quit IRC | 16:17 | |
| pkholkin | markus_z: thanks! | 16:17 |
| *** jaosorior has joined #openstack-nova | 16:18 | |
| mdbooth | ARGH! | 16:19 |
| mdbooth | The detach/delete race isn't fixable on the compute host | 16:20 |
| mdbooth | Because api gets the bdms and sends them to the compute host, which then acts on them | 16:20 |
| mdbooth | Even though they might be out of date | 16:20 |
| mdbooth | Why? | 16:20 |
| mriedem | mdbooth: did you find my comment in the compute manager code about that already? | 16:21 |
| mdbooth | mriedem: Not yet. I have spelunked significantly, but not everywhere. | 16:21 |
| *** tbachman has quit IRC | 16:21 | |
| mriedem | https://github.com/openstack/nova/blob/46c778efafa3ff3c7bb99d74656bb2d2869ceb16/nova/compute/manager.py#L2413 | 16:21 |
| mdbooth | mriedem: Incidentally, while I'd like to fix this race, I think it's orthogonal to the NFS thing. | 16:22 |
| mdbooth | Because the NFS change is safe either way. | 16:22 |
| mdbooth | It's just ugly complaining about removing things which no longer exist. | 16:22 |
| mdbooth | mriedem: Why not just ignore what api gave us and refresh anyway? | 16:23 |
| cfriesen | mdbooth: couldn't they still be out of date, just less likely? | 16:23 |
| mdbooth | cfriesen: Once we're on the compute host we can hold a lock | 16:24 |
| *** artom_ has joined #openstack-nova | 16:24 | |
| mdbooth | But obviously only against other thing which mutate bdms on the compute host | 16:24 |
| mdbooth | It would fix *this* race, for eg | 16:24 |
| *** egonzalez has left #openstack-nova | 16:24 | |
| cfriesen | mdbooth: coming from the linux kernel I was surprised (shocked, appalled) at the locking in nova. :) | 16:25 |
| mdbooth | cfriesen: locking in nova? | 16:25 |
| mdbooth | cfriesen: Yeah, I'm right there with you. | 16:25 |
| *** xinli has joined #openstack-nova | 16:25 | |
| pumaranikar | cdent, I have updated json formatter patch. Please have a look when you get time https://review.openstack.org/#/c/395194/ | 16:25 |
| *** artom has quit IRC | 16:27 | |
| *** trevormc has joined #openstack-nova | 16:27 | |
| mdbooth | mriedem: What's the significance of refresh if volume_id isn't set there? | 16:27 |
| cdent | pumaranikar: yup, will do, is definitely on my list for today | 16:27 |
| mriedem | to get the volume_id so we can delete the volume | 16:28 |
| mriedem | if we're deleting the instance while it's spawning during a boot from volume where nova creates the volume | 16:28 |
| pumaranikar | cdent, thanks. | 16:28 |
| mdbooth | mriedem: The race here is between detach and delete | 16:29 |
| *** bvanhav has quit IRC | 16:29 | |
| mdbooth | So the issue is that when delete runs, it has a bdm in its list which has already been deleted by detach | 16:30 |
| *** ayogi has quit IRC | 16:30 | |
| mriedem | mdbooth: there is where that comment and refresh came from https://review.openstack.org/#/c/258118/ | 16:30 |
| *** udesale__ has quit IRC | 16:31 | |
| mdbooth | mriedem: Fun. Any reason not to refresh unconditionally? | 16:31 |
| mdbooth | It's slightly more expensive, but it's unlikely to add a great deal to a delete operation. | 16:31 |
| *** egarbade- has quit IRC | 16:32 | |
| *** baoli has quit IRC | 16:32 | |
| mriedem | mdbooth: no, i had a targeted refresh for the specific thing i was fixing to avoid round tripping and pulling the bdm list unconditionally when i didn't need to | 16:32 |
| mriedem | mdbooth: that doesn't fix the race though right? | 16:32 |
| mdbooth | Critically, refresh while holding the instance lock on the compute host | 16:32 |
| *** ekhugen has quit IRC | 16:32 | |
| mriedem | so lock in delete and lock in detach | 16:32 |
| mriedem | you're saying | 16:32 |
| mdbooth | Yeah. delete already locks. | 16:32 |
| mdbooth | I added a patch to lock in detach. | 16:32 |
| *** sree has quit IRC | 16:32 | |
| *** sree has joined #openstack-nova | 16:33 | |
| mdbooth | https://review.openstack.org/#/c/430213/ | 16:33 |
| *** nkrinner is now known as nkrinner_afk | 16:33 | |
| *** ekhugen_alt has quit IRC | 16:33 | |
| *** patriciadomin has quit IRC | 16:34 | |
| mdbooth | detach currently races with itself, so I don't understand why that's not already there | 16:34 |
| * mdbooth wonders if there's some obtuse reason detach doesn't lock, but everything else does. | 16:34 | |
| mriedem | what do you mean by races with itself? | 16:34 |
| mdbooth | Detach the same volume multiple times in quick succession | 16:35 |
| mdbooth | They'll all run concurrently. | 16:35 |
| *** lpetrut has joined #openstack-nova | 16:35 | |
| *** openstackgerrit has quit IRC | 16:35 | |
| *** vsaienko has joined #openstack-nova | 16:37 | |
| *** aloga_ has joined #openstack-nova | 16:38 | |
| *** openstackgerrit has joined #openstack-nova | 16:38 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Run api sample tests against 2.latest https://review.openstack.org/430352 | 16:38 |
| *** artom_ is now known as artom | 16:38 | |
| mriedem | mdbooth: i imagine it's not there because in that scenario, eventually the first one wins and the user doesn't see any errors in the compute but they see the detach eventually complete, so they are happy | 16:39 |
| mriedem | the admin might see an error in the logs if they are monitoring | 16:39 |
| mriedem | anyway, left a comment in your chnage | 16:40 |
| mdbooth | mriedem: But meanwhile the backend is busy hassling cinder about it, and doing multiple cleanups simultaneously, and we've got our fingers crossed there are no side effects we haven't thought of. | 16:40 |
| mriedem | *chnage | 16:40 |
| mdbooth | Thanks | 16:40 |
| mriedem | crap, *change* | 16:40 |
| mdbooth | hehe | 16:40 |
| mriedem | well like all bugs, it's not a bug until it is and someone cares about it | 16:40 |
| mriedem | so shrug | 16:40 |
| mdbooth | mriedem: TBH, I only care about it because I wrote a patch which causes it to be noticed :) | 16:42 |
| mriedem | just put out a TC resolution to drop support for NFS and then you don't need to worry about this | 16:43 |
| mdbooth | mriedem: Well it would have to be *any* filesystem based volume backend. My patch supports them all :) | 16:44 |
| *** markus_z has quit IRC | 16:44 | |
| cdent | pumaranikar: nice work! I've left some questions within on that but they are mostly for johnthetubaguy and sdague | 16:44 |
| * mdbooth is pretty sure no real users care about these things, anyway | 16:44 | |
| *** chyka has joined #openstack-nova | 16:44 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add an update_cell command to nova-manage https://review.openstack.org/430354 | 16:46 |
| *** pkovacs has quit IRC | 16:47 | |
| pumaranikar | cdent, thanks for quick review :) | 16:48 |
| *** cdelatte has joined #openstack-nova | 16:49 | |
| *** jdurgin1 has quit IRC | 16:49 | |
| *** bvanhav has joined #openstack-nova | 16:50 | |
| *** psachin has quit IRC | 16:50 | |
| lyarwood | mdbooth: speaking of something that end users don't really care about, shouldn't all of that logic be in the DriverVolumeBlockDevice class like it is for attach_volume? | 16:51 |
| mriedem | armax: thanks for https://review.openstack.org/#/c/429984/ - i left some comments in there | 16:51 |
| mdbooth | lyarwood: Nope. See code comment. | 16:51 |
| armax | mriedem: thanks, I’ll have another pass | 16:51 |
| mdbooth | lyarwood: It's only relevant to backends which use it. Ideally that would be all of them, but I chose not to do them all in 1 patch. | 16:52 |
| dansmith | mriedem: this might be good to get in https://review.openstack.org/430354 | 16:53 |
| dansmith | mriedem: it's non-runtime and gives us yet another way to tweak those records if they get created incorrectly | 16:53 |
| sdague | cdent: for https://review.openstack.org/#/c/395194/11/nova/api/openstack/placement/wsgi_wrapper.py - is that always going to be a 5xx error, or are 4xx in that mix as well | 16:53 |
| dansmith | mriedem: I've now encountered two people that created their records and needed to change them | 16:53 |
| cdent | sdague that always not 5xx at that stage, only intentionally raised 4xx | 16:53 |
| mriedem | dansmith: we have create_cell and delete_cell | 16:53 |
| dansmith | mriedem: yeah, but you can't do that once you've created instances | 16:54 |
| mriedem | oh yeah | 16:54 |
| mriedem | fudge | 16:54 |
| lyarwood | mdbooth: sorry which comment? | 16:54 |
| mriedem | dansmith: let me contemplate this in the men's room | 16:55 |
| cdent | sdague: the goal there is to only add the formatting. there's middleware much further "out" which deals with trapping unexpected exceptions | 16:55 |
| *** hieulq_ has quit IRC | 16:55 | |
| sdague | cdent: right, so I wouldn't add the logging there then | 16:55 |
| * cdent nods | 16:55 | |
| sdague | because we don't want to be logging the same error multiple times if it's already gathered elsewhere | 16:55 |
| *** lpetrut has quit IRC | 16:56 | |
| cdent | sdague: these particular excpeptions will not leave the app (into middleware) as exceptions. webob turns them into proper responses. so any logging that is happening is either right there, or when the original exception is raised | 16:58 |
| *** andreas_s has quit IRC | 16:59 | |
| cdent | the need for this superclass is precisely because of the way webob turns exceptions within wsgify decorated functions into responses | 16:59 |
| mdbooth | lyarwood: https://review.openstack.org/#/c/383859/13/nova/virt/libvirt/volume/fs.py | 16:59 |
| *** adrian_otto has joined #openstack-nova | 16:59 | |
| lyarwood | mdbooth: ah sorry, I'm talking about moving the _detach_volume logic from the compute layer into https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L205 like we did for attach | 17:00 |
| *** eharney_ has joined #openstack-nova | 17:01 | |
| mdbooth | lyarwood: I guess. You'd still need to resolve the locking issues in compute manager, though | 17:02 |
| *** eharney has quit IRC | 17:03 | |
| *** eharney_ is now known as eharney | 17:03 | |
| *** hamzy has quit IRC | 17:03 | |
| lyarwood | mdbooth: yeah, I just thought of it again when I saw your change, it's something Nikola wanted to do before he left but never got around to. Anyway, ignore me, sorry for the noise. | 17:03 |
| *** sridharg has quit IRC | 17:04 | |
| *** derekh has quit IRC | 17:05 | |
| *** unicell has joined #openstack-nova | 17:08 | |
| *** unicell1 has quit IRC | 17:08 | |
| *** lpetrut has joined #openstack-nova | 17:08 | |
| sfinucan | sean-k-mooney, jaypipes: Do you know if os-vif publishes whether a VIF should support IPv6 or not? | 17:09 |
| sfinucan | i.e. as part of the VIF model | 17:09 |
| sean-k-mooney | no | 17:09 |
| sean-k-mooney | it is not a property of the VIF | 17:09 |
| sean-k-mooney | its a property of the neutron subnet | 17:09 |
| sean-k-mooney | i would not expect this to be reported by os-vif | 17:10 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Improve assertJsonEqual error reporting https://review.openstack.org/428199 | 17:10 |
| sean-k-mooney | sfinucan: also ^^ | 17:10 |
| sean-k-mooney | sfinucan: i should have mentioned you in the reply | 17:11 |
| sfinucan | sean-k-mooney: OK, cool | 17:12 |
| mriedem | dansmith: you know what might be nice is to put the service version in the os-services output | 17:12 |
| mdbooth | lyarwood mriedem: rebuild also disconnects twice. Once explicitly in compute manager, once again in the driver during destroy. | 17:12 |
| mriedem | dansmith: now that we have all of this stuff that depends on having computes at a certain version | 17:12 |
| sfinucan | So there's merit in keeping around the use_ipv6 option for building VIF filters in libvirt | 17:12 |
| sfinucan | e.g. https://libvirt.org/formatnwfilter.html | 17:12 |
| sfinucan | ? | 17:12 |
| sean-k-mooney | sfinucan: am im not sure but i dont we use that and i dont think we should | 17:13 |
| dansmith | mriedem: might be good to abstract it a bit if we do.. so report "LATEST" and "OLD" or something | 17:13 |
| *** tbachman has joined #openstack-nova | 17:13 | |
| sean-k-mooney | sfinucan: i would like to completely remove libvirt form our port binding if we can | 17:13 |
| mriedem | dansmith: yeah, was just thinking about a doc that armax is working on for get me a network and we don't have a way to tell you if your computes are new enough to use that | 17:13 |
| *** raunak has joined #openstack-nova | 17:14 | |
| sfinucan | sean-k-mooney: I don't think we can, assuming we want to keep the interface firewalls https://github.com/openstack/nova/blob/master/nova/virt/libvirt/firewall.py#L138-L179 | 17:14 |
| dansmith | mriedem: aye, although they log the service version on startup I think so we could also just rely on that for the short term | 17:14 |
| sean-k-mooney | sfinucan: the only place we use libvirt for port binding currently is the non hybrid plug case for ovs. that really should be done by os-vif | 17:14 |
| *** raunak has quit IRC | 17:14 | |
| *** alaski_ is now known as alaski | 17:14 | |
| sean-k-mooney | sfinucan: no we can we just need to not add the interfaces as an openvswithc interface in the libvirt xml. just add it as a generic tap | 17:15 |
| lyarwood | mdbooth: ewww, we can't really remove the compute layer call as other virt drivers might not do that right? | 17:15 |
| sean-k-mooney | sfinucan: then have os-vif add it to the ovs bridge | 17:15 |
| mdbooth | lyarwood: Presumably not | 17:15 |
| *** Apoorva has joined #openstack-nova | 17:15 | |
| lyarwood | mdbooth: as mriedem said before I think it's just another case of us assuming that nothing bad will happen if you disconnect_volume twice :| | 17:15 |
| *** breitz has quit IRC | 17:15 | |
| mriedem | i said that? | 17:16 |
| sean-k-mooney | sfinucan: where is _get_instance_filter_parameters used | 17:16 |
| lyarwood | mriedem: something along the lines of that if I understood correctly, maybe I didn't | 17:16 |
| *** yamahata has quit IRC | 17:16 | |
| sfinucan | sean-k-mooney: Here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/firewall.py#L181-L193 | 17:16 |
| mriedem | if it was smart, then yes i said it | 17:16 |
| mdbooth | hehe | 17:16 |
| sfinucan | sean-k-mooney: Which is in turn called here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/firewall.py#L112-L136 | 17:16 |
| sean-k-mooney | yep tracking back now. im trying to figure out if this code is still executed with os-vif | 17:17 |
| sfinucan | sean-k-mooney: I think it is. It's called in a few places in the libvirt driver.py | 17:18 |
| mdbooth | mriedem: So, I've been through the ERRORs generated against my NFS patch with a fine toothed comb. There are 2, and they're both existing errors where we're double-calling disconnect from higher up. They cause no ill effects other than the log message. | 17:18 |
| sean-k-mooney | basically i think we could move this to os-vif if it was still needed | 17:18 |
| cburgess | mriedem Sorry missed your messages yesterday, yes we use live_migration_progress_timeout why? | 17:18 |
| mriedem | cburgess: https://review.openstack.org/#/c/429798 | 17:18 |
| mdbooth | I originally made them ERROR because I didn't expect the errors higher up, which with hindsight perhaps I should have. | 17:18 |
| *** nikeshm has joined #openstack-nova | 17:19 | |
| mdbooth | I suggest I turn them into warnings and file bugs about them, but that we go with the NFS patch anyway. | 17:19 |
| nikeshm | hi | 17:19 |
| sean-k-mooney | sfinucan: so it is really called here https://github.com/openstack/nova/blob/417dac50364357000c479bb2cb7c71773172a930/nova/virt/libvirt/driver.py#L1371 | 17:19 |
| nikeshm | i am getting this error libvirtError: Requested operation is not valid: pivot of disk 'vdb' requires an active copy job | 17:19 |
| mriedem | lyarwood: ^ | 17:19 |
| * lyarwood looks | 17:20 | |
| cburgess | mriedem Oh cute... thanks for the heads up. This might actually explain some issues we saw recently. | 17:20 |
| nikeshm | tempest.api.compute.admin.test_volume_swap.TestVolumeSwap.test_volume_swap [416.350838s] ... FAILED | 17:20 |
| mdbooth | lyarwood: If mriedem is looking for a detailed second opinion, I don't mind walking you through the logs in the morning. | 17:20 |
| mdbooth | Would probably take an hour or so. | 17:20 |
| lyarwood | mdbooth: sure | 17:20 |
| sfinucan | sean-k-mooney: Yup | 17:20 |
| sean-k-mooney | sfinucan: so this si currently called after plug but im not sure its valide to call it here in all cases. | 17:21 |
| sfinucan | and it's used for "MAC, IP, and ARP spoofing protection" | 17:21 |
| lyarwood | nikeshm: what virt_type are you using? | 17:21 |
| mdbooth | lyarwood: Thanks! It's a date. | 17:21 |
| sean-k-mooney | sfinucan: i dont think this will have any effect for vhost-user for example | 17:21 |
| sfinucan | sean-k-mooney: No? How come? | 17:21 |
| nikeshm | lyarwood: virt_type = qemu | 17:22 |
| sean-k-mooney | how would that function configure mac,arp,ip spoofing on a vhost-user interfaces | 17:22 |
| sean-k-mooney | sfinucan: that would have to be done in ovs | 17:22 |
| lyarwood | nikeshm: and which verison of qemu? | 17:22 |
| sfinucan | sean-k-mooney: aha, correct | 17:22 |
| sfinucan | that is for IPTables only | 17:22 |
| *** jgrassler has quit IRC | 17:22 | |
| *** jaosorior has quit IRC | 17:22 | |
| sfinucan | it's part of the IptablesFirewallDriver | 17:23 |
| sean-k-mooney | sfinucan: it is for when you are using the old nova firewall not neutron security groups | 17:23 |
| *** jgr has joined #openstack-nova | 17:23 | |
| sfinucan | sean-k-mooney: danpb suggested otherwise though | 17:23 |
| sean-k-mooney | sfinucan: it basically part of nova networks i think | 17:23 |
| sean-k-mooney | sfinucan: i could be wrong | 17:23 |
| mdbooth | lyarwood: Plan is to walk through the errors reported here: http://logs.openstack.org/09/395709/6/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/c8091c2/logs/screen-n-cpu.txt.gz?level=ERROR | 17:23 |
| * sfinucan goes to check johnthetubaguy's comments on a related review | 17:23 | |
| *** jaosorior has joined #openstack-nova | 17:23 | |
| *** nic has joined #openstack-nova | 17:23 | |
| *** jaosorior has quit IRC | 17:24 | |
| sean-k-mooney | sfinucan: but i dont think this will have any eefect with the conntrack firewall driver in neutron for example | 17:24 |
| *** sree has quit IRC | 17:24 | |
| dansmith | mriedem: you want me to replicate that multiline warning on each help string for transport and db? | 17:24 |
| mriedem | dansmith: well they'd be slightly different but yeah, i don't think the actual docstring gets dumped in the cli help | 17:24 |
| mriedem | i can check quick | 17:24 |
| *** jaosorior has joined #openstack-nova | 17:24 | |
| dansmith | oh I thought it did | 17:25 |
| sean-k-mooney | sfinucan: looking at https://github.com/openstack/nova/blob/d5f113de34589933c23a7cecc25ca0bf5f47207d/nova/virt/libvirt/firewall.py#L117-L120 | 17:25 |
| dansmith | that's the point of putting return value stuff in there right? | 17:25 |
| mriedem | the help for the args is printed out, | 17:25 |
| sean-k-mooney | sfinucan: it will disable this code if securty groupd are enabled | 17:25 |
| mriedem | but i don't think the docstring gets into the help output for the command | 17:25 |
| mriedem | and i guess i don't have a test vm handy to verify | 17:25 |
| mriedem | but i had that issue with the nova-status stuff | 17:25 |
| mriedem | which is why i also pushed for man pages | 17:25 |
| *** unicell has quit IRC | 17:26 | |
| dansmith | hmm | 17:26 |
| dansmith | mriedem: remember you making me document the return values for the new cells commands there? I thought that was because the user, you know, sees that shit :) | 17:26 |
| *** jogo has quit IRC | 17:27 | |
| mriedem | do you have a devstack you can verify quick because i don't | 17:27 |
| lyarwood | nikeshm: feel free to write this up in a bug btw if it's easier - https://bugs.launchpad.net/nova/+filebug | 17:27 |
| *** efried has quit IRC | 17:28 | |
| dansmith | mriedem: I have an old one only, but let me look | 17:28 |
| mriedem | just do like: nova-manage cell_v2 create_cell -h | 17:28 |
| dansmith | it's too old for that :) | 17:29 |
| sfinucan | sean-k-mooney: Yeah, all the guides I'm seeing suggest that nwfilter - the thing that reads that config - is only for ebtables | 17:29 |
| sfinucan | i.e. not OVS | 17:29 |
| sfinucan | https://www.redhat.com/archives/libvir-list/2013-November/msg00234.html | 17:29 |
| dansmith | mriedem: my liberty system doesn't show that text at least | 17:29 |
| dansmith | so unless something has changed... | 17:29 |
| mriedem | nova-manage db sync -h | 17:29 |
| mriedem | would show "Sync the database up to the most recent version" if it worked | 17:29 |
| mriedem | it should show the help on the --version option though "Database version" | 17:30 |
| sean-k-mooney | sfinucan: yes so this code should really only be run for linuxbridge or macvtap binding | 17:31 |
| sean-k-mooney | so it proable should be moved into the linuxbridge pluging for os-vif | 17:31 |
| sfinucan | sean-k-mooney: ...and even then, doesn't neutron have its own anti-spoofing stuff? | 17:31 |
| sfinucan | e.g. http://kimizhang.com/neutron-ml2-port-security/ | 17:32 |
| sean-k-mooney | for ovs yes | 17:32 |
| sean-k-mooney | for linux bridge proably | 17:32 |
| sean-k-mooney | not sure though | 17:32 |
| sean-k-mooney | again i think this is mainly for nova-networks | 17:32 |
| sfinucan | that blog suggests yes for linucbridge | 17:32 |
| sfinucan | *linuxbridge | 17:32 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add an update_cell command to nova-manage https://review.openstack.org/430354 | 17:32 |
| sean-k-mooney | if you are using nova-netwokrs this code would be needed for firewall support because you would not have nova | 17:33 |
| sean-k-mooney | * neutron | 17:33 |
| nikeshm | lyarwood: qemu-utils 2.0.0+dfsg-2ubuntu1.30 amd64 QEMU utilities | 17:33 |
| sean-k-mooney | nova-networks without nova would be hard | 17:33 |
| *** kaisers has quit IRC | 17:33 | |
| sean-k-mooney | general question but is nova-networks dead yet? | 17:34 |
| sean-k-mooney | can we actully start deleting the code for it. i kindof lost track of that effort | 17:35 |
| lyarwood | nikeshm: and libvirt? | 17:35 |
| *** Apoorva has quit IRC | 17:35 | |
| nikeshm | lyarwood: libvirt-dev 1.2.2-0ubuntu13.1.17 amd64 development files for the libvirt library | 17:36 |
| *** Apoorva has joined #openstack-nova | 17:36 | |
| *** Swami has joined #openstack-nova | 17:36 | |
| *** kaisers has joined #openstack-nova | 17:37 | |
| *** mvk has quit IRC | 17:37 | |
| *** Swami has quit IRC | 17:37 | |
| *** rfolco has quit IRC | 17:38 | |
| *** esberglu has quit IRC | 17:38 | |
| *** nikhil|afk has joined #openstack-nova | 17:38 | |
| *** Swami has joined #openstack-nova | 17:38 | |
| *** slaweq has quit IRC | 17:39 | |
| sfinucan | sean-k-mooney: Nope. It's there for another 2-3 cycles at least :( | 17:40 |
| sean-k-mooney | :( really... why... | 17:41 |
| *** efried has joined #openstack-nova | 17:41 | |
| sfinucan | sean-k-mooney: cells v1 | 17:42 |
| sfinucan | need a migration path to cells v2 then another cycle for folks to switch over | 17:42 |
| sean-k-mooney | cells v1 only works with nova-networks? | 17:42 |
| sfinucan | from the looks of things, yup | 17:43 |
| sean-k-mooney | sfinucan: so ocate cells v2 pike miragtion and queens remove nova networks? | 17:43 |
| sfinucan | nope. cells v2 isn't complete yet | 17:44 |
| sean-k-mooney | hum ok i taught cells v1 worked with neutron i guess not. | 17:44 |
| sfinucan | you can't use more than one cell in cells v2 | 17:44 |
| mriedem | sean-k-mooney: sfinucan: you can use neutron with cells v1 | 17:44 |
| mriedem | godaddy is running ovs | 17:44 |
| mriedem | it requires patches for the external vif plug event callbackstuff | 17:45 |
| mriedem | but people are doing it | 17:45 |
| sfinucan | mriedem: So what's the tie with nova-net? | 17:45 |
| mriedem | nova-net will only start in ocata if running cells v1 | 17:45 |
| sfinucan | I thought that was the one blocker stopping us killing it | 17:45 |
| mriedem | nova-net will go when cells v1 goes | 17:45 |
| sfinucan | right, but not the other way round | 17:45 |
| *** karimb has quit IRC | 17:45 | |
| sfinucan | ? | 17:45 |
| mriedem | right | 17:46 |
| lyarwood | nikeshm: hmmm can you document this in a bug and I'll take a look this evening? I can't reproduce that locally on Fedora 24 | 17:46 |
| sfinucan | so why don't we keep cells v1 (which doesn't have a complete migration path) and kill nova-net (which does - neutron) | 17:46 |
| *** patriciadomin has joined #openstack-nova | 17:46 | |
| mriedem | sfinucan: because then we'd have to switch the cells v1 CI job to neutron, | 17:46 |
| *** ekhugen has joined #openstack-nova | 17:46 | |
| mriedem | and we don't have that external vif plugging callback stuff plumbed into cells v1 upstream | 17:46 |
| mriedem | which would require work to make cells v1 work with nova in our CI | 17:47 |
| mriedem | work we don't care to do for something that we're effectively crippling and setting up to remove | 17:47 |
| *** egarbade- has joined #openstack-nova | 17:47 | |
| sfinucan | mriedem: ah, so it's a non-trivial amount of work | 17:48 |
| mriedem | correct | 17:48 |
| sfinucan | Gotcha. I didn't get that link. Thanks for clearing it up | 17:48 |
| *** ekhugen_alt has joined #openstack-nova | 17:48 | |
| mriedem | np | 17:48 |
| sfinucan | mikal: Do I recall talk of file injection going away? | 17:49 |
| sean-k-mooney | sfinucan: so back to your original question we proably have to keep that function untill cells v1 goes... or move it to the linux bridge os-vif driver | 17:49 |
| *** baoli has joined #openstack-nova | 17:49 | |
| sfinucan | sean-k-mooney: That would sound about right | 17:49 |
| mriedem | blam! pike is the current focus of dev now https://launchpad.net/nova | 17:50 |
| *** efried has quit IRC | 17:50 | |
| sfinucan | But we probably don't need to keep it after that point, because neutron can do what libvirt is doing here | 17:50 |
| *** sree has joined #openstack-nova | 17:50 | |
| *** raunak has joined #openstack-nova | 17:50 | |
| sfinucan | ...and what libvirt is doing probably wouldn't even work for folks using OVS and/or security groups, which is most people if the surveys are to be believed | 17:51 |
| *** esberglu has joined #openstack-nova | 17:52 | |
| *** nikeshm has quit IRC | 17:52 | |
| *** adrian_otto has quit IRC | 17:53 | |
| *** adrian_otto has joined #openstack-nova | 17:54 | |
| *** efried has joined #openstack-nova | 17:54 | |
| *** adrian_otto has quit IRC | 17:54 | |
| *** sudipto_ has joined #openstack-nova | 17:55 | |
| *** sudipto has joined #openstack-nova | 17:55 | |
| mriedem | sfinucan: i plan on proposing a spec for pike to deprecate file injection (personalities) in the REST API (outside of config drive anyway) | 17:55 |
| mriedem | http://lists.openstack.org/pipermail/openstack-dev/2016-November/107195.html | 17:56 |
| mdbooth | mriedem: Fun. Does that mean nobody is using that? | 17:56 |
| mriedem | via config drive or the personality files or just in general? | 17:57 |
| *** browne has joined #openstack-nova | 17:57 | |
| gabor_antal_ | Hey there, may I ask a question? Is it okay if I update test-requirements with a newer version of hacking? | 17:57 |
| mdbooth | cfriesen mriedem: Incidentally, IIRC that also fails for config drives because we're constantly blowing config drives away and rebuilding them. | 17:57 |
| mriedem | gabor_antal_: requirements changes to nova go through the openstack/requirements repo, and updating hacking there is a global change which impacts all projects, | 17:58 |
| mriedem | gabor_antal_: so it's a large undertaking | 17:58 |
| mriedem | mdbooth: http://lists.openstack.org/pipermail/openstack-dev/2016-November/107195.html was also in the operators list and go no responses | 17:58 |
| auggy | nova bugs team meeting at the top of the hour in #openstack-meeting-4 ! | 17:58 |
| mriedem | so i have no idea how much it's used | 17:59 |
| johnthetubaguy | honestly, I am not sure as operators if they would know either | 18:00 |
| openstackgerrit | Diana Clarke proposed openstack/nova master: Reduce the number of COMMIT & SELECT 1 statements https://review.openstack.org/430390 | 18:00 |
| gabor_antal_ | mriedem: Should we propose to that repo or where? I just checked the new hacking, and has a great feature | 18:00 |
| *** ralonsoh has quit IRC | 18:00 | |
| *** rfolco has joined #openstack-nova | 18:00 | |
| mriedem | gabor_antal_: if you're going to propose it, it starts in the openstack/requirements repo | 18:00 |
| *** tesseract has quit IRC | 18:01 | |
| *** gouthamr has joined #openstack-nova | 18:02 | |
| *** lucasagomes is now known as lucas-afk | 18:02 | |
| *** alexpilotti has joined #openstack-nova | 18:02 | |
| *** abalutoiu__ is now known as abalutoiu | 18:02 | |
| *** yamahata has joined #openstack-nova | 18:02 | |
| *** aloga_ has quit IRC | 18:03 | |
| *** krtaylor has quit IRC | 18:03 | |
| gabor_antal_ | mriedem: I think I wanted to push this, but that is already merged: https://review.openstack.org/#/c/409626/ | 18:03 |
| *** vsaienko has quit IRC | 18:04 | |
| mriedem | gabor_antal_: oh so we just need to update https://github.com/openstack/nova/blob/master/test-requirements.txt#L5 | 18:04 |
| mriedem | i didn't realize hacking was excluded from global updates | 18:04 |
| mriedem | then i guess it's simpler since it's just nova | 18:04 |
| gabor_antal_ | Yeah, so then it's okay if I modify this line, | 18:05 |
| *** gszasz has quit IRC | 18:06 | |
| *** sudipto_ has quit IRC | 18:23 | |
| *** sudipto has quit IRC | 18:23 | |
| *** faizy has joined #openstack-nova | 18:23 | |
| *** vsaienko has joined #openstack-nova | 18:26 | |
| *** jpena is now known as jpena|away | 18:33 | |
| *** jpena|away is now known as jpena | 18:33 | |
| *** aloga_ has joined #openstack-nova | 18:33 | |
| *** unicell has joined #openstack-nova | 18:33 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Fix races with nfs volume mount/umount https://review.openstack.org/383859 | 18:35 |
| *** hamzy has joined #openstack-nova | 18:35 | |
| *** gouthamr has quit IRC | 18:35 | |
| *** jpena is now known as jpena|lunch | 18:37 | |
| *** jpena|lunch is now known as jpena|away | 18:37 | |
| *** owalsh is now known as owalsh-afk | 18:38 | |
| *** sambetts is now known as sambetts|afk | 18:38 | |
| *** satyar_ has joined #openstack-nova | 18:39 | |
| *** krtaylor has joined #openstack-nova | 18:39 | |
| *** satyar has quit IRC | 18:40 | |
| *** karimb has joined #openstack-nova | 18:40 | |
| *** jdurgin has quit IRC | 18:41 | |
| *** jkraj has quit IRC | 18:41 | |
| *** ducttape_ has quit IRC | 18:41 | |
| *** aloga_ has quit IRC | 18:44 | |
| *** moshele has joined #openstack-nova | 18:49 | |
| *** vsaienko has quit IRC | 18:51 | |
| *** vsaienko has joined #openstack-nova | 18:52 | |
| openstackgerrit | Sean McCully proposed openstack/nova master: allocations.consumer_id is not used in query. https://review.openstack.org/430399 | 18:52 |
| *** sree has quit IRC | 18:53 | |
| *** avolkov has quit IRC | 18:53 | |
| *** vsaienko has quit IRC | 18:54 | |
| *** alexpilo_ has joined #openstack-nova | 18:55 | |
| *** alexpilotti has quit IRC | 18:55 | |
| *** jdurgin has joined #openstack-nova | 18:57 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Stop _undefine_domain erroring if domain not found https://review.openstack.org/430400 | 19:00 |
| *** bvanhav_ has joined #openstack-nova | 19:00 | |
| *** bvanhav has quit IRC | 19:01 | |
| cdent | edleafe, bauzas: didn't we already have a fix like 430399 ^^ before? | 19:02 |
| *** ociuhandu has joined #openstack-nova | 19:03 | |
| *** vsaienko has joined #openstack-nova | 19:04 | |
| *** ducttape_ has joined #openstack-nova | 19:10 | |
| *** vsaienko has quit IRC | 19:14 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Stop leaving failed live-migrates in the migrating state https://review.openstack.org/430404 | 19:15 |
| cdent | edleafe, bauzas never mind, it's not, it's the same problem somewhere else | 19:15 |
| *** faizy has quit IRC | 19:16 | |
| johnthetubaguy | mriedem: FYI, there seems to be another nastly little live-migrate bug that has cropped up in our testing: https://review.openstack.org/430400 | 19:17 |
| johnthetubaguy | mriedem: still investigation, just a general heads up that stuff is cooking there | 19:17 |
| * johnthetubaguy goes to sort out food | 19:17 | |
| *** satyar_ has quit IRC | 19:18 | |
| mriedem | johnthetubaguy: ok i've left my -1 for your dessert :) | 19:19 |
| *** vsaienko has joined #openstack-nova | 19:22 | |
| openstackgerrit | Sean McCully proposed openstack/nova master: allocations.consumer_id is not used in query. https://review.openstack.org/430399 | 19:24 |
| *** ducttape_ has quit IRC | 19:31 | |
| *** vsaienko has quit IRC | 19:34 | |
| *** vsaienko has joined #openstack-nova | 19:36 | |
| *** adrian_otto has joined #openstack-nova | 19:38 | |
| *** Daisy has joined #openstack-nova | 19:39 | |
| *** gouthamr has joined #openstack-nova | 19:41 | |
| *** gouthamr has quit IRC | 19:41 | |
| *** owalsh-afk has quit IRC | 19:43 | |
| *** Daisy has quit IRC | 19:43 | |
| *** breitz has joined #openstack-nova | 19:44 | |
| *** xinli has quit IRC | 19:44 | |
| *** salv-orl_ has joined #openstack-nova | 19:50 | |
| cfriesen | johnthetubaguy: got a theory on the race in https://bugs.launchpad.net/nova/+bug/1662626 between live migration and deletion. instance deletion synchronizes on instance.uuid, but I don't think _post_live_migration() does. | 19:50 |
| openstack | Launchpad bug 1662626 in OpenStack Compute (nova) "live-migrate left in migrating as domain not found" [Undecided,In progress] - Assigned to John Garbutt (johngarbutt) | 19:50 |
| *** salv-orlando has quit IRC | 19:52 | |
| *** ducttape_ has joined #openstack-nova | 19:54 | |
| *** xinli has joined #openstack-nova | 20:01 | |
| johnthetubaguy | cfriesen: it could be, I need to look at what the periodic tasks are doing, there is just a loop of live-migrates on a test rig for this test, AFAIK. | 20:02 |
| johnthetubaguy | mriedem: yeah, you are right, I meant to look that up, but wanted dinner | 20:02 |
| *** mvensky has joined #openstack-nova | 20:03 | |
| *** salv-orl_ has quit IRC | 20:04 | |
| cfriesen | question...if instance.old_flavor refers to a deleted flavor, will it still be able to load it from the DB? | 20:04 |
| *** annegentle has joined #openstack-nova | 20:10 | |
| *** oomichi_ has joined #openstack-nova | 20:11 | |
| *** ducttape_ has quit IRC | 20:14 | |
| *** ducttape_ has joined #openstack-nova | 20:14 | |
| *** READ10 has quit IRC | 20:16 | |
| *** dave-mccowan has quit IRC | 20:19 | |
| *** rfolco has quit IRC | 20:26 | |
| mriedem | cfriesen: yes | 20:28 |
| mriedem | the old_flavor is stored in the extras table | 20:29 |
| mriedem | *instance_extra | 20:29 |
| *** amoralej is now known as amoralej|off | 20:29 | |
| *** ducttape_ has quit IRC | 20:31 | |
| *** bvanhav_ has quit IRC | 20:36 | |
| *** dave-mccowan has joined #openstack-nova | 20:37 | |
| cfriesen | do we allow resizing from a flavor with ephemeral/swap to a flavor without? I only see a check for root_gb. | 20:38 |
| cfriesen | mriedem: thanks | 20:38 |
| *** jaosorior has quit IRC | 20:40 | |
| openstackgerrit | Emilien Macchi proposed openstack/nova master: DNM - test tripleo without nova api in WSGI/apache https://review.openstack.org/429008 | 20:43 |
| *** ducttape_ has joined #openstack-nova | 20:43 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova master: conf: mark glance.api_servers opt as required https://review.openstack.org/428241 | 20:43 |
| *** dimtruck is now known as zz_dimtruck | 20:47 | |
| *** karimb has quit IRC | 20:49 | |
| *** karimb has joined #openstack-nova | 20:50 | |
| *** amotoki has quit IRC | 20:51 | |
| *** rtheis has joined #openstack-nova | 20:53 | |
| *** rtheis has quit IRC | 20:53 | |
| *** ijw has joined #openstack-nova | 20:57 | |
| *** crushil has quit IRC | 20:58 | |
| *** ducttape_ has quit IRC | 20:59 | |
| *** ducttape_ has joined #openstack-nova | 20:59 | |
| *** rfolco has joined #openstack-nova | 21:00 | |
| *** owalsh-afk has joined #openstack-nova | 21:00 | |
| *** ducttape_ has quit IRC | 21:01 | |
| *** oomichi_ has quit IRC | 21:03 | |
| smcginnis | johnthetubaguy: Start here: https://review.openstack.org/#/c/297140/ | 21:03 |
| smcginnis | johnthetubaguy: Then here: https://review.openstack.org/#/c/346438/ | 21:03 |
| *** nicolasbock has quit IRC | 21:04 | |
| smcginnis | johnthetubaguy: Actually, the second one isn't the one I was looking for. This one might be more interesting: https://review.openstack.org/#/c/346470/ | 21:04 |
| *** ianw has quit IRC | 21:07 | |
| *** moshele has quit IRC | 21:07 | |
| openstackgerrit | Diana Clarke proposed openstack/nova master: Reduce the number of COMMIT & SELECT 1 statements https://review.openstack.org/430390 | 21:07 |
| *** ianw has joined #openstack-nova | 21:08 | |
| *** moshele has joined #openstack-nova | 21:09 | |
| *** harlowja has quit IRC | 21:09 | |
| *** rfolco has quit IRC | 21:10 | |
| *** dave-mccowan has quit IRC | 21:10 | |
| johnthetubaguy | smcginnis: cool, thank you, something for the morning :) | 21:11 |
| *** nicolasbock has joined #openstack-nova | 21:11 | |
| smcginnis | ;) | 21:12 |
| *** eglynn has quit IRC | 21:14 | |
| *** zz_dimtruck is now known as dimtruck | 21:14 | |
| *** crushil has joined #openstack-nova | 21:14 | |
| *** moshele has quit IRC | 21:15 | |
| cdent | diana_clarke: I want to subscribe to your newsletter | 21:15 |
| *** eglynn has joined #openstack-nova | 21:16 | |
| *** ijw has quit IRC | 21:16 | |
| diana_clarke | cdent: Nah... it's just a low-hanging fruit, migration 216 only, thing. Nothing much to see there. | 21:19 |
| cdent | diana_clarke I don't know, there's just something fascinating about the collected works of your commits. Not sure what it is. | 21:20 |
| *** ijw has joined #openstack-nova | 21:20 | |
| *** gouthamr has joined #openstack-nova | 21:21 | |
| diana_clarke | cdent: perhaps it's because I have no clue what openstack is, so my commits always dance around that, lol. | 21:23 |
| cdent | oh you still worry about that? yeah, apparently you're supposed to stop worrying about that and just accept it | 21:23 |
| artom | diana_clarke, don't tell anyone, openstack is everything to everyone | 21:24 |
| *** delattec has joined #openstack-nova | 21:25 | |
| *** cdelatte has quit IRC | 21:26 | |
| mriedem | diana_clarke: any numbers on how much faster that makes that migration? | 21:26 |
| mriedem | i came across an open nova bug last week from tripleo about how the nova db migrations were timing them out | 21:26 |
| artom | Telcos want to orchestrate some NFV stuff, Rackspace wants a webhosting cloud, you want a job, and I want something I can use to forget the loneliness when alcohol isn't doing it | 21:26 |
| mriedem | artom: there is always opium | 21:27 |
| artom | mriedem, that's next on the list: 1. Alcohol 2. Openstack 3. Opium 4. ??? 5. Profit! | 21:27 |
| cdent | artom, that's the best description of openstack I've ever read | 21:28 |
| artom | I'll proll'y never reach 5 though | 21:28 |
| mriedem | diana_clarke: this one https://bugs.launchpad.net/nova/+bug/1661396 | 21:28 |
| openstack | Launchpad bug 1661396 in OpenStack Compute (nova) "undercloud install fails (nova-db-sync timeout) on VM on an SATA disk hypervisor" [Undecided,Incomplete] | 21:28 |
| artom | cdent, :) | 21:28 |
| dansmith | mriedem: that's ours and it's something with our setup as far as we can tell | 21:28 |
| mriedem | "This seems to be related to the switch to innodb_file_per_table to ON which has doubled the amount of time the db sync takes on this class of hardware." | 21:29 |
| *** smatzek_ has quit IRC | 21:29 | |
| diana_clarke | mriedem: It doesn't make 216 all that much faster, just a few seconds. Here are the nova db migrations, sorted slowest to fastest: http://paste.openstack.org/show/598003/ | 21:29 |
| dansmith | it's way more than double, it's like 100x or something | 21:29 |
| mriedem | heh, 267 is mine | 21:30 |
| mriedem | \o/ | 21:30 |
| mriedem | but that's also because it's scanning all of the tables | 21:31 |
| cdent | https://www.percona.com/blog/2015/02/24/mysqls-innodb_file_per_table-slowing/ | 21:31 |
| cdent | "Many of you in the audience are responsible for running automated tests on your codebase before deploying to production" | 21:31 |
| diana_clarke | mriedem: I started looking at them b/c of that tripleo bug, but honestly I don't think this will help much. Something else is up (like dansmith already said, I see now). | 21:31 |
| dansmith | yep | 21:32 |
| dansmith | but if it makes unit tests faster and doesn't alter the schema at all, then that's cool, although I'm skeptical since we cache the schema the first time we create it in the fixture | 21:32 |
| diana_clarke | dansmith: before I take the WIP off my patch, I'll do a DB dump before and after and diff them. It's already on my TODO list. | 21:33 |
| dansmith | diana_clarke: excellent, thanks | 21:33 |
| diana_clarke | mriedem: And here are the api database migration times, if you're curious. This time sorted by migration number: http://paste.openstack.org/show/598005/ | 21:34 |
| *** Jeffrey4l has quit IRC | 21:35 | |
| *** harlowja has joined #openstack-nova | 21:35 | |
| * cdent waves goodnight | 21:35 | |
| *** cdent has quit IRC | 21:36 | |
| mriedem | diana_clarke: fyi https://github.com/openstack/nova/blob/master/tools/db/schema_diff.py | 21:36 |
| mriedem | dprince wrote that when he was collapsing migrations way back when | 21:36 |
| *** Jeffrey4l has joined #openstack-nova | 21:36 | |
| diana_clarke | mriedem: ah, thanks! | 21:36 |
| *** MVenesio has quit IRC | 21:37 | |
| *** salv-orlando has joined #openstack-nova | 21:37 | |
| *** jamielennox is now known as jamielennox|away | 21:42 | |
| *** salv-orlando has quit IRC | 21:42 | |
| *** gouthamr has quit IRC | 21:45 | |
| *** catintheroof has quit IRC | 21:48 | |
| *** catintheroof has joined #openstack-nova | 21:49 | |
| *** salv-orlando has joined #openstack-nova | 21:50 | |
| *** shaner has quit IRC | 21:52 | |
| *** haypo has joined #openstack-nova | 21:53 | |
| *** haypo has joined #openstack-nova | 21:53 | |
| *** haypo has left #openstack-nova | 21:53 | |
| *** krtaylor has quit IRC | 21:54 | |
| *** catintheroof has quit IRC | 21:54 | |
| *** shaner has joined #openstack-nova | 21:54 | |
| *** adrian_otto has quit IRC | 21:59 | |
| *** tesseract has joined #openstack-nova | 21:59 | |
| *** smatzek_ has joined #openstack-nova | 22:00 | |
| *** tesseract- has joined #openstack-nova | 22:00 | |
| *** thorst_ has quit IRC | 22:01 | |
| *** ducttape_ has joined #openstack-nova | 22:02 | |
| *** thorst_ has joined #openstack-nova | 22:03 | |
| pumaranikar | sdague, can you please check https://review.openstack.org/#/c/395194/. Placement json formatter change. | 22:05 |
| *** tesseract has quit IRC | 22:07 | |
| *** tesseract- has quit IRC | 22:07 | |
| *** thorst_ has quit IRC | 22:08 | |
| *** tesseract has joined #openstack-nova | 22:08 | |
| openstackgerrit | Diana Clarke proposed openstack/nova master: Reduce the number of COMMIT & SELECT 1 statements https://review.openstack.org/430390 | 22:10 |
| *** trevormc has quit IRC | 22:11 | |
| *** ducttape_ has quit IRC | 22:13 | |
| *** thorst_ has joined #openstack-nova | 22:20 | |
| *** jheroux has quit IRC | 22:22 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor init_instance:resume_guests_state https://review.openstack.org/349582 | 22:24 |
| *** baoli has quit IRC | 22:24 | |
| *** vladikr has quit IRC | 22:24 | |
| *** baoli has joined #openstack-nova | 22:24 | |
| *** thorst_ has quit IRC | 22:25 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Changed maximum code complexity to 25 https://review.openstack.org/351176 | 22:25 |
| *** smatzek_ has quit IRC | 22:26 | |
| *** tesseract is now known as tesseract-RH | 22:26 | |
| *** edmondsw has quit IRC | 22:29 | |
| mordred | mriedem: so - I've got this question about boot from volume | 22:29 |
| *** baoli has quit IRC | 22:29 | |
| *** burgerk has quit IRC | 22:30 | |
| mordred | mriedem: http://developer.openstack.org/api-ref/compute/?expanded=create-server-detail#create-server says that block_device_mapping_v2.boot_index takes a string and also that None should be used for volumes not used as boot volumes | 22:30 |
| *** tesseract-RH is now known as tesseract | 22:31 | |
| mriedem | was just packing up... | 22:32 |
| mordred | mriedem: but we just got an error "Invalid input for field/attribute boot_index. Value: None. None is not of type 'integer" | 22:32 |
| *** ducttape_ has joined #openstack-nova | 22:32 | |
| mriedem | mordred: http://docs.openstack.org/developer/nova/block_device_mapping.html might be helpful | 22:32 |
| mordred | mriedem: yup. it also says None is valid | 22:32 |
| *** ijw has quit IRC | 22:32 | |
| mriedem | i feel like something was just recently changed in the json schema there, is this master? | 22:34 |
| mordred | dhellmann: you were doing master devstack? | 22:34 |
| *** vsaienko has quit IRC | 22:34 | |
| mordred | mriedem: I think so yeah? | 22:34 |
| dhellmann | mordred : yes, master devstack (from a few hours ago) | 22:34 |
| * mordred goes to look at json schema | 22:34 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/block_device_mapping.py#L56 | 22:34 |
| mordred | fantastic | 22:35 |
| mriedem | what's the image and dest type? | 22:36 |
| mriedem | source_type and destination_type i mean | 22:36 |
| mriedem | because https://github.com/openstack/nova/blob/master/nova/block_device.py#L198 | 22:37 |
| dhellmann | it's a qcow2 ubuntu image | 22:37 |
| mordred | destination_type would be 'volume' | 22:37 |
| mriedem | and source_type is? | 22:37 |
| mriedem | image? | 22:37 |
| dhellmann | I want to boot it ephemeral and attach a volume | 22:37 |
| mordred | yah- source_type also volume | 22:37 |
| mriedem | have you tried omitting boot_index | 22:38 |
| mriedem | ? | 22:38 |
| *** alexpilotti has joined #openstack-nova | 22:38 | |
| mordred | yes. that works | 22:38 |
| mordred | as does providing -1 or '-1' | 22:38 |
| *** alexpilo_ has quit IRC | 22:38 | |
| mordred | however, None worked in the past and is still referneced in the docs ... so maybe there's a bug somewhere, I'm just not sure what to file/write up | 22:38 |
| mordred | (we can make shade dtrt by omitting or using -1 | 22:38 |
| mriedem | oomichi: Kevin_Zheng: gmann: alex_xu: do you remember anything recently related to this? ^ | 22:39 |
| mriedem | https://review.openstack.org/#/c/410006/ | 22:39 |
| mriedem | mordred: i wouldn't put a ton of faith in the api-ref docs on this one | 22:40 |
| mordred | mriedem: ok | 22:40 |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova master: Placement api: set custom json_error_formatter in resource_class https://review.openstack.org/430463 | 22:41 |
| mriedem | i'd be interested in knowing if it's different on like a liberty install | 22:41 |
| mordred | mriedem: None worked against dreamhost - whatever version is running there | 22:41 |
| mriedem | mordred: because my guess is the wording in the api-ref was pulled from http://docs.openstack.org/developer/nova/block_device_mapping.html and that's more about the actual object code in nova rather than the API | 22:41 |
| mordred | ah - k. so it's likely just a docs bug | 22:42 |
| dhellmann | dreamhost is either mitaka or newton | 22:42 |
| *** jamielennox|away is now known as jamielennox | 22:42 | |
| mriedem | i'd file a bug either way so we can investigate | 22:42 |
| dhellmann | I can do that | 22:42 |
| mriedem | plus, if the api is ok but the docs are wrong, we can use the bug to fix the docs | 22:42 |
| mordred | cool. | 22:42 |
| mordred | thanks dhellmann ! | 22:42 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Changed maximum code complexity to 30 https://review.openstack.org/351176 | 22:43 |
| dhellmann | thanks, mordred & mriedem | 22:43 |
| mriedem | also, | 22:45 |
| mriedem | i wonder if you were hitting a nova v2 vs v2.1 endpoint before... | 22:45 |
| mriedem | v2 didn't have schema validation | 22:45 |
| mriedem | mordred: dhellmann: ^ | 22:45 |
| *** gouthamr has joined #openstack-nova | 22:45 | |
| mordred | oh - it's entirely possible | 22:45 |
| mordred | shade is (currently) just piggybacking novaclient which grabs latest microversion aiui | 22:46 |
| *** tblakes has quit IRC | 22:46 | |
| mordred | I haven't gotten to doing explicit microversion code myself | 22:46 |
| mordred | (that'll be next month - expect plenty of questions from me) | 22:46 |
| mriedem | there is where the legacy v2 api bdm v2 stuff happened https://github.com/openstack/nova/blob/liberty-eol/nova/api/openstack/compute/legacy_v2/servers.py#L424 | 22:47 |
| mriedem | which only checked boot_index here https://github.com/openstack/nova/blob/liberty-eol/nova/block_device.py#L201 | 22:47 |
| mriedem | if source_type == 'image' and destination_type == 'local': | 22:48 |
| mriedem | and then that dict was probably turned into an object https://github.com/openstack/nova/blob/liberty-eol/nova/objects/block_device.py#L73 | 22:48 |
| mriedem | where boot_index can be None | 22:48 |
| mriedem | the compute api did some validation here too https://github.com/openstack/nova/blob/liberty-eol/nova/compute/api.py#L1315 | 22:49 |
| mriedem | on the object | 22:49 |
| mriedem | SO, | 22:49 |
| mriedem | i think it just means that the v2.1 API json schema validation regressed from the v2 API validation | 22:49 |
| mriedem | would be cool if you guys could confirm that it was working when you were talking to a v2 compute endpoint cloud vs v2.1 | 22:49 |
| mriedem | but that'd be my professional opinion | 22:50 |
| mriedem | dr debug | 22:50 |
| mriedem | dhellmann: i've got to run but just throw ^ into the bug report and i'll check it out later when i'm home | 22:51 |
| dhellmann | mriedem : ok | 22:51 |
| dhellmann | mriedem : I am currently working my way through the rather long instructions for filing a nova bug | 22:51 |
| *** mriedem has quit IRC | 22:51 | |
| *** eharney has quit IRC | 22:51 | |
| *** jogo has joined #openstack-nova | 22:56 | |
| dhellmann | mriedem: https://bugs.launchpad.net/nova/+bug/1662699 | 22:56 |
| openstack | Launchpad bug 1662699 in OpenStack Compute (nova) "API documentation and behavior do not match for booting with attached volumes" [Undecided,New] | 22:56 |
| *** ducttape_ has quit IRC | 22:56 | |
| *** Swami has quit IRC | 22:57 | |
| *** edmondsw has joined #openstack-nova | 22:59 | |
| *** esberglu has quit IRC | 23:00 | |
| *** esberglu has joined #openstack-nova | 23:00 | |
| *** tesseract has quit IRC | 23:00 | |
| *** tesseract has joined #openstack-nova | 23:00 | |
| *** tesseract-RH has joined #openstack-nova | 23:01 | |
| *** esberglu has quit IRC | 23:01 | |
| *** tesseract has quit IRC | 23:01 | |
| *** tesseract-RH has quit IRC | 23:01 | |
| Daviey | dhellmann: I *think* that might have been the same issue i saw when using Packer with volumes. Had to change Packer's usage with Volumes | 23:02 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - servers.py https://review.openstack.org/359861 | 23:02 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - manager.py https://review.openstack.org/359868 | 23:02 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - linux_net.py https://review.openstack.org/359871 | 23:02 |
| dhellmann | Daviey : yeah, it's a behavior change but it's not clear if it's a bug and if so where (code or docs) | 23:03 |
| *** edmondsw has quit IRC | 23:04 | |
| *** jamesdenton has quit IRC | 23:06 | |
| *** fragatina has joined #openstack-nova | 23:07 | |
| *** lpetrut has quit IRC | 23:07 | |
| *** mdrabe has quit IRC | 23:09 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance-exists notification https://review.openstack.org/403660 | 23:11 |
| *** sdague has quit IRC | 23:12 | |
| *** ijw has joined #openstack-nova | 23:14 | |
| *** ijw has quit IRC | 23:16 | |
| *** esberglu has joined #openstack-nova | 23:16 | |
| *** esberglu has quit IRC | 23:18 | |
| *** tlian has quit IRC | 23:26 | |
| *** zhurong has joined #openstack-nova | 23:26 | |
| *** zhurong has quit IRC | 23:28 | |
| *** xinli has quit IRC | 23:28 | |
| *** dimtruck is now known as zz_dimtruck | 23:33 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add an update_cell command to nova-manage https://review.openstack.org/430354 | 23:35 |
| *** ducttape_ has joined #openstack-nova | 23:40 | |
| *** tlian has joined #openstack-nova | 23:42 | |
| *** tbachman has quit IRC | 23:42 | |
| *** Swami has joined #openstack-nova | 23:44 | |
| *** Swami has quit IRC | 23:45 | |
| *** baoli has joined #openstack-nova | 23:45 | |
| *** ducttape_ has quit IRC | 23:50 | |
| *** ducttape_ has joined #openstack-nova | 23:51 | |
| *** unicell has quit IRC | 23:52 | |
| *** karimb has quit IRC | 23:54 | |
| *** tbachman has joined #openstack-nova | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!