Thursday, 2016-01-14

*** Daisy has quit IRC00:00
*** _diana_1 has quit IRC00:00
*** haomaiwang has quit IRC00:01
*** haomaiwang has joined #openstack-nova00:01
*** zhangjn has joined #openstack-nova00:03
*** aginwala has joined #openstack-nova00:03
*** pratikmallya has quit IRC00:03
*** carey has joined #openstack-nova00:03
*** ssurana has quit IRC00:05
*** armax has quit IRC00:05
*** dougs1 has quit IRC00:06
*** dougs has joined #openstack-nova00:06
*** nic has quit IRC00:08
*** carey has quit IRC00:08
*** nic has joined #openstack-nova00:09
*** akshai has quit IRC00:09
*** moshele has quit IRC00:12
*** zhangjn has quit IRC00:14
*** mnestratov has quit IRC00:15
*** _diana_1 has joined #openstack-nova00:18
*** _diana_1 is now known as diana_clarke00:18
*** akshai has joined #openstack-nova00:20
openstackgerritNicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available  https://review.openstack.org/20528200:20
*** akshai has quit IRC00:25
*** irenab_ has joined #openstack-nova00:30
*** salv-orl_ has quit IRC00:31
*** irenab has quit IRC00:33
*** irenab_ is now known as irenab00:33
*** salv-orlando has joined #openstack-nova00:34
*** carey has joined #openstack-nova00:35
*** otter768 has joined #openstack-nova00:36
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Add maximum microversions for each releases  https://review.openstack.org/26724700:36
*** Sukhdev has joined #openstack-nova00:38
*** armax has joined #openstack-nova00:39
*** otter768 has quit IRC00:41
openstackgerritRyan Rossiter proposed openstack/nova: Use get_notification_transport() for notifications  https://review.openstack.org/26696000:42
openstackgerritRyan Rossiter proposed openstack/nova: Add tests for nova.rpc module  https://review.openstack.org/26724800:42
*** ssurana has joined #openstack-nova00:44
*** salv-orlando has quit IRC00:45
*** dims has quit IRC00:45
*** Sukhdev has quit IRC00:46
*** salv-orlando has joined #openstack-nova00:46
openstackgerritRyan Rossiter proposed openstack/nova: Add helper shim for getting items  https://review.openstack.org/26599500:53
openstackgerritRyan Rossiter proposed openstack/nova: Remove DictCompat from ComputeNode  https://review.openstack.org/26552100:53
*** edmondsw has quit IRC00:55
*** zhangjn has joined #openstack-nova00:57
*** gtt116__ has quit IRC00:58
*** haomaiwang has quit IRC01:01
*** haomaiwang has joined #openstack-nova01:01
*** tonytan4ever has quit IRC01:04
*** rk4n has joined #openstack-nova01:04
*** thorst has quit IRC01:04
*** thorst has joined #openstack-nova01:05
*** zhangjn_ has joined #openstack-nova01:05
*** zhangjn_ has quit IRC01:06
*** zhangjn has quit IRC01:07
*** zhangjn has joined #openstack-nova01:08
*** nic has quit IRC01:09
*** tonytan4ever has joined #openstack-nova01:10
*** zhangjn has quit IRC01:11
*** aginwala has quit IRC01:12
*** thorst has quit IRC01:13
*** browne has quit IRC01:13
*** EinstCrazy has joined #openstack-nova01:14
tangchen__Hi oomichi, alex_xu, I have made this patch pass the CI tests. Please help to review when you are free. Thanks a lot.  https://review.openstack.org/#/c/20261701:15
*** wasmum has joined #openstack-nova01:15
*** rk4n has quit IRC01:16
*** liusheng has joined #openstack-nova01:18
*** rk4n has joined #openstack-nova01:19
*** gongysh_ has quit IRC01:20
*** zhangjn has joined #openstack-nova01:20
*** zhangjn has quit IRC01:22
*** zhangjn has joined #openstack-nova01:23
*** rk4n has quit IRC01:23
*** jasondotstar has quit IRC01:24
*** dims has joined #openstack-nova01:24
*** ssurana has quit IRC01:25
*** zhangjn has quit IRC01:27
*** oomichi_away has quit IRC01:28
*** jasondotstar has joined #openstack-nova01:29
*** rfolco has joined #openstack-nova01:30
*** aginwala has joined #openstack-nova01:30
*** Sukhdev has joined #openstack-nova01:32
*** haomaiwang has quit IRC01:32
*** 14WAAOU1P has joined #openstack-nova01:33
*** zhangjn has joined #openstack-nova01:35
*** shuquan has joined #openstack-nova01:36
*** rfolco has quit IRC01:43
*** aginwala has quit IRC01:44
*** aginwala has joined #openstack-nova01:47
*** suro-patz has quit IRC01:47
*** Jeffrey4l has joined #openstack-nova01:48
*** yonglihe has joined #openstack-nova01:48
*** doug-fish has quit IRC01:48
*** mtanino has quit IRC01:49
openstackgerritJacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli  https://review.openstack.org/26669001:52
*** ljxiash has quit IRC01:52
*** jdurgin1 has quit IRC01:53
openstackgerritTakashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(1/5)  https://review.openstack.org/26139901:53
*** gjayavelu has quit IRC01:54
*** zhangjn has quit IRC01:54
*** EinstCrazy has quit IRC01:57
*** smoriya__ has joined #openstack-nova01:57
*** shuquan has quit IRC01:57
*** ljxiash has joined #openstack-nova01:57
*** yamahata has joined #openstack-nova01:58
*** Sukhdev has quit IRC01:58
*** smoriya_ has quit IRC01:59
*** EinstCrazy has joined #openstack-nova01:59
*** 14WAAOU1P has quit IRC02:01
*** haomaiwang has joined #openstack-nova02:01
*** shuquan has joined #openstack-nova02:01
*** vilobhmm11 has quit IRC02:05
*** thumpba has joined #openstack-nova02:10
*** lyanchih has joined #openstack-nova02:10
*** thorst has joined #openstack-nova02:11
*** gongysh has quit IRC02:12
*** ijw has quit IRC02:12
*** gongysh has joined #openstack-nova02:12
openstackgerritJacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli  https://review.openstack.org/26669002:13
*** EinstCra_ has joined #openstack-nova02:13
*** zhangjn has joined #openstack-nova02:16
*** browne has joined #openstack-nova02:16
*** EinstCrazy has quit IRC02:16
*** takashin has joined #openstack-nova02:16
*** thorst has quit IRC02:18
*** boris-42 has joined #openstack-nova02:18
*** tonytan4ever has quit IRC02:20
*** zhangjn has quit IRC02:20
*** aginwala has quit IRC02:22
*** zhangjn has joined #openstack-nova02:26
*** aginwala has joined #openstack-nova02:27
*** dims has quit IRC02:29
*** armax has quit IRC02:29
*** SourabhP has joined #openstack-nova02:30
*** ljxiash has quit IRC02:30
*** ljxiash has joined #openstack-nova02:31
*** thumpba has quit IRC02:32
*** thorst has joined #openstack-nova02:32
*** thorst has quit IRC02:34
*** ljxiash has quit IRC02:35
*** houming has joined #openstack-nova02:35
*** shyama has joined #openstack-nova02:36
*** otter768 has joined #openstack-nova02:36
*** ducttape_ has joined #openstack-nova02:37
*** zhangjn has quit IRC02:37
*** Jeffrey4l has quit IRC02:38
tangchen__Hi alex_xu, about the sample_dir = 'servers' thing, if I don't add this line, the CI won't pass because it won't search the files under servers dir.02:38
*** Jeffrey4l has joined #openstack-nova02:38
alex_xutangchen__: emm...let me check the code02:38
tangchen__alex_xu: I'm not sure if I made any mistake somewhere else.02:39
tangchen__alex_xu: I'll try again, and if I met the error, I will show you. Thx. :)02:39
alex_xutangchen__: cool, thanks :)02:39
*** apoorvad has quit IRC02:40
alex_xutangchen__: just note, you can test that locally with `tox -e functional`02:40
*** josecastroleon has quit IRC02:41
*** otter768 has quit IRC02:41
*** thumpba has joined #openstack-nova02:42
*** ducttape_ has quit IRC02:42
*** josecastroleon has joined #openstack-nova02:42
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli  https://review.openstack.org/26668702:43
*** zhangjn has joined #openstack-nova02:43
*** ducttape_ has joined #openstack-nova02:43
*** zhangjn has quit IRC02:44
*** erlon has quit IRC02:46
*** shuquan has quit IRC02:48
*** gtt116 has joined #openstack-nova02:49
*** gongysh_ has joined #openstack-nova02:50
*** artom_ has joined #openstack-nova02:50
*** shuquan has joined #openstack-nova02:51
*** davideag_ has joined #openstack-nova02:51
*** andrearo1 has joined #openstack-nova02:51
*** szaher__ has joined #openstack-nova02:52
*** crinkle_ has joined #openstack-nova02:52
*** tziarko_ has joined #openstack-nova02:52
*** masayukig has quit IRC02:52
*** _fortis has quit IRC02:52
*** mkoderer has quit IRC02:52
*** dulek has quit IRC02:52
openstackgerritEli Qiao proposed openstack/nova: Calculate block_migration in virt drivers if it's None  https://review.openstack.org/25410102:52
openstackgerritEli Qiao proposed openstack/nova: Return host and block_migration in task_api._execute()  https://review.openstack.org/25410202:52
*** ekarlso has quit IRC02:52
*** davideagnello has quit IRC02:52
*** maurosr has quit IRC02:52
*** tziarko has quit IRC02:52
*** mikal has quit IRC02:52
*** egarbade- has quit IRC02:52
*** andrearosa has quit IRC02:52
*** ccard_ has quit IRC02:52
*** crinkle has quit IRC02:52
*** artom has quit IRC02:53
*** aarefiev has quit IRC02:53
*** szaher_ has quit IRC02:53
*** mikal has joined #openstack-nova02:53
*** aarefiev has joined #openstack-nova02:53
*** egarbade- has joined #openstack-nova02:53
*** masayukig has joined #openstack-nova02:53
*** maurosr has joined #openstack-nova02:53
*** dulek has joined #openstack-nova02:54
*** mkoderer has joined #openstack-nova02:54
*** shuquan has quit IRC02:55
*** ccard_ has joined #openstack-nova02:55
*** _fortis has joined #openstack-nova02:56
tangchen__alex_xu: Yes, I have done that successfully yesterday.02:56
*** shuquan has joined #openstack-nova02:58
*** dims has joined #openstack-nova02:58
*** ducttape_ has quit IRC02:59
*** haomaiwang has quit IRC03:01
alex_xutangchen__: cool :)03:01
*** dims_ has joined #openstack-nova03:01
*** haomaiwa_ has joined #openstack-nova03:01
*** baoli has joined #openstack-nova03:02
*** unicell1 has quit IRC03:03
*** zhangjn has joined #openstack-nova03:03
*** dims has quit IRC03:03
*** haomaiwa_ has quit IRC03:04
*** diogogmt has joined #openstack-nova03:04
*** ekarlso has joined #openstack-nova03:05
*** crinkle_ is now known as crinkle03:08
*** aginwala has quit IRC03:09
*** zhangjn has quit IRC03:12
*** suro-patz has joined #openstack-nova03:13
*** thumpba has quit IRC03:13
*** aginwala has joined #openstack-nova03:14
*** thumpba has joined #openstack-nova03:16
*** aginwala has quit IRC03:16
*** zhangjn has joined #openstack-nova03:17
*** thumpba has quit IRC03:17
*** links has joined #openstack-nova03:17
*** ljxiash has joined #openstack-nova03:20
*** shuquan has quit IRC03:22
openstackgerritDiana Clarke proposed openstack/nova: Replace stubs.Set with stub_out (fakes)  https://review.openstack.org/26508203:23
*** shuquan has joined #openstack-nova03:25
*** thumpba has joined #openstack-nova03:26
*** thumpba has quit IRC03:28
*** thumpba has joined #openstack-nova03:28
*** daemontool has quit IRC03:30
*** oomichi has joined #openstack-nova03:30
*** zhangjn has quit IRC03:31
*** coolsvap|away is now known as coolsvap03:36
*** shuquan has quit IRC03:39
*** zhihais has quit IRC03:41
*** zhihais has joined #openstack-nova03:42
*** shuquan has joined #openstack-nova03:42
*** yamahata has quit IRC03:43
*** ljxiash has quit IRC03:45
*** ljxiash has joined #openstack-nova03:45
*** ljxiash has quit IRC03:49
openstackgerritTakashi NATSUME proposed openstack/nova: Add swap volume notifications  https://review.openstack.org/25028303:53
*** browne1 has joined #openstack-nova03:57
*** browne has quit IRC04:00
*** vilobhmm11 has joined #openstack-nova04:02
*** lyanchih has quit IRC04:08
*** ducttape_ has joined #openstack-nova04:09
*** salv-orl_ has joined #openstack-nova04:10
*** salv-orlando has quit IRC04:12
*** EinstCra_ has quit IRC04:13
*** EinstCrazy has joined #openstack-nova04:13
*** ducttape_ has quit IRC04:14
*** thumpba has quit IRC04:15
*** suro-patz has quit IRC04:20
*** zz_dimtruck is now known as dimtruck04:21
*** liusheng has quit IRC04:24
*** thumpba has joined #openstack-nova04:28
*** Marga_ has quit IRC04:28
*** dims_ has quit IRC04:30
*** Sukhdev has joined #openstack-nova04:33
*** zenoway has joined #openstack-nova04:35
*** mragupat has joined #openstack-nova04:35
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix support customer ip protocol when create security-rule using nova-cli  https://review.openstack.org/26668704:36
*** otter768 has joined #openstack-nova04:37
*** zenoway has quit IRC04:39
*** dimtruck is now known as zz_dimtruck04:40
*** otter768 has quit IRC04:42
*** Marga_ has joined #openstack-nova04:44
*** thumpba has quit IRC04:44
*** RA_ has joined #openstack-nova04:46
*** Marga_ has quit IRC04:48
openstackgerritRushi Agrawal proposed openstack/nova: Remove almost all mox from tests/unit/objects/test_instance.py  https://review.openstack.org/26429204:50
*** vilobhmm11 has quit IRC04:53
*** vilobhmm11 has joined #openstack-nova04:54
*** vilobhmm11 has quit IRC04:54
*** thumpba has joined #openstack-nova04:54
*** EinstCrazy has quit IRC04:57
*** shuquan has quit IRC04:58
openstackgerritTakashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(2/5)  https://review.openstack.org/26140104:58
*** oomichi is now known as oomichi_away04:58
*** vilobhmm11 has joined #openstack-nova05:00
*** EinstCrazy has joined #openstack-nova05:01
*** armax has joined #openstack-nova05:06
*** unicell has joined #openstack-nova05:06
*** vivekd has joined #openstack-nova05:08
*** lyanchih has joined #openstack-nova05:09
*** oomichi_away has quit IRC05:10
*** zenoway has joined #openstack-nova05:10
*** ljxiash has joined #openstack-nova05:11
*** zenoway has quit IRC05:14
*** haomaiwang has joined #openstack-nova05:16
*** pradipta has joined #openstack-nova05:17
*** zhangjn has joined #openstack-nova05:22
*** baoli has quit IRC05:22
*** SourabhP has quit IRC05:22
*** lyanchih has quit IRC05:24
*** zhangjn has quit IRC05:27
*** zhangjn has joined #openstack-nova05:28
*** jwcroppe has joined #openstack-nova05:29
*** thumpba has quit IRC05:30
*** zhangjn has quit IRC05:32
*** zhangjn has joined #openstack-nova05:41
*** thumpba has joined #openstack-nova05:41
*** SourabhP has joined #openstack-nova05:42
*** zhangjn has quit IRC05:45
*** artom_ has quit IRC05:47
*** artom_ has joined #openstack-nova05:47
*** moshele has joined #openstack-nova05:50
*** zhangjn has joined #openstack-nova05:50
*** zhangjn has quit IRC05:53
*** jaosorior has joined #openstack-nova05:54
*** SourabhP_ has joined #openstack-nova05:54
*** vilobhmm11 has quit IRC05:54
*** SourabhP has quit IRC05:54
*** SourabhP_ is now known as SourabhP05:54
*** vilobhmm11 has joined #openstack-nova05:55
*** shuquan has joined #openstack-nova05:56
*** haomaiwa_ has joined #openstack-nova05:56
*** haomaiwang has quit IRC05:56
*** brad[] has quit IRC05:57
*** zhangjn has joined #openstack-nova05:59
*** zhangjn has quit IRC06:00
*** haomaiwa_ has quit IRC06:01
*** haomaiwang has joined #openstack-nova06:01
*** suro-patz has joined #openstack-nova06:01
*** lyanchih has joined #openstack-nova06:02
*** vivekd has quit IRC06:03
*** RA_ has quit IRC06:04
*** unicell1 has joined #openstack-nova06:05
*** unicell has quit IRC06:06
*** shuquan has quit IRC06:08
*** shuquan has joined #openstack-nova06:10
*** zhangjn has joined #openstack-nova06:12
*** thumpba has quit IRC06:14
*** aginwala has joined #openstack-nova06:14
*** zhangjn has quit IRC06:15
*** brad[] has joined #openstack-nova06:15
*** zhangjn has joined #openstack-nova06:16
*** zhangjn has quit IRC06:18
*** yamahata has joined #openstack-nova06:19
*** zhangjn has joined #openstack-nova06:19
*** zhangjn has quit IRC06:20
*** aginwala_ has joined #openstack-nova06:23
*** zhangjn has joined #openstack-nova06:25
*** thumpba has joined #openstack-nova06:25
*** aginwala has quit IRC06:26
*** aginwala has joined #openstack-nova06:27
*** aginwala_ has quit IRC06:30
*** gangil has quit IRC06:31
*** SourabhP has quit IRC06:33
*** rotbeard has quit IRC06:33
*** vivekd has joined #openstack-nova06:37
*** otter768 has joined #openstack-nova06:38
*** nkrinner has joined #openstack-nova06:38
openstackgerritesracelik proposed openstack/nova: Config options: centralize "configdrive" options  https://review.openstack.org/25409206:39
*** zhangjn has quit IRC06:42
*** markvoelker has quit IRC06:42
*** jaosorior has quit IRC06:42
*** otter768 has quit IRC06:43
*** jaosorior has joined #openstack-nova06:43
*** aginwala has quit IRC06:43
*** yamahata has quit IRC06:43
*** aginwala has joined #openstack-nova06:43
*** jaosorior has quit IRC06:45
*** jaosorior has joined #openstack-nova06:46
*** sahid has joined #openstack-nova06:48
*** armax has quit IRC06:48
*** sahid has quit IRC06:49
*** armax has joined #openstack-nova06:49
*** sahid has joined #openstack-nova06:49
*** gsilvis has quit IRC06:50
*** edtubill has joined #openstack-nova06:51
*** zenoway has joined #openstack-nova06:51
openstackgerritEric Brown proposed openstack/nova: Fix config option types  https://review.openstack.org/16848106:51
*** edtubill has quit IRC06:52
*** browne1 has quit IRC06:52
*** amotoki_ has joined #openstack-nova06:52
*** amotoki_ has quit IRC06:52
*** gongysh_ has quit IRC06:53
*** jwcroppe has quit IRC06:56
*** shuquan has quit IRC06:57
*** vishwana_ is now known as vishwanathj07:00
*** haomaiwang has quit IRC07:01
*** vishwanathj is now known as vishwanathj_good07:01
*** vishwanathj_good is now known as vishwanathj_slee07:01
*** vishwanathj_slee is now known as vishwanathj_nap07:01
*** haomaiwang has joined #openstack-nova07:01
*** vishwanathj_nap is now known as vishwanathj_away07:01
openstackgerritesracelik proposed openstack/nova: Improve the help text for configdrive options  https://review.openstack.org/26687507:06
*** liusheng has joined #openstack-nova07:06
*** gjayavelu has joined #openstack-nova07:07
*** dedery has joined #openstack-nova07:08
*** mjura has joined #openstack-nova07:09
openstackgerritTakashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(3/5)  https://review.openstack.org/26140507:09
*** dedery_ has joined #openstack-nova07:10
*** gjayavelu has quit IRC07:11
*** gjayavelu has joined #openstack-nova07:11
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata  https://review.openstack.org/26560107:11
*** oomichi has joined #openstack-nova07:12
*** dedery has quit IRC07:12
openstackgerritSergey Nikitin proposed openstack/nova: enginefacade: 'quota' and 'reservation'  https://review.openstack.org/26054907:14
openstackgerritSergey Nikitin proposed openstack/nova: enginefacade: 'instance_group'  https://review.openstack.org/26131607:14
tojuvoneoomichi: Hi, there.07:14
*** daemontool has joined #openstack-nova07:14
oomichitojuvone: hey07:14
tojuvoneoomichi: Do you have some time to look at this once more: https://review.openstack.org/241562/07:15
*** diana_clarke has quit IRC07:15
*** thumpba has quit IRC07:16
oomichitojuvone: ok, will review it later :)07:16
tojuvoneoomichi: Thanks. No major changes, it should be ready now :)07:17
*** gsilvis has joined #openstack-nova07:18
*** shuquan has joined #openstack-nova07:18
*** gjayavelu has quit IRC07:19
*** daemontool has quit IRC07:22
*** paul-carlton2 has joined #openstack-nova07:22
*** cfriesen has quit IRC07:26
*** thumpba has joined #openstack-nova07:26
*** gtt116 has quit IRC07:26
*** gtt116 has joined #openstack-nova07:27
openstackgerritSergey Nikitin proposed openstack/nova: enginefacade: 'fixed_ip'  https://review.openstack.org/24081107:27
openstackgerritSergey Nikitin proposed openstack/nova: enginefacade: 'instance'  https://review.openstack.org/24414607:27
openstackgerritSergey Nikitin proposed openstack/nova: enginefacade: 'security_group'  https://review.openstack.org/24630207:27
*** lpetrut has joined #openstack-nova07:27
openstackgerritTakashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(4/5)  https://review.openstack.org/26140707:29
openstackgerritSergey Nikitin proposed openstack/nova: enginefacade: 'floating_ip'  https://review.openstack.org/24051307:30
*** ijw has joined #openstack-nova07:33
*** aginwala has quit IRC07:34
*** gongysh_ has joined #openstack-nova07:37
*** suro-patz has quit IRC07:38
openstackgerritRen Qiaowei proposed openstack/nova: enable uefi boot for x86_64  https://review.openstack.org/26293007:38
openstackgerritTakashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(5/5)  https://review.openstack.org/26141007:41
*** mragupat has quit IRC07:42
openstackgerritesracelik proposed openstack/nova: Config options: centralize section "hyperv"  https://review.openstack.org/25512407:48
*** Sukhdev has quit IRC07:49
*** markus_z has joined #openstack-nova07:49
*** salv-orl_ has quit IRC07:53
*** salv-orlando has joined #openstack-nova07:53
*** szhsong has joined #openstack-nova07:54
*** belmoreira has joined #openstack-nova07:55
openstackgerritWen Zhi Yu proposed openstack/nova: Clean up network resources when reschedule fails  https://review.openstack.org/24347707:55
*** zhihais has quit IRC07:57
openstackgerritAlex Xu proposed openstack/nova: doc: remove the detail about extensions and point to microversions  https://review.openstack.org/26737007:57
*** szhsong has quit IRC08:00
*** otter768 has joined #openstack-nova08:00
*** haomaiwang has quit IRC08:01
*** haomaiwang has joined #openstack-nova08:01
*** otter768 has quit IRC08:02
*** otter768_ has joined #openstack-nova08:02
*** shuquan has quit IRC08:03
*** otter768_ has quit IRC08:04
*** otter768 has joined #openstack-nova08:04
*** jaosorior has quit IRC08:05
*** otter768 has quit IRC08:05
*** otter768 has joined #openstack-nova08:06
*** shuquan has joined #openstack-nova08:06
*** shuquan has quit IRC08:06
openstackgerritDao Cong Tien proposed openstack/nova-specs: Ironic serial console support  https://review.openstack.org/26737108:08
*** otter768_ has joined #openstack-nova08:08
*** matrohon has joined #openstack-nova08:08
*** otter768_ has quit IRC08:09
*** shuquan has joined #openstack-nova08:09
*** otter768_ has joined #openstack-nova08:10
*** otter768 has quit IRC08:10
*** otter768_ has quit IRC08:11
*** otter768 has joined #openstack-nova08:12
*** otter768_ has joined #openstack-nova08:13
*** otter768 has quit IRC08:13
*** RA_ has joined #openstack-nova08:14
*** otter768_ has quit IRC08:15
*** otter768 has joined #openstack-nova08:15
*** paul-carlton2 has quit IRC08:17
*** otter768_ has joined #openstack-nova08:17
*** otter768 has quit IRC08:17
*** zakora has joined #openstack-nova08:18
*** otter768_ has quit IRC08:19
*** otter768 has joined #openstack-nova08:19
*** otter768_ has joined #openstack-nova08:21
*** shuquan has quit IRC08:22
*** oomichi is now known as oomich_away08:22
*** otter76__ has joined #openstack-nova08:23
*** otter768_ has quit IRC08:23
*** rdopiera has joined #openstack-nova08:23
*** jaosorior has joined #openstack-nova08:24
*** otter768 has quit IRC08:24
openstackgerritDao Cong Tien proposed openstack/nova: [WIP] Ironic serial console support  https://review.openstack.org/26738408:25
*** shuquan has joined #openstack-nova08:25
*** otter768 has joined #openstack-nova08:25
*** otter76__ has quit IRC08:25
*** rdopiera has quit IRC08:27
*** otter768_ has joined #openstack-nova08:27
*** rdopiera has joined #openstack-nova08:27
*** shuquan has quit IRC08:27
*** andrearo1 is now known as andrearosa08:28
*** zhangjn has joined #openstack-nova08:28
openstackgerritMarian Horban proposed openstack/nova: Restart of nova-compute service fixed  https://review.openstack.org/25844108:28
*** otter768 has quit IRC08:29
*** otter76__ has joined #openstack-nova08:29
openstackgerritPawel Koniszewski proposed openstack/nova: Finish post live migration even when exception occurs  https://review.openstack.org/23599408:29
*** thumpba has quit IRC08:30
*** otter768 has joined #openstack-nova08:31
*** otter768_ has quit IRC08:32
*** paul-carlton2 has joined #openstack-nova08:32
*** shuquan has joined #openstack-nova08:32
*** otter768_ has joined #openstack-nova08:32
*** otter76__ has quit IRC08:33
*** lpetrut has quit IRC08:33
openstackgerritesracelik proposed openstack/nova: Config options: centralize section "cells"  https://review.openstack.org/26018108:33
*** otter76__ has joined #openstack-nova08:34
*** otter768_ has quit IRC08:34
*** otter768 has quit IRC08:35
*** shuquan has quit IRC08:35
*** shuquan has joined #openstack-nova08:36
*** otter768 has joined #openstack-nova08:36
*** MCoLo has joined #openstack-nova08:36
*** otter76__ has quit IRC08:36
*** zhangjn has quit IRC08:37
*** otter768 has quit IRC08:38
*** otter768 has joined #openstack-nova08:38
*** jichen has joined #openstack-nova08:40
*** ijw has quit IRC08:40
*** jlanoux has joined #openstack-nova08:40
*** jlanoux has quit IRC08:40
*** otter768 has quit IRC08:40
*** otter768_ has joined #openstack-nova08:40
*** vilobhmm11 has quit IRC08:41
*** jlanoux has joined #openstack-nova08:41
openstackgerritAndrey Pavlov proposed openstack/nova: remove EC2 legacy code  https://review.openstack.org/26642508:42
*** otter768 has joined #openstack-nova08:42
*** otter768_ has quit IRC08:42
*** markvoelker has joined #openstack-nova08:43
*** otter768 has quit IRC08:44
*** otter768 has joined #openstack-nova08:44
*** coolsvap is now known as coolsvap|away08:44
*** otter768 has quit IRC08:45
*** otter768 has joined #openstack-nova08:46
*** otter768 has quit IRC08:47
*** markvoelker has quit IRC08:48
*** otter768 has joined #openstack-nova08:48
*** e0ne has joined #openstack-nova08:48
*** scheuran has joined #openstack-nova08:49
*** otter768_ has joined #openstack-nova08:50
*** RA_ has quit IRC08:51
*** otter768_ has quit IRC08:52
*** otter76__ has joined #openstack-nova08:52
*** otter768 has quit IRC08:52
*** otter76__ has quit IRC08:54
*** otter768 has joined #openstack-nova08:54
*** otter768 has quit IRC08:56
*** otter768_ has joined #openstack-nova08:56
*** derekh has joined #openstack-nova08:57
*** salv-orlando has quit IRC08:57
*** otter768 has joined #openstack-nova08:57
*** otter768_ has quit IRC08:58
*** salv-orlando has joined #openstack-nova08:58
*** paul-carlton2 has quit IRC08:59
*** otter768 has quit IRC08:59
*** otter768 has joined #openstack-nova08:59
*** tpatzig has joined #openstack-nova09:00
*** haomaiwang has quit IRC09:01
*** otter768 has quit IRC09:01
*** haomaiwang has joined #openstack-nova09:01
*** jistr has joined #openstack-nova09:03
*** otter768 has joined #openstack-nova09:03
*** otter768 has quit IRC09:05
*** otter768 has joined #openstack-nova09:05
*** salv-orlando has quit IRC09:05
*** salv-orlando has joined #openstack-nova09:05
*** otter768_ has joined #openstack-nova09:07
*** zenoway has quit IRC09:09
*** otter768_ has quit IRC09:09
*** otter76__ has joined #openstack-nova09:09
*** klkumar has joined #openstack-nova09:09
*** zenoway has joined #openstack-nova09:09
*** otter768 has quit IRC09:10
tdurakovhi everyone09:10
*** otter76__ has quit IRC09:10
*** otter768 has joined #openstack-nova09:11
*** scheuran has quit IRC09:11
*** ndipanov has joined #openstack-nova09:12
*** otter768_ has joined #openstack-nova09:13
*** otter768 has quit IRC09:13
*** zhangjn has joined #openstack-nova09:13
*** zenoway has quit IRC09:14
*** otter768 has joined #openstack-nova09:15
*** yassine_ has joined #openstack-nova09:15
*** dank_ has quit IRC09:15
*** otter768_ has quit IRC09:15
*** yamahata has joined #openstack-nova09:15
*** shuquan has quit IRC09:15
*** zhangjn has quit IRC09:16
*** otter768 has quit IRC09:17
*** otter768_ has joined #openstack-nova09:17
*** shuquan has joined #openstack-nova09:17
*** ig0r_ has joined #openstack-nova09:17
*** atuvenie has joined #openstack-nova09:17
*** shuquan has quit IRC09:17
*** otter768_ has quit IRC09:18
*** jamielennox is now known as jamielennox|away09:18
*** otter768 has joined #openstack-nova09:19
*** shuquan has joined #openstack-nova09:19
openstackgerritTobias Urdin proposed openstack/nova: Fix evaluation of host disk usage by volume-backed instances  https://review.openstack.org/20087009:19
*** zenoway has joined #openstack-nova09:20
*** otter768 has quit IRC09:20
*** otter768_ has joined #openstack-nova09:20
*** daemontool has joined #openstack-nova09:23
*** mgoddard has joined #openstack-nova09:24
*** otter768 has joined #openstack-nova09:24
*** otter768_ has quit IRC09:25
openstackgerritsahid proposed openstack/os-vif: introduce vif.Config  https://review.openstack.org/26676809:25
*** otter768 has quit IRC09:26
*** otter768 has joined #openstack-nova09:26
*** ihrachys has joined #openstack-nova09:27
*** otter768_ has joined #openstack-nova09:28
*** paul-carlton2 has joined #openstack-nova09:29
*** otter768_ has quit IRC09:30
*** otter768_ has joined #openstack-nova09:30
openstackgerritBalazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications  https://review.openstack.org/26378809:31
openstackgerritBalazs Gibizer proposed openstack/nova: Add service status notification  https://review.openstack.org/24567809:31
openstackgerritBalazs Gibizer proposed openstack/nova: Generate doc for versioned notifications  https://review.openstack.org/26515109:31
*** otter768 has quit IRC09:31
openstackgerritBalazs Gibizer proposed openstack/nova: Add infra for versioned notifications  https://review.openstack.org/24702409:31
openstackgerritBalazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications  https://review.openstack.org/24816709:31
openstackgerritBalazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable  https://review.openstack.org/24756409:31
*** otter768_ has quit IRC09:32
*** otter768 has joined #openstack-nova09:32
openstackgerritTimofey Durakov proposed openstack/nova: Ceph for live-migration job  https://review.openstack.org/25228309:32
*** otter768 has quit IRC09:34
*** otter768_ has joined #openstack-nova09:34
*** femnad has joined #openstack-nova09:35
*** otter768_ has quit IRC09:35
*** gcb has quit IRC09:35
openstackgerritSayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name  https://review.openstack.org/26335309:36
*** otter768 has joined #openstack-nova09:36
*** otter768 has quit IRC09:37
*** otter768_ has joined #openstack-nova09:38
*** thumpba has joined #openstack-nova09:38
*** oomich_away is now known as oomich09:39
*** otter768 has joined #openstack-nova09:39
*** otter768_ has quit IRC09:40
*** sfinucan has joined #openstack-nova09:40
*** lpetrut has joined #openstack-nova09:40
*** ijw has joined #openstack-nova09:40
*** danpb has joined #openstack-nova09:41
*** ig0r_ has quit IRC09:41
*** otter768 has quit IRC09:41
*** otter768 has joined #openstack-nova09:42
openstackgerritPavel Kholkin proposed openstack/nova: fixed log warning in sqlalchemy/api.py  https://review.openstack.org/24690109:43
*** otter768 has quit IRC09:43
*** otter768 has joined #openstack-nova09:43
openstackgerritDina Belova proposed openstack/nova: Integrate OSprofiler and Nova  https://review.openstack.org/25470309:44
*** markvoelker has joined #openstack-nova09:44
*** RA_ has joined #openstack-nova09:45
*** otter768_ has joined #openstack-nova09:45
*** ijw has quit IRC09:45
*** otter76__ has joined #openstack-nova09:47
*** otter768_ has quit IRC09:47
*** shuquan_ has joined #openstack-nova09:47
*** otter768 has quit IRC09:48
sfinucanMorning, markus_z09:48
markus_zsfinucan: hey hey, how's it going?09:48
*** shuquan has quit IRC09:48
*** shuquan_ is now known as shuquan09:48
*** thumpba has quit IRC09:48
sfinucanmarkus_z: Good :)09:48
sfinucanI was hoping you might have some ideas on this issue I'm having09:49
*** markvoelker has quit IRC09:49
markus_zsure, which one?09:49
sfinucanThe docs test is failing for this review, but I can't figure out why. Would you have any ideas? https://review.openstack.org/#/c/257956/1609:49
*** otter76__ has quit IRC09:49
*** otter768 has joined #openstack-nova09:49
markus_zI know the error, I'm checking the code09:50
*** garyk has joined #openstack-nova09:50
*** ajayaa has joined #openstack-nova09:50
garykdanpb: ndipanov: the patch https://review.openstack.org/#/c/252565/ addresses the issue with the additinal interfaces on the instance.09:50
*** otter768_ has joined #openstack-nova09:51
sfinucanmarkus_z: So I _think_ it's something to do with the default case09:51
sfinucanor maybe appending to existing cases09:51
sfinucancheck this out09:51
markus_zsfinucan: The code looks fine though. I check it out and test locally.09:52
*** otter768_ has quit IRC09:53
*** otter768_ has joined #openstack-nova09:53
*** otter768 has quit IRC09:53
sfinucanmarkus_z: http://paste.openstack.org/show/483857/09:54
ndipanovgaryk, right09:54
sfinucanthe contents of that list doesn't look right, IMO09:54
*** otter768 has joined #openstack-nova09:55
markus_zsfinucan: jepp, I see it, but I don't understand right now why that is the case09:56
sfinucanmarkus_z: That makes two of us09:56
*** otter768 has quit IRC09:57
sfinucanI'll add that changing it back to a tuple "fixes" the issue09:57
*** otter768 has joined #openstack-nova09:57
*** otter768_ has quit IRC09:57
openstackgerritPawel Koniszewski proposed openstack/nova: Live migration fails when the instance has a config_drive_format=iso9660  https://review.openstack.org/23465909:57
markus_zsfinucan: give me a few minutes to dig deeper09:58
sfinucanmarkus_z: no panic at all :) I've a meeting now but I'll look myself when I'm back09:59
sfinucanassuming you haven't it long sussed by then, heh09:59
* sfinucan scarpers off09:59
ndipanovgaryk, yeah I'll go back to that patch after the one I'm looking at now10:00
*** ijw has joined #openstack-nova10:00
ndipanovit's the best we can do without major refactor10:00
*** ajayaa has quit IRC10:00
ndipanovI'll also comment on the bug10:00
openstackgerritSayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name  https://review.openstack.org/26335310:00
*** haomaiwang has quit IRC10:01
*** otter768_ has joined #openstack-nova10:01
*** ajayaa has joined #openstack-nova10:01
garykndipanov: ok, thanks10:01
*** otter768 has quit IRC10:01
*** haomaiwang has joined #openstack-nova10:01
ndipanovto explain why is that the least bad solution10:01
*** oomich is now known as oomich_away10:01
*** pradipta has quit IRC10:03
*** otter768 has joined #openstack-nova10:03
*** otter768_ has quit IRC10:03
*** tiagogomes_ has left #openstack-nova10:04
*** otter768 has quit IRC10:05
*** otter768_ has joined #openstack-nova10:05
*** ijw has quit IRC10:05
*** otter768 has joined #openstack-nova10:06
*** shuquan has quit IRC10:07
*** otter768 has quit IRC10:08
*** otter768 has joined #openstack-nova10:08
*** otter768_ has quit IRC10:09
*** EinstCrazy has quit IRC10:10
*** salv-orl_ has joined #openstack-nova10:10
*** otter768_ has joined #openstack-nova10:10
*** otter768 has quit IRC10:10
*** cdent has joined #openstack-nova10:11
*** ajayaa has quit IRC10:12
*** ajayaa has joined #openstack-nova10:12
*** otter768 has joined #openstack-nova10:12
*** otter768_ has quit IRC10:12
*** salv-orlando has quit IRC10:12
*** otter768 has quit IRC10:14
*** otter768 has joined #openstack-nova10:14
*** ptm_away is now known as PaulMurray10:15
*** otter768_ has joined #openstack-nova10:16
*** otter768 has quit IRC10:16
openstackgerritSayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name  https://review.openstack.org/26335310:18
*** otter768 has joined #openstack-nova10:18
*** otter768_ has quit IRC10:18
openstackgerritAndrey Pavlov proposed openstack/nova: remove EC2 legacy code  https://review.openstack.org/26642510:18
*** ljxiash has quit IRC10:19
*** ljxiash has joined #openstack-nova10:20
*** otter768_ has joined #openstack-nova10:20
*** otter768 has quit IRC10:20
*** yamahata has quit IRC10:21
*** otter768 has joined #openstack-nova10:21
*** otter768_ has quit IRC10:22
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova: Added new scheduler filter: AggregateTypeExtraSpecsAffinityFilter  https://review.openstack.org/18927910:22
*** yamahata has joined #openstack-nova10:23
*** otter768 has quit IRC10:24
*** otter768_ has joined #openstack-nova10:24
*** ljxiash has quit IRC10:24
*** lyanchih has quit IRC10:25
*** otter768_ has quit IRC10:26
*** otter768 has joined #openstack-nova10:26
openstackgerritDaniel Berrange proposed openstack/nova: hacking: check for common double word typos  https://review.openstack.org/24919310:27
*** lyanchih has joined #openstack-nova10:27
*** otter768 has quit IRC10:27
*** otter768 has joined #openstack-nova10:27
*** yamahata has quit IRC10:28
*** otter768 has quit IRC10:29
*** otter768_ has joined #openstack-nova10:29
*** atuvenie_ has joined #openstack-nova10:30
*** lpetrut has quit IRC10:31
*** aix has joined #openstack-nova10:32
*** atuvenie has quit IRC10:33
*** otter768_ has quit IRC10:34
*** sudipto has joined #openstack-nova10:34
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.firewall' options  https://review.openstack.org/25799510:35
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.netutils' options  https://review.openstack.org/25800910:35
openstackgerritStephen Finucane proposed openstack/nova: Improve 'virt.images' conf options documentation  https://review.openstack.org/25955310:35
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.imagecache' options  https://review.openstack.org/25898410:35
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.images' options  https://review.openstack.org/25800410:35
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.disk' options  https://review.openstack.org/25891210:35
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.driver' options  https://review.openstack.org/25795610:35
openstackgerritStephen Finucane proposed openstack/nova: Improve 'virt.driver' conf options documentation  https://review.openstack.org/26636410:35
openstackgerritStephen Finucane proposed openstack/nova: Improve 'virt.firewall' conf options documentation  https://review.openstack.org/26636510:35
*** lyanchih has quit IRC10:37
*** lpetrut has joined #openstack-nova10:39
ndipanovsfinucan, I think I found a bug in the isolate patch10:39
ndipanovsfinucan, commenting now10:39
ndipanovsfinucan, there10:41
openstackgerritMike Fedosin proposed openstack/nova: [WIP] Make Xenplugin to work with glance v2 api  https://review.openstack.org/26693310:41
*** gongysh_ has quit IRC10:41
*** baoli has joined #openstack-nova10:42
openstackgerritMike Fedosin proposed openstack/nova: [WIP] Make Xenplugin to work with glance v2 api  https://review.openstack.org/26693310:45
sfinucanndipanov: Good spot - I'll address it now10:45
openstackgerritAlvaro Lopez Garcia proposed openstack/nova: libvirt: make live_migration_uri flag dependent on virt_type  https://review.openstack.org/17578010:45
ndipanovsfinucan, awesome!10:45
*** rfolco has joined #openstack-nova10:46
openstackgerritjichenjc proposed openstack/nova: Use stub_out and mock to remove mox:part 3  https://review.openstack.org/26475310:48
*** aix has quit IRC10:52
openstackgerritIldiko Vancsa proposed openstack/nova: Adapt the code to the new get_by_volume BDM functions  https://review.openstack.org/26746410:55
*** shinobu_ has joined #openstack-nova10:57
*** shinobu-compute has joined #openstack-nova10:58
*** haomaiwang has quit IRC11:01
ildikovjohnthetubaguy: hi. if you're around please abandon this patch for me: https://review.openstack.org/#/c/193133/11:01
*** haomaiwang has joined #openstack-nova11:01
*** ijw has joined #openstack-nova11:02
*** Jeffrey4l has quit IRC11:04
*** dims has joined #openstack-nova11:04
*** ociuhandu has quit IRC11:05
*** ociuhandu has joined #openstack-nova11:05
*** ociuhandu has quit IRC11:06
*** ijw has quit IRC11:07
*** RA_ has quit IRC11:07
openstackgerritStephen Finucane proposed openstack/nova: trivial: Add additional logs for NUMA scheduling  https://review.openstack.org/25478311:07
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=isolate' scheduling  https://review.openstack.org/20265511:08
openstackgerritStephen Finucane proposed openstack/nova: releasenotes: Note on CPU thread pinning support  https://review.openstack.org/26469311:08
*** amotoki_ has joined #openstack-nova11:09
*** ljxiash has joined #openstack-nova11:11
*** shyama has quit IRC11:11
*** shyama has joined #openstack-nova11:12
*** alexpilotti has joined #openstack-nova11:12
*** kolesovdv has joined #openstack-nova11:12
*** kmartin has quit IRC11:17
*** lucas-dinner is now known as lucasagomes11:18
*** aysyd has joined #openstack-nova11:21
*** shyama has quit IRC11:21
*** shyama has joined #openstack-nova11:22
*** carey has quit IRC11:23
*** fawadkhaliq has joined #openstack-nova11:25
*** Marga_ has joined #openstack-nova11:29
dedery_garyk: thanks for the validation and review11:30
*** shyama has quit IRC11:31
*** shyama has joined #openstack-nova11:31
*** zhangjn has joined #openstack-nova11:32
*** EinstCrazy has joined #openstack-nova11:33
*** Marga_ has quit IRC11:34
tdurakovsdague, hi, are you around?11:34
tdurakovjohnthetubaguy, got time to discuss ci for live-migration?11:35
johnthetubaguytdurakov: hows it going, with the ci?11:35
tdurakovjohnthetubaguy, ceph is done, now refactoring code to make it more readable, also there is a patch for current hook version: https://review.openstack.org/#/c/267154/ it would be great to merge it asap11:37
*** smatzek has joined #openstack-nova11:37
*** ericksonsantos has joined #openstack-nova11:38
tdurakovbtw, found out that live-migration fails on ci from time to time,  http://logs.openstack.org/83/252283/79/experimental/gate-tempest-dsvm-multinode-live-migration/070dcc0/ from logs it looks like that there is some qemu bug, so need assistance with this11:38
*** rotbeard has joined #openstack-nova11:38
tdurakovjohnthetubaguy, as a first step i think we need more logs for qemu, http://logs.openstack.org/83/252283/79/experimental/gate-tempest-dsvm-multinode-live-migration/070dcc0/logs/libvirt/qemu/instance-00000004.txt.gz - is not enough to find out reson imo11:39
*** ociuhandu has joined #openstack-nova11:39
johnthetubaguytdurakov: so this is the kind of thing I expected us to find, thats really good info11:40
johnthetubaguytdurakov: heh "local of migration failed"11:41
johnthetubaguyload11:41
tdurakovjohnthetubaguy, libvirt layer:  http://xsnippet.org/361328/11:41
tdurakovyep, it totally poor info to figure out what is going on11:41
garykdedery_: np. thanks for fixing this!11:42
johnthetubaguytdurakov: got any ideas on how to add more?11:42
openstackgerritMatthew Booth proposed openstack/nova: Fix backing file detection in libvirt live snapshot  https://review.openstack.org/26481411:42
*** shyama_ has joined #openstack-nova11:42
johnthetubaguytdurakov: oh, I see the snippet has way more info, gotcha11:42
johnthetubaguytdurakov: it says domain is not active, was the VM not running?11:42
*** shyama has quit IRC11:43
*** shyama_ is now known as shyama11:43
johnthetubaguytdurakov: I wonder if there is another failure causing the live-migrate failure? although its very likely a live-migrate problem11:43
*** zhangjn has quit IRC11:44
johnthetubaguytdurakov: whats your plan for fixing the job then? adding in the extra debug info as a start?11:45
*** markvoelker has joined #openstack-nova11:45
tdurakovjohnthetubaguy, snippet above from target node, there is strange info about interface11:45
johnthetubaguyBobBall: was a bit worried about that vif patch, seems to ignore errors on vif.unplug?11:45
johnthetubaguytdurakov: you mean that top line?11:45
tdurakovyep11:45
dedery_garyk: my pleasure (+it was super critical for our customers so I had to chase this one)11:45
johnthetubaguytdurakov: I wonder if that errors is because the VM was not started? I am not sure11:47
tdurakovjohnthetubaguy, i think no11:48
*** markvoelker has quit IRC11:49
johnthetubaguytdurakov: I was just looking at the domain not started line in that log at the end, but maybe thats the destination domain?11:49
*** baoli has quit IRC11:50
tdurakovjohnthetubaguy, yes, domain not started on dest11:50
tdurakovbecause of error above11:50
johnthetubaguyah, OK, that fits11:50
*** amotoki_ has quit IRC11:50
johnthetubaguytdurakov: I wonder if this is a neutron race to get the port setup during a live-migrate?11:51
tdurakovjohnthetubaguy, it's on nova-net11:51
BobBalljohnthetubaguy: Hmmm.  Yes, fair enough.  Thanks for the review.  We'll update the change ASAP (tomorrow, Nanjing time)11:51
johnthetubaguytdurakov: cool, so its totally our fault11:51
johnthetubaguyBobBall: no worries11:52
*** lpetrut has quit IRC11:52
tdurakovjohnthetubaguy, looks so, this is floating error, I'm going to add more logging in hook, and maybe qemu11:52
garykdedery_:  it alos covers a ton of other issues that were tried to be addressed in neutron but turned out to be rabbit holes11:52
*** lpetrut has joined #openstack-nova11:53
*** ociuhandu has quit IRC11:53
dedery_garyk: great! can you point me to some/all of them? I'd be happy to deep dive there.11:53
*** ociuhandu has joined #openstack-nova11:53
BobBalljohnthetubaguy: Regarding the vif being removed, there are many many cases where we don't have that defensive code.  Some where we do (e.g. vm_utils' cleanup_attached_vdis) but XAPI will actually raise a HANDLE_INVALID exception here.11:54
johnthetubaguytdurakov: a good plan, its just a case of keeping digging11:54
*** carey has joined #openstack-nova11:54
tdurakovjohnthetubaguy, yep, but it about job stability, so we need to find out root cause11:54
*** gszasz has joined #openstack-nova11:54
BobBalljohnthetubaguy: Since this is a VM operation it's already blocked on the VM mutex so I think it can't really happen though11:55
tdurakovkashyap, hi, are you around?11:55
johnthetubaguyBobBall: there is a case where we try to unplug and its already unplugged, thats cool, its the case the unplug failed that should be raised I think, since it used to be raised11:55
johnthetubaguyBobBall: oh, you mean the VIFs thing, yeah, it *should* be safe, with only nova talking to xapi11:55
BobBalljohnthetubaguy: I agree with that one - I was meaning the VIF.get_record defensiveness you suggested of checking that vif_ref is not None11:55
johnthetubaguytdurakov: sounds like you are doing the right things11:56
BobBallI think that if there's a concern that this generally _isn't_ safe then we need to do a lot of work to protect against that issue everywhere11:56
johnthetubaguyBobBall: yeah, its only a Nit, just the None type can't do thingy, is an odd error to fail with11:56
tdurakovjohnthetubaguy, can I ask you to help with merging patch for ansible 2.0 folks use my job for live-migration testing, and it totally broken right now:(11:57
BobBalljohnthetubaguy: It won't return None, it'll raise a HANDLE_INVALID exception so we'd need a try/cathc11:57
BobBalljohnthetubaguy: I'm tempted to catch HANDLE_INVALID in client/session.py and convert it to a None though...11:57
johnthetubaguyBobBall: oh right, I see, thats fine then11:57
johnthetubaguyBobBall: hmm, not sure. can't remember what we do for VM now11:58
johnthetubaguyBobBall: its an edge case, lets just keep it simple11:58
johnthetubaguytdurakov: whats the patch?11:58
tdurakovjohnthetubaguy, https://review.openstack.org/#/c/267154/11:58
johnthetubaguyI am about to run for lunch, but lets take a peak11:58
BobBalljohnthetubaguy: Will do.11:59
johnthetubaguytdurakov: does that work with both 1.x and 2.x?12:00
*** haomaiwang has quit IRC12:01
*** haomaiwang has joined #openstack-nova12:01
* johnthetubaguy bravely runs away, for food12:03
*** ijw has joined #openstack-nova12:04
openstackgerritSayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name  https://review.openstack.org/26335312:04
*** alexpilotti has quit IRC12:04
mdboothndipanov: Could you shovel this back into the gate for me: https://review.openstack.org/#/c/264814/12:04
mdboothHad to update it for a merge conflict12:04
mdboothAnd it's holding up the liberty release, as I understand it12:05
ndipanovmdbooth, no +2 on stable sorry12:05
mdboothndipanov: This is the master commit12:05
tdurakovjohnthetubaguy, works for both versions12:05
mdboothThe liberty backport is held up on the master patch merging12:05
mdboothIf I can get this merged, we'll be 1 step closer :)12:05
*** sakthi has quit IRC12:06
mdboothIt has been into the gate twice, now :/12:07
ildikovjohnthetubaguy: thanks12:07
mdboothHit spurious failures both times, then bounced by a merge conflict12:07
*** ijw has quit IRC12:09
*** burgerk has joined #openstack-nova12:10
*** lyanchih has joined #openstack-nova12:12
*** smatzek has quit IRC12:12
openstackgerritZhenyu Zheng proposed openstack/nova: Expose quiesce/unquiesce API  https://review.openstack.org/24898912:12
*** ajayaa has quit IRC12:16
*** ajayaa has joined #openstack-nova12:16
*** takashin has quit IRC12:17
*** sudipto has quit IRC12:17
*** rqw has joined #openstack-nova12:18
*** gongysh_ has joined #openstack-nova12:18
*** sudipto has joined #openstack-nova12:19
openstackgerritDaniel Berrange proposed openstack/nova: objects: add virtual 'image_meta' property to Instance object  https://review.openstack.org/19014512:19
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: convert to use instance.image_meta property  https://review.openstack.org/19014612:20
openstackgerritDaniel Berrange proposed openstack/nova: compute: convert manager to use nova.objects.ImageMeta  https://review.openstack.org/18968512:20
*** shuquan has joined #openstack-nova12:21
*** aix has joined #openstack-nova12:22
*** raildo-afk is now known as raildo12:22
openstackgerritRui Chen proposed openstack/nova: Only return latest fault of each instance in db api  https://review.openstack.org/22339212:23
openstackgerritRui Chen proposed openstack/nova: Create image for suspended instance booted from volume  https://review.openstack.org/22338212:24
openstackgerritDaniel Berrange proposed openstack/nova: hacking: check for common double word typos  https://review.openstack.org/24919312:24
openstackgerritRui Chen proposed openstack/nova-specs: Task states improvement  https://review.openstack.org/21657812:24
*** sudipto has quit IRC12:25
*** burgerk has quit IRC12:25
*** smatzek has joined #openstack-nova12:26
openstackgerritRui Chen proposed openstack/python-novaclient: Fix Resource.__eq__ mismatch semantics of object equal  https://review.openstack.org/25102012:28
*** shuquan has quit IRC12:28
*** lyanchih has quit IRC12:28
ndipanovdedery_, hey - commented on your patch and here: https://review.openstack.org/#/c/230919/212:30
ndipanovwould love to hear your thoughts12:30
*** otter768 has joined #openstack-nova12:30
*** rqw has quit IRC12:31
*** irenab_ has joined #openstack-nova12:32
*** erlon has joined #openstack-nova12:32
*** irenab_ has quit IRC12:33
*** rqw has joined #openstack-nova12:33
*** irenab has quit IRC12:33
openstackgerritjichenjc proposed openstack/nova: WIP:remove OS-EXT-IPS and OS-EXT-IPS-MAC extension  https://review.openstack.org/26653312:33
*** irenab has joined #openstack-nova12:35
*** otter768 has quit IRC12:35
*** irenab_ has joined #openstack-nova12:38
*** cdent has quit IRC12:39
*** rqw has quit IRC12:39
*** rqw has joined #openstack-nova12:40
*** irenab has quit IRC12:40
*** irenab_ is now known as irenab12:40
dedery_ndipanov: thank you. replied in the comments.12:41
*** thorst has joined #openstack-nova12:41
*** baoli has joined #openstack-nova12:41
*** markvoelker has joined #openstack-nova12:45
*** houming has quit IRC12:46
openstackgerritZhenyu Zheng proposed openstack/nova: Split-network-plane-for-live-migration  https://review.openstack.org/24500512:46
*** thumpba has joined #openstack-nova12:47
openstackgerritgaryk proposed openstack/nova: Objects: correctly update the ImageMeta version  https://review.openstack.org/26752412:48
*** scheuran has joined #openstack-nova12:48
garykdanpb: sahid: ^12:48
*** smoriya__ has quit IRC12:48
markus_zedleafe: I'm doint a review day today with the config options patches. Your scheduler help text patches have merge problems. Need help there?12:48
garykndipanov: ^^12:48
*** markvoelker has quit IRC12:50
danpbgaryk: no, that's wrong - we don't tie versions together anymore12:51
*** tiagogomes has joined #openstack-nova12:51
tiagogomesHello, can a host be in multiple availability zones?12:51
garykdanpb: ok, thanks!12:51
openstackgerritSean Dague proposed openstack/nova-specs: add spec for instance flavor API  https://review.openstack.org/26528212:51
*** thumpba has quit IRC12:53
*** kaisers has quit IRC12:53
mdboothDoes any core have a second to push this back into the gate for me: https://review.openstack.org/#/c/264814/12:55
mdboothIt was merge conflicted out of the gate.12:55
mdboothHas now re-passed check.12:55
mdboothI understand that it's holding up a liberty release.12:56
openstackgerritgaryk proposed openstack/nova: Objects: add limits, reservations and shares to ImageMetaProps object  https://review.openstack.org/18832112:57
*** ccarmack has joined #openstack-nova12:57
*** ccarmack has left #openstack-nova12:57
openstackgerritgaryk proposed openstack/nova: VMware: support limits via image meta data  https://review.openstack.org/18094212:58
*** haomaiwang has quit IRC12:59
openstackgerritSayali Lunkad proposed openstack/nova: Allows to set display_name as instance_name  https://review.openstack.org/26335313:00
*** doug-fish has joined #openstack-nova13:01
mdboothjohnthetubaguy: ^^^ Just looking for a procedural +2, +W on that patch13:02
*** gcb has joined #openstack-nova13:04
openstackgerritHans Lindgren proposed openstack/nova: Add Console and ConsolePool objects  https://review.openstack.org/26753913:04
openstackgerritHans Lindgren proposed openstack/nova: Make use of new Console and ConsolePool objects  https://review.openstack.org/26754013:04
*** ijw has joined #openstack-nova13:05
*** shinobu-compute has quit IRC13:06
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix support customer ip protocol when create security-rule using nova-cli  https://review.openstack.org/26668713:06
*** doug-fish has quit IRC13:07
*** fawadkhaliq has quit IRC13:07
*** doug-fish has joined #openstack-nova13:08
*** zenoway has quit IRC13:08
*** garyk has quit IRC13:08
*** ijw has quit IRC13:09
sfinucanndipanov: Done and done https://review.openstack.org/#/c/202655/13:09
*** dedery has joined #openstack-nova13:12
*** doug-fish has quit IRC13:12
*** diogogmt has quit IRC13:14
ndipanovsfinucan, nice - alaski will hopefully +2 it too and then we can bikeshed on debug vs info :)13:15
*** dedery_ has quit IRC13:15
*** akshai has joined #openstack-nova13:15
sfinucanndipanov: Can't wait :)13:16
alaskiI say warning, perhaps audit13:16
ndipanovI'm firmly in the info camp13:16
*** diogogmt has joined #openstack-nova13:17
alaskiI haven't actually gone through that patch yet, will look after going through this one again13:17
ndipanovtbh I am not sure about logging there13:17
ndipanovmy gut feeling is debug because normally you don't need that much info from that filter13:18
*** ducttape_ has joined #openstack-nova13:18
*** cdent has joined #openstack-nova13:19
*** mtanino has joined #openstack-nova13:19
sfinucanndipanov: alaski: I'm also unsure. I found it helpful during debugging, but I got requests saying it added little extra13:19
sfinucanhence why it was a different patch13:19
sfinucanI'd like to be a little more verbose if I could, and say exactly _why_ it failed for all cases13:19
johnthetubaguymdbooth: sorry was eating lunch, taking a peak now13:19
mdboothjohnthetubaguy: Thanks. ndipanov might possibly beat you to it, though :)13:20
johnthetubaguyeven better13:20
ndipanovjohnthetubaguy, don't give up though - you can still win this :)13:20
*** shyama has quit IRC13:21
*** smatzek has quit IRC13:21
PaulMurraymdbooth, I added storage pools on the midcycle etherpad as a "suggested feature discussion"13:21
*** shyama has joined #openstack-nova13:21
mdboothPaulMurray: Cool, thanks.13:21
PaulMurraymdbooth, would you check what I put is right please13:22
mdboothSure, do you have the link to hand?13:22
PaulMurrayhttps://etherpad.openstack.org/p/mitaka-nova-midcycle13:22
PaulMurrayL3713:22
mdboothSeen13:23
johnthetubaguytdurakov: did you seem my note on that patch, I wonder if we should check the ansible version?13:23
*** nithyag_ has quit IRC13:24
tdurakovjohnthetubaguy, well, we could, but what we should do if it doensn't fit our expectations?13:24
alaskindipanov: sfinucan looking at this my first thought is that the current debugs are good at that level, but the logging at the call site of that method should perhaps be info13:24
tdurakovas i wrote above this change works for both 1.x and 2.x either13:25
*** shyama has quit IRC13:25
*** markvoelker has joined #openstack-nova13:25
johnthetubaguytdurakov: sorry, missed your note, I am cool if it works for both versions13:25
*** shyama has joined #openstack-nova13:25
*** browne has joined #openstack-nova13:26
johnthetubaguytdurakov: FWIW, I was thinking we just error out and fail the script if it doesn't match, but works on both is way better than that option13:26
*** _diana_1 has joined #openstack-nova13:26
tdurakovjohnthetubaguy, acked, will save some amount of time13:27
*** lyanchih has joined #openstack-nova13:28
*** carey has quit IRC13:28
*** haomaiwang has joined #openstack-nova13:30
mdboothPaulMurray: I've added some more in there. Having not attended a midcycle before, I'm not sure how it runs. Is the timing of this discussion likely to be predictable? I think I mentioned that I'm only planning a  daytrip.13:31
*** doug-fish has joined #openstack-nova13:31
sfinucanalaski: Yeah, I might try focus on that13:31
mdboothndipanov: johnthetubaguy beat you :)13:32
sfinucanIssue was that I didn't have information like instance available in the function, so logs were missing important info13:32
PaulMurraymdbooth, I think we can arrange that13:32
PaulMurrayjohnthetubaguy, ^^^13:32
sfinucanI'll figure something out13:33
PaulMurraymdbooth, do you have any restriction on which day?13:33
johnthetubaguymdbooth: happy to tie down some times if you need that13:33
mdboothPaulMurray: The day before is plenty notice, btw.13:33
*** ccarmack has joined #openstack-nova13:33
mdboothNo restrictions.13:33
mdboothjohnthetubaguy: Any time is fine as long as I know at least the day before.13:34
*** smatzek has joined #openstack-nova13:34
*** ducttape_ has quit IRC13:35
alaskisfinucan: yeah, the log additions are nice.  but I agree with mikal that an info level log would be nice for operators who aren't at debug.  however your additional logs fit at debug13:35
*** dedery_ has joined #openstack-nova13:35
PaulMurrayjohnthetubaguy, talking about the midcycle, what times do you think are good for start and end of day?13:35
*** cdent has quit IRC13:35
mdboothFor those of us with a 2 hour drive: 8am is not cool :)13:35
PaulMurray8:30 :)13:36
mdbooth:P13:36
PaulMurraymdbooth, next year we could do it at your castle13:37
*** ferest has joined #openstack-nova13:37
mdboothYou'd have to fight off the tourists.13:37
*** dedery has quit IRC13:37
mdboothIt'd probably be a really good venue for it apart from that, though.13:38
*** dslevin has quit IRC13:39
*** edmondsw has joined #openstack-nova13:39
johnthetubaguyPaulMurray: I was thinking we start at 9am, but that more because its what we normally do13:40
*** diogogmt has quit IRC13:41
johnthetubaguymdbooth: which bit are you wanting to attend, the live-migrate stuff?13:41
mdboothjohnthetubaguy: Yeah.13:41
PaulMurrayjohnthetubaguy, that's ok - its hard to predict what traffic will be like if anyone is driving from in town13:42
PaulMurray9:30 would be easy to get to - but 9:00 should be ok13:42
* mdbooth used to do Cheltenham daily on a motorcycle in 50 mins.13:42
*** dedery_ has quit IRC13:42
mdboothBristol's another 30/40 mins?13:42
danpbfor those of us who like to sleep, 8am is not cool either :-)13:43
danpbworking from home, i'm used to waking up at 8:50 to start working at 9:00 :-)13:44
mdboothdanpb: Is midcycle going to be an opportunity to sleep it :)13:44
mdboothin13:44
lxsliI'd recommend 9:30 for traffic reasons13:44
danpbmdbooth: you didn't fancy staying at the holiday inn then ?13:44
* mdbooth tries to start work at 9:30, and wake up by lunchtime13:44
_diana_1I don't suppose the unit tests are segfaulting for anyone else? Locally, that is. In particular these: test_signature_utils (openssl/cryptography).13:45
* PaulMurray starts to understand why the code is the way it is13:45
danpb_diana_1: not noticed that for me on Fedora 23 hosts13:45
mdbooth_diana_1: There was a Fedora snafu a while back with a crypo library13:45
mdbooth_diana_1: If you aren't fully updated, you might be hitting that13:45
mdboothYou'll also need to ensure you rebuild the python cryptography library after fully updating13:46
mdboothNoting that a compiled version can be cached in a bunch of places13:46
_diana_1I've spent hours on this… I can't for the life of me fix it. But it helps knowing others have seen it. I'll try again. Thanks!13:46
mdboothIf you're hitting the same issue, you'll be getting a dynamic link error.13:47
mdboothSome EC stuff was removed from the library, but not from the headers.13:47
*** dslev has joined #openstack-nova13:48
*** browne has quit IRC13:48
bauzasnova meeting in 10 mins, amirite?13:48
johnthetubaguymikal tjones cburgess jgrimm adrian_otto funzo mjturek jcookekhugen irina_pov krtaylor danpb alexpilotti flip214 jaypipes garyk edleafe dims moshele anteaya Nisha sileht claudiub lxsli neiljerram markus_z swamireddy alevine tonyb andreykurilin ndipanov sc68cal akuriata artom jlvillal mnestratov kashyap aloga rgeragnov bauzas xyang tpatil med_ nic scottda nagyz belliott dguitarbite sdague jroll diana_clarke13:49
johnthetubaguy _diana_ raildo jichen gjayavelu mdorman klindgren sorrison belmoreira mrda auggy PaulMurray gcb thorst duncant macsz thomasem tpatzig13:49
edleafemarkus_z: just getting to my desk. Looks like the base move patch still has issues.13:49
johnthetubaguy^ Nova meeting in a few moments in #openstack meeting13:49
thomasemhey13:49
sdaguejohnthetubaguy: ack13:49
edleafemarkus_z: let me dig into that first13:49
thomasemcool, thanks!13:49
johnthetubaguybauzas: heh, thats a +1 from me13:50
gcbcool13:50
bauzas:)13:50
sdague_diana_1: did you try deleting your .tox dir?13:50
*** dedery has joined #openstack-nova13:50
sdaguein case it's stale and there was something with an abi bump13:50
*** jenie has joined #openstack-nova13:51
jeniehello13:51
jenieI am trying to spin an instance and I get a weird nova error13:51
jenie"RESP BODY: {"computeFault": {"message": "Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible.\n<type 'exceptions.ValueError'>", "code": 500}}"13:51
jeniewhat is the meaning of this error ?13:51
jenieI am using liberty13:52
*** dslev_ has joined #openstack-nova13:54
johnthetubaguyjenie: I would try on #openstack for usage issues, this is the development channel13:55
johnthetubaguyjenie: I suspect you will need to look at the logs to get a more detailed error about what is going wrong, folks in #openstack should be able to help with that13:56
jeniejohnthetubaguy: Since it said bug, I thought it is worthwhile to ask devs13:56
tiagogomesHi, is it safe to have a host in multiple availability zones, assuming that each availability zone will only have a single aggregate?13:56
*** dslev has quit IRC13:57
jeniejohnthetubaguy: the log has got the nothing and I am running nova using --debug option13:57
johnthetubaguytiagogomes: it breaks the idea of availability zones of being distinct groups of hosts that fail independently13:57
*** lyanchih has quit IRC13:58
johnthetubaguyjenie: I would ask the folks in #openstack who can help you find the debug info you need, could be in syslog, those folks will be able to help more with that13:58
jeniejohnthetubaguy:  okay but here atleast you responded , their no one seems to be responding13:59
*** rlrossit has joined #openstack-nova13:59
tiagogomesyes, but if you have a blade server, you want each blade to be an AZ.  But if in the future you connect that blade server to another blade server to extend power and storage, you want an AZ by blade server13:59
jenieI just created a pastebin, if it is worthwhile for any developers to look it could be nice of you14:00
jeniehttp://pastebin.com/C69DcUwm14:00
johnthetubaguytiagogomes: there is a spec about hierarchical zones that can be used for server groups, it sounds similar to what you are wanting14:00
*** dslev_ has quit IRC14:00
*** haomaiwang has quit IRC14:01
*** rgerganov has joined #openstack-nova14:01
_diana_1sdague: Yup, I tried that. Even just importing that test class causes a segfault for me now (which is why test discovery fails). Things were fine yesterday… I suspect I messed my openssl install up somehow. Off to try again. Thanks.14:01
*** haomaiwa_ has joined #openstack-nova14:01
tiagogomesjohnthetubaguy any change of that spec being implemented for Mitaka?14:02
*** ijw has joined #openstack-nova14:05
*** vivekd has quit IRC14:06
*** ashishjain has joined #openstack-nova14:06
*** zz_dimtruck is now known as dimtruck14:08
*** ctrath has joined #openstack-nova14:08
openstackgerritIldiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments  https://review.openstack.org/19313514:08
openstackgerritIldiko Vancsa proposed openstack/nova: comp: Prep Nova to allow multiple volume attachments  https://review.openstack.org/19313414:08
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach  https://review.openstack.org/15303814:08
openstackgerritIldiko Vancsa proposed openstack/nova: virt: Pass host when call attach to Cinder  https://review.openstack.org/25627314:08
openstackgerritIldiko Vancsa proposed openstack/nova: comp: Allow volume multiattach  https://review.openstack.org/26758714:08
*** jenie has quit IRC14:10
*** ijw has quit IRC14:10
openstackgerritTimofey Durakov proposed openstack/nova: Ceph for live-migration job  https://review.openstack.org/25228314:10
ildikovjohnthetubaguy: hi14:11
ildikovjohnthetubaguy: I reorganized the multiattach code ^^14:11
ildikovjohnthetubaguy: the first two patches need to make it into Mitaka in order to be able to enable the feature for Newton14:12
ildikovjohnthetubaguy: if we find a way to get all in that would be the best of course, but I thought to do this reorg just in case14:13
*** mdrabe has joined #openstack-nova14:14
*** ducttape_ has joined #openstack-nova14:16
*** dslev has joined #openstack-nova14:16
*** wanghao has quit IRC14:17
ndipanovjohnthetubaguy, so here's an interesting potentially very useful https://review.openstack.org/#/c/230919/214:19
ndipanovbugfix14:19
ndipanovjohnthetubaguy, addresses the same issue as this one https://review.openstack.org/#/c/252565/14:20
*** lucasagomes is now known as lucas-hungry14:20
ndipanov(we should probably have both, but we should definitely have the first one...)14:20
*** thumpba has joined #openstack-nova14:21
*** zakora has quit IRC14:21
ndipanovI would really like the fix to land on master at least but I guess seeing that this is easy to change/backout it's ok14:21
*** jichen has quit IRC14:23
*** jenie has joined #openstack-nova14:23
jenieunable to get help in #openstack channel14:24
jeniewhat shall I fo14:24
jeniehttp://pastebin.com/pyamYRem14:24
*** vladikr has joined #openstack-nova14:24
*** zakora has joined #openstack-nova14:24
openstackgerritRen Qiaowei proposed openstack/nova: enable uefi boot for x86_64  https://review.openstack.org/26293014:25
*** dims has quit IRC14:26
dederyndipanov: thank you for the review and comments14:29
*** dims has joined #openstack-nova14:30
*** cdent has joined #openstack-nova14:30
*** zakora has quit IRC14:30
*** jenie has quit IRC14:30
*** otter768 has joined #openstack-nova14:31
*** annegentle has joined #openstack-nova14:32
*** zakora has joined #openstack-nova14:33
*** changbl has quit IRC14:34
*** otter768 has quit IRC14:35
*** smatzek has quit IRC14:35
*** dedery_ has joined #openstack-nova14:37
*** dedery_ has quit IRC14:37
openstackgerritRyan Rossiter proposed openstack/nova: Add helper shim for getting items  https://review.openstack.org/26599514:37
openstackgerritRyan Rossiter proposed openstack/nova: Remove DictCompat from ComputeNode  https://review.openstack.org/26552114:37
*** dedery_ has joined #openstack-nova14:37
*** mrkz has joined #openstack-nova14:38
*** xyang1 has joined #openstack-nova14:39
*** browne has joined #openstack-nova14:39
*** jistr has quit IRC14:40
*** haomaiwa_ has quit IRC14:40
*** dedery has quit IRC14:40
*** jistr has joined #openstack-nova14:41
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [python3] byte/string conversions and enable more tests  https://review.openstack.org/26104514:41
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [python3] Port more code to python3 and enable tests  https://review.openstack.org/26208314:41
*** mriedem_away is now known as mriedem14:42
*** jaosorior has quit IRC14:42
*** jaosorior has joined #openstack-nova14:43
*** dimtruck is now known as zz_dimtruck14:44
*** mmedvede has quit IRC14:44
*** jaosorior has quit IRC14:44
*** cfriesen has joined #openstack-nova14:44
*** jaosorior has joined #openstack-nova14:45
*** rgerganov has quit IRC14:45
openstackgerritPavel Kholkin proposed openstack/nova: enginefacade: 'aggregate'  https://review.openstack.org/26224814:46
*** ducttape_ has quit IRC14:47
openstackgerritRen Qiaowei proposed openstack/nova: enable uefi boot for x86_64  https://review.openstack.org/26293014:48
*** garyk has joined #openstack-nova14:48
*** cfriesen has quit IRC14:48
*** cfriesen has joined #openstack-nova14:49
mriedemmissed it by that much14:49
*** shyama has quit IRC14:49
*** shyama has joined #openstack-nova14:49
johnthetubaguyndipanov: thats the one gary hit the other day?14:50
*** gcb has quit IRC14:50
mriedemgaryk: do you want to see this get into the 12.0.1 liberty release? https://review.openstack.org/#/c/266096/14:50
openstackgerritPavel Kholkin proposed openstack/nova: enginefacade: 'instance_group'  https://review.openstack.org/26131614:51
ndipanovjohnthetubaguy, yeah - several people keep hitting it14:51
ildikovdansmith: mriedem: hi, I uploaded the get_by_volume_* changes on top of Dan's patch14:51
ndipanovas you can see from the bug count and attempts at fixing it14:51
ildikovdansmith: mriedem: I also reorganized the multiattach series14:51
garykmriedem: yes. do we have time?14:51
*** artom_ has quit IRC14:52
*** chhavi has joined #openstack-nova14:52
mriedemgaryk: yeah14:52
garykok, thanks!14:52
*** links has quit IRC14:52
ndipanovjohnthetubaguy, the patch I linked is small and correct in the general case - I hope my explanation helps14:52
*** ashishjain has quit IRC14:54
mriedemndipanov: ewww14:54
mriedemhttps://review.openstack.org/#/c/186315/ was backported back to all of the stable branches too14:54
ndipanovmriedem, that's fine14:54
ndipanovthere's a fix that makes it irrelevant14:54
ndipanovmriedem, which actually adds locking14:54
openstackgerritPavel Kholkin proposed openstack/nova: enginefacade: 'instance_group'  https://review.openstack.org/26131614:55
*** Sukhdev has joined #openstack-nova14:55
ndipanovmriedem, https://review.openstack.org/#/c/194597/14:55
ndipanovso if a stable branch does not have this14:55
ndipanovthan the fix above you mention is "fine"14:55
ndipanovif it does however - it should also have the fix I linked14:55
ndipanovmriedem, makes sense??14:56
mriedemnot really, i don't have them all in my head, or haven't looked at them all either14:57
mriedemplus just got online and no coffee14:57
*** ashishjain has joined #openstack-nova14:57
mriedemndipanov: so it sounds like we want the locking change in the stable branches? https://review.openstack.org/#/q/I6ea2eda8a61f418b0c32f13a7ed6904352712857,n,z14:58
mriedemwhich would just be stable/kilo for the locking one14:58
*** dave-mccowan has joined #openstack-nova14:58
mriedemdansmith: has a -2 on https://review.openstack.org/#/c/233611/ because sahid had a -114:58
mriedembut it sounds like that's been sorted out now14:58
ndipanovmriedem, in that case you want to also grab the revert of the fix14:59
ndipanovso if a stable doesn't have it14:59
ndipanovI'd leave it at that14:59
mriedemwhat is 'it' in this case? the locking one?14:59
ndipanovor backport locking + https://review.openstack.org/#/c/230919/14:59
ndipanovso either have locking + https://review.openstack.org/#/c/230919/14:59
_diana_1alaski, sdague: May I please have the +2s & workflow added back on this review (https://review.openstack.org/#/c/265082/)? I had to rebase. Thanks!14:59
ndipanovmriedem, or don't touch it14:59
sdague_diana_1: looking15:00
*** Daisy has joined #openstack-nova15:00
mriedemndipanov: ok, so it sounds like we should just abandon https://review.openstack.org/#/c/233611/15:00
sdagueI'll look after this next meeting15:00
mriedemsince kilo doesn't have the locking change15:00
ndipanovmriedem, yes15:00
*** haomaiwa_ has joined #openstack-nova15:00
*** dave-mcc_ has joined #openstack-nova15:00
*** haomaiwa_ has quit IRC15:01
ndipanovmriedem, that is correct15:01
mriedemndipanov: and since locking is in stable/liberty (https://review.openstack.org/#/c/194597/), we'll want to backport https://review.openstack.org/#/c/230919/ to stable/liberty15:01
ndipanovmriedem, right15:01
ndipanovas soon as we land it on master15:01
ndipanovideally we'd want both on stable/kilo too but not sure we care enough15:01
mriedemkilo doesn't have the locking thing, as noted15:02
mriedemi just abandoned https://review.openstack.org/#/c/233611/ for kilo15:02
mriedemkilo is security / critical fix mode anyway, and with the amount of confusion on this, i don't think it's a candidate15:02
ndipanovmriedem, agreed15:04
*** dave-mccowan has quit IRC15:04
*** ijw has joined #openstack-nova15:05
gibihi cores! the versioned notification reviews need a second +2. The chain starts here: https://review.openstack.org/#/c/24702415:05
openstackgerritRen Qiaowei proposed openstack/nova: enable uefi boot for x86_64  https://review.openstack.org/26293015:06
openstackgerritDan Smith proposed openstack/nova: Allow sending the migrate data objects over the wire  https://review.openstack.org/25158815:08
mriedemmdbooth: i see you hit a merge conflict15:09
mdboothmriedem: Yup. Updated the stable backport to reflect that.15:10
*** smatzek has joined #openstack-nova15:10
mriedemi'm kind of wondering if we should backport https://review.openstack.org/#/c/264349/15:10
mriedembut that's getting messy15:10
*** takedakn has joined #openstack-nova15:10
*** pradk has joined #openstack-nova15:11
bauzasmriedem: not sure it's super urgent for that one15:12
mriedemit's not urgent, no15:12
bauzaswe could wait for a .215:12
bauzasbut the backport is acceptable yes15:12
mriedembut if we did backport it at some point, it would probably have merge conflicts with https://review.openstack.org/#/c/264817/15:12
*** atuvenie_ has quit IRC15:12
mriedemb/c https://review.openstack.org/#/c/264817/ on master has conflicts with https://review.openstack.org/#/c/264349/15:13
*** Jeffrey4l has joined #openstack-nova15:13
mriedembut, yeah, we could play this dance forever and never get 12.0.1 out, which is my priority15:13
*** zz_dimtruck is now known as dimtruck15:13
bauzasmriedem: but the master one has been rebased on top of the latter 264349 right?N15:13
bauzasyeah, I'm taking lot of time to review the ones you gave me yesterday15:14
mriedemthat's true15:14
mriedemso nvm15:14
openstackgerritRen Qiaowei proposed openstack/nova: enable uefi boot for x86_64  https://review.openstack.org/26293015:15
mriedemgdi, i'm distracted by the guy snoring in the office behind me at 9am15:15
rlrossitmriedem: sorry, I'll wake up15:16
rlrossitthat or just start coughing loudly15:16
rlrossitdansmith: opinion time. If I want to replicate the behavior of things in https://review.openstack.org/#/c/265951/3/nova/api/openstack/compute/floating_ips.py L48-54, I need to add NotImplementedError to the except in order to maintain the 'if it isn't set' check... is that cool or not cool?15:17
johnthetubaguymriedem: coffee machine broken or something?15:18
*** mmedvede has joined #openstack-nova15:18
dansmithrlrossit: you mean because it ends up trying to lazy-load a thing?15:18
mriedemjohnthetubaguy: he usually only snores around 1pm15:18
rlrossitdansmith: yeah15:18
mriedemjohnthetubaguy: must be narcoleptic15:18
johnthetubaguyah, post lunch snooze15:18
mriedemor just near retirement and doesn't give an f15:18
dansmithrlrossit: I dunno, that seems kinda wrong, but I don't know why.. I guess it's replicating the behavior there15:19
rlrossitdansmith: agreed... it seems very very wrong. I'm just not sure what they were trying to catch in that situation. Not having a fixed ip on the floating ip? or the fixed ip not having an address?15:20
dansmithwell, yeah, but I meant.. It feels wrong to catch notimplemented there15:20
dansmithrlrossit: you can of course just do:15:20
rlrossitobj_attr_is_set?15:20
dansmithif 'address' in fixedip: ... else: .. = None15:20
mriedemuse in, it's much nicer looking15:21
rlrossityup15:21
rlrossitdansmith: but keep the try still right?15:21
*** pratikmallya has joined #openstack-nova15:22
dansmithrlrossit: would we ever hit it?15:22
*** edtubill has joined #openstack-nova15:22
*** doug-fish has quit IRC15:22
* rlrossit shrugs15:22
rlrossitthis isn't tested, so I dunno15:22
*** doug-fish has joined #openstack-nova15:22
dansmithheh15:23
*** lucas-hungry is now known as lucasagomes15:24
rlrossitlet me try testing again without the try/except and let me see what happens15:24
*** carey has joined #openstack-nova15:24
*** mragupat has joined #openstack-nova15:25
*** takedakn1 has joined #openstack-nova15:25
rlrossitdansmith: ohh I think I get it. I think that's how they find out if the floating ip is allocated or not, maybe?15:26
dansmithsounds right15:26
rlrossitbecause I think most of the time it's getting key error on fixed_ip15:26
*** doug-fish has quit IRC15:27
*** takedakn has quit IRC15:27
*** takedakn1 is now known as takedakn15:27
mriedemrlrossit: floating ip or fixed ip?15:28
mriedembecause https://github.com/openstack/nova/blob/master/nova/objects/fixed_ip.py#L5715:28
rlrossitthis is in the floating ip api, it's checking if floating ip has a fixed ip15:28
ndipanovmriedem, are you looking into this?15:29
mriedemndipanov: the master branch changes?15:29
*** carey has quit IRC15:29
ndipanovyes15:29
*** mdrabe has quit IRC15:29
mriedemi haven't dug in, was going to read the nova meeting minutes first and catch up on some things15:29
mriedemi can add to the queue15:29
*** doug-fish has joined #openstack-nova15:29
mriedemndipanov: i read your big comment on the race and locking thing, and i just got scared15:29
ndipanovmriedem, yeah it's messed up15:30
*** mgoddard has quit IRC15:30
*** angdraug has joined #openstack-nova15:30
ndipanovbut it comes down to - when is that method supposed to mutate the info-cache15:30
*** mgoddard has joined #openstack-nova15:30
ndipanovand the answer is - only when there is actual data passed in15:31
mriedemndipanov: i wasn't really clear on your comments in https://review.openstack.org/#/c/230919/ about whether or not we even needed that if we had https://review.openstack.org/#/c/252565/15:31
*** pratikma_ has joined #openstack-nova15:31
ndipanovmriedem, so imho we should have both15:31
mriedem"This patch does one harmful thing though, which is making a call to get_instance_nw_info potentially destructive even if there are no ports/networks passed in."15:31
ndipanovthe second one is not going to do anything if we land the first one15:31
*** jang has quit IRC15:32
mriedemwhy would we land the 2nd one then?15:32
ndipanovmriedem, so I am refering to the patch beint reverted15:32
markus_zhm, I forgot the meeting today...15:32
ndipanovmriedem, well15:32
ndipanovwe don't need to really15:32
ndipanovI'd prefer that we land https://review.openstack.org/#/c/230919/15:33
*** takedakn has quit IRC15:33
ndipanovthe second one is more of a sanity check15:33
*** jang has joined #openstack-nova15:33
mriedem:)15:34
ndipanovit would make sure that - should we mess this up again in the future - we don't keep corrupting the nwinfo15:34
*** pratikmallya has quit IRC15:34
*** doug-fish has quit IRC15:34
ndipanovso I am in favor of it15:34
mriedemi'd probably have to dig into the bugs and locking change to get an idea for what the failure is,15:34
ndipanovbasically15:34
mriedemi just know we've struggled over this nw info cache code in neutron several times,15:34
mriedemit's like whack a mole15:34
mriedemand the mole always wins15:34
ndipanovif the event comes from neutron first15:35
ndipanovbefore there was a race15:35
ndipanovbut now there isn't15:35
ndipanovto mitigate the race15:35
*** jwcroppe has joined #openstack-nova15:35
mriedemthere isn't a race b/c of the locking added in liberty?15:35
ndipanovyes15:35
ndipanovso if the event makes it in first15:35
ndipanovit sees no ports15:35
ndipanovasks neutron - do we have some ports15:36
ndipanovand saves them to infocache15:36
ndipanovthen the boot thread goes in15:36
*** omnipresent has joined #openstack-nova15:36
ndipanovchecks the info cache15:36
mriedemwhich event?15:36
ndipanovand just adds the same ports15:36
mriedemvif-plugged?15:36
ndipanovport update15:36
johnthetubaguydoes the port uuid not help us spot the existing items?15:37
ndipanovjohnthetubaguy, well we didn't check for it15:37
ndipanovthat's what the second patch does15:37
johnthetubaguyoh right15:37
ndipanovbut that should never really happen because15:37
ndipanovthe event shoulc never add stuff to info-cache15:37
ndipanovactually I wonder if it needs to refresh it at ll15:37
johnthetubaguyI think its floating ips15:38
*** EinstCrazy has quit IRC15:38
ndipanovsince the assumption is that it came from nova so it wil get refreshed eventually15:38
johnthetubaguyand the metadata service15:38
ndipanovjohnthetubaguy, but that won't work15:38
ndipanovsince we don't pass anything in to that call15:38
*** akshai has quit IRC15:38
ndipanovmeaning it will just look at what's in the cache15:38
johnthetubaguyfloating ips just an update to an existing port, usually, I think15:39
ndipanovbut that update should come from the thread adding the floating -ip15:40
*** Sukhdev has quit IRC15:40
ndipanovin case it doesn't though then yeah15:40
johnthetubaguyadd floating ip is a neturon API call, not a nova one, but anyways, I should stop distracting15:40
*** Sukhdev has joined #openstack-nova15:40
ndipanovjohnthetubaguy, yeah makes sense then15:40
johnthetubaguyndipanov: which one is the port uuid patch?15:41
ndipanovjohnthetubaguy, https://review.openstack.org/#/c/252565/15:41
johnthetubaguyah, ack, thanks15:41
*** rushiagr_away is now known as rushiagr15:42
*** artom_ has joined #openstack-nova15:42
ndipanovjohnthetubaguy, in that case yes refreshing should never really add ports unless they were passed in15:43
ndipanovwhich is what merging this gives us https://review.openstack.org/#/c/230919/15:44
*** rqw has quit IRC15:44
*** Sukhdev has quit IRC15:46
*** akshai has joined #openstack-nova15:46
*** armax has quit IRC15:47
*** doug-fish has joined #openstack-nova15:47
*** claudiub has joined #openstack-nova15:48
johnthetubaguyndipanov: I wonder about edge cases around failed unplugs, but yeah, this feels a lot like how mriedem described it...15:48
johnthetubaguyndipanov: I like the port uuid and network thing though, that seems very safe15:49
openstackgerritPawel Koniszewski proposed openstack/nova: add index/show API for server migrations  https://review.openstack.org/25877115:49
*** mdrabe has joined #openstack-nova15:49
mriedemi want him to remove the bug refs from the code15:49
mriedemso -1 on that15:49
*** doug-fis_ has joined #openstack-nova15:49
mriedemall of the list comprehension and negative logic definitely makes this not fun to read15:49
mriedemit's not not easy to read15:50
mriedemwait :)15:50
*** femnad has quit IRC15:51
mriedemndipanov: i see now what you mean by https://review.openstack.org/#/c/252565/ being a safeguard though,15:51
mriedemit's just adding the filtering should it happen, and then logging the warning that we've missed something15:51
*** ducttape_ has joined #openstack-nova15:52
*** doug-fish has quit IRC15:52
dedery_mriedem: hi, +1 for the negative logic. will fix. I was wondering about it myself15:52
*** armax has joined #openstack-nova15:52
*** armax has quit IRC15:52
mriedemnegative logic is one thing, but wrapped in a block of list comprehension and my head starts to hurt15:53
*** kolesovdv has quit IRC15:53
dedery_mriedem: I was wondering about how to do it neatly on one hand and how to log the issues on another15:53
mriedemotherwise i'm ok with this once that's cleaned up15:53
dedery_I'm totally open for suggestions15:53
*** annegentle has quit IRC15:54
mriedemi made some suggestions in the _logged_is_not_in method15:54
dedery_i saw it but i wonder if there's another way to wrap the logging with the list creation15:54
mriedemhttps://docs.python.org/2/library/functions.html#filter15:55
*** femnad has joined #openstack-nova15:55
mriedempass your logging funtion into filter with the ifaces list15:55
*** Sukhdev has joined #openstack-nova15:55
dedery_great! will work on it and submit another patchset15:55
mriedemand call the logging function 'filter_duplicates' or something15:56
*** kylek3h has quit IRC15:56
openstackgerritMatthew Booth proposed openstack/nova: Remove fake_imagebackend.Raw and cleanup dependent tests  https://review.openstack.org/26766115:56
openstackgerritMatthew Booth proposed openstack/nova: Update import_file to provide a general-purpose interface  https://review.openstack.org/26766215:56
dedery_+ will mv the bug ref comments to the commit message15:56
*** vishwanathj_away is now known as vishwanathj15:57
mriedemk15:58
*** Daisy has quit IRC16:00
*** Jeffrey4l has quit IRC16:00
johnthetubaguymriedem: +1 your comments, I quite like the match up on port uuid and network uuid though, that makes good sense to me16:00
johnthetubaguythe general case at least16:00
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.firewall' options  https://review.openstack.org/25799516:00
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.netutils' options  https://review.openstack.org/25800916:00
openstackgerritStephen Finucane proposed openstack/nova: Improve 'virt.images' conf options documentation  https://review.openstack.org/25955316:00
*** Daisy has joined #openstack-nova16:00
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.imagecache' options  https://review.openstack.org/25898416:00
openstackgerritStephen Finucane proposed openstack/nova:  config options: Centralise 'virt.images' options  https://review.openstack.org/25800416:00
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.disk' options  https://review.openstack.org/25891216:01
*** doug-fis_ has quit IRC16:01
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.driver' options  https://review.openstack.org/25795616:01
openstackgerritStephen Finucane proposed openstack/nova: Improve 'virt.driver' conf options documentation  https://review.openstack.org/26636416:01
openstackgerritStephen Finucane proposed openstack/nova: Improve 'virt.firewall' conf options documentation  https://review.openstack.org/26636516:01
*** doug-fish has joined #openstack-nova16:01
*** mjura has quit IRC16:01
*** doug-fish has quit IRC16:01
*** doug-fish has joined #openstack-nova16:02
*** gongysh_ has quit IRC16:02
*** unicell has joined #openstack-nova16:04
*** Daisy has quit IRC16:05
*** belmoreira has quit IRC16:06
*** unicell1 has quit IRC16:06
*** armax has joined #openstack-nova16:06
*** yamahata has joined #openstack-nova16:06
*** doug-fish has quit IRC16:07
*** ihrachys has quit IRC16:07
*** jlanoux has quit IRC16:08
*** rotbeard has quit IRC16:09
*** salv-orlando has joined #openstack-nova16:09
mriedemdansmith: alaski: i just replied to the thread on multiattach, there is no policy in cinder against creating a multiattach volume,16:11
*** fawadkhaliq has joined #openstack-nova16:11
*** fawadkhaliq has quit IRC16:11
mriedemtheir capabilities filter will check for a host that supports multiattach based on the volume driver backends per host16:12
*** vivekd has joined #openstack-nova16:12
*** fawadkhaliq has joined #openstack-nova16:12
dansmithah16:12
mriedemso if you try to create a volume with multiattach and there are no hosts that support that, it'll fail with NoValidHost16:12
mriedemlvm supports it though16:12
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: deprecate live/block_migration_flag opts  https://review.openstack.org/26343616:12
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: remove the live/block_migration_flag opts  https://review.openstack.org/26343716:12
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: add a new live_migration_tunnelled config  https://review.openstack.org/26343416:12
mriedemso by default, the reference impl in cinder allows you to create a multiattach volume, but if you're using only xen virt drivers, you'll get NoValidHost at BFV or attach volume16:13
openstackgerritTom Patzig proposed openstack/nova-specs: Add volume option to flavors  https://review.openstack.org/26767316:13
alaskiso it fails in the same way that Nova will16:13
ildikovmriedem: 3PAR supports it too AFAIK16:13
ildikovbut the scenario is correct16:13
mriedemildikov: sure, some of the 50 cinder backends might support it16:13
*** salv-orl_ has quit IRC16:13
mriedemalaski: yeah i suppose so16:14
*** tonytan4ever has joined #openstack-nova16:14
mriedemcinder fails in the scheduler, nova fails on the compute16:14
mriedemwhich is picked based on where the instance is16:14
alaskiahh16:14
mriedemin the attach case i mean16:14
alaskibut compute failures end up looking like scheduler failures16:15
mriedemBFV is a crapshoot, unless you're using AZs or something16:15
mriedemsure16:15
markmc_diana_1, the signature utils unit tests on Fedora - does https://review.openstack.org/#/c/260277/ help?16:15
*** ashishjain has quit IRC16:16
alaskimriedem: dansmith at rax they would add a policy to disable it to move the error to the api.  not saying it's the right way, but it does provide immediate feedback16:16
*** ctrath has quit IRC16:16
mriedemyeah...16:17
dansmithalaski: we did say disabling features via policy sucks though right?16:17
alaskiyep16:17
mriedemi was going to say, that's the same as a config option in volume_api.check_attach16:17
*** yamahata has quit IRC16:18
markus_zauggy: Thanks for taking the bug skimming duty for the next 7 days. Just as a heads-up, I'm out of office tomorrow.16:18
*** yamahata has joined #openstack-nova16:18
alaskiI would like to use flavors, or flavor addons, as a way to provide some feedback about compute capabilities within a deployment16:18
*** paul-carlton2 has quit IRC16:19
mriedemalaski: dansmith: so even if we have a microversion on the attach/bfv api, you can still land on a compute that doesn't support it and blow up, which is i guess why a microversion is not required for this?16:19
mriedembut a microversion still signals,16:19
mriedemyou at least have a chance at this working, assuming hte cloud supports it16:19
dansmithright, I still like the signaling, even if it's not a guarantee16:20
alaskiagreed, it is useful16:20
dansmithbut I was expecting sdague to tell me I was abusing the infra with that suggestion :)16:20
openstackgerritSylvain Bauza proposed openstack/nova: Fix instance not destroyed after successful evacuation  https://review.openstack.org/25010116:20
*** edtubill has quit IRC16:20
bauzasdansmith: mriedem: found some corner case ^16:20
alaskidansmith: when you only have a hammer...16:20
*** edtubill has joined #openstack-nova16:20
*** diogogmt has joined #openstack-nova16:21
mriedemdansmith: well, it is an api behavior change, so it seems a microversion is warranted16:21
bauzaswhen an instance is evacuated successfully, the source host (when back up) is not able to delete it so it prevents a new migration to get back the instance to the source16:21
bauzasmriedem: dansmith: https://bugs.launchpad.net/nova/+bug/151820016:21
openstackLaunchpad bug 1518200 in OpenStack Compute (nova) "instance is not destroyed on source host after a successful evacuate" [Medium,In progress] - Assigned to Sylvain Bauza (sylvain-bauza)16:21
auggymarkus_z: np, I am doing my best!16:22
dansmithbauzas:  okay I'll look in a sec16:22
bauzasdansmith: no worries, I just thought you could be interested in because of robustify-evacuate16:22
*** tpatzig has left #openstack-nova16:22
bauzasthat's a bug, we can wait for it16:22
*** doug-fish has joined #openstack-nova16:23
bauzasbut it could be also a good candidate for liberty16:23
* bauzas goes back reviewing, yay16:23
mriedembauzas: i like that it's a list of possible values16:23
mriedemas i was reading the bug16:23
*** doug-fis_ has joined #openstack-nova16:24
bauzasmriedem: yeah I preferred to modify the DB API to accept a list rather than just doing a list comprehension like the owner did in the previous PS16:24
*** edtubill has quit IRC16:24
dedery_mriedem: going back to https://review.openstack.org/#/c/252565/8/nova/network/neutronv2/api.py and trying to apply the filter(function, items) logic to it I think that it'll become more of a mess in a way. I might be missing something here though16:24
ildikovmriedem: I assume that the microversion discussion has not much to do with when the feature can get in besides the time I would need to implement it, is this assumption correct?16:24
*** vivekd has quit IRC16:26
markus_zsfinucan: I'm reviewing your pci config change, do you have a minute for a question?16:26
johnthetubaguyalaski: dansmith: mriedem: FWIW, I like the micro version just to advertise its possible, even if we let all folks attach to multi-attach volumes16:26
sfinucanmarkus_z: Hit me16:26
*** rook-desktio has joined #openstack-nova16:27
markus_zsfinucan: I don't get the sentence "This field can be specified multiple times" for the whitelist.16:27
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: deprecate live/block_migration_flag opts  https://review.openstack.org/26343616:27
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: remove the live/block_migration_flag opts  https://review.openstack.org/26343716:27
*** doug-fish has quit IRC16:27
johnthetubaguymriedem: you made a point about only certain cinder backends supporting multi-attach, I guess thats covered by checks in cinder?16:27
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: add a new live_migration_tunnelled config  https://review.openstack.org/26343416:27
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: force use of direct vs p2p migration  https://review.openstack.org/26343216:27
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: force config related migration flags  https://review.openstack.org/26343316:27
*** ducttape_ has quit IRC16:27
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: parse live migration flags at startup  https://review.openstack.org/26343016:27
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: force use/non-use of NON_SHARED_INC flag  https://review.openstack.org/26343116:27
*** whenry has joined #openstack-nova16:27
ildikovjohnthetubaguy: if a back end does not support it you cannot create a multiattach volume16:27
alaskijohnthetubaguy: it's checked by a cinder scheduler filter16:27
*** edtubill has joined #openstack-nova16:27
*** suro-patz has joined #openstack-nova16:27
ildikovjohnthetubaguy: it will fail with an error16:28
*** Guest77121 is now known as med_16:28
*** med_ has quit IRC16:28
*** med_ has joined #openstack-nova16:28
_diana_1markmc: The signature util tests are failing for me on my mac (not fedora), but they worked fine yesterday, so I suspect I've just done something wrong upgrading openssl, but I'll give that patch a shot in a bit. Thanks!16:28
mriedemdedery_: i think i'm seeing what you mean16:28
johnthetubaguyildikov: alaski: cool, I hope that was the case16:28
*** doug-fis_ has quit IRC16:28
sfinucanmarkus_z: I took that from the spec https://github.com/openstack/nova-specs/blob/master/specs/juno/implemented/pci-passthrough-sriov.rst16:29
*** ducttape_ has joined #openstack-nova16:29
*** rook-desktio is now known as rook-desktop16:29
sfinucanHaving tested it, you can indeed specify the 'pci_passthrough_whitelist' option multiple times in your nova.conf file16:29
dedery_mriedem: and above all logic, if i want the logging to have reference to the instance i'd need to send another parameter to the filtering function - which is not possible (unless i send a tuple)16:29
sfinucanI don't know if that's "out of character" for a configuration option - the spec made me think it was hence why I brought it up16:30
markus_zsfinucan: seriously? that works?16:30
openstackgerritHans Lindgren proposed openstack/nova: Remove unused db parameter from scheduler.utils.set_vm_state_and_notify()  https://review.openstack.org/26768216:30
sfinucanmarkus_z: Sure does. Don't ask me how :)16:30
*** ctrath has joined #openstack-nova16:30
*** doug-fish has joined #openstack-nova16:30
markus_zsfinucan: I'm not sure if this is a feature or a bug...16:31
*** _diana_1 has quit IRC16:31
mriedemdedery_: yeah, maybe the filter idea doesn't work here16:31
sfinucanmarkus_z: Heh - like I said I took the spec to be the source of truth16:32
*** otter768 has joined #openstack-nova16:32
sfinucanI can remove if you don't agree with it though16:32
mriedemdedery_: so i'm ok with not using filter(), but can you cleanup the negative logic, remove the bug references, and for extra credit the test you added with the duplicate network ids - it'd be good if that validated that you logged the warning16:32
*** Daisy has joined #openstack-nova16:33
ildikovjohnthetubaguy: can somehow the multiattach be handled as a some kind of extension to the simple attach?16:33
mriedemjohnthetubaguy: re: multiattach, yeah, the cinder scheduler will filter out hosts/backends that don't support a volume create request with multiattach16:33
dedery_mriedem: np16:33
markus_zsfinucan: wuah, I need a minute to digest that. OK, I understand it now. Thanks16:33
*** omnipresent has quit IRC16:34
*** otter768 has quit IRC16:36
*** vivekd has joined #openstack-nova16:37
*** paul-carlton1 has quit IRC16:37
ildikovjohnthetubaguy: I mean basically the feature we have here is the attach, which is on the other hand a cross-project feature16:38
markus_zsfinucan: ok, wait, I think I got it. You *can* have "pci_passthrough_whitelist" multiple times in the nova.conf but only the last read value is used.16:38
ildikovjohnthetubaguy: with multiattach we kind of enable the extra function that Cinder provides16:38
markus_zsfinucan: Having it "multiple_times" means you can add the dict multiple times like in the unit test: https://github.com/openstack/nova/blob/master/nova/tests/unit/pci/test_stats.py#L20616:38
markus_zsfinucan: The examples in the spec have an *OR* relationship and a misleading description above16:39
sfinucanmarkus_z: Ah, so the spec is wrong. I'll go back and fix that, assuming I'm allowed fix something so old16:40
sfinucanas for that change, I can update the change saying as much16:40
markus_zsfinucan: let me add a few nits, takes 5 min16:41
sfinucanmarkus_z: sure :)16:41
markus_zThen push a change and I +1 it16:41
mriedembauzas: i have some concerns with the tests here https://review.openstack.org/#/c/250101/16:41
bauzasmriedem: yeah the compute test is silly, I had doubts on it16:42
mriedemildikov: re: the microversion for multiattach, that's an API change and i think it would come in N when we enable the API support16:42
bauzassince we're mocking the output, we don't really care16:42
mriedembauzas: yeah, and it's functionally equivalent to the test it's copied rom16:42
mriedem*from16:42
bauzasyeah I know16:42
*** dedery has joined #openstack-nova16:43
bauzaslike I said, I was not super overwhelmed by that16:43
bauzasone single test is enough IMHO, thanks for reviewing, will modify that16:43
mriedembauzas: or update the existing test in test_compute_mgr to set the migration status to 'done' like the new test does,16:44
mriedemthat test is a bit hokey anyway since it doesn't set the migration status16:44
mriedembut at least we could make an attempt at reality :)16:45
*** nkrinner has quit IRC16:45
*** mgoddard_ has joined #openstack-nova16:45
bauzasmriedem: yeah, I was thinking of that when saying "one single test"16:45
ildikovmriedem: ok, got it16:45
mriedemjohnthetubaguy: i saw in the nova meeting "so this afternoon, I am thinking of kicking out all blueprints that don't yet have any code up for review"16:45
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [python3] byte/string conversions and enable more tests  https://review.openstack.org/26104516:46
mriedemjohnthetubaguy: you don't think we can get code up for a bp in the next week and have it merged? :P16:46
*** zenoway has joined #openstack-nova16:46
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [python3] Port more code to python3 and enable tests  https://review.openstack.org/26208316:46
*** kylek3h has joined #openstack-nova16:46
*** kylek3h has quit IRC16:46
*** kylek3h has joined #openstack-nova16:46
openstackgerritdane-fichter proposed openstack/nova: Add image signature verification  https://review.openstack.org/18984316:46
*** jlanoux has joined #openstack-nova16:46
mriedemildikov: so with a microversion, we'd have something like the volume_api.check_attach validation in the REST API16:46
johnthetubaguymriedem: depends, what you wanting to do :)16:47
*** dedery_ has quit IRC16:47
*** dedery has quit IRC16:47
mriedemjohnthetubaguy: oh i just had a thing that i haven't gotten around to starting, but agree it's probably too late - it was a spec i revived from an operator from liberty that never posted any code16:47
openstackgerritPawel Koniszewski proposed openstack/nova: Auto converge as a default LM parameter  https://review.openstack.org/26600116:47
mriedemmy time is probably better spent reviewing non-priority bp's before 1/2116:47
johnthetubaguymriedem: its more a statement that we have more code up for review right now than we can get merged before the deadline, so lets start focusing are efforts16:47
mriedemyeah, +1 for blocking bp's with no code yet then16:48
mriedemsome people might be surprised by that, but they really shouldn't be16:48
johnthetubaguymriedem: honestly it sometimes makes code appear, and I just re-approve it for mitaka, but I didn't say that16:48
*** mgoddard has quit IRC16:48
mriedem#undo16:48
johnthetubaguyyeah, depends if it sounds really useful and looks sane16:49
johnthetubaguyits what we usually do, anyways16:49
markus_zsfinucan: I'm out of office tomorrow, If you push it in the next 15 minutes I +1 it :)16:49
*** zenoway has quit IRC16:51
ildikovmriedem: I assume it will be fine in case we enable the feature in N as the prerequisites will be in Mitaka16:51
*** kmartin has joined #openstack-nova16:51
mriedemildikov: yes, the prereqs being the bdm method calls that dansmith was working on16:51
ildikovmriedem: we need the detach code and I think we would need to figure out passing the host_name to Cinder somehow16:52
ildikovmriedem: the detach changes have to go in16:52
ildikovmriedem: we need to pass the attachment_id to Cinder16:52
mriedemin case newton api is multiattaching to mitaka computes i guess16:52
openstackgerritStephen Finucane proposed openstack/nova: Improve 'pci' conf options documentation  https://review.openstack.org/24333516:53
sfinucanmarkus_z: Done, I think16:53
ildikovmriedem: it's the same mixed environment problem16:53
markus_zchecking16:53
*** suro-patz has quit IRC16:53
ildikovmriedem: it's the prep patch: https://review.openstack.org/#/c/193134/7016:53
mriedemthomasem: you know we have an rc file in nova's tree that can be used to skip tests in the lxc job right?16:53
ildikovmriedem: only the no harm changes16:54
*** vivekd has quit IRC16:54
ildikovmriedem: it would also be needed for Cinder backends as much as I know from hemna: https://review.openstack.org/#/c/256273/16:55
thomasemmriedem: I do.16:55
thomasemmriedem: that's the one dimtruck is patching :)16:55
dimtruckmriedem: 10 mins ... i'll have it up there16:55
ildikovmriedem: not all but there is, I know that the migration is a question there16:55
dimtrucksorry for the delay..16:55
hemnayough16:55
hemnaildikov, https://review.openstack.org/#/c/266006/  that guy landed16:56
ildikovhemna: I'm listing the patches to mriedem that need to go in for Mitaka to enable multiattach in Newton16:56
hemnacinder can now accept both instance_uuid and hostname16:56
ildikovhemna: I saw thanks, tests are fine now16:56
hemnaok great :)16:56
ildikovbut I think it would be good to backport that change16:57
*** pumaranikar has joined #openstack-nova16:57
*** salv-orlando has quit IRC16:58
*** ihrachys has joined #openstack-nova16:58
*** zakora has quit IRC16:58
*** salv-orlando has joined #openstack-nova16:58
*** chhavi has quit IRC16:58
*** dslev has quit IRC16:58
mriedembackport which change?16:58
ildikovthe one that hemna linked above in Cinder16:59
markus_zsfinucan: a last tiny nit, then it should be done16:59
mriedemildikov: why does cinder liberty need that?16:59
mriedemif it's only to enable a thing for mitaka computes?16:59
*** mgoddard_ has quit IRC16:59
mriedemit's also an api change which makes backporting not fun17:00
markus_zsfinucan: In that one I mean: https://review.openstack.org/#/c/253732/817:00
*** mgoddard has joined #openstack-nova17:00
pkoniszewskihi, someone who can help me with the API? Is extension name related to policy rule name or is there a way to use different name for policy?17:00
*** chhavi has joined #openstack-nova17:00
ildikovmriedem: Nova didn't pass the host_name before17:00
ildikovmriedem: but for certain Cinder drivers that would be needed to track multiple attachments17:00
*** Sukhdev has quit IRC17:00
mriedemildikov: sure, but nova in liberty doesn't support multiattach17:01
mriedemso why does it matter?17:01
ildikovas I understand we want to prepare Mitaka computes to be able to deal with multiattach17:01
*** gszasz has quit IRC17:01
*** jlanoux has quit IRC17:01
mriedemyeah17:01
ildikovI mean in a mixed env when we will have the support in Newton17:01
mriedemand the cinder change is in mitaka17:01
*** ihrachys has quit IRC17:02
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise PCI options  https://review.openstack.org/25373217:02
openstackgerritStephen Finucane proposed openstack/nova: Improve 'pci' conf options documentation  https://review.openstack.org/24333517:02
sfinucanmarkus_z: And done :) 1 other change also (dicts)17:02
ildikovbut if we merge now the Nova side of the change then the Liberty Cinder will have issues with Mitaka Nova AFAIU17:02
*** claudiub has quit IRC17:02
*** matrohon has quit IRC17:02
ildikovmriedem: ^17:02
mriedemhmm17:03
*** ihrachys has joined #openstack-nova17:03
markus_zsfinucan: will fail. dict needs a colon17:03
markus_z;)17:03
mriedemildikov: i guess i assumed both cinder and nova would be mitaka17:03
mriedembut they don't have to be17:03
mriedemthis is what's not fun about cross-project features....17:03
hemnamriedem, +117:03
*** salv-orlando has quit IRC17:03
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise PCI options  https://review.openstack.org/25373217:03
openstackgerritStephen Finucane proposed openstack/nova: Improve 'pci' conf options documentation  https://review.openstack.org/24333517:03
sfinucanmarkus_z: grrrr17:04
*** salv-orlando has joined #openstack-nova17:04
ildikovmriedem: well, our discussions during the past week is all about that this is an ideal case that we will not have :(17:04
sfinucandone v3 :)17:04
*** _diana_1 has joined #openstack-nova17:04
mriedemi think i'd be ok with saying nova doesn't support multiattach in the api until newton, and only with cinder>=mitaka17:04
ildikovmriedem: but that backport in Cinder should not hurt I think from cross-project perspective17:04
mriedemno.....but it's also unnecessary in my mind, and it's an api change17:04
mriedemyou could argue it's needed in cinder kilo too17:04
ildikovyeah, but we have to prepare the Mitaka computes for proper detach and attach17:05
ildikovto send all the info to Cinder that it needs17:05
ildikovotherwise we will not have this feature in Newton either17:05
*** jwcroppe has quit IRC17:05
mriedemyes, and i'm saying, i think it's ok to say, in docs, that you need to have cinder>=mitaka for multiattach to work,17:05
mriedembecause that's when nova started supporting it in computes17:05
*** dslev has joined #openstack-nova17:06
ildikovbut passing the host_name has nothing to do with multiattach on the first place17:06
mriedemif the cinder team wants to backport that change to support newton nova talking to mitaka nova-compute talking to liberty cinder, then i guess that's up to the cinder team17:06
ildikovthat backport note was for the Cinder change17:06
mriedemi know17:07
ildikovmy point here is only that i need the first patch in my chain to land for Mitaka and AFAIK the second would be needed too17:07
mriedembut the cinder change is so https://review.openstack.org/#/c/256273/ in nova works, right?17:07
openstackgerritWang Bo proposed openstack/nova: Fix indexing of dict.keys() in python3  https://review.openstack.org/26770817:07
mriedemand if https://review.openstack.org/#/c/256273/ is only in nova mitaka, then we're covered i think17:07
openstackgerritHans Lindgren proposed openstack/nova: Use TimeFixture from oslo_utils in functional tests  https://review.openstack.org/26770917:07
ildikovmriedem: yeah, it works, the tests are pretty green now, the red ones are not my fault this time :)17:08
markus_zsfinucan: FYI, I'm out of office tomorrow. I'll do a review day on Monday.17:08
markus_z<= bottleneck17:08
mriedemto summarize, i guess i really only care about nova here. if someone tries multiattach with a liberty cinder and things are not working and https://review.openstack.org/#/c/266006/ is the fix, then i guess they can pick that up17:08
*** jwcroppe has joined #openstack-nova17:09
*** dslev has quit IRC17:09
*** jwcroppe has quit IRC17:09
mriedemanyway, i have a lunch date so have to run for awhile17:09
*** mriedem is now known as mriedem_lunch17:09
ildikovmriedem: sure, I just answered to your question, but it's on hemna what will happen with that patch, no question about that17:09
ildikovmriedem_lunch: I have to run too, be back later17:10
*** raildo is now known as raildo-afk17:12
*** ctrath has quit IRC17:13
*** paul-carlton2 has joined #openstack-nova17:13
_diana_1markmc: Silly me. I already have that patch. Tests are failing for me on an up-to-date master which includes that merged patch. Thanks though.17:13
*** markus_z has quit IRC17:14
hemnawell, if we want to backport it to liberty we can try17:16
hemnathat has to go through the backport process, approval17:16
hemnaand would need a bug associated with it17:17
hemnawhich there isn't now17:17
ildikovhemna: yeah, we have only the lvm driver bug17:17
hemnawhich is only associated with the multiattach code that hasn't landed.....17:17
hemnaso....17:17
hemnachicken....egg....17:17
*** Daisy has quit IRC17:18
ildikovhemna: we could call it proactivity too ;)17:19
ildikovhemna: I need to run now, I'll be back later17:19
*** ildikov is now known as ildikov_afk17:19
*** raildo-afk is now known as raildo17:20
*** jlanoux has joined #openstack-nova17:20
*** zenoway has joined #openstack-nova17:22
openstackgerritDan Smith proposed openstack/nova: Fix undetected races when getting BDMs by volume id  https://review.openstack.org/26716917:23
*** tjones has joined #openstack-nova17:23
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/api directory  https://review.openstack.org/25818017:23
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (2)  https://review.openstack.org/26058717:23
*** dslevin has joined #openstack-nova17:23
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (1)  https://review.openstack.org/26058617:23
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (3)  https://review.openstack.org/26058817:23
*** garyk has quit IRC17:23
*** klkumar has quit IRC17:24
*** carey has joined #openstack-nova17:25
*** garyk has joined #openstack-nova17:26
*** apoorvad has joined #openstack-nova17:26
*** zenoway has quit IRC17:26
*** ctrath has joined #openstack-nova17:26
openstackgerritDimitry Ushakov proposed openstack/nova: (lxc) Updated regex to ignore failing tests  https://review.openstack.org/26772417:27
*** scheuran has quit IRC17:27
*** nikhil_k has joined #openstack-nova17:27
*** jistr has quit IRC17:29
*** salv-orlando has quit IRC17:29
*** nikhil has quit IRC17:29
*** salv-orlando has joined #openstack-nova17:29
*** carey has quit IRC17:30
*** smatzek has quit IRC17:33
openstackgerritHans Lindgren proposed openstack/nova: Remove unused db parameter from scheduler.utils.set_vm_state_and_notify()  https://review.openstack.org/26768217:33
*** unicell has quit IRC17:34
*** lpetrut1 has joined #openstack-nova17:35
*** lpetrut has quit IRC17:36
*** nic has joined #openstack-nova17:38
*** lpetrut1 has quit IRC17:39
*** tjones has quit IRC17:40
*** ihrachys has quit IRC17:40
*** sahid has quit IRC17:40
*** sfinucan has quit IRC17:40
openstackgerritSylvain Bauza proposed openstack/nova: Fix instance not destroyed after successful evacuation  https://review.openstack.org/25010117:40
*** e0ne has quit IRC17:40
*** haomaiwang has joined #openstack-nova17:41
*** tjones has joined #openstack-nova17:42
*** tjones has quit IRC17:42
*** haomaiwang has quit IRC17:44
*** moshele has quit IRC17:44
*** ihrachys has joined #openstack-nova17:45
*** eil397 has joined #openstack-nova17:45
*** chhavi has quit IRC17:47
*** paul-carlton2 has quit IRC17:48
*** cdent has quit IRC17:49
*** tjones has joined #openstack-nova17:50
*** burt has joined #openstack-nova17:54
*** edtubill has quit IRC17:56
*** edtubill has joined #openstack-nova17:57
*** tonytan4ever has quit IRC17:57
*** zenoway has joined #openstack-nova17:57
openstackgerritDina Belova proposed openstack/nova: Integrate OSprofiler and Nova  https://review.openstack.org/25470317:57
*** suro-patz has joined #openstack-nova17:58
*** mriedem_lunch has quit IRC17:58
*** paul-carlton2 has joined #openstack-nova18:00
*** ndipanov has quit IRC18:00
*** zenoway has quit IRC18:01
*** unicell has joined #openstack-nova18:01
*** daemontool has quit IRC18:01
*** unicell has quit IRC18:01
*** unicell has joined #openstack-nova18:01
*** mriedem has joined #openstack-nova18:02
mriedemdansmith: let's bring it on home https://review.openstack.org/#/c/264817/18:03
*** ssurana has joined #openstack-nova18:03
*** ociuhandu has quit IRC18:03
dansmithgot it18:03
*** derekh has quit IRC18:05
*** ihrachys has quit IRC18:06
*** fesp has joined #openstack-nova18:09
*** fesp has quit IRC18:09
*** ihrachys has joined #openstack-nova18:10
*** nikhil_k is now known as nikhil18:11
mriedemdansmith: last comment on this one https://review.openstack.org/#/c/267169/5/nova/objects/block_device.py18:12
mriedemwhich is a redo comment from the last ps18:12
*** changbl has joined #openstack-nova18:13
mriedemnic: you have a merge conflict on this now https://review.openstack.org/#/c/205282/18:13
mriedemnic: let me go through your replies to my last review first18:13
mriedemi see notmorgan has input on liking 166 LOC untestable methods :)18:14
notmorganmriedem: i dislike splitting a method out into something crazy complex too18:16
nicmriedem: yes, I saw that and have them resolved18:16
notmorganmriedem: i am also not nova core so...18:16
notmorganmriedem: ;)18:16
nicI'm just verifying that the base unit tests still work before bugging Gerrit with it18:16
mriedemcrazy complex?18:17
mriedemnotmorgan: there are just several several-hundred+ LOC methods in the libvirt driver, and i kind of hate seeing those get bigger and gorpier18:17
mriedemhell we kicked the vmware driver in the nuts for 2 milestones for that reason18:17
mriedemnic: to be clear, i'm not saying you have to split that code out into a separate function, i'm just explaining why i was raising it18:18
nicIt's only long because of PEP8 line-wrapping constraints; it really only does like 5 things18:18
*** vishwanathj is now known as vishwanathj_18:18
* notmorgan kindof wishes we'd increate line-length to 120char18:18
mriedemstill, to test that case, you have to mock out the 100+ LOC above it18:18
mriedemwhich blows and is not really unity testing18:18
mriedemwhich is to say, it's hard to tell when we actually have test coverage on something18:19
mriedemlike has always been an issue in the vmware driver code, which is why we kicked them in said nuts to break it up18:19
mriedem</rant>18:19
*** tonytan4ever has joined #openstack-nova18:20
*** edtubill has quit IRC18:21
*** ihrachys has quit IRC18:23
*** whenry has quit IRC18:24
dansmithmriedem: oh sorry I forgot to commit my comment18:25
dansmithmriedem:  I said: I don't normally write (or ask for) tests that verify that some log statement was run18:25
dansmithmriedem: we have a couple examples18:25
dansmithmriedem: if you think it's important I can do it, but I don't really think it is18:25
mriedemdansmith: not really so much for the log statement, but just the case that you get back more than 1 bdm18:27
mriedemright now the tests for that method all return a list with 1 entry18:27
*** danpb has quit IRC18:27
dansmithmriedem: you mean just a test that verifies it gives you back your first item?18:28
mriedemyeah18:28
dansmithmriedem: you commented on the if statement, which only controls the log... so I was confused18:28
dansmithsure I can do that18:28
mriedemi assume you can read my thoughts by now18:28
*** atuvenie has joined #openstack-nova18:28
dansmithmriedem: I didn't mean to hit you baby18:30
dansmithmriedem: if I put something bogus as a second item in a returned set that would explode if we tried to process it, it'll ensure we're only pulling the first18:30
dansmithso I'll do that18:30
dansmiththusly:18:31
*** annegentle has joined #openstack-nova18:31
openstackgerritDan Smith proposed openstack/nova: Fix undetected races when getting BDMs by volume id  https://review.openstack.org/26716918:31
mriedemslick18:31
*** irenab has quit IRC18:32
openstackgerritMatt Riedemann proposed openstack/nova: Adapt the code to the new get_by_volume BDM functions  https://review.openstack.org/26746418:32
*** jaosorior has quit IRC18:33
*** otter768 has joined #openstack-nova18:33
*** irenab has joined #openstack-nova18:33
*** ssurana has quit IRC18:34
openstackgerritNicolas Simonds proposed openstack/nova: libvirt: Fix/implement revert-resize for RBD-backed images  https://review.openstack.org/18739518:35
openstackgerritNicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available  https://review.openstack.org/20528218:35
*** changbl has quit IRC18:35
nicmriedem: ta-da!18:35
*** paul-carlton2 has quit IRC18:35
mriedemstill reviewing replies to ps2418:35
*** irenab has quit IRC18:35
mriedemoh there is a dependent change isn't there...18:36
nicThere is now18:36
*** moshele has joined #openstack-nova18:36
nicI was hoping it would have merged on its own long before now, because there is overlapping functionality18:37
*** femnad has quit IRC18:37
*** irenab has joined #openstack-nova18:37
nicAnd the bit-rot over the past 1+ years made them diverge a bit18:37
*** otter768 has quit IRC18:37
nicSo now they're explicitly dependent, and harmonized18:38
*** jichen has joined #openstack-nova18:38
*** jlanoux has quit IRC18:38
*** rdopiera has quit IRC18:38
openstackgerritRyan Rossiter proposed openstack/nova: Remove DictCompat from FixedIP  https://review.openstack.org/26595118:40
openstackgerritRyan Rossiter proposed openstack/nova: Add tests for floating_ip private functions  https://review.openstack.org/26776818:40
*** tjones has quit IRC18:40
openstackgerritdane-fichter proposed openstack/nova: Add image signature verification  https://review.openstack.org/18984318:41
*** harlowja_at_home has joined #openstack-nova18:42
*** yassine_ has quit IRC18:42
*** ajayaa has quit IRC18:42
mriedemnic: my replies are posted in ps24 now https://review.openstack.org/#/c/205282/2418:42
mriedemi'll have to see what's changed since then18:42
*** rlrossit has quit IRC18:43
*** tjones has joined #openstack-nova18:43
*** rlrossit has joined #openstack-nova18:43
*** rlrossit_ has joined #openstack-nova18:46
*** rlrossit has quit IRC18:47
*** rlrossit has joined #openstack-nova18:47
*** e0ne has joined #openstack-nova18:48
*** aix has quit IRC18:49
rlrossitdoffm: https://xkcd.com/1172/18:49
*** zenoway has joined #openstack-nova18:50
dansmithtojuvone: I think that cinder failure means it's not your problem18:50
*** vilobhmm11 has joined #openstack-nova18:50
tojuvonedansmith: Yes, I also do not understand why it would be. Also do not see relation to change after which is coming18:51
*** rlrossit_ has quit IRC18:51
dansmithyeah, I'm not sure where to dig in,18:51
dansmithbecause I don't see any actual fails18:51
tojuvonedansmith: still I looked 24h back the failed gate-grenade-dsvm-multinode and no similar18:52
*** Marga_ has joined #openstack-nova18:52
dansmithsdague: where do I look to see why this failed? http://logs.openstack.org/62/267062/3/check/gate-grenade-dsvm-multinode/27b0239/logs/grenade.sh.txt.gz#_2016-01-14_07_46_55_34618:52
*** SourabhP has joined #openstack-nova18:52
tojuvonedansmith: but there is now 5 times the same failure reproduced on 241562 or 26706218:52
dansmithtojuvone: well, hmm, that's a bad sign18:53
tojuvonedansmith: so that makes me wonder and also as it has the jenkins -118:53
nicmriedem: thanks, expect another revision soon18:53
openstackgerritAndrey Pavlov proposed openstack/nova: remove EC2 legacy code  https://review.openstack.org/26642518:55
rlrossitdims: if you have a chance, could you take a look at https://review.openstack.org/#/c/266960/2 ? If I'm on the right track, I'll make the same changes in neutron and cinder (at least) for it.18:55
tojuvonedansmith: The fact it comes in both would indicate it could be because 26706218:55
*** smatzek has joined #openstack-nova18:55
dimsrlrossit : on it18:55
dansmithtojuvone: yeah, but I would expect to see some fails in the n-api log or something18:55
mriedemnic: hold up18:55
mriedemnic: i'm going through your latest18:55
tojuvonedansmith: Yes, still makes no sense18:55
dansmithtojuvone: mriedem might know if this is known18:56
tojuvonemdiedem: here would be one: http://logs.openstack.org/62/241562/17/check/gate-grenade-dsvm-multinode/c4304a6/18:57
dimsrlrossit : i'd recommend cutting a fake ceilometer review with a Depends-On to this Nova review to see if it works18:57
mriedemnic: ok, comments posted on latest change18:57
dimsrlrossit : looks good!18:57
tojuvonemriedem: :) now got right18:57
rlrossitdims: cool! I'll get that ceilometer review up as soon as I can18:58
dimsrlrossit : ceilometer is the only one that has tests that use the actual notifications generated18:58
* rlrossit wonders if nova should have functional tests for that18:58
*** ctrath has quit IRC18:58
mriedemtojuvone: this? http://logs.openstack.org/62/241562/17/check/gate-grenade-dsvm-multinode/c4304a6/logs/grenade.sh.txt.gz#_2016-01-13_22_57_38_66118:58
mriedemrlrossit: probably18:58
rlrossitI think some of gibi's changes for versioned notifications added some? Or maybe I'm just imagining it18:59
mriedemthere are unit tests that use the fake_notifier and asserts those18:59
*** PaulMurray is now known as ptm_away18:59
mriedemsee fake_notifier usage in nova.tests.unit.compute.test_compute18:59
tojuvonemriedem: Yes, it points there and have not seen same in other console.logs as error code18:59
*** ihrachys has joined #openstack-nova18:59
tojuvonemdiedem: I mean from other grenade failed cases in 24h.18:59
mriedemtojuvone: so the actual timeout for the server delete is here http://logs.openstack.org/62/241562/17/check/gate-grenade-dsvm-multinode/c4304a6/logs/grenade.sh.txt.gz#_2016-01-13_22_57_06_50819:00
rlrossitdims: is there documentation in oslo.messaging for how to config the notification transport vs. the regular transport?19:00
tojuvonemriedem: yes19:00
mriedemtojuvone: have you checked the n-cpu logs for that?19:00
mriedemtojuvone: this looks not good http://logs.openstack.org/62/241562/17/check/gate-grenade-dsvm-multinode/c4304a6/logs/subnode-2/old/screen-n-cpu.txt.gz#_2016-01-13_22_57_08_45319:02
mriedemrlrossit: dansmith: ^ remind you of something?19:02
dansmithoh dangit19:02
dansmithI always forget about the subnode directory19:02
*** angdraug has quit IRC19:02
rlrossitmriedem: wow throwing back to my first days in nova19:02
dimsrlrossit : first thing to check is if new config options are not set if it still works. it should fall back to the same config option used for rpc.19:03
rlrossitdims: agreed. I was hoping it would do that19:03
rlrossitor else we have ourselves an UpgradeImpact :(19:03
*** ihrachys has quit IRC19:03
dimsrlrossit : once we get past that then we can add a "[oslo_messaging_notifications]" section with transport_url in say a devstack patch19:04
dimsrlrossit : yep!19:04
dansmithtojuvone: you forgot to call super in obj_make_compatible() :)19:04
dansmithtojuvone: I missed it19:04
tojuvonemriedem: yes19:04
mriedemjdurgin: jbernard: have you guys reviewed this in awhile? https://review.openstack.org/#/c/187395/19:04
jbernardmriedem: no, it's on my list though19:05
tojuvonedansmith: ok, might that cause problem.19:05
dansmithtojuvone: yeah it means the version never gets set, which means it keeps kicking it back for backporting :)19:06
*** annegentle has quit IRC19:06
*** annegentle has joined #openstack-nova19:06
*** jaypipes has quit IRC19:07
tojuvonedansmith: Actually figured if something in code would cause this, it would be that function as only real change19:07
*** tjones has quit IRC19:08
*** jwcroppe has joined #openstack-nova19:08
dansmithyeah19:10
*** tonytan4ever has quit IRC19:11
*** omnipresent has joined #openstack-nova19:12
tojuvonedansmith, mriedem: Thanks :)19:12
*** tonytan4ever has joined #openstack-nova19:12
dansmithyep19:12
*** jwcroppe has quit IRC19:13
*** ZZelle_ has joined #openstack-nova19:14
*** zenoway has quit IRC19:15
*** ihrachys has joined #openstack-nova19:16
*** tjones has joined #openstack-nova19:16
*** ssurana has joined #openstack-nova19:17
*** fawadkhaliq has quit IRC19:17
*** fawadkhaliq has joined #openstack-nova19:17
*** Daisy has joined #openstack-nova19:18
*** fawadkhaliq has quit IRC19:19
tojuvoneand yet the light year with my machine for testing that I do not break anything (else).19:20
*** yamahata has quit IRC19:21
sdaguedansmith: probably n-cpu new19:22
*** claudiub has joined #openstack-nova19:23
*** mvensky has joined #openstack-nova19:23
dansmithsdague: n-cpu old actually.. I always forget to look for that nested directory19:23
*** ihrachys has quit IRC19:23
sdagueit's the destroy, that should be on the new side19:23
sdagueI mean, a failed create would probably explain why the destroy fails19:24
sdaguealthough, that doesn't actually make sense. We've sshed into that guest by that time19:25
*** carey has joined #openstack-nova19:26
*** dedery has joined #openstack-nova19:28
*** dedery has quit IRC19:28
*** dedery_ has joined #openstack-nova19:28
*** ssurana has quit IRC19:28
*** suro-patz has quit IRC19:30
*** haomaiwang has joined #openstack-nova19:30
*** carey has quit IRC19:31
*** gangil has joined #openstack-nova19:31
*** gangil has quit IRC19:31
*** gangil has joined #openstack-nova19:31
*** cdent has joined #openstack-nova19:33
*** vilobhmm11 has quit IRC19:33
*** ociuhandu has joined #openstack-nova19:33
*** vilobhmm11 has joined #openstack-nova19:33
dedery_mriedem: ping19:34
*** vilobhmm11 has quit IRC19:34
mriedempong19:34
*** suro-patz has joined #openstack-nova19:34
*** vilobhmm11 has joined #openstack-nova19:34
*** haomaiwang has quit IRC19:34
*** vilobhmm11 has quit IRC19:35
*** vilobhmm11 has joined #openstack-nova19:35
dedery_mriedem: hi :), looking at https://review.openstack.org/#/c/252565/8/nova/tests/unit/network/test_neutronv2.py and trying to add the mock for the log it seems that it's going to add some bad code on bad code.19:35
*** ihrachys has joined #openstack-nova19:36
*** lpetrut has joined #openstack-nova19:36
dedery_If you open the full code you'd see that _fake_get_instance_nw_info_helper is mimicking the _gather_port_ids_and_networks logic (see the comment by john about the cut and paste of the real logic)19:36
mriedemdedery_: i'd recommend that the new test is not put in TestNeutronV219:37
mriedemb/c that uses all of that crazy crap moxed setup stuff in the base class19:37
mriedemput the new test in TestNeutronv2WithMock19:38
mriedemeverything in TestNeutronV2 is kind of aweful b/c of the mega setup19:38
mriedem*awful19:39
*** ctrath has joined #openstack-nova19:39
*** pratikma_ has quit IRC19:39
dedery_agree. ok. mv to *WithMock. 10x19:39
*** annegent_ has joined #openstack-nova19:40
*** ccarmack has quit IRC19:42
dedery_mriedem: do you think that I should leave the copied logic in L.800-809?19:42
openstackgerritTomi Juvonen proposed openstack/nova: Add object and database support for host_status API  https://review.openstack.org/26706219:43
*** tonytan4ever has quit IRC19:43
*** annegentle has quit IRC19:43
*** diogogmt has quit IRC19:43
mriedemdedery_: does it need to be in there for the test to pass?19:43
mriedemor only for your new test?19:43
*** SourabhP has quit IRC19:44
dedery_no, only for my new test.19:44
mriedemremove it19:44
mriedem"""Helper function to test get_instance_nw_info.19:44
*** Daisy has quit IRC19:44
mriedem"""Helper function to rewrite the actual code and not test it, you're welcome"""19:44
dedery_yeh, it's bad...19:45
mriedemdedery_: just write a new test with mock in TestNeutronV2WithMock19:45
dedery_k19:45
*** Sukhdev has joined #openstack-nova19:45
mriedemthe other stuff should be burned19:45
mriedembut for some reason dansmith refuses to let it go19:45
openstackgerritsean mooney proposed openstack/os-vif: reorder tox envlist to run python 3.4 before 2.7  https://review.openstack.org/26779119:45
*** pratikmallya has joined #openstack-nova19:46
*** SourabhP has joined #openstack-nova19:49
*** atuvenie has quit IRC19:50
*** ihrachys has quit IRC19:50
*** ihrachys has joined #openstack-nova19:50
*** yamahata has joined #openstack-nova19:50
*** nelsnelson has quit IRC19:51
*** rlrossit has quit IRC19:51
*** nelsnelson has joined #openstack-nova19:51
openstackgerritsean mooney proposed openstack/os-vif: remove python 2.6 trove classifier  https://review.openstack.org/26779219:52
*** diogogmt has joined #openstack-nova19:53
*** ijw has quit IRC19:54
*** tjones has quit IRC19:54
*** lucasagomes is now known as lucas-dinner19:55
*** tjones has joined #openstack-nova19:55
*** tjones has quit IRC19:55
openstackgerritNicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available  https://review.openstack.org/20528219:55
*** tjones has joined #openstack-nova19:55
*** rlrossit has joined #openstack-nova19:56
*** rfolco has quit IRC19:56
*** eil397 has quit IRC19:58
*** yamahata has quit IRC19:58
*** yamahata has joined #openstack-nova19:59
*** gangil has quit IRC19:59
*** vilobhmm11 has quit IRC20:00
*** vilobhmm11 has joined #openstack-nova20:00
*** ctrath has quit IRC20:02
*** ctrath has joined #openstack-nova20:03
openstackgerritTimofey Durakov proposed openstack/nova: Ceph for live-migration job  https://review.openstack.org/25228320:03
mriedemBobBall: citrix xenserver ci is having some mirror issues http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/69/267169/6/2878/run_tests.log20:03
openstackgerritjichenjc proposed openstack/nova: WIP:remove OS-EXT-IPS and OS-EXT-IPS-MAC extension  https://review.openstack.org/26653320:03
*** ccarmack has joined #openstack-nova20:04
*** tjones has quit IRC20:05
*** gangil has joined #openstack-nova20:05
*** gangil has joined #openstack-nova20:05
*** pratikmallya has quit IRC20:05
*** artom_ has quit IRC20:06
openstackgerritAndrey Pavlov proposed openstack/nova: remove EC2 legacy code  https://review.openstack.org/26642520:07
*** ihrachys has quit IRC20:08
*** ihrachys has joined #openstack-nova20:08
*** armax has quit IRC20:09
*** armax has joined #openstack-nova20:09
*** jwcroppe has joined #openstack-nova20:09
*** josecastroleon has quit IRC20:10
*** josecastroleon has joined #openstack-nova20:12
*** ctrath has quit IRC20:16
*** eil397 has joined #openstack-nova20:17
*** ctrath has joined #openstack-nova20:17
*** ctrath has quit IRC20:17
*** penick has joined #openstack-nova20:18
*** Marga_ has quit IRC20:18
*** Marga_ has joined #openstack-nova20:18
*** eil397 has quit IRC20:19
*** irenab has quit IRC20:19
*** eil397 has joined #openstack-nova20:19
*** jwcroppe has quit IRC20:20
*** suro-patz has quit IRC20:22
*** irenab has joined #openstack-nova20:22
*** penick has quit IRC20:22
*** vilobhmm11 has quit IRC20:23
*** vilobhmm11 has joined #openstack-nova20:23
*** vilobhmm11 has quit IRC20:23
*** vilobhmm11 has joined #openstack-nova20:24
*** vilobhmm11 has quit IRC20:24
mriedemstable cores, need this in before we cut the 12.0.1 release20:24
mriedemhttps://review.openstack.org/#/c/267178/20:24
mriedemthe dependent change is in the gate20:24
mriedemdansmith: sdague: mikal: claudiub: ^20:24
mriedemmtreinish: ^20:24
bauzasmriedem: we're all good with the other changes, right?20:25
sdaguemriedem: +@20:25
sdague+220:25
mriedembauzas: yeah20:25
mriedemjust waiting to merge20:25
* bauzas litterally had no time to look thru20:25
bauzasokay20:25
mriedemi went through the git log today20:25
*** vilobhmm11 has joined #openstack-nova20:25
*** vilobhmm11 has quit IRC20:26
*** vilobhmm11 has joined #openstack-nova20:26
dansmith+W20:26
bauzasmriedem: just FYI, I prefer to update preludes separately given that http://docs-draft.openstack.org/78/267178/1/check/gate-nova-releasenotes/e7bdcb0//releasenotes/build/html/unreleased.html20:28
bauzasmriedem: but it's okay for that one20:28
mriedemupdate preludes separately?20:28
mriedemyou mean 1 release note per bug?20:28
bauzasthe main problem with preludes is that all the phrases are mixed in the same section, why it's good to provide the prelude by like the last patch as a summary20:29
mriedemto avoid the duplication20:29
mriedemyeah, that's why i phrased it that way20:29
bauzasmriedem: here we're fine because it's for a point release20:29
bauzasand it will be very probably the last change before tagging it20:29
mriedemat the end of mitaka, i think we'd be hard pressed to come up with a prelude summary that doesn't miss something20:30
bauzasexactly20:30
bauzashence me not okay if anyone providing a prelude section in a relnote20:30
mriedemwell, i think it depends on what it is20:30
bauzasagain, here it's okay20:30
bauzashttp://docs.openstack.org/developer/nova/code-review.html#when-a-release-note-is-needed20:31
bauzas"Don’t use them unless you know exactly what you are doing."20:31
bauzas:p20:31
mriedemyeah i know20:31
mriedemwe're on the same team here bauzas!20:31
*** unicell1 has joined #openstack-nova20:31
bauzaseven with a bad english phrasing :p20:31
*** vilobhmm11 has quit IRC20:32
openstackgerritChuck Carmack proposed openstack/nova: OREST API changes for user settable server description  https://review.openstack.org/25495020:32
bauzasmriedem: yeah totally in the same line, just trying to explain why I provided a gerrit comment ( just to make sure other people understand why *not* providing preludes)20:32
*** unicell has quit IRC20:32
*** svenno has quit IRC20:32
mriedembauzas: btw, unrelated, i've started reading an 860 page book on napolean20:33
bauzasmeh20:33
mriedemwah!20:33
bauzasI'm probably not a good French guy because I dislike him :)20:34
mriedemi'll let you know how it turns out in a year when i finish it20:34
*** otter768 has joined #openstack-nova20:34
bauzasbut sure, you'll see20:34
openstackgerritChuck Carmack proposed openstack/nova: REST API changes for user settable server description  https://review.openstack.org/25495020:34
*** vilobhmm11 has joined #openstack-nova20:34
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/26616020:35
*** annegent_ has quit IRC20:36
*** matrohon has joined #openstack-nova20:37
*** ihrachys has quit IRC20:37
*** toure has quit IRC20:38
*** penick has joined #openstack-nova20:38
*** otter768 has quit IRC20:39
*** rlrossit has quit IRC20:41
openstackgerritMatt Riedemann proposed openstack/nova: Adapt the code to the new get_by_volume BDM functions  https://review.openstack.org/26746420:41
openstackgerritMatt Riedemann proposed openstack/nova: Fix undetected races when getting BDMs by volume id  https://review.openstack.org/26716920:41
*** cdent has quit IRC20:42
*** Daisy has joined #openstack-nova20:42
*** mvensky has quit IRC20:42
*** mvensky_ has joined #openstack-nova20:42
openstackgerritAugustina Ragwitz proposed openstack/nova: Add test coverage to functional api tests _compare_result method  https://review.openstack.org/26344020:43
*** tonytan4ever has joined #openstack-nova20:44
openstackgerritNicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available  https://review.openstack.org/20528220:45
*** dkliban has joined #openstack-nova20:45
openstackgerritChuck Carmack proposed openstack/nova: REST API changes for user settable server description  https://review.openstack.org/25495020:46
mriedeminteresting re: multiattach https://review.openstack.org/#/c/110319/20:46
*** rlrossit_ has joined #openstack-nova20:47
*** ctrath has joined #openstack-nova20:47
sdaguectrl-s fake ... rinse... repeat20:48
*** ihrachys has joined #openstack-nova20:52
*** Sukhdev has quit IRC20:55
*** rlrossit_ has quit IRC21:00
hemnanice21:01
*** rlrossit has joined #openstack-nova21:03
*** ssurana has joined #openstack-nova21:03
*** Daisy has quit IRC21:03
*** pratikmallya has joined #openstack-nova21:06
*** pratikmallya has quit IRC21:07
*** pratikmallya has joined #openstack-nova21:08
*** ssurana has quit IRC21:08
*** jwang_ has quit IRC21:08
openstackgerritDimitry Ushakov proposed openstack/nova: (lxc) Updated regex to ignore failing tests  https://review.openstack.org/26772421:08
*** raildo is now known as raildo-afk21:09
sdagueoh, neat, there are actually a bunch of 404 tests that are 404ing for the wrong reason....21:09
*** pratikma_ has joined #openstack-nova21:09
*** ankita has joined #openstack-nova21:11
ankitaHi, Are scheduler.run_instance.* events sent in nova kilo ? Has the queue changed ?21:11
*** jwang has joined #openstack-nova21:12
*** smatzek has quit IRC21:12
*** gangil has quit IRC21:12
*** pratikmallya has quit IRC21:13
*** annegentle has joined #openstack-nova21:15
*** apoorvad has quit IRC21:17
*** jwcroppe has joined #openstack-nova21:17
openstackgerritMark Doffman proposed openstack/nova: Make os-instance-action read deleted instances.  https://review.openstack.org/25308721:20
openstackgerritMatt Riedemann proposed openstack/nova: Remove dead code from reserve_block_device_name rpcapi  https://review.openstack.org/26782221:25
*** ihrachys has quit IRC21:25
*** ihrachys has joined #openstack-nova21:26
*** changbl has joined #openstack-nova21:27
*** carey has joined #openstack-nova21:27
*** gangil has joined #openstack-nova21:27
*** gangil has joined #openstack-nova21:27
*** diogogmt has quit IRC21:27
*** harlowja has quit IRC21:27
*** aix has joined #openstack-nova21:28
openstackgerritdane-fichter proposed openstack/nova: Add image signature verification  https://review.openstack.org/18984321:28
*** StevenK has quit IRC21:30
*** ssurana has joined #openstack-nova21:30
*** jwcroppe has quit IRC21:31
*** StevenK has joined #openstack-nova21:31
*** vilobhmm11 has quit IRC21:31
*** carey has quit IRC21:32
*** vilobhmm11 has joined #openstack-nova21:32
*** aysyd has quit IRC21:32
*** vilobhmm11 has quit IRC21:32
*** akshai has quit IRC21:32
*** vilobhmm11 has joined #openstack-nova21:32
*** gjayavelu has joined #openstack-nova21:33
*** irenab has quit IRC21:33
*** irenab has joined #openstack-nova21:34
*** ssurana has quit IRC21:35
*** jichen has quit IRC21:35
*** irenab has quit IRC21:36
nicmriedem: I *think* the current patch set for the RBD stuffs addresses everything you were concerned about21:36
*** ankita_w_ has joined #openstack-nova21:36
*** akshai has joined #openstack-nova21:37
mriedemnic: yeah, will probably get back to that tomorrow. i haven't reviewed the tests or test coverage yet either.21:37
mriedemnic: and i'll probably put more time into the dependent change first21:37
*** pratikma_ has quit IRC21:37
*** irenab has joined #openstack-nova21:38
nicCareful with it; it's an antique…  :-P21:38
mriedemsdague: user_id and project_id should be uuid right?21:39
openstackgerritMark Doffman proposed openstack/nova: Move logging outside of LibvirtConfigObject.to_xml  https://review.openstack.org/22421621:39
mriedemdansmith: was someone working on converting the instance action object fields for user_id and project_id to be uuid fields rather than strings?21:40
*** irenab has quit IRC21:40
mriedemi think the only issue there is all of the test cleanup that is required21:40
*** shakamunyi has quit IRC21:40
*** mdrabe_ has joined #openstack-nova21:40
dansmithmriedem: well, migi is working on fixing a bunch of tests so we can do some uuid cleanups yeah21:40
*** dkliban has left #openstack-nova21:40
*** suro-patz has joined #openstack-nova21:41
alaskiI don't think project_id can be converted to uuid21:41
alaskifor the same reason that the api can't assume a uuid21:41
*** diogogmt has joined #openstack-nova21:42
openstackgerritAndrew Laski proposed openstack/nova: WIP Populate instance_mappings during boot.  https://review.openstack.org/26392521:42
openstackgerritAndrew Laski proposed openstack/nova: WIP Map instances to cell0 on failed schedule  https://review.openstack.org/26782721:42
openstackgerritAndrew Laski proposed openstack/nova: WIP Create instance mapping when instance is scheduled  https://review.openstack.org/26782821:42
*** eil397 has quit IRC21:42
*** irenab has joined #openstack-nova21:42
*** dims has quit IRC21:42
*** dims_ has joined #openstack-nova21:42
alaskidoffm: https://review.openstack.org/267827 shows the usage of cell0 I was thinking, just needs to be built out :)21:42
alaskimelwitt: https://review.openstack.org/267828 is what I was thinking for using the first created cell21:43
*** apoorvad has joined #openstack-nova21:43
*** mdrabe has quit IRC21:44
*** thumpba has quit IRC21:44
*** thumpba has joined #openstack-nova21:45
doffmalaski: Thanks. Will take a look.21:46
*** harlowja_at_home has quit IRC21:47
dansmithman, jenkins is busy these days21:47
*** vilobhmm11 has quit IRC21:48
*** thumpba has quit IRC21:49
*** jamielennox|away is now known as jamielennox21:49
*** vilobhmm11 has joined #openstack-nova21:50
*** vilobhmm11 has quit IRC21:51
*** vilobhmm11 has joined #openstack-nova21:51
*** mdrabe__ has joined #openstack-nova21:51
*** cdelatte has quit IRC21:52
*** mdrabe_ has quit IRC21:55
*** armax has quit IRC21:55
*** Sukhdev has joined #openstack-nova21:55
doffmalaski: Thanks, looks good. I suppose that if we were to do what was discussed the other day and make cell0 just a normal cell used for dumping purposes then the cell0 id would be configurable. I'll leave it for now though as a special 000000 id.22:00
*** thorst has quit IRC22:01
*** thumpba has joined #openstack-nova22:01
*** Daisy has joined #openstack-nova22:01
alaskidoffm: yeah.  I'm still in favor of it being a special cell, which means just a db and a cell_mapping.  but if we co-opted another cell we would just need some way to know which one22:02
*** thumpba has quit IRC22:02
*** vilobhmm11 has quit IRC22:03
melwittalaski: cool, thanks22:05
*** vilobhmm11 has joined #openstack-nova22:05
*** vilobhmm11 has quit IRC22:05
mriedemalaski: ok, i was noting in https://review.openstack.org/#/c/253087/ for the api samples that project_id and user_id should be uuids, but i guess they don't need to be and we don't have to assume they are22:06
tonybmdbooth: ping?22:06
*** vilobhmm11 has joined #openstack-nova22:06
mriedemsdague: i had some questions about using testscenarios in this functional test for a microversion add - might need your clarification https://review.openstack.org/#/c/253087/5/nova/tests/functional/api_sample_tests/test_instance_actions.py22:07
alaskimriedem: gotcha.  it would be good to have them as uuids in the api samples, just not enforced in the object itself22:07
mriedemsdague: since testscenarios and how everything is setup by magic in the api samples tests always baffles me22:07
mriedemdoffm: ^ reviewed your bp change if you have questions22:07
*** mdrabe__ has quit IRC22:08
*** mdrabe__ has joined #openstack-nova22:09
*** salv-orl_ has joined #openstack-nova22:09
*** salv-orlando has quit IRC22:12
openstackgerritAugustina Ragwitz proposed openstack/nova: Add test coverage to functional api tests _compare_result method  https://review.openstack.org/26344022:14
*** vilobhmm11 has quit IRC22:15
mriedemsdague: gmann: shouldn't https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_server_groups.py#L84 be scenarios = [('v2_13', {'api_major_version': 'v2.1'})] ?22:15
*** vilobhmm11 has joined #openstack-nova22:15
*** e0ne has quit IRC22:15
melwittalaski: so we'll want something like a nova-manage command that takes what's in an existing cells v1 deployment and generates the cell mappings? I see how the mq info is in the cells table, but how do we know what the cell dbs are?22:16
*** pratikmallya has joined #openstack-nova22:17
*** ildikov_afk is now known as ildikov22:17
*** vilobhmm11 has quit IRC22:18
*** vilobhmm11 has joined #openstack-nova22:19
*** ihrachys has quit IRC22:19
*** Daisy has quit IRC22:19
alaskimelwitt: I think we can leave it up to deployers to generate the cell mappings themselves, not try to pull them from existing cells22:20
*** ihrachys has joined #openstack-nova22:20
alaskiand for the non-cells case that will be necessary22:20
ildikovmriedem: thanks for taking care of the get_by_volume patch!22:20
mriedemnp22:20
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/cert directory  https://review.openstack.org/26784122:23
*** dave-mcc_ has quit IRC22:25
*** eil397 has joined #openstack-nova22:26
melwittalaski: okay, so the transport url and database connection will be args to the nova-manage command. and the host list can be pulled automatically using the provided database connection22:26
*** jwcroppe has joined #openstack-nova22:27
alaskimelwitt: yeah, I think that would be a good way to do it22:28
melwittalaski: thanks, that makes sense. I'll start working on it :)22:31
*** tjones has joined #openstack-nova22:31
*** matrohon has quit IRC22:31
*** suro-patz has quit IRC22:31
alaskimelwitt: awesome, thanks22:32
*** suro-patz has joined #openstack-nova22:32
*** matrohon has joined #openstack-nova22:33
* mriedem is comforted by the fact that api samples tests are still as confusing as they always were22:33
alaskis/comforted by/depressed by/22:33
alaskiI haven't looked in a while, but I always hated the recursive method in there that did the comparison22:34
alaskinot sure if it's still there22:34
melwittI remember when I first learned how to work on the api samples. that was rough22:34
*** otter768 has joined #openstack-nova22:35
*** ihrachys has quit IRC22:35
*** jwcroppe has quit IRC22:36
ildikovmriedem: in Mitaka we need these two patches to land for multiattach: https://review.openstack.org/#/c/193134 , https://review.openstack.org/#/c/25627322:36
*** ihrachys has joined #openstack-nova22:36
*** ijw has joined #openstack-nova22:36
ildikovmriedem: and then we can figure out the API for Newton and allow attaching the second volume22:37
*** otter768 has quit IRC22:39
rlrossitdims_: things are looking pretty red in that ceilometer change in zuul, but it looks like they're having issues because everything is failing for them. Sooo... the rpc change is good?22:41
*** ccarmack has quit IRC22:43
*** ZZelle__ has joined #openstack-nova22:44
openstackgerritTimofey Durakov proposed openstack/nova: Ceph for live-migration job  https://review.openstack.org/25228322:44
*** matrohon has quit IRC22:45
rlrossitdims_: all of their functional tests are currently failing, but at least tempest was good. Take a look if you want (https://review.openstack.org/#/c/267779/), I'll probably leave it sit until tomorrow, it's time to go home22:45
*** rlrossit has quit IRC22:46
openstackgerritMatt Riedemann proposed openstack/nova: ServerGroupsV213SampleJsonTest should actually test v2.13  https://review.openstack.org/26785322:49
mriedemtalk about confusing ^22:49
*** harlowja has joined #openstack-nova22:50
ildikovmriedem: I just saw someone working with these tests, but even that got me confused22:51
mriedemit's super confusing22:51
mriedemand it doesn't fail when it's wrong22:51
mriedemit's testscenarios magic22:51
*** lpetrut has quit IRC22:52
ildikovI remember that we had an issue that we had to modify the doc file and another file, but the only info was a regexp failure22:52
ildikovnot to mention what you've just said22:52
*** ihrachys_ has joined #openstack-nova22:52
*** claudiub has quit IRC22:52
*** dims_ has quit IRC22:54
*** ihrachys has quit IRC22:54
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: Trace original exception before converting exception  https://review.openstack.org/26523922:54
*** ijw has quit IRC22:54
*** _diana_1 has quit IRC22:55
*** ctrath has quit IRC22:55
*** claudiub has joined #openstack-nova22:55
*** ankita has quit IRC22:56
*** _diana_1 has joined #openstack-nova22:57
*** kylek3h has quit IRC22:58
*** browne has quit IRC22:59
*** mriedem has quit IRC23:00
openstackgerritDavid Edery proposed openstack/nova: ports & networks gather should validate existance  https://review.openstack.org/25256523:02
*** mdrabe__ has quit IRC23:02
*** doug-fish has quit IRC23:02
*** burt has quit IRC23:03
*** pradk has quit IRC23:04
auggymriedem: omg i've just spend the past several weeks diving into those with sdague23:05
*** e0ne has joined #openstack-nova23:06
*** pumaranikar has quit IRC23:06
*** ihrachys has joined #openstack-nova23:06
*** pumaranikar has joined #openstack-nova23:06
auggymy first real dive into Nova code and it was that!!23:06
auggytrial by fire!!23:06
*** haomaiwang has joined #openstack-nova23:07
*** pumaranikar has quit IRC23:07
*** mmedvede has quit IRC23:07
*** pumaranikar has joined #openstack-nova23:07
*** gongysh_ has joined #openstack-nova23:08
*** haomaiwang has quit IRC23:08
*** ihrachys_ has quit IRC23:09
*** pumaranikar has quit IRC23:12
*** omnipresent has quit IRC23:13
*** pradk_ has joined #openstack-nova23:15
*** ZZelle__ has quit IRC23:16
*** erlon has quit IRC23:16
*** dimtruck is now known as zz_dimtruck23:17
*** Daisy has joined #openstack-nova23:19
*** gyee has joined #openstack-nova23:21
*** diogogmt has quit IRC23:23
*** pratikmallya has quit IRC23:25
*** zenoway has joined #openstack-nova23:25
*** apoorvad has quit IRC23:26
*** carey has joined #openstack-nova23:27
*** dims has joined #openstack-nova23:27
*** mrkz has quit IRC23:29
*** xyang1 has quit IRC23:29
*** zenoway has quit IRC23:30
*** carey has quit IRC23:32
*** tjones has quit IRC23:33
*** jwcroppe has joined #openstack-nova23:33
*** mragupat has quit IRC23:39
*** jwcroppe has quit IRC23:39
*** pradk_ has quit IRC23:40
*** ducttape_ has quit IRC23:43
*** ducttape_ has joined #openstack-nova23:43
*** ihrachys has quit IRC23:46
gmannmriedem: yea it needs to be with 2.1. currently its hitting v2 and verify nothing  about 2.13 version23:46
*** lihg has joined #openstack-nova23:47
*** smoriya_ has joined #openstack-nova23:47
*** ducttape_ has quit IRC23:48
*** e0ne has quit IRC23:49
*** zenoway has joined #openstack-nova23:50
*** zenoway has quit IRC23:54
*** zz_dimtruck is now known as dimtruck23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!