Wednesday, 2016-01-13

*** carey has joined #openstack-nova00:00
*** zz_dimtruck is now known as dimtruck00:00
*** jmccrory has quit IRC00:04
*** diogogmt has quit IRC00:04
*** carey has quit IRC00:05
*** baoli has quit IRC00:07
*** vilobhmm11 has quit IRC00:08
*** dims has joined #openstack-nova00:09
*** gjayavelu has quit IRC00:09
*** nic1 has quit IRC00:10
*** pratikma_ has quit IRC00:11
*** mhorban_ has quit IRC00:11
*** aginwala has quit IRC00:13
*** zenoway has joined #openstack-nova00:15
*** salv-orl_ has quit IRC00:16
*** salv-orlando has joined #openstack-nova00:17
*** aginwala has joined #openstack-nova00:18
*** zenoway has quit IRC00:20
*** eliqiao has quit IRC00:22
openstackgerritTakashi NATSUME proposed openstack/python-novaclient: Add wrapper classes for return-request-id-to-caller  https://review.openstack.org/25880200:22
*** eliqiao has joined #openstack-nova00:23
*** ZZelle_ has quit IRC00:28
*** irenab_ has joined #openstack-nova00:30
*** tongli has joined #openstack-nova00:30
*** irenab has quit IRC00:33
*** irenab_ is now known as irenab00:33
*** ducttape_ has joined #openstack-nova00:33
*** otter768 has joined #openstack-nova00:35
*** rk4n has joined #openstack-nova00:36
*** tongli has quit IRC00:40
*** otter768 has quit IRC00:40
*** tongli has joined #openstack-nova00:40
*** dimtruck is now known as zz_dimtruck00:44
*** carey has joined #openstack-nova00:50
*** SourabhP has joined #openstack-nova00:50
*** hemna is now known as hemnafk00:50
*** zhangjn has joined #openstack-nova00:51
openstackgerritmelanie witt proposed openstack/nova: Add a functional test for instance fault message with retry  https://review.openstack.org/24404600:53
*** markmcclain has quit IRC00:53
*** SourabhP has quit IRC00:54
*** zz_dimtruck is now known as dimtruck00:55
*** Sukhdev has quit IRC00:55
*** markmcclain has joined #openstack-nova00:55
*** ctrath has quit IRC00:56
*** aginwala has quit IRC01:00
*** eil397 has quit IRC01:02
*** Jeffrey4l has joined #openstack-nova01:03
*** zenoway has joined #openstack-nova01:03
*** aginwala has joined #openstack-nova01:05
*** rk4n has quit IRC01:06
*** zenoway has quit IRC01:08
*** tongli has quit IRC01:10
*** ekarlso has quit IRC01:10
*** tongli has joined #openstack-nova01:11
*** tongli has quit IRC01:11
*** annegent_ has joined #openstack-nova01:11
*** tongli has joined #openstack-nova01:11
*** annegentle has quit IRC01:13
*** gongysh has joined #openstack-nova01:15
*** mriedem has joined #openstack-nova01:16
*** Marga_ has quit IRC01:17
*** doug-fish has quit IRC01:18
*** doug-fish has joined #openstack-nova01:19
*** zenoway has joined #openstack-nova01:20
*** ducttape_ has quit IRC01:22
*** aginwala has quit IRC01:23
*** eil397 has joined #openstack-nova01:24
*** zenoway has quit IRC01:24
*** eliqiao has quit IRC01:24
*** aginwala has joined #openstack-nova01:25
*** mtanino has quit IRC01:28
*** haomaiwang has joined #openstack-nova01:29
*** rk4n has joined #openstack-nova01:29
*** ducttape_ has joined #openstack-nova01:29
*** ducttape_ has quit IRC01:30
*** EinstCrazy has joined #openstack-nova01:30
*** suro-patz has quit IRC01:33
*** smatzek has joined #openstack-nova01:33
*** doug-fish has quit IRC01:33
*** aloga has quit IRC01:34
*** rk4n has quit IRC01:34
openstackgerritRen Qiaowei proposed openstack/nova: xenapi: simplify swap_xapi_host()  https://review.openstack.org/26625801:35
*** zenoway has joined #openstack-nova01:35
*** dims has quit IRC01:38
*** zenoway has quit IRC01:40
*** eliqiao has joined #openstack-nova01:42
*** ducttape_ has joined #openstack-nova01:44
*** smatzek has quit IRC01:47
*** haomaiwang has quit IRC01:48
*** 7JTABI1K9 has joined #openstack-nova01:49
*** smatzek has joined #openstack-nova01:50
*** vilobhmm11 has joined #openstack-nova01:51
*** gongysh has quit IRC01:54
*** ducttape_ has quit IRC01:54
*** thumpba has joined #openstack-nova01:55
*** ljxiash has joined #openstack-nova01:55
*** smatzek has quit IRC01:56
*** thumpba_ has joined #openstack-nova01:58
*** thumpba has quit IRC01:58
*** eil397 has quit IRC01:59
*** zenoway has joined #openstack-nova01:59
*** thumpba_ has quit IRC02:01
*** thumpba has joined #openstack-nova02:01
*** vladikr has joined #openstack-nova02:02
*** diogogmt has joined #openstack-nova02:02
*** aloga has joined #openstack-nova02:02
*** thumpba has quit IRC02:03
*** thorst_ has quit IRC02:03
*** zenoway has quit IRC02:04
*** thorst has joined #openstack-nova02:04
*** thumpba has joined #openstack-nova02:07
*** tongli has quit IRC02:09
*** vilobhmm111 has joined #openstack-nova02:10
*** tongli has joined #openstack-nova02:10
*** aginwala has quit IRC02:10
*** lyanchih has joined #openstack-nova02:11
*** ducttape_ has joined #openstack-nova02:12
*** ducttape_ has quit IRC02:13
*** vilobhmm11 has quit IRC02:13
openstackgerritVladik Romanovsky proposed openstack/nova: objects: update the old location parent_addr only if it has value  https://review.openstack.org/26656002:14
openstackgerritVladik Romanovsky proposed openstack/nova: neutron: pci_request logic considers 'direct-physical' vnic type  https://review.openstack.org/26258402:14
openstackgerritVladik Romanovsky proposed openstack/nova: pci: Add utility method for getting the MAC addr  https://review.openstack.org/26258502:14
openstackgerritVladik Romanovsky proposed openstack/nova: pci: do not filter out any SRIOV Physical Functions  https://review.openstack.org/24901602:14
openstackgerritVladik Romanovsky proposed openstack/nova: neutron: Update the port with a MAC address for PFs  https://review.openstack.org/26258602:14
openstackgerritVladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment  https://review.openstack.org/24901802:14
openstackgerritVladik Romanovsky proposed openstack/nova: pci: adding support to specify a device_type in pci requests  https://review.openstack.org/25925402:14
*** thorst has quit IRC02:14
openstackgerritVladik Romanovsky proposed openstack/nova: Add a vnic type for PF passthrough and a new libvirt vif driver  https://review.openstack.org/26258302:14
*** tongli has quit IRC02:15
*** zhangjn has quit IRC02:15
*** lyanchih has quit IRC02:16
*** aginwala has joined #openstack-nova02:17
*** lyanchih has joined #openstack-nova02:17
*** aginwala has quit IRC02:19
*** armax has joined #openstack-nova02:21
*** zenoway has joined #openstack-nova02:24
*** zenoway has quit IRC02:28
*** dave-mccowan has joined #openstack-nova02:30
*** thumpba has quit IRC02:31
*** thumpba has joined #openstack-nova02:31
*** thumpba has quit IRC02:32
*** EinstCrazy has quit IRC02:32
*** EinstCrazy has joined #openstack-nova02:32
*** Marga_ has joined #openstack-nova02:35
*** otter768 has joined #openstack-nova02:37
*** houming has joined #openstack-nova02:37
*** dimtruck is now known as zz_dimtruck02:38
*** thumpba has joined #openstack-nova02:38
*** markmcclain has quit IRC02:39
*** zhangjn has joined #openstack-nova02:39
*** markmcclain has joined #openstack-nova02:40
*** thumpba has quit IRC02:40
*** otter768 has quit IRC02:41
*** Marga_ has quit IRC02:41
*** Marga_ has joined #openstack-nova02:42
*** Marga_ has quit IRC02:42
*** thumpba has joined #openstack-nova02:42
*** Marga_ has joined #openstack-nova02:43
*** zenoway has joined #openstack-nova02:48
*** aginwala has joined #openstack-nova02:50
*** aginwala has quit IRC02:50
*** aginwala has joined #openstack-nova02:51
*** zenoway has quit IRC02:52
*** aginwala has quit IRC02:53
*** aginwala has joined #openstack-nova02:53
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Add reviewing point related to REST API  https://review.openstack.org/26664502:58
*** aginwala_ has joined #openstack-nova02:59
*** aginwala has quit IRC03:00
*** zz_dimtruck is now known as dimtruck03:01
*** _diana_1 has joined #openstack-nova03:07
*** thumpba has quit IRC03:08
*** mtanino has joined #openstack-nova03:08
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/26616003:11
*** thorst has joined #openstack-nova03:12
*** markmcclain has quit IRC03:12
*** zenoway has joined #openstack-nova03:13
*** markmcclain has joined #openstack-nova03:15
*** apoorvad has quit IRC03:16
*** thumpba has joined #openstack-nova03:16
*** otter768 has joined #openstack-nova03:17
*** yamahata has quit IRC03:17
*** dims has joined #openstack-nova03:17
*** zenoway has quit IRC03:18
*** thorst has quit IRC03:19
*** ekarlso has joined #openstack-nova03:19
*** mriedem has quit IRC03:20
openstackgerritEli Qiao proposed openstack/nova: Calculate block_migration in virt drivers if it's None  https://review.openstack.org/25410103:20
openstackgerritEli Qiao proposed openstack/nova: Return host and block_migration in task_api._execute()  https://review.openstack.org/25410203:20
*** unicell has quit IRC03:21
*** _diana_1 has quit IRC03:21
*** links has joined #openstack-nova03:23
*** claudiub has quit IRC03:24
*** edmondsw has quit IRC03:27
*** lyanchih has quit IRC03:32
*** dims has quit IRC03:33
*** gyee has quit IRC03:34
*** gongysh has joined #openstack-nova03:36
*** vivekd has joined #openstack-nova03:36
*** coolsvap|away is now known as coolsvap03:37
openstackgerritsandeep nandal proposed openstack/nova: Replaced range() and xrange() by six.moves.range()  https://review.openstack.org/26465203:37
*** markmcclain has quit IRC03:37
*** zenoway has joined #openstack-nova03:38
*** markmcclain has joined #openstack-nova03:38
*** Jeffrey4l has quit IRC03:40
*** annegent_ has quit IRC03:40
*** zenoway has quit IRC03:42
oomichialex_xu: hi, can you take a look at https://review.openstack.org/#/c/266645/? just one line ;)03:43
alex_xuoomichi: reading03:44
*** thumpba has quit IRC03:44
alex_xuoomichi: is there anywhere we use 'compute'? 'compute' node?03:45
*** thumpba has joined #openstack-nova03:45
alex_xuoomichi: but good to see https://review.openstack.org/#/c/196918/8 merged :)03:46
*** zhangjn has quit IRC03:46
oomichialex_xu: not yet. current microversion header name is against the rule as you know03:46
alex_xuoomichi: yea03:46
*** unicell has joined #openstack-nova03:46
oomichialex_xu: "nova's development experience" means that ;)03:46
alex_xuoomichi: :)03:47
*** carey has quit IRC03:47
oomichialex_xu: thanks for reviewing anyways :)03:48
*** lyanchih has joined #openstack-nova03:49
*** thumpba has quit IRC03:50
*** unicell1 has joined #openstack-nova03:50
*** unicell has quit IRC03:50
*** markmcclain has quit IRC03:52
*** Jeffrey4l has joined #openstack-nova03:53
*** ljxiash has quit IRC03:56
*** ljxiash has joined #openstack-nova03:56
*** annegentle has joined #openstack-nova04:00
*** ljxiash has quit IRC04:00
*** zenoway has joined #openstack-nova04:03
openstackgerritEli Qiao proposed openstack/nova: Object: Fix wrong usage migrate_data_obj in libvirt driver  https://review.openstack.org/26666804:03
*** gangil has quit IRC04:04
*** otter768 has quit IRC04:04
*** NightKhaos has quit IRC04:05
*** zenoway has quit IRC04:07
*** lyanchih has quit IRC04:08
*** vks has joined #openstack-nova04:08
*** tongli has joined #openstack-nova04:10
*** salv-orl_ has joined #openstack-nova04:10
*** Marga_ has quit IRC04:10
*** Jeffrey4l has quit IRC04:11
*** salv-orlando has quit IRC04:13
*** zhangjn has joined #openstack-nova04:16
*** vilobhmm111 has quit IRC04:17
*** thorst has joined #openstack-nova04:17
*** tongli has quit IRC04:23
*** Jeffrey4l has joined #openstack-nova04:23
*** markmcclain has joined #openstack-nova04:24
*** tongli has joined #openstack-nova04:24
*** thorst has quit IRC04:25
*** vivekd_ has joined #openstack-nova04:25
*** tongli has quit IRC04:26
*** tongli has joined #openstack-nova04:26
*** zenoway has joined #openstack-nova04:27
*** vivekd has quit IRC04:27
*** vivekd_ is now known as vivekd04:27
*** zhangjn has quit IRC04:29
*** markmcclain has quit IRC04:29
oomichijohnthetubaguy: sdague: one more reviewing point comes from api-wg: https://review.openstack.org/#/c/266645/04:29
openstackgerritYAMAMOTO Takashi proposed openstack/nova: Add mm-ctl to compute.filters  https://review.openstack.org/26667004:30
*** tongli has quit IRC04:30
*** tongli has joined #openstack-nova04:31
*** zenoway has quit IRC04:31
*** gangil has joined #openstack-nova04:34
*** gangil has joined #openstack-nova04:34
*** tongli has quit IRC04:35
*** tongli has joined #openstack-nova04:36
openstackgerritYAMAMOTO Takashi proposed openstack/nova: Remove mm-ctl from network.filters  https://review.openstack.org/26667304:38
*** EinstCra_ has joined #openstack-nova04:39
*** EinstCrazy has quit IRC04:39
*** vivekd_ has joined #openstack-nova04:39
*** tongli has quit IRC04:40
*** dimtruck is now known as zz_dimtruck04:40
*** vivekd has quit IRC04:41
*** dave-mccowan has quit IRC04:41
*** vivekd_ is now known as vivekd04:41
alex_xuoomichi: np04:45
*** zenoway has joined #openstack-nova04:47
*** dave-mccowan has joined #openstack-nova04:47
openstackgerritAnand Shanmugam proposed openstack/nova: Handle Instance Exceptions in add_fixed_ip and remove_fixed_ip  https://review.openstack.org/26667504:48
*** ljxiash has joined #openstack-nova04:51
*** EinstCra_ has quit IRC04:51
*** EinstCrazy has joined #openstack-nova04:51
*** ferest has joined #openstack-nova04:53
*** thumpba has joined #openstack-nova04:55
*** ferest_ has joined #openstack-nova04:56
*** ferest has quit IRC04:57
*** thumpba has quit IRC05:01
*** EinstCrazy has quit IRC05:01
*** EinstCrazy has joined #openstack-nova05:02
*** Sukhdev has joined #openstack-nova05:03
*** boris-42 has quit IRC05:03
*** EinstCrazy has quit IRC05:05
*** EinstCrazy has joined #openstack-nova05:05
*** EinstCrazy has quit IRC05:06
*** EinstCrazy has joined #openstack-nova05:06
*** markmcclain has joined #openstack-nova05:12
*** EinstCra_ has joined #openstack-nova05:15
*** EinstCrazy has quit IRC05:15
*** vks has quit IRC05:15
*** zhangjn has joined #openstack-nova05:15
*** vks has joined #openstack-nova05:16
*** EinstCra_ has quit IRC05:16
*** carey has joined #openstack-nova05:17
*** EinstCrazy has joined #openstack-nova05:17
*** ccarmack has joined #openstack-nova05:18
*** NightKhaos has joined #openstack-nova05:20
ccarmackalex_xu: are you there?05:20
alex_xuccarmack: I'm here05:21
ccarmackCould you take a look at https://review.openstack.org/#/c/254950/ ?  The merge conflict is due to the microversion changing.05:21
*** markmcclain has quit IRC05:21
*** thorst has joined #openstack-nova05:21
*** lyanchih has joined #openstack-nova05:22
alex_xuccarmack: ok, let me check05:22
ccarmackGreat, I'll look at the comments tomorrow, thanks05:22
alex_xuccarmack: np :)05:22
*** ccarmack has left #openstack-nova05:23
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli  https://review.openstack.org/26668705:24
*** NightKhaos has quit IRC05:24
*** NightKhaos has joined #openstack-nova05:25
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix support customer ip protocol when create security-rule using nova-cli  https://review.openstack.org/26668705:26
*** EinstCra_ has joined #openstack-nova05:26
*** EinstCrazy has quit IRC05:26
*** EinstCra_ has quit IRC05:27
*** gcb has quit IRC05:27
*** EinstCrazy has joined #openstack-nova05:28
*** thorst has quit IRC05:29
*** annegentle has quit IRC05:29
*** NightKhaos has quit IRC05:31
*** EinstCrazy has quit IRC05:31
*** EinstCrazy has joined #openstack-nova05:32
*** ferest_ has quit IRC05:33
*** aginwala_ has quit IRC05:36
*** dave-mccowan has quit IRC05:36
*** EinstCrazy has quit IRC05:37
*** EinstCra_ has joined #openstack-nova05:37
*** NightKhaos has joined #openstack-nova05:37
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix support customer ip protocol when create security-rule using nova-cli  https://review.openstack.org/26668705:38
*** gcb has joined #openstack-nova05:39
*** jwcroppe has quit IRC05:40
*** jaosorior has joined #openstack-nova05:41
openstackgerritJacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli  https://review.openstack.org/26669005:41
*** EinstCra_ has quit IRC05:41
openstackgerritMoshe Levi proposed openstack/nova: Enhance PCI passthrough whitelist to support regex  https://review.openstack.org/19948805:41
*** artom has quit IRC05:41
*** EinstCra_ has joined #openstack-nova05:43
*** mtanino has quit IRC05:43
*** NightKhaos has quit IRC05:43
*** NightKhaos has joined #openstack-nova05:44
*** zhangjn has quit IRC05:46
*** NightKhaos_ has joined #openstack-nova05:49
*** markmcclain has joined #openstack-nova05:50
*** NightKhaos has quit IRC05:51
*** NightKhaos_ is now known as NightKhaos05:51
*** markmcclain has quit IRC05:56
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix Exception message consistency with input protocol  https://review.openstack.org/26669806:00
*** edtubill has joined #openstack-nova06:01
*** zenoway has quit IRC06:01
*** zhangjn has joined #openstack-nova06:07
*** zhangjn has quit IRC06:07
*** zhangjn has joined #openstack-nova06:08
openstackgerritRen Qiaowei proposed openstack/nova: enable uefi boot for x86_64  https://review.openstack.org/26293006:12
*** zenoway has joined #openstack-nova06:13
openstackgerritWang Bo proposed openstack/nova: Replaces __builtin__ with six.moves.builtins  https://review.openstack.org/26670806:13
*** SourabhP has joined #openstack-nova06:14
*** zenoway has quit IRC06:18
*** aginwala has joined #openstack-nova06:19
*** aginwala_ has joined #openstack-nova06:20
*** ParsectiX has quit IRC06:22
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli  https://review.openstack.org/26668706:22
*** vivekd has quit IRC06:23
*** zhangjn has quit IRC06:23
*** aginwala has quit IRC06:24
*** gongysh has quit IRC06:24
*** zhangjn has joined #openstack-nova06:25
*** SourabhP_ has joined #openstack-nova06:26
*** thorst has joined #openstack-nova06:26
openstackgerritTakashi NATSUME proposed openstack/python-novaclient: Add return-request-id-to-caller function(1/5)  https://review.openstack.org/26139906:27
*** aginwala has joined #openstack-nova06:27
*** markvoelker has quit IRC06:27
*** SourabhP has quit IRC06:28
*** SourabhP_ is now known as SourabhP06:28
*** aginwala_ has quit IRC06:29
openstackgerritesracelik proposed openstack/nova: Config options: centralize section "hyperv"  https://review.openstack.org/25512406:32
*** thorst has quit IRC06:34
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata  https://review.openstack.org/26560106:37
*** shyama has joined #openstack-nova06:39
*** lyanchih has quit IRC06:39
*** zhangjn has quit IRC06:40
*** EinstCra_ has quit IRC06:40
*** vivekd has joined #openstack-nova06:40
*** EinstCrazy has joined #openstack-nova06:40
*** ferest has joined #openstack-nova06:41
openstackgerritEli Qiao proposed openstack/nova: Object: Fix wrong usage migrate_data_obj in libvirt driver  https://review.openstack.org/26666806:44
*** moshele has joined #openstack-nova06:44
*** SourabhP has quit IRC06:45
*** lyanchih has joined #openstack-nova06:45
openstackgerritesracelik proposed openstack/nova: Config options: centralize "configdrive" options  https://review.openstack.org/25409206:46
*** yamahata has joined #openstack-nova06:47
openstackgerritJacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli  https://review.openstack.org/26669006:47
*** ferest has quit IRC06:48
openstackgerritQin Zhao proposed openstack/nova: VMware: Handle image size correctly for OVA and streamOptimized images  https://review.openstack.org/16802406:48
*** zenoway has joined #openstack-nova06:49
*** zhangjn has joined #openstack-nova06:50
openstackgerritIldiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments  https://review.openstack.org/19313506:51
openstackgerritIldiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments  https://review.openstack.org/19313406:51
openstackgerritIldiko Vancsa proposed openstack/nova: db and obj: Allow multiple volume attachments  https://review.openstack.org/19313306:51
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach  https://review.openstack.org/15303806:51
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: virt: Pass host when call attach to Cinder  https://review.openstack.org/25627306:51
*** Sukhdev has quit IRC06:52
*** cfriesen has quit IRC06:53
*** jaosorior has quit IRC06:57
*** garyk has joined #openstack-nova06:57
*** josecastroleon has joined #openstack-nova07:02
*** esracelik has joined #openstack-nova07:08
*** mjura has joined #openstack-nova07:09
*** esracelik has quit IRC07:11
*** esracelik has joined #openstack-nova07:11
*** med_ has quit IRC07:12
*** esracelik has quit IRC07:14
*** med_ has joined #openstack-nova07:14
*** esracelik has joined #openstack-nova07:14
*** med_ is now known as Guest7712107:14
*** vivekd has quit IRC07:15
*** lpetrut has joined #openstack-nova07:22
*** paul-carlton2 has joined #openstack-nova07:24
*** aginwala has quit IRC07:25
*** markvoelker has joined #openstack-nova07:28
*** sahid has joined #openstack-nova07:28
*** sakthi has joined #openstack-nova07:29
*** edtubill has quit IRC07:30
sakthirequired to find instance reboot time? any suggestion07:31
*** thorst has joined #openstack-nova07:31
*** markvoelker has quit IRC07:33
*** paul-carlton2 has quit IRC07:34
*** jichen has joined #openstack-nova07:34
*** gwei3 has joined #openstack-nova07:35
*** shyama has quit IRC07:36
*** shyama has joined #openstack-nova07:36
*** rotbeard has quit IRC07:37
*** thorst has quit IRC07:39
*** e0ne has joined #openstack-nova07:41
*** rk4n has joined #openstack-nova07:41
*** nkrinner has joined #openstack-nova07:44
*** paul-carlton2 has joined #openstack-nova07:47
openstackgerritlinbing proposed openstack/nova: VMware: Fix bug of TypeError when getting reference of VCenter cluster is None.  https://review.openstack.org/25767407:48
*** mpavone has joined #openstack-nova07:57
openstackgerritTomi Juvonen proposed openstack/nova: Add host_status attribute for servers/detail and servers/{server_id}  https://review.openstack.org/24156207:57
*** otter768 has joined #openstack-nova08:00
*** ildikov has quit IRC08:00
*** otter768 has quit IRC08:02
*** otter768 has joined #openstack-nova08:02
bauzasgood morning Nova08:04
*** salv-orl_ has quit IRC08:04
*** otter768 has quit IRC08:04
*** salv-orlando has joined #openstack-nova08:04
*** otter768_ has joined #openstack-nova08:04
*** otter768_ has quit IRC08:06
*** otter768 has joined #openstack-nova08:06
*** jistr has joined #openstack-nova08:07
*** 7JTABI1K9 has quit IRC08:07
*** jistr is now known as jistr|doc08:07
*** 21WAARZWA has joined #openstack-nova08:07
*** otter768 has quit IRC08:08
*** otter768_ has joined #openstack-nova08:08
*** otter768 has joined #openstack-nova08:10
*** otter768_ has quit IRC08:10
*** zhangjn has quit IRC08:11
*** otter768_ has joined #openstack-nova08:12
*** Jeffrey4l has quit IRC08:12
*** paul-carlton2 has quit IRC08:12
*** otter768_ has quit IRC08:13
*** markus_z has joined #openstack-nova08:13
*** otter768_ has joined #openstack-nova08:13
*** otter768 has quit IRC08:15
oomichibauzas: o/08:15
*** otter768 has joined #openstack-nova08:15
*** otter768_ has quit IRC08:16
bauzas:-)08:17
*** otter768_ has joined #openstack-nova08:17
*** otter768 has quit IRC08:17
*** e0ne has quit IRC08:18
*** zakora has joined #openstack-nova08:19
*** otter768 has joined #openstack-nova08:19
*** otter768_ has quit IRC08:19
*** otter768_ has joined #openstack-nova08:21
*** otter768 has quit IRC08:21
openstackgerritsahid proposed openstack/os-vif: introduce vif.Config  https://review.openstack.org/26676808:23
*** otter768_ has quit IRC08:23
*** zhangjn has joined #openstack-nova08:23
*** otter768 has joined #openstack-nova08:23
openstackgerritesracelik proposed openstack/nova: Config options: centralize section "cells"  https://review.openstack.org/26018108:24
*** otter768 has quit IRC08:25
*** paul-carlton2 has joined #openstack-nova08:25
*** otter768 has joined #openstack-nova08:25
*** sudipto has joined #openstack-nova08:25
*** otter768_ has joined #openstack-nova08:27
*** otter76__ has joined #openstack-nova08:29
openstackgerritSudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor  https://review.openstack.org/26677308:29
*** otter768 has quit IRC08:29
*** otter768_ has quit IRC08:29
*** matrohon has joined #openstack-nova08:29
*** Jeffrey4l has joined #openstack-nova08:29
*** ildikov has joined #openstack-nova08:29
*** otter768 has joined #openstack-nova08:31
*** otter76__ has quit IRC08:31
*** yamahata has quit IRC08:32
*** otter768 has quit IRC08:32
*** smoriya_ has quit IRC08:32
*** otter768 has joined #openstack-nova08:33
*** lpetrut has quit IRC08:33
*** otter768_ has joined #openstack-nova08:34
*** liusheng has quit IRC08:35
*** liusheng has joined #openstack-nova08:35
*** moshele has quit IRC08:36
*** otter768_ has quit IRC08:36
*** otter76__ has joined #openstack-nova08:36
*** thorst has joined #openstack-nova08:37
*** otter768 has quit IRC08:37
*** moshele has joined #openstack-nova08:37
*** otter768 has joined #openstack-nova08:38
*** otter76__ has quit IRC08:38
*** otter768 has quit IRC08:40
*** otter768_ has joined #openstack-nova08:40
*** rdopiera has joined #openstack-nova08:40
*** vks has quit IRC08:40
*** daemontool has joined #openstack-nova08:40
*** otter768_ has quit IRC08:42
*** otter768 has joined #openstack-nova08:42
*** thorst has quit IRC08:43
*** ihrachys has joined #openstack-nova08:43
*** daemontool_ has joined #openstack-nova08:43
*** daemontool has quit IRC08:43
*** otter768_ has joined #openstack-nova08:44
*** daemontool_ is now known as daemontool08:44
*** otter768 has quit IRC08:44
*** jlanoux has joined #openstack-nova08:45
*** paul-carlton2 has quit IRC08:46
*** otter768 has joined #openstack-nova08:46
*** otter768_ has quit IRC08:46
*** otter768 has quit IRC08:48
*** otter768_ has joined #openstack-nova08:48
*** otter768_ has quit IRC08:50
*** otter768 has joined #openstack-nova08:50
garykmdbooth: danpb: any idea what may cause http://paste.openstack.org/show/483708/08:50
*** otter768_ has joined #openstack-nova08:52
*** otter768 has quit IRC08:52
openstackgerritTang Chen proposed openstack/nova: Add a REST API to trigger crash dump in an instance.  https://review.openstack.org/20261708:52
*** otter768 has joined #openstack-nova08:54
*** rk4n has quit IRC08:54
*** markvoelker has joined #openstack-nova08:54
*** otter768 has quit IRC08:55
*** otter76__ has joined #openstack-nova08:55
openstackgerritSudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor  https://review.openstack.org/26677308:55
*** otter768_ has quit IRC08:56
*** MVenesio has quit IRC08:56
*** otter768 has joined #openstack-nova08:57
*** markvoelker has quit IRC08:59
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli  https://review.openstack.org/26668708:59
*** otter768_ has joined #openstack-nova08:59
*** otter768 has quit IRC08:59
*** otter76__ has quit IRC09:00
*** 21WAARZWA has quit IRC09:01
*** 17WABJGSS has joined #openstack-nova09:01
*** otter768_ has quit IRC09:01
*** salv-orlando has quit IRC09:02
*** MCoLo has joined #openstack-nova09:02
*** sfinucan has joined #openstack-nova09:02
*** salv-orlando has joined #openstack-nova09:03
*** zhangjn has quit IRC09:03
*** gongysh has joined #openstack-nova09:03
*** otter768 has joined #openstack-nova09:03
*** rk4n has joined #openstack-nova09:04
*** slunkad has quit IRC09:04
*** otter768 has quit IRC09:05
*** otter768_ has joined #openstack-nova09:05
openstackgerritSudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor  https://review.openstack.org/26677309:05
openstackgerritJacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli  https://review.openstack.org/26669009:06
*** otter768 has joined #openstack-nova09:07
*** ndipanov has quit IRC09:08
*** otter768 has quit IRC09:08
*** mhorban_ has joined #openstack-nova09:08
*** otter768 has joined #openstack-nova09:09
*** amotoki has joined #openstack-nova09:10
*** shz has quit IRC09:10
*** otter768_ has quit IRC09:10
*** otter768_ has joined #openstack-nova09:11
*** otter768 has quit IRC09:11
*** MCoLo has quit IRC09:12
*** MCoLo has joined #openstack-nova09:12
*** otter768_ has quit IRC09:13
*** otter768 has joined #openstack-nova09:13
*** vivekd has joined #openstack-nova09:15
*** otter768_ has joined #openstack-nova09:15
*** otter768 has quit IRC09:15
*** ndipanov has joined #openstack-nova09:16
*** slunkad has joined #openstack-nova09:16
*** otter768 has joined #openstack-nova09:17
*** jaosorior has joined #openstack-nova09:18
*** otter768 has quit IRC09:19
*** otter76__ has joined #openstack-nova09:19
*** jlanoux has quit IRC09:19
*** otter768_ has quit IRC09:20
*** otter76__ has quit IRC09:20
*** jlanoux has joined #openstack-nova09:20
*** otter768 has joined #openstack-nova09:20
*** rmart04 has joined #openstack-nova09:21
openstackgerritIldiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments  https://review.openstack.org/19313509:21
openstackgerritIldiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments  https://review.openstack.org/19313409:21
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach  https://review.openstack.org/15303809:21
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: virt: Pass host when call attach to Cinder  https://review.openstack.org/25627309:21
*** zhangjn has joined #openstack-nova09:21
*** otter768 has quit IRC09:22
*** otter768 has joined #openstack-nova09:22
*** yassine has joined #openstack-nova09:23
*** rk4n has quit IRC09:23
*** otter768_ has joined #openstack-nova09:24
*** otter768 has quit IRC09:24
openstackgerritRen Qiaowei proposed openstack/nova: enable uefi boot for x86_64  https://review.openstack.org/26293009:25
*** otter768_ has quit IRC09:26
*** otter768 has joined #openstack-nova09:26
openstackgerritjaveme proposed openstack/nova: Use timedelta.total_second instead of calculating  https://review.openstack.org/26507909:27
*** otter768 has quit IRC09:28
*** salv-orlando has quit IRC09:28
*** otter768 has joined #openstack-nova09:28
*** salv-orlando has joined #openstack-nova09:28
*** paul-carlton2 has joined #openstack-nova09:28
*** PaulMurray has joined #openstack-nova09:29
*** otter768 has quit IRC09:30
*** otter768_ has joined #openstack-nova09:30
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix Exception message consistency with input protocol  https://review.openstack.org/26669809:31
*** otter768_ has quit IRC09:32
*** otter768 has joined #openstack-nova09:32
*** ferest has joined #openstack-nova09:33
*** e0ne has joined #openstack-nova09:33
*** otter768_ has joined #openstack-nova09:34
*** otter768 has quit IRC09:34
*** derekh has joined #openstack-nova09:35
openstackgerritEli Qiao proposed openstack/nova: Libvirt: Move graphics checking and console verify early when LM  https://review.openstack.org/26504209:35
openstackgerritEli Qiao proposed openstack/nova: Libvirt: cleanup when getting block device mapping  https://review.openstack.org/26680909:35
*** otter768_ has quit IRC09:36
*** otter768 has joined #openstack-nova09:36
*** zhangjn has quit IRC09:36
sfinucanIs there any reason why releasenotes with reno can't be wrapped at 79 characters?09:36
*** otter768_ has joined #openstack-nova09:38
sfinucanI notice most of the code reviews containing a 'releasenotes' file seem to be wrapped at < ~65 characters, presumably because this is what the generated file is wrapped at09:38
*** gongysh has quit IRC09:38
*** moshele has quit IRC09:39
*** ferest_ has joined #openstack-nova09:39
*** otter76__ has joined #openstack-nova09:39
*** otter768_ has quit IRC09:40
*** otter768 has quit IRC09:40
bauzassfinucan: what do you mean ? some relnotes are having more than 79 chars09:40
*** moshele has joined #openstack-nova09:40
*** danpb has joined #openstack-nova09:40
*** thorst has joined #openstack-nova09:41
*** otter76__ has quit IRC09:41
*** otter768 has joined #openstack-nova09:41
sfinucanbauzas: Not the ones I've seen (going on this: https://review.openstack.org/#/q/project:openstack/nova+file:releasenotes)09:41
*** ferest has quit IRC09:42
eliqiaohi johnthetubaguy, there?09:43
*** otter768 has quit IRC09:43
*** otter768_ has joined #openstack-nova09:44
*** slunkad has quit IRC09:45
bauzassfinucan: I'm possibly wrong, all the merged notes are <=7909:45
*** otter768_ has quit IRC09:45
*** otter768 has joined #openstack-nova09:45
*** slunkad has joined #openstack-nova09:45
sfinucanbauzas: Ah - a misunderstanding :) My question is can they be wrapped at 79 characters instead of something less (the trend seems to be ~65)09:46
bauzassfinucan: yes they can09:47
sfinucanbauzas: OK, sweet. Didn't want to break any unwritten rules09:47
*** otter768 has quit IRC09:47
bauzassfinucan: eg. https://github.com/openstack/nova/blob/master/releasenotes/notes/compute_upgrade_levels_auto-97acebc7b45b76df.yaml09:47
*** otter768 has joined #openstack-nova09:47
*** oomichi is now known as oomichi_away09:47
bauzassfinucan: if you wonder, you can still check it locally09:47
bauzassfinucan: just make sure that you commit your patch and then run tox -e releasenotes09:48
bauzas(because reno looks at the git repo, not at the local files)09:48
*** thorst has quit IRC09:48
*** rk4n has joined #openstack-nova09:49
*** otter768_ has joined #openstack-nova09:49
sfinucanbauzas: and that's what I'll do. Cheers :)09:50
PaulMurraydanpb, do you have a moment to talk about the midcycle?09:50
*** gwei3 has quit IRC09:50
openstackgerritMoshe Levi proposed openstack/nova: ironic driver: Adding Infiniband support  https://review.openstack.org/26654009:51
*** otter76__ has joined #openstack-nova09:51
*** otter768_ has quit IRC09:51
*** otter768 has quit IRC09:52
*** otter768 has joined #openstack-nova09:53
*** otter76__ has quit IRC09:53
johnthetubaguyeliqiao: I am here now09:54
eliqiaojohnthetubaguy: oh, hi. can you please take a look at this patch(you voted -1 for long time and I replied) #link https://review.openstack.org/#/c/131026/09:54
openstackgerritStephen Finucane proposed openstack/nova: trivial: Add additional logs for NUMA scheduling  https://review.openstack.org/25478309:54
openstackgerritStephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=isolate' scheduling  https://review.openstack.org/20265509:54
openstackgerritStephen Finucane proposed openstack/nova: releasenotes: Note on CPU thread pinning support  https://review.openstack.org/26469309:54
johnthetubaguyeliqiao: afraid its hard for me to spot those replies in my review email soup, I can take a peak09:55
*** otter768_ has joined #openstack-nova09:55
*** rk4n has quit IRC09:55
*** rk4n has joined #openstack-nova09:56
eliqiaojohnthetubaguy: okay, thx, not in a hurry, I will abandon it if we don't want that one, it's leaves there for long time ...09:56
*** coolsvap is now known as coolsvap|away09:56
*** otter768_ has quit IRC09:57
*** otter76__ has joined #openstack-nova09:57
*** otter768 has quit IRC09:58
*** otter768 has joined #openstack-nova09:59
*** rk4n has quit IRC10:00
johnthetubaguyeliqiao: do you have a link to where the check is in the allocate_for_instance code, I can't find it10:00
*** 17WABJGSS has quit IRC10:01
*** otter768_ has joined #openstack-nova10:01
*** haomaiwang has joined #openstack-nova10:01
*** rk4n has joined #openstack-nova10:01
oomichi_awayjohnthetubaguy: review request list you are receiving is over 300 now..10:02
oomichi_awaytoo long10:02
johnthetubaguyyeah10:02
*** otter76__ has quit IRC10:02
*** otter768_ has quit IRC10:02
*** carey has quit IRC10:02
* oomichi_away am afraid of pushing mine10:02
eliqiaohttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L57410:02
*** otter768_ has joined #openstack-nova10:03
eliqiaojohnthetubaguy: ^^ neutronv2 api will raise exception.10:03
johnthetubaguyeliqiao: what about nova-network?10:03
PaulMurrayjohnthetubaguy, for mid cycle live migration topics - would you prefer we sort them out first and then add to midcycle etherpad or10:03
danpbPaulMurray: hi10:03
PaulMurrayjohnthetubaguy, just ask people to sort it out on the etherpad10:03
PaulMurraydanpb, hi10:03
*** otter768 has quit IRC10:04
*** otter768_ has quit IRC10:04
johnthetubaguyPaulMurray: yeah, at the moment just been asking for folks to sort out things on the etherpad, whatever works for you folks really10:04
PaulMurraydanpb, we have several libvirt/qemu people going to the mid cycle10:04
danpbok10:04
*** otter768 has joined #openstack-nova10:05
*** rk4n has quit IRC10:05
eliqiaojohnthetubaguy: https://github.com/openstack/nova/blob/master/nova/network/api.py#L29910:05
PaulMurraydanpb, I wondered if it would be an idea to go through work being done in those areas10:05
eliqiaojohnthetubaguy: nova network doesn't has that method.10:05
PaulMurraydanpb, whats planned, what could do with help, etc.10:05
*** rk4n has joined #openstack-nova10:05
PaulMurrayand understand a rough timeline for things we depend on10:05
danpbare there particular items you're thinking about ?10:06
johnthetubaguyeliqiao: as I understand it, this is the nova-network code: https://github.com/openstack/nova/blob/master/nova/network/manager.py#L51410:06
*** EinstCrazy has quit IRC10:06
danpbthe migration stuff is the main feature in libvirt/qemu area10:06
PaulMurrayI've been focused on migration related stuff10:06
*** otter768_ has joined #openstack-nova10:06
*** otter768 has quit IRC10:06
PaulMurrayI'm not involved in those communities so I rely on others to tell me what is coming10:08
*** otter768 has joined #openstack-nova10:08
PaulMurrayI have a couple of HP guys coming who will be interested in what they can help with10:08
*** rk4n has quit IRC10:08
*** rk4n has joined #openstack-nova10:09
danpbwell ther's a bunch of other specs, but they're not partiularly large things and seem in control10:09
*** salv-orl_ has joined #openstack-nova10:09
*** otter76__ has joined #openstack-nova10:10
*** otter768 has quit IRC10:10
*** otter768_ has quit IRC10:11
eliqiaojohnthetubaguy: hmm... I am kinds of not understand how attach_interface work if configur nova-network as network_api, I will try to understand it...10:11
eliqiaojohnthetubaguy: Thanks for your time. :)10:11
johnthetubaguyeliqiao: the network_api gets swapped out, for nova-network it sends an rpc messages to the network manager to execute the code, in neutron, the network_api sends REST API calls to neutron, roughly, hope that helps10:12
PaulMurraydanpb, ok, I'll add a note along with live migration progress and we can get a summary of where we are10:12
*** otter768 has joined #openstack-nova10:12
*** otter76__ has quit IRC10:12
johnthetubaguyeliqiao: its the edge cases that worry me, like when subnets run out of IPs, etc10:12
*** salv-orlando has quit IRC10:13
*** rk4n has quit IRC10:13
eliqiaojohnthetubaguy: Thanks, it's really helps. okay, I am agree that keep that checking code there (for nova-network case)10:13
eliqiaojohnthetubaguy: Thanks again.10:13
*** otter768_ has joined #openstack-nova10:14
johnthetubaguyeliqiao: no worries, thanks for reaching out10:14
* eliqiao ops. should `am` with agree10:14
*** atuvenie has joined #openstack-nova10:15
*** cdent has joined #openstack-nova10:15
*** ndipanov has quit IRC10:16
*** otter76__ has joined #openstack-nova10:16
*** otter768_ has quit IRC10:16
*** salv-orl_ has quit IRC10:16
*** otter768 has quit IRC10:17
*** rk4n has joined #openstack-nova10:17
*** salv-orlando has joined #openstack-nova10:17
*** otter768 has joined #openstack-nova10:18
mdboothDoes anybody happen to know how to make cirros not default to a serial console?10:19
*** otter768 has quit IRC10:19
*** jistr|doc is now known as jistr10:19
*** otter768 has joined #openstack-nova10:20
*** otter76__ has quit IRC10:21
*** otter768_ has joined #openstack-nova10:22
*** vivekd_ has joined #openstack-nova10:22
*** otter768 has quit IRC10:22
kashyapmdbooth: If crude way works fo you: probably remove the console=ttyS0 option from the Kernel commandline?10:23
*** vivekd has quit IRC10:23
*** vivekd_ is now known as vivekd10:23
*** ljxiash has quit IRC10:23
mdboothkashyap: Does that involve editing the image itself?10:23
*** paul-carlton1 has quit IRC10:23
mdboothOr is there some magic I can give to openstack?10:23
*** ljxiash has joined #openstack-nova10:23
*** otter768 has joined #openstack-nova10:23
mdbooth(but crude is fine)10:24
kashyapmdbooth: Afraid yeah - editing the image with `guestfish`.10:24
mdboothOk, thanks.10:24
*** otter768_ has quit IRC10:24
*** lpetrut has joined #openstack-nova10:24
*** otter768 has quit IRC10:25
*** otter768 has joined #openstack-nova10:25
*** jistr has quit IRC10:26
kashyapmdbooth: It's in an unusual location: $ cat /boot/grub/menu.lst10:26
mdboothThat's normal for debian iirc10:27
gibijohnthetubaguy: hi! Could you please check the versioned notification patches again?10:27
kashyapAnd, I'd elide that - 'console=tty1 console=ttyS0'10:27
kashyapmdbooth: Ah, I see10:27
*** otter768_ has joined #openstack-nova10:27
johnthetubaguygibi: I do hope to get to them, had to take yesterday off in the end, so I am behind were I want to be10:27
*** otter768 has quit IRC10:27
*** klkumar has joined #openstack-nova10:28
*** ljxiash has quit IRC10:28
gibijohnthetubaguy: thanks a lot!10:28
*** otter768 has joined #openstack-nova10:29
*** otter768_ has quit IRC10:29
*** vivekd_ has joined #openstack-nova10:33
*** vivekd has quit IRC10:33
*** vivekd_ is now known as vivekd10:33
*** otter768 has quit IRC10:34
*** rfolco has joined #openstack-nova10:40
*** tyagiprince has joined #openstack-nova10:40
tyagiprinceHey people.. need some help.. I am facing trouble in listing down just the user's vms by changing the policy files..10:41
tyagiprinceI changed the compute:get_all rule to display just the instances where the user_id matches.. But it does not work10:41
*** rk4n has quit IRC10:42
tyagiprinceanyone?10:44
tyagiprincefamiliar with policy rules?10:45
openstackgerritPetrut Lucian proposed openstack/nova: HyperV: Add FC attached volumes support  https://review.openstack.org/25861710:46
*** thorst has joined #openstack-nova10:46
*** ndipanov has joined #openstack-nova10:47
*** ljxiash has joined #openstack-nova10:48
*** jistr has joined #openstack-nova10:51
*** thorst has quit IRC10:53
*** mleroy has joined #openstack-nova10:54
*** lpetrut1 has joined #openstack-nova10:55
*** markvoelker has joined #openstack-nova10:55
openstackgerritjichenjc proposed openstack/nova: Stop using mox stubs in nova.tests.unit.console  https://review.openstack.org/26683710:56
*** lpetrut has quit IRC10:56
*** lpetrut1 is now known as lpetrut10:56
*** markvoelker has quit IRC11:00
*** haomaiwang has quit IRC11:01
*** haomaiwang has joined #openstack-nova11:01
*** daemontool_ has joined #openstack-nova11:01
sakthifraid yeah - editing the image with `guestfish`.11:03
sakthisorry11:03
sakthirequired to find instance reboot time? any suggestion11:03
*** aysyd has joined #openstack-nova11:03
sakthiif vm has restarted from inside, its hard to record the downtime from virsh components11:04
sakthihow to find vm has restarted inside the vm11:04
*** daemontool has quit IRC11:05
*** jaosorior has quit IRC11:05
*** jaosorior has joined #openstack-nova11:05
*** jaosorior has quit IRC11:06
*** jaosorior has joined #openstack-nova11:07
johnthetubaguytyagiprince: there are two sets of rules, api and compute rules11:09
*** gibi has quit IRC11:09
johnthetubaguytyagiprince: but I would try on #openstack for usage information11:09
*** gcb has quit IRC11:09
*** rdopiera has quit IRC11:10
*** s1rp_ has quit IRC11:10
*** s1rp has joined #openstack-nova11:11
*** gibi has joined #openstack-nova11:11
*** gcb has joined #openstack-nova11:14
*** rdopiera has joined #openstack-nova11:17
*** lucas-dinner is now known as lucasagomes11:18
*** aarefiev has quit IRC11:20
*** aarefiev has joined #openstack-nova11:21
garykdanpb: have hit a very odd bug with libvirt and maybe you can point me in a direction here. try and spin up an instance with 4 nics attached. the libvirt xml file is created with 5 nics (and one is a dupe) => this leads to libvirtError: Unable to create tap device tapccfd7edd-74: Device or resource busy11:21
danpbhehe that's fun11:23
danpbi guess you'll want to look at nova-compute.log to seeat what point the extra nic appears11:23
danpbi expect something will be mangling the network info before it even gets to the libvirt driver11:24
garyki did that and it appear that there are 4 entries passed to the libvirt driver.11:24
garykdanpb: fyi https://bugs.launchpad.net/nova/+bug/153357211:26
openstackLaunchpad bug 1533572 in OpenStack Compute (nova) "Failed to create vm on kvm while boot with multiple nics" [Undecided,New]11:26
danpbthat bug shows 7 nics in the xml11:27
danpb3 pairs have identical mac11:27
*** aix has joined #openstack-nova11:28
danpbgaryk: can you attach the full nova-compute.log file showing it11:30
garyksure will do11:31
danpbthe code generating the xml just iterates over  'network_info' - so that must get mangled somewhere to include 7 entries11:32
*** Marga_ has joined #openstack-nova11:33
openstackgerritDina Belova proposed openstack/python-novaclient: Add profiling support to novaclient  https://review.openstack.org/25469911:34
danpbgaryk: could be related to scrambled network info cache https://review.openstack.org/#/c/260462/ https://review.openstack.org/#/c/265363/11:34
*** ferest has joined #openstack-nova11:34
*** rk4n has joined #openstack-nova11:34
*** gszasz has joined #openstack-nova11:35
openstackgerritxiexs proposed openstack/nova: Add sriov info for live migration  https://review.openstack.org/25519311:36
openstackgerritxiexs proposed openstack/nova: Add checking logic for sriov migration  https://review.openstack.org/26685311:36
*** mdbooth has quit IRC11:36
*** gongysh_ has quit IRC11:37
ndipanovdanpb, garyk yeah there are several patches for it up11:37
danpbndipanov: can you comment on that bug garyk shows above11:37
ndipanovyeah will do11:37
*** ferest_ has quit IRC11:37
*** rk4n has quit IRC11:38
*** mdbooth has joined #openstack-nova11:38
*** lyanchih has quit IRC11:41
*** gszasz has quit IRC11:42
*** gszasz has joined #openstack-nova11:42
*** houming has quit IRC11:42
*** smatzek has joined #openstack-nova11:42
openstackgerritesracelik proposed openstack/nova: Config options: centralize section "cells"  https://review.openstack.org/26018111:43
*** aix has quit IRC11:43
pkoniszewskidanpb: hey, there? I have one question according to your comment in https://review.openstack.org/#/c/227278/26/nova/virt/libvirt/driver.py11:44
*** zenoway has quit IRC11:44
*** haomaiwang has quit IRC11:44
*** zenoway has joined #openstack-nova11:44
*** kmartin has quit IRC11:45
danpbpkoniszewski: hi11:45
*** ndipanov has quit IRC11:45
pkoniszewskidanpb: hi, so, you suggested to ignore BDM entirely, but I'm not sure how can I know from instance's XML which block/file disks are shared11:46
pkoniszewskidanpb: I've checked what libvirt knows about cinder volumes attached through nova and it says that such devices are not shareable, so it will try to block live migrate volumes (in existing logic without my patches)11:48
*** ndipanov has joined #openstack-nova11:48
openstackgerritMoshe Levi proposed openstack/nova: ironic driver: Adding InfiniBand support  https://review.openstack.org/26654011:48
*** haomaiwang has joined #openstack-nova11:48
garykdanpb: ndipanov: yes, it may be related to thioe11:48
pkoniszewskidanpb: so at least I would need to get block devices from BDM and skip them when parsing XML11:48
pkoniszewskidanpb: nova knows that these are cinder devices and are shared so I wouldn't need to do anything hacky11:49
danpbpkoniszewski: hmm, yes, that would work11:49
ndipanovgaryk, yeah let me dig up 3 patches that try to fix this11:49
*** zenoway has quit IRC11:49
danpbget a list of all devices from the XML, and then use the BDM to filter out ones we don't want to copy11:49
openstackgerritIldiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments  https://review.openstack.org/19313511:49
openstackgerritIldiko Vancsa proposed openstack/nova: comp: Allow multiple volume attachments  https://review.openstack.org/19313411:49
openstackgerritIldiko Vancsa proposed openstack/nova: db and obj: Allow multiple volume attachments  https://review.openstack.org/19313311:49
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: REST API changes to support multi-attach  https://review.openstack.org/15303811:49
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: virt: Pass host when call attach to Cinder  https://review.openstack.org/25627311:50
pkoniszewskidanpb: okay, thanks for the confirmation, i'll give it a shot and we will see how it behaves11:50
openstackgerritesracelik proposed openstack/nova: Config options: centralize "configdrive" options  https://review.openstack.org/25409211:50
*** thorst has joined #openstack-nova11:51
*** pkholkin has quit IRC11:51
*** gongysh has joined #openstack-nova11:51
johnthetubaguygibi: just added some comments on here: https://review.openstack.org/#/c/245678/3011:51
ndipanovgaryk, https://review.openstack.org/#/c/252565/11:52
*** Marga_ has quit IRC11:52
ndipanovgaryk, that in is the closest to an acceptable solution11:52
*** Marga_ has joined #openstack-nova11:52
ndipanovsadly really fixing this is not quite so easy :(11:52
*** tdurakov has quit IRC11:53
openstackgerritPetrut Lucian proposed openstack/nova: HyperV: Add FC attached volumes support  https://review.openstack.org/25861711:54
*** daemontool_ has quit IRC11:54
garykndipanov: that whole layer or unndecesary caching is so problematic and i cannot let you know how much time i have spent dealing with broken stuff here.11:55
ndipanovyeah it's not great11:55
garykwe should really throw away the neutron integration and write it from scratch. and then we can party like its 198411:55
ndipanovgaryk, yeah but that thing is even in a layer above11:56
*** MVenesio has joined #openstack-nova11:56
ndipanovimho the network_api is a broken abstraction11:56
*** markvoelker has joined #openstack-nova11:56
garyk:)11:56
ndipanovthough neutron integration is more broken11:56
ndipanovno idea11:56
ndipanovI am actually a bit sad about that bug11:57
*** EinstCrazy has joined #openstack-nova11:57
ndipanovit's embarrassing11:57
*** daemontool has joined #openstack-nova11:57
garyk:)11:57
*** pkholkin has joined #openstack-nova11:57
garykwe all have perfect vision in hindsight11:58
ndipanovright11:58
openstackgerritesracelik proposed openstack/nova: Config options: centralize section "hyperv"  https://review.openstack.org/25512411:58
*** carey has joined #openstack-nova11:58
ndipanovso would you mind grabbing the patch I pointed to and seeing if it does it for you if you have a sec11:58
ndipanovgaryk, ^11:58
*** thorst has quit IRC11:59
garykwill check. stepping out for a bite and will let you know a littler later11:59
openstackgerritTimofey Durakov proposed openstack/nova: Ceph for live-migration job  https://review.openstack.org/25228311:59
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli  https://review.openstack.org/26668711:59
johnthetubaguyndipanov: totally agreed about the abstraction being broken, I remember discussions of making it better match the neutron API, then change nova-network's interface to match that, so its easier to drop. I know few folks have looked at the issue, but they all mostly ran away (screaming)12:00
ndipanovjohnthetubaguy, I don't blame them - I remember the discussion from paris summit12:00
johnthetubaguyyeah, its a thorny issue12:00
*** markvoelker has quit IRC12:00
*** haomaiwang has quit IRC12:01
*** tdurakov has joined #openstack-nova12:01
*** aix has joined #openstack-nova12:01
*** haomaiwang has joined #openstack-nova12:01
*** doug-fish has joined #openstack-nova12:01
ndipanovjohnthetubaguy, one thing that I missed in that data migration patch btw: https://review.openstack.org/#/c/266560/12:01
*** tyagiprince has quit IRC12:01
ndipanovand these two may be interesting for you as well https://review.openstack.org/#/c/262938/12:02
ndipanovIMHO this is quite good work12:02
*** carey has quit IRC12:03
*** wasmum- has quit IRC12:03
johnthetubaguyndipanov: ah, I see that eliminate duplication patch now, I didn't see that one before, good stuff12:03
ndipanovI have ot look at that one more closely yes12:04
*** salv-orlando has quit IRC12:05
*** baoli has joined #openstack-nova12:05
*** salv-orlando has joined #openstack-nova12:05
*** vladikr has quit IRC12:06
*** baoli has quit IRC12:08
*** devananda has quit IRC12:08
*** sudipto has quit IRC12:08
*** xianghui has quit IRC12:09
openstackgerritJacky_lei_zhang proposed openstack/python-novaclient: Fix support customer ip protocol when create security-rule using nova-cli  https://review.openstack.org/26669012:10
*** xianghui has joined #openstack-nova12:11
*** devananda has joined #openstack-nova12:12
openstackgerritTimofey Durakov proposed openstack/nova: Handle SetAdminPasswdNotSupported raised by libvirt driver  https://review.openstack.org/25285012:13
tdurakovpkoniszewski, hi, are you around?12:16
*** baoli has joined #openstack-nova12:16
pkoniszewskitdurakov: hi, im there12:16
tdurakovso, about ps-2512:17
tdurakovhave you tested it locally?12:17
pkoniszewskii had whole series applied12:17
tdurakovpkoniszewski, so, it worked locally, right?12:18
*** baoli has quit IRC12:18
pkoniszewskilocally whole series worked12:18
tdurakovon nfs?12:18
pkoniszewskiwithout nfs12:18
openstackgerritesracelik proposed openstack/nova: Improve the help text for configdrive options  https://review.openstack.org/26687512:18
tdurakovblock-migration?12:19
pkoniszewskiyes12:19
tdurakovok, deployed env for to check things, will apply your patches and test with nfs12:19
*** paul-carlton1 has joined #openstack-nova12:19
pkoniszewskiI need to reimplement this patch anyway12:19
*** zenoway has joined #openstack-nova12:20
tdurakovyep, need to check job too anyway12:20
tdurakovbtw, noticed multionode job in check pipeline fails from time-to-time with similar symptoms12:21
tdurakovpkoniszewski, will ping you as have some results, thank you12:21
pkoniszewskitdurakov: you are welcome12:22
*** omnipresent has joined #openstack-nova12:24
*** zenoway has quit IRC12:24
*** takedakn has joined #openstack-nova12:25
tobascojohnthetubaguy: bauzas alaski can we have some input on a good way to move forward in resolving this https://bugs.launchpad.net/nova/+bug/146917912:25
openstacktobasco: Error: Could not gather data from Launchpad for bug #1469179 (https://launchpad.net/bugs/1469179). The error has been logged12:25
*** vivekd has quit IRC12:28
*** atuvenie has quit IRC12:28
*** dims has joined #openstack-nova12:28
*** otter768 has joined #openstack-nova12:30
*** vivekd has joined #openstack-nova12:32
*** atuvenie has joined #openstack-nova12:33
*** ociuhandu has quit IRC12:33
*** otter768 has quit IRC12:35
*** salv-orlando has quit IRC12:37
*** salv-orlando has joined #openstack-nova12:37
*** rk4n has joined #openstack-nova12:38
*** Marga_ has quit IRC12:38
*** rk4n has quit IRC12:39
*** PaulMurray has quit IRC12:40
*** rk4n has joined #openstack-nova12:40
*** shaohe_feng has quit IRC12:42
*** kaisers1 has joined #openstack-nova12:43
*** rk4n has quit IRC12:43
*** rk4n has joined #openstack-nova12:43
*** thorst has joined #openstack-nova12:43
*** rk4n has quit IRC12:46
*** kaisers1 has quit IRC12:47
*** rk4n has joined #openstack-nova12:47
*** rk4n has quit IRC12:48
*** mhorban_ has quit IRC12:49
*** lyanchih has joined #openstack-nova12:50
*** claudiub has joined #openstack-nova12:50
*** atuvenie has quit IRC12:52
*** atuvenie_ has joined #openstack-nova12:52
*** EinstCrazy has quit IRC12:52
*** EinstCrazy has joined #openstack-nova12:52
*** rk4n has joined #openstack-nova12:52
*** raildo-afk is now known as raildo12:55
*** lyanchih has quit IRC12:55
*** mhorban_ has joined #openstack-nova12:56
*** rk4n has quit IRC12:56
*** markvoelker has joined #openstack-nova12:57
*** burgerk has joined #openstack-nova12:57
*** takedakn has quit IRC12:58
*** xyang1 has joined #openstack-nova12:58
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Add functional tests launcher for py3 env  https://review.openstack.org/26689512:58
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: DO NOTE MERGE: check that functional tests works on py34 env  https://review.openstack.org/26689612:58
*** rk4n has joined #openstack-nova12:59
*** dane-fichter has joined #openstack-nova12:59
*** haomaiwang has quit IRC13:01
dane-fichterdims: Do you have any idea what the source for that 'wmi is not defined' error is? Your port to python3 patch and my image signature patch are both failing the py34 gate because of it.13:01
*** 16WAAJ6X5 has joined #openstack-nova13:01
*** markvoelker has quit IRC13:02
*** links has quit IRC13:04
*** ociuhandu has joined #openstack-nova13:04
*** akshai has joined #openstack-nova13:04
*** vivekd has quit IRC13:05
openstackgerritMoshe Levi proposed openstack/nova: Sets binding:profile to empty dic when unbinding port  https://review.openstack.org/26136913:05
openstackgerritPavel Kholkin proposed openstack/nova: fixed log warning in sqlalchemy/api.py  https://review.openstack.org/24690113:06
*** browne has joined #openstack-nova13:07
openstackgerritPavel Kholkin proposed openstack/nova: fixed log warning in sqlalchemy/api.py  https://review.openstack.org/24690113:07
*** akshai has quit IRC13:08
*** rcernin has joined #openstack-nova13:09
tobascojohnthetubaguy: seems like the bug we were talking about before has been up since mid 201413:10
tobascojohnthetubaguy: see my latest comment in https://bugs.launchpad.net/nova/+bug/1469179, there is also atleast two other approaches that has been tried, once was to modify the DiskFilter for the nova scheduler which we have come up to is not an ideal solution13:11
openstackLaunchpad bug 1469179 in OpenStack Compute (nova) "instance.root_gb should be 0 for volume-backed instances" [Medium,In progress] - Assigned to Feodor Tersin (ftersin)13:11
*** svenno has joined #openstack-nova13:11
*** akshai has joined #openstack-nova13:11
*** mgoddard has quit IRC13:12
*** mgoddard has joined #openstack-nova13:13
bauzastobasco: johnthetubaguy: sorry in the middle of booking for the summit13:14
*** dslevin has quit IRC13:15
*** ducttape_ has joined #openstack-nova13:15
*** browne has quit IRC13:16
openstackgerritjichenjc proposed openstack/nova: Not using mox stubs in nova.tests.unit.consoleauth  https://review.openstack.org/26690313:17
johnthetubaguytobasco: yes, we should not modify the diskfilter, thats for sure13:18
johnthetubaguywell, at least, I don't think that makes sense given how it currently looks13:18
*** pradk has joined #openstack-nova13:19
openstackgerritjichenjc proposed openstack/nova: Stop using mox stubs in nova.tests.unit.console  https://review.openstack.org/26683713:19
*** ccarmack has joined #openstack-nova13:20
*** pradk has quit IRC13:23
tobascojohnthetubaguy: i think the solution på Feodor (see my last comment in on launchpad) is valid, it just needs some refreshing. This bug has been on launchpad atleast since August 2014, and as I said earlier I really wanna push for a fix for this. We are already running this fix in our staging environment for more testing13:23
*** vivekd has joined #openstack-nova13:23
*** dustins has joined #openstack-nova13:23
*** baoli has joined #openstack-nova13:25
*** dims has quit IRC13:25
*** dims has joined #openstack-nova13:26
*** dslev has joined #openstack-nova13:27
*** Daisy has joined #openstack-nova13:30
*** markvoelker has joined #openstack-nova13:31
*** browne has joined #openstack-nova13:31
*** ferest has quit IRC13:34
BobBalljohnthetubaguy: Reminder - could you comment on the fix at https://review.openstack.org/#/c/254022/ pls? :)13:34
*** ducttape_ has quit IRC13:35
*** MCoLo has left #openstack-nova13:37
*** baoli_ has joined #openstack-nova13:37
*** edmondsw has joined #openstack-nova13:39
*** burgerk has quit IRC13:40
*** baoli has quit IRC13:40
*** venkat_ has joined #openstack-nova13:40
*** Daisy has quit IRC13:41
*** MCoLo has joined #openstack-nova13:41
*** Daisy has joined #openstack-nova13:42
*** venkat_ has left #openstack-nova13:43
*** 16WAAJ6X5 has quit IRC13:44
*** rlrossit has joined #openstack-nova13:45
openstackgerritTimofey Durakov proposed openstack/nova: Ceph for live-migration job  https://review.openstack.org/25228313:47
*** Daisy has quit IRC13:47
*** cfriesen has joined #openstack-nova13:47
*** jistr has quit IRC13:48
*** jistr has joined #openstack-nova13:49
*** unicell has joined #openstack-nova13:49
rlrossitjohnthetubaguy: I talked with dims yesterday, and I would like to get oslo.messaging's separation of the rpc and notification queues into nova. It doesn't look to be that big, but would this still require a blueprint?13:49
*** unicell1 has quit IRC13:50
*** browne has quit IRC13:50
johnthetubaguyrlrossit: we can add it into that generic oslo blueprint that is already approved, I think.13:50
rlrossitjohnthetubaguy: would that be https://blueprints.launchpad.net/nova/+spec/oslo-for-mitaka ?13:51
*** rook-desktio has quit IRC13:52
*** vivekd has quit IRC13:53
johnthetubaguyrlrossit: thats the one13:53
tojuvonejaypipes: Applied your comments: https://review.openstack.org/241562/13:53
ildikovjohnthetubaguy: hi13:54
rlrossitcoolio I'll get to work on that then13:54
*** akshai has quit IRC13:54
johnthetubaguyildikov: hi13:54
ildikovjohnthetubaguy: I know it's on your list, but may I ask haw far the multiattach series in the queue?13:54
*** MCoLo has quit IRC13:55
ildikovjohnthetubaguy: I just would like to be sure I'll have time to fix additional comments if any13:55
*** dslev has quit IRC13:55
johnthetubaguyildikov: had to take yesterday off work, so running behind right now13:55
jaypipestojuvone: coolio. will look again shiortly.13:55
ildikovjohnthetubaguy: also mriedem helps me out with tempest testing13:55
*** mtanino has joined #openstack-nova13:55
*** gjayavelu has joined #openstack-nova13:55
openstackgerritJohn Garbutt proposed openstack/nova: Fix sphinx warnings from signature_utils  https://review.openstack.org/26474513:56
*** eharney has joined #openstack-nova13:56
ildikovjohnthetubaguy: ok, I got that, but if there's a chance to get to the series a bit sooner than later I would very much appreciate that13:56
*** Daisy has joined #openstack-nova13:57
ildikovjohnthetubaguy: if there's anything that would be faster to discuss here, please ping me any time13:58
openstackgerritJohn Garbutt proposed openstack/nova: Get support matrix notes from the ini file  https://review.openstack.org/26476313:58
*** carey has joined #openstack-nova13:59
openstackgerritPetrut Lucian proposed openstack/nova: HyperV: Add FC attached volumes support  https://review.openstack.org/25861714:00
*** vladikr has joined #openstack-nova14:00
*** akshai has joined #openstack-nova14:00
openstackgerritPavel Kholkin proposed openstack/nova: enginefacade: 'ec2_instance' and 'instance_fault'  https://review.openstack.org/26197914:01
*** jichen has quit IRC14:01
*** PaulMurray has joined #openstack-nova14:02
*** dane-fichter has quit IRC14:02
*** rmart04_ has joined #openstack-nova14:03
*** rmart04 has quit IRC14:04
*** rmart04_ is now known as rmart0414:04
*** carey has quit IRC14:04
*** links has joined #openstack-nova14:04
*** drankis has joined #openstack-nova14:05
*** rk4n has quit IRC14:06
tojuvonejaypipes: Thanks :)14:06
*** drankis has quit IRC14:06
*** rk4n has joined #openstack-nova14:06
*** lyanchih has joined #openstack-nova14:07
*** zz_dimtruck is now known as dimtruck14:07
sdaguejohnthetubaguy: I just sent an email about the project_id matching problem. If you could take a look, that would be great. I'm kind of stuck until we figure out a path forward here.14:07
*** ctrath has joined #openstack-nova14:08
*** links has quit IRC14:09
*** links has joined #openstack-nova14:09
*** dslev has joined #openstack-nova14:10
*** mdrabe has joined #openstack-nova14:10
*** sudipto has joined #openstack-nova14:12
*** annegentle has joined #openstack-nova14:14
*** thumpba has joined #openstack-nova14:15
*** pratikmallya has joined #openstack-nova14:15
*** ildikov has quit IRC14:15
openstackgerritMike Fedosin proposed openstack/nova: [WIP] Make Xenplugin to work with glance v2 api  https://review.openstack.org/26693314:17
*** salv-orlando has quit IRC14:18
*** ferest has joined #openstack-nova14:18
*** salv-orlando has joined #openstack-nova14:18
*** ljxiash_ has joined #openstack-nova14:19
*** lyanchih has quit IRC14:20
*** ljxiash has quit IRC14:20
*** artom has joined #openstack-nova14:21
johnthetubaguysdague: so that only works because the targets use letters other than a-f and keystone uuids doesn't include "-"?14:21
*** tojuvone is now known as tojuvone_away14:22
*** baoli_ has quit IRC14:22
*** haomaiwang has joined #openstack-nova14:22
johnthetubaguysdague: if we wanted v2.1/extensions/abc and v2.1/{project-id}/abc would we would be screwed? or did I miss-read it?14:23
rlrossitalright, this is probably a stupid question, but where are the tests for the rpc module?14:23
*** baoli has joined #openstack-nova14:23
rlrossitdansmith: I think I've become test blind14:23
*** haomaiwang has quit IRC14:24
*** 21WAAR2TX has joined #openstack-nova14:24
*** links has quit IRC14:25
bauzastobasco: johnthetubaguy: so I'm back14:25
bauzastobasco: what do you want to do ?14:25
*** lyanchih has joined #openstack-nova14:25
*** Daisy has quit IRC14:25
*** w_verdugo has joined #openstack-nova14:25
*** links has joined #openstack-nova14:25
*** Daisy has joined #openstack-nova14:26
*** diogogmt has quit IRC14:26
*** mriedem has joined #openstack-nova14:26
mriedemahoy14:26
bauzasaloha14:27
*** dimtruck is now known as zz_dimtruck14:27
*** baoli_ has joined #openstack-nova14:27
*** READ10 has joined #openstack-nova14:28
*** dslev has quit IRC14:29
*** erlon has joined #openstack-nova14:29
*** links has quit IRC14:29
mriedemif anyone is looking for something to do, we've had at least one CVE fix go into stable/liberty which will be in the upcoming 12.0.1 release,14:30
*** links has joined #openstack-nova14:30
mriedemand we need a release note for the CVE(s) that have gone in since 12.0.014:30
*** baoli has quit IRC14:30
*** Daisy has quit IRC14:30
*** otter768 has joined #openstack-nova14:31
dansmithrlrossit: okay, link me again and I can try to look after I get coffee14:31
mriedemmdbooth: https://review.openstack.org/#/c/264814/ is almost to the gate14:32
openstackgerritJacky_lei_zhang proposed openstack/nova: Fix support customer ip protcol when create security-rule using nova-cli  https://review.openstack.org/26668714:32
mriedemmdbooth: looks like you were going to redo https://review.openstack.org/#/c/264817/ ?14:32
mdboothmriedem: Again :) Yeah, I'll redo the stable backport when it lands.14:33
mdboothMight as well.14:33
*** thumpba has quit IRC14:33
mriedemmdbooth: i guess i don't understand the issue with the stable/liberty one that tonyb updated,14:34
mriedemthe commit id looks fine14:34
mriedemhttps://review.openstack.org/#/c/264814/14:34
mriedemoops14:34
mriedem6ce0bb1fb017ee4094bb11500c2a418db3d6ec2114:34
*** browne has joined #openstack-nova14:34
*** lucasagomes is now known as lucas-hungry14:35
mdboothYeah, not sure what the rebase issue was. Perhaps gerrit was having an off day.14:35
mdboothDidn't see it myself.14:35
mriedemi see the changes underneath failed jenkins, i'm looking into those14:35
mriedemlooks like large ops on stable/liberty is busted14:35
mdboothI've seen a ton of failures in that job over the last few days.14:36
*** otter768 has quit IRC14:36
mriedemhmm, ovh nodes14:36
mriedemthey are slower14:36
sdaguejohnthetubaguy: no, that's fine still14:36
*** smatzek has quit IRC14:36
rlrossitdansmith: this isn't the fixed IP stuff, I haven't looked at that yet today. Now my problem is that I don't see any tests for nova.rpc that I can add to for my oslo.messaging change. I think I'm just bad at looking for tests14:36
sdaguewe only get screwed if we have a top level resource which is only hex14:36
sdague /v2.1/badcafe/foo14:36
mriedemtime to run sdague's failopotomus or whatever it's called14:36
mdboothRandom thought, btw, would it be feasible for 'recheck' of something that failed in the gate to skip the 'check' queue next time round?14:37
tobascobauzas: would like to have your opinion in reviving this review https://review.openstack.org/#/c/200870/14:37
mriedemnope14:37
*** lyanchih has quit IRC14:37
mdboothWhat's the thinking there?14:37
tobascomriedem: would appreciate if you could give a quick look aswell https://review.openstack.org/#/c/200870/ ty14:37
mdbooth(or rtfm)14:37
*** lyanchih has joined #openstack-nova14:37
mriedemmdbooth: i think b/c something could have merged before it in the gate which makes it require a rebase for check14:38
mriedemso putting it back into gate again is just a waste of time14:38
*** dslevin has joined #openstack-nova14:38
dansmithrlrossit: ah, well the tests for that are usually per service like compute/test_rpcapi if that's what you're looking for14:39
*** thumpba has joined #openstack-nova14:39
mriedemhttp://tinyurl.com/peuhlyp14:39
mriedemit's not spiking...14:39
sdaguemdbooth / mriedem - or people recheck grind even though their patch is an issue, but it got a +A, so anyone can push it back to the gate queue and dos us.14:40
mriedemhttp://tinyurl.com/j5u4nf514:40
mriedemso large ops isn't spiking14:40
mdboothMaybe I've had a string of bad luck14:41
sdaguemriedem: that's all branches though14:41
mdboothOr more likely some kind of perception bias14:41
bauzastobasco: I feel the commit msg is good14:41
bauzastobasco: you got my blessing for resurrecting it14:41
sdagueI don't know if there is a good way to get a specific branch other than elastic recheck queries14:41
mriedemsdague: yeah doing that now14:41
*** cdent has quit IRC14:42
openstackgerritAndrey Pavlov proposed openstack/nova: remove EC2 legacy code  https://review.openstack.org/26642514:42
rlrossitdansmith: but are those testing just the API, and indirectly testing that nova.rpc? I'm wondering because I can do some pretty nasty things to the nova.rpc module and none of the unit tests are stopping me14:42
mdboothsdague: Do check and gate share resources, btw?14:43
dansmithrlrossit: ah, well a lot of it is inherited from oslo, so we might've removed (long ago) some coverage on that basis14:43
mriedemsdague: interesting http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22failed%20to%20reach%20ACTIVE%20status%20and%20task%20state%20%5C%5C%5C%22None%5C%5C%5C%22%20within%20the%20required%20time%20(196%20s).%20Current%20status:%20BUILD.%20Current%20task%20state:%20scheduling.%5C%22%20AND%20tags:%5C%22console%5C%22%20AND%20build_name:*-large-ops&from=7d14:43
dansmithrlrossit: what kind of things go undetected?14:43
mriedemsdague: it's all branches, and it is spiking in failures since yesterday14:44
rlrossitdansmith: not cleaning things up passed all tests14:44
mriedemon all nodes14:44
*** mrkz has joined #openstack-nova14:44
dansmithrlrossit: use more words14:44
dansmithrlrossit: like, I'm not sure why any dict cleanup would be needed in that code14:45
rlrossitdansmith: commented out TRANSPORT.cleanup() in cleanup() let everything pass14:45
mriedemthere isn't even an n-net log here? http://logs.openstack.org/15/264815/2/check/gate-tempest-dsvm-large-ops/bdb7af7/logs/14:45
*** EinstCrazy has quit IRC14:45
rlrossitdansmith: and, I changed over to make the notifier use oslo.messaging's new notification transport, and no that passed everything without changing any unit tests14:46
dansmithrlrossit: well, I guess I'd have to look to see if that's surprising to me, but okay14:46
rlrossitwow words are hard today14:46
dansmithI mean, in general, what you're saying seems right(ly scary) but.. if it's from the really early days, we have a lot of stuff like that with super minimal coverage14:47
dansmithgood that you're uncovering it and fixing it though :)14:47
openstackgerritDaniel Berrange proposed openstack/nova: objects: add virtual 'image_meta' property to Instance object  https://review.openstack.org/19014514:47
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: convert to use instance.image_meta property  https://review.openstack.org/19014614:47
openstackgerritDaniel Berrange proposed openstack/nova: compute: convert manager to use nova.objects.ImageMeta  https://review.openstack.org/18968514:47
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Add functional tests launcher for py3 env  https://review.openstack.org/26689514:47
*** rk4n has quit IRC14:48
rlrossitdansmith: I'd be more than happy to uncover it and *not* fix it, but then I'd feel guilty14:48
dansmithrlrossit: yep14:48
*** pradk has joined #openstack-nova14:49
dimsmriedem : only 2 of those 22 on that logstash query is on build_branch master14:51
mriedemyeah14:51
mriedemwell,14:51
mriedemhttp://logs.openstack.org/15/264815/2/check/gate-tempest-dsvm-large-ops/bdb7af7/logs/ - there is no nova-network in dstat14:52
mriedemkind of hard to boot an instance with networking when there is no networking service14:52
mriedemi don't see any failures in devstack14:52
*** burt has joined #openstack-nova14:53
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: nova conf single point of entry: fix error message  https://review.openstack.org/26695914:55
*** davidlenwell has quit IRC14:57
*** bklei has joined #openstack-nova14:58
openstackgerritRyan Rossiter proposed openstack/nova: Use get_notification_transport() for notifications  https://review.openstack.org/26696014:58
rlrossitdansmith: ^ is what originally caused my fear of unit tests not failing14:58
*** davidlenwell has joined #openstack-nova14:59
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [python3] byte/string conversions and enable more tests  https://review.openstack.org/26104515:00
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [python3] Port more code to python3 and enable tests  https://review.openstack.org/26208315:00
*** 21WAAR2TX has quit IRC15:01
*** haomaiwang has joined #openstack-nova15:01
openstackgerritBalazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications  https://review.openstack.org/26378815:01
openstackgerritBalazs Gibizer proposed openstack/nova: Add service status notification  https://review.openstack.org/24567815:01
openstackgerritBalazs Gibizer proposed openstack/nova: Generate doc for versioned notifications  https://review.openstack.org/26515115:01
openstackgerritBalazs Gibizer proposed openstack/nova: Add infra for versioned notifications  https://review.openstack.org/24702415:01
openstackgerritBalazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications  https://review.openstack.org/24816715:02
openstackgerritBalazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable  https://review.openstack.org/24756415:02
*** w_verdugo has quit IRC15:03
johnthetubaguysdague: ah, yeah, thats what I was thinking. But it seems like the best compromise15:03
*** w_verdugo has joined #openstack-nova15:03
mriedemi have no idea what is causing this http://logs.openstack.org/15/264815/2/check/gate-tempest-dsvm-neutron-large-ops/1cdb7d6/logs/devstacklog.txt.gz#_2016-01-13_10_17_32_14915:04
*** ducttape_ has joined #openstack-nova15:05
*** artom has quit IRC15:05
*** links has quit IRC15:07
openstackgerritSudipta Biswas proposed openstack/nova: Base enablement for memory bandwidth monitor  https://review.openstack.org/26677315:08
*** dave-mccowan has joined #openstack-nova15:09
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: DO NOTE MERGE: check that functional tests works on py34 env  https://review.openstack.org/26689615:09
*** burgerk has joined #openstack-nova15:10
gibijohnthetubaguy: I've respin the versioned notification chain based on your suggestions. I feel we are close.15:11
johnthetubaguygibi: it does feel close15:11
*** w_verdugo has quit IRC15:13
mriedemgaryk: i noticed that vmware nsx ci failed on this https://review.openstack.org/#/c/231468/15:13
mriedemgaryk: it's pretty trivial looking, but there is a backport proposed15:13
*** dave-mccowan has quit IRC15:13
mriedemso i'm hoping it's not a problem15:13
johnthetubaguygibi: we want to add the register_if(false) in the main code?15:14
johnthetubaguyI mean, do we15:14
gibijohnthetubaguy: I tried, everything works without that. What can go wrong?15:15
*** zz_dimtruck is now known as dimtruck15:15
rlrossitgibi: johnthetubaguy: which change had that in it?15:15
johnthetubaguygibi: heh, yeah, I think its just so its explicitly not registered, but its a nit for15:15
johnthetubaguyrlrossit: https://review.openstack.org/#/c/247024/28/nova/objects/notification.py15:16
gibijohnthetubaguy: ahh, so explicitness, good ideas, so others will not ask why it is not registered.15:16
*** cdent has joined #openstack-nova15:17
*** sudipto has quit IRC15:17
gibiI'm editing right now...15:17
openstackgerritMoshe Levi proposed openstack/nova: Enhance PCI passthrough whitelist to support regex  https://review.openstack.org/19948815:17
rlrossitwait those weren't registered before? huh good catch johnthetubaguy15:18
johnthetubaguyrlrossit: yeah, they don't want to be registered, as they shouldn't really get used, they are just base objects15:18
moshelemriedem: can you approve this https://review.openstack.org/#/c/261369/ again  ? I had to rebase it15:18
openstackgerritDan Smith proposed openstack/nova: Actually pass the migration data object down to the virt drivers  https://review.openstack.org/24821115:19
rlrossitjohnthetubaguy: but we still want to have them checked in the hashes right?15:19
openstackgerritDan Smith proposed openstack/nova: Allow sending the migrate data objects over the wire  https://review.openstack.org/25158815:19
*** breitz has quit IRC15:19
rlrossitso it should still be a regular register15:19
mriedemmoshele: looking15:19
*** edtubill has joined #openstack-nova15:20
rlrossitbut I guess since all the inheriting classes pick up on all of the fields, if we add a field in the base classes, it will enforce a version bump on all the subclasses, so I guess register_if(False) can work15:20
*** boris-42 has joined #openstack-nova15:20
*** omnipresent has quit IRC15:20
*** zenoway has joined #openstack-nova15:21
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Block flaky python34 test : vmwareapi.test_configdrive.ConfigDriveTestCase  https://review.openstack.org/26697615:21
dimsmriedem : one more bad test15:21
gibirlrossit: yeh the idea is that subclasses will be registered and the base class shall never be used directly15:22
johnthetubaguyrlrossit: so, I am not sure how that works, thinking about it, I hope a change to the base would trigger all the subclasses hashes anyways?15:22
mriedemmoshele: done15:23
*** rk4n has joined #openstack-nova15:23
moshelemriedem: thanks15:23
rlrossitjohnthetubaguy: might have to check with dansmith, but as far as I understand, if we add a field, that's brought down through the magical inheritance of the register_if(False), so yeah, the subclasses should have a fingerprint change if something is added to the base classes15:24
dansmithyep15:25
rlrossitthe register_if(False) bit is important though because that is what applies the class properties (putting fields as attributes on the object)15:25
dansmithalso yep15:25
*** READ10 has quit IRC15:25
gibirlrossit, johnthetubaguy: OK, then I will put the register_if there15:25
johnthetubaguycool15:25
*** shyama has quit IRC15:25
*** zenoway has quit IRC15:25
*** shyama has joined #openstack-nova15:26
*** READ10 has joined #openstack-nova15:27
*** rk4n has quit IRC15:28
*** armax has quit IRC15:28
garykmriedem: will look into that15:28
*** liusheng has quit IRC15:28
*** szhsong has quit IRC15:28
*** szhsong has joined #openstack-nova15:29
*** w_verdugo has joined #openstack-nova15:29
*** ctrath has quit IRC15:30
*** yamahata has joined #openstack-nova15:30
openstackgerritBalazs Gibizer proposed openstack/nova: doc: add devref about versioned notifications  https://review.openstack.org/26378815:31
openstackgerritBalazs Gibizer proposed openstack/nova: Add service status notification  https://review.openstack.org/24567815:31
openstackgerritBalazs Gibizer proposed openstack/nova: Generate doc for versioned notifications  https://review.openstack.org/26515115:31
openstackgerritBalazs Gibizer proposed openstack/nova: Add infra for versioned notifications  https://review.openstack.org/24702415:31
openstackgerritBalazs Gibizer proposed openstack/nova: Adds json sample for the versioned notifications  https://review.openstack.org/24816715:31
openstackgerritBalazs Gibizer proposed openstack/nova: Make emitting versioned notifications configurable  https://review.openstack.org/24756415:31
gibijohnthetubaguy, rlrossit: fix is up ^^15:31
*** dave-mcc_ has joined #openstack-nova15:32
lxsliPaulMurray: ping15:33
pkoniszewskidansmith: hi, there?15:33
dansmithpkoniszewski: yes15:33
*** shyama has quit IRC15:33
PaulMurraythanks lxsli15:34
*** tonytan4ever has joined #openstack-nova15:34
*** ctrath has joined #openstack-nova15:34
*** gjayavelu has quit IRC15:34
*** mdrabe has quit IRC15:35
*** lucas-hungry is now known as lucasagomes15:36
openstackgerritTimofey Durakov proposed openstack/nova: Ceph for live-migration job  https://review.openstack.org/25228315:36
*** acabot_ has joined #openstack-nova15:36
dave-mcc_https://review.openstack.org/#/c/254358 needs another workflow, please.  the merge failed when a couple gate jobs timed out before they finished.15:36
mriedemdave-mcc_: you just recheck that then15:37
mriedemit doesn't require another +W15:37
mriedemdave-mcc_: the elastic-recheck bot even commented on the change as to what known bug it failed with15:37
mriedemand gives instructions15:37
gibijohnthetubaguy: thanks!15:38
*** szhsong has quit IRC15:39
*** acabot_ has quit IRC15:39
dave-mcc_mriedem.  thanks.  i had thought that recheck wouldn't restart the merge.15:39
*** szhsong has joined #openstack-nova15:39
mriedemdave-mcc_: it will put it back in the check queue15:39
mriedemif it passes there it goes to gate queue as normal15:39
mriedemyou can monitor it here http://status.openstack.org/zuul/15:39
*** thangp has joined #openstack-nova15:40
*** Sukhdev has joined #openstack-nova15:40
mriedemfiler by 25435815:40
mriedem*filter15:40
*** fawadkhaliq has joined #openstack-nova15:40
*** thangp has left #openstack-nova15:41
*** acabot_ has joined #openstack-nova15:41
johnthetubaguydansmith: have you got a sec to help remove my confusion around this change: https://review.openstack.org/#/c/193133/46 I am trying to think about the best way to make this backwards compatible15:41
dansmithjohnthetubaguy: yeah, I've looked at this a couple times15:41
dansmithjohnthetubaguy: to be honest, it concerns me15:41
johnthetubaguydansmith:yeah, me too15:42
mriedemme 3!15:42
dansmithjohnthetubaguy: I kinda feel like the safest thing is to retool everything in nova to understand multiple attachments, then wait a cycle and then actually allow it to be used15:42
johnthetubaguyactually just realised the bit I was missing, getting it back for a different instance15:42
dansmithwhich I know is not a very popular position to take15:42
dansmithright15:42
alaskidansmith: +115:42
johnthetubaguyI think thats the only safe way forward15:42
mriedemso i think the point made was,15:43
mriedemin what case(s) is db.block_device_mapping_get_by_volume_id( called15:43
johnthetubaguyI mean we could check the service version, I suppose, but that seems too messy15:43
mriedemand i think it's just the assisted snapshot case, which should be blocked in the multiattach series anyway15:43
dansmithjohnthetubaguy: well, that was my suggestion if we have to merge this, but it does get a little hairy doing it that way, because we'd be denying the second attach based on that in the api,15:44
mriedemsee volume_snapshot_create here: https://review.openstack.org/#/c/193134/69/nova/compute/api.py15:44
dansmithjohnthetubaguy: plus we have to have some way to atomically make sure we don't allow more than one until the version lifts15:44
*** sudipto has joined #openstack-nova15:44
*** mgoddard_ has joined #openstack-nova15:45
*** gongysh_ has joined #openstack-nova15:45
johnthetubaguydansmith: true, APIs behind the LB doing different things again15:45
*** thangp has joined #openstack-nova15:45
*** zenoway has joined #openstack-nova15:45
dansmithFWIW, you have four cores here pretty concerned about it :/15:45
dansmiththree important ones and ... me15:46
mriedemi'm just trying to understand the scenario where it falls down15:46
johnthetubaguyalaski: dansmith: mriedem: seems like we are largely agreeing the safest approach is to add new tooling, move to it, then move the API across15:46
mriedemlet me comment in the review15:46
johnthetubaguyI was missing that extra case, till just now, but yeah, this seems fairly tricky15:47
*** armax has joined #openstack-nova15:48
tdurakovsdague, hi, are you around?15:48
*** mgoddard has quit IRC15:48
alaskimriedem: it falls down for remove_volume_connection and _detach_volume and swap_volume in compute/manager15:49
alaskion an older compute15:49
*** zenoway has quit IRC15:49
mriedemah https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L487915:50
johnthetubaguymriedem: alaski: +115:50
mriedemah for detach we even have the instance https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L470015:50
mriedembut didn't use it15:50
mriedemsame with swap15:50
johnthetubaguyyep15:50
*** mragupat has joined #openstack-nova15:50
dansmithright, because all these assume the singular case15:50
mriedemand that's where people were talking about doing a hack in stable/liberty to update those, but that's assuming people would update their liberty computes before deploying mitaka api15:51
mriedemwhich we can't assume15:51
johnthetubaguyseems like add the new method, this release, move this release to start using the new method, bump major version, add the support next release?15:51
johnthetubaguymriedem: yeah, I don't want to rely on that every release15:51
*** tojuvone_away is now known as tojuvone15:52
johnthetubaguyparticular since we claim to support continuous deployment15:52
*** mdrabe has joined #openstack-nova15:52
*** matrohon has quit IRC15:54
dansmithyeah, backporting something only to liberty to allow for this feature to land is pretty uncool15:55
dansmithdo it when we have to for a bug, but..15:55
mriedemi think i've doc'ed the case now https://review.openstack.org/#/c/193133/46/nova/db/sqlalchemy/api.py15:55
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/26616015:55
*** diogogmt has joined #openstack-nova15:55
mriedemso it sounds like the only other possible solution is to check the compute service version before sending any multiattach requests15:55
mriedembut i'm not clear on how that is done or where15:55
mriedembtw, cinder meeting in 4 minutes where this will probably come up15:56
dansmithmriedem: it's done by calling Service.get_minimum_version()15:56
mriedemand if you have at least one liberty compute that will return the liberty compute version?15:56
dansmithmriedem: but we have to be able to do that in a place/scenario where we can ensure that we're denying the second attach and not allow a race between first and second attach to allow both to continue15:56
dansmithmriedem: yes15:57
*** kfarr has joined #openstack-nova15:57
openstackgerritRushi Agrawal proposed openstack/nova: Remove almost all mox from tests/unit/objects/test_instance.py  https://review.openstack.org/26429215:57
mriedemwell i'd guess we'd do it in the compute APIs attach method15:58
openstackgerritTimofey Durakov proposed openstack/nova: Ceph for live-migration job  https://review.openstack.org/25228315:58
mriedemwe could check to see if the volume is a multiattach volume and if it already has at least one attachment (it's status would be in-use)15:58
dansmithmriedem: where? in db_api?15:58
mriedemcould actually maybe be in the volume_api.check_attach method where the status checking is already happening on the volume15:58
mriedemno i wasn't thinking db api15:59
dansmithI don't think we can there15:59
mriedemb/c concurrency?15:59
*** hemnafk is now known as hemna15:59
*** garyk has quit IRC15:59
*** devananda has quit IRC15:59
* mriedem jumps to cinder meeting16:00
dansmithhmm, I guess if you check the service version first, then try to attach it..16:00
*** carey has joined #openstack-nova16:00
dansmiththere might be some ordering that lets cinder serialize for you , I dunno16:00
*** kmartin has joined #openstack-nova16:00
dansmithstill seems worrisome16:00
johnthetubaguyoh, using the in-use to serialize, basically16:00
johnthetubaguyeek, possibly16:00
dansmithwell,16:00
dansmithI don't know the semantics of the cinder call16:00
*** haomaiwang has quit IRC16:01
dansmithwe'd depend heavily on those being right and not changing16:01
johnthetubaguyoh, so there is an issue, I think...16:01
johnthetubaguyanother use could be attached to the volume, outside of nova16:01
mriedemthe compute api calls off to cinder to 'reserve' the volume before casting off to compute to actually attach16:01
mriedemthe reserve call puts the volume in-use16:01
mriedem*sorry16:01
*** haomaiwang has joined #openstack-nova16:01
mriedemputs it in 'attaching' status16:01
mriedemthe compute call to cinder os-attach actually changes the volume status to in-use16:01
dansmithand can we tell if multiples have done that atomically?16:01
*** devananda has joined #openstack-nova16:01
mriedemjohnthetubaguy: well we don't support 'outside of nova' cases right?16:02
johnthetubaguyyeah, I can't remember if multiples go to attaching? or just stay in-use?16:02
mriedemwe need hemna for that16:02
johnthetubaguymriedem: I was thinking cinder was adding that soon16:02
mriedemjohnthetubaguy: they have to go to attaching if already attached to one and you're attaching another16:02
mriedemelse the caller never knows when it can start hitting the mountpoint on that instance16:02
mriedemi was talking to smcginnis about that last night b/c i'm writing the tempest test for this16:03
johnthetubaguyI guess16:03
hemnahey16:03
hemnain cinder meeting at the moment16:03
mriedemhemna: we can circle back after the cinder meeting16:03
*** bklei has quit IRC16:03
hemnaok16:03
mriedemjohnthetubaguy: L105 here: https://review.openstack.org/#/c/266605/2/tempest/api/compute/volumes/test_attach_volume.py16:04
*** carey has quit IRC16:05
*** mjura has quit IRC16:06
*** moshele has quit IRC16:09
*** zenoway has joined #openstack-nova16:09
*** rmart04 has quit IRC16:10
openstackgerritTimofey Durakov proposed openstack/nova: Ceph for live-migration job  https://review.openstack.org/25228316:10
*** salv-orl_ has joined #openstack-nova16:10
*** ljxiash_ has quit IRC16:11
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: deprecate live/block_migration_flag opts  https://review.openstack.org/26343616:12
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: remove the live/block_migration_flag opts  https://review.openstack.org/26343716:12
openstackgerritMark McLoughlin proposed openstack/nova: libvirt: add a new live_migration_tunnelled config  https://review.openstack.org/26343416:12
*** artom has joined #openstack-nova16:12
*** zhihaisong has joined #openstack-nova16:12
*** ctrath has quit IRC16:12
*** szhsong has quit IRC16:12
*** ljxiash has joined #openstack-nova16:13
*** salv-orlando has quit IRC16:13
rlrossitdansmith: alright, I'm confused. https://review.openstack.org/#/c/265444/ has basically identical logs to my FixedIP change (https://review.openstack.org/#/c/265951/)16:13
dansmithboth of those probably interact in instance.save() right?16:14
dansmithhave you checked to make sure those logs don't happen on other people's changes?16:14
*** zenoway has quit IRC16:14
*** atuvenie_ has quit IRC16:14
rlrossitwell, https://review.openstack.org/#/c/231689/ doesn't have it16:16
rlrossitso did I introduce a bug in 265444?16:16
*** lyanchih has quit IRC16:16
*** ctrath has joined #openstack-nova16:17
*** klkumar has quit IRC16:17
*** acabot_ has quit IRC16:18
*** dims_ has joined #openstack-nova16:18
*** lyanchih has joined #openstack-nova16:19
openstackgerritStephen Finucane proposed openstack/nova: Cleanup NovaObjectDictCompat from BandwidthUsage  https://review.openstack.org/26363816:20
openstackgerritStephen Finucane proposed openstack/nova: Cleanup NovaObjectDictCompat from NumaTopology  https://review.openstack.org/26001616:20
*** Marga_ has joined #openstack-nova16:20
rlrossitwell wait https://review.openstack.org/#/c/247024/ has it so something in master must've started those up16:21
*** dims has quit IRC16:21
*** acabot_ has joined #openstack-nova16:21
dansmithrlrossit: when did it start?16:22
*** ihrachys has quit IRC16:22
openstackgerritAndrew Laski proposed openstack/nova: Persist the request spec during an instance boot  https://review.openstack.org/25862816:22
*** smatzek has joined #openstack-nova16:23
*** angdraug has joined #openstack-nova16:23
openstackgerritDaniel Berrange proposed openstack/nova: hacking: check for common double word typos  https://review.openstack.org/24919316:23
* rlrossit doesn't know logstash wizardry like mriedem16:23
*** ferest has quit IRC16:24
*** lyanchih has quit IRC16:24
mriedemlink?16:24
*** tonytan4ever has quit IRC16:24
rlrossitmriedem: trying to find when these error messages started popping up http://logs.openstack.org/44/265444/1/check/gate-tempest-dsvm-full/eb4cac5/logs/screen-n-api.txt.gz?level=ERROR16:25
mriedemknown issue16:25
mriedemhttps://review.openstack.org/#/c/265950/16:25
mriedemget that approved and released16:25
rlrossitso those errors aren't being caused by me...16:26
rlrossitdang16:26
dansmithhah16:26
*** zenoway has joined #openstack-nova16:26
mriedemsdague: i answered your -1 here https://review.openstack.org/#/c/265950/16:26
mriedemwould be nice to move on that16:26
mriedemftr, i don't know what a-hole introduced those...16:27
*** jdurgin1 has joined #openstack-nova16:27
*** acabot_ has quit IRC16:28
openstackgerritRussell Bryant proposed openstack/os-vif: Import of code from https://github.com/jaypipes/os_vif  https://review.openstack.org/26637716:28
pkoniszewskidansmith: hi again, sorry for the delay16:30
*** ildikov has joined #openstack-nova16:30
dansmithpkoniszewski: you missed me, I'm not here anymore16:30
* dansmith jokes16:31
danpbdoes anyone know who the helpful people on the infra team are ?16:31
mriedemdanpb: all of them?16:31
* danpb is trying to get someone to deal with gerrit group membership for os-vif but just getting ignored on #openstack-infra16:31
mriedemdanpb: fungi, clarkb, jeblair, anteaya16:31
danpbmriedem: any specific people worthing pinging16:31
pkoniszewskidansmith: I just ran an issue introduced by https://review.openstack.org/#/c/247720/16:31
danpbah thanks16:31
pkoniszewskiinto an issue *16:31
*** gcb has quit IRC16:31
anteayadanpb: what is up?16:32
*** otter768 has joined #openstack-nova16:32
*** gcb has joined #openstack-nova16:32
dansmithpkoniszewski: what issue?16:32
pkoniszewskidansmith: basically my patches to allow block live migration of an instance with attached volumes are failing, because there is missing "True" when converting migrate data object to legacy dict16:32
*** zhihaisong has quit IRC16:32
*** szaher_ has joined #openstack-nova16:33
*** gjayavelu has joined #openstack-nova16:33
danpbanteaya: we had the os-vif  project added to infra just before xmas16:33
dansmithpkoniszewski: link?16:33
danpbanteaya: bt the os-vif-core group on gerrit is empty so i can't approve any patches or add any other reviews16:33
danpbanteaya: are you able to add me to  https://review.openstack.org/#/admin/groups/1175,members16:33
anteayadanpb: right I saw you ask a few times the other day16:33
danpb(my acct is with email addr  berrange@redhat.com)16:33
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova-specs: spec update: centralize-config-options  https://review.openstack.org/26701416:33
anteayaI don't have gerrit admin permissions so can't add you16:34
*** zakora has quit IRC16:34
anteayadanpb: let me time the request and I'll try to help16:34
*** zhihaisong has joined #openstack-nova16:34
danpbanteaya: do you know who would be a good person to ask16:34
anteayadanpb: stand by16:34
danpbthanks16:34
anteayadanpb: just be in -infra and hang on16:34
danpbok16:34
anteayafinishing one conversation and I have another on hold will try to get you in throught the gap16:34
pkoniszewskidansmith: https://review.openstack.org/#/c/247719/10/nova/compute/manager.py line 5083 is missing pre_live_migrate_data=True parameter16:34
*** mpavone has quit IRC16:35
pkoniszewskidansmith: I see that you are adding it in https://review.openstack.org/#/c/248211/28/nova/compute/manager.py16:35
dansmithpkoniszewski: I think if you allow my bottom patch to merge you can do away with that whole check16:35
*** nic has joined #openstack-nova16:36
ildikovjohnthetubaguy: mriedem: dansmith: hi, sorry, I'm back, just read the logs16:36
*** mhorban_ has quit IRC16:37
sdaguemriedem: it's still failing jenkins16:37
*** otter768 has quit IRC16:37
pkoniszewskidansmith: if you are sure that your bottom patch is "nearly" merged then it's fine...16:38
mriedemsdague: ah, looking, doen't look like my issue though16:38
mdboothmriedem: Does the gate job literally just merge commits, then? I was under the impression that commits are somehow rebased in the process of being merged.16:38
mriedemmdbooth: http://docs.openstack.org/infra/zuul/gating.html16:38
mdboothi.e. I was expecting my commit id to be different when it lands to what it is now.16:38
ildikovjohnthetubaguy: mriedem: dansmith: what if having an experimental flag for multiattach, which can be enabled ig the env is safe, so basically people can "play" with it in labs, etc. on top of that if that's possible we can also check the compute version16:39
mriedemildikov: let's wait to talk about multiattach until after the cinder meeting is over16:39
dansmithpkoniszewski: sdague and danpb and mriedem would love to hit the merge button on that to help you out :P16:39
*** zhihais has joined #openstack-nova16:39
ildikovmriedem: yeah, thanks, sorry I just got to that part in the log16:40
*** Marga_ has quit IRC16:40
mriedemdansmith: https://review.openstack.org/#/c/248211/ is bottom now right?16:40
mriedemi haven't looked at that yet16:40
*** Marga_ has joined #openstack-nova16:41
dansmithmriedem: aye16:41
*** zhihaisong has quit IRC16:41
dansmithmriedem: alex_xu has ripped it to hell and back, so I think it's good :D16:41
openstackgerritBrianna Poulos proposed openstack/nova: Catch UnsupportedAlgorithm exceptions  https://review.openstack.org/26702116:42
mriedemthere is always more flesh that can be sullied16:42
dansmithI have no more to give16:42
*** mdrabe has quit IRC16:42
mriedemWRONG!16:42
dansmithheh16:42
nicmriedem: I am available if you have questions about https://review.openstack.org/20528216:42
*** lyanchih has joined #openstack-nova16:43
mriedemdansmith: btw, watch this if you haven't yet http://www.imdb.com/title/tt2582802/16:43
nicI think I squashed all of your concerns in the review as of yesterday16:43
mriedemnic: it's on the todo list16:43
sdaguemriedem: ok, so here is my issue https://review.openstack.org/#/c/265950/2/oslo_db/api.py is exactly the same functional change16:43
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: cleanup: Don't call import_opt for 'vcpu_pin_set'  https://review.openstack.org/26702216:43
nicmriedem: I know; just trying to help you plan your day  ;-)16:43
sdaguebut was masked because of the nesting16:43
sdagueand that behavior is kind of nuts16:43
dansmithmriedem: queueed16:44
pkoniszewskidansmith: but... there is one piece missing in your change anyway, you fixed the issue, but there's no test coverage to make sure that we won't fall into this again16:44
sdaguemriedem: right?16:44
pkoniszewskidansmith: from driver perspective it is needed because we do .get on all dicts so it might fail silently again16:44
dansmithpkoniszewski: after this patch everything will break if you treat the thing as a dict in the driver16:45
dansmithpkoniszewski: there is no .get() handler on the object16:45
mriedemsdague: let me look at this again with fresh eyes when i'm not doing 3 things at once,16:45
mriedemsdague: because yeah i agree this looks like i'm smoking crack (again)16:45
openstackgerritdane-fichter proposed openstack/nova: Add image signature verification  https://review.openstack.org/18984316:46
mriedemsdague: oh wait you uploaded PS216:46
sdaguemriedem: yes16:46
mriedemyeah then it is the same16:47
sdagueI reflowed the logic16:47
*** cdelatte has joined #openstack-nova16:47
*** ptm__ has joined #openstack-nova16:47
*** paul-carlton2 has quit IRC16:47
mriedemoh i see16:47
mriedemthat threw me16:47
*** gjayavelu has quit IRC16:47
*** gangil has quit IRC16:47
*** suro-patz has joined #openstack-nova16:48
sdagueI was finding it hard to explain why I thought the logic was weird, so I redid it to make it more clear why I thought it was weird16:48
*** whenry has joined #openstack-nova16:48
sdagueto the best of my understanding that's exactly the same resultant branch structure16:48
*** zhihais has quit IRC16:48
mriedemthere is a problem in your change16:49
sdagueectxt.reraise value is irrelevant for the exception block, because all db errors will be true for that16:49
*** bradjones has quit IRC16:49
mriedemit will re-introduce the original bug i was trying to fix16:49
mriedemwhich is don't trace on expected db errors16:49
*** ipbabble has quit IRC16:49
mriedemat least until the last iteration16:50
sdaguemriedem: it's the same logic as you had though16:50
sdaguemriedem: what do you mean until the last iteration?16:50
mriedemmine took ectxt.reraise into account16:50
pkoniszewskidansmith: got it, i will give it a shot with my patches on top of these changes16:50
pkoniszewskidansmith: thanks16:50
mriedemsdague: i commented in the review16:50
*** bradjones has joined #openstack-nova16:50
*** bradjones has quit IRC16:50
*** bradjones has joined #openstack-nova16:50
*** PaulMurray has quit IRC16:50
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Add functional tests launcher for py3 env  https://review.openstack.org/26689516:50
dansmithpkoniszewski: cool16:51
sdaguemriedem: oh, because there is a not16:51
mriedemyar16:51
*** zhihais has joined #openstack-nova16:51
mriedemso maybe we just remove the LOG.exception in the retry block16:51
mriedemb/c it will trace before reraising when it's run out of retries anyway16:51
*** rcernin has quit IRC16:51
sdagueok so16:51
sdagueself._is_exception_expected(e) is always true if e is a db.error16:52
sdagueper L17516:52
sdaguewhich means that if e is a db_error16:52
sdagueectxt is always false16:52
sdaguewhich means if ectxt.reraise and isinstance(e, self.db_error):16:52
sdagueis "if False and isinstance(e, self.db_error):"16:52
*** gszasz has quit IRC16:53
mriedemyeah, got that16:53
sdaguewhich means you should actually just delete that code16:53
sdaguebecause it will always evaluate to False16:53
mriedemwhich you do in ps216:53
mriedemi don't have a problem with that16:53
*** mtanino has quit IRC16:54
sdaguewhich means your change is actually https://review.openstack.org/#/c/265950/3/oslo_db/api.py16:55
sdagueright?16:55
mriedemi think so16:56
sdaguewhich, if that's your change, that's fine. But it should be that change, so it's clear.16:56
mriedemthe only thing with that is if e is like OverQuota from nova (not a db_error in this code), we don't log it here at all,16:57
mriedembut maybe that's ok16:57
*** ccarmack has left #openstack-nova16:57
sdaguemriedem: right, but you wouldn't in ps116:57
*** mgoddard_ has quit IRC16:57
*** mgoddard has joined #openstack-nova16:57
sdaguesorry, that was the crux of my -1. This seemed a really round about way to express what's happening.16:57
mriedemtrue16:57
mriedemwhich is also what my test was added for16:58
*** suro-patz has quit IRC16:58
mriedemok, let me clean up the commit message and then we'll be good i think16:59
mriedemand add you as co-author16:59
sdagueright, sure, though there was no test to make sure you got into that block in the first place16:59
mriedemyeah16:59
sdagueyeh, I'm ok with the result here, I just didn't like the indirection16:59
*** dustins has quit IRC16:59
mriedemi don't like when we fight sean :/16:59
*** atuvenie has joined #openstack-nova16:59
mriedemi like making up16:59
dansmith....17:00
openstackgerritLucas Alvares Gomes proposed openstack/nova: Ironic: Lightweight fetching of nodes  https://review.openstack.org/22184817:00
*** jlanoux has quit IRC17:00
mriedemi took it there17:00
mriedemdeal with it17:00
dansmithhah17:00
*** haomaiwang has quit IRC17:01
*** haomaiwang has joined #openstack-nova17:01
*** salv-orl_ has quit IRC17:03
*** lyanchih has quit IRC17:03
*** nkrinner has quit IRC17:03
*** salv-orlando has joined #openstack-nova17:03
*** gangil has joined #openstack-nova17:05
*** gangil has joined #openstack-nova17:05
*** nic has quit IRC17:06
*** drankis has joined #openstack-nova17:07
*** gjayavelu has joined #openstack-nova17:08
*** jistr has quit IRC17:08
scottdaDoes anyone know if the OpenStack Client has support for microversions/17:08
scottda?17:08
*** nic has joined #openstack-nova17:08
*** mdrabe has joined #openstack-nova17:09
*** _diana_1 has joined #openstack-nova17:09
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.firewall' options  https://review.openstack.org/25799517:10
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.netutils' options  https://review.openstack.org/25800917:10
openstackgerritStephen Finucane proposed openstack/nova: Improve 'virt.images' conf options documentation  https://review.openstack.org/25955317:10
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.imagecache' options  https://review.openstack.org/25898417:10
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.images' options  https://review.openstack.org/25800417:10
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.disk' options  https://review.openstack.org/25891217:10
openstackgerritStephen Finucane proposed openstack/nova: config options: Centralise 'virt.driver' options  https://review.openstack.org/25795617:10
openstackgerritStephen Finucane proposed openstack/nova: Improve 'virt.driver' conf options documentation  https://review.openstack.org/26636417:10
openstackgerritStephen Finucane proposed openstack/nova: Improve 'virt.firewall' conf options documentation  https://review.openstack.org/26636517:10
sdaguescottda: it does not17:10
*** annegentle has quit IRC17:10
*** sfinucan has quit IRC17:10
sdaguemriedem: do I need to send your flowers?17:11
scottdasdague: ok, thanks17:11
*** amotoki has quit IRC17:11
mriedemsdague: nah17:11
mriedemchances are they'd be poisonous to our cats who would eat them and then die17:11
mriedemand then you'd have to just send more flowers for the funeral17:11
mriedemnow, if there is a plant that is poisonous to 12 year old smelly noisy basset hounds, i'm on board with that17:12
*** apoorvad has joined #openstack-nova17:12
mriedemjust don't let jaypipes know17:12
jaypipeslol17:12
*** moshele has joined #openstack-nova17:13
*** gjayavelu has quit IRC17:13
*** pratikmallya has quit IRC17:13
*** pratikmallya has joined #openstack-nova17:13
sdagueheh17:14
sdagueok, someone that knows python3 more, what is the value of a change like this - https://review.openstack.org/#/c/264652/3 ?17:14
mriedemi'd ask haypo17:15
jrollsdague: so the difference is that it will use xrange on python 2, which returns a generator rather than a list17:16
sdaguebecause as far as I can tell the end result is the same for our uses17:16
jrollwhich is great for giant lists17:16
jrollbut looks like no value in this case17:16
sdagueright, for giant lists17:17
sdaguethat you aren't going to expand17:17
dansmithprobably why it says "to improve consistency" and not "to make any real difference"17:17
*** pratikmallya has quit IRC17:18
sdagueok, except I thought we were going to avoid six when we didn't really need to care about the differences17:18
dansmithnot disagreeing :)17:19
dansmithjust point out out that the author seems to agree it's pointless :)17:19
mriedemhaypo said the same, said it seems useless17:19
sdagueok, -217:19
cdentsdague++17:19
cdentthere seems to be a lot of this kind of thing going round lately17:19
*** _diana_1 is now known as diana_clarke17:19
*** sahid has quit IRC17:19
mriedemsee the rant thread on the ML17:20
*** paul-carlton2 has joined #openstack-nova17:20
sdaguewell, honestly, there is a lot in general17:20
hemnahey17:20
sdagueI though the rant was about fixing gramar issues17:20
sdaguewhich I'm actually fine with17:20
*** mragupat has quit IRC17:20
hemna-2 missing .!!!17:20
hemna:P17:20
ctrathalaski: is there a known limit on the number of cells in a single cloud?17:20
mriedemthe rant was about if len(x) > 0 vs if x17:20
*** mragupat has joined #openstack-nova17:20
mriedemsomeone opened a bug and targeted it against like 20 projects17:21
mriedemand started pushing global change patches on them17:21
alaskictrath: v1?17:21
ctrathalaski: sure, given that v2 would only be theoretical at this point17:21
mriedemcells v1 would be limited by rabbitmq talking between parent and child cells wouldn't it?17:22
*** thumpba has quit IRC17:22
mriedemwhich is kind of the same problem that cells in general is trying to solve17:22
alaskictrath: there's no known limit, but I'm not sure anyone has gotten past tens of cells17:22
diana_clarkeSpeaking of trying to be useful, but perhaps just being a nuisance...17:22
*** thumpba has joined #openstack-nova17:22
diana_clarkeI'm on maternity leave, but I'd still like to contribute when baby lets me. I have a couple of stubs.Set -> stub_out patches up for review. I figure I could try to remove the dependency on mox during my leave, unless these patches are more of nuisance for the core reviewers than help. Is there a sub-team for this, or anyone I should be coordinating with? Anything else I should know on this front? Thanks!17:22
mriedemctrath: ask the cern guys17:22
*** mragupat_ has joined #openstack-nova17:23
mriedemdiana_clarke: there isn't a sub-team, just random people pushing random fixes for the same thing17:23
ctrathmriedem: ok.. do they hang out on a specific channel?17:23
mriedemctrath: #openstack-operators17:23
ctraththx17:23
mriedemctrath: at some point i'm going to sound like a broken record17:23
openstackgerritAlexis Lee proposed openstack/nova: Catch errors while creating veth pair  https://review.openstack.org/26414617:24
*** krtaylor has quit IRC17:25
sdaguediana_clarke: there is a blueprint for it17:25
sdagueso if the commit message matches that, they are easy to process17:26
mriedemgerrit should also tell you if your change is conflicting with someone elses17:26
*** krtaylor has joined #openstack-nova17:26
sdaguehttps://review.openstack.org/#/q/message:%22bp:remove-mox%2217:26
mriedemdiana_clarke: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/remove-mox17:26
*** mragupat has quit IRC17:26
sdagueI'll try to stay on top of +2ing these17:26
sdaguediana_clarke: also, congrats!17:26
diana_clarkesdague: thanks!17:27
*** cdent has quit IRC17:27
mdboothmriedem: It failed again :) Different test, though. Ah, well, maybe tomorrow's the lucky day. Recheck when it times out.17:27
*** ccarmack has joined #openstack-nova17:27
mriedemmdbooth: i'll be babysitting those b/c they are hodling up teh 12.0.1 release17:28
mriedemso don't worry about it17:28
mdboothmriedem: Thanks!17:28
*** markus_z has quit IRC17:28
mriedemyou can pay me in english candy when we're in bristol17:28
dansmithtojuvone: around?17:28
mdboothhehe17:28
sdaguediana_clarke: looked at and +2ed your 2 patches here17:29
tojuvonedansmith: Yes, here17:30
*** xyang1 has quit IRC17:31
dansmithtojuvone: how mad are you going to be at me if I ask you to split up your patch?17:31
*** tiagogomes_ has joined #openstack-nova17:31
mriedemi'm not sure if anyone knew this, but der kommissar is in town17:31
dansmithtojuvone: touching api versions, db api, objects, etc all in one patch is pretty thick17:31
nicmriedem: don't turn around, then17:31
tiagogomes_Hello, does nova already support multi-attach for volumes? If no, will Mitaka support it?17:31
dansmithlol17:32
rlrossitdansmith: grep -r "fixed.*\[.*\]" nova/ | more, add a liberal portion of patience, bake at 350 for about 30 minutes, and https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ips.py#L47-L54 pops out17:32
*** mtanino has joined #openstack-nova17:32
tojuvonedansmith: ok, sure there is not much time left, but can do.17:32
rlrossitthat's why my exception was getting eaten by n-api17:32
dansmithtojuvone: what if I do it for you/17:32
*** fesp has joined #openstack-nova17:32
dansmithrlrossit: hah17:32
rlrossitDictCompat: not even once17:33
dansmithjaypipes: thoughts on that?17:33
tojuvonedansmith: Thanks, that would be good :)17:33
*** annegentle has joined #openstack-nova17:33
*** xyang1 has joined #openstack-nova17:33
tojuvonedansmith: then there was also that formal spec change17:34
dansmithtojuvone: yeah, that's not so pressing17:34
diana_clarkesdague: Thanks a ton! I'll try to keep them coming & remove the dependency before I return to work.17:34
mriedemtiagogomes_: there is a series under review17:34
*** fesp has quit IRC17:34
mriedemtiagogomes_: https://review.openstack.org/#/q/topic:bp/volume-multi-attach17:34
mriedemtiagogomes_: there are some issues17:34
sdaguediana_clarke: thanks much17:34
tojuvonedansmith: yes17:34
jaypipesdansmith: thoughts on what precisely?17:35
dansmithjaypipes: splitting tojuvone's patch into the api bits and the db/objects bits17:35
dansmithjaypipes: i think it will be pretty easy, I'm going to take a crack at it17:35
jaypipesdansmith: oh... yeah, cool by me.17:36
tojuvonedansmith, jaypipes: and if still some comments, I'll work them by tomorrow17:38
*** MVenesio has quit IRC17:38
dansmithtojuvone: I think jaypipes' comments were addressed, and I was just trying to wrap my head around the whole thing which made me think it needs splitting17:38
ndipanovjaypipes, you may like this https://review.openstack.org/#/c/262939/17:38
dansmithtojuvone: after I split this I'll hopefully review and +2 the objects bits17:39
tojuvonedansmith: yes, I think so too17:39
openstackgerritRyan Rossiter proposed openstack/nova: Remove DictCompat from FixedIP  https://review.openstack.org/26595117:39
dansmithtojuvone: so, I was able to split the patch without touching code.. that's a real good indication that it needed to be split :D17:40
jaypipesndipanov: thx for the heads up. added to my queue.17:40
mriedemmdbooth: want to drop your -1 on this? https://review.openstack.org/#/c/264817/17:41
mdboothmriedem: Sure. I'm assuming that my assumption about the changing commit id is incorrect?17:41
tojuvonedansmith: Great :) Btw is the 21st also deadline for novaclient as it needs nova side to land first (and other microversions)17:41
mdboothi.e. it'll literally be a git merge, and therefore preserve it.17:41
mriedemmdbooth: it is17:42
openstackgerritDan Smith proposed openstack/nova: Add host_status attribute for servers/detail and servers/{server_id}  https://review.openstack.org/24156217:42
openstackgerritDan Smith proposed openstack/nova: Add object and database support for host_status API  https://review.openstack.org/26706217:42
mdboothmriedem: Cool, that was the only thing.17:42
dansmithtojuvone: ^17:42
mriedemtojuvone: novaclient is more or less on it's own release schedule17:42
openstackgerritRyan Rossiter proposed openstack/nova: Add helper shim for getting items  https://review.openstack.org/26599517:43
mdboothmriedem: Done.17:43
openstackgerritRyan Rossiter proposed openstack/nova: Remove DictCompat from ComputeNode  https://review.openstack.org/26552117:43
*** rmart04 has joined #openstack-nova17:43
tojuvonemriedem: I thought so, thanks17:43
*** Sukhdev has quit IRC17:47
*** suro-patz has joined #openstack-nova17:47
*** unicell has quit IRC17:47
dansmithtojuvone: a couple things on the first patch. I can do them for you  but then I kinda lose the ability to +2 it ...17:48
*** paul-carlton2 has quit IRC17:50
*** shyama has joined #openstack-nova17:50
*** paul-carlton2 has joined #openstack-nova17:51
*** sudipto has quit IRC17:52
openstackgerritPawel Koniszewski proposed openstack/nova: Allow block live migration of an instance with attached volumes  https://review.openstack.org/22727817:53
*** moshele has quit IRC17:54
tojuvonedansmith: Well if I can work out by the comments, let's see.17:55
*** rmart04 has left #openstack-nova17:56
openstackgerritRussell Bryant proposed openstack/os-vif: Import of code from https://github.com/jaypipes/os_vif  https://review.openstack.org/26637717:56
*** raildo is now known as raildo-afk17:57
*** cdent has joined #openstack-nova17:58
openstackgerritAndrea Rosa proposed openstack/nova: Adding volume operations for shelved instances  https://review.openstack.org/25952817:58
dansmithtojuvone: here is an example of the compat thing from another object: https://github.com/openstack/nova/blob/master/nova/objects/service.py#L135-L13617:58
*** gangil has quit IRC17:59
*** gangil has joined #openstack-nova17:59
*** gangil has joined #openstack-nova17:59
*** haomaiwang has quit IRC18:01
*** carey has joined #openstack-nova18:01
*** derekh has quit IRC18:01
*** haomaiwang has joined #openstack-nova18:01
tojuvonedansmith: thanks, have to take a look.18:01
dansmithtojuvone: actually, if you'll do the obj_make_compatible change, I'll do the test18:02
dansmithtojuvone: probably not too bad for me to +2 when I just wrote a test :018:02
mriedemmdbooth: well we figured out why n-net isn't starting on stable..18:03
tojuvonedansmith: Cool!18:03
mriedemhttps://bugs.launchpad.net/devstack/+bug/153377718:03
openstackLaunchpad bug 1533777 in devstack "n-net doesn't start in gate-tempest-dsvm-large-ops job on stable/liberty but devstack doesn't fail" [Undecided,New]18:03
*** e0ne has quit IRC18:04
*** ptm__ has quit IRC18:04
*** carey has quit IRC18:05
*** raildo-afk is now known as raildo18:06
openstackgerritAnand Shanmugam proposed openstack/nova: Handle Instance Exceptions in add_fixed_ip and remove_fixed_ip  https://review.openstack.org/26667518:08
*** svenno has quit IRC18:08
*** boris-42 has quit IRC18:08
*** erlon has quit IRC18:08
*** jed56 has quit IRC18:08
*** yonglihe has quit IRC18:08
*** wanghao has quit IRC18:08
*** kgalanov has quit IRC18:08
*** junjie has quit IRC18:08
*** briancurtin has quit IRC18:08
*** dougwig has quit IRC18:08
*** zhenguo has quit IRC18:08
*** auggy has quit IRC18:08
*** carl_baldwin has quit IRC18:08
*** patrickeast has quit IRC18:08
*** sballe has quit IRC18:08
*** ramishra_ has quit IRC18:08
*** tpeoples has quit IRC18:08
*** ameade has quit IRC18:08
*** fmccrthy has quit IRC18:08
*** DuncanT has quit IRC18:08
*** serverascode has quit IRC18:08
*** betherly has quit IRC18:08
*** zhiyan has quit IRC18:08
*** scottda has quit IRC18:08
*** andrewbogott has quit IRC18:08
*** angular_mike__ has quit IRC18:08
dansmithheh18:08
dansmithguess we know who all is using irccloud18:08
openstackgerritArtom Lifshitz proposed openstack/nova: Add tag column to vifs and bdm  https://review.openstack.org/26401418:10
openstackgerritArtom Lifshitz proposed openstack/nova: Add metadata objects for device tagging  https://review.openstack.org/26401518:10
openstackgerritArtom Lifshitz proposed openstack/nova: Device tagging user visible changes  https://review.openstack.org/26401818:10
openstackgerritArtom Lifshitz proposed openstack/nova: Add compute manager device tagging support  https://review.openstack.org/26401718:10
ildikovdansmith: :)18:10
openstackgerritArtom Lifshitz proposed openstack/nova: vNIC tagging: libvirt driver implementation  https://review.openstack.org/26401618:10
*** tonytan4ever has joined #openstack-nova18:10
*** Marga_ has quit IRC18:11
*** gcb has quit IRC18:11
*** gcb has joined #openstack-nova18:12
*** lpetrut has quit IRC18:12
mgagnepkoniszewski I'm working on making live migration work again on our side and we found QEMU 2.0 to be broken in some way. Can you help? the destination target is getting fully provisioned instead of thin provisioned.18:12
*** zhihais has quit IRC18:12
*** zhihais has joined #openstack-nova18:13
*** serverascode has joined #openstack-nova18:14
openstackgerritTracy Jones proposed openstack/nova: Stop using mox stubs in test_configdrive  https://review.openstack.org/26547618:14
*** tjones has joined #openstack-nova18:14
*** DuncanT has joined #openstack-nova18:14
*** scottda has joined #openstack-nova18:14
tjonesmriedem: https://review.openstack.org/#/c/265476/ i've addressed your comments.  i have another patch that i am working on for set_stubs if that is ok18:15
ildikovdansmith: johnthetubaguy: mriedem: can we continue the multiattach chat to figure out a kind of roadmap and a way to get most of the code in?18:15
*** rmart04 has joined #openstack-nova18:16
mriedemildikov: so we were talking earlier about putting a compute service check in volume_api.check_attach such that if we were going to attach a multiattach volume,18:17
mriedemwe wouldn't do it if there were any liberty computes18:17
*** unicell has joined #openstack-nova18:17
mriedem*attach a multiattach volume that is already attached to 1 instance18:18
ildikovmriedem: are we good if that's done?18:18
sdaguemriedem: ok, so right now Nova is using 27 test nodes for every change18:18
mriedemthe concern was around locking in case you get 2 concurrent attach requests on the same volume but different instanes18:18
*** andrewbogott has joined #openstack-nova18:18
sdague5 of which are because of the duplicate constraints / non-constraints jobs18:18
ildikovmriedem: my experimental flag idea was for the same purpose only let the user turn multiattach on18:18
*** ramishra_ has joined #openstack-nova18:18
*** svenno has joined #openstack-nova18:19
ildikovmriedem: but that should be an issue in normal case too I would assume18:19
mriedemildikov: the compute service checking is at least a bit more dynamic, i.e. once all of your computes are at mitaka then it would be enabled18:19
*** rmart04 has quit IRC18:20
mriedembut the potential issue is any kind of race18:20
ildikovI mean you need to check the volume in either case, if the service check is false, then you check a different status on the volume, but the check is still there18:20
mriedemwhat happens if 2 concurrent requests come into cinder to reserve the same volume?18:20
*** SourabhP has joined #openstack-nova18:20
ildikovmriedem: but is this extra race?18:20
mriedemthe reserve call changes the volume status to 'attaching'18:20
dansmithildikov: we try not to have experimental features behind flags like that18:20
*** carl_baldwin has joined #openstack-nova18:21
*** ameade has joined #openstack-nova18:21
ildikovdansmith: if we can figure out without that I'm supportive on that18:21
*** sballe has joined #openstack-nova18:21
*** dustins has joined #openstack-nova18:21
dansmithwell, we know how to do it without that18:21
dansmithbut it means N :/18:21
mriedemunless the compute version filtering could work right?18:21
*** erlon has joined #openstack-nova18:22
ildikovmriedem: if you check it here: https://review.openstack.org/#/c/193135/78/nova/virt/block_device.py multiattach is allowed if the volume is 'attached'18:22
ildikovmriedem: so attaching is still not ok18:22
*** yonglihe has joined #openstack-nova18:22
ildikovdansmith: I don't think we need a new function in the BDM object18:22
*** wanghao has joined #openstack-nova18:23
mriedemmy system is apparently garbage collecting on itself atm....18:23
*** betherly has joined #openstack-nova18:23
ildikovalthough I know we need to ensure that we don't have multiple BDMs per instance until we have a mixed env18:23
*** patrickeast has joined #openstack-nova18:23
mriedemuntil we *dont* have a mixed env18:23
ildikovdansmith: what about the compute version check?18:23
*** zhiyan has joined #openstack-nova18:24
ildikovmriedem: yes, sorry, so I meant that we need a full upgraded env with new computes to get it enabled18:24
*** tpeoples has joined #openstack-nova18:24
dansmithildikov: well, that'd be the only way, but it also means gating an api feature dynamically, which is potentially confusing, as well as hard to get right18:24
*** Jeffrey4l has quit IRC18:25
*** ericksonsantos has quit IRC18:25
ildikovdansmith: do you mean the tempest tests?18:25
mriedemno18:25
*** dougwig has joined #openstack-nova18:25
*** briancurtin has joined #openstack-nova18:25
dansmithno, I mean getting the api to actually behave properly, without races, and without surprising-to-the-client behavior18:26
*** patrickeast_ has joined #openstack-nova18:26
*** patrickeast_ has quit IRC18:26
ildikovok, sorry you wrote 'gating' so I got confused18:26
mriedemfeature toggling18:26
dansmithyeah, ^ better word18:27
dansmiths18:27
ildikova config option can solve this if the dynamical aspect is an issue18:27
ildikovwe can have the service check oadditionally18:27
ildikovso if someone turns it on, but the env is still not good then it will not work18:28
dansmithno18:28
*** ociuhandu has quit IRC18:28
*** paul-carlton2 has quit IRC18:28
dansmithit means we're toggling the api-visible feature via config instead of dynamically, which isn't really better18:28
*** auggy has joined #openstack-nova18:29
*** junjie has joined #openstack-nova18:29
mriedemi guess from a client perspective you'd get a 400 back on the 2nd attach call to the same volume18:29
mriedemwhich is the same18:29
*** jed56 has joined #openstack-nova18:29
*** SourabhP has quit IRC18:30
*** dims_ has quit IRC18:30
ildikovyeah, the config would be false by default so it should not be different behaviour by default18:30
*** mgagne has quit IRC18:30
dansmithdefault is not the concern18:30
*** rcernin has joined #openstack-nova18:30
openstackgerritRafael Folco proposed openstack/nova: libvirt: check min required qemu/kvm versions on ppc64/ppc64le  https://review.openstack.org/22655518:30
*** diana_clarke has quit IRC18:31
*** mgagne has joined #openstack-nova18:31
openstackgerritVladik Romanovsky proposed openstack/nova: neutron: pci_request logic considers 'direct-physical' vnic type  https://review.openstack.org/26258418:31
openstackgerritVladik Romanovsky proposed openstack/nova: pci: Add utility method for getting the MAC addr  https://review.openstack.org/26258518:31
mriedemildikov: also, https://review.openstack.org/#/c/193135/78/nova/virt/block_device.py isn't a good place really to break things18:31
openstackgerritVladik Romanovsky proposed openstack/nova: neutron: Update the port with a MAC address for PFs  https://review.openstack.org/26258618:31
*** kgalanov has joined #openstack-nova18:31
openstackgerritVladik Romanovsky proposed openstack/nova: pci: changing the claiming and allocation logic for PF/VF assignment  https://review.openstack.org/24901818:31
openstackgerritVladik Romanovsky proposed openstack/nova: pci: adding support to specify a device_type in pci requests  https://review.openstack.org/25925418:31
*** mgagne is now known as Guest8280318:31
openstackgerritVladik Romanovsky proposed openstack/nova: Add a vnic type for PF passthrough and a new libvirt vif driver  https://review.openstack.org/26258318:31
mriedemildikov: b/c by the time you get to https://review.openstack.org/#/c/193135/78/nova/virt/block_device.py the request has already cast off to the compute and the response was a 20218:31
mriedemildikov: i was really talking about doing the validation in volume_api.check_attach18:31
*** dims has joined #openstack-nova18:32
*** fmccrthy has joined #openstack-nova18:32
*** Guest82803 is now known as mgagne18:32
ildikovmriedem: if that's called higher than compute it's good, I just saw that there's a check_attach call in block_device18:33
*** mgagne has quit IRC18:33
*** mgagne has joined #openstack-nova18:33
ildikovI mean the file you linked18:33
mriedemif do_check_attach is true18:33
*** otter768 has joined #openstack-nova18:33
mriedemwhich the compute manager passes false18:33
mriedemsec18:33
mriedemhere https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L467518:34
*** _diana_1 has joined #openstack-nova18:34
mriedemit passes do_check_attach=False from the compute manager b/c it assumes we've already done that in the compute api18:34
mriedemhere https://github.com/openstack/nova/blob/master/nova/compute/api.py#L298818:34
ildikovoh, that's perfect, we have the volume info18:35
mriedemso volume_api.check_attach is really where you'd need to check (1) is the volume multiattach and (2) is it already attached to something and (3) are there any liberty computes, and if so, fail the request18:35
mriedemwhich gives back the 400 to the client18:35
ildikovI mean we have everything there we need and the API has to be upgraded first18:35
*** yamahata has quit IRC18:35
dansmithokay, so another wrinkle here18:35
dansmithlets say you start up 32 API workers,18:36
ildikovshoot18:36
dansmithwhile you still have some liberty computes18:36
*** zhenguo has joined #openstack-nova18:36
*** atuvenie has quit IRC18:36
dansmithyou do one attach, which works because liberty is present, and caches that service version18:36
hemnaI'm back18:37
hemnasorry, been a crazy morning.18:37
dansmiththen you do another, which fails because liberty and no multiattach allowed18:37
dansmiththen you upgrade your last liberty,18:37
dansmithdo an attach, that succeeds18:37
dansmiththen you do another attach, which goes to an older api worker, which still thinks liberty is around, and it fails18:37
dansmiththen another, hits a new worker, succeeds18:37
mriedemb/c the compute version is cached18:37
*** otter768 has quit IRC18:38
dansmithmriedem: and because we _can't_ always check it from the db on every api request18:38
ildikovbut I assume the cahce is refreshed time to time18:38
dansmithyes, ops should kill off all their api workers when they upgrade their last liberty node, but..18:38
dansmithildikov: it's not, but that would make it worse18:38
ildikovand it's still the better use case18:38
*** e0ne has joined #openstack-nova18:38
*** aginwala has joined #openstack-nova18:38
*** angular_mike__ has joined #openstack-nova18:38
dansmithildikov: because as some of them refresh and not others, you get very inconsistent behavior within the caching interval (if there was one, which there is not)18:39
*** raildo is now known as raildo-afk18:39
*** gjayavelu has joined #openstack-nova18:39
ildikovso it's still better to not allow it when you can use than the opposite case18:39
ildikovdansmith: so the cache is populated once at start time?18:39
mriedemhypothetically speaking, once your first api worker finds that the min version has changed, couldn't it set a flag that the other workers could check and then refresh themselves?18:39
dansmithtojuvone: one more super nit on the first patch if you can include that when you resubmit.. literally one character change :)18:40
dansmithmriedem: set a flag where?18:40
mriedemand when to unset it18:40
dansmithmriedem: if we query the db every time to check a flag, we might as well check the actual version. the point is it's just extra db traffic on every request18:40
mriedemright, it couldn't be in the db18:40
*** jaypipes has quit IRC18:41
tojuvonedansmith: ok18:41
dansmithyeah, so thinking about this more, using service version to enable api visible features is kinda scary18:41
dansmithand really not what it was intended for18:41
ildikovbut restarting the workers is a recommendation, right?18:42
mriedemhow do we cache the service version today?18:42
dansmithildikov: there's no real need to restart them today, certainly not an urgent one like this would be18:42
dansmithmriedem: how? it's somewhat of a singleton like behavior.. if we've ever fetched it, we return that version instead of making the call18:42
mriedemdansmith: going back to your scenario, when you said, "then you upgrade your last liberty, do an attach, that succeeds" - if the compute version is cached, how would that succeed? or is it the first time that api worker checks the version?18:43
*** ig0r_ has joined #openstack-nova18:43
ildikovdansmith: in your scenario how the first multiattach succeeds, when you cached the old version?18:43
*** tonytan4ever has quit IRC18:43
ildikovmriedem: just asked the same question :) ^18:43
dansmithmriedem: it would only succeed after the last liberty was removed if that api worker hadn't cached it yet (either ever, or because it was just recycled)18:43
mriedemrihgt18:44
mriedem*right18:44
mriedemso in-memory cache per worker18:44
dansmithyes18:44
dansmiththis is literally two days old18:44
*** jaypipes has joined #openstack-nova18:44
dansmithtwo days ago, this would have been a hit for every check and not even a consideration18:44
dansmithmriedem: anyway, sure seems like we're getting to the point of forcing this peg into the hole18:45
mriedemwell, i was thinking about a more centralized cache that isn't the actual db18:45
mriedemand the api workers go there18:45
mriedembut still, how do you reset the cache18:45
dansmithwell, if we had that then we could easily do something to manually invalidate18:46
dansmithbut that's infrastructure we don't have today, AFAIK18:46
mriedemnova-manage to the rescue :)18:46
ildikovdansmith: but then it's inconsistent now too, I  mean reflecting to your comment about refreshing the cache18:46
dansmithwe also tried to think of how this would work with zk, remember and it wasn't straightforward18:46
dansmithso yes, in theory and in the future we should do that thing18:46
mriedemyeah, i was thinking about something like zk18:47
*** _diana_1 is now known as diana_clarke18:47
dansmithildikov: yeah, remember this service version is used/intended for internal stuff, not to be visible like this, which is why these issues are popping up now18:47
ildikovbut still the scenario for upgrade is to restart the workers IIUC18:47
dansmithildikov: yes, but it doesn't give inconsistent api behavior if you don't, while you're doing it, etc18:48
ildikovso if because of not doing it you don't have the latest operations working that's kind of according to the scenario18:48
*** anish has quit IRC18:49
ildikovand it's the best version of a corner case, I mean getting the full support later, but actually not ruining anything18:49
dansmithI don't think I understood any of that18:50
ildikov*not* getting18:50
ildikovso if the cache for the workers is messed up then the worst case is that some of the valid multiattach calls will fail because of missing a required step for the upgrade18:51
openstackgerritSean Dague proposed openstack/nova: update min tox version to 2.0  https://review.openstack.org/26709518:51
openstackgerritSean Dague proposed openstack/nova: always use pip constraints  https://review.openstack.org/26709618:51
openstackgerritSean Dague proposed openstack/nova: reduce pep8 requirements to just hacking  https://review.openstack.org/26709718:51
dansmithildikov: yes, agreed with that18:51
*** READ10 has quit IRC18:51
dansmithildikov: I just don't think that's a good thing to knowingly do18:51
ildikovdansmith: but you will no end up with messed up BDMs18:51
sdaguemriedem: so, that's the alternative route on the testing that you and danpb suggested yesterday18:51
mriedemsdague: sorry, haven't gotten back to that yet18:52
mriedemwas looking at oslo.cache18:52
sdaguemriedem: yeh, no prob18:52
sdaguehttps://review.openstack.org/267095 is needed regardless, our tox min version is wrong18:52
ildikovdansmith: I'm not saying it's ideal, but I still wonder how often this would happen18:52
*** aginwala has quit IRC18:52
sdaguewe should pick one of https://review.openstack.org/267096 or the project-config change18:52
mriedemseems rather than in-memory caches per api worker for the service versions, we should using something like oslo.cache which just wraps dogpile.cache,18:52
mriedemwhich allows expiring the cached entries18:53
mriedemand it looks like a generator function for when the value needs to be refreshed, which would be our db lookup call on the version18:53
ildikovdansmith: considering the fact that only a very few Cinder drivers support multiattach, which means that for all drivers it's not supported you will have multiattach=false in the volume info18:53
mriedemildikov: i don't think that matters,18:53
mriedemlvm supports it, and is the reference implementation i ncinder18:53
danpbsdague: that does look nicer to me18:54
danpbbtw, what's the functional difference between the -constraints and old style tests ?18:54
*** daemontool has quit IRC18:54
hemnacorrect, not all cinder drivers even enable it18:54
*** daemontool has joined #openstack-nova18:54
hemnamostly because we haven't had a full end to end (cinder + nova) ability to test it all.18:55
sdaguedanpb: constraints uses the upper-constraints.txt from upstream git repo18:55
sdagueto install exact versions of all dependencies18:55
dansmithmriedem: well, other uses of the version don't depend on multiple workers like this knowing the same value,18:55
dansmithmriedem: so if we are going to use this for this feature and future ones, then sure18:55
mriedemdansmith: just thinking out loud,18:56
mriedemsince it seems like this could be useful18:56
dansmithmriedem: the current caching is in the service object itself and is usable by all the services, most of which wouldn't participate in that cache cluster18:56
mriedemi agree it's getting late in mitaka to be thiking about this18:56
dansmithyeah18:56
sdaguedanpb: https://github.com/openstack/nova/blob/1005478e03b7da8cedc163ea4de5ffa5b4d6dbac/tox.ini#L1218:56
*** andrewbogott has quit IRC18:56
*** andrewbogott has joined #openstack-nova18:56
mriedemi'm sure the yahoo! team would love to add fancy caching tools to nova18:56
ildikov:)18:56
*** tonytan4ever has joined #openstack-nova18:57
* dansmith runs18:57
*** aginwala has joined #openstack-nova18:57
*** nic1 has joined #openstack-nova18:58
*** lpetrut has joined #openstack-nova18:58
mriedemsdague: is passenv the thing we need from tox 2.0?18:58
danpbsdague: does that mean the local   test-requirements.txt  is no longer needed or is it still involved ?18:58
sdaguedanpb: it's needed, but exact versions come from upper-constraints.txt18:58
sdaguethat's basically preresolved a set of versions that are coinstallable18:59
ildikovdansmith: you can run, if you give your blessing to the service version check approach :)18:59
sdagueand that pass some set of tests upstream18:59
mriedemsdague: +2 since we use passenv18:59
* dansmith looks over his shoulder at ildikov and keeps running18:59
dansmith:)18:59
*** nic has quit IRC18:59
danpbsdague: ah, i see what you mean18:59
sdaguemriedem: yeh, I don't know exactly why the other thing breaks. I know it does on 1.9.2 but not on 2.019:00
mriedemso the version check approach doens't work b/c of the stale api worker issue dan pointed out19:00
ildikovdansmith: hemna just asked me yesterday whether I became a vampire :)19:00
dansmithildikov: heh19:00
ildikovdansmith: so be careful ;)19:00
hemnahehe19:00
* ildikov finished joking :)19:00
mriedemno one is actually scared of these kinds of vampires http://cdn02.cdn.justjared.com/wp-content/uploads/headlines/2012/12/twilight-breaking-dawn-tops-box-office-killing-them-softly-comes-up-short.jpg19:00
*** haomaiwang has quit IRC19:01
*** yamahata has joined #openstack-nova19:01
mriedemi get it, you're a sensitive teenage virgin boy19:01
mriedemmove on19:01
*** 5EXAAP39W has joined #openstack-nova19:01
*** mgoddard_ has joined #openstack-nova19:01
ildikovmriedem: believe me, if I ever turn into a vammpire, I will not be a toy-like one as those... :)19:01
dansmithhow do the get her hair to stay like that for the picture?19:01
dansmiths/the/they/19:01
mriedemfan19:01
mriedemindustrial fan19:01
*** ericksonsantos has joined #openstack-nova19:01
dansmithheh19:02
*** mriedem is now known as mriedem_meeting19:02
sdaguemriedem_meeting: commented back on https://review.openstack.org/#/c/26709519:02
*** nic1 has quit IRC19:02
ildikovdansmith: wig, CGI or I don't want to know...19:02
dansmithheh19:02
openstackgerritAndrey Kurilin proposed openstack/nova-specs: Update novaclient-api-microversions spec  https://review.openstack.org/21120619:02
ildikovdansmith: how big this wrinkle is with the workers?19:03
*** raildo-afk is now known as raildo19:03
dansmithildikov: [11:00:04]  <mriedem>so the version check approach doens't work b/c of the stale api worker issue dan pointed out19:03
*** dave-mcc_ has quit IRC19:04
dansmithildikov: I'm just one person, but I have a hard time feeling like it's a good idea at this point19:04
*** vilobhmm11 has joined #openstack-nova19:04
*** danpb has quit IRC19:04
ildikovdansmith: ok, missed that19:04
*** mgoddard has quit IRC19:04
*** jaosorior has quit IRC19:05
ildikovdansmith: I still feel that among any issues that can happen, this scenario is the smallest issue, also can happen if the upgrade did not happen properly19:05
*** nic has joined #openstack-nova19:05
*** Marga_ has joined #openstack-nova19:05
*** jaosorior has joined #openstack-nova19:05
*** shyama has quit IRC19:07
*** vilobhmm11 has quit IRC19:07
ildikovdansmith: I still think the config option is also a possibility, I know you don't like it19:08
*** vilobhmm11 has joined #openstack-nova19:08
*** vilobhmm11 has quit IRC19:08
dansmithyeah, I don't :/19:08
*** vilobhmm11 has joined #openstack-nova19:08
*** dedery_ has joined #openstack-nova19:08
ildikovdansmith: that would give us the upgrade path or any options like this19:09
*** ccarmack has quit IRC19:09
dansmithildikov: well, TBH, I think disabling behavior the api claims to support based on config is something we've clearly said we're not going to do any more19:10
ildikovI mean these options would19:10
dansmithildikov: so if you think that's the right path forward, you'll need to convince more than just me19:10
ildikovI'm just looking for a possibility here19:11
ildikovI would like to see as much of the code in as possible, obviously preferably all19:12
*** dedery has quit IRC19:12
*** dedery_ has quit IRC19:13
*** vivekd has joined #openstack-nova19:13
ildikovdansmith: what do you see as a way forward here?19:13
dansmithildikov: I really think you're better served by trying to convince other people, but:19:14
dansmith1. Merge code in mitaka to tolerate multiple attachments safely19:14
dansmith2. Merge api code to enable it for nova users in N19:14
*** kfarr has quit IRC19:15
ildikovby api code I guess you mean the check_attach and compute changes19:15
dansmithyes, for check_attach, not sure about the compute bits19:15
dansmithI'd have to go back and look19:16
dansmithbut basically, anything that lets the user actually do a multiattach is under #219:16
*** jichen has joined #openstack-nova19:16
ildikovthat's check_attach and one more call in block_device.py if the request would get through check_attach somehow19:17
*** atuvenie has joined #openstack-nova19:17
ildikovbut teorethically it should not19:17
ildikovI can move the addition of the instance_uuid to the get_by_volume_id() calls and then the first patch can be merged regardles of the final verdict19:18
*** smatzek has quit IRC19:19
dansmiththat seems like a good move regardless19:19
*** smatzek has joined #openstack-nova19:19
dansmithI'm still not sure about the internal consistency of the object method change returning something surprising19:19
ildikovI still don't see how a new function in the object would help here neither the changes in the db function19:19
ildikovdansmith: it will not19:20
dansmithfeels like you need to convert all uses of that method to a new one that requires instance_uuid in order to set the stage for consuming this right?19:20
ildikovthe get_by_volume_id function already has instance_uuid as a param19:20
dansmithildikov: well, four nova cores feel like it will19:20
dansmithildikov: if you convert all callers of that object method to pass the instance uuid then you're covered19:21
dansmithor create a new one just for cleanliness19:21
ildikovwithout multiattach enabled, if you add the instance_uuid to the call, you will either get back the right BDM or nothing19:21
ildikovif you don't have instance_uuid it will return what it returns today a we're still talking about non-multiattach case19:22
ildikovdansmith: the volume_snapshot_create retrieves the instance_uuid from the BDM, this is why it is disabled for multiattach volumes in my second patch19:22
*** ccarmack has joined #openstack-nova19:23
ildikovall the other calls can be updated, the information is there it just wasn't passed19:23
dansmithildikov: to be honest, I'm getting rather frustrated with this conversation and I really need to get on to working on some other things19:24
ildikovand even with multiattach enabled the volume_snapshot is disabled in compute_api, so it is safe from upgrade perspective as the API should go first19:24
ildikovdansmith: ok, got it19:25
dansmiththere are three other people involved in looking at this, so it'd be good to let one of them take over for a while19:25
dansmithsorry, no offense19:25
ildikovnone taken19:25
*** kfarr has joined #openstack-nova19:25
*** ccarmack has quit IRC19:27
*** Sukhdev has joined #openstack-nova19:27
*** artom has quit IRC19:30
*** unicell1 has joined #openstack-nova19:30
*** fawadkhaliq has quit IRC19:30
*** ccarmack has joined #openstack-nova19:30
*** rdopiera has quit IRC19:32
*** unicell has quit IRC19:33
*** dave-mccowan has joined #openstack-nova19:33
openstackgerritUkesh Kumar proposed openstack/python-novaclient: make the ERRORs consistent with each others  https://review.openstack.org/26712819:34
*** tjones has quit IRC19:34
*** tjones has joined #openstack-nova19:34
*** aginwala has quit IRC19:38
*** thangp has left #openstack-nova19:39
*** boris-42 has joined #openstack-nova19:40
*** ccarmack1 has joined #openstack-nova19:42
*** ccarmack1 has left #openstack-nova19:43
*** ccarmack has quit IRC19:44
*** ccarmack has joined #openstack-nova19:45
*** mriedem_meeting is now known as mriedem19:52
*** ctrath has quit IRC19:52
*** tjones has quit IRC19:54
*** mpavone has joined #openstack-nova19:55
tonybmdbooth, mriedem: it needs a rebase as it was based on ps1 of the previous review.  but ps2 was tagged +W so when it merged ps1 (that I rebaseed) would become unmergeable.  I was trying to streamline things so we didn't have that issue.19:57
*** davidlenwell has quit IRC19:57
*** cdent has quit IRC19:57
*** pratikmallya has joined #openstack-nova19:57
mriedemtonyb: ah19:57
mriedemso, who wants to talk about multiattach some more?!19:57
*** aginwala has joined #openstack-nova19:58
*** davidlenwell has joined #openstack-nova19:58
mriedemildikov: so one issue with this,19:58
mriedemthere is no microversion, so as a user, who do i ever know when the cloud i'm talking to supports multiattach?19:58
mriedembesides the attach call just failing with a 400?19:58
*** ctrath has joined #openstack-nova19:59
mriedemconsider you have a config option in check_attach to enable multiattach support19:59
*** mpavone has quit IRC19:59
mriedemthat is not advertised in the API in anyway19:59
mriedemso if i make a request to attach a multiattach volume to a 2nd instance, if that flag is False, i get a 400,19:59
ildikovsorry, here19:59
mriedemand if i'm talking to a liberty API (no multiattach code at all), i get a 40019:59
mriedemso as a client, i have no way of knowing at what versoin of the nova api multiattach actually is supported20:00
*** baoli_ has quit IRC20:00
*** lpetrut has quit IRC20:00
*** lpetrut has joined #openstack-nova20:00
mriedemit almost seems like at the end of the series, there should be a microversion in the rest api that checks if you're trying to attach a multiattach volume to a 2nd instance, but you're below the microversio nthat says that's ok to do, then it fails20:00
*** 5EXAAP39W has quit IRC20:01
openstackgerritTomi Juvonen proposed openstack/nova: Add object and database support for host_status API  https://review.openstack.org/26706220:01
mriedemjaypipes ^ weren't you working on something like that?20:01
*** whenry has quit IRC20:01
*** haomaiwang has joined #openstack-nova20:01
*** carey has joined #openstack-nova20:02
*** pratikma_ has joined #openstack-nova20:02
jaypipesmriedem: all I did was rebase a patch from an ericsson contributor.20:02
edleafemriedem: are these 'NoValidHost' failures related to the bugs you and sdague were working on? https://review.openstack.org/#/c/258180/20:02
*** aginwala has quit IRC20:02
mriedemyou own it now20:02
*** ijw has joined #openstack-nova20:03
mriedemno valid host failures?20:03
*** aginwala has joined #openstack-nova20:03
*** tonytan4ever has quit IRC20:03
mriedemjaypipes: ok, but do you have an opinion on how nova adveritises multiattach support?20:03
mriedemhemna: ^20:03
mriedemedleafe: http://logs.openstack.org/80/258180/10/check/gate-tempest-dsvm-full/5cc12a2/logs/screen-n-cpu.txt.gz?level=TRACE20:04
mriedemthat looks like a problem with your change20:04
edleafemriedem: the logs are full of stuff like this: http://paste.openstack.org/show/483812/20:04
mriedemyeah20:04
mriedemyou're moving config options around right?20:04
edleafemriedem: yeah20:04
mriedemedleafe: see the n-cpu log20:04
mriedemNoSuchOptError: no such option in group DEFAULT: dhcp_domain20:04
*** pratikmallya has quit IRC20:04
edleafeof course, they work great locally :)20:05
mriedemunit tests always work great locally20:05
edleafeheh20:05
* mriedem cues wah wah horn sound20:05
ildikovmriedem: lol :)20:05
edleafemriedem: ok, thanks - let me dig deeper20:05
ildikovmriedem: so the API question is tricky, but I got your concern20:05
*** mgoddard_ has quit IRC20:06
mriedemildikov: so i think the thing we can all agree on for mitaka is the places in the compute manager that call bdm.get_by_volume that have an instance (remove_volume_connector, detach and swap), need to be updated to pass the instance uuid in20:06
*** eharney has quit IRC20:06
hemnahey20:06
mriedemit's not really clear to me if a new bdm method needs to be added for that (bdm object method)20:06
ildikovin my opinion no20:06
*** carey has quit IRC20:06
ildikovthat would not solve anything20:06
mriedemhemna: read back from (1:58:25 PM) mriedem: ildikov: so one issue with this,20:06
hemnamriedem, does nova need to advertise multiattach for a vol ?20:07
mriedemhemna: well, if it's not discoverable from the api, how does a user know they can use it?20:07
ildikovso there will be one API request that will not fail in cases, when the volume allows multiattach20:07
mriedemhaving said that, even with a microversion, if you're not using libvirt, multiattach won't work anyway20:07
ildikovall the rest of the calls behaves the same20:07
hemnamriedem, I dunno, it's new territory20:08
mriedemhemna: well normally this is how we advertise features in the api, via microversions20:08
hemnafrom cinder's perspective we advertise it from the cinder create --allow-multiattach20:08
hemnait's a grey area20:08
mriedemyeah, i can create a multiattach volume in cinder since juno20:08
hemnanova can already attach20:08
hemnaso...20:08
mriedemthat doesn't mean i can do anything with it20:08
hemnait's just allowing the same one to be attached again...maybe.20:08
mriedemheh20:09
hemnahehe20:09
mriedemyeah, the maybe part is the question20:09
hemnayah20:09
ildikovcurrently the API layer in Nova is not changed, only the behaviour of that one call20:09
mriedemildikov: well, it's an api behaviour change20:10
mriedem*behavior, i'm not british20:10
ildikovand if it makes it for Mitaka then prolly it's better not advertise it immediatelly ;)20:10
hemnaI'm not sure what the right answer here is20:10
ildikovme neither I just got used to that my MS Products are...20:10
*** claudiub has quit IRC20:10
mriedemmaybe i need to start a ML thread20:11
hemnamriedem, can't hurt at this point....well...maybe20:12
hemnahehe20:12
mriedemwell, this really needs more than just like me and dan20:12
hemnayah agreed20:12
ildikovmriedem: quick question. are you also against of having a config option for enable/disable multiattach or maybe add it to the policy file?20:12
hemnait's best to have more discussion20:12
hemnaI just hope it doesn't derail this effort for the 5th time.20:12
hemna:(20:12
mriedemildikov: the config option still doesn't solve the ability to discover that multiattach is supported by nova from the api20:12
mriedemyou still just get a 40020:12
mriedemwhich you'd get from liberty nova for different reasons20:13
hemnaI think ildikov makes the 6th attempt at this.20:13
mriedemi will blame all of the previous cinder/nova PTLs20:13
mriedemand jaypipes20:13
ildikovthe reason is the same in the sense that multiattach is not supported20:13
ildikovmriedem: +1 :)20:13
ildikovif the volume/cinder driver or the virt driver does not support it the response is the same20:14
mriedemin that case it's actually worse20:14
mriedemb/c you don't know that's the reason it fails until you cast to the compute node and find out the virt driver on that node doesn't support multiattach20:15
hemnaonly the volume itself knows if it's supported20:15
ildikovok I added new errors, but the outcome is the same20:15
hemnacinder's API supports it, but the volume itself is the source of truth20:15
openstackgerritJames E. Blair proposed openstack/nova: Change the default set of tox jobs to run  https://review.openstack.org/26714020:15
hemna2 volumes from the same cinder backend may have different settings20:15
mriedemhemna: so if i try to create a volume with multiattach but using a cinder backend that doesn't support multiattach, i'm assuming that fails?20:15
hemnacorrect20:15
mriedemok20:15
mriedemwhich is the same if i try to boot from volume with a libvirt/lxc nova compute20:16
hemnayou call cinder create --allow-multiattach20:16
hemnaone backend works, the other doesn't20:16
mriedemyou get a 202 for the boot, but the instance errors out with NoValidHost20:16
*** annegentle has quit IRC20:17
*** whenry has joined #openstack-nova20:17
*** annegentle has joined #openstack-nova20:17
*** eliqiao has quit IRC20:17
*** dims has quit IRC20:18
ildikovmriedem: back to the config option question, do you see a way to enable this for Mitaka?20:18
*** dims has joined #openstack-nova20:18
*** diana_clarke has quit IRC20:19
*** eliqiao has joined #openstack-nova20:20
mriedemthat would probably be the only option, but it's still not something we really want to do i don't think20:20
*** rcernin has quit IRC20:20
*** albertom has quit IRC20:20
mriedemildikov: let me finish up some other work i already started today and then i'm going to try and summarize the issues in a ML thread20:20
*** lucasagomes is now known as lucas-dinner20:20
mriedemso others can weigh in, b/c we're just going in circles20:21
ildikovmriedem: ok20:21
openstackgerritTimofey Durakov proposed openstack/nova: Ceph for live-migration job  https://review.openstack.org/25228320:21
ildikovmriedem: in the meantime I will reorganize the patches20:21
mriedemor, you know, sleep20:21
ildikovthat will be fine after next Thursday :)20:21
*** tjones has joined #openstack-nova20:22
*** tdurakov_ has joined #openstack-nova20:22
tdurakov_sdague, hi20:22
ildikovmriedem: so we need almost all the code in except the check_attach changes and the block_device.py change where we enable multiattach20:22
ildikovI wonder about the virt drivers, that would not do any harm in20:23
ildikovso I need to move those snippets at the end of the chain so if it will finaly not make it for Mitaka fully we still have all the pieces to enable it preferably very early Newton20:24
ildikovmriedem: so plan B is to get all the necessary code in until next Thursday or we loose N too20:25
*** e0ne has quit IRC20:25
mriedemildikov: arguablly passing the instance uuid to bdm.get_by_volume from those 3 places in the compute manager is a bug fix20:26
mriedemso the FF doesn't matter for that20:26
hemnait's a bug!20:26
hemna:P20:26
mriedemyou could do that separately today20:26
dansmithI want it to be a new object call, FWIW20:26
*** Sukhdev has quit IRC20:26
dansmithbecause I think we should deprecate the one that currently makes it optional20:26
dansmithand have a new one that makes instance required20:26
ildikovmriedem: we need to pass the attachment_id in detach20:26
dansmithotherwise people will wrongly use the old method20:26
ildikovdansmith: the create_volume_snapshot will still need the old one20:27
mriedemthere is the one place that doesn't have an instance20:27
mriedembut....20:27
mriedemwe could still deprecate the bdm method20:27
*** gangil has quit IRC20:27
*** ericksonsantos has quit IRC20:27
mriedemwhich also basically deprecates the assisted snapshot API when you don't pass an instance id20:27
mriedemwe can always update that api later with a microversion and compute rpcapi change20:28
*** lpetrut has quit IRC20:28
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/api directory  https://review.openstack.org/25818020:28
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (2)  https://review.openstack.org/26058720:28
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (1)  https://review.openstack.org/26058620:28
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (3)  https://review.openstack.org/26058820:28
mriedemi don't know how you drop the deprecated bdm method though20:28
mriedemw/o breaking that api20:28
ildikovmriedem: if it means I don't have to bump a version now that sounds good to me20:28
mriedemdansmith: i think that's the issue on that one20:28
ildikovmriedem: you can't20:28
dansmithwell, we have to figure out something, but regardless we can handle an exceptional case20:28
ildikovit retrieves the instance_uuid from the BDM it gets back20:29
mriedemand we can't remove the instance uuid from the get_by_volume method b/c old compute20:29
ildikovyeah we had this round in the reviews earlier20:29
hemnahave to run to lunch....20:29
*** hemna is now known as hemnafk20:29
ildikovhemnafk: enjoy!20:29
dansmithmriedem: how do you call the assisted snapshot api without an instance?20:30
mriedemyou pass a volume id20:30
ildikovbut as mriedem said that patch with adding the instance_uuids to the calls is a bugfix20:30
mriedemcompute api then looks up the bdm by that volume id20:30
*** nagyz_ has quit IRC20:30
mriedemand then gets the instance from that bdm20:30
ildikovyeap, exactly what I meant in my above comment20:30
*** jaosorior has quit IRC20:30
*** eharney has joined #openstack-nova20:30
*** jaosorior has joined #openstack-nova20:30
mriedemhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L326120:31
dansmithmriedem: so we can check that the volume is not multiattach, then look up all the bdms for that volume, fail if there is more than one, extract the one instance_uuid20:31
dansmithright?20:31
mriedemhttps://review.openstack.org/#/c/193134/69/nova/compute/api.py20:31
mriedemsee L326520:31
ildikovold compute i sstill issue, easier to just simply block it for multiattach volumes20:31
ildikovmriedem: tnx20:32
*** zhihais has quit IRC20:32
dansmithmriedem: yeah, for just that that works. was there still a case where we had to end up calling this bdm method without instance?20:32
mriedemthat is also a thing that is only supported by the libvirt driver20:32
dansmithmriedem: you said we can't deprecate it20:32
ildikovmriedem: saw your comment about the exception name, will fix it later when I get there20:32
mriedemdansmith: that's the only place where we don't have an instance20:32
*** zhihais has joined #openstack-nova20:33
ildikovyeah, it's a pity we've never passed it where we had the info :(20:33
*** otter768 has joined #openstack-nova20:34
*** jaosorior has quit IRC20:34
dansmithmriedem: I guess I was thinking we'd deprecate the current method, add a new one that requires instance, and a new one that doesn't take instance, but selects out all the BDMs matching the volume, asserting that there is only one, and then returning that one20:34
mriedemwell, also volume_snapshot_delete20:34
dansmiththat fixes potential abuse I think20:35
*** tonytan4ever has joined #openstack-nova20:35
*** raildo is now known as raildo-afk20:35
mriedemdansmith: which with the .first() in the db api today, is basically the same20:36
mriedembehavior-wise20:36
dansmithit's not20:36
ildikovvolume_snapshot_delete should be fine if we don't have volume snapshot20:36
dansmithbecause if we end up with two BDMs in for a volume we're not expecting it will just pick and go20:36
mriedemdansmith: so by "asserting that there is only one" you mean raise an error if there is more than one?20:36
ildikovit's not failing, but frankly speaking I don't think that one case worth the effort20:36
dansmithand I'm saying we should say that if you want to call the with-no-instance version, we ensure we never return you a bdm that is attached for a multiattach volume, just because we expect you checked it first20:36
dansmithmriedem: yeah20:37
*** ctrath has quit IRC20:37
dansmithotherwise someone that doesn't have this in their head,20:37
mriedemi'm ok with that20:37
*** daemontool has quit IRC20:37
dansmithwill look and say "hey, check out that one doesn't require instance, I'll use that one"20:37
dansmithfor some thing in the future20:37
*** Marga_ has quit IRC20:37
mriedemyeah20:37
mriedemso i think that's a decent plan20:37
ildikovwe have the info in the volume20:37
ildikovit has the attachment list20:37
dansmithwe still have to defend our database20:38
ildikovif that's more than one then we can fail without BDM change20:38
*** daemontool has joined #openstack-nova20:38
*** otter768 has quit IRC20:38
ildikovbut with multiattach we will have multiple BDMs for one volume20:38
*** markmcclain has joined #openstack-nova20:38
openstackgerritEric Brown proposed openstack/nova: Use of six.PY3 should be forward compatible  https://review.openstack.org/26715220:38
*** Marga_ has joined #openstack-nova20:39
openstackgerritAndrew Laski proposed openstack/nova: Doc: Add rough plan for cellsv2 upgrade scenarios  https://review.openstack.org/26715320:39
ildikovdansmith: I don't get the db protection comment, could you clarify it a bit what did you mean?20:39
*** rlrossit has quit IRC20:39
mriedemwe have no unique constraints on the bdm table20:39
dansmithildikov: I'm saying we should not make our object depend on the attachment list on the volume to determine if it's doing something sane. It needs to operate based on what is in our database20:40
ildikovbut this check has nothing to do with it, neither multiattach20:40
*** rlrossit has joined #openstack-nova20:40
dansmithwhich means pull out all matching BDMs, and fail if there is more than one20:40
*** ctrath has joined #openstack-nova20:40
mriedemagree with dan20:40
dansmithso that means that in mitaka, we must:20:41
ildikovbut that's a bugfix for a generic race issue if I understand it correctly20:41
mriedemrelying on the volume attachment list in that case also relies on the cinder db being 100% every time we need it to be20:41
dansmith1. Deprecate the current method20:41
ildikovit has nothing to do with this change20:41
dansmith2. Add a new one that requires instance20:41
dansmith3. Add a new one that does not take instance, and only returns if there is exactly one BDM in the database for that volume20:41
dansmithelse we can't even do this in N20:41
*** ctrath1 has joined #openstack-nova20:41
ildikovmriedem: in the sense of Cinder owns the volume, it should be the source of truth20:41
dansmithildikov: it does because you're effectively corrupting our database20:41
mriedemand then adjust what's calling #1 to use 2 or 320:41
dansmithwith this change, without handling the change20:41
dansmithmriedem: yes20:41
mriedemi think we can get that into mitaka as a bug fix20:42
dansmithyes20:42
mriedemjust b/c it's already a potential race given no unique constraint20:42
mriedemgod, it's like, if we had a uuid on the bdm table or something...20:43
dansmithheh20:43
*** apoorvad has quit IRC20:43
ildikovas mriedem said we don't have unique BDMs today, so I'm not corrupting the DB any further than how much it currently is20:43
*** Marga_ has quit IRC20:43
openstackgerritTimofey Durakov proposed openstack/nova: live-migration hook ansible 2.0 compaitability  https://review.openstack.org/26715420:43
dansmithyou totally are20:43
dansmithright now we have to race to corrupt the database20:43
dansmithafter your change, we merely have to use a feature as it was intended to corrupt the database20:44
ildikovbut you can identify the bdm with the instance and volume id20:44
*** rlrossit_ has joined #openstack-nova20:44
*** rlrossit_ has quit IRC20:44
*** rlrossit_ has joined #openstack-nova20:44
*** rlrossit has quit IRC20:44
*** ctrath has quit IRC20:45
dansmithmriedem: I'll just do this on my own as the bug fix and we can -2 the multiattach work until it merges20:45
dansmithit'll take me less time than arguing20:45
mriedemi was going to say, i could do the bdm/db api stuff too, but it's yours if you want20:45
dansmithmriedem: open me a bug and we'll call it square :)20:46
mriedemalrighty20:46
*** aginwala has quit IRC20:46
ildikovthanks guys, sorry I haven't slept for a while so if you think it's the best this way then tnx for helping out20:46
*** dimtruck is now known as zz_dimtruck20:47
dansmithildikov: I'm going to steal your db/api bit into my patch, FYI20:48
ildikovdansmith: my pleasure to give it to you :)20:49
*** rcernin has joined #openstack-nova20:49
dansmithheh, I'm sure20:49
*** tdurakov_ has quit IRC20:50
*** aginwala has joined #openstack-nova20:50
ildikovdansmith: well, if this keeps this work rolling as I said I can only say thank you20:51
mriedemdansmith: https://bugs.launchpad.net/nova/+bug/153383420:52
openstackLaunchpad bug 1533834 in OpenStack Compute (nova) "nova.objects.BlockDeviceMapping.get_by_volume_id can be racy and should be deprecated" [Medium,Triaged]20:52
ildikovmriedem: thanks!20:52
dansmithmriedem: thanks20:52
*** tdurakov_ has joined #openstack-nova20:53
*** gangil has joined #openstack-nova20:53
*** gangil has joined #openstack-nova20:53
ildikovmriedem: I will reorganize the rest of the patches then and add it on top of dansmith's one20:54
dimssdague : should nova-dhcpbridge be generating log files?20:55
*** belmoreira has joined #openstack-nova20:56
*** tdurakov_ has quit IRC20:56
*** armax has quit IRC20:56
*** aix has quit IRC20:56
*** atuvenie has quit IRC20:58
dimssdague : we seem to be hitting the dhcp lease problem a lot http://status.openstack.org//elastic-recheck/20:58
*** baoli has joined #openstack-nova20:59
openstackgerritDan Smith proposed openstack/nova: WIP: Fix stupid  https://review.openstack.org/26716920:59
dansmithmriedem: that's my plan20:59
dansmith^20:59
openstackgerritdane-fichter proposed openstack/nova: Add image signature verification  https://review.openstack.org/18984320:59
mriedembut you can't fix stupid20:59
*** haomaiwang has quit IRC21:01
*** aginwala has quit IRC21:01
*** haomaiwang has joined #openstack-nova21:01
dansmithguess I'll have to change it then21:01
*** ekarlso has quit IRC21:01
*** ekarlso has joined #openstack-nova21:01
*** tdurakov_ has joined #openstack-nova21:03
*** aginwala has joined #openstack-nova21:03
*** dustins has quit IRC21:03
*** raildo-afk is now known as raildo21:03
*** raildo is now known as raildo-afk21:03
*** rcernin has quit IRC21:04
*** tdurakov_ has quit IRC21:05
*** tdurakov_ has joined #openstack-nova21:05
*** smatzek has quit IRC21:07
*** akshai has quit IRC21:08
*** zz_dimtruck is now known as dimtruck21:08
*** baoli has quit IRC21:09
*** baoli has joined #openstack-nova21:10
*** yonglihe has quit IRC21:11
*** akshai has joined #openstack-nova21:12
*** ig0r_ has quit IRC21:14
*** akshai has quit IRC21:19
*** vladikr has quit IRC21:21
*** baoli has quit IRC21:21
*** baoli has joined #openstack-nova21:22
*** ig0r_ has joined #openstack-nova21:22
*** tjones has left #openstack-nova21:23
mriedempatrickeast: congrats https://blueprints.launchpad.net/nova/+spec/cinder-backend-report-discard21:26
* patrickeast cheers21:27
patrickeastmriedem: thanks for pushing it through21:28
*** angdraug has quit IRC21:28
*** armax has joined #openstack-nova21:30
*** ig0r_ has quit IRC21:31
*** aysyd has quit IRC21:31
openstackgerritDan Smith proposed openstack/nova: Fix undetected races when getting BDMs by volume id  https://review.openstack.org/26716921:33
dansmithmriedem: ildikov ^21:33
dansmithcreated at top speed.. exercise caution21:33
*** baoli has quit IRC21:33
mriedemjust like maverick21:33
*** baoli has joined #openstack-nova21:34
dansmithnegative ghost writer21:34
*** RichardRaseley has joined #openstack-nova21:34
mriedemrider21:34
mriedemha21:34
dansmithI've seen it both ways21:34
*** salv-orlando has quit IRC21:34
dansmithfind me a paramount script and I'll concede :)21:34
mriedemdude21:34
dansmithI just saw you commented21:34
* dansmith reads21:34
mriedemhttp://www.urbandictionary.com/define.php?term=That%27s+a+negative+Ghost+Rider21:34
*** salv-orlando has joined #openstack-nova21:35
mriedemeven google tried correcting me when i tried 'negative ghost writer'21:35
dansmithyeah, that guy knows21:35
*** apoorvad has joined #openstack-nova21:35
ildikovdansmith: thanks, checking21:35
dansmithpfft21:35
dansmithshocking, mriedem has naming concerns :)21:36
sdaguedims: it's a call script from dnsmasq21:37
sdagueI don't know if there is a log anywhere else21:37
mriedemccarmack: if you're looking for something to work on https://bugs.launchpad.net/nova/+bug/153385921:38
openstackLaunchpad bug 1533859 in OpenStack Compute (nova) "There should be a DB API test that ensures no new tables have soft-delete columns" [Undecided,New]21:38
*** hemnafk is now known as hemna21:40
hemnamriedem, nova doesn't do soft deletes now ?21:40
*** Marga_ has joined #openstack-nova21:40
mriedemhemna: it does21:40
mriedem'no new tables'21:40
mriedemlike no new taxes21:40
hemna:)21:40
dansmithdamn21:40
dansmithbeat me to it21:40
*** rfolco has quit IRC21:42
openstackgerritSean Dague proposed openstack/nova: always use pip constraints  https://review.openstack.org/26709621:42
openstackgerritDan Smith proposed openstack/nova: Fix undetected races when getting BDMs by volume id  https://review.openstack.org/26716921:43
dansmithmriedem: just for you ^21:44
*** ig0r_ has joined #openstack-nova21:44
*** akshai has joined #openstack-nova21:44
*** thumpba has quit IRC21:44
*** ig0r_ has quit IRC21:45
*** baoli has quit IRC21:45
*** Marga_ has quit IRC21:45
ildikovdansmith: I added a question, the patch looks good, tnx21:45
*** baoli has joined #openstack-nova21:45
ccarmackmriedem: I assigned that bug to myself21:46
*** jichen has quit IRC21:48
*** Sukhdev has joined #openstack-nova21:49
*** dimtruck is now known as zz_dimtruck21:49
*** pratikmallya has joined #openstack-nova21:51
*** FL1SK has quit IRC21:51
openstackgerritTomi Juvonen proposed openstack/nova: Add host_status attribute for servers/detail and servers/{server_id}  https://review.openstack.org/24156221:53
*** whenry has quit IRC21:53
*** pratikma_ has quit IRC21:54
*** rcernin has joined #openstack-nova21:55
openstackgerritDan Smith proposed openstack/nova: Add host_status attribute for servers/detail and servers/{server_id}  https://review.openstack.org/24156221:56
openstackgerritDan Smith proposed openstack/nova: Add object and database support for host_status API  https://review.openstack.org/26706221:56
dansmithtojuvone: rebased ^21:56
*** rotbeard has joined #openstack-nova21:57
*** ssurana has joined #openstack-nova21:57
mriedemdansmith: comment about the warning log fixme in https://review.openstack.org/#/c/267169/3/nova/objects/block_device.py21:57
*** baoli has quit IRC21:57
*** baoli has joined #openstack-nova21:58
*** smatzek has joined #openstack-nova21:58
dansmithmriedem: we can't filter in that legacy one because it changes the behavior for liberty clients in the case of the race21:59
dansmiththere's no real point either21:59
dansmithjust convert everything to call one of the two new methods,21:59
dansmithwarn in the old one -- warning goes away when you fully migrate to mitaka21:59
dansmiththen we drop that method and don't look back21:59
tojuvonedansmith: Thanks a lot. It's midnight, so I continue tomorrow. I'll be catching oomichi in the morning I guess.21:59
mriedemyeah, do the warning then21:59
mriedemand at some point,22:00
mriedemwe should remove 'or reserved' here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L463822:00
dansmithtojuvone: cool thanks22:00
dansmithmriedem: okay I'll add a log22:00
*** haomaiwang has quit IRC22:01
mriedemi assume you're going to do the method call changes on a follow up change?22:01
*** ccarmack has left #openstack-nova22:01
*** haomaiwang has joined #openstack-nova22:01
*** ZZelle_ has joined #openstack-nova22:01
*** Marga_ has joined #openstack-nova22:01
*** carey has joined #openstack-nova22:02
dansmithmriedem: or make ildikov do them :)22:03
dansmithbut definitely not in here, preferably22:03
mriedemyeah i just wasn't sure if you were signing up to do it22:03
ildikovmriedem: dansmith: I will do the change22:03
dansmithildikov: cool, thanks22:04
ildikovpreferably tomorrow in my time zone though, I hope that's acceptable, only a few hours from now :)22:04
dansmithildikov: not only acceptable, but preferred22:04
ildikovdansmith: thanks :)22:05
openstackgerritDan Smith proposed openstack/nova: Fix undetected races when getting BDMs by volume id  https://review.openstack.org/26716922:05
*** belmoreira has quit IRC22:05
mriedemso with https://github.com/openstack/nova/commit/91b35b22e753a4eb0c22c004bb12586970a95e11 we've dropped support for compute rpc 3.x22:06
*** Marga_ has quit IRC22:07
mriedemway back in grizzly, that volume_id or 'reserved' condition was added to fix a regression in compute rpc 2.x https://github.com/openstack/nova/commit/66f1a34cabc26930db2a1afed5a0f5ced4d1c01522:07
*** carey has quit IRC22:07
mriedemb/c volume_id needed to be optional on that call to the compute manager22:07
*** RichardRaseley has quit IRC22:09
*** salv-orl_ has joined #openstack-nova22:09
*** kfarr has quit IRC22:09
*** baoli has quit IRC22:09
mriedemin v2.1, volume_id is required in the rest api22:09
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/volumes.py#L7922:09
*** baoli has joined #openstack-nova22:10
*** burgerk has quit IRC22:10
*** zz_dimtruck is now known as dimtruck22:10
mriedemand v2 https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/volumes.py#L29322:10
mriedemtherefore, there is no way you can get from the rest api to the compute manager w/o a volume_id now22:10
mriedemso we can drop that 'reserved' thing22:10
mriedemyay!22:10
*** rcernin has quit IRC22:10
openstackgerritChuck Carmack proposed openstack/nova: config options: centralize 'spice' options  https://review.openstack.org/26427122:10
*** salv-orlando has quit IRC22:12
*** ccarmack has joined #openstack-nova22:12
openstackgerritBrianna Poulos proposed openstack/nova: Catch UnsupportedAlgorithm exceptions  https://review.openstack.org/26702122:12
*** ndipanov has quit IRC22:12
openstackgerritdane-fichter proposed openstack/nova: Add image signature verification  https://review.openstack.org/18984322:12
*** pratikma_ has joined #openstack-nova22:13
*** yamahata has quit IRC22:14
*** pratikmallya has quit IRC22:16
ildikovdansmith: mriedem: I call it a day now, thanks for the discussions and help with the BDM object stuff22:16
mriedemttyl22:16
ildikovlaters22:16
dansmithildikov: thanks22:17
bauzasmriedem: given ttx's email, do you want to have a stable point release ?22:19
mriedemholy crap, am i 1 hour and 19 minutes late for the cells v2 meeting?22:19
* bauzas is a bit off those days due to a local conference 22:19
mriedembauzas: yeah, have to get mdbooth's security fixes in first22:19
bauzasalaski: mriedem: meh, did I missed the cells v2 meeting ?22:20
*** dimtruck is now known as zz_dimtruck22:20
bauzassad22:20
bauzashttp://snowcamp.io is just leaving me out :(22:20
*** baoli_ has joined #openstack-nova22:21
alaskibauzas: yep, you can catch the transcript if you're interested22:21
bauzasalaski: aaaaarh, sorry :(22:21
dansmithwat?22:22
*** daemontool has quit IRC22:22
dansmithit was later today/22:22
dansmithI guess it flipped after the new year22:22
* dansmith scolds his calendar22:22
* bauzas needs to fix his calendar too22:22
*** Sukhdev has quit IRC22:22
alaskidansmith: yep, really messed things up22:22
dansmithdoh22:23
bauzasalaski: could you please ping me next time for the meeting ?22:23
*** daemontool has joined #openstack-nova22:23
alaskiI don't even have a calendar that can deal with even/odd rather than alternating weeks22:23
bauzaslike we do for nova :)22:23
*** boris-42 has quit IRC22:23
*** baoli__ has joined #openstack-nova22:24
alaskiI'll add a ping list to the meeting page, but if it gets ridiculous like the Nova one I'm dropping it22:24
*** baoli has quit IRC22:24
bauzasmeh22:24
*** armax has quit IRC22:25
bauzasmriedem: for mdbooth's patches, I missed the convo, could you please point me out the links ?22:25
dansmithalaski: stay strong against silly ping lists :)22:26
*** baoli_ has quit IRC22:26
*** tdurakov_ has quit IRC22:27
*** baoli__ has quit IRC22:27
alaskiheh.  Maybe I'll compromise and ping only for the first meetings of the year, in case this happens again22:27
*** baoli has joined #openstack-nova22:28
openstackgerritMatt Riedemann proposed openstack/nova: Remove "or 'reserved'" condition from reserve_block_device_name  https://review.openstack.org/26720622:28
mriedemi actually had a reminder popup22:29
mriedembut because of too many tabs and blinking windows and crap, i missed it22:29
alaskifor shame22:29
mriedem:(22:29
*** zz_dimtruck is now known as dimtruck22:29
mriedemi need an intern to remind me22:29
alaskialso, https://review.openstack.org/#/c/267153/ is for you22:29
mriedemi did see that scroll by22:29
mriedemyou may also enjoy https://review.openstack.org/#/c/267206/22:30
*** baoli has quit IRC22:30
mriedembauzas: look! cve release notes http://docs-draft.openstack.org/78/267178/1/check/gate-nova-releasenotes/e7bdcb0//releasenotes/build/html/unreleased.html22:30
*** baoli has joined #openstack-nova22:30
mriedembauzas: also https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/liberty+topic:bug/152427422:31
bauzascoolness22:32
alaskiI love that the commit message is about 50x larger than the actual change22:32
mriedemhistory22:32
mriedemi had to look up those commits, so i figured i'd doc them22:32
bauzasmriedem: I like your commit msg22:33
alaskiit's excellent, just amusing22:33
*** Sukhdev has joined #openstack-nova22:33
bauzasbecause it helps me to understand the problem22:33
bauzasmriedem: for the stable patches, do you want to wait for the still opens ?22:33
mriedembauzas: for those that aren't approved yet?22:33
*** pratikma_ has quit IRC22:33
bauzasyup22:33
mriedemthere was only 1 i kind of thouht should get in22:34
mriedemsec22:34
mriedemhttps://review.openstack.org/#/c/266096/22:34
mriedembut i was waiting for garyk to vouch for it22:34
*** Sukhdev has quit IRC22:34
bauzasokay, I'll look at those tomorrow22:34
*** otter768 has joined #openstack-nova22:35
bauzasbut I'll just +1 those22:35
mriedemheh22:35
mriedemif you can think of anything missing from release notes given the change log, let me know22:35
mriedemi at least wanted the cve's doc'ed22:35
bauzasfair enough22:35
bauzasyup22:35
bauzasand I like that22:35
*** edtubill has quit IRC22:37
*** pratikmallya has joined #openstack-nova22:37
*** ccarmack has left #openstack-nova22:39
*** xyang1 has quit IRC22:39
*** otter768 has quit IRC22:40
*** baoli has quit IRC22:42
*** baoli has joined #openstack-nova22:43
*** smatzek has quit IRC22:43
*** Marga_ has joined #openstack-nova22:43
*** thorst has quit IRC22:43
*** thorst has joined #openstack-nova22:44
*** vivekd has quit IRC22:46
*** Marga_ has quit IRC22:47
*** thorst has quit IRC22:48
*** dave-mccowan has quit IRC22:49
*** tdurakov_ has joined #openstack-nova22:50
*** Marga_ has joined #openstack-nova22:52
mriedemalright, multiattach quandry ML thread sent22:52
mriedemit's not fun22:52
mriedemhttp://lists.openstack.org/pipermail/openstack-dev/2016-January/084031.html22:53
*** ccarmack has joined #openstack-nova22:53
*** browne has quit IRC22:54
*** armax has joined #openstack-nova22:54
*** baoli has quit IRC22:54
*** baoli has joined #openstack-nova22:55
*** aginwala has quit IRC22:58
*** mriedem is now known as mriedem_away23:00
*** haomaiwang has quit IRC23:01
*** haomaiwang has joined #openstack-nova23:01
*** armax has quit IRC23:01
*** mdrabe has quit IRC23:01
*** tdurakov_ has quit IRC23:01
vilobhmm11bauzas : ping23:02
*** ctrath1 has quit IRC23:02
*** rlrossit_ has quit IRC23:02
*** burt has quit IRC23:02
*** tdurakov_ has joined #openstack-nova23:03
vilobhmm11dansmith : ping need some help23:03
*** thorst has joined #openstack-nova23:04
*** _diana_1 has joined #openstack-nova23:06
*** baoli has quit IRC23:06
*** aginwala has joined #openstack-nova23:06
*** baoli has joined #openstack-nova23:07
*** aginwala has quit IRC23:07
*** aginwala has joined #openstack-nova23:07
*** artom has joined #openstack-nova23:08
*** thorst has quit IRC23:08
*** zenoway has quit IRC23:09
*** ccarmack has quit IRC23:09
*** _diana_1 has quit IRC23:10
*** _diana_1 has joined #openstack-nova23:10
*** ctrath has joined #openstack-nova23:10
*** tdurakov_ has quit IRC23:11
vilobhmm11mriedem : are you around ?23:15
*** thorst has joined #openstack-nova23:17
*** baoli_ has joined #openstack-nova23:18
*** annegentle has quit IRC23:18
*** baoli__ has joined #openstack-nova23:20
*** baoli has quit IRC23:21
*** ociuhandu has joined #openstack-nova23:23
*** baoli_ has quit IRC23:23
*** amotoki has joined #openstack-nova23:28
*** _diana_1 has quit IRC23:28
*** pratikmallya has quit IRC23:28
*** baoli__ has quit IRC23:29
*** pratikmallya has joined #openstack-nova23:29
*** ZZelle_ has quit IRC23:30
*** _diana_1 has joined #openstack-nova23:31
*** pratikmallya has quit IRC23:33
*** armax has joined #openstack-nova23:37
*** moshele has joined #openstack-nova23:40
*** mrkz has quit IRC23:40
*** mragupat_ has quit IRC23:41
*** ctrath has quit IRC23:41
*** yassine has quit IRC23:43
*** Daisy has joined #openstack-nova23:43
*** pratikmallya has joined #openstack-nova23:43
*** dimtruck is now known as zz_dimtruck23:46
*** akshai has quit IRC23:47
*** FL1SK has joined #openstack-nova23:49
*** diogogmt has quit IRC23:49
*** ducttape_ has quit IRC23:50
*** smoriya_ has joined #openstack-nova23:51
*** armax has quit IRC23:51
*** amotoki has quit IRC23:52
*** amotoki has joined #openstack-nova23:52
*** pradk has quit IRC23:53
*** amotoki has quit IRC23:53
*** Daisy has quit IRC23:54
*** akshai has joined #openstack-nova23:54
*** Daisy has joined #openstack-nova23:55
*** aginwala has quit IRC23:56
*** armax has joined #openstack-nova23:58
*** browne has joined #openstack-nova23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!