mriedem1 | bauzas: edleafe: ^ | 00:00 |
---|---|---|
kfox1111 | say I create m1.small. it has extra spec hostagg=type1. I create a host aggregate called type1 and set metadata hostagg=type1 on it. | 00:00 |
kfox1111 | I also setup the hostaggrigate filter in nova. | 00:01 |
kfox1111 | now, when the user goes and uses m1.small, it will only launch on members of the type1 host aggregate. | 00:01 |
melwitt | right | 00:01 |
kfox1111 | then, I go and add magnum_instance_type=vm to m1.small extra_spec. | 00:01 |
*** salv-orlando has joined #openstack-nova | 00:01 | |
*** dannywilson has quit IRC | 00:02 | |
kfox1111 | the user goes and tries to lauch, the filter kicks in, finds no host aggregate with magnum_instance_type=vm and fails the launch. | 00:02 |
*** openstack has joined #openstack-nova | 00:04 | |
*** IanGovett has joined #openstack-nova | 00:04 | |
*** markvoelker has quit IRC | 00:04 | |
melwitt | yeah | 00:05 |
*** salv-orlando has quit IRC | 00:06 | |
*** roldyx has joined #openstack-nova | 00:06 | |
*** SourabhP has quit IRC | 00:06 | |
roldyx | hello, I am using ice-house.. | 00:07 |
roldyx | is it possible to have one tenant by zona?? | 00:07 |
roldyx | one tenant == one host aggregate | 00:07 |
roldyx | nova availability-zone-list <<-- shows me two zones.. | 00:08 |
kfox1111 | kind of? | 00:08 |
kfox1111 | you can set up per tenant flavors, and pin them to host aggregates. | 00:09 |
roldyx | but when I execute nova availability-zone-list always have two zones | 00:10 |
*** tsekiyam_ has joined #openstack-nova | 00:11 | |
*** boris-42 has quit IRC | 00:12 | |
kfox1111 | not sure. I haven't played with availability zones much. | 00:12 |
roldyx | when i open the dashboard(horizon) and launch one instance.. I have 2 zones in "availability zones" | 00:13 |
*** vilobhmm has quit IRC | 00:14 | |
*** vilobhmm has joined #openstack-nova | 00:14 | |
*** tsekiyama has quit IRC | 00:15 | |
*** mtanino has quit IRC | 00:15 | |
*** Sukhdev has quit IRC | 00:16 | |
*** tjones1 has left #openstack-nova | 00:16 | |
*** tsekiyam_ has quit IRC | 00:16 | |
kfox1111 | did you create the host aggregate as an availability zone? | 00:17 |
kfox1111 | I think there's a way to make it one, or not. | 00:17 |
*** achanda has quit IRC | 00:17 | |
*** y_sawai has joined #openstack-nova | 00:18 | |
kfox1111 | I've been making mine as non az's, then just making them available to flavors that I tag to specific tenants. | 00:18 |
*** y_sawai has quit IRC | 00:19 | |
*** promulo__ has joined #openstack-nova | 00:21 | |
roldyx | kfox1111: i understand you.. but my problem is different.. | 00:22 |
*** ijw has quit IRC | 00:24 | |
roldyx | many users use dashboard and select wrong AZ | 00:24 |
*** promulo_ has quit IRC | 00:25 | |
*** hogepodge has joined #openstack-nova | 00:25 | |
*** yingjun has joined #openstack-nova | 00:27 | |
roldyx | and call me because a "red banner" appear on the screen | 00:27 |
kfox1111 | maby "nova aggregate-update youraggregateid youraggregatename nova"? | 00:27 |
kfox1111 | maybe | 00:28 |
*** davideagnello has joined #openstack-nova | 00:28 | |
kfox1111 | http://blog.russellbryant.net/2013/05/21/availability-zones-and-host-aggregates-in-openstack-compute-nova/ | 00:28 |
kfox1111 | seems to claim that if the az field is set, it exposes it as an az as well. | 00:29 |
kfox1111 | so maybe it needs to be unset. | 00:29 |
roldyx | AZ nova does not exist :) I have deleted | 00:29 |
roldyx | kfox1111: tomorrow I try again... | 00:33 |
roldyx | thaks anyway | 00:33 |
roldyx | :) | 00:34 |
*** achanda has joined #openstack-nova | 00:36 | |
*** ZZelle_ has quit IRC | 00:38 | |
*** barra204 has quit IRC | 00:39 | |
*** ijuwang has joined #openstack-nova | 00:42 | |
*** roldyx has quit IRC | 00:42 | |
*** zzzeek has joined #openstack-nova | 00:43 | |
*** diogogmt has quit IRC | 00:46 | |
openstackgerrit | IWAMOTO Toshihiro proposed openstack/nova: Omit RescheduledException in instance_fault.message https://review.openstack.org/165751 | 00:46 |
*** MentalRay has joined #openstack-nova | 00:46 | |
*** ijuwang has quit IRC | 00:49 | |
*** diogogmt has joined #openstack-nova | 00:49 | |
*** ijuwang has joined #openstack-nova | 00:50 | |
*** oomichi has joined #openstack-nova | 00:50 | |
*** ssurana1 has quit IRC | 00:53 | |
*** ssurana has joined #openstack-nova | 00:54 | |
*** otter768 has joined #openstack-nova | 00:55 | |
*** earlephilhower has quit IRC | 00:55 | |
*** achanda has quit IRC | 00:56 | |
*** ijuwang has quit IRC | 00:57 | |
*** ssurana has quit IRC | 00:59 | |
*** otter768 has quit IRC | 00:59 | |
*** newbie_2 has quit IRC | 01:04 | |
*** achanda has joined #openstack-nova | 01:07 | |
*** zzzeek has quit IRC | 01:08 | |
*** jasondotstar has quit IRC | 01:08 | |
*** yingjun has quit IRC | 01:10 | |
*** IanGovett has quit IRC | 01:12 | |
*** hemna has joined #openstack-nova | 01:14 | |
*** hemna has quit IRC | 01:21 | |
*** ijw has joined #openstack-nova | 01:23 | |
*** otter768 has joined #openstack-nova | 01:25 | |
*** lyanchih has joined #openstack-nova | 01:25 | |
*** hemna has joined #openstack-nova | 01:27 | |
*** shuquan has joined #openstack-nova | 01:27 | |
*** deepthi has joined #openstack-nova | 01:31 | |
*** patrickeast has quit IRC | 01:38 | |
*** MentalRay has quit IRC | 01:45 | |
*** ijw_ has joined #openstack-nova | 01:45 | |
*** artom has quit IRC | 01:46 | |
*** jdandrea has quit IRC | 01:46 | |
*** tobe_ has joined #openstack-nova | 01:49 | |
*** ijw has quit IRC | 01:49 | |
*** otter768 has quit IRC | 01:53 | |
*** liusheng has quit IRC | 01:53 | |
*** vilobhmm has quit IRC | 01:57 | |
*** sambol has joined #openstack-nova | 01:58 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert SMBFS vol driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202779 | 01:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert NFS volume driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202778 | 01:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Introduce LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202777 | 01:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert Scality vol driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202783 | 01:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert Quobyte driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202782 | 01:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert GPFS volume driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202781 | 01:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert GlusterFS driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202780 | 01:58 |
*** thorst has joined #openstack-nova | 02:01 | |
*** tpeoples has joined #openstack-nova | 02:02 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert SMBFS vol driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202779 | 02:03 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert NFS volume driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202778 | 02:03 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Introduce LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202777 | 02:03 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert Scality vol driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202783 | 02:03 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert Quobyte driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202782 | 02:03 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert GPFS volume driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202781 | 02:03 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert GlusterFS driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202780 | 02:03 |
anish | a man on a mission here ^ | 02:04 |
*** ijw has joined #openstack-nova | 02:04 | |
*** thorst has quit IRC | 02:06 | |
*** ijw_ has quit IRC | 02:08 | |
*** shyu has joined #openstack-nova | 02:12 | |
*** yingjun has joined #openstack-nova | 02:12 | |
*** shuquan has quit IRC | 02:13 | |
*** dave-mccowan has quit IRC | 02:18 | |
*** shuquan has joined #openstack-nova | 02:19 | |
*** yingjun has quit IRC | 02:22 | |
*** yingjun has joined #openstack-nova | 02:22 | |
*** achanda has quit IRC | 02:23 | |
*** shuquan has quit IRC | 02:27 | |
*** shuquan_ has joined #openstack-nova | 02:27 | |
*** yingjun has quit IRC | 02:27 | |
openstackgerrit | ZhaoBo proposed openstack/nova: Fixed raise SecurityGroupCannotBeApplied as network port_security off https://review.openstack.org/188260 | 02:30 |
*** dims_ has quit IRC | 02:31 | |
*** zhenguo has joined #openstack-nova | 02:32 | |
*** tonytan4ever has quit IRC | 02:33 | |
openstackgerrit | Michael Sambol proposed openstack/nova: DO NOT MERGE https://review.openstack.org/202854 | 02:34 |
*** yingjun has joined #openstack-nova | 02:34 | |
*** yamahata has joined #openstack-nova | 02:35 | |
*** signed8bit_ZZZzz has quit IRC | 02:36 | |
*** jogo has quit IRC | 02:38 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE https://review.openstack.org/202379 | 02:41 |
*** y_sawai has joined #openstack-nova | 02:48 | |
*** y_sawai has quit IRC | 02:49 | |
*** y_sawai has joined #openstack-nova | 02:52 | |
*** ijw has quit IRC | 02:52 | |
*** hakimo has joined #openstack-nova | 02:53 | |
*** hakimo_ has quit IRC | 02:55 | |
*** vladikr has quit IRC | 02:55 | |
*** andreykurilin__ has quit IRC | 02:57 | |
*** y_sawai_ has joined #openstack-nova | 03:01 | |
*** Administrator_ has quit IRC | 03:02 | |
*** y_sawai has quit IRC | 03:04 | |
*** hakimo_ has joined #openstack-nova | 03:10 | |
*** hakimo has quit IRC | 03:10 | |
*** tpeoples has quit IRC | 03:11 | |
*** boris-42 has joined #openstack-nova | 03:14 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE https://review.openstack.org/202379 | 03:18 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Show 'locked_by' information in server Show & List Detail https://review.openstack.org/202391 | 03:18 |
*** Kennan has quit IRC | 03:20 | |
*** Kennan has joined #openstack-nova | 03:20 | |
*** shuquan_ has quit IRC | 03:21 | |
*** achanda has joined #openstack-nova | 03:23 | |
*** liusheng has joined #openstack-nova | 03:25 | |
*** hakimo has joined #openstack-nova | 03:27 | |
*** hakimo_ has quit IRC | 03:27 | |
*** achanda has quit IRC | 03:28 | |
*** dims_ has joined #openstack-nova | 03:32 | |
*** unicell has quit IRC | 03:34 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add instance action events for live migration https://review.openstack.org/195372 | 03:36 |
*** dims_ has quit IRC | 03:37 | |
*** annegentle has joined #openstack-nova | 03:38 | |
*** ildikov has quit IRC | 03:40 | |
*** tonytan4ever has joined #openstack-nova | 03:40 | |
*** hakimo_ has joined #openstack-nova | 03:44 | |
*** hakimo has quit IRC | 03:44 | |
*** mriedem1 has quit IRC | 03:46 | |
*** y_sawai_ has quit IRC | 03:48 | |
*** y_sawai has joined #openstack-nova | 03:48 | |
*** y_sawai has quit IRC | 03:49 | |
*** yingjun has quit IRC | 03:49 | |
*** y_sawai has joined #openstack-nova | 03:49 | |
*** jogo has joined #openstack-nova | 03:50 | |
*** tpeoples has joined #openstack-nova | 03:53 | |
*** y_sawai has quit IRC | 03:54 | |
*** otter768 has joined #openstack-nova | 03:54 | |
*** coolsvap|away is now known as coolsvap | 03:54 | |
*** achanda has joined #openstack-nova | 03:55 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 03:56 |
*** hemna has quit IRC | 03:58 | |
*** otter768 has quit IRC | 03:58 | |
*** achanda has quit IRC | 04:00 | |
*** erlon has quit IRC | 04:00 | |
*** hakimo has joined #openstack-nova | 04:01 | |
*** hakimo_ has quit IRC | 04:01 | |
*** baoli_ has joined #openstack-nova | 04:08 | |
*** hemna has joined #openstack-nova | 04:08 | |
*** baoli_ has quit IRC | 04:08 | |
*** hemna has quit IRC | 04:11 | |
*** annegentle has quit IRC | 04:11 | |
*** baoli has quit IRC | 04:11 | |
*** newbie_2 has joined #openstack-nova | 04:11 | |
*** hemna has joined #openstack-nova | 04:12 | |
*** hemna has quit IRC | 04:12 | |
*** hakimo_ has joined #openstack-nova | 04:18 | |
*** hakimo has quit IRC | 04:18 | |
*** unicell has joined #openstack-nova | 04:22 | |
*** unicell has quit IRC | 04:26 | |
*** unicell has joined #openstack-nova | 04:27 | |
*** y_sawai has joined #openstack-nova | 04:30 | |
*** thedodd has joined #openstack-nova | 04:33 | |
*** lyanchih has quit IRC | 04:35 | |
*** newbie_2 has quit IRC | 04:36 | |
*** y_sawai has quit IRC | 04:36 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 04:37 |
*** sambol has quit IRC | 04:39 | |
*** haomaiw__ has joined #openstack-nova | 04:42 | |
*** zhenguo has quit IRC | 04:43 | |
*** haomaiwa_ has quit IRC | 04:44 | |
gmann_ | oomichi: alex_xu : updated 'locked_by' patch - please have look -https://review.openstack.org/#/c/202391/ | 04:47 |
oomichi | gmann_: yeah, will soon :) | 04:48 |
gmann_ | oomichi: Thanks | 04:48 |
*** hemna has joined #openstack-nova | 04:48 | |
*** hemna has quit IRC | 04:49 | |
*** hemna has joined #openstack-nova | 04:52 | |
*** tobe_ has quit IRC | 04:53 | |
*** SourabhP has joined #openstack-nova | 04:54 | |
*** tonytan4ever has quit IRC | 04:56 | |
*** SourabhP_ has joined #openstack-nova | 04:57 | |
*** shyama has joined #openstack-nova | 04:58 | |
*** SourabhP has quit IRC | 04:59 | |
*** SourabhP_ is now known as SourabhP | 04:59 | |
alex_xu | gmann_: yea, will do asap | 04:59 |
gmann_ | alex_xu: Thanks :) | 04:59 |
alex_xu | gmann_: np | 04:59 |
alex_xu | oomichi: hi | 05:00 |
*** yingjun has joined #openstack-nova | 05:02 | |
*** lyanchih has joined #openstack-nova | 05:02 | |
oomichi | alex_xu: hello | 05:04 |
alex_xu | oomichi: one question, why we can't remove this option directly https://review.openstack.org/202724 | 05:04 |
oomichi | alex_xu: I am gussing that is the deprecation process manner for options | 05:05 |
*** dannywilson has joined #openstack-nova | 05:06 | |
alex_xu | oomichi: emm...as my understand deprecation is for some option rename to another one, or move the control to other option? This option is totally useless now. | 05:06 |
oomichi | alex_xu: yeah, most case. the point is deprecated_for_removal option | 05:07 |
oomichi | alex_xu: http://docs.openstack.org/developer/oslo.config/opts.html | 05:08 |
oomichi | alex_xu: "deprecated_for_removal – indicates whether this opt is planned for removal in a future release" | 05:08 |
*** telemonster has quit IRC | 05:08 | |
*** telemonster has joined #openstack-nova | 05:08 | |
oomichi | alex_xu: as the theory, oslo.config seems to contain this option before removing | 05:08 |
alex_xu | oomichi: ok, let me take a look at | 05:10 |
alex_xu | oomichi: thanks | 05:10 |
oomichi | alex_xu: np :) | 05:10 |
*** yingjun has quit IRC | 05:12 | |
*** yingjun has joined #openstack-nova | 05:12 | |
gmann_ | alex_xu: oomichi : this might be good to have as deprecation as we still support /v3 ? | 05:13 |
gmann_ | alex_xu: oomichi : i mean api-paste.ini | 05:13 |
oomichi | gmann_: does that mean /v3 of api-paste.ini also need deprecation time ? | 05:15 |
gmann_ | oomichi: humm good point, IMO no :) | 05:15 |
*** ssurana has joined #openstack-nova | 05:15 | |
alex_xu | oomichi: why we still need /v3? we never release it? | 05:15 |
*** browne has quit IRC | 05:16 | |
oomichi | gmann_: yeah, my answer also "no" | 05:16 |
oomichi | alex_xu: I also want to remove /v3 endpoint | 05:16 |
gmann_ | oomichi: alex_xu : yea, got it. v3 thing never got released. then we can just delete that config too | 05:16 |
alex_xu | oomichi: oops, I got you. we are same side | 05:16 |
gmann_ | oomichi: alex_xu : we wil be able to remove soon as test merge thing gets completed | 05:17 |
alex_xu | gmann_: yea | 05:17 |
*** thedodd has quit IRC | 05:17 | |
alex_xu | gmann_: cool! | 05:17 |
*** yingjun has quit IRC | 05:17 | |
oomichi | gmann_: yeah, your works will be able to remove it, thats GOOD! | 05:17 |
*** boris-42_ has joined #openstack-nova | 05:20 | |
*** oro has joined #openstack-nova | 05:21 | |
*** kmARC has joined #openstack-nova | 05:21 | |
*** kaisers2 has joined #openstack-nova | 05:21 | |
*** ameade_ has joined #openstack-nova | 05:21 | |
*** browne has joined #openstack-nova | 05:21 | |
*** ijw has joined #openstack-nova | 05:22 | |
*** raorn has joined #openstack-nova | 05:22 | |
*** obondarev_ has joined #openstack-nova | 05:23 | |
*** boris-42 has quit IRC | 05:23 | |
*** kaisers1 has quit IRC | 05:23 | |
*** jbernard has quit IRC | 05:23 | |
*** ameade has quit IRC | 05:23 | |
*** ondergetekende has quit IRC | 05:23 | |
*** obondarev has quit IRC | 05:23 | |
*** mmedvede has quit IRC | 05:23 | |
*** raorn_ has quit IRC | 05:23 | |
*** samueldmq has quit IRC | 05:23 | |
*** samuel-dmq has joined #openstack-nova | 05:23 | |
*** mmedvede has joined #openstack-nova | 05:24 | |
openstackgerrit | yalei wang proposed openstack/nova: Support unaddressed port https://review.openstack.org/202882 | 05:24 |
*** ameade_ is now known as ameade | 05:24 | |
*** ondergetekende has joined #openstack-nova | 05:24 | |
*** boris-42_ is now known as boris-42 | 05:24 | |
*** jbernard has joined #openstack-nova | 05:24 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Show 'locked_by' information in server Show & List Detail https://review.openstack.org/202391 | 05:25 |
*** hust has joined #openstack-nova | 05:27 | |
*** browne has quit IRC | 05:27 | |
*** lpetrut has joined #openstack-nova | 05:28 | |
hust | Can guys help me? | 05:28 |
*** vilobhmm has joined #openstack-nova | 05:29 | |
hust | i cann't ping on instance to internet | 05:29 |
hust | where i run #ifconfig, that is config ipv6 address, not ipv4 address | 05:30 |
hust | next, i run #router, it return empty, | 05:30 |
hust | In my network node, it can ping to external | 05:31 |
hust | thanks! | 05:31 |
tonyb | hust: #openstack is a better place for that question. | 05:31 |
tonyb | hust: this is more more deleopment questions | 05:31 |
hust | :((, ok, thanks you | 05:32 |
tonyb | hust: sorry I can't be of more help. | 05:32 |
*** lpetrut has quit IRC | 05:34 | |
*** Murali has joined #openstack-nova | 05:35 | |
*** dannywilson has quit IRC | 05:35 | |
*** dannywilson has joined #openstack-nova | 05:36 | |
*** markvoelker has joined #openstack-nova | 05:41 | |
*** redbeard has joined #openstack-nova | 05:41 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Remove unused parameter overwrite in elevated https://review.openstack.org/202885 | 05:43 |
*** Nikolay_St has quit IRC | 05:43 | |
*** Sukhdev has joined #openstack-nova | 05:43 | |
*** markvoelker_ has joined #openstack-nova | 05:44 | |
*** humble_ has joined #openstack-nova | 05:45 | |
*** markvoelker has quit IRC | 05:45 | |
*** tobe_ has joined #openstack-nova | 05:46 | |
*** hust has quit IRC | 05:46 | |
*** wanghua has quit IRC | 05:48 | |
*** lyanchih has quit IRC | 05:50 | |
*** annashen has joined #openstack-nova | 05:51 | |
*** lyanchih has joined #openstack-nova | 05:51 | |
*** y_sawai has joined #openstack-nova | 05:52 | |
*** otter768 has joined #openstack-nova | 05:55 | |
*** yingjun has joined #openstack-nova | 05:56 | |
*** otter768 has quit IRC | 05:59 | |
*** dims_ has joined #openstack-nova | 06:00 | |
*** dims_ has quit IRC | 06:06 | |
*** ig0r_ has joined #openstack-nova | 06:08 | |
*** SourabhP has quit IRC | 06:08 | |
*** SourabhP has joined #openstack-nova | 06:13 | |
*** rajesht has joined #openstack-nova | 06:15 | |
*** tobe_ has quit IRC | 06:16 | |
*** slong_ has quit IRC | 06:17 | |
*** SourabhP_ has joined #openstack-nova | 06:18 | |
*** SourabhP has quit IRC | 06:20 | |
*** SourabhP_ is now known as SourabhP | 06:20 | |
*** achanda has joined #openstack-nova | 06:21 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/197213 | 06:21 |
*** SourabhP has quit IRC | 06:22 | |
openstackgerrit | Sergey Vilgelm proposed openstack/nova: Switch to the oslo_utils.fileutils https://review.openstack.org/199575 | 06:23 |
*** dannywil_ has joined #openstack-nova | 06:24 | |
*** scheuran has joined #openstack-nova | 06:24 | |
*** dannywil_ has quit IRC | 06:25 | |
*** dannywil_ has joined #openstack-nova | 06:26 | |
*** dannywilson has quit IRC | 06:27 | |
*** tobe_ has joined #openstack-nova | 06:31 | |
*** karimb has joined #openstack-nova | 06:32 | |
*** Nikolay_St has joined #openstack-nova | 06:35 | |
*** hemna has quit IRC | 06:36 | |
*** Sukhdev has quit IRC | 06:37 | |
*** ijw has quit IRC | 06:37 | |
*** deepakcs has joined #openstack-nova | 06:38 | |
*** achanda has quit IRC | 06:39 | |
*** ndipanov has quit IRC | 06:42 | |
*** lyanchih has quit IRC | 06:43 | |
*** ndipanov has joined #openstack-nova | 06:43 | |
*** oro has quit IRC | 06:44 | |
*** kmARC has quit IRC | 06:44 | |
*** achanda has joined #openstack-nova | 06:45 | |
*** ig0r_ has quit IRC | 06:45 | |
openstackgerrit | Alex Xu proposed openstack/nova-specs: Remove extension from Nova V2.1 API https://review.openstack.org/202900 | 06:46 |
*** jyuso1 has quit IRC | 06:48 | |
*** ig0r_ has joined #openstack-nova | 06:48 | |
*** ijw has joined #openstack-nova | 06:49 | |
alex_xu | oomichi: gmann_ https://review.openstack.org/#/c/202900/1 :) | 06:50 |
openstackgerrit | Abhishek Kekane proposed openstack/nova-specs: Improve performance of UnShelve API https://review.openstack.org/135387 | 06:51 |
*** belmoreira has joined #openstack-nova | 06:51 | |
gmann_ | alex_xu: that is nice. will look over weekend :) | 06:52 |
alex_xu | gmann_: thanks :) | 06:52 |
*** cfriesen has quit IRC | 06:53 | |
oomichi | alex_xu: yeah, many people love it :) but the scope seems huge, will check it later carefully | 06:54 |
alex_xu | oomichi: yea, thanks | 06:54 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Allow for migration object to be passed to _move_claim https://review.openstack.org/199679 | 06:55 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: generalize claim code to be useful for other move actions https://review.openstack.org/197138 | 06:55 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: move filtering of mygration by type lower in the call stack https://review.openstack.org/199678 | 06:55 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: Make rebuild_instance RPC take an optional migration https://review.openstack.org/200485 | 06:55 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Define migration states and transitions and use when changing status https://review.openstack.org/197669 | 06:55 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Introduce a simple state machine module https://review.openstack.org/197668 | 06:55 |
*** lyanchih has joined #openstack-nova | 06:58 | |
*** sudipto has joined #openstack-nova | 07:00 | |
*** ssurana has quit IRC | 07:01 | |
*** sahid has joined #openstack-nova | 07:02 | |
*** sgordon has quit IRC | 07:03 | |
*** afazekas has joined #openstack-nova | 07:06 | |
*** vilobhmm has quit IRC | 07:07 | |
*** y_sawai has quit IRC | 07:07 | |
*** bradjones has quit IRC | 07:08 | |
alex_xu | oomichi: could you take the comment of this patch also https://review.openstack.org/#/c/197871/ | 07:08 |
*** markus_z has joined #openstack-nova | 07:10 | |
*** bradjones has joined #openstack-nova | 07:11 | |
*** bradjones has quit IRC | 07:11 | |
*** bradjones has joined #openstack-nova | 07:11 | |
*** boris-42 has quit IRC | 07:12 | |
*** doude has joined #openstack-nova | 07:12 | |
*** ijw has quit IRC | 07:15 | |
*** sgordon has joined #openstack-nova | 07:25 | |
*** achanda has quit IRC | 07:27 | |
*** alex_klimov has joined #openstack-nova | 07:28 | |
openstackgerrit | yalei wang proposed openstack/nova: Support unaddressed port https://review.openstack.org/202882 | 07:29 |
*** shyu has quit IRC | 07:36 | |
*** shyu has joined #openstack-nova | 07:37 | |
*** jlanoux has joined #openstack-nova | 07:37 | |
*** salv-orlando has joined #openstack-nova | 07:39 | |
*** lyanchih has quit IRC | 07:40 | |
*** achanda has joined #openstack-nova | 07:42 | |
openstackgerrit | Shiina, Hironori proposed openstack/nova: Add a compute RPC API to inject an NMI https://review.openstack.org/202605 | 07:42 |
*** jlanoux has quit IRC | 07:43 | |
*** jlanoux has joined #openstack-nova | 07:44 | |
*** oomichi has quit IRC | 07:47 | |
*** dannywil_ has quit IRC | 07:49 | |
*** dims_ has joined #openstack-nova | 07:49 | |
*** coolsvap is now known as coolsvap|afk | 07:51 | |
garyk | cores, daily beg time, please review the patch https://review.openstack.org/#/c/188789/8 | 07:53 |
*** dguitarbite has joined #openstack-nova | 07:55 | |
ndipanov | garyk, it's depending on another patch that also needs to merge | 07:55 |
ndipanov | and I don't think it's going to get much love either | 07:55 |
*** eglynn has quit IRC | 07:55 | |
*** dguitarbite is now known as Guest13513 | 07:55 | |
*** lyanchih has joined #openstack-nova | 07:55 | |
*** otter768 has joined #openstack-nova | 07:56 | |
garyk | ndipanov: ah, correct - https://review.openstack.org/#/c/198312/1 | 07:56 |
ndipanov | garyk, I can bet you a fiver that no one will look at that other than me ever | 07:56 |
*** dims_ has quit IRC | 07:56 | |
garyk | nothing is getting any love. | 07:56 |
*** kumar has joined #openstack-nova | 07:57 | |
garyk | ndipanov: what can i say. i have tried to raise issues about reviews but that just pisses people off…. | 07:57 |
ndipanov | the thing with this is - you need a lot of context. I can see this taking a core who has not worked on this bit of code upwards of an hour to review | 07:58 |
garyk | the core team is getting smaller and smaller and the amount of code landing is linear. in addition that bug fixes are also not landing and we are hitting endless bugs with out testing | 07:58 |
ndipanov | no one has that kind of time | 07:58 |
garyk | ndipanov: so if they are going to commit to the project then they need to make that time | 07:58 |
*** kaisers2 has quit IRC | 07:59 | |
garyk | seriously | 07:59 |
garyk | we are being paid by companies to do this :) | 07:59 |
ndipanov | that is true but I am also certain that most of "us" have at least 4 other things they need to deal with that they are also being paid to do | 08:00 |
*** otter768 has quit IRC | 08:00 | |
garyk | it is all a matter of priorities. | 08:00 |
garyk | i am unable to comment on the priorities of others as i am not wearing their shoes. | 08:00 |
ndipanov | I am wearing no shoes atm | 08:01 |
*** Jeffrey4l has quit IRC | 08:01 | |
garyk | but from the standpoint of the project things are a a standstill | 08:01 |
garyk | me too :) | 08:01 |
garyk | but it is my weekend and i am working | 08:01 |
ndipanov | ah yes | 08:01 |
*** romainh has joined #openstack-nova | 08:01 | |
ndipanov | I'll review that series later hopefully | 08:01 |
garyk | ndipanov: this is what life in nova feels like one moment you are up … https://vine.co/v/enhjKXxjPrT | 08:02 |
ndipanov | omg?! | 08:03 |
ndipanov | that poor kid | 08:03 |
garyk | yeah, you pass the gate and it all goes pear shape from then on... | 08:03 |
*** Marga_ has quit IRC | 08:04 | |
garyk | they should lock his parents away for posting that - i am sure it is going to be many years of therapy | 08:04 |
*** lucasagomes has joined #openstack-nova | 08:05 | |
*** annashen has quit IRC | 08:05 | |
ndipanov | haha | 08:06 |
*** yingjun has quit IRC | 08:10 | |
*** jistr has joined #openstack-nova | 08:15 | |
*** kmARC has joined #openstack-nova | 08:15 | |
*** shuquan has joined #openstack-nova | 08:16 | |
*** achanda has quit IRC | 08:16 | |
*** salv-orlando has quit IRC | 08:17 | |
*** eglynn has joined #openstack-nova | 08:17 | |
*** oro has joined #openstack-nova | 08:19 | |
*** yingjun has joined #openstack-nova | 08:19 | |
*** moshele has joined #openstack-nova | 08:22 | |
*** ijw has joined #openstack-nova | 08:24 | |
johnthetubaguy | garyk: you got a sec for this one: https://review.openstack.org/#/c/170641/9 | 08:26 |
johnthetubaguy | garyk: its not got a green CI run | 08:26 |
johnthetubaguy | also, bit confused by the commit message, can you clarify that for me, I think the code should be fine though, but would feel better with a green CI run | 08:28 |
*** yingjun has quit IRC | 08:29 | |
*** yingjun has joined #openstack-nova | 08:30 | |
*** yassine has joined #openstack-nova | 08:31 | |
mdbooth | garyk: That vine is awesome | 08:31 |
* tonyb just gets internal error 500 :( | 08:32 | |
sahid | ndipanov: hi, something i do not understand here http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/hardware.py#n732 | 08:33 |
sahid | why and who can we have limit_cell=None ? | 08:33 |
sahid | s/who/how | 08:33 |
*** armax has quit IRC | 08:33 | |
sahid | i mean we should always have limit_cell defined | 08:33 |
ndipanov | sahid, well | 08:33 |
ndipanov | that's a very good question | 08:33 |
*** shuquan has quit IRC | 08:34 | |
*** shuquan_ has joined #openstack-nova | 08:34 | |
ndipanov | forcing a host means it will not go thorugh filters | 08:34 |
ndipanov | which means it'll be None | 08:34 |
ndipanov | bauzas, ^ | 08:34 |
openstackgerrit | Shiina, Hironori proposed openstack/nova: Add a Nova API to inject an NMI https://review.openstack.org/202617 | 08:34 |
ndipanov | it's wrong | 08:34 |
*** yingjun has quit IRC | 08:34 | |
ndipanov | and we should probably fix that | 08:34 |
ndipanov | but at the moment it is like that | 08:34 |
* mdbooth larts python 3 | 08:35 | |
*** abhishekk has joined #openstack-nova | 08:36 | |
sahid | ndipanov: what about to have ram/cpu_allocation_ratio to 1 if limit_cell is not set? | 08:36 |
openstackgerrit | Qin Zhao proposed openstack/nova: Add hacking check for greenthread.spawn() and eventlet.spawn() https://review.openstack.org/195713 | 08:36 |
mdbooth | Hmm, here's an interesting thing | 08:37 |
*** derekh has joined #openstack-nova | 08:37 | |
mdbooth | It turns out python3 renamed iteritems for some retarded reason | 08:37 |
ndipanov | sahid, well that's not good either is it - that would fail otherwise potentially valid requests on the claim | 08:37 |
*** oomichi has joined #openstack-nova | 08:37 | |
ndipanov | mdbooth, yes that's a well known fact | 08:37 |
mdbooth | This causes a python 34 failure in the gate | 08:37 |
ndipanov | items does what iteritms used to | 08:37 |
*** pixelbeat_ has joined #openstack-nova | 08:38 | |
mdbooth | However, _exact_instance_filter uses iteritens | 08:38 |
ndipanov | that's basically what people have been fixing | 08:38 |
mdbooth | Suggesting that it has no unit test coverage | 08:38 |
ndipanov | mostly with py3 patches | 08:38 |
*** eglynn has quit IRC | 08:38 | |
ndipanov | you need to use six | 08:38 |
ndipanov | .iteritems | 08:38 |
mdbooth | ndipanov: Got that (python 3 is still a stupid idea). The interesting thing was the lack of unit test failures. | 08:39 |
mdbooth | Another example of python code which is obviously 'syntactically' incorrect, but doesn't actually fail until you run it | 08:41 |
*** markvoelker_ has quit IRC | 08:42 | |
*** lpetrut has joined #openstack-nova | 08:42 | |
*** lpetrut has quit IRC | 08:43 | |
*** ociuhandu has joined #openstack-nova | 08:43 | |
*** kumar has quit IRC | 08:43 | |
mdbooth | Is there a reason we don't tend to pass additional context in exceptions, except for ec2 exceptions? | 08:45 |
*** tpeoples has quit IRC | 08:45 | |
*** shuquan has joined #openstack-nova | 08:45 | |
*** shuquan_ has quit IRC | 08:45 | |
mdbooth | I've ensured that InstanceUpdateConflict contains both expected and actual values, which should be usable in calling code | 08:46 |
mdbooth | However, they're stuffed into exc.kwargs, instead of fields of the class | 08:46 |
openstackgerrit | Matthew Booth proposed openstack/nova: Implement compare-and-swap for instance update https://review.openstack.org/202593 | 08:47 |
*** bfic has joined #openstack-nova | 08:48 | |
lyanchih | Why nova will allow users attach volume to or detach volume from paused instance? | 08:49 |
johnthetubaguy | garyk: can I ask you questions about the NSXv stuff, getting a bit confused | 08:49 |
openstackgerrit | Matthew Booth proposed openstack/nova: Fix un-sixed use of iteritems in _exact_instance_filter https://review.openstack.org/202927 | 08:50 |
*** haypo has joined #openstack-nova | 08:52 | |
*** coolsvap|afk is now known as coolsvap | 08:54 | |
nagyz_ | ndipanov, how come you're online 24/7? are you a robot? :P | 08:54 |
*** yingjun has joined #openstack-nova | 08:54 | |
nagyz_ | johnthetubaguy, if it's a general NSX question, shoot, I might know the answer | 08:55 |
*** markus_z has quit IRC | 08:56 | |
johnthetubaguy | nagyz_: cool, looking at this patch (gets link) | 08:56 |
johnthetubaguy | nagyz_: https://review.openstack.org/#/c/147126/17 | 08:56 |
*** ociuhandu has quit IRC | 08:56 | |
johnthetubaguy | nagyz_: I am curious what it fails when the vnic is not updated, and in what cases the update is actually required | 08:57 |
*** markvoelker has joined #openstack-nova | 08:57 | |
johnthetubaguy | s/it// | 08:57 |
ndipanov | nagyz_, it's 9:57 AM here - that's human time | 08:57 |
*** lpetrut has joined #openstack-nova | 09:00 | |
*** lpetrut has quit IRC | 09:00 | |
*** kumar has joined #openstack-nova | 09:00 | |
*** markvoelker has quit IRC | 09:02 | |
*** promulo__ has quit IRC | 09:02 | |
*** promulo_ has joined #openstack-nova | 09:02 | |
*** deepakcs has quit IRC | 09:04 | |
*** danpb has joined #openstack-nova | 09:06 | |
ndipanov | so johnthetubaguy this http://docs.openstack.org/infra/manual/developers.html#peer-review | 09:06 |
ndipanov | that's absolutely the worst guide to reviewing known to man | 09:06 |
ndipanov | :) | 09:06 |
*** eglynn has joined #openstack-nova | 09:06 | |
johnthetubaguy | ndipanov: its just a starting point right, thats cross project | 09:06 |
*** aix has joined #openstack-nova | 09:07 | |
johnthetubaguy | ndipanov: I would say its way better than not having one, but yeah, lots of room for additions | 09:07 |
ndipanov | it's basically "how to be the nitpickiest reviewer in the world" | 09:07 |
ndipanov | it literally starts with something that is (should be) checked by a machine | 09:07 |
ndipanov | as point 1. | 09:08 |
*** Maike has joined #openstack-nova | 09:08 | |
*** bauzas is now known as bauwser | 09:08 | |
johnthetubaguy | ndipanov: yeah, I would prefer spotting of bugs over any of the things listed, but yeah | 09:08 |
ndipanov | so reviewers should know these things | 09:09 |
nagyz_ | johnthetubaguy, ah, so not an actual NSX question but an OpenStack <> NSXv integration question. then you'll have to wait for garyk :) | 09:09 |
ndipanov | but that's not what code review should be about | 09:09 |
ndipanov | or at least a good code review | 09:09 |
johnthetubaguy | nagyz_: ah, no worries, yeah, its more about the neutron API for the NSXv stuff, than anything else | 09:09 |
ndipanov | you do make a point of understanding the context first | 09:09 |
ndipanov | but we should ephasize that more imho | 09:10 |
johnthetubaguy | ndipanov: yep, I try to cover that more in the Nova one, but I am not happy with the wording yet, we can push that up | 09:10 |
ndipanov | cool | 09:10 |
*** lpetrut has joined #openstack-nova | 09:10 | |
johnthetubaguy | ndipanov: so I have reached a break in reviews, if you fancy a quick hangout now to catch up with these process things before the midcycle? | 09:10 |
johnthetubaguy | ndipanov: I can PM you a room, if that helps | 09:11 |
*** moshele has quit IRC | 09:11 | |
*** markvoelker has joined #openstack-nova | 09:12 | |
lifeless | ndipanov: send in patches to that manual :) | 09:13 |
*** markus_z has joined #openstack-nova | 09:13 | |
ndipanov | lifeless, well the manual is a good baseline of useful information but we link it in the context of a review tutorial | 09:14 |
bauwser | ndipanov: mmm ? | 09:15 |
*** dims_ has joined #openstack-nova | 09:15 | |
*** pczesno has joined #openstack-nova | 09:15 | |
bauwser | ndipanov: re: http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/hardware.py#n732 ? | 09:15 |
*** lpetrut has quit IRC | 09:16 | |
*** markvoelker has quit IRC | 09:17 | |
*** bfic has quit IRC | 09:18 | |
*** gszasz has joined #openstack-nova | 09:18 | |
*** liusheng has quit IRC | 09:18 | |
*** liusheng has joined #openstack-nova | 09:19 | |
*** dims_ has quit IRC | 09:20 | |
*** kumar has quit IRC | 09:21 | |
*** yamahata has quit IRC | 09:23 | |
*** tobe_ has quit IRC | 09:25 | |
*** markvoelker has joined #openstack-nova | 09:26 | |
andrearosa | wanghao: I have updated the bug description and title for the old --force-detach bug: https://bugs.launchpad.net/nova/+bug/1449221 Please have a look and add your comments if you have time. Thanks | 09:30 |
openstack | Launchpad bug 1449221 in OpenStack Compute (nova) "Nova doesn't allow to cleanup volumes stuck in 'attaching' or 'detaching' status" [Undecided,In progress] - Assigned to Andrea Rosa (andrea-rosa-m) | 09:30 |
*** markvoelker has quit IRC | 09:31 | |
*** pczesno has quit IRC | 09:31 | |
*** zzz_pczesno has joined #openstack-nova | 09:31 | |
*** ZZelle has quit IRC | 09:31 | |
*** zzz_pczesno is now known as pczesno | 09:31 | |
wanghao | andrearose: Sure | 09:31 |
*** yingjun has quit IRC | 09:33 | |
*** Kennan2 has joined #openstack-nova | 09:33 | |
*** Kennan has quit IRC | 09:33 | |
lifeless | ndipanov: yes, but if the advice can be improved, surely we should | 09:35 |
*** redbeard has quit IRC | 09:37 | |
bauwser | alex_xu: aloha :) | 09:37 |
wanghao | andrearose: I saw the bug description, there is a question: Will nova don't call the force-detach of cinder API if nova catch the exception which came from cinder? | 09:37 |
bauwser | alex_xu: seen your comment on https://review.openstack.org/#/c/197911/3/nova/objects/image_meta.py,cm but not sure I understand :) | 09:37 |
wanghao | andrearose: I think nova should do this operation. | 09:38 |
*** marzif_ has joined #openstack-nova | 09:39 | |
*** asselin_ has joined #openstack-nova | 09:40 | |
*** asselin has quit IRC | 09:40 | |
*** markvoelker has joined #openstack-nova | 09:41 | |
*** humble_ has quit IRC | 09:42 | |
*** gibi has quit IRC | 09:42 | |
*** gibi has joined #openstack-nova | 09:42 | |
andrearosa | wanghao: the idea is that nova shouldn't take any specific actions to react to a cinder failure. It is up to an operator decide how to fix the cinder side and decide to call the cinder -force directly to cinder | 09:44 |
andrearosa | the change is basically leave nova retry to detach a stuck volume and if the nova detach operations go well then nova has done its job and every other potential errors in cinder have to be addressed directly in cinder and not using nova | 09:45 |
*** markvoelker has quit IRC | 09:45 | |
*** bfic has joined #openstack-nova | 09:46 | |
andrearosa | wanghao: that was the outcome from the long discussion on the spec | 09:46 |
wanghao | andrearosa: em.. if cinder is in failure, even if nova call the force-detach ,it also can't make work. | 09:48 |
wanghao | andrearosa: I got this. | 09:48 |
*** romainh has quit IRC | 09:49 | |
wanghao | andrearosa: Well, nova just need to ensure BDM could be cleand up when volume stuck in detaching or attaching. I'm ok with this bug description. | 09:51 |
andrearosa | wanghao: thanks for taking time to review it. | 09:53 |
wanghao | andrearosa: you | 09:54 |
wanghao | andrearosa: you're welcome. | 09:54 |
*** bfic has quit IRC | 09:54 | |
*** toan has quit IRC | 09:55 | |
*** markvoelker has joined #openstack-nova | 09:55 | |
wanghao | andrearosa: About this "Nova will delete the BDM record only if the call to cinder "terminate_connection" will success." If cinder is in failure, this API may be not successful. | 09:56 |
*** toan has joined #openstack-nova | 09:56 | |
wanghao | andrearosa: It's a synchronization API in cinder. | 09:56 |
*** otter768 has joined #openstack-nova | 09:56 | |
*** jyuso1 has joined #openstack-nova | 09:57 | |
*** shuquan has quit IRC | 09:57 | |
andrearosa | wanghao: yes you are right but we can't remove BDM until we have terminated the connection otherwise the volume could show back up. | 09:58 |
*** liusheng has quit IRC | 09:59 | |
andrearosa | so if the terminate_connection fails because cinder is down we leave the situation as it is in nova | 09:59 |
*** markvoelker has quit IRC | 10:00 | |
andrearosa | but when the cider is up again re-detaching the volume will clean-up the nova DB | 10:00 |
*** jichen has joined #openstack-nova | 10:01 | |
*** bfic has joined #openstack-nova | 10:01 | |
*** sudipto has quit IRC | 10:01 | |
*** otter768 has quit IRC | 10:01 | |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'hw_cpu_threads_policy' image metadata prop https://review.openstack.org/202647 | 10:03 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'hw:cpu_threads_policy=separate' scheduling https://review.openstack.org/202652 | 10:03 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Make use of 'InstanceNUMACell.cpu_policy' field https://review.openstack.org/202653 | 10:03 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: trivial: Make use of 'CPUAllocation' enum values https://review.openstack.org/202654 | 10:03 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'hw:cpu_threads_policy=isolate' scheduling https://review.openstack.org/202655 | 10:03 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'cpu_policy' and 'cpu_threads_policy' fields https://review.openstack.org/202648 | 10:03 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'hw:cpu_threads_policy=avoid' filtering https://review.openstack.org/202649 | 10:03 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: trivial: Add some logs to 'numa_topology_filter' https://review.openstack.org/202650 | 10:03 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'hw:cpu_threads_policy=require' scheduling https://review.openstack.org/202651 | 10:03 |
wanghao | andrearosa: If in this situation, we also can use force-detach API of cinder to terminated connection when cinder is up. | 10:03 |
andrearosa | wanghao: that won't cleanup the nova DB | 10:04 |
*** bfic has quit IRC | 10:05 | |
*** dims_ has joined #openstack-nova | 10:05 | |
andrearosa | we still need to call bdm.destroy() in nova | 10:05 |
wanghao | andrearosa: I mean Nova clean up BDM first no matter the terminated_connection exception. And then user call force-detach in cinder to finish the terminated_conection. | 10:05 |
*** shyu has quit IRC | 10:07 | |
*** shyu has joined #openstack-nova | 10:07 | |
andrearosa | wanghao: I think we can't, let me find the comment where that point was discussed | 10:07 |
*** deepakcs has joined #openstack-nova | 10:07 | |
*** markvoelker has joined #openstack-nova | 10:07 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Show 'locked_by' information in server Show & List Detail https://review.openstack.org/202391 | 10:08 |
*** wverdugo500 has quit IRC | 10:08 | |
andrearosa | wanghao: please have a look at the comment that hemnafk add here https://review.openstack.org/#/c/84048/48/specs/liberty/approved/add-force-detach-to-nova.rst | 10:10 |
*** markvoelker has quit IRC | 10:12 | |
andrearosa | wanghao: my reading is that we can safetly remove the DBM record only when cinder have unexported the volume to the host and that happens when we call the terminate_connection | 10:12 |
openstackgerrit | Qin Zhao proposed openstack/nova: Refuse to delete compute service if host is in host aggregate https://review.openstack.org/197648 | 10:14 |
wanghao | andrearosa: yeah, I remember this, my response is that we will call force-detach in cinder side to make sure unexported volume. | 10:14 |
*** IanGovett has joined #openstack-nova | 10:15 | |
garyk | johnthetubaguy: nagyz_: i am around | 10:15 |
andrearosa | wanghao: then we are exposed to race conditions, if we get rid of BDM then we call the force-detach and cinder is down we are in a bad situation. | 10:17 |
wanghao | andrearosa: you're right. It will make thing worse. | 10:18 |
*** amotoki has joined #openstack-nova | 10:18 | |
andrearosa | wanghao: I am wonder if we should put this disucssion on the bug and ask someone from cinder to chime in, what do you think? | 10:18 |
wanghao | andrearose: Great. | 10:19 |
*** jasondotstar has joined #openstack-nova | 10:21 | |
openstackgerrit | Eli Qiao proposed openstack/nova: BDM: Stop booting if a blank volume as boot device https://review.openstack.org/180457 | 10:21 |
*** markvoelker has joined #openstack-nova | 10:22 | |
*** shyu has quit IRC | 10:27 | |
wanghao | andrearose: I have added a comment about what we discussed. You can add your opinion on this. | 10:27 |
andrearosa | wanghao: thanks | 10:28 |
*** amotoki_ has joined #openstack-nova | 10:28 | |
wanghao | andrearose: :) | 10:28 |
*** mleroy has joined #openstack-nova | 10:30 | |
johnthetubaguy | garyk: hey, sorry, on a call, about to finish | 10:30 |
*** amotoki has quit IRC | 10:31 | |
johnthetubaguy | garyk: I added comments in the code review basically | 10:31 |
johnthetubaguy | garyk: just wondering about how it works | 10:31 |
*** openstackgerrit has quit IRC | 10:31 | |
*** markvoelker has quit IRC | 10:32 | |
*** openstackgerrit has joined #openstack-nova | 10:32 | |
gmann_ | mtreinish: clarkb : multinode job sometimes fails for live migration too. | 10:37 |
gmann_ | mtreinish: clarkb - http://logs.openstack.org/91/202391/5/check/gate-tempest-dsvm-multinode-full/f838b41/logs/testr_results.html.gz | 10:37 |
*** markvoelker has joined #openstack-nova | 10:37 | |
*** danpb has left #openstack-nova | 10:37 | |
mdbooth | So, if I fix a bug in a unit test, do I have to submit a unit test to ensure that the unit test isn't subsequently re-broken? | 10:38 |
lifeless | I'd say that depends on the nature of the bug | 10:38 |
*** danpb has joined #openstack-nova | 10:38 | |
gmann_ | mtreinish: clarkb : migration started for host "devstack-trusty-2-node-hpcloud-b3-3757707" but after migration finish, server has host "devstack-trusty-2-node-hpcloud-b3-3757707-20386" | 10:38 |
mdbooth | We need to go deeper | 10:38 |
gmann_ | mtreinish: clarkb : is this known one or whats wrong? | 10:38 |
lifeless | mdbooth: wait until I get you writing on the tests for the testing tools tests | 10:38 |
lifeless | the dream gets unstable | 10:39 |
*** lsmola has joined #openstack-nova | 10:40 | |
*** RuiChen has quit IRC | 10:40 | |
*** thorst has joined #openstack-nova | 10:40 | |
*** aix has quit IRC | 10:41 | |
*** markvoelker has quit IRC | 10:42 | |
openstackgerrit | Matthew Booth proposed openstack/nova: Fix libguestfs failure in test_can_resize_need_fs_type_specified https://review.openstack.org/202973 | 10:44 |
mdbooth | lifeless: I'm not submitting a unit test for that ^^^ :P | 10:44 |
*** aix has joined #openstack-nova | 10:45 | |
*** thorst has quit IRC | 10:45 | |
lifeless | mdbooth: so, what I think would be nice there - and no, not asking you to do it - would be to have two variations of all the tests that exercise the guestfs influenced code path (generated dynamically) | 10:47 |
lifeless | mdbooth: and have one set skip() automatically if its not executing usefully | 10:47 |
lifeless | mdbooth: and we really need a test slave running the other half of the set | 10:47 |
lifeless | mdbooth: further, having some type validation in the method would be good too | 10:48 |
lifeless | duck typing is well and good, except when it goes awful :) | 10:48 |
mdbooth | duck typing is awful except when... | 10:48 |
mdbooth | it's just awful | 10:48 |
lifeless | heh | 10:48 |
* lifeless potters off to write some haskell | 10:49 | |
lifeless | now the question is, did I totally wedge openstack with mock 1.1.4 | 10:49 |
mdbooth | In all seriousness, I do like to tidy up Nova rather than produce fly-by minimal fixes to let me get my work done | 10:50 |
mdbooth | However, when I do this, they inevitably become the whole job | 10:50 |
mdbooth | Then they get rejected for idiotic bike-shedding reasons | 10:50 |
mdbooth | Then the actual job never gets done | 10:50 |
lifeless | I have little tolerance for that pain myself | 10:50 |
mdbooth | I get the impression that people just like it untidy round here | 10:51 |
lifeless | so hardly going to critique pavlov :) | 10:51 |
mdbooth | So, whatever | 10:51 |
lifeless | are you going to the midcycle ? | 10:51 |
mdbooth | No | 10:51 |
*** markvoelker has joined #openstack-nova | 10:51 | |
*** markvoelker has quit IRC | 10:56 | |
*** garyk has quit IRC | 10:57 | |
*** toan has quit IRC | 10:58 | |
*** toan has joined #openstack-nova | 10:59 | |
*** pedroalvarez has quit IRC | 10:59 | |
*** pedroalvarez has joined #openstack-nova | 11:00 | |
mdbooth | Oh, ffs | 11:01 |
mdbooth | AssertionError: Expected 'seek' to be called once. Called 0 times | 11:01 |
mdbooth | Can we *please* stop writing tests like that | 11:01 |
mdbooth | They're idiotic | 11:01 |
openstackgerrit | Anthony PERARD proposed openstack/nova: contrib: Add vif-bridge-nova-network script for Xen. https://review.openstack.org/201257 | 11:02 |
danpb | mdbooth: what, you mean you don't like tests that are essentially saying assertEqual(read("/path/to/file.py"), "copy of contents of /path/to/file.py") | 11:03 |
mdbooth | danpb: That would be it :/ | 11:03 |
rgerganov | mdbooth: next step is to compute MD5 checksum of the code under test and assert it is the correct one | 11:05 |
*** lyanchih has quit IRC | 11:05 | |
mdbooth | rgerganov: That's an excellent idea. You should propose it in Tokyo | 11:05 |
*** dims_ has quit IRC | 11:06 | |
mdbooth | It would have the advantage of provably preventing all regressions | 11:06 |
mdbooth | That has to be worth a lot | 11:06 |
*** markvoelker has joined #openstack-nova | 11:06 | |
rgerganov | right .. I am actually thinking of creating test generator | 11:06 |
mdbooth | Awesome | 11:06 |
rgerganov | 100% test coverage | 11:06 |
mdbooth | The holy grail! | 11:07 |
*** oomichi has quit IRC | 11:09 | |
*** markvoelker has quit IRC | 11:11 | |
*** bfic has joined #openstack-nova | 11:13 | |
*** coolsvap is now known as coolsvap|away | 11:14 | |
*** Guest13513 has quit IRC | 11:14 | |
*** bfic has quit IRC | 11:18 | |
*** markvoelker has joined #openstack-nova | 11:19 | |
*** lucasagomes is now known as lucas-hungry | 11:20 | |
*** bfic has joined #openstack-nova | 11:21 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 11:23 |
*** markvoelker has quit IRC | 11:24 | |
rgerganov | ndipanov: johnthetubaguy: do we need to update cells_api when adding new functionality or this is deprecated by CellsV2 ? | 11:28 |
alex_xu | bauwser: hey :) I may misunderstand, so using new name for image properties in the object, but we still need back-compatible with old properties name, is it right? | 11:31 |
*** markvoelker has joined #openstack-nova | 11:32 | |
*** alex_xu is now known as alexus | 11:34 | |
*** roldyx has joined #openstack-nova | 11:37 | |
roldyx | hi | 11:37 |
*** bfic has quit IRC | 11:38 | |
roldyx | I have a problem.. I am using ice-house and I have 2 AZ Abailability Zones | 11:38 |
roldyx | My problem is the following.. | 11:39 |
roldyx | Two Tenants: prod_int and prod_ext | 11:40 |
roldyx | two AZ: AZ_prod_int and AZ_prod_ext | 11:41 |
*** redbeard has joined #openstack-nova | 11:42 | |
roldyx | but.. when i execute 'nova avalability-zone-list', I obtain always AZ_prod_int and AZ_prod_ext | 11:43 |
mnaser | roldyx: this channel isnt for support, please check out #openstack for help | 11:43 |
roldyx | mnaser.. ups.. :( | 11:44 |
mnaser | np | 11:44 |
*** markvoelker has quit IRC | 11:44 | |
*** bfic has joined #openstack-nova | 11:46 | |
*** moshele has joined #openstack-nova | 11:48 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove/deprecate unused parts of the compute node object https://review.openstack.org/186757 | 11:48 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Make ComputeNode.service_id nullable to match db schema https://review.openstack.org/169284 | 11:48 |
*** dprince has joined #openstack-nova | 11:49 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Avoid querying for Service in resource tracker https://review.openstack.org/169288 | 11:50 |
*** roldyx has quit IRC | 11:51 | |
*** josecastroleon has joined #openstack-nova | 11:51 | |
*** deepthi has quit IRC | 11:53 | |
*** markvoelker has joined #openstack-nova | 11:55 | |
openstackgerrit | Deepak C Shetty (deepakcs) proposed openstack/nova: libvirt: Nova part of volume snapshot improvements https://review.openstack.org/172813 | 11:55 |
openstackgerrit | Deepak C Shetty (deepakcs) proposed openstack/nova: objects: Add support for OnlineSnapshotStatus object https://review.openstack.org/194538 | 11:55 |
bauwser | alexus: hey, there is no reason IMHO for that | 11:56 |
bauwser | alexus: just because it's not checked | 11:56 |
*** markus_z has quit IRC | 11:57 | |
alexus | bauwser: so we can free to change existed properties name? | 11:57 |
bauwser | oh oh, API meeting in 2 mins, and I can going there! | 11:57 |
mdbooth | Has anybody proposed a revert of change Id835d080a1ada52cbd3f24dad9bab5eeb2f29a54 yet? | 11:57 |
*** Jeffrey4l has joined #openstack-nova | 11:57 | |
alexus | bauwser: thanks :) | 11:57 |
mdbooth | It breaks python27 tests, so it's weird it could get in at all | 11:57 |
*** otter768 has joined #openstack-nova | 11:57 | |
bauwser | alexus: well, the legacy fields is needed for helping, but not really needed for something missed | 11:58 |
mdbooth | sdague: Incidentally, that change adds the following comment to tox.ini: | 11:58 |
mdbooth | + # TODO(sdague) this is a brute force work around for pip not respecting test-requirements.txt | 11:58 |
*** gmann has joined #openstack-nova | 11:58 | |
mdbooth | sdague: However, see https://review.openstack.org/#/c/200579/ | 11:58 |
mdbooth | Nova has intentionally broken tox in this regard :/ | 11:58 |
alexus | bauwser: ok, I think the key is "missed"...I need recheck the code | 11:58 |
*** gmann has quit IRC | 11:59 | |
*** gmann has joined #openstack-nova | 11:59 | |
*** lyanchih has joined #openstack-nova | 11:59 | |
alexus | nova api meeting in 1 min~ | 11:59 |
sdague | mdbooth: because it was the only way that anyone could ever land changes | 12:00 |
*** markvoelker has quit IRC | 12:00 | |
sdague | as the doc job was failing, if you can get that revert to pass, probably by rebasing on master, it's fine to change back | 12:00 |
mdbooth | sdague: See above for the reason I think it's required | 12:01 |
mdbooth | It's because we're breaking tox with: | 12:01 |
mdbooth | install_command = pip install -U --force-reinstall {opts} {packages} | 12:01 |
sdague | mdbooth: you are not listening to me | 12:01 |
*** amotoki_ has quit IRC | 12:02 | |
sdague | mdbooth: no, that used to work fine using the test-requirements.txt file | 12:02 |
*** otter768 has quit IRC | 12:02 | |
sdague | there was a pip change where that stopped being a thing | 12:02 |
sdague | and there might be a fix now | 12:02 |
mdbooth | Are you sure, or did it happen to work coincidentally because there wasn't an upstream package which broke it? | 12:02 |
mdbooth | Because that force update thing is evil | 12:03 |
sdague | nope, totally sure, because the break is about sphinx | 12:03 |
sdague | it really isn't | 12:03 |
sdague | not for tox, and we've had it a long time | 12:03 |
mdbooth | It breaks tox --sitepackages, for eg | 12:03 |
mdbooth | That command no longer does what you ask | 12:03 |
mdbooth | Because we then tell pip to go ahead and blow it all away anyway | 12:03 |
sdague | we've been doing that forever | 12:04 |
mdbooth | We've been doing it for a while | 12:04 |
sdague | anyway, if you want to make that patch work, please do | 12:04 |
sdague | there was half a day of working through that issue to get things working here so patches could land again | 12:04 |
mdbooth | I'm patching install_commands out of tox.ini downstream, for eg, because it produces non-deterministic behaviour | 12:04 |
sdague | right, do whatever you like downstream, for upstream we want to be taking new code | 12:05 |
sdague | and running in a venv | 12:05 |
sdague | that's been a core tenant for years | 12:05 |
*** mgoddard has joined #openstack-nova | 12:05 | |
*** nkrinner_afk is now known as nkrinner | 12:05 | |
*** moshele has quit IRC | 12:06 | |
*** lyanchih has quit IRC | 12:06 | |
*** jasondotstar has quit IRC | 12:06 | |
*** markvoelker has joined #openstack-nova | 12:09 | |
*** markvoelker has quit IRC | 12:13 | |
lifeless | sdague: whats this tox issue ? | 12:14 |
lifeless | sdague: [can I help?] | 12:14 |
sdague | lifeless: that sphinx thing we were debugging the other day | 12:14 |
lifeless | oh right | 12:14 |
sdague | where the venv wasn't respecting the sphinx pin | 12:14 |
lifeless | that was a pbr bug | 12:14 |
sdague | right, is that released now? | 12:14 |
lifeless | interacting with markers in mock's dependencies | 12:14 |
lifeless | yes. pbr 1.3 is good | 12:15 |
sdague | so we can revert it? | 12:15 |
sdague | ok, cool | 12:15 |
openstackgerrit | Sean Dague proposed openstack/nova: Don't force package upgrades when running tox https://review.openstack.org/200579 | 12:15 |
*** romainh has joined #openstack-nova | 12:15 | |
lifeless | sdague: the mock_open thing should be fixed for you in 1.1.4 | 12:16 |
*** markvoelker has joined #openstack-nova | 12:16 | |
lifeless | sdague: but of course that fix broke someone else. | 12:16 |
sdague | heh | 12:16 |
lifeless | sdague: https://github.com/testing-cabal/mock/issues/288 | 12:16 |
lifeless | I did love the report 'does not work'. | 12:17 |
*** ferest has joined #openstack-nova | 12:18 | |
sdague | heh | 12:19 |
*** markvoelker has quit IRC | 12:21 | |
*** lsmola has quit IRC | 12:21 | |
*** jasondotstar has joined #openstack-nova | 12:21 | |
*** ferest has quit IRC | 12:21 | |
*** baoli has joined #openstack-nova | 12:21 | |
*** lyanchih has joined #openstack-nova | 12:22 | |
*** lucas-hungry is now known as lucasagomes | 12:22 | |
*** lsmola has joined #openstack-nova | 12:23 | |
*** edmondsw has joined #openstack-nova | 12:23 | |
*** kylek3h has joined #openstack-nova | 12:24 | |
*** mmedvede_ has joined #openstack-nova | 12:24 | |
*** markvoelker has joined #openstack-nova | 12:24 | |
sdague | lifeless: did you ever look at what was happening here - https://review.openstack.org/#/c/200500/5/nova/tests/unit/virt/hyperv/test_vhdutils.py,cm ? | 12:24 |
sdague | we ended up just skipping that test | 12:25 |
*** dims_ has joined #openstack-nova | 12:25 | |
*** lpetrut has joined #openstack-nova | 12:28 | |
lifeless | sdague: I don't know. Check your bugs in mock upstream, if there isn't one matching, file it on bugs.python.org and link it from your skip | 12:29 |
lifeless | sdague: but | 12:29 |
*** aysyd has joined #openstack-nova | 12:30 | |
lifeless | sdague: that looks like the mock_open thing 1.1.4 fixes | 12:30 |
lifeless | sdague: so maybe try removing the skip to start with | 12:30 |
lifeless | sdague: orthogonally, thats where i'd use an expectedfailure rather than a skip, so you can tell if its fixed or not | 12:30 |
lifeless | night | 12:31 |
*** markvoelker has quit IRC | 12:32 | |
sdague | night | 12:33 |
*** thorst has joined #openstack-nova | 12:33 | |
*** deepakcs has quit IRC | 12:34 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Removing extension "OS-EXT-VIF-NET" from v2.1 extension-list https://review.openstack.org/198934 | 12:34 |
*** thorst has quit IRC | 12:35 | |
openstackgerrit | Michal Rostecki proposed openstack/nova: Dedicate aggregates for specific tenants https://review.openstack.org/195783 | 12:36 |
*** coolsvap|away is now known as coolsvap | 12:37 | |
*** markvoelker has joined #openstack-nova | 12:39 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova: Add MKS protocol for remote consoles https://review.openstack.org/199129 | 12:39 |
openstackgerrit | Radoslav Gerganov proposed openstack/nova: Add MKS console support https://review.openstack.org/203006 | 12:39 |
*** eharney has quit IRC | 12:41 | |
*** vladikr has joined #openstack-nova | 12:42 | |
*** markvoelker has quit IRC | 12:43 | |
*** lpetrut has quit IRC | 12:46 | |
pczesno | johnthetubaguy: hi, regarding : https://blueprints.launchpad.net/nova/+spec/virt-driver-cpu-thread-pinning | 12:46 |
*** abhishekk has quit IRC | 12:46 | |
johnthetubaguy | pczesno: hi | 12:46 |
pczesno | johnthetubaguy: the code was send yesterday, which is after the deadline | 12:46 |
pczesno | johnthetubaguy: can we get an approval again? | 12:47 |
johnthetubaguy | pczesno: it seems to have the unit tests failing, is that expected? | 12:47 |
openstackgerrit | Radoslav Gerganov proposed openstack/nova: VMware: add serial port device https://review.openstack.org/149203 | 12:47 |
pczesno | johnthetubaguy: nope, i need an hour or two to fix that | 12:48 |
johnthetubaguy | pczesno: it looks like you have not updated all the version numbers | 12:48 |
pczesno | johnthetubaguy: right | 12:48 |
johnthetubaguy | pczesno: so it doesn't look ready for review yet, so still doesn't meet the freeze requirements | 12:48 |
pczesno | johnthetubaguy: and if i would get it working today? | 12:49 |
johnthetubaguy | pczesno: OK, since you asked nicely, yes. Although do be aware its really really tight to get this merged now, lots of other stuff has already been through a cycle of reviews, etc :( | 12:50 |
pczesno | johnthetubaguy: thanks, i get that, will work with reviewer to make it happen | 12:50 |
*** eharney has joined #openstack-nova | 12:51 | |
johnthetubaguy | pczesno: so we do have another 80 or so blueprints currently under review and trying to get in, and no where near enough people doing reviews right now, but its still technically possible | 12:52 |
* johnthetubaguy is going to get some lunch now | 12:52 | |
*** markvoelker has joined #openstack-nova | 12:53 | |
*** scheuran has quit IRC | 12:54 | |
*** dims_ has quit IRC | 12:54 | |
*** nkrinner has quit IRC | 12:55 | |
bauwser | alexus: johnthetubaguy: sdague: I was thinking of https://docs.python.org/2/tutorial/modules.html#packages-in-multiple-directories by using the __path__ globals to provide an incremental way to change legacy_v2 stuff | 12:55 |
sdague | bauwser: incremental is really not worth it, lets just rip the bandaid off on this one | 12:56 |
sdague | it doesn't impact our users | 12:56 |
*** afaranha has joined #openstack-nova | 12:56 | |
alexus | it is already incremental way https://review.openstack.org/#/c/193725/ isn't move all the plugins, just move part of that | 12:57 |
bauwser | sdague: my biggest worries with https://review.openstack.org/#/c/193589/ is that it mixes both a package rename, a new WSGI resource and some refactoring | 12:58 |
*** markvoelker has quit IRC | 12:58 | |
afaranha | hello | 12:59 |
afaranha | does anyone knows if there is a bug in some tests in Nova? | 13:00 |
*** browne has joined #openstack-nova | 13:00 | |
afaranha | I just cloned the nova and run this test and I got fail nova.tests.unit.virt.hyperv.test_vhdutils.VHDUtilsTestCase.test_get_vhd_format_zero_length_file | 13:00 |
*** gmann has quit IRC | 13:00 | |
bauwser | afaranha: yeah, that's a CI issue | 13:01 |
lyanchih | Guys can you please help me review our patch https://review.openstack.org/#/c/202436/ | 13:01 |
bauwser | afaranha: I mean, our gate is broken | 13:02 |
sdague | bauwser: wait, it is? | 13:02 |
sdague | bauwser: is anyone working on that fix? | 13:02 |
bauwser | sdague: yup, just looking at it now | 13:02 |
sdague | so, probably another mock open issue | 13:02 |
bauwser | sdague: looking at logstash while I type | 13:03 |
*** edleafe is now known as figleaf | 13:03 | |
sdague | lifeless fixed one issue, but I think broke another case at the same time | 13:03 |
*** samuel-dmq has quit IRC | 13:04 | |
*** Murali has quit IRC | 13:04 | |
*** baoli has quit IRC | 13:04 | |
*** samueldmq has joined #openstack-nova | 13:04 | |
*** Maike has quit IRC | 13:05 | |
bauwser | sdague: http://logs.openstack.org/57/186757/13/check/gate-nova-python27/c75a463/console.html as an other example | 13:05 |
*** strictlyb has quit IRC | 13:05 | |
lyanchih | Hi, why nova allow users attach volume or detach volume from paused instance? I had test one issue, when yoou detach volume from paused instance, then attach any volume to same device name. Libvirt will throw exception. | 13:05 |
bauwser | sdague: I mean http://logs.openstack.org/57/186757/13/check/gate-nova-python27/c75a463/console.html#_2015-07-17_12_11_00_988 | 13:05 |
jroll | sdague: ironic is busted too, looking like https://github.com/testing-cabal/mock/commit/e9db0161fc11eceba189a0cc161deefce57529a8 | 13:05 |
*** markvoelker has joined #openstack-nova | 13:05 | |
afaranha | bauwser, do you now if the submitted patches will be frozen until this bug is fixed? | 13:05 |
jroll | I think the fix is s/return_value/return_value()/ | 13:05 |
bauwser | afaranha: I'm trying to see the number of occurrences to see if it's a transient issue | 13:06 |
jroll | (for things using mock_open().return_value) | 13:06 |
bauwser | call me stupid, but I'm unable to get a logstash pattern :/ | 13:06 |
afaranha | bauwser, thank you | 13:06 |
*** lyanchih has left #openstack-nova | 13:07 | |
*** markvoelker_ has joined #openstack-nova | 13:07 | |
*** lyanchih has joined #openstack-nova | 13:07 | |
alexus | bauwser: re: https://review.openstack.org/#/c/197911/ for now, we didn't use the requestspec obj yet. So image properties in request spec dict, and use 'hypervisor_version_requires' as properties name, after we change to obj, the original name won't work anymore | 13:08 |
*** bfic has quit IRC | 13:09 | |
bauwser | alexus: no because I'm hydrating correctly when needed :) | 13:09 |
*** markvoelker has quit IRC | 13:09 | |
bauwser | alexus: and the filter is later modified to call the correct field | 13:09 |
alexus | bauwser: but the old original property won't load into ImageMetaProps obj | 13:10 |
*** bnemec has joined #openstack-nova | 13:11 | |
*** jasondotstar has quit IRC | 13:11 | |
alexus | bauwser: you need load image properties into ImageMetaProps obj first. | 13:12 |
*** baoli has joined #openstack-nova | 13:12 | |
bauwser | alexus: double checking | 13:12 |
*** mdrabe has joined #openstack-nova | 13:13 | |
*** rdo has quit IRC | 13:13 | |
*** ivasev has joined #openstack-nova | 13:14 | |
*** baoli has quit IRC | 13:15 | |
*** rdo has joined #openstack-nova | 13:15 | |
bauwser | alexus: okay, sounds like I owe you something | 13:16 |
alexus | bauwser: :) | 13:16 |
bauwser | alexus: it will be your fault when I'll flood that channel | 13:16 |
*** rajesht has quit IRC | 13:17 | |
*** doude has quit IRC | 13:18 | |
*** xyang1 has joined #openstack-nova | 13:18 | |
*** doude has joined #openstack-nova | 13:19 | |
openstackgerrit | lyanchih proposed openstack/nova: nova secgroup-list-rules shows empty table with neutron https://review.openstack.org/203022 | 13:20 |
*** Piet has quit IRC | 13:21 | |
* alexus reboot again... | 13:21 | |
kashyap | mdbooth: Randomly stumbled on this, on your libguestfs test fix patch -- http://logs.openstack.org/73/202973/1/check/gate-nova-python27/665d6f4/console.html#_2015-07-17_11_42_35_478 | 13:23 |
mdbooth | kashyap: I bisected that earlier, btw | 13:23 |
kashyap | Reading a bit of scroll, seems like you already are on it. | 13:23 |
mdbooth | It's broken in master by the looks of it | 13:24 |
kashyap | mdbooth: Ah, okay. Interesting, learnt something new reading that. | 13:24 |
*** jecarey has joined #openstack-nova | 13:24 | |
mdbooth | It was originally broken by https://review.openstack.org/#/c/200500/ | 13:24 |
mdbooth | But that adds a skip for the affected test | 13:24 |
mdbooth | So I wonder if it was subsequently removed | 13:24 |
*** mriedem has joined #openstack-nova | 13:24 | |
* mdbooth hasn't got there, yet | 13:24 | |
kashyap | mdbooth: A silly question - why are there multiple py27 logs? | 13:24 |
kashyap | Thought it should be one for a single run, no? - http://logs.openstack.org/73/202973/1/check/gate-nova-python27/665d6f4/tox/ | 13:24 |
mdbooth | -0 is installation of the virtualenv | 13:24 |
mdbooth | -1 is installation of deps | 13:25 |
mdbooth | -2 is installation of the application under test | 13:25 |
kashyap | Ah, thanks for the education. | 13:25 |
*** baoli has joined #openstack-nova | 13:26 | |
*** cpschult has joined #openstack-nova | 13:28 | |
mdbooth | dansmith mriedem sdague: This seems to have caused a gate regression: https://review.openstack.org/#/c/200500/ | 13:28 |
mdbooth | Example: http://logs.openstack.org/73/202973/1/check/gate-nova-python27/665d6f4/console.html#_2015-07-17_11_42_35_478 | 13:28 |
mdbooth | The above patch includes 1 skip | 13:28 |
dansmith | it was to fix a gate regression, IIRC | 13:28 |
mdbooth | But I'm hitting the same issue in other tests | 13:28 |
mdbooth | It's weird that it's only manifesting 7 days after it was merged | 13:29 |
dansmith | well, I saw that bug locally | 13:29 |
mriedem | mdbooth: are the other tests using mock_open? | 13:29 |
mdbooth | pip changing packages under our noses? | 13:29 |
dansmith | rebuilding my .tox helped | 13:29 |
mdbooth | mriedem: Yes | 13:29 |
mriedem | mdbooth: then it's some weirdness with mock_open | 13:29 |
jroll | so, mock_open was changed in the mock release from this morning | 13:29 |
mdbooth | dansmith: I do that lots. Above is a failure on jenkins. | 13:29 |
dansmith | jroll: again? | 13:29 |
jroll | https://github.com/testing-cabal/mock/commit/e9db0161fc11eceba189a0cc161deefce57529a8 | 13:29 |
jroll | yep | 13:29 |
dansmith | ffs | 13:29 |
jroll | ironic is busted too | 13:29 |
jroll | \o/ | 13:29 |
bauwser | mdbooth: I was unable to find a correct logstash pattern for it :/ | 13:30 |
*** dansmith is now known as superdan | 13:30 | |
jroll | dansmith: I think it broke things accessing mock_open().return_value directly | 13:30 |
mriedem | bauwser: fingerprint is going to suck since it's going to depend on the test case that's failing, randomly, with mock_open | 13:31 |
mriedem | PLUS | 13:31 |
mriedem | logstash indexing is behind by 13 hours | 13:31 |
bauwser | mriedem: mmm, not really | 13:31 |
bauwser | mriedem: AH ! | 13:31 |
mriedem | so logstash isn't going to show anything from today so far | 13:31 |
* bauwser was thinking he was having fat fingers | 13:31 | |
*** Jeffrey4l has quit IRC | 13:31 | |
mriedem | jroll: do you know if there is an LP bug open? | 13:31 |
mdbooth | Anyway, it looks to me as though all python27 jobs will fail due to the above | 13:32 |
jroll | mriedem: I opened https://bugs.launchpad.net/ironic/+bug/1475653 | 13:32 |
openstack | Launchpad bug 1475653 in Ironic "Gate broken with mock 1.1.4 release" [Critical,Confirmed] | 13:32 |
jroll | idk about nova though | 13:32 |
bauwser | mriedem: I spotted the issue since 1 hour app. | 13:32 |
bauwser | mriedem: no bugs founds | 13:32 |
bauwser | mriedem: except https://bugs.launchpad.net/nova/+bug/1473401 which could be related | 13:33 |
openstack | Launchpad bug 1473401 in OpenStack Compute (nova) "gate-nova-python27 and gate-nova-docs failing for mock 1.1.0" [Critical,Fix committed] - Assigned to Sean Dague (sdague) | 13:33 |
mriedem | bauwser: that's the old one from last week | 13:33 |
mriedem | for mock 1.1.0 | 13:33 |
bauwser | mriedem: yup, I know | 13:33 |
mriedem | next week there will be a bug for mock 1.1.5 breaking the gate | 13:34 |
*** jang3 has joined #openstack-nova | 13:34 | |
*** jang has quit IRC | 13:34 | |
bauwser | \o/ | 13:34 |
*** READ10 has joined #openstack-nova | 13:34 | |
mdbooth | Would we consider *not* just taking whatever our upstream wants to break? | 13:34 |
*** markvoelker_ has quit IRC | 13:34 | |
bauwser | mdbooth: the question is why the regression passed the gate ? | 13:34 |
mriedem | mdbooth: well we'd have to block mock >= 1.1.4 | 13:34 |
mriedem | bauwser: it's not tested in the gate | 13:34 |
mriedem | it's the forked mock library in github | 13:35 |
bauwser | mriedem: I see | 13:35 |
mdbooth | bauwser: Because mock wasn't broken at the time it was introduced, I assume | 13:35 |
mdbooth | So we broke because pypi was updated | 13:35 |
bauwser | gotcha | 13:35 |
mriedem | well, guys, it's a library | 13:35 |
mriedem | it breaks us for the same reason that oslo releases often break us | 13:35 |
mriedem | anyway | 13:36 |
*** rgerganov has quit IRC | 13:36 | |
bauwser | okay, I suppose I should write a change ? :) | 13:36 |
*** raph_ has joined #openstack-nova | 13:36 | |
mriedem | the other day someone was saying that mock_open behaved differently if you used it as a context manager, i have no idea if that would fix this | 13:36 |
mdbooth | If mock is being unstable right now, could we add a version ceiling until it's working again? | 13:36 |
*** jang3 has quit IRC | 13:36 | |
bauwser | mriedem: opening the bug | 13:37 |
mriedem | yeah let's get the bug open first, | 13:37 |
mriedem | w/o logstash it's hard to know who else is broken, so i'm asking in some other channels | 13:38 |
*** tcammann has quit IRC | 13:38 | |
mriedem | if it were pervasive we could think about a cap | 13:38 |
*** anteaya has quit IRC | 13:38 | |
mriedem | mdbooth: btw, is this random or completely repeatable locally? | 13:39 |
*** ctrath has joined #openstack-nova | 13:39 | |
*** jang1 has joined #openstack-nova | 13:39 | |
mdbooth | Also fails locally for me | 13:39 |
mdbooth | I used git bisect to blame the above patch | 13:39 |
mdbooth | I can play with mock versions if you'd like | 13:39 |
bauwser | mriedem: https://bugs.launchpad.net/nova/+bug/1475661 | 13:39 |
openstack | Launchpad bug 1475661 in OpenStack Compute (nova) "py27 jobs failing due to mock_open" [Critical,Confirmed] | 13:39 |
mriedem | well as superdan said that was to fix for busted mock 1.1.0 | 13:39 |
*** tcammann has joined #openstack-nova | 13:40 | |
*** ijuwang has joined #openstack-nova | 13:40 | |
mdbooth | Sounds like a cap at <1.1.0 might be in order | 13:40 |
bauwser | testing locally as well - not sure a bisect can help | 13:40 |
mriedem | the cap would be <1.1.4 | 13:40 |
raph_ | hello everybody. https://bugs.launchpad.net/nova/+bug/1475652 -> can somebody confirm or invalidate ? | 13:41 |
openstack | Launchpad bug 1475652 in OpenStack Compute (nova) "libvirt, rbd imagebackend, disk.rescue not deleted when unrescued" [Undecided,New] | 13:41 |
mriedem | jbernard: ^ | 13:41 |
mdbooth | mriedem: Well, the above patch introduced a skip | 13:41 |
*** zzzeek has joined #openstack-nova | 13:41 | |
mdbooth | Which isn't great | 13:41 |
*** anteaya has joined #openstack-nova | 13:42 | |
mriedem | not great no but neither is completely blocking the entire project | 13:43 |
*** hakimo has joined #openstack-nova | 13:43 | |
*** hakimo_ has quit IRC | 13:43 | |
jroll | this mock change completely removes the ability to set a side effect for write() on a mock file, best I can tell | 13:43 |
jroll | that's super awesome | 13:43 |
mriedem | yeah | 13:44 |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/virt/hyperv/test_vhdutils.py#n268 | 13:44 |
mriedem | f it, let's just go back to mox :) | 13:44 |
jroll | oh god no | 13:44 |
mriedem | although i suspect mox3 has some issues too since we forked it | 13:44 |
mdbooth | Well, mock isn't a runtime requirement of nova. It's not critical. We don't have to rush to take the latest release if it's currently broken. | 13:44 |
jroll | lol | 13:44 |
bauwser | mriedem: http://status.openstack.org/zuul/ shows that all nova changes are impacted AFAICS | 13:44 |
mriedem | mdbooth: it's critical in that we can't pass anything through the gate | 13:45 |
mdbooth | mriedem: Right. If we roll back to <1.1.0 we can do that again. | 13:45 |
openstackgerrit | Stefan Amann proposed openstack/nova: Perform port_rescan on s390x platforms https://review.openstack.org/203035 | 13:45 |
mriedem | <1.1.4 | 13:45 |
*** dims_ has joined #openstack-nova | 13:45 | |
mdbooth | If we roll back to 1.1.0 we can take the skip out | 13:45 |
mriedem | i do'nt care about the skip | 13:45 |
mdbooth | Sorry, <1.1.0 | 13:45 |
mdbooth | Ok, but it's related | 13:45 |
mdbooth | Sounds like we're about to add more skips | 13:45 |
mriedem | so is there anything in the docs about how this is supposed to be used but we're not using it properly? | 13:46 |
mriedem | https://docs.python.org/dev/library/unittest.mock.html#mock-open | 13:46 |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/virt/hyperv/test_vhdutils.py#n268 | 13:46 |
*** diogogmt has quit IRC | 13:47 | |
*** leseb_ has left #openstack-nova | 13:48 | |
*** markvoelker has joined #openstack-nova | 13:49 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Added server tags support in nova-api https://review.openstack.org/128940 | 13:50 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Fixed incorrect behaviour of method _check_instance_exists https://review.openstack.org/203037 | 13:50 |
*** mwagner_lap has joined #openstack-nova | 13:50 | |
*** raildo1 is now known as raildo | 13:51 | |
*** dave-mccowan has joined #openstack-nova | 13:54 | |
*** markvoelker has quit IRC | 13:54 | |
*** artom has joined #openstack-nova | 13:55 | |
*** artom has quit IRC | 13:56 | |
*** doude has quit IRC | 13:56 | |
*** artom has joined #openstack-nova | 13:56 | |
mdbooth | So yes, the return value of the MagicMock() returned by mock_open is not as expected | 13:56 |
*** jdandrea has joined #openstack-nova | 13:56 | |
mdbooth | (Pdb) mock_open.return_value | 13:56 |
mdbooth | <MagicMock name='open()' id='140548935772688'> | 13:56 |
mdbooth | (Pdb) mock_open() | 13:56 |
mdbooth | <MagicMock name='open()' spec='file' id='140548935772752'> | 13:56 |
mdbooth | (Pdb) mock_open() | 13:56 |
mdbooth | <MagicMock name='open()' spec='file' id='140548933406608'> | 13:56 |
sdague | yeh, lifeless was trying to fix the other mock_open issue | 13:57 |
sdague | but apparently this broke a new one | 13:57 |
mdbooth | The above isn't the behaviour I expect from a MagicMock | 13:57 |
mdbooth | It looks like mock is broken to me | 13:57 |
mriedem | here https://github.com/testing-cabal/mock/issues/288 | 13:57 |
mriedem | jroll: ^ | 13:57 |
mriedem | i'm going to push a cap to g-r | 13:58 |
mriedem | which is what lifeless suggests in that issue | 13:58 |
*** otter768 has joined #openstack-nova | 13:58 | |
jroll | so I think this is intentional | 13:59 |
jroll | and not just a fallout of trying to fix the other thing | 13:59 |
* jroll checks if behavior in python3 matches | 13:59 | |
*** markvoelker has joined #openstack-nova | 13:59 | |
jroll | mdbooth: mriedem: yeah, this appears to match 3.4.0, at least | 14:00 |
jroll | and matching python3 is the goal here | 14:00 |
*** gyee has joined #openstack-nova | 14:00 | |
mdbooth | jroll: So the new behaviour is the intended behaviour going forward? | 14:00 |
*** shuquan has joined #openstack-nova | 14:01 | |
jroll | mdbooth: it appears so, or at least you're going to be told it's a bug in python, not in mock | 14:01 |
mriedem | sdague: do we cap mock <1.1.4 or just block it !=1.1.4? | 14:01 |
jroll | python3, that is | 14:01 |
*** otter768 has quit IRC | 14:03 | |
sdague | mriedem: != | 14:04 |
sdague | and ask lifeless to *please* run nova unit tests with new mock releases, because we're going to expose compat issues like this | 14:04 |
jroll | that doesn't help other projects :/ | 14:06 |
*** eharney has quit IRC | 14:06 | |
*** shuquan has quit IRC | 14:06 | |
jroll | mriedem: if you're curious on the fix, this is the fix for ironic https://review.openstack.org/#/c/203042/ | 14:06 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'hw_cpu_threads_policy' to ImageMetaProps https://review.openstack.org/202647 | 14:06 |
jroll | should be similar things for broken nova tests | 14:06 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'hw:cpu_threads_policy=separate' scheduling https://review.openstack.org/202652 | 14:06 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Make use of 'InstanceNUMACell.cpu_policy' field https://review.openstack.org/202653 | 14:06 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: trivial: Make use of 'CPUAllocation' enum values https://review.openstack.org/202654 | 14:06 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'hw:cpu_threads_policy=isolate' scheduling https://review.openstack.org/202655 | 14:06 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'cpu_policy' and 'cpu_threads_policy' fields https://review.openstack.org/202648 | 14:06 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'hw:cpu_threads_policy=avoid' filtering https://review.openstack.org/202649 | 14:06 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: trivial: Add some logs to 'numa_topology_filter' https://review.openstack.org/202650 | 14:06 |
openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Add 'hw:cpu_threads_policy=require' scheduling https://review.openstack.org/202651 | 14:06 |
*** markvoelker has quit IRC | 14:07 | |
*** dboik has joined #openstack-nova | 14:07 | |
mriedem | jroll: boy i don't know, i feel like working around the regression in 1.1.4 will just lead to a failure when 1.1.5 tries to fix that regression | 14:08 |
jroll | mriedem: reading that bug report, it doesn't seem like lifeless believes it's a regression | 14:08 |
*** Piet has joined #openstack-nova | 14:09 | |
mriedem | "but something isn't quite linked up properly there.I think this should be filed upstream at https://bugs.python.org/" | 14:09 |
jroll | mriedem: and then what happens when python folks say "this isn't a bug" :P | 14:09 |
*** cinerama has quit IRC | 14:09 | |
mriedem | yeah | 14:09 |
mriedem | idk | 14:09 |
mriedem | but it's friday and lifeless isn't around | 14:09 |
mriedem | so i'd rather not guess | 14:09 |
*** jecarey has quit IRC | 14:09 | |
jroll | urgh | 14:10 |
mriedem | for nova i'd prefer to block 1.1.4 and then hash it out with lifeless next week since he's going to be at the nova meetup | 14:10 |
mriedem | ironic can do whatever it wants to do | 14:10 |
*** jecarey has joined #openstack-nova | 14:10 | |
jroll | well, if g-r blocks it we really have no choice | 14:11 |
*** hakimo has quit IRC | 14:11 | |
*** hakimo_ has joined #openstack-nova | 14:11 | |
jroll | unless we don't merge requirements bumps until this is over | 14:12 |
jroll | I'm just going to wip it | 14:12 |
mriedem | you could still merge your change if you want and it works with mock 1.1.3 | 14:12 |
openstackgerrit | Bart Wensley proposed openstack/nova: Add new pci_max_virtual_functions config option https://review.openstack.org/203044 | 14:13 |
jroll | yeah, I don't think it will work with 1.1.3 | 14:13 |
* jroll tests | 14:13 | |
*** rdo has quit IRC | 14:13 | |
mriedem | well, unless you require a minimum of 1.1.4 then that's probably a bad idea to begin with | 14:13 |
mdbooth | Here's an interesting thing. global requirements for stable/kilo correctly has testtools>=1.4.0, but nova stable/kilo has broken testtools!=1.2.0,>=0.9.36 | 14:13 |
mdbooth | Any idea why those 2 aren't in sync? | 14:14 |
*** markvoelker has joined #openstack-nova | 14:14 | |
mriedem | mdbooth: umm? https://github.com/openstack/requirements/blob/stable/kilo/global-requirements.txt#L266 | 14:14 |
mriedem | you were looking at g-r master | 14:15 |
mdbooth | mriedem: Nah, I was looking in requirements.txt | 14:15 |
mdbooth | not global-requirements.txt | 14:15 |
mdbooth | Right | 14:15 |
mriedem | requirements repo wasn't syncing on itself in kilo | 14:15 |
*** shihanzhang has quit IRC | 14:15 | |
mdbooth | test-requirements.txt | 14:15 |
mdbooth | even | 14:16 |
mdbooth | Ok, what's the process to fix that? | 14:16 |
mdbooth | Just propose the fix to stable g-r.txt? | 14:16 |
mriedem | to do what? | 14:16 |
mriedem | raise the minimum required testtools? | 14:16 |
mdbooth | Yeah | 14:16 |
mriedem | why do we need to? | 14:16 |
mdbooth | In Nova kilo it's currently 1.4.0 | 14:16 |
mdbooth | Because that's the minimum version which used unittest2 | 14:16 |
mdbooth | Which we're using | 14:17 |
mriedem | https://github.com/openstack/nova/blob/stable/kilo/test-requirements.txt#L21 | 14:17 |
*** shihanzhang has joined #openstack-nova | 14:17 | |
mriedem | ? | 14:17 |
mdbooth | mriedem: Yeah, that needs to be >=1.4.0 | 14:17 |
mdbooth | I'll propose it to g-r | 14:17 |
*** markvoelker has quit IRC | 14:18 | |
mriedem | honestly i don't really know what you're talking about | 14:20 |
mdbooth | mriedem: Sec, code makes all clear | 14:20 |
mdbooth | mriedem: https://review.openstack.org/203046 | 14:20 |
mriedem | i don't see nova using unittest2 in stable/kilo | 14:21 |
mriedem | explicitly anyway | 14:21 |
mdbooth | It doesn't. *testtools* uses unittest/unittest2 | 14:21 |
mdbooth | So we use testtools.TestCase | 14:21 |
mdbooth | which inherits from unittest(2)?.TestCase | 14:21 |
mriedem | ok? | 14:22 |
mriedem | and? | 14:22 |
mdbooth | Our tests fail if we're not using unittest2 | 14:22 |
mdbooth | which is never the case before testtools version 1.4.0 | 14:22 |
mdbooth | So our kilo tests always fail with testtools <1.4.0 | 14:22 |
mdbooth | Try it if you don't believe me :) | 14:22 |
mriedem | so just propose a cherry pick of this https://github.com/openstack/requirements/commit/74e2456c40f294633791b1581ada242c6792e67a | 14:23 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: switch to oslo.cache https://review.openstack.org/203049 | 14:23 |
mdbooth | mriedem: That's a better idea, will do | 14:23 |
* mdbooth isn't familiar with this repo | 14:23 | |
*** unicell1 has joined #openstack-nova | 14:24 | |
mriedem | it'd be helpful if you had a paste of a test that fails in kilo with testtools < 1.4.0 | 14:24 |
mdbooth | git grep assertRaisesRegex | 14:24 |
mdbooth | All of them | 14:24 |
*** unicell has quit IRC | 14:25 | |
*** mestery has quit IRC | 14:25 | |
*** erlon has joined #openstack-nova | 14:26 | |
*** yamahata has joined #openstack-nova | 14:27 | |
mriedem | mdbooth: are you on py26 or py27? | 14:28 |
mdbooth | py27 | 14:28 |
mdbooth | It's not hard to follow in the code | 14:28 |
*** markvoelker has joined #openstack-nova | 14:28 | |
*** chaochin has quit IRC | 14:29 | |
*** Jeffrey4l has joined #openstack-nova | 14:29 | |
*** chaochin has joined #openstack-nova | 14:29 | |
*** rdo has joined #openstack-nova | 14:32 | |
*** eharney has joined #openstack-nova | 14:32 | |
*** Kennan2 has quit IRC | 14:32 | |
*** tpeoples has joined #openstack-nova | 14:33 | |
mdbooth | mriedem: Here's an example failure: http://paste.fedoraproject.org/245395/37143575/ | 14:33 |
*** park_heijlong has quit IRC | 14:33 | |
*** markvoelker has quit IRC | 14:33 | |
mdbooth | Hmm, no it isn't | 14:33 |
mdbooth | sec | 14:33 |
*** park_heijlong has joined #openstack-nova | 14:33 | |
*** Kennan has joined #openstack-nova | 14:33 | |
mdbooth | mriedem: There: http://paste.openstack.org/show/383823/ | 14:34 |
mdbooth | I reproduced that by recreating my venv after adding <1.4.0 to testtools in test-requirements.txt | 14:34 |
*** xyang2 has joined #openstack-nova | 14:34 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Added server tags support in nova-api https://review.openstack.org/128940 | 14:35 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Fixed incorrect behaviour of method _check_instance_exists https://review.openstack.org/203037 | 14:35 |
*** chuckcarmack has joined #openstack-nova | 14:36 | |
openstackgerrit | jichenjc proposed openstack/nova: Check flavor type before add tenant access https://review.openstack.org/124338 | 14:36 |
*** tsekiyama has joined #openstack-nova | 14:37 | |
*** apmelton has quit IRC | 14:38 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Enable python34 tests for nova/tests/unit/scheduler/test*.py https://review.openstack.org/187968 | 14:40 |
*** apmelton has joined #openstack-nova | 14:40 | |
*** tongli has joined #openstack-nova | 14:42 | |
*** mgarza_ has joined #openstack-nova | 14:43 | |
*** krtaylor has quit IRC | 14:45 | |
*** MentalRay has joined #openstack-nova | 14:45 | |
*** hemna has joined #openstack-nova | 14:46 | |
*** sambol has joined #openstack-nova | 14:48 | |
*** mtanino has joined #openstack-nova | 14:49 | |
*** cfriesen has joined #openstack-nova | 14:50 | |
openstackgerrit | jichenjc proposed openstack/nova-specs: Delete version specified code suggestion https://review.openstack.org/164229 | 14:50 |
*** markvoelker has joined #openstack-nova | 14:50 | |
*** Jeffrey4l has quit IRC | 14:51 | |
*** tonytan4ever has joined #openstack-nova | 14:51 | |
*** hemna has quit IRC | 14:52 | |
*** ddaskal has joined #openstack-nova | 14:53 | |
*** achanda has joined #openstack-nova | 14:53 | |
*** gyee has quit IRC | 14:53 | |
*** markvoelker has quit IRC | 14:57 | |
*** rdo has quit IRC | 14:57 | |
mriedem | well it's 10am and i've wasted my morning | 14:57 |
mriedem | now what do i do | 14:57 |
*** markvoelker_ has joined #openstack-nova | 14:57 | |
*** markvoelker_ has quit IRC | 14:57 | |
*** krtaylor has joined #openstack-nova | 14:57 | |
*** markvoelker has joined #openstack-nova | 14:57 | |
*** mestery has joined #openstack-nova | 14:58 | |
*** rdo has joined #openstack-nova | 14:59 | |
*** jlearman has quit IRC | 14:59 | |
bauwser | mriedem: coffee always hlep | 14:59 |
bauwser | helps (even) | 14:59 |
mriedem | already downed 2 cups | 15:00 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: objects: send PciDeviceList 1.2 to all code that can handle it https://review.openstack.org/202616 | 15:00 |
*** mgoddard1 has joined #openstack-nova | 15:00 | |
*** jaypipes has joined #openstack-nova | 15:01 | |
*** mgoddard has quit IRC | 15:01 | |
*** Jeffrey4l has joined #openstack-nova | 15:01 | |
bauwser | mriedem: planning to port your g-r change to nova once it's merged ? | 15:01 |
bauwser | mriedem: I have a 17 patches series holding | 15:01 |
openstackgerrit | Zhang Hua proposed openstack/nova: Enable password support for vnc session https://review.openstack.org/203064 | 15:02 |
mriedem | bauwser: that's automatic, the sync | 15:02 |
mriedem | i don't want to review code | 15:02 |
mriedem | someone can review my code for a change | 15:02 |
bauwser | mriedem: the bot, you mean? | 15:02 |
mriedem | yeah | 15:02 |
bauwser | mriedem: okay, thought you were planning to not wait for the bot but that's fair :) | 15:03 |
*** dprince has quit IRC | 15:03 | |
*** gyee has joined #openstack-nova | 15:03 | |
*** tonytan4ever has quit IRC | 15:03 | |
cfriesen | bauwser: Some time back I mentioned a problem with nova.pci.devspec.MAX_FUNC being too small, so you suggested we should make it a config option. Here you go (from a coworker): https://review.openstack.org/#/c/203044/ | 15:04 |
*** achanda has quit IRC | 15:05 | |
bauwser | cfriesen: well, I suggested it like at 1am my time - not ebriated, but sleepy :) | 15:05 |
*** READ10 has quit IRC | 15:05 | |
bauwser | cfriesen: but that sounds still a good point :p | 15:05 |
*** adreznec has quit IRC | 15:07 | |
*** gszasz has quit IRC | 15:09 | |
*** adreznec has joined #openstack-nova | 15:09 | |
*** wwriverrat has quit IRC | 15:10 | |
mnaser | hi friends, wondering if any cores have time to review a small patch (submitted since july 8th and i already have 2 +1s) .. https://review.openstack.org/#/c/199516/ | 15:10 |
*** tonytan4ever has joined #openstack-nova | 15:10 | |
*** piyanai has joined #openstack-nova | 15:14 | |
*** cpschult has quit IRC | 15:16 | |
*** mdrabe has quit IRC | 15:16 | |
*** dprince has joined #openstack-nova | 15:16 | |
openstackgerrit | Raildo Mascena de Sousa Filho proposed openstack/nova: Nested Quota Driver: Create column allocated in Quota table https://review.openstack.org/151327 | 15:17 |
openstackgerrit | Raildo Mascena de Sousa Filho proposed openstack/nova: Nested Quota : cloud_admin and project_admin creation https://review.openstack.org/182522 | 15:17 |
openstackgerrit | Raildo Mascena de Sousa Filho proposed openstack/nova: Removal of redundant context checking in wsgi.py file https://review.openstack.org/182140 | 15:17 |
*** dannywilson has joined #openstack-nova | 15:20 | |
*** diogogmt has joined #openstack-nova | 15:22 | |
*** jecarey has quit IRC | 15:23 | |
*** coolsvap is now known as coolsvap|away | 15:23 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Scheduler RPC API select_dests() https://review.openstack.org/199205 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Remove unnecessary method in FilterScheduler https://review.openstack.org/188485 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Create RequestSpec object https://review.openstack.org/145528 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Consider that all scheduler calls are IO Ops https://review.openstack.org/188486 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec object in the FilterScheduler https://review.openstack.org/188487 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify left filters for RequestSpec https://review.openstack.org/202678 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Prepare filters for using RequestSpec object https://review.openstack.org/197912 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify metric-related filters for RequestSpec https://review.openstack.org/202676 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec in the ChanceScheduler https://review.openstack.org/199051 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify NUMA, PCI and num_instances filters for RequestSpec https://review.openstack.org/202677 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Aggregate filters for RequestSpec https://review.openstack.org/202674 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify default filters for RequestSpec https://review.openstack.org/202675 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add RequestSpec methods for primitiving into dicts https://review.openstack.org/187197 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Affinity filter for RequestSpec https://review.openstack.org/202673 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec object in HostManager https://review.openstack.org/191251 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Use the same pci_requests field for all filters and HostManager https://review.openstack.org/191250 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add two fields to ImageMetaProps object https://review.openstack.org/197911 | 15:25 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP: Modifies conductor to use RequestSpec object https://review.openstack.org/203078 | 15:25 |
bauwser | ok, cores, I think I need some help for reducing my changes number :) | 15:26 |
*** rdo has quit IRC | 15:27 | |
bauwser | jaypipes: alaski: ^ | 15:27 |
jaypipes | bauwser: lol, ok :) | 15:27 |
*** cinerama has joined #openstack-nova | 15:27 | |
*** jaypipes is now known as blockedpipes | 15:27 | |
bauwser | jaypipes: I won't be at the midcycle, but I'm preparing to be virtually there | 15:27 |
*** rdo has joined #openstack-nova | 15:27 | |
*** annashen has joined #openstack-nova | 15:28 | |
bauwser | blockedpipes: meaning that we could possibly do some sprint for all our stuff :) | 15:28 |
bauwser | blockedpipes: on my own, ^ is fully implemented now | 15:29 |
bauwser | blockedpipes: the last one is WIP because I'm lazy but it will be complete by Monday | 15:29 |
bauwser | blockedpipes: on your own, do you need some special review traction ? | 15:29 |
openstackgerrit | Michael Sambol proposed openstack/nova: Move V2.1 code into correct directories https://review.openstack.org/202854 | 15:30 |
*** tongli has quit IRC | 15:30 | |
*** mdrabe has joined #openstack-nova | 15:30 | |
*** tongli has joined #openstack-nova | 15:31 | |
figleaf | blockedpipes: I hope the new Friday nick isn't reflective of anything physical :) | 15:31 |
openstackgerrit | Michael Sambol proposed openstack/nova: Move V2.1 code into correct directories https://review.openstack.org/202854 | 15:31 |
*** cpschult has joined #openstack-nova | 15:31 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 15:33 |
mriedem | bauwser: there you go ^ | 15:33 |
bauwser | \o/ | 15:33 |
*** READ10 has joined #openstack-nova | 15:33 | |
*** READ10 has quit IRC | 15:33 | |
*** READ10 has joined #openstack-nova | 15:33 | |
bauwser | mriedem: too late, I pulled the trigger ^ | 15:33 |
openstackgerrit | raphael.glon proposed openstack/nova: Fix proposal for libvirt rbd unrescue action https://review.openstack.org/203086 | 15:33 |
*** artom has quit IRC | 15:33 | |
*** dannywilson has quit IRC | 15:34 | |
mriedem | blockedpipes: maybe a fiber supplement is the answer to your problem? | 15:34 |
superdan | hehe | 15:34 |
mriedem | i mean, you are in florida | 15:34 |
mriedem | i thought they just handed those out on the corners | 15:34 |
cfriesen | add it to the water supply... | 15:34 |
*** annashen has quit IRC | 15:35 | |
blockedpipes | mriedem, cfriesen: no, my queue is just entirely full. | 15:36 |
tdurakov | mriedem, Hi Matt | 15:37 |
openstackgerrit | Stefan Amann proposed openstack/nova: Perform port_rescan on s390x platforms https://review.openstack.org/203035 | 15:38 |
tdurakov | mriedem, could you review my patches for conductor? https://review.openstack.org/#/c/184495/ | 15:38 |
*** earlephilhower has joined #openstack-nova | 15:40 | |
cfriesen | blockedpipes: just write a bigger value to /proc/sys/fs/pipe-max-size | 15:40 |
bauwser | blockedpipes: np, I fully understand :) | 15:40 |
*** armax has joined #openstack-nova | 15:40 | |
blockedpipes | cfriesen: heh. a personal sysctl. nice. | 15:41 |
*** gyee has quit IRC | 15:41 | |
cfriesen | blockedpipes: I've often thought babies should have diagnostic ports | 15:41 |
blockedpipes | cfriesen: the fact that they don't is partly why my wife and I choose to be child-free. | 15:42 |
mriedem | the os-brick integration change is ready to go IMO https://review.openstack.org/#/c/175569/ | 15:42 |
mriedem | there are changes lined up behind this and it's big so would be good to avoid rebase hell on this one | 15:42 |
mriedem | big as in: +193, -2281 | 15:43 |
*** belmoreira has quit IRC | 15:43 | |
blockedpipes | yeah, will try to get to that this afternoon, mrda-away | 15:43 |
blockedpipes | gah, mriedem | 15:43 |
mriedem | i'd like to see ndipanov review it since it's all libvirt volume stuff | 15:43 |
mriedem | nudge nudge | 15:44 |
* ndipanov raises head above grass | 15:44 | |
ndipanov | will do it today | 15:44 |
*** Marc_F has quit IRC | 15:44 | |
mriedem | cool | 15:45 |
*** jogo has quit IRC | 15:46 | |
*** ildikov has joined #openstack-nova | 15:47 | |
*** jogo has joined #openstack-nova | 15:47 | |
*** Nikolay_St has quit IRC | 15:49 | |
*** raildo_ has joined #openstack-nova | 15:49 | |
*** gyee has joined #openstack-nova | 15:50 | |
*** earlephilhower has quit IRC | 15:51 | |
*** Nikolay_St has joined #openstack-nova | 15:52 | |
*** romainh has left #openstack-nova | 15:52 | |
*** redbeard has quit IRC | 15:53 | |
*** earlephilhower has joined #openstack-nova | 15:55 | |
*** hemnafk is now known as hemna | 15:55 | |
*** raildo_ has quit IRC | 15:58 | |
*** afazekas has quit IRC | 15:58 | |
*** schwicke has joined #openstack-nova | 15:58 | |
*** otter768 has joined #openstack-nova | 15:59 | |
*** vilobhmm has joined #openstack-nova | 16:00 | |
*** Jeffrey4l has quit IRC | 16:00 | |
openstackgerrit | Stefan Amann proposed openstack/nova: Perform port_rescan on s390x platforms https://review.openstack.org/203035 | 16:00 |
*** mestery has quit IRC | 16:01 | |
*** jlanoux has quit IRC | 16:01 | |
*** mestery has joined #openstack-nova | 16:01 | |
*** mgoddard1 has quit IRC | 16:02 | |
*** mgoddard has joined #openstack-nova | 16:03 | |
*** amotoki has joined #openstack-nova | 16:03 | |
*** otter768 has quit IRC | 16:04 | |
mriedem | so close https://jenkins04.openstack.org/job/gate-tempest-dsvm-neutron-full/1054/console | 16:05 |
superdan | danpb: https://review.openstack.org/#/c/197911/4 | 16:07 |
superdan | danpb: have you looked that over? I put some comments inline | 16:08 |
danpb | superdan: not looked at any reviews yet - still working through my vacation email backlog today | 16:09 |
superdan | okay | 16:09 |
danpb | i'll check it out next week | 16:10 |
*** oro has quit IRC | 16:10 | |
*** kmARC has quit IRC | 16:11 | |
*** jichen has quit IRC | 16:12 | |
mriedem | g-r block on mock 1.1.4 is merged, should see a sync soon | 16:13 |
*** artom has joined #openstack-nova | 16:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 16:16 |
*** annashen has joined #openstack-nova | 16:16 | |
dims_ | superdan: added jaypipes to oslo-versionedobjects-core? | 16:17 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/203141 | 16:18 |
superdan | dims_: he's always been there | 16:18 |
dims_ | superdan: ah! just spotted his vote yesterday. yay! | 16:18 |
superdan | heh | 16:18 |
dims_ | superdan: want to add more folks? | 16:19 |
mriedem | like oprah, you get to be core, and you get to be core | 16:19 |
superdan | I don't get the oprah joke :) | 16:19 |
*** angdraug has joined #openstack-nova | 16:20 | |
*** tonytan4ever has quit IRC | 16:21 | |
superdan | alI know about oprah is you have to time it to be there on the right day | 16:21 |
superdan | and you get a car | 16:21 |
superdan | and a spaceshit | 16:21 |
superdan | er, spaceship | 16:21 |
superdan | heh | 16:21 |
*** ildikov_ has joined #openstack-nova | 16:21 | |
*** nic has joined #openstack-nova | 16:24 | |
*** ildikov has quit IRC | 16:24 | |
*** alex_klimov has quit IRC | 16:25 | |
superdan | mriedem: will that mock thing affect stable/juno? | 16:27 |
mriedem | superdan: we have mock capped on stable | 16:27 |
johnthetubaguy | sdague: I am just wondering about the need to raise the min version of python-cinderclient with this bug fix: https://review.openstack.org/#/c/192158/2 | 16:27 |
openstackgerrit | Radoslav Gerganov proposed openstack/nova: Add MKS console support https://review.openstack.org/203006 | 16:27 |
openstackgerrit | Radoslav Gerganov proposed openstack/nova: Add MKS protocol for remote consoles https://review.openstack.org/199129 | 16:27 |
superdan | okay, this failure is something else I guess | 16:27 |
mriedem | btw, i want to officially announce that i submit to my new google overlords | 16:29 |
superdan | using gmail? or rewriting everything in go? | 16:30 |
earlephilhower | Or this: http://www.theregister.co.uk/2015/07/17/google_signs_as_thirdrate_openstack_sponsor/ | 16:30 |
ndipanov | or starting work there? | 16:30 |
earlephilhower | ? | 16:30 |
mriedem | http://fortune.com/2015/07/16/google-joins-openstack/ | 16:30 |
mriedem | superdan: i figured it'd be all over the twitters | 16:30 |
superdan | sure, like yesterday | 16:30 |
mriedem | i know | 16:30 |
superdan | I figured you meant something about you personally | 16:30 |
superdan | like moving there | 16:31 |
mriedem | no | 16:31 |
mriedem | hell no | 16:31 |
mriedem | see, i'm > 30 + wife and child | 16:31 |
*** jistr has quit IRC | 16:31 | |
mriedem | therefore, not eligible for employment | 16:31 |
superdan | heh | 16:31 |
ndipanov | mriedem, but if you lift... | 16:31 |
ctrath | what mriedem is saying is that he loves Minnesota winters | 16:32 |
mriedem | i do | 16:32 |
mnaser | any cores mind having a look at this patch.. submitted on july 8th .. https://review.openstack.org/#/c/199516/ | 16:32 |
mriedem | winter is a socially approved excuse for being a shut in | 16:32 |
*** ashuk has joined #openstack-nova | 16:32 | |
figleaf | mriedem: so are summers in south texas | 16:33 |
superdan | bauwser: maybe you should move this to the front so we can get it out of your set? https://review.openstack.org/#/c/188485/14 | 16:33 |
*** sahid has quit IRC | 16:34 | |
*** tonytan4ever has joined #openstack-nova | 16:34 | |
*** annashen has quit IRC | 16:36 | |
*** cpschult has quit IRC | 16:37 | |
*** haypo has left #openstack-nova | 16:37 | |
*** dims_ has quit IRC | 16:37 | |
*** artom has quit IRC | 16:38 | |
*** piyanai has quit IRC | 16:38 | |
*** annashen has joined #openstack-nova | 16:40 | |
*** elmiko has joined #openstack-nova | 16:42 | |
elmiko | hi all, i'm having trouble determining something about the novaclient Client object , specifically surrounding cacert, insecure and the use of keystone Session objects. | 16:43 |
elmiko | could anyone help me understand the cacert and insecure options, i've looked at the code but i'm not sure how it works. | 16:44 |
elmiko | like, if i specify insecure=True, that means it will ignore the cacert? | 16:44 |
*** moshele has joined #openstack-nova | 16:44 | |
elmiko | further, if we have users who specify a cacert, and i want to pass a Session object to the Client, can i just switch around the cacert and ignore the insecure option? | 16:45 |
elmiko | (for creating the Session, that is) | 16:45 |
*** Nikolay_St has quit IRC | 16:46 | |
*** gyee has quit IRC | 16:46 | |
*** unicell1 has quit IRC | 16:50 | |
*** jlearman has joined #openstack-nova | 16:50 | |
*** artom has joined #openstack-nova | 16:50 | |
*** cpschult has joined #openstack-nova | 16:50 | |
*** browne has quit IRC | 16:54 | |
*** artom has quit IRC | 16:54 | |
*** artom has joined #openstack-nova | 16:55 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Introduce utility module for pcp https://review.openstack.org/203163 | 16:57 |
*** piyanai has joined #openstack-nova | 16:58 | |
*** ijw_ has joined #openstack-nova | 17:01 | |
*** vilobhmm has quit IRC | 17:01 | |
*** derekh has quit IRC | 17:01 | |
*** patrickeast has joined #openstack-nova | 17:04 | |
*** ijw__ has joined #openstack-nova | 17:04 | |
* johnthetubaguy wishes everyone a safe journey to the mid cycle | 17:07 | |
tonyb | johnthetubaguy: see you in a couple of days. | 17:07 |
*** ijw_ has quit IRC | 17:07 | |
figleaf | johnthetubaguy: see you in sunny Minnesota! | 17:08 |
*** cpschult has quit IRC | 17:08 | |
*** unicell has joined #openstack-nova | 17:10 | |
*** lucasagomes is now known as lucas-beer | 17:11 | |
*** yamahata has quit IRC | 17:11 | |
openstackgerrit | Michael Sambol proposed openstack/nova: DO NOT MERGE https://review.openstack.org/202854 | 17:12 |
openstackgerrit | Michael Sambol proposed openstack/nova: Move existing V2 to legacy-v2 https://review.openstack.org/193725 | 17:12 |
openstackgerrit | Radoslav Gerganov proposed openstack/nova: VMware: add serial port device https://review.openstack.org/149203 | 17:13 |
*** piyanai has quit IRC | 17:14 | |
bauwser | superdan: sure thing, thanks for reviewing my changes | 17:15 |
superdan | bauwser: np | 17:15 |
superdan | only done a few so far | 17:16 |
bauwser | superdan: that's fine, the series is very long, so reviewing the first is good IMHO | 17:16 |
*** schwicke has quit IRC | 17:17 | |
*** annashen has quit IRC | 17:17 | |
*** MVenesio has joined #openstack-nova | 17:17 | |
*** danpb has quit IRC | 17:17 | |
*** thangp has joined #openstack-nova | 17:18 | |
*** msambol has joined #openstack-nova | 17:19 | |
*** msambol has quit IRC | 17:20 | |
*** msambol has joined #openstack-nova | 17:21 | |
*** piyanai has joined #openstack-nova | 17:22 | |
*** sambol has quit IRC | 17:22 | |
*** ssurana has joined #openstack-nova | 17:22 | |
*** otter768 has joined #openstack-nova | 17:24 | |
*** dillinga has joined #openstack-nova | 17:25 | |
*** msambol has quit IRC | 17:25 | |
*** harlowja has quit IRC | 17:26 | |
*** harlowja has joined #openstack-nova | 17:26 | |
*** tonytan4ever has quit IRC | 17:26 | |
*** ashuk has quit IRC | 17:26 | |
*** irenab has joined #openstack-nova | 17:27 | |
*** dillinga has quit IRC | 17:27 | |
*** annashen has joined #openstack-nova | 17:27 | |
*** piyanai has quit IRC | 17:27 | |
*** amotoki has quit IRC | 17:33 | |
*** oro has joined #openstack-nova | 17:35 | |
*** mestery has quit IRC | 17:35 | |
*** yamahata has joined #openstack-nova | 17:35 | |
*** dougwig has quit IRC | 17:35 | |
*** kmARC has joined #openstack-nova | 17:35 | |
*** achanda has joined #openstack-nova | 17:35 | |
*** leseb_ has joined #openstack-nova | 17:36 | |
*** jdurgin has joined #openstack-nova | 17:36 | |
*** mestery has joined #openstack-nova | 17:36 | |
*** dougwig has joined #openstack-nova | 17:37 | |
mriedem | superdan: with this https://review.openstack.org/#/c/203169/ - kilo -> liberty is still good right? | 17:42 |
mriedem | i remember the change on master saying it depended on the change in kilo | 17:42 |
mriedem | i also pointed it out to apevec as a blocker for 2015.1.1 | 17:42 |
*** rook has quit IRC | 17:42 | |
superdan | mriedem: yeah, this only affects kilo->kilo things.. the relationships that get used are those of your conductor, so if you're running conductor from L, then these are ignored | 17:43 |
*** Sukhdev has joined #openstack-nova | 17:43 | |
*** karimb has quit IRC | 17:44 | |
*** boris-42 has joined #openstack-nova | 17:45 | |
*** vilobhmm has joined #openstack-nova | 17:46 | |
*** SourabhP has joined #openstack-nova | 17:47 | |
*** cpschult has joined #openstack-nova | 17:48 | |
*** irenab has quit IRC | 17:48 | |
*** shyama_ has joined #openstack-nova | 17:49 | |
*** irenab has joined #openstack-nova | 17:49 | |
*** shyama has quit IRC | 17:50 | |
*** shyama_ is now known as shyama | 17:50 | |
*** browne has joined #openstack-nova | 17:52 | |
*** irenab has quit IRC | 17:53 | |
*** lykinsbd has joined #openstack-nova | 17:54 | |
*** lucas-beer has quit IRC | 17:57 | |
openstackgerrit | Raildo Mascena de Sousa Filho proposed openstack/nova: Nested Quota Driver: Set default values to sub-projects and users. https://review.openstack.org/151677 | 17:58 |
sdague | johnthetubaguy: yes, we should | 17:59 |
openstackgerrit | Raildo Mascena de Sousa Filho proposed openstack/nova: NestedQuotaDriver:Modification of settable quotas of nested projects https://review.openstack.org/200342 | 18:00 |
*** piyanai has joined #openstack-nova | 18:00 | |
melwitt | superdan, bauwser: about https://review.openstack.org/#/c/188485/, does that not fall into the category of a pluggable thing we shouldn't remove public interfaces from unless there's a compelling reason? I'm thinking of the review from awhile back that wanted to remove a thing ironic uses (https://review.openstack.org/#/c/143285/) | 18:00 |
superdan | melwitt: I think his point was the it's still in instance_properties, right? | 18:01 |
melwitt | superdan: oh, probably. I looked at it too quickly | 18:02 |
superdan | melwitt: in the commit message | 18:03 |
melwitt | superdan: yeah. I got turned around a bit by alaski's comment in there | 18:03 |
*** tonytan4ever has joined #openstack-nova | 18:04 | |
*** Kennan2 has joined #openstack-nova | 18:04 | |
superdan | melwitt: may I suggest "melaknee" ? | 18:04 |
*** Kennan has quit IRC | 18:05 | |
melwitt | superdan: haha, that's a good one | 18:05 |
*** haomaiw__ has quit IRC | 18:06 | |
*** shyama has quit IRC | 18:06 | |
superdan | or melwitty | 18:07 |
*** mestery has quit IRC | 18:10 | |
*** dannywilson has joined #openstack-nova | 18:10 | |
mriedem | hemna: make your os-brick change in nova depend on this: https://review.openstack.org/#/c/203193/ | 18:12 |
mriedem | hemna: so add this to your nova change: | 18:12 |
mriedem | Depends-On: Id36f9665c8ff2a720713ceaaa5b05f9b03706681 | 18:12 |
mriedem | hemna: and then it looks like you'll be able to abandon this https://review.openstack.org/#/c/175569/ | 18:13 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Switch to using os-brick https://review.openstack.org/175569 | 18:13 |
*** piyanai has quit IRC | 18:14 | |
hemna | ok added it | 18:15 |
mriedem | +2 again | 18:15 |
*** aarefiev has quit IRC | 18:16 | |
mriedem | hemna: while we're at it, could you also remove this line from volume.py? | 18:16 |
mriedem | arch=platform.machine()) | 18:16 |
mriedem | for fc? | 18:16 |
mriedem | since that's no longer necessary in brick 0.3.0 | 18:16 |
hemna | ah yah good idea. | 18:16 |
ndipanov | superdan, so what do we do about this https://review.openstack.org/#/c/202616/ | 18:16 |
hemna | rerunning tox locally before I push that up. | 18:17 |
ndipanov | I think we can just land it no problem | 18:17 |
ndipanov | but I'll run a recheck once https://review.openstack.org/#/c/203169/1 lands | 18:18 |
*** Mike_D_laptop has joined #openstack-nova | 18:18 | |
superdan | ndipanov: I think we can land it anytime, but agree we should wait until after that one just to be sure | 18:19 |
ndipanov | superdan, NB it will break if someone goes from 2015.1.0 -> 2015.2 in a rolling upgrade fashion | 18:20 |
ndipanov | so we might want to document that at least | 18:20 |
superdan | is that kilo GA to lemming you mean? | 18:21 |
ndipanov | yes | 18:21 |
superdan | yeah, I'll add that to the lemming note now | 18:21 |
ndipanov | I think that's a good tradeoff | 18:22 |
superdan | aye | 18:22 |
*** haomaiwang has joined #openstack-nova | 18:23 | |
openstackgerrit | Raildo Mascena de Sousa Filho proposed openstack/nova: NestedQuotaDriver:Modification of settable quotas of nested projects https://review.openstack.org/200342 | 18:25 |
openstackgerrit | Raildo Mascena de Sousa Filho proposed openstack/nova: Nested Quota Driver: Create column allocated in Quota table https://review.openstack.org/151327 | 18:25 |
openstackgerrit | Raildo Mascena de Sousa Filho proposed openstack/nova: Nested Quota : cloud_admin and project_admin creation https://review.openstack.org/182522 | 18:25 |
openstackgerrit | Raildo Mascena de Sousa Filho proposed openstack/nova: Removal of redundant context checking in wsgi.py file https://review.openstack.org/182140 | 18:25 |
openstackgerrit | Raildo Mascena de Sousa Filho proposed openstack/nova: Nested Quota Driver: Set default values to sub-projects and users. https://review.openstack.org/151677 | 18:25 |
*** yassine has quit IRC | 18:25 | |
*** angdraug has quit IRC | 18:27 | |
*** haomaiwang has quit IRC | 18:28 | |
*** piyanai has joined #openstack-nova | 18:28 | |
*** mestery has joined #openstack-nova | 18:31 | |
*** haomaiwa_ has joined #openstack-nova | 18:31 | |
*** markvoelker has quit IRC | 18:32 | |
mriedem | chuckcarmack: i have an easy thing you could do | 18:33 |
mriedem | it's not nova, but is helpful regardless | 18:34 |
*** eglynn has quit IRC | 18:36 | |
chuckcarmack | mriedem: ok, what is it? | 18:36 |
mriedem | we need to cleanup old elastic-recheck queuries that are no longer valid, see the bottom of this page http://status.openstack.org/elastic-recheck/index.html | 18:36 |
*** haomaiwa_ has quit IRC | 18:36 | |
mriedem | anything that hasn't hit in over 10 days and the bug is marked as fixed or invalid in launchpad, we should delete those queries | 18:36 |
mriedem | that's in this project http://git.openstack.org/cgit/openstack-infra/elastic-recheck/ | 18:37 |
mriedem | the queries are all here http://git.openstack.org/cgit/openstack-infra/elastic-recheck/tree/queries | 18:37 |
mriedem | so it's just a matter of removing the ones that don't hit anymore for fixed/invalid bugs | 18:37 |
*** unicell1 has joined #openstack-nova | 18:38 | |
*** unicell has quit IRC | 18:38 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Switch to using os-brick https://review.openstack.org/175569 | 18:39 |
chuckcarmack | mriedem: ok, I'll work on that. Its going to take me some time to understand what is elastic-recheck. | 18:40 |
mriedem | chuckcarmack: http://docs.openstack.org/infra/elastic-recheck/readme.html | 18:40 |
*** lpetrut has joined #openstack-nova | 18:40 | |
chuckcarmack | thanks.. mriedem | 18:40 |
*** Sayaji has joined #openstack-nova | 18:41 | |
mriedem | awesome, something else is pulling in mock 1.1.4 | 18:41 |
mriedem | so g-r block doesn't fix it yet | 18:41 |
*** haomaiwang has joined #openstack-nova | 18:41 | |
chuckcarmack | mriedem: g-r? | 18:42 |
mriedem | chuckcarmack: unrelated | 18:42 |
mriedem | https://bugs.launchpad.net/nova/+bug/1475661 | 18:42 |
openstack | Launchpad bug 1475661 in OpenStack Compute (nova) "py27 jobs failing due to mock_open after mock 1.1.4 released" [Critical,In progress] - Assigned to Matt Riedemann (mriedem) | 18:42 |
mriedem | g-r == global-requirements https://github.com/openstack/requirements/blob/master/global-requirements.txt | 18:42 |
Sayaji | I want to set mtu on a vm interface by modifying libvirt.xml. Is is possible to do it by writing a vif driver ? | 18:44 |
openstackgerrit | Chinmaya Bharadwaj proposed openstack/nova: VMware: Fixes instance creation failure using block device mapping https://review.openstack.org/197192 | 18:48 |
*** ildikov_ has quit IRC | 18:49 | |
lifeless | sdague: :/ | 18:51 |
mgagne | alaski: I'm working on making Kilo api cell compatible with Juno compute cell. It looks like all compute_node and services are represented by a dict by Juno instead of objects and Kilo is missing code to transform the response to object. What's the best way to make it compatible? | 18:53 |
*** haomaiwang has quit IRC | 18:53 | |
mgagne | alaski: I'm using _from_db_object to convert compute_node dict to object but it's eating away the host field :/ | 18:54 |
*** otter768 has quit IRC | 18:54 | |
sdague | lifeless: so pinning mock does not work | 18:54 |
sdague | because it doesn't stay pinned | 18:54 |
sdague | that used to work, any idea why it doesn't now | 18:55 |
sdague | because if the answer is that we've got to pin mock in every dependency for it to be pinned in nova, that's not an answer | 18:55 |
lifeless | sdague: so it will with constraints, which we're nearly ready to roll out for tox | 18:56 |
lifeless | but that doesn't help us right today | 18:56 |
sdague | right | 18:57 |
lifeless | point me at a log? | 18:57 |
sdague | so I think mriedem is just going to do the flame thrower override | 18:57 |
sdague | https://jenkins02.openstack.org/job/gate-nova-python27/1136/console | 18:57 |
*** haomaiwang has joined #openstack-nova | 18:57 | |
sdague | also, please, before you release another mock, can you run the nova unit tests with it | 18:57 |
lifeless | I can probably do better | 18:57 |
lifeless | whatever flame thrower is | 18:57 |
sdague | because I think we've demonstrated that we touch most of the edges of mock, so it's a good sample set | 18:58 |
mriedem | we're going to install mock ahead of reqiurements/test-requirements in tox.ini | 18:58 |
sdague | mriedem: actually, after | 18:58 |
sdague | put it in the commands list | 18:58 |
sdague | then nothing can change it | 18:59 |
sdague | the cinder unit tests got broken by the mock release as well, not sure how bad the rest of the carnage is | 18:59 |
mriedem | ironic alo | 18:59 |
mriedem | *also | 18:59 |
mriedem | jroll: was pushing a separate workaround for the single ironic test that was busted | 18:59 |
jroll | ohai | 19:00 |
lifeless | let me revert and cut a 1.2 | 19:00 |
sdague | ok, got to run | 19:00 |
lifeless | after I look at the actual test | 19:00 |
*** Mike_D_laptop has quit IRC | 19:00 | |
jroll | lifeless: if you're curious, https://review.openstack.org/#/c/203042/ | 19:00 |
sdague | good weekend folks | 19:00 |
*** lpetrut has quit IRC | 19:00 | |
*** gyee has joined #openstack-nova | 19:00 | |
jroll | lifeless: tl;dr accessing mock_open().return_value, and using that to set e.g. write() side effect, is now broken | 19:00 |
*** adreznec has quit IRC | 19:02 | |
lifeless | jroll: indeed, because it now returns different objects | 19:02 |
lifeless | because of the closure issue | 19:02 |
jroll | right | 19:02 |
jroll | just making sure you're aware with how it broke | 19:02 |
lifeless | thank you | 19:03 |
jroll | np, thanks in advance for fixing the world ;D | 19:03 |
mriedem | we'll see about this ^ | 19:04 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 19:05 |
mriedem | er ^ | 19:05 |
openstackgerrit | David Medberry proposed openstack/nova: Update Filter Scheduler doc https://review.openstack.org/203214 | 19:06 |
*** cpschult has quit IRC | 19:07 | |
*** adreznec has joined #openstack-nova | 19:07 | |
*** MentalRay_ has joined #openstack-nova | 19:08 | |
*** ndipanov has quit IRC | 19:09 | |
lifeless | ok so | 19:10 |
lifeless | http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/virt/hyperv/test_vmops.py#n981 | 19:10 |
lifeless | that looks very odd | 19:11 |
lifeless | unexpected facility even | 19:11 |
*** haomaiwang has quit IRC | 19:11 | |
lifeless | Did it work under 1.0.1 ? | 19:11 |
mriedem | worked on 1.1.3 | 19:11 |
*** MentalRay has quit IRC | 19:11 | |
lifeless | not what I asked ;) | 19:11 |
mriedem | worked < 1.1.0 also | 19:12 |
mriedem | i don't kno wabout 1.0.1 specifically | 19:12 |
*** haomaiwang has joined #openstack-nova | 19:12 | |
mriedem | lifeless: if it helps, we had this workaround for mock 1.1.0 https://github.com/openstack/nova/commit/4442979e71bb09ff9b71604c0dddd37c2bede04d | 19:13 |
lifeless | right | 19:13 |
lifeless | so the point of 1.1.4 was to fix folk that couldn't move to 1.1.0 because it was different to 1.0.1 | 19:13 |
lifeless | so I don't expect that nova/tests/unit/virt/hyperv/test_vmops.py to work | 19:14 |
lifeless | the question is whether the prior code works | 19:14 |
mriedem | like revert that part of 4442979e71bb09ff9b71604c0dddd37c2bede04d ? | 19:14 |
lifeless | yes, which i'm trying now | 19:15 |
lifeless | which works | 19:17 |
lifeless | so that hack was IMO broken | 19:17 |
*** dims_ has joined #openstack-nova | 19:18 | |
*** haomaiwang has quit IRC | 19:18 | |
mriedem | ok, so let me try undoing those | 19:18 |
lifeless | test_get_vhd_format_vhd isn't fixed | 19:18 |
lifeless | and the zero length file thing is new | 19:18 |
lifeless | trying them under 1.0.1 | 19:19 |
mriedem | oh | 19:19 |
*** otter768 has joined #openstack-nova | 19:20 | |
*** unicell1 has quit IRC | 19:20 | |
*** lyanchih has quit IRC | 19:21 | |
openstackgerrit | melanie witt proposed openstack/nova: rebuild: fix rebuild of server with volume attached https://review.openstack.org/176891 | 19:21 |
*** unicell has joined #openstack-nova | 19:22 | |
lifeless | jroll: looking into ironic now | 19:23 |
*** tonytan4ever has quit IRC | 19:23 | |
*** edmondsw has quit IRC | 19:24 | |
*** tonytan4ever has joined #openstack-nova | 19:25 | |
*** tonytan4ever has quit IRC | 19:26 | |
lifeless | jroll: ok your one makes sense as a regression | 19:27 |
lifeless | jroll: I'll roll the revert etc | 19:27 |
lifeless | hmm | 19:29 |
*** erlon has quit IRC | 19:30 | |
*** dims__ has joined #openstack-nova | 19:30 | |
*** ddaskal has quit IRC | 19:31 | |
*** haomaiwang has joined #openstack-nova | 19:32 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Switch to using os-brick https://review.openstack.org/175569 | 19:32 |
*** dims_ has quit IRC | 19:34 | |
*** lpetrut has joined #openstack-nova | 19:35 | |
melwitt | mgagne: what do you mean by "it's eating away the host field"? like the compute_node dict has host key set and then when you get the object, it has nothing for the host field? | 19:36 |
mgagne | melwitt: I'm still debugging but it looks like the host is found in the service key | 19:36 |
*** haomaiwang has quit IRC | 19:36 | |
mgagne | melwitt: and current _from_db_object method does not account for that case | 19:36 |
mgagne | melwitt: nor is _host_from_db_object | 19:37 |
*** haomaiwa_ has joined #openstack-nova | 19:37 | |
mgagne | melwitt: I'm really struggling to make it work. A long of stuff has moved to objects and not compat code has been made for Juno | 19:37 |
lifeless | mriedem: jroll: so | 19:38 |
lifeless | the ironic thing, I think there's a better way to write the test | 19:38 |
*** Nikolay_St has joined #openstack-nova | 19:39 | |
melwitt | mgagne: in _host_from_db_object (I'm looking at it) it does a lookup for service in the db and will set host accordingly, so it's supposed to be accounting for that case | 19:40 |
*** haomaiwang has joined #openstack-nova | 19:40 | |
mgagne | melwitt: there is no service in the api cell db for the compute node | 19:41 |
melwitt | mgagne: oh. okay :( | 19:41 |
mgagne | melwitt: either it's not properly syncing up or we made the wrong assumption that it would be there | 19:41 |
*** haomaiwa_ has quit IRC | 19:41 | |
*** ddaskal has joined #openstack-nova | 19:42 | |
*** Sukhdev has quit IRC | 19:43 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 19:44 |
lifeless | jroll: I think there's a more pithy way to write the test anyhow | 19:44 |
*** otter768 has quit IRC | 19:44 | |
lifeless | jroll: but I'm going to do a 1.2 with it reverted anyway | 19:44 |
*** otter768 has joined #openstack-nova | 19:45 | |
mgagne | melwitt: so it looks like I'm always falling into that except block: https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L110 | 19:46 |
*** haomaiwang has quit IRC | 19:47 | |
*** freyes has quit IRC | 19:47 | |
*** ig0r_ has quit IRC | 19:47 | |
mgagne | melwitt: so yea, there is a service_id in the db_compute but it's not found in the database because it's never synced up | 19:48 |
lifeless | mriedem: jroll: 1.2.0 up on pypi | 19:49 |
*** freyes has joined #openstack-nova | 19:49 | |
*** ddaskal has quit IRC | 19:50 | |
mriedem | lifeless: ok, testing quick | 19:52 |
*** haomaiwa_ has joined #openstack-nova | 19:52 | |
*** jichen has joined #openstack-nova | 19:52 | |
mriedem | rpodolyaka: melwitt: is there a typo in here https://review.openstack.org/#/c/176891/ ? | 19:53 |
melwitt | mgagne: right... I just took a look myself. so it seems like we need another case where we can pull the host from the service key in the message like you said | 19:53 |
mgagne | melwitt: I'm going down that path. I fixed it and now it's breaking somewhere else | 19:53 |
*** cpschult has joined #openstack-nova | 19:53 | |
*** piyanai has quit IRC | 19:53 | |
*** jecarey has joined #openstack-nova | 19:53 | |
melwitt | mgagne: :( the lack of compat code is an oversight so I think we'd want to go through and add it and backport it to kilo | 19:54 |
mgagne | finally | 19:54 |
mgagne | I fixed ONE call :D | 19:54 |
mgagne | a lot of calls expect an object, not a dict | 19:54 |
jroll | lifeless: nice, ty | 19:55 |
melwitt | mgagne: yeah. the way it's supposed to be done (and I'm guilty of forgetting to do it) is on the far side, check if something is an object, if it's not, convert it to one so stuff downstream works | 19:55 |
lifeless | jroll: see my comments in https://github.com/testing-cabal/mock/issues/288 | 19:56 |
lifeless | jroll: the thing special about mock_open is read_data, and name support, nothing else really | 19:56 |
lifeless | jroll: so while the revert fixes you, I suspect you can have a cleaner test without mock_open anyhow | 19:56 |
*** moshele has quit IRC | 19:57 | |
melwitt | mriedem: it seems that way at first glance but I think rpodolyaka might mean recreate as in destroy followed by a create. I just don't know if rebuild will create it if it doesn't exist i.e. don't know if the term "recreate" is accurate | 19:57 |
mgagne | melwitt: yea... I'm working to get kilo working here so I don't mind fixing stuff. What I fear is: missing broken calls and the atrocious latency in getting stuff reviewed and then backported :-/ | 19:57 |
jroll | lifeless: yeah, I tend to agree, I wasn't sure if there was a reason mock_open was used specifically there | 19:57 |
*** gyee has quit IRC | 19:57 | |
*** haomaiwa_ has quit IRC | 19:57 | |
melwitt | mriedem: as opposed to, does rebuild simply end up with no BDM in the current state | 19:58 |
jroll | lifeless: fwiw, fixing that test was the first time I had seen mock_open :P | 19:58 |
mriedem | melwitt: well, destroy_bdm means delete the bdm entry from the d | 19:58 |
mriedem | *db | 19:58 |
mriedem | so when rebuild tries to detach and attach later, we get BlockDeviceMappingNotFound from the db api | 19:59 |
mriedem | http://paste.openstack.org/show/281945 | 19:59 |
mriedem | melwitt: can you update the wording there and then we'll push it through and start working on backports? | 20:00 |
melwitt | mriedem: sure | 20:01 |
mriedem | I'd just say, "If True, the corresponding BDM is deleted from the database. False is useful for operations like rebuild when the BDM must be preserved." | 20:02 |
mriedem | sometihng like that | 20:02 |
mriedem | not a huge deal, i think i'd be +2 on this anyway | 20:02 |
*** haomaiwang has joined #openstack-nova | 20:03 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 20:03 |
mriedem | lifeless: thar she blar ^ | 20:03 |
*** READ10 has quit IRC | 20:06 | |
*** haomaiwa_ has joined #openstack-nova | 20:06 | |
*** mjturek1 has quit IRC | 20:06 | |
lifeless | oh yeah | 20:07 |
lifeless | 1.2 is compat with 2.6 again | 20:07 |
lifeless | folk stepped up | 20:07 |
*** dave-mccowan has quit IRC | 20:07 | |
*** haomaiwang has quit IRC | 20:08 | |
*** figleaf is now known as edleafe | 20:09 | |
*** piyanai has joined #openstack-nova | 20:10 | |
mriedem | lifeless: hrm, them it seems we could just make these two lines mock>=1.2 | 20:11 |
mriedem | https://github.com/openstack/requirements/blob/master/global-requirements.txt#L244 | 20:11 |
openstackgerrit | melanie witt proposed openstack/nova: rebuild: fix rebuild of server with volume attached https://review.openstack.org/176891 | 20:11 |
openstackgerrit | melanie witt proposed openstack/nova: rebuild: make sure server is shut down before volumes are detached https://review.openstack.org/176892 | 20:11 |
mriedem | melwitt: +2 | 20:12 |
mriedem | if you want to push that through, you only added the test right? | 20:13 |
melwitt | mriedem: yeah, I added the test_rebuild_driver_with_volumes. I wasn't sure if it's okay for me to +2 | 20:14 |
superdan | pretty safe I think | 20:14 |
mriedem | do it | 20:14 |
mriedem | i want to start squashing and backporting the fixes to stable so the tempest change gets in | 20:15 |
superdan | we should be conservative with such things, but seems legit, especially if others agree it's cool to push through | 20:15 |
melwitt | okay, just wanted to check first. :) | 20:15 |
mriedem | melwitt: generally people make a comment when approving saying what they added or changed | 20:16 |
*** haomaiwa_ has quit IRC | 20:16 | |
melwitt | mriedem: right. doing that now | 20:16 |
mriedem | to at least ack that they worked on it | 20:16 |
mriedem | ok | 20:16 |
*** dave-mccowan has joined #openstack-nova | 20:16 | |
*** jasondotstar has joined #openstack-nova | 20:16 | |
mriedem | fwiw i would have probably asked that the rebuild test added to test_compute.py was done in test_compute_mgr.py and done with mock, but i see why you did it in test_compute.py (copy of the test already in there + the volume stuff) | 20:17 |
*** lpetrut has quit IRC | 20:18 | |
melwitt | mriedem: yeah, good point | 20:19 |
*** thangp has quit IRC | 20:21 | |
*** haomaiwang has joined #openstack-nova | 20:21 | |
mriedem | cool, got the stable/kilo backport running tests now | 20:24 |
*** haomaiwang has quit IRC | 20:26 | |
*** dboik has quit IRC | 20:26 | |
*** haomaiwang has joined #openstack-nova | 20:26 | |
*** adreznec has quit IRC | 20:27 | |
*** afaranha has quit IRC | 20:28 | |
*** angdraug has joined #openstack-nova | 20:29 | |
melwitt | mgagne: I have optimism about cells compat fixes and backports because we're actively working on cells in general. and I think the majority of fixes should be simple (converting to objects on the far side) | 20:32 |
*** tongli has quit IRC | 20:34 | |
*** dims__ has quit IRC | 20:34 | |
*** adreznec has joined #openstack-nova | 20:34 | |
*** haomaiwang has quit IRC | 20:34 | |
*** lsmola has quit IRC | 20:35 | |
*** haomaiwang has joined #openstack-nova | 20:35 | |
*** raildo has quit IRC | 20:35 | |
mgagne | melwitt: ok, I managed to fix calls related to services and hypervisors | 20:36 |
*** kylek3h has quit IRC | 20:36 | |
mgagne | melwitt: we are not running tempest yet and I'm not sure if tempest covers "admin" calls | 20:36 |
*** piyanai has quit IRC | 20:36 | |
*** vladikr has quit IRC | 20:40 | |
melwitt | mgagne: cool. this is the exclusion list we use for the cells tempest job, excluding APIs not supported by cells v1 https://github.com/openstack/nova/blob/master/devstack/tempest-dsvm-cells-rc | 20:42 |
*** piyanai has joined #openstack-nova | 20:44 | |
*** piyanai has quit IRC | 20:46 | |
*** aysyd has quit IRC | 20:47 | |
kfox1111 | got a problem. have a vm that has an ephemeral disk created ext4 by the centos 7.1 host. | 20:47 |
kfox1111 | the vm itself is centos 6.6. | 20:47 |
kfox1111 | it crashed. it rebooted, and complaining it doesnt like the 64bit extention on /dev/vdb1 | 20:48 |
*** piyanai has joined #openstack-nova | 20:48 | |
*** haomaiwang has quit IRC | 20:48 | |
kfox1111 | I tried to nova rescue the vm, but it only attaches the main disk, not the ephemeral... | 20:48 |
*** Piet has quit IRC | 20:49 | |
*** haomaiwang has joined #openstack-nova | 20:51 | |
*** piyanai has quit IRC | 20:51 | |
*** dprince has quit IRC | 20:53 | |
*** bnemec has quit IRC | 20:54 | |
*** jwcroppe_ has joined #openstack-nova | 20:54 | |
openstackgerrit | Mathieu Gagné proposed openstack/nova: Fix compat support for compute cells running Juno https://review.openstack.org/203241 | 20:55 |
*** jwcroppe has quit IRC | 20:56 | |
*** haomaiwang has quit IRC | 20:56 | |
*** eharney has quit IRC | 20:57 | |
*** ijw__ has quit IRC | 20:57 | |
*** jogo is now known as flashgordon | 20:57 | |
*** edmondsw has joined #openstack-nova | 20:59 | |
*** dims_ has joined #openstack-nova | 21:00 | |
dims_ | mriedem: melwitt: one of you have some time for a oslo related review? https://review.openstack.org/#/c/192900/ (switching nova to oslo.service) thanks in advance! | 21:04 |
*** jichen has quit IRC | 21:04 | |
*** jasondotstar has quit IRC | 21:05 | |
*** haomaiwang has joined #openstack-nova | 21:11 | |
*** jecarey has quit IRC | 21:12 | |
*** htruta has quit IRC | 21:12 | |
*** y_sawai has joined #openstack-nova | 21:12 | |
*** jwcroppe has joined #openstack-nova | 21:14 | |
*** chuckcarmack has left #openstack-nova | 21:14 | |
*** jwcroppe_ has quit IRC | 21:16 | |
*** jwcroppe_ has joined #openstack-nova | 21:17 | |
*** haomaiwang has quit IRC | 21:17 | |
*** ijw_ has joined #openstack-nova | 21:18 | |
*** jwcroppe has quit IRC | 21:19 | |
*** haomaiwa_ has joined #openstack-nova | 21:21 | |
*** tomen has joined #openstack-nova | 21:21 | |
*** jwcroppe has joined #openstack-nova | 21:23 | |
*** tpeoples has quit IRC | 21:25 | |
*** jwcroppe_ has quit IRC | 21:25 | |
*** kmARC has quit IRC | 21:26 | |
*** oro has quit IRC | 21:26 | |
*** haomaiwang has joined #openstack-nova | 21:27 | |
*** dave-mccowan has quit IRC | 21:27 | |
*** dave-mccowan has joined #openstack-nova | 21:28 | |
*** jwcroppe_ has joined #openstack-nova | 21:28 | |
*** tomen has quit IRC | 21:29 | |
*** haomaiwa_ has quit IRC | 21:29 | |
*** blockedpipes has quit IRC | 21:29 | |
*** jwcroppe has quit IRC | 21:30 | |
clarkb | I am trying to fix the tempest migration tests in hpcloud because they fail on name resolution of the remote compute node. What determines the name that nova will try to resolve there? | 21:31 |
mgagne | melwitt: unfortunately, looks like what I found was only a small part of the problem. Now I'm getting timeout from juno conductor because an exception seems to be raised in the api cell: AttributeError: 'dict' object has no attribute 'obj_reset_changes' | 21:31 |
*** jasondotstar has joined #openstack-nova | 21:31 | |
clarkb | there fqdn of the test nodes are foo.novalocal and bar.novalocal which is what we have in /etc/hosts but nova tries to resolve foo and bar (just the hostname no fqdn) | 21:31 |
clarkb | superdan: ^ | 21:32 |
mgagne | clarkb: I think it's only the shortname found in the service tables. I might be wrong. | 21:32 |
*** haomaiwang has quit IRC | 21:32 | |
clarkb | ok so if I put hostname and not hostname -f in /etc/hosts that should fix it, just want to make sure that is the correct thing here (rather than configuring nova to use fqdns) | 21:33 |
superdan | clarkb: I think it's actually just using myip right? | 21:33 |
*** dave-mccowan has quit IRC | 21:33 | |
mgagne | https://github.com/openstack/nova/blob/master/nova/netconf.py#L33-L39 | 21:34 |
mgagne | I vote for that one | 21:34 |
melwitt | mgagne: you're probably hitting the instance_update_at_top in cells/messaging.py. that needs to detect non-object and create an object otherwise, I think | 21:34 |
*** ivasev has quit IRC | 21:34 | |
*** eglynn has joined #openstack-nova | 21:35 | |
*** jwcroppe has joined #openstack-nova | 21:35 | |
*** mdrabe has quit IRC | 21:35 | |
mgagne | melwitt: I already added compat code and it still fails :-/ | 21:35 |
clarkb | superdan: my_ip has a record for the fqdn in /etc/hosts too so would expect reverse lookups t use that name | 21:36 |
melwitt | mgagne: in instance_update_at_top you check "if not isinstance(instance, objects.Instance):" and convert it? | 21:36 |
clarkb | ah the dfault is socket.gethostname | 21:36 |
superdan | clarkb: can you show me logs of the failed name resolution? because I thought migration uses just myip for communication between nodes | 21:36 |
clarkb | so ya I should just remove the -f | 21:37 |
mgagne | if isinstance(instance, dict): | 21:37 |
mgagne | instance = objects.Instance._from_db_object(ctxt, | 21:37 |
mgagne | objects.Instance(), instance) | 21:37 |
clarkb | superdan: http://logs.openstack.org/25/193725/11/check/gate-tempest-dsvm-multinode-full/5029b4b/logs/subnode-2/screen-n-cpu.txt.gz?level=TRACE | 21:37 |
*** jwcroppe_ has quit IRC | 21:37 | |
clarkb | superdan: it only fails on hpcloud (not rax) because hpcloud adds a novalocal domain name via cloud-init | 21:37 |
superdan | oh live migration | 21:37 |
mriedem | melwitt: oh btw, on your nested quota ML re: keystone v3 ML - bknudson is going to be sitting in on the nova meetup at some point next week (he's local) so you should ask him about all of that then | 21:37 |
mriedem | he worked on it | 21:37 |
*** eglynn has quit IRC | 21:38 | |
melwitt | mgagne: okay. where is that error being raise then, in instance_update_from_api? | 21:38 |
mgagne | melwitt: should the code be in messaging.py ? | 21:38 |
melwitt | mgagne: yes | 21:38 |
*** eglynn has joined #openstack-nova | 21:38 | |
mgagne | melwitt: I got it wrong then | 21:38 |
melwitt | mgagne: well, I'm not sure | 21:38 |
*** haomaiw__ has joined #openstack-nova | 21:38 | |
melwitt | mgagne: that's where I would have done it but I'm not sure if doing it at cells/manager.py would/should work too | 21:39 |
mgagne | http://paste.openstack.org/show/384674/ | 21:39 |
melwitt | mriedem: oh, cool. thanks | 21:39 |
mgagne | melwitt: it's already in manager.py and it looks to have no effect | 21:39 |
*** jwcroppe_ has joined #openstack-nova | 21:40 | |
mgagne | melwitt: problem is there is no ctxt available in messaging to pass to objects.Instance._from_db_object | 21:41 |
*** jwcroppe has quit IRC | 21:42 | |
*** jwcroppe has joined #openstack-nova | 21:43 | |
*** lykinsbd has quit IRC | 21:45 | |
*** jwcroppe_ has quit IRC | 21:45 | |
melwitt | mgagne: there is as message.ctxt, I'm trying to think why what you did didn't work | 21:47 |
mgagne | melwitt: yep, just found it :D | 21:47 |
*** eglynn has quit IRC | 21:48 | |
*** haomaiw__ has quit IRC | 21:48 | |
mgagne | melwitt: manager.py is not involved at all. logging in there never shows up | 21:48 |
*** eglynn has joined #openstack-nova | 21:50 | |
*** haomaiwa_ has joined #openstack-nova | 21:50 | |
melwitt | mgagne: hm. I notice the instance_delete_everywhere is done the same way you did, so I would think that's the right way to do it. I don't know why it isn't working | 21:51 |
mgagne | melwitt: could be related to the direction (up/down) of the call | 21:51 |
mgagne | melwitt: I suspect instance_delete_everywhere is called from api cell while instance_update_at_top is called from compute cell and therefore messaging.py in called, not manager.py | 21:52 |
*** eglynn_ has joined #openstack-nova | 21:52 | |
*** Piet has joined #openstack-nova | 21:53 | |
*** mriedem has quit IRC | 21:54 | |
*** cpschult has quit IRC | 21:55 | |
mgagne | melwitt: and now it fails elsewhere http://paste.openstack.org/show/384715/ | 21:55 |
*** eglynn has quit IRC | 21:55 | |
melwitt | mgagne: that means the object thinks it has no context | 21:56 |
mgagne | ok, I used message.ctxt | 21:57 |
melwitt | mgagne: like "instance = objects.Instance._from_db_object(message.ctxt" ? | 21:58 |
mgagne | yes | 21:58 |
mgagne | if every instance "object" coming from Juno compute cell is a fict, I'm not sure how fixable that it without major work | 21:58 |
mgagne | http://paste.openstack.org/show/384717/ | 21:59 |
mgagne | dict* | 21:59 |
melwitt | hm | 21:59 |
*** piyanai has joined #openstack-nova | 22:04 | |
mgagne | ok I fixed with expected_attrs=['flavor'] | 22:04 |
openstackgerrit | Earle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 22:04 |
mgagne | now it fails elsewhere, I'm not sure if it's due to me having broken instances or what | 22:04 |
mgagne | http://paste.openstack.org/show/384719/ | 22:06 |
melwitt | mgagne: okay. I think you're going to need to add more to the expected_attrs | 22:07 |
*** MentalRay_ has quit IRC | 22:07 | |
mgagne | melwitt: sure, system_metadata ? | 22:07 |
melwitt | mgagne: if you take a look at run_compute_api_method in messaging.py, those are the common ones | 22:08 |
mgagne | melwitt: ok, what is run_compute_api_method used for? can I add instance_update_at_top to it& | 22:08 |
mgagne | hmm | 22:09 |
melwitt | mgagne: that is, in there we have something similar where we converted to objects and we're going to send an instance off to compute | 22:09 |
mgagne | coded changed since | 22:09 |
mgagne | ok so it's for downstream messages | 22:09 |
melwitt | mgagne: I just meant it has expected_attrs = ['metadata', 'system_metadata', 'security_groups', 'info_cache'] | 22:09 |
melwitt | mgagne: so I think you can do the same to prevent the commonly accessed attrs from lazy loading | 22:10 |
mgagne | alright, will try now | 22:10 |
melwitt | mgagne: and also flavor as you already ahve | 22:11 |
mgagne | now you are reading my screen =) | 22:11 |
melwitt | haha | 22:12 |
mgagne | awesome, it looks to not be falling apart anymore | 22:13 |
melwitt | mgagne: the other methods where you may see fails are instance_destroy_at_top and instance_info_cache_update_at_top. basically if you look in cells/rpcapi.py in the docstring, anything new in there that doesn't have compat code :( | 22:14 |
melwitt | mgagne: * 1.35 - Make instance_update_at_top, instance_destroy_at_top and instance_info_cache_update_at_top use instance objects | 22:15 |
mgagne | well, rpcapi is invoked from the compute cell which is running Juno. You can't update it retroactively. So compat code for those new calls need to be in messaging.py of api cell right? | 22:15 |
melwitt | mgagne: I was just saying you can know from the docstring in rpcapi.py what areas could be problematic, what changed in kilo that would be missing the compat code | 22:16 |
mgagne | sure. I'm still trying to understand how cells code is structured =) | 22:17 |
melwitt | I still don't understand the flow entirely myself. example being thinking the cells/manager.py compat code for instance_update_at_top would have worked fine | 22:18 |
*** zzzeek has quit IRC | 22:18 | |
*** y_sawai has quit IRC | 22:19 | |
*** zzzeek has joined #openstack-nova | 22:21 | |
*** davideagnello has quit IRC | 22:21 | |
*** haomaiw__ has joined #openstack-nova | 22:21 | |
*** haomaiwa_ has quit IRC | 22:22 | |
*** Nikolay_St has quit IRC | 22:23 | |
*** Nikolay_St has joined #openstack-nova | 22:24 | |
mgagne | melwitt: thank you very much for your help. I'll continue my tests and propose patches as I find more of those. | 22:25 |
*** piyanai has quit IRC | 22:26 | |
*** MVenesio has quit IRC | 22:26 | |
*** ijuwang has quit IRC | 22:27 | |
*** edmondsw has quit IRC | 22:28 | |
melwitt | mgagne: sure. sorry for all the trouble with it, and thank you for fixing and proposing the patches. I'll be reviewing them | 22:28 |
*** IanGovett has quit IRC | 22:34 | |
*** xyang2 has quit IRC | 22:39 | |
*** haomaiwa_ has joined #openstack-nova | 22:42 | |
*** haomaiw__ has quit IRC | 22:43 | |
*** jasondotstar has quit IRC | 22:44 | |
*** haomaiw__ has joined #openstack-nova | 22:45 | |
*** ctrath has quit IRC | 22:46 | |
*** haomaiwa_ has quit IRC | 22:46 | |
*** ijw_ has quit IRC | 22:48 | |
*** mgarza_ has quit IRC | 22:49 | |
*** eglynn_ has quit IRC | 22:53 | |
*** mriedem has joined #openstack-nova | 22:57 | |
*** flashgordon has quit IRC | 22:58 | |
*** haomaiw__ has quit IRC | 22:59 | |
*** haomaiwa_ has joined #openstack-nova | 22:59 | |
*** Sayaji has quit IRC | 23:01 | |
*** achanda has quit IRC | 23:04 | |
*** haomaiwa_ has quit IRC | 23:06 | |
*** annashen has quit IRC | 23:06 | |
*** ijw_ has joined #openstack-nova | 23:06 | |
*** annashen has joined #openstack-nova | 23:08 | |
*** ijw_ has quit IRC | 23:12 | |
*** haomaiwa_ has joined #openstack-nova | 23:13 | |
*** ijw_ has joined #openstack-nova | 23:13 | |
*** flashgordon has joined #openstack-nova | 23:14 | |
*** dave-mccowan has joined #openstack-nova | 23:16 | |
*** davideagnello has joined #openstack-nova | 23:17 | |
*** haomai___ has joined #openstack-nova | 23:17 | |
*** haomaiwa_ has quit IRC | 23:18 | |
*** y_sawai has joined #openstack-nova | 23:19 | |
*** davideagnello has quit IRC | 23:20 | |
*** MVenesio has joined #openstack-nova | 23:21 | |
*** MVenesio has quit IRC | 23:22 | |
*** haomai___ has quit IRC | 23:23 | |
*** y_sawai has quit IRC | 23:24 | |
*** haomaiwa_ has joined #openstack-nova | 23:25 | |
*** ijw_ has quit IRC | 23:26 | |
*** tpeoples has joined #openstack-nova | 23:30 | |
*** hemna is now known as hemnafk | 23:31 | |
*** haomaiw__ has joined #openstack-nova | 23:32 | |
*** haomaiwa_ has quit IRC | 23:33 | |
*** vilobhmm has quit IRC | 23:41 | |
*** cfriesen has quit IRC | 23:41 | |
*** haomaiw__ has quit IRC | 23:42 | |
*** pixelbeat_ has quit IRC | 23:43 | |
*** haomaiwa_ has joined #openstack-nova | 23:46 | |
*** moshele has joined #openstack-nova | 23:54 | |
*** MentalRay_ has joined #openstack-nova | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!