Wednesday, 2015-05-13

*** Raildo_ has joined #openstack-nova00:05
*** markvoelker has joined #openstack-nova00:06
*** achanda_ has joined #openstack-nova00:06
*** 92AAA7LGD has quit IRC00:09
*** 18WAABPY2 has quit IRC00:09
*** Marga_ has quit IRC00:10
*** achanda has quit IRC00:10
*** Marga_ has joined #openstack-nova00:10
*** achanda_ has quit IRC00:11
*** derekh has quit IRC00:12
*** salv-orlando has joined #openstack-nova00:15
*** annegentle has joined #openstack-nova00:17
*** otter768 has joined #openstack-nova00:21
*** garyk has joined #openstack-nova00:21
openstackgerritsajeesh cs proposed openstack/nova: Create column allocated in Quota table  https://review.openstack.org/15132700:22
*** annegentle has quit IRC00:23
*** yingjun has joined #openstack-nova00:23
*** tsekiyam_ has joined #openstack-nova00:25
*** otter768 has quit IRC00:25
*** zsais has quit IRC00:25
*** salv-orlando has quit IRC00:26
*** promulo_ has joined #openstack-nova00:26
*** mtanino has quit IRC00:27
vilobhmm1johnthetubaguy : https://review.openstack.org/#/c/138607/ whenever you are free please let me know if looks ok to you…00:28
*** david-lyle has quit IRC00:28
vilobhmm1and good to remove the X00:28
*** tsekiyama has quit IRC00:28
*** tsekiyam_ has quit IRC00:29
*** promulo__ has quit IRC00:30
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me. trying to log where urllib3 connectionpool is created  https://review.openstack.org/18249500:33
*** annegentle has joined #openstack-nova00:33
*** IanGovett has quit IRC00:40
jogowee gate is blocked00:41
*** angdraug has quit IRC00:41
*** marun has quit IRC00:48
*** jdurgin has quit IRC00:50
*** browne has quit IRC00:53
openstackgerritsajeesh cs proposed openstack/nova: Create column allocated in Quota table  https://review.openstack.org/15132700:53
*** rwsu has quit IRC00:54
*** Raildo__ has joined #openstack-nova00:54
*** ferest has joined #openstack-nova00:57
*** Raildo_ has quit IRC00:58
*** erickson has joined #openstack-nova00:59
*** ericksonfgds has quit IRC01:00
*** Nic has quit IRC01:01
*** oro has joined #openstack-nova01:01
openstackgerritsajeesh cs proposed openstack/nova: Setting the default values of resources to zero.  https://review.openstack.org/15167701:03
*** baoli has quit IRC01:10
*** oro has quit IRC01:10
*** signed8bit_ZZZzz is now known as signed8b_01:12
*** claudiub|2 has quit IRC01:12
openstackgerritsajeesh cs proposed openstack/nova: Removal of redundant context checking from wsgi.py ,which is common to all api calls  https://review.openstack.org/18214001:13
*** dave-mccowan has quit IRC01:20
*** alanf-mc has quit IRC01:20
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me. trying to log where urllib3 connectionpool is created  https://review.openstack.org/18249501:21
*** marun has joined #openstack-nova01:24
*** popw has joined #openstack-nova01:26
*** claudiub has joined #openstack-nova01:28
*** VW_ has joined #openstack-nova01:30
*** VW_ has quit IRC01:30
*** VW_ has joined #openstack-nova01:31
*** Sukhdev has joined #openstack-nova01:33
*** Raildo_ has joined #openstack-nova01:35
*** oro has joined #openstack-nova01:35
*** oro_ has joined #openstack-nova01:35
*** tobe43 has joined #openstack-nova01:38
*** Raildo__ has quit IRC01:39
*** Raildo_ has quit IRC01:39
*** mestery has quit IRC01:45
*** zzzeek has quit IRC01:47
*** erickson has quit IRC01:47
*** vilobhmm1 has quit IRC01:49
*** vilobhmm1 has joined #openstack-nova01:49
*** Sukhdev_ has joined #openstack-nova01:53
*** ferest has quit IRC01:53
*** vilobhmm1 has quit IRC01:54
*** Sukhdev has quit IRC01:54
*** slong has joined #openstack-nova01:56
*** claudiub has quit IRC02:02
*** patrickeast has quit IRC02:03
*** annegentle has quit IRC02:07
openstackgerritgaryk proposed openstack/nova: libvirt: improve logging  https://review.openstack.org/18245202:10
openstackgerritgaryk proposed openstack/nova: libvirt: use instance UUID with exception InstanceNotFound  https://review.openstack.org/18244202:10
*** erickson has joined #openstack-nova02:11
*** browne has joined #openstack-nova02:17
*** otter768 has joined #openstack-nova02:22
openstackgerritsajeesh cs proposed openstack/nova: Two roles ,namely project_admin and cloud_admin are created. For updating or deleting the quota, the user should be either project_admin or cloud_admin or admin But only admin or cloud_admin can update or delete the quota of the root project.  https://review.openstack.org/18252202:24
*** zzzeek has joined #openstack-nova02:26
*** zzzeek has quit IRC02:26
*** otter768 has quit IRC02:26
*** pixelbeat_ has quit IRC02:27
*** yingjun has quit IRC02:29
*** dave-mccowan has joined #openstack-nova02:30
*** baoli has joined #openstack-nova02:30
*** yingjun has joined #openstack-nova02:32
*** dave-mccowan has quit IRC02:38
*** yamahata has quit IRC02:39
*** annegentle has joined #openstack-nova02:40
*** annegentle has quit IRC02:41
*** baoli has quit IRC02:44
*** achanda has joined #openstack-nova02:47
*** gyee has quit IRC02:47
*** sdake has quit IRC02:51
*** dsanders has quit IRC02:54
*** oro_ has quit IRC02:54
*** oro has quit IRC02:55
*** unicell has quit IRC02:58
*** tobe43 has quit IRC02:58
*** alexpilotti has quit IRC03:00
*** signed8b_ is now known as signed8bit_ZZZzz03:01
*** baoli has joined #openstack-nova03:02
*** yamahata has joined #openstack-nova03:03
*** erickson has quit IRC03:10
*** annegentle has joined #openstack-nova03:10
*** slong has quit IRC03:12
*** dave-mccowan has joined #openstack-nova03:14
*** dave-mcc_ has joined #openstack-nova03:14
*** signed8bit_ZZZzz is now known as signed8b_03:16
*** salv-orlando has joined #openstack-nova03:17
*** signed8b_ is now known as signed8bit_ZZZzz03:17
*** dims_ has quit IRC03:18
*** annegentle has quit IRC03:20
*** links has joined #openstack-nova03:30
*** nickchase has quit IRC03:32
*** vilobhmm1 has joined #openstack-nova03:33
*** zhangtralon has joined #openstack-nova03:38
*** zhangtralon has quit IRC03:39
*** yingjun has quit IRC03:40
*** marun has quit IRC03:41
*** patrickeast has joined #openstack-nova03:42
*** salv-orlando has quit IRC03:42
*** Sree_ has joined #openstack-nova03:43
*** Jeffrey4l has quit IRC03:43
*** Sree_ is now known as Guest9477003:43
*** david-lyle has joined #openstack-nova03:48
*** asettle has joined #openstack-nova03:49
*** baoli has quit IRC03:49
*** zhangtralon has joined #openstack-nova03:49
*** oro has joined #openstack-nova03:52
*** oro_ has joined #openstack-nova03:52
*** Sukhdev_ has quit IRC03:53
*** dave-mccowan has quit IRC03:53
*** dave-mcc_ has quit IRC03:53
*** Jeffrey4l has joined #openstack-nova03:56
*** coolsvap|afk is now known as coolsvap03:56
*** deepthi has joined #openstack-nova04:04
*** salv-orlando has joined #openstack-nova04:10
*** dims has joined #openstack-nova04:18
*** otter768 has joined #openstack-nova04:22
*** ildikov has quit IRC04:23
*** salv-orlando has quit IRC04:25
*** dims has quit IRC04:25
*** zhangtralon has quit IRC04:25
*** vilobhmm1 has quit IRC04:25
*** vilobhmm1 has joined #openstack-nova04:26
*** otter768 has quit IRC04:27
*** tojuvone has joined #openstack-nova04:29
*** salv-orlando has joined #openstack-nova04:32
*** salv-orlando has quit IRC04:33
*** Guest94770 has quit IRC04:34
*** ildikov has joined #openstack-nova04:36
openstackgerritQin Zhao proposed openstack/nova: Use host AZ instead of instance AZ in scheduler request_spec  https://review.openstack.org/17426904:37
*** yingjun has joined #openstack-nova04:41
*** deepakcs has joined #openstack-nova04:41
deepakcsjohnthetubaguy: ping04:41
*** ildikov has quit IRC04:43
*** josecastroleon has joined #openstack-nova04:53
*** josecastroleon has quit IRC04:55
*** nkrinner has joined #openstack-nova04:58
*** markvoelker has quit IRC04:58
*** ildikov has joined #openstack-nova04:59
*** CongTo has joined #openstack-nova04:59
*** _gryf|afk is now known as _gryf05:01
*** CongToThanh has joined #openstack-nova05:02
*** zhangtralon has joined #openstack-nova05:02
*** CongToThanh has quit IRC05:02
*** patrickeast has quit IRC05:03
*** markvoelker has joined #openstack-nova05:06
*** ir2ivps3 has quit IRC05:06
*** unicell has joined #openstack-nova05:07
openstackgerritQin Zhao proposed openstack/nova: Raise invalid input if use invalid ip for network to attach interface  https://review.openstack.org/16289405:07
*** rook has quit IRC05:08
*** zhangtralon has quit IRC05:08
*** unicell has quit IRC05:11
*** vilobhmm11 has joined #openstack-nova05:11
*** unicell has joined #openstack-nova05:12
*** achanda_ has joined #openstack-nova05:12
*** hemna_ has joined #openstack-nova05:13
*** vilobhmm1 has quit IRC05:15
*** rook has joined #openstack-nova05:15
*** yingjun has quit IRC05:16
*** mikal_ has joined #openstack-nova05:17
*** Sree_ has joined #openstack-nova05:18
*** dosaboy_ has joined #openstack-nova05:18
*** thomasem_ has joined #openstack-nova05:19
*** Sree_ is now known as Guest2338405:19
*** mishkin___ has joined #openstack-nova05:19
*** redbeard has joined #openstack-nova05:20
*** coolsvap- has joined #openstack-nova05:23
*** ir2ivps3 has joined #openstack-nova05:24
*** bkopilov is now known as bkopilov_wfh05:24
*** fawadkhaliq has joined #openstack-nova05:24
*** eliqiao1 has joined #openstack-nova05:25
*** achanda has quit IRC05:26
*** coolsvap has quit IRC05:26
*** mishkin__ has quit IRC05:26
*** hemna has quit IRC05:26
*** anteaya has quit IRC05:26
*** thomasem has quit IRC05:26
*** eliqiao has quit IRC05:26
*** dosaboy has quit IRC05:27
*** mikal has quit IRC05:27
openstackgerritSudipta Biswas proposed openstack/nova-specs: Cleanup 'scheduled_at' from instances table  https://review.openstack.org/18012005:27
*** anteaya has joined #openstack-nova05:29
*** CongTo has quit IRC05:29
*** herch has joined #openstack-nova05:30
*** CongTo has joined #openstack-nova05:30
*** Guest23384 has quit IRC05:32
*** rook has quit IRC05:34
*** Nikolay_St has quit IRC05:34
herchhi, anyway to have multiple hypervisors on same host and still be able to manage their VMs using openstack?05:36
openstackgerritGhanshyam Mann proposed openstack/nova: Merge test_admin_actions between v2 and v2.1  https://review.openstack.org/17075405:39
openstackgerritIWAMOTO Toshihiro proposed openstack/nova: Omit RescheduledException in instance_fault.message  https://review.openstack.org/16575105:45
*** kiranr has joined #openstack-nova05:45
*** claudiub has joined #openstack-nova05:45
*** ildikov has quit IRC05:45
*** dulek has joined #openstack-nova05:48
*** josecastroleon has joined #openstack-nova05:50
openstackgerritGhanshyam Mann proposed openstack/nova: Merge V2 and V2.1 hypervisor functional tests  https://review.openstack.org/16708205:50
*** claudiub has quit IRC05:51
*** lpetrut has joined #openstack-nova05:56
*** dims has joined #openstack-nova06:01
*** yingjun has joined #openstack-nova06:02
*** kiranr is now known as kiran-r06:04
*** CongTo has quit IRC06:06
*** dims has quit IRC06:06
openstackgerritQin Zhao proposed openstack/nova: Refactor show_port() in neutron api  https://review.openstack.org/13502006:09
*** afazekas_ has joined #openstack-nova06:11
*** park_ has joined #openstack-nova06:16
*** sahid has joined #openstack-nova06:17
openstackgerritMarian Horban proposed openstack/nova: Disassociating of floating IPs corrected  https://review.openstack.org/14935806:22
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex  https://review.openstack.org/17963806:23
*** mpaolino has joined #openstack-nova06:23
*** otter768 has joined #openstack-nova06:23
openstackgerritmelanie witt proposed openstack/nova: Send Instance object to cells instance_update_at_top  https://review.openstack.org/17651806:25
*** jcoufal has joined #openstack-nova06:25
*** deepthi has quit IRC06:26
*** otter768 has quit IRC06:28
*** moshele has joined #openstack-nova06:31
*** CongTo has joined #openstack-nova06:31
*** ildikov has joined #openstack-nova06:32
*** VW_ has quit IRC06:33
openstackgerritEli Qiao proposed openstack/nova: Object: Merge db accesses for extra field of instance  https://review.openstack.org/16007606:34
*** Murali has joined #openstack-nova06:37
*** deepthi has joined #openstack-nova06:37
*** asettle has quit IRC06:38
*** VW has joined #openstack-nova06:45
*** zhangtralon has joined #openstack-nova06:49
*** lpetrut has quit IRC06:50
*** irenab has joined #openstack-nova06:51
*** pece has joined #openstack-nova06:51
*** dulek has quit IRC06:51
*** dulek has joined #openstack-nova06:51
*** kiranr has joined #openstack-nova06:54
*** achanda_ has quit IRC06:55
*** fifieldt has joined #openstack-nova06:56
*** fifieldt has quit IRC06:56
openstackgerritOleg Bondarev proposed openstack/nova: Log a warning if sec-groups and port id are provided on boot  https://review.openstack.org/15406806:56
*** kiran-r has quit IRC06:57
*** herch has quit IRC06:58
openstackgerritRoman Bogorodskiy proposed openstack/nova-specs: NIC bonding support for SRIOV ports  https://review.openstack.org/18224206:59
openstackgerritmelanie witt proposed openstack/nova: Send Instance object to cells instance_update_at_top  https://review.openstack.org/17651807:01
*** cfriesen has quit IRC07:02
*** kiranr has quit IRC07:02
*** kiranr has joined #openstack-nova07:02
openstackgerritBalazs Gibizer proposed openstack/nova-specs: Add notification for service status change  https://review.openstack.org/18235007:03
*** markus_z has joined #openstack-nova07:06
*** CongTo has quit IRC07:07
openstackgerritRui Chen proposed openstack/nova: Fix resource leaking when consume_from_instance raise exception  https://review.openstack.org/18216507:07
*** ZZelle_ has quit IRC07:08
*** ZZelle_ has joined #openstack-nova07:08
*** dulek has quit IRC07:09
*** ildikov has quit IRC07:10
*** VW has quit IRC07:13
*** jichen has joined #openstack-nova07:16
*** kiranr is now known as kiran-r07:16
*** doron_afk has joined #openstack-nova07:18
*** mpavone has joined #openstack-nova07:18
*** x3k is now known as xek07:19
*** redbeard has quit IRC07:22
*** ildikov has joined #openstack-nova07:25
*** eglynn-afk has quit IRC07:25
*** vilobhmm11 has quit IRC07:27
openstackgerritQin Zhao proposed openstack/nova: Make resize api of compute manager to send object  https://review.openstack.org/16186007:29
*** kodoku has joined #openstack-nova07:30
*** Marga_ has quit IRC07:31
*** Nikolay_St has joined #openstack-nova07:31
*** jlanoux has joined #openstack-nova07:38
*** deepthi has quit IRC07:39
*** xek has quit IRC07:40
*** xek has joined #openstack-nova07:41
*** deepthi has joined #openstack-nova07:44
*** gszasz has joined #openstack-nova07:46
*** jistr has joined #openstack-nova07:49
*** zhangtralon has quit IRC07:49
*** zhangtralon has joined #openstack-nova07:50
*** dulek has joined #openstack-nova07:50
*** danpb has joined #openstack-nova07:51
*** browne has quit IRC07:54
*** dulek has quit IRC07:55
*** mmedvede has quit IRC07:56
*** mpavone has quit IRC07:57
*** dsanders has joined #openstack-nova07:58
openstackgerritQin Zhao proposed openstack/nova: Make resize api of compute manager to send object  https://review.openstack.org/16186007:59
*** Longgeek has joined #openstack-nova08:00
*** eglynn-afk has joined #openstack-nova08:01
*** chaochin has joined #openstack-nova08:03
*** derekh has joined #openstack-nova08:03
*** mpavone has joined #openstack-nova08:04
*** mmedvede has joined #openstack-nova08:11
johnthetubaguydansmith: jogo: thanks for pushing that through for me, a hopped off after the cross project meeting08:12
openstackgerritTina Tang proposed openstack/nova: Fix in LibvirtISCSIVolumeDriver to avoid deleting incorrect device  https://review.openstack.org/18256508:12
johnthetubaguydeepakcs: I am around now (although just running downstairs for a coffee), can I help?08:13
*** ppal has joined #openstack-nova08:14
deepakcsjohnthetubaguy: reg. your comment in https://review.openstack.org/#/c/134517/7/specs/liberty/approved/volume-snapshot-improvements.rst08:15
deepakcsjohnthetubaguy: i commented back. I don't think that spec is a dep, its related tho'08:16
johnthetubaguydeepakcs: OK, thats cool, thanks08:16
*** dsanders has quit IRC08:18
bauzasjohnthetubaguy: I'm just reading the current WIP devrefs, happy with comments if they are -W ?08:18
bauzaseven if, should I say rather08:18
*** yingjun has quit IRC08:18
bauzasflavors and errors are the ones I'm digging into08:18
johnthetubaguybauzas: all comments welcome, just got the first one merged, so I was going to go back and look at those later on08:19
johnthetubaguybauzas: thats cool08:19
bauzasjohnthetubaguy: cool, will do08:19
*** eglynn-afk is now known as eglynn08:19
bauzasjohnthetubaguy: do you know the philly ops etherpad which talked about errors ?08:19
*** haypo has joined #openstack-nova08:19
bauzasjohnthetubaguy: https://etherpad.openstack.org/p/PHL-ops-nova-feedback08:20
johnthetubaguybauzas: I read it one upon a time, about the "self debugging" stuff, thats partly what the summit session hopes to cover08:20
johnthetubaguybauzas: just nipping to get a coffee, brb08:20
bauzasjohnthetubaguy: okay, I thought I would probably add some comments on the errors devref change to make it clearer08:20
bauzasjohnthetubaguy: sure thing, you had short night08:20
kashyapIt'd be nice the plain text exported versions of these are posted somewhere for permanancy. Etherpads are very sluggish.08:21
kashyaps/the/if the08:21
bauzaskashyap: dansmith told me once how to make those plain text, sec08:21
*** oro_ has quit IRC08:21
kashyapJust export it.08:21
*** oro has quit IRC08:21
bauzaskashyap: yeah https://etherpad.openstack.org/p/PHL-ops-nova-feedback/export/txt08:23
kashyapYep. The point being, over the period of a cycle plenty of these will be accumulated, searching Etherpads for that one bit of info will become cumbersome. . .08:23
*** otter768 has joined #openstack-nova08:24
sahiddanpb: about the work on libvirt, i'm working on making Host.get_domain to return a Guest object, is that makes sense for you or do you think it will be better to keep sepration between Host and Guest?08:24
*** nihilifer has joined #openstack-nova08:25
*** otter768 has quit IRC08:29
*** lucasagomes has joined #openstack-nova08:29
*** kodoku has quit IRC08:30
johnthetubaguybauzas: comments are good, I wrote that on an ipad on a train, so its not exactly ready yet, but comments would be good08:31
bauzasjohnthetubaguy: yeah, my comments are really on how we structure those docs08:32
bauzasjohnthetubaguy: IMHO that should be both a reference document and guidelines for future changes08:32
bauzasjohnthetubaguy: like a manifesto for improvement08:32
johnthetubaguybauzas: thats the plan, it doesn't have the second bit written yet08:33
bauzasjohnthetubaguy: not exactly as detailed as a spec, but at least covering the limitations and stating the possible efforts08:33
johnthetubaguybauzas: I was hoping to have the "current" state merged before the summit, but well, thats not happening08:33
bauzasjohnthetubaguy: ok, then I just braindumped a few things08:33
*** oro_ has joined #openstack-nova08:33
*** oro has joined #openstack-nova08:33
bauzasjohnthetubaguy: IMHO those docs are good for providing contributors a way to improve Nova on a consensual thing08:34
johnthetubaguybauzas: +1 hoping to do loads more of these08:35
bauzasjohnthetubaguy: yeah I like the idea08:35
*** Jeffrey4l has quit IRC08:36
bauzasjohnthetubaguy: and you have all my credits for having proposed a change to the architectural diagram08:36
bauzasjohnthetubaguy: for that, I mean, it was just *necessary*08:36
johnthetubaguycools08:37
openstackgerritRui Chen proposed openstack/python-novaclient: server-group-list support 'all_projects' parameter  https://review.openstack.org/18256808:38
openstackgerritNisha Agarwal proposed openstack/nova-specs: Nova and Ironic-virt-driver to support json list  https://review.openstack.org/18257208:42
*** dguitarbite has joined #openstack-nova08:43
openstackgerritLan Qi Song proposed openstack/nova: Remove useless volume when boot from volume failed  https://review.openstack.org/17708408:46
*** Jeffrey4l has joined #openstack-nova08:47
openstackgerritsahid proposed openstack/nova: libvirt: make _create_domain to return a Guest object  https://review.openstack.org/18218508:49
openstackgerritsahid proposed openstack/nova: libvirt: introduce method shutdown to Guest object  https://review.openstack.org/18219408:49
openstackgerritsahid proposed openstack/nova: libvirt: introduce method resume to Guest object  https://review.openstack.org/18219508:49
openstackgerritsahid proposed openstack/nova: libvirt: introduce a Guest to wrap around virConnect  https://review.openstack.org/17431308:49
openstackgerritsahid proposed openstack/nova: libvirt: introduce method get_guest to Host object  https://review.openstack.org/18196908:49
*** josecastroleon has quit IRC08:50
sahidjohnthetubaguy: hello, any chance you take a look at my coments on the spec here https://review.openstack.org/#/c/165838/ ?08:51
*** sudipto has joined #openstack-nova08:51
*** yingjun has joined #openstack-nova08:51
*** ericksonfgds has joined #openstack-nova08:52
johnthetubaguysahid: so the token as a hash thing08:53
gilliardalex_xu: are you there?08:53
johnthetubaguysahid: I was thinking, if you have the token in the DB, and you get access to the DB, you could use the token08:53
johnthetubaguysahid: if you get access to only the hash, its no use to the attaker08:53
*** josecastroleon has joined #openstack-nova08:54
danpbsahid: yes, I would like Host to return Guest instances, instead of returning libvirt.virDomain instances08:55
deepakcsjohnthetubaguy: thanks for +2ing the spec patch08:55
danpbsahid: as that matches our general goal that we isolate the places which talk to the libvirt python module in just host.py and guest.py08:55
sahidjohnthetubaguy: ok so the token will be in "clear" on when the user call the API to retrieve it.. I understand now08:55
danpbthe rest of the nova code should exclusively use the Host and Guest classes and not the libvirt python classes08:56
johnthetubaguysahid: maybe I don't get how that all works, but I was more thinking about people looking at the tokens on the disk08:56
sahidjohnthetubaguy: well mysqk store data in binary i do not believe it easy to read token on the disk08:57
sahidi mean it's probably more dificult than read them from memcached08:57
johnthetubaguysahid: did you see some else also had suggested storing this in the DB08:58
sahidjohnthetubaguy: you mena the other spec you have pointed ?08:58
johnthetubaguysahid: its on the disk, you can read that in many many ways, memcache you need to get access to the memory while it contains the tokens, I would thinking the exact opposite08:58
sahidmena/mean08:58
johnthetubaguysahid: yep08:59
sahidjohnthetubaguy: memcched do not provide any security layer,you can just use the api on the host08:59
sahidwe ctually use the instance_uuid as key08:59
johnthetubaguysahid: right, thats a deployment problem, easily fixed08:59
sahidjohnthetubaguy: but yes you solution about using a hash i interesting09:00
sahidyour09:00
sahidis09:00
sahidi will refer it on the spec09:00
johnthetubaguysahid: so if we need to give back users tokens we already have in the DB, then a hash would not work, unless each request gets a new token (which honestly, is my preference)09:00
johnthetubaguysahid: the problem is storing the token on disk, rather than it just living in memory, thats quite a change, security wise09:01
sahidjohnthetubaguy: ok by you solution we will improve the security and it is something important we can do09:01
sahidsure09:01
johnthetubaguysahid: well, we should get a security team expert to review this09:01
johnthetubaguysahid: probably need to add a salt to the hash, etc09:01
sahidyes..09:02
sahidlet me rework the spec to add your thinking and we will see09:02
*** doron_afk is now known as doron09:03
sahiddanpb: cool that is what i was thinking but i wanted to get your advice09:04
sahiddanpb: i have started this work here https://review.openstack.org/#/c/181969/09:04
danpbyes, just saw that09:06
johnthetubaguysahid: FWIW, for the folks that like using memcache, I worry about us just dropping that support here, and using the DB instead, but I like the idea of the DB as the new default09:06
*** ajo has joined #openstack-nova09:07
ajobauzas ping09:07
ajoquick question09:07
openstackgerritBalazs Gibizer proposed openstack/nova: scheduler:refactor group info in filter_properties  https://review.openstack.org/14827509:07
openstackgerritBalazs Gibizer proposed openstack/nova: api: add soft-affinity policies for server groups  https://review.openstack.org/14752009:07
openstackgerritBalazs Gibizer proposed openstack/nova: Add functional tests to soft affinity capabilities  https://review.openstack.org/14752109:07
openstackgerritBalazs Gibizer proposed openstack/nova: scheduler: add num of instance per host in a group  https://review.openstack.org/14827709:07
openstackgerritBalazs Gibizer proposed openstack/nova: object:count members per hosts in InstanceGroup  https://review.openstack.org/14751709:07
ajois there a way to force nova to start an instance in a certain compute node?09:07
bauzasajo09:07
bauzasajo: yup09:08
sahidjohnthetubaguy: yes, i'm thinking - if we want to keep working both that mean maintenant the old code + add support for the framework objects and make them working together09:08
kashyapajo: I was testing something like that yesterday:09:08
bauzasajo: --availability-zone=nova:host09:08
*** Jeffrey4l has quit IRC09:08
kashyap$ nova boot --config-drive false --flavor 1 --key_name oskey1 --image cirros-0.3.3-x86_64-disk --availability-zone=nova:devstack3 cirrvm11-as-demo09:08
ajobauzas++09:08
ajothanks, I was in a run09:08
ajothanks kashyap  :)09:08
ajoyou're awesome guys :)09:09
kashyapajo: Note that it only works as an admin role.09:09
*** dulek has joined #openstack-nova09:09
johnthetubaguysahid: we can refactor the old memcache code to like like a DB API, then just switch in and out the DB API used by the objects right?09:09
johnthetubaguysahid: at least thats what I was thinking about when I was suggesting we support both09:09
openstackgerritNisha Agarwal proposed openstack/nova-specs: Add IronicFilter for ironic act-upon capabilities  https://review.openstack.org/18258109:10
*** Jeffrey4l has joined #openstack-nova09:10
johnthetubaguysahid: now we could deprecate the memcache support when you add the DB support, I am OK with that, its the removing it without deprecating (and a chance for feedback) that worries me09:12
sahidjohnthetubaguy: well yes problably i do not know if "just switch un and out DB API" is the good term here but yes it's probably the way to follow :)09:13
johnthetubaguysahid: :) "persistence layer" maybe, but yeah09:13
sahidjohnthetubaguy: please comment on the review your thinking on the hash point and memcache support like that i will take the time to investigate how we can do that09:15
sahidto keep a trace09:15
johnthetubaguysahid: yeah, I added comments while we were talking here, let me know if I missed something09:16
sahidsure thank you09:17
johnthetubaguysahid: the tokens have an expiry time, which helps reduce the impact of not doing the hash, but it would be good to talk about rejecting the idea in the alternatives if its not practical09:17
openstackgerritVictor Stinner proposed openstack/nova: Replace iter.next() with next(iter)  https://review.openstack.org/17982109:18
sahidjohnthetubaguy: well from how i see that we can probably do it, but yes we need to investigate to see if no blockers09:18
*** ankit_ag has joined #openstack-nova09:19
sudiptobauzas, Hi, i was looking at scrubbing through some of the old Nova defects and found this. https://bugs.launchpad.net/nova/+bug/1369818 I actually think this is fixed in some form in Kilo. Your thoughts?09:20
openstackLaunchpad bug 1369818 in OpenStack Compute (nova) "Nova show will not display NoValidHost with right exception traces" [Medium,Confirmed] - Assigned to Sudipta Biswas (sbiswas7)09:20
johnthetubaguysahid: cool, I am guessing it might mean we generate a new token for every request for a token, while wasteful, I quite like it09:20
*** ericksonfgds has quit IRC09:20
openstackgerritVictor Stinner proposed openstack/nova: Fix raise syntax for Python 3  https://review.openstack.org/17994609:27
*** dulek has quit IRC09:28
*** dulek has joined #openstack-nova09:29
Anticimexdoes nova-api, nova-compute and nova-conductor's MQ client libs handle multiple MQ endpoints?09:32
openstackgerritsahid proposed openstack/nova: libvirt: introduce method poweroff to Guest object  https://review.openstack.org/18219409:35
openstackgerritsahid proposed openstack/nova: libvirt: introduce method resume to Guest object  https://review.openstack.org/18219509:35
*** dims has joined #openstack-nova09:35
*** fawadkhaliq has quit IRC09:36
*** yingjun has quit IRC09:37
*** doron is now known as doron_afk09:39
*** apuimedo has joined #openstack-nova09:40
*** 5EXAA60VI has quit IRC09:40
*** dims has quit IRC09:40
openstackgerritVictor Stinner proposed openstack/nova: Avoid useless copy in get_instance_metadata()  https://review.openstack.org/18259609:40
*** gszasz has quit IRC09:41
*** ildikov has quit IRC09:48
johnthetubaguyAnticimex: sorry, not sure I understand your question, do you mean having multiple queuing servers?09:52
Anticimexyes09:53
Anticimexe.g. pointing to multiple endpoints of the same MQ cluster09:53
*** CongTo has joined #openstack-nova09:53
openstackgerritMichal Rostecki proposed openstack/nova: Create a reserved aggregate filter  https://review.openstack.org/17875009:54
*** tojuvone has quit IRC09:55
openstackgerritNisha Agarwal proposed openstack/nova-specs: Add IronicFilter for ironic act-upon capabilities  https://review.openstack.org/18258109:56
openstackgerritNisha Agarwal proposed openstack/nova-specs: Nova and Ironic-virt-driver to support json list  https://review.openstack.org/18257209:59
*** moshele has quit IRC10:00
*** tojuvone has joined #openstack-nova10:00
*** moshele has joined #openstack-nova10:01
*** dims has joined #openstack-nova10:01
*** lpetrut has joined #openstack-nova10:02
*** ildikov has joined #openstack-nova10:03
*** IanGovett has joined #openstack-nova10:06
sudiptojohnthetubaguy, bauzas I actually found somewhat of a miss match while investigating the bug 1369818...It appears that there's a bit of an inconsistency in the way we show the "NoValidHost" exception to the user. in the scheduler/filter_scheduler.py - while raising the exception - we are saying we shouldn't include much information about the environment to the user. But at the same time, in the nova/scheduler/utils.py - if the max_attempts have e10:07
openstackbug 1369818 in OpenStack Compute (nova) "Nova show will not display NoValidHost with right exception traces" [Medium,Confirmed] https://launchpad.net/bugs/1369818 - Assigned to Sudipta Biswas (sbiswas7)10:07
sudiptoxceeded - we are showing the full stack details of what went wrong with the last host - as a part of the exception...10:07
johnthetubaguysudipto: yeah, we shouldn't be giving the user a full stack trace10:07
johnthetubaguysudipto: but we want that in notifications and instance_faults, etc10:08
*** jamielennox is now known as jamielennox|away10:08
johnthetubaguysudipto: its a mess around that error, been meaning to take a closer look for a little while now10:08
bauzasjohnthetubaguy: sudipto: there is another bug that mentions that10:08
bauzassudipto: https://bugs.launchpad.net/nova/+bug/143129110:09
openstackLaunchpad bug 1431291 in OpenStack Compute (nova) "Scheduler Failures are no longer logged with enough detail for a site admin to do problem determination" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza)10:09
sudiptojohnthetubaguy, bauzas ok - https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L16510:09
bauzassudipto: the main problem is how the scheduler can know the instance.uuid he is working on10:09
*** doude has joined #openstack-nova10:09
bauzassudipto: IMHO you're working on a bug that needs further discussion10:10
sudiptobauzas, Yup - so i pinged you earlier :D10:10
bauzassudipto: we should be discussing on how to improve that feedback during the Summit10:10
sudiptobauzas, :( won't be at the summit but i will probably talk to you on IRC10:11
bauzassudipto: yeah, I have ideas and POCs, but I need to share that with the team10:11
bauzassudipto: what johnthetubaguy explained is one of the things that I would see improvements10:11
bauzassudipto: ie. instance faults10:11
bauzassudipto: the story is like this, the scheduler doesn't know which instances he has to decide10:12
bauzassudipto: so, he runs thru all the filters and give back to the conductor a list of hosts or None10:12
johnthetubaguybauzas: I think thats the wrong way around, the conductor needs to do the error handling for the error the scheduler returns, but its a little mixed up right now I suspect10:13
bauzasjohnthetubaguy: that's exactly what I'm writing :)10:13
johnthetubaguybauzas: I think you are mixing up returning zero hosts, and retrying three times due to exceptions10:13
bauzasjohnthetubaguy: but the conductor doesn't know what happened in the scheduler10:13
johnthetubaguyagreed10:13
bauzasjohnthetubaguy: that's another story10:13
johnthetubaguybauzas: agreed, but its the same error right now, which is a big issue, having those errors different would be a good step forward by its-self10:14
bauzasjohnthetubaguy: having a same NoValidHost exception is confusing10:14
bauzaseh, jinxed10:14
johnthetubaguy:)10:14
*** gszasz has joined #openstack-nova10:15
johnthetubaguybauzas: turns out they look slightly different right now, but they should be totally different10:15
bauzasagreed10:15
sudiptothere's one more case I see (and excuse my little knowledge) - the conductor/manager.py - has the build_instances method. I have a total of 2 hosts and my max_retries is set to > 2. In such a case, even though we exhaust the 2 hosts to try on and fail in conductor - we still end up calling the scheduler_client.select_destinations method.10:15
sudiptoit probably is just an optimization - but still...10:15
bauzassudipto: compute.build_instances() will burn in hell soon10:16
sudiptobauzas, Ah i see..10:16
sudiptobauzas, So for the time being, I guess i should just hold on to the bug i have and wait for your discussion at the summit for a way forward.10:16
bauzassudipto: well, the problem is that it's not trivial to fix :/10:17
bauzasI mean, fixing that correctly10:17
sudiptobauzas, yeah i just started debugging a few bugs based on an area interest per johnthetubaguy 's suggestion and ended up in this place, where i quite frankly had to struggle a bit to get the hang of what was going on here.10:17
bauzassudipto: that's all your honor, sir.10:18
sudiptobauzas, I'd be interested if you guys come to some conclusion during the summit and need some volunteers. I wouldn't be there sigh!10:18
bauzassudipto: sure thing10:18
*** dulek has quit IRC10:19
bauzasjohnthetubaguy: oh I see why you thought I made a confusion, since I was explaining the single scheduler failure story10:20
sudiptojohnthetubaguy, bauzas  on a separate area, why do we have these auth urls in the nova.conf - instead of retrieving them from the service catalog?10:23
*** wanghao has quit IRC10:25
*** melwitt has quit IRC10:25
*** josecastroleon1 has joined #openstack-nova10:25
*** otter768 has joined #openstack-nova10:25
openstackgerritjichenjc proposed openstack/nova: Change group controller of V2 test cases  https://review.openstack.org/18261310:25
openstackgerritjichenjc proposed openstack/nova: Add schema check for security_groups  https://review.openstack.org/18261410:25
*** wanghao has joined #openstack-nova10:25
*** jhesketh has quit IRC10:25
*** wendar has quit IRC10:25
*** gus has quit IRC10:25
johnthetubaguysudipto: sometimes you want to use a different one to the user catalog, mostly just because that was easy at the time. Defaulting to the service catalog might make a lot of sense as a spec10:25
*** wendar_ has joined #openstack-nova10:25
*** GLaupre has quit IRC10:26
*** gszasz has quit IRC10:26
*** jbernard has quit IRC10:26
*** obondarev_ has quit IRC10:26
sudiptojohnthetubaguy, ok...10:27
*** tlbr has quit IRC10:27
sudiptojohnthetubaguy, so it's mostly a evolution problem.10:27
*** obondarev has joined #openstack-nova10:27
*** melwitt has joined #openstack-nova10:28
*** mikal_ has quit IRC10:28
*** mikal has joined #openstack-nova10:28
*** josecastroleon has quit IRC10:28
johnthetubaguysudipto: its mostly something no one has cared enough about to fix / think through10:28
*** Vek has quit IRC10:28
*** dulek has joined #openstack-nova10:28
sudiptojohnthetubaguy, ok..10:29
*** josecastroleon1 has quit IRC10:29
*** xgsa has quit IRC10:30
*** promulo_ has quit IRC10:30
*** otter768 has quit IRC10:30
*** promulo_ has joined #openstack-nova10:30
*** xgsa has joined #openstack-nova10:30
*** jhesketh has joined #openstack-nova10:31
johnthetubaguysudipto: would be happy to see that config sorted out though10:31
johnthetubaguysudipto: really looking for someone to go through and tag all the config variables with a classification, or something similar10:32
*** EmilienM has quit IRC10:33
*** danieru has quit IRC10:33
sudiptojohnthetubaguy, ok i can give it a shot.10:33
*** tlbr has joined #openstack-nova10:33
*** ekarlso has quit IRC10:33
*** gus has joined #openstack-nova10:33
*** pixelbeat_ has joined #openstack-nova10:33
*** danieru has joined #openstack-nova10:34
*** EmilienM has joined #openstack-nova10:35
*** jbernard has joined #openstack-nova10:36
*** deepthi has quit IRC10:37
openstackgerritsahid proposed openstack/nova: libvirt: make _create_domain to return a Guest object  https://review.openstack.org/18218510:40
openstackgerritsahid proposed openstack/nova: libvirt: introduce method poweroff to Guest object  https://review.openstack.org/18219410:40
openstackgerritsahid proposed openstack/nova: libvirt: introduce method resume to Guest object  https://review.openstack.org/18219510:40
openstackgerritsahid proposed openstack/nova: libvirt: introduce method get_guest to Host object  https://review.openstack.org/18196910:40
*** ekarlso has joined #openstack-nova10:40
*** cbader has quit IRC10:41
*** deepakcs has quit IRC10:41
*** mpaolino has quit IRC10:44
*** ekarlso has quit IRC10:45
*** ekarlso has joined #openstack-nova10:45
openstackgerritStuart McLaren proposed openstack/nova: Add explicit dependency on python-keystoneclient  https://review.openstack.org/18196610:47
johnthetubaguybauzas: what do you mean by "context request id is not persisted"?10:49
*** zhangtralon has quit IRC10:49
*** dulek has quit IRC10:50
*** dulek has joined #openstack-nova10:50
openstackgerritJohn Garbutt proposed openstack/nova: devref: discuss current state of error handling  https://review.openstack.org/17863510:51
*** dulek_ has joined #openstack-nova10:53
*** dulek_ has quit IRC10:53
*** dulek_ has joined #openstack-nova10:54
*** dulek has quit IRC10:54
*** kmartin has quit IRC10:56
*** lucasagomes is now known as lucas-afk10:57
ekarlsojohnthetubaguy: heya11:00
ekarlsojohnthetubaguy: you up for a nova q ?11:00
*** asselin has quit IRC11:01
*** ildikov has quit IRC11:02
johnthetubaguyekarlso: sure11:06
*** moshele has quit IRC11:07
openstackgerritMikhail Feoktistov proposed openstack/nova: Virtuozzo instance resize support  https://review.openstack.org/18225711:11
*** bfic has joined #openstack-nova11:12
*** ociuhandu has joined #openstack-nova11:13
*** ildikov has joined #openstack-nova11:17
*** Jeffrey4l has quit IRC11:22
*** salv-orlando has joined #openstack-nova11:28
*** moshele has joined #openstack-nova11:29
*** sahid has quit IRC11:31
*** VW has joined #openstack-nova11:31
*** VW has quit IRC11:32
*** VW has joined #openstack-nova11:32
*** sahid has joined #openstack-nova11:34
*** mjturek1 has joined #openstack-nova11:34
*** tobe4333 has joined #openstack-nova11:35
*** atuvenie has joined #openstack-nova11:36
*** josecastroleon has joined #openstack-nova11:36
*** salv-orlando has quit IRC11:37
*** moshele has quit IRC11:38
*** Jeffrey4l has joined #openstack-nova11:38
*** moshele has joined #openstack-nova11:39
openstackgerritMikhail Feoktistov proposed openstack/nova: Virtuozzo instance resize support  https://review.openstack.org/18225711:40
*** coolsvap- is now known as coolsvap|afk11:41
*** salv-orlando has joined #openstack-nova11:43
*** IanGovett has quit IRC11:43
*** artom has joined #openstack-nova11:46
*** mwagner_lap has quit IRC11:46
*** yamahata has quit IRC11:48
*** IanGovett has joined #openstack-nova11:49
openstackgerritjichenjc proposed openstack/nova: Cleanup HTTPRequest for security_groups test  https://review.openstack.org/18263011:52
*** sdake has joined #openstack-nova11:54
*** dprince has joined #openstack-nova11:54
openstackgerritHans Lindgren proposed openstack/nova: Remove unused refresh_security_group_members() call  https://review.openstack.org/18263211:55
openstackgerritHans Lindgren proposed openstack/nova: Make security group refresh with refresh_instance_security_groups()  https://review.openstack.org/18263311:55
*** kiran-r has quit IRC11:55
*** tobe4333 has quit IRC11:57
Anticimexjohnthetubaguy: found my answer on http://docs.openstack.org/juno/config-reference/content/configuring-rpc.html i believe11:58
Anticimexjohnthetubaguy: rabbit_hosts = $rabbit_host:$rabbit_port      (ListOpt) RabbitMQ HA cluster host:port pairs. -- seems right?11:58
*** IanGovett1 has joined #openstack-nova11:58
*** sdake has quit IRC11:59
*** igordcard_ has quit IRC11:59
*** igordcard_ has joined #openstack-nova11:59
*** sdake has joined #openstack-nova12:00
*** IanGovett has quit IRC12:01
bauzasjohnthetubaguy: I mean req-id12:01
bauzasjohnthetubaguy: in the logs, you can see req-id but you have no way to see req-id in the instance object12:02
bauzasjohnthetubaguy: just because it's the context request-id which is not persisted AFAICS12:02
*** derekh_ has joined #openstack-nova12:08
*** derekh has quit IRC12:12
*** CongTo has quit IRC12:12
openstackgerritLee Yarwood proposed openstack/nova: Multipath commands with error messages in stdout fail to parse  https://review.openstack.org/17266012:12
*** aix has joined #openstack-nova12:13
*** signed8bit_ZZZzz has quit IRC12:14
johnthetubaguyAnticimex: that sounds about right, we share the same oslo_messaging code as other projects, so hopefully its consistent between all the projects12:15
johnthetubaguybauzas: not sure what you mean by "see req-id in the instance object"?12:15
bauzasjohnthetubaguy: so, when looking at logs, we have the context provided for each line, right?12:17
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Ignore me. trying to log where urllib3 connectionpool is created  https://review.openstack.org/18249512:17
bauzasjohnthetubaguy: something like req-edd46208-48f5-45cb-af7e-1f45b93b39b212:17
johnthetubaguybauzas: right, for each API request you can track logs between all the different services, and between logs and notifications, and instance_actions in the DB also use request-id, for the ones that are tracked that way12:18
bauzasjohnthetubaguy: right, my point is : request-id is not persisted when you nova show an instance12:18
bauzasjohnthetubaguy: so, given you have an ERROR when booting an instance, you can see the last trace and the UUID12:19
bauzasjohnthetubaguy: using nova show12:19
johnthetubaguybauzas: its can't be, you can find some of them with nova list-instance-actions or something like that12:19
bauzasjohnthetubaguy: IMHO having the req-id provided when doing a nova show would help operators to query the logs using this req-id12:20
johnthetubaguybauzas: it can't. thats my point12:20
bauzasjohnthetubaguy: it can't, but why ?12:20
johnthetubaguybauzas: you could show the last request id, but there is a request id for every single API request you make12:20
johnthetubaguybauzas: instance actions shows the related request ids for each instance12:21
bauzasjohnthetubaguy: then I have to doublecheck12:21
johnthetubaguybauzas: I am going to start with this stuff in the error doc, in the process of re-writing it all12:23
bauzasjohnthetubaguy: oooooh I see now in the client, that's a contrib module12:24
bauzasjohnthetubaguy: /os-instance-actions/12:24
* bauzas is just lost with all the extensions we have12:24
*** mwagner_lap has joined #openstack-nova12:25
*** Vek has joined #openstack-nova12:25
bauzasjohnthetubaguy: thanks for that, I see it's done http://developer.openstack.org/api-ref-compute-v2-ext.html12:25
*** Jeffrey4l has quit IRC12:25
bauzasjohnthetubaguy: apologize for that, I never found it accessible12:26
*** cbader has joined #openstack-nova12:26
*** vladikr has joined #openstack-nova12:26
*** otter768 has joined #openstack-nova12:26
johnthetubaguybauzas: its not really tested or complete, thats a different, but important issue!12:26
bauzasjohnthetubaguy: yeah, since it was in the contib path for the client and only part of the extension for the API, I missed it12:27
bauzasjohnthetubaguy: I just wonder that while it's not our duty to do that, we shouldn't provide a doc saying how to troubleshootr12:28
Anticimexjohnthetubaguy: yeah, in http://www.severalnines.com/blog/high-availability-openstack-shoestring-budget-deploying-minimal-3-node-cluster they claim to configure it this way, so I assume it does work.  will know in a bit12:28
openstackgerritTina Tang proposed openstack/nova: Fix in LibvirtISCSIVolumeDriver to avoid deleting incorrect device  https://review.openstack.org/18256512:28
johnthetubaguyAnticimex: there is a doc on this somewhere… http://docs.openstack.org/high-availability-guide/content/index.html12:29
Anticimexah, crap.  you are right12:30
johnthetubaguybauzas: thats totally our duty12:30
Anticimexi've been in the HA doc several times12:30
Anticimexnot sure how i have missed it12:30
bauzasjohnthetubaguy: then, we can discuss that at the Ops-related session12:30
johnthetubaguyAnticimex: not sure if that has what you need, but we should patch that doc if its missing :)12:30
bauzasjohnthetubaguy: because I'm sometimes lagging behind our API capabilities12:31
*** dulek_ has quit IRC12:31
*** otter768 has quit IRC12:31
johnthetubaguybauzas: well, sadly is basically useless right now and needs fixing12:31
Anticimexjohnthetubaguy: active/active, "Configure OpenStack services to use RabbitMQ" starts with "rabbit_hosts = ..."12:31
bauzasjohnthetubaguy: and the API microversion should unleash the power12:31
Anticimexexactly what I was looking for12:31
Anticimexdidn't turn up in google though :)12:31
openstackgerritjichenjc proposed openstack/nova: Cleanup HTTPRequest for security_groups test  https://review.openstack.org/18263012:31
johnthetubaguybauzas: we have tight tracking of the notifications which fils in the gaps quite well, thats the current way to deal with this12:31
*** moshele has quit IRC12:31
johnthetubaguybauzas: yup12:32
*** alexpilotti has joined #openstack-nova12:32
*** aysyd has joined #openstack-nova12:33
*** annegentle has joined #openstack-nova12:34
*** mpaolino has joined #openstack-nova12:34
*** Jeffrey4l has joined #openstack-nova12:39
*** salv-orlando has quit IRC12:39
*** matrohon has joined #openstack-nova12:41
*** dave-mccowan has joined #openstack-nova12:42
*** mestery has joined #openstack-nova12:44
*** READ10 has joined #openstack-nova12:44
*** moshele has joined #openstack-nova12:45
*** annegentle has quit IRC12:45
openstackgerritNoel Nelson Dsouza proposed openstack/nova: Nova can stop instance when Fake/Actual compute driver used  https://review.openstack.org/18265012:45
*** annegentle has joined #openstack-nova12:46
*** gszasz has joined #openstack-nova12:47
*** cds has joined #openstack-nova12:48
cdsany nova devs free to look at https://bugs.launchpad.net/nova/+bug/1450291 ? blocking people from upgrading versions atm12:49
openstackLaunchpad bug 1450291 in OpenStack Compute (nova) "nova-manage db sync not committing to database" [Undecided,New]12:49
*** kiran-r has joined #openstack-nova12:51
johnthetubaguycds: I just marked it as critical, in the hope we can get some attention on that12:52
cdsthank you, apprecite it :)12:52
cdsappreciate*12:53
*** tojuvone has quit IRC12:55
johnthetubaguymikal: dansmith: any ideas what could be happening here, given the test we do in turbo hipster? seems like nova-manage db sync fails: https://bugs.launchpad.net/nova/+bug/145029112:56
openstackLaunchpad bug 1450291 in OpenStack Compute (nova) "nova-manage db sync not committing to database" [Critical,Confirmed]12:56
johnthetubaguymriedem: this one ^ probably needs stable branch attention at somepoint, I tagged it for backport, I guess thats what you want to track these things?12:57
openstackgerritDmitry Guryanov proposed openstack/nova: libvirt: resize ploop disks with prl_disk_tool  https://review.openstack.org/18239013:00
*** lucas-afk is now known as lucasagomes13:01
johnthetubaguycds: have you reproduced that bug at all, I wonder if its a config error thats hidden by the config logging looking a bit broken?13:01
alex_xugilliard: I'm here13:03
*** bkopilov_wfh has quit IRC13:04
*** baoli has joined #openstack-nova13:05
*** baoli has quit IRC13:05
*** nkrinner has quit IRC13:06
*** annegentle has quit IRC13:06
*** bkopilov_wfh has joined #openstack-nova13:07
alex_xujohnthetubaguy: should I metion this https://review.openstack.org/127863 in api session etherpad?13:07
*** annegentle has joined #openstack-nova13:07
openstackgerritPranali Deore proposed openstack/nova: Unshelving volume backed instance fails  https://review.openstack.org/17003113:07
*** baoli_ has joined #openstack-nova13:07
mriedemjohnthetubaguy: yeah, needs a fix on master first :)13:09
johnthetubaguymriedem: totally13:09
*** claudiub has joined #openstack-nova13:10
*** mriedem has quit IRC13:10
*** mriedem has joined #openstack-nova13:11
*** eglynn has quit IRC13:12
johnthetubaguyalex_xu: this is the one for the API session, yes totally the sort of good stuff to add I feel: https://etherpad.openstack.org/p/YVR-nova-api-2.1-in-liberty13:12
*** redbeard has joined #openstack-nova13:13
alex_xujohnthetubaguy: ok, got it, thanks13:13
*** baoli has joined #openstack-nova13:14
*** cds has quit IRC13:16
*** baoli_ has quit IRC13:16
claudiubmriedem: hello. Can you take a look at a bugfix? You already did a review a couple of days ago, it already had a +2, it should be ready to go. :) https://review.openstack.org/#/c/181916/13:21
mriedemclaudiub: gate is a bit busted atm so i'm looking at that first13:22
openstackgerritRadoslav Gerganov proposed openstack/nova: VMware: verify vCenter server certificate  https://review.openstack.org/17972813:22
claudiubmriedem: sure, take your time. :)13:22
*** romainh has joined #openstack-nova13:23
openstackgerritRadoslav Gerganov proposed openstack/nova: VMware: Handle image size correctly for OVA and streamOptimized images  https://review.openstack.org/16802413:25
johnthetubaguyclaudiub: I wonder if you could start a list of the top 3 to 5 most important patches that are ready for wider review, once you folks as a hyper-v subteam have done lots of reviews on the patches, in gerrit, and are happy with the code?13:25
claudiubjohnthetubaguy: I'd be happy to.13:26
*** sudipto has quit IRC13:27
openstackgerritRadoslav Gerganov proposed openstack/nova: VMware: Use virtual disk size instead of image size  https://review.openstack.org/16801313:27
*** garyk has quit IRC13:29
claudiubjohnthetubaguy: IMO, we should put the commits in a line, so the conflicts are resolved and also it will show the preference and readyness of the commits.13:29
johnthetubaguyclaudiub: I added a section at the end of the etherpad for you to start, I guess the above one can be the first patch: https://etherpad.openstack.org/p/liberty-nova-priorities-tracking13:30
johnthetubaguyclaudiub: thats up to you, ideally we have the code refactored such that most patches never conflict13:30
claudiubjohnthetubaguy: yeah, that's what I was saying, that the patch above should merge asap, since it fixes cold migration.13:30
johnthetubaguyclaudiub: thats a great example13:30
claudiubjohnthetubaguy: so, I'll do another review on our patches and if they look good to me, I'll add them to the etherpad list, in order of preference.13:32
dansmithjohnthetubaguy: seems like maybe an ubuntu packaging thing, no?13:32
johnthetubaguyclaudiub: just keep it to a top 3 or 5 patches though, if possible13:32
johnthetubaguydansmith: oh really, I clearly didn't read that properly, sorry!13:32
claudiubjohntheyubaguy: sure thing.13:32
claudiubtube*13:32
claudiubtuba*13:32
johnthetubaguy:)13:33
johnthetubaguymy nick was create such that IRC clients with autocomplete may one day rule the world13:33
dansmithjohnthetubaguy: well, I dunno, just first glance seems like it might be13:33
claudiubi'm not good at musical instruments, not even at spelling them. :D13:33
johnthetubaguydansmith: yeah, it feels like the nova config file might be in a non standard location, and not being passed into nova-manage, but I am not sure13:34
dansmithjohnthetubaguy: same error with cinder db sync13:34
*** exploreshaifali has joined #openstack-nova13:34
dansmithjohnthetubaguy: yeah, I dunno13:34
johnthetubaguydansmith: although, someone said that did actually add the tables13:34
dansmithjohnthetubaguy: kinda feel like it's not critical though, until someone on a different set of packages reports it13:34
johnthetubaguydansmith: sorry, yeah, total over-reaction on my part13:34
*** gszasz has quit IRC13:35
dansmithjohnthetubaguy: someone else said it doesn't happen on RDO13:35
dansmithbut yeah, I dunno what emits that message, but it also doesn't fully seem to be a fatal error either13:36
*** popw has quit IRC13:37
*** eglynn has joined #openstack-nova13:37
*** claudiub|2 has joined #openstack-nova13:38
johnthetubaguydansmith: yeah, I got the impression they didn't get any tables created, but maybe I miss read the other bits anyways13:38
*** sdake_ has joined #openstack-nova13:38
dansmithwell, either way, if it's only happening on upgraded ubuntu packages, that surely seems like a deps problem or something13:39
openstackgerritClaudiu Belu proposed openstack/nova-specs: Adds spec for instance live resize  https://review.openstack.org/14121913:39
*** ankit_ag has quit IRC13:39
johnthetubaguydansmith: yeah, its just odd that the logs suggest the migrations all happened, thats why I was thinking it just getting written into the wrong DB, although that could be a dependency thing I guess (config not loading correctly, etc)13:40
*** claudiub has quit IRC13:40
dansmithyeah, that message seems like something not loading properly in our long chain of dependent things, I think13:40
dansmithbut I'm not really sure who to ask to look at it13:40
*** oro has quit IRC13:41
*** claudiub has joined #openstack-nova13:41
*** oro_ has quit IRC13:41
*** burt has joined #openstack-nova13:42
*** claudiub|3 has joined #openstack-nova13:42
*** sdake has quit IRC13:42
*** claudiub|2 has quit IRC13:42
johnthetubaguydansmith: me neither I am afraid, dims comes to mind as I see lots of oslo related messages13:43
*** CongTo has joined #openstack-nova13:43
dansmithyeah, that's probably a good call13:43
*** claudiub|2 has joined #openstack-nova13:43
*** claudiub_ has joined #openstack-nova13:43
claudiub_johnthetubaguy: also, I've updated the instance-live-resize bp. There were plenty of comments, I hope I did not miss any. Also, I think there was a comment or 2 which was not clear enough to me. Whenever you have a little bit of time, please take a look. :)13:44
*** claudiub|4 has joined #openstack-nova13:44
*** claudiu5 has joined #openstack-nova13:45
*** claudiu5 has quit IRC13:45
johnthetubaguyclaudiub: honestly a few days behind there right now, so working on the new stuff I have not yet touched first, but I will get back to that, but it could be post summit, although there is a summit session that includes online resize discussions BTW, should probably add a link to your spec in the etherpad13:45
*** artom has quit IRC13:45
*** artom has joined #openstack-nova13:45
*** claudiub has quit IRC13:45
*** bjornar has quit IRC13:46
*** claudiub|3 has quit IRC13:46
*** BadCub-Hiding is now known as BadCub13:46
claudiub_johnthetubaguy: interesting. I'll have to make sure I get to that session13:47
johnthetubaguyclaudiub_: https://bugs.launchpad.net/nova/+bug/1453835 it needs the priority setting on it, that would get it more reviews13:47
openstackLaunchpad bug 1453835 in OpenStack Compute (nova) "Hyper-V: Nova cold resize / migration fails" [Medium,In progress] - Assigned to Claudiu Belu (cbelu)13:47
johnthetubaguyclaudiub_: I just added the priorty13:47
johnthetubaguyclaudiub_: can you describe on that bug why that regression was not picked up by the CI tests?13:48
claudiub_johnthetubaguy: I do not have permission to set priority /.importance13:48
*** claudiub|2 has quit IRC13:48
johnthetubaguyclaudiub_: you can give yourself permission, let me find the link13:48
*** claudiub|4 has quit IRC13:48
*** links has quit IRC13:48
johnthetubaguyclaudiub_: https://wiki.openstack.org/wiki/Nova/BugTriage13:49
johnthetubaguyclaudiub_: hmm, not sure that actually tell you...13:49
johnthetubaguyclaudiub_: https://launchpad.net/~nova-bugs13:50
claudiub_johnthetubaguy: I'm not sure why, it could be because the Hyper-V CI is setup with 2 compute nodes. I've hit the bug only having one compute node. We're currently testing Kilo on every system and this eventually came up.13:50
johnthetubaguyclaudiub_: hmm, thats worth digging into, there maybe another bug there13:51
*** moshele has quit IRC13:51
*** moshele has joined #openstack-nova13:52
*** dboik has joined #openstack-nova13:52
claudiub_johnthetubaguy: will do13:52
claudiub_gtg!13:52
johnthetubaguyclaudiub_: I just updated the wiki in the hope it helps others know about the bug team, does that look better? https://wiki.openstack.org/wiki/Nova/BugTriage13:53
*** dboik_ has joined #openstack-nova13:53
*** claudiub_ has quit IRC13:57
*** dboik has quit IRC13:57
*** cfriesen has joined #openstack-nova13:57
*** markvoelker has quit IRC13:59
*** doron_afk has quit IRC14:00
*** sdake has joined #openstack-nova14:01
*** doron_afk has joined #openstack-nova14:01
*** mmedvede_ has quit IRC14:01
openstackgerritjaveme proposed openstack/nova: VMware: Update to return the correct ESX iqn  https://review.openstack.org/16270014:01
*** Kennan has quit IRC14:03
*** Kennan has joined #openstack-nova14:03
*** yingjun has joined #openstack-nova14:03
*** sdake_ has quit IRC14:04
*** amotoki_ has joined #openstack-nova14:06
*** mtanino has joined #openstack-nova14:07
dimsjohnthetubaguy: dansmith: what seems to be the issue?14:08
dansmithdims: oslo. oslo is the issue.14:08
* dansmith kids14:08
dansmithdims: https://bugs.launchpad.net/nova/+bug/145029114:09
openstackLaunchpad bug 1450291 in OpenStack Compute (nova) "nova-manage db sync not committing to database" [High,Incomplete]14:09
dimshaha looking14:09
dansmithdims: thought you might be a good person to start with for figuring out what that error means14:09
*** claudiub has joined #openstack-nova14:11
johnthetubaguydims: thanks for looking14:13
*** eharney has quit IRC14:14
*** nickchase has joined #openstack-nova14:14
*** CongTo has quit IRC14:14
*** garyk has joined #openstack-nova14:14
*** nihilifer has quit IRC14:15
*** haomaiwang has joined #openstack-nova14:15
*** jaypipes has joined #openstack-nova14:15
mriedemdansmith: log?14:16
mriedemdansmith: gate is f'ed btw14:16
mriedemgrenade14:16
dansmithmriedem: log what?14:17
mriedemdansmith: you were saying something about oslo messages above14:17
dansmithmriedem: that bug is all I have14:18
dansmith[07:09:10]  <dansmith> dims: https://bugs.launchpad.net/nova/+bug/145029114:18
openstackLaunchpad bug 1450291 in OpenStack Compute (nova) "nova-manage db sync not committing to database" [High,Incomplete]14:18
mriedemoh14:18
mriedemmaybe ubuntu threw in some nova db migrations of their own :{P14:18
dimsjohnthetubaguy: dansmith: "No handlers could be found for logger" just means the code path that ended with a LOG.xyz did not end up configuring logging, so there's something screwy in their environment or how they installed stuff. have any of us been able to replicate the problem?14:18
dansmithmriedem: someone said they didn't have the problem with RDO, and all the others are ubuntu 14.04 or whatever, so kinda seems like ubuntu deps14:18
dansmithmriedem: heh, I don't think so :)14:19
dansmithdims: that explains why the migrations still get applied14:19
dansmithdims: like I said above, seemed more like a warning than anything14:19
dimsright14:19
*** claudiub|2 has joined #openstack-nova14:19
dansmithdims: so that's cool, probably just a config issue then?14:19
dimsyep14:19
mriedemneed to know the version of oslo.db, sqlalchemy-migrate and sqlalchemy when they hit this14:20
mriedemadded that to the bug14:20
dimsthanks mriedem14:20
dansmithis this in any way our deal though?14:20
*** claudiub|3 has joined #openstack-nova14:20
mriedemme?14:20
dansmithmeaning,14:20
mriedemhells naw14:20
dansmithis this purely ubuntu packaging?14:20
mriedemidk14:20
mriedemmy packages are just fine :)14:20
dansmithI just think we should probably drop the severity based on the impact, especially since I don't think we have anything to do here14:21
mriedemwould be good to get the versions from their site-packages when it's running and failing though14:21
dansmithI'm not even sure who still works for canonical to ask14:21
*** claudiub|4 has joined #openstack-nova14:21
mriedemi know some distros like to munge the requirements and specify their own14:21
dansmithI thought all distros did that? :)14:21
*** tonytan4ever has joined #openstack-nova14:21
mriedemlike rdo zero's out requirements.txt in the rpmbuild and assumes it's rpm requirements are golden14:22
*** mpaolino has quit IRC14:22
mriedemwe dont14:22
*** claudiub has quit IRC14:22
dansmithwell, that's kindof to be expected I think :)14:22
mriedemwe're masochists, we keep our deps up to the same version as what's in requirements.txt14:22
*** claudiub has joined #openstack-nova14:22
mriedemwhich means like daily package updates during development14:22
dansmithright, but we support things shipped via rpm,14:22
dansmithso fi we don't do that, things can shift because pip decides to "help"14:23
mriedemwe're using rpms too14:23
mriedemnot pip14:23
mriedembut we base the requirements in our rpm spec on what's in requirements.txt14:23
*** claudiu7 has joined #openstack-nova14:23
*** claudiub|2 has quit IRC14:23
dansmithright, but we have other things that openstack in our distro,14:23
mriedemso when g-r updates that, we update our packages if needed14:23
mriedemit's painful14:23
dansmithso we have to make sure we have a common package that works for everything14:24
*** jecarey has joined #openstack-nova14:24
*** haomaiwang has quit IRC14:25
dansmithmriedem: anyway, you said grenade is effing up the gate this morning?14:25
*** claudiub_ has joined #openstack-nova14:25
*** claudiub|3 has quit IRC14:25
mriedemwell, https://bugs.launchpad.net/python-openstackclient/+bug/145446714:25
openstackLaunchpad bug 1454467 in python-openstackclient "Latest version 1.0.4 doesn't work with master" [Undecided,New]14:25
mriedemlooks like jogo saved all of our asses https://review.openstack.org/#/c/182524/14:26
*** bkopilov has joined #openstack-nova14:26
*** claudiub|4 has quit IRC14:26
*** claudiu7 has quit IRC14:26
*** dave-mccowan has quit IRC14:26
*** dulek has joined #openstack-nova14:26
*** claudiub has quit IRC14:27
openstackgerritRadoslav Gerganov proposed openstack/nova: VMware: use get_datastore_by_ref from oslo.vmware  https://review.openstack.org/16304314:27
openstackgerritRadoslav Gerganov proposed openstack/nova: VMware: use get_object_properties_dict from oslo.vmware  https://review.openstack.org/16383114:27
*** otter768 has joined #openstack-nova14:27
*** bkopilov_wfh has quit IRC14:27
dansmithfun14:28
*** afazekas has joined #openstack-nova14:29
*** atuvenie has quit IRC14:31
*** otter768 has quit IRC14:32
*** pixelbeat has joined #openstack-nova14:32
*** pixelbeat_ has quit IRC14:34
mikal.14:37
*** cds has joined #openstack-nova14:37
mikaljohnthetubaguy: you still want to talk TH? Or is that done now?14:37
*** lennyb has joined #openstack-nova14:37
johnthetubaguymikal: TH?14:37
johnthetubaguymikal: oh turbo hipster14:38
mriedemcds: what does nova-manage db version show?14:38
mriedem'nova-manage db version'14:38
*** dave-mccowan has joined #openstack-nova14:39
cdsNo handlers could be found for logger "oslo_config.cfg" 28014:39
mriedemthat's it?14:39
cdsyes, 280 is on a newline though14:39
*** tsekiyama has joined #openstack-nova14:39
dansmithmikal: I think we've got a handle on it14:40
mriedemcds: then you're upgraded14:40
dansmithmikal: johnthetubaguy was concerned db_sync was completely broken14:40
mriedemhttps://github.com/openstack/nova/tree/stable/kilo/nova/db/sqlalchemy/migrate_repo/versions 280 is the latest kilo migration14:40
johnthetubaguyyeah, I over reacted14:40
mikaldansmith: oh, ok14:41
mriedemcds: what version of oslo.config is installed?14:41
mikalSo, just noting that TH doesn't test postgres at all because we've never found a user with a production database who is willing to share14:41
johnthetubaguycds: do you have nova.conf correct on node you are running nova-manage?14:41
cdsi dumped my config at https://bugs.launchpad.net/nova/+bug/145029114:41
openstackLaunchpad bug 1450291 in OpenStack Compute (nova) "nova-manage db sync not committing to database" [High,Incomplete]14:41
mriedemjohnthetubaguy: he's at migration 28014:41
mriedemso the migrations ran14:41
dansmithyeah, this is just a logging-unconfigured warning I think14:42
dansmithwhich is what I first thought,14:42
dansmithbut dims confirmed14:42
dansmithand we know the migrations are happening, so..14:42
johnthetubaguyah, OK14:42
johnthetubaguycds: does the DB have the correct information in it?14:42
*** yingjun has quit IRC14:42
*** oro has joined #openstack-nova14:42
cdspython-oslo.config                                    1:1.9.3-0ubuntu1~cloud014:42
cdsyes, but nova doesn't seem to find it14:42
*** oro has quit IRC14:42
cdsmy instances table remains14:42
johnthetubaguycds: what is the nova error you are seeing?14:43
cdsbut nova lost comes up blank14:43
cdslist*14:43
mriedembut there are instances in the instances table?14:43
dansmithsure sounds like some config mismatch14:43
johnthetubaguydansmith: +114:44
*** mestery has quit IRC14:44
*** claudiub_ has quit IRC14:45
openstackgerritZhengguang Ou proposed openstack/nova: Fix the race condition between detaching volume and creating image  https://review.openstack.org/16615214:47
*** zsais has joined #openstack-nova14:48
*** Murali has quit IRC14:48
*** mpaolino has joined #openstack-nova14:49
*** cds has quit IRC14:50
openstackgerritgaryk proposed openstack/nova: VMware: improve instance names on VC  https://review.openstack.org/16660814:50
*** patrickeast has joined #openstack-nova14:52
*** hemna_ is now known as hemna14:53
*** xgsa has quit IRC14:54
*** garyk has quit IRC14:56
*** garyk has joined #openstack-nova14:56
*** josecastroleon has quit IRC14:57
*** bkopilov has quit IRC14:57
*** kmartin has joined #openstack-nova14:59
cfriesendiscovered what I think is a day-one race in cpu pinning.  https://bugs.launchpad.net/nova/+bug/1454451   Who are the right people to contact.  ndipanov I assume, anyone else?14:59
openstackLaunchpad bug 1454451 in OpenStack Compute (nova) "simultaneous boot of multiple instances leads to cpu pinning overlap" [Undecided,New] - Assigned to Chris Friesen (cbf123)14:59
*** Marga_ has joined #openstack-nova14:59
dansmithndipanov is out for a while15:01
dansmithcfriesen: danpb or sahid probably15:02
*** marcusvrn_ has joined #openstack-nova15:02
*** Sukhdev has joined #openstack-nova15:02
*** Marga_ has quit IRC15:03
*** Marga_ has joined #openstack-nova15:03
danpbi'm not familiar enough with the schedling code really - sahid or nikola when he returns in a week & 1/215:04
cfriesennot a race in the scheduler...resource tracking in nova-compute15:05
*** b3nt_pin is now known as beagles15:05
danpbsure, i consider that to be part of scheduling :-)15:05
openstackgerritVictor Stinner proposed openstack/nova: Replace MySQL-python with PyMySQL in tests  https://review.openstack.org/18270915:07
*** jichen has quit IRC15:07
haypodansmith, hi. i rewrote my patch for VersionedObjectDictCompat: https://review.openstack.org/#/c/182699/15:09
dansmithhaypo: yeah, why did you do that?15:09
dansmithhaypo: in general, it's much preferred to re-use your existing review instead of abandoning and moving to another one15:09
kashyapcfriesen: I can give it a shot to reproduce sometime this week, since I recall testing similar stuff from git some months ago.15:09
dansmithhaypo: I really really hate the if statement in the middle of the class, FYI15:10
haypodansmith, ah. i splitted my change into two changes, i removed notes in a first change15:10
dansmithhaypo: still, you shouldn't have abandoned the original15:10
cfriesenkashyap: sweet, thanks.15:10
dansmithhaypo: now the history is confused15:10
*** unicell1 has joined #openstack-nova15:10
kashyapcfriesen: Tomm is a holiday here, so I may try it Friday.15:10
haypodansmith, ok sorry, i will reuse the same change id next time15:11
*** bkopilov has joined #openstack-nova15:11
dansmiththanks15:11
*** n0ano has quit IRC15:11
haypodansmith, do you prefer testing the python major version inside the function? i chose to test in the class body is to not add performance overhead at each code, the class body is only executed once15:11
*** unicell has quit IRC15:12
*** apuimedo has quit IRC15:12
dansmithhaypo: I'll reply on the review in a bit15:12
*** nelsnelson has joined #openstack-nova15:14
*** garyk has quit IRC15:15
*** garyk has joined #openstack-nova15:15
*** dims has quit IRC15:15
*** dims has joined #openstack-nova15:16
*** moshele has quit IRC15:16
*** matrohon has quit IRC15:16
*** garyk has quit IRC15:19
*** tojuvone has joined #openstack-nova15:19
*** bfic has quit IRC15:19
*** jistr is now known as jistr|mtg15:19
*** salv-orlando has joined #openstack-nova15:22
openstackgerritAndrew Laski proposed openstack/nova-specs: Cells: Add host mapping table and object  https://review.openstack.org/18271515:24
markus_zIf anyone is able to establish a secure websocket connection (wss) with nova-serialproxy to the guests, please contact me. I can't figure it out.15:24
*** afazekas_ has quit IRC15:24
*** afazekas has quit IRC15:24
*** Nikolay_St has quit IRC15:26
*** Nikolay_St has joined #openstack-nova15:27
mriedemdirectxman12: ^?15:27
gilliardsahid wrote a howto I think?15:28
openstackgerritWalter A. Boring IV (hemna) proposed openstack/nova: WIP switch to using os-brick  https://review.openstack.org/17556915:28
*** jistr|mtg is now known as jistr15:29
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Eventlet supports python logging directly  https://review.openstack.org/17980115:29
*** sdake has quit IRC15:30
*** sdake has joined #openstack-nova15:30
*** moshele has joined #openstack-nova15:32
*** yamahata has joined #openstack-nova15:33
*** ildikov has quit IRC15:33
*** browne has joined #openstack-nova15:34
*** thangp has joined #openstack-nova15:35
openstackgerritdave-mcnally proposed openstack/nova: Add policy to cover snapshotting of volume backed instances  https://review.openstack.org/17680515:36
*** yamahata has quit IRC15:36
*** Nikolay_St has quit IRC15:36
*** yamahata has joined #openstack-nova15:36
*** mriedem has quit IRC15:37
*** mriedem has joined #openstack-nova15:37
*** exploreshaifali has quit IRC15:37
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Add rootwrap daemon mode support  https://review.openstack.org/18069515:39
*** salv-orlando has quit IRC15:41
*** lennyb has quit IRC15:43
*** bkopilov has quit IRC15:44
*** eharney has joined #openstack-nova15:45
*** bkopilov has joined #openstack-nova15:45
*** obedmr has joined #openstack-nova15:46
sahidgilliard: yes, markus_z you can find some informationon devref manual15:46
markus_zdirectxman12: sahid: I've found how to start the nova-serialproxy. But this didn't cover how the setup should be when "wss" instead of "ws" should be used.15:48
dansmithwss is like https15:48
dansmithws = cleartext, wss = ssl'd15:48
openstackgerritJoel Coffman proposed openstack/nova: libvirt: Clean up unit tests for _hard_reboot  https://review.openstack.org/17739815:49
markus_zdansmith: right, and "websockify" is not able to create a ssl connection to my compute node15:49
tojuvoneWas there a discussion reserved in summit for service groups and tooz? Referring the dev mailinglist discussion on "Service group foundations and features".15:49
dansmithmarkus_z: ah, I see15:50
markus_zI assume that the nova-serialproxy needs a key-file or a cert-file. This is not described in the documentation.15:51
*** shakamunyi has quit IRC15:51
*** barra204 has quit IRC15:51
markus_zDevstack uses HTTP with WS and there it works fine. But now I want to create a "real-live" environment with HTTPS and WSS.15:52
lucasagomeshey quick q. When we issue a "nova delete" in one instance that still "spawning" it doesn't invoke the destroy() method in the driver right?15:53
tojuvoneor should I reserve a slot for having API changes for external monitoring system to update Nova states like in https://review.openstack.org/169836 ?15:54
*** kiran-r has quit IRC15:54
lucasagomescause in Ironic we are able to stop provisioning at some points mid-operation, and it seems that "nova delete" for not invoking destroy() is cause the instance to get stuck15:54
mriedemlucasagomes: it's a crap shoot15:55
dansmithlucasagomes: looks like it should still call it to me15:56
lucasagomesmriedem, right, I mean you can still look at the ironic node and issue a delete in ironic and then delete in nova and the instance goes away15:57
dansmithbut I can see something else being half-setup causing it to bail early15:57
lucasagomesdansmith, yeah... it's because we need to boot a machine so sometimes it the deployment can fail due some network problems15:58
*** dprince has quit IRC15:58
lucasagomesand the ramdisk can't connect to the machine etc15:58
lucasagomesit will timeout eventually15:58
lucasagomesbut sometimes you just want to get rid of that instance immediately and free the ne15:58
lucasagomesnode*15:58
dansmithlucasagomes: I meant something in nova preventing the delete from ever actually calling driver.delete15:58
lucasagomesdansmith, yeah, it seems so. I added some debug in the destroy() method and it's not being invoked15:59
markus_zsahid: If you could give me any pointer you have about websockets and nova-serialproxy in this mail http://lists.openstack.org/pipermail/openstack/2015-May/012661.html that would be really great! I have to leave for today.15:59
lucasagomesdansmith, I will investigate more. Just asked to see if someone had some idea off the top of their heads15:59
*** markus_z has quit IRC16:00
*** vilobhmm1 has joined #openstack-nova16:00
*** redbeard has quit IRC16:01
obedmrhi there, does this message sound familiar to someone "RTNETLINK answers: File exists" ? It's happening when starting 5 VMs in a row, 4 succeed and 1 failed16:03
*** unicell1 has quit IRC16:06
*** obedmr has quit IRC16:06
*** jlanoux has quit IRC16:07
*** obedmr has joined #openstack-nova16:07
*** dulek has quit IRC16:08
*** garyk has joined #openstack-nova16:08
*** jcoufal has quit IRC16:08
mriedemobedmr: goolge16:08
mriedem*google16:09
mriedemhttps://bugs.launchpad.net/nova/+bug/100058016:09
openstackLaunchpad bug 1000580 in neutron "Quantum Linux Bridge interface driver plug operation fails with RTNETLINK error" [High,Fix released] - Assigned to Sumit Naiksatam (snaiksat)16:09
mriedemhowever, that's super old16:09
mriedemobedmr: are you on diablo?16:09
mriedemor essex16:09
obedmrmriedem: actually I saw those links, but the thing is that I'm on Kilo16:11
*** dsanders has joined #openstack-nova16:11
obedmrusing nova-network legacy16:11
*** erlon has joined #openstack-nova16:12
mriedemobedmr: report a new bug with your configuration details, version you're running, and a paste of the trace16:12
*** rwsu has joined #openstack-nova16:13
obedmrmriedem: sure, doing it, thanks16:13
openstackgerritQin Zhao proposed openstack/nova: Make resize api of compute manager to send object  https://review.openstack.org/16186016:15
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Add rootwrap daemon mode support  https://review.openstack.org/18069516:19
openstackgerritVictor Stinner proposed openstack/nova: Run tests with PyMySQL on Python 3  https://review.openstack.org/18270916:20
*** xyhuang has joined #openstack-nova16:21
*** lpetrut has quit IRC16:21
*** Nic has joined #openstack-nova16:21
*** alanf-mc has joined #openstack-nova16:24
*** vilobhmm1 has quit IRC16:25
*** nihilifer has joined #openstack-nova16:25
*** jistr has quit IRC16:25
*** otter768 has joined #openstack-nova16:28
*** sahid has quit IRC16:28
*** nihilifer has quit IRC16:28
*** alanf-mc has quit IRC16:28
*** dprince has joined #openstack-nova16:29
*** haypo has quit IRC16:32
*** otter768 has quit IRC16:32
*** alanf-mc has joined #openstack-nova16:33
_gryfdansmith, hi16:34
dansmithhello16:34
_gryfdansmith, I saw your comments16:34
_gryfdansmith, thanks16:34
*** tonytan4ever has quit IRC16:35
_gryfdansmith, there is a little difference between how it is implemented right now from what you are proposing16:35
_gryfdansmith, https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/plugins/v3/services.py#L10716:35
_gryfdansmith, this line show exactly how id field is used in case of services api16:36
_gryfits exactly the same way as it was before in 2.0 version of the API16:36
_gryfdansmith, so the req lacks of {service: .. } part16:37
*** derekh_ has quit IRC16:37
_gryfdansmith, and the id is used differently one can expect :)16:37
*** alanf-mc_ has joined #openstack-nova16:38
dansmith_gryf: are you talking about the mark-service-down spec?16:38
_gryfdansmith, yes16:38
*** nihilifer has joined #openstack-nova16:38
dansmith_gryf: I'm proposing that the spec behave like the current api does, instead of something different16:39
*** unicell has joined #openstack-nova16:39
_gryfdansmith, let me repeat myself: currently, for v2.1 api, os-services are behave like I've described16:40
*** alanf-mc has quit IRC16:41
*** Jeffrey4l has quit IRC16:41
_gryfdansmith, so IMHO there are 3 opts we have: either we make all the calls for os-services coherent in correct way, make it look the same as the current way, ot make this particular call like you proposed16:41
*** mpaolino has quit IRC16:42
dansmith_gryf: I see now, based on the code how incredibly broken that api is (if id == "enable" <-- insane)16:42
_gryfdansmith, YES!16:42
_gryf:)16:42
*** jlanoux has joined #openstack-nova16:42
*** arnaud____ has joined #openstack-nova16:43
_gryfdansmith, i feel that right way to do is report a bug for broken api and make the new call in correct way16:44
dansmith_gryf: there's no way to make this really correct without adding a new thing, so we might as well just continue to mirror what is there and hopefully implement a new services endpoint that is less stupid later16:45
*** marun has joined #openstack-nova16:46
_gryfdansmith, hm. why cannot we just report a bug for it? 2.1 is still current, isn't it?16:46
*** claudiub has joined #openstack-nova16:46
dansmithwe can't change it, we can only replace it16:46
*** amotoki_ has quit IRC16:46
_gryfoh16:47
_gryfthat suck16:47
dansmithwell, you know, stable APIs and all..16:47
_gryfright...16:47
cfriesendansmith: change it with a microversion?  or is that too much of a change?16:48
dansmithcfriesen: we still have to honor the old mechanism until we drop v2.0 support (which may never happen)16:49
cfriesendansmith: I guess we'd have to add a new endpoint with a microversion16:49
dansmithcfriesen: the microversion would be "add a new /services-that-does-not-suck-as-much" endpoint16:49
dansmithright16:49
_gryfoh crap16:49
dansmithI would strongly recommend you not place that road block in front of landing this spec :)16:49
*** arnaud____ has quit IRC16:49
cfriesendansmith: but it's so simple. :)16:50
_gryfdansmith, but i like your endpoint name ;)16:50
*** ppal has quit IRC16:50
*** browne has quit IRC16:51
*** romainh has left #openstack-nova16:51
*** patrickeast_ has joined #openstack-nova16:51
*** lpetrut has joined #openstack-nova16:52
openstackgerritjaveme proposed openstack/nova: VMware: Prefer ShutdownGuest to PowerOffVM_Task  https://review.openstack.org/18163416:52
*** patrickeast has quit IRC16:52
*** patrickeast_ is now known as patrickeast16:52
*** signed8bit has joined #openstack-nova16:55
*** Marga_ has quit IRC16:57
openstackgerritJean-Daniel Bonnetot proposed openstack/nova-specs: Sort instances if possible inside an host aggregate  https://review.openstack.org/18275816:58
*** vilobhmm1 has joined #openstack-nova16:59
*** sdake has quit IRC17:00
*** jcoufal has joined #openstack-nova17:01
*** tjones1 has joined #openstack-nova17:02
*** Sukhdev has quit IRC17:02
*** jcoufal has quit IRC17:02
*** Sukhdev has joined #openstack-nova17:03
*** patrickeast has quit IRC17:03
*** ijw has joined #openstack-nova17:04
*** davideag_ has joined #openstack-nova17:04
*** winston-d is now known as winston-d_zzZ17:04
jogosdague: when is the last time you ran abandon_old_reviews?17:05
*** zzzeek has joined #openstack-nova17:06
*** davideagnello has quit IRC17:07
lucasagomesdansmith, hi there, the delete is getting stuck in this lock here https://github.com/openstack/nova/blob/3841b8254e0dd820d26377312b6c004f4bd9b58e/nova/compute/manager.py#L243117:08
lucasagomesjust a FYI, I don't know yet how I'm going to resolve it17:08
dansmithah17:08
openstackgerritEric Harney proposed openstack/nova: libvirt: Proxy RBD library call into a separate thread  https://review.openstack.org/18021217:09
dansmithis the build process waiting on ironic?17:09
dansmithlucasagomes: ^17:09
lucasagomesdansmith, probably. Lemme investigate it17:09
dansmithseems likely17:09
lucasagomesdansmith, thanks for the tip!17:10
*** Nic1 has joined #openstack-nova17:10
*** Nic has quit IRC17:10
dansmith np17:10
jogolooks like its been a while17:11
* jogo runs abandon old reivews17:11
*** alanf-mc_ has quit IRC17:12
*** davideagnello has joined #openstack-nova17:12
lucasagomesdansmith, yeah it looks like spawn() is waiting in a loopingcall waiting the node to get ACTIVE (in ironic)17:13
*** moshele has quit IRC17:13
*** alanf-mc has joined #openstack-nova17:13
lucasagomesand it doesn't return until it's ACTIVE or ERROR (in case of a timeout)17:13
*** claudiub|2 has joined #openstack-nova17:13
lucasagomesperhaps somehow we need to cleanup the lock when it's waiting somehow17:13
directxman12markus_z: /win 1317:14
*** achanda has joined #openstack-nova17:14
openstackgerritjaveme proposed openstack/nova: VMware: Prefer ShutdownGuest to PowerOffVM_Task  https://review.openstack.org/18163417:14
*** claudiub has quit IRC17:14
dansmithlucasagomes: well, it's doing what it's supposed to.. does ironic not give us any indication that there has been a failure so that it can break out?17:15
*** davideag_ has quit IRC17:15
dansmithjaypipes: when you're free, vilobhmm1 and I had trouble verifying something about that computefilter call discussion we had the other day17:16
jaypipesdansmith: yes?17:16
dansmiththis: https://github.com/openstack/nova/blob/master/nova/scheduler/driver.py#L5117:16
dansmithjaypipes: seems to only ever be called by the chance scheduler17:16
lucasagomesdansmith, yeah it does. If something fails in ironic the node goes to DEPLOYFAIL provison_state and then the loop is nova is interrupted17:16
dansmithjaypipes: the filter scheduler gets its list of hosts from ComputeNodeList17:16
lucasagomesand instance gets marked as ERROR17:16
lucasagomesit's just that inconvinience that we can't delete an instance with Ironic mid-deployment17:17
lucasagomesvia nova17:17
lucasagomesit's supported via ironic api directly17:17
lucasagomesanyway... I will see if there's anything we can do in the nova side tomorrow. If not we better document it17:17
lucasagomesdansmith, cheers for the help!17:17
dansmithlucasagomes: probably one of those situations where having a driver that calls another distributed service is a sticky place to be17:18
dansmithlucasagomes: but yep, cool17:18
lucasagomesdansmith, yeah. Also deployment in Ironic happens in two phases, before the ramdisk gets into the disk17:18
lucasagomesand after it gets in the disk17:18
dansmithjaypipes: filter scheduler gets it from here I think: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L53517:18
*** nihilifer has quit IRC17:18
lucasagomesso there's synchronization from nova -> ironic -> ramdisk (and back)17:18
*** vilobhmm1 has quit IRC17:18
lucasagomesit's not easy :-)17:18
dansmithlucasagomes: yeah17:18
lucasagomesramdisk get into the node*17:19
*** vilobhmm1 has joined #openstack-nova17:19
jaypipesdansmith: well, no, it gets it from here: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L53217:19
*** mpavone has quit IRC17:19
dansmithlucasagomes: we could have some state I guess to allow it to be interrupted, but right now it's stateless, so.. :/17:19
jaypipesdansmith: and that has the disabled=False hard-coded into it in the DB API layer.17:20
dansmithjaypipes: well, yeah17:20
*** harlowja has quit IRC17:20
dansmithjaypipes: it's the hosts_up() thing we were wondering about17:20
jaypipesdansmith: with this: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L185-L18717:20
*** harlowja has joined #openstack-nova17:20
dansmithjaypipes: I think because he was expecting that to be called because you said it was17:20
jaypipesdansmith: which is the equivalent :)17:20
jaypipesdansmith: it's a mess for sure.17:20
lucasagomesyeah, well, let's see I don't know the right fix yet but at least I know where/why it's failing17:21
dansmithjogo: you're blowing up my review box17:21
dansmithjaypipes: I'm not saying it's different, I just want to make sure I'm not missing how hosts_up() actually gets called from filter scheduler17:21
jogodansmith: running sdague's abandoner17:22
jogoit should abandon 185 or so17:22
jogowe have a lot of dead reviews17:23
jogohad17:23
dansmithjogo: yeah, it's just annoying me with a mail ding about every second17:23
jogohehe17:23
openstackgerritChris Friesen proposed openstack/nova: Fix race between resource audit and cpu pinning  https://review.openstack.org/18276617:23
jogoI hope you don't get an audible ping or something17:23
cfriesenwould love to see comments on the direction taken in this fix ^17:23
cfriesensort of nasty to be adding items to the conductor instance_update17:24
*** claudiub has joined #openstack-nova17:24
dansmithcfriesen: yeah, can't do that, IMHO17:25
*** lucasagomes is now known as lucas-dinner17:25
*** sudipto has joined #openstack-nova17:25
*** claudiub|2 has quit IRC17:26
cfriesendansmith: the thing is I'm not convinced we can call instance.save() since that would persist all the changes since the last save, whereas the old code was only updating the node/host at that point17:27
cfriesendansmith: but we need to save the numa_topology claim while under the semaphore17:28
bauzasdoes anyone know how to access a client manager which is in the contrib path of the novaclient ?17:28
bauzasie. https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/contrib/migrations.py ?17:28
cfriesenbauzas: would love to see your thoughts on the fix above and the bug related to it17:28
bauzascfriesen: unfortunately, I'm quite off upstream since I have to close some internal things before I go to Vancouver17:29
cfriesenbauzas: no worries17:30
cfriesenbauzas: me too...this is one of my internal things. :)17:30
*** salv-orlando has joined #openstack-nova17:30
bauzasand since tomorrow is (again, ergh) a French holiday, tonight is my last day17:30
dansmithcfriesen: passing that value to instance_update() doesn't even make sense right?17:30
dansmithcfriesen: that goes straight to the db update call, which knows nothing about instance['numa_topology'] AFAICT17:30
*** fawadkhaliq has joined #openstack-nova17:31
cfriesendansmith: well, it's not blowing up my lab. :)   checking17:32
dansmithcfriesen: should be ignored, I think17:32
mriedemjogo: this seems to be the kind of thing you're usually interested in https://review.openstack.org/#/c/181944/17:33
*** browne has joined #openstack-nova17:33
openstackgerritMikhail Feoktistov proposed openstack/nova: Virtuozzo instance resize support  https://review.openstack.org/18225717:33
*** 17SACKCIT has joined #openstack-nova17:34
*** 7YUAAALBR has joined #openstack-nova17:34
jogomriedem: yup!17:34
*** thangp has quit IRC17:34
jogovery slick17:34
*** 7YUAAALBR has quit IRC17:34
*** 17SACKCIT has quit IRC17:34
bauzasmelwitt: around for a question ?17:35
bauzasmelwitt: I need your novaclient expertise :)17:35
*** asselin has joined #openstack-nova17:35
cfriesendansmith: I added 'numa_topology' to "allowed_updates"  in the conductor.  or are you saying that the DB API won't do anything with it?17:35
openstackgerritMikhail Feoktistov proposed openstack/nova: Virtuozzo instance resize support  https://review.openstack.org/18225717:35
dansmithcfriesen: the db17:35
melwittbauzas: checking17:36
dansmithcfriesen: when you call instance_update, you're just flat updating the db model, which doesn't have a numa_topology on the instance17:36
bauzasmelwitt: what I basically wonder is how to call a nova.migrations.list() method when just instanciating the client object directly17:36
*** thangp has joined #openstack-nova17:37
dansmithcfriesen: and since it's stored in the DB as an object, if you send a non-object you'll break the copy in the db, and if you send an object, you'll be breaking rpc17:37
bauzashttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/contrib/migrations.py17:37
dansmithcfriesen: it's actually stored in instance_extra.numa_topology17:37
vilobhmm1dansmith, jaypipes : sorry got caught up in some meeting17:37
*** nihilifer has joined #openstack-nova17:37
vilobhmm1but dansmith yes jaypipes is right17:37
bauzasmelwitt: for some reason, the CLI has some way to call cs.migrations.list() but my local object doesn't know it17:37
dansmithvilobhmm1: about the service query filtering for disabled=True, right?17:38
bauzasmelwitt: so I guess I have to extend the client17:38
vilobhmm1yes17:38
dansmithvilobhmm1: right, I'm not arguing that point :)17:38
bauzasmelwitt: but since I'm not a client expert, I'm lost in translation17:38
*** xyhuang has quit IRC17:38
vilobhmm1for the host_up thing17:38
*** doude has quit IRC17:38
*** nihilifer has quit IRC17:38
melwittbauzas: I wrote a similar example in here https://bugs.launchpad.net/python-novaclient/+bug/1313266 you have to import the extension, put it in a list, pass the list to the client object, then you can access it17:39
openstackLaunchpad bug 1313266 in python-keystoneclient "List extensions not exposed in the user-facing library API" [Wishlist,Fix released] - Assigned to Matt Fischer (mfisch)17:39
*** xyhuang has joined #openstack-nova17:39
bauzasmelwitt: lemme look17:39
bauzasmelwitt: I see, introspecting the object and extending it live ?17:39
*** yamahata has quit IRC17:40
bauzasmelwitt: probably that https://bugs.launchpad.net/python-novaclient/+bug/1313266/comments/9 ?17:40
openstackLaunchpad bug 1313266 in python-keystoneclient "List extensions not exposed in the user-facing library API" [Wishlist,Fix released] - Assigned to Matt Fischer (mfisch)17:40
melwittbauzas: yes17:41
dansmithcfriesen: I think you might want/need to wait until the RT is fixed for instance objects17:41
*** marcusvrn_ is now known as marcusvrn17:41
bauzasmelwitt: ok, will see how to do this properly17:41
*** belmoreira has joined #openstack-nova17:41
bauzasmelwitt: I owe you a beer/soft/soda/whatever in Vancouver17:41
*** alexpilotti has quit IRC17:41
melwittheh :)17:42
dansmithah, beers.. the oft-promised, never-collected currency of opensource17:42
bauzasdansmith: :)17:42
bauzasdansmith: that's why we have evening events right ?17:42
bauzasbeers are fre17:42
bauzasfree17:43
dansmithheh, resets the counts, right?17:43
bauzas:)17:43
melwittI can't even remember how I figured out the client thing. it must be in the code somewhere. I should add it to the novaclient doc17:43
bauzasmelwitt: the worst thing is that the extensions parameter is not provided in the main client17:43
*** belmoreira has quit IRC17:43
*** salv-orlando has quit IRC17:44
cfriesendansmith: just confirmed that it's not working, DB not being updated.  I'll have to figure out something though.\17:44
bauzasie. when you correctly do nova.client(version, ...)17:44
dansmithcfriesen: good, because if it was working, I was going to be very concerned :)17:44
bauzasmelwitt: so I will probably monkeypatch the attribute17:44
bauzasmelwitt: oh sec, there is a kwargs17:44
bauzasmarvelous17:45
cfriesendansmith: how about something truly disgusting...read the instance object from the DB, update the affected fields, call instance.save()?17:45
cfriesennot as a final fix, but a workaround17:45
bauzasmelwitt: yeah, love that https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/contrib/migrations.py17:46
dansmithcfriesen: ask some RT people. Personally, I think that's likely to generate too much load, especially given that the audience for this feature is small17:46
dansmithcfriesen: I'd much prefer to live with the possibility until we can fix it properly17:46
cfriesendansmith: I'm not even thinking of submitting that, just as an internal workaround till we get a proper upstream fix.17:46
dansmithcfriesen: oh sure17:46
dansmithcfriesen: damn, was hoping to get another -2 out of that :P17:46
dansmithcfriesen: does the scheduler pick which cpus you get pinned to? If so, I'm not sure I understand how this fixes any race17:47
dansmither, if not I meant17:48
openstackgerritMatt Riedemann proposed openstack/nova: neutron: log hypervisor_macs before raising PortNotUsable  https://review.openstack.org/17545817:48
*** danpb has quit IRC17:49
*** patrickeast has joined #openstack-nova17:50
cfriesendansmith: the instance claim picks the cpus that we get pinned to, and stores them in the numa topology.  currently the claimed numa topology gets updated in the instance shortly after releasing the semaphore17:51
cfriesenwe need to update it in the instance in the DB before releasing the semaphore17:51
cfriesendansmith: because the resource audit takes the semaphore and then queries the DB for all the instances on this host17:52
dansmithcfriesen: so the claim process grabs the semaphore and reads the current pinnings from the db before assigning a pinning ?17:52
bauzasmelwitt: thanks a lot, it works17:52
cfriesendansmith: ResourceTracker.instance_claim() takes the semaphore and calls down into claim, which looks at the current pinnings stored locally in nova-compute17:53
dansmithcfriesen: okay, that's what I thought, that's why I don't understand why we have to write to the DB with the semaphore held17:54
cfriesendansmith: but the resource audit runs every minute and rebuilds the local picture of in-use resources based on what's in the DB17:54
melwittbauzas: whew, I'm glad. also found how I realized it, this is what the shell does to find all the extensions and pass them in the kwarg so everything works https://github.com/openstack/python-novaclient/blob/master/novaclient/shell.py#L525-L52717:54
dansmithcfriesen: ah, okay17:54
dansmithcfriesen: so you're racing with *that*17:54
bauzasmelwitt: yeah17:54
cfriesendansmith: yes17:54
bauzasmelwitt: I also have to beat with the host-evacuate logic, but I can just mimic it since nova.evacuate() is there17:55
cfriesendansmith: so currently we can claim a cpu for an instance, run the resource audit, then claim the same cpu for another instance17:55
bauzasmelwitt: (all of that is not upstream, don't be worried about that :p )17:55
dansmithcfriesen: yeah, I get it17:55
*** nihilifer has joined #openstack-nova17:56
openstackgerritJohn Garbutt proposed openstack/nova: devref: discuss current state of error handling  https://review.openstack.org/17863517:57
*** haomaiwa_ has joined #openstack-nova17:57
openstackgerritAndrew Laski proposed openstack/nova: WIP Retry a cell delete if host constraint fails  https://review.openstack.org/18277217:58
*** fawadk has joined #openstack-nova17:58
*** marcusvrn has quit IRC17:59
*** doron_afk has quit IRC17:59
openstackgerritErickson Filipe Guedes dos Santos proposed openstack/nova: Create column allocated in Quota table  https://review.openstack.org/15132718:00
*** jcook- has joined #openstack-nova18:01
*** fawadkhaliq has quit IRC18:01
*** Sukhdev_ has joined #openstack-nova18:03
*** jcook has quit IRC18:04
*** jcook- is now known as jcook18:04
*** annegentle has quit IRC18:04
*** fawadkhaliq has joined #openstack-nova18:04
*** Sukhdev has quit IRC18:05
*** yamahata has joined #openstack-nova18:05
*** fawadk has quit IRC18:06
*** ijw has quit IRC18:07
*** ijw has joined #openstack-nova18:07
*** cds has joined #openstack-nova18:09
cdsanyone have time to look at https://bugs.launchpad.net/nova/+bug/1446082 ?18:10
openstackLaunchpad bug 1446082 in OpenStack Compute (nova) "Instance without "extra" data crashes nova-compute" [Undecided,In progress] - Assigned to Christoph Dwertmann (cdwertmann)18:10
*** ijw_ has joined #openstack-nova18:10
*** ajo has quit IRC18:10
*** fawadk has joined #openstack-nova18:11
*** ijw has quit IRC18:12
*** luv_ has joined #openstack-nova18:12
*** alanf-mc has quit IRC18:12
mriedemdansmith: hrm ^18:12
dansmithwill look ina sec18:13
*** luv has quit IRC18:13
*** luv_ is now known as luv18:13
*** romainh has joined #openstack-nova18:13
mriedemcds: so you ran migrate_flavor_data ?18:13
*** nihilifer has quit IRC18:13
*** fawadkhaliq has quit IRC18:13
cdsi have not, did not know that existed18:14
cdswhat is the command?18:14
*** fawadk has quit IRC18:14
mriedemsec18:14
mriedemhttps://wiki.openstack.org/wiki/ReleaseNotes/Kilo#Upgrade_Support18:14
mriedemhttps://wiki.openstack.org/wiki/ReleaseNotes/Kilo#Upgrade_Notes_218:14
mriedemAfter fully upgrading to kilo (i.e. all nodes are running kilo code), you should start a background migration of flavor information from its old home to its new home. Kilo conductor nodes will do this on the fly when necessary, but the rest of the idle data needs to be migrated in the the background. This is critical to complete before the Liberty release, where support for the old location will be dropped. Use "nova-manage migrate-flavo18:15
*** gokrokve has joined #openstack-nova18:16
*** alanf-mc has joined #openstack-nova18:17
mriedembut according to https://github.com/openstack/nova/commit/bf8b3946e6964059dce581f54ed4f928e2cdf5ab that's just something that has to be run before upgrading to liberty18:18
cdshmm18:19
cdslet me try this nova-manage db migrate_flavor_data18:19
cds%(total)i instances matched query, %(done)i completed {'total': 0, 'done': 0}18:20
cdscompute node still dies18:20
cdserr %(total)i instances matched query, %(done)i completed {'total': 1, 'done': 1}18:20
dansmithcds:  you know you can't upgrade from icehouse to kilo directly right?18:20
*** pixelbeat has quit IRC18:20
cdscorrect18:20
cdsi am on juno18:20
mriedemdansmith: the original bug reporter was on icehouse18:21
dansmithoh, I see18:21
mriedemhttps://github.com/openstack/nova/commit/6d3c920a569ff843dde3463eb07ab04bd1847e7f18:21
mriedemso the 252 migration creates the instance_extra table but doesn't move any data into it, i'm assuming that is supposed to be a live schema upgrade / data migration in the objects on first access?18:23
dansmiththe trace in the original bug doesn't make much sense,18:23
dansmithbecause it implies that the instance itself is None18:23
dansmithmriedem: yeah18:24
*** Nikolay_St has joined #openstack-nova18:24
dansmiththat was in juno though right?18:24
openstackgerritVladik Romanovsky proposed openstack/nova-specs: Allow admins to query user keypairs and create new on their behalf  https://review.openstack.org/17557918:24
mriedemdansmith: yeah https://review.openstack.org/#/c/108097/18:24
mriedemso...upgrade from icehouse directly to kilo w/o migrating any data, run kilo code which assumes the data migration happened in juno?18:25
cdsi guess it's possible i upgraded from icehouse->juno and never ran the db migration18:26
dansmithno, because we didn't have anything from i->j to fill in extra, AFAIK18:26
*** tojuvone has quit IRC18:26
cdsbut i was on juno before installing kilo18:26
dansmithand we couldn't have required them to touch all their instances18:26
dansmithcds: you abandoned your patch because why again?18:26
cdssorry, that wasn't my patch18:27
mriedemdansmith: the guy screwed up18:27
mriedemdansmith: he pushed https://review.openstack.org/#/c/175288/ and then abandoned that for change 2, which Vek said do it in the first18:28
mriedemso now both are abandoned :)18:28
dansmithright, then the other was abandoned18:28
*** Marga_ has joined #openstack-nova18:28
dansmithcds: that's not you?18:28
mriedemderp18:28
mriedemno18:28
mriedemchris != craig18:28
dansmithokay18:28
cds:)18:28
* mriedem acts like he knows all of these guys18:28
dansmithISTR a patch to create instance_extra in certain cases18:28
dansmithlemme look for a sec18:29
*** otter768 has joined #openstack-nova18:29
*** tonytan4ever has joined #openstack-nova18:29
dansmithI'm just not sure how this ever passed grenade if it was broken18:31
openstackgerritQin Zhao proposed openstack/nova: Make resize api of compute manager to send flavor object  https://review.openstack.org/16186018:32
mriedemdansmith: do we actually put numa stuff in extra?18:32
mriedemin grnade18:32
dansmithmriedem: doesn't matter I don't think18:32
dansmithunless we don't query with that in expected_attrs if that filter isn't enabled, but I doubt it18:32
*** otter768 has quit IRC18:33
cdsany suggestions on what i could do in the meantime? is it possible to roll back nova to juno, rerun db sync, and the move back to kilo?18:33
dansmithoh, you know why18:33
dansmithwhen we added this, we were doing independent queries18:34
dansmithand then we probably optimized after we moved past the point where new instances get extra records by default18:34
*** claudiub|2 has joined #openstack-nova18:34
*** claudiub has quit IRC18:34
*** ijw_ has quit IRC18:34
*** Marga_ has quit IRC18:35
*** ijw has joined #openstack-nova18:35
*** Marga_ has joined #openstack-nova18:35
*** ijw has quit IRC18:35
dansmithso since those patches are abandonded, I think I'll just write a new one18:35
dansmithwow, too many D's18:35
dansmithcds: can you test a patch for me?18:35
cdsof course18:36
*** ijw has joined #openstack-nova18:36
dansmithokay, give me a bit18:36
*** jlanoux_ has joined #openstack-nova18:36
cdslet me rejoin on something other than webchat18:37
*** jlanoux has quit IRC18:37
*** cds has quit IRC18:37
*** cds has joined #openstack-nova18:37
cdsalright18:37
dansmithzzzeek: I think I've asked this a hundred times, but what's the newer way to tell if a thing is loaded in a sqla object?18:37
dansmithwithout triggering a load18:38
openstackgerritVladik Romanovsky proposed openstack/nova-specs: Allow admins to query user keypairs and create new on their behalf  https://review.openstack.org/17557918:38
zzzeekdansmith: do you mean an attribute, like myobject.some_attribute18:38
dansmithI thought it changed between 0.8 and 0.918:38
dansmithzzzeek: yes18:38
zzzeekdansmith: the always-worked way is just to look in __dict__, myobject.__dict__[‘some_attribute’]18:38
dansmithzzzeek: so "if 'some_attribute' in obj.__dict__" to detect presence?18:39
zzzeekdansmith: the newish way is probably inspect(myobject).attrs.some_attribute .loaded_value18:39
zzzeekdansmith: if the value is there, then that’s the value.   the more modern non-hacky way is the inspect() form18:39
dansmithokay, probably should do the old way since this is for a backport18:39
dansmithzzzeek: thanks18:39
zzzeekdansmith: good plan18:39
*** Nikolay_St has quit IRC18:43
*** pixelbeat has joined #openstack-nova18:45
*** sudipto has quit IRC18:45
*** claudiub has joined #openstack-nova18:46
*** aix has quit IRC18:47
openstackgerritsajeesh cs proposed openstack/nova: Nested Quota Driver  https://review.openstack.org/14982818:48
*** claudiub|2 has quit IRC18:50
openstackgerritDan Smith proposed openstack/nova: Fix loading things in instance_extra for old instances  https://review.openstack.org/18278718:50
dansmithcds: ^18:51
*** Sukhdev_ has quit IRC18:51
cdsthanks18:51
dansmithcds: looks like it should still apply to kilo18:51
cdsok18:51
dansmithnow, the migrate_flavor_data thing really should be creating extra records18:51
dansmithyou said you tried that and didn't get any, is that right?18:52
cdsi got one18:52
dansmithone?18:52
cdsnova-manage db migrate_flavor_data 5018:52
cdsNo handlers could be found for logger "oslo_config.cfg"18:52
cds%(total)i instances matched query, %(done)i completed {'total': 1, 'done': 1}18:52
dansmithoh I see, missed that second one18:52
dansmithwell, that's concerning18:53
dansmithcds: presumably you have lots of undeleted instances in your instances table, right?18:53
dansmithcds: and do you have some extra rows, or just the one it created?18:53
*** yapeng has joined #openstack-nova18:54
*** xyhuang has quit IRC18:57
*** baoli has quit IRC18:57
cdssec19:00
cdsapplying patch19:00
*** annegentle has joined #openstack-nova19:00
*** Longgeek has quit IRC19:01
*** Longgeek has joined #openstack-nova19:01
*** Longgeek has quit IRC19:02
*** Longgeek has joined #openstack-nova19:02
dansmithwriting tests now,19:02
dansmithand replicated the behavior, which is fixed with that patch19:02
*** yapeng has quit IRC19:02
mriedemdansmith: ping me when the tests are up, looked good otherwise19:02
dansmithk19:03
*** claudiub|2 has joined #openstack-nova19:03
*** Longgeek has quit IRC19:04
*** Longgeek has joined #openstack-nova19:04
*** claudiub has quit IRC19:05
*** exploreshaifali has joined #openstack-nova19:05
*** sdake has joined #openstack-nova19:06
cdsdansmith: besides applying the patch and removing the old .pyc file, why is error pointing back to stale code?19:06
mriedemdansmith: melwitt was seeing the same issues in the change that i was at the same time :)19:07
mriedemi had to look closer19:07
dansmithcds: meaning you still see the error but it's pointing to a line in the code that is no longer right?19:08
cdscorrect19:08
dansmithmriedem: which change?19:08
mriedemdansmith: ps119:08
dansmithcds: sure seems like a pyc thing19:08
mriedemhttps://review.openstack.org/#/c/182787/ comments inline19:08
cdssame error, same line, but that line no longer exists in the source file19:08
melwittcds: did you restart the service?19:09
melwittor is it a nova-manage thing19:09
mriedemnova-manage already ran19:09
openstackgerritJoe Gordon proposed openstack/nova-specs: Make backlog usable  https://review.openstack.org/18279319:09
mriedemhas to patch, remove pyc, and restart nova-compute19:09
jogoturns out nova-specs backlog wasn't actually usable until now ^19:10
*** pixelbeat has quit IRC19:12
dansmithmriedem: melwitt yeah, did that flavor change prospectively, didn't actually test anything yet, good catch19:12
*** alanf-mc has quit IRC19:13
*** alanf-mc has joined #openstack-nova19:14
cdsdansmith: got it running with the updated patch, same thing unfortunately19:15
cdsline 515 in your patch19:15
dansmithcds: can you paste the trace?19:15
dansmithpastebin *19:15
cdssure19:15
cdshttp://pastebin.com/fip6YBTG19:15
*** alanf-mc has quit IRC19:15
*** exploreshaifali has quit IRC19:16
*** alanf-mc has joined #openstack-nova19:16
*** Sukhdev has joined #openstack-nova19:16
openstackgerritgaryk proposed openstack/nova: VMware: detach cinder volume when instance destroyed  https://review.openstack.org/16973219:16
openstackgerritgaryk proposed openstack/nova: VMware: remove redundant check for block devices  https://review.openstack.org/17064119:16
mriedemhmm, db_inst.get('extra') returning None?19:18
dansmithI'm wondering if it's actually in the object, but None19:18
dansmitheither way, foo.get().get() makes no sense19:19
cdsi can get my db for certain fields if it would help19:19
cdscheck my db*19:19
dansmiththis is code semantics19:19
mriedemcds: well, you're getting into a block where the extra column/field is on the instance record19:19
dansmithsdague:19:22
dansmither19:22
dansmithcds:19:22
openstackgerritDan Smith proposed openstack/nova: Fix loading things in instance_extra for old instances  https://review.openstack.org/18278719:22
dansmithdon't need the test parts of course19:22
mriedemlooks better19:23
dansmithadding test for the flavor part19:24
openstackgerritMarian Horban proposed openstack/nova: Disassociating of floating IPs corrected  https://review.openstack.org/14935819:24
*** claudiub has joined #openstack-nova19:25
cdswoahhhh19:25
cdsit worked :)19:25
cdsafaik at least19:25
*** alanf-mc has quit IRC19:25
dansmithcds: did we warn you about the hourly rate for this kind of support? :)19:25
cdslol19:26
*** Nikolay_St has joined #openstack-nova19:26
openstackgerritDan Smith proposed openstack/nova: Fix loading things in instance_extra for old instances  https://review.openstack.org/18278719:26
dansmithupdated to include coverage for flavor in the test:19:26
cdsso tell me this.. am i going to run into more problems?19:26
dansmith^19:26
*** alanf-mc has joined #openstack-nova19:27
cdsshould i snapshot these VMs and recreate new instances?19:27
dansmithcds: well, that question is very, uh, loaded :)19:27
dansmithcds: but no, you shouldn't need to do that19:27
*** claudiub|2 has quit IRC19:27
dansmithcds: we just goofed a little on two-cycle-old instances here I think19:28
cdshmm19:28
dansmithI haven't run git-blame yet to see if it was my fault or not, but I assume so..19:28
cdsso liberty is released, i should be able to db sync and be alright?19:29
dansmithyou mean *when* it's released?19:29
cdsyes19:29
dansmithyes, and I'll backport this fix so that when your packages are next updated, it should have this in there19:30
cdsawesome19:30
dansmithcds: the only thing that has me still concerned is why you were only seeing one instance get hit with the migrate_flavor_data thing19:30
dansmithbecause that will be a requirement before liberty will let you do db_sync19:30
*** belmoreira has joined #openstack-nova19:32
cdshmm19:32
cdscould i recreate all the flavors now that i am on kilo and redeploy the vms?19:33
cdsthis is a dev cluster with <50 vms19:33
*** belmoreira has quit IRC19:33
dansmiththis is actually not about flavors, but about instances and how they reference the flavors19:33
cdsah19:33
dansmithso anything you do to touch the instance will do the migration for you,19:33
*** dave-mccowan has quit IRC19:33
dansmiththe migrate_flavor_data thing is just to migrate any instances that aren't touched to trigger that migration19:33
dansmithcould you run it again with this patch applied? maybe this was preventing it from hitting everything19:34
cdssure19:34
dansmithI kinda expect not given that we don't catch and ignore this in the migration thing...19:35
cdsyeah19:35
cdsstill 019:35
*** frickler has quit IRC19:36
dansmithit's super odd that you didn't see this error when trying to do that in the first place actually19:36
*** nkrinner has joined #openstack-nova19:36
cdsany suggestions? or just hope it gets caught and fixed upstream19:38
dansmithI'm thinking and looking at the code...19:38
*** eharney has quit IRC19:38
*** pece has quit IRC19:39
dansmithcould you maybe do some queries in your database to count things?19:39
openstackgerritJoe Gordon proposed openstack/nova-specs: Make backlog usable  https://review.openstack.org/18279319:39
dansmithbasically, it would be helpful to know how many non-deleted instances you have that don't have a corresponding record in instance_extra19:39
cdsof course19:40
*** jlanoux_ has quit IRC19:40
*** packet has joined #openstack-nova19:40
dansmithzzzeek: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L6011-601319:40
dansmithzzzeek: if we do that and InstanceExtra doesn't exist for that instance, will we get a record?19:41
zzzeekdansmith: yes19:41
cfriesendansmith: back to that race in nova-compute...looks like I can call objects.InstanceNUMATopology.get_by_instance_uuid() and update just that object rather than the whole instance.19:41
dansmithhmm, okay19:41
zzzeekdansmith: 3050 points, can’t go wrong: http://stackoverflow.com/a/38578/3454919:42
dansmithzzzeek: yeah, I need to understand that better, sorry19:43
zzzeekdansmith: not a problem19:45
* zzzeek did SQL for like ~3 years not knowing JOIN19:45
dimslol :)19:45
dansmitheven still, the ORM between me and SQL often makes me second guess things19:47
dansmithbecause I just assume it's pure magic19:47
*** Sukhdev_ has joined #openstack-nova19:47
*** jwcroppe has joined #openstack-nova19:48
melwittit's alchemy :)19:48
*** IanGovett has joined #openstack-nova19:48
dansmithright19:48
dansmithif it was named SQLnotscaryatallcomeonin then it'd be different :)19:48
*** ijw_ has joined #openstack-nova19:49
melwittthat's for sure!19:49
dansmiththat's about the only thing harder to type quickly than sqlalchemy too19:49
*** IanGovett1 has quit IRC19:50
*** Sukhdev has quit IRC19:50
*** jwcroppe_ has quit IRC19:50
*** arnaud____ has joined #openstack-nova19:50
cdsdansmith: 33 instance uuids in instance_extras19:50
cds37 non-deleted VMs19:50
cdsin instances19:50
*** ijw has quit IRC19:51
*** erlon has quit IRC19:51
dansmithhmm19:52
bauzasmikal: as per https://bugs.launchpad.net/nova/+bug/1450798 it seems that's an Invalid one19:52
openstackLaunchpad bug 1450798 in OpenStack Compute (nova) "Multiple command injection vulns in schema_diff tool" [Undecided,New]19:52
bauzasmikal: you agree ?19:53
dansmithcds: you're checking non-deletedness how?19:54
cdsselect deleted from instances where deleted = 0;19:54
dansmithcds: are any of your instances deleted=NULL?19:54
*** arnaud____ has quit IRC19:55
cdsno19:55
cdsthe default for that column is null also19:55
cdswhich is why i was confused19:55
dansmithyeah, that's because $history I think19:55
dansmithcds: so of the four instances in there hat don't have extra records, does anything stand out?19:56
dansmithlike, super old, super new?19:56
dansmithcds: are they in any state like RESIZED or something?19:56
dansmithcds: do they have a task_state ?19:56
cdslet me poke around19:57
*** dprince has quit IRC19:57
dansmithcds: really appreciate your help with this19:57
cdsmy help? you are helping me :P19:57
dansmithwell,19:58
dansmiththis part helps you in the future, helps me now I guess :)19:59
*** ijw_ has quit IRC19:59
cdsdansmith: instances in the error state do not appear in the instance_extra table20:02
cdsthat is the discrepancy20:02
dansmithcds: ah, okay, and I assume those have a task_state set, which is why20:03
cdsare deleted instances info supposed to remain in instance_extra ?20:05
melwittmriedem: I don't know if you've had a chance to revisit this log a warning for sec groups + port id https://review.openstack.org/#/c/154068/20:06
dansmithcds: you mean if you  have an instance with an extra record and then you delete it?20:07
cdsyes20:07
*** baoli has joined #openstack-nova20:08
dansmithcds: yeah, we do a soft_delete() on that, which should just set deleted!=0 on the extra record20:08
cdslast question... :)20:09
cdsdo you guys have any scripts laying around to purge an instance based on uuid20:10
cdsfrom the nova db20:10
mriedemmelwitt: i noticed there was some back and forth20:10
*** eharney has joined #openstack-nova20:10
dansmithcds: did you hear that?20:11
dansmithcds: that was the sound of everyone scattering from the room20:11
cds:(20:11
dansmithheh20:11
dansmithcds: unfortunately we don't, and we don't have any prescription for when and how to do that20:11
dansmithcds: we're also not proud of it.20:11
cdsjust want to get my db in a consistent state20:12
alaskiI recently found http://openstack-in-production.blogspot.com/2015/05/purging-nova-databases-in-cell.html which could be used as a starting point20:12
dansmithalaski: ah, nice20:12
dansmithcds: it's actually a big problem and right now it's left as an exercise for the deployer, which sucks20:12
dansmithcds: a hint though, alaski runs a really big (singlehandedly, I hear) so you can press him for details :)20:13
dansmither, "really big cloud"20:13
alaskiwell, I have two hands really20:13
dansmithhah20:13
melwittmriedem: yeah, I was reading over it. I think it's okay, but can't say I'm sure how much logging a warning helps. maybe it's better than nothing20:14
mriedemmelwitt: so....20:14
mriedemi think i'm -1 on this20:14
mriedemwell, i'm sure i'm -1 but for multiple reasons20:14
*** mmedvede has quit IRC20:15
mriedemmelwitt: assuming we warn in L and error in M, we need this in the release notes so the commit message needs DocImpact/UpgradeImpact for that as a looming API failure20:15
mriedembut because it's suggesting we're going to break an API in M, i'm -1 on *that*20:15
*** jwcroppe_ has joined #openstack-nova20:16
mriedemb/c warts and all, i don't think we can do that20:16
mriedemuntil we have a new neutron api in nova where we can break backwards compat - so whatever beagles is working on20:16
melwittmriedem: hm, yeah.. the back and forth made it get to this state20:17
garykmriedem: is there any code from beagles? i have just seen the spec20:17
*** jwcroppe has quit IRC20:18
beaglesgaryk, no code yet - now that I have some approval on the specs, I can get moving20:18
* beagles wishes he was going to summit, would've been great to discuss in person20:19
alaskidoes anyone know a way to mock a method call invoked through super(<classname>, self).method()?20:19
melwittcds: the blog post alaski links mentions about it, there is a nova-manage tool for archiving (deleting and moving to shadow tables) rows but it doesn't work on instances, it's broken20:20
garykbeagles: i guess by what you wrote means we will need to bach it out on irc20:20
*** kmartin has quit IRC20:21
cdsyeah i rewriting that cern tool20:21
cdsto just take the uuid20:21
*** haypo has joined #openstack-nova20:21
*** ildikov has joined #openstack-nova20:21
*** romainh has left #openstack-nova20:24
*** claudiub has quit IRC20:24
*** jecarey has quit IRC20:24
openstackgerritChris Friesen proposed openstack/nova: Fix race between resource audit and cpu pinning  https://review.openstack.org/18276620:25
melwittalaski: do you have an example? do you mean the super class's method calls some other method and you want to mock that? afaik, I think you'd have to mock.patch.object a class, or use mock.patch with the path to the method20:25
cfriesencan anyone think of a better way to do this ^ given the current code?20:26
*** pixelbeat has joined #openstack-nova20:26
*** dave-mccowan has joined #openstack-nova20:26
*** mmedvede has joined #openstack-nova20:27
alaskimelwitt: I'm trying to mock http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/cells_api.py#n229 specifically20:27
mriedemalaski: i'm sorry20:28
alaskimelwitt: but mocking it on the instantiated compute api didn't seem to work20:28
mriedemalaski: do you know what method_name is ahead of time?20:29
dansmithcfriesen: sorry, I was in the middle of that other thing earlier20:29
cfriesendansmith: no worries20:29
alaskimriedem: heh.  I'll probably just wrap it in a _get_parent_class method or something, because all I care about is that execution gets there.20:29
alaskimriedem: yes20:29
melwittalaski: hm, I thought that would have worked20:29
*** otter768 has joined #openstack-nova20:29
mriedemand mock.patch.object(compute_api.API, method_name) doesn't work?20:30
*** mwagner_lap has quit IRC20:30
alaskiI tried mocking on http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/compute/test_compute_cells.py#n10620:31
alaskiwhich is compute.API()20:31
alaskihmm, let me try the import20:32
melwittalaski: it gets set to ComputeCellsAPI() on L118 though20:33
alaskimelwitt: yeah, that threw me off at first, but I tried ORIG_COMPUTE_API as well20:33
bauzasalaski: oh, cells meeting in 30 mins right?20:33
alaskibauzas: yep20:33
melwittalaski: oh, hm.20:33
*** otter768 has quit IRC20:34
alaskimriedem: that worked, you're my hero for the day20:35
alaskicompute_api.API works, compute_api.API() does not20:35
*** ijw has joined #openstack-nova20:36
mriedemalaski: sweet20:36
*** ijw has quit IRC20:37
mriedemthat makes two:20:37
mriedem(12:51:02 PM) stevemar: mriedem, my hero <320:37
*** ijw has joined #openstack-nova20:37
alaskiheh20:37
*** kmartin has joined #openstack-nova20:38
*** annegentle has quit IRC20:39
openstackgerritAndrew Laski proposed openstack/nova: Retry a cell delete if host constraint fails  https://review.openstack.org/18277220:39
*** annegentle has joined #openstack-nova20:39
*** jecarey has joined #openstack-nova20:40
*** jwcroppe has joined #openstack-nova20:43
*** jwcroppe_ has quit IRC20:45
*** ajo has joined #openstack-nova20:47
*** achanda has quit IRC20:48
*** belmoreira has joined #openstack-nova20:49
*** vladikr has quit IRC20:49
openstackgerritgaryk proposed openstack/nova: VMware: detach cinder volume when instance destroyed  https://review.openstack.org/16973220:49
openstackgerritAndrew Laski proposed openstack/nova: Retry a cell delete if host constraint fails  https://review.openstack.org/18277220:49
openstackgerritgaryk proposed openstack/nova: VMware: remove redundant check for block devices  https://review.openstack.org/17064120:49
*** jwcroppe_ has joined #openstack-nova20:51
*** nkrinner has quit IRC20:51
*** ildikov has quit IRC20:52
*** jwcroppe has quit IRC20:53
*** pixelbeat has quit IRC20:54
openstackgerritgaryk proposed openstack/nova: VMware: remove invalid comment  https://review.openstack.org/18283920:56
*** Sukhdev has joined #openstack-nova20:59
*** thangp has quit IRC21:00
*** eglynn_ has joined #openstack-nova21:01
*** Sukhdev_ has quit IRC21:01
*** eglynn has quit IRC21:01
openstackgerritMatt Riedemann proposed openstack/nova: VMware: remove invalid comment  https://review.openstack.org/18283921:01
*** isq_ has joined #openstack-nova21:04
*** kashyap` has joined #openstack-nova21:05
*** dgonzalez_ has joined #openstack-nova21:05
*** aysyanne has joined #openstack-nova21:05
*** mriedem has quit IRC21:06
*** NobodyCa1 has joined #openstack-nova21:07
*** ildikov has joined #openstack-nova21:07
*** mishkin____ has joined #openstack-nova21:07
*** garyk has quit IRC21:09
*** rwmjones has quit IRC21:09
*** mleroy has quit IRC21:09
*** kashyap has quit IRC21:09
*** dgonzalez has quit IRC21:09
*** aysyd has quit IRC21:09
*** ekarlso has quit IRC21:09
*** mishkin___ has quit IRC21:09
*** larsks has quit IRC21:09
*** wolsen has quit IRC21:09
*** sgordon has quit IRC21:09
*** NobodyCam has quit IRC21:09
*** Kennan has quit IRC21:09
*** tanee has quit IRC21:09
*** greghaynes has quit IRC21:09
*** isq has quit IRC21:09
*** dgonzalez_ is now known as dgonzalez21:09
*** mleroy has joined #openstack-nova21:09
*** greghayn1 has joined #openstack-nova21:09
*** isq_ has quit IRC21:09
*** isq_ has joined #openstack-nova21:09
*** kashyap` has quit IRC21:09
*** kashyap` has joined #openstack-nova21:09
*** sgordon has joined #openstack-nova21:10
*** sgordon has quit IRC21:10
*** sgordon has joined #openstack-nova21:10
*** ekarlso has joined #openstack-nova21:10
*** wolsen has joined #openstack-nova21:10
*** larsks has joined #openstack-nova21:10
*** garyk has joined #openstack-nova21:10
*** Kennan has joined #openstack-nova21:10
*** tanee has joined #openstack-nova21:11
*** NobodyCa1 is now known as NobodyCam21:11
*** achanda has joined #openstack-nova21:11
*** Marga_ has quit IRC21:11
openstackgerritgaryk proposed openstack/nova: VMware: detach cinder volume when instance destroyed  https://review.openstack.org/16973221:11
*** Marga_ has joined #openstack-nova21:12
openstackgerritgaryk proposed openstack/nova: VMware: remove redundant check for block devices  https://review.openstack.org/17064121:13
*** pixelbeat has joined #openstack-nova21:16
*** vilobhmm11 has joined #openstack-nova21:20
*** gokrokve has quit IRC21:20
*** vilobhmm12 has joined #openstack-nova21:21
*** haomaiwa_ has quit IRC21:21
*** vilobhmm11 has quit IRC21:21
*** gokrokve has joined #openstack-nova21:21
openstackgerritChris Friesen proposed openstack/nova: Fix race between resource audit and cpu pinning  https://review.openstack.org/18276621:22
*** nickchase has quit IRC21:22
*** jwcroppe has joined #openstack-nova21:22
*** vilobhmm11 has joined #openstack-nova21:22
*** angdraug has joined #openstack-nova21:23
*** vilobhmm1 has quit IRC21:23
*** vilobhmm1 has joined #openstack-nova21:24
*** mriedem has joined #openstack-nova21:25
*** jwcroppe_ has quit IRC21:25
*** gokrokve has quit IRC21:25
*** vilobhmm12 has quit IRC21:26
melwittdansmith: in this patch, when you give the example of Instance(uuid=...) will it not go to save the uuid field as a changed field? asking because I have a similar thing in my cells patch doing an instance_update equivalent, and I obj_reset_changes(['uuid']) perhaps needlessly before the save() https://review.openstack.org/#/c/182766/2/nova/compute/resource_tracker.py,cm21:27
*** vilobhmm11 has quit IRC21:27
dansmithmelwitt: it will try, yeah21:28
dansmithmelwitt: which won't hurt anything, but it should be avoided21:28
dansmithobj.obj_reset_changes(fields['uuid'])21:28
dansmithwill take care of it21:28
dansmithcfriesen: ^21:28
melwittokay21:29
*** matrohon has joined #openstack-nova21:29
*** gokrokve has joined #openstack-nova21:29
*** greghayn1 is now known as greghaynes21:29
cfriesendansmith: before calling save(), you mean?21:30
dansmithcfriesen: yeah21:30
cfriesendansmith: works. new rev coming up21:30
dansmithcfriesen: you can also just reset all changes before setting the numa21:31
dansmitheither way21:31
dansmithcfriesen: wait21:31
cfriesenyes21:31
*** annegentle has quit IRC21:32
dansmithcfriesen: comment on your comment21:32
dansmithcfriesen: be more forceful and carry more hate in your voice, please21:32
cfriesen:)21:33
cfriesendansmith: to clarify...how would RT using instance objects throughout change things?  instance_ref is already an object21:33
dansmithit's not21:33
* dansmith goes to back up that bold statement21:34
cfriesensure it is. :)21:34
*** kmartin has quit IRC21:34
dansmithoh, this is passed in from compute just for this call isn't it?21:35
cfriesenyep21:35
dansmiththen I'm -2 on this :)21:35
cfriesenheh21:35
dansmithjust convert that whole thing to do a .save21:35
dansmithdump the instance_update21:35
cfriesenokay, but that'll save all the changes, no?21:35
cfriesenI wasn't sure it was okay to save everything at this point21:36
dansmithit will, which will be the three there plus your numa topology21:36
dansmithcfriesen: the numa topology isn't set on instance_ref until after that call21:37
dansmithoh, you moved this, right?21:38
dansmithit was in _set_instance_host_and_node() before right?21:38
cfriesendansmith: yeah, I moved it to right before where we drop the semaphore21:39
dansmithokay21:39
dansmithso, I think what you should do is set the instance.numa_topology before the call to _set_instance_host_and_node() and then just do instance.save() in there21:39
dansmithmaybe with a comment by the call that says it'll be saved when we do the host and node set21:40
*** ildikov has quit IRC21:40
dansmiththat makes the whole thing a single save call21:40
mriedemalaski: https://review.openstack.org/#/c/169517/ should probably be on stable/kilo right?21:40
dansmithcfriesen: I don't think there's any reason not to save the whole thing there21:41
mriedemalaski: nevermind21:41
alaskimriedem: yes21:41
mriedemwas merged in kilo21:41
alaskioh, cool21:41
mriedemwhen you said 'just fixed that' in the other review, i thought that was more literal21:41
alaskitime is relative :)  but it didn't seem like 5 weeks ago21:42
cfriesendansmith: okay, can give that a try.21:42
dansmithcfriesen: it would be awesome if you followed this fix up with converting any places in that call chain that are always an object to use attribute syntax21:43
dansmithcfriesen: it's super confusing to see that be used as a dict there21:43
cfriesendansmith: yeah...legacy code I'm assuming21:43
dansmithyes21:43
dansmithand it used to have to stay that way because of where instance was coming from, but it looks like maybe more of this can be cleaned up than I thought21:43
dansmithso at least right here would be good21:44
* dansmith runs off for a bit21:44
*** Sukhdev_ has joined #openstack-nova21:44
*** gokrokve has quit IRC21:45
*** gokrokve has joined #openstack-nova21:45
*** Sukhdev has quit IRC21:46
*** gokrokve has quit IRC21:50
*** dave-mccowan has quit IRC21:53
*** ildikov has joined #openstack-nova21:53
*** belmoreira has quit IRC21:54
*** IanGovett has quit IRC21:57
*** IanGovett has joined #openstack-nova21:57
jogohave we documented v2.0 as deprecated yet?21:57
*** ajo has quit IRC21:58
*** mriedem is now known as mriedem_away21:58
*** aysyanne has quit IRC22:03
*** lucas-dinner has quit IRC22:03
*** nihilifer has joined #openstack-nova22:04
*** ddutta has joined #openstack-nova22:05
*** igordcard has joined #openstack-nova22:10
*** Marga_ has quit IRC22:11
*** gokrokve has joined #openstack-nova22:11
*** Marga_ has joined #openstack-nova22:11
*** lpetrut has quit IRC22:13
*** achanda has quit IRC22:13
*** Nic1 has quit IRC22:14
*** eharney has quit IRC22:14
*** salv-orlando has joined #openstack-nova22:15
*** salv-orlando has quit IRC22:15
*** jecarey has quit IRC22:16
*** eglynn_ has quit IRC22:16
*** vilobhmm1 has quit IRC22:16
*** zzzeek has quit IRC22:17
openstackgerritChris Friesen proposed openstack/nova: Fix race between resource audit and cpu pinning  https://review.openstack.org/18276622:17
*** vilobhmm1 has joined #openstack-nova22:17
*** matrohon has quit IRC22:17
openstackgerritChris Friesen proposed openstack/nova: Fix race between resource audit and cpu pinning  https://review.openstack.org/18276622:18
*** burt has quit IRC22:19
dansmithcfriesen: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L17522:19
dansmithmight be what I was thinking of22:19
*** jamielennox|away is now known as jamielennox22:19
cfriesendansmith: likely.  the most recent version should be what you were asking for...I haven't had a chance to test it out critically yet.22:21
dansmithcfriesen: yep, just looked22:21
dansmithcfriesen: needs tests and then I think it's good22:21
cfriesendansmith: you looking for additional unit tests to cover the race case?22:23
dansmithcfriesen: yeah22:23
dansmithcfriesen: probably also good to verify that the numa bit gets caught in that save too,22:23
dansmithso that someone doesn't reorder it ignoring your comment22:23
cfriesendansmith: makes sense.  going to be a while, got internal stuff to close off before summit22:24
dansmithokay22:24
cfriesendansmith: thanks for the assist22:24
dansmithnp, thanks for not listening to my first assessment of the situation :)22:25
*** nelsnelson has quit IRC22:25
cfriesenlol22:26
*** baoli has quit IRC22:26
*** otter768 has joined #openstack-nova22:30
*** pixelbeat has quit IRC22:30
*** Sukhdev has joined #openstack-nova22:33
*** patrickeast has quit IRC22:33
*** patrickeast_ has joined #openstack-nova22:33
*** ekarlso has quit IRC22:34
*** ekarlso has joined #openstack-nova22:34
*** otter768 has quit IRC22:35
*** cfriesen has quit IRC22:35
*** cfriesen has joined #openstack-nova22:35
*** Sukhdev_ has quit IRC22:37
*** dims_ has joined #openstack-nova22:40
*** achanda has joined #openstack-nova22:40
-openstackstatus- NOTICE: Gerrit and Zuul are going offline for reboots to fix a security vulnerability.22:40
*** ChanServ changes topic to "Gerrit and Zuul are going offline for reboots to fix a security vulnerability."22:40
*** dims has quit IRC22:41
*** Sukhdev has quit IRC22:43
*** dims has joined #openstack-nova22:43
*** claudiub has joined #openstack-nova22:45
*** dims_ has quit IRC22:47
*** openstackgerrit has quit IRC22:47
*** ddutta has quit IRC22:48
*** openstackgerrit has joined #openstack-nova22:49
*** claudiub has quit IRC22:49
*** claudiub has joined #openstack-nova22:50
*** pixelbeat has joined #openstack-nova22:51
*** Raildo_ has joined #openstack-nova22:53
*** tonytan4ever has quit IRC22:54
*** obedmr has quit IRC22:54
*** ericksonfgds has joined #openstack-nova22:58
*** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. -=- master is open for Lemming development"22:58
-openstackstatus- NOTICE: Gerrit and Zuul are back online.22:58
*** patrickeast_ has quit IRC22:58
*** patrickeast has joined #openstack-nova23:01
*** tjones2 has joined #openstack-nova23:07
*** tjones2 has left #openstack-nova23:08
openstackgerritDan Smith proposed openstack/nova: Fix loading things in instance_extra for old instances  https://review.openstack.org/18278723:08
*** achanda has quit IRC23:09
*** tjones1 has quit IRC23:09
*** gokrokve has quit IRC23:13
*** gokrokve has joined #openstack-nova23:14
*** gokrokve has quit IRC23:15
*** pixelbeat has quit IRC23:16
*** signed8bit is now known as signed8bit_ZZZzz23:16
*** vipuls is now known as vipul23:20
*** Marga_ has quit IRC23:20
*** Marga_ has joined #openstack-nova23:21
openstackgerritJoe Gordon proposed openstack/nova: Add note to doc  explaining scope  https://review.openstack.org/18288123:22
openstackgerritJoe Gordon proposed openstack/nova: Consolidate API sections in docs  https://review.openstack.org/18288223:22
openstackgerritJoe Gordon proposed openstack/nova: Use a depth of 2 in devref  https://review.openstack.org/18288323:22
openstackgerritJoe Gordon proposed openstack/nova: Prune development.environment doc  https://review.openstack.org/18288423:22
openstackgerritJoe Gordon proposed openstack/nova: Add API section to devref  https://review.openstack.org/18288523:22
openstackgerritVictor Stinner proposed openstack/nova: Replace dict(obj.iteritems()) with dict(obj)  https://review.openstack.org/18288723:24
*** achanda has joined #openstack-nova23:26
*** igordcard has quit IRC23:29
*** signed8bit_ZZZzz is now known as signed8bit23:31
dansmithcfriesen:23:33
openstackgerritDan Smith proposed openstack/nova: Fix race between resource audit and cpu pinning  https://review.openstack.org/18276623:33
*** JayF has quit IRC23:33
dansmith+= tests23:33
*** BadCub is now known as BadCub-Hiding23:38
*** Raildo_ has quit IRC23:44
*** rfolco has quit IRC23:45
*** ociuhandu has quit IRC23:45
*** dave-mccowan has joined #openstack-nova23:47
*** tsekiyam_ has joined #openstack-nova23:53
*** exploreshaifali has joined #openstack-nova23:54
jlvillaldansmith: Any chance you can "restore" https://review.openstack.org/#/c/130877/  ?23:54
jlvillaldansmith: I am going to start working on it.  And the original owner is on vacation, until the summit starts.23:54
dansmithdone23:55
jlvillaldansmith: Thanks!23:55
dansmithnp23:55
*** ericksonfgds has quit IRC23:55
*** tsekiyama has quit IRC23:57
openstackgerritVictor Stinner proposed openstack/nova: Replace dict.iteritems() with six.iteritems(dict)  https://review.openstack.org/17978423:57
openstackgerritVictor Stinner proposed openstack/nova: Replace dict(obj.iteritems()) with dict(obj)  https://review.openstack.org/18288723:57
*** mtanino has quit IRC23:57
*** tsekiyam_ has quit IRC23:58
*** tjones1 has joined #openstack-nova23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!