| *** baoli_ has quit IRC | 00:00 | |
| *** baoli has joined #openstack-nova | 00:01 | |
| *** Longgeek has joined #openstack-nova | 00:01 | |
| *** dboik has quit IRC | 00:02 | |
| *** iamjarvo has quit IRC | 00:02 | |
| *** dboik_ has quit IRC | 00:02 | |
| openstackgerrit | Tim Pownall proposed openstack/nova: Updated determine_vm_mode and _attach_disks to pull vm_mode and auto_disk_config values from the image_ref during rescue mode. https://review.openstack.org/164940 | 00:03 |
|---|---|---|
| melwitt | mikal: as long as we don't have to wait for the microversion support, and from what cyeoh has said in the review (https://review.openstack.org/#/c/152569/) that patch only adds the very basic things, doesn't offer full support | 00:04 |
| *** baoli has quit IRC | 00:05 | |
| *** Nikolay_1t has quit IRC | 00:05 | |
| *** Nikolay_St has joined #openstack-nova | 00:06 | |
| *** yjiang5 has quit IRC | 00:09 | |
| *** baoli has joined #openstack-nova | 00:09 | |
| mikal | melwitt: well, we have a deps freeze in a couple of days | 00:11 |
| mikal | melwitt: worst case we can do another release to add that in | 00:11 |
| mikal | oomichi: fixed, sorry I missed that | 00:12 |
| *** marun has joined #openstack-nova | 00:13 | |
| *** rmoe has quit IRC | 00:13 | |
| oomichi | mikal: thanks again! | 00:13 |
| *** shaohe_feng1 has quit IRC | 00:13 | |
| melwitt | mikal: cool. not knowing deeply about microversion I'm not sure how soon it's needed, but I was just thinking in general client can't take advantage of the feature in nova until then | 00:14 |
| *** baoli has quit IRC | 00:14 | |
| mikal | melwitt: well, we don't have release freezes for clients, so we can just roll it out when its ready | 00:15 |
| *** markvoelker has quit IRC | 00:15 | |
| melwitt | mikal: right, I think it sounds good | 00:15 |
| *** achanda has quit IRC | 00:15 | |
| *** achanda has joined #openstack-nova | 00:16 | |
| *** oomichi has quit IRC | 00:17 | |
| *** baoli has joined #openstack-nova | 00:18 | |
| *** achanda has quit IRC | 00:18 | |
| *** achanda has joined #openstack-nova | 00:18 | |
| *** Longgeek has quit IRC | 00:18 | |
| *** rmoe has joined #openstack-nova | 00:26 | |
| *** tsekiyam_ has joined #openstack-nova | 00:27 | |
| *** mtanino has quit IRC | 00:30 | |
| *** achanda has quit IRC | 00:30 | |
| *** tsekiyama has quit IRC | 00:30 | |
| *** tsekiyam_ has quit IRC | 00:31 | |
| *** markvoelker has joined #openstack-nova | 00:32 | |
| *** dave-mccowan has joined #openstack-nova | 00:34 | |
| *** dboik has joined #openstack-nova | 00:35 | |
| *** vmtrooper has joined #openstack-nova | 00:35 | |
| *** nelsnelson has quit IRC | 00:35 | |
| *** dboik_ has joined #openstack-nova | 00:36 | |
| *** Mike_D_laptop has quit IRC | 00:37 | |
| cyeoh | melwitt: which change is dependent on microversions support? | 00:38 |
| melwitt | cyeoh: ot | 00:38 |
| melwitt | cyeoh: it's not a change that's dependent, I was talking about support for microversions in novaclient that you have commented recently https://review.openstack.org/#/c/152569/ | 00:39 |
| *** dboik has quit IRC | 00:40 | |
| cyeoh | melwitt, ah yea we' re not affected by the freeze since its nova client but I've been wondering if I should just update it | 00:40 |
| melwitt | cyeoh: basically I was thinking the support in novaclient is important because until then, lots of users won't be able to take advantage of the microversions that are in nova. | 00:40 |
| *** vmtrooper has quit IRC | 00:40 | |
| cyeoh | melwitt: yep, it would effectively be only accessible via the REST API directly | 00:41 |
| melwitt | cyeoh: we have the freedom to release that whenever it's ready like you said since we're not affected by the freezes. but just to put that review on people's radar :) | 00:41 |
| *** diegows has quit IRC | 00:41 | |
| *** diegows has joined #openstack-nova | 00:42 | |
| cyeoh | melwitt: yea sounds good. I should probably sketch out a list of things for novaclient that we need to do and check with Andrey if its ok if I refactor it a bit myself so we can start merging very minimal functionality | 00:44 |
| melwitt | cyeoh: I think that would be great. thanks for taking a look at it, we needed the api experts in there | 00:45 |
| *** rfolco has joined #openstack-nova | 00:46 | |
| cyeoh | melwitt: ok will get on to it this afternoon | 00:46 |
| melwitt | thanks cyeoh | 00:47 |
| *** melwitt has quit IRC | 00:51 | |
| *** browne has quit IRC | 00:52 | |
| *** asettle has quit IRC | 00:55 | |
| *** baoli has quit IRC | 00:55 | |
| *** ybathia has quit IRC | 00:56 | |
| *** Nikolay_St has quit IRC | 00:57 | |
| *** annashen has joined #openstack-nova | 00:58 | |
| *** Nikolay_St has joined #openstack-nova | 00:59 | |
| *** Longgeek has joined #openstack-nova | 00:59 | |
| *** slong has joined #openstack-nova | 00:59 | |
| *** annashen has quit IRC | 01:02 | |
| openstackgerrit | Christopher Yeoh proposed openstack/nova: Add common function for v2 API flavor_get. https://review.openstack.org/136567 | 01:02 |
| *** promulo__ has joined #openstack-nova | 01:03 | |
| *** salv-orl_ has quit IRC | 01:04 | |
| *** neelashah has joined #openstack-nova | 01:06 | |
| *** promulo has quit IRC | 01:06 | |
| *** neelashah has quit IRC | 01:08 | |
| *** tjones1 has quit IRC | 01:08 | |
| *** yingjun has joined #openstack-nova | 01:12 | |
| *** Maike has quit IRC | 01:19 | |
| *** Nic has quit IRC | 01:19 | |
| *** Maike has joined #openstack-nova | 01:20 | |
| *** dsanders has quit IRC | 01:22 | |
| *** apuimedo has quit IRC | 01:25 | |
| *** otter768 has joined #openstack-nova | 01:30 | |
| *** popw has joined #openstack-nova | 01:32 | |
| *** otter768 has quit IRC | 01:35 | |
| *** slong_ has joined #openstack-nova | 01:38 | |
| *** shaohe_feng1 has joined #openstack-nova | 01:38 | |
| *** slong has quit IRC | 01:39 | |
| *** rdo has quit IRC | 01:41 | |
| *** nellysmitt has joined #openstack-nova | 01:43 | |
| dims | tonyb: thanks! | 01:44 |
| *** park_ has joined #openstack-nova | 01:45 | |
| *** adalbas has quit IRC | 01:45 | |
| dims | mikal: one config drive review if you get a chance libvirt has issues only with cdrom as disk format during live migration. vfat works fine. verified both on trunk using a tempest test and on a stable juno setup at work. here's the review - https://review.openstack.org/#/c/133919/ | 01:46 |
| dims | thanks! | 01:46 |
| *** nellysmitt has quit IRC | 01:47 | |
| *** zhenguo has quit IRC | 01:47 | |
| *** jcru has joined #openstack-nova | 01:49 | |
| *** yingjun has quit IRC | 01:52 | |
| *** eliqiao has joined #openstack-nova | 01:53 | |
| *** shaohe_feng has left #openstack-nova | 01:55 | |
| *** shaohe_feng has joined #openstack-nova | 01:55 | |
| *** yingjun has joined #openstack-nova | 01:55 | |
| *** VW_ has joined #openstack-nova | 01:56 | |
| *** igordcard_ has quit IRC | 01:59 | |
| *** dims has quit IRC | 01:59 | |
| *** casusbel_ has joined #openstack-nova | 02:02 | |
| *** VW_ has quit IRC | 02:03 | |
| *** VW_ has joined #openstack-nova | 02:03 | |
| *** casusbelli has quit IRC | 02:06 | |
| *** harlowja_ is now known as harlowja_away | 02:06 | |
| *** slong_ has quit IRC | 02:06 | |
| openstackgerrit | Vincent Hou proposed openstack/nova: Add attach_status check before detaching a volume https://review.openstack.org/164951 | 02:07 |
| *** yamahata has quit IRC | 02:09 | |
| *** salv-orlando has joined #openstack-nova | 02:18 | |
| *** unicell has quit IRC | 02:19 | |
| *** coolsvap|afk is now known as coolsvap | 02:19 | |
| *** erkules_ has joined #openstack-nova | 02:21 | |
| *** sdake__ has joined #openstack-nova | 02:21 | |
| *** asettle has joined #openstack-nova | 02:23 | |
| *** VW_ has quit IRC | 02:23 | |
| *** erkules has quit IRC | 02:23 | |
| *** vmtrooper has joined #openstack-nova | 02:24 | |
| *** sdake has quit IRC | 02:25 | |
| *** yingjun has quit IRC | 02:25 | |
| *** marun has quit IRC | 02:25 | |
| *** hblixt has quit IRC | 02:26 | |
| *** dsanders has joined #openstack-nova | 02:26 | |
| *** yingjun has joined #openstack-nova | 02:28 | |
| *** telemons1er is now known as telmnstr | 02:28 | |
| *** telmnstr is now known as telemonster | 02:28 | |
| *** vmtrooper has quit IRC | 02:29 | |
| *** diegows has quit IRC | 02:30 | |
| *** Maike_ has joined #openstack-nova | 02:30 | |
| *** Maike has quit IRC | 02:31 | |
| *** haomaiwang has joined #openstack-nova | 02:32 | |
| *** VW_ has joined #openstack-nova | 02:33 | |
| *** coolsvap is now known as coolsvap|afk | 02:33 | |
| *** kaisers1 has joined #openstack-nova | 02:34 | |
| *** browne has joined #openstack-nova | 02:34 | |
| *** kaisers has quit IRC | 02:34 | |
| *** zzzeek has joined #openstack-nova | 02:35 | |
| *** otter768 has joined #openstack-nova | 02:37 | |
| *** baoli has joined #openstack-nova | 02:38 | |
| *** coolsvap|afk is now known as coolsvap | 02:45 | |
| *** melwitt has joined #openstack-nova | 02:52 | |
| *** exploreshaifali has joined #openstack-nova | 02:55 | |
| *** exploreshaifali has quit IRC | 03:00 | |
| *** baoli has quit IRC | 03:01 | |
| *** zzzeek has quit IRC | 03:01 | |
| *** baoli has joined #openstack-nova | 03:01 | |
| *** jcru has quit IRC | 03:05 | |
| *** marun has joined #openstack-nova | 03:06 | |
| *** yingjun has quit IRC | 03:07 | |
| *** coolsvap is now known as coolsvap|afk | 03:09 | |
| *** Marga_ has quit IRC | 03:09 | |
| *** dboik_ has quit IRC | 03:13 | |
| *** gyee has quit IRC | 03:15 | |
| *** coolsvap|afk is now known as coolsvap | 03:16 | |
| *** dsanders has quit IRC | 03:18 | |
| *** ajayaa has joined #openstack-nova | 03:19 | |
| *** changbl has joined #openstack-nova | 03:20 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for floating_ips_bulk https://review.openstack.org/150704 | 03:23 |
| *** salv-orlando has quit IRC | 03:29 | |
| *** Longgeek has quit IRC | 03:29 | |
| *** kiwik-chenrui has quit IRC | 03:33 | |
| *** sbfox has joined #openstack-nova | 03:39 | |
| *** sdake__ has quit IRC | 03:39 | |
| *** sdake has joined #openstack-nova | 03:41 | |
| *** tonytan4ever has quit IRC | 03:41 | |
| *** nellysmitt has joined #openstack-nova | 03:44 | |
| *** melwitt has quit IRC | 03:47 | |
| *** nellysmitt has quit IRC | 03:48 | |
| *** rfolco has quit IRC | 03:53 | |
| *** baoli has quit IRC | 03:58 | |
| *** baoli has joined #openstack-nova | 03:59 | |
| *** ajayaa has quit IRC | 04:01 | |
| *** ijw has quit IRC | 04:02 | |
| *** otter768 has quit IRC | 04:04 | |
| *** rajesht has joined #openstack-nova | 04:08 | |
| *** Marga_ has joined #openstack-nova | 04:11 | |
| *** Marga__ has joined #openstack-nova | 04:12 | |
| *** vmtrooper has joined #openstack-nova | 04:13 | |
| *** dave-mccowan has quit IRC | 04:14 | |
| *** Marga_ has quit IRC | 04:16 | |
| *** vmtrooper has quit IRC | 04:18 | |
| *** patrickeast has quit IRC | 04:28 | |
| *** salv-orlando has joined #openstack-nova | 04:28 | |
| *** Longgeek has joined #openstack-nova | 04:30 | |
| *** ajayaa has joined #openstack-nova | 04:37 | |
| *** rushiagr_away is now known as rushiagr | 04:37 | |
| *** Longgeek has quit IRC | 04:37 | |
| *** Longgeek has joined #openstack-nova | 04:38 | |
| *** baoli has quit IRC | 04:42 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Rename and move the v2.1 api policy into separated files https://review.openstack.org/150267 | 04:43 |
| *** adrian_otto has joined #openstack-nova | 04:47 | |
| *** VW_ has quit IRC | 04:47 | |
| *** ajayaa has quit IRC | 04:47 | |
| *** boris-42 has joined #openstack-nova | 04:47 | |
| *** VW_ has joined #openstack-nova | 04:48 | |
| *** marun has quit IRC | 04:48 | |
| *** VW__ has joined #openstack-nova | 04:48 | |
| *** dsanders has joined #openstack-nova | 04:50 | |
| *** dims has joined #openstack-nova | 04:52 | |
| *** VW_ has quit IRC | 04:53 | |
| *** VW__ has quit IRC | 04:57 | |
| *** dims has quit IRC | 04:57 | |
| *** VW_ has joined #openstack-nova | 04:58 | |
| *** VW__ has joined #openstack-nova | 04:58 | |
| *** VW__ has quit IRC | 04:59 | |
| *** yingjun has joined #openstack-nova | 05:02 | |
| *** VW_ has quit IRC | 05:02 | |
| *** penick has joined #openstack-nova | 05:05 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Update unique constraint of compute_nodes with deleted column https://review.openstack.org/153123 | 05:06 |
| *** achanda has joined #openstack-nova | 05:06 | |
| *** yingjun has quit IRC | 05:10 | |
| mikal | dims: that breakage has been known for a while and worked around... Did we regress? | 05:10 |
| openstackgerrit | Joe Julian proposed openstack/nova: log meaningful error message on download exception https://review.openstack.org/164039 | 05:11 |
| *** penick has quit IRC | 05:11 | |
| *** sdake has quit IRC | 05:13 | |
| *** asettle has quit IRC | 05:13 | |
| *** xek has quit IRC | 05:18 | |
| *** unicell has joined #openstack-nova | 05:20 | |
| *** sbfox has quit IRC | 05:23 | |
| *** salv-orlando has quit IRC | 05:31 | |
| *** markvoelker has quit IRC | 05:33 | |
| *** penick has joined #openstack-nova | 05:35 | |
| *** rushiagr is now known as rushiagr_away | 05:36 | |
| openstackgerrit | Amandeep proposed openstack/python-novaclient: Flavor created only when flavorid is an integer https://review.openstack.org/165299 | 05:41 |
| *** casusbel_ has quit IRC | 05:42 | |
| *** casusbelli has joined #openstack-nova | 05:43 | |
| *** armax has quit IRC | 05:44 | |
| *** nellysmitt has joined #openstack-nova | 05:44 | |
| *** garyk has quit IRC | 05:46 | |
| *** Sukhdev has joined #openstack-nova | 05:47 | |
| *** sbfox has joined #openstack-nova | 05:49 | |
| *** nellysmitt has quit IRC | 05:49 | |
| *** rajesht_ has joined #openstack-nova | 05:49 | |
| *** Maike_ has quit IRC | 05:50 | |
| *** yingjun has joined #openstack-nova | 05:52 | |
| *** ybathia has joined #openstack-nova | 05:55 | |
| *** bkopilov has joined #openstack-nova | 05:55 | |
| *** ajayaa has joined #openstack-nova | 06:01 | |
| *** vmtrooper has joined #openstack-nova | 06:02 | |
| *** annashen has joined #openstack-nova | 06:03 | |
| *** rushiagr_away is now known as rushiagr | 06:03 | |
| *** otter768 has joined #openstack-nova | 06:05 | |
| *** vmtrooper has quit IRC | 06:07 | |
| *** annashen has quit IRC | 06:08 | |
| *** otter768 has quit IRC | 06:09 | |
| *** lpetrut has joined #openstack-nova | 06:10 | |
| *** ybathia has quit IRC | 06:12 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/162030 | 06:18 |
| gmann | sdague: regarding v2 test failure for v2.1 in https://review.openstack.org/#/c/165053/ | 06:19 |
| gmann | sdague: in v2 tests, all v2.1 extensions became enabled (because 'extensions_whitelist' is blank). | 06:24 |
| *** sudipto has joined #openstack-nova | 06:24 | |
| gmann | sdague: there are extensions merged/split between v2 and v2.1, so might be some tests would work against other endpoints. Need to twist tests to enable tests | 06:25 |
| *** _gryf has joined #openstack-nova | 06:25 | |
| *** achanda has quit IRC | 06:25 | |
| gmann | sdague: may be like - https://review.openstack.org/#/c/162016/5/nova/tests/functional/v3/test_flavors.py | 06:26 |
| *** achanda has joined #openstack-nova | 06:27 | |
| *** ferest has joined #openstack-nova | 06:27 | |
| *** Nikolay_St has quit IRC | 06:27 | |
| *** liusheng has quit IRC | 06:31 | |
| *** liusheng has joined #openstack-nova | 06:31 | |
| *** nellysmitt has joined #openstack-nova | 06:32 | |
| *** ferest has quit IRC | 06:32 | |
| *** Mike_D_laptop has joined #openstack-nova | 06:32 | |
| *** salv-orlando has joined #openstack-nova | 06:33 | |
| *** markvoelker has joined #openstack-nova | 06:33 | |
| *** shaohe_feng1 has quit IRC | 06:33 | |
| *** ishant has joined #openstack-nova | 06:35 | |
| *** markvoelker has quit IRC | 06:38 | |
| *** oro has joined #openstack-nova | 06:40 | |
| *** Maike has joined #openstack-nova | 06:42 | |
| *** oro_ has joined #openstack-nova | 06:42 | |
| *** oro has quit IRC | 06:44 | |
| *** oro_ has quit IRC | 06:45 | |
| *** oro_ has joined #openstack-nova | 06:46 | |
| *** oro_ has quit IRC | 06:46 | |
| *** oro_ has joined #openstack-nova | 06:47 | |
| *** afazekas has joined #openstack-nova | 06:47 | |
| openstackgerrit | Amandeep proposed openstack/python-novaclient: Flavor created only when flavorid is an integer https://review.openstack.org/165299 | 06:54 |
| *** browne has quit IRC | 06:55 | |
| *** _gryf has quit IRC | 06:55 | |
| openstackgerrit | Ankit Agrawal proposed openstack/nova: Detach volume after deleting the instance https://review.openstack.org/145738 | 06:57 |
| *** mestery has quit IRC | 06:58 | |
| *** rajesht_ has quit IRC | 06:59 | |
| *** _gryf has joined #openstack-nova | 07:02 | |
| *** Sukhdev has quit IRC | 07:03 | |
| *** adrian_otto has quit IRC | 07:05 | |
| *** __gryf has joined #openstack-nova | 07:11 | |
| *** aswadr has joined #openstack-nova | 07:14 | |
| *** garyk has joined #openstack-nova | 07:15 | |
| *** adelinatuvenie has joined #openstack-nova | 07:16 | |
| *** markvoelker has joined #openstack-nova | 07:17 | |
| *** mpavone has joined #openstack-nova | 07:20 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Raise an exception when adding an already associated security group https://review.openstack.org/160689 | 07:20 |
| *** aix has quit IRC | 07:20 | |
| *** romainh has joined #openstack-nova | 07:20 | |
| *** pkoniszewski has joined #openstack-nova | 07:20 | |
| *** nellysmi_ has joined #openstack-nova | 07:21 | |
| *** markvoelker has quit IRC | 07:21 | |
| *** nellysmitt has quit IRC | 07:22 | |
| *** sahid has joined #openstack-nova | 07:25 | |
| *** oro_ has quit IRC | 07:25 | |
| *** nellysmi_ has quit IRC | 07:26 | |
| *** pradipta has joined #openstack-nova | 07:28 | |
| *** nellysmitt has joined #openstack-nova | 07:28 | |
| *** salv-orlando has quit IRC | 07:33 | |
| park_ | gmann: ping. | 07:34 |
| *** achanda has quit IRC | 07:35 | |
| *** ildikov has quit IRC | 07:35 | |
| *** lpetrut has quit IRC | 07:37 | |
| gmann | park_: pong | 07:38 |
| *** achanda has joined #openstack-nova | 07:39 | |
| *** salv-orlando has joined #openstack-nova | 07:42 | |
| *** adelinatuvenie has quit IRC | 07:49 | |
| *** ishant has quit IRC | 07:50 | |
| *** vmtrooper has joined #openstack-nova | 07:51 | |
| *** ishant has joined #openstack-nova | 07:51 | |
| *** jcoufal has joined #openstack-nova | 07:55 | |
| openstackgerrit | Joshua Hesketh proposed openstack/nova: Add pip-check-reqs tox environment https://review.openstack.org/164973 | 07:55 |
| *** vmtrooper has quit IRC | 07:56 | |
| *** doude has joined #openstack-nova | 07:58 | |
| *** Bsony has joined #openstack-nova | 07:58 | |
| *** jlanoux has joined #openstack-nova | 08:03 | |
| *** TobiasE1 has joined #openstack-nova | 08:03 | |
| *** rushiagr is now known as rushiagr_away | 08:05 | |
| *** TobiasE has quit IRC | 08:05 | |
| *** otter768 has joined #openstack-nova | 08:06 | |
| *** belmoreira has joined #openstack-nova | 08:07 | |
| *** dulek has joined #openstack-nova | 08:09 | |
| *** markus_z has joined #openstack-nova | 08:09 | |
| *** otter768 has quit IRC | 08:10 | |
| *** achanda has quit IRC | 08:10 | |
| *** rushiagr_away is now known as rushiagr | 08:11 | |
| *** exploreshaifali has joined #openstack-nova | 08:12 | |
| *** Marga__ has quit IRC | 08:13 | |
| *** pradipta has quit IRC | 08:14 | |
| *** yingjun has quit IRC | 08:17 | |
| *** markvoelker has joined #openstack-nova | 08:18 | |
| *** dsanders has quit IRC | 08:19 | |
| *** mleroy_ has joined #openstack-nova | 08:22 | |
| *** jistr has joined #openstack-nova | 08:22 | |
| *** markvoelker has quit IRC | 08:23 | |
| *** matrohon has joined #openstack-nova | 08:23 | |
| *** lsmola has joined #openstack-nova | 08:25 | |
| *** dsanders has joined #openstack-nova | 08:26 | |
| *** adelinatuvenie has joined #openstack-nova | 08:27 | |
| *** _gryf has quit IRC | 08:28 | |
| *** sahid has quit IRC | 08:28 | |
| *** __gryf is now known as _gryf | 08:29 | |
| *** yingjun has joined #openstack-nova | 08:29 | |
| *** pradipta has joined #openstack-nova | 08:30 | |
| *** sbfox has quit IRC | 08:30 | |
| *** moshele has joined #openstack-nova | 08:31 | |
| *** ildikov has joined #openstack-nova | 08:31 | |
| *** sahid has joined #openstack-nova | 08:33 | |
| *** ndipanov has joined #openstack-nova | 08:33 | |
| *** apuimedo has joined #openstack-nova | 08:35 | |
| *** jlanoux has quit IRC | 08:35 | |
| *** sahid has quit IRC | 08:36 | |
| *** sahid has joined #openstack-nova | 08:37 | |
| *** uschreiber_ has joined #openstack-nova | 08:38 | |
| *** mleroy_ has quit IRC | 08:38 | |
| *** uschreiber_ has quit IRC | 08:39 | |
| *** dsanders has quit IRC | 08:39 | |
| *** uschreiber_ has joined #openstack-nova | 08:41 | |
| *** uschreiber_ has quit IRC | 08:42 | |
| *** uschreiber_ has joined #openstack-nova | 08:42 | |
| *** uschreiber_ has quit IRC | 08:42 | |
| *** gszasz has joined #openstack-nova | 08:48 | |
| *** ankit_ag has joined #openstack-nova | 08:54 | |
| openstackgerrit | yuntongjin proposed openstack/nova: Remove db layer hard-code permission checks for floating_ips_bulk https://review.openstack.org/150704 | 08:59 |
| *** Maike has quit IRC | 08:59 | |
| *** Maike has joined #openstack-nova | 09:00 | |
| *** ociuhandu has quit IRC | 09:01 | |
| openstackgerrit | garyk proposed openstack/nova: Tox: reduce complexity level to 35 https://review.openstack.org/165335 | 09:01 |
| *** annashen has joined #openstack-nova | 09:05 | |
| *** deepthi has joined #openstack-nova | 09:06 | |
| *** Mike_D_laptop has quit IRC | 09:07 | |
| *** erkules_ is now known as erkules | 09:07 | |
| *** erkules has joined #openstack-nova | 09:07 | |
| *** annashen has quit IRC | 09:10 | |
| *** lucasagomes has joined #openstack-nova | 09:12 | |
| *** boris-42 has quit IRC | 09:12 | |
| *** andreykurilin_ has joined #openstack-nova | 09:15 | |
| *** nuritv has joined #openstack-nova | 09:15 | |
| *** park_ has quit IRC | 09:18 | |
| *** markvoelker has joined #openstack-nova | 09:19 | |
| *** Mike_D_laptop has joined #openstack-nova | 09:21 | |
| *** markvoelker has quit IRC | 09:23 | |
| *** mleroy_ has joined #openstack-nova | 09:28 | |
| *** afazekas_ has joined #openstack-nova | 09:31 | |
| *** yingjun has quit IRC | 09:33 | |
| *** mleroy_ has quit IRC | 09:35 | |
| *** zz_johnthetubagu is now known as johnthetubaguy | 09:36 | |
| *** BobBall_AWOL is now known as BobBall | 09:37 | |
| *** vmtrooper has joined #openstack-nova | 09:40 | |
| openstackgerrit | ZhiQiang Fan proposed openstack/python-novaclient: Don't record time when self.timing is False https://review.openstack.org/165343 | 09:40 |
| openstackgerrit | garyk proposed openstack/nova: Tox: reduce complexity level to 35 https://review.openstack.org/165335 | 09:42 |
| *** ZZelle has quit IRC | 09:43 | |
| *** dims_ has joined #openstack-nova | 09:43 | |
| *** ZZelle has joined #openstack-nova | 09:43 | |
| *** jlanoux has joined #openstack-nova | 09:44 | |
| *** afazekas_ has quit IRC | 09:45 | |
| *** vmtrooper has quit IRC | 09:45 | |
| *** oro_ has joined #openstack-nova | 09:45 | |
| *** alexpilotti has joined #openstack-nova | 09:47 | |
| *** penick has quit IRC | 09:49 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Neutron: Check port binding status https://review.openstack.org/156112 | 09:49 |
| *** eliqiao has quit IRC | 09:52 | |
| *** pixelb has joined #openstack-nova | 09:55 | |
| *** kashyapc_ has joined #openstack-nova | 09:58 | |
| *** otter768 has joined #openstack-nova | 10:06 | |
| *** bfic has joined #openstack-nova | 10:10 | |
| *** otter768 has quit IRC | 10:11 | |
| *** xek has joined #openstack-nova | 10:12 | |
| *** nellysmitt has quit IRC | 10:13 | |
| *** aloga has quit IRC | 10:15 | |
| *** halfss has joined #openstack-nova | 10:15 | |
| *** aloga has joined #openstack-nova | 10:16 | |
| *** TobiasE has joined #openstack-nova | 10:19 | |
| *** TobiasE1 has quit IRC | 10:19 | |
| *** markvoelker has joined #openstack-nova | 10:19 | |
| *** exploreshaifali has quit IRC | 10:21 | |
| *** markvoelker has quit IRC | 10:24 | |
| *** yingjun has joined #openstack-nova | 10:26 | |
| *** haomaiwang has quit IRC | 10:26 | |
| *** mestery has joined #openstack-nova | 10:26 | |
| *** haomaiwang has joined #openstack-nova | 10:27 | |
| *** halfss has quit IRC | 10:27 | |
| *** yingjun has quit IRC | 10:28 | |
| *** haomaiwang has quit IRC | 10:31 | |
| *** andreykurilin_ has quit IRC | 10:34 | |
| *** nellysmitt has joined #openstack-nova | 10:35 | |
| *** nellysmitt has quit IRC | 10:37 | |
| *** redhand has joined #openstack-nova | 10:39 | |
| redhand | Hello. | 10:39 |
| redhand | I have problem with migration in openstack icehouse. | 10:39 |
| redhand | It seems that when migrating instance, openstack create new one. | 10:39 |
| redhand | I do not have any data that I had before migration. | 10:39 |
| mdbooth | redhand: Hey, sounds like a question which would be better asked in #openstack | 10:43 |
| redhand | Ok. Thanks. | 10:43 |
| mdbooth | redhand: Np. Good luck. | 10:43 |
| *** kashyapc_ has quit IRC | 10:43 | |
| redhand | :-) | 10:43 |
| *** unicell has quit IRC | 10:44 | |
| *** kashyapc has joined #openstack-nova | 10:45 | |
| *** gmann_ has joined #openstack-nova | 10:45 | |
| *** exploreshaifali has joined #openstack-nova | 10:45 | |
| *** jyuso1 has quit IRC | 10:51 | |
| *** boris-42 has joined #openstack-nova | 10:51 | |
| openstackgerrit | wuhao proposed openstack/nova-specs: Add previous page links for Nova GET servers API https://review.openstack.org/165041 | 10:52 |
| *** Bsony_ has joined #openstack-nova | 10:54 | |
| *** nellysmitt has joined #openstack-nova | 10:55 | |
| *** ajayaa has quit IRC | 10:56 | |
| *** yingjun has joined #openstack-nova | 10:56 | |
| sahid | ndipanov: if you can take a llok at this, when i have worked to add new test i felt like we can make the method _test_compute_api better | 10:57 |
| sahid | https://review.openstack.org/#/c/164177/ | 10:57 |
| *** Bsony has quit IRC | 10:57 | |
| *** penick has joined #openstack-nova | 10:58 | |
| ndipanov | sahid, hmm interesting | 10:58 |
| *** rushiagr is now known as rushiagr_away | 11:01 | |
| *** dulek has quit IRC | 11:02 | |
| *** baoli has joined #openstack-nova | 11:02 | |
| *** dulek has joined #openstack-nova | 11:02 | |
| *** doude has quit IRC | 11:07 | |
| *** annashen has joined #openstack-nova | 11:07 | |
| *** nellysmitt has quit IRC | 11:08 | |
| *** amotoki has joined #openstack-nova | 11:10 | |
| *** redhand has left #openstack-nova | 11:10 | |
| *** annashen has quit IRC | 11:11 | |
| *** mwagner_lap has quit IRC | 11:12 | |
| *** markvoelker has joined #openstack-nova | 11:20 | |
| *** baoli has quit IRC | 11:21 | |
| *** baoli has joined #openstack-nova | 11:21 | |
| *** krykowski has joined #openstack-nova | 11:23 | |
| sdague | gmann: ok, so actually getting rid of the /v3 endpoint without dropping all the sames seems really difficult due to these changes in assumptions | 11:23 |
| sahid | jaypipes: hello, can i ask you to take a look a these two reviews 159106, 160904 - the last one is a fix that could be intersting to merge for K3 then that still need to be worked to make the possibility to use NUMA cells without memory or cpu defined | 11:23 |
| *** markvoelker has quit IRC | 11:25 | |
| *** vmtrooper has joined #openstack-nova | 11:29 | |
| openstackgerrit | Keiichi KII proposed openstack/nova: libvirt: add a utility to extract detached IQNs for multipath https://review.openstack.org/165370 | 11:29 |
| sdague | alaski: once you get up - https://review.openstack.org/#/c/164794/ has a bug and really should have more tests | 11:31 |
| *** IanGovett has joined #openstack-nova | 11:31 | |
| openstackgerrit | sahid proposed openstack/nova: doc: fix a docstext formatting https://review.openstack.org/165372 | 11:32 |
| openstackgerrit | Keiichi KII proposed openstack/nova: libvirt: add a utility to extract attached IQNs for multipath https://review.openstack.org/165373 | 11:32 |
| *** nellysmitt has joined #openstack-nova | 11:33 | |
| *** vmtrooper has quit IRC | 11:34 | |
| *** IanGovett has quit IRC | 11:39 | |
| openstackgerrit | Sean Dague proposed openstack/nova: let fake virt track resources https://review.openstack.org/165376 | 11:40 |
| *** VW_ has joined #openstack-nova | 11:41 | |
| *** mrda is now known as mrda-away | 11:42 | |
| *** nellysmitt has quit IRC | 11:43 | |
| *** setuid has quit IRC | 11:44 | |
| *** achanda has joined #openstack-nova | 11:45 | |
| *** setuid has joined #openstack-nova | 11:45 | |
| *** Nikolay_St has joined #openstack-nova | 11:46 | |
| *** ajayaa has joined #openstack-nova | 11:48 | |
| *** IanGovett has joined #openstack-nova | 11:49 | |
| *** achanda has quit IRC | 11:49 | |
| *** rushiagr_away is now known as rushiagr | 11:51 | |
| *** erlon has joined #openstack-nova | 11:53 | |
| *** lpetrut has joined #openstack-nova | 11:55 | |
| *** dprince has joined #openstack-nova | 11:56 | |
| *** VW_ has quit IRC | 11:57 | |
| *** Nikolay_St has quit IRC | 11:57 | |
| *** david-lyle_afk is now known as david-lyle | 12:00 | |
| *** markvoelker has joined #openstack-nova | 12:02 | |
| *** TobiasE has quit IRC | 12:02 | |
| *** mwagner_lap has joined #openstack-nova | 12:03 | |
| *** yingjun has quit IRC | 12:03 | |
| *** pradipta has quit IRC | 12:04 | |
| sdague | dims_: so I think I asked this the other day, but where is the libvirt bugzilla for this - https://review.openstack.org/#/c/133919 | 12:05 |
| *** TobiasE has joined #openstack-nova | 12:05 | |
| dims_ | https://bugzilla.redhat.com/show_bug.cgi?id=1203032 d34dh0r53 | 12:05 |
| openstack | bugzilla.redhat.com bug 1203032 in libvirt "Enhancing block/disk migration in libvirt" [Low,New] - Assigned to tony | 12:05 |
| dims_ | sdague: https://bugzilla.redhat.com/show_bug.cgi?id=1203032 | 12:05 |
| dims_ | tonyb: helped log it last night | 12:06 |
| sdague | ok, can we reference that in the code instead of the lp bug | 12:06 |
| sdague | or in addition | 12:06 |
| dims_ | lp bug has it in comments, is that enough? | 12:06 |
| sdague | I suppose | 12:07 |
| dims_ | was not sure since this is the working path that got blocked by mistake... | 12:07 |
| *** otter768 has joined #openstack-nova | 12:07 | |
| dims_ | thanks sdague | 12:08 |
| *** marun has joined #openstack-nova | 12:12 | |
| *** otter768 has quit IRC | 12:13 | |
| openstackgerrit | garyk proposed openstack/nova: Ensure that API updates notify compute node https://review.openstack.org/163434 | 12:16 |
| *** sudipto has quit IRC | 12:17 | |
| *** eharney has joined #openstack-nova | 12:17 | |
| *** rfolco has joined #openstack-nova | 12:17 | |
| *** wverdugo500 has left #openstack-nova | 12:17 | |
| *** marun has quit IRC | 12:17 | |
| *** ociuhandu has joined #openstack-nova | 12:18 | |
| *** TobiasE has quit IRC | 12:18 | |
| *** derekh has joined #openstack-nova | 12:19 | |
| *** dims_ has quit IRC | 12:22 | |
| *** dims_ has joined #openstack-nova | 12:22 | |
| *** Mike_D_laptop has quit IRC | 12:23 | |
| *** sdake has joined #openstack-nova | 12:23 | |
| *** popw has quit IRC | 12:23 | |
| *** deepthi has quit IRC | 12:27 | |
| *** raildo_away is now known as raildo | 12:28 | |
| *** gmann_ has quit IRC | 12:29 | |
| *** aysyd has joined #openstack-nova | 12:29 | |
| mdbooth | Does anybody here understand restore: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1869 | 12:32 |
| mdbooth | That looks to me like if an instance has no host we just set it to active in the db and do nothing else. | 12:33 |
| mdbooth | Why would that be correct? | 12:33 |
| *** wverdugo500 has joined #openstack-nova | 12:35 | |
| *** wverdugo500 has left #openstack-nova | 12:35 | |
| *** sdake_ has joined #openstack-nova | 12:37 | |
| sdague | bauzas: are there tests for the claims code that actually ensure the new claim isn't going over the threshold? | 12:38 |
| *** lucasagomes is now known as lucas-hungry | 12:39 | |
| openstackgerrit | Gorka Eguileor proposed openstack/nova: Preserve usage and reservations on quota deletion https://review.openstack.org/163423 | 12:39 |
| *** jistr is now known as jistr|biab | 12:39 | |
| *** TobiasE has joined #openstack-nova | 12:40 | |
| *** unicell has joined #openstack-nova | 12:41 | |
| *** sdake has quit IRC | 12:41 | |
| bauzas | sdague: morning | 12:44 |
| bauzas | sdague: you mean, testing that claims are aborted if going over the limit ? | 12:45 |
| ndipanov | sdague, there must be | 12:46 |
| ndipanov | compute/test_claims.py | 12:46 |
| *** dulek has quit IRC | 12:46 | |
| ndipanov | plus they are also tested by the resource tracker tests | 12:46 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add the instance update calls from Compute https://review.openstack.org/160513 | 12:46 |
| sdague | ok, I thought i was seeing an off by one error on that | 12:47 |
| sdague | let me poke a little more, might just be not enough coffee yet | 12:47 |
| bauzas | sdague: yeah, agreed with ndipanov | 12:47 |
| kashyapc | mdbooth: $ git blame -L 1854,1873 nova/compute/api.py says Dan Smith touched it ('restore' function) multiple times :-) | 12:48 |
| mdbooth | bauzas sdague: I've been thinking about some related things this morning. That code races, so it can over-allocate. I'm guessing that's the sort of race (accounting) we're ok with, though? | 12:49 |
| bauzas | sdague: eg. https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_claims.py#L157-L163 | 12:49 |
| *** rushiagr is now known as rushiagr_away | 12:49 | |
| bauzas | mdbooth: I miss some context | 12:50 |
| bauzas | mdbooth: what is the problem ? | 12:50 |
| bauzas | (not saying there is no problem, but wanted to know the one we're talking about :) ) | 12:50 |
| mdbooth | bauzas: Sorry if I'm butting in :) Assume you and sdague were talking about Claim objects? | 12:51 |
| mdbooth | They race, because resources is passed in unlocked afaict | 12:52 |
| mdbooth | However, I suspect that we wouldn't want to lock resources there, and we're cool with the race | 12:52 |
| mdbooth | dansmith: Question above about restore if you've got a sec. Looks weird, suspect I'm missing some context. | 12:53 |
| *** jecarey has joined #openstack-nova | 12:54 | |
| alaski | sdague: thanks, will look into testing that now | 12:54 |
| *** VW_ has joined #openstack-nova | 12:54 | |
| sdague | bauzas: ok, I'm seeing something odd at a higher level, but hold on, I need to fix a different thing first | 12:55 |
| *** adalbas has joined #openstack-nova | 12:56 | |
| *** salv-orlando has quit IRC | 12:56 | |
| openstackgerrit | Sean Dague proposed openstack/nova: load ram_allocation_ratio when asked https://review.openstack.org/165397 | 12:56 |
| *** TobiasE has quit IRC | 12:57 | |
| *** salv-orlando has joined #openstack-nova | 12:57 | |
| bauzas | mdbooth: well, we still lock when claiming actually | 12:57 |
| bauzas | mdbooth: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L92-L93 | 12:58 |
| mdbooth | bauzas: So we do. | 12:58 |
| sdague | turns out that trying to set ram_allocation_ratio in tests completely doesn't work because of the issue in - https://review.openstack.org/165397 | 12:58 |
| *** dkliban_afk is now known as dkliban | 12:58 | |
| *** READ10 has quit IRC | 12:58 | |
| mdbooth | bauzas: That's a bit of a big hammer, isn't it? | 13:00 |
| bauzas | sdague: mmm, in general, the flags are changed before calling the methods, so it should still work, nope ? | 13:00 |
| *** changbl has quit IRC | 13:00 | |
| *** vladikr has joined #openstack-nova | 13:01 | |
| mdbooth | I guess it's ok if nobody's complaining about the performance | 13:01 |
| bauzas | sdague: I mean, before initing the classes | 13:01 |
| sdague | bauzas: that's not set at init | 13:01 |
| sdague | that's set at class eval time | 13:01 |
| sdague | which happens at code load | 13:01 |
| bauzas | sdague: oh right, checked the link | 13:01 |
| bauzas | mdbooth: Claims are honey pots | 13:02 |
| bauzas | mdbooth: are you sure you want to dig in them ? | 13:02 |
| *** boris-42 has quit IRC | 13:02 | |
| mdbooth | bauzas: Not really, no :) My ears just pricked up because I've been looking at something related this morning. | 13:03 |
| bauzas | mdbooth: disclaimer, I sincerely think we need to do something - but my proposal goes to reworking on the claims by using them in the scheduler | 13:03 |
| *** amotoki has quit IRC | 13:03 | |
| *** amotoki has joined #openstack-nova | 13:05 | |
| *** mpaolino has joined #openstack-nova | 13:06 | |
| edleafe | ndipanov: do you have time to revisit https://review.openstack.org/#/c/148904 ? | 13:06 |
| *** ildikov has quit IRC | 13:06 | |
| ndipanov | edleafe, on my list of things to do today | 13:06 |
| edleafe | ndipanov: kthx | 13:07 |
| ndipanov | but that doesn't mean a lot :( | 13:07 |
| ndipanov | since I got 2 things already that I didn't plan on :( | 13:07 |
| *** mpaolino has quit IRC | 13:07 | |
| *** mpaolino has joined #openstack-nova | 13:08 | |
| *** eharney has quit IRC | 13:11 | |
| *** eharney has joined #openstack-nova | 13:11 | |
| *** neelashah has joined #openstack-nova | 13:13 | |
| openstackgerrit | garyk proposed openstack/nova: VMware: Consume the oslo.vmware objects https://review.openstack.org/136935 | 13:13 |
| *** diegows has joined #openstack-nova | 13:14 | |
| *** vmtrooper has joined #openstack-nova | 13:17 | |
| *** mpaolino has quit IRC | 13:18 | |
| *** mpaolino has joined #openstack-nova | 13:19 | |
| *** eglynn-afk is now known as eglynn | 13:19 | |
| *** kaufer has joined #openstack-nova | 13:20 | |
| bauzas | PaulMurray: around ? | 13:20 |
| *** rushiagr_away is now known as rushiagr | 13:20 | |
| bauzas | PaulMurray: I was reviewing https://review.openstack.org/#/c/165037/2 | 13:20 |
| *** vmtrooper has quit IRC | 13:22 | |
| *** setuid has quit IRC | 13:22 | |
| bauzas | PaulMurray: why aren't you implementing __eq__ without __hash__ ? | 13:23 |
| bauzas | PaulMurray: I also think that dansmith would be interested in your change | 13:23 |
| *** mriedem_away has quit IRC | 13:24 | |
| *** setuid has joined #openstack-nova | 13:24 | |
| edleafe | bauzas: I believe that dansmith and PaulMurray discussed this on IRC a few days ago | 13:24 |
| *** mpaolino has quit IRC | 13:24 | |
| bauzas | edleafe: oh ok | 13:25 |
| *** TobiasE has joined #openstack-nova | 13:25 | |
| *** diegows has quit IRC | 13:25 | |
| *** mpaolino has joined #openstack-nova | 13:25 | |
| bauzas | edleafe: I'm still interested in knowing the reason :) | 13:25 |
| *** TobiasE has quit IRC | 13:26 | |
| *** bkopilov has quit IRC | 13:27 | |
| edleafe | bauzas: I believe it was to prevent unnecessary RT updates. | 13:27 |
| edleafe | bauzas: https://review.openstack.org/#/c/160942/9/nova/compute/resource_tracker.py,cm Line #573 | 13:28 |
| bauzas | edleafe: mmm, that doesn't convince me | 13:29 |
| openstackgerrit | Zhenguo Niu proposed openstack/nova: Put the snapshot task states in correct order https://review.openstack.org/164968 | 13:29 |
| *** mpaolino has quit IRC | 13:30 | |
| *** mpaolino has joined #openstack-nova | 13:31 | |
| bauzas | edleafe: because "a == b" is not the same as "a is b" | 13:31 |
| edleafe | bauzas: this is another type of equivalence | 13:33 |
| bauzas | edleafe: right | 13:33 |
| alex_xu | sdague: re: https://review.openstack.org/150267 json didn't support comment. But we can add an fake rule, the rule name is the comment, does make sense to you? | 13:33 |
| edleafe | bauzas: not comparing in the 'is' sense, but in the 'has the same values' sense | 13:34 |
| bauzas | edleafe: that's exactly why __eq__ exists | 13:34 |
| *** salv-orlando has quit IRC | 13:34 | |
| *** zzzeek has joined #openstack-nova | 13:34 | |
| edleafe | bauzas: how would you handle ignored fields with __eq__? | 13:34 |
| bauzas | edleafe: if we want to test that 2 objects have the same reference, then the 'is' field is for | 13:35 |
| *** alexpilotti has quit IRC | 13:35 | |
| *** VW_ has quit IRC | 13:35 | |
| bauzas | edleafe: that's an implementation detail | 13:36 |
| *** mpaolino has quit IRC | 13:36 | |
| *** mpaolino has joined #openstack-nova | 13:36 | |
| bauzas | edleafe: and logically, if 2 objects are considered equivalent, they're whatever their fields are | 13:36 |
| *** lucas-hungry is now known as lucasagomes | 13:37 | |
| bauzas | edleafe: so, for example, ComputeNode can override __eq__ by adding which ignored fields are | 13:37 |
| *** dboik has joined #openstack-nova | 13:39 | |
| *** jistr|biab is now known as jistr | 13:39 | |
| sdague | alex_xu: hmmm... | 13:40 |
| *** boris-42 has joined #openstack-nova | 13:41 | |
| edleafe | bauzas: I'll leave it to dansmith and PaulMurray to explain the rationale | 13:41 |
| alex_xu | sdague: better way I think it is make oslo.policy ignore a special rule called "comment" | 13:41 |
| sdague | alex_xu: honestly, that seems weird as well | 13:41 |
| *** VW_ has joined #openstack-nova | 13:41 | |
| alex_xu | sdague: Then there will be a rule like "comment": "This is file for ...." | 13:41 |
| alex_xu | sdague: yea... | 13:41 |
| sdague | perhaps the important thing is a README.rst in that directory | 13:42 |
| alex_xu | sdague: or make oslo.policy can filter out some line begin with like '#...' | 13:42 |
| sdague | alex_xu: yeh, that would be nice as well | 13:42 |
| *** yingjun has joined #openstack-nova | 13:42 | |
| *** mpaolino has quit IRC | 13:43 | |
| alex_xu | sdague: README.rst can be done now, oslo.policy will be next release. so....which choice~ | 13:43 |
| sdague | let's do the README.rst | 13:43 |
| *** mriedem has joined #openstack-nova | 13:43 | |
| *** krykowski has quit IRC | 13:43 | |
| *** mpaolino has joined #openstack-nova | 13:43 | |
| alex_xu | sdague: ok, no problem, update soon | 13:43 |
| *** ankit_ag has quit IRC | 13:45 | |
| *** burt has joined #openstack-nova | 13:46 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in pci_device, quotas https://review.openstack.org/164250 | 13:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in security_group* https://review.openstack.org/164251 | 13:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in service, tag, vif https://review.openstack.org/164252 | 13:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Actually stop passing context to remotable methods https://review.openstack.org/164253 | 13:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove context from remotable call signature https://review.openstack.org/164268 | 13:47 |
| *** ishant has quit IRC | 13:48 | |
| *** dulek has joined #openstack-nova | 13:49 | |
| *** sandywalsh has joined #openstack-nova | 13:50 | |
| *** VW_ has quit IRC | 13:50 | |
| *** fifieldt has quit IRC | 13:51 | |
| *** TobiasE has joined #openstack-nova | 13:51 | |
| *** yingjun has quit IRC | 13:52 | |
| mriedem | dansmith: more rebase issues? | 13:52 |
| *** zzzeek has quit IRC | 13:52 | |
| dansmith | yep | 13:52 |
| mriedem | nvm you already got them | 13:52 |
| dansmith | yep | 13:52 |
| dansmith | edleafe: everything merged but one, yes? | 13:52 |
| edleafe | dansmith: yes - thanks for your work on these | 13:53 |
| edleafe | dansmith: the last needed a missing call, which I pushed a little while ago | 13:53 |
| dansmith | yeah, will look in a sec | 13:53 |
| *** eharney_ has joined #openstack-nova | 13:54 | |
| *** VW_ has joined #openstack-nova | 13:55 | |
| *** iamjarvo has joined #openstack-nova | 13:55 | |
| mdbooth | Is this some lambda optimisation I'm unaware of: | 13:56 |
| mdbooth | def setter(self, value, name=name, field=field): | 13:56 |
| *** eharney has quit IRC | 13:56 | |
| *** thomasem has joined #openstack-nova | 13:56 | |
| *** yingjun has joined #openstack-nova | 13:56 | |
| mdbooth | afaik the name and field kwargs can never be used, because the setting forms part of a property | 13:56 |
| dansmith | mdbooth: it's to pass name and field by value | 13:57 |
| mdbooth | Wondering if moving these values into the function signature somehow detaches is from the calling context? | 13:57 |
| dansmith | mdbooth: else they'll be linked in scope and wrong at the time of actual use | 13:57 |
| *** zz_jgrimm is now known as jgrimm | 13:57 | |
| *** eharney_ is now known as eharney | 13:58 | |
| *** jecarey has quit IRC | 13:59 | |
| *** mpaolino has quit IRC | 13:59 | |
| *** mpaolino has joined #openstack-nova | 13:59 | |
| *** dulek has quit IRC | 13:59 | |
| larsks | In nova.version, in _load_config(), are the calls to cfg.has_option() basically no-ops, since we call cfg.get() *before* that check? E.g., https://github.com/openstack/nova/blob/master/nova/version.py#L52 | 13:59 |
| *** dulek has joined #openstack-nova | 14:00 | |
| mdbooth | dansmith: That's nasty! Thanks. | 14:00 |
| dansmith | mdbooth: when you forget that it happens, it gets *real* confusing | 14:00 |
| *** TobiasE has quit IRC | 14:00 | |
| *** nelsnelson has joined #openstack-nova | 14:01 | |
| mdbooth | I'll bet. Intuitively name and field should be different variables ever time. | 14:01 |
| dansmith | yeah | 14:01 |
| dansmith | larsks: maybe? does .get() return None if there's nothing set? If so, this is defaulting behavior | 14:01 |
| *** thomasem has quit IRC | 14:01 | |
| dansmith | mdbooth: http://stackoverflow.com/questions/12423614/local-variables-in-python-nested-functions | 14:01 |
| larsks | dansmith: It just looks crazy to me right now, since we're simply calling cfg.get() twice with the same args. | 14:01 |
| dansmith | larsks: oh, indeed, maybe a bad merge or something? | 14:02 |
| dansmith | larsks: perhaps the remnants of defaulting behavior and a bad merge | 14:02 |
| larsks | dansmith: Sounds likely. | 14:02 |
| *** mpaolino has quit IRC | 14:03 | |
| *** alexpilotti has joined #openstack-nova | 14:03 | |
| *** mpaolino has joined #openstack-nova | 14:04 | |
| *** whenry has quit IRC | 14:04 | |
| *** thomasem has joined #openstack-nova | 14:04 | |
| openstackgerrit | Lars Kellogg-Stedman proposed openstack/nova: remove duplicate calls to cfg.get() https://review.openstack.org/165425 | 14:04 |
| dansmith | larsks: we can now end up with those globals unset, right? | 14:05 |
| dansmith | is that the correct behavior? | 14:05 |
| *** adelinatuvenie has quit IRC | 14:05 | |
| larsks | dansmith: no, they have defaults at the top of version.py | 14:05 |
| larsks | https://github.com/openstack/nova/blob/master/nova/version.py#L19 | 14:06 |
| dansmith | ah, right, okay cool | 14:06 |
| *** changbl has joined #openstack-nova | 14:06 | |
| dansmith | larsks: hmm, forensics show that those lines were added by danpb in whole | 14:07 |
| dansmith | in 2012, mind you | 14:07 |
| *** TobiasE has joined #openstack-nova | 14:08 | |
| larsks | dansmith: I'll ask... | 14:08 |
| dansmith | yeah | 14:08 |
| dansmith | otherwise this seems fine to me | 14:08 |
| *** kaufer1 has joined #openstack-nova | 14:08 | |
| *** otter768 has joined #openstack-nova | 14:08 | |
| *** thangp has joined #openstack-nova | 14:09 | |
| *** thomasem has quit IRC | 14:09 | |
| *** sbauza_test has joined #openstack-nova | 14:09 | |
| *** kaufer has quit IRC | 14:09 | |
| *** thomasem has joined #openstack-nova | 14:09 | |
| *** annashen has joined #openstack-nova | 14:10 | |
| *** TobiasE has quit IRC | 14:12 | |
| *** otter768 has quit IRC | 14:13 | |
| *** kaufer1 has quit IRC | 14:13 | |
| *** mtanino has joined #openstack-nova | 14:13 | |
| *** VW_ has quit IRC | 14:13 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add CellMapping object https://review.openstack.org/161867 | 14:13 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Test fixture for the api database https://review.openstack.org/164794 | 14:14 |
| mriedem | alex_xu: in https://review.openstack.org/#/c/160088/ aren't you missing v2 instance_usage_audit_log? | 14:14 |
| *** alexpilotti has quit IRC | 14:14 | |
| *** annashen has quit IRC | 14:14 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add InstanceMapping object https://review.openstack.org/161904 | 14:14 |
| alex_xu | mriedem: wait a sec, let me check | 14:15 |
| *** nellysmitt has joined #openstack-nova | 14:15 | |
| *** alexpilotti has joined #openstack-nova | 14:15 | |
| *** kaufer has joined #openstack-nova | 14:15 | |
| alex_xu | mriedem: that's done by this patch https://review.openstack.org/#/c/150354/ | 14:15 |
| openstackgerrit | Zhenguo Niu proposed openstack/nova: Fix some typos https://review.openstack.org/165426 | 14:17 |
| *** TobiasE has joined #openstack-nova | 14:17 | |
| mriedem | alex_xu: hmm yeah http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/contrib/instance_usage_audit_log.py#n80 | 14:17 |
| mriedem | weird, i did a clean clone from master before pulling your change down and don't have that locally | 14:17 |
| alex_xu | mriedem: that just merged, https://review.openstack.org/#/c/160088/ didn't rebase yet | 14:18 |
| mriedem | oooo | 14:18 |
| alex_xu | mriedem: :) thanks for the review | 14:18 |
| *** mpaolino has quit IRC | 14:18 | |
| *** iamjarvo has quit IRC | 14:18 | |
| mriedem | i'll cherry pick instead of git review -d then | 14:18 |
| *** iamjarvo has joined #openstack-nova | 14:19 | |
| *** mpaolino has joined #openstack-nova | 14:19 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Expand help message on some quota config options https://review.openstack.org/165170 | 14:21 |
| *** mpaolino has quit IRC | 14:21 | |
| *** mpaolino has joined #openstack-nova | 14:22 | |
| mriedem | alex_xu: policy.json still has this: "compute_extension:instance_usage_audit_log": "rule:admin_api", | 14:26 |
| mdbooth | dansmith: I had a query earlier about https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1869 | 14:27 |
| mriedem | alex_xu: nvm, we aren't updating policy.json | 14:27 |
| mdbooth | The else branch looks a bit odd there. I suspect I'm just missing some context. | 14:27 |
| *** mestery has quit IRC | 14:27 | |
| *** kaufer has quit IRC | 14:27 | |
| mriedem | alex_xu: but i do see "compute_extension:instance_usage_audit_log": "rule:admin_api", in fake_policy still, | 14:28 |
| alex_xu | mriedem: you mean this patch https://review.openstack.org/#/c/150267/11? | 14:28 |
| *** kaufer has joined #openstack-nova | 14:28 | |
| openstackgerrit | yuntongjin proposed openstack/nova: Remove db layer hard-code permission checks for floating_ips_bulk https://review.openstack.org/150704 | 14:28 |
| mriedem | alex_xu: no, i'm looking at https://review.openstack.org/#/c/150354/ | 14:28 |
| dansmith | mdbooth: the branch looks weird, or the code inside the two sides? | 14:28 |
| *** dave-mccowan has joined #openstack-nova | 14:29 | |
| mriedem | alex_xu: in this one you change fake_policy for the instance_usage_audit_log v3 extension to not require admin https://review.openstack.org/#/c/150354/9/nova/tests/unit/fake_policy.py | 14:29 |
| mdbooth | dansmith: Just the else branch. Why would it set the state to active if there's no host without telling a driver to do anything about it? | 14:29 |
| mdbooth | Obviously it can't talk to a driver if there's no host | 14:29 |
| mriedem | alex_xu: in this other change for hosts/services, you change the v2 api in fake_policy but not the v3 api https://review.openstack.org/#/c/160088/8/nova/tests/unit/fake_policy.py | 14:29 |
| alex_xu | mriedem: yes, I want all the api unittest is unwind | 14:29 |
| mdbooth | But why the ACTIVE state? | 14:29 |
| *** sbauza_test has quit IRC | 14:30 | |
| *** mpaolino has quit IRC | 14:30 | |
| *** mpaolino has joined #openstack-nova | 14:30 | |
| alex_xu | mriedem: I just want to keep the v2 api unittest same as before | 14:31 |
| alex_xu | mriedem: the goal of unitest, I want to keep v2.1 api unittest is unwind, keep same as before for v2 api unittest | 14:31 |
| *** exploreshaifali has quit IRC | 14:31 | |
| dansmith | mdbooth: well, it doesn't immediately try to talk to the compute node in that case | 14:32 |
| dims_ | sdague: server side n-cpu logs are littered with "REQ: curl -g -i -X" at DEBUG level, should they be logged? example - http://logs.openstack.org/74/163974/7/check/check-tempest-dsvm-full/b3b48d2/logs/screen-n-cpu.txt.gz#_2015-03-17_17_10_24_571 | 14:32 |
| dansmith | mdbooth: I'm not sure what the semantics of the call is, but I expect that it's expecting you to run a rebuild on the instance after you restore it, and rebuild probably wants a subset of vm_states | 14:32 |
| mdbooth | dansmith: Ok, thanks. | 14:33 |
| mriedem | alex_xu: i guess i'm just confused about the inconsistency between those two changes and what's changed in fake_policy | 14:33 |
| alex_xu | mriedem: yea, https://review.openstack.org/#/c/160088/8 this looks strange, let me check | 14:33 |
| alex_xu | mriedem: yea, I think https://review.openstack.org/#/c/160088/8 is wrong, let me update it | 14:34 |
| mriedem | alex_xu: also in that one: http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/contrib/availability_zone.py#n67 | 14:35 |
| mriedem | availability_zone:detail requires admin in v2 | 14:35 |
| mriedem | but there isn't an admin context check in the v2 API for service_get_all | 14:35 |
| mriedem | which is what ServiceList.get_all calls | 14:35 |
| alex_xu | mriedem: http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/contrib/availability_zone.py#n62 | 14:36 |
| alex_xu | mriedem: the context is elevated | 14:36 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add the instance update calls from Compute https://review.openstack.org/160513 | 14:36 |
| mriedem | alex_xu: it's elevated to get the az's | 14:36 |
| mriedem | not the service | 14:36 |
| *** tsekiyama has joined #openstack-nova | 14:36 | |
| *** bauzas has quit IRC | 14:36 | |
| mriedem | ctxt = context.elevated() | 14:36 |
| mriedem | enabled_services = objects.ServiceList.get_all(context, disabled=False) | 14:36 |
| mriedem | different context variable | 14:37 |
| alex_xu | mriedem: oops, you are right, I missed that | 14:37 |
| mriedem | :) | 14:37 |
| alex_xu | mriedem: thanks ;) | 14:37 |
| openstackgerrit | yuntongjin proposed openstack/nova: Remove db layer hard-code permission checks for floating_ips_bulk https://review.openstack.org/150704 | 14:37 |
| *** changbl has quit IRC | 14:38 | |
| sdague | dims_: looking | 14:40 |
| sdague | I assume that's one of the foo-clients | 14:40 |
| dims_ | keystoneclient | 14:40 |
| *** renatoarmani has joined #openstack-nova | 14:40 | |
| sdague | no, it's cinderclient I think | 14:40 |
| *** adelinatuvenie has joined #openstack-nova | 14:41 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Adjust resource tracker for new Ironic states https://review.openstack.org/164313 | 14:41 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Adjust resource tracker for new Ironic states https://review.openstack.org/164313 | 14:42 |
| dims_ | sdague: i see, i went by the "DEBUG keystoneclient.session" in the line | 14:42 |
| sdague | right, but that's because we always initialize logger(__name__) | 14:42 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Add support for cleaning in Ironic driver https://review.openstack.org/161474 | 14:42 |
| *** hemnafk is now known as hemna | 14:42 | |
| openstackgerrit | Dorin Paslaru proposed openstack/nova: Hyper-V: Sets *DataRoot paths for instances https://review.openstack.org/162999 | 14:43 |
| *** VW_ has joined #openstack-nova | 14:43 | |
| openstackgerrit | yuntongjin proposed openstack/nova: Remove db layer hard-code permission checks for floating_ips_bulk https://review.openstack.org/150704 | 14:44 |
| sdague | and now the bad habbits of keystone sessions are injected into all the clients | 14:44 |
| dims_ | right other clients end up doing that as well - http://paste.openstack.org/show/193130/ | 14:45 |
| sdague | yep | 14:45 |
| sdague | vaguely related, what's up with all the extra - - - in user_identity? | 14:46 |
| *** achanda has joined #openstack-nova | 14:47 | |
| *** mpaolino has quit IRC | 14:47 | |
| sahid | dansmith: i would like to rewrite a bunch of code for onsole; and firstable make it using objects. can i use your blueprint kilo-objects to do that? | 14:48 |
| *** mpaolino has joined #openstack-nova | 14:48 | |
| sahid | /onsole/console | 14:48 |
| sahid | then we use memcache to store token wich is something not good, memcached cannot guarantee the expire, we need to use a database | 14:48 |
| dansmith | sahid: that'd be a lemming thing, right | 14:49 |
| dansmith | ? | 14:49 |
| sahid | dansmith: ah yes | 14:49 |
| dansmith | sahid: so a lemming spec for that would be good I think | 14:49 |
| sahid | ok so it's better i provide an spec to explain that? | 14:49 |
| dansmith | I think so | 14:50 |
| sahid | yes you probably right, thank you. | 14:50 |
| *** mpaolino has quit IRC | 14:50 | |
| *** browne has joined #openstack-nova | 14:50 | |
| *** shaohe_feng1 has joined #openstack-nova | 14:50 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Adjust resource tracker for new Ironic states https://review.openstack.org/164313 | 14:51 |
| *** mpaolino has joined #openstack-nova | 14:51 | |
| *** achanda has quit IRC | 14:52 | |
| *** mpaolino has quit IRC | 14:52 | |
| *** mpaolino has joined #openstack-nova | 14:53 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Rename and move the v2.1 api policy into separated files https://review.openstack.org/150267 | 14:53 |
| shaohe_feng1 | hi cores, there are still some policy patches are ready. https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/v3-api-policy,n,z | 14:53 |
| *** adrian_otto has joined #openstack-nova | 14:55 | |
| *** Bsony has joined #openstack-nova | 14:55 | |
| *** Longgeek has quit IRC | 14:56 | |
| *** Bsony_ has quit IRC | 14:57 | |
| *** bauzas has joined #openstack-nova | 14:58 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Add support for cleaning in Ironic driver https://review.openstack.org/161474 | 14:58 |
| *** changbl has joined #openstack-nova | 15:01 | |
| mriedem | anyone else seeing this unit test race? http://logs.openstack.org/30/164330/1/check/gate-nova-python27/5b01a0a/console.html#_2015-03-17_17_54_45_705 | 15:03 |
| *** shaohe_feng1 has quit IRC | 15:04 | |
| mriedem | ah nvm | 15:04 |
| openstackgerrit | Sean Dague proposed openstack/nova: load ram_allocation_ratio when asked https://review.openstack.org/165397 | 15:04 |
| *** amotoki has quit IRC | 15:06 | |
| *** vmtrooper has joined #openstack-nova | 15:06 | |
| *** garyk has quit IRC | 15:07 | |
| *** Marga_ has joined #openstack-nova | 15:07 | |
| *** salv-orlando has joined #openstack-nova | 15:09 | |
| openstackgerrit | Eric Brown proposed openstack/nova: Use oslo_config choices support https://review.openstack.org/158573 | 15:09 |
| *** bfic has quit IRC | 15:09 | |
| openstackgerrit | Eric Brown proposed openstack/nova: Use oslo_config choices support https://review.openstack.org/158573 | 15:10 |
| *** jecarey has joined #openstack-nova | 15:10 | |
| *** claudiub has joined #openstack-nova | 15:11 | |
| *** vmtrooper has quit IRC | 15:11 | |
| *** pkoniszewski has quit IRC | 15:12 | |
| *** jaypipes has quit IRC | 15:12 | |
| *** tjones1 has joined #openstack-nova | 15:14 | |
| *** tjones1 has left #openstack-nova | 15:14 | |
| *** welldannit has joined #openstack-nova | 15:14 | |
| *** shaohe_feng1 has joined #openstack-nova | 15:16 | |
| *** amotoki has joined #openstack-nova | 15:16 | |
| *** whenry has joined #openstack-nova | 15:17 | |
| *** salv-orlando has quit IRC | 15:17 | |
| sdague | johnthetubaguy: hey, so I'm effectively reverting - https://review.openstack.org/#/c/85037/ (which was your patch) in https://review.openstack.org/165397. The eval time binding is tripping up other things here and it breaks restart applying changes for this value. | 15:17 |
| *** dave-mccowan has quit IRC | 15:17 | |
| *** kashyapc has quit IRC | 15:18 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for service_get_by_host* https://review.openstack.org/150349 | 15:18 |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for service_get_all https://review.openstack.org/160088 | 15:18 |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for service_get_by_compute_host https://review.openstack.org/160089 | 15:18 |
| johnthetubaguy | sdague: hmm, OK, it does have quite a performance impact though | 15:18 |
| johnthetubaguy | sdague: I can't remember how much | 15:19 |
| mriedem | 5 sec to 4 sec with 200 hosts | 15:19 |
| mriedem | is what the commit msg said | 15:19 |
| *** pcaruana has joined #openstack-nova | 15:19 | |
| sdague | yeh | 15:19 |
| johnthetubaguy | well ms not s, but yes | 15:19 |
| sdague | I don't understand why though, the call path through oslo cfg should be fast | 15:19 |
| mriedem | oh right | 15:19 |
| johnthetubaguy | sounds kinda trivial mind | 15:20 |
| alex_xu | mriedem: ^^ I fixed available_zone one, but for the test_hosts, I remember why I change like that now I replied at https://review.openstack.org/#/c/160088/8/nova/tests/unit/fake_policy.py | 15:20 |
| sdague | it does really make this weird because it breaks config reload for this variable | 15:20 |
| *** dave-mccowan has joined #openstack-nova | 15:20 | |
| johnthetubaguy | sdague: honestly, I don't know why either, its something the profiler highlighted as slow, I changed it and things got a little bit faster | 15:20 |
| johnthetubaguy | sdague: agreed it makes reload odd, you would need a callback to do the reload | 15:20 |
| dansmith | sdague: are you good with this now? https://review.openstack.org/#/c/164794/6 | 15:21 |
| sdague | dansmith: yes +A | 15:22 |
| dansmith | sdague: cool | 15:22 |
| raorn | greetings, everyone... | 15:22 |
| openstackgerrit | Sean Dague proposed openstack/nova: load ram_allocation_ratio when asked https://review.openstack.org/165397 | 15:23 |
| sdague | johnthetubaguy: just updating the commit message to reference the other patch | 15:23 |
| sdague | it was weird enough code that I went diving to figure out when it was added | 15:23 |
| johnthetubaguy | sdague: ah, good call, thanks | 15:23 |
| dansmith | mriedem: okay, this time through the gate is my turn to win | 15:23 |
| raorn | I need your advice... tried to fix a bug, made a small hack, but it doesn't work. then I had to make even bigger hack, it works, but I'm not sure if it's right... | 15:24 |
| raorn | https://review.openstack.org/#/c/163393/ | 15:24 |
| raorn | last comment... | 15:24 |
| sdague | johnthetubaguy: I also wonder if this is really a more structural problem with the way the filters are iterated over. | 15:24 |
| johnthetubaguy | sdague: yeah, I meant to go back and look at some of that, just never got chance, the reason for me to care so much largely went away | 15:26 |
| sdague | johnthetubaguy: ok | 15:26 |
| johnthetubaguy | sdague: interestingly, based on the ops summit discussion, the log messages were the biggest performance hit, although that might have been the call to the translation code that did it | 15:26 |
| sdague | johnthetubaguy: reference? | 15:27 |
| sdague | I guess I missed that one | 15:27 |
| *** whenry has quit IRC | 15:28 | |
| johnthetubaguy | sdague: there was a commit ages ago I did around that, but I was more just planning to review the fix when it comes up for review at this point, we need the logging, just too much is costly | 15:28 |
| johnthetubaguy | sdague: I actually opted for only logging on error cases, which sounded inline with their request anyways | 15:28 |
| *** renatoarmani has quit IRC | 15:29 | |
| mriedem | so when the scheduler fails, we don't have enough logging, but with logging the scheduler is too slow | 15:30 |
| mriedem | damned if you do, damned if you don't | 15:30 |
| *** dsanders has joined #openstack-nova | 15:30 | |
| *** browne has quit IRC | 15:30 | |
| mriedem | could scrub scheduler logging for things like LOG.debug('foo %s' % 'bar') | 15:30 |
| sdague | well, I think the issue is the filter model just keeps reducing a list until it's empty | 15:30 |
| *** sandywalsh has quit IRC | 15:31 | |
| *** nellysmitt has quit IRC | 15:32 | |
| sdague | so honestly, I think the interface you want is really on success "I picked FOO" and on failure "I couldn't schedule because not enough BAR (list of hosts that made it to this filter with their free BAR)" | 15:33 |
| *** penick has quit IRC | 15:33 | |
| dansmith | so, for debugging, | 15:33 |
| dansmith | I think what I want is: a list of filters that were applied in order, and the number of hosts after each step | 15:34 |
| sdague | right now you get: 2015-03-18 11:33:58.035 24481 INFO nova.filters [req-71a1018c-c9c4-4bc6-912a-52b375439e33 admin openstack - - -] Filter RamFilter returned 0 hosts | 15:34 |
| sdague | 2015-03-18 11:33:58.036 24481 WARNING nova.scheduler.utils [req-71a1018c-c9c4-4bc6-912a-52b375439e33 admin openstack - - -] Failed to compute_task_build_instances: No valid host was found. There are not enough hosts available. | 15:34 |
| bauzas | dansmith: that's already done in debug mode | 15:34 |
| sdague | right, so the complaint is they have to run debug mode to handle tickets | 15:34 |
| dansmith | bauzas: but that should be something discoverable though | 15:34 |
| dansmith | right | 15:34 |
| sdague | because when nova boot fails, people just file tickets | 15:35 |
| dansmith | we should record that, and if we fail to schedule, then we should store that in fault or something | 15:35 |
| sdague | right | 15:35 |
| bauzas | dansmith: we can level up this info | 15:35 |
| dansmith | I dunno that being in the log is really the right place for normal legitimate failures | 15:35 |
| bauzas | dansmith: the other problem was that operators were taking time for getting which instance was not good | 15:35 |
| dansmith | I feel like it needs to be a first class citizen | 15:36 |
| sdague | dansmith: ok, where would you record that? | 15:36 |
| dansmith | sdague: if it wasn't sensitive, I would put it in fault | 15:36 |
| dansmith | maybe we add to fault and only expose it if suitably endowed? | 15:36 |
| bauzas | dansmith: my proposal was that operators could ask for the instance_uuid and then look at the logs | 15:37 |
| *** armax has joined #openstack-nova | 15:37 | |
| dansmith | bauzas: right, but in small clouds full of power users, exposing it to the user is the right thing | 15:37 |
| dansmith | bauzas: because they can see that if they just don't ask for $foo they can succeed and don't need to open a ticket | 15:37 |
| sdague | dansmith: so long term, sure. But it would be good to make this better in kilo. | 15:38 |
| *** amotoki has quit IRC | 15:38 | |
| dansmith | sdague: long term, I'd like to be a millionaire, but .. :P | 15:38 |
| bauzas | dansmith: well, the problem is that it's sensitive data, as you mentioned | 15:38 |
| dansmith | so, | 15:38 |
| sdague | and upleveling the right info in the logs seem doable, whereas sorting out the self service for info like this seems like it's going to be a spec | 15:38 |
| dansmith | there isn't just one fault for instance, | 15:39 |
| dansmith | oh, I'm fine upleveling for kilo if that solves the problem, not arguing about that | 15:39 |
| dansmith | I'm just saying it doesn't address the core issue, IMHO | 15:39 |
| sdague | dansmith: agreed | 15:39 |
| dansmith | but to finish: | 15:39 |
| dansmith | there isn't just one fault, so we could create a fault with the sensitive details in it, before we create the main fault of NoValidHost | 15:40 |
| johnthetubaguy | dansmith: I saw instance actions/tasks getting admin vs user views in the API, with a simply policy that might let everyone see both if you want it | 15:40 |
| dansmith | but, that might leave a window where it was discoverable, so maybe that's a bad idea | 15:40 |
| johnthetubaguy | dansmith: +1 to an instance fault btw | 15:40 |
| dansmith | in lemming, we could just add a field to fault for this data and expose on policy | 15:40 |
| dansmith | would be pretty easy | 15:40 |
| *** unicell has quit IRC | 15:40 | |
| johnthetubaguy | right | 15:40 |
| *** rajesht has quit IRC | 15:41 | |
| *** ajayaa has quit IRC | 15:41 | |
| *** packet has joined #openstack-nova | 15:41 | |
| bauzas | dansmith: agreed | 15:42 |
| dansmith | I can write a spec for that if it seems reasonable to everyone | 15:42 |
| bauzas | dansmith: I +1 on sdague comment about only modifying logs for Kilo and opening up a spec for what's returned on API | 15:42 |
| *** unicell has joined #openstack-nova | 15:42 | |
| dansmith | sure, I wasn't even talking about kilo above | 15:42 |
| dansmith | kilo is dead to me :) | 15:43 |
| sdague | dansmith: heh, well I'd like to fix something here for kilo because it was a specific ask from a ton of deployers | 15:43 |
| * dansmith makes a farting noise | 15:43 | |
| dansmith | who are these "operators" anyway? | 15:43 |
| *** changbl has quit IRC | 15:44 | |
| dansmith | (for the logs: that was sarcasm) | 15:44 |
| sdague | heh | 15:44 |
| *** dulek has quit IRC | 15:44 | |
| *** rmoe has quit IRC | 15:44 | |
| bauzas | lol | 15:44 |
| sdague | and I really do like openning this up for more self service in the future, because I actually think the majority of deploys would use that | 15:45 |
| *** changbl has joined #openstack-nova | 15:45 | |
| dansmith | yes | 15:45 |
| *** mpaolino has quit IRC | 15:45 | |
| sdague | so +1 on you writing a spec :) | 15:45 |
| dansmith | alright | 15:46 |
| *** mpaolino has joined #openstack-nova | 15:46 | |
| sdague | mriedem: hey, you want to vote on the patch under that psuedo revert as well - https://review.openstack.org/#/c/165376/ | 15:46 |
| *** dulek has joined #openstack-nova | 15:47 | |
| *** matrohon has quit IRC | 15:47 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add CellMapping object https://review.openstack.org/161867 | 15:49 |
| *** sdake_ has quit IRC | 15:51 | |
| mriedem | sdague: yeah, after a quick meeting | 15:52 |
| *** mestery has joined #openstack-nova | 15:52 | |
| *** sdake has joined #openstack-nova | 15:52 | |
| *** Sukhdev has joined #openstack-nova | 15:53 | |
| *** unicell has quit IRC | 15:53 | |
| *** garyk has joined #openstack-nova | 15:53 | |
| *** unicell has joined #openstack-nova | 15:54 | |
| openstackgerrit | Tobias Engelbert proposed openstack/nova: Allow multiple volume attachments https://review.openstack.org/153033 | 15:55 |
| *** kashyapc_ has joined #openstack-nova | 15:56 | |
| *** salv-orl_ has joined #openstack-nova | 15:58 | |
| *** thedodd has joined #openstack-nova | 15:59 | |
| *** dulek has quit IRC | 16:00 | |
| mriedem | aha! | 16:00 |
| *** ijw has joined #openstack-nova | 16:00 | |
| mriedem | naughty mocks blew up my tests | 16:00 |
| *** renatoarmani has joined #openstack-nova | 16:01 | |
| *** yamahata has joined #openstack-nova | 16:01 | |
| *** ijw has quit IRC | 16:02 | |
| *** unicell has quit IRC | 16:02 | |
| *** ijw has joined #openstack-nova | 16:02 | |
| *** rmoe has joined #openstack-nova | 16:02 | |
| *** yingjun has quit IRC | 16:03 | |
| *** apuimedo has quit IRC | 16:04 | |
| *** ijw has quit IRC | 16:04 | |
| *** mpavone has quit IRC | 16:05 | |
| *** ijw has joined #openstack-nova | 16:05 | |
| *** changbl has quit IRC | 16:06 | |
| *** exploreshaifali has joined #openstack-nova | 16:06 | |
| *** belmoreira has quit IRC | 16:07 | |
| openstackgerrit | garyk proposed openstack/nova: Tox: reduce complexity level to 35 https://review.openstack.org/165335 | 16:07 |
| *** jgrimm_ has joined #openstack-nova | 16:07 | |
| *** adalbas has quit IRC | 16:07 | |
| *** maurosr- has joined #openstack-nova | 16:08 | |
| *** timello_ has joined #openstack-nova | 16:08 | |
| *** mjturek2 has joined #openstack-nova | 16:08 | |
| *** maurosr has quit IRC | 16:09 | |
| *** timello has quit IRC | 16:09 | |
| *** maurosr| has joined #openstack-nova | 16:09 | |
| *** jgrimm- has joined #openstack-nova | 16:09 | |
| *** otter768 has joined #openstack-nova | 16:09 | |
| *** maurosr| is now known as maurosr | 16:09 | |
| *** timello has joined #openstack-nova | 16:10 | |
| *** mjturek3 has joined #openstack-nova | 16:10 | |
| *** jgrimm has quit IRC | 16:10 | |
| *** mjturek1 has quit IRC | 16:11 | |
| *** annashen has joined #openstack-nova | 16:11 | |
| *** timello_ has quit IRC | 16:12 | |
| *** browne has joined #openstack-nova | 16:12 | |
| *** mjturek2 has quit IRC | 16:12 | |
| *** maurosr- has quit IRC | 16:12 | |
| *** Bsony has quit IRC | 16:13 | |
| *** jgrimm_ has quit IRC | 16:13 | |
| *** iamjarvo has quit IRC | 16:13 | |
| *** Maike has quit IRC | 16:13 | |
| mriedem | edleafe: PaulMurray: isn't there some resources object now that could be used here instead of this Resources class? https://review.openstack.org/#/c/165376/1/nova/virt/fake.py | 16:14 |
| *** otter768 has quit IRC | 16:14 | |
| alex_xu | emm....looks like nothing I can do now. expect something magic happend tomorrow morning~ | 16:15 |
| *** Nic has joined #openstack-nova | 16:16 | |
| *** annashen has quit IRC | 16:16 | |
| edleafe | mriedem: jaypipes-afk had a proposed class in https://review.openstack.org/#/c/128992 | 16:18 |
| *** timello has quit IRC | 16:20 | |
| *** mpavone has joined #openstack-nova | 16:20 | |
| *** timello has joined #openstack-nova | 16:22 | |
| *** adalbas has joined #openstack-nova | 16:23 | |
| openstackgerrit | Julien Danjou proposed openstack/nova: simple_tenant_usage: declare method static https://review.openstack.org/165017 | 16:25 |
| openstackgerrit | Julien Danjou proposed openstack/nova: Leverage timeutils, drop strtime() https://review.openstack.org/164753 | 16:25 |
| *** TobiasE has quit IRC | 16:26 | |
| openstackgerrit | Eric Brown proposed openstack/nova: Use oslo_config choices support https://review.openstack.org/158573 | 16:27 |
| *** gszasz has quit IRC | 16:27 | |
| *** marun has joined #openstack-nova | 16:31 | |
| *** ajayaa has joined #openstack-nova | 16:32 | |
| *** zzzeek has joined #openstack-nova | 16:38 | |
| *** irenab has quit IRC | 16:41 | |
| *** unicell1 has joined #openstack-nova | 16:41 | |
| *** jcru has joined #openstack-nova | 16:41 | |
| *** Bsony has joined #openstack-nova | 16:42 | |
| *** mpaolino has quit IRC | 16:42 | |
| *** Marga_ has quit IRC | 16:42 | |
| *** Marga_ has joined #openstack-nova | 16:43 | |
| *** oro_ has quit IRC | 16:44 | |
| *** thomasem has quit IRC | 16:46 | |
| *** penick has joined #openstack-nova | 16:48 | |
| *** neelashah has quit IRC | 16:49 | |
| *** unicell has joined #openstack-nova | 16:50 | |
| *** penick has quit IRC | 16:51 | |
| *** Sukhdev has quit IRC | 16:52 | |
| *** unicell1 has quit IRC | 16:52 | |
| *** VW_ has quit IRC | 16:52 | |
| *** tjones1 has joined #openstack-nova | 16:55 | |
| *** sahid has quit IRC | 16:55 | |
| *** vmtrooper has joined #openstack-nova | 16:55 | |
| *** melwitt has joined #openstack-nova | 16:56 | |
| *** adrian_otto has left #openstack-nova | 16:57 | |
| *** openstackgerrit has quit IRC | 16:59 | |
| *** openstackgerrit has joined #openstack-nova | 16:59 | |
| *** vmtrooper has quit IRC | 17:00 | |
| *** neelashah has joined #openstack-nova | 17:00 | |
| *** alexpilotti has quit IRC | 17:02 | |
| *** alexpilotti_ has joined #openstack-nova | 17:02 | |
| *** Nikolay_St has joined #openstack-nova | 17:02 | |
| *** penick has joined #openstack-nova | 17:02 | |
| *** iamjarvo has joined #openstack-nova | 17:04 | |
| *** achanda has joined #openstack-nova | 17:04 | |
| *** iamjarvo has quit IRC | 17:05 | |
| *** jlanoux has quit IRC | 17:05 | |
| *** iamjarvo has joined #openstack-nova | 17:05 | |
| *** emagana has joined #openstack-nova | 17:06 | |
| nihilifer | can any core reviewer look at this one? https://review.openstack.org/#/c/163780/ I know that this bug has low priority, but I'd like to know whether unit tests look good for you | 17:07 |
| *** jistr has quit IRC | 17:08 | |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Remove pci_device.update_device helper function https://review.openstack.org/165512 | 17:08 |
| ndipanov | nihilifer, well I'd rather see mock instead of mox used | 17:08 |
| ndipanov | but not a huge deal imho | 17:09 |
| ndipanov | but I am assuming you had some more detailed questions about them | 17:09 |
| ndipanov | btw dansmith ^^ the patch I just posted | 17:09 |
| ndipanov | any chance we could land that | 17:09 |
| ndipanov | ? | 17:09 |
| ndipanov | even tho past FF | 17:09 |
| *** annashen has joined #openstack-nova | 17:11 | |
| dansmith | initial reaction is it's a low-risk cleanup so, probably | 17:11 |
| dansmith | in a minute I will look closer | 17:11 |
| ndipanov | cool | 17:11 |
| ndipanov | removes code | 17:11 |
| dansmith | yeah, but what's the rush to land immediately? | 17:12 |
| nihilifer | ndipanov: I don't have any detailed question | 17:12 |
| nihilifer | ndipanov: so should I change this to mock? | 17:12 |
| *** renatoar_ has joined #openstack-nova | 17:13 | |
| ndipanov | oh yeah - no rush just pinging so that it does not get unreasonably delayed due to ceromonial reasons and it's a super quick cleanup | 17:13 |
| *** Nic has quit IRC | 17:13 | |
| ndipanov | nihilifer, don't do it on my account - but people may complain about it | 17:13 |
| *** mpavone has quit IRC | 17:13 | |
| *** exploreshaifali has quit IRC | 17:15 | |
| ndipanov | omg this neutron api code hurts my eyes ... :( | 17:15 |
| *** renatoarmani has quit IRC | 17:16 | |
| ndipanov | nihilifer, I'd say don't change it | 17:17 |
| ndipanov | that code is horrible and we want to rewrite it completely I think, so no point in modernizing tests now - just go with the flow | 17:17 |
| nihilifer | ok | 17:18 |
| nihilifer | almost every test in this neutron modules uses mox, as far as I see | 17:19 |
| ndipanov | yeah | 17:19 |
| *** salv-orl_ has quit IRC | 17:19 | |
| dansmith | ndipanov: I can fix your typo in gerrit, and also recommend we drop the blueprint linkage so it doesn't look like a "feature" :) | 17:19 |
| ndipanov | dansmith, typo | 17:20 |
| ndipanov | oh man I used :set spell | 17:20 |
| ndipanov | I deeply suck at typing :( | 17:20 |
| dansmith | it's in a method name | 17:20 |
| dansmith | so probably ignored | 17:20 |
| ndipanov | :( | 17:20 |
| ndipanov | wonder if I could get rope to feed into my vim dictionary ... | 17:21 |
| dansmith | yjiang5 did pull a couple things out of the object recently, so want to make sure this is moving the direction he expects | 17:21 |
| dansmith | but otherwise, seems "meh" to me | 17:21 |
| *** penick has quit IRC | 17:22 | |
| ndipanov | dansmith, so was doing some out of tree patching of PCIDevices and this bit me | 17:22 |
| dansmith | *gasp* | 17:22 |
| ndipanov | o it is not unlikely to happen in master | 17:22 |
| ndipanov | since tests didn't catch it | 17:22 |
| *** Nikolay_St has quit IRC | 17:22 | |
| ndipanov | but yeah agreed - meh | 17:23 |
| *** salv-orlando has joined #openstack-nova | 17:25 | |
| *** harlowja_away is now known as harlowja_ | 17:27 | |
| *** tjones1 has left #openstack-nova | 17:27 | |
| *** Marga_ has quit IRC | 17:28 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add the instance update calls from Compute https://review.openstack.org/160513 | 17:29 |
| edleafe | garyk: johnthetubaguy: dansmith: jaypipes-afk: ^^ | 17:30 |
| *** Nic has joined #openstack-nova | 17:30 | |
| *** bkopilov has joined #openstack-nova | 17:30 | |
| *** Nikolay_St has joined #openstack-nova | 17:30 | |
| *** markus_z has quit IRC | 17:30 | |
| johnthetubaguy | edleafe: that blueprint https://blueprints.launchpad.net/nova/+spec/isolate-scheduler-db was marked as implemented already, is that not the final patch? | 17:31 |
| johnthetubaguy | I mean, is that now the final patch? | 17:31 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Remove pci_device.update_device helper function https://review.openstack.org/165512 | 17:31 |
| edleafe | johnthetubaguy: yes, this is the final patch | 17:31 |
| *** sdake_ has joined #openstack-nova | 17:31 | |
| edleafe | johnthetubaguy: perhaps bauzas jumped the gun a bit :) | 17:31 |
| garyk | edleafe: thanks | 17:32 |
| johnthetubaguy | edleafe: cool, just checking | 17:32 |
| johnthetubaguy | very close to the wire now | 17:32 |
| *** sandywalsh has joined #openstack-nova | 17:32 | |
| edleafe | johnthetubaguy: oh, I know... | 17:33 |
| *** Mike_D_laptop has joined #openstack-nova | 17:33 | |
| *** oro_ has joined #openstack-nova | 17:34 | |
| *** ybathia has joined #openstack-nova | 17:35 | |
| PaulMurray | mriedem, re Resources class - i thought the same thing initially | 17:35 |
| *** sdake has quit IRC | 17:35 | |
| PaulMurray | mriedem, sdague's change is in a (fake) virt driver. The resources classes that jaypipes is proposing would be overkill for this - fake, but could be used eventually | 17:36 |
| mriedem | PaulMurray: yeah i see that now | 17:36 |
| PaulMurray | mriedem, by the way, feel free to obstruct this - it would conflict with the first patch in my series ;) | 17:37 |
| mriedem | which patch? jay's or sean's? | 17:37 |
| PaulMurray | mine | 17:37 |
| *** rajesht has joined #openstack-nova | 17:38 | |
| PaulMurray | sdague's patch would conflict with https://review.openstack.org/#/c/148904/ | 17:38 |
| *** Nikolay_St has quit IRC | 17:38 | |
| PaulMurray | sdague, only because I changed that 100000000000000000 disk size to be something that can be stored on a compute | 17:38 |
| *** rdo has joined #openstack-nova | 17:38 | |
| *** lpetrut has quit IRC | 17:39 | |
| *** Mike_D_laptop has quit IRC | 17:39 | |
| *** Nikolay_St has joined #openstack-nova | 17:39 | |
| PaulMurray | sorry sdague that was meant for mriedem ^^^^^^ | 17:39 |
| *** tonytan4ever has joined #openstack-nova | 17:39 | |
| *** sbfox has joined #openstack-nova | 17:40 | |
| *** coolsvap is now known as coolsvap|afk | 17:41 | |
| *** xyang1 has joined #openstack-nova | 17:42 | |
| *** rajesht has quit IRC | 17:42 | |
| PaulMurray | bauzas, I have a question about you comments in https://review.openstack.org/#/c/159765/5/nova/compute/resource_tracker.py | 17:42 |
| bauzas | PaulMurray: sure, wazzup ? | 17:43 |
| PaulMurray | bauzas, I get asked to remove unused parameters in other patches - you're asking me to leave it in | 17:43 |
| bauzas | PaulMurray: oh joy of reviews | 17:43 |
| PaulMurray | bauzas, I know it was already unused in one of the methods | 17:43 |
| PaulMurray | bauzas, but most of them I removed the code that used it | 17:44 |
| bauzas | PaulMurray: just to be clear, I was not -1'ing on that | 17:44 |
| bauzas | PaulMurray: it was a nit | 17:44 |
| PaulMurray | bauzas, oh - ok | 17:44 |
| *** nellysmitt has joined #openstack-nova | 17:44 | |
| PaulMurray | bauzas, -1 for the missing TODO? | 17:44 |
| bauzas | PaulMurray: exactly | 17:44 |
| bauzas | PaulMurray: at least for the pci drop | 17:44 |
| bauzas | PaulMurray: because I don't see where it's coming from | 17:45 |
| PaulMurray | bauzas, ok - understood | 17:45 |
| bauzas | PaulMurray: sorry, was unclear but when you're seeing "nit: <foo>", that's not my reason of -1 | 17:45 |
| PaulMurray | bauzas, its just a short cut really - that parameter is the only thing in resources that doesn't exist in the database | 17:45 |
| *** Nikolay_St has quit IRC | 17:45 | |
| bauzas | PaulMurray: that sounds hacky | 17:45 |
| PaulMurray | bauzas, yeah | 17:46 |
| bauzas | PaulMurray: so yeah, that just means this field is useless then ? | 17:46 |
| bauzas | PaulMurray: because it's not persisted | 17:46 |
| PaulMurray | bauzas, no - its handled seperately later - copied out into pci tracker | 17:46 |
| PaulMurray | bauzas, that goes in a separate table | 17:47 |
| bauzas | PaulMurray: could you please point me where it's used ? | 17:47 |
| bauzas | oh I see your other popping in the dependent patch | 17:48 |
| bauzas | PaulMurray: well, I really hate those hacky things | 17:48 |
| bauzas | PaulMurray: really, why not those people wouldn't use the resources correctly ? man ! | 17:48 |
| PaulMurray | bauzas, looking.... | 17:49 |
| PaulMurray | L 438 | 17:49 |
| *** derekh has quit IRC | 17:49 | |
| PaulMurray | bauzas, ^^ | 17:49 |
| bauzas | *facepalm* | 17:50 |
| bauzas | oh gosh, a special case... | 17:51 |
| bauzas | that's even popping the resources | 17:51 |
| PaulMurray | bauzas, in next patch I implement a method that adds an "update_from_virt_driver()" method that handles all the copy properly | 17:51 |
| PaulMurray | bauzas, but that bit of code is not about compute_node - so leave that as is | 17:52 |
| bauzas | PaulMurray: well, my main concern is that you're cleaning up the resouce usage, but you still need to hack something | 17:52 |
| bauzas | that's just creating a precedent | 17:52 |
| PaulMurray | bauzas, not my code | 17:53 |
| bauzas | PaulMurray: agred | 17:53 |
| bauzas | PaulMurray: I mean, I hate it, but I know it's not your point | 17:53 |
| *** kashyapc_ has quit IRC | 17:54 | |
| PaulMurray | bauzas, I know - I did try to clean that bit up, but in the end not related to my change - I do get drawn into trying to fix the world sometimes | 17:55 |
| *** ndipanov has quit IRC | 17:55 | |
| bauzas | PaulMurray: oh, make sure I understand you... | 17:56 |
| *** lucasagomes has left #openstack-nova | 17:56 | |
| * PaulMurray would like to push a 600,000 line patch, but feels no one would review it | 17:57 | |
| PaulMurray | bauzas, would you be ok with a comment about the pop() or would you prefer I get rid of it? It does go away in two patches | 17:59 |
| PaulMurray | bauzas, I think I know your ansewr | 17:59 |
| *** thomasem has joined #openstack-nova | 18:00 | |
| bauzas | PaulMurray: how much for betting ? | 18:00 |
| *** thomasem has quit IRC | 18:00 | |
| *** exploreshaifali has joined #openstack-nova | 18:00 | |
| bauzas | PaulMurray: I need to review the patch that is saying bye bye to it | 18:01 |
| bauzas | PaulMurray: so honestly feel free to do as you wish | 18:01 |
| *** jcoufal has quit IRC | 18:02 | |
| PaulMurray | bauzas, ok - will do - thanks | 18:02 |
| dansmith | mriedem: sdague: are there gate issues? | 18:03 |
| dansmith | seems like a lot of my patches near the head of the gate are re-running tests a lot | 18:03 |
| sdague | dansmith: don't know, haven't looked today | 18:03 |
| dansmith | okay | 18:03 |
| mriedem | http://jogo.github.io/gate/ | 18:03 |
| mriedem | dansmith: are you hitting failures? | 18:03 |
| *** thomasem has joined #openstack-nova | 18:03 | |
| *** thomasem has quit IRC | 18:04 | |
| PaulMurray | bauzas, are you reviewing more in the series? - if so I will wait and do in morning | 18:04 |
| *** sdake has joined #openstack-nova | 18:04 | |
| dansmith | mriedem: nothing I've had to recheck yet, I'm just watching job status and they're getting restarted a lot it seems, like everything in front of them is failing | 18:04 |
| *** thomasem has joined #openstack-nova | 18:04 | |
| *** Nikolay_St has joined #openstack-nova | 18:04 | |
| *** romainh has quit IRC | 18:06 | |
| *** abhishekk has quit IRC | 18:06 | |
| sdague | dansmith: if you can point to a failed job, I can look. There isn't really any good postmortem tracking here | 18:07 |
| dansmith | sdague: it's not a big deal, I'll wait until they land or get kicked out | 18:07 |
| *** sdake_ has quit IRC | 18:07 | |
| dansmith | sdague: was just wondering based on the behavior | 18:07 |
| *** jyuso1 has joined #openstack-nova | 18:09 | |
| *** otter768 has joined #openstack-nova | 18:10 | |
| *** Sukhdev has joined #openstack-nova | 18:11 | |
| *** ajayaa has quit IRC | 18:11 | |
| melwitt | bauzas alaski: I dug into the CellRoutingInconsistency errors from the tempest job last night and found they're all to do with the hypervisors api, for example if someone were to do a 'get hypervisor' with a name, it will have no routing info in the name (unless the caller included it, which tempest doesn't). is there any way we can get the routing info to route for it at the top or do we have to fail? | 18:11 |
| mriedem | this bdm conversion code is going to make my head explode | 18:12 |
| *** Marga_ has joined #openstack-nova | 18:12 | |
| *** otter768 has quit IRC | 18:14 | |
| *** ijw has quit IRC | 18:15 | |
| *** igordcard has quit IRC | 18:16 | |
| *** ijw has joined #openstack-nova | 18:16 | |
| *** lpetrut has joined #openstack-nova | 18:17 | |
| *** tonytan4ever has quit IRC | 18:22 | |
| *** VW_ has joined #openstack-nova | 18:22 | |
| *** biju has joined #openstack-nova | 18:23 | |
| jogo | dansmith: every so often we get a patch that gets in to the gate queue that fails pep8 or unit tests or something | 18:24 |
| jogo | and slows everything down like this | 18:24 |
| dansmith | okay | 18:24 |
| mriedem | blarg | 18:27 |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/block_device.py#n269 | 18:27 |
| mriedem | i want to refresh my connection_info b/c it's not there, but if it's not there, it won't refresh | 18:27 |
| biju | in iptables i can see many chains created with name nova-compute-inst-169 , nova-compute-inst-171 etc what are these numbers how can i identify chains of instances,can some one help | 18:28 |
| melwitt | mriedem: could you do this thing to get the connection again? http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/block_device.py#n231 | 18:29 |
| *** ildikov has joined #openstack-nova | 18:30 | |
| *** VW_ has quit IRC | 18:30 | |
| melwitt | mriedem: er, nevermind that's right there already. I must not understand | 18:30 |
| *** afazekas has quit IRC | 18:31 | |
| *** patrickeast has joined #openstack-nova | 18:33 | |
| dims_ | hey mriedem: there's a twist to the pre-existing port neutron change... https://bugs.launchpad.net/nova/+bug/1433524 | 18:33 |
| openstack | Launchpad bug 1433524 in OpenStack Compute (nova) "Nova deletes first preexisting port if second was attached to instance" [Undecided,New] | 18:33 |
| *** jyuso1 has quit IRC | 18:37 | |
| *** biju has quit IRC | 18:38 | |
| *** vilobhmm has joined #openstack-nova | 18:39 | |
| mriedem | melwitt: yeah, the bug is we attached a volume but before we detach, the bdm.connection_info is gone | 18:39 |
| mriedem | from the db | 18:39 |
| mriedem | so we blow up on detach with NoneType | 18:39 |
| mriedem | it's been a gate race issue for about a year now | 18:39 |
| mriedem | dims_: great | 18:40 |
| mriedem | well let's revert it then L) | 18:40 |
| mriedem | :) | 18:40 |
| dansmith | mriedem: would read_deleted help your bdm case? | 18:40 |
| mriedem | dansmith: i don't think the bdm is deleted though | 18:41 |
| mriedem | we get a bdm from the db, it's just that it's missing that field | 18:41 |
| dansmith | ah | 18:41 |
| mriedem | my attempt at a workaround was here https://review.openstack.org/#/c/164330/ | 18:41 |
| mriedem | but it's not going to work as is and is a pain in my ass to try and unit test w/o a db | 18:41 |
| mriedem | b/c surprise surprise mocking out a global utility method sort of makes other tests fail in racey ways :) | 18:42 |
| mriedem | so... i might start small and add a warning log if we get into this block http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/block_device.py#n272 | 18:43 |
| dansmith | mriedem: is this just because attach is a cast? | 18:43 |
| mriedem | and then hopefully recreate in the gate | 18:43 |
| mriedem | hmm | 18:43 |
| mriedem | well, tempest waits for the volume to be in-use | 18:43 |
| mriedem | before detaching | 18:43 |
| dansmith | so that happens early in compute_api before we even do the cast, right? | 18:44 |
| dansmith | that's reserve_volume? | 18:44 |
| mriedem | looking | 18:44 |
| vilobhmm | hi https://review.openstack.org/#/q/owner:cbehrens%2540codestud.com+status:open,n,z | 18:44 |
| *** vmtrooper has joined #openstack-nova | 18:44 | |
| vilobhmm | hi chris behrens | 18:44 |
| mriedem | vilobhmm: he's basically gone | 18:44 |
| vilobhmm | ok | 18:45 |
| vilobhmm | had few questions regarding the object model in nova for quotas | 18:45 |
| vilobhmm | as in cinder we are plannig to use the object model | 18:45 |
| vilobhmm | whom can i talk to | 18:45 |
| vilobhmm | mriedem : ^^ | 18:45 |
| mriedem | dansmith: yeah, compute api reserves the volume before doing the cast to attach the volume | 18:46 |
| *** dprince has quit IRC | 18:46 | |
| vilobhmm | esp specific to https://review.openstack.org/#/c/39986/17 review request | 18:46 |
| dansmith | mriedem: we have to do it before we try to connect to make sure it's ours I guess | 18:46 |
| *** rushiagr is now known as rushiagr_away | 18:46 | |
| dansmith | mriedem: that's pretty early, but... | 18:46 |
| alaski | melwitt: I think we need to fail in that case, because the only guarantee of uniqueness we have is the full cell path | 18:47 |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n3012 | 18:47 |
| dansmith | mriedem: we need an intermediate state of attaching and in-use or something | 18:47 |
| *** moshele has quit IRC | 18:47 | |
| *** moshele has joined #openstack-nova | 18:47 | |
| alaski | melwitt: so we can't just look up hypervisors in each cell | 18:47 |
| dansmith | mriedem: one option would be to make the api look up the bdm on detach and fail fast if there is no connection_info yet right? and then pass the bdm to manager so it doesn't have to look it up again | 18:48 |
| *** achanda has quit IRC | 18:48 | |
| dansmith | tempest would have to be graceful about this, but that seems like the right behavior | 18:48 |
| *** moshele has quit IRC | 18:49 | |
| *** vmtrooper has quit IRC | 18:49 | |
| mriedem | dansmith: hmm, that's kind of making compute api need to know the internals of what the compute manager is going to be doing though right? | 18:49 |
| dansmith | we can't detach without the connection_info, right? | 18:50 |
| mriedem | right, but we shouldn't have lost the connection_info in between | 18:50 |
| dansmith | I mean, that's not opaque to the api, I don't think | 18:50 |
| *** tonytan4ever has joined #openstack-nova | 18:50 | |
| dansmith | wait, | 18:50 |
| dansmith | we didn't lose it, we just haven't generated it yet right? | 18:50 |
| *** tjones1 has joined #openstack-nova | 18:50 | |
| mriedem | as in, something might be overwriting that to None in the db after attach | 18:50 |
| mriedem | there is no regenerate | 18:50 |
| mriedem | after attach | 18:50 |
| mriedem | that's what my workaround patch is attempting to do | 18:50 |
| dansmith | not regenerate, generate | 18:50 |
| mriedem | dansmith: so you think we're trying to detach before we ever attached and set that info? | 18:51 |
| *** Marga_ has quit IRC | 18:51 | |
| dansmith | yeah, tempest will start to detach before we do *anything* to actually attach, right? | 18:51 |
| dansmith | we set it as in-use in cinder and then BAM tempest is detaching, no? | 18:51 |
| mriedem | i thought that's what the in-use status was for | 18:51 |
| mriedem | hmmm | 18:52 |
| dansmith | right, but, | 18:52 |
| dansmith | according to the ordering, we set it early to grab the volume, | 18:52 |
| dansmith | which implies it's connected, but it isn't | 18:52 |
| dansmith | that's why I'm saying we need another state in between | 18:52 |
| mriedem | so why is attach_volume a cast? | 18:52 |
| dansmith | but without that, at least make detach defensive | 18:52 |
| dansmith | mriedem: for the same reason they all are, presumably | 18:52 |
| mriedem | attach_interface is a call | 18:52 |
| dansmith | it involves a lot of stuff that could take a while | 18:52 |
| mriedem | detach* are casts | 18:52 |
| *** Marga_ has joined #openstack-nova | 18:53 | |
| dansmith | yeah, and we've been aruging over attach_interface being a call for a long time :P | 18:53 |
| dansmith | either way, converting to a call is not a good solution here, I don't think | 18:53 |
| mriedem | yeah, was just wondering | 18:53 |
| mriedem | historical etc etc | 18:53 |
| openstackgerrit | Tomoki Sekiyama proposed openstack/nova: libvirt: Remove error messages from multipath command output before parsing https://review.openstack.org/165560 | 18:53 |
| mriedem | ok, so i didn't realize attach_volume was a cast and we have this state change race | 18:54 |
| sdague | alaski: one of your objects changes is failing in the gate, possible interface change on it? | 18:54 |
| dansmith | mriedem: attach_interface returns stuff, which is the primary reason, but volume does not | 18:54 |
| mriedem | in the compute manager we also aren't reverting the state of the volume when detach fails, that's it's own bug | 18:54 |
| dansmith | mriedem: why is that a bug? | 18:54 |
| vilobhmm | dansmith : ping | 18:54 |
| dansmith | vilobhmm: hi | 18:54 |
| mriedem | dansmith: the volume is left in state 'detaching' permantently | 18:55 |
| mriedem | unless cinder has a reset-state api | 18:55 |
| dansmith | oh, aren't reverting | 18:55 |
| dansmith | read that wrong | 18:55 |
| dansmith | well, | 18:55 |
| dansmith | if you fail fast in api, it will help that | 18:55 |
| *** sbfox has quit IRC | 18:55 | |
| mriedem | sure | 18:55 |
| mriedem | fwiw, we do revert the volume state on failure eventually http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n4683 | 18:55 |
| mriedem | if the driver fails | 18:55 |
| alaski | sdague: possible, but the objects changes rely on very little from the rest of Nova | 18:55 |
| mriedem | but if the compute manager fails before that, we don't catch it | 18:55 |
| melwitt | alaski: thanks, that's what I thought but wanted to double check. my understand is the only way we could find a compute host would be to pull all of them from all cells and filter after that | 18:56 |
| vilobhmm | for quota objects https://github.com/openstack/nova/blob/master/nova/objects/quotas.py how did we end up consolidating the models fro class Quota, QuotaUsage, QuotaClass and Reservations into class Quotas in objects/quotas.py which just has 3-4 fields | 18:56 |
| sdague | alaski: go look at the py27 unit tests | 18:56 |
| dansmith | mriedem: aye | 18:56 |
| vilobhmm | dansmith : ^^ | 18:56 |
| dansmith | mriedem: so you wanna try to cook up that change or should I? | 18:56 |
| sdague | for 161904,7 | 18:56 |
| mriedem | dansmith: it's my white whale right now | 18:56 |
| mriedem | vilobhmm: the objects are based on the db model | 18:56 |
| mriedem | so the fields come from that | 18:56 |
| dansmith | mriedem: is that a .. yes? | 18:56 |
| mriedem | and the operations | 18:56 |
| mriedem | dansmith: i'm working on it | 18:56 |
| vilobhmm | mridem : i get that and i have wip request open in cinder for cinder quota objects https://review.openstack.org/#/c/163232/ | 18:57 |
| dansmith | mriedem: >>> bool("White Whale") | 18:57 |
| dansmith | True | 18:57 |
| dansmith | okay | 18:57 |
| mriedem | dansmith: so you suggest passing the bdm from the api to the compute manager via rpc? | 18:57 |
| alaski | sdague: this is going to sound dumb, but how do I get to the jenkins page for that. zuul just links me back to the review | 18:57 |
| mriedem | so an rpc version change? | 18:57 |
| dansmith | mriedem: might as well so that we avoid looking it up twice | 18:57 |
| dansmith | mriedem: yeah, an easy one | 18:57 |
| sdague | alaski: expand it in zuul | 18:57 |
| sdague | and click on the test link | 18:57 |
| sdague | it will take you to the jenkins console | 18:58 |
| vilobhmm | which has a 1:1 mapping between the quota model and the quota object but since quota depends on othes models as well like quotaclass, quota usage and reservations how do you combine them into one respresentation at the object level was what i asking about ( the way its done in nova/objects/quotas.py) | 18:58 |
| alaski | sdague: heh, I didn't click because there was no + or anything | 18:58 |
| *** sbfox has joined #openstack-nova | 18:58 | |
| sdague | yeh, it's a ux thing that is probably poorly explained | 18:58 |
| vilobhmm | mriedem, dansmith : ^^ | 18:58 |
| dansmith | vilobhmm: we're kinda in k3 cram mode here and it sounds like you're talking about lemming things, can we punt this convo until some other time? | 18:59 |
| alaski | melwitt: correct. and that would mostly work, unless two hosts shared the same name which would be completely possible | 18:59 |
| vilobhmm | dansmith : ok | 18:59 |
| melwitt | alaski: yes true | 18:59 |
| dansmith | vilobhmm: thanks, I'll be glad to help you with your stuff, but would like to do it at an appropriate time | 19:00 |
| dansmith | vilobhmm: assuming you're not trying to get this done for kilo | 19:00 |
| vilobhmm | dansmith : thats fine…for L no rush thanks | 19:00 |
| dansmith | vilobhmm: okay thanks | 19:00 |
| *** dprince has joined #openstack-nova | 19:00 | |
| *** achanda has joined #openstack-nova | 19:01 | |
| mriedem | dansmith: this seems to only fail in encrypted volume scenario tests so yeah maybe the encrypted nature of the test makes attach slower and more likely to fail here | 19:02 |
| mriedem | that's purely speculation though | 19:02 |
| dansmith | mriedem: sure.. also a good reason for it to be a cast :) | 19:02 |
| openstackgerrit | Sean Dague proposed openstack/nova: load ram_allocation_ratio when asked https://review.openstack.org/165397 | 19:02 |
| sdague | oh pep8 unused imports, sometimes I hate you | 19:03 |
| *** sandywalsh has quit IRC | 19:03 | |
| dansmith | oh man, one more test and we slam in all the object context stuff | 19:03 |
| * dansmith waits with held breath | 19:03 | |
| *** alexpilotti_ has quit IRC | 19:04 | |
| *** Marga_ has quit IRC | 19:04 | |
| *** Marga_ has joined #openstack-nova | 19:05 | |
| *** liusheng has quit IRC | 19:05 | |
| *** andreykurilin_ has joined #openstack-nova | 19:06 | |
| *** liusheng has joined #openstack-nova | 19:06 | |
| *** emagana has quit IRC | 19:06 | |
| *** marun has quit IRC | 19:07 | |
| mriedem | dansmith: ha, speak of the devil https://review.openstack.org/#/c/163937/ | 19:07 |
| dansmith | heh | 19:08 |
| dansmith | woot | 19:09 |
| *** emagana has joined #openstack-nova | 19:09 | |
| *** diegows has joined #openstack-nova | 19:09 | |
| mriedem | i'm not really sure how that change helps yet | 19:09 |
| alaski | sdague: ahh, dansmith broke it https://review.openstack.org/#/c/164268/ | 19:10 |
| dansmith | alaski: oh jeez, broke what? | 19:10 |
| *** cburgess has quit IRC | 19:10 | |
| dansmith | oh, caused a patch to need a rebase? :) | 19:10 |
| alaski | dansmith: I think so, yeah :) | 19:10 |
| * dansmith stamps another alaski icon on the side of his plane | 19:11 | |
| *** cburgess has joined #openstack-nova | 19:11 | |
| alaski | lol | 19:11 |
| *** nellysmitt has quit IRC | 19:12 | |
| dansmith | mriedem: hmm, maybe this contradicts my theory | 19:12 |
| *** renatoar_ has quit IRC | 19:12 | |
| *** exploreshaifali has quit IRC | 19:13 | |
| dansmith | mriedem: what is the difference between reserve and attach in the volume api/ | 19:13 |
| sdague | so... I'm trying to figure out if there is any sensible way to return more detailed information off the last filter failure in the scheduler. The challenge is the filters code ends up nested a few layers deep, and has an interface of returning just a host list (with no other info). | 19:13 |
| dansmith | ah, there is an attaching | 19:13 |
| sdague | which is fine if you are thinking about this as prolog, and just need a boolean, but is kind of odd in actually telling anyone what went wrong | 19:14 |
| mriedem | dansmith: yeah, reserve sets an 'available' volume into 'in-use' | 19:14 |
| mriedem | oops | 19:14 |
| mriedem | 'attaching' | 19:14 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add InstanceMapping object https://review.openstack.org/161904 | 19:15 |
| dansmith | right, okay, so that means I'm wrong | 19:15 |
| mriedem | so compute api sets the volume to 'attaching' before the cast | 19:15 |
| dansmith | ah, so here's the race | 19:16 |
| dansmith | we set it to in-use before we save the bdm object I think | 19:16 |
| *** Mike_D_laptop has joined #openstack-nova | 19:16 | |
| mriedem | yeah, because the @update_db wrapper doesn't hit until after the attach/in-use | 19:16 |
| mriedem | from hte driver calling volume_api | 19:16 |
| dansmith | right | 19:17 |
| mriedem | so we should just update the bdm.connection_info in the db after getting that info from volume_api before calling driver.attach_volume | 19:17 |
| mriedem | that's much easier | 19:17 |
| dansmith | so just tacking another .save() in there would be good | 19:17 |
| dansmith | and then the update_db wrapper will be a no-op if there is nothing else changed | 19:17 |
| mriedem | right | 19:17 |
| dansmith | yay for one line gate blocker fixes :) | 19:17 |
| mriedem | yup | 19:17 |
| mriedem | i think that's what this guy thought he was doing https://review.openstack.org/#/c/163937/1 | 19:18 |
| mriedem | but it's wrong | 19:18 |
| dansmith | yeah | 19:18 |
| mriedem | and an ugly refactor | 19:18 |
| mriedem | so i'll just update my change against the old gate bug | 19:18 |
| mriedem | and dupe his against that | 19:18 |
| dansmith | cool | 19:18 |
| mriedem | \o/ | 19:18 |
| * dansmith blows off the barrel and holsters his weapon | 19:18 | |
| *** casusbelli has quit IRC | 19:19 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add CellMapping object https://review.openstack.org/161867 | 19:20 |
| dansmith | alaski: look at those naked remotables with no context! :) | 19:20 |
| *** Mike_D_laptop has quit IRC | 19:20 | |
| dansmith | sdague: did you have some issue with those objects of his? | 19:20 |
| sdague | dansmith: no, I just was trying to be helpful and let alaski know it was failing early | 19:21 |
| dansmith | ah, okay | 19:21 |
| *** salv-orlando has quit IRC | 19:24 | |
| alaski | dansmith: I love it, they're so sleek now | 19:25 |
| alaski | sdague: thanks | 19:25 |
| *** adelinatuvenie has quit IRC | 19:25 | |
| *** plaurin_ has left #openstack-nova | 19:25 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add InstanceMapping object https://review.openstack.org/161904 | 19:26 |
| alaski | alright, both objects should be good to go now | 19:26 |
| *** johnthetubaguy is now known as zz_johnthetubagu | 19:27 | |
| *** andreykurilin_ has quit IRC | 19:27 | |
| *** irenab has joined #openstack-nova | 19:29 | |
| mriedem | dansmith: i can't see that nova actually calls cinder api os-attach...do you know if that's a thing that cinder picks up via periodict task when the volume shows up connected to something on the host? | 19:30 |
| *** salv-orlando has joined #openstack-nova | 19:30 | |
| mriedem | b/c cinder os-attach is what eventually updates the volume status to 'in-use' in the cinder db | 19:30 |
| dansmith | mriedem: this? https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L265 | 19:31 |
| mriedem | yeah, was looking at that | 19:31 |
| mriedem | i think i goofed up and thought that was 'status' rather than 'attach_status' | 19:31 |
| *** annashen has quit IRC | 19:31 | |
| mriedem | so that would be it :) | 19:31 |
| dansmith | alright :) | 19:31 |
| mriedem | ok, this would fix it then https://review.openstack.org/#/c/163937/ | 19:33 |
| *** eharney has quit IRC | 19:33 | |
| mriedem | but fugly | 19:33 |
| mriedem | and i wouldn't want to backport that | 19:33 |
| *** aswadr has quit IRC | 19:34 | |
| *** tjones1 has left #openstack-nova | 19:35 | |
| dansmith | mriedem: all we need is a single .save() call right? | 19:35 |
| dansmith | no need to do all that | 19:35 |
| mriedem | yeah, right above volume_api.attach(context, volume_id, instance.uuid, | 19:36 |
| dansmith | right | 19:36 |
| dansmith | let's do _that_ instead of this :) | 19:36 |
| dansmith | I thought you were going to convert your other patch to that and post | 19:37 |
| mriedem | unit test bro! | 19:37 |
| *** boris-42 has quit IRC | 19:37 | |
| *** vilobhmm1 has joined #openstack-nova | 19:38 | |
| *** vilobhmm has quit IRC | 19:39 | |
| *** Vek has quit IRC | 19:39 | |
| *** erlon has quit IRC | 19:39 | |
| *** krtaylor has quit IRC | 19:39 | |
| *** comstud has quit IRC | 19:39 | |
| *** cyeoh has quit IRC | 19:39 | |
| *** lbragstad has quit IRC | 19:39 | |
| *** toan has quit IRC | 19:39 | |
| *** toan has joined #openstack-nova | 19:40 | |
| *** lbragstad has joined #openstack-nova | 19:40 | |
| *** comstud has joined #openstack-nova | 19:41 | |
| *** erlon has joined #openstack-nova | 19:41 | |
| *** krtaylor has joined #openstack-nova | 19:41 | |
| *** cyeoh has joined #openstack-nova | 19:41 | |
| *** rfolco has quit IRC | 19:41 | |
| *** boris-42 has joined #openstack-nova | 19:42 | |
| *** Marga_ has quit IRC | 19:43 | |
| *** romainh has joined #openstack-nova | 19:43 | |
| *** Marga_ has joined #openstack-nova | 19:44 | |
| *** VW_ has joined #openstack-nova | 19:44 | |
| *** diegows has quit IRC | 19:44 | |
| *** VW_ has quit IRC | 19:44 | |
| *** diegows has joined #openstack-nova | 19:45 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Save bdm.connection_info before calling volume_api.attach_volume https://review.openstack.org/164330 | 19:50 |
| mriedem | mtreinish: turns out that was a really trivial fix for that old gate bug ^ | 19:50 |
| *** diegows_ has joined #openstack-nova | 19:50 | |
| mtreinish | mriedem: oh is that the thing we were looking at the other day? | 19:50 |
| mriedem | last week | 19:50 |
| mriedem | the encrypted volumes scenario test | 19:50 |
| *** VW_ has joined #openstack-nova | 19:52 | |
| *** VW_ has quit IRC | 19:52 | |
| *** sdake_ has joined #openstack-nova | 19:52 | |
| *** VW_ has joined #openstack-nova | 19:52 | |
| *** diegows has quit IRC | 19:53 | |
| *** ijw has quit IRC | 19:53 | |
| *** Marga_ has quit IRC | 19:54 | |
| *** matrohon has joined #openstack-nova | 19:54 | |
| *** devlaps has joined #openstack-nova | 19:55 | |
| *** zigo__ has joined #openstack-nova | 19:56 | |
| *** zigo has quit IRC | 19:56 | |
| *** sdake has quit IRC | 19:56 | |
| *** swamireddy_ has quit IRC | 19:57 | |
| openstackgerrit | Chris Friesen proposed openstack/nova: Validate server group anti-affinity policy https://review.openstack.org/162746 | 19:58 |
| melwitt | mriedem: way to go :) | 19:58 |
| *** swamireddy has joined #openstack-nova | 19:58 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate unused conductor service calls https://review.openstack.org/133664 | 19:58 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Refactor some service tests and make them not require db https://review.openstack.org/133665 | 19:58 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Convert service and servicegroup to objects https://review.openstack.org/133663 | 19:58 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Add a fixture for the NovaObject indirection API https://review.openstack.org/164146 | 19:58 |
| mriedem | i credit dansmith since i was looking at this w/o knowing attach was a cast | 19:58 |
| *** flwang has quit IRC | 19:59 | |
| melwitt | dansmith mriedem: way to go both :) | 19:59 |
| bauzas | melwitt: so you had a question about CellsRoutingInconsistency ? | 19:59 |
| *** achanda has quit IRC | 20:00 | |
| *** thomasem has quit IRC | 20:00 | |
| *** flwang has joined #openstack-nova | 20:01 | |
| *** emagana has quit IRC | 20:01 | |
| melwitt | bauzas: I did, alaski let me know we expect failure with the CellRoutingInconsistency (missing cell_name) for all the hypervisors api because we can't get routing info from the top, at best we could pull all compute hosts and filter. I've been weeding through the remaining tempest job failures and checking which ones are addressable | 20:01 |
| *** VW_ has quit IRC | 20:02 | |
| bauzas | melwitt: sorry I don't get your point | 20:04 |
| bauzas | melwitt: could you please point me to a log ? | 20:05 |
| melwitt | bauzas: sorry, probably dropping a lot of context. things tempest does like "list hypervisors" "get hypervisor" it passes a plain name that we can't route. I had asked as a double check if there's anything we could do about it | 20:05 |
| *** pixelb has quit IRC | 20:05 | |
| *** Maike has joined #openstack-nova | 20:05 | |
| openstackgerrit | Kent Wang proposed openstack/nova: Adds Not Null constraint to KeyPair name https://review.openstack.org/163230 | 20:06 |
| *** dprince has quit IRC | 20:06 | |
| melwitt | bauzas: this is one from the cells run on your second patch that clears up the 'dict' object has no attribute 'host' errors. affer those go away, we're left with the cell routing failure http://logs.openstack.org/06/160506/7/check/check-tempest-dsvm-cells/8394946/logs/screen-n-api.txt.gz?level=TRACE#_2015-03-13_20_21_41_976 | 20:06 |
| sdague | dansmith: you were -1 on a prev version of - https://review.openstack.org/#/c/151953 - however the new version it a lot cleaner | 20:07 |
| sdague | you want to rivisit | 20:07 |
| sdague | it's libvirt race condition mitigation | 20:07 |
| *** thomasem has joined #openstack-nova | 20:09 | |
| *** rfolco has joined #openstack-nova | 20:10 | |
| dansmith | mriedem: your test doesn't really validate that it's doing the right thing, although it's close :) | 20:10 |
| *** Sukhdev has quit IRC | 20:11 | |
| *** Maike has quit IRC | 20:11 | |
| *** otter768 has joined #openstack-nova | 20:11 | |
| *** Maike has joined #openstack-nova | 20:11 | |
| mriedem | dansmith: well, yeah...i could make the test smarter by stubbing out save() and checking what's changed on the object for each call | 20:11 |
| dansmith | yeah | 20:12 |
| mriedem | i can still do that, there is still time! | 20:12 |
| dansmith | mriedem: I +2d anyway | 20:12 |
| *** openstackgerrit has quit IRC | 20:14 | |
| bauzas | melwitt: what the heck | 20:14 |
| *** dprince has joined #openstack-nova | 20:15 | |
| *** openstackgerrit has joined #openstack-nova | 20:15 | |
| bauzas | melwitt: I don't even understand how this exception is raised | 20:15 |
| *** otter768 has quit IRC | 20:15 | |
| bauzas | I mean the ExpectedException | 20:15 |
| *** exploreshaifali has joined #openstack-nova | 20:16 | |
| *** changbl has joined #openstack-nova | 20:17 | |
| *** eharney has joined #openstack-nova | 20:18 | |
| bauzas | melwitt: seen this on the same patch http://logs.openstack.org/06/160506/7/check/check-tempest-dsvm-cells/8394946/logs/screen-n-cell-child.txt.gz?level=TRACE ? | 20:18 |
| bauzas | oops http://logs.openstack.org/06/160506/7/check/check-tempest-dsvm-cells/8394946/logs/screen-n-cell-child.txt.gz?level=TRACE#_2015-03-13_20_21_49_964 | 20:19 |
| *** diegows_ has quit IRC | 20:19 | |
| *** aysyd has quit IRC | 20:19 | |
| *** aysyd has joined #openstack-nova | 20:21 | |
| *** Marga_ has joined #openstack-nova | 20:21 | |
| *** romainh has left #openstack-nova | 20:22 | |
| *** tjones1 has joined #openstack-nova | 20:25 | |
| *** tjones1 has left #openstack-nova | 20:25 | |
| *** moshele has joined #openstack-nova | 20:30 | |
| *** annashen has joined #openstack-nova | 20:32 | |
| *** vladikr has quit IRC | 20:32 | |
| *** vmtrooper has joined #openstack-nova | 20:33 | |
| *** Bsony has quit IRC | 20:34 | |
| *** Maike has quit IRC | 20:35 | |
| *** Maike has joined #openstack-nova | 20:35 | |
| openstackgerrit | Chris Friesen proposed openstack/nova: Fix race in server group policy validation https://review.openstack.org/164762 | 20:35 |
| *** annashen has quit IRC | 20:37 | |
| *** vmtrooper has quit IRC | 20:38 | |
| *** Bsony has joined #openstack-nova | 20:38 | |
| *** adalbas has quit IRC | 20:41 | |
| mfisch | Can anyone explain what happened to novaclient, why it went from v3 back to v2? Was that a typo? | 20:44 |
| mfisch | 2.19 and 2.20 have "v3" and master now has v2, not v3 | 20:44 |
| edleafe | dansmith: jaypipes-afk: garyk: johnthetubaguy: Can I get a final push to get https://review.openstack.org/#/c/160513/ over the finish line? | 20:46 |
| mfisch | nm I found the commit, that's a pretty annoying change... | 20:46 |
| *** mrda-away is now known as mrda | 20:47 | |
| *** achanda has joined #openstack-nova | 20:48 | |
| mriedem | dansmith: derp, i got my test but bdm.save() doesn't call self.obj_reset_changes() at the end :( | 20:48 |
| mriedem | kosher to add in this change, or as a dependent? | 20:48 |
| *** annashen has joined #openstack-nova | 20:50 | |
| mriedem | well that doesn't seem to help anyway | 20:51 |
| mriedem | heh, b/c i stubbed out bdm.save() | 20:51 |
| mriedem | double derp | 20:51 |
| *** sdake has joined #openstack-nova | 20:52 | |
| melwitt | bauzas: I think the ExpectedException thing comes from the @oslo_messaging.expected_exceptions(exception.CellRoutingInconsistency) decorator on things in cells/manager.py | 20:53 |
| *** exploreshaifali has quit IRC | 20:56 | |
| *** sdake_ has quit IRC | 20:56 | |
| *** alexpilotti has joined #openstack-nova | 20:56 | |
| melwitt | bauzas: on the log you linked, that should be fixed now by https://review.openstack.org/#/c/163978/ | 20:57 |
| openstackgerrit | Eric Brown proposed openstack/nova: Use oslo_config choices support https://review.openstack.org/158573 | 21:00 |
| *** thomasem has quit IRC | 21:01 | |
| openstackgerrit | Eric Brown proposed openstack/nova: Use oslo_config choices support https://review.openstack.org/158573 | 21:02 |
| *** jmulsow1 has joined #openstack-nova | 21:03 | |
| *** Nikolay_St has quit IRC | 21:04 | |
| *** Nikolay_St has joined #openstack-nova | 21:04 | |
| *** sbfox has quit IRC | 21:05 | |
| lbragstad | mriedem: do you need anything else on the keystone side here: https://bugs.launchpad.net/keystone/+bug/1410622 ? | 21:06 |
| openstack | Launchpad bug 1410622 in Keystone "nova is still broken with boto==2.35*" [Medium,Triaged] | 21:06 |
| mriedem | lbragstad: no | 21:06 |
| mriedem | makred invalid | 21:06 |
| mriedem | *marked | 21:06 |
| lbragstad | mriedem: sweet, thanks | 21:06 |
| *** Bsony has quit IRC | 21:06 | |
| jmulsow1 | Would anyone be willing to do a review on https://review.openstack.org/#/c/164308/ since string freeze is tomorrow? It is a change to an API message. | 21:08 |
| *** tjones1 has joined #openstack-nova | 21:08 | |
| *** tjones1 has left #openstack-nova | 21:09 | |
| *** Nikolay_St has quit IRC | 21:10 | |
| *** Nikolay_St has joined #openstack-nova | 21:10 | |
| openstackgerrit | Sean Dague proposed openstack/nova: wip: in tree add of EnhancedFakeLogger https://review.openstack.org/165601 | 21:11 |
| openstackgerrit | Sean Dague proposed openstack/nova: wip: test_ops_logs stub test https://review.openstack.org/165602 | 21:11 |
| *** dprince has quit IRC | 21:14 | |
| openstackgerrit | Michal Rostecki proposed openstack/nova: Adding security groups to existing ports https://review.openstack.org/163780 | 21:15 |
| *** iamjarvo has quit IRC | 21:16 | |
| *** BobBall is now known as BobBall_AWOL | 21:18 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: WIP: Fix for deletes first preexisting port if second was attached to instance https://review.openstack.org/165608 | 21:18 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add the instance update calls from Compute https://review.openstack.org/160513 | 21:18 |
| dims_ | mriedem: hoping this would fix! https://review.openstack.org/165608. seems to work on devstack | 21:21 |
| dims_ | back in a bit | 21:21 |
| *** Nikolay_St has quit IRC | 21:24 | |
| bauzas | sdague: got your bug comment on https://bugs.launchpad.net/bugs/1431291 | 21:25 |
| openstack | Launchpad bug 1431291 in OpenStack Compute (nova) "Scheduler Failures are no longer logged with enough detail for a site admin to do problem determination" [High,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza) | 21:25 |
| *** Nikolay_St has joined #openstack-nova | 21:25 | |
| bauzas | sdague: ack, will work on it starting tomorro | 21:25 |
| bauzas | ow | 21:25 |
| sdague | bauzas: ok, great | 21:25 |
| sdague | I stuck this up as wip - https://review.openstack.org/#/c/165602/ which could be used to test the results | 21:26 |
| bauzas | sdague: starring it | 21:26 |
| bauzas | I saw your series, was about to review it | 21:26 |
| *** __TheDodd__ has joined #openstack-nova | 21:27 | |
| sdague | the top 2 are in WIP, because one is hacking a base fixture and the other doesn't have the real test yet, it's just the setup for it. | 21:27 |
| *** thedodd has quit IRC | 21:28 | |
| *** mriedem is now known as mriedem_away | 21:28 | |
| *** lpetrut has quit IRC | 21:29 | |
| bauzas | sdague: sure | 21:31 |
| *** jamielennox is now known as jamielennox|away | 21:31 | |
| *** annashen has quit IRC | 21:33 | |
| *** kaufer has quit IRC | 21:35 | |
| *** jmulsow1 has quit IRC | 21:36 | |
| *** changbl has quit IRC | 21:37 | |
| *** Vek has joined #openstack-nova | 21:38 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Replace conductor get_ec2_ids() with new Instance.ec2_ids attribute https://review.openstack.org/158066 | 21:39 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Add EC2Ids object and link to Instance object as optional attribute https://review.openstack.org/149746 | 21:39 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused metadata conductor parameter https://review.openstack.org/149747 | 21:39 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate conductor get_ec2_ids() https://review.openstack.org/149749 | 21:39 |
| *** Marga_ has quit IRC | 21:39 | |
| *** browne has quit IRC | 21:39 | |
| *** annashen has joined #openstack-nova | 21:40 | |
| *** Marga_ has joined #openstack-nova | 21:40 | |
| *** Marga_ has quit IRC | 21:40 | |
| *** browne has joined #openstack-nova | 21:40 | |
| *** Marga_ has joined #openstack-nova | 21:40 | |
| *** devlaps has quit IRC | 21:43 | |
| *** asettle has joined #openstack-nova | 21:44 | |
| *** xyang1 has quit IRC | 21:49 | |
| *** flaper87 has quit IRC | 21:50 | |
| *** eglynn has quit IRC | 21:50 | |
| *** eglynn has joined #openstack-nova | 21:50 | |
| *** mwagner_lap has quit IRC | 21:51 | |
| *** yamahata has quit IRC | 21:52 | |
| *** yamahata has joined #openstack-nova | 21:52 | |
| *** asettle has quit IRC | 21:53 | |
| *** flaper87 has joined #openstack-nova | 21:53 | |
| *** matrohon has quit IRC | 21:54 | |
| *** thangp has quit IRC | 21:57 | |
| *** boris-42 has quit IRC | 22:02 | |
| *** neelashah has quit IRC | 22:03 | |
| *** dave-mccowan has quit IRC | 22:04 | |
| *** nelsnelson has quit IRC | 22:05 | |
| *** pixelb has joined #openstack-nova | 22:07 | |
| *** asettle has joined #openstack-nova | 22:07 | |
| *** ZZelle_ has joined #openstack-nova | 22:09 | |
| *** burt has quit IRC | 22:09 | |
| *** tjones1 has joined #openstack-nova | 22:10 | |
| *** marun has joined #openstack-nova | 22:10 | |
| *** asettle has quit IRC | 22:12 | |
| *** otter768 has joined #openstack-nova | 22:12 | |
| *** jamielennox|away is now known as jamielennox | 22:12 | |
| *** asettle has joined #openstack-nova | 22:13 | |
| *** Bsony has joined #openstack-nova | 22:13 | |
| *** hdd has joined #openstack-nova | 22:13 | |
| *** otter768 has quit IRC | 22:17 | |
| *** Bsony has quit IRC | 22:18 | |
| *** dboik has quit IRC | 22:18 | |
| *** packet has quit IRC | 22:19 | |
| *** annashen has quit IRC | 22:20 | |
| openstackgerrit | Kent Wang proposed openstack/nova: Adds Not Null constraint to KeyPair name https://review.openstack.org/163230 | 22:20 |
| *** oro_ has quit IRC | 22:20 | |
| *** Nic has quit IRC | 22:21 | |
| *** vmtrooper has joined #openstack-nova | 22:22 | |
| *** welldannit has quit IRC | 22:22 | |
| *** vmtrooper has quit IRC | 22:27 | |
| *** tjones1 has left #openstack-nova | 22:29 | |
| *** angdraug has joined #openstack-nova | 22:31 | |
| openstackgerrit | Fei Long Wang proposed openstack/nova: Fix nova backup for volume-backed instance https://review.openstack.org/164494 | 22:32 |
| *** diegows_ has joined #openstack-nova | 22:32 | |
| *** annashen has joined #openstack-nova | 22:33 | |
| *** cbader has quit IRC | 22:34 | |
| *** melwitt has quit IRC | 22:34 | |
| *** Sukhdev has joined #openstack-nova | 22:35 | |
| *** Marga_ has quit IRC | 22:36 | |
| *** stefanb has joined #openstack-nova | 22:40 | |
| *** dboik has joined #openstack-nova | 22:41 | |
| *** dkliban is now known as dkliban_afk | 22:42 | |
| *** dboik_ has joined #openstack-nova | 22:43 | |
| *** dboik has quit IRC | 22:46 | |
| *** Marga_ has joined #openstack-nova | 22:47 | |
| *** andreykurilin_ has joined #openstack-nova | 22:48 | |
| *** jecarey has quit IRC | 22:51 | |
| *** aysyd has quit IRC | 22:55 | |
| *** VW_ has joined #openstack-nova | 22:58 | |
| *** zzzeek has quit IRC | 22:59 | |
| openstackgerrit | Fei Long Wang proposed openstack/nova: Fix nova backup for instance with volume-backend https://review.openstack.org/164494 | 23:01 |
| *** tjones2 has joined #openstack-nova | 23:05 | |
| *** jlvillal has joined #openstack-nova | 23:08 | |
| *** Maike has quit IRC | 23:12 | |
| *** eglynn has quit IRC | 23:13 | |
| *** claudiub has quit IRC | 23:21 | |
| *** mjturek3 has quit IRC | 23:25 | |
| *** andreykurilin_ has quit IRC | 23:25 | |
| *** mrodden has quit IRC | 23:25 | |
| *** hemna is now known as hemnafk | 23:26 | |
| *** mrodden has joined #openstack-nova | 23:27 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Rename and move the v2.1 api policy into separated files https://review.openstack.org/150267 | 23:28 |
| *** dims__ has joined #openstack-nova | 23:29 | |
| *** boris-42 has joined #openstack-nova | 23:30 | |
| *** dims_ has quit IRC | 23:33 | |
| *** diegows_ has quit IRC | 23:36 | |
| *** jcru has quit IRC | 23:37 | |
| *** hdd has quit IRC | 23:37 | |
| *** IanGovett has quit IRC | 23:42 | |
| *** BobBall_AWOL has quit IRC | 23:44 | |
| *** BobBall_AWOL has joined #openstack-nova | 23:46 | |
| *** apuimedo has joined #openstack-nova | 23:50 | |
| *** dave-mccowan has joined #openstack-nova | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!