| *** baoli has quit IRC | 00:00 | |
| *** liusheng has quit IRC | 00:00 | |
| *** baoli has joined #openstack-nova | 00:00 | |
| *** liusheng has joined #openstack-nova | 00:00 | |
| *** r-daneel has joined #openstack-nova | 00:02 | |
| *** tonytan4ever has quit IRC | 00:07 | |
| *** gokrokve has joined #openstack-nova | 00:08 | |
| *** annashen has quit IRC | 00:08 | |
| *** igordcard_ has quit IRC | 00:10 | |
| *** erlon has quit IRC | 00:11 | |
| *** aix has joined #openstack-nova | 00:12 | |
| *** tjones1 has quit IRC | 00:13 | |
| *** dave-mccowan has joined #openstack-nova | 00:16 | |
| *** annashen has joined #openstack-nova | 00:16 | |
| *** emagana has quit IRC | 00:26 | |
| *** ijw has quit IRC | 00:27 | |
| *** eliqiao has joined #openstack-nova | 00:28 | |
| *** samueldmq has quit IRC | 00:28 | |
| *** annashen has quit IRC | 00:28 | |
| *** vmtrooper has joined #openstack-nova | 00:28 | |
| *** vmtrooper has quit IRC | 00:33 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add and use raise_http_not_implemented_error() https://review.openstack.org/163697 | 00:33 |
|---|---|---|
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add a hacking rule for consistent HTTP501 message https://review.openstack.org/163698 | 00:33 |
| *** claudiub has quit IRC | 00:36 | |
| *** otter768 has joined #openstack-nova | 00:36 | |
| *** r-daneel has quit IRC | 00:37 | |
| *** xyang1 has quit IRC | 00:40 | |
| *** otter768 has quit IRC | 00:40 | |
| *** Longgeek has joined #openstack-nova | 00:41 | |
| *** Marga_ has quit IRC | 00:46 | |
| *** kmartin has quit IRC | 00:47 | |
| *** Marga_ has joined #openstack-nova | 00:47 | |
| *** achanda_ has quit IRC | 00:48 | |
| *** salv-orlando has joined #openstack-nova | 00:50 | |
| *** shaohe_feng1 has joined #openstack-nova | 00:52 | |
| *** browne has quit IRC | 00:54 | |
| *** rmoe has quit IRC | 00:57 | |
| *** Longgeek has quit IRC | 01:01 | |
| *** Longgeek has joined #openstack-nova | 01:01 | |
| openstackgerrit | Eli Qiao proposed openstack/nova-specs: Validate the service state before deleting it https://review.openstack.org/163274 | 01:02 |
| *** promulo__ has joined #openstack-nova | 01:04 | |
| *** promulo has quit IRC | 01:08 | |
| *** rmoe has joined #openstack-nova | 01:11 | |
| *** Nic has quit IRC | 01:18 | |
| *** yingjun has joined #openstack-nova | 01:19 | |
| openstackgerrit | melanie witt proposed openstack/python-novaclient: Ensure the use of volume endpoint in volumes apis https://review.openstack.org/164321 | 01:19 |
| *** wverdugo5002 has joined #openstack-nova | 01:19 | |
| *** exploreshaifali has quit IRC | 01:20 | |
| *** otter768 has joined #openstack-nova | 01:21 | |
| *** wverdugo5002 has left #openstack-nova | 01:21 | |
| *** dsanders1 has quit IRC | 01:22 | |
| *** dims has quit IRC | 01:26 | |
| *** IanGovett has quit IRC | 01:31 | |
| *** liusheng has quit IRC | 01:31 | |
| *** liusheng has joined #openstack-nova | 01:32 | |
| *** itzikb has joined #openstack-nova | 01:38 | |
| itzikb | heyongli: ping | 01:38 |
| *** neelashah has joined #openstack-nova | 01:39 | |
| *** dave-mccowan has quit IRC | 01:40 | |
| *** ybathia has quit IRC | 01:41 | |
| *** Longgeek has quit IRC | 01:41 | |
| *** popw has joined #openstack-nova | 01:44 | |
| *** itzikb has quit IRC | 01:46 | |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_associate https://review.openstack.org/161234 | 01:47 |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: add neutron api NotImplemented test cases for Network V2.1 https://review.openstack.org/162564 | 01:47 |
| *** Longgeek has joined #openstack-nova | 01:49 | |
| *** browne has joined #openstack-nova | 01:51 | |
| *** annashen has joined #openstack-nova | 01:52 | |
| *** dims has joined #openstack-nova | 01:54 | |
| *** Marga_ has quit IRC | 01:55 | |
| *** dave-mccowan has joined #openstack-nova | 01:56 | |
| *** Marga_ has joined #openstack-nova | 01:58 | |
| *** baoli has quit IRC | 01:58 | |
| *** jcru has joined #openstack-nova | 01:59 | |
| *** baoli has joined #openstack-nova | 01:59 | |
| *** jcru has quit IRC | 02:00 | |
| *** ajayaa has joined #openstack-nova | 02:02 | |
| *** dims has quit IRC | 02:03 | |
| *** annashen has quit IRC | 02:03 | |
| *** annashen has joined #openstack-nova | 02:03 | |
| *** yamahata has quit IRC | 02:07 | |
| *** Marga_ has quit IRC | 02:08 | |
| *** zzzeek has quit IRC | 02:09 | |
| *** Marga_ has joined #openstack-nova | 02:10 | |
| *** salv-orlando has quit IRC | 02:11 | |
| *** Marga_ has quit IRC | 02:13 | |
| *** patrickeast has quit IRC | 02:15 | |
| *** vmtrooper has joined #openstack-nova | 02:17 | |
| *** jyuso1 has joined #openstack-nova | 02:21 | |
| *** vmtrooper has quit IRC | 02:22 | |
| *** erkules_ has joined #openstack-nova | 02:22 | |
| *** baoli has quit IRC | 02:23 | |
| *** baoli has joined #openstack-nova | 02:24 | |
| *** unicell has quit IRC | 02:25 | |
| *** erkules has quit IRC | 02:25 | |
| *** coolsvap|afk is now known as coolsvap | 02:27 | |
| *** achanda has joined #openstack-nova | 02:27 | |
| *** yingjun has quit IRC | 02:31 | |
| *** sdake__ has quit IRC | 02:32 | |
| *** kaisers1 has joined #openstack-nova | 02:34 | |
| *** kaisers has quit IRC | 02:35 | |
| *** hemna has joined #openstack-nova | 02:35 | |
| *** yingjun has joined #openstack-nova | 02:35 | |
| *** iamjarvo has joined #openstack-nova | 02:37 | |
| *** krtaylor has quit IRC | 02:38 | |
| *** Anticimex has quit IRC | 02:42 | |
| *** haomaiwang has joined #openstack-nova | 02:43 | |
| *** ajayaa has quit IRC | 02:43 | |
| *** krtaylor has joined #openstack-nova | 02:50 | |
| *** achanda has quit IRC | 02:52 | |
| *** gokrokve has quit IRC | 02:56 | |
| *** gokrokve has joined #openstack-nova | 02:57 | |
| *** gokrokve has quit IRC | 02:57 | |
| *** tonytan4ever has joined #openstack-nova | 02:58 | |
| *** melwitt has quit IRC | 02:58 | |
| *** jecarey has joined #openstack-nova | 02:59 | |
| *** dkliban is now known as dkliban_afk | 03:00 | |
| *** yingjun has quit IRC | 03:00 | |
| *** dims has joined #openstack-nova | 03:04 | |
| *** dsanders has joined #openstack-nova | 03:05 | |
| *** popw has quit IRC | 03:10 | |
| *** salv-orlando has joined #openstack-nova | 03:11 | |
| *** dims has quit IRC | 03:11 | |
| *** boris-42 has quit IRC | 03:12 | |
| *** harlowja is now known as harlowja_away | 03:15 | |
| *** vivekd has joined #openstack-nova | 03:16 | |
| *** ajayaa has joined #openstack-nova | 03:17 | |
| *** yingjun has joined #openstack-nova | 03:18 | |
| *** popw has joined #openstack-nova | 03:19 | |
| *** otter768 has quit IRC | 03:20 | |
| *** zzzeek has joined #openstack-nova | 03:22 | |
| *** zzzeek has quit IRC | 03:22 | |
| *** ajayaa has quit IRC | 03:25 | |
| *** gokrokve has joined #openstack-nova | 03:25 | |
| *** gokrokve has quit IRC | 03:27 | |
| *** sluo_wfh is now known as sluo_laptop | 03:28 | |
| *** markvoelker has quit IRC | 03:29 | |
| *** ajayaa has joined #openstack-nova | 03:29 | |
| openstackgerrit | Fei Long Wang proposed openstack/nova: Fix nova backup for volume-backed instance https://review.openstack.org/164494 | 03:30 |
| *** gokrokve has joined #openstack-nova | 03:31 | |
| *** VW_ has joined #openstack-nova | 03:33 | |
| *** david-lyle is now known as david-lyle_afk | 03:35 | |
| *** neelashah has quit IRC | 03:38 | |
| *** rushiagr_away is now known as rushiagr | 03:39 | |
| *** Alexandra_ has joined #openstack-nova | 03:39 | |
| *** mitz has quit IRC | 03:40 | |
| *** asettle has quit IRC | 03:41 | |
| *** shyama has joined #openstack-nova | 03:42 | |
| *** eharney has quit IRC | 03:46 | |
| *** coolsvap is now known as coolsvap|afk | 03:48 | |
| *** penick has joined #openstack-nova | 03:48 | |
| *** dsanders has quit IRC | 03:49 | |
| *** vmtrooper has joined #openstack-nova | 03:49 | |
| *** Alexandra_ is now known as asettle | 03:50 | |
| *** yingjun has quit IRC | 03:51 | |
| *** Anticimex has joined #openstack-nova | 03:52 | |
| *** flwang has quit IRC | 03:52 | |
| *** vladikr has quit IRC | 03:55 | |
| *** coolsvap|afk is now known as coolsvap | 03:55 | |
| openstackgerrit | Tim Pownall proposed openstack/nova: Updated _create_vm_record and _attach_disks to pull vm_mode and auto_disk_config values from the image_ref during rescue mode. https://review.openstack.org/164940 | 03:56 |
| *** Longgeek has quit IRC | 03:59 | |
| *** rushiagr is now known as rushiagr_away | 04:00 | |
| *** achanda has joined #openstack-nova | 04:01 | |
| *** baoli has quit IRC | 04:02 | |
| *** signed8b_ has joined #openstack-nova | 04:03 | |
| *** dave-mccowan has quit IRC | 04:07 | |
| *** hemna has quit IRC | 04:09 | |
| *** iamjarvo has quit IRC | 04:17 | |
| *** salv-orlando has quit IRC | 04:23 | |
| *** annashen has quit IRC | 04:25 | |
| *** annashen has joined #openstack-nova | 04:27 | |
| *** ajayaa has quit IRC | 04:31 | |
| *** mitz has joined #openstack-nova | 04:34 | |
| *** baoli has joined #openstack-nova | 04:35 | |
| *** vmtrooper has quit IRC | 04:37 | |
| *** rushiagr_away is now known as rushiagr | 04:39 | |
| *** baoli has quit IRC | 04:40 | |
| *** baoli has joined #openstack-nova | 04:40 | |
| *** baoli has quit IRC | 04:40 | |
| *** oomichi has joined #openstack-nova | 04:41 | |
| *** oomichi has quit IRC | 04:41 | |
| *** achanda has quit IRC | 04:46 | |
| *** annashen has quit IRC | 04:47 | |
| *** achanda has joined #openstack-nova | 04:49 | |
| *** achanda has quit IRC | 04:49 | |
| *** dboik_ has quit IRC | 04:49 | |
| *** ajayaa has joined #openstack-nova | 04:50 | |
| *** VW_ has quit IRC | 04:54 | |
| *** pradipta has joined #openstack-nova | 04:57 | |
| *** Marga_ has joined #openstack-nova | 04:58 | |
| *** Longgeek has joined #openstack-nova | 04:59 | |
| *** annashen has joined #openstack-nova | 05:00 | |
| *** baoli has joined #openstack-nova | 05:01 | |
| *** baoli has quit IRC | 05:01 | |
| *** Marga_ has quit IRC | 05:04 | |
| *** Longgeek has quit IRC | 05:04 | |
| *** ybathia has joined #openstack-nova | 05:05 | |
| *** emagana has joined #openstack-nova | 05:10 | |
| *** exploreshaifali has joined #openstack-nova | 05:12 | |
| *** unicell has joined #openstack-nova | 05:13 | |
| *** gokrokve_ has joined #openstack-nova | 05:15 | |
| *** yingjun has joined #openstack-nova | 05:16 | |
| *** annashen has quit IRC | 05:17 | |
| *** gokrokve has quit IRC | 05:18 | |
| *** deepthi has joined #openstack-nova | 05:18 | |
| *** gokrokve_ has quit IRC | 05:19 | |
| *** salv-orlando has joined #openstack-nova | 05:20 | |
| *** otter768 has joined #openstack-nova | 05:21 | |
| *** otter768 has quit IRC | 05:26 | |
| *** annashen has joined #openstack-nova | 05:28 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Deassociate before delete network in os-tenant-networks delete method https://review.openstack.org/164563 | 05:29 |
| openstackgerrit | Alex Xu proposed openstack/nova: Pass project_id when create networks by os-tenant-networks https://review.openstack.org/164549 | 05:29 |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for network_create_safe https://review.openstack.org/161626 | 05:29 |
| *** exploreshaifali has quit IRC | 05:30 | |
| *** unicell1 has joined #openstack-nova | 05:37 | |
| *** unicell has quit IRC | 05:37 | |
| *** dsanders has joined #openstack-nova | 05:40 | |
| *** yamahata has joined #openstack-nova | 05:49 | |
| *** Nikolay_St has quit IRC | 05:49 | |
| *** vivekd has quit IRC | 05:50 | |
| *** rushiagr is now known as rushiagr_away | 05:51 | |
| *** eliqiao has quit IRC | 05:53 | |
| *** ishant|2 has joined #openstack-nova | 05:53 | |
| *** ishant|2 has quit IRC | 05:54 | |
| *** ishant has joined #openstack-nova | 05:54 | |
| *** dsanders has quit IRC | 05:56 | |
| *** asettle has quit IRC | 05:59 | |
| *** oro has joined #openstack-nova | 06:01 | |
| *** Longgeek has joined #openstack-nova | 06:01 | |
| *** oro_ has joined #openstack-nova | 06:01 | |
| *** baoli has joined #openstack-nova | 06:02 | |
| *** baoli has quit IRC | 06:06 | |
| *** eliqiao has joined #openstack-nova | 06:06 | |
| openstackgerrit | Vincent Hou proposed openstack/nova: Add attach_status check before detaching a volume https://review.openstack.org/164951 | 06:07 |
| *** yingjun has quit IRC | 06:08 | |
| *** tonytan4ever has quit IRC | 06:11 | |
| *** tonytan4ever has joined #openstack-nova | 06:11 | |
| *** lpetrut has joined #openstack-nova | 06:11 | |
| *** Marga_ has joined #openstack-nova | 06:12 | |
| openstackgerrit | yunhong-jiang proposed openstack/nova: Use VirtCPUModel in compute resource tracker. https://review.openstack.org/148139 | 06:13 |
| openstackgerrit | yunhong-jiang proposed openstack/nova: Use cpu model object in virt driver https://review.openstack.org/148368 | 06:13 |
| *** oro_ has quit IRC | 06:14 | |
| *** Marga_ has quit IRC | 06:15 | |
| *** oro has quit IRC | 06:15 | |
| *** tonytan4ever has quit IRC | 06:15 | |
| *** Marga_ has joined #openstack-nova | 06:15 | |
| *** annashen has quit IRC | 06:18 | |
| *** mtanino has quit IRC | 06:21 | |
| *** Maike has joined #openstack-nova | 06:25 | |
| *** vmtrooper has joined #openstack-nova | 06:26 | |
| *** achanda has joined #openstack-nova | 06:26 | |
| *** dboik has joined #openstack-nova | 06:29 | |
| *** vmtrooper has quit IRC | 06:31 | |
| openstackgerrit | Vincent Hou proposed openstack/nova: Add attach_status check before detaching a volume https://review.openstack.org/164951 | 06:31 |
| *** baoli has joined #openstack-nova | 06:32 | |
| *** baoli has quit IRC | 06:32 | |
| *** baoli has joined #openstack-nova | 06:33 | |
| *** baoli has quit IRC | 06:33 | |
| openstackgerrit | Vincent Hou proposed openstack/nova: Add attach_status check before detaching a volume https://review.openstack.org/164951 | 06:34 |
| *** eliqiao has quit IRC | 06:34 | |
| *** signed8b_ has quit IRC | 06:34 | |
| *** Longgeek has quit IRC | 06:35 | |
| *** Longgeek has joined #openstack-nova | 06:35 | |
| *** nkrinner has joined #openstack-nova | 06:36 | |
| *** eliqiao has joined #openstack-nova | 06:38 | |
| *** gokrokve has joined #openstack-nova | 06:41 | |
| *** sdake has joined #openstack-nova | 06:44 | |
| *** hanzhang has quit IRC | 06:44 | |
| *** salv-orlando has quit IRC | 06:44 | |
| *** hanzhang has joined #openstack-nova | 06:45 | |
| *** ajayaa has quit IRC | 06:46 | |
| *** ajayaa has joined #openstack-nova | 06:46 | |
| *** unicell1 has quit IRC | 06:47 | |
| openstackgerrit | Zhenguo Niu proposed openstack/nova: Put the snapshot task states in correct order https://review.openstack.org/164968 | 06:48 |
| *** sdake has quit IRC | 06:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/162030 | 06:49 |
| *** unicell has joined #openstack-nova | 06:51 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Add api microvesion unit test case for wsgi.action https://review.openstack.org/141973 | 06:52 |
| *** browne has quit IRC | 06:52 | |
| *** yamahata has quit IRC | 06:53 | |
| *** yamahata has joined #openstack-nova | 06:53 | |
| *** romainh has joined #openstack-nova | 06:55 | |
| *** ferest has joined #openstack-nova | 06:57 | |
| *** unicell has quit IRC | 06:58 | |
| *** nkrinner has quit IRC | 06:59 | |
| *** nkrinner has joined #openstack-nova | 06:59 | |
| *** exploreshaifali has joined #openstack-nova | 07:00 | |
| *** mrda is now known as mrda-away | 07:00 | |
| *** unicell has joined #openstack-nova | 07:02 | |
| *** gokrokve has quit IRC | 07:02 | |
| *** tdurakov_ has joined #openstack-nova | 07:02 | |
| *** tdurakov has left #openstack-nova | 07:02 | |
| *** gokrokve has joined #openstack-nova | 07:02 | |
| *** markvoelker has joined #openstack-nova | 07:04 | |
| *** tdurakov_ has quit IRC | 07:04 | |
| *** sahid has joined #openstack-nova | 07:05 | |
| *** gokrokve has quit IRC | 07:07 | |
| *** markvoelker has quit IRC | 07:08 | |
| *** ferest has quit IRC | 07:09 | |
| *** rajesht has joined #openstack-nova | 07:10 | |
| rajesht | dansmith: you around ? | 07:10 |
| *** emagana has quit IRC | 07:14 | |
| openstackgerrit | Joshua Hesketh proposed openstack/nova: Add pip-check-reqs tox environment https://review.openstack.org/164973 | 07:16 |
| *** kashyapc has joined #openstack-nova | 07:18 | |
| *** tdurakov has joined #openstack-nova | 07:19 | |
| *** yamahata has quit IRC | 07:20 | |
| *** otter768 has joined #openstack-nova | 07:22 | |
| *** lpetrut has left #openstack-nova | 07:24 | |
| *** afazekas has joined #openstack-nova | 07:25 | |
| rajesht | jogo: you around ? | 07:25 |
| *** otter768 has quit IRC | 07:27 | |
| *** exploreshaifali has quit IRC | 07:28 | |
| *** achanda has quit IRC | 07:31 | |
| *** TobiasE has joined #openstack-nova | 07:32 | |
| *** baoli has joined #openstack-nova | 07:34 | |
| *** Marga_ has quit IRC | 07:34 | |
| *** baoli has quit IRC | 07:38 | |
| *** mpavone has joined #openstack-nova | 07:41 | |
| *** ajayaa has quit IRC | 07:46 | |
| *** armax has quit IRC | 07:48 | |
| openstackgerrit | Zhenguo Niu proposed openstack/nova: Replace duplicate codes with an existing function https://review.openstack.org/164977 | 07:48 |
| *** Maike has quit IRC | 07:49 | |
| *** sahid has quit IRC | 07:55 | |
| *** ybathia has quit IRC | 07:56 | |
| openstackgerrit | Tobias Engelbert proposed openstack/nova: REST API changes to support multiple volume attach https://review.openstack.org/153038 | 07:57 |
| openstackgerrit | Vincent Hou proposed openstack/nova: Add attach_status check before detaching a volume https://review.openstack.org/164951 | 07:57 |
| *** ybathia has joined #openstack-nova | 08:00 | |
| *** markus_z has joined #openstack-nova | 08:01 | |
| *** oomichi_ has joined #openstack-nova | 08:02 | |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: enforce domain:update/delete policy for floating_ip_dns v2.1 REST API layer. https://review.openstack.org/160237 | 08:02 |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for floating_ip_dns https://review.openstack.org/150710 | 08:02 |
| *** haomaiwang has quit IRC | 08:03 | |
| *** haomaiwa_ has joined #openstack-nova | 08:04 | |
| *** erkules_ is now known as erkuls | 08:04 | |
| *** pask81 has joined #openstack-nova | 08:05 | |
| *** markvoelker has joined #openstack-nova | 08:05 | |
| *** erkuls is now known as erkules | 08:05 | |
| *** erkules has quit IRC | 08:05 | |
| *** erkules has joined #openstack-nova | 08:05 | |
| *** markvoelker has quit IRC | 08:10 | |
| *** ybathia has quit IRC | 08:10 | |
| *** ybathia has joined #openstack-nova | 08:11 | |
| *** irenab_ has joined #openstack-nova | 08:15 | |
| *** vmtrooper has joined #openstack-nova | 08:15 | |
| *** irenab has quit IRC | 08:16 | |
| *** irenab_ is now known as irenab | 08:16 | |
| *** kaisers1 has quit IRC | 08:18 | |
| *** vmtrooper has quit IRC | 08:21 | |
| *** yingjun has joined #openstack-nova | 08:22 | |
| *** vivekd has joined #openstack-nova | 08:27 | |
| *** park_ has joined #openstack-nova | 08:28 | |
| *** Nikolay_St has joined #openstack-nova | 08:28 | |
| *** ajayaa has joined #openstack-nova | 08:28 | |
| *** dulek has joined #openstack-nova | 08:30 | |
| *** salv-orlando has joined #openstack-nova | 08:31 | |
| *** exploreshaifali has joined #openstack-nova | 08:34 | |
| *** baoli has joined #openstack-nova | 08:35 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add a hacking rule for consistent HTTP501 message https://review.openstack.org/163698 | 08:36 |
| *** hanzhang has quit IRC | 08:37 | |
| *** baoli has quit IRC | 08:39 | |
| *** apuimedo has joined #openstack-nova | 08:41 | |
| *** dims has joined #openstack-nova | 08:42 | |
| *** jlanoux has joined #openstack-nova | 08:46 | |
| *** ildikov has joined #openstack-nova | 08:47 | |
| *** dims has quit IRC | 08:48 | |
| *** matrohon has joined #openstack-nova | 08:49 | |
| *** TobiasE1 has joined #openstack-nova | 08:52 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Removed unused variables, methods and classes https://review.openstack.org/164666 | 08:52 |
| *** andreykurilin_ has joined #openstack-nova | 08:53 | |
| *** sahid has joined #openstack-nova | 08:54 | |
| *** TobiasE has quit IRC | 08:54 | |
| *** Nikolay_St has quit IRC | 08:57 | |
| *** pradipta has quit IRC | 08:59 | |
| *** boris-42 has joined #openstack-nova | 08:59 | |
| *** royce has joined #openstack-nova | 09:00 | |
| *** ajayaa has quit IRC | 09:01 | |
| openstackgerrit | Vincent Hou proposed openstack/nova: Add attach_status check before detaching a volume https://review.openstack.org/164951 | 09:01 |
| *** lpetrut has joined #openstack-nova | 09:03 | |
| *** ybathia has quit IRC | 09:03 | |
| *** ajayaa has joined #openstack-nova | 09:03 | |
| *** jistr has joined #openstack-nova | 09:04 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused oslo logging fixture https://review.openstack.org/164988 | 09:04 |
| *** dulek has quit IRC | 09:05 | |
| *** royce has quit IRC | 09:05 | |
| *** jcoufal has joined #openstack-nova | 09:05 | |
| *** Nikolay_St has joined #openstack-nova | 09:06 | |
| *** markvoelker has joined #openstack-nova | 09:06 | |
| eliqiao | hi oomichi_: | 09:07 |
| oomichi_ | eliqiao: hi | 09:08 |
| eliqiao | oomichi_: it's about https://review.openstack.org/#/c/150350/10/nova/api/openstack/compute/contrib/cells.py | 09:08 |
| eliqiao | oomichi_: I'v update the comments. | 09:08 |
| eliqiao | oomichi_: can you please correct me if I was wrong? | 09:09 |
| oomichi_ | eliqiao: thanks for updating. ok, will see it later carefully | 09:10 |
| *** eglynn-pto has joined #openstack-nova | 09:11 | |
| eliqiao | oomichi_: thanks in advance. :) feel free to correct on me, I'd like to listen | 09:11 |
| *** markvoelker has quit IRC | 09:11 | |
| *** mpavone has quit IRC | 09:12 | |
| *** zz_johnthetubagu is now known as johnthetubaguy | 09:14 | |
| gilliard | oomichi_: Hi. Do you know why the json-home spec isn't being rendered into html by the docs job? | 09:17 |
| gilliard | The output of the docs job for https://review.openstack.org/#/c/130715/ is just http://docs-draft.openstack.org/15/130715/15/check/gate-nova-specs-docs/07730e2//doc/build/html/specs/liberty/index.html | 09:17 |
| oomichi_ | gilliard: oh, I notice it now. | 09:18 |
| gilliard | I find it easier to review specs in html, but this one isn't showing up :( It's the first Liberty spec? | 09:19 |
| *** annashen has joined #openstack-nova | 09:19 | |
| *** apuimedo has quit IRC | 09:19 | |
| oomichi_ | gilliard: maybe I need to check Liberty's template. I just updated json-home spec by changing spec directory. | 09:20 |
| gilliard | OK I'm looking into it too, hopefully it's a quick/simple change | 09:20 |
| oomichi_ | gilliard: thanks so much :-) | 09:21 |
| *** salv-orlando has quit IRC | 09:21 | |
| *** kaisers has joined #openstack-nova | 09:21 | |
| *** salv-orlando has joined #openstack-nova | 09:21 | |
| *** otter768 has joined #openstack-nova | 09:23 | |
| gilliard | So, in Kilo, the specs are split into "approved" and "implemented". Is there a 3rd category like "proposed"/ | 09:23 |
| gilliard | ? | 09:23 |
| *** annashen has quit IRC | 09:23 | |
| oomichi_ | gilliard: "proposed" seems unnecessary because the approved specs only are stored into "approved" on the master repo. | 09:25 |
| gilliard | OK so there's a wildcard missing from index.rst I'll put a patch up in a minute... | 09:26 |
| oomichi_ | gilliard: ah, nice | 09:26 |
| *** apuimedo has joined #openstack-nova | 09:27 | |
| *** mpavone has joined #openstack-nova | 09:27 | |
| *** otter768 has quit IRC | 09:27 | |
| openstackgerrit | Julien Danjou proposed openstack/nova: simple_tenant_usage: leverage timeutils, drop strtime() https://review.openstack.org/164753 | 09:29 |
| openstackgerrit | Julien Danjou proposed openstack/nova: Stop using exception.message https://review.openstack.org/164752 | 09:30 |
| *** krykowski has joined #openstack-nova | 09:32 | |
| *** park_ has quit IRC | 09:32 | |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_destroy https://review.openstack.org/160257 | 09:33 |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_create https://review.openstack.org/150718 | 09:33 |
| *** yingjun has quit IRC | 09:33 | |
| openstackgerrit | Romain Hardouin proposed openstack/nova-specs: Refresh quotas usage https://review.openstack.org/161782 | 09:34 |
| *** lpetrut has quit IRC | 09:35 | |
| *** shyama has left #openstack-nova | 09:35 | |
| eliqiao | ping | 09:36 |
| eliqiao | sorry, mistake ping.. | 09:36 |
| *** rushiagr_away is now known as rushiagr | 09:39 | |
| oomichi_ | mikal, cyeoh: hi | 09:40 |
| oomichi_ | mikal, cyeoh: can you take a look at https://review.openstack.org/#/c/163697/ ? that is trying to make error messages consistent | 09:41 |
| oomichi_ | mikal, cyeoh: maybe it would keep v2.1+ consistent in long term. | 09:42 |
| *** ZZelle has joined #openstack-nova | 09:43 | |
| *** exploreshaifali has quit IRC | 09:45 | |
| *** eliqiao has quit IRC | 09:46 | |
| *** markus_z has quit IRC | 09:47 | |
| *** mpavone has quit IRC | 09:47 | |
| *** markus_z has joined #openstack-nova | 09:47 | |
| *** mpavone has joined #openstack-nova | 09:48 | |
| *** andreykurilin_ has quit IRC | 09:48 | |
| *** dims has joined #openstack-nova | 09:50 | |
| *** lpetrut has joined #openstack-nova | 09:53 | |
| *** andreykurilin_ has joined #openstack-nova | 09:56 | |
| mikal | oomichi_: I will add it to my list for tomorrow | 09:58 |
| oomichi_ | mikal: thanks :-) | 09:58 |
| *** oro has joined #openstack-nova | 09:59 | |
| *** igordcard_ has joined #openstack-nova | 09:59 | |
| *** andreykurilin_ has quit IRC | 10:01 | |
| openstackgerrit | Mike Durnosvistov proposed openstack/nova: libvirt: Resize down an instance booted from a volume https://review.openstack.org/152964 | 10:02 |
| openstackgerrit | Mike Durnosvistov proposed openstack/nova: libvirt: don't allow to resize down the default ephemeral disk https://review.openstack.org/158646 | 10:02 |
| *** mpavone has quit IRC | 10:03 | |
| *** oro has quit IRC | 10:04 | |
| *** vmtrooper has joined #openstack-nova | 10:04 | |
| *** mpavone has joined #openstack-nova | 10:06 | |
| *** TobiasE1 has quit IRC | 10:06 | |
| *** TobiasE has joined #openstack-nova | 10:07 | |
| *** markvoelker has joined #openstack-nova | 10:07 | |
| *** claudiub has joined #openstack-nova | 10:08 | |
| *** vmtrooper has quit IRC | 10:09 | |
| *** markvoelker has quit IRC | 10:12 | |
| *** pkoniszewski has joined #openstack-nova | 10:14 | |
| openstackgerrit | Julien Danjou proposed openstack/nova: simple_tenant_usage: leverage timeutils, drop strtime() https://review.openstack.org/164753 | 10:28 |
| *** popw has quit IRC | 10:29 | |
| *** dulek has joined #openstack-nova | 10:30 | |
| *** achanda has joined #openstack-nova | 10:31 | |
| *** claudiub has quit IRC | 10:32 | |
| openstackgerrit | Matthew Gilliard proposed openstack/nova-specs: Adds "approved" list of Liberty specs https://review.openstack.org/165016 | 10:32 |
| *** sahid has quit IRC | 10:33 | |
| *** hanzhang has joined #openstack-nova | 10:34 | |
| *** Maike has joined #openstack-nova | 10:34 | |
| *** exploreshaifali has joined #openstack-nova | 10:34 | |
| gilliard | oomichi_: If you think ^^ is correct, maybe you want to change the order of the dependency? I'd like johnthetubaguy to confirm that it's right first, tbh. | 10:34 |
| *** pask81 has quit IRC | 10:35 | |
| *** sahid has joined #openstack-nova | 10:35 | |
| *** lpetrut has quit IRC | 10:36 | |
| openstackgerrit | Julien Danjou proposed openstack/nova: simple_tenant_usage: leverage timeutils, drop strtime() https://review.openstack.org/164753 | 10:36 |
| openstackgerrit | Julien Danjou proposed openstack/nova: simple_tenant_usage: declare method static https://review.openstack.org/165017 | 10:36 |
| *** achanda has quit IRC | 10:36 | |
| *** pask81 has joined #openstack-nova | 10:38 | |
| *** xylan has quit IRC | 10:40 | |
| *** exploreshaifali has quit IRC | 10:41 | |
| *** haomaiwa_ has quit IRC | 10:44 | |
| *** VW_ has joined #openstack-nova | 10:44 | |
| *** ajayaa has quit IRC | 10:51 | |
| oomichi_ | gilliard: thanks for doing that. you are right, and will move the json-home spec as your patch. | 10:52 |
| *** coolsvap is now known as coolsvap|afk | 10:53 | |
| gilliard | oomichi_: Welcome. You can read your spec at http://docs-draft.openstack.org/16/165016/1/check/gate-nova-specs-docs/9ed2e80//doc/build/html/specs/liberty/approved/nova-api-json-home.html now :) | 10:53 |
| oomichi_ | gilliard: great, maybe a part of index.rst is still necessary on your patch. | 10:56 |
| *** rushiagr is now known as rushiagr_away | 10:56 | |
| oomichi_ | gilliard: for nova-spec repo. | 10:56 |
| gilliard | oomichi_: for "implemented" ? | 10:56 |
| *** rushiagr_away is now known as rushiagr | 10:57 | |
| oomichi_ | gilliard: https://review.openstack.org/#/c/165016/1/doc/source/specs/liberty/index.rst | 10:57 |
| *** deepthi has quit IRC | 10:57 | |
| openstackgerrit | Sean Dague proposed openstack/nova: remove v3 api from paste configuration https://review.openstack.org/161221 | 10:57 |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_destroy https://review.openstack.org/160257 | 10:58 |
| openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_create https://review.openstack.org/150718 | 10:58 |
| gilliard | oomichi_: I don't follow you, sorry. | 10:58 |
| oomichi_ | gilliard: your patch changes index.rst also, and json-home spec patch seems unnecessary to include it. | 10:59 |
| *** shadyabh1 has quit IRC | 11:00 | |
| oomichi_ | gilliard: so I feel another patch is necessary for index.rst change. | 11:00 |
| *** shadyabhi has joined #openstack-nova | 11:00 | |
| *** Bsony has joined #openstack-nova | 11:00 | |
| *** Bsony has quit IRC | 11:00 | |
| *** Bsony has joined #openstack-nova | 11:01 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova-specs: Add JSON-Home support for API path discovery https://review.openstack.org/130715 | 11:01 |
| oomichi_ | gilliard: your comment is applied to ^^^. thanks :) | 11:02 |
| gilliard | Cool. If I add a patch which _only_ changes index.rst, you could make yours depend on that one. | 11:03 |
| *** Maike_ has joined #openstack-nova | 11:03 | |
| *** Maike__ has joined #openstack-nova | 11:04 | |
| *** Maike has quit IRC | 11:04 | |
| openstackgerrit | Matthew Gilliard proposed openstack/nova-specs: Adds "approved" list of Liberty specs https://review.openstack.org/165016 | 11:04 |
| gilliard | oomichi_: I mean, rebase yours on top of that one ^^ | 11:05 |
| *** pixelb has joined #openstack-nova | 11:07 | |
| oomichi_ | gilliard: ah, I see. +1 for that. will rebase soon | 11:07 |
| *** Maike_ has quit IRC | 11:08 | |
| *** markvoelker has joined #openstack-nova | 11:08 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova-specs: Add JSON-Home support for API path discovery https://review.openstack.org/130715 | 11:08 |
| *** yingjun has joined #openstack-nova | 11:08 | |
| *** krykowski has quit IRC | 11:08 | |
| gilliard | :( docs job doesn't like a directory with no specs in it :( | 11:09 |
| oomichi_ | gilliard: some dummy file or something is necessary. | 11:09 |
| oomichi_ | gilliard: yea | 11:09 |
| *** Maike_ has joined #openstack-nova | 11:12 | |
| *** lpetrut has joined #openstack-nova | 11:12 | |
| openstackgerrit | Matthew Gilliard proposed openstack/nova-specs: Adds "approved" list of Liberty specs https://review.openstack.org/165016 | 11:12 |
| *** TobiasE has quit IRC | 11:13 | |
| *** markvoelker has quit IRC | 11:14 | |
| *** Maike__ has quit IRC | 11:14 | |
| *** pixelb has quit IRC | 11:15 | |
| *** Maike__ has joined #openstack-nova | 11:15 | |
| *** krykowski has joined #openstack-nova | 11:17 | |
| *** claudiub has joined #openstack-nova | 11:17 | |
| *** Maike_ has quit IRC | 11:19 | |
| openstackgerrit | Matthew Gilliard proposed openstack/nova-specs: Adds "approved" list of Liberty specs https://review.openstack.org/165016 | 11:21 |
| openstackgerrit | Matthew Gilliard proposed openstack/nova-specs: Adds "approved" list of Liberty specs https://review.openstack.org/165016 | 11:24 |
| *** IanGovett has joined #openstack-nova | 11:24 | |
| gilliard | oomichi_: so fiddly :( | 11:24 |
| *** otter768 has joined #openstack-nova | 11:24 | |
| gilliard | honestly I did want to review the json-home spec, but there was this yak, and i had a razor and... | 11:26 |
| *** otter768 has quit IRC | 11:28 | |
| *** Marga_ has joined #openstack-nova | 11:29 | |
| shaohe_feng | dansmith: hi, do you know how to avoid lazy load in db object? now there is a loop in my two objects. | 11:36 |
| *** markvoelker has joined #openstack-nova | 11:38 | |
| openstackgerrit | Paul Murray proposed openstack/nova: Convert RT compute_node to be a ComputeNode object https://review.openstack.org/160942 | 11:39 |
| openstackgerrit | Paul Murray proposed openstack/nova: Add nova object equivalence and ComputeNode changes https://review.openstack.org/165037 | 11:39 |
| sdague | oomichi_: interesting fact, running existing api samples tests against v21 as v2 don't pass | 11:42 |
| sdague | oomichi_: would you be able to dive into that one so we could make that change to default policy? | 11:43 |
| oomichi_ | sdague: interesting, I'd like to dig it. can you provide some URLs or something for that? | 11:44 |
| sdague | I can push my failing patch if you like | 11:44 |
| sdague | I'm not going to be able to chase that one down before the freeze | 11:44 |
| oomichi_ | sdague: ok, please push it to me ;) | 11:45 |
| *** baoli has joined #openstack-nova | 11:45 | |
| *** mtanino has joined #openstack-nova | 11:46 | |
| *** baoli has quit IRC | 11:47 | |
| *** baoli has joined #openstack-nova | 11:47 | |
| *** VW_ has quit IRC | 11:48 | |
| *** igordcard has quit IRC | 11:48 | |
| *** igordcard has joined #openstack-nova | 11:49 | |
| *** dave-mccowan has joined #openstack-nova | 11:50 | |
| *** baoli has quit IRC | 11:50 | |
| *** vmtrooper has joined #openstack-nova | 11:53 | |
| *** flwang1 has quit IRC | 11:53 | |
| *** exploreshaifali has joined #openstack-nova | 11:53 | |
| *** flwang has joined #openstack-nova | 11:56 | |
| openstackgerrit | wuhao proposed openstack/nova-specs: Add previous page links for Nova GET servers API https://review.openstack.org/165041 | 11:56 |
| *** Longgeek has quit IRC | 11:58 | |
| *** vmtrooper has quit IRC | 11:58 | |
| *** dprince has joined #openstack-nova | 12:01 | |
| *** subscope has quit IRC | 12:02 | |
| *** rushiagr is now known as rushiagr_away | 12:04 | |
| *** coolsvap|afk is now known as coolsvap | 12:04 | |
| *** ajayaa has joined #openstack-nova | 12:05 | |
| *** oomichi_ has quit IRC | 12:06 | |
| *** apuimedo has quit IRC | 12:13 | |
| *** htruta has joined #openstack-nova | 12:13 | |
| *** oro has joined #openstack-nova | 12:14 | |
| *** subscope has joined #openstack-nova | 12:14 | |
| *** jcru has joined #openstack-nova | 12:16 | |
| *** yingjun has quit IRC | 12:16 | |
| *** dims has quit IRC | 12:16 | |
| *** dims has joined #openstack-nova | 12:17 | |
| *** TobiasE has joined #openstack-nova | 12:19 | |
| *** jaypipes has joined #openstack-nova | 12:20 | |
| *** jcru has quit IRC | 12:20 | |
| dims | gilliard: hahaha | 12:21 |
| *** aysyd has joined #openstack-nova | 12:22 | |
| *** eliqiao has joined #openstack-nova | 12:24 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Objects: use setattr rather than dict syntax in remotable https://review.openstack.org/163974 | 12:24 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add CellMapping object https://review.openstack.org/161867 | 12:24 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Test fixture for the api database https://review.openstack.org/164794 | 12:24 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Split out NovaTimestampObject https://review.openstack.org/163605 | 12:24 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add InstanceMapping object https://review.openstack.org/161904 | 12:25 |
| *** jistr is now known as jistr|class | 12:26 | |
| *** salv-orlando has quit IRC | 12:30 | |
| *** Maike__ has quit IRC | 12:31 | |
| eliqiao | hi alski: around? | 12:31 |
| *** Maike has joined #openstack-nova | 12:31 | |
| *** adalbas has joined #openstack-nova | 12:32 | |
| *** exploreshaifali has quit IRC | 12:33 | |
| *** shaohe_feng1 has quit IRC | 12:34 | |
| eliqiao | hi alaski: around? | 12:35 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Objects: use setattr rather than dict syntax in remotable https://review.openstack.org/163974 | 12:35 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add CellMapping object https://review.openstack.org/161867 | 12:35 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Test fixture for the api database https://review.openstack.org/164794 | 12:35 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Split out NovaTimestampObject https://review.openstack.org/163605 | 12:35 |
| alaski | eliqiao: yes | 12:35 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add InstanceMapping object https://review.openstack.org/161904 | 12:36 |
| eliqiao | alaski: great, you are there, can you help to take a look at https://review.openstack.org/#/c/150350/ , it is a cell api related changes. | 12:36 |
| alaski | eliqiao: sure, I'll look through it | 12:37 |
| *** TobiasE has quit IRC | 12:37 | |
| eliqiao | alaski: thanks :) | 12:37 |
| hanzhang | who can help me review this patch:https://review.openstack.org/#/c/161641/ | 12:38 |
| *** pkoniszewski has quit IRC | 12:41 | |
| *** adalbas has quit IRC | 12:41 | |
| *** Marga_ has quit IRC | 12:42 | |
| *** flwang has quit IRC | 12:45 | |
| *** toan-tran has joined #openstack-nova | 12:45 | |
| *** Marga_ has joined #openstack-nova | 12:46 | |
| *** dkliban_afk is now known as dkliban | 12:48 | |
| *** flwang has joined #openstack-nova | 12:48 | |
| *** toan-tran has quit IRC | 12:48 | |
| *** toan-tran has joined #openstack-nova | 12:48 | |
| *** rushiagr_away is now known as rushiagr | 12:49 | |
| *** vladikr has joined #openstack-nova | 12:52 | |
| *** exploreshaifali has joined #openstack-nova | 12:52 | |
| *** adalbas has joined #openstack-nova | 12:53 | |
| *** eliqiao has quit IRC | 12:53 | |
| openstackgerrit | Sean Dague proposed openstack/nova: expose v21 as /v2 endpoint in sample paste.ini https://review.openstack.org/165053 | 12:54 |
| *** nelsnels_ has quit IRC | 12:55 | |
| *** oro_ has joined #openstack-nova | 12:56 | |
| *** obutenko_ has quit IRC | 12:58 | |
| *** mriedem_away is now known as mriedem | 12:58 | |
| *** obutenko has quit IRC | 12:58 | |
| *** toan-tran has left #openstack-nova | 12:59 | |
| *** salv-orlando has joined #openstack-nova | 13:00 | |
| *** jecarey has quit IRC | 13:02 | |
| *** TobiasE has joined #openstack-nova | 13:04 | |
| sdague | jaypipes: ok, so I remain confused about something around the limits here. Maybe in a bit you can help me understand the piece I'm missing. | 13:04 |
| openstackgerrit | garyk proposed openstack/nova: VMware: add in folder support on VC https://review.openstack.org/165060 | 13:07 |
| *** amotoki has joined #openstack-nova | 13:09 | |
| *** igordcard_ has quit IRC | 13:10 | |
| *** ijw has joined #openstack-nova | 13:11 | |
| *** ijw has quit IRC | 13:11 | |
| *** sahid has quit IRC | 13:11 | |
| obondarev | jaypipes: hey, will you please look at https://review.openstack.org/#/c/157755/ | 13:11 |
| *** ijw has joined #openstack-nova | 13:12 | |
| *** dboik has quit IRC | 13:14 | |
| *** ijw_ has joined #openstack-nova | 13:15 | |
| *** ijw has quit IRC | 13:16 | |
| *** changbl has quit IRC | 13:16 | |
| *** flwang has quit IRC | 13:16 | |
| *** kaufer has joined #openstack-nova | 13:17 | |
| *** apuimedo has joined #openstack-nova | 13:18 | |
| *** flwang has joined #openstack-nova | 13:18 | |
| *** liusheng has quit IRC | 13:19 | |
| *** liusheng has joined #openstack-nova | 13:19 | |
| *** nelsnelson has joined #openstack-nova | 13:20 | |
| *** nelsnelson has quit IRC | 13:22 | |
| *** nelsnelson has joined #openstack-nova | 13:22 | |
| *** mtanino has quit IRC | 13:24 | |
| alex_xu | sdague: good morning, does this https://etherpad.openstack.org/p/apipolicycheck looks good to you? or my comment is right one? | 13:24 |
| alex_xu | sdague: sorry, wrong link, this one https://review.openstack.org/160068 | 13:24 |
| *** otter768 has joined #openstack-nova | 13:25 | |
| *** sdake has joined #openstack-nova | 13:26 | |
| *** eharney has joined #openstack-nova | 13:27 | |
| *** alexpilotti has joined #openstack-nova | 13:27 | |
| *** sdake__ has joined #openstack-nova | 13:27 | |
| *** otter768 has quit IRC | 13:29 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Validate maximum limit for quota https://review.openstack.org/165069 | 13:31 |
| *** salv-orlando has quit IRC | 13:31 | |
| *** sdake has quit IRC | 13:31 | |
| *** alexpilotti has quit IRC | 13:32 | |
| *** alexpilotti has joined #openstack-nova | 13:32 | |
| *** ociuhandu has joined #openstack-nova | 13:33 | |
| dansmith | shaohe_feng: in general, make sure a thing is loaded :) | 13:34 |
| dansmith | shaohe_feng: if you remove the context from an object it will not be able to lazy load, but I'm guessing that there is a better answer than that | 13:35 |
| dansmith | shaohe_feng: if you show me what you're doing and what is happening I can try to give that better answer | 13:35 |
| *** dboik has joined #openstack-nova | 13:36 | |
| *** flwang has quit IRC | 13:37 | |
| *** flwang has joined #openstack-nova | 13:38 | |
| *** neelashah has joined #openstack-nova | 13:41 | |
| *** vmtrooper has joined #openstack-nova | 13:42 | |
| *** johnthetubaguy is now known as zz_johnthetubagu | 13:43 | |
| *** burt has joined #openstack-nova | 13:43 | |
| *** claudiub has quit IRC | 13:44 | |
| *** pixelb has joined #openstack-nova | 13:45 | |
| *** vmtrooper has quit IRC | 13:47 | |
| *** sdake has joined #openstack-nova | 13:48 | |
| *** aloga has quit IRC | 13:48 | |
| *** aloga has joined #openstack-nova | 13:49 | |
| *** zzzeek has joined #openstack-nova | 13:50 | |
| *** zz_johnthetubagu is now known as johnthetubaguy | 13:51 | |
| *** sdake__ has quit IRC | 13:51 | |
| mriedem | obondarev: comment/question in your patch | 13:53 |
| mriedem | obondarev: there is also a duplicate / deprecated _build_instance flow in compute manager that is possibly missing the same thing, but i'm not sure | 13:54 |
| mriedem | or how up to date we are keeping _build_instance since it's deprecated | 13:54 |
| *** shaohe_feng1 has joined #openstack-nova | 13:56 | |
| *** VW_ has joined #openstack-nova | 13:56 | |
| *** pkoniszewski has joined #openstack-nova | 13:57 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for floating_ip_dns https://review.openstack.org/150710 | 13:59 |
| *** eharney has quit IRC | 13:59 | |
| *** dboik_ has joined #openstack-nova | 14:00 | |
| *** gokrokve has joined #openstack-nova | 14:01 | |
| *** iamjarvo has joined #openstack-nova | 14:02 | |
| obondarev | mriedem: thanks! will check your comments | 14:02 |
| *** subscope has quit IRC | 14:03 | |
| *** dboik has quit IRC | 14:03 | |
| *** lsmola has quit IRC | 14:03 | |
| *** r-daneel has joined #openstack-nova | 14:03 | |
| *** VW_ has quit IRC | 14:04 | |
| mriedem | shameless plug here, would be good to have this in before k-3 so i can backport it to stable https://review.openstack.org/#/c/163890/ | 14:04 |
| mriedem | since we backported the thing which introduced it | 14:04 |
| *** bkopilov has quit IRC | 14:05 | |
| *** lsmola has joined #openstack-nova | 14:05 | |
| *** jistr|class is now known as jistr | 14:05 | |
| *** lsmola has quit IRC | 14:06 | |
| dansmith | mriedem: I'll trade you | 14:06 |
| mriedem | shoot | 14:06 |
| *** lsmola has joined #openstack-nova | 14:06 | |
| dansmith | mriedem: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/kilo-objects+owner:danms,n,z | 14:06 |
| dansmith | :) | 14:06 |
| dansmith | they're really easy though | 14:06 |
| mriedem | not really a fair trade | 14:06 |
| dansmith | lots of review points | 14:06 |
| dansmith | hehe | 14:06 |
| mriedem | true, i like to pad the stats | 14:07 |
| mriedem | i'll dig in | 14:07 |
| *** VW_ has joined #openstack-nova | 14:07 | |
| *** thangp has joined #openstack-nova | 14:07 | |
| *** garyk1 has joined #openstack-nova | 14:07 | |
| *** garyk has quit IRC | 14:07 | |
| *** Maike_ has joined #openstack-nova | 14:08 | |
| *** pixelb has quit IRC | 14:08 | |
| *** lsmola has quit IRC | 14:10 | |
| *** mtanino has joined #openstack-nova | 14:10 | |
| *** Maike has quit IRC | 14:10 | |
| *** TobiasE has quit IRC | 14:10 | |
| *** lsmola has joined #openstack-nova | 14:10 | |
| mriedem | dansmith: question inline https://review.openstack.org/#/c/164243/ | 14:11 |
| *** salv-orlando has joined #openstack-nova | 14:11 | |
| *** salv-orlando has quit IRC | 14:11 | |
| mriedem | also, since you threw that wedge in when using these, how are we not blowing up? or did you already cleanup the callers? | 14:11 |
| *** salv-orlando has joined #openstack-nova | 14:11 | |
| dansmith | mriedem: answer inline | 14:12 |
| dansmith | mriedem: right, the last round was fixing the callers, then putting the wedge in to prevent new callers | 14:12 |
| *** TobiasE has joined #openstack-nova | 14:13 | |
| dansmith | mriedem: this round removes dependence on them by the methods themselves, and then wedges them, then updates the actual signature | 14:13 |
| *** adelinatuvenie has joined #openstack-nova | 14:13 | |
| *** ishant has quit IRC | 14:15 | |
| mriedem | dansmith: and no version bump necessary here at the end? https://review.openstack.org/#/c/164268/ | 14:15 |
| *** thomasem has joined #openstack-nova | 14:15 | |
| dansmith | mriedem: nope, because there is no rpc-visible change | 14:15 |
| *** thomasem has quit IRC | 14:15 | |
| *** kaisers has quit IRC | 14:16 | |
| *** thomasem has joined #openstack-nova | 14:16 | |
| bauzas | dansmith: mornooning, I was just reviewing a change where someone was adding a new method with a signature having a context | 14:16 |
| obondarev | mriedem: please check my answer https://review.openstack.org/#/c/157755/ | 14:16 |
| bauzas | dansmith: so, should I just -1 it because now it's merged ? | 14:16 |
| dansmith | bauzas: if they're adding a method, they have to right now | 14:16 |
| dansmith | bauzas: can you point me at the change? | 14:17 |
| bauzas | dansmith: sure, lemme find it again (it was 1 hour before) | 14:17 |
| dansmith | bauzas: until that set ^^ merges and changes the signature | 14:17 |
| dansmith | bauzas: thanks for keeping an eye out :) | 14:17 |
| bauzas | dansmith: yeah, hence my question because I know that we need to remove the context on remotable methods, but I was unware of the status now | 14:17 |
| alaski | I had to add context params to the two objects I have up for review, though I would like to remove that as soon as I can | 14:18 |
| *** vivekd has quit IRC | 14:18 | |
| *** subscope has joined #openstack-nova | 14:18 | |
| dansmith | alaski: speaking of that, I started reviewing some of those patches yesterday and got distracted, but I think I sent at least one to the gate | 14:18 |
| alaski | dansmith: yep, thanks! the others in the series needed to be rebased, but gerrit wouldn't let me push while changes were approved | 14:19 |
| alaski | which I think was my fault because I rebased them | 14:19 |
| dansmith | cool | 14:19 |
| sdague | all nova patches will currently fail the gate because of the cells devstack exercises job, fwiw | 14:19 |
| dansmith | sdague: what's going on? | 14:20 |
| bauzas | dansmith: got it https://review.openstack.org/#/c/161904/5/nova/objects/instance_mapping.py,cm (from alaski) | 14:20 |
| alaski | sdague: what's the failure? | 14:20 |
| mriedem | alaski: dansmith: https://review.openstack.org/#/c/165063/ | 14:20 |
| sdague | horizon login page change, and the exercises are super dumb | 14:20 |
| mriedem | horizon login page changed | 14:20 |
| dansmith | heh | 14:20 |
| alaski | wow, ok | 14:20 |
| dansmith | alaski: by the way, on dash.py, I have a bunch of local changes to change how the lines get reported: http://imgur.com/iLeEIYx | 14:21 |
| bauzas | alaski: left you a comment on https://review.openstack.org/#/c/161904/5/nova/objects/instance_mapping.py,cm re: to the above convo | 14:21 |
| alaski | dansmith: oh yeah, meant to ping you on that since I figured you had local changes | 14:21 |
| bauzas | alaski: but sounds like it was just a rebase thing right ? | 14:21 |
| dansmith | alaski: I dunno who else uses it, but since you apparently do, how do you feel about that? it shows the status of each test individually.. helps indicate pep8 fail (early) vs. devstack fail (middle) | 14:21 |
| alaski | dansmith: that's pretty sweet | 14:22 |
| dansmith | bauzas: well, that one is okay, classmethods will continue to have contexts.. they kinda have to :) | 14:22 |
| dansmith | alaski: okay, I'll try to get that pushed up then | 14:22 |
| bauzas | dansmith: okay then I was confused, I need to look at your series | 14:22 |
| *** jecarey has joined #openstack-nova | 14:23 | |
| bauzas | dansmith: oh ok, classmethods are fine, but only these ones ? yeah makes sense | 14:23 |
| alaski | bauzas: the decorator calls the method with a context, it's just that now the caller doesn't pass a context | 14:23 |
| dansmith | bauzas: right, because classmethods are queries that don't have an object yet | 14:23 |
| bauzas | dansmith: yeah I was just shooting before asking | 14:24 |
| bauzas | ... | 14:24 |
| alaski | bauzas: eh, what dansmith said. I was thinking remotable | 14:24 |
| dansmith | bauzas: np, it's confusing :) | 14:24 |
| mriedem | dansmith: not sure the test needed changing here https://review.openstack.org/#/c/164245/ | 14:24 |
| alaski | dansmith: thanks. I am also getting duplicate entries for my patches in dash. Did you fix that too? | 14:24 |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for floating_ip_dns https://review.openstack.org/150710 | 14:24 |
| dansmith | alaski: yes, that's because of the new dependency tracker in zuul, it reports the things ahead of a patch, which I now filter out | 14:25 |
| dansmith | mriedem: actually, I need to go back to that, I think that might've been because of that NoDb thing and I never stripped it | 14:25 |
| dansmith | mriedem: thanks | 14:25 |
| alaski | dansmith: nice. I've been running dashless since the divide by zero thing broke me until I fixed it yesterday, so that was all new | 14:26 |
| dansmith | alaski: heh | 14:26 |
| dansmith | I feel so naked without the dash running | 14:26 |
| alaski | me too, but apparently I enjoyed that for a while :) | 14:26 |
| dansmith | heh | 14:27 |
| mriedem | sitting by a window | 14:27 |
| mriedem | if people don't want to look they don't have to | 14:27 |
| alaski | lol, agreed | 14:28 |
| *** nellysmitt has joined #openstack-nova | 14:29 | |
| * sdague headdesks | 14:30 | |
| sdague | so... apparently, this new test code wasn't working because I copied a bit of code that changed the scheduler to chance | 14:30 |
| dansmith | alaski: pushed | 14:31 |
| *** jcru has joined #openstack-nova | 14:32 | |
| *** garyk1 has quit IRC | 14:32 | |
| openstackgerrit | Sean Dague proposed openstack/nova: Remove db layer hard-code permission checks for pci https://review.openstack.org/150355 | 14:33 |
| *** _gryf has quit IRC | 14:33 | |
| *** zz_jgrimm is now known as jgrimm | 14:33 | |
| *** VW_ has quit IRC | 14:33 | |
| openstackgerrit | Sean Dague proposed openstack/nova: Remove db layer hard-code permission checks for pci https://review.openstack.org/150355 | 14:33 |
| dansmith | mriedem: oh, actually that assertion doesn't really make sense, I was thinking of something else | 14:33 |
| alaski | dansmith: thanks, looks nice | 14:33 |
| dansmith | mriedem: but it also shouldn't need to change :) | 14:33 |
| mriedem | dansmith: yeah, it's pointless, but it's also in the other tests | 14:33 |
| mriedem | so we could either leave it or remove them all | 14:34 |
| dansmith | yar | 14:34 |
| dansmith | here it comes | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in agent, aggregate https://review.openstack.org/164243 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in bandwidth, block_device https://review.openstack.org/164244 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in ec2 object https://review.openstack.org/164245 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in fixed_ip, flavor, floating_ip https://review.openstack.org/164246 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in instance* objects https://review.openstack.org/164247 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in compute_node, keypair https://review.openstack.org/164248 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in migration, network https://review.openstack.org/164249 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in pci_device, quotas https://review.openstack.org/164250 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in security_group* https://review.openstack.org/164251 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in service, tag, vif https://review.openstack.org/164252 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Actually stop passing context to remotable methods https://review.openstack.org/164253 | 14:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove context from remotable call signature https://review.openstack.org/164268 | 14:34 |
| *** achanda has joined #openstack-nova | 14:34 | |
| sdague | dansmith: you might want to put a Depends-On on the first patch | 14:37 |
| sdague | otherwise you are going to recheck that whole stack later | 14:37 |
| dansmith | sdague: well, I could, but if I do that it will be recorded in history as depending on that other change, which isn't right, right? | 14:37 |
| *** emagana has joined #openstack-nova | 14:37 | |
| *** markmcclain has joined #openstack-nova | 14:38 | |
| sdague | sure | 14:38 |
| *** Marga_ has quit IRC | 14:38 | |
| *** ajayaa has quit IRC | 14:39 | |
| *** kaisers has joined #openstack-nova | 14:40 | |
| *** achanda has quit IRC | 14:43 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for network_create_safe https://review.openstack.org/161626 | 14:43 |
| *** baoli has joined #openstack-nova | 14:44 | |
| *** gokrokve_ has joined #openstack-nova | 14:44 | |
| mriedem | woe to all those out of tree objects | 14:45 |
| *** gokrokve has quit IRC | 14:45 | |
| dansmith | heh | 14:46 |
| *** browne has joined #openstack-nova | 14:46 | |
| *** hemnafk is now known as hemna | 14:46 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for network_create_safe https://review.openstack.org/161626 | 14:49 |
| *** kashyapc has quit IRC | 14:49 | |
| edleafe | dansmith: jaypipes-afk: changes to https://review.openstack.org/#/c/160511/ are ready for your re-review. | 14:50 |
| *** baoli has quit IRC | 14:51 | |
| dansmith | edleafe: I'm going to wait for him to +2 since he had the most concerns about the approach | 14:51 |
| edleafe | dansmith: sure, makes sense | 14:52 |
| dansmith | looks like my changes were made though | 14:53 |
| *** baoli has joined #openstack-nova | 14:53 | |
| *** gokrokve_ has quit IRC | 14:53 | |
| edleafe | dansmith: trying to get this series in before FF | 14:54 |
| mriedem | dansmith: i almost made it all the way through https://review.openstack.org/#/c/164268/ | 14:54 |
| dansmith | edleafe: orly? I had no idea! :) | 14:54 |
| edleafe | dansmith: I'm usually very subtle | 14:55 |
| *** gokrokve has joined #openstack-nova | 14:56 | |
| *** david-lyle_afk is now known as david-lyle | 14:57 | |
| dansmith | mriedem: replied | 14:57 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove context from remotable call signature https://review.openstack.org/164268 | 15:00 |
| dansmith | mriedem: better ^ ? | 15:00 |
| *** kmartin has joined #openstack-nova | 15:00 | |
| mriedem | sec | 15:00 |
| mriedem | i got an internal icehouse issue b/c someone doesn't like that they don't get any details when scheduling files due to over commit | 15:00 |
| mriedem | sdague: ^ sound familiar? | 15:00 |
| mriedem | *fails | 15:01 |
| sdague | mriedem: yeh, that's basically what everyone was complaining about in the ops meetup | 15:01 |
| mriedem | yeah :) | 15:01 |
| mriedem | so i'm linking the guy to the ML thread on it | 15:01 |
| mriedem | did any bugs get reported from that issue? | 15:01 |
| sdague | yes - https://bugs.launchpad.net/nova/+bug/1431291 | 15:02 |
| openstack | Launchpad bug 1431291 in OpenStack Compute (nova) "Scheduler Failures are no longer logged with enough detail for a site admin to do problem determination" [High,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza) | 15:02 |
| sdague | I'm working on a test case atm | 15:02 |
| *** penick has quit IRC | 15:02 | |
| mriedem | cool | 15:02 |
| johnthetubaguy | jaypipes: zzzeek: I am wondering if you will get chance to look at the online schema migration stuff, we are looking dangerously close to merging this initial system in kilo: https://review.openstack.org/#/c/154521 | 15:03 |
| zzzeek | johnthetubaguy: I’ve looked to some degree | 15:03 |
| zzzeek | johnthetubaguy: I think jerdfelt has been very thorough as we’ve worked thorugh some alembic issues together on it | 15:04 |
| johnthetubaguy | zzzeek: yeah, I feel like we should get this merged now, particularly given its an alternative migration path, so if it doesn't work for someone, they need not use it | 15:05 |
| zzzeek | johnthetubaguy: my usual concern is, “why is this only in nova”, when its of general use | 15:06 |
| *** jaypipes has quit IRC | 15:06 | |
| johnthetubaguy | zzzeek: I kinda hope we can prove its useful-ness, then merge it back into oslo.db? | 15:06 |
| zzzeek | johnthetubaguy: I’d rather see something like oslo.migrations | 15:07 |
| dansmith | because like a lot of things, we incubate stuff where they're needed, learn, and then break it out into a general thing once it's working :) | 15:07 |
| zzzeek | dansmith: fine | 15:07 |
| johnthetubaguy | dansmith: yeah, thats what I was thinking | 15:07 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Sets *DataRoot paths for instances https://review.openstack.org/162999 | 15:07 |
| johnthetubaguy | zzzeek: agreed we should get others to adopt it, where its useful though | 15:07 |
| zzzeek | this feature is so dramatic it’s almost like, why doesnt alembic do this, kind of thing | 15:07 |
| mriedem | dansmith: so this is just a one time thing with the context removal right? https://review.openstack.org/#/c/164268/2..3/nova/tests/unit/objects/test_objects.py | 15:07 |
| mriedem | i.e. no reason in changing the test | 15:08 |
| johnthetubaguy | zzzeek: honestly, that might be a good way forward | 15:08 |
| *** pkoniszewski has quit IRC | 15:08 | |
| dansmith | mriedem: yeah, there's nothing to change after the test :) | 15:08 |
| dansmith | mriedem: after the patch I mean | 15:08 |
| mriedem | k | 15:08 |
| zzzeek | johnthetubaguy: well the issue may be that, at least from my impression, this is very good for “small” migrations, e.g. adding /removing columns. but if you launch it on the public and tell them “it’s automatic!” they will break it immediately and demand it do more and more without any intervention | 15:08 |
| zzzeek | johnthetubaguy: this particular slope seems to be at a really high angle | 15:09 |
| dansmith | that's why this is an alternate path for the time being | 15:09 |
| dansmith | to get some brave souls to test the water | 15:09 |
| johnthetubaguy | yeah, I like the parallel bit for now | 15:09 |
| *** kashyapc has joined #openstack-nova | 15:10 | |
| johnthetubaguy | dansmith: top idea btw! | 15:10 |
| zzzeek | OK so how does it interact with the existing “fixed” migrations? | 15:10 |
| dansmith | \o/ | 15:10 |
| *** dave-mccowan has quit IRC | 15:10 | |
| johnthetubaguy | zzzeek: you run one or the other approach, we test to make sure the resultant scheme is the same | 15:10 |
| dansmith | zzzeek: if our fixed migrations are properly idempotent, then you can switch back and forth | 15:11 |
| johnthetubaguy | zzzeek: there is lock to make sure you don't do both at the same time | 15:11 |
| dansmith | or at least switch forth on a test deployment | 15:11 |
| johnthetubaguy | right | 15:11 |
| jerdfelt | zzzeek: fwiw, i've tested migrating from every previous version to the latest (1-274 at least) | 15:11 |
| zzzeek | OK one thing I couldnt see when i looked, guess i should look more, is from the spec, there’s the “add” phase, then theres the “in place” phase and then the “remove” phase, the “in place” part of this I thoughut still required manual migration scripts? | 15:12 |
| zzzeek | otherwise where do all the things that cant be automated go, changes of column default, changes in the columns within an index, changes of table or column name, etc | 15:13 |
| jerdfelt | zzzeek: the only failures are things like the change from MyISAM to InnoDB, but if I have around that particular problem, it handles all of the differences in schemas seen | 15:13 |
| zzzeek | jerdfelt: so literally, you’ve automated 100% of migration | 15:13 |
| jerdfelt | zzzeek: there are still some gaps with things like dialect specific options (mysql collations, etc) but nothing we've ever done in nova | 15:13 |
| *** fdelvale has joined #openstack-nova | 15:14 | |
| zzzeek | jerdfelt: right, you dont use ENUM types, or CHECK constraints, or things like that | 15:14 |
| jerdfelt | we do use ENUM types in nova | 15:14 |
| zzzeek | jerdfelt: how are those impelmented on Postgresql? | 15:14 |
| *** browne has quit IRC | 15:14 | |
| bauzas | sdague: are you working on the bug, you said ? | 15:15 |
| bauzas | sdague: because I was about working on it too | 15:15 |
| bauzas | sdague: so I just want to know how we can both do work in parallel | 15:15 |
| sdague | bauzas: so, I was mostly working on a test to expose the issue, I had not started trying to do the actual reporting | 15:15 |
| jerdfelt | zzzeek: alembic supports them (why am i'm telling you what alembic can do? :) | 15:16 |
| bauzas | sdague: okay sounds fine | 15:16 |
| sdague | if you want to propose something that actually reports the details, I can bring this test over for verification and regression testing | 15:16 |
| zzzeek | jerdfelt: alembic doesnt support detection of changes in ENUM, and your system deos away with the concept of manually editing migration files | 15:16 |
| bauzas | sdague: so let me know once your change is up so I could rebase my work on top of you | 15:16 |
| zzzeek | jerdfelt: so if someone wants to add a new element to an ENUM, and they use online schema migrations, what do they do ? | 15:16 |
| bauzas | sdague: yeah, was trying to add more verbosity to the existing logs by adding the instance_uuid value from the spec | 15:17 |
| openstackgerrit | Matthew Booth proposed openstack/nova: VMware: Improve reporting of path test failures https://review.openstack.org/159483 | 15:17 |
| jerdfelt | zzzeek: it doesn't handle 100% of possible migrations, just what we've tried to do before. in the case of changing an ENUM, then we need to add support for that when someone tries to do that | 15:17 |
| bauzas | sdague: and I need to go thru code so it would probably also put more than just NoValidHost, either you're rescheduling or facing a scheduler filter issue | 15:17 |
| *** eliqiao has joined #openstack-nova | 15:18 | |
| bauzas | PaulMurray: so, on your patch now https://review.openstack.org/#/c/148904/ | 15:18 |
| zzzeek | jerdfelt: OK. So there are a *ton* of things that alembic doesnt detect :) they’re listed. the plan is that you’ll implement full auto-detection for each of those as needed? | 15:18 |
| *** eharney has joined #openstack-nova | 15:18 | |
| PaulMurray | bauzas, https://review.openstack.org/#/c/148904/14/nova/compute/resource_tracker.py L#309 | 15:18 |
| sdague | bauzas: I can post a wip, but the test is going to have to adjust to whatever the new reporting is. Honestly, I'd say, how about you propose what you think the right functional bits are here, and I can test on those. | 15:18 |
| zzzeek | jerdfelt: becasue then that really is, a big new thing that is certainly external to openstack | 15:18 |
| bauzas | PaulMurray: yeah saw the comment | 15:19 |
| PaulMurray | bauzas, the point was we don't need to look up service any more - right? | 15:19 |
| jerdfelt | zzzeek: i know it doesn't do everything. are you saying that alembic will never do that or just that no one has written the code to do that yet? | 15:19 |
| zzzeek | jerdfelt: ive purposely not gone down that road b.c. it would be a support nightmare. the product would have been unadoptable all this time and I’d ahve no users | 15:19 |
| PaulMurray | bauzas, because you detached it | 15:19 |
| openstackgerrit | wuhao proposed openstack/nova-specs: Add previous page links for Nova GET servers API https://review.openstack.org/165041 | 15:19 |
| bauzas | PaulMurray: mmm | 15:20 |
| PaulMurray | bauzas, so I think he's right - you think so? | 15:20 |
| zzzeek | jerdfelt: I can’t imagine with just me maintaining it that alembic is going to automate every possible thing that can change on every possible database backend, and even if it did, databses add new features way faster than alembic could ever keep up with them. | 15:20 |
| bauzas | PaulMurray: now we're only checking the service information because we're adding the service host field to the compute fields | 15:20 |
| jerdfelt | zzzeek: if you have no interest in having alembic do that in the future, then comment on the review to that effect. i'll abandon the patch since i have no interest in supporting that myself solely | 15:20 |
| bauzas | PaulMurray: but indeed, we don't need to carry a relationship nowadays | 15:20 |
| *** VW_ has joined #openstack-nova | 15:21 | |
| zzzeek | jerdfelt: even easy things like detecting changes in column defaults is very difficult, and providing migrations that work for them, given quirks like on MSSQL you need to drop all the constraints separately before you change an column etc., super difficult | 15:21 |
| zzzeek | jerdfelt: how do you auto-detect a change in table or column name ? | 15:21 |
| bauzas | PaulMurray: now in RT, we're checking if a service exists with the name of the host, and if so, we're moving forward | 15:21 |
| bauzas | sdague: sure, I can do that too | 15:21 |
| jerdfelt | zzzeek: we don't allow column name changes. that doesn't play well with live upgrades and the spec forbids it | 15:21 |
| bauzas | PaulMurray: replying to hans now | 15:22 |
| PaulMurray | bauzas, so it gets used to write to service_id - do we need that? | 15:22 |
| PaulMurray | bauzas, or are you saying we don't? | 15:22 |
| johnthetubaguy | zzzeek: well we can constrain ourselves a little bit in the Nova to get the expand/contract, I am OK with that, even if that restricts our db choices, etc. Its not a supper happy place, but its better than not ever having online migrations, I think, at least it seems worth trying | 15:23 |
| zzzeek | jerdfelt: it’s not that I dont find it interesting, its just that I find it to be an impossible ideal. you will *always* need to write manual migrations in the real world to get things done. if nova can limit its migrations to not needing this, that’s fine, but in the abstract, people put data migrations in their scripts, they do all kinds of things. I really think such a system needs to provide areas for manual intervention | 15:23 |
| bauzas | PaulMurray: no, I will write a patch to remove this field, we no longer need it | 15:23 |
| *** annashen has joined #openstack-nova | 15:23 | |
| eliqiao | hello, any cores help to merge https://review.openstack.org/#/c/141973/ Christopher has +2 and jenkins has verified it | 15:23 |
| jerdfelt | johnthetubaguy: i wish these conversations happened before the the spec was approved instead of now when i've written all of this code and it's two days before merge freeze | 15:23 |
| bauzas | PaulMurray: the service_id field is not deprecated | 15:23 |
| bauzas | s/not/now | 15:23 |
| *** eliqiao has quit IRC | 15:24 | |
| zzzeek | jerdfelt: the whole success of SQLAlchemy and Alembic has been because they never pretended that the whole database can be abstracted away. the fact that you can get at things and manually intervene is why the toolset has stood out and for many people changed the definition of ORM for them | 15:24 |
| johnthetubaguy | jerdfelt: agreed :( | 15:25 |
| jerdfelt | zzzeek: i kind of wish you had brought this up back last june or november when you had reviewed the spec | 15:25 |
| alex_xu | a set of policy patch get one +2 already, looking for next one: https://review.openstack.org/150354 https://review.openstack.org/150353 https://review.openstack.org/150352 https://review.openstack.org/161628 https://review.openstack.org/161627 https://review.openstack.org/150352 https://review.openstack.org/160309 | 15:25 |
| PaulMurray | bauzas, shall I leave it there and let you remove it after? | 15:25 |
| zzzeek | jerdfelt: i wlil of coruse merge as many new automations to alembic as you can send me, i dont know that this invalidates your system | 15:25 |
| *** kaufer1 has joined #openstack-nova | 15:26 | |
| zzzeek | jerdfelt: I’m not limiting what alembic can do in the future, ill automate as much as is possible. i dont think that shoudl be a concern | 15:26 |
| *** otter768 has joined #openstack-nova | 15:26 | |
| alex_xu | johnthetubaguy: mriedem alaski ^^^ appreciate if you can review them when you have time! | 15:26 |
| dansmith | jerdfelt: this conversation is only potentially interesting in the "abstract this for others" case, IMHO, has nothing to do with the nova spec and merging this code into nova | 15:26 |
| johnthetubaguy | jerdfelt: zzzeek: I am OK nova being constrained in what it can do, so we get online migrations, and look at each problem as it comes up | 15:26 |
| *** kaufer has quit IRC | 15:27 | |
| zzzeek | johnthetubaguy: yes that’s all im saying, but I think in the long term, people are going to want to be able to inject something custom into this tool. | 15:27 |
| johnthetubaguy | alex_xu: are all the details update in here now? https://etherpad.openstack.org/p/kilo-nova-priorities-tracking | 15:27 |
| *** VW_ has quit IRC | 15:28 | |
| alex_xu | johnthetubaguy: ok, will update at there, thanks | 15:28 |
| mdbooth | Trivial test cleanup gathering rebases if anybody has a sec: https://review.openstack.org/#/c/159483/ | 15:29 |
| johnthetubaguy | zzzeek: OK, I think I get what you mean, supporting patches where we need to "do custom magic in this horrible edge case" sort of things? And I am assuming we can add that later, when we meet that sort of problem | 15:29 |
| *** dave-mccowan has joined #openstack-nova | 15:29 | |
| zzzeek | johnthetubaguy: that is all im saying. but i dont know offhand what is ia “horrible edge case” and what’s just a “real world 20% use case” | 15:30 |
| *** otter768 has quit IRC | 15:30 | |
| bauzas | PaulMurray: well, removing this field is very difficult because we first need to nullify it on the Service object | 15:30 |
| bauzas | PaulMurray: so I was planning to work on that for L | 15:31 |
| *** vmtrooper has joined #openstack-nova | 15:31 | |
| bauzas | PaulMurray: it would substancially increase the level of change by your patch if you would | 15:31 |
| *** Marga_ has joined #openstack-nova | 15:31 | |
| bauzas | PaulMurray: that said, a comment saying it's now deprecated is worth it :) | 15:31 |
| zzzeek | jerdfelt: the way online schema migrations works is also very different from how I’ve always done them so I have a sense that it solves a lot of problems that I haven’t gotten my head around yet. for example, it solves the database-specific migration issue, b.c. it always runs against a specific backend fully. so comparison of things like CHECK constraints can be done by basic string comparison and such. | 15:31 |
| *** changbl has joined #openstack-nova | 15:32 | |
| *** tsekiyama has joined #openstack-nova | 15:32 | |
| PaulMurray | bauzas, so you're saying keep it as it is but put a comment saying its going to go away - yes? | 15:32 |
| jerdfelt | zzzeek: that is how the patch compares types (see _compare_type) | 15:33 |
| *** dave-mccowan has quit IRC | 15:33 | |
| jerdfelt | since the alembic support has some odd behavior right now | 15:33 |
| zzzeek | jerdfelt: there’s often a gap between how SQLAlchemy metadata specifies something and how it ends up looking in a target DB. specific dialects will resolve abstract constructs into different things on the target backend that don’t necessarily translate back to the original metadata thing. that’s where all the problems come from | 15:34 |
| jerdfelt | believe me, i know :( | 15:35 |
| zzzeek | jerdfelt: espeically things like the “boolean” and “db-agnostic enum” types that also spit out a CHECK constraint | 15:35 |
| *** vmtrooper has quit IRC | 15:35 | |
| zzzeek | jerdfelt: im not sure why i implemnted those so eagerly :) | 15:36 |
| jerdfelt | yeah, there are some corner cases (like server side defaulted booleans) | 15:36 |
| jerdfelt | but i understand why it's not supported | 15:37 |
| *** dave-mccowan has joined #openstack-nova | 15:37 | |
| jerdfelt | the more i worked on this, the more i hated existing SQL implementations. it's like 90% common, but the remaining 10% makes things so much more complicated | 15:37 |
| bauzas | PaulMurray: exactlyu | 15:38 |
| bauzas | PaulMurray: I made a big fat comment, please review again | 15:38 |
| zzzeek | jerdfelt: I used to write migrations for a big Oracle DB where i had to create temp tables, do big INSERT from SELECTs to migrate the data over, then drop old tables and build them out into new structures, stuff like that. it’s just a very different concept to work those kinds of migrations into this kind of system and I would have to think pretty hard to get my head around that so that is sort of why i didnt have a strong | 15:38 |
| zzzeek | philosophical objecvtion to the online migration idea, b.c. i dont think I’ve gotten my head into it enough to really know how its going to work | 15:38 |
| bauzas | PaulMurray: I -1 your patch because of the dict notation you used (coming from an older PS probably), that's it | 15:39 |
| PaulMurray | bauzas, sure - thanks | 15:42 |
| *** adelinatuvenie has quit IRC | 15:42 | |
| PaulMurray | bauzas, changin now | 15:42 |
| *** annashen has quit IRC | 15:43 | |
| *** nkrinner has quit IRC | 15:48 | |
| *** yamahata has joined #openstack-nova | 15:49 | |
| *** rajesht has quit IRC | 15:53 | |
| *** unicell has quit IRC | 15:54 | |
| *** ajayaa has joined #openstack-nova | 15:54 | |
| *** Marga_ has quit IRC | 15:56 | |
| *** liusheng has quit IRC | 15:57 | |
| *** Marga_ has joined #openstack-nova | 15:58 | |
| *** liusheng has joined #openstack-nova | 15:58 | |
| *** matrohon has quit IRC | 15:58 | |
| *** ijw_ has quit IRC | 15:59 | |
| *** pask811 has joined #openstack-nova | 16:01 | |
| *** mdbooth has quit IRC | 16:02 | |
| *** Marga_ has quit IRC | 16:03 | |
| *** pask81 has quit IRC | 16:03 | |
| *** pask811 has quit IRC | 16:04 | |
| *** tonytan4ever has joined #openstack-nova | 16:04 | |
| *** iamjarvo has quit IRC | 16:05 | |
| *** Longgeek has joined #openstack-nova | 16:06 | |
| *** kmartin has quit IRC | 16:06 | |
| *** amotoki has quit IRC | 16:06 | |
| *** kmartin has joined #openstack-nova | 16:07 | |
| *** mdbooth has joined #openstack-nova | 16:07 | |
| *** kaisers has quit IRC | 16:07 | |
| *** sahid has joined #openstack-nova | 16:08 | |
| openstackgerrit | Chris Friesen proposed openstack/nova: Fix "down" nova-compute service spuriously marked as "up" https://review.openstack.org/163060 | 16:08 |
| *** baoli has quit IRC | 16:09 | |
| *** pask81 has joined #openstack-nova | 16:09 | |
| *** dboik_ has quit IRC | 16:09 | |
| *** Longgeek has quit IRC | 16:10 | |
| bauzas | dansmith: minor nit, I like +1'ing your series but don't you think we could maybe squash most of the patches ? | 16:12 |
| bauzas | dansmith: I mean, that's definitely cool to split those into small chunks but that's maybe overkill nope ? | 16:12 |
| mdbooth | bauzas: It minimises rebases | 16:12 |
| mdbooth | Also, it localises any fallout | 16:12 |
| dansmith | yeah | 16:12 |
| dansmith | it | 16:13 |
| bauzas | mdbooth: yeah indeed you're right | 16:13 |
| dansmith | it is the same number of files to review, just a few more clicks :) | 16:13 |
| dansmith | I could have split each object, but went for pairs :) | 16:13 |
| bauzas | dansmith: eh eh, and bump in stats ? :) | 16:13 |
| anteaya | do nova people care if random people use the word nova in their stackforge project name? https://review.openstack.org/#/c/163687/ | 16:13 |
| dansmith | bauzas: for you! | 16:13 |
| bauzas | dansmith: lol | 16:13 |
| wasmum | anyone have time for a cinder question? | 16:14 |
| bauzas | dansmith: I seriously don't care about my stats, I'm just worried of my Gerrit dashboard :D | 16:14 |
| dansmith | bauzas: oh please, wanna compare dashboards? :) | 16:14 |
| *** kaisers has joined #openstack-nova | 16:14 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Sets *DataRoot paths for instances https://review.openstack.org/165129 | 16:15 |
| dansmith | anteaya: seems appropriate in that case | 16:15 |
| bauzas | dansmith: I'm lazy, that's basically a Gerrit query for each firefox tab | 16:15 |
| dansmith | anteaya: if they start calling it "nova-ng" or something, then that'd be concerning | 16:15 |
| anteaya | very good | 16:16 |
| bauzas | dansmith: but I should put those into a gerrit-dash-creator dash | 16:16 |
| anteaya | care to comment or shall I be the messenger? | 16:16 |
| dansmith | bauzas: maybe, but a +W on each will make them go away :) | 16:16 |
| bauzas | dansmith: eh I wish I could :) | 16:16 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Sets *DataRoot paths for instances https://review.openstack.org/165129 | 16:17 |
| bauzas | dansmith: but you're right, will amend my queries by only seeing those where I'm not yet voting on the latest PS | 16:17 |
| bauzas | an easy -label:Code-Review>=2,self should do the trick | 16:18 |
| bauzas | arh | 16:18 |
| * anteaya commented | 16:18 | |
| bauzas | -label:Code-Review>=-2,self of course | 16:18 |
| sdague | bauzas: yeh, that's in most of the upstream dashboards | 16:19 |
| sdague | anteaya: I +2ed it as well, if you want to +A | 16:20 |
| anteaya | okay thanks | 16:21 |
| *** rmoe has quit IRC | 16:21 | |
| *** salv-orlando has quit IRC | 16:21 | |
| openstackgerrit | Paul Murray proposed openstack/nova: Use compute_node consistently in ResourceTracker https://review.openstack.org/159765 | 16:23 |
| openstackgerrit | Paul Murray proposed openstack/nova: Add nova object equivalence and ComputeNode changes https://review.openstack.org/165037 | 16:23 |
| openstackgerrit | Paul Murray proposed openstack/nova: Cleanups for pci stats in preparation for RT using ComputeNode https://review.openstack.org/161843 | 16:23 |
| openstackgerrit | Paul Murray proposed openstack/nova: Convert RT compute_node to be a ComputeNode object https://review.openstack.org/160942 | 16:23 |
| openstackgerrit | Paul Murray proposed openstack/nova: Move ComputeNode creation at init stage in ResourceTracker https://review.openstack.org/148904 | 16:23 |
| edleafe | dansmith: reviewing your patch series, and was wondering: in the remotable methods, why is context still a required parameter? | 16:25 |
| dansmith | edleafe: seen the last patch yet/ | 16:25 |
| edleafe | no | 16:25 |
| *** Maike_ has quit IRC | 16:25 | |
| edleafe | dansmith: is it like a surprise twist ending? | 16:25 |
| dansmith | edleafe: shouldn't be a surprise, no :) | 16:26 |
| edleafe | dansmith: only about 5 deep so far... | 16:26 |
| dansmith | sdague: I closed the tab on that fix for the exercises.. how's that going? | 16:26 |
| dansmith | edleafe: https://review.openstack.org/#/c/164268/ | 16:26 |
| bauzas | dansmith: nice to see that you add a check on the decorator too for raising an exception | 16:26 |
| sdague | not in my review list, I guess it landed | 16:26 |
| edleafe | dansmith: aw, crap - you ruined the surprise! | 16:27 |
| dansmith | sdague: okay | 16:27 |
| *** jaypipes has joined #openstack-nova | 16:27 | |
| *** Nic has joined #openstack-nova | 16:28 | |
| *** pkoniszewski has joined #openstack-nova | 16:28 | |
| *** dave-mccowan has quit IRC | 16:28 | |
| *** unicell has joined #openstack-nova | 16:30 | |
| *** garyk has joined #openstack-nova | 16:31 | |
| *** unicell1 has joined #openstack-nova | 16:31 | |
| *** packet has joined #openstack-nova | 16:33 | |
| *** Bsony has quit IRC | 16:33 | |
| *** dave-mccowan has joined #openstack-nova | 16:34 | |
| *** unicell has quit IRC | 16:35 | |
| *** rmoe has joined #openstack-nova | 16:39 | |
| *** melwitt has joined #openstack-nova | 16:39 | |
| *** kashyapc has quit IRC | 16:39 | |
| *** kashyapc has joined #openstack-nova | 16:40 | |
| *** browne has joined #openstack-nova | 16:40 | |
| *** bkopilov has joined #openstack-nova | 16:41 | |
| *** baoli has joined #openstack-nova | 16:43 | |
| *** oro has quit IRC | 16:44 | |
| *** oro_ has quit IRC | 16:44 | |
| *** bkopilov has quit IRC | 16:46 | |
| *** annashen has joined #openstack-nova | 16:46 | |
| *** thomasem has quit IRC | 16:47 | |
| *** penick has joined #openstack-nova | 16:47 | |
| *** harlowja_away is now known as harlowja | 16:49 | |
| *** VW_ has joined #openstack-nova | 16:50 | |
| *** TobiasE has quit IRC | 16:52 | |
| *** TobiasE has joined #openstack-nova | 16:53 | |
| *** alexpilotti has quit IRC | 16:53 | |
| *** salv-orlando has joined #openstack-nova | 16:53 | |
| *** markus_z has quit IRC | 16:55 | |
| *** unicell has joined #openstack-nova | 16:56 | |
| *** pkoniszewski has quit IRC | 16:57 | |
| *** unicell1 has quit IRC | 16:58 | |
| *** ociuhandu has quit IRC | 16:59 | |
| *** lpetrut has quit IRC | 16:59 | |
| *** TobiasE1 has joined #openstack-nova | 17:01 | |
| *** sahid has quit IRC | 17:01 | |
| *** TobiasE has quit IRC | 17:02 | |
| *** TobiasE has joined #openstack-nova | 17:02 | |
| *** Bsony has joined #openstack-nova | 17:03 | |
| *** sbfox has joined #openstack-nova | 17:03 | |
| *** jlanoux has quit IRC | 17:04 | |
| *** dsanders has joined #openstack-nova | 17:05 | |
| *** TobiasE1 has quit IRC | 17:05 | |
| *** tonytan4ever has quit IRC | 17:05 | |
| *** GumBall has joined #openstack-nova | 17:09 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Sets *DataRoot paths for instances https://review.openstack.org/162999 | 17:09 |
| *** dboik has joined #openstack-nova | 17:10 | |
| kashyapc | harlowja: Heya, when you have a sec, re: your comment here -- https://github.com/openstack/nova/blob/master/nova/virt/libvirt/utils.py#L199, I did a quick test yesterday. | 17:10 |
| harlowja | sup | 17:10 |
| kashyapc | harlowja: Allow me to explain: | 17:10 |
| *** GumBall has left #openstack-nova | 17:11 | |
| harlowja | k | 17:11 |
| *** Nikolay_St has quit IRC | 17:11 | |
| *** coolsvap is now known as coolsvap|afk | 17:11 | |
| kashyapc | (1) Let's begin by creating a base qcow2 image: | 17:11 |
| kashyapc | $ qemu-img create -f qcow2 base.qcow2 1G | 17:11 |
| harlowja | let us begin | 17:11 |
| harlowja | should i get a VM to do this :-P | 17:11 |
| kashyapc | :-) | 17:11 |
| harlowja | k, one sec | 17:11 |
| harlowja | i play along to | 17:11 |
| kashyapc | harlowja: No, it's just a walk-through, spelling it out | 17:11 |
| harlowja | oh | 17:11 |
| harlowja | :( | 17:11 |
| harlowja | but but i wanted to play along | 17:12 |
| kashyapc | harlowja: And, it's harmless, you can do it on your physical machine :-) | 17:12 |
| harlowja | lol | 17:12 |
| harlowja | ok | 17:12 |
| *** Nic has quit IRC | 17:12 | |
| *** mpavone has quit IRC | 17:12 | |
| kashyapc | harlowja: Shall I proceed? | 17:13 |
| harlowja | sure | 17:13 |
| harlowja | lol | 17:13 |
| harlowja | i suppose :-P | 17:13 |
| kashyapc | harlowja: Okay. I presume you ran the above command and noted the 'cluster_size' | 17:13 |
| * harlowja still trying to remember my sudo password on this vm, lol | 17:13 | |
| *** Nic has joined #openstack-nova | 17:14 | |
| harlowja | anyways, k | 17:14 |
| kashyapc | harlowja: Don't need to remember, if you have `virt-edit` tool, do this ugly hack: | 17:14 |
| kashyapc | harlowja: $ virt-edit -a /path/to/disk/image /etc/passwd -e 's/^root:.*?:/root::/' | 17:14 |
| harlowja | installing qemu-kvm, lol | 17:14 |
| kashyapc | It'll remove your root password of your VM :-) | 17:14 |
| *** jistr has quit IRC | 17:14 | |
| harlowja | ya, but then i have to get to the hypervisor, more work, lol | 17:14 |
| kashyapc | harlowja: You don't need a VM, jeez | 17:15 |
| harlowja | lol | 17:15 |
| harlowja | but but | 17:15 |
| kashyapc | It's all just images, and they're not even allocated, you _won't_ run out of space. You wrote that piece of code in the above URL :-) | 17:15 |
| harlowja | :-P | 17:15 |
| kashyapc | Anyhow, | 17:16 |
| kashyapc | (2) Let's create (imagine, or real) an _overlay_ based on the above image in (1): | 17:16 |
| kashyapc | $ qemu-img create -f qcow2 -b ./base.qcow2 -o backing_fmt=qcow2 overlay1.qcow2 | 17:16 |
| kashyapc | _Also_ note down the 'cluster_size' here. | 17:16 |
| kashyapc | harlowja: Now, they both _do_ match. Is that what you were alluding to, that they didn't match, many moons ago, when you wrote that? | 17:17 |
| harlowja | ya, i think so | 17:17 |
| harlowja | maybe at some point they didn't | 17:17 |
| harlowja | TODO no longer needed, lol | 17:17 |
| kashyapc | harlowja: Okay, later, I'll send a clean-up patch. When reading code that confused me :-) | 17:18 |
| harlowja | ya, i wrote like a replacement nova in that paste.ubuntu.com url | 17:18 |
| *** VW_ has quit IRC | 17:18 | |
| harlowja | to bad nobody can find it | 17:18 |
| harlowja | super-secret software | 17:18 |
| harlowja | to bad its gone, lol | 17:18 |
| kashyapc | No worries, at-least you're here. I can chase you down and make you respond at this conversation. :-) | 17:19 |
| kashyapc | s/at/to | 17:20 |
| *** vmtrooper has joined #openstack-nova | 17:20 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Sets *DataRoot paths for instances https://review.openstack.org/162999 | 17:20 |
| harlowja | lol | 17:20 |
| *** armax has joined #openstack-nova | 17:21 | |
| *** salv-orl_ has joined #openstack-nova | 17:21 | |
| *** patrickeast has joined #openstack-nova | 17:22 | |
| *** salv-orlando has quit IRC | 17:25 | |
| *** dulek has quit IRC | 17:25 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add InstanceMapping object https://review.openstack.org/161904 | 17:25 |
| *** vmtrooper has quit IRC | 17:25 | |
| *** johnthetubaguy is now known as zz_johnthetubagu | 17:26 | |
| *** ybathia has joined #openstack-nova | 17:26 | |
| *** otter768 has joined #openstack-nova | 17:27 | |
| sdague | oh hai jogo, I was just looking at that patch as you approved it :) | 17:27 |
| *** gokrokve has quit IRC | 17:28 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add CellMapping object https://review.openstack.org/161867 | 17:28 |
| *** Mike_D_laptop has joined #openstack-nova | 17:28 | |
| jogo | sdague: hehe I thought you would like those patches | 17:28 |
| *** tonytan4ever has joined #openstack-nova | 17:28 | |
| sdague | yeh, well I just went digging for those, as I was trying to retarget our v2.1 tests on a v2 target | 17:28 |
| sdague | and they should take the errors down to a more sane number, I think | 17:29 |
| *** dsanders has quit IRC | 17:29 | |
| sdague | jogo: your pov on the paste.ini question on the list would also be appreciated, we've had a small amount of commentary there | 17:29 |
| sdague | ok, time to find lunch | 17:29 |
| jogo | sdague: I'll take a look at the paste.ini thread | 17:30 |
| *** dsanders has joined #openstack-nova | 17:31 | |
| *** otter768 has quit IRC | 17:31 | |
| bauzas | edleafe: can you help me on reviewing your series by answering a question I have that you didn't replied ? :) | 17:32 |
| *** unicell has quit IRC | 17:32 | |
| *** unicell has joined #openstack-nova | 17:33 | |
| *** packet has quit IRC | 17:33 | |
| edleafe | bauzas: which question? | 17:33 |
| bauzas | edleafe: https://review.openstack.org/#/c/160511/13/nova/scheduler/host_manager.py,cm | 17:33 |
| bauzas | edleafe: you're providing a new flag | 17:34 |
| *** achanda has joined #openstack-nova | 17:34 | |
| *** BobBall is now known as BobBall_AWOL | 17:34 | |
| bauzas | edleafe: oh I'm reading the spec, and it was silently added as work item | 17:34 |
| edleafe | bauzas: at the midcycle - jogo was concerned about impact of large in-memory demands on schedulers at large sites | 17:35 |
| bauzas | edleafe: ok seeing that in detail in the sped | 17:35 |
| bauzas | spec | 17:35 |
| bauzas | edleafe: I missed that point to be opt-out | 17:35 |
| edleafe | bauzas: sites may need to turn off that behavior if it is too much on the memory | 17:35 |
| bauzas | edleafe: I'm fine with that, btw. | 17:36 |
| *** exploreshaifali has quit IRC | 17:36 | |
| bauzas | edleafe: yeah, I was not *against* it, just wanted to make sure it was safely discussed during the spec | 17:36 |
| edleafe | bauzas: but jaypipes-afk was very much against it | 17:36 |
| edleafe | bauzas: I think he wants to remove all CONF settings :) | 17:36 |
| bauzas | edleafe: ahem, I don't want to open a can of worms | 17:37 |
| bauzas | edleafe: but I have my own opinion | 17:37 |
| edleafe | bauzas: Mmmm... worms! | 17:37 |
| bauzas | edleafe: yeah, I was saying a Pandora box until someone pointed out the right term | 17:37 |
| *** pask81 has quit IRC | 17:38 | |
| bauzas | and I like it, definitely more conceptual than someone having the same name as a webradio | 17:38 |
| edleafe | bauzas: :) | 17:38 |
| jogo | edleafe: yup, not just the in memory aspect, but also the extra RPC traffic etc. | 17:38 |
| edleafe | bauzas: I'm going to start 'Can of Worms' radio station | 17:38 |
| bauzas | edleafe: you're lucky, "Can of Worms" webradio is not available here | 17:38 |
| bauzas | jogo: that's fine by me | 17:39 |
| edleafe | bauzas: where I used to live there was a comple highway intersection, with roads passing over each other on several levels, all twisty and turny | 17:39 |
| edleafe | bauzas: the locals called that intersection the Can of Worms | 17:40 |
| bauzas | jogo: I mean, as the change is quite huge, having a conf flag sounds a good approach for making sure we can easily change the behaviour | 17:40 |
| bauzas | edleafe: :) | 17:41 |
| *** vhosakot has joined #openstack-nova | 17:43 | |
| *** afazekas has quit IRC | 17:43 | |
| *** dave-mccowan has quit IRC | 17:44 | |
| *** toure_ has joined #openstack-nova | 17:47 | |
| *** toure_ has quit IRC | 17:47 | |
| openstackgerrit | Timofey Durakov proposed openstack/nova: fixed tests in test_neutrounv2 to pass with random PYTHONHASHSEED https://review.openstack.org/160900 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: fixed tests in test_iptables_network to work with random PYTHONHASHSEED https://review.openstack.org/163352 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Refactored test in test_neutron_driver to pass with random PYTHONHASHSEED https://review.openstack.org/160901 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: refactored tests to pass in test_inject to pass with random PYTHONHASHSEED https://review.openstack.org/163354 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: fixed test in test_disk_config to work with random PYTHONHASHSEED https://review.openstack.org/160671 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: fix for vmware test_driver_api to pass with random PYTHONHASHSEED https://review.openstack.org/163357 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: fixed tests in test_simple_tenant_usage to pass with random PYTHONHASHSEED https://review.openstack.org/160897 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: fixed tests in test_matchers to pass with random PYTHONHASHSEED https://review.openstack.org/163358 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: libvirt test_cpu_info method fixed random PYTHONHASHSEED compatibility https://review.openstack.org/160669 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: refactored tests in test_wsgi to pass with random PYTHONHASHSEED https://review.openstack.org/160898 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: refactored test in vmware test_read_write_util to pass with random PYTHONHASHSEED https://review.openstack.org/163359 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Refactored test in linux_net to pass with random PYTHONHASHSEED https://review.openstack.org/160899 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: refactored tests in test_objects to pass with random PYTHONHASHSEED https://review.openstack.org/161313 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Removed 'PYTHONHASHSEED=0' from tox.ini https://review.openstack.org/163877 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Added assertJsonEqual method to TestCase class https://review.openstack.org/164210 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: fixed tests in test_instance to pass with random PYTHONHASHSEED https://review.openstack.org/161135 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Refactored test_availability_zone to work properly with random PYTHONHASHSEED https://review.openstack.org/160672 | 17:48 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Refactored tests in test_neutron_driver to pass with random PYTHONHASHSEED https://review.openstack.org/163361 | 17:48 |
| *** kaufer has joined #openstack-nova | 17:49 | |
| *** annashen has quit IRC | 17:49 | |
| vhosakot | After I run DevStack’s ./stack.sh, I see “lots and lots” of neutron and nova processes. Has anyone see this issue ? These processes are slowing the CPU. I’ve attached the processes (output of ps) here - http://paste.openstack.org/show/192944/ | 17:49 |
| dansmith | vhosakot: got lots of CPUs? | 17:50 |
| dansmith | like, say, 24? :) | 17:50 |
| *** dprince has quit IRC | 17:51 | |
| *** kaufer1 has quit IRC | 17:52 | |
| vhosakot | dansmith: wow, good point, let me check.. 1 sec please | 17:53 |
| PaulMurray | edleafe, bauzas thanks for reviewing those patches - FYI the ones with jenkins failure are due to something getting the dependencies wrong | 17:53 |
| PaulMurray | edleafe, bauzas it thinks there is a patch missing, but there isn't - recheck fixes it | 17:53 |
| PaulMurray | edleafe, bauzas don't know if you've ever seen that but it happens to me sometimes if I push a bunch of patches together - maybe my client? | 17:54 |
| mriedem | vhosakot: https://github.com/openstack-dev/devstack/blob/master/stackrc#L627 | 17:54 |
| *** dave-mccowan has joined #openstack-nova | 17:55 | |
| *** kashyapc has quit IRC | 17:55 | |
| *** gyee has joined #openstack-nova | 17:55 | |
| *** penick has quit IRC | 17:56 | |
| vhosakot | dansmith: Yes, I have 16 CPUs | 17:56 |
| dansmith | so, that looks right to me I think | 17:56 |
| mriedem | vhosakot: you should also see lots of glance and cinder workers | 17:57 |
| mriedem | maybe heat and others | 17:57 |
| mriedem | that API_WORKERS flag should set them all | 17:57 |
| *** oro has joined #openstack-nova | 17:57 | |
| *** oro_ has joined #openstack-nova | 17:58 | |
| vhosakot | mriedem: Wow, yes, I do see lots and lots of glance, cinder and heat processes too! | 17:59 |
| dansmith | why do you think they're slowing the cpu? | 17:59 |
| *** exploreshaifali has joined #openstack-nova | 17:59 | |
| dansmith | they should mostly be idle unless you're doing something | 17:59 |
| dansmith | and if you're doing something, they are there to split the load across all your CPUs.. that's the point :) | 17:59 |
| vhosakot | dansmith: hmmm... right, given that I have 16 CPUs, nothing should be slow.. but, I do see the environment slow/freeze often.. | 18:00 |
| mriedem | periodic tasks maybe | 18:00 |
| dansmith | well, I don't think it's related to the number of processes :) | 18:00 |
| mriedem | vhosakot: assuming you're running keystone with apache (default)? | 18:00 |
| vhosakot | mriedem: yes, default keystone (with apache) | 18:01 |
| *** baoli has quit IRC | 18:01 | |
| *** gokrokve has joined #openstack-nova | 18:02 | |
| *** alexpilotti has joined #openstack-nova | 18:02 | |
| *** adelinatuvenie has joined #openstack-nova | 18:03 | |
| bauzas | PaulMurray: you mean the "dependency patch has merge issue" ? | 18:03 |
| *** thomasem has joined #openstack-nova | 18:03 | |
| vhosakot | mriedem: so, al these "many many" processes are expected then ? | 18:03 |
| bauzas | PaulMurray: yeah, that's a know infra bug | 18:03 |
| *** dave-mccowan has quit IRC | 18:04 | |
| *** ildikov has quit IRC | 18:04 | |
| mriedem | vhosakot: yeah | 18:05 |
| vhosakot | mriedem, dansmith: cool, thanks a lot for all the help!! | 18:05 |
| *** baoli_ has joined #openstack-nova | 18:05 | |
| mriedem | vhosakot: if there is some operation you're doing which then stomps on everything, digging into that to find a perf issue could be useful | 18:06 |
| *** aix has quit IRC | 18:06 | |
| mriedem | assuming standard rabbit + mysql setup | 18:06 |
| mriedem | mongodb with ceilometer | 18:06 |
| *** Nikolay_St has joined #openstack-nova | 18:08 | |
| *** krykowski has quit IRC | 18:09 | |
| *** dprince has joined #openstack-nova | 18:12 | |
| *** sbfox has quit IRC | 18:13 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Expand help message on some quota config options https://review.openstack.org/165170 | 18:14 |
| *** vhosakot has quit IRC | 18:14 | |
| *** dboik has quit IRC | 18:14 | |
| *** sdake__ has joined #openstack-nova | 18:14 | |
| *** achanda has quit IRC | 18:16 | |
| *** baoli_ has quit IRC | 18:16 | |
| *** sdake has quit IRC | 18:18 | |
| *** tjones1 has joined #openstack-nova | 18:18 | |
| *** penick has joined #openstack-nova | 18:18 | |
| *** penick has left #openstack-nova | 18:18 | |
| *** tjones1 has left #openstack-nova | 18:19 | |
| *** fdelvale has quit IRC | 18:21 | |
| *** achanda has joined #openstack-nova | 18:21 | |
| *** ijw has joined #openstack-nova | 18:23 | |
| *** dave-mccowan has joined #openstack-nova | 18:25 | |
| *** Marga_ has joined #openstack-nova | 18:31 | |
| dansmith | jerdfelt: are you working on a patch for the nova-manage UX issues? | 18:31 |
| *** ajayaa has quit IRC | 18:33 | |
| *** dboik has joined #openstack-nova | 18:34 | |
| *** baoli has joined #openstack-nova | 18:34 | |
| *** welldannit has joined #openstack-nova | 18:35 | |
| *** sbfox has joined #openstack-nova | 18:36 | |
| *** dboik has quit IRC | 18:36 | |
| *** dboik has joined #openstack-nova | 18:36 | |
| *** baoli_ has joined #openstack-nova | 18:37 | |
| *** gokrokve has quit IRC | 18:38 | |
| *** packet has joined #openstack-nova | 18:39 | |
| edleafe | jaypipes: got a few minutes to review the changes to https://review.openstack.org/#/c/160511 ? | 18:39 |
| *** baoli has quit IRC | 18:39 | |
| edleafe | jaypipes: I believe that I've addressed all of your concerns | 18:39 |
| *** dboik has quit IRC | 18:41 | |
| *** welldannit has quit IRC | 18:41 | |
| *** dboik has joined #openstack-nova | 18:41 | |
| *** welldannit has joined #openstack-nova | 18:41 | |
| *** dboik has quit IRC | 18:41 | |
| dansmith | alaski: for what it's worth, on the timestamp object, | 18:42 |
| dansmith | alaski: I thought you were going to create it so that NovaObject -> TimestampObject -> PersistentObject -> Instance (for example) | 18:42 |
| dansmith | so that PersistentObject would just add in deleted/deleted_at | 18:43 |
| dansmith | but it's cool the way it is | 18:43 |
| *** annashen has joined #openstack-nova | 18:43 | |
| *** dboik has joined #openstack-nova | 18:43 | |
| alaski | well, that would have required modifying all of the current objects to not take NovaObject | 18:44 |
| dansmith | why/ | 18:44 |
| dansmith | all the existing ones that inherit from PersistentObject would still, and would have the same set of fields in the end, no? | 18:45 |
| *** dboik has quit IRC | 18:45 | |
| *** sdake has joined #openstack-nova | 18:45 | |
| *** dboik has joined #openstack-nova | 18:45 | |
| mriedem | alaski: on https://review.openstack.org/#/c/157755/ - another network system being...nova-network? | 18:45 |
| alaski | yeah, I suppose it would work out they would just be inheriting twice for no reason | 18:45 |
| mriedem | or alaski's fancy pants out of tree network API? | 18:45 |
| jaypipes | edleafe: will do this evening. sorry, busy right now with non $work stuff.... | 18:46 |
| dansmith | alaski: well, I dunno about no reason, but whatever, it doesn't matter :D | 18:46 |
| edleafe | jaypipes: appreciate it | 18:46 |
| alaski | mriedem: heh, I didn't really have a particular thing in mind. just that's it's extensible | 18:46 |
| mriedem | i will accept jordache as an answer for fancy pants | 18:46 |
| dansmith | lol | 18:46 |
| edleafe | jaypipes: I'll be on and off this evening | 18:46 |
| *** sdake__ has quit IRC | 18:48 | |
| alaski | dansmith: so really that main problem was that if PersistentObject inherited from a mixin with fields defined then classes inheriting from PersistentObject only got one set of fields | 18:49 |
| alaski | dansmith: the way fields are defined would need to be modified a bit to support that sort of multiple inheritance | 18:50 |
| alaski | I looked at it a bit but it started getting messy quickly | 18:50 |
| dansmith | alaski: if we take instance for .. instance (hah!), if we didn't have dict, there would be only one inheritance path back to novaobject, right? | 18:50 |
| dansmith | with dict, the dict mixin is the only extra one and it doesn't bring any fields, so it'd be okay right? | 18:50 |
| *** lsmola has quit IRC | 18:52 | |
| alaski | dansmith: if PersistentObject inherited from NovaObject then there would be two paths back | 18:52 |
| *** jcoufal has quit IRC | 18:53 | |
| *** gokrokve has joined #openstack-nova | 18:53 | |
| alaski | or from TimestampMixin, inheriting from NovaObject | 18:53 |
| dansmith | OH, I see, I didn't think we were using persistent as a mixin | 18:53 |
| dansmith | no idea why we are, but that explains it | 18:53 |
| dansmith | damn glad I already +2d that patch! :) | 18:54 |
| alaski | heh | 18:54 |
| *** matrohon has joined #openstack-nova | 18:54 | |
| *** pixelb has joined #openstack-nova | 18:54 | |
| alaski | where would you expect PersistentObject to be used? | 18:55 |
| dansmith | if persistentobject inherited from novaobject, | 18:55 |
| dansmith | then instance would only have to inherit from persistent | 18:55 |
| dansmith | which is what I thought was going on because I didn't bother to look | 18:56 |
| alaski | gotcha | 18:56 |
| *** rushiagr is now known as rushiagr_away | 18:59 | |
| openstackgerrit | Sai Kiran proposed openstack/python-novaclient: Display security group id in 'nova show' output https://review.openstack.org/157383 | 19:00 |
| alaski | mriedem: I had to look up your fancy pants btw. I was apparently not hip back in the day | 19:01 |
| mriedem | jordache? | 19:01 |
| dansmith | back in the day? | 19:01 |
| dansmith | mriedem still wears his jordache proudly, I'm sure | 19:02 |
| mriedem | loud and proud | 19:02 |
| alaski | wikipedia says they were popular in the 70s/80s | 19:02 |
| dansmith | http://www.nbc.com/saturday-night-live/video/mom-jeans/n11727 | 19:02 |
| mriedem | hey, i didn't need to be alive in the 40s and 50s to know pomade was the shit | 19:02 |
| dansmith | hmm, 70s? | 19:03 |
| dansmith | I would have thought they were purely an 80s thing | 19:03 |
| mriedem | alaski: this is probably more our speed http://www.ebay.com/bhp/mens-girbaud-jeans | 19:04 |
| mriedem | given i don't know how old you really are | 19:04 |
| alaski | I'm a child of the 80s | 19:05 |
| mriedem | so the he-man you tubes i was watching yesterday in private should have been linked here in public | 19:06 |
| alaski | definitely | 19:06 |
| alaski | jncos were all the rage when I was in high school | 19:06 |
| dansmith | oh man, I remember jncos | 19:07 |
| mriedem | ha https://www.youtube.com/watch?v=3uEdaM1cJnA | 19:07 |
| mriedem | oh skeletor | 19:07 |
| mriedem | that's what it's like when i drop off at daycare each morning | 19:08 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: libvirt: partial fix for live-migration with config drive https://review.openstack.org/133919 | 19:08 |
| dims | melwitt: thanks fixed ^^ | 19:08 |
| *** Marga_ has quit IRC | 19:08 | |
| *** vmtrooper has joined #openstack-nova | 19:08 | |
| *** annashen has quit IRC | 19:09 | |
| dansmith | mriedem: well, that's 2:03 I'll never get back | 19:09 |
| alaski | mriedem: that bear looks like it was added later as a joke | 19:10 |
| mriedem | yeah, maybe special guest star | 19:10 |
| mriedem | baron von bear | 19:10 |
| *** signed8bit has joined #openstack-nova | 19:11 | |
| openstackgerrit | Sai Kiran proposed openstack/python-novaclient: Display security group id in 'nova show' output https://review.openstack.org/157383 | 19:12 |
| *** vmtrooper has quit IRC | 19:13 | |
| *** pixelb has quit IRC | 19:15 | |
| *** sbfox has quit IRC | 19:16 | |
| *** lpetrut has joined #openstack-nova | 19:16 | |
| *** packet has quit IRC | 19:16 | |
| *** exploreshaifali has quit IRC | 19:17 | |
| *** mleroy_ has joined #openstack-nova | 19:18 | |
| *** Nikolay_St has quit IRC | 19:19 | |
| mriedem | ugh, can i say i'm sick and tired of these mfing neutron dbdeadlock errors on this mfing plane yet? | 19:19 |
| *** dboik has quit IRC | 19:20 | |
| openstackgerrit | Sai Kiran proposed openstack/python-novaclient: Display security group id in server details https://review.openstack.org/157383 | 19:20 |
| *** dboik has joined #openstack-nova | 19:20 | |
| *** aix has joined #openstack-nova | 19:21 | |
| *** yamahata has quit IRC | 19:22 | |
| *** oro_ has quit IRC | 19:24 | |
| *** oro has quit IRC | 19:24 | |
| *** Nikolay_St has joined #openstack-nova | 19:24 | |
| *** jcoufal has joined #openstack-nova | 19:26 | |
| *** marun has quit IRC | 19:28 | |
| *** oro has joined #openstack-nova | 19:28 | |
| *** marun has joined #openstack-nova | 19:29 | |
| *** dboik has quit IRC | 19:31 | |
| *** promulo__ is now known as promulo | 19:31 | |
| *** dboik has joined #openstack-nova | 19:31 | |
| mriedem | relatively easy if not somewhat tedious review https://review.openstack.org/#/c/138934/ | 19:32 |
| *** achanda has quit IRC | 19:33 | |
| *** neelashah has quit IRC | 19:33 | |
| mriedem | i swear i saw something recently related to the scheduler work where i thought some of these db apis were being removed https://review.openstack.org/#/c/159762/ | 19:37 |
| mriedem | edleafe: ^? sound familiar? | 19:37 |
| mriedem | like ndipanov had something | 19:37 |
| *** matrohon has quit IRC | 19:37 | |
| edleafe | mriedem: looking... | 19:38 |
| *** Nikolay_St has quit IRC | 19:38 | |
| edleafe | mriedem: nope - doesn't ring a bell | 19:40 |
| *** Nikolay_St has joined #openstack-nova | 19:40 | |
| *** sbfox has joined #openstack-nova | 19:41 | |
| *** yamahata has joined #openstack-nova | 19:41 | |
| *** casusbelli has joined #openstack-nova | 19:43 | |
| *** andreykurilin_ has joined #openstack-nova | 19:45 | |
| *** Nikolay_St has quit IRC | 19:46 | |
| *** Nikolay_St has joined #openstack-nova | 19:46 | |
| dansmith | bauzas: just hit a merge conflict halfway through my context series, FYI :) | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in ec2 object https://review.openstack.org/164245 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in fixed_ip, flavor, floating_ip https://review.openstack.org/164246 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in instance* objects https://review.openstack.org/164247 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in compute_node, keypair https://review.openstack.org/164248 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in migration, network https://review.openstack.org/164249 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in pci_device, quotas https://review.openstack.org/164250 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in security_group* https://review.openstack.org/164251 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in service, tag, vif https://review.openstack.org/164252 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Actually stop passing context to remotable methods https://review.openstack.org/164253 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Remove context from remotable call signature https://review.openstack.org/164268 | 19:47 |
| mriedem | oy | 19:47 |
| mriedem | dansmith: which patch was it? | 19:48 |
| mriedem | first i guess, ec2 | 19:48 |
| dansmith | the ec2 one | 19:48 |
| bauzas | dansmith: oh oh | 19:48 |
| dansmith | yeah | 19:48 |
| *** dboik has quit IRC | 19:48 | |
| mriedem | weird, diff between ps2 and p3 are the same | 19:48 |
| bauzas | dansmith: you wanted me to have a better number of reviews for my stats eh ? :D | 19:49 |
| dansmith | cgit was able to rebase it, jgit was not | 19:49 |
| *** dboik has joined #openstack-nova | 19:49 | |
| dansmith | bauzas: no, jenkins did :) | 19:49 |
| bauzas | dansmith: eh eh, let me then give a bribe to the man behind Jenkins | 19:50 |
| dansmith | heh | 19:50 |
| edleafe | dansmith: I think gerrit gets confused | 19:50 |
| dansmith | edleafe: it uses a different git implementation that isn't as good at merging | 19:51 |
| bauzas | dansmith: seriously, I really want to give you my voice but I don't want to be looking like I would like to gamify | 19:51 |
| bauzas | call my shy | 19:51 |
| bauzas | me* | 19:51 |
| dansmith | bauzas: I think your +1s are still there anyway | 19:51 |
| bauzas | dansmith: oh right, if that's just a rebase | 19:52 |
| mriedem | everythign is the same, it's a trivial rebase | 19:52 |
| bauzas | then that's okay | 19:52 |
| *** annashen has joined #openstack-nova | 19:52 | |
| *** dboik has quit IRC | 19:54 | |
| *** ZZelle_ has joined #openstack-nova | 19:55 | |
| *** dboik has joined #openstack-nova | 19:55 | |
| *** overlayer has joined #openstack-nova | 19:56 | |
| *** matrohon has joined #openstack-nova | 19:59 | |
| *** vladikr has quit IRC | 19:59 | |
| *** overlayer has quit IRC | 19:59 | |
| *** dboik_ has joined #openstack-nova | 20:00 | |
| *** igordcard_ has joined #openstack-nova | 20:00 | |
| *** renatoarmani has joined #openstack-nova | 20:01 | |
| *** dboik has quit IRC | 20:02 | |
| *** melwitt_ has joined #openstack-nova | 20:04 | |
| *** melwitt has quit IRC | 20:05 | |
| mriedem | edleafe: i think was i was thinking maybe is there was a patch that consolidated the usage of service_get_all_by_topic|host and just uses service_get_all_by_binary now | 20:05 |
| *** melwitt_ is now known as melwitt | 20:05 | |
| mriedem | *what i was thinking | 20:05 |
| edleafe | mriedem: ah, dansmith | 20:06 |
| edleafe | ugh | 20:06 |
| edleafe | mriedem: dansmith's patch | 20:06 |
| mriedem | https://github.com/openstack/nova/commit/3a28a184a0bc0192f1f967e7a92d5e101c6edf76 | 20:06 |
| mriedem | yeah | 20:06 |
| dansmith | did I break somethng? | 20:06 |
| mriedem | no | 20:06 |
| edleafe | for once | 20:06 |
| mriedem | i was reviewing https://review.openstack.org/#/c/159762/ and looking for usage of those db apis | 20:07 |
| mriedem | or lack thereof | 20:07 |
| *** jcoufal has quit IRC | 20:07 | |
| *** fifieldt has quit IRC | 20:08 | |
| *** aix has quit IRC | 20:09 | |
| *** neelashah has joined #openstack-nova | 20:10 | |
| *** Nikolay_St has quit IRC | 20:10 | |
| *** Nikolay_St has joined #openstack-nova | 20:11 | |
| bauzas | mriedem: help needed for get_by_topic stuff ? | 20:13 |
| *** unicell has quit IRC | 20:14 | |
| bauzas | mriedem: it comes from a patch from my series where I was using get_by_topic and dansmith helped me reworking this by creating get_by_binary because he disliked using a CONF opt | 20:14 |
| *** unicell has joined #openstack-nova | 20:14 | |
| bauzas | mriedem: I also used an elevated context for calling these, but it was unnecessary | 20:15 |
| mriedem | bauzas: no, not an issue | 20:15 |
| *** ildikov has joined #openstack-nova | 20:15 | |
| mriedem | i just knew i had seen dan's patch awhile back and i remembered it while reviewing alex's api policy change | 20:15 |
| bauzas | mriedem: I should rather had to use a simple RequestContext | 20:15 |
| bauzas | mriedem: understood, I was just there for giving a status | 20:16 |
| openstackgerrit | Josh Gachnang proposed openstack/nova: Adjust resource tracker for new Ironic states https://review.openstack.org/164313 | 20:17 |
| *** diegows has joined #openstack-nova | 20:17 | |
| *** mrda-away is now known as mrda | 20:18 | |
| *** achanda has joined #openstack-nova | 20:19 | |
| *** sdake__ has joined #openstack-nova | 20:21 | |
| *** fifieldt has joined #openstack-nova | 20:21 | |
| *** dboik_ has quit IRC | 20:22 | |
| *** dboik has joined #openstack-nova | 20:22 | |
| *** sdake has quit IRC | 20:25 | |
| *** r-daneel has quit IRC | 20:25 | |
| *** aix has joined #openstack-nova | 20:25 | |
| flwang | dansmith: jaypipes: pls revisit the nova backup fix https://review.openstack.org/164494 at your most convenience, thanks | 20:26 |
| *** dboik has quit IRC | 20:26 | |
| *** dboik has joined #openstack-nova | 20:26 | |
| mriedem | flwang: looking | 20:29 |
| flwang | mriedem: you're always the superman | 20:29 |
| mriedem | haha, that i'm sure is not an overstatement | 20:30 |
| *** Nikolay_1t has joined #openstack-nova | 20:30 | |
| mriedem | but let's not talk about my need to wear fully body spandex under my normal clothes all of the time | 20:30 |
| *** Nikolay_St has quit IRC | 20:31 | |
| flwang | you know, to be superman is not very hard, you just need to put the underpants outside the normal clothes | 20:32 |
| mriedem | good point | 20:33 |
| *** dboik has quit IRC | 20:35 | |
| *** dboik has joined #openstack-nova | 20:36 | |
| *** romainh has left #openstack-nova | 20:37 | |
| mrodden | if i get to the office tomorrow and mriedem is running around making whoosh noises in his underwear... | 20:37 |
| *** raildo is now known as raildo_away | 20:37 | |
| flwang | mrodden: hey, how are you? man | 20:38 |
| *** tjones1 has joined #openstack-nova | 20:38 | |
| mrodden | flwang, been keeping pretty busy | 20:38 |
| flwang | mrodden: hope everything is good for you guys | 20:39 |
| mrodden | trying to fix the volume-backup interaction i see | 20:40 |
| mriedem | flwang: small -1 in there | 20:40 |
| flwang | mriedem: I love -1 :) | 20:41 |
| *** neelashah has quit IRC | 20:41 | |
| flwang | i will eat it as my lunch | 20:41 |
| *** dave-mccowan has quit IRC | 20:41 | |
| *** dprince has quit IRC | 20:41 | |
| *** Bsony has quit IRC | 20:42 | |
| *** boris-42 has quit IRC | 20:42 | |
| *** achanda has quit IRC | 20:44 | |
| *** achanda has joined #openstack-nova | 20:45 | |
| *** kaufer has quit IRC | 20:45 | |
| *** kaufer has joined #openstack-nova | 20:45 | |
| *** sdake has joined #openstack-nova | 20:45 | |
| *** sdake__ has quit IRC | 20:49 | |
| *** kaufer has left #openstack-nova | 20:49 | |
| openstackgerrit | jichenjc proposed openstack/nova: Change some comments for instance param https://review.openstack.org/165213 | 20:50 |
| mriedem | i know where that idea came from ^ | 20:55 |
| *** mestery has quit IRC | 20:55 | |
| dims | mriedem: nothing gets past you :) | 20:56 |
| mriedem | he fixed it before i had a chance | 20:56 |
| dims | haha | 20:56 |
| *** vmtrooper has joined #openstack-nova | 20:58 | |
| *** dkliban is now known as dkliban_afk | 20:58 | |
| *** thomasem has quit IRC | 20:58 | |
| *** mestery has joined #openstack-nova | 20:59 | |
| *** alexpilotti has quit IRC | 21:00 | |
| *** eglynn-pto is now known as eglynn | 21:01 | |
| *** alexpilotti has joined #openstack-nova | 21:02 | |
| *** vmtrooper has quit IRC | 21:02 | |
| *** harlowja has quit IRC | 21:03 | |
| *** alexpilotti has quit IRC | 21:03 | |
| *** harlowja_ has joined #openstack-nova | 21:03 | |
| *** kaufer has joined #openstack-nova | 21:04 | |
| bauzas | so flights booked for Vancouver, I don't have to buy a canoe | 21:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Log exception from deallocate_port_for_instance for triage https://review.openstack.org/164738 | 21:05 |
| *** alexpilotti has joined #openstack-nova | 21:06 | |
| *** ybathia has quit IRC | 21:06 | |
| mriedem | a canoe would help with any fur trapping going on while you're there | 21:06 |
| *** ybathia has joined #openstack-nova | 21:06 | |
| mriedem | b/c that's what i think of when i think of french guys + canada | 21:06 |
| *** alexpilotti has quit IRC | 21:06 | |
| mriedem | + canoe | 21:06 |
| *** mpavone has joined #openstack-nova | 21:07 | |
| bauzas | erm, I should indeed ask Lufthansa for traveling with a canoe | 21:08 |
| *** oro_ has joined #openstack-nova | 21:08 | |
| *** oro_ has quit IRC | 21:08 | |
| bauzas | mriedem: do you know that the Grenoble hockey team is called the "Wolves burners" ? | 21:08 |
| mriedem | unsurprisingly i didn't know that :) | 21:09 |
| bauzas | mriedem: they're on the same competition with the Villard Bears | 21:09 |
| bauzas | because we had wolves and bears | 21:09 |
| *** kaufer has quit IRC | 21:09 | |
| mriedem | as in, literally wolves and bears are a problem around those parts? | 21:10 |
| mriedem | or they just sound like bad ass mascots? | 21:10 |
| *** kaufer has joined #openstack-nova | 21:10 | |
| *** adelinatuvenie has quit IRC | 21:10 | |
| bauzas | mriedem: http://en.wikipedia.org/wiki/Br%C3%BBleurs_de_Loups | 21:10 |
| *** mmedvede has quit IRC | 21:11 | |
| bauzas | mriedem: mmm, they were a problem like 2 centuries ago, now they're just parked | 21:12 |
| mriedem | gilliard: do you know if dave mcnally or anyone else at HP was going to pick this up? https://bugs.launchpad.net/nova/+bug/1243306 | 21:12 |
| openstack | Launchpad bug 1243306 in OpenStack Compute (nova) "consoleauth cannot be run in HA configuration without external memcache" [Wishlist,Confirmed] | 21:12 |
| *** kaufer has quit IRC | 21:12 | |
| *** kaufer has joined #openstack-nova | 21:13 | |
| *** kaufer has quit IRC | 21:13 | |
| *** kaufer has joined #openstack-nova | 21:13 | |
| *** aysyd has quit IRC | 21:14 | |
| *** lpetrut has quit IRC | 21:15 | |
| *** lpetrut has joined #openstack-nova | 21:16 | |
| *** mmedvede has joined #openstack-nova | 21:18 | |
| *** iamjarvo has joined #openstack-nova | 21:20 | |
| *** lpetrut has quit IRC | 21:20 | |
| *** rfolco has quit IRC | 21:22 | |
| *** annashen has quit IRC | 21:23 | |
| mriedem | jerdfelt: now that we have test_models_sync, it seems we could remove this right? http://git.openstack.org/cgit/openstack/nova/tree/tools/db/schema_diff.py | 21:25 |
| *** oro_ has joined #openstack-nova | 21:25 | |
| mriedem | i.e. even if we compact the migrations, test_models_sync will verify the migrations match the model | 21:25 |
| *** neelashah has joined #openstack-nova | 21:25 | |
| *** thangp has quit IRC | 21:27 | |
| *** eharney has quit IRC | 21:27 | |
| *** otter768 has joined #openstack-nova | 21:29 | |
| *** Marga_ has joined #openstack-nova | 21:31 | |
| *** otter768 has quit IRC | 21:33 | |
| *** SwimmingDolphin has joined #openstack-nova | 21:39 | |
| *** nellysmitt has quit IRC | 21:40 | |
| *** signed8bit has quit IRC | 21:41 | |
| *** nellysmitt has joined #openstack-nova | 21:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Remove the schema_diff script https://review.openstack.org/165229 | 21:45 |
| *** nellysmitt has quit IRC | 21:46 | |
| bauzas | mriedem: jerdfelt: btw. what do you think about removing the sqlite unittests for test_models_sync ? | 21:46 |
| mriedem | bauzas: i don't | 21:46 |
| *** dboik has quit IRC | 21:46 | |
| mriedem | at least not in Kilo | 21:46 |
| mriedem | i'm not running unit tests locally with mysql or pg | 21:46 |
| bauzas | mriedem: yeah I think so too, but maybe we should discuss with oslo.db people nope ? | 21:46 |
| *** dboik has joined #openstack-nova | 21:46 | |
| mriedem | as far as? | 21:47 |
| bauzas | mriedem: well, my devstack can run the migration tests | 21:47 |
| mriedem | it can run the migrations | 21:47 |
| bauzas | mriedem: well, it's easy to setup the unittests for mysql | 21:48 |
| bauzas | provided you have a devstack VM | 21:48 |
| bauzas | but agreed, it could be a problem if we would just remove sqlite now | 21:48 |
| *** kaufer has quit IRC | 21:49 | |
| mriedem | i don't have a devstack vm for my day to day stuff when what i'm working on doesn't require some integration testing | 21:49 |
| bauzas | mriedem: my point is to say that instead of overriding the test and passing it, we should maybe discuss wiht oslo.db guys and tell them the problems that we have with this | 21:49 |
| mriedem | i used to and the thing always got borked | 21:49 |
| bauzas | mriedem: because test_models_sync is actually an oslo.db method | 21:50 |
| *** SwimmingDolphin has quit IRC | 21:50 | |
| bauzas | mriedem: agreed on not requriring a devstack VM for day-to-day stuff, but I think that db migrations is not a d2d stuff :) | 21:50 |
| mriedem | yeah test_models_sync is in oslo.db, but it runs against sqlite too right? | 21:51 |
| mriedem | http://logs.openstack.org/23/153123/8/check/gate-nova-python27/e1cc1a4/console.html#_2015-03-14_12_38_48_559 | 21:51 |
| bauzas | mriedem: it runs against sqlite because we are having a TestCase having a mixin dependency with an oslo.db testcase | 21:52 |
| *** iamjarvo has quit IRC | 21:52 | |
| *** gokrokve has quit IRC | 21:52 | |
| mriedem | sure | 21:53 |
| mriedem | so the proposal is don't run it against sqlite b/c sqlite doesn't support alter statements like the other backends right? | 21:53 |
| *** FreeCandy has joined #openstack-nova | 21:53 | |
| *** FreeCandy has quit IRC | 21:53 | |
| mriedem | and when we run into blocking issues with those it's a pain in the ass | 21:53 |
| *** FreeCandy has joined #openstack-nova | 21:53 | |
| *** FreeCandy has quit IRC | 21:53 | |
| *** FreeCandy has joined #openstack-nova | 21:54 | |
| mriedem | if you're not on alembic or sqlalchemy >= 1.0.0 and sqlalchemy-migrate isn't up to date | 21:54 |
| *** FreeCandy has joined #openstack-nova | 21:54 | |
| *** FreeCandy has joined #openstack-nova | 21:54 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: Implement instance update logic in Scheduler https://review.openstack.org/160511 | 21:55 |
| jaypipes | edleafe: ^^ I just added to the commit message about DoCImpact, nothing else. | 21:55 |
| *** asettle has joined #openstack-nova | 21:55 | |
| jaypipes | dansmith: https://review.openstack.org/#/c/160511/ was +1d by you earlier... just FYI, I filled in some commentary in the commit message for the doc team, otherwise made no changes to it. | 21:56 |
| dansmith | jaypipes: dude you're so 30 seconds late | 21:56 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Add the RPC calls for instance updates. https://review.openstack.org/160507 | 21:56 |
| jaypipes | dansmith: hmm? | 21:56 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Modify filters to get instance info from HostState https://review.openstack.org/160512 | 21:57 |
| dansmith | jaypipes: had already hit it after your update | 21:57 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Add the instance update calls from Compute https://review.openstack.org/160513 | 21:57 |
| jaypipes | dansmith: ah :) | 21:57 |
| jaypipes | thx | 21:57 |
| bauzas | jaypipes: dansmith: edleafe: okay, I'm now +1 | 21:58 |
| *** burt has quit IRC | 21:59 | |
| bauzas | I mean, having all the logic in the HostManager is cool by me | 22:00 |
| *** jcru has quit IRC | 22:00 | |
| jaypipes | dansmith: https://review.openstack.org/#/c/160507/ is also ready. | 22:01 |
| jaypipes | bauzas: yeah, I think that's a better long-term design... | 22:01 |
| dansmith | jaypipes: yeah, I haven't reviewed that one yet | 22:01 |
| bauzas | jaypipes: agreed, I was just looking at the spec | 22:01 |
| jaypipes | dansmith: yeah, no worries... | 22:01 |
| bauzas | jaypipes: basically comparing the spec and the implementation | 22:01 |
| *** neelashah has quit IRC | 22:02 | |
| bauzas | as the spec was over discussed | 22:02 |
| bauzas | uber discussed should I say even | 22:02 |
| bauzas | the rest was nitpicking, hence my +1 | 22:03 |
| dansmith | jaypipes: edleafe: that one can't work | 22:03 |
| *** dboik has quit IRC | 22:03 | |
| dansmith | jaypipes: edleafe: RPC versions are wrong | 22:03 |
| jaypipes | dansmith: ? how so? | 22:03 |
| dansmith | manager is still at 4.1 | 22:03 |
| dansmith | rpc is sending 4.2 | 22:03 |
| *** dboik has joined #openstack-nova | 22:03 | |
| *** ijw has quit IRC | 22:03 | |
| jaypipes | ahhhh | 22:04 |
| *** eglynn is now known as eglynn-afk | 22:04 | |
| bauzas | dansmith: you beated me by a second | 22:04 |
| jaypipes | doh, nice catch. sorry abotu that | 22:04 |
| dansmith | looks like the bump is later in the patch, maybe a rebase casualty | 22:04 |
| jaypipes | yeah | 22:04 |
| dansmith | so yeah, needs to move back with the rpc change | 22:04 |
| dansmith | later in the set, I mean | 22:04 |
| *** oro has quit IRC | 22:04 | |
| *** ijw has joined #openstack-nova | 22:05 | |
| *** welldannit has quit IRC | 22:05 | |
| bauzas | dansmith: yeah, that's because I asked to flip the patches | 22:06 |
| dansmith | bauzas: ah, so it's your fault, eh? :) | 22:06 |
| *** oro_ has quit IRC | 22:06 | |
| bauzas | dansmith: yeah, the RPC patch was provided before the HostManager methods | 22:06 |
| *** ijw has quit IRC | 22:06 | |
| dansmith | they really should be in the same patch, yeah | 22:06 |
| bauzas | dansmith: so edleafe flipped those patches | 22:07 |
| *** ijw has joined #openstack-nova | 22:07 | |
| dansmith | jaypipes: edleafe said he'd be in and out tonight. do you need me to fix those or are you on it? | 22:07 |
| jaypipes | dansmith: I can, no problemo. | 22:07 |
| dansmith | okay | 22:08 |
| *** asettle has quit IRC | 22:08 | |
| *** mpavone has quit IRC | 22:09 | |
| *** harlowja_ has quit IRC | 22:09 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: Add the RPC calls for instance updates. https://review.openstack.org/160507 | 22:09 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Modify filters to get instance info from HostState https://review.openstack.org/160512 | 22:09 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Add the instance update calls from Compute https://review.openstack.org/160513 | 22:09 |
| jaypipes | dansmith: done. | 22:10 |
| dansmith | yup | 22:10 |
| jaypipes | dansmith: danke. | 22:10 |
| *** harlowja has joined #openstack-nova | 22:11 | |
| mriedem | oh lab services people.... | 22:12 |
| bauzas | jaypipes: dansmith: what do you think about flipping the last 2 patches in the series | 22:12 |
| bauzas | ? | 22:12 |
| mriedem | 'how do i allow the admin to pick which vmware datastore they want to schedule instances to from horizon'? | 22:12 |
| *** hblixt has joined #openstack-nova | 22:13 | |
| bauzas | jaypipes: I would prefer to only change the filters once we are sure that the RPC calls are actually done | 22:13 |
| mriedem | 'what do you mean nova doesn't have an api to show all the vmware datastores?!' | 22:13 |
| dansmith | mriedem: heh | 22:13 |
| jaypipes | mriedem: tell them "Ctrl-Alt-Del, then hit Enter." | 22:13 |
| mriedem | i want to say, i'd tell your customer to use vcenter | 22:13 |
| mriedem | i think i actually did say that... | 22:13 |
| mriedem | or maybe the vmware distro, i'm assuming it might have fun knobs like that to help transition people to openstack | 22:14 |
| jaypipes | lol, unlikely. | 22:14 |
| jaypipes | more the other way around. | 22:14 |
| edleafe | me is back | 22:17 |
| edleafe | jaypipes: need me to fix it? | 22:17 |
| *** Marga_ has quit IRC | 22:17 | |
| *** Marga_ has joined #openstack-nova | 22:18 | |
| *** Marga_ has quit IRC | 22:18 | |
| dansmith | edleafe: I'm going to have another -1 on the top patch you can fix :) | 22:18 |
| jaypipes | edleafe: nope. all done :) | 22:18 |
| edleafe | dansmith: gee thanks! :) | 22:19 |
| *** Marga_ has joined #openstack-nova | 22:19 | |
| dansmith | edleafe: done | 22:21 |
| *** jgrimm is now known as zz_jgrimm | 22:21 | |
| bauzas | so sounds like we don't need to flip the patches because you both +W these ? :) | 22:21 |
| bauzas | eh | 22:22 |
| dansmith | oh, sorry, I missed your comment | 22:23 |
| dansmith | just a sec | 22:23 |
| *** nelsnelson has quit IRC | 22:23 | |
| edleafe | dansmith: really? Fixing the one line that uses an inconsistent continuation pattern when I'm changing that call is worth a -1? | 22:23 |
| *** annashen has joined #openstack-nova | 22:23 | |
| dansmith | edleafe: clean it up in another patch.. if I blame that file, it will look like that line changed in a giant scheduler change and I won't understand in a year | 22:24 |
| dansmith | edleafe: I'll effing fix it if it's that big of a deal | 22:24 |
| edleafe | dansmith: of course not | 22:24 |
| *** harlowja has quit IRC | 22:24 | |
| *** harlowja_ has joined #openstack-nova | 22:24 | |
| dansmith | bauzas: the filters still work without the rpc because of the startup update logic, right? | 22:24 |
| dansmith | bauzas: you're probably right about the ordering though | 22:25 |
| dansmith | bauzas: if you can convince edleafe I'll stand by to re-apply votes :) | 22:25 |
| bauzas | dansmith: well yeah but I was thinking it would be better to see the filters updated *because of RPC* and not because we had an intermediate way in HostManager | 22:26 |
| *** mleroy_ has quit IRC | 22:26 | |
| dansmith | yes, you're right | 22:26 |
| edleafe | dansmith: convince me of what? | 22:26 |
| bauzas | that said, I'm only concerned because we're close enough to FF | 22:26 |
| bauzas | so provided we can safely merge both *before* FF, I actually don't care | 22:26 |
| bauzas | but my point is to say it would be horrible if we would not have the last patch before we're freezing Kilo | 22:27 |
| bauzas | of course, it should not be a problem because we can still ask for an exception | 22:27 |
| *** adrian_otto has joined #openstack-nova | 22:28 | |
| dansmith | bauzas: we'd revert the filter change if the RPC one didn't make it and we weren't going to put it in, right? | 22:28 |
| dansmith | so probably not a huge deal | 22:28 |
| *** annashen has quit IRC | 22:28 | |
| *** jecarey has quit IRC | 22:30 | |
| bauzas | dansmith: agreed | 22:30 |
| jaypipes | edleafe: https://review.openstack.org/#/c/160513/ reviewed. | 22:30 |
| bauzas | dansmith: that's why I'm discussing it off-gerrit | 22:30 |
| edleafe | jaypipes: thx | 22:31 |
| devananda | hey, question for ya'll ... i know it's well past nova's feature freeze, but if we were able to finally close this bug https://bugs.launchpad.net/ironic/+bug/1174153 | 22:31 |
| openstack | Launchpad bug 1174153 in Ironic "data from previous tenants accessible with nova baremetal" [High,Triaged] | 22:31 |
| devananda | with changes isolated to the ironic driver, is there a chance we could get that in before kilo release? | 22:31 |
| devananda | dansmith: ^ ? | 22:31 |
| openstackgerrit | Josh Gachnang proposed openstack/nova: Add support for cleaning in Ironic driver https://review.openstack.org/161474 | 22:31 |
| mriedem | devananda: it's a bug fix right? | 22:32 |
| mriedem | there isn't a bug fix freeze | 22:32 |
| devananda | mriedem: from nova's POV, yes. | 22:32 |
| *** ijw has quit IRC | 22:32 | |
| mikal | So, we promised to do a novaclient release this week | 22:32 |
| devananda | it required a lot of feature work in Ironic | 22:32 |
| mriedem | devananda: is there a patch up for review? | 22:32 |
| mikal | melwitt: has that bug fix we were waiting for landed yet? | 22:32 |
| devananda | but yea, in nova, it's "oh hey, ironic can do X now, so use that" and the bug is closed | 22:32 |
| melwitt | mikal: the novaclient thing, it's +2 by Vek here https://review.openstack.org/164321 | 22:33 |
| mriedem | devananda: i'd say just post a patch for review | 22:33 |
| mriedem | that fixes the bug | 22:33 |
| devananda | mriedem: there are two patches up ... JoshNang had forgotten to tag the bug on them, so he has updated the commit message(s) now | 22:33 |
| *** iamjarvo has joined #openstack-nova | 22:33 | |
| mriedem | devananda: are those in the bug report? | 22:33 |
| mikal | melwitt: I will review that now | 22:33 |
| *** unicell has quit IRC | 22:34 | |
| *** unicell has joined #openstack-nova | 22:35 | |
| devananda | mriedem: huh. no. i'm fixing that. | 22:36 |
| *** BadCub has joined #openstack-nova | 22:37 | |
| *** Mr_T has joined #openstack-nova | 22:37 | |
| mikal | melwitt: approved, just waiting for the merge | 22:37 |
| *** JayF has joined #openstack-nova | 22:37 | |
| melwitt | cool, thanks mikal | 22:38 |
| mriedem | devananda: you could add them to the nova meeting agenda for thursday too, or mark in LP for kilo-3 | 22:38 |
| mriedem | that will get them on the release dashboard | 22:38 |
| mriedem | if they are like 500 LOC, no promises they'll land L) | 22:38 |
| mriedem | :) | 22:38 |
| *** andreykurilin_ has quit IRC | 22:38 | |
| devananda | mriedem: ok - didn't know that it was OK for me to target bugs in Nova :) | 22:38 |
| *** ijw has joined #openstack-nova | 22:39 | |
| devananda | mriedem: nope. one is 27 lines, one is ~120 | 22:39 |
| bauzas | devananda: you have to be part of the nova bugs team in LP | 22:39 |
| devananda | I am | 22:39 |
| bauzas | devananda: that's an open directory | 22:39 |
| bauzas | devananda: then yes, you can set a milestone | 22:39 |
| devananda | k k | 22:39 |
| devananda | mriedem: k3 or rc1? | 22:40 |
| *** marun has quit IRC | 22:40 | |
| mriedem | devananda: i'd think k-3, but i'm not the PTL | 22:40 |
| mriedem | i heard that bum was around here somewhere | 22:40 |
| bauzas | mriedem: I would say yup | 22:40 |
| bauzas | k3 bugs would be changed to rc1 nope? | 22:40 |
| *** ijw has quit IRC | 22:40 | |
| bauzas | just before we begin the RC dance | 22:41 |
| mriedem | if they are still critical for the release | 22:41 |
| mriedem | else they are deferred | 22:41 |
| *** ijw has joined #openstack-nova | 22:42 | |
| bauzas | agreed | 22:42 |
| bauzas | I mean, no bugs are targeted now for RC1 https://bugs.launchpad.net/nova/ | 22:42 |
| devananda | ah, ok | 22:43 |
| devananda | k3 it is | 22:43 |
| mriedem | https://launchpad.net/nova/+milestone/kilo-rc1 | 22:43 |
| mriedem | not yet | 22:43 |
| mriedem | anyway | 22:43 |
| mriedem | who wants to break the gate on thursday! | 22:43 |
| mikal | k-3 I would think | 22:44 |
| *** matrohon has quit IRC | 22:45 | |
| mikal | mriedem: its not my turn | 22:45 |
| mikal | mriedem: I did that last time | 22:45 |
| mikal | mriedem: it must be melwitt's turn? | 22:45 |
| *** asettle has joined #openstack-nova | 22:45 | |
| *** BadCub has left #openstack-nova | 22:45 | |
| mriedem | mikal: break the gate? | 22:45 |
| mriedem | or do a release? | 22:45 |
| mikal | mriedem: is there a difference between these two operations? | 22:46 |
| mikal | mriedem: but I meant breaking the gate | 22:46 |
| *** vmtrooper has joined #openstack-nova | 22:46 | |
| mriedem | mikal: you have to push some code usually to break the gate :) | 22:47 |
| mriedem | but yeah a client release can wedge it nicely too | 22:47 |
| mikal | mriedem: nah, releases break the gate all the time! | 22:47 |
| devananda | mriedem: nah. just tag a client release of something or other ;) | 22:47 |
| devananda | heh | 22:47 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Implement instance update logic in Scheduler https://review.openstack.org/160511 | 22:47 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add the instance update calls from Compute https://review.openstack.org/160513 | 22:47 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Modify filters to get instance info from HostState https://review.openstack.org/160512 | 22:47 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add the RPC calls for instance updates. https://review.openstack.org/160507 | 22:47 |
| mriedem | mikal: usually stable | 22:47 |
| mriedem | but we don't care about stable | 22:47 |
| edleafe | dansmith: jaypipes: updates pushed^^ | 22:47 |
| dansmith | edleafe: you pushed them all... what all changed? | 22:48 |
| *** wverdugo500 has joined #openstack-nova | 22:48 | |
| edleafe | dansmith: dunno - was just looking | 22:48 |
| bauzas | edleafe: rebase ? | 22:48 |
| edleafe | I thought just the last one would go | 22:48 |
| edleafe | ah - I pulled jaypipes | 22:48 |
| edleafe | damn! | 22:48 |
| edleafe | ah - I pulled jaypipes' rebase | 22:48 |
| * edleafe is blushing with that last typo | 22:49 | |
| dansmith | that shouldn't have re-pushed everythng | 22:49 |
| dansmith | base patch looks unchanged tho | 22:49 |
| *** wverdugo5001 has joined #openstack-nova | 22:49 | |
| edleafe | dansmith: yeah, just from the rebased one on | 22:50 |
| dansmith | edleafe: you reverted the fix he made to the second one | 22:50 |
| bauzas | dansmith: sounds like a rebase | 22:50 |
| edleafe | dansmith: I did? | 22:50 |
| edleafe | I thought I pulled that version | 22:50 |
| dansmith | nope, see my comment | 22:51 |
| dansmith | edleafe: and the one on the top | 22:51 |
| *** vmtrooper has quit IRC | 22:51 | |
| edleafe | dansmith: goddam it | 22:51 |
| edleafe | I suck | 22:51 |
| *** IanGovett has quit IRC | 22:52 | |
| *** adrian_otto has quit IRC | 22:53 | |
| melwitt | mikal mriedem: my turn to break the gate? no thanks :P | 22:53 |
| *** zzzeek has quit IRC | 22:54 | |
| *** sgordon has quit IRC | 22:56 | |
| *** thomasem has joined #openstack-nova | 22:57 | |
| edleafe | dansmith: What was the reversion on the last patch? https://review.openstack.org/#/c/160513/18..19/nova/scheduler/manager.py,cm | 22:57 |
| dansmith | edleafe: it shouldn't be modified in that patch | 22:58 |
| dansmith | edleafe: if you rebase it on the earlier patch that does the bump, it will be fixed | 22:58 |
| *** mriedem is now known as mriedem_away | 22:59 | |
| *** changbl has quit IRC | 22:59 | |
| openstackgerrit | Christine Wang proposed openstack/nova: Return 404 if detach volumes with invalid volume https://review.openstack.org/165244 | 23:00 |
| *** ociuhandu has joined #openstack-nova | 23:04 | |
| edleafe | dansmith: ok, I've made the fixes. I'll rebase and repush | 23:05 |
| *** smcquaid has joined #openstack-nova | 23:07 | |
| *** emagana has quit IRC | 23:08 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova-specs: Adds spec for instance live resize https://review.openstack.org/141219 | 23:08 |
| *** dims has quit IRC | 23:09 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add the instance update calls from Compute https://review.openstack.org/160513 | 23:09 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Modify filters to get instance info from HostState https://review.openstack.org/160512 | 23:09 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add the RPC calls for instance updates. https://review.openstack.org/160507 | 23:09 |
| *** paul-- has quit IRC | 23:09 | |
| edleafe | dansmith: jaypipes: sorry for the screw up. This should be better ^^ | 23:09 |
| *** smcquaid has quit IRC | 23:10 | |
| *** annashen has joined #openstack-nova | 23:11 | |
| *** paul-- has joined #openstack-nova | 23:13 | |
| *** hemna is now known as hemnafk | 23:14 | |
| melwitt | alaski: are migrations supposed to work in cells, like if the new flavor isn't in the cell's db, it can't get to if it resides on the api cell | 23:16 |
| jamielennox | mikal: responded to comment on https://review.openstack.org/#/c/136931/ | 23:17 |
| mikal | jamielennox: looking at it now, thanks! | 23:19 |
| *** Marga_ has quit IRC | 23:20 | |
| *** dims has joined #openstack-nova | 23:20 | |
| *** Mr_T has left #openstack-nova | 23:21 | |
| *** renatoarmani has quit IRC | 23:21 | |
| *** Marga_ has joined #openstack-nova | 23:23 | |
| *** Marga_ has quit IRC | 23:26 | |
| *** Marga_ has joined #openstack-nova | 23:27 | |
| bauzas | melwitt: my understanding is that for flavors, it goes to the cells scheduler | 23:27 |
| bauzas | melwitt: wich checks for a child cell and then returns it | 23:27 |
| melwitt | bauzas: what I'm seeing is when resize_instance is called in the cells/messaging, it will then call the compute api resize_instance(flavor_id) and then compute tries to look up the target flavor_id and fails because the flavor lives only in the top cell | 23:29 |
| bauzas | melwitt: right, that's exactly what I think | 23:30 |
| bauzas | melwitt: I mean, it goes to the cells scheduler, which picks a child cell, goes to cells.messaging for calling the child cell which calls the compute and then returns | 23:30 |
| melwitt | bauzas: oh, sorry, I didn't understand that's what you were saying. so we expect this not to work (unless of course the target flavor happens to be in the cell db) | 23:31 |
| *** Marga_ has quit IRC | 23:31 | |
| bauzas | melwitt: I just think it's not filtered right | 23:31 |
| *** Marga_ has joined #openstack-nova | 23:31 | |
| melwitt | bauzas: this is tempest, it adds flavors via the api, then does a bunch of migrations | 23:31 |
| *** Marga_ has quit IRC | 23:32 | |
| bauzas | melwitt: honestly, I was thinking that migrations were just something grey for cells | 23:32 |
| bauzas | melwitt: and one of the reasons we kicked off cells v2 | 23:32 |
| *** Marga_ has joined #openstack-nova | 23:32 | |
| melwitt | bauzas: I'm picking through seeing if I can legitimately fix some cells v1 things to pass with end goal making the job vote. ruling out things we just can't address, this looks like one. | 23:33 |
| melwitt | bauzas: yeah, definitely understand the need for the v2 :) | 23:33 |
| bauzas | melwitt: just to be clear, look at cells.manager and how build_instances() is done | 23:35 |
| *** sbfox has quit IRC | 23:35 | |
| bauzas | melwitt: cells api is calling cells rpcapi which calls cells manager.build_instances() | 23:35 |
| bauzas | then goes to messaging.build_instances which asks the cells_scheduler.build_instances (old way !) | 23:36 |
| *** nelsnelson has joined #openstack-nova | 23:36 | |
| bauzas | then the scheduler picks a child cells and communicate to the child cells using the messaging thing again | 23:37 |
| bauzas | melwitt: anyway I don't see much room for migrations in that codepath | 23:37 |
| *** Maike has joined #openstack-nova | 23:38 | |
| melwitt | bauzas: that helps. when I trace those calls I see that flavor (for build_instances) is looked up in the db *before* calling down to the cell, that's how it works | 23:38 |
| melwitt | bauzas: the trouble with migration is it's not doing the same. it doesn't try to look up the flavor until it's already down in the cell | 23:39 |
| bauzas | melwitt: yeah there are a lot of assumptions that are done | 23:39 |
| melwitt | bauzas: yeah, I know cells was made to try to fit what's already here, doesn't always fit | 23:39 |
| bauzas | melwitt: you know that migrations code changed in Icehouse and is now quite unified ? | 23:40 |
| bauzas | melwitt: plus the fact that's now the conductor which issues calls to computes, no longer the scheduler | 23:40 |
| melwitt | bauzas: I've seen recent migrations code but wasn't familiar in the past | 23:40 |
| bauzas | melwitt: IMHO the main problem is that the cells v1 code was written before that and was not updated accordingly, which generated tech debt | 23:41 |
| bauzas | melwitt: there is room for improving migrations in cells v1, but I seriously doubt it's an easy trick - in a bugfix | 23:41 |
| *** nellysmitt has joined #openstack-nova | 23:42 | |
| bauzas | so as we're now close to FF, it would be deferred to Liberty | 23:42 |
| bauzas | anyway, heading off to bed, bye | 23:42 |
| melwitt | bauzas: I see. thanks for explaining everything | 23:43 |
| bauzas | melwitt: np | 23:43 |
| *** Marga_ has quit IRC | 23:45 | |
| *** nellysmitt has quit IRC | 23:47 | |
| mikal | So, melwitt's fix landed in novaclient, so I think we're ready to do a release there? | 23:48 |
| *** david-lyle is now known as david-lyle_afk | 23:50 | |
| *** oomichi has joined #openstack-nova | 23:51 | |
| *** leseb has quit IRC | 23:51 | |
| oomichi | mikal: hi, morning | 23:52 |
| oomichi | mikal: thanks for reviewing. | 23:52 |
| mikal | oomichi: no problems | 23:52 |
| oomichi | mikal: but on https://review.openstack.org/#/c/163697 , no score. can you take a look again? | 23:52 |
| mikal | Yep, will do in a sec | 23:53 |
| *** ZZelle_ has quit IRC | 23:54 | |
| *** Marga_ has joined #openstack-nova | 23:56 | |
| *** sgordon has joined #openstack-nova | 23:57 | |
| *** annashen has quit IRC | 23:57 | |
| *** dboik_ has joined #openstack-nova | 23:58 | |
| *** leseb has joined #openstack-nova | 23:58 | |
| openstackgerrit | Tim Pownall proposed openstack/nova: Updated determine_vm_mode and _attach_disks to pull vm_mode and auto_disk_config values from the image_ref during rescue mode. https://review.openstack.org/164940 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!