| amuller | it has to know to do that | 00:00 |
|---|---|---|
| zzzeek | amuller: see https://review.openstack.org/#/c/244058/2/nova/db/sqlalchemy/api.py,cm for some examples | 00:00 |
| *** aranjan has quit IRC | 00:00 | |
| zzzeek | you can see some "Subtransactions=True" going away | 00:00 |
| *** dedery has quit IRC | 00:00 | |
| zzzeek | amuller: the reason that flag exists, is because i didnt want people using that feature casually | 00:00 |
| *** aranjan has joined #openstack-neutron | 00:01 | |
| *** minwang2 has quit IRC | 00:01 | |
| *** shashank_hegde has quit IRC | 00:01 | |
| *** yamahata has quit IRC | 00:01 | |
| zzzeek | amuller: e.g. i didnt want an automatic, implicit "subtransaction" w/o people knowing what that pattern is for. openstack /neutron *is* sort of using that pattern here but i think if it were today maybe i would not have put this pattern into SQLAlchemy | 00:01 |
| amuller | zzzeek: that patch is transitioning a bit of Nova code from the old mode (like Neutron) to the new enginefacade? | 00:01 |
| zzzeek | amuller: yes | 00:01 |
| amuller | ok, reading more... | 00:02 |
| zzzeek | amuller: the point of enginefacade is we can make any kind of "wrap a method in X" thing that we want | 00:02 |
| armax | blogan: ping | 00:02 |
| armax | https://review.openstack.org/#/c/249448/ | 00:02 |
| zzzeek | amuller: it includes the ".independent" symbol which states, "run this in an independent transaction" | 00:02 |
| *** Sukhdev has quit IRC | 00:02 | |
| zzzeek | amuller: we dont have that right now with all this session.begin(subtransactions) stuff | 00:02 |
| amuller | zzzeek: 'run this in an independent transaction' == session.begin(nested=True) ? | 00:03 |
| *** sridhar_ram has quit IRC | 00:03 | |
| zzzeek | amuller: it is not! it is: context.session = a_brand_new_session() | 00:03 |
| amuller | hmm | 00:03 |
| amuller | ok, this is a lot to take in, I'll have to read more about enginefacade | 00:03 |
| *** sridhar_ram has joined #openstack-neutron | 00:04 | |
| zzzeek | e.g. it is totally independent of whatver broken state the existing session is in | 00:04 |
| *** aranjan_ has joined #openstack-neutron | 00:04 | |
| *** EinstCrazy has quit IRC | 00:04 | |
| *** aranjan_ has quit IRC | 00:04 | |
| *** aranjan_ has joined #openstack-neutron | 00:05 | |
| amuller | zzzeek: so in our .rst, the outer create would have the writer decorator, and _do_other_thing writer.independent? | 00:06 |
| *** alexpilotti has joined #openstack-neutron | 00:06 | |
| zzzeek | amuller: if you wanted it that way yes. | 00:06 |
| *** Pavo has joined #openstack-neutron | 00:07 | |
| *** aranjan has quit IRC | 00:07 | |
| *** minwang2 has joined #openstack-neutron | 00:07 | |
| *** shashank_hegde has joined #openstack-neutron | 00:08 | |
| *** edgar__ has quit IRC | 00:08 | |
| *** Pavo has quit IRC | 00:08 | |
| amuller | zzzeek: Alright, as usual I'm more confused than I started with, but that's to be expected :) Thanks for your time | 00:08 |
| *** aranjan_ has quit IRC | 00:09 | |
| zzzeek | amuller: the enginefacade is what i came up with to allow all these different patterns to be encapsulated in @enginefacade.whatever | 00:09 |
| zzzeek | amuller: and then part of oslo.db, and tested, and not reinvented in every project | 00:09 |
| *** Pavo has joined #openstack-neutron | 00:09 | |
| *** Sukhdev has joined #openstack-neutron | 00:10 | |
| amuller | zzzeek: That I do get | 00:10 |
| zzzeek | amuller: but to do it right, neutron would want to totally switch over to it. neutron's patterns are already not terrible here so it wouldnt be as hard as nova | 00:10 |
| amuller | hah, one thing we do better than Nova | 00:10 |
| zzzeek | amuller: plus, getting all of openstack is one of my compass goals so if i get nova AND neutron, bonus time! :) | 00:11 |
| *** edgar__ has joined #openstack-neutron | 00:11 | |
| zzzeek | e.g. on enginefacade | 00:11 |
| *** edgar__ has quit IRC | 00:12 | |
| *** edgar__ has joined #openstack-neutron | 00:13 | |
| amuller | zzzeek: lol | 00:14 |
| amuller | zzzeek: /me wonders if compass is used outside of Red Hat | 00:14 |
| *** gildub has joined #openstack-neutron | 00:16 | |
| *** edgar__ has quit IRC | 00:17 | |
| *** thorst has joined #openstack-neutron | 00:18 | |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Clarify how we milestones are assigned https://review.openstack.org/249489 | 00:18 |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Clarify how we milestones are assigned https://review.openstack.org/249489 | 00:18 |
| *** thorst has quit IRC | 00:19 | |
| *** TrevorV2 has joined #openstack-neutron | 00:19 | |
| spandhe | kevinbenton: In realized one more thing later.. in case of multiple IPs, we dont want dhcp configure all the ips.. we only want it to configure the static ip.. how can we do that if they are part of the same port? | 00:20 |
| *** lnicolas has joined #openstack-neutron | 00:20 | |
| *** wolverineav has joined #openstack-neutron | 00:21 | |
| *** TrevorV has quit IRC | 00:22 | |
| kevinbenton | spandhe: I don't remember the behavior of dnsmasq with multiple IPs | 00:25 |
| kevinbenton | spandhe: it may just end up using the first match | 00:25 |
| *** wolverineav has quit IRC | 00:26 | |
| *** markvoelker has quit IRC | 00:26 | |
| kevinbenton | spandhe: because dhcp doesn't easily support multiple addresses | 00:27 |
| *** shaohe_feng has joined #openstack-neutron | 00:28 | |
| *** aranjan has joined #openstack-neutron | 00:29 | |
| spandhe | kevinbenton: I think it does.. let me pull the link | 00:29 |
| *** jobewan has quit IRC | 00:30 | |
| *** dims has joined #openstack-neutron | 00:30 | |
| spandhe | kevinbenton: I thought this handled it: https://github.com/openstack/neutron/blob/master/neutron/agent/linux/dhcp.py#L639-L640 | 00:31 |
| *** dims_ has quit IRC | 00:31 | |
| spandhe | https://github.com/openstack/neutron/blob/master/neutron/agent/linux/dhcp.py#L533 | 00:31 |
| *** sthillma has quit IRC | 00:32 | |
| kevinbenton | spandhe: right, but I mean I'm not sure what dnsmasq does with that | 00:32 |
| *** sthillma has joined #openstack-neutron | 00:32 | |
| kevinbenton | spandhe: it may just use the first in the lease list | 00:32 |
| kevinbenton | spandhe: you might just have to test and see what happens | 00:33 |
| spandhe | kevinbenton: maybe | 00:33 |
| kevinbenton | spandhe: if it's predictable then we can make sure it's always the first ip in fixed IPs that goes first or something | 00:33 |
| kevinbenton | spandhe: so whichever one you want via dhcp just needs to be first | 00:34 |
| *** ijw has quit IRC | 00:34 | |
| *** ijw has joined #openstack-neutron | 00:34 | |
| spandhe | kevinbenton: how do I achieve that predictability? when I iterate through the ips, how do I make sure that the first one is the static one? | 00:34 |
| *** shaohe_feng has quit IRC | 00:35 | |
| *** shaohe_feng has joined #openstack-neutron | 00:36 | |
| kevinbenton | spandhe: I was thinking the order that the fixed IPs are specified in the API | 00:37 |
| *** amuller has quit IRC | 00:37 | |
| jamespd | kevinbenton: If I want to add a 'description' standardattribute, for use with securitygrouprules, should I be adding a 'description' column to the standardattribute table? | 00:37 |
| *** mchestr has quit IRC | 00:37 | |
| jamespd | kevinbenton: or is there some other level of indirections. | 00:37 |
| spandhe | kevinbenton: you mean, while creating the port? does that order stay? I thought it will be a simple list after that point | 00:37 |
| kevinbenton | spandhe: well lists are ordered but the issue is in the DB there isn't order right now | 00:38 |
| kevinbenton | spandhe: so we would have to save an index | 00:38 |
| *** miyagishi_t has joined #openstack-neutron | 00:38 | |
| kevinbenton | jamespd: that one might be a join to another table since most stuff doesn't have a description (or it already does but it's in its table) | 00:39 |
| spandhe | kevinbenton: one thing I could do is, store the static IP in the binding profile as well. and on the dhcp driver side read it from there | 00:40 |
| jamespd | kevinbenton: so, standardattribute only gets a column when it applies to all resources? | 00:40 |
| kevinbenton | spandhe: Yeah, that could work for now. It would be good if neutron had predictable dhcp behavior with multiple IPs though | 00:40 |
| kevinbenton | jamespd: Yeah, we don't want a ton of null entries | 00:41 |
| spandhe | kevinbenton: sounds like a bug? | 00:41 |
| spandhe | maybe it doesnt matter for dynamic ip allocation | 00:42 |
| *** baoli has joined #openstack-neutron | 00:42 | |
| kevinbenton | spandhe: well it kinda does because a VMs ip might randomly change if the order flips on a reload | 00:42 |
| kevinbenton | spandhe: I would check that it's not predictable and then file a bug | 00:43 |
| spandhe | kevinbenton: sounds good.. | 00:43 |
| *** baoli_ has joined #openstack-neutron | 00:43 | |
| *** yamamoto has joined #openstack-neutron | 00:44 | |
| kevinbenton | spandhe: we do sort before writing to dnsmasq but it looks like only to put ipv6 before ipv4 | 00:44 |
| kevinbenton | https://github.com/openstack/neutron/blob/master/neutron/agent/linux/dhcp.py#L468 | 00:44 |
| *** sridhar_ram has quit IRC | 00:44 | |
| *** TrevorV2 has quit IRC | 00:45 | |
| kevinbenton | spandhe: so multiple ipv4 might not be predictable | 00:45 |
| *** lindycoder has joined #openstack-neutron | 00:45 | |
| spandhe | looks like it | 00:45 |
| *** jerrygb has quit IRC | 00:45 | |
| *** Sukhdev has quit IRC | 00:45 | |
| *** yamamoto has quit IRC | 00:46 | |
| *** shaohe_feng has quit IRC | 00:46 | |
| spandhe | kevinbenton: this is what I got for a port with multiple ips: http://paste.openstack.org/show/479940/ | 00:46 |
| *** jerrygb has joined #openstack-neutron | 00:46 | |
| *** jinxing has joined #openstack-neutron | 00:46 | |
| spandhe | seems like its sorting them… let me check | 00:47 |
| *** baoli has quit IRC | 00:47 | |
| kevinbenton | spandhe: Yeah, I know all are written. I mean what does dnsmasq do when it gets a dhcp request | 00:47 |
| openstackgerrit | Merged openstack/python-neutronclient: Add reno for release notes management https://review.openstack.org/248933 | 00:47 |
| *** Sukhdev has joined #openstack-neutron | 00:47 | |
| kevinbenton | spandhe: does it just return the first in the list? | 00:47 |
| spandhe | it will probably take the first one.. thats what it seems like from the reasoning behind ipv6 sorting.. but I dont know for sure | 00:48 |
| spandhe | we need to make sure that we keep that order same | 00:49 |
| spandhe | thinking if I can use https://github.com/openstack/neutron/blob/master/neutron/agent/linux/dhcp.py#L538-L539 somehow | 00:49 |
| *** sridhar_ram has joined #openstack-neutron | 00:50 | |
| *** minwang2 has quit IRC | 00:50 | |
| *** jerrygb has quit IRC | 00:50 | |
| *** Marga_ has quit IRC | 00:51 | |
| *** Pavo has quit IRC | 00:51 | |
| kevinbenton | spandhe: just have to make sure your static IPs are lower than the dynamic ones :) | 00:52 |
| *** Pavo has joined #openstack-neutron | 00:52 | |
| *** Swami has quit IRC | 00:53 | |
| *** rtheis has quit IRC | 00:53 | |
| spandhe | kevinbenton: I was thinking about that :) but the problem is, these assumptions really block us from expanding internally, no matter how reasonable the assumption is :( | 00:53 |
| spandhe | anyway ill talk to folks about that | 00:54 |
| *** Yuji has joined #openstack-neutron | 00:55 | |
| *** Yuji has quit IRC | 00:55 | |
| *** yamamoto has joined #openstack-neutron | 00:55 | |
| *** yamamoto has quit IRC | 00:55 | |
| *** yamamoto has joined #openstack-neutron | 00:56 | |
| *** Marga_ has joined #openstack-neutron | 00:56 | |
| *** yamamoto has quit IRC | 00:58 | |
| *** hoangcx has joined #openstack-neutron | 00:59 | |
| *** alexpilotti has quit IRC | 00:59 | |
| kevinbenton | spandhe: Yeah, it's reasonable to request that the fixed IPs are stored in order as specified in the API | 00:59 |
| kevinbenton | Then we can always ensure the first one is the first for dnsmasq | 00:59 |
| *** ajmiller has quit IRC | 00:59 | |
| *** alexpilotti has joined #openstack-neutron | 00:59 | |
| *** salv-orl_ has quit IRC | 01:01 | |
| kevinbenton | spandhe: we did the same for dns servers at one point | 01:02 |
| *** yamahata has joined #openstack-neutron | 01:03 | |
| *** sridhar_ram1 has joined #openstack-neutron | 01:03 | |
| spandhe | kevinbenton: I have one more small confusion.. the physnet is L2 domain, right? | 01:03 |
| openstackgerrit | IWAMOTO Toshihiro proposed openstack/neutron: Fix typo for OVSDB https://review.openstack.org/249499 | 01:03 |
| *** iwamoto has joined #openstack-neutron | 01:03 | |
| *** apuimedo has quit IRC | 01:03 | |
| *** Marga__ has joined #openstack-neutron | 01:04 | |
| *** apuimedo has joined #openstack-neutron | 01:04 | |
| kevinbenton | spandhe: it depends. If it's flat networking, then yes, a physnet is one l2 domain | 01:04 |
| spandhe | kevinbenton: all the subnets in one rack will be part of same physnet right? | 01:04 |
| kevinbenton | spandhe: yes | 01:04 |
| *** sridhar_ram has quit IRC | 01:04 | |
| spandhe | ok.. be right back.. have more qns.. | 01:05 |
| kevinbenton | spandhe: if you are using VLANs, then a physnet + vlan id will be a broadcast domain | 01:05 |
| kevinbenton | Or a 'segment' in neutron terms | 01:05 |
| *** EinstCrazy has joined #openstack-neutron | 01:05 | |
| *** zhangjn has joined #openstack-neutron | 01:05 | |
| kevinbenton | And a neutron network is usually one segment | 01:05 |
| spandhe | kevinbenton: we are using flat networks in ironic.. VLAN tagging is done on the switches beforehand | 01:05 |
| *** rohit_ has quit IRC | 01:06 | |
| *** eil397 has quit IRC | 01:06 | |
| *** hitalia has quit IRC | 01:06 | |
| *** Marga_ has quit IRC | 01:07 | |
| *** doug-fish has joined #openstack-neutron | 01:07 | |
| *** sridhar_ram1 is now known as sridhar_ram | 01:08 | |
| *** Pavo has quit IRC | 01:09 | |
| *** sripriya has quit IRC | 01:11 | |
| *** eil397 has joined #openstack-neutron | 01:11 | |
| kevinbenton | spandhe: I have to head home. Can you ping me tomorrow? | 01:11 |
| *** doug-fish has quit IRC | 01:12 | |
| *** Swami has joined #openstack-neutron | 01:14 | |
| *** josecastroleon has joined #openstack-neutron | 01:17 | |
| *** vivek-ebay has quit IRC | 01:17 | |
| *** baoli_ has quit IRC | 01:18 | |
| *** annp has joined #openstack-neutron | 01:18 | |
| *** baoli has joined #openstack-neutron | 01:19 | |
| *** Masaki has joined #openstack-neutron | 01:20 | |
| *** baoli has quit IRC | 01:21 | |
| *** baoli has joined #openstack-neutron | 01:22 | |
| *** markvoelker has joined #openstack-neutron | 01:27 | |
| *** aranjan has quit IRC | 01:28 | |
| *** tomoe_ has joined #openstack-neutron | 01:29 | |
| *** tiswanso has quit IRC | 01:29 | |
| openstackgerrit | Brent Eagles proposed openstack/neutron: Adding a VNIC type for physical functions https://review.openstack.org/246923 | 01:30 |
| *** alexpilotti has quit IRC | 01:31 | |
| *** markvoelker has quit IRC | 01:31 | |
| *** lindycoder has quit IRC | 01:32 | |
| *** baoli has quit IRC | 01:33 | |
| *** jyuso1 has joined #openstack-neutron | 01:34 | |
| *** baoli has joined #openstack-neutron | 01:34 | |
| *** iyamahat has joined #openstack-neutron | 01:36 | |
| *** Masaki has quit IRC | 01:36 | |
| *** Masaki has joined #openstack-neutron | 01:36 | |
| *** zhenguo has joined #openstack-neutron | 01:37 | |
| *** hitalia has joined #openstack-neutron | 01:38 | |
| *** yamamoto has joined #openstack-neutron | 01:40 | |
| *** Marga__ has quit IRC | 01:41 | |
| *** stanzgy has joined #openstack-neutron | 01:42 | |
| *** Marga_ has joined #openstack-neutron | 01:42 | |
| *** Aish has quit IRC | 01:42 | |
| *** skamithi has joined #openstack-neutron | 01:45 | |
| *** skamithi has left #openstack-neutron | 01:45 | |
| *** gongysh__ has joined #openstack-neutron | 01:46 | |
| *** josecastroleon has quit IRC | 01:46 | |
| openstackgerrit | Swaminathan Vasudevan proposed openstack/neutron: Debug patch to test the gate failures on SSHTimeOut https://review.openstack.org/247748 | 01:46 |
| *** Swami has quit IRC | 01:48 | |
| *** gildub has quit IRC | 01:49 | |
| *** zhangjn has quit IRC | 01:49 | |
| *** liwei has joined #openstack-neutron | 01:50 | |
| *** liwei has quit IRC | 01:50 | |
| *** liwei has joined #openstack-neutron | 01:50 | |
| *** tbachman has joined #openstack-neutron | 01:52 | |
| spandhe | kevinbenton: yeah sure.. ill ping you tomorrow.. sorry just got out of meeting | 01:52 |
| *** zhangjn has joined #openstack-neutron | 01:52 | |
| *** mlavalle has quit IRC | 01:54 | |
| *** fitoduarte has quit IRC | 01:55 | |
| *** tiswanso has joined #openstack-neutron | 01:55 | |
| *** eil397 has quit IRC | 01:56 | |
| *** liwei has quit IRC | 01:58 | |
| *** Pavo has joined #openstack-neutron | 01:58 | |
| *** jerrygb has joined #openstack-neutron | 01:59 | |
| *** Pavo has quit IRC | 02:00 | |
| *** Pavo has joined #openstack-neutron | 02:02 | |
| *** Sukhdev has quit IRC | 02:02 | |
| *** apuimedo is now known as apuimedo|zzz | 02:03 | |
| *** shaohe_feng has joined #openstack-neutron | 02:10 | |
| *** jbell8 has joined #openstack-neutron | 02:12 | |
| *** shashank_hegde has quit IRC | 02:14 | |
| *** jbell8 has quit IRC | 02:14 | |
| *** thorst has joined #openstack-neutron | 02:20 | |
| *** enikanorov has joined #openstack-neutron | 02:22 | |
| *** enikanorov_ has quit IRC | 02:22 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 02:22 | |
| *** shaohe_feng1 has joined #openstack-neutron | 02:23 | |
| openstackgerrit | Swaminathan Vasudevan proposed openstack/neutron: Debug patch to test the gate failures on SSHTimeOut https://review.openstack.org/247748 | 02:24 |
| *** shaohe_feng has quit IRC | 02:24 | |
| *** thorst has quit IRC | 02:24 | |
| *** vivek-ebay has joined #openstack-neutron | 02:25 | |
| *** jinxing has quit IRC | 02:26 | |
| *** markvoelker has joined #openstack-neutron | 02:28 | |
| *** edgar__ has joined #openstack-neutron | 02:28 | |
| *** tomoe_ has quit IRC | 02:30 | |
| *** jerrygb has quit IRC | 02:32 | |
| *** abhiraut has quit IRC | 02:32 | |
| *** markvoelker has quit IRC | 02:33 | |
| *** edgar__ has quit IRC | 02:33 | |
| *** jerrygb has joined #openstack-neutron | 02:33 | |
| *** apuimedo|zzz has quit IRC | 02:33 | |
| *** vivek-eb_ has joined #openstack-neutron | 02:34 | |
| openstackgerrit | Hirofumi Ichihara proposed openstack/neutron: Add availability_zone support for network https://review.openstack.org/204436 | 02:35 |
| *** gongysh__ has quit IRC | 02:35 | |
| *** shivrao has quit IRC | 02:37 | |
| *** jerrygb has quit IRC | 02:37 | |
| *** vivek-ebay has quit IRC | 02:37 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 02:38 | |
| *** jdandrea has quit IRC | 02:38 | |
| *** annp has quit IRC | 02:39 | |
| *** dims has quit IRC | 02:39 | |
| *** jerrygb has joined #openstack-neutron | 02:40 | |
| *** apuimedo|zzz has joined #openstack-neutron | 02:40 | |
| *** shaohe_feng1 has quit IRC | 02:40 | |
| *** outworlder has quit IRC | 02:40 | |
| *** Rui_ has joined #openstack-neutron | 02:41 | |
| *** hitalia has quit IRC | 02:41 | |
| *** skamithi has joined #openstack-neutron | 02:43 | |
| *** skamithi has left #openstack-neutron | 02:43 | |
| *** Piet has joined #openstack-neutron | 02:51 | |
| *** gangil has joined #openstack-neutron | 02:52 | |
| *** gangil has quit IRC | 02:52 | |
| *** gangil has joined #openstack-neutron | 02:52 | |
| *** Rui_ has quit IRC | 02:53 | |
| *** tbachman_ has joined #openstack-neutron | 02:53 | |
| *** sam_s has joined #openstack-neutron | 02:53 | |
| *** sam_s has quit IRC | 02:53 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 02:54 | |
| *** sridhar_ram has quit IRC | 02:54 | |
| *** tbachman has quit IRC | 02:54 | |
| *** tbachman_ is now known as tbachman | 02:54 | |
| *** spandhe has quit IRC | 02:54 | |
| *** s3wong has quit IRC | 02:59 | |
| *** zhhuabj has joined #openstack-neutron | 03:01 | |
| *** eil397 has joined #openstack-neutron | 03:04 | |
| *** salv-orlando has joined #openstack-neutron | 03:05 | |
| *** gangil has quit IRC | 03:08 | |
| *** zhhuabj has quit IRC | 03:09 | |
| *** breitz has quit IRC | 03:09 | |
| shz | ping obondarev | 03:09 |
| *** breitz has joined #openstack-neutron | 03:09 | |
| *** eil397 has quit IRC | 03:10 | |
| *** eil397 has joined #openstack-neutron | 03:11 | |
| *** tomoe_ has joined #openstack-neutron | 03:11 | |
| *** alger has joined #openstack-neutron | 03:11 | |
| *** zhaobo0825 has quit IRC | 03:12 | |
| *** jwy has quit IRC | 03:13 | |
| *** alger has quit IRC | 03:13 | |
| *** alger has joined #openstack-neutron | 03:14 | |
| *** RA has joined #openstack-neutron | 03:14 | |
| *** RA is now known as Guest30762 | 03:14 | |
| *** Guest30762 is now known as RA_ | 03:16 | |
| *** jerrygb has quit IRC | 03:16 | |
| *** jerrygb has joined #openstack-neutron | 03:16 | |
| *** vishwanathj has quit IRC | 03:17 | |
| *** terryyao has joined #openstack-neutron | 03:20 | |
| *** Marga_ has quit IRC | 03:20 | |
| *** sthillma has quit IRC | 03:21 | |
| *** yuanying has quit IRC | 03:21 | |
| *** jerrygb has quit IRC | 03:21 | |
| *** zhhuabj has joined #openstack-neutron | 03:22 | |
| *** thorst has joined #openstack-neutron | 03:22 | |
| *** tflynn_ has joined #openstack-neutron | 03:23 | |
| *** edgar has joined #openstack-neutron | 03:25 | |
| *** Marga_ has joined #openstack-neutron | 03:25 | |
| *** thorst has quit IRC | 03:26 | |
| *** tflynn has quit IRC | 03:27 | |
| *** tflynn_ has quit IRC | 03:28 | |
| *** markvoelker has joined #openstack-neutron | 03:29 | |
| *** edgar has quit IRC | 03:29 | |
| *** Marga_ has quit IRC | 03:30 | |
| reedip | yamamoto: ping | 03:32 |
| yamamoto | reedip: pong | 03:33 |
| reedip | Hi yamamoto | 03:33 |
| yamamoto | hi | 03:33 |
| *** minwang2 has joined #openstack-neutron | 03:34 | |
| *** changbl has quit IRC | 03:34 | |
| reedip | yamamoto: the code( without the UT) for TAS neutronclient is ready , wanted to know if it can be committed under python-neutronclient for the initial review, or should it be initially committed under TAS | 03:34 |
| reedip | yamamoto: maybe this can be discussed in today's meeting ? | 03:34 |
| *** markvoelker has quit IRC | 03:34 | |
| *** SurajD has joined #openstack-neutron | 03:35 | |
| yamamoto | reedip: is it implemented with NeutronClientExtension? | 03:35 |
| reedip | yes | 03:35 |
| *** markvoelker has joined #openstack-neutron | 03:35 | |
| yamamoto | reedip: in that case taas repo is more appropriate. | 03:36 |
| yamamoto | reedip: you can follow what l2gw does https://github.com/openstack/networking-l2gw/tree/master/networking_l2gw/l2gatewayclient | 03:36 |
| reedip | yamamoto: Ok | 03:36 |
| reedip | yamamoto: will do that | 03:37 |
| *** salv-orlando has quit IRC | 03:38 | |
| *** boris-42 has quit IRC | 03:38 | |
| *** yushiro has quit IRC | 03:39 | |
| *** john5223 is now known as zz_john5223 | 03:41 | |
| *** achanda has joined #openstack-neutron | 03:41 | |
| yamamoto | reedip: thank you | 03:42 |
| reedip | yamamoto: Thank you for your advice :-) | 03:43 |
| openstackgerrit | Merged openstack/neutron: Minor doc fix in alembic_migrations.rst https://review.openstack.org/249066 | 03:44 |
| *** minwang2 has quit IRC | 03:45 | |
| *** LZ has joined #openstack-neutron | 03:45 | |
| *** ijw has quit IRC | 03:46 | |
| *** minwang2 has joined #openstack-neutron | 03:47 | |
| *** changbl has joined #openstack-neutron | 03:47 | |
| *** hichihara has joined #openstack-neutron | 03:48 | |
| hichihara | amotoki: ping | 03:49 |
| *** zhangjn has quit IRC | 03:51 | |
| *** achanda has quit IRC | 03:51 | |
| *** salv-orlando has joined #openstack-neutron | 03:51 | |
| *** salv-orlando has quit IRC | 03:56 | |
| *** minwang2 has quit IRC | 03:57 | |
| *** yushiro has joined #openstack-neutron | 03:59 | |
| openstackgerrit | ZongKai LI proposed openstack/neutron: skip add_endpoint for endpoint not changed case https://review.openstack.org/222459 | 04:00 |
| *** Pavo has quit IRC | 04:04 | |
| *** karthiks has joined #openstack-neutron | 04:05 | |
| reedip | @yamamoto: is there an L2gw CLI? I cannot find it in the current neutron CLIs | 04:05 |
| *** gildub has joined #openstack-neutron | 04:05 | |
| *** strictlyb is now known as sb | 04:05 | |
| *** yuanying has joined #openstack-neutron | 04:06 | |
| *** minwang2 has joined #openstack-neutron | 04:07 | |
| *** aleksandr_null has joined #openstack-neutron | 04:08 | |
| *** thorst has joined #openstack-neutron | 04:14 | |
| *** ivar-lazzaro has quit IRC | 04:16 | |
| *** thorst has quit IRC | 04:18 | |
| *** SridharG has joined #openstack-neutron | 04:19 | |
| *** zz_john5223 is now known as john5223 | 04:20 | |
| *** yushiro has quit IRC | 04:21 | |
| SridharG | carl_baldwin: Hello Carl, can you pls review the following patch when you get sometime, thanks. https://review.openstack.org/#/c/236805/ | 04:26 |
| *** Masaki has quit IRC | 04:26 | |
| *** signed8bit has quit IRC | 04:26 | |
| *** mfuruta has joined #openstack-neutron | 04:27 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-specs: (Operator-only) Logging API for security groups https://review.openstack.org/203509 | 04:28 |
| *** minwang2 has quit IRC | 04:28 | |
| *** minwang2 has joined #openstack-neutron | 04:29 | |
| carl_baldwin | SridharG: I'll try to get to it soon. | 04:29 |
| SridharG | thanks carl_baldwin | 04:29 |
| openstackgerrit | Hirofumi Ichihara proposed openstack/neutron: Add availability_zone support for network https://review.openstack.org/204436 | 04:33 |
| *** shashank_hegde has joined #openstack-neutron | 04:34 | |
| *** minwang2 has quit IRC | 04:36 | |
| *** mohankumar has joined #openstack-neutron | 04:37 | |
| *** vikasc has joined #openstack-neutron | 04:40 | |
| *** rotbeard has joined #openstack-neutron | 04:41 | |
| *** doug-fish has joined #openstack-neutron | 04:42 | |
| *** Pavo has joined #openstack-neutron | 04:42 | |
| *** hichihara has quit IRC | 04:43 | |
| *** vikasc has quit IRC | 04:44 | |
| *** doug-fish has quit IRC | 04:46 | |
| *** iyamahat has quit IRC | 04:46 | |
| *** Pavo has quit IRC | 04:47 | |
| *** bochi-michael has joined #openstack-neutron | 04:48 | |
| *** diga has joined #openstack-neutron | 04:49 | |
| *** shwetaap has joined #openstack-neutron | 04:56 | |
| *** Ramanjaneya has joined #openstack-neutron | 04:57 | |
| *** tflynn has joined #openstack-neutron | 04:58 | |
| *** sthillma has joined #openstack-neutron | 05:00 | |
| *** sthillma_ has joined #openstack-neutron | 05:00 | |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Add Incomplete state to list of acceptable states for RFE bugs https://review.openstack.org/249483 | 05:01 |
| *** djan has quit IRC | 05:02 | |
| *** djan has joined #openstack-neutron | 05:03 | |
| *** sthillma has quit IRC | 05:04 | |
| *** sthillma_ is now known as sthillma | 05:04 | |
| *** vikasc has joined #openstack-neutron | 05:09 | |
| *** beagles has quit IRC | 05:12 | |
| *** rossella_s has quit IRC | 05:14 | |
| *** rossella_s has joined #openstack-neutron | 05:14 | |
| *** vikasc has quit IRC | 05:14 | |
| *** Piet has quit IRC | 05:15 | |
| *** b3nt_pin has joined #openstack-neutron | 05:17 | |
| *** b3nt_pin is now known as Guest65357 | 05:17 | |
| *** salv-orlando has joined #openstack-neutron | 05:18 | |
| *** thorst has joined #openstack-neutron | 05:18 | |
| *** tflynn has quit IRC | 05:20 | |
| *** shausy has joined #openstack-neutron | 05:21 | |
| *** doug-fish has joined #openstack-neutron | 05:23 | |
| *** thorst has quit IRC | 05:23 | |
| *** mohankumar has quit IRC | 05:23 | |
| *** salv-orlando has quit IRC | 05:24 | |
| *** tflynn has joined #openstack-neutron | 05:26 | |
| *** nate_gone is now known as njohnston | 05:27 | |
| *** apuimedo|zzz has quit IRC | 05:27 | |
| *** doug-fish has quit IRC | 05:27 | |
| *** tflynn_ has joined #openstack-neutron | 05:27 | |
| *** zhangjn has joined #openstack-neutron | 05:28 | |
| *** mohankumar has joined #openstack-neutron | 05:29 | |
| *** tflynn has quit IRC | 05:30 | |
| *** Marga_ has joined #openstack-neutron | 05:35 | |
| *** oshvartz_ has quit IRC | 05:36 | |
| *** oshvartz has quit IRC | 05:37 | |
| *** Marga_ has quit IRC | 05:37 | |
| *** Marga_ has joined #openstack-neutron | 05:37 | |
| *** Marga_ has quit IRC | 05:38 | |
| *** shaohe_feng has joined #openstack-neutron | 05:38 | |
| *** shwetaap has quit IRC | 05:38 | |
| *** gongysh__ has joined #openstack-neutron | 05:39 | |
| *** Marga_ has joined #openstack-neutron | 05:40 | |
| *** gberginc has quit IRC | 05:41 | |
| *** trinaths has joined #openstack-neutron | 05:43 | |
| *** shaohe_feng1 has joined #openstack-neutron | 05:45 | |
| *** shwetaap has joined #openstack-neutron | 05:46 | |
| *** tflynn_ has quit IRC | 05:46 | |
| *** shaohe_feng has quit IRC | 05:47 | |
| *** nlahouti has joined #openstack-neutron | 05:47 | |
| *** nlahouti1 has joined #openstack-neutron | 05:48 | |
| *** abregman has joined #openstack-neutron | 05:49 | |
| *** amotoki has quit IRC | 05:49 | |
| *** nlahouti2 has joined #openstack-neutron | 05:50 | |
| *** SridharG has left #openstack-neutron | 05:50 | |
| *** nlahouti has quit IRC | 05:52 | |
| *** nlahouti1 has quit IRC | 05:53 | |
| *** hitalia has joined #openstack-neutron | 05:55 | |
| *** nplanel has joined #openstack-neutron | 05:57 | |
| *** aduyck has quit IRC | 05:59 | |
| *** ahduyck has quit IRC | 06:00 | |
| *** amotoki has joined #openstack-neutron | 06:01 | |
| *** Sukhdev has joined #openstack-neutron | 06:02 | |
| *** manjeets has joined #openstack-neutron | 06:04 | |
| *** tflynn has joined #openstack-neutron | 06:05 | |
| *** shaohe_feng has joined #openstack-neutron | 06:05 | |
| *** shaohe_feng1 has quit IRC | 06:07 | |
| *** amotoki has quit IRC | 06:10 | |
| *** jschwarz has joined #openstack-neutron | 06:14 | |
| *** numans has joined #openstack-neutron | 06:15 | |
| *** amotoki has joined #openstack-neutron | 06:15 | |
| *** lnicolas has quit IRC | 06:16 | |
| *** edgar has joined #openstack-neutron | 06:16 | |
| *** vivek-eb_ has quit IRC | 06:16 | |
| *** mkolesni has joined #openstack-neutron | 06:18 | |
| *** lajos-katona has joined #openstack-neutron | 06:19 | |
| *** lajos-katona has left #openstack-neutron | 06:19 | |
| *** vikasc has joined #openstack-neutron | 06:19 | |
| *** rcernin has joined #openstack-neutron | 06:19 | |
| *** edgar has quit IRC | 06:20 | |
| openstackgerrit | Merged openstack/python-neutronclient: Add flavor argument to loadbalancer v2 create https://review.openstack.org/223303 | 06:20 |
| *** yamamoto has quit IRC | 06:22 | |
| *** yamamoto has joined #openstack-neutron | 06:23 | |
| *** tflynn_ has joined #openstack-neutron | 06:24 | |
| *** tflynn has quit IRC | 06:24 | |
| *** akamyshnikova has joined #openstack-neutron | 06:24 | |
| *** apuimedo|zzz has joined #openstack-neutron | 06:24 | |
| *** wolverineav has joined #openstack-neutron | 06:27 | |
| *** sleviim has joined #openstack-neutron | 06:28 | |
| *** wolverineav has quit IRC | 06:31 | |
| *** tbh has joined #openstack-neutron | 06:32 | |
| *** vishwanathj has joined #openstack-neutron | 06:33 | |
| *** spandhe has joined #openstack-neutron | 06:35 | |
| *** gberginc has joined #openstack-neutron | 06:35 | |
| *** sthillma has quit IRC | 06:37 | |
| *** amotoki has quit IRC | 06:39 | |
| *** josecastroleon has joined #openstack-neutron | 06:39 | |
| *** gberginc has quit IRC | 06:39 | |
| *** vikasc has quit IRC | 06:41 | |
| *** ekuris has joined #openstack-neutron | 06:41 | |
| *** zhangjn has quit IRC | 06:42 | |
| *** vthapar has joined #openstack-neutron | 06:45 | |
| *** wang has joined #openstack-neutron | 06:45 | |
| *** wang is now known as Guest42640 | 06:45 | |
| *** alger has quit IRC | 06:46 | |
| *** gberginc has joined #openstack-neutron | 06:46 | |
| *** garyk1 has joined #openstack-neutron | 06:51 | |
| *** sudipto has joined #openstack-neutron | 06:55 | |
| *** neeti has joined #openstack-neutron | 06:56 | |
| *** gildub has quit IRC | 06:56 | |
| *** roeyc has joined #openstack-neutron | 06:56 | |
| *** amotoki has joined #openstack-neutron | 06:57 | |
| *** jprovazn has joined #openstack-neutron | 06:58 | |
| *** javeriak has joined #openstack-neutron | 06:58 | |
| *** SridharG has joined #openstack-neutron | 06:58 | |
| *** manjeets has quit IRC | 06:59 | |
| *** Sukhdev_ has joined #openstack-neutron | 06:59 | |
| *** jet-rongl has joined #openstack-neutron | 07:01 | |
| *** nlahouti2 has quit IRC | 07:01 | |
| *** Sukhdev has quit IRC | 07:03 | |
| *** javeriak has quit IRC | 07:05 | |
| *** Sukhdev_ has quit IRC | 07:06 | |
| *** mohankumar has quit IRC | 07:06 | |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron: Update toctree of neutron document https://review.openstack.org/249603 | 07:08 |
| *** armax has quit IRC | 07:08 | |
| *** rubasov has quit IRC | 07:08 | |
| *** wwj has joined #openstack-neutron | 07:09 | |
| *** itzikb has joined #openstack-neutron | 07:09 | |
| *** Guest42640 has quit IRC | 07:13 | |
| *** vivek-ebay has joined #openstack-neutron | 07:13 | |
| dasm | good morning o/ | 07:13 |
| *** Marga_ has quit IRC | 07:15 | |
| trinaths | very good morning | 07:15 |
| *** Marga_ has joined #openstack-neutron | 07:15 | |
| openstackgerrit | Trinath Somanchi proposed openstack/neutron: Freescale ML2 driver code complete decomposition. https://review.openstack.org/249037 | 07:16 |
| *** spandhe has quit IRC | 07:18 | |
| *** yfried has joined #openstack-neutron | 07:18 | |
| *** bmwiedemann has joined #openstack-neutron | 07:19 | |
| *** vivek-ebay has quit IRC | 07:19 | |
| *** shaohe_feng has quit IRC | 07:20 | |
| bmwiedemann | Hi, is that normal that http://tarballs.openstack.org/neutron/neutron-stable-kilo.tar.gz contains neutron-8.0.0.dev486 instead of 2015.1.3 that it still had yesterday | 07:20 |
| *** alger has joined #openstack-neutron | 07:21 | |
| *** wwj has quit IRC | 07:22 | |
| *** roeyc has quit IRC | 07:22 | |
| *** spandhe has joined #openstack-neutron | 07:22 | |
| bmwiedemann | neutron-stable-liberty.tar.gz is also bad. | 07:25 |
| *** wwj has joined #openstack-neutron | 07:26 | |
| *** Ramanjaneya has quit IRC | 07:26 | |
| *** Ramanjaneya has joined #openstack-neutron | 07:26 | |
| *** scheuran has joined #openstack-neutron | 07:26 | |
| *** alger has quit IRC | 07:29 | |
| *** doug-fish has joined #openstack-neutron | 07:30 | |
| *** javeriak has joined #openstack-neutron | 07:31 | |
| *** korean101 has joined #openstack-neutron | 07:31 | |
| korean101 | Hi | 07:31 |
| *** nyechiel has joined #openstack-neutron | 07:32 | |
| *** nmagnezi has joined #openstack-neutron | 07:33 | |
| *** shaohe_feng has joined #openstack-neutron | 07:34 | |
| *** dims has joined #openstack-neutron | 07:35 | |
| *** doug-fish has quit IRC | 07:35 | |
| *** mohankumar has joined #openstack-neutron | 07:35 | |
| *** Ramanjaneya has quit IRC | 07:36 | |
| *** ekuris has quit IRC | 07:36 | |
| *** fedexo has quit IRC | 07:36 | |
| *** anshul has joined #openstack-neutron | 07:37 | |
| korean101 | can i ask something? | 07:38 |
| *** toddnni has quit IRC | 07:38 | |
| *** jschwarz has quit IRC | 07:38 | |
| *** salv-orlando has joined #openstack-neutron | 07:38 | |
| korean101 | i delpoy 2 instance on two different compute node (compute-001/compute-002) | 07:38 |
| korean101 | using DVR (via VXLAN) | 07:38 |
| openstackgerrit | Swaminathan Vasudevan proposed openstack/neutron: Debug patch to test the gate failures on SSHTimeOut https://review.openstack.org/247748 | 07:39 |
| korean101 | i got poor iperf performance 2Gbps between 2 instance | 07:39 |
| *** dims_ has joined #openstack-neutron | 07:39 | |
| korean101 | is it maximum speed? (2Gbps) | 07:39 |
| korean101 | VXLAN limitations? | 07:40 |
| *** Ramanjaneya has joined #openstack-neutron | 07:40 | |
| dasm | korean101: what kind of nics do you have? | 07:40 |
| dasm | vxlan has degradation but shouldn't be soo poor | 07:40 |
| *** dims has quit IRC | 07:40 | |
| *** salv-orlando has quit IRC | 07:41 | |
| *** javeriak has quit IRC | 07:42 | |
| *** gildub has joined #openstack-neutron | 07:45 | |
| *** SurajD has quit IRC | 07:47 | |
| *** rcernin_ has joined #openstack-neutron | 07:47 | |
| slaweq_work | korean101: I had something like that on 10G NIC some time ago | 07:47 |
| slaweq_work | problem was with vhost-net process (it use only one core) | 07:47 |
| *** javeriak has joined #openstack-neutron | 07:47 | |
| slaweq_work | solution was to use Jumbo frames on vms (and ofcourse on hosts also) | 07:48 |
| *** nyechiel has quit IRC | 07:48 | |
| *** ekuris has joined #openstack-neutron | 07:49 | |
| *** SurajD has joined #openstack-neutron | 07:50 | |
| *** itzikb has quit IRC | 07:52 | |
| *** nyechiel has joined #openstack-neutron | 07:52 | |
| korean101 | dasm: Broadcom 57810 | 07:53 |
| *** javeriak has quit IRC | 07:54 | |
| *** javeriak has joined #openstack-neutron | 07:54 | |
| korean101 | i already set jumbo frame 9000 both of all (host/guest) | 07:54 |
| *** oshvartz_ has joined #openstack-neutron | 07:56 | |
| *** itzikb has joined #openstack-neutron | 07:56 | |
| *** oshvartz has joined #openstack-neutron | 07:56 | |
| *** mohankumar has quit IRC | 07:57 | |
| *** javeriak_ has joined #openstack-neutron | 07:57 | |
| *** javeriak has quit IRC | 07:59 | |
| *** zhangjn has joined #openstack-neutron | 07:59 | |
| *** zhangjn has quit IRC | 08:00 | |
| *** zhangjn has joined #openstack-neutron | 08:01 | |
| enikanorov | korean101: did you set network_device_mtu in nova.conf for nova-compute? | 08:02 |
| korean101 | enikanorov: no, isn't it deprecated? | 08:04 |
| *** shaohe_feng1 has joined #openstack-neutron | 08:04 | |
| *** tmorin has joined #openstack-neutron | 08:04 | |
| *** roeyc has joined #openstack-neutron | 08:05 | |
| *** tflynn has joined #openstack-neutron | 08:05 | |
| *** dedery has joined #openstack-neutron | 08:05 | |
| enikanorov | korean101: virtual interfaces for the instance are created by nova-compute. if you don't configure it so use jumbos, you'll be left with 1500 on VIFs in the middle of the path | 08:06 |
| *** djan_ has joined #openstack-neutron | 08:06 | |
| *** RA_ has quit IRC | 08:06 | |
| *** shaohe_feng has quit IRC | 08:06 | |
| *** djan has quit IRC | 08:07 | |
| korean101 | enikanorov: ok, now i'll try it | 08:08 |
| korean101 | enikanorov: thanks! | 08:08 |
| *** tflynn_ has quit IRC | 08:08 | |
| itzikb | moshele: good morning | 08:08 |
| itzikb | moshele: regarding the patch - http://144.76.193.39/ci-artifacts/217177/18/Tempest-Sriov/logs/q-sriov-agt.log.gz | 08:08 |
| *** shashank_hegde has quit IRC | 08:10 | |
| korean101 | enikanorov: qbr402988fb-83, qvo402988fb-83, qvb402988fb-83 all mtu 9000 | 08:10 |
| enikanorov | ok, then everything looks ok... can you verify that ping does well? | 08:11 |
| enikanorov | *goes | 08:11 |
| enikanorov | ping > 1500 bytes | 08:12 |
| korean101 | enikanorov: wait, i'll try it | 08:12 |
| *** spandhe has quit IRC | 08:13 | |
| korean101 | enikanorov: # ping -s 2000 192.168.1.101 PING 192.168.1.101 (192.168.1.101) 2000(2028) bytes of data. | 08:13 |
| *** Luigi_ has joined #openstack-neutron | 08:13 | |
| *** Ramanjaneya has quit IRC | 08:13 | |
| *** dedery has quit IRC | 08:14 | |
| *** dedery has joined #openstack-neutron | 08:15 | |
| *** markus_z has joined #openstack-neutron | 08:15 | |
| *** zhangjn has quit IRC | 08:16 | |
| korean101 | enikanorov: host: physical interface mtu 9000, veth mtu 9000, VHOST_NET_ENABLED=1 | 08:16 |
| korean101 | enikanorov: guest: eth0 mtu 1450 | 08:16 |
| *** matrohon has joined #openstack-neutron | 08:17 | |
| korean101 | enikanorov: but i got same result, 2Gbps... | 08:17 |
| enikanorov | if you have recent version, you can increase mtu on gues via api, setting network mtu accordingly | 08:17 |
| enikanorov | if it is not helping, i would suggest to play with physical interface offloading modes | 08:18 |
| korean101 | enikanorov: Kilo release, i manullay set "ip link set mtu 9000 eth0" | 08:18 |
| *** dedery has quit IRC | 08:18 | |
| enikanorov | korean101: is it vlan deployment? | 08:19 |
| enikanorov | ah, vxlan | 08:19 |
| korean101 | enikanorov: and i already set host's offload "ethtool -K eth1 tx-udp_tnl-segmentation off" | 08:19 |
| korean101 | enikanorov: yes, vxlan | 08:19 |
| *** achanda has joined #openstack-neutron | 08:19 | |
| enikanorov | vxlan should have mtu like 8950 on guest | 08:19 |
| korean101 | enikanorov: ok minus 50 | 08:19 |
| korean101 | enikanorov: i'll try again | 08:19 |
| enikanorov | anyway, depending on the NIC, different offloading options might affect performance | 08:19 |
| *** dedery has joined #openstack-neutron | 08:20 | |
| *** Luigi_ has quit IRC | 08:20 | |
| korean101 | enikanorov: !!!!!!! | 08:20 |
| *** Luigi_ has joined #openstack-neutron | 08:20 | |
| enikanorov | is it better now? | 08:21 |
| korean101 | enikanorov: OMG!!! thanks | 08:21 |
| korean101 | enikanorov: i got 10Gbps | 08:21 |
| enikanorov | good! | 08:21 |
| korean101 | enikanorov: so genius | 08:21 |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron: Update toctree of neutron document https://review.openstack.org/249603 | 08:21 |
| korean101 | enikanorov: actually 'veth mtu' is good | 08:21 |
| *** ildikov has quit IRC | 08:22 | |
| *** hitalia has quit IRC | 08:22 | |
| *** thorst has joined #openstack-neutron | 08:23 | |
| openstackgerrit | Andreas Scheuring proposed openstack/neutron: lb: ml2-agt: Separate AgentLoop from LinuxBridge specific impl https://review.openstack.org/246318 | 08:23 |
| *** mickeys has joined #openstack-neutron | 08:24 | |
| *** eil397 has quit IRC | 08:24 | |
| *** javeriak_ has quit IRC | 08:25 | |
| slaweq_work | korean101: but as I said, probably You need to change MTU on vms also | 08:27 |
| *** javeriak has joined #openstack-neutron | 08:27 | |
| slaweq_work | if You have mtu 9000 on NICs then please set e.g. 8950 on vms | 08:27 |
| slaweq_work | and test iperf then | 08:27 |
| *** thorst has quit IRC | 08:27 | |
| korean101 | slaweq_work: yes, thanks! you are right | 08:28 |
| slaweq_work | ok | 08:28 |
| korean101 | slaweq_work: many thanks!!! | 08:28 |
| *** tflynn has quit IRC | 08:28 | |
| *** zhangjn has joined #openstack-neutron | 08:29 | |
| *** oshvartz has quit IRC | 08:30 | |
| *** yfried_ has joined #openstack-neutron | 08:30 | |
| *** wolverineav has joined #openstack-neutron | 08:31 | |
| *** oshvartz_ has quit IRC | 08:31 | |
| *** yfried has quit IRC | 08:31 | |
| *** javeriak has quit IRC | 08:32 | |
| *** mickeys has quit IRC | 08:32 | |
| *** achanda has quit IRC | 08:33 | |
| *** wenjianhn has joined #openstack-neutron | 08:33 | |
| *** diga has quit IRC | 08:33 | |
| *** wolverineav has quit IRC | 08:35 | |
| *** wwj has quit IRC | 08:36 | |
| *** neeti has quit IRC | 08:36 | |
| *** wwj has joined #openstack-neutron | 08:37 | |
| amotoki | korean101: it seems you already solved your question. Without vxlan offload nic, we need to set larger mtu like 8950. | 08:38 |
| *** jpena has joined #openstack-neutron | 08:39 | |
| *** Ramanjaneya has joined #openstack-neutron | 08:39 | |
| *** nplanel has quit IRC | 08:39 | |
| *** lajos-katona has joined #openstack-neutron | 08:40 | |
| amotoki | korean101: this is our test results about one year ago (with icehouse neutron) | 08:40 |
| amotoki | korean101: http://www.slideshare.net/VirtualTech-JP/2014-4-qopenstackfallpresentationpublic20150310a | 08:40 |
| amotoki | korean101: see p.15 | 08:40 |
| *** jlanoux has joined #openstack-neutron | 08:41 | |
| *** maht has joined #openstack-neutron | 08:42 | |
| *** hdaniel has joined #openstack-neutron | 08:44 | |
| *** subscope has joined #openstack-neutron | 08:44 | |
| *** hdaniel_ has joined #openstack-neutron | 08:44 | |
| openstackgerrit | ting wang proposed openstack/neutron: fix some misspellings https://review.openstack.org/249635 | 08:44 |
| korean101 | amotoki: oh, thanks | 08:44 |
| *** lajos-katona has left #openstack-neutron | 08:44 | |
| korean101 | amotoki: but VXLAN offload doesn't pretty much better | 08:45 |
| amotoki | korean101: doesn't vlxan offload show good perfoamcne? | 08:45 |
| amotoki | *performance | 08:45 |
| *** anshul has quit IRC | 08:47 | |
| *** edgar has joined #openstack-neutron | 08:48 | |
| korean101 | amotoki: yes, not pretty much | 08:50 |
| *** neeti has joined #openstack-neutron | 08:50 | |
| amotoki | korean101: a good point is that we can get better perfoamcen with 1500 mtu. | 08:50 |
| korean101 | amotoki: # ethtool -K eth1 tx-udp_tnl-segmentation off | 08:51 |
| korean101 | amotoki: i use that command | 08:51 |
| korean101 | amotoki: broadcom 57810 10G NIC | 08:51 |
| amotoki | korean101: 8950 mtu in guests sometimes leads to a trouble for external connections. | 08:51 |
| *** anshul has joined #openstack-neutron | 08:51 | |
| amotoki | korean101: yeah,, it looks offload is disabled. | 08:52 |
| *** edgar has quit IRC | 08:52 | |
| *** ihrachys has joined #openstack-neutron | 08:52 | |
| *** Luigi_ has quit IRC | 08:54 | |
| *** sridhar_ram has joined #openstack-neutron | 08:54 | |
| *** Luigi_ has joined #openstack-neutron | 08:55 | |
| *** dedery has quit IRC | 08:55 | |
| *** ygbo has joined #openstack-neutron | 08:57 | |
| *** yfried_ has quit IRC | 08:58 | |
| *** hdaniel_ has quit IRC | 08:58 | |
| *** yfried has joined #openstack-neutron | 08:58 | |
| *** hdaniel has quit IRC | 08:58 | |
| *** hdaniel has joined #openstack-neutron | 08:59 | |
| *** sridhar_ram has quit IRC | 08:59 | |
| *** mohankumar has joined #openstack-neutron | 09:01 | |
| *** ferest has joined #openstack-neutron | 09:03 | |
| *** lajos-katona1 has joined #openstack-neutron | 09:06 | |
| *** apuimedo|zzz is now known as apuimedo | 09:08 | |
| *** itzikb_ has joined #openstack-neutron | 09:10 | |
| *** mkoderer_ is now known as mkoderer | 09:11 | |
| *** achanda has joined #openstack-neutron | 09:11 | |
| *** itzikb has quit IRC | 09:11 | |
| *** igordcard has joined #openstack-neutron | 09:12 | |
| igordcard | hi mohankumar | 09:12 |
| igordcard | mohankumar, how are you? | 09:13 |
| *** kawa2014 has joined #openstack-neutron | 09:13 | |
| *** rossella_s has quit IRC | 09:14 | |
| *** rossella_s has joined #openstack-neutron | 09:14 | |
| *** wang has joined #openstack-neutron | 09:15 | |
| *** wang is now known as Guest23546 | 09:15 | |
| *** vivek-ebay has joined #openstack-neutron | 09:16 | |
| *** wwj has quit IRC | 09:17 | |
| mohankumar | igordcard, good .. i had an question , it got clarified . thanks :) | 09:17 |
| igordcard | mohankumar, I have a question too now | 09:18 |
| *** ildikov has joined #openstack-neutron | 09:18 | |
| *** nyechiel_ has joined #openstack-neutron | 09:18 | |
| *** lajos-katona1 has left #openstack-neutron | 09:18 | |
| *** yfried has quit IRC | 09:18 | |
| *** fer__ has joined #openstack-neutron | 09:19 | |
| igordcard | mohankumar, can you set up a chain with the mpls correlation with the current code? | 09:19 |
| *** trinaths has left #openstack-neutron | 09:20 | |
| *** nyechiel has quit IRC | 09:20 | |
| igordcard | mohankumar, oh, I think it got clarified too, the Flow Classifier is marked as WIP | 09:20 |
| *** vivek-ebay has quit IRC | 09:20 | |
| *** lezbar has quit IRC | 09:21 | |
| *** mohankumar has quit IRC | 09:22 | |
| *** tfukushima has joined #openstack-neutron | 09:23 | |
| *** skraynev has quit IRC | 09:23 | |
| *** Prem_ has quit IRC | 09:25 | |
| *** dguitarbite has quit IRC | 09:26 | |
| *** salv-orlando has joined #openstack-neutron | 09:27 | |
| *** salv-orlando has quit IRC | 09:28 | |
| *** Prithiv has joined #openstack-neutron | 09:28 | |
| *** lezbar has joined #openstack-neutron | 09:28 | |
| *** neiljerram has joined #openstack-neutron | 09:29 | |
| *** sudipto has quit IRC | 09:29 | |
| *** salv-orlando has joined #openstack-neutron | 09:29 | |
| *** dguitarbite has joined #openstack-neutron | 09:29 | |
| *** ferest has quit IRC | 09:31 | |
| *** iwamoto has quit IRC | 09:31 | |
| openstackgerrit | Sreekumar S proposed openstack/neutron: Disabling/Re-enabling ML2 type driver create orphan n/w segments https://review.openstack.org/245137 | 09:32 |
| openstackgerrit | Reedip proposed openstack/python-neutronclient: Support for Name field in Members and HMs https://review.openstack.org/246077 | 09:34 |
| *** dims_ has quit IRC | 09:34 | |
| *** jistr has joined #openstack-neutron | 09:35 | |
| *** annp has joined #openstack-neutron | 09:36 | |
| *** fer__ has quit IRC | 09:37 | |
| *** terryyao has quit IRC | 09:37 | |
| *** itzikb has joined #openstack-neutron | 09:37 | |
| *** sthillma has joined #openstack-neutron | 09:37 | |
| *** itzikb_ has quit IRC | 09:41 | |
| *** achanda has quit IRC | 09:41 | |
| *** kbyrne has joined #openstack-neutron | 09:42 | |
| *** dansmith has quit IRC | 09:42 | |
| bmwiedemann | this is wrong: curl -s http://tarballs.openstack.org/neutron/neutron-stable-kilo.tar.gz | tar tvz|head -3 | 09:43 |
| bmwiedemann | there should not be neutron-8.0.0.dev | 09:44 |
| bmwiedemann | should it? | 09:44 |
| *** dansmith has joined #openstack-neutron | 09:45 | |
| *** dansmith is now known as Guest11153 | 09:45 | |
| *** subscope has quit IRC | 09:46 | |
| *** rubasov has joined #openstack-neutron | 09:47 | |
| moshele | itzikb: hi | 09:47 |
| itzikb | moshele: hi there | 09:47 |
| *** amotoki has quit IRC | 09:48 | |
| moshele | itizkb: what is the question? | 09:48 |
| moshele | itzkb: what is the question? | 09:48 |
| *** lajos-katona has joined #openstack-neutron | 09:48 | |
| *** mohankumar has joined #openstack-neutron | 09:49 | |
| openstackgerrit | Merged openstack/neutron: Fix typo for OVSDB https://review.openstack.org/249499 | 09:49 |
| *** salv-orlando has quit IRC | 09:50 | |
| *** Guest23546 has quit IRC | 09:50 | |
| *** kbyrne has quit IRC | 09:50 | |
| *** kbyrne has joined #openstack-neutron | 09:50 | |
| *** brad_behle_ has joined #openstack-neutron | 09:50 | |
| *** yfried has joined #openstack-neutron | 09:51 | |
| *** sleviim has quit IRC | 09:52 | |
| *** oshvartz has joined #openstack-neutron | 09:53 | |
| *** oshvartz_ has joined #openstack-neutron | 09:53 | |
| *** swat30 has quit IRC | 09:53 | |
| *** bapalm has quit IRC | 09:53 | |
| *** brad_behle has quit IRC | 09:54 | |
| *** sgran has quit IRC | 09:54 | |
| *** sgran has joined #openstack-neutron | 09:54 | |
| *** sshen_ has joined #openstack-neutron | 09:54 | |
| *** sshen has quit IRC | 09:55 | |
| *** bapalm has joined #openstack-neutron | 09:55 | |
| *** swat30 has joined #openstack-neutron | 09:56 | |
| openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Delete HA network when last HA router is deleted https://review.openstack.org/207395 | 09:56 |
| *** sthillma has quit IRC | 09:57 | |
| *** sthillma has joined #openstack-neutron | 09:57 | |
| ajo | ihrachys , kevinbenton : if you could have another read of https://review.openstack.org/#/c/241154/ (rpc callback rolling upgrade mechanism) I'd start pumping code in | 09:57 |
| *** fzdarsky has joined #openstack-neutron | 09:57 | |
| *** salv-orlando has joined #openstack-neutron | 09:57 | |
| openstackgerrit | Merged openstack/neutron: Freescale ML2 driver code complete decomposition. https://review.openstack.org/249037 | 10:00 |
| *** tbh is now known as Guest4968 | 10:01 | |
| *** zhenguo has quit IRC | 10:01 | |
| *** Guest4968 has joined #openstack-neutron | 10:02 | |
| *** mhickey has joined #openstack-neutron | 10:02 | |
| *** fer_ has joined #openstack-neutron | 10:02 | |
| *** miyagishi_t has quit IRC | 10:02 | |
| *** sthillma has quit IRC | 10:03 | |
| *** Marga_ has quit IRC | 10:04 | |
| *** baoli has quit IRC | 10:06 | |
| *** rcernin_ has quit IRC | 10:06 | |
| *** hoangcx has quit IRC | 10:06 | |
| *** Marga_ has joined #openstack-neutron | 10:06 | |
| *** RA_ has joined #openstack-neutron | 10:07 | |
| *** zhangjn has quit IRC | 10:09 | |
| *** jet-rongl has quit IRC | 10:09 | |
| *** silvrax has joined #openstack-neutron | 10:11 | |
| silvrax | I have a question about the enable_distributed_routing setting in the ovs agent ini. The networking guide suggests to enable it on the network node, but the wiki says the opposite. So I'm wondering what to do with it. | 10:12 |
| *** EinstCrazy has quit IRC | 10:13 | |
| *** neeti has quit IRC | 10:13 | |
| *** yamamoto has quit IRC | 10:15 | |
| *** subscope has joined #openstack-neutron | 10:16 | |
| *** Marga_ has quit IRC | 10:17 | |
| *** tfukushima has quit IRC | 10:21 | |
| *** anshul has quit IRC | 10:22 | |
| *** ygbo has quit IRC | 10:23 | |
| *** ygbo has joined #openstack-neutron | 10:25 | |
| *** jet-rongl has joined #openstack-neutron | 10:27 | |
| *** kobis has joined #openstack-neutron | 10:29 | |
| *** anshul has joined #openstack-neutron | 10:30 | |
| *** javeriak has joined #openstack-neutron | 10:30 | |
| *** SurajD has quit IRC | 10:31 | |
| ihrachys | ajo: on it, yeah. wanted to (probably) +2 yesterday | 10:31 |
| *** igordcard has quit IRC | 10:32 | |
| *** safchain has joined #openstack-neutron | 10:33 | |
| *** SurajD has joined #openstack-neutron | 10:34 | |
| *** RA_ has quit IRC | 10:34 | |
| *** roeyc has quit IRC | 10:36 | |
| *** yfried has quit IRC | 10:37 | |
| *** yfried_ has joined #openstack-neutron | 10:37 | |
| openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Delete HA network when last HA router is deleted https://review.openstack.org/207395 | 10:38 |
| ihrachys | ajo: I left some comments there, nothing critical, but I hope we can quickly respin before I +2 | 10:39 |
| *** iyamahat has joined #openstack-neutron | 10:39 | |
| scheuran | ZZelle, rossella_s, could you please have a look at this patchset again? https://review.openstack.org/#/c/238584/ | 10:43 |
| scheuran | It's about making the ovs hashing mechanism common. Should be in good shape after a couple of rounds.. | 10:43 |
| *** yamahata has quit IRC | 10:43 | |
| rossella_s | scheuran, will put it in my queue, will review later today :) | 10:43 |
| scheuran | rossella_s, thanks! | 10:43 |
| ZZelle | scheuran, me tto | 10:43 |
| ZZelle | scheuran, me too | 10:43 |
| *** tomoe_ has quit IRC | 10:43 | |
| scheuran | ZZelle, perfect, thanks! | 10:44 |
| *** dedery has joined #openstack-neutron | 10:44 | |
| openstackgerrit | Rossella Sblendido proposed openstack/neutron: Revert "Revert "OVS agent reacts to events instead of polling"" https://review.openstack.org/245105 | 10:44 |
| *** iyamahat has quit IRC | 10:46 | |
| *** subscope has quit IRC | 10:47 | |
| *** javeriak has quit IRC | 10:47 | |
| *** RA_ has joined #openstack-neutron | 10:47 | |
| *** LZ has quit IRC | 10:49 | |
| *** annp has quit IRC | 10:50 | |
| *** ekuris has quit IRC | 10:50 | |
| *** javeriak has joined #openstack-neutron | 10:52 | |
| *** yamamoto has joined #openstack-neutron | 10:53 | |
| *** stanzgy has quit IRC | 10:56 | |
| *** yamamoto has quit IRC | 10:56 | |
| *** yamamoto has joined #openstack-neutron | 10:57 | |
| *** RA_ has quit IRC | 11:00 | |
| *** wenjianhn has quit IRC | 11:04 | |
| *** yamamoto_ has joined #openstack-neutron | 11:11 | |
| *** Guest11153 has quit IRC | 11:12 | |
| mhickey | ZZelle: Hi | 11:13 |
| *** yamamoto has quit IRC | 11:15 | |
| *** edgar has joined #openstack-neutron | 11:15 | |
| *** dansmith has joined #openstack-neutron | 11:15 | |
| *** dansmith is now known as Guest10504 | 11:15 | |
| *** RA_ has joined #openstack-neutron | 11:15 | |
| *** sambetts-afk is now known as sambetts | 11:15 | |
| mhickey | ZZelle: Thanks for review comments on config generation. I have a question on it if you have time? | 11:16 |
| *** vivek-ebay has joined #openstack-neutron | 11:18 | |
| *** sudipto has joined #openstack-neutron | 11:18 | |
| *** gongysh__ has quit IRC | 11:19 | |
| *** gongysh_ has quit IRC | 11:19 | |
| *** edgar has quit IRC | 11:19 | |
| ajo | ihrachys : ping https://review.openstack.org/#/c/241154/10/doc/source/devref/rpc_callbacks.rst (L124) | 11:20 |
| *** yamamoto_ has quit IRC | 11:20 | |
| ajo | I think we don't have the report of enabled extensions until later in mitaka | 11:20 |
| *** shaohe_feng1 has quit IRC | 11:21 | |
| *** roeyc has joined #openstack-neutron | 11:21 | |
| *** vivek-ebay has quit IRC | 11:23 | |
| *** Fdaisuke has joined #openstack-neutron | 11:23 | |
| ihrachys | ajo: it's not about extensions (they are l2 agent only anyway) | 11:24 |
| ajo | ihrachys , I got it wrong, then | 11:24 |
| ihrachys | ajo: I mean, the agent itself should define the active list of objects of interest | 11:24 |
| *** nplanel has joined #openstack-neutron | 11:24 | |
| ihrachys | ajo: not all types, just those that it's going to subscribe to | 11:24 |
| ajo | ihrachys , ahhh, | 11:24 |
| ajo | ok, I agree on that | 11:24 |
| ajo | we can build the list based on the subscriptions made | 11:24 |
| ajo | not on the know objects | 11:25 |
| ajo | that makes sense | 11:25 |
| ihrachys | ajo: I even think that later in line 144 you mention it | 11:25 |
| *** yamamoto has joined #openstack-neutron | 11:25 | |
| ihrachys | ajo: otherwise we would e.g. make neutron-server to send old qos policy versions even when all qos enabled agents are upgraded | 11:25 |
| ihrachys | ajo: there is only a question about current agents that did not send the list | 11:26 |
| ajo | hmm, I don't understand how would that happen | 11:26 |
| ihrachys | ajo: so maybe for L->M we may need to push all qos policy updates anyway, but for M->N we could drop it | 11:26 |
| ihrachys | ajo: ok, I will try to describe the scenario | 11:26 |
| ajo | yeah, I think we need to assume, if qos service is installed, we have to check connected l2 agents, and consider them interested in QoSPolicy 1.0 | 11:27 |
| ajo | ihrachys : correct | 11:27 |
| ajo | ihrachys , thanks | 11:27 |
| *** Guest10504 has quit IRC | 11:29 | |
| ihrachys | ajo: you upgrade your neutron-server, it restarts and detects agents that 'know' about qos_policy==1.0. so it starts to broadcast it. so far so good. then you go and upgrade all your qos enabled agents to the new version, and restart them. note there are other agents with qos not enabled; they don't care about qos policies, but they still 'know' qos_policy==1.0. neutron-server still has the agent entry in db, so it still | 11:29 |
| ihrachys | broadcasts 1.0 for those agents, even though they don't really need it. | 11:29 |
| *** djan_ has quit IRC | 11:30 | |
| *** brad_behle_ has quit IRC | 11:30 | |
| *** wuhg has quit IRC | 11:31 | |
| *** dansmith_ has joined #openstack-neutron | 11:31 | |
| *** yamamoto has quit IRC | 11:32 | |
| *** tbachman_ has joined #openstack-neutron | 11:33 | |
| *** javeriak_ has joined #openstack-neutron | 11:33 | |
| *** Luigi_ has quit IRC | 11:35 | |
| ajo | ihrachys , ah, yes, that's why I mean we should consider only the agents known to use the qos extension | 11:36 |
| *** tbachman has quit IRC | 11:36 | |
| ajo | ihrachys , we could make for this L to M a filter like | 11:36 |
| *** tbachman_ is now known as tbachman | 11:36 | |
| *** Guest65357 is now known as beagles | 11:36 | |
| *** javeriak has quit IRC | 11:37 | |
| ajo | ihrachys : if agent is L2, and agent does not report objects and agent does not report extensions => it wants QoSPolicy 1.0 | 11:37 |
| ihrachys | ajo: the only party that actually knows about what's enabled is agent, and I don't think you want to base decision on the list of extension names reported by agent. for the least, you may have 3rd party extensions you don't even know about | 11:37 |
| ajo | starting at M, all L2 agents will report extensions | 11:37 |
| ajo | ihrachys : you know the binary name | 11:37 |
| ihrachys | ajo: yes, that assumption is the best you can do for L->M | 11:37 |
| ajo | ihrachys , but it's a good corner case, if for example you had updated agents, where qos is not enabled... | 11:38 |
| ajo | if we didn't go and look for the list of extensions in the l2 case, we would be sending "oldies" for all the cycle | 11:38 |
| ihrachys | ajo: right. well, currently, it's not much sense not to have qos enabled agents in the cloud if you enable the feature. | 11:39 |
| ajo | true | 11:39 |
| ihrachys | ajo: for the simple reason that we don't schedule on it :) | 11:39 |
| ihrachys | and that takes us to another thing you work on ;) | 11:39 |
| ajo | that'd be a broken configuration | 11:39 |
| ajo | ihrachys , so, may be it's enough to look for the agent binary names, and the list of "objects of interest", expecting an empty set if no object is subscribed | 11:40 |
| *** ferest has joined #openstack-neutron | 11:40 | |
| ihrachys | ajo: if you don't consider 3rd party l2 agents, yes | 11:40 |
| ajo | ihrachys , of course, we will target specific binary names, that's reported | 11:41 |
| ihrachys | ajo: are binary names always the same no matter how we package it? | 11:41 |
| ajo | ihrachys , yes | 11:41 |
| ajo | ihrachys , let me check for a reference | 11:41 |
| ihrachys | ah right, it is hardcoded, cool | 11:41 |
| ihrachys | self.agent_state = { | 11:41 |
| ihrachys | 'binary': 'neutron-openvswitch-agent', | 11:41 |
| ihrachys | so no extraction from sys.argv or smth like that | 11:42 |
| *** jamielennox is now known as jamielennox|away | 11:42 | |
| ajo | ihrachys : https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py#L93 | 11:42 |
| ajo | yep | 11:42 |
| ajo | it's fixed :) | 11:42 |
| ajo | at least for the two ones we care about | 11:42 |
| *** neeti has joined #openstack-neutron | 11:43 | |
| ajo | where "we care about" is == they rely on QoSPolicies | 11:43 |
| ajo | not that I don't care about other agents | 11:43 |
| *** ferest has quit IRC | 11:45 | |
| *** marcusvrn_ has joined #openstack-neutron | 11:47 | |
| *** EinstCrazy has joined #openstack-neutron | 11:47 | |
| openstackgerrit | Merged openstack/neutron: Clarify how we milestones are assigned https://review.openstack.org/249489 | 11:48 |
| *** zhangjn has joined #openstack-neutron | 11:48 | |
| *** zhangjn has quit IRC | 11:49 | |
| *** zhangjn has joined #openstack-neutron | 11:49 | |
| *** EinstCrazy has quit IRC | 11:49 | |
| *** EinstCrazy has joined #openstack-neutron | 11:50 | |
| *** dansmith_ has quit IRC | 11:52 | |
| *** dansmith_ has joined #openstack-neutron | 11:52 | |
| openstackgerrit | Brent Eagles proposed openstack/neutron: Adding a VNIC type for physical functions https://review.openstack.org/246923 | 11:52 |
| *** SurajD has quit IRC | 11:53 | |
| ZZelle | mhickey, hi | 11:53 |
| *** amotoki has joined #openstack-neutron | 11:54 | |
| *** gongysh_ has joined #openstack-neutron | 11:54 | |
| openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Avoid working with the transaction that has been rolled back https://review.openstack.org/230481 | 11:56 |
| *** SurajD has joined #openstack-neutron | 11:56 | |
| mhickey | ZZelle: Cheers on the review comments. Wondering what you mean by "oslo_config-generator is not installed"? | 11:57 |
| *** gongysh_ has quit IRC | 11:57 | |
| ZZelle | mhickey, iirc in the change it's written that users can use tox -egenconfig or tools/...sh directly | 11:58 |
| mhickey | ZZelle: yes; so tox target would call the script or script can be called directly | 11:59 |
| ZZelle | mhickey, in the 2nd case, you cannot ensure that oslo-config-generator (called by tools/....sh) is installed so it would be great to raise a meaningful error | 11:59 |
| mhickey | ZZelle: ok, understand what you mean. Makes sense. :) | 11:59 |
| ZZelle | mhickey, great | 11:59 |
| *** tbachman_ has joined #openstack-neutron | 12:00 | |
| mhickey | ZZelle: on the "link/anchor" in the release-notes file, do you mean to reference the review link instead? | 12:00 |
| *** lajos-katona1 has joined #openstack-neutron | 12:00 | |
| *** jamielennox|away is now known as jamielennox | 12:01 | |
| *** tbachman has quit IRC | 12:02 | |
| *** tbachman_ is now known as tbachman | 12:02 | |
| *** lajos-katona has quit IRC | 12:02 | |
| *** liangbo has joined #openstack-neutron | 12:02 | |
| ZZelle | mhickey, reference gerrit cgit url | 12:02 |
| *** yamamoto has joined #openstack-neutron | 12:02 | |
| *** subscope has joined #openstack-neutron | 12:02 | |
| ZZelle | mhickey, i am not fully sure what is the right way but it seems that releasenotes should reference only permalink | 12:03 |
| ZZelle | as we won't update release notes after their release | 12:03 |
| *** dansmith_ is now known as dansmith | 12:04 | |
| *** dansmith is now known as Guest87843 | 12:05 | |
| *** achanda has joined #openstack-neutron | 12:05 | |
| *** lajos-katona has joined #openstack-neutron | 12:05 | |
| *** lajos-katona1 has quit IRC | 12:05 | |
| *** jaypipes has joined #openstack-neutron | 12:05 | |
| mhickey | ZZelle: unsure waht cgit url is? | 12:06 |
| mhickey | *what* | 12:06 |
| *** gongysh_ has joined #openstack-neutron | 12:10 | |
| ZZelle | mhickey, https://git.openstack.org/cgit/openstack/neutron | 12:10 |
| mhickey | ZZelle: thanks | 12:14 |
| openstackgerrit | Oleg Bondarev proposed openstack/neutron: DVR:don't reschedule the l3 agent running on compute node https://review.openstack.org/245631 | 12:15 |
| *** maht has quit IRC | 12:15 | |
| *** jet-rongl has quit IRC | 12:16 | |
| *** rtheis has joined #openstack-neutron | 12:16 | |
| *** lajos-katona1 has joined #openstack-neutron | 12:18 | |
| *** MVenesio has joined #openstack-neutron | 12:18 | |
| *** neeti has quit IRC | 12:19 | |
| *** roeyc has quit IRC | 12:19 | |
| *** lajos-katona has quit IRC | 12:20 | |
| *** lajos-katona1 has quit IRC | 12:22 | |
| *** achanda has quit IRC | 12:24 | |
| *** thorst has joined #openstack-neutron | 12:24 | |
| *** gongysh_ has quit IRC | 12:25 | |
| *** mihero has quit IRC | 12:25 | |
| *** gongysh_ has joined #openstack-neutron | 12:25 | |
| *** sudipto has quit IRC | 12:27 | |
| *** thorst has quit IRC | 12:29 | |
| *** javeriak has joined #openstack-neutron | 12:29 | |
| *** javeriak_ has quit IRC | 12:29 | |
| *** gongysh_ has quit IRC | 12:31 | |
| *** lajos-katona has joined #openstack-neutron | 12:31 | |
| *** tomoe_ has joined #openstack-neutron | 12:33 | |
| *** achanda has joined #openstack-neutron | 12:33 | |
| openstackgerrit | Salvatore Orlando proposed openstack/neutron: Pecan: Streamline request body processing https://review.openstack.org/242680 | 12:33 |
| ihrachys | ZZelle: command not found seems like a reasonable error to me | 12:35 |
| *** RA_ has quit IRC | 12:36 | |
| *** achanda has quit IRC | 12:41 | |
| *** dedery_ has joined #openstack-neutron | 12:42 | |
| *** dims has joined #openstack-neutron | 12:42 | |
| *** tbachman has quit IRC | 12:42 | |
| *** ociuhandu has quit IRC | 12:43 | |
| *** fzdarsky is now known as fzdarsky|afk | 12:44 | |
| *** jpena is now known as jpena|lunch | 12:45 | |
| *** dedery has quit IRC | 12:45 | |
| *** dedery_ has quit IRC | 12:46 | |
| *** jerrygb has joined #openstack-neutron | 12:48 | |
| *** claudiub has joined #openstack-neutron | 12:49 | |
| *** terryyao has joined #openstack-neutron | 12:49 | |
| *** boris-42 has joined #openstack-neutron | 12:49 | |
| *** jaypipes_ has joined #openstack-neutron | 12:51 | |
| *** jaypipes has quit IRC | 12:51 | |
| *** jaypipes_ is now known as jaypipes | 12:53 | |
| *** anshul has quit IRC | 12:54 | |
| *** gildub has quit IRC | 12:54 | |
| *** ekuris has joined #openstack-neutron | 12:55 | |
| *** jinxing has joined #openstack-neutron | 12:57 | |
| openstackgerrit | Martin Hickey proposed openstack/neutron: [WIP] Automatically generate neutron core configuration files https://review.openstack.org/204206 | 12:58 |
| apuimedo | ihrachys: is jlibosva going to be around? | 12:58 |
| ihrachys | apuimedo: he is off to London starting from today; he'll be back in a week. | 12:58 |
| apuimedo | ihrachys: :-) | 12:59 |
| apuimedo | escaping the snow? | 12:59 |
| *** Prithiv has quit IRC | 12:59 | |
| *** Prithiv has joined #openstack-neutron | 12:59 | |
| *** korzen has joined #openstack-neutron | 12:59 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-neutronclient: Updated from global requirements https://review.openstack.org/247158 | 13:00 |
| *** javeriak has quit IRC | 13:00 | |
| ihrachys | apuimedo: not sure it's that much better in London, but hey | 13:02 |
| *** zhipeng has joined #openstack-neutron | 13:02 | |
| *** javeriak has joined #openstack-neutron | 13:02 | |
| *** bochi-michael has quit IRC | 13:02 | |
| apuimedo | true | 13:02 |
| *** shaohe_feng has joined #openstack-neutron | 13:03 | |
| *** chlong has joined #openstack-neutron | 13:03 | |
| *** jaypipes has quit IRC | 13:04 | |
| *** yamamoto has quit IRC | 13:05 | |
| *** Luigi has joined #openstack-neutron | 13:08 | |
| *** david-lyle has quit IRC | 13:09 | |
| ihrachys | apuimedo: also jlibosva seems to be one of those rare folks who actually enjoy snow | 13:09 |
| apuimedo | I do too :P | 13:10 |
| apuimedo | I'm glad it started snowing here | 13:10 |
| *** gongysh_ has joined #openstack-neutron | 13:11 | |
| *** salv-orlando has quit IRC | 13:12 | |
| *** jerrygb has quit IRC | 13:13 | |
| *** wang has joined #openstack-neutron | 13:13 | |
| *** Ramanjaneya has quit IRC | 13:13 | |
| *** wang is now known as Guest15159 | 13:14 | |
| *** rossella_s has quit IRC | 13:14 | |
| *** Guest15159 is now known as wwj | 13:14 | |
| *** rossella_s has joined #openstack-neutron | 13:14 | |
| *** wwj has quit IRC | 13:15 | |
| *** maht has joined #openstack-neutron | 13:16 | |
| *** skraynev has joined #openstack-neutron | 13:17 | |
| *** yamamoto has joined #openstack-neutron | 13:19 | |
| openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: devref: Rolling upgrade mechanism for rpc-callbacks https://review.openstack.org/241154 | 13:19 |
| ajo | ihrachys : https://review.openstack.org/#/c/241154/10..11/doc/source/devref/rpc_callbacks.rst | 13:19 |
| ajo | sorry for the delay :) | 13:19 |
| ajo | I hope it looks better | 13:19 |
| *** maht has quit IRC | 13:20 | |
| *** vivek-ebay has joined #openstack-neutron | 13:20 | |
| *** salv-orlando has joined #openstack-neutron | 13:23 | |
| *** salv-orlando has quit IRC | 13:24 | |
| *** javeriak has quit IRC | 13:24 | |
| *** salv-orlando has joined #openstack-neutron | 13:25 | |
| *** zhipeng has quit IRC | 13:25 | |
| *** vivek-ebay has quit IRC | 13:25 | |
| *** nmagnezi_ has joined #openstack-neutron | 13:26 | |
| *** jyuso1 has quit IRC | 13:27 | |
| *** tiswanso has quit IRC | 13:27 | |
| *** tiswanso has joined #openstack-neutron | 13:27 | |
| ihrachys | amotoki: ping re public client API | 13:29 |
| amotoki | pong | 13:29 |
| *** maht has joined #openstack-neutron | 13:29 | |
| amotoki | ihrachys: pong | 13:29 |
| *** ildikov has quit IRC | 13:29 | |
| ihrachys | amotoki: hi. which parts of client module are considered public? f.e. neutronclient/client.py? | 13:29 |
| ihrachys | is it public or private? | 13:30 |
| *** ociuhandu has joined #openstack-neutron | 13:30 | |
| amotoki | ihrachys: it is really a messy area. | 13:32 |
| amotoki | both HTTPClient and SessionClient in neutronclient.client work, but I don't think it is not intended to be used publicly. | 13:32 |
| amotoki | I think we need to have some generic client class as novaclient does. | 13:33 |
| ihrachys | amotoki: so I was looking at the following patch https://review.openstack.org/#/c/118006/15/neutronclient/client.py and it looked to me suspicious since it seems it changed API for those classes. | 13:33 |
| ihrachys | amotoki: also, please clarify your wording ^ is it 'not intended' or 'intended' to be used publicly? | 13:34 |
| *** jerrygb has joined #openstack-neutron | 13:34 | |
| openstackgerrit | Hirofumi Ichihara proposed openstack/neutron: Add availability_zone support for network https://review.openstack.org/204436 | 13:34 |
| *** gberginc has quit IRC | 13:35 | |
| amotoki | ihrachys: woops. i want to mean 'not intended' | 13:35 |
| *** gongysh_ has quit IRC | 13:35 | |
| *** ildikov has joined #openstack-neutron | 13:35 | |
| ihrachys | amotoki: ok, so if it's not intended, then the patch did not break guarantees, right? | 13:35 |
| amotoki | ihrachys: personally I think so and it sounds okay to me. I have never heard the clear definition :( | 13:36 |
| *** fzdarsky|afk is now known as fzdarsky | 13:37 | |
| amotoki | we don't use __all__ anywhere, and there is no way to declare what is public as class level. | 13:37 |
| amotoki | it is really a tricky point. | 13:37 |
| openstackgerrit | Salvatore Orlando proposed openstack/neutron: Scope get_tenant_quotas by tenant_id https://review.openstack.org/233855 | 13:38 |
| openstackgerrit | Salvatore Orlando proposed openstack/neutron: Pecan: Handle PolicyNotUnauthorizedException in policy hook https://review.openstack.org/234457 | 13:38 |
| ihrachys | amotoki: yeah, it would be great to have clear definition. f.e. if the module is not public, we could just rename it into e.g. neutronclient/_client.py | 13:38 |
| ihrachys | so that underscore signals it's private | 13:38 |
| *** itzikb has quit IRC | 13:38 | |
| *** jerrygb has quit IRC | 13:39 | |
| amotoki | but do we have this kind of naming convention in OpenStack? | 13:39 |
| ihrachys | amotoki: we definitely do have it in oslo, and I believe it's smth to follow | 13:39 |
| *** margaret_frances has joined #openstack-neutron | 13:39 | |
| amotoki | ihrachys: good news. will check. | 13:39 |
| Sam-I-Am | ihrachys: ran into this yesterday - but with linuxbridge - https://bugs.launchpad.net/neutron/+bug/1399249 | 13:40 |
| openstack | Launchpad bug 1399249 in neutron "Neutron openvswitch-agent doesn't recover ports from binding_failed status" [High,In progress] - Assigned to Nir Magnezi (nmagnezi) | 13:40 |
| Sam-I-Am | looks like its been around a while :/ | 13:40 |
| amotoki | ihrachys: another option is to use __all__. | 13:40 |
| ihrachys | Sam-I-Am: oh yeah, it's one of those things that don't happen | 13:41 |
| nmagnezi | Sam-I-Am, doing my best, last patchset sent yesterday | 13:41 |
| ihrachys | Sam-I-Am: we have a patch though, and afaik it's not ovs specific | 13:41 |
| nmagnezi | Sam-I-Am, new reviews came up just today | 13:41 |
| ihrachys | amotoki: ok, I will assume that part of API is not public :) | 13:42 |
| ihrachys | amotoki: thanks for clarifications on that one, I now feel more safe backporting it | 13:43 |
| Sam-I-Am | looks like the problem impacts both the ovs and lb agents | 13:43 |
| *** mohankumar has quit IRC | 13:43 | |
| *** roeyc has joined #openstack-neutron | 13:43 | |
| *** skraynev has quit IRC | 13:44 | |
| ihrachys | Sam-I-Am: it's ml2 plugin that does not retry https://review.openstack.org/#/c/162260/25/neutron/plugins/ml2/plugin.py | 13:44 |
| *** jianyong has quit IRC | 13:44 | |
| ihrachys | Sam-I-Am: so yes | 13:44 |
| ihrachys | Sam-I-Am: it's not driver speicfic | 13:44 |
| Sam-I-Am | nmagnezi: which patch set? | 13:44 |
| *** gongysh_ has joined #openstack-neutron | 13:44 | |
| *** baoli has joined #openstack-neutron | 13:45 | |
| Sam-I-Am | nmagnezi: ahh found it | 13:45 |
| Sam-I-Am | that bug has a few listed | 13:45 |
| *** ildikov has quit IRC | 13:47 | |
| ihrachys | nmagnezi: I need to admit the code becomes too complicated to follow, again :| | 13:48 |
| Sam-I-Am | yeah i just looked at that code | 13:48 |
| Sam-I-Am | eeeoooo | 13:48 |
| nmagnezi | ihrachys, it was complicated to begin with, and sadly I agree | 13:49 |
| *** liangbo has quit IRC | 13:49 | |
| Sam-I-Am | looking at it before coffee is even worse | 13:49 |
| ihrachys | Sam-I-Am: try scotch | 13:49 |
| *** tomoe_ has quit IRC | 13:49 | |
| Sam-I-Am | now theres an idea | 13:50 |
| Sam-I-Am | unit test - shot glass | 13:50 |
| nmagnezi | Sam-I-Am, they are in the works, as I states in the patch.. | 13:50 |
| *** tiswanso has quit IRC | 13:54 | |
| *** claudiub_ has joined #openstack-neutron | 13:55 | |
| *** oshvartz_ has quit IRC | 13:56 | |
| *** Guest4968 has quit IRC | 13:57 | |
| *** jaypipes has joined #openstack-neutron | 13:57 | |
| *** oshvartz_ has joined #openstack-neutron | 13:57 | |
| *** lajos-katona1 has joined #openstack-neutron | 13:57 | |
| *** ildikov has joined #openstack-neutron | 13:57 | |
| *** abregman has quit IRC | 13:58 | |
| *** lajos-katona has quit IRC | 13:58 | |
| *** abregman has joined #openstack-neutron | 13:58 | |
| ihrachys | ajo: some more nits for devref | 13:58 |
| ajo | ihrachys : ack, will handle it after qos meeting | 13:59 |
| ihrachys | ajo: I believe html there are issues with how you refer to other pages | 13:59 |
| ihrachys | ajo: sure | 13:59 |
| openstackgerrit | Merged openstack/neutron: fix some misspellings https://review.openstack.org/249635 | 13:59 |
| ajo | ihrachys , ah, I was waiting on the render to see how the link worked | 13:59 |
| *** zhenguo has joined #openstack-neutron | 13:59 | |
| openstackgerrit | Merged openstack/neutron: Remove duplicate deprecation messages for quota_items option https://review.openstack.org/233244 | 13:59 |
| ihrachys | ajo: actually it seems render link is broken now, I suspect constraints jobs enabled broke it | 13:59 |
| ihrachys | ajo: so you need to check locally for now | 13:59 |
| ihrachys | ajo: I will reach Nachi on that one | 14:00 |
| ajo | thanks ihrachys | 14:00 |
| *** margaret_frances has quit IRC | 14:00 | |
| ihrachys | ajo: meeting? | 14:00 |
| *** ekuris has quit IRC | 14:00 | |
| *** amuller has joined #openstack-neutron | 14:01 | |
| ajo | ping hdaniel #openstack-meeting-3 | 14:01 |
| ajo | QoS meeting :) | 14:01 |
| *** mfranc213 has joined #openstack-neutron | 14:01 | |
| *** skraynev has joined #openstack-neutron | 14:01 | |
| openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Delete HA network when last HA router is deleted https://review.openstack.org/207395 | 14:02 |
| *** dane_leblanc has joined #openstack-neutron | 14:02 | |
| *** mfranc213 has quit IRC | 14:02 | |
| *** shausy has quit IRC | 14:03 | |
| *** mfranc213 has joined #openstack-neutron | 14:03 | |
| *** tbachman has joined #openstack-neutron | 14:04 | |
| *** vivek-ebay has joined #openstack-neutron | 14:04 | |
| *** oshvartz_ has quit IRC | 14:04 | |
| *** oshvartz_ has joined #openstack-neutron | 14:05 | |
| *** SurajD has quit IRC | 14:05 | |
| *** jinxing has quit IRC | 14:05 | |
| *** oshvartz_ has quit IRC | 14:05 | |
| *** oshvartz_ has joined #openstack-neutron | 14:06 | |
| *** SurajD has joined #openstack-neutron | 14:06 | |
| *** openstackgerrit has quit IRC | 14:06 | |
| *** jinxing has joined #openstack-neutron | 14:06 | |
| *** openstackgerrit has joined #openstack-neutron | 14:07 | |
| *** dane_leblanc has quit IRC | 14:09 | |
| *** dane_leblanc has joined #openstack-neutron | 14:11 | |
| *** bdemers has joined #openstack-neutron | 14:12 | |
| *** jerrygb has joined #openstack-neutron | 14:13 | |
| *** ekuris has joined #openstack-neutron | 14:14 | |
| *** mohankumar has joined #openstack-neutron | 14:15 | |
| *** ekuris has quit IRC | 14:15 | |
| *** ekuris has joined #openstack-neutron | 14:17 | |
| *** jpena|lunch is now known as jpena | 14:18 | |
| *** tiswanso has joined #openstack-neutron | 14:18 | |
| *** rcernin has quit IRC | 14:19 | |
| *** dane_leblanc has quit IRC | 14:20 | |
| *** mohankumar has quit IRC | 14:20 | |
| *** thorst_ has joined #openstack-neutron | 14:21 | |
| *** dane_leblanc has joined #openstack-neutron | 14:21 | |
| *** mfranc213 has quit IRC | 14:22 | |
| *** thorst__ has joined #openstack-neutron | 14:22 | |
| *** yamamoto has quit IRC | 14:23 | |
| *** regXboi has joined #openstack-neutron | 14:25 | |
| *** thorst_ has quit IRC | 14:26 | |
| *** thorst__ has quit IRC | 14:29 | |
| *** fer_ has quit IRC | 14:30 | |
| *** lindycoder has joined #openstack-neutron | 14:30 | |
| *** thorst_ has joined #openstack-neutron | 14:30 | |
| *** rpothier has joined #openstack-neutron | 14:30 | |
| *** sudipto has joined #openstack-neutron | 14:32 | |
| *** Guest87843 is now known as dansmith | 14:32 | |
| openstackgerrit | Rossella Sblendido proposed openstack/neutron: Revert "Revert "OVS agent reacts to events instead of polling"" https://review.openstack.org/245105 | 14:33 |
| *** thorst_ has quit IRC | 14:35 | |
| *** Swami has joined #openstack-neutron | 14:35 | |
| *** oshvartz_ has quit IRC | 14:35 | |
| *** oshvartz_ has joined #openstack-neutron | 14:36 | |
| *** Tiancheng has joined #openstack-neutron | 14:37 | |
| gsagie | kevinbenton: ping | 14:37 |
| *** jianyong has joined #openstack-neutron | 14:37 | |
| *** oshvartz has quit IRC | 14:38 | |
| *** terryyao has quit IRC | 14:39 | |
| mhickey | ihrachys: Hello. Do you have time for question? | 14:40 |
| *** yamamoto has joined #openstack-neutron | 14:40 | |
| ihrachys | mhickey: yes, though I am in a meeting, so it may take a while to respond | 14:41 |
| mhickey | ihrachys: thats fine; in no rush, just need some advice :) | 14:41 |
| *** javeriak has joined #openstack-neutron | 14:42 | |
| ihrachys | mhickey: shoot | 14:42 |
| *** tomoe_ has joined #openstack-neutron | 14:43 | |
| *** nyechiel_ has quit IRC | 14:43 | |
| *** tomoe_ has quit IRC | 14:43 | |
| *** tomoe_ has joined #openstack-neutron | 14:43 | |
| *** gongysh_ has quit IRC | 14:43 | |
| mhickey | ihrachys: https://github.com/openstack/neutron/blob/master/neutron/quota/__init__.py#L325 calls the deprecated function with the explicit msg | 14:44 |
| *** fer_ has joined #openstack-neutron | 14:44 | |
| mhickey | ihrachys: The opts code which loads config items for the config generation imports quota | 14:45 |
| mhickey | ihrachys: hence this deprecated msg is displayed for each run of the generator per config file | 14:45 |
| *** sudipto has quit IRC | 14:45 | |
| mhickey | ihrachys: Is this ok until the method is eventually removed? | 14:46 |
| ihrachys | mhickey: why do you care? Also, I think the deprecation warning was fixed lately with https://github.com/openstack/neutron/commit/3945250118e83cbdc4f792d38ebac128eb31ec8a | 14:46 |
| *** mgoddard_ has joined #openstack-neutron | 14:46 | |
| *** rpothier has left #openstack-neutron | 14:46 | |
| mhickey | ihrachys: I am asking incase someone might care? | 14:46 |
| mhickey | ihrachys: just wondering, thats all. thanks for the feedback. :) | 14:47 |
| *** mgoddard has quit IRC | 14:50 | |
| ihrachys | mhickey: we did care. that's why we removed the message. | 14:50 |
| ihrachys | mhickey: but even if we did not yet, it should not have affected your work | 14:50 |
| mhickey | ihrachys: sure. wanted to be sure i wasn't creating an issue. | 14:52 |
| ihrachys | mhickey: you create awesomeness so far | 14:52 |
| *** ildikov has quit IRC | 14:52 | |
| *** gongysh_ has joined #openstack-neutron | 14:53 | |
| mhickey | ihrachys: one last thing... | 14:53 |
| *** pradk has joined #openstack-neutron | 14:54 | |
| *** Redcavalier has joined #openstack-neutron | 14:55 | |
| mhickey | ihrachys: wrt upgrade work; what should I be looking into? | 14:56 |
| *** ekuris has quit IRC | 14:59 | |
| *** Prithiv has quit IRC | 14:59 | |
| ihrachys | mhickey: I don't think you have assigned yourself to anything? If I were you, I would better make sure generator thing goes in M1. | 15:00 |
| ihrachys | mhickey: we can discuss assignments for upgrades next irc meeting. is it ok for you? | 15:00 |
| ajo | irenab , not sure if the neutron agents have a way to tell you which fields changed, | 15:00 |
| ajo | probably that's cleared out at notification time | 15:00 |
| ajo | neutron agents->neutron objects | 15:01 |
| *** jianyong has quit IRC | 15:01 | |
| *** gongysh_ has quit IRC | 15:01 | |
| *** johnbelamaric has joined #openstack-neutron | 15:01 | |
| irenab | ajo: I must to leave now. will ping you later to share my thoughts on this | 15:01 |
| ihrachys | irenab: yeah, it may be the agent extension, but it's a tiny bit later than we could make the decision. | 15:01 |
| ajo | irenab: we should probably either mute it at a higher level (service plugin) | 15:01 |
| ajo | irenab : or introduce an extra flag to the notification drivers to indicate if rules changed | 15:01 |
| ihrachys | ajo: extension maintains policy objects cache, so it can determine it | 15:01 |
| *** davidsha has joined #openstack-neutron | 15:02 | |
| mhickey | ihrachys: sure. i wasn't sure how best to get involved with the upgrade work. | 15:02 |
| irenab | ajo: ihrachys : Best way to be to filter this change out so it won’t notify at all | 15:02 |
| ajo | ihrachys , yes, we could ignore them at agent level | 15:02 |
| ajo | but then we don't save unnecesary messages, | 15:02 |
| ihrachys | mhickey: it's my fault, I need to think of how to make all folks interested full with stuff to tinker :) | 15:02 |
| irenab | but maybe some backends would keep the desciption ... | 15:02 |
| ajo | said that, may be some implementations could care about object updates via RPC (including description) for some reason | 15:02 |
| ihrachys | mhickey: I will think of it till next meeting | 15:02 |
| ajo | irenab : yes | 15:02 |
| ajo | so may be it's better to ignore non useful ones on the agent | 15:03 |
| *** fer_ has quit IRC | 15:03 | |
| ajo | irenab : see you ;) | 15:03 |
| irenab | ajo: I think we sahre similar dillamas :-). will ping you later to decide | 15:03 |
| mhickey | ihrachys: wrt generator work; I think it is in a good state now, just waiting on the update to descriptions. Do you think there is a need for more patche(s) to finish the bp? | 15:03 |
| ihrachys | irenab: yeah, in theory some backends may care about description. though I can't come up with real use cases, it may be more 'pure' to notify the agent. | 15:04 |
| mhickey | or are we getting on top of the work? | 15:04 |
| *** SridharG has left #openstack-neutron | 15:04 | |
| ihrachys | mhickey: I will try to stop the time with my portable time machine now and sqeeze some minutes for the patch now. | 15:04 |
| openstackgerrit | Hirofumi Ichihara proposed openstack/neutron: Add availability_zone support for router https://review.openstack.org/224418 | 15:04 |
| *** manjeets has joined #openstack-neutron | 15:05 | |
| *** ildikov has joined #openstack-neutron | 15:05 | |
| mhickey | ihrachys: that would be great whenever you get a chance; no rush! Thanks for feedback.:) | 15:06 |
| *** vikasc has joined #openstack-neutron | 15:07 | |
| ihrachys | mhickey: there is rush | 15:07 |
| ihrachys | mhickey: M1 it's called | 15:07 |
| mhickey | ihrachys: ok, understand. | 15:07 |
| korzen | hi ihrachys, do we know if the RFEs are needed for OVO impl? | 15:07 |
| ihrachys | korzen: I did not have time to touch base with armax on this one yesterday (though we had a chat), I will try to reach him today. | 15:08 |
| Sam-I-Am | mhickey: moo | 15:09 |
| Sam-I-Am | mhickey: seems like there was a comment about updating the option descriptions. want to make sure we're all on the same page there. | 15:09 |
| mhickey | Sam-I-Am: Hey. Sure, I just put in as a placeholder. Shoot.. | 15:10 |
| korzen | ihrachys ack | 15:12 |
| Sam-I-Am | mhickey: cedric's comment | 15:12 |
| *** nmagnezi_ has quit IRC | 15:12 | |
| *** signed8bit has joined #openstack-neutron | 15:14 | |
| *** karthiks has quit IRC | 15:14 | |
| ajo | ihrachys , moshele , njohnston , irenab , slaweq_work : https://review.openstack.org/249842 | 15:14 |
| *** mlavalle has joined #openstack-neutron | 15:15 | |
| ihrachys | ajo: I presume you checked it's even this week? | 15:15 |
| ajo | ihrachys , yes I compared to the neutron meetings which alternate | 15:15 |
| *** fer_ has joined #openstack-neutron | 15:15 | |
| ihrachys | aye cool | 15:15 |
| ajo | so next week would be no meeting, and the week after would be meeting | 15:15 |
| *** yalie has joined #openstack-neutron | 15:16 | |
| *** nmagnezi has quit IRC | 15:16 | |
| *** aix has quit IRC | 15:16 | |
| *** mkolesni has quit IRC | 15:17 | |
| *** TrevorV has joined #openstack-neutron | 15:18 | |
| *** aduyck has joined #openstack-neutron | 15:18 | |
| *** Marga_ has joined #openstack-neutron | 15:18 | |
| *** ahduyck has joined #openstack-neutron | 15:18 | |
| mhickey | Sam-I-Am: sorry; give me a few mins... | 15:19 |
| Sam-I-Am | mhickey: sure, dont think its a big deal as long as everyone's on the same page with the scope of the patch | 15:20 |
| *** tomoe_ has quit IRC | 15:21 | |
| *** garyk1 has quit IRC | 15:23 | |
| *** edgar__ has joined #openstack-neutron | 15:24 | |
| *** shaohe_feng has quit IRC | 15:29 | |
| sc68cal | ajo: hey you wanted to talk about classifiers? | 15:30 |
| Sam-I-Am | sc68cal: moo? | 15:30 |
| *** chlong has quit IRC | 15:31 | |
| sc68cal | Sam-I-Am: hey dude, sorry about yesterday - had to talk caroline to doctor yesterday and today | 15:31 |
| Sam-I-Am | ew | 15:31 |
| *** mgoddard has joined #openstack-neutron | 15:32 | |
| *** shaohe_feng has joined #openstack-neutron | 15:32 | |
| *** Fdaisuke has left #openstack-neutron | 15:32 | |
| sc68cal | Sam-I-Am: I know I owe you a chat about multinode | 15:32 |
| sc68cal | Sam-I-Am: I'm free now, if you want to chat over IRC - i'm having breakfast at my coffee place | 15:32 |
| Sam-I-Am | yeah that works. give me a few mins. | 15:33 |
| *** mgoddard_ has quit IRC | 15:33 | |
| amuller | carl_baldwin: kevinbenton: HA network deletion patch by akamyshnikova is ready for review | 15:33 |
| kevinbenton | amuller: link? | 15:34 |
| amuller | kevinbenton: https://review.openstack.org/#/c/207395/ | 15:34 |
| *** mohankumar has joined #openstack-neutron | 15:34 | |
| Sam-I-Am | kevinbenton: ohai! | 15:35 |
| Sam-I-Am | kevinbenton: https://bugs.launchpad.net/bugs/1519509 | 15:35 |
| openstack | Launchpad bug 1519509 in neutron "Creating instances fails after enabling port_security extension on existing deployment" [Undecided,New] | 15:35 |
| Sam-I-Am | if you get a few mins. there's some confusion on my bug. | 15:36 |
| *** signed8bit has quit IRC | 15:38 | |
| kevinbenton | Sam-I-Am: yeah, in a meeting for next 20 mins but after that i can look | 15:38 |
| Sam-I-Am | kevinbenton: thx | 15:38 |
| *** nplanel has quit IRC | 15:39 | |
| ihrachys | mhickey: so I am looking at that debug agent changes in the patch, and I really don't see why you need to do anything there | 15:39 |
| ihrachys | mhickey: it works fine with no changes in test_commands and debug/shell.py | 15:39 |
| ihrachys | mhickey: I reverted to the original and I am able to run the test successfully | 15:40 |
| *** signed8bit has joined #openstack-neutron | 15:40 | |
| *** matrohon has quit IRC | 15:41 | |
| ihrachys | mhickey: and since we don't have debug.ini file in the tree anyway, I don't think we should mind much. in theory, we could add another generator entry for debug.ini that would dump just that external bridge option there, but I don't see how it's in scope of the patch (which is 'getting rid of sample config files' I guess) | 15:41 |
| *** tomoe_ has joined #openstack-neutron | 15:42 | |
| *** nyechiel_ has joined #openstack-neutron | 15:43 | |
| kevinbenton | amuller: will you be around in a bit? i have some questions about that patch | 15:43 |
| amuller | kevinbenton: yep | 15:43 |
| *** tbachman has quit IRC | 15:43 | |
| *** tomoe_ has quit IRC | 15:44 | |
| *** jianyong has joined #openstack-neutron | 15:44 | |
| mhickey | Sam-I-Am: I'm back. Which comment from Cedric are you referring to? | 15:46 |
| Sam-I-Am | sc68cal: moo | 15:46 |
| kevinbenton | Sam-I-Am: just left a comment | 15:46 |
| Sam-I-Am | mhickey: oh the one about editing the descriptions in this patch | 15:46 |
| mhickey | Sam-I-Am: ok, the comment in the commit msg? | 15:48 |
| Sam-I-Am | yeah | 15:48 |
| sc68cal | Sam-I-Am: pong | 15:48 |
| Sam-I-Am | sc68cal: multinode! | 15:48 |
| mhickey | Sam-I-Am: Would you like to use the patch to update some help descriptions? | 15:49 |
| sc68cal | Sam-I-Am: all the nodes! | 15:49 |
| Sam-I-Am | kevinbenton: thx | 15:49 |
| Sam-I-Am | mhickey: that was the plan since some have already been updated | 15:49 |
| *** aix has joined #openstack-neutron | 15:49 | |
| Sam-I-Am | mhickey: i'm sure i'll fix more in a later patch, but a good once-through would be nice | 15:49 |
| Sam-I-Am | sc68cal: so talk to me. what are you doing with multinode? | 15:50 |
| mhickey | Sam-I-Am: Thats what I understand. Am I putting out the wrong message? | 15:50 |
| Sam-I-Am | mhickey: no. i just think there was some confusion about patch scope. | 15:51 |
| Sam-I-Am | turns out some of the descriptions in the code (that are now used) are poorly worded or vague/confusing | 15:51 |
| mhickey | ihrachys: ok, I get an error after making changes when I run the following tests: neutron/tests/unit/debug/test_commands.py | 15:52 |
| ihrachys | not sure why , but I don't :) | 15:52 |
| mhickey | ihrachys: I get the error: "oslo_config.cfg.DuplicateOptError: duplicate option: external_network_bridge" | 15:52 |
| sc68cal | Sam-I-Am: brb - coffee wifi stinks | 15:52 |
| Sam-I-Am | sc68cal: excellent | 15:52 |
| mhickey | Sam-I-Am: ok, could you add a comment to better define the scope? | 15:53 |
| ihrachys | mhickey: can you revert and push it into gate so that we see whether it's indeed some issue in the code, or just your local issue? | 15:53 |
| mhickey | or what is best opetion? | 15:53 |
| *** numans has quit IRC | 15:53 | |
| ihrachys | mhickey: (note that I still review the patch) | 15:54 |
| *** roeyc has quit IRC | 15:54 | |
| kevinbenton | amuller: ok. still there? | 15:54 |
| mhickey | ihrachys: sure; it could be my system | 15:54 |
| amuller | kevinbenton: ya | 15:54 |
| *** Sukhdev has joined #openstack-neutron | 15:54 | |
| kevinbenton | amuller: why does this start a transaction before calling _delete_ha_network? | 15:54 |
| mhickey | ihrachys: ok, thanks. | 15:54 |
| *** roeyc has joined #openstack-neutron | 15:54 | |
| *** roeyc has quit IRC | 15:55 | |
| amuller | kevinbenton: line 492? | 15:55 |
| kevinbenton | amuller: yep | 15:55 |
| amuller | kevinbenton: yeah that may need to be removed | 15:56 |
| kevinbenton | amuller: ok. i'll leave a comment | 15:56 |
| kevinbenton | amuller: i just want to make sure i wasn't rehashing something already discussed | 15:56 |
| amuller | kevinbenton: it shouldn't make a positive effect (grouping up a select and a write in a transaction), only a negative one, if core_plugin.delete_network is a complex operation with external calls | 15:57 |
| *** claudiub_ has quit IRC | 15:58 | |
| kevinbenton | amuller: right. if the network is concurrently deleted, it will be the same effect either way | 15:58 |
| *** boris-42 has quit IRC | 15:58 | |
| amuller | kevinbenton: this one's much more complex, interesting and important: https://review.openstack.org/#/c/230481/ | 15:59 |
| amuller | kevinbenton: I still have to go through the latest PS though | 15:59 |
| *** kobis has quit IRC | 16:00 | |
| *** zhangjn has quit IRC | 16:00 | |
| *** john-davidge has joined #openstack-neutron | 16:00 | |
| amuller | kevinbenton: that patch both fixes a L3 HA bug and should stabilize the fullstack job | 16:01 |
| *** Marga_ has quit IRC | 16:01 | |
| kevinbenton | amuller: is _create_ha_network itself called from within a transaction? | 16:02 |
| Sukhdev | mestery : Ping | 16:02 |
| sc68cal | Sam-I-Am: so - multinode | 16:03 |
| amuller | kevinbenton: are we still talking about the HA network deletion patch? | 16:03 |
| kevinbenton | amuller: no this second one you sent | 16:03 |
| kevinbenton | amuller: ah yes, i see that it is | 16:04 |
| amuller | kevinbenton: yes, that's one of the changes the patch makes | 16:04 |
| amuller | kevinbenton: it also puts create_port calls in a transaction | 16:04 |
| amuller | kevinbenton: check out create_router line 405 | 16:04 |
| kevinbenton | amuller: but what happens when one throws an exception? | 16:05 |
| amuller | kevinbenton: previously (before the patch) each operation was in its transaction: create_router, create_network, create_port | 16:05 |
| Sukhdev | mestery : I updated the bug - this is good to go - unless you have any additional question - https://bugs.launchpad.net/networking-l2gw/+bug/1518794 | 16:05 |
| openstack | Launchpad bug 1518794 in networking-l2gw "Release request for networking-L2GW for stable/liberty" [Medium,Confirmed] - Assigned to Sukhdev Kapur (sukhdev-8) | 16:05 |
| amuller | kevinbenton: currently we only manually rollback the router object | 16:05 |
| amuller | kevinbenton: then | 16:06 |
| Sam-I-Am | sc68cal: multinode! | 16:06 |
| amuller | kevinbenton: each resource is responsible for its own manual rollbacks | 16:06 |
| amuller | kevinbenton: including networks and ports | 16:06 |
| Sam-I-Am | mhickey: comment made | 16:06 |
| amuller | kevinbenton: for example line 269 | 16:06 |
| kevinbenton | amuller: yes, for networks and ports they need to be manually rolled back. using the db to undo it is not an option | 16:06 |
| *** jinxing has quit IRC | 16:06 | |
| Sam-I-Am | sc68cal: whats the status of it? | 16:06 |
| ihrachys | mhickey: ok I pushed some comments. take a look when you have time. | 16:06 |
| amuller | kevinbenton: they are | 16:07 |
| *** tbachman has joined #openstack-neutron | 16:07 | |
| kevinbenton | amuller: ok. so this is still using a delete_port/delete_network call to undo? | 16:07 |
| amuller | kevinbenton: yes | 16:07 |
| kevinbenton | amuller: then why are they all bundled into a transaction? | 16:07 |
| *** pavel_bondar_ has joined #openstack-neutron | 16:07 | |
| amuller | kevinbenton: the patch does two things: It fixes the manual rollback mechanism (It didn't actually work before...), secondly it bundles up create_router stuff in to a transaction | 16:07 |
| sc68cal | Sam-I-Am: there are a number of jobs that have been created, some that use devstack-gate to set up multiple nodes | 16:08 |
| kevinbenton | amuller: right, i don't understand the second part | 16:08 |
| amuller | kevinbenton: otherwise, if the base router object, and its HA specific resources are all in specific transactions, we kept getting hit by races between create_router and L3 agent syncs | 16:08 |
| sc68cal | Sam-I-Am: so, multinode for legacy l3, dvr, and now grenade upgrades | 16:08 |
| amuller | kevinbenton: an agent would try to sync after the base router object was committed but before its HA resources were | 16:08 |
| mhickey | ihrachys, Sam-I-Am: Thanks for comments | 16:08 |
| amuller | kevinbenton: so, two approaches, you either put everything in to a single transaction, or | 16:08 |
| *** daneyon_ has quit IRC | 16:08 | |
| amuller | kevinbenton: you try to deal with the races | 16:08 |
| mhickey | ihrachys: I will push PS first with changes rolled back in debug | 16:09 |
| *** dims has quit IRC | 16:09 | |
| *** daneyon has joined #openstack-neutron | 16:09 | |
| kevinbenton | amuller: right. fix the sync mechanism on the l3 agent to understand that the router isn't done being setup | 16:09 |
| *** jdandrea has joined #openstack-neutron | 16:09 | |
| amuller | kevinbenton: I don't think the fix should be in the agent code | 16:09 |
| mhickey | ihrachys: maybe work on comments tomorrow as have to head off in the next hour | 16:09 |
| amuller | kevinbenton: the server shouldn't return a half baked router | 16:09 |
| *** jdandrea has quit IRC | 16:09 | |
| kevinbenton | amuller: the issue is that we are pretending the ha router is one resource | 16:09 |
| *** armax has joined #openstack-neutron | 16:10 | |
| *** Piet has joined #openstack-neutron | 16:10 | |
| kevinbenton | amuller: an ML2 driver in post commit of network create can do a DB lookup right now with its own context | 16:10 |
| kevinbenton | amuller: this will break that | 16:10 |
| mhickey | ihrachys: wrt WIP, I put this in because of the update to help description. should i remove it? | 16:10 |
| *** jdandrea has joined #openstack-neutron | 16:10 | |
| kevinbenton | amuller: because it won't be 'post commit' anymore | 16:10 |
| *** dims has joined #openstack-neutron | 16:11 | |
| ihrachys | mhickey: what's about it? I may miss smth. | 16:11 |
| *** jdandrea has quit IRC | 16:11 | |
| amuller | kevinbenton: *sighs*, how on earth do advanced services use ml2, it's utterly broken | 16:11 |
| mhickey | ihrachys: sorry, what is question? | 16:11 |
| *** jdandrea has joined #openstack-neutron | 16:12 | |
| amuller | kevinbenton: someone sometime will have to decouple ml2's DB operations from its notifications and have it managed by another layer | 16:12 |
| kevinbenton | amuller: it's not a notification | 16:12 |
| kevinbenton | amuller: it's part of the creation process | 16:12 |
| kevinbenton | amuller: if an ml2 backend fails to wire your vlans correctly, you don't want to return success | 16:12 |
| amuller | kevinbenton: I consider any communications from neutron-server to a backend a notification | 16:13 |
| *** vikasc has quit IRC | 16:13 | |
| kevinbenton | amuller: and that's wrong for any system that requires resource allocation of other systems | 16:13 |
| *** crose has joined #openstack-neutron | 16:13 | |
| kevinbenton | any driver* that requires resource allocation | 16:13 |
| *** EinstCrazy has quit IRC | 16:14 | |
| kevinbenton | amuller: we can push to change the model so no backend is allowed to take part in the API operations | 16:14 |
| kevinbenton | amuller: and then set the status to DOWN for everything | 16:14 |
| kevinbenton | amuller: then they can try to asynchronously communicate with stuff and if it fails, change it to ERROR | 16:15 |
| *** vikasc has joined #openstack-neutron | 16:15 | |
| *** vthapar has quit IRC | 16:16 | |
| kevinbenton | amuller: similar to how nova handles instances | 16:16 |
| Sam-I-Am | sc68cal: its 2 nodes? | 16:16 |
| kevinbenton | amuller: however, I don't think it's a pattern in other projects to hide a bunch of API objects until they all reach a certain state | 16:17 |
| amuller | kevinbenton: Essentially I'd like to consider moving ml2 post_commit outside of... ml2 =D | 16:17 |
| ihrachys | mhickey: oh I actually caught the opts issue | 16:18 |
| amuller | kevinbenton: Have some sort of manager on top that can intelligently call post_commit ops after the entire parent transaction is commited | 16:18 |
| ihrachys | mhickey: I will look at it now that I have a way to reproduce | 16:18 |
| amuller | kevinbenton: and push the manual ml2 rollback code to that manager | 16:18 |
| amuller | kevinbenton: so that you can have l3 code (or adv. services), or anything really, use a single transaction for multiple operations including ml2 ops | 16:19 |
| kevinbenton | amuller: well ML2 can easily be changed to do it this way. the issue is that we are basically facing an API change now for any driver that used to have a say in creation | 16:19 |
| *** tomoe_ has joined #openstack-neutron | 16:19 | |
| *** vikasc has quit IRC | 16:19 | |
| kevinbenton | amuller: a current user of (e.g. big switch or arista) will know that the network was allocated on the backend as well when a create_network call returns | 16:20 |
| kevinbenton | amuller: if it fails, they will get an API error | 16:20 |
| *** Prithiv has joined #openstack-neutron | 16:20 | |
| kevinbenton | amuller: but what we are talking about doing would mean a success on every call | 16:20 |
| kevinbenton | amuller: and they would have to poll waiting for all of the status fields to update to ACTIVE | 16:20 |
| amuller | kevinbenton: Why an API change? Say you had a meta-ml2-manager batch up two operations: create_router, create_port. Commit both in one transaction, then call post_commit for the port | 16:21 |
| amuller | kevinbenton: how is that different than what we have now? | 16:21 |
| amuller | kevinbenton: (arista/bigswitch wise) | 16:21 |
| amuller | the transaction for the port just happened to also include router stuff | 16:21 |
| ihrachys | tonyb: https://review.openstack.org/#/c/249889/ yay | 16:21 |
| *** Tiancheng has quit IRC | 16:21 | |
| ihrachys | tonyb: hopefully the channel is still avail | 16:22 |
| kevinbenton | amuller: what do you suspect should happen when the network goes into ERROR state then? | 16:22 |
| *** rohit_ has joined #openstack-neutron | 16:23 | |
| kevinbenton | amuller: or the post commit fails | 16:23 |
| kevinbenton | amuller: is what i meant | 16:23 |
| amuller | kevinbenton: if the post commit fails you do what ml2 does now | 16:23 |
| amuller | kevinbenton: manual rollback for not only the port but also the router in this case | 16:23 |
| *** Sukhdev has quit IRC | 16:23 | |
| *** john-davidge has quit IRC | 16:23 | |
| sc68cal | Sam-I-Am: yes | 16:23 |
| mhickey | ihrachys: is it the issue with beug you have encountered? | 16:23 |
| mhickey | *debug* | 16:24 |
| ihrachys | mhickey: aye | 16:24 |
| amuller | kevinbenton: better yet stop manually rolling back stuff | 16:24 |
| kevinbenton | amuller: sure, but that's the API change | 16:24 |
| *** dane_leblanc has quit IRC | 16:24 | |
| amuller | kevinbenton: the reason we do manual rollbacks is for external notifications | 16:24 |
| mhickey | ihrachys: great, I will hold back then. was just about to deliver! :) | 16:24 |
| amuller | kevinbenton: do those without calling top level service plugin / core plugin methods | 16:24 |
| amuller | kevinbenton: if you tease out the messages from the plugin code | 16:24 |
| amuller | you can control them individually | 16:24 |
| *** Pavo has joined #openstack-neutron | 16:25 | |
| *** zhenguo has quit IRC | 16:25 | |
| kevinbenton | amuller: i don't know what that means | 16:25 |
| kevinbenton | amuller: what do you mean by control them individually? | 16:26 |
| *** crose has quit IRC | 16:26 | |
| *** mohankumar has quit IRC | 16:27 | |
| *** tomoe_ has quit IRC | 16:27 | |
| openstackgerrit | Merged openstack/neutron: Optimize router delete execution https://review.openstack.org/240971 | 16:28 |
| amuller | kevinbenton: hrmph, actually my suggestion may not be pragmatic with everything out of tree | 16:29 |
| amuller | kevinbenton: the more I think about this the more issues I find | 16:29 |
| amuller | kevinbenton: the gist of it is a framework that would queue up RPC/REST calls from ml2 drivers instead of calling them directly | 16:29 |
| amuller | commit the entire transaction (which may include router resources and ml2 resources, maybe more than one), then fire off those messages | 16:29 |
| rossella_s | mestery hi Kyle! hope you are the right person to ask, can you please have a look at bug 1519750, I'd like to have your opinion | 16:29 |
| openstack | bug 1519750 in neutron "stable tarball contains master version" [Undecided,New] https://launchpad.net/bugs/1519750 | 16:29 |
| *** subscope has quit IRC | 16:29 | |
| amuller | messages would be tied to their associated resources | 16:29 |
| mestery | rossella_s: Yes, will look | 16:29 |
| rossella_s | mestery, thanks! | 16:29 |
| kevinbenton | amuller: the REST call is not just a notification. it can be used to retrieve information and populate local database tables | 16:30 |
| kevinbenton | amuller: so we can let the drivers maintain all of the logic of what they want to do | 16:30 |
| *** scheuran has quit IRC | 16:30 | |
| kevinbenton | amuller: and just have them expose a 'post commit' method... :) | 16:30 |
| kevinbenton | amuller: that some manager calls after commit | 16:30 |
| *** lajos-katona1 has left #openstack-neutron | 16:30 | |
| amuller | kevinbenton: Does it matter? We still commit like we did before, we may just commit more than a single resource type | 16:31 |
| *** rubasov has quit IRC | 16:31 | |
| amuller | kevinbenton: And we still execute the REST call | 16:31 |
| kevinbenton | amuller: and when the call fails, what would you like to do? | 16:31 |
| amuller | kevinbenton: rollback the resource associated with the message | 16:31 |
| amuller | like we do now | 16:31 |
| mhickey | Sam-I-Am: Hey | 16:32 |
| kevinbenton | amuller: and does the API still block waiting for all of that to finish? | 16:32 |
| amuller | kevinbenton: yes | 16:32 |
| *** achanda has joined #openstack-neutron | 16:32 | |
| Sam-I-Am | mhickey: hey | 16:33 |
| kevinbenton | amuller: and this is all to make sure all neutron resources show up at the same time in the database | 16:33 |
| kevinbenton | amuller: right? | 16:34 |
| amuller | kevinbenton: It's much more than that no? | 16:34 |
| amuller | kevinbenton: looking at Ann's patch | 16:34 |
| mhickey | Sam-I-Am: I will not be doing any other changes today to the patch. So work away on your changes. | 16:34 |
| amuller | kevinbenton: users of ml2 have to take care of manual rollbacks | 16:34 |
| *** sthillma has joined #openstack-neutron | 16:35 | |
| amuller | kevinbenton: I don't wanna have to do that | 16:35 |
| amuller | I want it to be generalized | 16:35 |
| kevinbenton | amuller: this is the same for any advanced services that make use of nova instances for example | 16:35 |
| *** fedexo has joined #openstack-neutron | 16:35 | |
| amuller | kevinbenton: or *aaS that use ml2 | 16:35 |
| *** sthillma_ has joined #openstack-neutron | 16:35 | |
| amuller | kevinbenton: I don't know how they tackled this issue | 16:35 |
| amuller | kevinbenton: lbaas creates ports for example | 16:35 |
| amuller | octavia creates networks | 16:35 |
| kevinbenton | amuller: just delete the resource if you dont' want it anymore | 16:35 |
| amuller | kevinbenton: *just* | 16:36 |
| amuller | it's tricky, unmaintainable, and it's not details I want to concern myself with | 16:36 |
| kevinbenton | amuller: the thing that is unique to your situation is you want to lie to the agents and pretend that none of the resources exist until all of them do | 16:36 |
| amuller | kevinbenton: I want to use the concept known as a transaction =D | 16:36 |
| kevinbenton | when you ask ML2 for a network, you are asking for someting that involves external resources | 16:36 |
| kevinbenton | can* involve external resources | 16:37 |
| kevinbenton | so either we change the model to return that call do you right away and just indicate that some local database stuff has been done but there is no resource yet | 16:37 |
| kevinbenton | or you have to treat it as something that has actually happened and ask for it to be undone because you don't need it anymore | 16:38 |
| mhickey | Sam-I-Am,ihrachys:ok, I see your comments wrt description scope. sounds a sensible approach. | 16:38 |
| kevinbenton | we can write some code to help with the pattern of rolling back ML2 resources very easily in exceptions | 16:38 |
| kevinbenton | amuller: but that won't solve your other ask of not showing things that exist until all of the things exist | 16:38 |
| amuller | kevinbenton: Ann might just quit out of frustration if that patch takes a 180 =p | 16:39 |
| openstackgerrit | Timothy Swanson proposed openstack/neutron: Fix floating IP status for HA router https://review.openstack.org/249389 | 16:39 |
| kevinbenton | amuller: i'm fine with the cleanup stuff. i'm not quite comfortable with the bundling of everything into a transaction | 16:39 |
| *** sthillma has quit IRC | 16:40 | |
| *** sthillma_ is now known as sthillma | 16:40 | |
| kevinbenton | amuller: for that, can't you just change the get_routers method of l3 ha mixin to not return a router missing stuff? | 16:40 |
| amuller | kevinbenton: I'd have to think about it | 16:40 |
| kevinbenton | amuller: so that would protect the agents from seeing the routers that aren't ready? | 16:40 |
| amuller | kevinbenton: it's certainly possible to solve | 16:41 |
| amuller | kevinbenton: without bundling everything in to a transaction | 16:41 |
| amuller | it's just harder | 16:41 |
| kevinbenton | amuller: well are there examples of other projects that hide resources that are used by a different resource? | 16:42 |
| amuller | kevinbenton: not sure what you're asking | 16:42 |
| kevinbenton | amuller: do any other projects do what you are trying to do here | 16:42 |
| *** ajmiller has joined #openstack-neutron | 16:43 | |
| kevinbenton | amuller: put a bunch of different types of resource creations into one DB transaction | 16:43 |
| amuller | kevinbenton: I don't know, I'd think it's a safe bet | 16:43 |
| amuller | I'd be surprised if we don't have instances of that in the Neutron code base, unknowingly | 16:43 |
| *** Pavo_ has joined #openstack-neutron | 16:43 | |
| kevinbenton | amuller: we are pretty careful to prevent it in review | 16:44 |
| kevinbenton | amuller: at least we used to be | 16:44 |
| *** mohankumar has joined #openstack-neutron | 16:44 | |
| kevinbenton | amuller: can you just create the router last? | 16:44 |
| *** Sukhdev has joined #openstack-neutron | 16:45 | |
| kevinbenton | amuller: ah, interfaces need a reference to it. nevermind | 16:45 |
| *** hitalia has joined #openstack-neutron | 16:45 | |
| amuller | kevinbenton: we could move the HA network earlier | 16:45 |
| amuller | but yeah the port needs the router alive | 16:46 |
| *** mgoddard_ has joined #openstack-neutron | 16:46 | |
| kevinbenton | amuller: so L482 https://review.openstack.org/#/c/230481/11/neutron/db/l3_hamode_db.py | 16:47 |
| kevinbenton | amuller: what happens if that throws an exception | 16:47 |
| amuller | kevinbenton: bad things heh | 16:47 |
| kevinbenton | amuller: the session start at L477 will rollback everything that happened, right? | 16:47 |
| amuller | the update code is not as... well taken care of | 16:48 |
| sc68cal | Sam-I-Am: just put a post on the ML about upgrades - http://lists.openstack.org/pipermail/openstack-dev/2015-November/080503.html | 16:48 |
| *** javeriak has quit IRC | 16:48 | |
| *** javeriak has joined #openstack-neutron | 16:48 | |
| *** josecastroleon has quit IRC | 16:48 | |
| *** eil397 has joined #openstack-neutron | 16:48 | |
| *** iyamahat has joined #openstack-neutron | 16:49 | |
| *** josecastroleon has joined #openstack-neutron | 16:50 | |
| *** iyamahat has quit IRC | 16:50 | |
| *** iyamahat has joined #openstack-neutron | 16:50 | |
| *** mgoddard has quit IRC | 16:50 | |
| *** dane_leblanc has joined #openstack-neutron | 16:51 | |
| *** marun has joined #openstack-neutron | 16:52 | |
| *** yfried_ has quit IRC | 16:53 | |
| *** javeriak_ has joined #openstack-neutron | 16:53 | |
| *** javeriak has quit IRC | 16:53 | |
| amuller | kevinbenton: welp, fire alarm's going off, perfect time to head out to lunch | 16:54 |
| kevinbenton | amuller: the discussion of changing ML2 to return after commit right away has come up several times and i think lots of people are on boad | 16:54 |
| kevinbenton | amuller: backward compat in the API is the annoying part | 16:54 |
| kevinbenton | amuller: ack. ttyl | 16:54 |
| *** Pavo_ has quit IRC | 16:55 | |
| *** mohankumar has quit IRC | 16:55 | |
| *** dane_leblanc has quit IRC | 16:56 | |
| korzen | sc68cal, I have run the grenade multinode twice, one failed: http://logs.openstack.org/69/143169/60/experimental/gate-grenade-dsvm-neutron-multinode/bf6bae1/ | 16:56 |
| *** mgoddard_ has quit IRC | 16:56 | |
| garyk | eezhova: the following patch is causing the gate to fail quite a few times today - https://github.com/openstack/neutron/commit/bb16a2ef6c768d6fd685ab36f9dc94002f76e768 | 16:57 |
| *** mgoddard has joined #openstack-neutron | 16:57 | |
| garyk | any idea | 16:57 |
| korzen | sc68cal and one success: http://logs.openstack.org/69/143169/60/experimental/gate-grenade-dsvm-neutron-multinode/7c05ff0/ | 16:57 |
| garyk | please see bug https://bugs.launchpad.net/neutron/+bug/1519888 and http://logs.openstack.org/36/204436/50/check/gate-neutron-dsvm-functional/b3d357e/testr_results.html.gz | 16:57 |
| openstack | Launchpad bug 1519888 in neutron "Neutron gate failure for test_restart_l3_agent_on_sighup" [Undecided,New] | 16:57 |
| *** dsneddon has quit IRC | 16:57 | |
| *** TrevorV has quit IRC | 16:58 | |
| *** TrevorV has joined #openstack-neutron | 16:58 | |
| sc68cal | korzen: ok - please reply on the ML and add that link | 16:58 |
| sc68cal | korzen: nice find :) | 16:59 |
| *** amuller is now known as amuller_afk | 16:59 | |
| manjeets | amuller: ping | 16:59 |
| manjeets | garyk: ping | 17:00 |
| openstackgerrit | Rossella Sblendido proposed openstack/neutron: Revert "Revert "OVS agent reacts to events instead of polling"" https://review.openstack.org/245105 | 17:00 |
| *** dsneddon has joined #openstack-neutron | 17:02 | |
| *** jistr has quit IRC | 17:02 | |
| garyk | manjeets: yo yo | 17:02 |
| *** shaohe_feng has quit IRC | 17:02 | |
| *** dane_leblanc has joined #openstack-neutron | 17:03 | |
| *** hdaniel has quit IRC | 17:03 | |
| manjeets | when i creating router with --ha true then why -distributed is set to true by default? | 17:03 |
| manjeets | should'nt it be false by default ? | 17:03 |
| *** markvoelker has quit IRC | 17:03 | |
| *** abregman has quit IRC | 17:03 | |
| *** jlanoux has quit IRC | 17:04 | |
| *** ihrachys has quit IRC | 17:04 | |
| manjeets | if I just say --ha true it won't let me create router saying ha dvr is not supported | 17:04 |
| *** vikasc has joined #openstack-neutron | 17:04 | |
| sc68cal | manjeets: what is your neutron.conf ? is distributed the default for routers? | 17:06 |
| *** javeriak has joined #openstack-neutron | 17:06 | |
| *** javeriak_ has quit IRC | 17:06 | |
| *** mickeys has joined #openstack-neutron | 17:06 | |
| *** tmorin has quit IRC | 17:06 | |
| manjeets | its says router_distributed = True ? | 17:08 |
| manjeets | sc68cal: | 17:08 |
| *** roeyc has joined #openstack-neutron | 17:08 | |
| *** spandhe has joined #openstack-neutron | 17:08 | |
| *** spandhe has quit IRC | 17:08 | |
| sc68cal | manjeets: so - do we have a bug where if the default is for routers to be distributed, client requests with just --ha true are allowed - but client requests with --ha true and --distributed true fail? | 17:11 |
| *** maht has quit IRC | 17:11 | |
| *** eil397 has quit IRC | 17:12 | |
| *** ildikov has quit IRC | 17:12 | |
| *** mohankumar has joined #openstack-neutron | 17:12 | |
| manjeets | i think --ha true and --distributed true is not supported yet offcourse it fails but thats WIP | 17:12 |
| *** rossella_s has quit IRC | 17:14 | |
| manjeets | what my point if I am creating router saying --ha true it shows by defaults sets --distributed to true | 17:14 |
| sc68cal | manjeets: right - because you specified router_distributed = true in neutron.conf? | 17:14 |
| *** EinstCrazy has joined #openstack-neutron | 17:14 | |
| manjeets | so that default is read from conf ? i thought it was set somewhere in neutron code while creating router ? | 17:15 |
| sc68cal | manjeets: it can be set by an API request that specifies the value, but neutron also pulls in a default value from neutron.conf | 17:15 |
| *** amotoki has quit IRC | 17:15 | |
| sc68cal | manjeets: if it is not specified in the API request | 17:16 |
| *** rossella_s has joined #openstack-neutron | 17:16 | |
| sc68cal | manjeets: so - sounds like we are not validating well enough to take the setting from neutron.conf into account, when we check for the --ha and --distributed settings | 17:16 |
| manjeets | i'll check if it is specified in API. I would say it should not specified as true by default in api right ? | 17:16 |
| sc68cal | if I am not mistaken - we should be forcing API clients to do --ha true --distributed false | 17:16 |
| manjeets | yes thats what I am saying if user does not specify --distributed param it should be set to False | 17:17 |
| *** maht has joined #openstack-neutron | 17:17 | |
| sc68cal | manjeets: no | 17:17 |
| sc68cal | manjeets: if user does not specify --distributed param, the setting router_distributed in neutron.conf is consulted | 17:17 |
| *** nlahouti has joined #openstack-neutron | 17:18 | |
| sc68cal | manjeets: which means, we probably need to have better validation in the cases where router_distributed = true in neutron.conf, and an API client only sends --ha true in their api request | 17:18 |
| sc68cal | since it would create a router that is both HA, and DVR - which you said is not currently supported | 17:18 |
| sc68cal | and is rejected when someone explicitly sends a request with those params set | 17:19 |
| *** Luigi has quit IRC | 17:19 | |
| manjeets | consulting conf file also make sense because its upto provider how they want to set it up ? | 17:21 |
| manjeets | and question should we allow someone to create router if just --ha true is specified | 17:21 |
| manjeets | ? | 17:21 |
| *** X123 has joined #openstack-neutron | 17:21 | |
| *** ivar-lazzaro has joined #openstack-neutron | 17:22 | |
| *** moshele has quit IRC | 17:22 | |
| *** moshele has joined #openstack-neutron | 17:23 | |
| *** Marga_ has joined #openstack-neutron | 17:23 | |
| sc68cal | manjeets: not if router_distributed = true is set in neutron.conf | 17:23 |
| *** vikasc has quit IRC | 17:23 | |
| *** shashank_hegde has joined #openstack-neutron | 17:23 | |
| sc68cal | manjeets: it should throw the same error that doing a --ha true and --distributed true does | 17:23 |
| mhickey | Sam-I-Am, ihrachys: I have to head off. I will look at patch tomorrow and get to comments etc. | 17:23 |
| sc68cal | manjeets: if it actually does throw an error, i'm grepping the code now - do you know where that validation is? | 17:23 |
| Sam-I-Am | mhickey: thanksgiving here tomorrow, so i'll probably be working anyway :) | 17:24 |
| *** ivar-laz_ has joined #openstack-neutron | 17:24 | |
| manjeets | I think somewhere while creating router that validation is done | 17:24 |
| *** maht has quit IRC | 17:24 | |
| mhickey | Sam-I-Am: Move away from the keyboard! Enjoy the day! :) | 17:24 |
| Sam-I-Am | mhickey: what if i can take my keyboard with me? | 17:24 |
| mhickey | Sam-I-Am: ha, ha | 17:25 |
| *** maht has joined #openstack-neutron | 17:25 | |
| mhickey | Happy Thanksgiving to all celebrating it. | 17:25 |
| *** maht has quit IRC | 17:25 | |
| Sam-I-Am | i got sort of sidetracked today... | 17:25 |
| Sam-I-Am | as usual | 17:25 |
| mhickey | Sam-I-Am, ihrachys: thnaks for the help. :) | 17:25 |
| mhickey | *thanks* | 17:26 |
| sc68cal | manjeets: I'm not seeing it | 17:26 |
| *** nlahouti1 has joined #openstack-neutron | 17:26 | |
| mhickey | Sam-I-Am: not a boher | 17:26 |
| mhickey | *bother* | 17:26 |
| mhickey | Bye all | 17:26 |
| Sam-I-Am | seeya | 17:26 |
| sc68cal | manjeets: ok nevermind I found it | 17:27 |
| *** rossella_s has quit IRC | 17:27 | |
| *** ivar-lazzaro has quit IRC | 17:27 | |
| *** jerrygb has quit IRC | 17:27 | |
| *** nlahouti has quit IRC | 17:27 | |
| *** eil397 has joined #openstack-neutron | 17:27 | |
| manjeets | sc68cal: can you paste and share the link ? | 17:28 |
| sc68cal | manjeets: the check looks correct though - https://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L382 | 17:28 |
| *** jerrygb has joined #openstack-neutron | 17:28 | |
| *** jerrygb has quit IRC | 17:28 | |
| *** jerrygb has joined #openstack-neutron | 17:28 | |
| *** rossella_s has joined #openstack-neutron | 17:28 | |
| sc68cal | manjeets: and https://github.com/openstack/neutron/blob/master/neutron/db/l3_dvr_db.py#L801 does pull from neutron.conf | 17:28 |
| *** EinstCrazy has quit IRC | 17:29 | |
| *** ihrachys has joined #openstack-neutron | 17:29 | |
| *** david-lyle has joined #openstack-neutron | 17:30 | |
| ihrachys | mhickey: ok, I have a solution, see latest comment | 17:30 |
| sc68cal | manjeets: unless I'm missing something, but it looks ok when I speed read it | 17:30 |
| *** oshvartz_ has quit IRC | 17:32 | |
| *** iyamahat has quit IRC | 17:32 | |
| *** Swami has quit IRC | 17:33 | |
| *** Marga_ has quit IRC | 17:33 | |
| *** mhickey has quit IRC | 17:33 | |
| manjeets | sc68cal: yes thanks it looks fine since default is read from conf | 17:37 |
| manjeets | thanks sc68cal: | 17:37 |
| *** baoli has quit IRC | 17:37 | |
| sc68cal | manjeets: ok - so ... was this a fishing expedition or did you actually encounter this error in an environment | 17:37 |
| manjeets | i was exploring ha and dvr stuff and I was wondering why its not allowing me to create a router when i just say --ha true | 17:38 |
| *** ygbo has quit IRC | 17:38 | |
| manjeets | was thinking why by default it is true | 17:39 |
| *** abhiraut has joined #openstack-neutron | 17:39 | |
| *** abhiraut has quit IRC | 17:39 | |
| manjeets | I am trying in actual environment i have two node devstack | 17:39 |
| *** bdemers has quit IRC | 17:40 | |
| sc68cal | manjeets: ok - for some reason I interpreted that it was actually allowing the create through when you just specified --ha true and no --distributed | 17:40 |
| sc68cal | even though it was set to true in neutron.conf | 17:41 |
| sc68cal | my mistake | 17:41 |
| *** Sukhdev has quit IRC | 17:41 | |
| manjeets | no it is not allowing. if you just say --ha true | 17:41 |
| *** Sukhdev has joined #openstack-neutron | 17:41 | |
| sc68cal | manjeets: ah gotcha. | 17:42 |
| *** jerrygb has quit IRC | 17:43 | |
| *** spandhe has joined #openstack-neutron | 17:43 | |
| manjeets | it reads from conf thats what its intended to do . since I am new to neutron I did not know if reading from conf I thought it is set to default somewhwere in api | 17:43 |
| manjeets | thats why i was confirming if it had been set in api by default to true that should not be done | 17:43 |
| manjeets | thanks sc68cal: | 17:43 |
| sc68cal | manjeets: no problem - happy to help | 17:43 |
| *** Prithiv has quit IRC | 17:44 | |
| *** MVenesio has quit IRC | 17:44 | |
| *** MVenesio has joined #openstack-neutron | 17:45 | |
| *** changbl has quit IRC | 17:46 | |
| *** pavel_bondar_ has quit IRC | 17:47 | |
| *** kawa2014 has quit IRC | 17:47 | |
| *** nplanel has joined #openstack-neutron | 17:48 | |
| *** abhiraut has joined #openstack-neutron | 17:49 | |
| *** johnbelamaric has quit IRC | 17:50 | |
| *** Swami has joined #openstack-neutron | 17:50 | |
| *** nlahouti1 has quit IRC | 17:52 | |
| *** jprovazn has quit IRC | 17:53 | |
| openstackgerrit | Ryan Moats proposed openstack/neutron: WIP: Collector Proof of Concept DO NOT MERGE!!! https://review.openstack.org/213474 | 17:53 |
| openstackgerrit | Ryan Moats proposed openstack/neutron: Add instrumentation devref, Part I https://review.openstack.org/204282 | 17:53 |
| *** abhiraut has quit IRC | 17:54 | |
| openstackgerrit | Kevin Benton proposed openstack/neutron: [WIP]: 'baremetal' support for OVS agent https://review.openstack.org/249265 | 17:54 |
| *** yfried_ has joined #openstack-neutron | 17:55 | |
| *** johnbelamaric has joined #openstack-neutron | 17:55 | |
| *** mohankumar has quit IRC | 17:55 | |
| *** achanda has quit IRC | 17:55 | |
| kevinbenton | salv-orlando: salvatoooooooooore! | 17:56 |
| regXboi | ok, happy thanksgiving to all the us folks, and I'll see everybody on monday | 17:57 |
| * regXboi exits, stage right | 17:57 | |
| sc68cal | regXboi: enjoy | 17:57 |
| *** regXboi has left #openstack-neutron | 17:57 | |
| *** Pavo has quit IRC | 17:59 | |
| *** achanda has joined #openstack-neutron | 18:00 | |
| *** david-lyle has quit IRC | 18:00 | |
| *** marun has left #openstack-neutron | 18:00 | |
| *** madhu_ak has joined #openstack-neutron | 18:02 | |
| *** davidsha has quit IRC | 18:02 | |
| * X123 waves | 18:02 | |
| Sam-I-Am | X123: howdy | 18:03 |
| X123 | ahah u are in here too :) | 18:03 |
| X123 | maybe we should make an openstack network security channel | 18:04 |
| * X123 grins | 18:04 | |
| Sam-I-Am | me /set mode +paranoid :) | 18:04 |
| X123 | ahah.. that's me :) | 18:05 |
| sc68cal | I think we have an openstack security channel. | 18:05 |
| X123 | i've been doing cybersecurity and ddos protection design for almost 20 years now | 18:05 |
| sc68cal | although I am at peak IRC channels. | 18:05 |
| X123 | paranoid is in the blood :) | 18:05 |
| *** fedexo has quit IRC | 18:06 | |
| *** ildikov has joined #openstack-neutron | 18:06 | |
| *** Pavo has joined #openstack-neutron | 18:07 | |
| openstackgerrit | Swaminathan Vasudevan proposed openstack/neutron: Debug patch to test the gate failures on SSHTimeOut https://review.openstack.org/247748 | 18:07 |
| ihrachys | mestery: I believe that's the fix for releases issue: https://review.openstack.org/#/c/249962/1 | 18:07 |
| X123 | so yeah the layer2 security is severely lacking :0 | 18:07 |
| *** sambetts is now known as sambetts-afk | 18:07 | |
| mestery | ihrachys: You rock man, looking now | 18:08 |
| *** madhu_ak has quit IRC | 18:08 | |
| *** Marga_ has joined #openstack-neutron | 18:10 | |
| *** Marga_ has quit IRC | 18:10 | |
| *** iyamahat has joined #openstack-neutron | 18:10 | |
| *** Marga_ has joined #openstack-neutron | 18:11 | |
| *** abhiraut has joined #openstack-neutron | 18:11 | |
| sc68cal | X123: most deployments were using tenant networking, so each tenant had their own l2 segment | 18:11 |
| *** abhiraut has quit IRC | 18:12 | |
| *** achanda has quit IRC | 18:13 | |
| ihrachys | mestery: yay it works ;) | 18:14 |
| kevinbenton | X123: what is missing? | 18:15 |
| *** ociuhandu has quit IRC | 18:15 | |
| kevinbenton | X123: I would be happy to help cover any gaps there | 18:15 |
| X123 | need some sort of isolation of the public interface on public external l2 bridge | 18:16 |
| kevinbenton | X123: what do you mean? | 18:16 |
| X123 | can see every broadcast/multicast on the segment from the VM and adjacency discovery isn't filtered properly | 18:16 |
| kevinbenton | X123: what public interface | 18:17 |
| X123 | external interface bridged l2 into a VM | 18:17 |
| *** toddnni has joined #openstack-neutron | 18:17 | |
| X123 | br-ex = public shared interface | 18:17 |
| kevinbenton | X123: so you mean a VM that has an interface on a shared network | 18:17 |
| X123 | yeah | 18:18 |
| *** iyamahat has quit IRC | 18:18 | |
| X123 | to get a real internet ip for example | 18:18 |
| kevinbenton | X123: why wouldn't you expect to see the VM's broadcast traffic? | 18:18 |
| X123 | because it's public interface with multiple tenants sharing it | 18:18 |
| X123 | you don't want to see anything from any other vm or tenant | 18:18 |
| kevinbenton | X123: the model in neutron is that a network is a broadcast domain | 18:19 |
| *** markus_z has quit IRC | 18:19 | |
| X123 | but security rules should be filtering everything out | 18:19 |
| X123 | since it's a shared network to get public address space from multiple tenants | 18:19 |
| *** SurajD has quit IRC | 18:19 | |
| sc68cal | X123: there are deployment configurations where the external network that br-ex is connected to has real physical devices that VMs need to access | 18:19 |
| X123 | it's not good if one tenant can interfere with another | 18:19 |
| kevinbenton | X123: what do you mean by interfere? | 18:20 |
| kevinbenton | X123: traffic visibility and interferring are two different things | 18:20 |
| *** david-lyle has joined #openstack-neutron | 18:20 | |
| X123 | stealing ip addresses for example | 18:20 |
| kevinbenton | X123: and how do you propose to steal an IP address? | 18:20 |
| X123 | seeing broadcasts from other vm's is not good | 18:20 |
| X123 | with ARP? | 18:20 |
| X123 | lol | 18:21 |
| *** ihrachys has quit IRC | 18:21 | |
| kevinbenton | X123: ARP spoofing is prevented | 18:21 |
| X123 | i've already done it multiple times | 18:21 |
| X123 | it's not prevented | 18:21 |
| kevinbenton | X123: on what code base? | 18:21 |
| X123 | pretty sure our QA test is kilo based | 18:21 |
| *** ihrachys has joined #openstack-neutron | 18:21 | |
| sc68cal | X123: so - two release cycles behind? | 18:22 |
| kevinbenton | X123: did they enable ARP spoofing prevention? | 18:22 |
| X123 | yes, and that does seem to filter arps with opcode 2 | 18:22 |
| X123 | but only egress from the vm | 18:22 |
| X123 | or ingress from the vm into ovs if you look at it that way | 18:22 |
| Sam-I-Am | kevinbenton: he has the port_security extension and arp spoof protection enabled, best i can tell | 18:23 |
| BLZbubba | is it insane to want ipv6 for fixed addresses and ipv4 for floating, and have the vm's use the 64:ff9b::/96 subnet? | 18:23 |
| kevinbenton | X123: and that is an issue because? | 18:23 |
| *** shivrao has joined #openstack-neutron | 18:23 | |
| X123 | ?? | 18:23 |
| *** achanda has joined #openstack-neutron | 18:24 | |
| kevinbenton | X123: how are you arp poisoning these VMs? | 18:24 |
| X123 | with opcode 1 | 18:24 |
| openstackgerrit | Merged openstack/neutron: ovs: Make interface name hashing algorithm common and extend it https://review.openstack.org/238584 | 18:25 |
| *** yfried_ has quit IRC | 18:25 | |
| *** shwetaap has quit IRC | 18:25 | |
| X123 | or, with pause/unpause | 18:25 |
| X123 | or with creating a new vm | 18:25 |
| sc68cal | BLZbubba: not insane - but it would be an advanced service | 18:26 |
| kevinbenton | X123: so does your codebase have this patch? https://github.com/openstack/neutron/commit/862e2975e50de665f109fe340fa40a51f96375f6 | 18:26 |
| kevinbenton | X123: because that changed the filtering off of opcode 2 | 18:26 |
| *** yfried_ has joined #openstack-neutron | 18:27 | |
| BLZbubba | sc68cal: how much work would be required to do this? if it is less than requesting a 10.x.x.x subnet from our IP nazis maybe I'll try it | 18:27 |
| X123 | not sure if it does or not | 18:27 |
| *** jagter has quit IRC | 18:27 | |
| X123 | will ask our devs | 18:27 |
| sc68cal | BLZbubba: I'm saying you'd need to create a whole new neutron advanced service to handle NAT64 | 18:27 |
| BLZbubba | gotcha | 18:27 |
| kevinbenton | X123: it's in stable/kilo so it will depend on which kilo version they are using | 18:28 |
| *** sthillma has quit IRC | 18:28 | |
| kevinbenton | X123: also, is this openvswitch or linuxbridge? | 18:28 |
| X123 | ovs | 18:28 |
| kevinbenton | X123: ok. so with a VM pause/unpause you are seeing a window where traffic is unfiltered, right? | 18:29 |
| *** jagter has joined #openstack-neutron | 18:29 | |
| X123 | yes | 18:29 |
| X123 | like it allows one or two packets to go through before the flow rule catches the arp reply | 18:30 |
| *** Pavo has quit IRC | 18:30 | |
| kevinbenton | X123: ok. i suspected this was an issue when i wrote the linuxbridge one so it will just drop all arps until setup | 18:30 |
| *** sthillma has joined #openstack-neutron | 18:31 | |
| kevinbenton | X123: i will need to do the same for openvswitch | 18:31 |
| X123 | yeah | 18:31 |
| kevinbenton | X123: please find out if you have the latest stable/kilo and if it still has the alternate opcode issue | 18:31 |
| *** shwetaap has joined #openstack-neutron | 18:31 | |
| X123 | I will check with our devs and get back to you.. i'm a network engineer not a programmer :P | 18:31 |
| X123 | it shouldn't just be arps though, all broadcast/multicast should be filtered to the vm | 18:31 |
| kevinbenton | X123: because? | 18:32 |
| X123 | and anything relevant should be proxied or sent to ovs flow rules | 18:32 |
| *** Pavo has joined #openstack-neutron | 18:32 | |
| X123 | what if someone sets up a windows vm and sees a bunch of other windows vms on the network | 18:32 |
| Sam-I-Am | X123: just look at your running code and see if it matches that patch | 18:32 |
| X123 | we don't want tenants to see other tenants on the public interface | 18:32 |
| *** Pavo has quit IRC | 18:32 | |
| X123 | also what if someone sets up a dhcp server | 18:32 |
| kevinbenton | X123: please. there are dhcp spoofing rules for that | 18:33 |
| *** gberginc has joined #openstack-neutron | 18:33 | |
| *** bzhao has quit IRC | 18:33 | |
| X123 | just an example of why you don't want to see broadcasts lol | 18:33 |
| kevinbenton | X123: setup egress filtering on your security group rules if you don't want to leak traffic | 18:33 |
| *** vivek-ebay has quit IRC | 18:33 | |
| *** nplanel has quit IRC | 18:33 | |
| sc68cal | X123: so.... you want a public, shared, l2 network to not be reachable across tenants | 18:33 |
| *** bzhao has joined #openstack-neutron | 18:33 | |
| X123 | yes | 18:34 |
| kevinbenton | X123: if you have an example of some traffic where someone can't filter out traffic they don't want to leak or see, then provide that example | 18:34 |
| sc68cal | X123: so why are you making it shared | 18:34 |
| kevinbenton | X123: if you have a windows VM and don't want to see windows traffic, filter it out | 18:34 |
| X123 | it shuld be filtered by default | 18:35 |
| X123 | it's shared because there's a /20 of public ips | 18:35 |
| X123 | on a layer2 segment for all the VM's to get public ips | 18:35 |
| openstackgerrit | Doug Hellmann proposed openstack/neutron: force releasenotes warnings to be treated as errors https://review.openstack.org/249973 | 18:35 |
| X123 | which is perfectly normal | 18:35 |
| X123 | and those shouldn't interfere with each other | 18:35 |
| sc68cal | X123: so - what if one tenant actually needs to reach a vm of another tenant, on that network? | 18:36 |
| kevinbenton | X123: they can still interfere with each other using unicast | 18:36 |
| kevinbenton | X123: you need to be more specific with what you mean by 'interfere' | 18:36 |
| X123 | kevinbenton yes that's fine, anything they could normally send over the internet | 18:36 |
| X123 | i mean layer2 level | 18:37 |
| X123 | i don't care about layer3 stuff | 18:37 |
| X123 | that's on the tenant to filter out | 18:37 |
| sc68cal | X123: but a neutron network is a l2 broadcast segment | 18:37 |
| X123 | unicast l3 is not a concern | 18:37 |
| kevinbenton | X123: that's an arbitrary decision | 18:37 |
| kevinbenton | X123: why shouldn't a tenant filter out traffic they don't want sent? | 18:38 |
| *** bbzhao has joined #openstack-neutron | 18:39 | |
| kevinbenton | X123: you can certainly file a feature request to allow networks to block broadcast | 18:39 |
| * X123 sigh | 18:39 | |
| X123 | if you create a vm on rackspace | 18:39 |
| X123 | you see absolutely no bc or mc traffic from ANY other vm | 18:39 |
| X123 | and you see no arps at all from anything unless it's to the ip of that VM | 18:39 |
| sc68cal | X123: on their openstack deployment? | 18:39 |
| X123 | yes | 18:39 |
| X123 | that is what i want | 18:39 |
| X123 | same with digital ocean, amazon, etc | 18:39 |
| X123 | it's all filtered | 18:39 |
| sc68cal | X123: oh look, RAX made decisions that broke an API or made it different | 18:39 |
| *** iyamahat has joined #openstack-neutron | 18:40 | |
| kevinbenton | X123: file a feature request | 18:40 |
| *** johnbelamaric has quit IRC | 18:40 | |
| *** ihrachys has quit IRC | 18:41 | |
| *** ijw has joined #openstack-neutron | 18:41 | |
| *** abhiraut has joined #openstack-neutron | 18:41 | |
| *** ihrachys has joined #openstack-neutron | 18:41 | |
| kevinbenton | X123: because you are arguing for blocking l2 features that neutron offers. it's a regression in functionality | 18:41 |
| *** bzhao has quit IRC | 18:42 | |
| *** yamahata has joined #openstack-neutron | 18:42 | |
| *** ijw has quit IRC | 18:42 | |
| *** achanda_ has joined #openstack-neutron | 18:42 | |
| *** ijw has joined #openstack-neutron | 18:42 | |
| *** achanda has quit IRC | 18:42 | |
| *** achanda_ has quit IRC | 18:43 | |
| *** vivek-ebay has joined #openstack-neutron | 18:43 | |
| *** vivek-ebay has quit IRC | 18:44 | |
| X123 | if it's a 'public' shared network it should be isolated | 18:45 |
| X123 | if it's a tenant network it doesn't have to be | 18:45 |
| X123 | this is how all the normal virtualization providers operate | 18:45 |
| sc68cal | X123: that's... totally the opposite of what they mean today | 18:45 |
| X123 | like i mentioned | 18:45 |
| kevinbenton | X123: a network can be shared with 1:M tenants | 18:46 |
| kevinbenton | X123: and for various purposes | 18:46 |
| kevinbenton | X123: if i share a network and say 'hey, connect to this if you want a multicast stock quote feed', i don't want this stuff dropped | 18:46 |
| X123 | you wouldn't set it to public then | 18:46 |
| *** roeyc has quit IRC | 18:47 | |
| X123 | or internet facing | 18:47 |
| kevinbenton | X123: there is no such thing as 'public' | 18:47 |
| kevinbenton | X123: or an 'internet facing' option in neutron | 18:47 |
| X123 | there should be | 18:47 |
| X123 | or just a way to say this network is shared but the ports are isolated | 18:48 |
| kevinbenton | X123: that's why i said to file a feature request | 18:48 |
| *** ZZelle_ has joined #openstack-neutron | 18:48 | |
| X123 | i.e. private vlan isolated mode | 18:48 |
| *** Pavo has joined #openstack-neutron | 18:48 | |
| kevinbenton | X123: i can see that you might want this. it would be a new attribute on the network that just drops all multi/broadcast | 18:48 |
| *** maht has joined #openstack-neutron | 18:48 | |
| X123 | same thing as pvlan isolated on normal network equipment | 18:49 |
| X123 | and then an adjacency proxy | 18:49 |
| kevinbenton | X123: pvlan isolated allows two on the same pvlan to still communicate via broadcast, is that a requirement? | 18:49 |
| X123 | it does not | 18:49 |
| X123 | pvlan isolated only allows communication with a pvlan promisc | 18:49 |
| kevinbenton | X123: ah, right | 18:50 |
| X123 | it does not even allow unicast between two isolated | 18:50 |
| X123 | but since ovs can be programmed, it could allow unicast | 18:50 |
| kevinbenton | X123: so that's a bad feature then | 18:50 |
| X123 | with some sort of l2pop like it does on tenant network | 18:50 |
| kevinbenton | X123: what you want is just no unicast/multicast, right? | 18:50 |
| X123 | no bc/mc | 18:50 |
| kevinbenton | right | 18:51 |
| X123 | and then adjacency proxy | 18:51 |
| X123 | (arp/nd) | 18:51 |
| kevinbenton | that's obvious | 18:51 |
| X123 | yeah | 18:51 |
| X123 | that basically defines it as a 'public' shared network | 18:51 |
| X123 | meaning there's multiple tenants, servers, whatever | 18:52 |
| X123 | owned by different people | 18:52 |
| X123 | and we don't want them to mess with each other | 18:52 |
| kevinbenton | X123: no, it won't be called 'public' because you can still want multiple different tenants on the same broadcast domain | 18:52 |
| sc68cal | that's not a definition of public to me | 18:52 |
| X123 | yeah well that can simply be a shared network | 18:52 |
| X123 | not public | 18:52 |
| X123 | public = public internet exchange | 18:52 |
| X123 | like exchange points tons of people connecting | 18:52 |
| X123 | u want to limit access/isolate as much as possible | 18:53 |
| *** maht has quit IRC | 18:53 | |
| kevinbenton | what would you call people with connectivity to Internet2? | 18:53 |
| X123 | shared = everyone can access | 18:53 |
| kevinbenton | still mostly public to me | 18:53 |
| X123 | i don't care what you call it :0 | 18:53 |
| kevinbenton | yet they can subscribe to multicast | 18:53 |
| X123 | just needs to be a "shared isolated" ? network type | 18:53 |
| *** maht has joined #openstack-neutron | 18:53 | |
| kevinbenton | X123: it will literally be something like "unicast only" | 18:53 |
| X123 | so it should be populated like l2pop | 18:53 |
| X123 | if l2pop inserts multicast rules into OVS | 18:54 |
| X123 | to allow multicast to those particular VMs | 18:54 |
| X123 | it can allow it | 18:54 |
| X123 | that's what SDN is for | 18:54 |
| kevinbenton | X123: using words like 'public' that everyone can define on there own is bad for an API | 18:54 |
| X123 | you only can send/get what is prepopulated into the flow rules | 18:54 |
| X123 | everything else is dropped | 18:54 |
| X123 | that's what i really want :) | 18:54 |
| sc68cal | X123: the issue is you are changing at the API layer, and packing a lot of implicit behavior behind the API | 18:54 |
| sc68cal | X123: sure you can do it through SDN wizardry | 18:54 |
| X123 | drop everything, add rules in ovs to allow what i want | 18:54 |
| X123 | how about that :0 | 18:55 |
| sc68cal | X123: but if I have 2 openstack clouds that I use, and one has a different behavior than the other, well that sucks as a user | 18:55 |
| sc68cal | just saying it's 'public' is not sufficient | 18:55 |
| kevinbenton | sc68cal: +1. that's why we would want this explicit in the API | 18:55 |
| sc68cal | kevinbenton: agreed | 18:55 |
| X123 | yeah some rule in the api to say hey this network is internet access only | 18:55 |
| kevinbenton | X123: "unicast" only | 18:56 |
| kevinbenton | X123: internet is up to how the upstream network is configured | 18:56 |
| X123 | not just unicast only because you can send unicast arps | 18:56 |
| X123 | but unicast and filtered so there can't be any interaction between VMs | 18:56 |
| *** ihrachys has quit IRC | 18:56 | |
| sc68cal | but we still have this issue where we have tons of extensions to the Neutron Network resource, which makes it mean very different things | 18:56 |
| X123 | unless it's protocol ipv4 or ipv6 | 18:56 |
| sc68cal | and now as a user of 2 clouds I have to hunt down all these extensions and what they mean | 18:57 |
| X123 | this wouldn't be something the tenant has access to | 18:57 |
| *** ihrachys has joined #openstack-neutron | 18:57 | |
| *** Aish has joined #openstack-neutron | 18:57 | |
| *** ociuhandu has joined #openstack-neutron | 18:57 | |
| kevinbenton | X123: the tenant would most definitely need to be able to read it | 18:57 |
| X123 | it would be something set upon creation of the network by the openstack admin | 18:57 |
| X123 | tenant can't change it | 18:57 |
| X123 | or that would break everything | 18:57 |
| sc68cal | X123: yes but tenant needs to read it | 18:57 |
| *** fer_ has quit IRC | 18:57 | |
| X123 | yeah so it knows the interface on the vm is connected to it | 18:58 |
| X123 | obviously it's possible to do because rackspace is doing it | 18:58 |
| X123 | and they are using openstack as far as i know | 18:58 |
| sc68cal | X123: yeah but i doubt RAX is exposing it through an API | 18:58 |
| X123 | so what are they doing? | 18:58 |
| kevinbenton | X123: they don't expose it | 18:58 |
| X123 | well that's fine with me | 18:59 |
| kevinbenton | X123: it's not hard to write stuff that just arbitrarily drops things | 18:59 |
| *** garyk has quit IRC | 18:59 | |
| sc68cal | X123: so it's just some weirdness about a neutron network in RAX's openstack - that's *not* a good practice | 18:59 |
| *** sridhar_ram has joined #openstack-neutron | 18:59 | |
| sc68cal | X123: how are we supposed to standardize and give users any hope of actually deploying across multiple openstacks if the API looks the same but has totally different behaviors | 18:59 |
| kevinbenton | this conversation is not covering any new ground at this point. we established about 15 minutes ago that this makes sense as a feature request | 18:59 |
| kevinbenton | X123: please follow this guide to file an RFE bug: http://docs.openstack.org/developer/neutron/policies/blueprints.html#neutron-request-for-feature-enhancements | 19:00 |
| X123 | why does this patch only look at the arp src ip, it should check the mac also | 19:00 |
| X123 | just to be ultra paranoid :) | 19:00 |
| kevinbenton | X123: mac spoofing is already covered | 19:00 |
| *** vivek-ebay has joined #openstack-neutron | 19:00 | |
| X123 | it's covered layer3 though? | 19:01 |
| X123 | with iptables | 19:01 |
| kevinbenton | X123: which mac are you referring to/ | 19:02 |
| X123 | mac of the VM | 19:02 |
| kevinbenton | X123: part of the arp payload or the l2 header? | 19:02 |
| Sam-I-Am | its in 2 places - the mac/ip filter on the linuxbridge to which the vm connects... then on br-int for actual arp spoof protection | 19:02 |
| X123 | where is it on the linux bridge | 19:02 |
| X123 | iptables or something else? | 19:02 |
| Sam-I-Am | yeah | 19:02 |
| sc68cal | ebtables | 19:02 |
| *** amuller_afk is now known as amuller | 19:03 | |
| Sam-I-Am | sc68cal: thats arp spoof, on linuxbridge | 19:03 |
| kevinbenton | iptables for mac spoofing | 19:03 |
| Sam-I-Am | this is just the per-vm mac/ip filter | 19:03 |
| X123 | i see no ebtables rules | 19:03 |
| *** safchain has quit IRC | 19:03 | |
| kevinbenton | X123: https://github.com/openstack/neutron/blob/master/neutron/agent/linux/iptables_firewall.py#L366-L368 | 19:03 |
| Sam-I-Am | you wont, because with ovs they're implemented in flows | 19:03 |
| Sam-I-Am | if you used the linuxbridge agent you'd see ebtables | 19:03 |
| *** nyechiel_ has quit IRC | 19:03 | |
| X123 | so ovs flow has mac spoofing rule somewhere? | 19:04 |
| Sukhdev | Folks fresh install of devstack fails neutron with the following traceback - http://paste.openstack.org/show/480024/ Has anyone seen this or any idea what is missing? | 19:04 |
| kevinbenton | X123: no | 19:04 |
| kevinbenton | X123: iptables for mac spoofing | 19:04 |
| kevinbenton | X123: OVS flows for arp spoofing | 19:04 |
| X123 | but looking at the iptables rule, it only matches layer3 | 19:04 |
| X123 | it has a rule matching 1.2.3.4/32 with mac source xxx | 19:04 |
| X123 | and then the next rule is drop everything else | 19:04 |
| X123 | that drop everythign else rule is layer3 only | 19:04 |
| X123 | because it doesn't specify the mac filter | 19:04 |
| X123 | so it will pretty much ignore anything NON IP | 19:05 |
| X123 | like arps | 19:05 |
| X123 | or other layer2 stuff | 19:05 |
| X123 | get what im saying | 19:05 |
| kevinbenton | X123: i see. so it's possible that a VM can lie about who has it's own IP address | 19:05 |
| kevinbenton | X123: not much to gain from that | 19:05 |
| kevinbenton | X123: but it is something that should be fixed | 19:05 |
| X123 | i know, and i know :0 | 19:05 |
| X123 | i'm just one of those guys | 19:06 |
| *** maht has quit IRC | 19:06 | |
| X123 | that plugs every single hole | 19:06 |
| X123 | even if it's insignificant | 19:06 |
| *** maht has joined #openstack-neutron | 19:06 | |
| X123 | like i said, i've been doing cybersecurity for almost 20 yrs | 19:06 |
| X123 | even the most insignificant thing can sometimes be the worst exploit | 19:06 |
| *** hdaniel has joined #openstack-neutron | 19:07 | |
| kevinbenton | X123: do you have a link to a doc on iptables showing what it will/won't process with a drop rule? | 19:08 |
| *** Guest50696 has quit IRC | 19:09 | |
| X123 | hmm no but afaik it only sees packets, not frames | 19:09 |
| *** Piet has quit IRC | 19:10 | |
| X123 | but with all the addons to it.. | 19:10 |
| *** maht has quit IRC | 19:10 | |
| sc68cal | X123: I just saw your comment in #openstack - http://eavesdrop.openstack.org/irclogs/%23openstack/%23openstack.2015-11-25.log.html#t2015-11-25T16:26:19 | 19:10 |
| sc68cal | X123: you know, sometimes humility helps | 19:10 |
| X123 | haha | 19:10 |
| *** aix has quit IRC | 19:11 | |
| *** jpena has quit IRC | 19:11 | |
| *** maht has joined #openstack-neutron | 19:11 | |
| X123 | i've been saying the same thing to sam for over a year now it's kind of an inside joke | 19:11 |
| sc68cal | oh well I don't find it funny. | 19:11 |
| X123 | but it's true | 19:11 |
| sc68cal | I don't remember you paying my wages | 19:12 |
| *** barra204 is now known as shakamunyi | 19:12 | |
| *** maht has quit IRC | 19:12 | |
| *** maht has joined #openstack-neutron | 19:12 | |
| sc68cal | It's easy to sit back and say well stupid devs are stupid and be arrogant | 19:12 |
| kevinbenton | X123: just because you are mad that neutron doesn't support the topology you want to make doesn't mean devs don't understand networks | 19:13 |
| *** Marga_ has quit IRC | 19:13 | |
| *** sthillma has quit IRC | 19:14 | |
| X123 | http://ebtables.netfilter.org/br_fw_ia/br_fw_ia.html | 19:14 |
| *** lindycoder has quit IRC | 19:15 | |
| *** maht has quit IRC | 19:17 | |
| *** jckasper has joined #openstack-neutron | 19:17 | |
| *** lindycoder has joined #openstack-neutron | 19:17 | |
| *** maht has joined #openstack-neutron | 19:17 | |
| *** salv-orl_ has joined #openstack-neutron | 19:19 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 19:20 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 19:20 | |
| *** maht has quit IRC | 19:20 | |
| *** maht has joined #openstack-neutron | 19:20 | |
| *** salv-orlando has quit IRC | 19:22 | |
| *** maht has quit IRC | 19:22 | |
| *** jianyong has quit IRC | 19:24 | |
| *** jianyong has joined #openstack-neutron | 19:24 | |
| *** madhu_ak has joined #openstack-neutron | 19:25 | |
| *** john-davidge has joined #openstack-neutron | 19:25 | |
| X123 | i'm not mad at all :D and didn't call anyone stupid | 19:29 |
| X123 | don't put words into my mouth | 19:29 |
| X123 | hopefully that ebtables link will shed some light on it | 19:30 |
| *** sthillma has joined #openstack-neutron | 19:31 | |
| *** abhiraut has quit IRC | 19:33 | |
| *** johnbelamaric has joined #openstack-neutron | 19:34 | |
| *** dane_leblanc has quit IRC | 19:36 | |
| *** abhiraut has joined #openstack-neutron | 19:38 | |
| *** edgar__ has quit IRC | 19:39 | |
| *** edgar has joined #openstack-neutron | 19:40 | |
| *** achanda has joined #openstack-neutron | 19:42 | |
| *** s3wong has joined #openstack-neutron | 19:43 | |
| *** abhiraut has quit IRC | 19:44 | |
| *** dane_leblanc has joined #openstack-neutron | 19:45 | |
| *** changbl has joined #openstack-neutron | 19:45 | |
| *** Marga_ has joined #openstack-neutron | 19:46 | |
| *** Aish has quit IRC | 19:46 | |
| *** Aish has joined #openstack-neutron | 19:46 | |
| *** Marga_ has quit IRC | 19:48 | |
| *** Marga_ has joined #openstack-neutron | 19:49 | |
| *** dane_leblanc has quit IRC | 19:49 | |
| *** gberginc has quit IRC | 19:50 | |
| *** achanda has quit IRC | 19:50 | |
| *** achanda has joined #openstack-neutron | 19:53 | |
| *** mickeys has quit IRC | 19:53 | |
| *** achanda has quit IRC | 19:53 | |
| *** gildub has joined #openstack-neutron | 19:55 | |
| *** dane_leblanc has joined #openstack-neutron | 19:56 | |
| *** abregman has joined #openstack-neutron | 19:56 | |
| Sukhdev | mestery : are you around? | 19:57 |
| Sukhdev | mestery : if you are around - L2GW is ready to be released - https://bugs.launchpad.net/networking-l2gw/+bug/1518794 | 19:58 |
| openstack | Launchpad bug 1518794 in networking-l2gw "Release request for networking-L2GW for stable/liberty" [Medium,Confirmed] - Assigned to Sukhdev Kapur (sukhdev-8) | 19:58 |
| *** abregman is now known as abregman|afk | 19:59 | |
| kevinbenton | X123: i can't repro the pause/unpause behavior you are seeing | 20:00 |
| kevinbenton | X123: i don't see the flows being destroyed when i pause it | 20:00 |
| X123 | hmm | 20:00 |
| X123 | try snapshotting it | 20:00 |
| X123 | that worked also | 20:00 |
| *** korzen has quit IRC | 20:00 | |
| X123 | our release didn't have that arp patch so we will patch it and test | 20:01 |
| X123 | maybe something else got fixed since we froze the dev code | 20:01 |
| *** slaweq has joined #openstack-neutron | 20:02 | |
| X123 | all i did to test it was send arps out on the vm with something like arping | 20:02 |
| X123 | leave it running | 20:03 |
| X123 | while u snapshot or pause | 20:03 |
| X123 | and it will do it | 20:03 |
| X123 | i don't know if the rules are getting destroyed or not, but i know it lets through at least 1 packet | 20:03 |
| X123 | another way to do it is | 20:04 |
| X123 | make a snapshot of the vm and then boot up that snapshot | 20:04 |
| X123 | and it steals the ip of the vm you made the snapshot of | 20:04 |
| X123 | so it lets through at least one arp | 20:04 |
| X123 | but after that it's filtered | 20:04 |
| X123 | that is the behaviour i'm seeing | 20:04 |
| kevinbenton | X123: yeah, no rules being wiped out on snapshot either. but i'm on master | 20:05 |
| *** shivrao has quit IRC | 20:05 | |
| X123 | i'm not sure it's wiping out the rules i didn't check | 20:06 |
| X123 | i checked if it was allowing packets | 20:06 |
| kevinbenton | X123: well it would have to wipe out the rule or OVS is broken | 20:06 |
| Redcavalier | x123, we'll need to do some more tests on this then | 20:06 |
| *** hitalia has quit IRC | 20:06 | |
| Redcavalier | and see if it wipes out the rules or not | 20:06 |
| X123 | yeah maybe they patched it already | 20:07 |
| kevinbenton | X123: also, on booting a VM, is nova not waiting for neutron to notify in your deployment? | 20:07 |
| *** salv-orl_ has quit IRC | 20:07 | |
| X123 | now that i have no idea :D Redcavalier? | 20:07 |
| kevinbenton | because nova shouldn't even start the VM until after the l2 agent has wired everything | 20:07 |
| *** Pavo has quit IRC | 20:07 | |
| Redcavalier | hrm, good question. I can say that we create the neutron port before creating the VM | 20:07 |
| X123 | yeah that was my thinking kevin | 20:08 |
| X123 | it should do that, but it doesn't seem like it is | 20:08 |
| X123 | or at least, it allows an arp to be sent | 20:08 |
| Redcavalier | So the neutron port should be ready before the VM is booted | 20:08 |
| *** Pavo has joined #openstack-neutron | 20:08 | |
| kevinbenton | so can you see if you can reproduce any of this after the ARP patch is in that blocks all op codes? | 20:08 |
| X123 | maybe it's because of that arp patch | 20:08 |
| *** shivrao has joined #openstack-neutron | 20:08 | |
| *** javeriak has quit IRC | 20:08 | |
| *** Pavo has quit IRC | 20:09 | |
| X123 | yeah will try | 20:09 |
| X123 | but I did test arp replies | 20:09 |
| Redcavalier | Yes, we have some adjustements we need to make before we can test the patch, but it will be done shortly | 20:09 |
| *** changbl has quit IRC | 20:09 | |
| X123 | when you pause and unpause the vm does it shut down the interfaces onthe vm? | 20:09 |
| kevinbenton | ok. ping me on here when you get results | 20:09 |
| *** Guest47588 has joined #openstack-neutron | 20:10 | |
| X123 | will do | 20:10 |
| *** Guest47588 is now known as Pavo | 20:10 | |
| Redcavalier | Yes, I will do so. Thank you for your help, everything that was discussed here actually helped us a lot in trying to fix our issues. | 20:10 |
| *** ihrachys has quit IRC | 20:10 | |
| X123 | yes it did thanks! | 20:10 |
| X123 | next step, ipv6 :P | 20:11 |
| *** Guest50696 has joined #openstack-neutron | 20:12 | |
| *** ihrachys has joined #openstack-neutron | 20:12 | |
| *** ihrachys has quit IRC | 20:14 | |
| *** edgar has quit IRC | 20:16 | |
| *** neiljerram has quit IRC | 20:16 | |
| *** ihrachys has joined #openstack-neutron | 20:18 | |
| Sam-I-Am | X123: you'll have fun there | 20:19 |
| Sam-I-Am | aight i need to bail for a bit | 20:19 |
| Sam-I-Am | family stuffs | 20:19 |
| ihrachys | armax: hi. I wanted to talk about one thing that upgrades subteam wanted to clarify. please ping me when avail. | 20:19 |
| armax | ihrachys: here | 20:19 |
| ihrachys | armax: ok. so there is plan to look at invasiveness of oslo.versionedobjects adoption in db mixin for core resources like port or network (why is it upgrade? because it may help us adoption live data migration technics later in the run); and the question is whether this work needs RFE/BP/spec prior to us starting playing with it. | 20:22 |
| *** Swami has quit IRC | 20:22 | |
| *** changbl has joined #openstack-neutron | 20:22 | |
| ihrachys | note that oslo.versionedobjects are already used for QoS things in the tree, and the step we care now about is adopting similar approaches for more resources. | 20:23 |
| armax | ihrachys: either way, it would be good to have an idea on how you plan to tackle the problem | 20:23 |
| armax | ihrachys: how complex do you think the effort is? | 20:23 |
| ihrachys | armax: I believe it's quite complex, though it would be hard to perceive all issues we'll encounter prior to start. | 20:24 |
| ihrachys | armax: anyway, rossella and korzen were going to play with it for some PoC to see some high level issues with that plan | 20:24 |
| armax | ihrachys: so you think that iterating on a spec is not going to benefit much? | 20:24 |
| ihrachys | armax: I believe that PoC could give us some clue | 20:24 |
| armax | ihrachys: do you think that after we shed some light on the problem it’s worth capturing guidelines on how to develop versioned resources going forward? | 20:25 |
| armax | ihrachys: in the end are you planning of versioning only one or two resources? | 20:25 |
| ihrachys | armax: it may be worth iterating on some details specific for neutron, like how we handle all that pluggability that we currently have (note that OVO library assumes object schema is quite strict, so we need some clever approaches applied to overcome it for extensions) | 20:25 |
| armax | ihrachys: if so, then explaining what steps are involved to convert the other resources in due course | 20:26 |
| ihrachys | armax: no, the ideal outcome is that eventually we get all objects migrated to OVO | 20:26 |
| *** njohnston is now known as nate_gone | 20:26 | |
| ihrachys | armax: where eventually is probably == 3+ cycles from now :) | 20:26 |
| armax | ihrachys: right | 20:26 |
| armax | but not all at once | 20:26 |
| armax | that’s what I am saying | 20:26 |
| ihrachys | armax: documenting it is the right thing to do anyway, with devref or similar. | 20:26 |
| armax | ihrachys: so if that’s the case an RFE bug + devref might be the way forward | 20:27 |
| *** john5223 is now known as zz_john5223 | 20:27 | |
| *** mchestr has joined #openstack-neutron | 20:27 | |
| *** mchestr has quit IRC | 20:27 | |
| ihrachys | armax: sure not at once. once/if it works fine for what we see, we may once put forward a requirement that new features should use those objects from start. we are not there now though. | 20:27 |
| armax | a devref can explain how to develop neutron OVO enabled resources | 20:27 |
| armax | and how to convert existing ones | 20:27 |
| armax | ihrachys: if you target ports only, that would be a good start | 20:28 |
| armax | ihrachys: or just networks, | 20:28 |
| ihrachys | armax: I am open to however we decide to tackle it (bp/spec if needed) as long as we are not blocked for the cycle just because of 'overcommit' concern. | 20:28 |
| *** madhu_ak has quit IRC | 20:29 | |
| armax | ihrachys: you got 2 blueprints to approve and one assigned to you | 20:29 |
| armax | ihrachys: rossella_s and ajo are light from a BP standpoint | 20:29 |
| armax | ihrachys: there should be some headroom | 20:29 |
| ihrachys | armax: the plan now is ports as first prio (handled by rossella) since kevinbenton's rpc refactor for l2 agent needs the object anyway; and networks are to be looked by korzen in parallel | 20:30 |
| armax | ihrachys: but make sure you target the smallest possible target that can be completed in the span of what’s left for mitaka | 20:30 |
| armax | let’s not do more than two | 20:30 |
| ihrachys | armax: right. it's not going to happen in one day, so we should choose targets properly. | 20:30 |
| armax | comparing notes whilst dealing with ports and networks should be useful | 20:31 |
| ihrachys | btw I am not sure it will be able to go merged in Mitaka, but I want us to look at it now nevertheless to at least understand the complexity | 20:32 |
| *** minwang2 has joined #openstack-neutron | 20:32 | |
| ihrachys | just want to make sure that IF we get to something decent in quick time, it gets a chance for getting in | 20:32 |
| armax | ihrachys: I’d say RFE + devref that documents how to develop versioned resources + how you converted the ones you converted and how to convert the remaining ones should be enough | 20:32 |
| armax | ihrachys: the chance of getting in is dictacted by who is going to work on it :) | 20:32 |
| armax | some of us already have the plate close to being full | 20:33 |
| ihrachys | armax: ok cool. thanks for that. so the plan will be: sync with rossella and korzen to get PoCs; document findings; assess the scope and start the real coding; merge if ready; if not, postpone to N whatever we'll have at the end of M. | 20:33 |
| armax | ihrachys: right, but you guys are already juggling | 20:34 |
| ihrachys | armax: I understand concern of overcommit, so I am ok having it explicitly Low prio | 20:34 |
| armax | ihrachys: make sure you don’t drop anything else that benefits other initiatives | 20:34 |
| *** madhu_ak has joined #openstack-neutron | 20:34 | |
| armax | like the l2 improvements and extensions | 20:34 |
| armax | or anything else that you guys have on your plate | 20:35 |
| ihrachys | armax: agreed. | 20:35 |
| armax | ihrachys: addressing live rolling upgrades should be high | 20:35 |
| ihrachys | armax: there was also plugin agnostic core resource extension manager in my mind, but meh, we'll see. | 20:35 |
| armax | ihrachys: I’d say do not bother | 20:35 |
| armax | ihrachys: allow you some slack | 20:36 |
| armax | ihrachys: gate failures, and stable issues are always lurking around | 20:36 |
| ihrachys | armax: problem with objects is that it's not directly connected to rolling; it just MAY open doors to low controller downtime; but they do not solve any immediate ops issues. | 20:36 |
| ihrachys | armax: ack, I will try to say 'no' to stuff that comes my direction. | 20:36 |
| armax | ihrachys: ok I see | 20:37 |
| ihrachys | I will update the team about our chat. | 20:37 |
| *** TrevorV has quit IRC | 20:37 | |
| armax | ihrachys: is there anywhere I can read more about OVO? | 20:38 |
| armax | ihrachys: besides the code? :) | 20:38 |
| ihrachys | armax: well... in neutron devref, it's very limited and qos oriented so far: http://docs.openstack.org/developer/neutron/devref/quality_of_service.html#qos-versioned-objects | 20:39 |
| armax | ihrachys: ok | 20:39 |
| ihrachys | armax: but should give some idea. but actually it's better to read code, yes ;) | 20:39 |
| armax | thanks | 20:39 |
| ihrachys | 'cause it's a-w-e-s-o-m-e. repeat after me. | 20:40 |
| *** baoli has joined #openstack-neutron | 20:40 | |
| armax | ihrachys: I am shy | 20:40 |
| ihrachys | if you want to get grasp of neutron usage, you better check the objects: https://github.com/openstack/neutron/tree/master/neutron/objects and the qos plugin: https://github.com/openstack/neutron/blob/master/neutron/services/qos/qos_plugin.py that should give some idea | 20:41 |
| ihrachys | maybe start from the plugin because it shows some power of it. | 20:41 |
| armax | ihrachys: ok cool…I’ll shout awesomeness after getting educated | 20:41 |
| *** salv-orlando has joined #openstack-neutron | 20:44 | |
| ihrachys | armax: I am looking forward to hear from you what you think. maybe I am biased, so it would be interesting to hear from someone outside qos subteam | 20:44 |
| armax | ihrachys: wanna do the PTL gig for a week? | 20:45 |
| ihrachys | maybe it's all hoax and we are better with cozy well known sqla objects! | 20:45 |
| *** willsama has joined #openstack-neutron | 20:45 | |
| armax | ihrachys: that would give me some time :) | 20:45 |
| sc68cal | not that my opinion means anything but I think we need OVO | 20:45 |
| *** willsama has quit IRC | 20:45 | |
| sc68cal | if it's worked for nova, I think we'd be smart to take a leaf out of their book | 20:45 |
| ihrachys | sc68cal: dare to adopt for fwaasv2 plugin??? | 20:45 |
| ihrachys | ;) | 20:46 |
| sc68cal | ihrachys: probably would be a good idea | 20:46 |
| ihrachys | YES. | 20:46 |
| * sc68cal throws it on the big pile | 20:46 | |
| ihrachys | let's sleep on it | 20:46 |
| ihrachys | HenryG: btw that neutron/objects/base.py thing should probably go to neutron-lib too, as well as rpc callbacks machinery. not sure you considered it already. | 20:47 |
| openstackgerrit | Russell Bryant proposed openstack/neutron: Change instances of Openstack to OpenStack. https://review.openstack.org/243134 | 20:48 |
| sc68cal | armax: so - the blueprint i'm responsible for - the logging API, I've went ahead and +2'd the spec - in https://review.openstack.org/203509 | 20:49 |
| sc68cal | s/the/one of the | 20:49 |
| armax | sc68cal: I meant to ping you | 20:49 |
| armax | sc68cal: it’s mostly good, I wanted to get some answers..nothing major | 20:50 |
| * ihrachys -> bed | 20:50 | |
| *** ihrachys has quit IRC | 20:50 | |
| *** baoli_ has joined #openstack-neutron | 20:51 | |
| sc68cal | armax: yeah I think there may be some refinement that may need to go into the notifications impact section, about what exactly the sg-agent is | 20:51 |
| sc68cal | armax: I assume they mean, they're going to have their own agent that will listen for notifications | 20:51 |
| sc68cal | armax: either that or maybe an l2 agent extension. | 20:52 |
| armax | sc68cal: true, but I wouldnt’ want to guess | 20:52 |
| armax | :) | 20:52 |
| armax | sc68cal: besides, I didn’t see what types of events were going to be collected or extracted | 20:52 |
| armax | sc68cal: isn’t that the purpose of the proposal? | 20:52 |
| *** baoli has quit IRC | 20:53 | |
| sc68cal | armax: frankly the REST API has taken 30 revisions to get it reasonable - I was going to wait and see how they would approach the implementation. I know they wanted to add new attributes to security group REST API resource so they could extend the L2 agent, but I put the kabosh on that | 20:54 |
| armax | sc68cal: ic | 20:54 |
| sc68cal | I was hoping the changes to the REST API where it's all under their own endpoint would force them to not touch the l2 agent at all | 20:54 |
| armax | sc68cal: they are not the easiest ckind | 20:54 |
| sc68cal | armax: ideally this whole logging thing could be a separate project | 20:54 |
| sc68cal | armax: basically no changes to the neutron repo or fwaas repo | 20:55 |
| armax | sc68cal: oh boy | 20:55 |
| armax | sc68cal: is the intention to extract stuff from logs only? | 20:56 |
| armax | sc68cal: but if that’s the case, we gott put the right stuff in the logs in the first place | 20:57 |
| armax | sc68cal: and make sure it doesn’t go away | 20:57 |
| sc68cal | armax: I think what they are doing is using iptables' log function, so it dumps the packet info to syslog | 20:58 |
| sc68cal | armax: that is at least one of the drivers they want to implement | 20:58 |
| *** abregman|afk has quit IRC | 20:58 | |
| sc68cal | armax: the question is, if someone wants to do a logging of a security group rule, what if they want a pcap ? | 20:59 |
| sc68cal | armax: and how does that interact with TaaS? | 20:59 |
| armax | sc68cal: I thought we said not to go there | 20:59 |
| armax | sc68cal: but yeah, at some point we gotta draw a line | 20:59 |
| sc68cal | armax: ok, then if that's the case we just assume the API will emit textual logs | 21:00 |
| *** johnbelamaric has quit IRC | 21:00 | |
| *** johnbelamaric1 has joined #openstack-neutron | 21:00 | |
| armax | sc68cal: for that we don’t need neutron to be in the way, I don’t think | 21:00 |
| armax | sc68cal: that’s what I figured, but structured data | 21:00 |
| armax | sc68cal: rather than a plain list of strings | 21:00 |
| armax | sc68cal: otherwise what’s the point of the API? | 21:01 |
| armax | sc68cal: any log driver is gonna behave differently | 21:01 |
| sc68cal | armax: true | 21:03 |
| *** shwetaap has quit IRC | 21:04 | |
| *** w_verdugo has left #openstack-neutron | 21:04 | |
| armax | sc68cal: thing is, the current proposal doesn’t seem complete | 21:04 |
| armax | to me | 21:04 |
| *** w_verdugo has joined #openstack-neutron | 21:07 | |
| *** john-davidge has quit IRC | 21:07 | |
| *** zz_john5223 is now known as john5223 | 21:13 | |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Delete HA network when last HA router is deleted https://review.openstack.org/207395 | 21:16 |
| sc68cal | armax: yeah - I also just commented on the spec about overlap with https://bugs.launchpad.net/bugs/1519537 | 21:17 |
| openstack | Launchpad bug 1519537 in neutron "[RFE] - Diagnostics Extension for Neutron" [Undecided,New] | 21:17 |
| amuller | kevinbenton: https://review.openstack.org/#/c/207395/ | 21:17 |
| amuller | kevinbenton: just removed the transaction from the HA network deletion patch | 21:17 |
| *** dims_ has joined #openstack-neutron | 21:21 | |
| *** dims has quit IRC | 21:22 | |
| *** shashank_hegde has quit IRC | 21:24 | |
| *** mgoddard_ has joined #openstack-neutron | 21:25 | |
| *** dims has joined #openstack-neutron | 21:26 | |
| *** mgoddard__ has joined #openstack-neutron | 21:26 | |
| *** mgoddard has quit IRC | 21:26 | |
| *** rossella_s has quit IRC | 21:26 | |
| *** rossella_s has joined #openstack-neutron | 21:27 | |
| *** dims_ has quit IRC | 21:28 | |
| *** mgoddard_ has quit IRC | 21:30 | |
| *** shivrao has quit IRC | 21:30 | |
| ZZelle_ | amuller, hi | 21:31 |
| amuller | ZZelle_: heya! | 21:31 |
| ZZelle_ | amuller, in https://review.openstack.org/207395, it is possible that we create a new router during HA network delete? | 21:31 |
| amuller | ZZelle_: yes, in which case the invalid request exception will be thrown | 21:32 |
| amuller | and the network won't be deleted | 21:32 |
| tonyb | ajo: ping? | 21:32 |
| amuller | ZZelle_: that's the only reason I'm OK with that patch | 21:32 |
| *** johnbelamaric has joined #openstack-neutron | 21:33 | |
| *** johnbelamaric1 has quit IRC | 21:33 | |
| *** mgoddard__ has quit IRC | 21:33 | |
| ZZelle_ | amuller, i was thinking about the opposite case, ie: the ha network is deleted after L399 is executed by a concurrent create_router | 21:34 |
| ZZelle_ | in https://review.openstack.org/#/c/207395/10/neutron/db/l3_hamode_db.py | 21:35 |
| *** openstackgerrit has quit IRC | 21:36 | |
| amuller | ZZelle_: I can't think of an order of event that doesn't work properly | 21:37 |
| amuller | events* | 21:37 |
| ZZelle_ | amuller, ok | 21:37 |
| *** openstackgerrit has joined #openstack-neutron | 21:37 | |
| amuller | ZZelle_: can you list one? | 21:37 |
| *** hitalia has joined #openstack-neutron | 21:37 | |
| *** signed8bit has quit IRC | 21:38 | |
| *** iyamahat has quit IRC | 21:41 | |
| ZZelle_ | amuller, according to model table constraints, i would say no BUT i am not really fluent with HA db internals | 21:41 |
| *** sthillma has quit IRC | 21:41 | |
| *** sthillma has joined #openstack-neutron | 21:41 | |
| *** mgoddard has joined #openstack-neutron | 21:42 | |
| *** mickeys has joined #openstack-neutron | 21:42 | |
| *** mgoddard_ has joined #openstack-neutron | 21:43 | |
| *** tbachman has quit IRC | 21:44 | |
| *** tbachman has joined #openstack-neutron | 21:45 | |
| *** edgar has joined #openstack-neutron | 21:45 | |
| *** mgoddard has quit IRC | 21:47 | |
| *** tflynn has joined #openstack-neutron | 21:47 | |
| *** ijw has quit IRC | 21:47 | |
| *** tflynn_ has joined #openstack-neutron | 21:49 | |
| *** signed8b_ has joined #openstack-neutron | 21:49 | |
| *** signed8b_ has quit IRC | 21:50 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Remove useless lb-agent remove_empty_bridges https://review.openstack.org/250030 | 21:50 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Move a note to bridge_lib https://review.openstack.org/250031 | 21:51 |
| *** tflynn has quit IRC | 21:51 | |
| *** baoli_ has quit IRC | 21:53 | |
| *** dims_ has joined #openstack-neutron | 21:53 | |
| *** Redcavalier has quit IRC | 21:53 | |
| *** ijw has joined #openstack-neutron | 21:55 | |
| *** dims has quit IRC | 21:56 | |
| *** Sukhdev has quit IRC | 21:56 | |
| openstackgerrit | Merged openstack/python-neutronclient: Updated from global requirements https://review.openstack.org/247158 | 21:57 |
| *** fzdarsky has quit IRC | 21:59 | |
| *** shashank_hegde has joined #openstack-neutron | 21:59 | |
| *** Sukhdev has joined #openstack-neutron | 22:00 | |
| *** shashank_hegde has quit IRC | 22:00 | |
| *** shashank_hegde has joined #openstack-neutron | 22:01 | |
| *** Aish has quit IRC | 22:03 | |
| *** Aish has joined #openstack-neutron | 22:04 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Use SAVEPOINT transaction instead of a nested transaction https://review.openstack.org/250035 | 22:05 |
| ZZelle_ | amuller, i have found this bug ^^ while reviewing previous change | 22:06 |
| *** tflynn_ has quit IRC | 22:07 | |
| *** mickeys has quit IRC | 22:08 | |
| amuller | ZZelle_: hmm | 22:08 |
| *** tbachman_ has joined #openstack-neutron | 22:09 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Remove useless lb-agent remove_empty_bridges https://review.openstack.org/250030 | 22:09 |
| *** fzdarsky has joined #openstack-neutron | 22:09 | |
| amuller | ZZelle_: I left a comment to Ann, I'm not sure about the retry loop in that method | 22:09 |
| *** tbachman has quit IRC | 22:09 | |
| *** tbachman_ is now known as tbachman | 22:09 | |
| amuller | ZZelle_: I think it'll try to use the same VRID on every attempt because of repeatable read | 22:09 |
| ZZelle_ | amuller, according to the failing usecase, the loop is currently not used as it crashs on the 2nd iteration | 22:10 |
| amuller | heh | 22:10 |
| amuller | ZZelle_: yeah I think your fix is correct | 22:11 |
| amuller | ZZelle_: need to figure out testing for this | 22:11 |
| openstackgerrit | yalei wang proposed openstack/neutron: Add new limit_portsec_domain attr for port https://review.openstack.org/250036 | 22:12 |
| *** iyamahat has joined #openstack-neutron | 22:12 | |
| openstackgerrit | yalei wang proposed openstack/neutron: Add new limit_portsec_domain attr for port https://review.openstack.org/250036 | 22:14 |
| *** nate_gone is now known as njohnston | 22:14 | |
| ZZelle_ | amuller, now that you pointed out the repeatable read, i don't understand how the loop can be useful | 22:14 |
| amuller | ZZelle_: it isn't on master | 22:14 |
| amuller | ZZelle_: another bug... | 22:14 |
| amuller | ZZelle_: we can solve it by returning a random VRID in the range for example | 22:15 |
| amuller | we do that with segmentation IDs | 22:15 |
| *** manjeets has left #openstack-neutron | 22:16 | |
| ZZelle_ | amuller, sure? i remembered the helpers module performed a RetryRequest | 22:16 |
| openstackgerrit | Merged openstack/neutron: Add availability_zone support for network https://review.openstack.org/204436 | 22:17 |
| amuller | ZZelle_: ok, we used to at some point =p | 22:18 |
| amuller | ZZelle_: oh yeah we do | 22:19 |
| amuller | neutron/plugins/ml2/drivers/helpers.py.allocate_partially_specified_segment | 22:19 |
| amuller | uses random.choice | 22:19 |
| amuller | ZZelle_: ^ | 22:19 |
| amuller | I knew I wasn't crazy | 22:19 |
| *** gildub has quit IRC | 22:20 | |
| ZZelle_ | but it also uses a RetryRequest :) | 22:20 |
| *** rtheis has quit IRC | 22:20 | |
| *** pradk has quit IRC | 22:20 | |
| amuller | ZZelle_: it does, didn't always used to | 22:21 |
| amuller | ZZelle_: even with api level retries the random helps avoid contention | 22:21 |
| *** Sukhdev has quit IRC | 22:22 | |
| *** rotbeard has quit IRC | 22:23 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: WIP Correct _allocate_vr_id to support REPEATABLE READ transactions https://review.openstack.org/250040 | 22:23 |
| amuller | ZZelle_: thanks :)) | 22:24 |
| *** njohnston is now known as nate_gone | 22:24 | |
| amuller | ZZelle_: maybe your 2 patches should be squashed, for your consideration | 22:24 |
| *** safchain has joined #openstack-neutron | 22:25 | |
| *** Swami has joined #openstack-neutron | 22:26 | |
| amuller | ZZelle_: I'm off for thanksgiving weekend | 22:26 |
| amuller | ZZelle_: be back Monday! | 22:26 |
| ZZelle_ | amuller, Good Thanksgiving! | 22:27 |
| amuller | thanks :) | 22:27 |
| *** amuller has quit IRC | 22:27 | |
| *** hitalia has quit IRC | 22:29 | |
| *** shivrao has joined #openstack-neutron | 22:30 | |
| *** jaypipes has quit IRC | 22:30 | |
| *** johnbelamaric has quit IRC | 22:30 | |
| *** moshele has quit IRC | 22:31 | |
| *** moshele has joined #openstack-neutron | 22:33 | |
| *** ijw has quit IRC | 22:34 | |
| *** david-lyle has quit IRC | 22:34 | |
| *** edgar has quit IRC | 22:36 | |
| *** edgar has joined #openstack-neutron | 22:42 | |
| *** lindycoder has quit IRC | 22:43 | |
| openstackgerrit | Hirofumi Ichihara proposed openstack/neutron: Add availability_zone support for router https://review.openstack.org/224418 | 22:48 |
| *** ijw has joined #openstack-neutron | 22:49 | |
| openstackgerrit | Doug Wiegley proposed openstack/neutron-lib: Initial shared exceptions https://review.openstack.org/247856 | 22:52 |
| *** moshele has quit IRC | 22:55 | |
| *** slaweq has quit IRC | 22:58 | |
| *** ijw has quit IRC | 23:01 | |
| *** safchain has quit IRC | 23:03 | |
| *** ijw has joined #openstack-neutron | 23:05 | |
| *** Prem_ has joined #openstack-neutron | 23:06 | |
| *** david-lyle has joined #openstack-neutron | 23:07 | |
| *** ijw has quit IRC | 23:09 | |
| *** Aish has left #openstack-neutron | 23:11 | |
| openstackgerrit | Swaminathan Vasudevan proposed openstack/neutron: Change check_ports_exist_on_l3agent to pass the subnet_ids https://review.openstack.org/241843 | 23:12 |
| *** gildub has joined #openstack-neutron | 23:13 | |
| *** shashank_hegde has quit IRC | 23:13 | |
| *** moshele has joined #openstack-neutron | 23:16 | |
| *** med_ has quit IRC | 23:17 | |
| *** mickeys has joined #openstack-neutron | 23:18 | |
| *** RA has joined #openstack-neutron | 23:20 | |
| *** RA is now known as Guest43529 | 23:20 | |
| *** moshele has quit IRC | 23:24 | |
| *** david-lyle has quit IRC | 23:24 | |
| *** med_ has joined #openstack-neutron | 23:25 | |
| *** yalie has quit IRC | 23:27 | |
| *** nyechiel_ has joined #openstack-neutron | 23:28 | |
| *** ZZelle_ has quit IRC | 23:42 | |
| *** djan has joined #openstack-neutron | 23:43 | |
| *** mickeys has quit IRC | 23:45 | |
| openstackgerrit | Doug Wiegley proposed openstack/neutron: Move i18n to _i18n, as per oslo_i18n guidelines https://review.openstack.org/250071 | 23:47 |
| *** EinstCrazy has joined #openstack-neutron | 23:48 | |
| openstackgerrit | Doug Wiegley proposed openstack/neutron: Move i18n to _i18n, as per oslo_i18n guidelines https://review.openstack.org/250071 | 23:49 |
| *** EinstCrazy has quit IRC | 23:52 | |
| *** yasui_ has joined #openstack-neutron | 23:53 | |
| *** hoangcx has joined #openstack-neutron | 23:54 | |
| *** davideagnello has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!