| *** padkrish has quit IRC | 00:00 | |
| *** SayajiPatil has quit IRC | 00:00 | |
| *** salv-orlando has quit IRC | 00:02 | |
| lifeless | lets fix this in the right place | 00:02 |
|---|---|---|
| lifeless | e.g. testtools | 00:02 |
| lifeless | unittest's run method fails here, catches and transforms to error | 00:03 |
| HenryG | marun: sorry I was afk | 00:04 |
| *** dfarrell07 has joined #openstack-neutron | 00:05 | |
| marun | lifeless: so by fix you mean optionally fail if SystemExit is raised? | 00:07 |
| openstackgerrit | Miguel Angel Ajo proposed a change to openstack/neutron: Add test to compare security_group_info_for_devices with old rpc https://review.openstack.org/115575 | 00:09 |
| kevinbenton | lifeless: i’m looking at testtools now | 00:09 |
| kevinbenton | lifeless: are you already doing it? | 00:10 |
| kevinbenton | lifeless: no point in doubling up work | 00:10 |
| *** sbfox has quit IRC | 00:12 | |
| lifeless | so the issue is that we don't install a handler for BaseException | 00:12 |
| lifeless | kevinbenton: yes, I'm on it | 00:13 |
| lifeless | the unittest behaviour is to fail on SystemExit | 00:13 |
| *** seizadi has quit IRC | 00:13 | |
| lifeless | but not on KeyboardInterrupt - which it doesn't catch | 00:13 |
| lifeless | I'm just trying to decide what the right behaviour is | 00:13 |
| lifeless | I think landing that hook based check is a reasonable short term fix | 00:15 |
| lifeless | I want to let this one percolate a couple of days I think | 00:15 |
| kevinbenton | lifeless: what i’m having difficulty getting is why SystemExit isn’t caught in the same way is BaseException | 00:16 |
| kevinbenton | lifeless: this is the part marking it as passed | 00:18 |
| kevinbenton | lifeless: https://github.com/testing-cabal/testtools/blob/master/testtools/runtest.py#L149 | 00:18 |
| *** dfarrell07 has quit IRC | 00:18 | |
| lifeless | kevinbenton: actually its testtools/testcase.py line 218 | 00:18 |
| kevinbenton | lifeless: how does that catch baseexception? | 00:20 |
| lifeless | it doesn't | 00:20 |
| lifeless | which is why its not marked as a failure | 00:20 |
| kevinbenton | lifeless: http://paste.openstack.org/show/104456/ | 00:21 |
| kevinbenton | lifeless: results in http://paste.openstack.org/show/104457/ | 00:22 |
| lifeless | what testtools version is that ? | 00:23 |
| *** padkrish has joined #openstack-neutron | 00:23 | |
| kevinbenton | looks like testtools-0.9.35-py2.7 | 00:24 |
| *** padkrish has joined #openstack-neutron | 00:24 | |
| *** yamamoto has quit IRC | 00:24 | |
| *** otherwiseguy has quit IRC | 00:25 | |
| *** yamamoto has joined #openstack-neutron | 00:25 | |
| *** tsg has joined #openstack-neutron | 00:26 | |
| marun | kevinbenton: can I leave this to you? | 00:26 |
| marun | kevinbenton: I really need to sleep | 00:26 |
| kevinbenton | marun: well do we still want to merge this? | 00:27 |
| openstackgerrit | A change was merged to openstack/neutron: Imported Translations from Transifex https://review.openstack.org/117100 | 00:27 |
| marun | kevinbenton: there is a patch to make the functional job non-voting whenever the infra guys wake up | 00:27 |
| openstackgerrit | A change was merged to openstack/neutron: Add functional test for IptablesManager https://review.openstack.org/117852 | 00:27 |
| openstackgerrit | A change was merged to openstack/neutron: Improve some plugins help strings https://review.openstack.org/117990 | 00:27 |
| openstackgerrit | A change was merged to openstack/neutron: Apic drivers enhancements (second approach): Topology https://review.openstack.org/116780 | 00:27 |
| kevinbenton | marun: you can go to bed, but I don’t think there is anything left for me to do either | 00:28 |
| marun | kevinbenton: fair enough | 00:28 |
| lifeless | you've got an old subunit for sure | 00:29 |
| lifeless | and an old testtools | 00:29 |
| lifeless | but I can't see anything that would change this behaviour in the commits since 0.9.35 | 00:29 |
| *** marun is now known as marun_afk | 00:30 | |
| *** networkstatic has quit IRC | 00:32 | |
| openstackgerrit | Kevin Benton proposed a change to openstack/neutron: Prevent SystemExits when running tests https://review.openstack.org/118225 | 00:32 |
| *** tsg has quit IRC | 00:33 | |
| lifeless | weird, reproduction test does crack | 00:34 |
| kevinbenton | lifeless: what do you mean. same thing on latest version? | 00:35 |
| lifeless | kevinbenton: http://paste.ubuntu.com/8211009/ | 00:35 |
| *** swat30 has quit IRC | 00:36 | |
| *** thomasem_ has joined #openstack-neutron | 00:36 | |
| lifeless | ah | 00:36 |
| lifeless | I misinterpreted | 00:37 |
| *** thomasem has quit IRC | 00:37 | |
| lifeless | the ui is outputting stuff during cleanup | 00:37 |
| lifeless | ok | 00:37 |
| lifeless | so we don't catch systemexit | 00:37 |
| lifeless | upstream does. | 00:37 |
| kevinbenton | i see | 00:38 |
| lifeless | upstream == unittest | 00:38 |
| kevinbenton | the test runner then | 00:38 |
| kevinbenton | oh | 00:38 |
| lifeless | no, the TestCase.run method in Python2.7+ | 00:38 |
| lifeless | but what we do is wrong | 00:39 |
| *** swat30 has joined #openstack-neutron | 00:39 | |
| *** tsg has joined #openstack-neutron | 00:40 | |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Local arp responder for VLAN https://review.openstack.org/112949 | 00:40 |
| lifeless | in that sys.exit(0) results in a 0 exit status | 00:40 |
| *** thomasem_ has quit IRC | 00:40 | |
| mestery | marun_afk kevinbenton: Ack, just gave +2 on that patch. | 00:42 |
| marun_afk | mestery: I think maybe we have an alternate solution... | 00:42 |
| *** marun_afk is now known as marun | 00:42 | |
| * mestery reads backscroll and catches up with marun ... | 00:42 | |
| marun | kevinbenton: I think skipping the l3 test additions might be the best way forward | 00:42 |
| marun | kevinbenton: things only started breaking after that. | 00:42 |
| *** emagana has joined #openstack-neutron | 00:43 | |
| marun | kevinbenton: so if we skip them we can merge it fast rather than having to rely on infra | 00:43 |
| Administrator_ | hi all! | 00:43 |
| *** sbfox has joined #openstack-neutron | 00:43 | |
| *** JayJ_ has quit IRC | 00:45 | |
| kevinbenton | marun: ok. do you want to do that? i’m not familiar with which tests those were | 00:46 |
| *** JayJ_ has joined #openstack-neutron | 00:46 | |
| marun | kevinbenton: I guess in this instance maybe I can get away with +2'ing my own patch if mestery will approve | 00:46 |
| mestery | marun: Ack, I trust your judgement. Which patch? | 00:47 |
| marun | mestery: I'll have to propose | 00:47 |
| mestery | marun: Sounds good | 00:47 |
| *** emagana has quit IRC | 00:47 | |
| marun | mestery: it will basically skip all the test additions from git commit id 66730877 | 00:47 |
| mestery | marun: Which failure is that introducing or tickling? | 00:48 |
| marun | mestery: https://bugs.launchpad.net/neutron/+bug/1364171 | 00:48 |
| *** changbl has joined #openstack-neutron | 00:48 | |
| marun | mestery: I'll submit a patch that skips it | 00:49 |
| mestery | marun: Ack, I'll be here for a bit, and then back < 1 hour later, I'll keep my eye out for it | 00:49 |
| marun | mestery: I'll post it in the next 5m | 00:50 |
| marun | mestery: it's super late for me | 00:50 |
| mestery | marun: I was thknking that ;) | 00:50 |
| marun | lifeless: http://ur1.ca/i3p8h | 00:50 |
| marun | lifeless: apparently this is what happens when sys.exit() is called in a test | 00:51 |
| marun | lifeless: exactly what we're seeing in the neutron functional job | 00:51 |
| marun | ajo: ^^ | 00:51 |
| *** SridharRamaswamy has joined #openstack-neutron | 00:51 | |
| lifeless | marun: so that would be sys.exit(1) or something | 00:51 |
| yamamoto | mestery: can you revisit https://review.openstack.org/#/c/112949/ which lost +A due to a rebase? | 00:51 |
| lifeless | marun: sys.exit(0) will appear to pass but run too-few tests. | 00:51 |
| lifeless | marun: I am working up a patch for that now | 00:52 |
| mestery | yamamoto: Yes, looking now | 00:52 |
| yamamoto | mestery: thank you | 00:52 |
| mestery | yamamoto: +A, is it looking like we'll get all the ofagent patches in today yet or are there a few more left? | 00:52 |
| marun | lifeless: so you're going to fix so that sys.exit() never breaks the test run? | 00:53 |
| yamamoto | mestery: one patch is left but it's devstack patch https://review.openstack.org/#/c/108915/ | 00:53 |
| mestery | yamamoto: cool! | 00:54 |
| lifeless | marun: no, we shouldn't catch BaseException. I will make it so that it always triggers an error. | 00:54 |
| mestery | yamamoto: Feel free to mark your BPs as "Implemented" when they all land or ping me and I can do it, thanks! | 00:54 |
| marun | lifeless: I'm not picky on how, so long as the failure is something we can debug. | 00:54 |
| *** yamahata has quit IRC | 00:55 | |
| marun | lifeless: we're likely to have a lot more potential for unintended SystemExit as we expand the scope of functional testing in Neutron | 00:55 |
| yamamoto | mestery: i'll update bp state when patches are merged. | 00:55 |
| mestery | yamamoto: thank you! | 00:55 |
| lifeless | marun: why is library code calling systemexit? | 00:56 |
| lifeless | marun: https://bugs.launchpad.net/testtools/+bug/1364188 | 00:56 |
| marun | lifeless: who said anything about library code? | 00:56 |
| marun | lifeless: we're adding functional tests for agents | 00:56 |
| *** ianw has quit IRC | 00:57 | |
| marun | lifeless: there are going to be SystemExit in there, and sometimes they will be triggered accidentally by careless hands | 00:57 |
| *** ianw has joined #openstack-neutron | 00:57 | |
| lifeless | marun: so usually there is a CLI layer and then internals, even in things like agents. | 00:57 |
| marun | lifeless: sure, and we'll get there | 00:57 |
| marun | lifeless: but much of the codebase has only ever seen unit and integration testing up till now | 00:58 |
| marun | lifeless: there are going to be teething pains | 00:58 |
| lifeless | marun: I'm wondering if a single sed over the codebase to replace SystemExit and sys.exit with something custom would avoid the test issue entirely | 00:58 |
| marun | lifeless: and our test runner shouldn't explode in the process | 00:58 |
| lifeless | marun: oh I totally agree | 00:58 |
| lifeless | marun: I'm working on the patch right now | 00:58 |
| marun | lifeless++ | 00:59 |
| *** yamamoto has quit IRC | 00:59 | |
| *** emagana has joined #openstack-neutron | 00:59 | |
| kevinbenton | lifeless: so what is that a patch to then? | 00:59 |
| lifeless | testtools | 00:59 |
| ajo__ | lifeless++ | 01:01 |
| ajo__ | I totally agree, we need to patch & capture those, looking forward to see the patch lifeless , thanks | 01:02 |
| openstackgerrit | Maru Newby proposed a change to openstack/neutron: Skip functional l3 agent test https://review.openstack.org/118233 | 01:04 |
| *** emagana has quit IRC | 01:04 | |
| openstackgerrit | Kevin Benton proposed a change to openstack/neutron: Prevent SystemExits when running tests https://review.openstack.org/118225 | 01:05 |
| kevinbenton | marun, mestery: ^^ unit test added to that patch if we want to go forward with it | 01:06 |
| marun | lifeless: what do you think of submitting a patch to neutron now so that we can fix the failing job and reverting when we have a fixed version of testtools available? | 01:07 |
| lifeless | marun: you have to fix the failing job irrespectively; how much churn is kindof an ops question :) | 01:07 |
| *** dfarrell07 has joined #openstack-neutron | 01:07 | |
| marun | kevinbenton: I think we should go forward with it then | 01:07 |
| kevinbenton | lifeless: it’s harder to fix without an output though :-) | 01:07 |
| lifeless | marun: all what I'm doing will do is make it easier to debug | 01:07 |
| marun | lifeless: ok | 01:08 |
| marun | mestery: I'm going to +2 and you can approve when ready | 01:08 |
| *** devvesa has joined #openstack-neutron | 01:08 | |
| *** ianw has quit IRC | 01:09 | |
| kevinbenton | ajo: i think you just duplicated maruns bug | 01:10 |
| *** ianw has joined #openstack-neutron | 01:10 | |
| *** ianw has quit IRC | 01:11 | |
| kevinbenton | ajo: whoops. nevermind. i see you already marked it that way | 01:11 |
| *** ianw has joined #openstack-neutron | 01:11 | |
| openstackgerrit | Liping Mao proposed a change to openstack/neutron: Neutron metering does not check overlap ip range https://review.openstack.org/116652 | 01:11 |
| ajo__ | kevinbenton++ | 01:12 |
| *** padkrish_ has joined #openstack-neutron | 01:12 | |
| *** padkrish_ has quit IRC | 01:12 | |
| marun | kevinbenton: I've posted a patch to skip the test in case we want it: https://review.openstack.org/#/c/118233/ | 01:12 |
| marun | I think I'm going to abandon the patch to stop the functional job from voting | 01:12 |
| marun | It would be better if we handle it in our own tree | 01:13 |
| *** devvesa has quit IRC | 01:13 | |
| kevinbenton | marun: right | 01:13 |
| *** padkrish_ has joined #openstack-neutron | 01:13 | |
| *** otherwiseguy has joined #openstack-neutron | 01:13 | |
| kevinbenton | marun: were you ever able to reproduce locally? | 01:13 |
| marun | nope | 01:13 |
| *** carlp has quit IRC | 01:13 | |
| marun | Something environment-specific I guess | 01:14 |
| mestery | marun kevinbenton: This is the one we want to merge? https://review.openstack.org/#/c/118225/ | 01:14 |
| kevinbenton | mestery: that and this https://review.openstack.org/#/c/118233/ | 01:14 |
| kevinbenton | mestery: that first one will help reveal the error when it happens until testtools is fixed | 01:14 |
| marun | kevinbenton: not sure we want to merge the skip fist | 01:14 |
| *** padkrish has quit IRC | 01:15 | |
| marun | at first | 01:15 |
| kevinbenton | marun: yeah, would be nice to get a few failures... | 01:15 |
| marun | kevinbenton++ | 01:15 |
| mestery | marun: I suspect we should wait for Jenkins to patch for https://review.openstack.org/#/c/118225/ before going +A on it | 01:15 |
| marun | mestery: yes | 01:15 |
| ajo__ | yes | 01:15 |
| mestery | marun: I'll keep an eye on it, once Jenkins passes, I'll +A it tonight yet. | 01:15 |
| marun | mestery: I'll leave that to you. | 01:15 |
| marun | mestery++ | 01:15 |
| mestery | marun: You should get to bed, it must be ridicuously late where you are! :) Same with with ajo__ I bet ;) | 01:16 |
| kevinbenton | are there any consequences to merging without waiting? i thought the gate immediately blocked it anyway? | 01:16 |
| kevinbenton | sorry, approving* | 01:16 |
| ajo__ | mestery , around 03:16 | 01:16 |
| ajo__ | ':) | 01:16 |
| mestery | ajo__: :P | 01:16 |
| ajo__ | stress keeps me up, no coffee since 5pm ... :) :) but enough for today, time to sleep!, | 01:17 |
| ajo__ | have a good day/night gentlemen! | 01:17 |
| kevinbenton | ajo__: aloha! | 01:17 |
| *** otherwiseguy has quit IRC | 01:17 | |
| ajo__ | :) | 01:17 |
| *** ajo__ has quit IRC | 01:18 | |
| *** arosen1 has joined #openstack-neutron | 01:18 | |
| *** stanzgy has joined #openstack-neutron | 01:20 | |
| *** arosen has quit IRC | 01:21 | |
| lifeless | right, part 1 of the fix done | 01:22 |
| lifeless | just need to replicate it for the deferredruntest | 01:22 |
| lifeless | then I can push | 01:22 |
| *** padkrish_ has quit IRC | 01:24 | |
| *** dfarrell07 has quit IRC | 01:25 | |
| *** amotoki has joined #openstack-neutron | 01:26 | |
| *** marun is now known as marun_afk | 01:26 | |
| *** ianw has quit IRC | 01:28 | |
| *** ianw has joined #openstack-neutron | 01:29 | |
| *** amotoki has quit IRC | 01:31 | |
| *** seizadi has joined #openstack-neutron | 01:36 | |
| *** gildub has quit IRC | 01:37 | |
| *** sgordon_ has quit IRC | 01:38 | |
| *** tomoe_ has joined #openstack-neutron | 01:39 | |
| *** tomoe_ has quit IRC | 01:39 | |
| *** tomoe_ has joined #openstack-neutron | 01:40 | |
| *** mitarun has joined #openstack-neutron | 01:43 | |
| *** baoli has joined #openstack-neutron | 01:44 | |
| *** packet has joined #openstack-neutron | 01:45 | |
| kevinbenton | lifeless: what’s your approach to the fix? just catching SystemExit in addition to the others? | 01:47 |
| *** mestery has quit IRC | 01:48 | |
| *** mitarun has quit IRC | 01:48 | |
| *** mitarun has joined #openstack-neutron | 01:48 | |
| lifeless | kevinbenton: http://paste.ubuntu.com/8211457/ WIP | 01:48 |
| *** baoli has quit IRC | 01:49 | |
| *** baoli has joined #openstack-neutron | 01:49 | |
| *** marun_afk has quit IRC | 01:50 | |
| *** baoli has quit IRC | 01:50 | |
| *** baoli has joined #openstack-neutron | 01:51 | |
| kevinbenton | lifeless: interesting. I take it this isn’t your first patch to testtools :-) | 01:51 |
| lifeless | kevinbenton: I'm one of the maintainers | 01:52 |
| kevinbenton | lifeless: makese sense. definitely would have been much worse for me to attempt to fix it | 01:53 |
| *** mitarun has quit IRC | 01:53 | |
| *** yamahata has joined #openstack-neutron | 01:53 | |
| *** baohua has joined #openstack-neutron | 01:53 | |
| *** emagana has joined #openstack-neutron | 01:53 | |
| *** baohua has quit IRC | 01:54 | |
| openstackgerrit | A change was merged to openstack/neutron: ML2: Fix release of network segments to allocation pools https://review.openstack.org/118140 | 01:54 |
| *** gildub has joined #openstack-neutron | 01:54 | |
| *** baoli has quit IRC | 01:55 | |
| *** baohua has joined #openstack-neutron | 01:55 | |
| *** emagana has quit IRC | 01:57 | |
| *** alexpilotti has quit IRC | 01:57 | |
| openstackgerrit | A change was merged to openstack/neutron: Fix a recent ipv6 UT regression https://review.openstack.org/118075 | 01:58 |
| *** suresh12 has joined #openstack-neutron | 01:59 | |
| *** seizadi has quit IRC | 01:59 | |
| *** amotoki has joined #openstack-neutron | 02:00 | |
| *** yamamoto has joined #openstack-neutron | 02:02 | |
| openstackgerrit | shihanzhang proposed a change to openstack/neutron: Refactor security group rpc call https://review.openstack.org/111876 | 02:03 |
| *** xuhanp has joined #openstack-neutron | 02:06 | |
| *** otherwiseguy has joined #openstack-neutron | 02:07 | |
| *** mlavalle_ has quit IRC | 02:07 | |
| *** dfarrell07 has joined #openstack-neutron | 02:08 | |
| *** ianw has quit IRC | 02:09 | |
| *** ianw has joined #openstack-neutron | 02:11 | |
| *** otherwiseguy has quit IRC | 02:11 | |
| *** baoli has joined #openstack-neutron | 02:13 | |
| openstackgerrit | Rajeev Grover proposed a change to openstack/neutron: Fix AttributeError when setting external gateway on DVR router https://review.openstack.org/112146 | 02:15 |
| kevinbenton | rkukura: do you know who manages the ODL CI? | 02:15 |
| *** mitarun has joined #openstack-neutron | 02:16 | |
| lifeless | kevinbenton: https://github.com/testing-cabal/testtools/pull/104 | 02:18 |
| *** tomoe__ has joined #openstack-neutron | 02:19 | |
| *** diegows has quit IRC | 02:19 | |
| *** suresh12 has quit IRC | 02:19 | |
| *** nlahouti has joined #openstack-neutron | 02:20 | |
| *** mlavalle_ has joined #openstack-neutron | 02:21 | |
| *** tomoe_ has quit IRC | 02:22 | |
| lifeless | kevinbenton: would love it if you can give that a spin and let me know if it does indeed fix it for you | 02:23 |
| kevinbenton | lifeless: sure. give me 15 mins | 02:23 |
| kevinbenton | lifeless: debugging another issue right now | 02:23 |
| *** mitarun has quit IRC | 02:24 | |
| *** padkrish has joined #openstack-neutron | 02:24 | |
| *** mitarun has joined #openstack-neutron | 02:24 | |
| *** nlahouti has quit IRC | 02:27 | |
| *** padkrish has quit IRC | 02:27 | |
| *** nlahouti has joined #openstack-neutron | 02:27 | |
| *** padkrish has joined #openstack-neutron | 02:27 | |
| *** prasoon has joined #openstack-neutron | 02:28 | |
| *** padkrish has quit IRC | 02:28 | |
| openstackgerrit | Kevin Benton proposed a change to openstack/neutron: BSN: Bind external ports in ML2 driver https://review.openstack.org/116188 | 02:29 |
| *** padkrish has joined #openstack-neutron | 02:29 | |
| *** mitarun has quit IRC | 02:29 | |
| *** tomoe__ has quit IRC | 02:29 | |
| *** tomoe_ has joined #openstack-neutron | 02:30 | |
| *** mlavalle_ has quit IRC | 02:32 | |
| *** mlavalle_ has joined #openstack-neutron | 02:32 | |
| *** prasoon has quit IRC | 02:32 | |
| *** mlavalle_ has quit IRC | 02:33 | |
| kevinbenton | lifeless: works great | 02:37 |
| kevinbenton | lifeless: http://paste.openstack.org/show/104479/ | 02:37 |
| *** linuxgeek_ has quit IRC | 02:38 | |
| *** seizadi has joined #openstack-neutron | 02:43 | |
| *** suresh12 has joined #openstack-neutron | 02:44 | |
| *** padkrish has quit IRC | 02:45 | |
| *** emagana has joined #openstack-neutron | 02:47 | |
| *** ianw has quit IRC | 02:48 | |
| *** ianw has joined #openstack-neutron | 02:49 | |
| *** packet has quit IRC | 02:50 | |
| *** mspreitz has joined #openstack-neutron | 02:51 | |
| *** packet has joined #openstack-neutron | 02:51 | |
| *** packet has quit IRC | 02:51 | |
| *** emagana has quit IRC | 02:52 | |
| openstackgerrit | Yanping Qu proposed a change to openstack/neutron: Adds FWaaS driver for Cisco CSR1kv https://review.openstack.org/115389 | 02:54 |
| lifeless | kevinbenton: cool | 02:54 |
| *** suresh12 has quit IRC | 02:55 | |
| *** tflynn has quit IRC | 02:55 | |
| *** seizadi has quit IRC | 02:55 | |
| *** tflynn has joined #openstack-neutron | 02:55 | |
| *** devvesa has joined #openstack-neutron | 02:57 | |
| *** xuhanp_ has quit IRC | 02:58 | |
| *** zz_naotokl is now known as naotok | 03:00 | |
| *** ianw has quit IRC | 03:01 | |
| *** devvesa has quit IRC | 03:01 | |
| *** ianw has joined #openstack-neutron | 03:01 | |
| *** tflynn has quit IRC | 03:03 | |
| *** tflynn has joined #openstack-neutron | 03:03 | |
| *** padkrish has joined #openstack-neutron | 03:05 | |
| *** padkrish has quit IRC | 03:05 | |
| *** padkrish has joined #openstack-neutron | 03:05 | |
| *** prasoon has joined #openstack-neutron | 03:06 | |
| *** shakamunyi has joined #openstack-neutron | 03:15 | |
| openstackgerrit | Sridar Kandaswamy proposed a change to openstack/neutron: Changes to support FWaaS in a DVR based environment https://review.openstack.org/113359 | 03:16 |
| *** shakamunyi has quit IRC | 03:20 | |
| *** dfarrell07 has quit IRC | 03:20 | |
| *** SridharR_ has joined #openstack-neutron | 03:20 | |
| openstackgerrit | nlahouti proposed a change to openstack/neutron: Cisco DFA ML2 Mechanism Driver - Part 4 https://review.openstack.org/111863 | 03:22 |
| *** tflynn has quit IRC | 03:23 | |
| *** tflynn has joined #openstack-neutron | 03:23 | |
| *** SridharRamaswamy has quit IRC | 03:23 | |
| *** SridharR_ has quit IRC | 03:23 | |
| *** padkrish has quit IRC | 03:23 | |
| *** SridharRamaswamy has joined #openstack-neutron | 03:24 | |
| *** suresh12 has joined #openstack-neutron | 03:26 | |
| *** amotoki_ has joined #openstack-neutron | 03:27 | |
| *** otherwiseguy has joined #openstack-neutron | 03:27 | |
| *** Yi has joined #openstack-neutron | 03:27 | |
| lifeless | kevinbenton: released | 03:28 |
| kevinbenton | lifeless: well that was fast. :-) | 03:28 |
| lifeless | kevinbenton: benefits of a lean process :) | 03:28 |
| *** SridharRamaswamy has quit IRC | 03:28 | |
| *** amotoki_ has quit IRC | 03:31 | |
| *** Yi has quit IRC | 03:34 | |
| *** suresh12 has quit IRC | 03:34 | |
| *** mitarun has joined #openstack-neutron | 03:38 | |
| *** padkrish has joined #openstack-neutron | 03:38 | |
| *** padkrish has quit IRC | 03:39 | |
| *** xianghuihui has joined #openstack-neutron | 03:39 | |
| *** baoli has quit IRC | 03:39 | |
| *** padkrish has joined #openstack-neutron | 03:39 | |
| *** mestery has joined #openstack-neutron | 03:41 | |
| *** mitarun has quit IRC | 03:41 | |
| *** emagana has joined #openstack-neutron | 03:41 | |
| *** mitarun has joined #openstack-neutron | 03:42 | |
| *** xianghui has quit IRC | 03:42 | |
| *** mitarun has quit IRC | 03:46 | |
| *** emagana has quit IRC | 03:46 | |
| *** ianw has quit IRC | 03:48 | |
| *** ianw has joined #openstack-neutron | 03:48 | |
| *** suresh12 has joined #openstack-neutron | 03:49 | |
| *** seizadi has joined #openstack-neutron | 03:50 | |
| *** tsg has quit IRC | 03:53 | |
| *** dfarrell07 has joined #openstack-neutron | 03:53 | |
| *** leenheer has joined #openstack-neutron | 03:53 | |
| kevinbenton | lifeless: shouldn’t we wait for the version bump in the test requirements before reverting that patch? | 03:57 |
| *** xuhanp_ has joined #openstack-neutron | 03:57 | |
| lifeless | kevinbenton: Up to you; if you don't then folk *can* run with an older testtools. If you do then you force everyone to upgrade. | 03:58 |
| kevinbenton | lifeless: well until we get to the root cause of the exit in the functional test we should probably wait | 03:59 |
| kevinbenton | lifeless: becasue the gate won’t be upgraded to the new testtools, right? | 03:59 |
| lifeless | interestingly I think there's a little angle I missed in the patch, won't affect us (we use subunit) but may mask status for folk using the shell status code from e.g. testtools.run | 03:59 |
| lifeless | the gate will use the latest testtools soon as bandersnatch runs | 03:59 |
| lifeless | though hmm | 04:00 |
| *** mitarun has joined #openstack-neutron | 04:00 | |
| lifeless | nope all good - testtools>=0.9.34 | 04:00 |
| kevinbenton | is bandersnatch the image build process? | 04:01 |
| lifeless | in global-requirements | 04:01 |
| lifeless | bandersnatch is the pypi mirror tool | 04:01 |
| lifeless | I suspect runs started now will be using 1.0.0 | 04:01 |
| kevinbenton | oh, i was thinking the gate built images that cached all of the requisites | 04:01 |
| lifeless | they do | 04:02 |
| lifeless | but then they install and newer things are cache misses | 04:02 |
| *** xuhanp has quit IRC | 04:02 | |
| kevinbenton | oh, i don’t understand how pip works | 04:02 |
| kevinbenton | i was thinking it would be satisfied by the current install since it’s >=0.9.34 | 04:02 |
| kevinbenton | and not upgrade | 04:03 |
| lifeless | they get cached, not installed | 04:04 |
| lifeless | there's a download cache | 04:04 |
| *** tsg has joined #openstack-neutron | 04:04 | |
| *** mitarun has quit IRC | 04:05 | |
| *** mitarun has joined #openstack-neutron | 04:05 | |
| *** mestery has quit IRC | 04:08 | |
| kevinbenton | oh okay | 04:09 |
| kevinbenton | i was thinking the image would do pip install of everything | 04:09 |
| *** chandankumar has joined #openstack-neutron | 04:11 | |
| *** yfried_ has quit IRC | 04:11 | |
| *** xuhanp_ has quit IRC | 04:13 | |
| *** LiberTerra has quit IRC | 04:14 | |
| *** ianw has quit IRC | 04:16 | |
| *** tflynn has quit IRC | 04:16 | |
| *** ianw has joined #openstack-neutron | 04:16 | |
| *** tflynn has joined #openstack-neutron | 04:17 | |
| *** xianghuihui has quit IRC | 04:19 | |
| *** dbite has joined #openstack-neutron | 04:19 | |
| *** xianghui has joined #openstack-neutron | 04:20 | |
| *** dfarrell07 has quit IRC | 04:23 | |
| *** trinaths has joined #openstack-neutron | 04:23 | |
| *** carl_baldwin has joined #openstack-neutron | 04:24 | |
| trinaths | Good Morning All. | 04:25 |
| *** seizadi has quit IRC | 04:28 | |
| *** emagana has joined #openstack-neutron | 04:36 | |
| *** teju has joined #openstack-neutron | 04:36 | |
| *** chandankumar has quit IRC | 04:38 | |
| *** emagana has quit IRC | 04:40 | |
| *** teju has quit IRC | 04:46 | |
| *** devvesa has joined #openstack-neutron | 04:46 | |
| *** padkrish has quit IRC | 04:49 | |
| *** divyac has quit IRC | 04:49 | |
| *** seizadi has joined #openstack-neutron | 04:50 | |
| *** oda-g has quit IRC | 04:50 | |
| *** devvesa has quit IRC | 04:51 | |
| *** chandankumar has joined #openstack-neutron | 04:51 | |
| *** nati_ueno has joined #openstack-neutron | 04:53 | |
| *** killer_prince is now known as lazy_prince | 04:53 | |
| *** s3wong has joined #openstack-neutron | 04:56 | |
| *** vishwanathj has joined #openstack-neutron | 04:58 | |
| *** leenheer has quit IRC | 05:00 | |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Ignore unknown l2pop entry removals https://review.openstack.org/114443 | 05:02 |
| openstackgerrit | A change was merged to openstack/neutron: ofagent: Local arp responder for VLAN https://review.openstack.org/112949 | 05:03 |
| *** linuxgeek_ has joined #openstack-neutron | 05:06 | |
| *** irenab has joined #openstack-neutron | 05:06 | |
| *** xuhanp has joined #openstack-neutron | 05:07 | |
| *** prasoon has quit IRC | 05:08 | |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Enable local arp responder for TYPE_FLAT https://review.openstack.org/114119 | 05:09 |
| *** irenab has quit IRC | 05:11 | |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Enable local arp responder for TYPE_LOCAL https://review.openstack.org/114310 | 05:12 |
| *** padkrish has joined #openstack-neutron | 05:12 | |
| *** kopparam has joined #openstack-neutron | 05:13 | |
| *** padkrish has joined #openstack-neutron | 05:13 | |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Implement physical_interface_mappings https://review.openstack.org/113166 | 05:14 |
| *** xuhanp_ has joined #openstack-neutron | 05:14 | |
| *** carl_baldwin has quit IRC | 05:15 | |
| openstackgerrit | vikas proposed a change to openstack/neutron: Check for valid peer_id field https://review.openstack.org/116835 | 05:15 |
| *** yfried_ has joined #openstack-neutron | 05:16 | |
| *** prasoon has joined #openstack-neutron | 05:16 | |
| *** otherwiseguy has quit IRC | 05:17 | |
| openstackgerrit | Sumit Naiksatam proposed a change to openstack/neutron: Avoid changing constants module when adding new service plugin https://review.openstack.org/116996 | 05:17 |
| *** s3wong has quit IRC | 05:18 | |
| *** s3wong has joined #openstack-neutron | 05:19 | |
| openstackgerrit | Hareesh Puthalath proposed a change to openstack/neutron: Supply missing cisco_cfg_agent.ini file https://review.openstack.org/118252 | 05:19 |
| openstackgerrit | vikas proposed a change to openstack/neutron: Check for valid peer_id field https://review.openstack.org/116835 | 05:19 |
| *** Administrator_ has quit IRC | 05:21 | |
| *** xuhanp_ has quit IRC | 05:21 | |
| *** s3wong has quit IRC | 05:21 | |
| *** hanzhang has joined #openstack-neutron | 05:22 | |
| *** s3wong has joined #openstack-neutron | 05:22 | |
| yamamoto | amotoki: ping | 05:23 |
| amotoki | yamahata: what? I need to leave now unfortunately | 05:24 |
| yamamoto | amotoki: can you revisit https://review.openstack.org/#/c/114119/ which lost +A due to rebases? | 05:25 |
| amotoki | yamahata: done. type_local too? | 05:25 |
| yamamoto | amotoki: thank you. yes. | 05:25 |
| amotoki | yamahata: done both. good luck! | 05:26 |
| yamamoto | amotoki: thank you! | 05:26 |
| *** amotoki_ has joined #openstack-neutron | 05:28 | |
| *** vishwanathj has quit IRC | 05:30 | |
| openstackgerrit | vikas proposed a change to openstack/neutron: Check for valid peer_id field https://review.openstack.org/116835 | 05:31 |
| *** hanzhang has quit IRC | 05:31 | |
| *** emagana has joined #openstack-neutron | 05:31 | |
| *** hanzhang has joined #openstack-neutron | 05:32 | |
| *** amotoki_ has quit IRC | 05:33 | |
| *** xuhanp_ has joined #openstack-neutron | 05:33 | |
| *** juice has quit IRC | 05:35 | |
| *** juice has joined #openstack-neutron | 05:36 | |
| *** emagana has quit IRC | 05:36 | |
| *** nati_ueno has quit IRC | 05:38 | |
| *** nati_ueno has joined #openstack-neutron | 05:38 | |
| *** mitarun has quit IRC | 05:38 | |
| *** mitarun has joined #openstack-neutron | 05:39 | |
| *** suresh12 has quit IRC | 05:39 | |
| openstackgerrit | Kevin Benton proposed a change to openstack/neutron: BSN: Bind external ports in ML2 driver https://review.openstack.org/116188 | 05:40 |
| *** xuhanp_ has quit IRC | 05:40 | |
| *** mitarun has quit IRC | 05:40 | |
| *** mitarun has joined #openstack-neutron | 05:40 | |
| *** nati_ueno has quit IRC | 05:43 | |
| *** changbl has quit IRC | 05:46 | |
| *** xuhanp_ has joined #openstack-neutron | 05:50 | |
| *** ianw has quit IRC | 05:50 | |
| *** ianw has joined #openstack-neutron | 05:51 | |
| openstackgerrit | Trinath Somanchi proposed a change to openstack/neutron: Freescale FWaaS Plugin https://review.openstack.org/109659 | 05:52 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-neutronclient: Use adapter from keystoneclient https://review.openstack.org/118006 | 05:53 |
| *** mspreitz has quit IRC | 05:53 | |
| *** lori|away is now known as lori | 05:55 | |
| *** xuhanp_ has quit IRC | 05:57 | |
| *** seizadi has quit IRC | 05:57 | |
| *** roeyc has joined #openstack-neutron | 05:57 | |
| openstackgerrit | Sridar Kandaswamy proposed a change to openstack/neutron: Changes to support FWaaS in a DVR based environment https://review.openstack.org/113359 | 05:57 |
| *** xuhanp_ has joined #openstack-neutron | 06:00 | |
| trinaths | amotoki: Hi, In your free time, can you look into the new patchset. Updated with your review comments. | 06:01 |
| *** roeyc has quit IRC | 06:01 | |
| *** k4n0 has joined #openstack-neutron | 06:06 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/neutron: Imported Translations from Transifex https://review.openstack.org/118259 | 06:06 |
| openstackgerrit | A change was merged to openstack/neutron: Prevent SystemExits when running tests https://review.openstack.org/118225 | 06:07 |
| *** s3wong has quit IRC | 06:08 | |
| *** xuhanp_ has quit IRC | 06:08 | |
| *** zhhuabj has quit IRC | 06:10 | |
| *** zhhuabj has joined #openstack-neutron | 06:10 | |
| *** suresh12 has joined #openstack-neutron | 06:10 | |
| *** cristov_mac has joined #openstack-neutron | 06:13 | |
| *** suresh12 has quit IRC | 06:15 | |
| openstackgerrit | Kevin Benton proposed a change to openstack/neutron: BSN: Bind external ports in ML2 driver https://review.openstack.org/116188 | 06:24 |
| *** dbite has quit IRC | 06:25 | |
| *** emagana has joined #openstack-neutron | 06:26 | |
| *** dbite has joined #openstack-neutron | 06:29 | |
| openstackgerrit | nlahouti proposed a change to openstack/python-neutronclient: Add API in python-neutronclient for Cisco DFA https://review.openstack.org/97416 | 06:29 |
| *** emagana has quit IRC | 06:30 | |
| *** neeti has joined #openstack-neutron | 06:30 | |
| *** rm_work|away is now known as rm_work | 06:32 | |
| *** nlahouti has quit IRC | 06:34 | |
| *** SridharG has joined #openstack-neutron | 06:34 | |
| *** devvesa has joined #openstack-neutron | 06:35 | |
| *** suresh12 has joined #openstack-neutron | 06:36 | |
| openstackgerrit | Paddu Krishnan proposed a change to openstack/neutron: VDP Support in OVS Neutron Agent https://review.openstack.org/115442 | 06:38 |
| openstackgerrit | Paddu Krishnan proposed a change to openstack/neutron: Support for LLDP/VDP Module needed for VDP support in OVS agent https://review.openstack.org/105563 | 06:38 |
| *** devvesa_ has joined #openstack-neutron | 06:39 | |
| *** devvesa has quit IRC | 06:39 | |
| *** cnesa9 has quit IRC | 06:42 | |
| *** mitarun has quit IRC | 06:48 | |
| *** salv-orlando has joined #openstack-neutron | 06:48 | |
| *** mitarun_ has joined #openstack-neutron | 06:50 | |
| *** bvandenh has joined #openstack-neutron | 06:50 | |
| openstackgerrit | Sumit Naiksatam proposed a change to openstack/neutron: Avoid changing constants module when adding new service plugin https://review.openstack.org/116996 | 06:51 |
| *** ianw has quit IRC | 06:52 | |
| *** ianw has joined #openstack-neutron | 06:52 | |
| *** suresh12 has quit IRC | 06:53 | |
| *** roeyc has joined #openstack-neutron | 06:53 | |
| openstackgerrit | Paddu Krishnan proposed a change to openstack/neutron: Support for DFA Overlay Type Driver https://review.openstack.org/115452 | 06:53 |
| *** amaretskiy has joined #openstack-neutron | 06:54 | |
| *** saju_m has joined #openstack-neutron | 06:55 | |
| *** simon-AS559 has joined #openstack-neutron | 06:57 | |
| *** sbfox has quit IRC | 06:57 | |
| *** yamamoto has quit IRC | 06:58 | |
| *** skolekonov has joined #openstack-neutron | 06:59 | |
| *** kopparam has quit IRC | 07:00 | |
| *** kopparam has joined #openstack-neutron | 07:00 | |
| *** pasquier-s has joined #openstack-neutron | 07:01 | |
| *** chandankumar has quit IRC | 07:01 | |
| *** openstackgerrit has quit IRC | 07:02 | |
| *** rha has joined #openstack-neutron | 07:02 | |
| *** mitarun_ has quit IRC | 07:03 | |
| *** amuller has joined #openstack-neutron | 07:04 | |
| *** suresh12 has joined #openstack-neutron | 07:04 | |
| *** prasoon has quit IRC | 07:04 | |
| *** mitarun has joined #openstack-neutron | 07:04 | |
| *** dbite has quit IRC | 07:05 | |
| *** dbite_ has joined #openstack-neutron | 07:05 | |
| *** kopparam has quit IRC | 07:05 | |
| *** mitarun has quit IRC | 07:08 | |
| *** dbite_ has quit IRC | 07:09 | |
| *** cristov_mac has quit IRC | 07:10 | |
| *** padkrish has quit IRC | 07:10 | |
| *** matrohon has joined #openstack-neutron | 07:13 | |
| *** dgollub has joined #openstack-neutron | 07:13 | |
| *** Longgeek has joined #openstack-neutron | 07:20 | |
| *** emagana has joined #openstack-neutron | 07:20 | |
| *** Longgeek has quit IRC | 07:20 | |
| *** Longgeek has joined #openstack-neutron | 07:23 | |
| *** emagana has quit IRC | 07:24 | |
| *** tsg has quit IRC | 07:24 | |
| *** gildub has quit IRC | 07:25 | |
| *** afazekas has joined #openstack-neutron | 07:28 | |
| *** amotoki_ has joined #openstack-neutron | 07:28 | |
| *** luqas has joined #openstack-neutron | 07:29 | |
| *** yamamoto has joined #openstack-neutron | 07:30 | |
| *** Altran has joined #openstack-neutron | 07:32 | |
| *** naotok is now known as zz_naotok | 07:33 | |
| *** amotoki_ has quit IRC | 07:33 | |
| *** catohornet has joined #openstack-neutron | 07:34 | |
| *** jschwarz has joined #openstack-neutron | 07:37 | |
| amuller | ajo: morning | 07:39 |
| *** jistr has joined #openstack-neutron | 07:45 | |
| *** yamamoto has quit IRC | 07:48 | |
| *** yamamoto has joined #openstack-neutron | 07:49 | |
| *** yamamoto has quit IRC | 07:49 | |
| *** kopparam has joined #openstack-neutron | 07:49 | |
| *** yamamoto has joined #openstack-neutron | 07:49 | |
| ajo | hi amuller morning | 07:51 |
| amuller | ajo: I understand there was an intergalactic crisis while I slept | 07:51 |
| amuller | with the functional job | 07:52 |
| *** padkrish has joined #openstack-neutron | 07:52 | |
| jschwarz | INTERGALACTIC CRISIS!!! | 07:52 |
| ajo | hehehe, yes | 07:52 |
| *** safchain has joined #openstack-neutron | 07:52 | |
| *** salv-orlando has quit IRC | 07:52 | |
| ajo | but we found that system exists acutally behaved the same | 07:52 |
| ajo | actually | 07:52 |
| ajo | and kevinbenton had a patch ready: https://review.openstack.org/#/c/118225/ | 07:53 |
| ajo | so it's merged now | 07:53 |
| ajo | next events of the failure should have the system exit captured, and a stack tace | 07:53 |
| ajo | trace | 07:53 |
| *** suresh12 has quit IRC | 07:56 | |
| *** ygbo has joined #openstack-neutron | 07:56 | |
| amuller | ajo: Do you know when was the job made voting again? | 07:57 |
| amuller | kevinbenton++ | 07:57 |
| *** padkrish has quit IRC | 07:57 | |
| ajo | not sure amuller, I believe marun asked yeterday to make it non-voting again until the sys.exit / SystemExit points are unconvered | 07:57 |
| kevinbenton | amuller: not sure | 07:57 |
| kevinbenton | ajo: that patch wasn’t merged yet | 07:58 |
| kevinbenton | ajo: we wanted a few failures first | 07:58 |
| kevinbenton | https://review.openstack.org/#/c/118233/ | 07:58 |
| amuller | it's pretty weird, since Maru fixed the l3 functional test I saw that succeeding every time, I actually saw intermittent errors with a follow up patch that wasn't merged yet | 07:58 |
| amuller | I didn't think the issue was with the base patch | 07:59 |
| *** jp_at_hp has joined #openstack-neutron | 07:59 | |
| ajo | kevinbenton, and the systemexit capture? | 07:59 |
| ajo | that one was merged, right? | 07:59 |
| kevinbenton | yeah, just merged like 30 minutes ago | 07:59 |
| ajo | good good | 08:00 |
| *** karimb has joined #openstack-neutron | 08:03 | |
| *** mestery has joined #openstack-neutron | 08:03 | |
| *** afazekas has quit IRC | 08:05 | |
| *** afazekas has joined #openstack-neutron | 08:06 | |
| *** mancdaz has quit IRC | 08:08 | |
| *** cnesa9 has joined #openstack-neutron | 08:10 | |
| *** yfauser has joined #openstack-neutron | 08:11 | |
| *** yfauser has left #openstack-neutron | 08:11 | |
| *** morganfainberg is now known as morganfainberg_Z | 08:12 | |
| *** yamamoto has quit IRC | 08:13 | |
| *** yamamoto has joined #openstack-neutron | 08:14 | |
| *** emagana has joined #openstack-neutron | 08:14 | |
| *** saju_m has quit IRC | 08:18 | |
| *** yfauser has joined #openstack-neutron | 08:18 | |
| *** yfauser has quit IRC | 08:18 | |
| *** yfauser has joined #openstack-neutron | 08:18 | |
| *** yfauser has left #openstack-neutron | 08:18 | |
| *** francois_eleouet has quit IRC | 08:18 | |
| *** ZZelle has joined #openstack-neutron | 08:19 | |
| *** yfauser1 has joined #openstack-neutron | 08:19 | |
| *** emagana has quit IRC | 08:19 | |
| ZZelle | amotoki, hi | 08:19 |
| *** yfauser1 has left #openstack-neutron | 08:19 | |
| *** matrohon has quit IRC | 08:19 | |
| *** tflynn has quit IRC | 08:20 | |
| *** cnesa10 has joined #openstack-neutron | 08:20 | |
| *** cnesa9 has quit IRC | 08:22 | |
| *** mestery has quit IRC | 08:22 | |
| *** francois_eleouet has joined #openstack-neutron | 08:23 | |
| *** mestery has joined #openstack-neutron | 08:23 | |
| *** rook has joined #openstack-neutron | 08:23 | |
| trinaths | jschwarz: Hi. hru doing. | 08:25 |
| jschwarz | trinaths, great, how are you? | 08:29 |
| *** matrohon has joined #openstack-neutron | 08:32 | |
| *** saju_m has joined #openstack-neutron | 08:34 | |
| *** irenab has joined #openstack-neutron | 08:34 | |
| *** doude has joined #openstack-neutron | 08:37 | |
| *** jlibosva has joined #openstack-neutron | 08:38 | |
| *** yfauser has joined #openstack-neutron | 08:39 | |
| *** yfauser has left #openstack-neutron | 08:39 | |
| *** rook has quit IRC | 08:40 | |
| Altran | trinaths: about Your comment to 116505 - one patch is to master and 2nd is to stable/icehouse | 08:40 |
| *** prasoon has joined #openstack-neutron | 08:42 | |
| trinaths | Altran: oh okay. will check the review. | 08:42 |
| jschwarz | Altran, morning :) | 08:42 |
| trinaths | jschwarz: Doing Good. :) | 08:42 |
| Altran | jschwarz: morning :) | 08:43 |
| jschwarz | :) | 08:43 |
| *** prasoon has quit IRC | 08:43 | |
| trinaths | Altran: done | 08:44 |
| kevinbenton | amotoki: ping | 08:46 |
| *** mestery has quit IRC | 08:52 | |
| *** dave_tucker_zzz is now known as dave_tucker | 08:52 | |
| *** mestery has joined #openstack-neutron | 08:52 | |
| *** sambetts has joined #openstack-neutron | 08:53 | |
| *** mitarun has joined #openstack-neutron | 08:54 | |
| *** rotbeard has joined #openstack-neutron | 09:00 | |
| *** mwagner_lap has joined #openstack-neutron | 09:04 | |
| *** suresh12 has joined #openstack-neutron | 09:06 | |
| *** Altran1 has joined #openstack-neutron | 09:07 | |
| *** Altran1 is now known as jswiders | 09:07 | |
| *** yfauser has joined #openstack-neutron | 09:07 | |
| *** alexpilotti has joined #openstack-neutron | 09:08 | |
| *** yfauser1 has joined #openstack-neutron | 09:08 | |
| *** yfauser1 has left #openstack-neutron | 09:08 | |
| *** emagana has joined #openstack-neutron | 09:08 | |
| *** yfauser has quit IRC | 09:08 | |
| *** luqas has quit IRC | 09:09 | |
| *** Altran has quit IRC | 09:09 | |
| alexpilotti | rkukura: Hi | 09:10 |
| yamamoto | mestery: ping | 09:10 |
| *** suresh12 has quit IRC | 09:11 | |
| *** emagana has quit IRC | 09:13 | |
| *** alexpilotti has quit IRC | 09:15 | |
| *** claudiub has joined #openstack-neutron | 09:16 | |
| trinaths | amotoki: ping | 09:17 |
| *** JadnG has joined #openstack-neutron | 09:18 | |
| *** kickinz1 has joined #openstack-neutron | 09:22 | |
| *** irenab has quit IRC | 09:27 | |
| *** salv-orlando has joined #openstack-neutron | 09:28 | |
| *** roeyc has quit IRC | 09:28 | |
| *** aix has joined #openstack-neutron | 09:29 | |
| *** amotoki_ has joined #openstack-neutron | 09:29 | |
| *** geekinutah has quit IRC | 09:30 | |
| *** yamamoto has quit IRC | 09:30 | |
| *** geekinutah has joined #openstack-neutron | 09:31 | |
| *** cipcosma has joined #openstack-neutron | 09:32 | |
| *** amotoki_ has quit IRC | 09:34 | |
| *** rm_work is now known as rm_work|away | 09:37 | |
| *** prasoon has joined #openstack-neutron | 09:37 | |
| *** saju_m has quit IRC | 09:37 | |
| *** sambetts has quit IRC | 09:38 | |
| *** sambetts has joined #openstack-neutron | 09:39 | |
| *** luqas has joined #openstack-neutron | 09:40 | |
| *** yamamoto has joined #openstack-neutron | 09:49 | |
| *** prasoon_ has joined #openstack-neutron | 09:50 | |
| *** prasoon has quit IRC | 09:50 | |
| *** vdo has joined #openstack-neutron | 09:52 | |
| *** yamamoto has quit IRC | 09:54 | |
| *** doude has quit IRC | 09:58 | |
| *** baohua has quit IRC | 09:58 | |
| *** rm_work|away is now known as rm_work | 09:59 | |
| *** doude has joined #openstack-neutron | 09:59 | |
| *** saju_m has joined #openstack-neutron | 10:00 | |
| *** zhhuabj has quit IRC | 10:01 | |
| *** emagana has joined #openstack-neutron | 10:02 | |
| *** emagana has quit IRC | 10:06 | |
| *** xuhanp has quit IRC | 10:08 | |
| *** mitarun has quit IRC | 10:09 | |
| *** mitarun has joined #openstack-neutron | 10:10 | |
| *** dgollub has quit IRC | 10:11 | |
| *** doude has quit IRC | 10:12 | |
| *** rm_work is now known as rm_work|away | 10:13 | |
| *** yfauser has joined #openstack-neutron | 10:13 | |
| *** yfauser has left #openstack-neutron | 10:13 | |
| *** doude has joined #openstack-neutron | 10:14 | |
| *** mitarun has quit IRC | 10:14 | |
| *** mestery has quit IRC | 10:15 | |
| *** mestery has joined #openstack-neutron | 10:15 | |
| *** yfauser has joined #openstack-neutron | 10:17 | |
| *** yfauser has left #openstack-neutron | 10:17 | |
| *** mestery has quit IRC | 10:21 | |
| *** mestery has joined #openstack-neutron | 10:22 | |
| *** mitarun has joined #openstack-neutron | 10:23 | |
| *** mitarun has quit IRC | 10:26 | |
| *** mitarun has joined #openstack-neutron | 10:27 | |
| *** pcm_ has joined #openstack-neutron | 10:31 | |
| trinaths | can someone review this change, https://review.openstack.org/#/c/109659/. | 10:32 |
| *** mitarun has quit IRC | 10:32 | |
| *** evgenyf has joined #openstack-neutron | 10:33 | |
| *** vdo has left #openstack-neutron | 10:35 | |
| *** yamahata has quit IRC | 10:36 | |
| *** linuxgeek_ has quit IRC | 10:36 | |
| *** alexpilotti has joined #openstack-neutron | 10:42 | |
| *** pcm_ has quit IRC | 10:44 | |
| *** pcm_ has joined #openstack-neutron | 10:47 | |
| *** dgollub has joined #openstack-neutron | 10:48 | |
| *** yamamoto has joined #openstack-neutron | 10:49 | |
| *** prasoon_ has quit IRC | 10:49 | |
| *** yamamoto_ has joined #openstack-neutron | 10:51 | |
| *** jab has quit IRC | 10:53 | |
| *** yamamoto has quit IRC | 10:54 | |
| *** yamamoto_ has quit IRC | 10:56 | |
| *** emagana has joined #openstack-neutron | 10:57 | |
| *** emagana has quit IRC | 11:01 | |
| *** rook has joined #openstack-neutron | 11:06 | |
| trinaths | can someone review this change, https://review.openstack.org/#/c/109659/. | 11:09 |
| *** marun_afk has joined #openstack-neutron | 11:14 | |
| *** amotoki_ has joined #openstack-neutron | 11:15 | |
| *** marun_afk is now known as marun | 11:16 | |
| *** ihrachyshka has joined #openstack-neutron | 11:19 | |
| *** sergeysh has joined #openstack-neutron | 11:19 | |
| jschwarz | I keep trying to merge 116832 (which was approved last night) but it keep failing at the gate on non-deterministic checks... | 11:19 |
| jschwarz | My next recheck will be #3 | 11:19 |
| ZZelle | amotoki_, hi | 11:21 |
| jschwarz | Any way some core could look into this? | 11:21 |
| amotoki | ZZelle: hi | 11:21 |
| amotoki | ZZelle: I will switch my IRC client from now. | 11:22 |
| *** amotoki has quit IRC | 11:22 | |
| ZZelle | amotoki, could you have a look at https://review.openstack.org/116988 about removing some SELECT FOR UPDATE? | 11:22 |
| *** amotoki_ is now known as amotoki | 11:22 | |
| ZZelle | amotoki, could you have a look at https://review.openstack.org/116988 about removing some SELECT FOR UPDATE? | 11:23 |
| amotoki | ZZelle: will look. my review list is quite overflowed... it is in the list. | 11:24 |
| HenryG | akamyshnikova: Hi. Did you get any feedback about the oslo.db issue with load_tests? | 11:25 |
| *** ihrachyshka has quit IRC | 11:25 | |
| *** mwagner_lap has quit IRC | 11:25 | |
| *** irenab has joined #openstack-neutron | 11:25 | |
| *** prasoon has joined #openstack-neutron | 11:26 | |
| trinaths | amotoki: Hi, Consider https://review.openstack.org/#/c/109659/ too into your review list. | 11:26 |
| ZZelle | amotoki, :s | 11:26 |
| *** JayJ_ has quit IRC | 11:26 | |
| *** JayJ_ has joined #openstack-neutron | 11:27 | |
| *** yfauser has joined #openstack-neutron | 11:28 | |
| *** yfauser has left #openstack-neutron | 11:28 | |
| akamyshnikova | HenryG, Hi! I'm in process of debugging this.. They need more information. And today I see that problem not in load_tests. I run tests as they were before today and get the same error with DBConnectionError once. | 11:31 |
| HenryG | akamyshnikova: OK. Let me know if I can help. | 11:32 |
| *** JayJ_ has quit IRC | 11:32 | |
| marun | amotoki: ping | 11:32 |
| amotoki | marun: pong | 11:33 |
| amotoki | marun: morning? | 11:33 |
| akamyshnikova | HenryG, Thanks :) | 11:33 |
| marun | amotoki: afternoon :) | 11:33 |
| marun | amotoki: re: https://review.openstack.org/#/c/105563/ | 11:33 |
| marun | amotoki: I'm blocking this because it lacks functional tests and there has been zero review effort applied to the follow-on patches | 11:33 |
| marun | amotoki: I'm getting alot of pressure from cisco to ignore both those facts | 11:34 |
| marun | amotoki: I see on the review that your opinion may differ, though | 11:34 |
| *** dbite has joined #openstack-neutron | 11:35 | |
| marun | amotoki: do you think functional testing is not necessary for the patch in question? | 11:35 |
| marun | amotoki: and that the patch can stand alone without the follow-ons for the blueprint, which will definitely not make FF given how little attention they have received? | 11:35 |
| amotoki | marun: Perhaps I am the only reivewer. Good question. What I am not sure is how we can implement functional test a tool which just send a packet. | 11:36 |
| amotoki | marun: your comment is fair enough to me. | 11:36 |
| *** dave_tucker is now known as dave_tucker_zzz | 11:38 | |
| marun | amotoki: At the minimum a functional test would verify actual operation | 11:38 |
| marun | amotoki: it wouldn't have to be complex | 11:38 |
| marun | amotoki: but unit tests alone give us nothing | 11:38 |
| *** dave_tucker_zzz is now known as dave_tucker | 11:39 | |
| amotoki | marun: i got it. at least the tool needs to be called successfully, and we can create a temporary netdev to test it. Is my understanding right? | 11:40 |
| marun | amotoki: correct | 11:40 |
| marun | amotoki: Given how many other priorities we have, teaching them to write a functional test and try to get it and the follow-ons merged seemed unreasonable before FF | 11:41 |
| amotoki | marun: I hope you leave the comment in that review. It is fair if you describe the reason of -2. | 11:41 |
| marun | amotoki: I've been describing in private email but I will leave on the review as you suggest. | 11:41 |
| marun | amotoki: It wasn't helpful to you to not be clear on the review, I apologize. | 11:41 |
| amotoki | marun: I agree with you. We need to have good and same coverage for new feature. I will lower my score. | 11:42 |
| *** neeti has quit IRC | 11:43 | |
| amotoki | marun: i think it is better we clarfiy the merge criteria (per milestone?) depending on our current situation. The situation changes as time goes. | 11:44 |
| marun | amotoki: I would agree. The explanation of FPF should make it clear that pushing patches is not enough | 11:44 |
| *** trinaths has quit IRC | 11:45 | |
| *** mestery has quit IRC | 11:46 | |
| marun | amotoki: For a given blueprint to make it, all patches in the series should have received some reviewer attention and one or more reviewers should be able to agree that the feature is sufficiently implemented to make merge before FF likely. | 11:46 |
| *** k4n0 has quit IRC | 11:46 | |
| *** baoli has joined #openstack-neutron | 11:48 | |
| *** neeti has joined #openstack-neutron | 11:48 | |
| amotoki | marun: honestly there is no special reason on the blueprint except that they requested me a lot of times.... I am now focusing on community ones in neutron (+ horizon). | 11:50 |
| *** yamamoto has joined #openstack-neutron | 11:50 | |
| *** emagana has joined #openstack-neutron | 11:51 | |
| marun | amotoki: ok | 11:54 |
| *** yamamoto has quit IRC | 11:55 | |
| *** emagana has quit IRC | 11:55 | |
| *** SridharG has left #openstack-neutron | 12:00 | |
| *** flaviof_zzz is now known as flaviof | 12:00 | |
| *** mestery has joined #openstack-neutron | 12:06 | |
| *** claudiub has quit IRC | 12:06 | |
| *** irenab has quit IRC | 12:11 | |
| *** lori is now known as lori|away | 12:12 | |
| *** mestery_ has joined #openstack-neutron | 12:12 | |
| *** mestery has quit IRC | 12:13 | |
| bjornar | I am having trouble getting floating ips reachable. My router ip is reachable, but not the floating ip on the same network. I see arp replies for floating, and it has the same mac as routers, but I can not see packets sent to floating ip inside namespace. (perhaps I see the first packet of a ping-sequence...) Any clues? OVS? | 12:17 |
| *** yfried_ has quit IRC | 12:17 | |
| *** Guest26899 is now known as b3nt_pin | 12:18 | |
| *** b3nt_pin is now known as beagles | 12:18 | |
| *** jasondotstar has quit IRC | 12:19 | |
| *** jckasper_ has quit IRC | 12:19 | |
| *** diegows has joined #openstack-neutron | 12:22 | |
| rkukura | alexpilotti: Still looking for me? | 12:24 |
| alexpilotti | rkukura: hi there | 12:24 |
| rkukura | alexpilotti: What’s up? | 12:25 |
| alexpilotti | rkukura: 2 lines patch waiting for a last +2 :-) https://review.openstack.org/#/c/116505/ | 12:25 |
| alexpilotti | salv-orlando: could you please lift the -1 from ^ | 12:25 |
| alexpilotti | salv-orlando: teh Hyper-V CI reported back in the meantime | 12:26 |
| *** beagles is now known as beagles_brb | 12:26 | |
| *** mwagner_lap has joined #openstack-neutron | 12:29 | |
| *** aveiga has joined #openstack-neutron | 12:29 | |
| *** yamamoto has joined #openstack-neutron | 12:31 | |
| *** JayJ_ has joined #openstack-neutron | 12:33 | |
| rkukura | alexpilotti: Gave my +2, will wait a bit for salv-orlando to remove his -1 and give +A | 12:34 |
| *** kopparam has quit IRC | 12:34 | |
| salv-orlando | alexpilotti: no I don’t because I’m a horrible person | 12:35 |
| *** mestery has joined #openstack-neutron | 12:35 | |
| *** kopparam has joined #openstack-neutron | 12:35 | |
| *** mestery_ has quit IRC | 12:35 | |
| *** rpothier has joined #openstack-neutron | 12:35 | |
| jschwarz | Anyone know how to force recheck of the VMWare NSX CI? I tried "recheck-vmware" but it did nothing... (117142) | 12:35 |
| *** aveiga has quit IRC | 12:36 | |
| alexpilotti | salv-orlando: I knew it | 12:36 |
| alexpilotti | salv-orlando: I’ll tell Santa Claus | 12:36 |
| *** rdo has quit IRC | 12:37 | |
| ZZelle | jschwarz, salv-orlando should know how to recheck vmware ... but he is a horrible person | 12:38 |
| *** baohua has joined #openstack-neutron | 12:38 | |
| *** rdo has joined #openstack-neutron | 12:39 | |
| jschwarz | ZZelle, CI bots are being cruel to me today. Maybe they are horrible persons as well? | 12:39 |
| *** beagles_brb is now known as beagles | 12:39 | |
| jschwarz | ZZelle, reminds me of https://www.youtube.com/watch?v=E7iU0GGVco8 XD | 12:40 |
| *** kopparam has quit IRC | 12:40 | |
| jswiders | jschwarz: wtf xD | 12:41 |
| jschwarz | XD | 12:41 |
| *** zhhuabj has joined #openstack-neutron | 12:41 | |
| jschwarz | jswiders, wait for the end, there's a storyline there | 12:41 |
| yamamoto | can anyone restore +A of https://review.openstack.org/#/c/113166/, which was lost due to a rebase? | 12:42 |
| *** yfauser has joined #openstack-neutron | 12:43 | |
| *** yfauser has left #openstack-neutron | 12:43 | |
| *** emagana has joined #openstack-neutron | 12:45 | |
| *** neeti has quit IRC | 12:46 | |
| *** heyongli has joined #openstack-neutron | 12:47 | |
| *** dave_tucker is now known as dave_tucker_zzz | 12:49 | |
| *** emagana has quit IRC | 12:49 | |
| *** claudiub has joined #openstack-neutron | 12:50 | |
| *** jckasper has joined #openstack-neutron | 12:50 | |
| *** jckasper_ has joined #openstack-neutron | 12:51 | |
| *** xuhanp has joined #openstack-neutron | 12:52 | |
| *** stanzgy has quit IRC | 12:54 | |
| *** jckasper has quit IRC | 12:55 | |
| rkukura | yamamoto: Done | 12:57 |
| *** irenab has joined #openstack-neutron | 12:58 | |
| yamamoto | rkukura: thank you! | 12:58 |
| *** claudiub has quit IRC | 12:59 | |
| rkukura | yamamoto: I did add one nit comment, which you might want to address in a different patch. | 12:59 |
| *** oreillyd has joined #openstack-neutron | 12:59 | |
| *** dbite has quit IRC | 12:59 | |
| *** tongli has joined #openstack-neutron | 13:00 | |
| *** claudiub has joined #openstack-neutron | 13:00 | |
| yamamoto | rkukura: sounds like a valid concern, thank you. replied in the review | 13:03 |
| mestery | yamamoto: pong | 13:05 |
| yamamoto | mestery: pang | 13:06 |
| mestery | yamamoto: What can I help you with? | 13:06 |
| yamamoto | mestery: i wanted to ask you to restore +A after a rebase but rkukura kindly has done it. thank you | 13:07 |
| mestery | yamamoto: Excellent, glad rkukura could help in my abscensce :) | 13:08 |
| *** mitarun has joined #openstack-neutron | 13:09 | |
| marun | mestery: can you push https://review.openstack.org/#/c/118233/ | 13:10 |
| marun | mestery: we have enough logs to work on a fix | 13:10 |
| mestery | marun: Will do sir | 13:11 |
| marun | mestery: danke! | 13:11 |
| mestery | marun: done! | 13:11 |
| *** aveiga has joined #openstack-neutron | 13:13 | |
| *** amveiga has joined #openstack-neutron | 13:13 | |
| *** yfried_ has joined #openstack-neutron | 13:14 | |
| *** amveiga has quit IRC | 13:15 | |
| *** kbringard has joined #openstack-neutron | 13:15 | |
| *** xuhanp has quit IRC | 13:23 | |
| salv-orlando | obondarev: I am sorry it was a bit confusing reviewing https://review.openstack.org/#/c/117913/ I have now stacked all the patches for reorganizing migrations - there are 3 patches and the series starts at https://review.openstack.org/#/c/112732 | 13:23 |
| salv-orlando | garyk: ^^ | 13:24 |
| *** thomasem has joined #openstack-neutron | 13:24 | |
| *** annegent_ has joined #openstack-neutron | 13:26 | |
| jschwarz | salv-orlando, any chance you know how to retrigger the vmware CI? | 13:26 |
| marun | salv-orlando: how to see the pass/fail rate for a given job? | 13:26 |
| salv-orlando | jschwarz: the CI should leave a comment telling you how to do that… did you receive such somment? | 13:27 |
| *** dkehn_ has joined #openstack-neutron | 13:27 | |
| salv-orlando | the command is vmware-recheck-patch | 13:27 |
| marun | salv-orlando: trying to figure out whether it makes sense to rush a skip for the failing functional test or whether bouncing queued jobs wouldn't be worth it due to periodic nature of failure | 13:27 |
| jschwarz | salv-orlando, Nope. I went to the site somewhere and ran "recheck-vmware" like it said but it did nothing | 13:27 |
| salv-orlando | marun: graphite.openstack.org - ever used it? | 13:27 |
| salv-orlando | use the hit count metric | 13:27 |
| marun | salv-orlando: ok | 13:27 |
| salv-orlando | recheck-vmware caused us a lot of trouble | 13:27 |
| marun | salv-orlando: haven't used it before | 13:28 |
| salv-orlando | where did you find that comment, jschwarz? | 13:28 |
| jschwarz | trouble? | 13:28 |
| salv-orlando | yes because it also triggers upstream checks | 13:28 |
| salv-orlando | and you don’t want to recheck upstream if jenkins is failed | 13:28 |
| jschwarz | salv-orlando, the test's failure linked be here: http://208.91.1.172/logs/neutron/117142/5/416422/ | 13:28 |
| salv-orlando | so we changed the recheck command | 13:28 |
| jschwarz | salv-orlando, then the wiki here https://wiki.openstack.org/wiki/NovaVMware/Minesweeper specifies recheck-vmware | 13:29 |
| salv-orlando | jschwarz: thanks I’ll amend it | 13:29 |
| *** signed8bit has joined #openstack-neutron | 13:29 | |
| jschwarz | salv-orlando, thank you :) will run vmware-recheck-patch | 13:29 |
| marun | salv-orlando: how to find hit count? | 13:29 |
| *** signed8bit has quit IRC | 13:29 | |
| *** signed8bit has joined #openstack-neutron | 13:30 | |
| salv-orlando | jschwarz: your failure is one that I need to whitelist because it’s a problem that from time to time appears on our infrastructure where we use nested virtualization (it’s openstack!) | 13:30 |
| salv-orlando | jschwarz: http://208.91.1.172/logs/neutron/117142/5/416422/logs/screen-q-svc.txt.gz#_2014-09-02_02_03_47_123 | 13:30 |
| jschwarz | salv-orlando, aye - that's why I wanted to trigger a recheck | 13:31 |
| jschwarz | :) | 13:31 |
| zilberstein | hello #openstack-neutron | 13:32 |
| salv-orlando | marun: did you already select the job’s stats | 13:32 |
| zilberstein | I created and assigned floating IP. I can ping fixed IP, but not floating one. What could be the reason ? | 13:32 |
| *** julim has joined #openstack-neutron | 13:32 | |
| zilberstein | Ther's no SNAT/DNAT iptables rules | 13:32 |
| *** tomoe_ has quit IRC | 13:33 | |
| zilberstein | Isnt that strange ? | 13:33 |
| *** tomoe_ has joined #openstack-neutron | 13:33 | |
| * zilberstein would appreciate any hints on how to make floating IP reachable from outside | 13:35 | |
| salv-orlando | marun: btw, graphite will give you hit counts on a time scale of your choice for failure and success. | 13:35 |
| salv-orlando | if you’re looking at a simple % over a period of time maybe it’s better to use logstash | 13:36 |
| *** lazy_prince is now known as killer_prince | 13:36 | |
| *** seizadi has joined #openstack-neutron | 13:36 | |
| *** tomoe_ has quit IRC | 13:38 | |
| *** emagana has joined #openstack-neutron | 13:39 | |
| *** dkehn_ is now known as dkehnx | 13:39 | |
| *** mitarun has quit IRC | 13:41 | |
| *** mitarun has joined #openstack-neutron | 13:42 | |
| *** heyongli has quit IRC | 13:42 | |
| *** emagana has quit IRC | 13:44 | |
| *** dave_tucker_zzz is now known as dave_tucker | 13:44 | |
| *** mitarun has quit IRC | 13:46 | |
| *** JayJ_ has quit IRC | 13:49 | |
| *** JayJ_ has joined #openstack-neutron | 13:50 | |
| *** lnxnut has joined #openstack-neutron | 13:51 | |
| *** dbite has joined #openstack-neutron | 13:52 | |
| salv-orlando | mestery: ajo and shihanzhang should submit a new patch set for add-ipset-to-security (https://review.openstack.org/#/c/111877/) today. This will leave us realistically too little for reviewing. So that has to be a FFE candidate for me. In the meanwhile, I seem to not see any other community relevant blueprint close enough to merge. So I’m thinking of dedicating my efforts either to | 13:53 |
| salv-orlando | https://blueprints.launchpad.net/neutron/+spec/agent-child-processes-status or https://blueprints.launchpad.net/neutron/+spec/tenant-delete | 13:53 |
| salv-orlando | the thing with the latter is that it gives neutron admin access to keystone - from what I gather, and I’m not sure if that’s a good idea or not. | 13:53 |
| salv-orlando | I mean I think not but I can be convinced otherwise. | 13:54 |
| *** xuhanp has joined #openstack-neutron | 13:54 | |
| salv-orlando | mestery: do you have any other suggestion? | 13:54 |
| salv-orlando | obviously if you want I can suggest you a blueprint to review ;) | 13:54 |
| *** sbfox has joined #openstack-neutron | 13:54 | |
| *** seizadi has quit IRC | 13:54 | |
| *** r-daneel has joined #openstack-neutron | 13:54 | |
| *** sc68cal_ is now known as sc68cal | 13:55 | |
| *** irenab has quit IRC | 13:55 | |
| ajo | salv-orlando, I talked with him, and he will submit tomorrow morning, we were discussing the details | 13:55 |
| ajo | I'm working on addressing all the remaining comments for the SG RPC refactor | 13:55 |
| ajo | which may be finished by tonight | 13:55 |
| salv-orlando | ajo: I honestly thought that merged. | 13:57 |
| salv-orlando | ping me when you push it. | 13:57 |
| salv-orlando | we need to ensure it’s approved by tomorrow | 13:57 |
| ajo | salv-orlando, yes.. :/ , thank you, I will | 13:57 |
| *** marun has quit IRC | 13:59 | |
| *** jobewan has joined #openstack-neutron | 13:59 | |
| *** amuller_ has joined #openstack-neutron | 14:00 | |
| *** amuller has quit IRC | 14:01 | |
| *** marun has joined #openstack-neutron | 14:01 | |
| ajo | salv-orlando, there's a suggestion from amotoki in favor of removing the "enhanced_rpc " setting | 14:02 |
| ajo | since we can auto-detect an old version of the server side RPC, and fall back, I suppose it's not needed | 14:03 |
| ajo | if we find any bug, we will just fix it, as usual, | 14:03 |
| ajo | I see no reason now to have a manual override to the old rpc version | 14:03 |
| ajo | salv-orlando, what do you think about this? | 14:03 |
| salv-orlando | what do you mean by manual override? like you do not want to increase anymore the RPC version? | 14:05 |
| ajo | no | 14:05 |
| ajo | at this moment, we have a flag in config file | 14:05 |
| ajo | to enable/disable the usage of the new rpc | 14:05 |
| ajo | enabled by default | 14:05 |
| ajo | on the agent side | 14:06 |
| salv-orlando | so you think that would do the same as versioning? | 14:06 |
| ajo | so the agent could target the old rpc, or the new rpc | 14:06 |
| *** jobewan has quit IRC | 14:06 | |
| *** chuckC has quit IRC | 14:06 | |
| ajo | via versioning, we can detect if the new function is available, and use it | 14:06 |
| ajo | or, fall back to the old one | 14:06 |
| ajo | this is in the code already | 14:06 |
| *** jobewan has joined #openstack-neutron | 14:06 | |
| *** openstackgerrit has joined #openstack-neutron | 14:07 | |
| *** amotoki has quit IRC | 14:07 | |
| ajo | let me point you to the setting | 14:07 |
| *** haleyb has joined #openstack-neutron | 14:07 | |
| salv-orlando | ajo: I know where it is | 14:07 |
| *** prad has joined #openstack-neutron | 14:07 | |
| ajo | ok, so the question is, | 14:07 |
| ajo | do this setting make sense anymore with the auto-detection? | 14:07 |
| ajo | why would we want to manually force the use of the old rpc version? | 14:07 |
| salv-orlando | ajo: enable_enhanced_rpc never made sense for me. | 14:08 |
| ajo | ok, that's a +1 | 14:08 |
| ajo | so I'm removing it | 14:08 |
| salv-orlando | I accepted the comment I made initially that this was introduced to give an option to run rpcs the old way | 14:08 |
| *** tsg has joined #openstack-neutron | 14:08 | |
| ajo | ok, sorry salv-orlando I didn't remember | 14:08 |
| salv-orlando | while I saiid that I saw no reasons for which somebody would want to run a RPC which is an order of magnitude slower | 14:08 |
| salv-orlando | and test coverage we have in place ensures the new RPC is not less reliable than the current one. | 14:09 |
| ajo | ripping it out then... | 14:09 |
| ajo | I'm find the reason of a failing unit test, | 14:09 |
| salv-orlando | ajo: I’m ok with it | 14:09 |
| ajo | not sure if it came by hanzhang changes or, via rebase | 14:09 |
| openstackgerrit | Mathieu Rohon proposed a change to openstack/neutron: make delete_router sends delete_port to core_plugin https://review.openstack.org/116924 | 14:10 |
| jschwarz | ajo++ | 14:10 |
| ajo | ahh, previous patchset with master rebase don't blow up the unit tests | 14:12 |
| ajo | so it must have been something new | 14:12 |
| *** mitarun has joined #openstack-neutron | 14:12 | |
| *** sgordon_ has joined #openstack-neutron | 14:13 | |
| salv-orlando | ajo: it’s printing all chain names separated by a pipe | 14:13 |
| ajo | salv-orlando, where, what? | 14:13 |
| salv-orlando | (OUTPUT|POSTROUTING|PREROUTING|float-snat|snat) | 14:13 |
| salv-orlando | http://logs.openstack.org/76/111876/31/check/gate-neutron-python27/ce1db65/console.html#_2014-09-02_02_36_56_908 | 14:14 |
| ajo | Ah, yes | 14:14 |
| salv-orlando | the ut failure I mean | 14:14 |
| ajo | it's failing the match to a regular expression | 14:14 |
| ajo | I found the differences already | 14:14 |
| salv-orlando | I think that is what’s making it fail | 14:14 |
| ajo | salv-orlando, there are a couple of rules missing | 14:14 |
| ajo | compared to the regular expression that it must match | 14:15 |
| ajo | it looks like something changed from patchset 30 to 31 made it happen | 14:15 |
| ajo | so I'm going to replay the changes one by one while testing | 14:15 |
| ajo | running: git review -m 111876,30 | fpaste | 14:16 |
| ajo | -> http://ur1.ca/i3yiq | 14:16 |
| *** mitarun has quit IRC | 14:17 | |
| *** lori|away is now known as lori | 14:17 | |
| *** killer_prince is now known as lazy_prince | 14:18 | |
| *** haleyb_ has joined #openstack-neutron | 14:18 | |
| *** otherwiseguy has joined #openstack-neutron | 14:18 | |
| ajo | aha | 14:20 |
| ajo | found the source! | 14:20 |
| ajo | I believe... checking | 14:21 |
| mestery | salv-orlando: Your thinking sounds good to me. Also, the L3 HA stuff, how close is that? I think that one looks like it should merge this week yet, what do you think? | 14:21 |
| *** leenheer has joined #openstack-neutron | 14:24 | |
| ajo | salv-orlando, what makes the UT fail, is the change from .add to .update in the sets (remote_group_ids & cur_group_ids) http://paste.fedoraproject.org/130403/14096673/raw/ | 14:24 |
| *** bvandenh has quit IRC | 14:25 | |
| salv-orlando | mestery: I have not looked at it enough. markmcclain is following it. | 14:25 |
| salv-orlando | ajo: cool. I guess the solution is not super difficult? | 14:25 |
| mestery | salv-orlando: Yes, makes sense | 14:25 |
| mestery | thanks salv-orlando! | 14:25 |
| ajo | salv-orlando, yes, but I don't find the difference between .add / :update here, I'd like to understand what's happening exactly | 14:25 |
| ajo | (on it) | 14:25 |
| *** jistr has quit IRC | 14:26 | |
| ajo | aahhh | 14:26 |
| ajo | ok | 14:26 |
| ajo | he iterated over the "update" group using .update... | 14:27 |
| ajo | so, iteration out + .update, let's test.. | 14:27 |
| *** emagana has joined #openstack-neutron | 14:27 | |
| *** jistr has joined #openstack-neutron | 14:28 | |
| ajo | aha! that was it | 14:28 |
| *** tsg has quit IRC | 14:28 | |
| *** emagana has quit IRC | 14:31 | |
| *** mestery_ has joined #openstack-neutron | 14:31 | |
| *** yamahata has joined #openstack-neutron | 14:31 | |
| *** trinaths has joined #openstack-neutron | 14:31 | |
| *** SridharG has joined #openstack-neutron | 14:32 | |
| *** mestery has quit IRC | 14:33 | |
| *** trinaths_afk has joined #openstack-neutron | 14:34 | |
| *** sballe has joined #openstack-neutron | 14:35 | |
| *** tomoe_ has joined #openstack-neutron | 14:35 | |
| *** mestery_ is now known as mestery | 14:35 | |
| openstackgerrit | Miguel Angel Ajo proposed a change to openstack/neutron: Refactor security group rpc call https://review.openstack.org/111876 | 14:36 |
| *** trinaths has quit IRC | 14:37 | |
| *** trinaths_afk is now known as trinaths | 14:37 | |
| ajo | ^ only addressed the UT failure, working now into all the comments @ patchset 30/31 | 14:37 |
| openstackgerrit | Evgeny Fedoruk proposed a change to openstack/neutron: Radware LBaaS v2 driver https://review.openstack.org/113525 | 14:37 |
| openstackgerrit | Arvind Somya proposed a change to openstack/neutron: ML2 Type Driver refactor part 3 https://review.openstack.org/115151 | 14:39 |
| *** mspreitz has joined #openstack-neutron | 14:41 | |
| *** jistr has quit IRC | 14:42 | |
| trinaths | pcm_, Hi | 14:42 |
| *** jistr has joined #openstack-neutron | 14:43 | |
| openstackgerrit | Miguel Angel Ajo proposed a change to openstack/neutron: Implements the ProcessMonitor in the dhcp_agent and dnsmasq driver https://review.openstack.org/115935 | 14:43 |
| pcm_ | trinaths: hi | 14:43 |
| trinaths | pcm_: Can you elobarate your comments please. | 14:44 |
| *** kakuma has quit IRC | 14:44 | |
| mestery | salv-orlando: Per ttx, we need to have all reviews in-flight tomorrow if we want them to land in Juno-3. I've moved security group refactor to high in anticipation of it needing an FFE. | 14:44 |
| mestery | salv-orlando: FYI | 14:44 |
| pcm_ | trinaths: Which bug #? | 14:44 |
| trinaths | review.openstack.org/109659 | 14:45 |
| trinaths | pcm_, sent you a mail on this | 14:45 |
| openstackgerrit | Miguel Angel Ajo proposed a change to openstack/neutron: Implements the ProcessMonitor in the dhcp_agent and dnsmasq driver https://review.openstack.org/115935 | 14:45 |
| ajo | now, really back to the SG RPC | 14:45 |
| pcm_ | trinaths: let me look... | 14:45 |
| ajo | mestery, thanks | 14:46 |
| ZZelle | marun, i updated https://review.openstack.org/116988 with a bug reference | 14:46 |
| *** nlahouti has joined #openstack-neutron | 14:46 | |
| *** mitarun has joined #openstack-neutron | 14:46 | |
| salv-orlando | mestery: ttx’s communication was the reason for me contacting you. | 14:47 |
| ajo | mestery, I hope I manage to leave it in good state by tonight, but it's good to be ready if FFE was needed | 14:47 |
| trinaths | pcm_, okay | 14:47 |
| salv-orlando | ajo: I think you’ve never experienced an openstack merge freeze marathon? | 14:47 |
| *** jswiders has left #openstack-neutron | 14:47 | |
| pcm_ | trinaths: Sure. The code calls super() for delete_firewall(). It is much preferable, if the specific exceptions that the method can raise, be caught, instead of the generic Exception | 14:47 |
| *** shakamunyi has joined #openstack-neutron | 14:48 | |
| ajo | salv-orlando, ehhh, more or less, but didn't have so much code on 'my plate' :] | 14:48 |
| salv-orlando | it’s a bit like a rave. With the only difference that the only music you’ll hear is that of your fingers hitting the keyboard | 14:48 |
| pcm_ | trinaths: With Exception, if an unexpected exception occurs, it gets masked (especially since all that is done is a log message, w/o any exception info) | 14:48 |
| ajo | I missed FF for an early implementation of the agent-child-status stuff, during icehouse, .. then one of my daughter was born, so I got a bit disconnected for a while | 14:49 |
| ajo | '''''':D salv-orlando :D | 14:49 |
| pcm_ | trinaths: So, if you can catch the specific exceptions that can be thrown, that would be much preferred. | 14:49 |
| trinaths | pcm_,:okay. Here I'm using neutron client here. | 14:49 |
| trinaths | pcm_, "sepcific exception" means? | 14:49 |
| ajo | salv-orlando, I believe I didn't experience it in full. ':) | 14:50 |
| pcm_ | trinaths: Does the call to delete_firewall() use the client? | 14:50 |
| trinaths | pcm_, yes. it sends this call to crd | 14:51 |
| jschwarz | salv-orlando, that's what earphones are for ;-) | 14:51 |
| pcm_ | trinaths: I see that in other places, where you call self._client.FOO(), but in this case you are calling the parent delete_firewall(), which I guess is calling the mixin function (Line 201). | 14:53 |
| *** padkrish has joined #openstack-neutron | 14:53 | |
| pcm_ | trinaths: Is that also using the client? | 14:53 |
| salv-orlando | jschwarz: yes earphones and death metal are recommended for feature freeze time | 14:53 |
| salv-orlando | also feature freeze is where reviewers stop nitpicking. | 14:53 |
| jschwarz | salv-orlando, so I guess you're not a Britney Spears fan? ;-) | 14:54 |
| trinaths | pcm_,: oh. at L201, its not using the client. | 14:54 |
| *** leenheer has quit IRC | 14:54 | |
| salv-orlando | things like call this variable fred instead of bob or add a comma here are not allowed anymore | 14:54 |
| trinaths | pcm_, its just a DB based delete. | 14:54 |
| salv-orlando | they can be fixed with followup patches | 14:54 |
| ajo | salv-orlando++ death-metal works the best | 14:54 |
| salv-orlando | jschwarz: I would love to see Britney Spears do death metal | 14:55 |
| ajo | lol | 14:55 |
| trinaths | :) | 14:55 |
| pcm_ | trinaths: Right, so that exception handler is checking for a generic Exception, and not specific exceptions that could be thrown. | 14:55 |
| ajo | It'd be all an experience | 14:55 |
| trinaths | pcm_: okay | 14:55 |
| *** tsg has joined #openstack-neutron | 14:55 | |
| jschwarz | salv-orlando, Challenge accepted: https://www.youtube.com/watch?v=8v0ENscgHIo | 14:55 |
| *** carl_baldwin has joined #openstack-neutron | 14:56 | |
| jschwarz | ajo & | 14:56 |
| jschwarz | ^ | 14:56 |
| *** chuckC has joined #openstack-neutron | 14:56 | |
| *** zhipeng has joined #openstack-neutron | 14:58 | |
| salv-orlando | jschwarz: I think that it is more than acceptable | 14:58 |
| jschwarz | salv-orlando, I live to serve | 14:58 |
| trinaths | pcm_, what specific exception do we expect here? its a DB error. as per the comment, do we save_and_reraise it? | 14:59 |
| ajo | lol jschwarz | 14:59 |
| ajo | ok, I need to AFK for a while, I'll be back in 1h | 14:59 |
| jschwarz | ajo, good night | 14:59 |
| jschwarz | (I won't see you again probably) | 14:59 |
| openstackgerrit | Salvatore Orlando proposed a change to openstack/neutron: Remove logic for conditional migrations https://review.openstack.org/117913 | 15:01 |
| *** skolekonov has quit IRC | 15:01 | |
| pcm_ | trinaths: Depends on your intent. Sounds like you want to just ignore an log the exception. | 15:01 |
| *** diegows has quit IRC | 15:03 | |
| trinaths | pcm_, Are there any specific exceptions for this? | 15:03 |
| pcm_ | trinaths: Looking at the mixin class, it calls one() which can return NoResultFound or MultipleResultsFound. I suspect, you'd only see the former, so you could catch that one. | 15:03 |
| *** yamahata has quit IRC | 15:03 | |
| pcm_ | trinaths: Likewise, the log could state that the delete failed as entry not found. | 15:04 |
| *** yamahata has joined #openstack-neutron | 15:04 | |
| jschwarz | bye all | 15:04 |
| *** jschwarz has quit IRC | 15:04 | |
| *** gongysh has joined #openstack-neutron | 15:04 | |
| *** saju_m has quit IRC | 15:05 | |
| *** shakamunyi has quit IRC | 15:07 | |
| *** leenheer has joined #openstack-neutron | 15:08 | |
| *** sballe_ has joined #openstack-neutron | 15:08 | |
| *** xuhanp has quit IRC | 15:08 | |
| *** sballe has quit IRC | 15:08 | |
| *** flaviof is now known as flaviof_zzz | 15:09 | |
| *** gongysh has quit IRC | 15:09 | |
| *** tomoe_ has quit IRC | 15:11 | |
| *** yamahata has quit IRC | 15:11 | |
| *** shakamunyi has joined #openstack-neutron | 15:11 | |
| *** mspreitz_ has joined #openstack-neutron | 15:12 | |
| trinaths | pcm_, got it. thanks for review. will commit a revised version. | 15:12 |
| openstackgerrit | Rajeev Grover proposed a change to openstack/neutron: Fix interface IP address for DVR with gateway https://review.openstack.org/118378 | 15:14 |
| *** markmcclain has joined #openstack-neutron | 15:15 | |
| *** markmcclain has quit IRC | 15:16 | |
| *** mspreitz has quit IRC | 15:16 | |
| *** sgordon_ has quit IRC | 15:16 | |
| *** stefanb has joined #openstack-neutron | 15:16 | |
| *** leenheer has quit IRC | 15:17 | |
| *** markmcclain has joined #openstack-neutron | 15:18 | |
| *** flaviof_zzz is now known as flaviof | 15:19 | |
| *** jorgem has joined #openstack-neutron | 15:19 | |
| *** yeungp has joined #openstack-neutron | 15:19 | |
| *** matrohon has quit IRC | 15:20 | |
| *** yfauser has joined #openstack-neutron | 15:20 | |
| *** yfauser has left #openstack-neutron | 15:20 | |
| *** zhhuabj has quit IRC | 15:21 | |
| nlahouti | salv-orlando: Hi, do you have a minute? | 15:27 |
| *** simon-AS559 has quit IRC | 15:27 | |
| *** seizadi has joined #openstack-neutron | 15:27 | |
| *** emagana has joined #openstack-neutron | 15:27 | |
| *** baohua has quit IRC | 15:27 | |
| *** emagana has quit IRC | 15:28 | |
| *** emagana has joined #openstack-neutron | 15:28 | |
| salv-orlando | nlahouti: how can I help you? | 15:29 |
| *** SridharG has quit IRC | 15:30 | |
| salv-orlando | marun: can’t find the bug for functional failures… need for a recheck. Can you quickly remind me? | 15:31 |
| nlahouti | salv-orlando: You reviewed https://review.openstack.org/#/c/111761/ and it needs approval as the parent patch already merged. can you please approve it | 15:31 |
| marun | salv-orlando: coming up | 15:31 |
| marun | salv-orlando: https://bugs.launchpad.net/neutron/+bug/1364171 | 15:31 |
| salv-orlando | nlahouti: did I ever approve 111761? | 15:31 |
| marun | salv-orlando: I've broken the job for a different reason (neverending) | 15:31 |
| marun | salv-orlando: posting a fix now | 15:31 |
| marun | salv-orlando: https://review.openstack.org/#/c/118380/ | 15:32 |
| salv-orlando | marun: no worries. UoYou’re allowed to break everything. | 15:32 |
| *** networkstatic has joined #openstack-neutron | 15:32 | |
| *** amuller__ has joined #openstack-neutron | 15:33 | |
| *** mspreitz has joined #openstack-neutron | 15:33 | |
| salv-orlando | nlahouti: ah you want it approved because somebody else approved the parent patch and it need to be approved for a sort of atomicity? | 15:33 |
| *** dbite_ has joined #openstack-neutron | 15:34 | |
| *** mspreitz_ has quit IRC | 15:34 | |
| trinaths | pcm_, sent you a mail. can you check that once. | 15:34 |
| nlahouti | salv-orlando: you reviewed it multiple times. All I'm asking to review | 15:34 |
| *** dbite_ has quit IRC | 15:34 | |
| salv-orlando | nlahouti: ah ok… you actually wrote “approve" | 15:34 |
| *** dbite_ has joined #openstack-neutron | 15:35 | |
| nlahouti | salv-orlando: if nothing to address in the review would be great if you can approve it. | 15:35 |
| salv-orlando | nlahouti: I’m working on reviewing 2 other blueprints now. In a few hours I should have time to review it. | 15:35 |
| salv-orlando | nlahouti: otherwise your best targets are emagana and garyk who approved the base DFA patch. | 15:36 |
| nlahouti | salv-orlando: I'm grateful for your time. | 15:36 |
| *** amuller_ has quit IRC | 15:37 | |
| *** dbite has quit IRC | 15:37 | |
| emagana | nlahouti: I am around and I just finish another review, I could spend some time on the DFA ones. | 15:37 |
| nlahouti | salv-orlando: since you reviewed it before and know about the extension framework discussion I asked you :) | 15:38 |
| nlahouti | emagana: hi, thanks a lot. really appreciate it. | 15:38 |
| lazy_prince | morgabra: ping | 15:38 |
| salv-orlando | nlahouti: sure. I was proposing alternatives as you might be able to find core reviewers with a lower load | 15:38 |
| *** changbl has joined #openstack-neutron | 15:38 | |
| *** pasquier-s has quit IRC | 15:39 | |
| nlahouti | salv-orlando: I know. | 15:39 |
| lazy_prince | morgabra: would like to talk about https://github.com/rackerlabs/ironic-neutron-plugin/ if you are free.. | 15:39 |
| *** amuller__ has quit IRC | 15:40 | |
| *** diga has joined #openstack-neutron | 15:40 | |
| *** amuller__ has joined #openstack-neutron | 15:40 | |
| *** JayJ_ has quit IRC | 15:41 | |
| *** mitarun has quit IRC | 15:42 | |
| *** mitarun has joined #openstack-neutron | 15:43 | |
| *** padkrish has quit IRC | 15:44 | |
| *** evgenyf has quit IRC | 15:45 | |
| *** shakamunyi has quit IRC | 15:46 | |
| openstackgerrit | Itzik Brown proposed a change to openstack/neutron: Adds an option to enable broadcast replies to Dnsmasq https://review.openstack.org/118277 | 15:46 |
| *** haleyb_ has quit IRC | 15:47 | |
| openstackgerrit | Trinath Somanchi proposed a change to openstack/neutron: Freescale FWaaS Plugin https://review.openstack.org/109659 | 15:48 |
| *** mitarun has quit IRC | 15:48 | |
| *** radez_g0` is now known as radez | 15:49 | |
| *** rotbeard has quit IRC | 15:50 | |
| *** signed8bit has quit IRC | 15:50 | |
| enikanorov_ | salv-orlando: hi. looking at unconditional migrations patch... is there a way we can get rid of the need of having every plugin installed to run migrations? | 15:51 |
| *** seizadi has quit IRC | 15:51 | |
| enikanorov_ | salv-orlando: it seems that it goes down to head.py collecting everything db-related. I'm thinking if we can change it to directory traversal instead of direct importing | 15:52 |
| *** Longgeek has quit IRC | 15:54 | |
| enikanorov_ | that may allow us to only run migrations for the plugin that is installed | 15:54 |
| *** sleipneir012 has joined #openstack-neutron | 15:54 | |
| *** marun_ has joined #openstack-neutron | 15:55 | |
| *** diga has quit IRC | 15:56 | |
| *** padkrish has joined #openstack-neutron | 15:56 | |
| *** marun has quit IRC | 15:57 | |
| *** padkrish has joined #openstack-neutron | 15:57 | |
| *** sballe_ has quit IRC | 15:58 | |
| trinaths | pcm_, replied it | 15:58 |
| *** suresh12 has joined #openstack-neutron | 15:59 | |
| *** afazekas has quit IRC | 15:59 | |
| *** simon-AS559 has joined #openstack-neutron | 15:59 | |
| *** yamamoto has quit IRC | 16:01 | |
| *** simon-AS5591 has joined #openstack-neutron | 16:01 | |
| *** mitarun has joined #openstack-neutron | 16:01 | |
| *** julim has quit IRC | 16:01 | |
| openstackgerrit | Itzik Brown proposed a change to openstack/neutron: Adds an option to enable broadcast replies to Dnsmasq https://review.openstack.org/118277 | 16:03 |
| *** yamamoto has joined #openstack-neutron | 16:03 | |
| *** shakamunyi has joined #openstack-neutron | 16:04 | |
| *** simon-AS559 has quit IRC | 16:04 | |
| *** sballe has joined #openstack-neutron | 16:04 | |
| *** jistr has quit IRC | 16:05 | |
| *** devvesa_ has quit IRC | 16:06 | |
| *** amuller__ has quit IRC | 16:07 | |
| *** yamamoto has quit IRC | 16:08 | |
| *** rotbeard has joined #openstack-neutron | 16:08 | |
| *** sleipneir012 has quit IRC | 16:08 | |
| openstackgerrit | Robert Kukura proposed a change to openstack/neutron: ML2: Driver API changes for hierarchical port binding https://review.openstack.org/115110 | 16:10 |
| openstackgerrit | Robert Kukura proposed a change to openstack/neutron: ML2: DB changes for hierarchical port binding https://review.openstack.org/116122 | 16:10 |
| openstackgerrit | Robert Kukura proposed a change to openstack/neutron: ML2: Hierarchical port binding https://review.openstack.org/116209 | 16:10 |
| *** sgordon_ has joined #openstack-neutron | 16:10 | |
| *** padkrish has quit IRC | 16:11 | |
| *** morganfainberg_Z is now known as morganfainberg | 16:11 | |
| rkukura | Cores (and others) - reviews of the above 3 patches would really be appreciated. I believe they are ready to merge, and they complete the dynamic segments + hierarchical binding implementation. | 16:13 |
| *** annegent_ has quit IRC | 16:13 | |
| *** annegent_ has joined #openstack-neutron | 16:14 | |
| *** rha has quit IRC | 16:14 | |
| *** yfauser has joined #openstack-neutron | 16:15 | |
| *** yfauser has left #openstack-neutron | 16:15 | |
| *** mestery_ has joined #openstack-neutron | 16:16 | |
| openstackgerrit | Trinath Somanchi proposed a change to openstack/neutron: Freescale FWaaS Plugin https://review.openstack.org/109659 | 16:17 |
| *** sballe has quit IRC | 16:17 | |
| trinaths | pcm_, Done. | 16:17 |
| *** sbalukoff1 has quit IRC | 16:18 | |
| *** emagana has quit IRC | 16:19 | |
| *** padkrish has joined #openstack-neutron | 16:19 | |
| *** padkrish has quit IRC | 16:19 | |
| *** mestery has quit IRC | 16:19 | |
| *** emagana has joined #openstack-neutron | 16:19 | |
| *** padkrish has joined #openstack-neutron | 16:20 | |
| emagana | nlahouti: ping | 16:20 |
| *** shakamunyi has quit IRC | 16:20 | |
| trinaths | mestery_: Hi, can you kindly review the change https://review.openstack.org/#/c/109659/. Its improved from the last review. | 16:21 |
| mestery_ | trinaths: will have a peek sir | 16:21 |
| nlahouti | emagana: hi | 16:22 |
| mestery_ | trinaths: I'd really like SumitNaiksatam to have a look and give his blessing as well since this is a FWaaS plugin. | 16:22 |
| emagana | nlahouti: It seems that Part 2 DFA commit is blocked by https://review.openstack.org/#/c/105563/ | 16:22 |
| trinaths | mestery_: thanks sir. for CI result, its in queue with 25 patches in line. | 16:22 |
| SumitNaiksatam | mestery_: trinaths: hi | 16:23 |
| trinaths | mestery_, True, but your blessing will also help me.. :-) | 16:23 |
| SumitNaiksatam | trinaths: thanks for your deligence on this | 16:23 |
| trinaths | SumitNaiksatam: Hi Sir | 16:23 |
| nlahouti | emagana: that's correct. But part 3 and 4 are not related to part 2. | 16:23 |
| SumitNaiksatam | trinaths: and for following up on the changes suggested by akihiro | 16:24 |
| trinaths | SumitNaiksatam: I have addressed amotoki review comments and other comments. | 16:24 |
| emagana | what is the point of merging Part 3 and Part 4 if one will be missing, dont you need all of them? | 16:24 |
| SumitNaiksatam | trinaths: his last review comment was a -1 | 16:24 |
| trinaths | SumitNaiksatam: amotoki last comments on patchset 42 are also addressed in 44. | 16:24 |
| SumitNaiksatam | trinaths: if you can get a quick nod from him that will be great | 16:24 |
| *** sbalukoff has joined #openstack-neutron | 16:24 | |
| trinaths | SumitNaiksatam: its due to router_distributed config relocation | 16:25 |
| trinaths | SumitNaiksatam: now I corrected it | 16:25 |
| trinaths | SumitNaiksatam: kindly in your free time please bless me with your review. | 16:25 |
| SumitNaiksatam | trinaths: sure, but it would be great to get akihiro to validate it as well since it was his concern | 16:25 |
| *** _cjones_ has joined #openstack-neutron | 16:25 | |
| emagana | nlahouti: what is the point of merging Part 3 and Part 4 if one will be missing, dont you need all of them? (in case your missed) | 16:25 |
| anteaya | trinaths: how are your reviews going? | 16:25 |
| anteaya | trinaths: are you managing to supply useful comments on other people's patches? | 16:26 |
| trinaths | SumitNaiksatam: sure sir. will work with him tomorrow my morning (IST) | 16:26 |
| nlahouti | emagana: we need all of them eventually but part 1 and 3 and 4 be merged without 2. | 16:26 |
| *** rha has joined #openstack-neutron | 16:26 | |
| *** mestery has joined #openstack-neutron | 16:26 | |
| anteaya | emagana: so are you in favour or allowing varmour ci to comment on the sandbox again? or no? | 16:26 |
| SumitNaiksatam | trinaths: again, thanks for your deligence on this! | 16:26 |
| trinaths | anteaya: I'm reviewing the code. People send me comments and improve the code base. | 16:26 |
| anteaya | trinaths: have you talked with any core reviewers about your reviews? | 16:27 |
| emagana | anteaya: I need to review their results, just give me few minutes | 16:27 |
| anteaya | trinaths: are any core reviewers telling you that what you are doing is helpful? | 16:27 |
| anteaya | emagana: kk | 16:27 |
| emagana | nlahouti: That is not the point, the review cycles are minimal, if because Part 2 the whole thing will not work, then I will move to another commits, do you understand my point? | 16:28 |
| trinaths | anteaya: No, I did not. was struck with J-3. I did not ask any core reviewer about the quality of my review. will ask soon | 16:28 |
| emagana | nlahouti: By review cycles minimal I really mean that I dont have a lot of review cycles and I want to push for staff that will work for Juno not just for staff that will make some progress.. | 16:28 |
| anteaya | trinaths: make a point of it because I will be asking you about it again | 16:28 |
| anteaya | trinaths: everybody is struck with J3, that is the point | 16:29 |
| trinaths | anteaya: okay. How to ask them. Can I ask here, or via email? | 16:29 |
| *** mestery_ has quit IRC | 16:30 | |
| emagana | anteaya: Yes, please let vArmour to comment again, I asked them to test their CI against my testing commits | 16:30 |
| anteaya | emagana: will do, thanks for those patches | 16:30 |
| *** marun_ has quit IRC | 16:30 | |
| *** padkrish has quit IRC | 16:30 | |
| emagana | anteaya: That will tell us if the system is operational or not. | 16:30 |
| anteaya | emagana: at next week's third party meeting can you add an agenda item to inform other people about them | 16:30 |
| nlahouti | emagana: sure I understand. My point is that the code in part 3 and 4 are not related to part 2. | 16:30 |
| anteaya | emagana: it is a good direction | 16:30 |
| anteaya | emagana: I see that, and I like it | 16:31 |
| emagana | anteaya: Absolutely, I will do it, right now! :-) | 16:31 |
| anteaya | trinaths: you don't seem to have a problem asking people for reviews of your patches, I have full confidence you can find a way to ask people for reviews of your reviews | 16:31 |
| anteaya | trinaths: if you decide it is important to you | 16:31 |
| *** dfarrell07 has joined #openstack-neutron | 16:32 | |
| anteaya | emagana: thanks | 16:32 |
| *** dsneddon has joined #openstack-neutron | 16:32 | |
| trinaths | anteaya: :-) | 16:32 |
| emagana | nlahouti: that does not make sense at all! | 16:33 |
| trinaths | anteaya: really great to work with you. | 16:33 |
| *** safchain has quit IRC | 16:34 | |
| emagana | nlahouti: Those patches said that are realted to this BP: ml2-mechanism-driver-for-cisco-dfa | 16:34 |
| emagana | nlahouti: Now you are telling us that they are not!!!! Something is wrong then!!! | 16:34 |
| *** snowgust has joined #openstack-neutron | 16:35 | |
| nlahouti | emagana: the whole solution needs all the pieces to work (all part of MD - DFA + horizon + VPD which is part 2 is blocked by it). | 16:35 |
| *** padkrish has joined #openstack-neutron | 16:35 | |
| *** BillTheKat has joined #openstack-neutron | 16:36 | |
| nlahouti | emagana: part 2 code sends vendor-specific OUI info from MD to the VPD agent. | 16:36 |
| anteaya | trinaths: well I'll be honest with you, I find working with you exhausting, you have all kinds of energy to ensure your work is accomplished and very little time to support the work of others | 16:36 |
| anteaya | trinaths: you are a net drain on my time | 16:36 |
| trinaths | anteaya: :-( | 16:37 |
| nlahouti | emagana: what I was referring to that part 3 and part 4 are not related to part 2 one is dealing with extensions and the other one deals with config profile services. | 16:38 |
| *** xmltok has joined #openstack-neutron | 16:38 | |
| emagana | nlahouti: Then you need different BPs | 16:38 |
| *** yamamoto has joined #openstack-neutron | 16:38 | |
| *** otherwiseguy has quit IRC | 16:39 | |
| *** jlibosva has quit IRC | 16:39 | |
| emagana | nlahouti: Did you discuss with mestery your approach, it seems unfair to me for the rest of the developers! | 16:39 |
| nlahouti | emagana: we already filed 5 BP for this feature. | 16:39 |
| *** jp_at_hp has quit IRC | 16:39 | |
| emagana | nlahouti: then you need to point your commits to the right BPs | 16:39 |
| trinaths | anteaya: If I really have energy to ensure my work done, I might not have been here struggling for J-3 | 16:40 |
| trinaths | anteaya: I'm doing reviews as a code walk through and unit testing tests. for others. There are reviews of me which improved the code of others too. | 16:41 |
| emagana | Neutron team will need a lot of beer in Juno!!! | 16:42 |
| trinaths | emagana: :-) | 16:42 |
| nlahouti | emagana: They are pointing to : https://blueprints.launchpad.net/openstack/?searchtext=ml2-mechanism-driver-for-cisco-dfa which is for the MD | 16:42 |
| *** yamamoto has quit IRC | 16:43 | |
| *** padkrish has quit IRC | 16:43 | |
| *** pballand has joined #openstack-neutron | 16:44 | |
| nlahouti | emagana: and the spec: http://git.openstack.org/cgit/openstack/neutron-specs/tree/specs/juno/cisco-dfa-mechanismdriver.rst | 16:44 |
| *** jschwarz has joined #openstack-neutron | 16:44 | |
| *** jschwarz has quit IRC | 16:45 | |
| *** s3wong has joined #openstack-neutron | 16:45 | |
| emagana | nlahouti: I do not understand it yet. I only see three BPs, one for Neutron, One for Neutron-CLient and one for Horizon. | 16:45 |
| emagana | nlahouti: Anyway, let me ask you this, if Part2 is NOT merge, will the DFA driver work properly? | 16:46 |
| nlahouti | emagana: the other on was for extension-in-ml2 which is mereged (#89211) and the other one was the VDP | 16:46 |
| nlahouti | emagana: today I noticed that VDP BP is moved to Kilo. | 16:47 |
| nlahouti | emagana: so that code is not going to be merged for juno. | 16:47 |
| *** claudiub has quit IRC | 16:48 | |
| nlahouti | emagana: the DFA solution needs VDP BP to work | 16:48 |
| emagana | nlahouti: which is Part 2, right? | 16:49 |
| *** ygbo has quit IRC | 16:49 | |
| nlahouti | emagana: no. It is https://review.openstack.org/#/c/105563/ | 16:49 |
| emagana | nlahouti: which depends on https://review.openstack.org/#/c/105563/ right? | 16:49 |
| nlahouti | emagana: right. | 16:49 |
| emagana | then, I honestly do not see any reason why we should merge Part 2, 3 and 4 if https://review.openstack.org/#/c/105563/ is not being reviewed. | 16:50 |
| nlahouti | emagana: but MD-DFA BP, horizon BP and neutronclient are approved and codes are ready | 16:50 |
| emagana | nlahouti: I need you to understand that review cycles are critical right now... | 16:50 |
| emagana | if https://review.openstack.org/#/c/105563/ has any chances I would try to push it.. but I do not think so.. You may want to follow up with maru newby | 16:51 |
| *** tflynn has joined #openstack-neutron | 16:52 | |
| *** ivar-lazzaro has joined #openstack-neutron | 16:52 | |
| *** beagles is now known as beagles_brb | 16:52 | |
| nlahouti | emagana: I understand. But https://review.openstack.org/#/c/105563/ was under the review and now it is moved to Kilo. | 16:52 |
| emagana | Then, I believe the whole DFA staff should move to Kilo just because https://review.openstack.org/#/c/105563/ agree? | 16:54 |
| *** luqas has quit IRC | 16:55 | |
| nlahouti | emagana: But part 1 is merged and if we merged part 2 and 3 then we don't need to do all these process all over again for Kilo. | 16:55 |
| emagana | nlahouti: I need to attend a meeting for an hour or so, I should be able to discuss further later today. | 16:55 |
| *** sballe has joined #openstack-neutron | 16:55 | |
| *** suresh12 has quit IRC | 16:56 | |
| nlahouti | emagana: thx a lot for your time. Please ping me. I'll be online | 16:56 |
| *** SumitNaiksatam has quit IRC | 16:56 | |
| emagana | nlahouti: In the meantime, I would recommend you to get advise from mestery, as PTL he can provide some advising on how to proceed! | 16:56 |
| emagana | mestery: Can you comment on the DFA staff? | 16:56 |
| *** dave_tucker is now known as dave_tucker_zzz | 16:56 | |
| nlahouti | emagana: sure will do that. | 16:56 |
| *** dave_tucker_zzz is now known as dave_tucker | 16:56 | |
| *** amaretskiy has quit IRC | 16:57 | |
| *** amcrn has joined #openstack-neutron | 16:58 | |
| *** sballe_ has joined #openstack-neutron | 16:59 | |
| *** reed has joined #openstack-neutron | 16:59 | |
| mestery | emagana nlahouti: If things aren't in the merge queue by tomorrow morning, they are highly unlikely to make Juno at this point. | 17:00 |
| mestery | ttx is tagging Thursday sometime | 17:00 |
| mestery | And the queue is already at 8 hours or so, likely to get worse throughout the day. | 17:00 |
| mestery | I know rkukura is lookoing at the DFA stuff, so I've asked him to evaluate in the next few hours and reply back. | 17:00 |
| *** lazy_prince is now known as killer_prince | 17:01 | |
| nlahouti | mestery: As you know VDP is moved to Kilo. But we can have MD-DFA part1 (which is already merged) part 3 and 4 (need to be approved) | 17:01 |
| *** karimb has quit IRC | 17:01 | |
| nlahouti | mestery: Thanks a lot Kyle. | 17:02 |
| mestery | nlahouti: Got it. | 17:03 |
| *** sballe has quit IRC | 17:03 | |
| emagana | mestery: DFA depends on VDP, from my point of view the rest of the code for DFA could be merged in Kilo because it will not work at least we merge VDP. | 17:03 |
| mestery | emagana: That was my understanding as well | 17:03 |
| *** harlowja has joined #openstack-neutron | 17:04 | |
| *** sballe has joined #openstack-neutron | 17:04 | |
| nlahouti | emagana mestery: My point was to have part 3 and part 4 merged in Juno and merged part 2 for Kilo. | 17:04 |
| mestery | nlahouti: Got it | 17:05 |
| emagana | mestery: It seems that rkukura will provide more details, let's wait. | 17:05 |
| nlahouti | mestery: Because horizon BP and neutronclient depend on that merge | 17:05 |
| nlahouti | mestery: sure. | 17:05 |
| mestery | Yes, lets see what rkukura says today yet once he's looked closer | 17:05 |
| emagana | nlahouti: If I am not around just send me an email | 17:06 |
| nlahouti | emagana: sure will do that. | 17:06 |
| *** rotbeard has quit IRC | 17:06 | |
| *** sballe_ has quit IRC | 17:07 | |
| *** yamamoto has joined #openstack-neutron | 17:09 | |
| *** SumitNaiksatam has joined #openstack-neutron | 17:10 | |
| *** BillTheKat has quit IRC | 17:11 | |
| *** SridharG has joined #openstack-neutron | 17:11 | |
| *** SridharG has quit IRC | 17:11 | |
| *** yamamoto has quit IRC | 17:13 | |
| openstackgerrit | Brian Haley proposed a change to openstack/neutron: L3 Metering label as shared https://review.openstack.org/70090 | 17:14 |
| *** diegows has joined #openstack-neutron | 17:15 | |
| openstackgerrit | Sandhya Dasu proposed a change to openstack/neutron: Implements a ML2 mechanism driver for Cisco UCS Manager https://review.openstack.org/74134 | 17:15 |
| *** baoli has quit IRC | 17:18 | |
| *** changbl has quit IRC | 17:18 | |
| *** padkrish has joined #openstack-neutron | 17:20 | |
| *** sballe has quit IRC | 17:20 | |
| *** emagana has quit IRC | 17:21 | |
| *** emagana has joined #openstack-neutron | 17:22 | |
| *** emagana has quit IRC | 17:22 | |
| *** emagana has joined #openstack-neutron | 17:23 | |
| openstackgerrit | Armando Migliaccio proposed a change to openstack/neutron: Avoid auto-scheduling for distributed routers https://review.openstack.org/115754 | 17:23 |
| openstackgerrit | AARON ZHANG proposed a change to openstack/neutron: Implement full sync for cisco n1kv plugin https://review.openstack.org/113037 | 17:23 |
| *** sballe has joined #openstack-neutron | 17:24 | |
| *** suresh12 has joined #openstack-neutron | 17:25 | |
| *** dsneddon has quit IRC | 17:26 | |
| openstackgerrit | Vivekanandan Narasimhan proposed a change to openstack/neutron: Refactor the DVR scheduler to get rid of hints https://review.openstack.org/114410 | 17:27 |
| *** dsneddon has joined #openstack-neutron | 17:27 | |
| *** suresh12 has quit IRC | 17:27 | |
| *** suresh12 has joined #openstack-neutron | 17:27 | |
| *** mitarun has quit IRC | 17:28 | |
| *** dave_tucker is now known as dave_tucker_zzz | 17:28 | |
| *** mitarun has joined #openstack-neutron | 17:28 | |
| *** rms_13 has joined #openstack-neutron | 17:29 | |
| *** baoli has joined #openstack-neutron | 17:30 | |
| *** suresh12 has quit IRC | 17:30 | |
| *** suresh12_ has joined #openstack-neutron | 17:30 | |
| *** rook has left #openstack-neutron | 17:31 | |
| *** mitarun has quit IRC | 17:31 | |
| *** mitarun has joined #openstack-neutron | 17:32 | |
| *** sballe_ has joined #openstack-neutron | 17:32 | |
| *** sballe_ has quit IRC | 17:32 | |
| *** dbite_ has quit IRC | 17:33 | |
| *** dbite_ has joined #openstack-neutron | 17:34 | |
| *** tsg has quit IRC | 17:35 | |
| *** aix has quit IRC | 17:35 | |
| openstackgerrit | Carl Baldwin proposed a change to openstack/neutron: Cleanup rename of get_compute_ports_on_host_by_subnet https://review.openstack.org/118415 | 17:37 |
| openstackgerrit | Yanping Qu proposed a change to openstack/neutron: Adds FWaaS driver for Cisco CSR1kv https://review.openstack.org/115389 | 17:38 |
| *** oreillyd has quit IRC | 17:39 | |
| *** SridharG has joined #openstack-neutron | 17:41 | |
| *** dencaval has joined #openstack-neutron | 17:43 | |
| *** otherwiseguy has joined #openstack-neutron | 17:45 | |
| *** jp_at_hp has joined #openstack-neutron | 17:48 | |
| *** jp_at_hp has quit IRC | 17:48 | |
| *** jp_at_hp has joined #openstack-neutron | 17:48 | |
| *** aveiga has quit IRC | 17:50 | |
| openstackgerrit | Rajeev Grover proposed a change to openstack/neutron: Fix AttributeError when setting external gateway on DVR router https://review.openstack.org/112146 | 17:51 |
| *** amcrn has quit IRC | 17:51 | |
| *** arborism has joined #openstack-neutron | 17:52 | |
| *** arborism is now known as amcrn | 17:52 | |
| trinaths | markmcclain: Hi, Freescale CI, has 25 patchsets in queue for this to arrive. For subsequent patchsets it will skip. | 17:54 |
| *** devvesa has joined #openstack-neutron | 17:55 | |
| *** beagles_brb is now known as beagles | 17:57 | |
| *** emagana has quit IRC | 17:57 | |
| *** baoli has quit IRC | 17:59 | |
| openstackgerrit | Vivekanandan Narasimhan proposed a change to openstack/neutron: Fix DVR to unbind SNAT namespaces on gateway clear https://review.openstack.org/118422 | 17:59 |
| *** dave_tucker_zzz is now known as dave_tucker | 17:59 | |
| *** devvesa has quit IRC | 17:59 | |
| *** coolsvap has quit IRC | 18:00 | |
| *** dave_tucker is now known as dave_tucker_zzz | 18:00 | |
| *** SridharG has left #openstack-neutron | 18:00 | |
| *** dave_tucker_zzz is now known as dave_tucker | 18:00 | |
| *** signed8bit has joined #openstack-neutron | 18:01 | |
| *** doude has quit IRC | 18:01 | |
| *** dave_tucker is now known as dave_tucker_zzz | 18:03 | |
| *** dave_tucker_zzz is now known as dave_tucker | 18:03 | |
| *** dsneddon has quit IRC | 18:04 | |
| *** rm_work|away is now known as rm_work | 18:04 | |
| *** emagana has joined #openstack-neutron | 18:05 | |
| *** dsneddon has joined #openstack-neutron | 18:05 | |
| *** sgordon_ has quit IRC | 18:06 | |
| *** dave_tucker is now known as dave_tucker_zzz | 18:06 | |
| *** garyduan has quit IRC | 18:06 | |
| *** dave_tucker_zzz is now known as dave_tucker | 18:06 | |
| *** coolsvap has joined #openstack-neutron | 18:06 | |
| *** mspreitz_ has joined #openstack-neutron | 18:07 | |
| *** changbl has joined #openstack-neutron | 18:08 | |
| *** mspreitz has quit IRC | 18:08 | |
| *** garyduan has joined #openstack-neutron | 18:08 | |
| *** yamamoto has joined #openstack-neutron | 18:09 | |
| *** k_stev has joined #openstack-neutron | 18:10 | |
| *** harlowja has quit IRC | 18:12 | |
| *** harlowja has joined #openstack-neutron | 18:13 | |
| markmcclain | trinaths: ok.. when it votes I'll remove the -1 | 18:13 |
| *** mspreitz_ has quit IRC | 18:13 | |
| *** rm_work is now known as rm_work|away | 18:14 | |
| *** yamamoto has quit IRC | 18:14 | |
| *** jp_at_hp has quit IRC | 18:17 | |
| *** sgordon_ has joined #openstack-neutron | 18:18 | |
| openstackgerrit | Vivekanandan Narasimhan proposed a change to openstack/neutron: Fix DVR to service DHCP Ports https://review.openstack.org/117185 | 18:19 |
| *** matrohon has joined #openstack-neutron | 18:23 | |
| *** amuller has joined #openstack-neutron | 18:24 | |
| *** bjornar_ has joined #openstack-neutron | 18:25 | |
| *** julim has joined #openstack-neutron | 18:27 | |
| *** dmellado has quit IRC | 18:28 | |
| *** dmellado has joined #openstack-neutron | 18:29 | |
| openstackgerrit | Miguel Angel Ajo proposed a change to openstack/neutron: Refactor security group rpc call https://review.openstack.org/111876 | 18:32 |
| *** emagana has quit IRC | 18:33 | |
| *** emagana has joined #openstack-neutron | 18:35 | |
| *** trinaths has quit IRC | 18:35 | |
| amuller | mestery: ping about L3 HA | 18:37 |
| mestery | amuller: ack, whats up? | 18:37 |
| amuller | I understand features have to be approved by tomorrow morning your time to land in J3? | 18:38 |
| *** mitarun has quit IRC | 18:38 | |
| *** mitarun has joined #openstack-neutron | 18:38 | |
| ajo | salv-orlando, : https://review.openstack.org/111876 just the wide exception capture missing fix, I'll go on with that later around 11-12pm CEST | 18:39 |
| ajo | all the other comments have been addressed, as far as I know | 18:40 |
| *** afazekas has joined #openstack-neutron | 18:40 | |
| *** padkrish has quit IRC | 18:40 | |
| ajo | mestery, amuller, I think I understood that, I suppose it's based on the estimated merge times for the gate, right? | 18:40 |
| openstackgerrit | Kevin Benton proposed a change to openstack/neutron: Big Switch: Retry on 503 errors from backend https://review.openstack.org/114379 | 18:40 |
| salv-orlando | ajo: no worries I will be around | 18:40 |
| ajo | salv-orlando, thanks | 18:40 |
| ajo | salv-orlando, also versioning looks good to me know after RPC refactor & amotoki comments | 18:41 |
| salv-orlando | the features should be approved with enough time to go through the gate and merge before thursday | 18:41 |
| ajo | amuller, ^ | 18:41 |
| ajo | tight!!! | 18:42 |
| ajo | :] | 18:42 |
| salv-orlando | with an 80-deep queue, and the pesky bugs we are hitting it’s not looking good. | 18:42 |
| amuller | mestery: I have Carl and Maru dedicated to the L3 HA feature but I don't think it'll be approved tomorrow | 18:42 |
| amuller | carl_baldwin: ^ | 18:42 |
| ajo | argh | 18:42 |
| ajo | another failure in the functional job: http://logs.openstack.org/35/115935/10/check/check-neutron-dsvm-functional/8259e32/console.html#_2014-09-02_15_41_02_982 amuller look | 18:43 |
| mestery | amuller: OK, lets see what we can do | 18:43 |
| salv-orlando | I think we can jostle 3-4 FFEs. Rather than rushing L3 HA I think it’s worth reviewing it for one more week. | 18:43 |
| *** mitarun has quit IRC | 18:43 | |
| salv-orlando | ajo: don’t panic. marun has that under control. | 18:43 |
| *** padkrish has joined #openstack-neutron | 18:43 | |
| ajo | salv-orlando, .... pheww :) | 18:44 |
| amuller | Yeah... I can make significant improvements in a week, that I'd make either to the original patches or in subsequent patches, either case | 18:44 |
| salv-orlando | ajo: https://review.openstack.org/#/c/118380/ | 18:44 |
| carl_baldwin | Hi. Back from vacation and ready to hit the reviews again. | 18:44 |
| ajo | ''':) salv-orlando | 18:44 |
| * carl_baldwin goes to read context. | 18:44 | |
| *** adam_g` is now known as adaM_g | 18:44 | |
| *** padkrish has quit IRC | 18:44 | |
| *** adaM_g is now known as adam_g | 18:44 | |
| ajo | salv-orlando++ thanks for the info | 18:45 |
| *** doude has joined #openstack-neutron | 18:46 | |
| *** otherwiseguy has quit IRC | 18:46 | |
| openstackgerrit | Edgar Magana proposed a change to openstack/neutron: Commit to verify third-party CI systems https://review.openstack.org/114393 | 18:47 |
| openstackgerrit | Edgar Magana proposed a change to openstack/neutron: Commit to verify third-party CI systems (Neg) https://review.openstack.org/114629 | 18:47 |
| carl_baldwin | amuller: salv-orlando: mestery: I will dedicate the rest of my day today to reviewing L3 HA. I’ll be able to say more after another round of review but I think that I will end up agreeing with salv-orlando that another week may help. | 18:48 |
| amuller | carl_baldwin: I'm working on the server side patches now, after comments from Armando, Maru and others | 18:48 |
| carl_baldwin | I’ll go through the agent side now. | 18:49 |
| amuller | carl_baldwin: I'm trying to push a revision of the first server side patch tonight | 18:49 |
| amuller | if I don't fall asleep I'll get it done =D | 18:49 |
| carl_baldwin | amuller: I’ll be around for the rest of my day minus a couple of hours for family. Keep me posted. | 18:50 |
| *** cnesa10 has quit IRC | 18:51 | |
| amuller | carl_baldwin: Will do | 18:51 |
| *** changbl has quit IRC | 18:52 | |
| *** jckasper has joined #openstack-neutron | 18:54 | |
| *** jckasper_ has quit IRC | 18:55 | |
| *** changbl has joined #openstack-neutron | 18:55 | |
| mestery | carl_baldwin: Tahnks! | 18:58 |
| *** dave_tucker is now known as dave_tucker_zzz | 18:59 | |
| *** sambetts has quit IRC | 18:59 | |
| *** sweston_ is now known as sweston | 18:59 | |
| *** dave_tucker_zzz is now known as dave_tucker | 19:01 | |
| *** otherwiseguy has joined #openstack-neutron | 19:02 | |
| *** pballand has quit IRC | 19:02 | |
| *** sgordon_ has quit IRC | 19:07 | |
| *** marun_ has joined #openstack-neutron | 19:08 | |
| *** yamamoto has joined #openstack-neutron | 19:09 | |
| *** yamamoto has quit IRC | 19:14 | |
| *** emagana has quit IRC | 19:14 | |
| *** padkrish has joined #openstack-neutron | 19:15 | |
| *** emagana has joined #openstack-neutron | 19:15 | |
| *** emagana has quit IRC | 19:18 | |
| *** ZZelle_ has joined #openstack-neutron | 19:18 | |
| *** emagana has joined #openstack-neutron | 19:18 | |
| *** sgordon_ has joined #openstack-neutron | 19:21 | |
| *** padkrish_ has joined #openstack-neutron | 19:21 | |
| *** annegent_ has quit IRC | 19:22 | |
| *** padkrish has quit IRC | 19:24 | |
| *** prasoon has quit IRC | 19:24 | |
| *** prasoon has joined #openstack-neutron | 19:25 | |
| openstackgerrit | lifeless proposed a change to openstack/neutron: Revert "Prevent SystemExits when running tests" https://review.openstack.org/118447 | 19:25 |
| openstackgerrit | lifeless proposed a change to openstack/neutron: Revert "Prevent SystemExits when running tests" https://review.openstack.org/118447 | 19:26 |
| *** dmellado has quit IRC | 19:26 | |
| *** prasoon has quit IRC | 19:29 | |
| jogo | so neutron-full | 19:29 |
| jogo | the top two gate bugs hit neutron-full the most | 19:29 |
| *** dmellado has joined #openstack-neutron | 19:30 | |
| *** tsg has joined #openstack-neutron | 19:30 | |
| *** dbite_ has quit IRC | 19:33 | |
| *** tflynn has quit IRC | 19:34 | |
| *** dbite_ has joined #openstack-neutron | 19:34 | |
| mestery | jogo: I forget the number, but is one of htem the ssh issue? | 19:34 |
| mestery | jogo: salv-orlando was hoping to root cause that early this week if that's one of them. | 19:34 |
| jogo | mestery: we are discussiong them in #openstack-qa | 19:34 |
| mestery | jogo: Got it, thanks! | 19:35 |
| markmcclain | rkukura, nlahouti: we have to revert: https://review.openstack.org/#/c/103281/ | 19:36 |
| mestery | markmcclain: Is this because of the keystone issues you raised? | 19:37 |
| salv-orlando | markmcclain: I was reviewing the other patches for that blueprint. What’s the reason? | 19:37 |
| rkukura | markmcclain: I’m reviewing those as well | 19:37 |
| markmcclain | mestery: yes… the keystone integration was not removed as requested | 19:37 |
| nlahouti | markmcclain: is it because of VDP? | 19:37 |
| mestery | markmcclain: Then I'm onboard with the revert due to that | 19:38 |
| salv-orlando | markmcclain: keystone integration? why would this require keystone integration? Is it launching VMs? | 19:38 |
| markmcclain | salv-orlando: it connecting a mech driver to keystone notifications | 19:38 |
| nlahouti | salv-orlando: It is listening to keystone notification. | 19:38 |
| markmcclain | by spawning a thread | 19:38 |
| salv-orlando | I see. I’ll go back to the reviews. This is at least unusual. | 19:39 |
| * salv-orlando I meant I’ll look back at the reviews for that patch. | 19:39 | |
| markmcclain | that is not robust and has lots of unexpected behaviour in when multiple neutron servers are deployed | 19:40 |
| nlahouti | markmcclain: do you mean processing same notification? | 19:40 |
| nlahouti | markmcclain: by multiple servers? | 19:40 |
| markmcclain | nlahouti: yes if the notification actually arrives | 19:40 |
| markmcclain | notifications are a fanout so everyone thread gets a copy | 19:41 |
| nlahouti | markmcclain: sure, here we save the info in the DB | 19:41 |
| markmcclain | nlahouti: maybe | 19:41 |
| rkukura | markmcclain, nlahouti: If the handling of the notifications is idempotent, I don’t see a big issue. If it isn’t, that could probably be fixed as a bug. | 19:42 |
| markmcclain | rkukura: we don't allow any other plugin to do this | 19:42 |
| markmcclain | and have blocked every other proposal to do tie into keystone in this manner | 19:42 |
| markmcclain | the proposal will cause more headaches than it solves | 19:43 |
| markmcclain | which is why we've long objected to it | 19:43 |
| nlahouti | markmcclain: the MD just processes the tenant creating/deleting notification and save it in the DB with tenant's name | 19:43 |
| markmcclain | nlahouti: those are not reliable as you have it constructed | 19:44 |
| *** devvesa has joined #openstack-neutron | 19:44 | |
| *** gildub has joined #openstack-neutron | 19:44 | |
| nlahouti | markmcclain: can you please elaborate on this? | 19:44 |
| markmcclain | fanout messages can get lost | 19:45 |
| markmcclain | if neutron is not running the notificaitons will be thrown on the floor | 19:45 |
| rkukura | markmcclain, nlahouti: Could the handling of the keystone notification be broken out a separate service that Cisco ships on top of Juno? | 19:45 |
| markmcclain | rkukura: that something we should strongly consider for Kilo | 19:46 |
| nlahouti | markmcclain: if neutron is not running it means MD-DFA is not running right? | 19:46 |
| *** dbite_ has quit IRC | 19:46 | |
| rkukura | My vague understanding is that this is intended to create a DFA profile for each user. I’d think doing this via the DFA service plugin API would be sufficient, and Cisco could add an agent to automate it. | 19:46 |
| *** pballand has joined #openstack-neutron | 19:47 | |
| *** devvesa has quit IRC | 19:48 | |
| markmcclain | rkukura: that's fine.. we'll revert | 19:49 |
| nlahouti | rkukura markmcclain: MD DFA will create the same project/tenant (which is created openstack) in the DCNM | 19:49 |
| markmcclain | they can fix the issue raise and resubmit | 19:49 |
| *** reed has quit IRC | 19:51 | |
| *** trinaths has joined #openstack-neutron | 19:51 | |
| nlahouti | markmcclain: With the issue that you mentioned for notification, what else can be used instead of notification? | 19:51 |
| rkukura | markmcclain: It would be more productive to address this via a bug fix I’d think, unless this is somehow causing gate failures. | 19:52 |
| *** annegent_ has joined #openstack-neutron | 19:52 | |
| *** padkrish_ has quit IRC | 19:52 | |
| nlahouti | rkukura: I agree. We can open a bug and fix it there. | 19:53 |
| markmcclain | nlahouti: as I stated my email to the team on Friday it is something that the community will need to work on Kilo because the problem is actually complex | 19:53 |
| markmcclain | *DFA team | 19:53 |
| nlahouti | markmcclain: It that okay to open a bug and I will work on fix ? | 19:53 |
| *** crose has joined #openstack-neutron | 19:53 | |
| openstackgerrit | Karthik Natarajan proposed a change to openstack/neutron: Implementation of Brocade Vyatta vRouter L3 Plugin https://review.openstack.org/102336 | 19:53 |
| markmcclain | nlahouti: we'll revert and the code can be fixed and reproposed | 19:54 |
| nlahouti | markmcclain: In that case we cannot make the Juno, right? | 19:54 |
| *** prasoon has joined #openstack-neutron | 19:55 | |
| *** baoli has joined #openstack-neutron | 19:55 | |
| *** morganfainberg is now known as needs | 19:57 | |
| *** needs is now known as needscoffee | 19:57 | |
| *** doude has quit IRC | 19:58 | |
| nlahouti | markmcclain: Is that the part you were referring to: "We don’t allow MechDrivers or even plugins to listen for Keystone notifications. We’ve long precluded this for a myriad of of technical reasons including: handling notifications that are lost, not all Keystone projects/users are added via the keystone API (depends on the backing store), synchronization issues in a deployment with multiple neutron servers behind a load ba | 19:58 |
| *** doude has joined #openstack-neutron | 19:58 | |
| *** tflynn has joined #openstack-neutron | 19:59 | |
| openstackgerrit | Carl Baldwin proposed a change to openstack/neutron: Refactor l2_pop code to pass mac/ip info more readably https://review.openstack.org/112178 | 20:00 |
| *** prasoon has quit IRC | 20:01 | |
| *** pballand has quit IRC | 20:02 | |
| openstackgerrit | mark mcclain proposed a change to openstack/neutron: Revert "Cisco DFA ML2 Mechanism Driver" https://review.openstack.org/118456 | 20:02 |
| *** SumitNaiksatam has quit IRC | 20:02 | |
| markmcclain | nlahouti: yep that was the private warning of the issue as well as the comment left in the review | 20:03 |
| *** pballand has joined #openstack-neutron | 20:04 | |
| *** pballand has quit IRC | 20:05 | |
| *** sgordon_ has quit IRC | 20:07 | |
| *** itzikb has joined #openstack-neutron | 20:07 | |
| *** afazekas has quit IRC | 20:09 | |
| *** rook has joined #openstack-neutron | 20:09 | |
| *** yamamoto has joined #openstack-neutron | 20:09 | |
| *** julim has quit IRC | 20:11 | |
| *** trinaths has quit IRC | 20:12 | |
| *** julim has joined #openstack-neutron | 20:13 | |
| *** gduan has joined #openstack-neutron | 20:13 | |
| *** garyduan has quit IRC | 20:14 | |
| *** yamamoto has quit IRC | 20:14 | |
| *** padkrish has joined #openstack-neutron | 20:15 | |
| *** kickinz1 has quit IRC | 20:15 | |
| nlahouti | markmcclain: I replied to your comments on that patch and had to push changes for other reviews and in all the comments I ask reviewer that the patch is updated according to their comments and basically waiting for their review. According to the commit message in https://review.openstack.org/118456 Do you mean I intentionally push the commit to hide objection? | 20:15 |
| ZZelle_ | hi, everyone! | 20:16 |
| *** sballe has quit IRC | 20:16 | |
| *** cipcosma has quit IRC | 20:17 | |
| ZZelle_ | some core can have a final look at https://review.openstack.org/116988 which removes a "simple" SELECT FOR UPDATE | 20:17 |
| markmcclain | nlahouti: except that the revised patches should have indicated either via marking them as WIP or a comment on the current revision that there were outstanding issues raised that were not addressed | 20:19 |
| *** sgordon_ has joined #openstack-neutron | 20:19 | |
| *** NuclearW0rm has joined #openstack-neutron | 20:21 | |
| markmcclain | nlahouti: the intent of the commit msg was not to suggest malice, but state the objective reason for the revert | 20:22 |
| nlahouti | markmcclain: thx for clarification. | 20:26 |
| *** sballe has joined #openstack-neutron | 20:26 | |
| nlahouti | markmcclain: Would that be any issue to use keystone API to get list of projects instead of listening to keystone notification? | 20:31 |
| markmcclain | nlahouti: we rejected bigswitch's request to do that as well | 20:32 |
| *** zacksh has quit IRC | 20:32 | |
| *** itzikb has quit IRC | 20:33 | |
| *** mlavalle has joined #openstack-neutron | 20:33 | |
| nlahouti | markmcclain: who about using tenant_id in the network dict and use that to create the project in DCNM? | 20:34 |
| *** julim has quit IRC | 20:34 | |
| markmcclain | that is fine.. you can react on demand | 20:35 |
| *** julim has joined #openstack-neutron | 20:35 | |
| *** emagana has quit IRC | 20:36 | |
| markmcclain | but spawning a thread to listen to keystone or sync with keystone is something we've long prohibited in plugins and drivers | 20:37 |
| *** emagana has joined #openstack-neutron | 20:37 | |
| markmcclain | any rate we can revert and the patch can be cleaned up and reproposed | 20:37 |
| *** otherwiseguy has quit IRC | 20:39 | |
| *** zacksh has joined #openstack-neutron | 20:39 | |
| rkukura | markmcclain: I think it would be reasonable to give nlahouti some amount of time to figure out whether a bug fix can be submitted to replace the notification handling with some other solution, before actually reverting the patch. | 20:39 |
| *** julim has quit IRC | 20:39 | |
| markmcclain | rkukura: I disagree.. the unit merged should meet our requirements which is why we should pull it out.. revise and resubmit | 20:40 |
| *** snowgust has quit IRC | 20:40 | |
| rkukura | markmcclain: There are a lot of patches that I would revert by that standard. | 20:40 |
| *** emagana_ has joined #openstack-neutron | 20:41 | |
| nlahouti | markmcclain: in that case the project can be created but I need to use the name of the project as well so using keystone API is okay here, right? | 20:41 |
| *** emagana has quit IRC | 20:41 | |
| *** otherwiseguy has joined #openstack-neutron | 20:41 | |
| *** crc32 has joined #openstack-neutron | 20:44 | |
| *** pballand has joined #openstack-neutron | 20:49 | |
| *** LiberTerra has joined #openstack-neutron | 20:52 | |
| *** LiberTerra has quit IRC | 20:52 | |
| *** LiberTerra has joined #openstack-neutron | 20:52 | |
| *** mestery has quit IRC | 20:53 | |
| *** mwagner_lap has quit IRC | 20:53 | |
| amuller | Damnit, every time. I bring up a multi-node devstack setup, devstack creates a default network called private, but it's a 'local' network... I use VXLAN and it takes me like 30 minutes to debug why I don't have connectivity | 20:54 |
| amuller | What a pain | 20:54 |
| ajo | :/ | 20:54 |
| amuller | delete it, re-create it, viola, vxlan network, everything works | 20:54 |
| *** tchaypo has left #openstack-neutron | 20:54 | |
| ajo | amuller, not sure if you can change the private network CIDR in devstack | 20:54 |
| ajo | ah | 20:55 |
| ajo | you need it not to be local | 20:55 |
| ajo | sorry | 20:55 |
| ajo | yeah, you need to automate that, or modify devstack to support something else that it's not 'local' | 20:55 |
| *** mestery has joined #openstack-neutron | 20:55 | |
| *** needscoffee is now known as morganfainberg | 20:56 | |
| *** mlavalle has quit IRC | 20:56 | |
| *** mlavalle has joined #openstack-neutron | 20:56 | |
| *** baoli has quit IRC | 20:59 | |
| *** baoli has joined #openstack-neutron | 21:00 | |
| *** tsg has quit IRC | 21:00 | |
| *** jorgem has quit IRC | 21:00 | |
| *** tsg has joined #openstack-neutron | 21:01 | |
| *** emagana_ has quit IRC | 21:01 | |
| *** mlavalle has quit IRC | 21:02 | |
| *** emagana has joined #openstack-neutron | 21:02 | |
| *** mlavalle has joined #openstack-neutron | 21:02 | |
| *** emagana has quit IRC | 21:03 | |
| *** emagana has joined #openstack-neutron | 21:03 | |
| *** mlavalle has quit IRC | 21:04 | |
| *** mlavalle has joined #openstack-neutron | 21:04 | |
| *** crose has quit IRC | 21:07 | |
| *** pballand has quit IRC | 21:07 | |
| ajo | salv-orlando, https://review.openstack.org/#/c/112798/ your comments where quite reasonable. I agree to address them in a follow up patch. | 21:08 |
| salv-orlando | ajo: yes lets not hold this work. | 21:08 |
| *** yamamoto has joined #openstack-neutron | 21:09 | |
| ajo | thank you | 21:09 |
| *** annegent_ has quit IRC | 21:14 | |
| *** yamamoto has quit IRC | 21:14 | |
| *** tsg has quit IRC | 21:14 | |
| openstackgerrit | A change was merged to openstack/neutron: Make log level in linux.utils.execute configurable https://review.openstack.org/111715 | 21:17 |
| *** mlavalle has quit IRC | 21:17 | |
| *** mlavalle has joined #openstack-neutron | 21:18 | |
| *** cnesa10 has joined #openstack-neutron | 21:21 | |
| *** otherwiseguy has quit IRC | 21:23 | |
| *** otherwiseguy has joined #openstack-neutron | 21:23 | |
| *** dave_tucker is now known as dave_tucker_zzz | 21:24 | |
| *** dave_tucker_zzz is now known as dave_tucker | 21:26 | |
| *** emagana has quit IRC | 21:29 | |
| *** doude has quit IRC | 21:30 | |
| *** emagana has joined #openstack-neutron | 21:30 | |
| *** morganfainberg is now known as steve_notmorgan | 21:32 | |
| *** steve_notmorgan is now known as morganfainberg | 21:32 | |
| *** devvesa has joined #openstack-neutron | 21:33 | |
| *** Sukhdev has joined #openstack-neutron | 21:33 | |
| openstackgerrit | Assaf Muller proposed a change to openstack/neutron: Add L3 VRRP HA base classes https://review.openstack.org/64553 | 21:34 |
| openstackgerrit | Assaf Muller proposed a change to openstack/neutron: Add a new scheduler for the l3 HA https://review.openstack.org/66347 | 21:34 |
| *** emagana has quit IRC | 21:34 | |
| *** prasoon has joined #openstack-neutron | 21:35 | |
| ZZelle_ | amuller, hi | 21:35 |
| *** changbl has quit IRC | 21:35 | |
| amuller | ZZelle_: heya | 21:35 |
| *** ZZelle_ has left #openstack-neutron | 21:35 | |
| *** ZZelle_ has joined #openstack-neutron | 21:35 | |
| ZZelle_ | amuller, it seems not normal that your "private" network is not a vxlan network | 21:36 |
| amuller | ZZelle_: my fault, not devstack | 21:36 |
| amuller | ZZelle_: my localrc did not have ml2 configuration, I have an ml2 conf.ini that I copy in after devstack finishes | 21:36 |
| ZZelle_ | amuller, that's it | 21:37 |
| amuller | yeah | 21:37 |
| amuller | I have to update my local.conf to have a valid ml2 conf | 21:37 |
| *** emagana has joined #openstack-neutron | 21:37 | |
| *** devvesa has quit IRC | 21:37 | |
| *** lori is now known as lori|away | 21:38 | |
| amuller | carl_baldwin: pushed new version of the models patch | 21:39 |
| amuller | carl_baldwin: scheduler patch has only nits, I'll fix those tomorrow, too late for me | 21:39 |
| *** prasoon has quit IRC | 21:39 | |
| *** mitarun has joined #openstack-neutron | 21:39 | |
| carl_baldwin | amuller: Will look at it very soon. | 21:40 |
| carl_baldwin | I’ll also finish up my review of the L3 agent patch. | 21:40 |
| openstackgerrit | AARON ZHANG proposed a change to openstack/neutron: Implement full sync for cisco n1kv plugin https://review.openstack.org/113037 | 21:40 |
| *** rpothier has quit IRC | 21:40 | |
| amuller | carl_baldwin++ | 21:40 |
| carl_baldwin | amuller: Talk to you tomorrow. | 21:41 |
| amuller | carl_baldwin: Just gonna check out Darragh's comment on the agent patch then I'm out | 21:41 |
| *** vivek-ebay has joined #openstack-neutron | 21:41 | |
| carl_baldwin | amuller: Yeah, looks like he hit an error. I didn’t see him provide a stack trace though. | 21:42 |
| amuller | hmm he is correct | 21:42 |
| *** jckasper has quit IRC | 21:42 | |
| amuller | I guess that part isn't covered in the functional test | 21:42 |
| *** mitarun has quit IRC | 21:44 | |
| amuller | hmm, but it is, the mystery continues | 21:44 |
| *** bjornar_ has quit IRC | 21:44 | |
| *** lnxnut has quit IRC | 21:46 | |
| openstackgerrit | Kevin Benton proposed a change to openstack/neutron: BSN: Bind external ports in ML2 driver https://review.openstack.org/116188 | 21:46 |
| carl_baldwin | amuller: Could there be a stack trace hidden and suppressed by the functional test? | 21:47 |
| carl_baldwin | amuller: I know it is getting late for you. I’m sure you’ll figure it out. | 21:48 |
| amuller | if the l3 agent is catching the exception | 21:48 |
| amuller | and not re-raising it | 21:48 |
| amuller | then yeah the functional test would succeed as there's no explicit assert for the floating IP on the external gateway | 21:49 |
| amuller | shit | 21:49 |
| *** sballe_ has joined #openstack-neutron | 21:49 | |
| *** JayJ has joined #openstack-neutron | 21:52 | |
| *** annegent_ has joined #openstack-neutron | 21:53 | |
| *** sballe has quit IRC | 21:53 | |
| ajo | amuller, go go go! ;) | 21:53 |
| ajo | hi carl_baldwin :) | 21:53 |
| amuller | lol =D | 21:53 |
| amuller | this whole situation is surreal | 21:53 |
| carl_baldwin | ajo: Hi | 21:54 |
| *** simon-AS5591 has quit IRC | 21:54 | |
| *** SayajiPatil_ has joined #openstack-neutron | 21:54 | |
| *** oda-g has joined #openstack-neutron | 21:54 | |
| ajo | amuller, the fun of deadlines :) | 21:54 |
| *** padkrish has quit IRC | 21:55 | |
| carl_baldwin | amuller: On the bright side, It is good to know that a few of us reviewers (like Darragh) are actually trying the code. | 21:56 |
| amuller | yeah I'm pretty impressed | 21:56 |
| *** emagana has quit IRC | 21:57 | |
| amuller | it's not trivial to test out this stuff, I have to ask him what's his setup | 21:57 |
| *** alexpilotti has quit IRC | 21:57 | |
| carl_baldwin | I know, I’m still working on my setup while doing inspection based reviews. | 21:57 |
| *** emagana has joined #openstack-neutron | 21:57 | |
| amuller | You need a minimum of 2 VMs, I wasn't able to simulate two l3 agents on a single VM... That's what the final patch in the agent series is about | 21:58 |
| openstackgerrit | Karthik Natarajan proposed a change to openstack/neutron: Implementation of Brocade Vyatta vRouter L3 Plugin https://review.openstack.org/102336 | 21:59 |
| amuller | I got a functional test for failover but I wasn't able to get two l3 agents on the same machine with devstack | 21:59 |
| amuller | ml2 was failing to bind the HA ports | 21:59 |
| *** annegent_ has quit IRC | 21:59 | |
| kevinbenton | amuller: did you run two openvswitch agents? | 21:59 |
| amuller | yeah | 21:59 |
| amuller | I ran two pairs of ovs agent + l3 agent, each pair had the same 'host' value in their neutron.conf | 22:00 |
| amuller | each pair had a unique state_path | 22:00 |
| ajo | amuller++ :) | 22:00 |
| ajo | so it was that, :) | 22:00 |
| *** emagana_ has joined #openstack-neutron | 22:00 | |
| rkukura | kevinbenton: I will review your external port patches today - got tied up with other reviews - sorry | 22:00 |
| amuller | and I created two 'integration bridges' and two external bridges | 22:00 |
| amuller | pointed each pair to the correct one | 22:00 |
| kevinbenton | amuller: did they show up in neutron agent-show as independent agents? | 22:00 |
| *** emagana has quit IRC | 22:00 | |
| amuller | and connected the two integration bridges with a veth pair | 22:00 |
| amuller | kevinbenton: yes | 22:00 |
| ajo | kevinbenton, they should :) | 22:01 |
| ajo | amuller, how did you mapped the connectivity between the two l2 agents finally? | 22:01 |
| ajo | veth pair? | 22:01 |
| ajo | o ovs ports? | 22:01 |
| ajo | or | 22:01 |
| amuller | veth pair | 22:01 |
| kevinbenton | ajo: veth pair | 22:02 |
| rkukura | amuller: Why are you trying to run two L2 agents on the same host? | 22:02 |
| kevinbenton | rkukura: thanks | 22:02 |
| ajo | rkukura, functional testing :) | 22:02 |
| amuller | rkukura: I'm trying to simulate multi node on a single machine | 22:02 |
| *** annegent_ has joined #openstack-neutron | 22:02 | |
| amuller | It's so I can work on L3 HA easier but the end goal is getting it working on Tempest like this | 22:02 |
| ajo | amuller, for functional testing or it was for something else? | 22:02 |
| ajo | ahh | 22:02 |
| amuller | since it seems like tempest multi node is going no where | 22:02 |
| ajo | sorry | 22:02 |
| kevinbenton | amuller: did you get anything useful with debugging in the openvswitch logs? | 22:03 |
| ajo | seems like a cheap way to do multi mode, with far less resources | 22:03 |
| ajo | rkukura, hi :) | 22:03 |
| rkukura | amuller: You probably need to make the two L2 agents use different host IDs then, and have two nova-computes that set these same host IDs on ports. | 22:03 |
| kevinbenton | rkukura: nova-compute shouldn’t be necessary for L3 agents though, right? | 22:04 |
| amuller | rkukura: no instances involved | 22:04 |
| rkukura | kevinbenton: Didn’t realize L3 agents were all you cared about | 22:04 |
| ajo | rkukura, ah, it was you how showed me that with host-id in ml2, why does that happen, ports are tied to hosts-id's too? | 22:04 |
| rkukura | ML2 port binding is based on the binding:host_id value on the port. | 22:05 |
| kevinbenton | well the L3 agent scheduler should set the host_id based on the agent-id from the DB... | 22:05 |
| ajo | ahaa | 22:05 |
| *** vivek-ebay has quit IRC | 22:05 | |
| rkukura | kevinbenton: right | 22:06 |
| openstackgerrit | Abhishek Raut proposed a change to openstack/neutron: ML2 mechanism driver for Cisco Nexus1000V https://review.openstack.org/114872 | 22:07 |
| *** vivek-ebay has joined #openstack-neutron | 22:07 | |
| *** emagana_ has quit IRC | 22:08 | |
| openstackgerrit | mark mcclain proposed a change to openstack/neutron: Revert "Cisco DFA ML2 Mechanism Driver" https://review.openstack.org/118456 | 22:08 |
| *** emagana has joined #openstack-neutron | 22:09 | |
| *** yamamoto has joined #openstack-neutron | 22:09 | |
| *** dfarrell07 has quit IRC | 22:10 | |
| *** SayajiPatil_ has quit IRC | 22:11 | |
| *** emagana has quit IRC | 22:13 | |
| *** pcm_ has quit IRC | 22:13 | |
| *** yamamoto has quit IRC | 22:14 | |
| *** emagana has joined #openstack-neutron | 22:14 | |
| *** annegent_ has quit IRC | 22:15 | |
| *** kbringard has quit IRC | 22:16 | |
| *** matrohon has quit IRC | 22:17 | |
| rkukura | kevinbenton: Is the extension still needed with https://review.openstack.org/#/c/116188/? | 22:17 |
| kevinbenton | rkukura: so it’s not needed there but the downside is that all of the validation for formats is gone | 22:18 |
| kevinbenton | rkukura: i was hoping to make that sort of standardized by ML2 doing the validation | 22:19 |
| kevinbenton | rkukura: here. https://review.openstack.org/#/c/116187/ | 22:19 |
| rkukura | kevinbenton: Would this be a good candidate for implementation as an ML2 extension driver? | 22:19 |
| kevinbenton | rkukura: so just the validation isn’t even any extension per say because it doesn’t add more resources | 22:20 |
| rkukura | ML2 extension drivers add attributes to core resources. | 22:20 |
| openstackgerrit | Doug Wiegley proposed a change to openstack/neutron: Remove py33 from tox env list. eventlet means it'll never work. https://review.openstack.org/118479 | 22:20 |
| kevinbenton | rkukura: not even attributes anymore since this is all contained in the HOST_ID | 22:20 |
| *** tsg has joined #openstack-neutron | 22:21 | |
| sballe_ | Coudl somebody remind me when the weekly neutron meeting? | 22:21 |
| kevinbenton | rkukura: the other component to this was DB records that keep track of these identifiers while they aren’t assigned to ports | 22:21 |
| kevinbenton | rkukura: which was this one https://review.openstack.org/#/c/97173/ | 22:21 |
| rkukura | kevinbenton: I’ll need to spend some time on all this. | 22:22 |
| kevinbenton | rkukura: however, that isn’t driver specific. it’s basically just a place to store records and that isn’t critical to merge because it could be argued that this is some other tool’s job outside of neutron | 22:22 |
| kevinbenton | rkukura: ok. the first one is basically the important one | 22:22 |
| kevinbenton | rkukura: https://review.openstack.org/#/c/116187/15 | 22:22 |
| openstackgerrit | Miguel Angel Ajo proposed a change to openstack/neutron: Refactor security group rpc call https://review.openstack.org/111876 | 22:23 |
| ajo | salv-orlando, sorry, I cleared your +2, I just realized :/ | 22:23 |
| *** sgordon_ has quit IRC | 22:23 | |
| ajo | https://review.openstack.org/#/c/111876/34 | 22:23 |
| ajo | I was addressing the comments here: https://review.openstack.org/#/c/111876/31/neutron/api/rpc/handlers/securitygroups_rpc.py | 22:24 |
| openstackgerrit | Assaf Muller proposed a change to openstack/neutron: Test HA router failover https://review.openstack.org/117994 | 22:24 |
| openstackgerrit | Assaf Muller proposed a change to openstack/neutron: Add HA support to the l3 agent https://review.openstack.org/70700 | 22:24 |
| ajo | now it makes sense, thank you for reviewing, sorry for clearing the +2 :/ :] | 22:24 |
| amuller | carl_baldwin: I fixed the issue with the floating IPs, added it to functional test | 22:26 |
| amuller | carl_baldwin: And now it's time to crash, talk to ya tomorrow | 22:26 |
| *** rms_13__ has joined #openstack-neutron | 22:27 | |
| *** karimb has joined #openstack-neutron | 22:27 | |
| amuller | ajo: night | 22:27 |
| *** amuller has quit IRC | 22:27 | |
| *** jobewan has quit IRC | 22:28 | |
| *** signed8bit has quit IRC | 22:29 | |
| *** trinaths has joined #openstack-neutron | 22:31 | |
| carl_baldwin | amuller: ‘night | 22:33 |
| *** signed8bit has joined #openstack-neutron | 22:35 | |
| *** prasoon has joined #openstack-neutron | 22:35 | |
| *** prad has quit IRC | 22:36 | |
| *** JayJ has quit IRC | 22:36 | |
| *** prasoon has quit IRC | 22:40 | |
| openstackgerrit | Rajeev Grover proposed a change to openstack/neutron: Fix AttributeError when setting external gateway on DVR router https://review.openstack.org/112146 | 22:40 |
| *** rms_13__ has quit IRC | 22:41 | |
| *** dgollub has quit IRC | 22:42 | |
| *** pcm_ has joined #openstack-neutron | 22:44 | |
| *** emagana has quit IRC | 22:45 | |
| *** emagana has joined #openstack-neutron | 22:45 | |
| *** karimb has quit IRC | 22:45 | |
| *** zhipeng has quit IRC | 22:47 | |
| *** pballand has joined #openstack-neutron | 22:48 | |
| *** signed8bit has quit IRC | 22:48 | |
| salv-orlando | markmcclain, mestery: do you reckon it’s ok for a neutron service plugin to have admin access to keystone so that it can list tenants? I think that 1) operators want to keep things as segregate as possible, and it might not be ok for them if service accounts can list users or tenants (imagine for instance bogus services which might add themselves to the catalog) | 22:48 |
| *** pcm_ has quit IRC | 22:48 | |
| salv-orlando | 2) defintely not ok imho to have admin access to keystone from neutron | 22:48 |
| *** pcm_ has joined #openstack-neutron | 22:49 | |
| *** dave_tucker is now known as dave_tucker_zzz | 22:49 | |
| salv-orlando | this is being attempted here: https://review.openstack.org/#/c/115964/2/neutron/services/identity/sync.py | 22:49 |
| *** thomasem has quit IRC | 22:49 | |
| *** emagana has quit IRC | 22:50 | |
| *** nijaba_ has quit IRC | 22:51 | |
| markmcclain | salv-orlando: I'd like to see a more holistic solution | 22:52 |
| salv-orlando | where holistic means? | 22:54 |
| salv-orlando | there is also a mechanism for listening to notifications.... | 22:54 |
| markmcclain | a mechanism that cleans up across projects | 22:55 |
| markmcclain | so if a project is deleted seems that we should ensure nova cleans up before we do | 22:56 |
| *** dmellado has quit IRC | 22:56 | |
| *** haleyb_ has joined #openstack-neutron | 22:56 | |
| *** dmellado has joined #openstack-neutron | 22:57 | |
| salv-orlando | ok holistic as looking at all projects | 22:59 |
| *** suresh12_ has quit IRC | 22:59 | |
| salv-orlando | ok I think that’s enough for delaying this work item | 23:00 |
| *** rook has quit IRC | 23:00 | |
| markmcclain | salv-orlando: yes… seems that if projects are independently performing garbage collection that could lead to harder problems for ops to chase down | 23:00 |
| salv-orlando | cool. | 23:01 |
| * markmcclain thinks this would be cool session for paris | 23:01 | |
| *** vivek-ebay has quit IRC | 23:01 | |
| *** suresh12 has joined #openstack-neutron | 23:05 | |
| *** baoli has quit IRC | 23:05 | |
| openstackgerrit | Miguel Angel Ajo proposed a change to openstack/neutron: Add test to compare security_group_info_for_devices with old rpc https://review.openstack.org/115575 | 23:06 |
| *** networkstatic has quit IRC | 23:06 | |
| *** emagana has joined #openstack-neutron | 23:07 | |
| *** tgohad has joined #openstack-neutron | 23:08 | |
| *** pballand has quit IRC | 23:09 | |
| *** yamamoto has joined #openstack-neutron | 23:09 | |
| *** tsg has quit IRC | 23:09 | |
| *** haleyb_ has quit IRC | 23:10 | |
| *** pballand has joined #openstack-neutron | 23:11 | |
| *** carl_baldwin has quit IRC | 23:11 | |
| *** vivek-ebay has joined #openstack-neutron | 23:12 | |
| *** haleyb_ has joined #openstack-neutron | 23:12 | |
| kevinbenton | salv-orlando, markmcclain: if this were proposed today would it still be accepted? https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/arista/mechanism_arista.py#L374 | 23:13 |
| kevinbenton | salv-orlando, markmcclain: i suspect it’s using the keystone credentials to query keystone | 23:14 |
| *** yamamoto has quit IRC | 23:14 | |
| kevinbenton | is it just that it can’t happen in neutron and it should be swept under the rug to the backend? | 23:14 |
| *** rm_work|away is now known as rm_work | 23:16 | |
| *** tongli has quit IRC | 23:16 | |
| *** tongli has joined #openstack-neutron | 23:16 | |
| *** pballand has quit IRC | 23:17 | |
| *** ianw has quit IRC | 23:17 | |
| kevinbenton | this also does something very similar | 23:18 |
| kevinbenton | https://github.com/openstack/neutron/blob/master/neutron/plugins/ibm/sdnve_api.py#L339 | 23:18 |
| *** ianw has joined #openstack-neutron | 23:18 | |
| *** ZZelle_ has quit IRC | 23:20 | |
| *** devvesa has joined #openstack-neutron | 23:22 | |
| *** ivar-lazzaro has quit IRC | 23:26 | |
| *** devvesa has quit IRC | 23:26 | |
| *** cnesa10 has quit IRC | 23:27 | |
| *** cnesa10 has joined #openstack-neutron | 23:28 | |
| salv-orlando | kevinbenton: maybe it’s just me being paranoid. On the other hand while I’m don’t feel responsible for potential security issues in a driver or a vendor plugin, I feel I should speak out regarding those on service plugins designed for community consumptions | 23:30 |
| salv-orlando | and if I reviewed the patches which added keystone integration in plugin and drivers for tenant validation I would have given them a super-extra hard time. | 23:31 |
| *** vivek-ebay has quit IRC | 23:31 | |
| openstackgerrit | Swaminathan Vasudevan proposed a change to openstack/neutron: Add validation for the dvr router l3agent binding https://review.openstack.org/118491 | 23:31 |
| salv-orlando | because I love being an a-hole | 23:31 |
| *** vivek-ebay has joined #openstack-neutron | 23:32 | |
| kevinbenton | salv-orlando: mine was torpedoed for recording keystone project names. :-( | 23:32 |
| *** haleyb_ has quit IRC | 23:32 | |
| kevinbenton | salv-orlando: didn’t even have any keystone integration | 23:32 |
| kevinbenton | salv-orlando: so i was trying to figure out what the standard was for this kind of stuff is | 23:33 |
| *** haleyb_ has joined #openstack-neutron | 23:33 | |
| *** Sukhdev has quit IRC | 23:33 | |
| nlahouti | kevinbenton: and I was told even keystone API cannot be used to get tenant's list (in the plugins /drivers) and here https://review.openstack.org/#/c/115964/2/neutron/services/identity/sync.py,unified L#80 I see it is being used. May be I'm wrong. | 23:35 |
| *** prasoon has joined #openstack-neutron | 23:36 | |
| kevinbenton | nlahouti: using the keystone credentials to get tenants can fail if the keystone user isn’t an admin | 23:36 |
| *** markmcclain has quit IRC | 23:37 | |
| *** emagana has quit IRC | 23:37 | |
| *** haleyb_ has quit IRC | 23:38 | |
| kevinbenton | nlahouti: that’s why i had taken a different approach of just recording them as they came in | 23:38 |
| *** haleyb_ has joined #openstack-neutron | 23:38 | |
| *** padkrish has joined #openstack-neutron | 23:39 | |
| nlahouti | kevinbenton: yes. I saw your patch while back. | 23:39 |
| *** sgordon_ has joined #openstack-neutron | 23:40 | |
| *** prasoon has quit IRC | 23:42 | |
| *** padkrish has quit IRC | 23:42 | |
| *** flaviof is now known as flaviof_zzz | 23:43 | |
| *** ivar-lazzaro has joined #openstack-neutron | 23:46 | |
| *** yamamoto has joined #openstack-neutron | 23:46 | |
| *** reed has joined #openstack-neutron | 23:47 | |
| *** mlavalle has quit IRC | 23:50 | |
| *** emagana has joined #openstack-neutron | 23:50 | |
| salv-orlando | kevinbenton: the standard imho so far is that services ignore keystone for validation of tenant ids. | 23:50 |
| salv-orlando | whether this is right or not is a good question, and as an answer I’d probably just refer to markmcclain’s comments regarding a need for a holistic approach (ie: a solution which encompasses openstack as a whole) | 23:51 |
| kevinbenton | salv-orlando: right. i’m just whining because all we get on the backend are the tenant UUIDs and they are hideous | 23:52 |
| kevinbenton | salv-orlando: and there is data coming into neutron with the context that provides this info | 23:52 |
| kevinbenton | salv-orlando: but it is evil to store this in a database | 23:53 |
| salv-orlando | kevinbenton: if this is about ops (and your SEs) wishing to get something more human friendly we give ‘em tools that reconcile the uuids with keystone data. | 23:53 |
| *** nijaba has joined #openstack-neutron | 23:53 | |
| salv-orlando | in that case is the admin that willingly and as a one off gains admin access to keystone | 23:53 |
| *** nijaba has quit IRC | 23:53 | |
| *** nijaba has joined #openstack-neutron | 23:53 | |
| *** k_stev1 has joined #openstack-neutron | 23:53 | |
| kevinbenton | salv-orlando: which is a complete waste when it’s already in the context! | 23:53 |
| kevinbenton | salv-orlando: backend controller requires openstack specific client libraries to read from keystone, etc | 23:54 |
| *** k_stev has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!