Monday, 2014-09-01

*** skraynev has quit IRC00:07
*** Guest3116 has quit IRC00:07
*** feleouet has quit IRC00:07
*** wendar has quit IRC00:07
*** sc68cal has quit IRC00:07
*** adam_g has quit IRC00:07
*** peopleme1ge has quit IRC00:07
*** muhanpong has quit IRC00:07
*** Madkiss has quit IRC00:07
*** dguitarbite has quit IRC00:07
*** shakamunyi has quit IRC00:07
*** Madkiss_ has joined #openstack-neutron00:07
*** Madkiss_ is now known as Madkiss00:07
*** zhiyan_ has joined #openstack-neutron00:07
*** wendar_ has joined #openstack-neutron00:07
*** francois_eleouet has joined #openstack-neutron00:07
*** zacksh has joined #openstack-neutron00:07
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: merge br-tun into br-int  https://review.openstack.org/11248800:07
*** muhanpon1 has joined #openstack-neutron00:07
*** nati_ueno has joined #openstack-neutron00:07
*** jdag___ has joined #openstack-neutron00:07
*** jamespd_ has joined #openstack-neutron00:08
*** openstack has joined #openstack-neutron00:09
*** zhiyan_ is now known as zhiyan00:09
*** jdag___ is now known as jdag__00:10
*** baoli has joined #openstack-neutron00:11
*** rook has quit IRC00:11
*** swat30 has quit IRC00:11
*** jamespd has quit IRC00:11
*** mitz_ has quit IRC00:11
*** puck has quit IRC00:11
*** raorn_ has quit IRC00:11
*** swat30_ is now known as swat3000:11
*** padkrish has joined #openstack-neutron00:12
*** padkrish has joined #openstack-neutron00:12
*** padkrish has quit IRC00:15
*** gildub has joined #openstack-neutron00:16
*** ivar-lazzaro has quit IRC00:19
*** diegows has joined #openstack-neutron00:20
*** karimb has quit IRC00:21
*** oda-g has joined #openstack-neutron00:22
*** diegows has quit IRC00:24
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Enable local arp responder for local VMs  https://review.openstack.org/11316000:24
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: l2pop: Allow network types overridable  https://review.openstack.org/11294700:25
*** diegows has joined #openstack-neutron00:25
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Local arp responder for VLAN  https://review.openstack.org/11294900:28
*** tomoe_ has joined #openstack-neutron00:28
*** ivar-lazzaro has joined #openstack-neutron00:30
*** stack__ has joined #openstack-neutron00:34
*** rook has joined #openstack-neutron00:36
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Implement physical_interface_mappings  https://review.openstack.org/11316600:37
*** padkrish has joined #openstack-neutron00:40
*** silverpuff has joined #openstack-neutron00:46
*** padkrish has quit IRC00:49
openstackgerritKevin Benton proposed a change to openstack/neutron: Adds external attachment type validators to ML2  https://review.openstack.org/11618700:52
openstackgerritKevin Benton proposed a change to openstack/neutron: External Attachment Point Extension  https://review.openstack.org/9717300:52
*** yongli has joined #openstack-neutron00:54
*** padkrish has joined #openstack-neutron00:54
*** shakamunyi has joined #openstack-neutron00:54
*** yamamoto has quit IRC00:55
*** padkrish has quit IRC00:56
*** inara has quit IRC00:57
*** padkrish has joined #openstack-neutron00:57
*** balles has quit IRC00:59
*** rook has quit IRC00:59
*** shakamunyi has quit IRC00:59
*** balles has joined #openstack-neutron00:59
*** gildub has quit IRC01:01
*** inara has joined #openstack-neutron01:02
*** gildub has joined #openstack-neutron01:05
*** inara has quit IRC01:05
*** sbfox has quit IRC01:05
*** prasoon has quit IRC01:06
*** inara has joined #openstack-neutron01:06
*** ivar-lazzaro has quit IRC01:11
*** tsg has joined #openstack-neutron01:11
*** stanzgy has joined #openstack-neutron01:13
*** ivar-lazzaro has joined #openstack-neutron01:14
*** inara has quit IRC01:17
*** ivar-lazzaro has quit IRC01:17
*** diegows has quit IRC01:20
*** inara has joined #openstack-neutron01:21
*** dfarrell07 has joined #openstack-neutron01:23
*** otherwiseguy has quit IRC01:25
*** terryw has joined #openstack-neutron01:25
*** ivar-lazzaro has joined #openstack-neutron01:25
openstackgerritKevin Benton proposed a change to openstack/neutron: BSN: Bind external ports in ML2 driver  https://review.openstack.org/11618801:26
*** ivar-lazzaro has quit IRC01:30
*** tsg has quit IRC01:36
*** dfarrell07 has quit IRC01:36
*** popw has joined #openstack-neutron01:43
*** dguitarbite has joined #openstack-neutron01:44
*** yamamoto has joined #openstack-neutron01:45
*** mitarun has joined #openstack-neutron01:45
*** mitarun has quit IRC01:49
*** SridharRamaswamy has joined #openstack-neutron01:49
*** diegows has joined #openstack-neutron01:51
nlahoutiCan someone please let me know how to rebase a patch with dependency, where the patch that it depends on is merged?  (i.e A -> B and B is merged)01:51
*** baohua has joined #openstack-neutron01:52
*** ivar-lazzaro has joined #openstack-neutron01:54
*** shakamunyi has joined #openstack-neutron01:55
*** JayJ has joined #openstack-neutron01:55
*** rook has joined #openstack-neutron01:55
*** mitarun has joined #openstack-neutron01:59
StevenKnlahouti: Okay, so A depends on B, and B is merged, which means B is now in master, so you can rebase A onto an up-to-date master01:59
*** shakamunyi has quit IRC01:59
*** rook has quit IRC02:00
*** mitarun has quit IRC02:01
*** mitarun has joined #openstack-neutron02:02
nlahoutiStevenK: thx. so need to do 1) clone master 2) cherry-pick the patch ...02:02
*** diegows has quit IRC02:03
*** popw has quit IRC02:03
StevenKnlahouti: You should already have master in your local repo -- So, git checkout master and then git pull ; and then you want to git checkout <your A branch> and then run git rebase -i master02:03
openstackgerritArvind Somya proposed a change to openstack/neutron: ML2 Type Driver refactor part 3  https://review.openstack.org/11515102:03
*** prasoon has joined #openstack-neutron02:04
nlahoutiStevenK: got it. thx a lot for your reply. And one more thing.02:05
*** mitarun has quit IRC02:06
nlahoutiStevenK: I had case that A-> B and also A-> C and B & C are merged.02:06
nlahoutibecause of second dependency I had to duplicate file in A from C. to have only A-> B dependency.02:07
*** padkrish has joined #openstack-neutron02:08
nlahoutinow when I rebase, in the commit message it shows conflict files. But it doesn't show as part of files getting committed (basically they shouldn't be committed).02:08
*** yamahata has joined #openstack-neutron02:08
*** yamahata_ has quit IRC02:09
StevenKnlahouti: Rebase is a little special02:09
nlahoutiStevenK: would that cause any issue after git review ?02:09
*** yamahata_ has joined #openstack-neutron02:09
*** prasoon has quit IRC02:09
StevenKnlahouti: Can you pastebin git status ?02:09
*** terryw has quit IRC02:11
*** popw has joined #openstack-neutron02:12
nlahoutigit status doesn't show anything now only topic branch and nothing to commit, working directory clean02:12
nlahoutiI can pastebin the commit message02:12
*** padkrish has quit IRC02:12
StevenKnlahouti: Huh, what happened after git rebase -i master ?02:12
openstackgerritKevin Benton proposed a change to openstack/neutron: Big Switch: Bind IVS ports in ML2 driver  https://review.openstack.org/11374902:14
nlahoutiStevenK: there was merge errors and I fixed it and added the modified files then git rebase —continue.02:15
StevenKnlahouti: Ah, right, excellent. Then git review and you're done02:15
openstackgerritA change was merged to openstack/neutron: Networks are not scheduled to DHCP agents for Cisco N1KV plugin  https://review.openstack.org/11409102:17
nlahoutiStevenK: Here is the log: http://paste.openstack.org/show/103987/02:18
*** otherwiseguy has joined #openstack-neutron02:20
nlahoutiStevenK: And here is the steps that I did: http://paste.openstack.org/show/103988/02:25
StevenKnlahouti: Should be fine, but I'd suggest running git show and eyeballing the diff02:27
*** prasoon has joined #openstack-neutron02:32
nlahoutiStevenK: I checked 'git show' and it has all the changes and seems correct.02:32
nlahoutiStevenK: hopefully 'git review' doesn't give any error. thx a lot for your time. I'll update you on how it goes.02:33
StevenKnlahouti: Then you should be good to run git review :-)02:33
openstackgerritKevin Benton proposed a change to openstack/neutron: Allow setting a tenant router's external IP  https://review.openstack.org/8366402:34
*** sungju has quit IRC02:36
*** ianw has quit IRC02:36
*** ianw has joined #openstack-neutron02:36
openstackgerritnlahouti proposed a change to openstack/neutron: Cisco DFA ML2 Mechanism Driver - Part 3  https://review.openstack.org/11176102:39
*** JayJ has quit IRC02:39
*** JayJ has joined #openstack-neutron02:40
nlahoutiStevenK: It went through and was okay :) thank a lot again.02:40
*** zhhuabj has joined #openstack-neutron02:41
*** zhhuabj has quit IRC02:43
*** zhhuabj has joined #openstack-neutron02:44
*** padkrish has joined #openstack-neutron02:45
openstackgerritFeng Xi Yan proposed a change to openstack/neutron: ML2 Mechanism Driver for vCenter DVS port group creation  https://review.openstack.org/11122702:48
*** zhhuabj has quit IRC02:49
*** zhhuabj has joined #openstack-neutron02:49
openstackgerritAngus Lees proposed a change to openstack/neutron: Remove chain for correct router during update_routers()  https://review.openstack.org/11744402:54
openstackgerritAngus Lees proposed a change to openstack/neutron: Remove chain for correct router during update_routers()  https://review.openstack.org/11744402:56
*** shakamunyi has joined #openstack-neutron02:56
*** zhhuabj has quit IRC02:56
*** rook has joined #openstack-neutron02:56
*** tchaypo has joined #openstack-neutron02:58
tchayponlahouti: are you familiar with "git reflog"?02:59
*** shakamunyi has quit IRC03:00
*** rook has quit IRC03:01
lifelesstchaypo: thats where you get flogged multiple times right?03:01
*** zhhuabj has joined #openstack-neutron03:01
tchaypolifeless: no, that would be bizarre03:02
tchaypooops, I misspelled03:02
lifelessre-flogged, right?03:03
nlahoutitchaypo: haven't used it. I usually use 'git log'03:04
tchaypoIf you've done something like a rebase and realised that it didn't give you the result you wanted, `git reflog` can help you step back to just before the rebase03:06
tchaypoI used to be scared of rebasing until I got used to using reflog to step back in time. Now I'm less scared about reflog because I know I can just undo it if it goes bad03:07
StevenKtchaypo: It's not so much undo as "Pretend it never happened"03:09
tchaypohttp://stackoverflow.com/questions/134882/undoing-a-git-rebase is probably as good a starting point as any03:09
nlahoutitchaypo: thanks for the info. I'll keep it in my mind to use it. I'm really cautious when rebasing and don't want to mess up anything.03:10
tchaypoYeah, that's a good description. If you wanted to be more formal and were used to thinking of the commit history as a graph where each commit is a node, you might say that the reflog is a history of which node "HEAD" points at, which lets you use "git reset --hard" to step directly to any other node in the graph03:11
tchaypoBut if you start describing it that way you'll probably end up talking about homeomorphic endofunctors, and that's not a road any sane person wants to go down03:12
StevenKtchaypo: Commit history *is* a graph :-P03:12
tchaypoSure, but not everyone *thinks* of it that way03:12
*** baoli has quit IRC03:18
openstackgerritKevin Benton proposed a change to openstack/neutron: UTs: Disable auto deletion of ports/subnets/nets  https://review.openstack.org/10246503:23
*** padkrish has quit IRC03:25
openstackgerritKevin Benton proposed a change to openstack/neutron: Big Switch: Retry on 503 errors from backend  https://review.openstack.org/11437903:26
*** tflynn has joined #openstack-neutron03:31
*** mitarun has joined #openstack-neutron03:33
*** amotoki has joined #openstack-neutron03:37
*** LiberTerra has quit IRC03:39
*** dfarrell07 has joined #openstack-neutron03:40
openstackgerritItsuro Oda proposed a change to openstack/neutron: Add endpoint_type parameter to MetaInterfaceDriver  https://review.openstack.org/11341103:41
*** networkstatic has quit IRC03:41
openstackgerritnlahouti proposed a change to openstack/neutron: Cisco DFA ML2 Mechanism Driver - Part 4  https://review.openstack.org/11186303:44
*** JayJ has quit IRC03:45
*** JayJ has joined #openstack-neutron03:45
*** mitarun has quit IRC03:49
*** mitarun has joined #openstack-neutron03:49
*** tsg has joined #openstack-neutron03:50
*** jistr has joined #openstack-neutron03:53
*** dfarrell07 has quit IRC03:53
*** mitarun has quit IRC03:53
*** SridharRamaswamy has quit IRC03:54
*** jistr is now known as jistr|doc03:55
*** ivar-lazzaro has quit IRC03:57
*** shakamunyi has joined #openstack-neutron03:57
*** rook has joined #openstack-neutron03:57
*** ivar-lazzaro has joined #openstack-neutron03:57
*** rook has quit IRC04:01
*** shakamunyi has quit IRC04:01
*** mitarun has joined #openstack-neutron04:07
*** otherwiseguy has quit IRC04:07
*** otherwiseguy has joined #openstack-neutron04:08
*** fifieldt_ has quit IRC04:08
*** saju_m has joined #openstack-neutron04:10
*** ijw has joined #openstack-neutron04:12
*** JayJ has quit IRC04:15
*** ijw has quit IRC04:16
*** padkrish has joined #openstack-neutron04:22
*** padkrish has quit IRC04:23
*** padkrish has joined #openstack-neutron04:23
*** dfarrell07 has joined #openstack-neutron04:23
*** chandankumar has joined #openstack-neutron04:32
*** dfarrell07 has quit IRC04:35
*** nati_ueno has quit IRC04:36
*** nati_ueno has joined #openstack-neutron04:36
*** garyk has quit IRC04:40
*** saju_m has quit IRC04:43
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: Fix a recent ipv6 UT regression  https://review.openstack.org/11807504:44
*** saju_m has joined #openstack-neutron04:47
*** saju_m has quit IRC04:47
*** yfried has quit IRC04:51
*** _cjones_ has joined #openstack-neutron04:52
*** leenheer has joined #openstack-neutron04:52
*** chandankumar has quit IRC04:53
*** _cjones_ has quit IRC04:53
*** simon-AS559 has joined #openstack-neutron04:57
*** _cjones_ has joined #openstack-neutron04:58
*** rook has joined #openstack-neutron04:58
*** shakamunyi has joined #openstack-neutron04:58
*** simon-AS5591 has joined #openstack-neutron04:59
*** chandankumar has joined #openstack-neutron05:01
openstackgerritAngus Lees proposed a change to openstack/neutron: Purge use of "PRED and A or B" poor-mans-ternary  https://review.openstack.org/11084905:01
*** simon-AS559 has quit IRC05:01
*** rook has quit IRC05:02
*** shakamunyi has quit IRC05:02
*** _cjones_ has quit IRC05:03
*** _cjones_ has joined #openstack-neutron05:03
*** padkrish has quit IRC05:04
openstackgerritKoteswara Rao Kelam proposed a change to openstack/neutron: shared policy shouldn't have unshared rules  https://review.openstack.org/11591205:08
*** _cjones_ has quit IRC05:08
*** chandankumar has quit IRC05:09
openstackgerritAngus Lees proposed a change to openstack/neutron: Remove unused arg to config.setup_logging()  https://review.openstack.org/11118005:09
*** killer_prince is now known as lazy_prince05:12
*** kopparam has joined #openstack-neutron05:13
*** chandankumar has joined #openstack-neutron05:14
*** rotbeard has joined #openstack-neutron05:14
*** flaviof_zzz has joined #openstack-neutron05:17
*** padkrish has joined #openstack-neutron05:21
*** padkrish has quit IRC05:24
*** padkrish has joined #openstack-neutron05:24
*** padkrish_ has joined #openstack-neutron05:27
*** padkrish has quit IRC05:27
*** trinaths has joined #openstack-neutron05:28
*** JayJ has joined #openstack-neutron05:29
*** SridharG has joined #openstack-neutron05:32
*** JayJ has quit IRC05:33
Guest41143Hello, I added a static routes to a router and now, I want to remove it. How is it done?05:37
Guest41143Using 'neutron router-list -c name -c routes' print outs the static routes of a router05:38
*** LiberTerra has joined #openstack-neutron05:39
openstackgerritJamie Lennox proposed a change to openstack/python-neutronclient: Use adapter from keystoneclient  https://review.openstack.org/11800605:40
*** chandankumar has quit IRC05:40
*** simon-AS5591 has quit IRC05:41
*** padkrish_ has quit IRC05:46
*** padkrish has joined #openstack-neutron05:47
*** garyk has joined #openstack-neutron05:48
*** jamielennox has joined #openstack-neutron05:49
*** sbfox has joined #openstack-neutron05:53
*** _cjones_ has joined #openstack-neutron05:53
*** nlahouti has quit IRC05:55
*** shakamunyi has joined #openstack-neutron05:59
*** rook has joined #openstack-neutron05:59
*** _cjones_ has quit IRC05:59
*** JayJ has joined #openstack-neutron06:00
openstackgerritKoteswara Rao Kelam proposed a change to openstack/neutron: shared policy shouldn't have unshared rules  https://review.openstack.org/11591206:01
*** rook has quit IRC06:03
*** shakamunyi has quit IRC06:03
*** k4n0 has joined #openstack-neutron06:04
*** JayJ has quit IRC06:04
*** LiberTerra has quit IRC06:05
*** sungju has joined #openstack-neutron06:05
*** leenheer has quit IRC06:05
*** tflynn has quit IRC06:10
*** nati_uen_ has joined #openstack-neutron06:10
*** nati_ueno has quit IRC06:13
*** ijw has joined #openstack-neutron06:13
*** ijw has quit IRC06:18
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy API-2: Classifiers, Actions, and Rules  https://review.openstack.org/10181606:18
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy Mapping API-1: EP, EPG, L2 Policy, L3 Policy  https://review.openstack.org/10071606:18
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy Plugin-3: Contracts  https://review.openstack.org/10379806:18
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy Mapping Plugin-1: EP, EPG, L2 Policy, L3 Policy  https://review.openstack.org/10195706:18
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy Plugin-1: EP, EPG, L2 Policy, L3 Policy  https://review.openstack.org/9639306:18
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy Plugin-2: Classifiers, Actions, and Rules  https://review.openstack.org/10346506:18
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy API-3: Contracts  https://review.openstack.org/10348606:18
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy API-1: EP, EPG, L2 Policy, L3 Policy  https://review.openstack.org/9590006:18
openstackgerritOpenStack Proposal Bot proposed a change to openstack/neutron: Imported Translations from Transifex  https://review.openstack.org/11710006:19
*** jamielennox has left #openstack-neutron06:20
*** chandankumar has joined #openstack-neutron06:20
*** ivar-lazzaro has quit IRC06:20
*** ivar-lazzaro has joined #openstack-neutron06:20
*** ivar-lazzaro has quit IRC06:21
*** yfauser has joined #openstack-neutron06:23
*** yfauser has left #openstack-neutron06:23
*** yfried has joined #openstack-neutron06:26
*** lazy_prince has quit IRC06:26
*** hanzhang has joined #openstack-neutron06:32
hanzhanghi all06:33
*** gildub has quit IRC06:33
*** salv-orlando has joined #openstack-neutron06:33
*** padkrish has quit IRC06:33
*** padkrish has joined #openstack-neutron06:34
*** chandankumar has quit IRC06:38
*** irenab has joined #openstack-neutron06:40
*** RussB has joined #openstack-neutron06:40
*** padkrish_ has joined #openstack-neutron06:41
*** padkrish has quit IRC06:41
*** RussB has left #openstack-neutron06:41
*** simon-AS559 has joined #openstack-neutron06:41
*** chandankumar has joined #openstack-neutron06:43
openstackgerritA change was merged to openstack/neutron: Provide a quick way to run flake8  https://review.openstack.org/11532706:46
openstackgerrityangxurong proposed a change to openstack/neutron: Huawei SDN Mechanism Driver for ML2 Plugin  https://review.openstack.org/10410306:49
*** devvesa has joined #openstack-neutron06:51
*** roeyc has joined #openstack-neutron06:51
openstackgerritMotohiro Otsuka proposed a change to openstack/neutron: Remove reference to cisco_cfg_agent.ini from setup.cfg again.  https://review.openstack.org/11809206:51
*** chandankumar has quit IRC06:54
*** chandankumar has joined #openstack-neutron06:54
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: Fix a recent ipv6 UT regression  https://review.openstack.org/11807506:58
*** pasquier-s has joined #openstack-neutron06:59
*** rook has joined #openstack-neutron06:59
*** shakamunyi has joined #openstack-neutron06:59
openstackgerritgaryk proposed a change to openstack/neutron: Remove @author from copyright statements  https://review.openstack.org/11232907:01
*** JayJ has joined #openstack-neutron07:01
*** jlibosva has joined #openstack-neutron07:01
*** nlahouti has joined #openstack-neutron07:01
*** nlahouti has joined #openstack-neutron07:02
*** otherwiseguy has quit IRC07:02
*** nlahouti has quit IRC07:02
*** Longgeek has joined #openstack-neutron07:02
*** jschwarz has joined #openstack-neutron07:03
*** rook has quit IRC07:04
*** kopparam has quit IRC07:04
*** shakamunyi has quit IRC07:04
*** kopparam has joined #openstack-neutron07:04
*** JayJ has quit IRC07:05
*** Longgeek has quit IRC07:06
*** Longgeek has joined #openstack-neutron07:08
*** kopparam has quit IRC07:09
*** killer_prince has joined #openstack-neutron07:09
*** killer_prince is now known as lazy_prince07:09
*** doude has joined #openstack-neutron07:09
*** yfauser has joined #openstack-neutron07:11
*** padkrish_ has quit IRC07:14
*** yfauser has left #openstack-neutron07:15
*** gildub has joined #openstack-neutron07:20
openstackgerritA change was merged to openstack/neutron: Apic drivers enhancements (second approach): L3 refactor  https://review.openstack.org/11615607:22
*** luqas has joined #openstack-neutron07:22
*** luqas has quit IRC07:26
*** sungju has quit IRC07:27
*** chandankumar has quit IRC07:28
openstackgerritKevin Benton proposed a change to openstack/neutron: Allow setting a tenant router's external IP  https://review.openstack.org/8366407:28
*** saurabh_ has quit IRC07:31
*** luqas has joined #openstack-neutron07:32
*** kopparam has joined #openstack-neutron07:33
openstackgerritKevin Benton proposed a change to openstack/neutron: UTs: Disable auto deletion of ports/subnets/nets  https://review.openstack.org/10246507:34
*** mitarun has quit IRC07:37
openstackgerritKevin Benton proposed a change to openstack/neutron: Big Switch: Separate L3 functions into L3 service  https://review.openstack.org/11365307:37
*** mitarun has joined #openstack-neutron07:38
kevinbentonamotoki: ping07:39
amotokikevinbenton: pong07:39
kevinbentonamotoki: nevermind. was going to ask how to retrigger the NEC CI but I see in the comment it’s recheck-nec07:40
kevinbentonamotoki: had a failure on https://review.openstack.org/#/c/114379/07:40
kevinbentonamotoki: that i doubt was related because the change was all isolated to the Big Switch code07:40
*** chandankumar has joined #openstack-neutron07:41
amotokikevinbenton: ah... let me check it is temporary or not.07:41
*** mitarun has quit IRC07:42
*** yamamoto has quit IRC07:44
jschwarzamotoki, morning :)07:45
amotokikevinbenton: two failures occurred due to kombu not found. It seems temporary problem on pypi mirror or our proxy.07:45
jschwarzamotoki, could you possibly take a look at https://review.openstack.org/#/c/116832/ ? You +2'd it before and I made some changes to the code :)07:47
amotokijschwarz: sure07:47
jschwarzamotoki, thanks :)07:47
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: Make Juno migrations config independent  https://review.openstack.org/10976807:51
*** Altran has joined #openstack-neutron07:51
*** nati_uen_ has quit IRC07:55
*** nati_ueno has joined #openstack-neutron07:55
*** rm_work|away is now known as rm_work07:56
*** _cjones_ has joined #openstack-neutron08:00
*** rook has joined #openstack-neutron08:00
*** shakamunyi has joined #openstack-neutron08:00
*** karimb has joined #openstack-neutron08:01
*** JayJ has joined #openstack-neutron08:02
*** mitarun has joined #openstack-neutron08:03
*** skolekonov has joined #openstack-neutron08:03
*** tsg has quit IRC08:03
*** _cjones_ has quit IRC08:04
*** ygbo has joined #openstack-neutron08:04
*** rook has quit IRC08:04
*** shakamunyi has quit IRC08:05
*** JayJ has quit IRC08:06
*** tomoe_ has quit IRC08:07
*** tomoe_ has joined #openstack-neutron08:08
*** Longgeek has quit IRC08:09
*** Longgeek has joined #openstack-neutron08:10
kevinbentonamotoki: thanks08:11
*** luqas has quit IRC08:12
*** yamamoto has joined #openstack-neutron08:12
openstackgerritKevin Benton proposed a change to openstack/neutron: Adds external attachment type validators to ML2  https://review.openstack.org/11618708:15
*** sungju has joined #openstack-neutron08:18
*** nati_uen_ has joined #openstack-neutron08:18
*** luqas has joined #openstack-neutron08:19
*** luqas has quit IRC08:22
*** nati_ueno has quit IRC08:22
*** matrohon has joined #openstack-neutron08:23
*** luqas has joined #openstack-neutron08:23
*** padkrish has joined #openstack-neutron08:25
*** Dafna has joined #openstack-neutron08:28
*** sungju has quit IRC08:29
*** padkrish has quit IRC08:29
*** kopparam has quit IRC08:30
*** kopparam has joined #openstack-neutron08:31
*** cnesa9 has joined #openstack-neutron08:38
*** amuller has joined #openstack-neutron08:38
*** Longgeek has quit IRC08:39
*** Longgeek has joined #openstack-neutron08:39
*** Longgeek has quit IRC08:44
*** lazy_prince is now known as killer_prince08:45
*** killer_prince is now known as lazy_prince08:45
amulleramotoki: Good evening08:46
amulleramotoki: The keepalive patch: https://review.openstack.org/#/c/68142/08:46
amullerhas +2 from Maru08:46
*** Longgeek has joined #openstack-neutron08:46
amulleramotoki: I thought maybe you'd like to take a look :)08:47
amotokiamuller: wait for a while. will visit after finishing the current one.08:47
*** yamamoto has quit IRC08:47
amullerok08:47
*** k4n0 has quit IRC08:47
amulleramotoki: Also I see your DVR patches to Horizon were merged08:48
amulleramotoki: I wanted to ask if you're planning on doing something simple for HA? Like admins seeing if a router is HA or not?08:48
amotokiamuller: yes. it is in my mind.08:48
amulleramotoki: ok cool08:49
amulleramotoki: hopefully we'll merge all of the patches very soon08:49
amotokiamuller: it is small enough so we can do it after J-3 cut.08:49
amulleryep08:49
amulleramotoki: Thanks for your work Akihiro08:51
*** yamamoto has joined #openstack-neutron08:52
openstackgerritJakub Libosvar proposed a change to openstack/neutron: Add functional test for IptablesManager  https://review.openstack.org/11785208:53
*** salv-orlando has quit IRC08:55
*** aix has joined #openstack-neutron08:56
openstackgerritSridar Kandaswamy proposed a change to openstack/neutron: Changes to support FWaaS in a DVR based environment  https://review.openstack.org/11335908:59
*** rook has joined #openstack-neutron09:01
*** shakamunyi has joined #openstack-neutron09:01
*** rm_work is now known as rm_work|away09:01
*** chandankumar has quit IRC09:02
*** JayJ has joined #openstack-neutron09:02
*** dguerri`afk is now known as dguerri09:04
trinathsHi all09:05
*** rook has quit IRC09:05
*** shakamunyi has quit IRC09:05
*** k4n0 has joined #openstack-neutron09:06
*** jp_at_hp has joined #openstack-neutron09:07
*** zilberstein has joined #openstack-neutron09:07
zilbersteinhello #openstack-neutron09:07
zilbersteinIs there's a way to assign floating IP to VPS without creating allocation pool for network ?09:07
*** ivar-lazzaro has joined #openstack-neutron09:08
*** safchain has joined #openstack-neutron09:08
*** JayJ has quit IRC09:08
*** luqas has quit IRC09:10
*** nati_uen_ has quit IRC09:10
*** nati_ueno has joined #openstack-neutron09:11
*** roeyc has quit IRC09:11
*** yamamoto has quit IRC09:14
*** yamamoto has joined #openstack-neutron09:15
*** yamamoto has quit IRC09:15
*** ijw has joined #openstack-neutron09:15
*** yamamoto has joined #openstack-neutron09:16
*** salv-orlando has joined #openstack-neutron09:17
*** mitarun has quit IRC09:17
*** mitarun has joined #openstack-neutron09:18
*** marun has joined #openstack-neutron09:18
*** ijw has quit IRC09:20
*** nati_uen_ has joined #openstack-neutron09:20
*** mitarun has quit IRC09:22
zilbersteinwhat exactly neutron floatingip-create --fixed-ip-address do ?09:22
openstackgerritSam Betts proposed a change to openstack/neutron: Added TAP_DEVICE_PREFIX info to common/constants  https://review.openstack.org/11697009:22
openstackgerritTrinath Somanchi proposed a change to openstack/neutron: Freescale FWaaS Plugin  https://review.openstack.org/10965909:23
*** nati_ueno has quit IRC09:24
*** lori is now known as lori|away09:30
*** cnesa9 has quit IRC09:30
*** geekinut1h has quit IRC09:30
*** geekinutah has joined #openstack-neutron09:31
*** mitarun has joined #openstack-neutron09:31
*** mitarun has quit IRC09:34
*** xuhanp has joined #openstack-neutron09:34
*** mitarun has joined #openstack-neutron09:34
*** mitarun has quit IRC09:39
*** sambetts has joined #openstack-neutron09:42
*** luqas has joined #openstack-neutron09:42
*** jistr|doc is now known as jistr09:42
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: Introduce havana initial state  https://review.openstack.org/11273209:43
*** dave_tucker_zzz is now known as dave_tucker09:51
*** _cjones_ has joined #openstack-neutron09:56
amotokijschwarz: I just commented to your patch. I am not sure why we need to use defaultdict rather than set().09:58
amulleramotoki: thanks for the approval10:00
*** xuhanp has quit IRC10:00
*** k4n0 has quit IRC10:00
*** _cjones_ has quit IRC10:01
*** rook has joined #openstack-neutron10:01
*** shakamunyi has joined #openstack-neutron10:02
*** ZZelle has joined #openstack-neutron10:02
*** mitarun has joined #openstack-neutron10:04
*** claudiub has joined #openstack-neutron10:05
*** amotoki has quit IRC10:05
*** yamamoto has quit IRC10:06
*** shakamunyi has quit IRC10:07
*** sbfox has quit IRC10:09
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: Remove logic for conditional migrations  https://review.openstack.org/11791310:09
*** afazekas has joined #openstack-neutron10:10
*** kopparam_ has joined #openstack-neutron10:11
*** rook has quit IRC10:13
*** kopparam has quit IRC10:13
openstackgerritTrinath Somanchi proposed a change to openstack/neutron: Freescale FWaaS Plugin  https://review.openstack.org/10965910:13
*** k4n0 has joined #openstack-neutron10:13
*** yamamoto has joined #openstack-neutron10:14
*** yamamoto has quit IRC10:16
*** yamamoto has joined #openstack-neutron10:16
*** luqas has quit IRC10:17
*** mitarun has quit IRC10:17
*** luqas has joined #openstack-neutron10:17
*** kopparam_ has quit IRC10:17
*** kopparam has joined #openstack-neutron10:18
*** tomoe__ has joined #openstack-neutron10:20
*** Guest13287 is now known as puck10:20
*** tomoe__ has quit IRC10:21
*** tomoe_ has quit IRC10:23
*** kopparam has quit IRC10:23
*** roeyc has joined #openstack-neutron10:25
*** jistr has quit IRC10:25
*** yamamoto has quit IRC10:25
*** mitarun has joined #openstack-neutron10:26
*** alexpilotti has joined #openstack-neutron10:28
*** yfried_ has joined #openstack-neutron10:32
openstackgerritVinod Kumar proposed a change to openstack/neutron: RESTful API to retrieve dvrhostmac for ODL  https://review.openstack.org/11812610:32
*** luqas has quit IRC10:33
*** yfried has quit IRC10:34
*** yamahata has quit IRC10:41
*** mitarun has quit IRC10:44
*** mitarun has joined #openstack-neutron10:44
*** Longgeek has quit IRC10:46
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: NSX: Add a foreign key for gateway devices  https://review.openstack.org/9382610:47
*** mitarun has quit IRC10:48
*** alexpilotti has quit IRC10:50
openstackgerritRossella Sblendido proposed a change to openstack/neutron: Remove locking from network and subnet delete op  https://review.openstack.org/11536010:51
*** _cjones_ has joined #openstack-neutron10:55
openstackgerritTrinath Somanchi proposed a change to openstack/neutron: Freescale FWaaS Plugin  https://review.openstack.org/10965910:55
*** tomoe_ has joined #openstack-neutron10:55
*** _cjones_ has quit IRC11:00
*** rook has joined #openstack-neutron11:02
*** shakamunyi has joined #openstack-neutron11:03
*** irenab has quit IRC11:03
*** Longgeek has joined #openstack-neutron11:05
*** JayJ has joined #openstack-neutron11:06
*** lori|away is now known as lori11:06
*** rook has quit IRC11:07
*** yfried_ has quit IRC11:07
*** shakamunyi has quit IRC11:07
openstackgerritAssaf Muller proposed a change to openstack/neutron: Add L3 VRRP HA base classes  https://review.openstack.org/6455311:09
openstackgerritAssaf Muller proposed a change to openstack/neutron: Add a new scheduler for the l3 HA  https://review.openstack.org/6634711:09
*** JayJ has quit IRC11:10
*** luqas has joined #openstack-neutron11:12
*** tomoe_ has quit IRC11:12
*** kopparam has joined #openstack-neutron11:14
*** yamamoto has joined #openstack-neutron11:15
*** popw has quit IRC11:15
*** yamamoto_ has joined #openstack-neutron11:16
*** yamamoto has quit IRC11:17
*** prasoon has quit IRC11:17
*** ijw has joined #openstack-neutron11:17
openstackgerritA change was merged to openstack/neutron: ofagent: merge br-tun into br-int  https://review.openstack.org/11248811:20
openstackgerritA change was merged to openstack/neutron: ofagent: Enable local arp responder for local VMs  https://review.openstack.org/11316011:20
*** yamamoto_ has quit IRC11:21
*** balles has quit IRC11:21
*** ijw has quit IRC11:22
*** sballe has joined #openstack-neutron11:22
*** nati_uen_ has quit IRC11:23
*** yfried_ has joined #openstack-neutron11:24
openstackgerritJohn Schwarz proposed a change to openstack/neutron: Refactor model_query_hooks  https://review.openstack.org/11714211:25
openstackgerritJohn Schwarz proposed a change to openstack/neutron: Allow filtering routers by network-ids  https://review.openstack.org/11158011:25
*** chandankumar has joined #openstack-neutron11:26
jschwarzsalv-orlando, morning :) Just sent new patch sets to the model_query_hook refactor (https://review.openstack.org/117142) if you get a chance to look at it sometime :)11:28
*** kopparam has quit IRC11:28
*** kopparam has joined #openstack-neutron11:29
*** baohua has quit IRC11:30
*** rook has joined #openstack-neutron11:34
*** baoli has joined #openstack-neutron11:35
*** baoli has quit IRC11:35
*** baoli has joined #openstack-neutron11:36
openstackgerritPreeti Mirji proposed a change to openstack/neutron: Adm policy can't use other tenants unshared rules  https://review.openstack.org/10895211:37
*** yamahata has joined #openstack-neutron11:38
*** chandankumar has quit IRC11:39
*** Longgeek has quit IRC11:39
openstackgerritVinod Kumar proposed a change to openstack/neutron: RESTful API to retrieve dvrhostmac for ODL  https://review.openstack.org/11812611:40
*** Longgeek has joined #openstack-neutron11:40
*** Longgeek has quit IRC11:41
*** luqas has quit IRC11:41
openstackgerritRobert Kukura proposed a change to openstack/neutron: ML2: Fix release of network segments to allocation pools  https://review.openstack.org/11814011:41
*** Longgeek has joined #openstack-neutron11:41
*** nati_ueno has joined #openstack-neutron11:42
*** Longgeek_ has joined #openstack-neutron11:42
*** Longgeek_ has quit IRC11:42
*** Longgeek_ has joined #openstack-neutron11:42
*** nati_ueno has quit IRC11:43
*** nati_ueno has joined #openstack-neutron11:44
rkukurasalv-orlando, nati_ueno: Can you take a quick look at https://review.openstack.org/118140, which fixes a serious issue introduced by a patch that merged yesterday?11:45
*** alexpilotti has joined #openstack-neutron11:45
nati_uenorkukura: sure!11:46
rkukuranati_ueno: Thanks!11:46
*** Longgeek has quit IRC11:46
*** ZZelle has quit IRC11:48
*** jab has joined #openstack-neutron11:52
*** jab has quit IRC11:52
*** jab has joined #openstack-neutron11:52
*** prasoon has joined #openstack-neutron11:54
*** rook has quit IRC11:55
*** popw has joined #openstack-neutron11:58
*** drankis has joined #openstack-neutron12:01
*** shakamunyi has joined #openstack-neutron12:03
*** yamamoto has joined #openstack-neutron12:04
*** gildub has quit IRC12:06
*** boris-42_ is now known as boris-4212:06
openstackgerritLiping Mao proposed a change to openstack/neutron: Neutron metering do not check overlap ip range  https://review.openstack.org/11665212:07
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: l2pop: Allow network types overridable  https://review.openstack.org/11294712:07
*** shakamunyi has quit IRC12:08
*** markvoelker has joined #openstack-neutron12:09
*** nati_ueno has quit IRC12:11
*** sballe has quit IRC12:11
*** diegows has joined #openstack-neutron12:12
*** Longgeek_ has quit IRC12:14
*** amotoki has joined #openstack-neutron12:17
*** Longgeek has joined #openstack-neutron12:17
*** naotokl is now known as zz_naotokl12:20
openstackgerritAkihiro Motoki proposed a change to openstack/neutron: Don't spawn metadata-proxy for non-isolated nets  https://review.openstack.org/11683212:22
*** kopparam has quit IRC12:22
*** kopparam has joined #openstack-neutron12:23
openstackgerritAssaf Muller proposed a change to openstack/neutron: Add HA support to the l3 agent  https://review.openstack.org/7070012:24
openstackgerritAssaf Muller proposed a change to openstack/neutron: Test HA router failover  https://review.openstack.org/11799412:24
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Enable local arp responder for TYPE_FLAT  https://review.openstack.org/11411912:24
trinathsWhen I check out the latest code, for my unit testing, I get the error "NoSuchOptError: no such option: router_distributed".12:25
trinathsI'm any new configuration ? an DVR guys around ?12:25
*** roeyc has quit IRC12:26
jschwarztrinaths, where do you get that error?12:26
*** kopparam has quit IRC12:27
trinathswhile unit testing.12:28
trinathsnear create_firewall12:28
*** luqas has joined #openstack-neutron12:29
*** ZZelle has joined #openstack-neutron12:29
trinathsjschwarz: Here is the complete log. http://paste.openstack.org/show/104196/12:29
jschwarztrinaths, beats me :< sorry12:30
trinathsjschwarz: in neutron/common/config.py, there is not config option for router_distributed12:31
trinathsjschwarz: If we give a place to options "router_distributed". All unit tests pass.12:32
jschwarztrinaths, I'm afraid I'm not that much into DVR at all...12:33
jschwarzI remember having a similar problem a while back but don't remember what I did to solve it12:34
trinathsjschwarz: [Doubt] For any options in neutron.conf, is it mandatory to have cfg.CONF option in /neutron/common/config.py ?12:35
trinathsamotoki: ping12:35
jschwarztrinaths, I think they can be placed in other files as well, but really not sure12:35
trinathsjschwarz: True, but I have found this config option anywhere in neutron code.12:36
jschwarztrinaths, I found it in ./neutron/db/l3_dvr_db.py, line 4012:36
trinathsjschwarz: okay. seen it. But since its a global option, why can't it be moved to config.py12:38
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: NSX: Validate gateway device list against DB  https://review.openstack.org/11814812:39
jschwarztrinaths, I don't think it's a global option... If DVR is disable, why should there be a router_distirubted configuration?12:39
trinathsjschwarz: If, its present in neutron.conf, and not present in config.py. my unit testing doesn't need this DVR config. and its gives me such errors12:41
*** trinaths has quit IRC12:42
*** ZZelle has quit IRC12:43
*** prasoon has quit IRC12:45
*** prasoon has joined #openstack-neutron12:46
*** garyk has quit IRC12:47
*** mitarun has joined #openstack-neutron12:47
*** irenab has joined #openstack-neutron12:50
*** mitarun has quit IRC12:51
*** stanzgy has quit IRC12:52
Altranjschwarz: thanks for Your reviews, about https://review.openstack.org/#/c/117219 I think that Your suggestion about logging number of probes cleared is valid and not out of scope of patch  - do You think it's enough to log "%d probe(s) cleared" or distinguish 0 and non 0 ?12:55
*** sballe has joined #openstack-neutron12:55
jschwarzAltran, the more information (especially when it's a %d information), the merrier IMO12:55
jschwarzAltran, also your code was nice to review :)12:55
*** _cjones_ has joined #openstack-neutron12:56
Altranjschwarz: well they were simple fixes after all :)12:56
jschwarzXD12:56
jschwarzAltran, if you are adding a counter there, then I think a renaming of that function's name is a must12:57
Altranjschwarz: is it preferred to use singular in class names ? because its named ClearProbe12:59
*** lazy_prince is now known as killer_prince12:59
*** baoli has quit IRC13:00
*** baoli has joined #openstack-neutron13:00
*** _cjones_ has quit IRC13:00
*** JayJ has joined #openstack-neutron13:01
jschwarzAltran, I'd rename that as well to something like ProbeClearer13:01
jschwarzor something more elegant13:01
jschwarzClearProbe also hints that only one probe is cleared...13:01
Altranyeah, but there is ListProbe in the same file which has even less sense :D13:04
*** Longgeek has quit IRC13:04
*** shakamunyi has joined #openstack-neutron13:04
*** Longgeek has joined #openstack-neutron13:04
*** JayJ_ has joined #openstack-neutron13:09
*** shakamunyi has quit IRC13:09
openstackgerritAkihiro Motoki proposed a change to openstack/neutron: Fix comments in api.rpc.handlers  https://review.openstack.org/11816113:09
*** JayJ has quit IRC13:10
jschwarzAltran, I really don't know... it's starting to seem like quite a bit of renaming, so if I were you I'd try to put it in one patch set with a good excuse for the renaming13:10
jschwarzAltran, otherwise might be best to have 2 request changes with one of them doing the renaming13:11
jschwarzAltran, but I really don't know ;-<13:11
Altranjschwarz: I think I'll rename the method but leave class alone - will see what other reviewers will say about it13:13
jschwarzAltran, sounds like a plan :)13:14
*** rotbeard has quit IRC13:15
Altranhmm by the way I just thought I might consider changing my nick on IRC - I've had it registered from non OpenStack related use but it might be not optimal when someone tries to find me on IRC to discuss something13:19
*** mitarun has joined #openstack-neutron13:20
jschwarzlol yeah, I was quite surprised to find out you were Jacek :P13:20
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: NSX: Add a foreign key for gateway devices  https://review.openstack.org/9382613:20
jschwarzYou can identify to a different nick than the one you're using13:21
*** Altran is now known as jswiders13:21
*** irenab has quit IRC13:21
jschwarzjswiders++13:23
jswiders:)13:23
jschwarzbut now js<tab> doesn't always complete to me... :<13:23
*** JayJ_ has quit IRC13:24
jswidershehe ^^13:24
*** JayJ_ has joined #openstack-neutron13:26
*** JayJ_ has quit IRC13:28
openstackgerritJacek Swiderski proposed a change to openstack/neutron: Clarify message when no probes are cleared  https://review.openstack.org/11721913:32
rkukurasalv-orlando, amotoki: Thanks for the quick +2s on https://review.openstack.org/#/c/118140/. Looks like jenkins failed in https://review.openstack.org/#/c/118140/, which I’ve been seeing recently and does not seem possibly related to this patch. Should we go ahead and +A now, or recheck first?13:33
rkukurasalv-orlando, amotoki: The jenkins failure is tempest.scenario.test_network_advanced_server_ops.TestNetworkAdvancedServerOps.test_server_connectivity_resize in http://logs.openstack.org/40/118140/1/check/check-tempest-dsvm-neutron-full-2/79d3e03/console.html.13:33
amullerrkukura: I've seen that fail randomly recently as well13:34
amullerunrelated to patch13:34
amotokirkukura: actually both are same. If Jenkins post -1, check job will be run regardless of +A.13:34
rkukuraamotoki, amuller, salv-orlando: Do we have a bug associated with this random failure mode?13:35
*** salv-orlando has quit IRC13:35
openstackgerritAssaf Muller proposed a change to openstack/neutron: Add HA support to the l3 agent  https://review.openstack.org/7070013:37
openstackgerritAssaf Muller proposed a change to openstack/neutron: Test HA router failover  https://review.openstack.org/11799413:37
amotokirkukura: I don't know if we have or not. checking logstash.13:38
*** silverpuff has quit IRC13:39
*** simon-AS559 has quit IRC13:39
openstackgerritAkihiro Motoki proposed a change to openstack/neutron: Fix a bug in Mellanox plugin RPC caused by secgroup RPC refactoring  https://review.openstack.org/11816513:40
jswidersrkukura: https://bugs.launchpad.net/grenade/+bug/1349617 seems to be it (its also no1 in elastic recheck)13:40
*** tomoe_ has joined #openstack-neutron13:41
*** seizadi has joined #openstack-neutron13:41
rkukurajswiders: thanks13:43
jswidersbtw starting this week, weekly meetings are in new time slot ?13:44
rkukurajswiders: I thought that started after feature freeze, so next week13:45
jswidersrkukura: oh right - thanks :)13:46
*** Administrator_ has joined #openstack-neutron13:46
*** bvandenh has joined #openstack-neutron13:47
openstackgerritA change was merged to openstack/neutron: Introduces a keepalived manager for HA  https://review.openstack.org/6814213:48
*** openstack has joined #openstack-neutron13:57
*** openstackstatus has joined #openstack-neutron13:57
*** ChanServ sets mode: +v openstackstatus13:57
openstackgerritJacek Swiderski proposed a change to openstack/neutron: Clarify message when no probes are cleared  https://review.openstack.org/11721913:58
*** jab has quit IRC14:00
*** _cjones_ has quit IRC14:00
*** jab has joined #openstack-neutron14:02
*** jab has quit IRC14:02
*** jab has joined #openstack-neutron14:02
*** shakamunyi has joined #openstack-neutron14:05
*** lxsli has left #openstack-neutron14:06
*** yfauser has joined #openstack-neutron14:08
*** yfauser has left #openstack-neutron14:08
*** yfried_ has quit IRC14:09
*** roeyc has joined #openstack-neutron14:09
*** shakamunyi has quit IRC14:09
*** jprovazn has joined #openstack-neutron14:10
*** sballe has joined #openstack-neutron14:12
*** simon-AS559 has joined #openstack-neutron14:12
*** balles has joined #openstack-neutron14:13
*** Longgeek has quit IRC14:15
openstackgerritA change was merged to openstack/neutron: Apic drivers enhancements (second approach): Sync  https://review.openstack.org/11615714:15
openstackgerritJakub Libosvar proposed a change to openstack/neutron: Add functional test for IptablesManager  https://review.openstack.org/11785214:16
*** mlavalle has joined #openstack-neutron14:18
openstackgerritArvind Somya proposed a change to openstack/neutron: ML2 Type Driver refactor part 3  https://review.openstack.org/11515114:20
openstackgerritJacek Swiderski proposed a change to openstack/neutron: Fix condition for IPv6 attributes validation  https://review.openstack.org/11779914:20
*** Longgeek has joined #openstack-neutron14:21
*** BillTheKat has joined #openstack-neutron14:23
*** mlavalle has left #openstack-neutron14:24
yamamotorkukura: ping14:26
rkukurayamamoto: hi14:26
yamamotorkukura: do you have any comments on https://review.openstack.org/#/c/112947/ ?14:26
yamamotorkukura: nachi suggested to ask your input14:27
rkukurayamamoto: I glanced at it earlier, but will take a closer look ASAP14:27
yamamotorkukura: thank you!14:27
*** LiberTerra has joined #openstack-neutron14:34
*** miguel1 has joined #openstack-neutron14:34
rkukurayamamoto: LGTM! Any specific concerns?14:35
openstackgerritRossella Sblendido proposed a change to openstack/neutron: Remove locking from network and subnet delete op  https://review.openstack.org/11536014:35
*** aix has quit IRC14:36
yamamotorkukura: no specific concerns afaik.  nachi suggested to wait for your input because it's ml2 change.14:36
*** k4n0 has quit IRC14:37
rkukurayamamoto: Gave my +2/+A14:38
yamamotorkukura: thank you!14:39
*** dgollub has joined #openstack-neutron14:39
rkukurayamamoto: no problem!14:39
miguel1--14:40
*** miguel1 has quit IRC14:41
*** miguel1 has joined #openstack-neutron14:42
jschwarzjswiders, I added a comment to your ipv6 patch set14:42
*** miguel1 has quit IRC14:43
jschwarzjswiders, let me know if you don't agree with me :)14:43
*** miguel1 has joined #openstack-neutron14:43
*** tomoe_ has quit IRC14:44
*** leenheer has joined #openstack-neutron14:46
jswidersjschwarz: I was about to say why are You so negative with "if you don't agree" from start - but I do check situation with both ra_mode and address_mode - rightfully (or probably not) when I was refactoring my tests to helper function, I've also used it for test_update_subnet_ipv6_attributes from which I originated my tests14:47
*** yamamoto has quit IRC14:47
jschwarzjswiders, ah yes, you are right :)14:49
jschwarzjswiders, one sec14:49
jschwarzjswiders, better? :)14:49
*** miguel1 has quit IRC14:49
*** mlavalle_ has joined #openstack-neutron14:50
jswidersjschwarz: yup :)14:50
*** mlavalle_ has quit IRC14:50
jschwarzjswiders, i'm trying to be positive (sorry if it doesn't work all the time).. if I was negative you'd know ;-)14:50
*** tomoe_ has joined #openstack-neutron14:50
*** dave_tucker is now known as dave_tucker_zzz14:51
*** salv-orlando has joined #openstack-neutron14:51
jswidersjschwarz: if I didn't know that You are not him I would ask You if You are one of my friends - he would also apologize when I say he's to negative sometimes14:52
jschwarzjswiders, lol... can't help but being nice ;->14:53
jswidersjschwarz: well either way thanks for reviews :)14:53
jschwarzjswiders, sure thing... let me know if you have some more down the line14:54
*** sbfox has joined #openstack-neutron14:55
*** _cjones_ has joined #openstack-neutron14:56
*** HenryG has joined #openstack-neutron14:57
*** BillTheKat has quit IRC14:59
*** sbfox has quit IRC14:59
*** _cjones_ has quit IRC15:01
*** aix has joined #openstack-neutron15:01
*** jschwarz has quit IRC15:01
*** trinaths has joined #openstack-neutron15:02
*** mspreitz has joined #openstack-neutron15:03
*** tomoe_ has quit IRC15:05
*** shakamunyi has joined #openstack-neutron15:06
*** jswiders has quit IRC15:07
trinathsHi15:07
trinathsamotoki: ping, if you are free we can discuss.15:07
amotokitrinaths: it's too late to me. now going to bed.15:08
trinathsamotoki: okay, np, Good Night15:08
*** lori is now known as lori|away15:10
*** shakamunyi has quit IRC15:10
rkukuraamotoki: Jenkins passed this time, so do you want to do the +A on https://review.openstack.org/#/c/118140/?15:10
openstackgerritMiguel Angel Ajo proposed a change to openstack/neutron: Implements ProcessMonitor to watch over external processes  https://review.openstack.org/11279815:10
rkukuraamotoki: Thanks!15:11
amotokirkukura: nice! approved.15:11
*** sballe has quit IRC15:13
*** jogo_ is now known as jogo15:14
*** mitarun has quit IRC15:14
*** Longgeek_ has joined #openstack-neutron15:16
*** markvoel_ has joined #openstack-neutron15:19
*** Longgeek has quit IRC15:19
*** markvoel_ has quit IRC15:19
*** SridharG has left #openstack-neutron15:23
*** amotoki has quit IRC15:26
*** cnesa9 has joined #openstack-neutron15:28
*** mitarun has joined #openstack-neutron15:28
*** r-daneel has joined #openstack-neutron15:29
*** bvandenh has quit IRC15:29
*** r-daneel has quit IRC15:29
*** r-daneel has joined #openstack-neutron15:29
openstackgerritenikanorov proposed a change to openstack/neutron: Fix setup.cfg so setup could succeed  https://review.openstack.org/11817615:31
*** sgordon_ has joined #openstack-neutron15:31
*** a_le has quit IRC15:34
*** mitarun has quit IRC15:34
*** mitarun has joined #openstack-neutron15:34
*** sbfox has joined #openstack-neutron15:36
*** pasquier-s has quit IRC15:38
*** mitarun has quit IRC15:39
*** _cjones_ has joined #openstack-neutron15:40
*** seizadi has quit IRC15:40
*** a_le has joined #openstack-neutron15:40
*** padkrish has joined #openstack-neutron15:41
*** padkrish has joined #openstack-neutron15:42
*** _cjones_ has quit IRC15:43
*** mlavalle_ has joined #openstack-neutron15:43
*** _cjones_ has joined #openstack-neutron15:43
mlavalle_mestery: what time are we meeting today?15:43
*** ryu25 has joined #openstack-neutron15:43
*** mestery_ has joined #openstack-neutron15:45
mlavalle_meta2-18~ /window -115:45
*** mestery has quit IRC15:46
*** yamamoto has joined #openstack-neutron15:47
*** _cjones_ has quit IRC15:48
*** balles has quit IRC15:48
marunmlavalle_: at late o'clock for all of us on the other side of utc15:48
marunmlavalle_: the alternate time doesn't start till next week15:48
mlavalle_marun: yeah, that's really what I wanted to know :-)15:49
marunmlavalle_: :)15:49
*** roeyc has quit IRC15:51
*** yamamoto has quit IRC15:51
*** mlavalle_ has quit IRC15:54
*** skolekonov has quit IRC15:54
*** mlavalle_ has joined #openstack-neutron15:54
*** thomasem has joined #openstack-neutron15:56
*** dbite has quit IRC15:57
*** mitarun has joined #openstack-neutron15:58
*** devvesa has quit IRC16:04
*** shakamunyi has joined #openstack-neutron16:06
*** shakamunyi has quit IRC16:11
*** otherwiseguy has joined #openstack-neutron16:13
*** leenheer has quit IRC16:14
*** ZZelle has joined #openstack-neutron16:18
openstackgerritJacek Swiderski proposed a change to openstack/neutron: Clarify message when no probes are cleared  https://review.openstack.org/11721916:22
*** matrohon has quit IRC16:22
*** ryu25 has quit IRC16:22
*** aix has quit IRC16:23
*** simon-AS559 has quit IRC16:25
*** baoli has joined #openstack-neutron16:25
*** salv-orlando has quit IRC16:25
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy API-2: Classifiers, Actions, and Rules  https://review.openstack.org/10181616:28
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy Mapping API-1: EP, EPG, L2 Policy, L3 Policy  https://review.openstack.org/10071616:28
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy Mapping Plugin-1: EP, EPG, L2 Policy, L3 Policy  https://review.openstack.org/10195716:28
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy Plugin-1: EP, EPG, L2 Policy, L3 Policy  https://review.openstack.org/9639316:28
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy: Resource Mapping Driver (2)  https://review.openstack.org/11377516:28
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy Plugin-2: Classifiers, Actions, and Rules  https://review.openstack.org/10346516:28
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy API-3: Contracts  https://review.openstack.org/10348616:28
openstackgerritStephen Wong proposed a change to openstack/neutron: Group Policy API-1: EP, EPG, L2 Policy, L3 Policy  https://review.openstack.org/9590016:28
*** otherwiseguy has quit IRC16:30
*** dfarrell07 has joined #openstack-neutron16:30
*** padkrish has quit IRC16:31
*** ijw has joined #openstack-neutron16:32
openstackgerritJakub Libosvar proposed a change to openstack/neutron: Add functional test for IptablesManager  https://review.openstack.org/11785216:33
*** dbite has joined #openstack-neutron16:35
*** aix has joined #openstack-neutron16:36
*** ijw has quit IRC16:37
*** ijw has joined #openstack-neutron16:37
*** Longgeek_ has quit IRC16:40
*** luqas has quit IRC16:40
*** sballe has joined #openstack-neutron16:40
*** Longgeek has joined #openstack-neutron16:40
*** Longgeek_ has joined #openstack-neutron16:41
*** sballe has quit IRC16:41
*** afazekas has quit IRC16:41
*** _cjones_ has joined #openstack-neutron16:42
*** Longgee__ has joined #openstack-neutron16:44
*** Longgeek has quit IRC16:45
*** yamamoto has joined #openstack-neutron16:45
*** Longgeek_ has quit IRC16:48
*** simon-AS559 has joined #openstack-neutron16:49
openstackgerritTrinath Somanchi proposed a change to openstack/neutron: Freescale FWaaS Plugin  https://review.openstack.org/10965916:50
*** yamamoto has quit IRC16:50
*** simon-AS5591 has joined #openstack-neutron16:51
*** padkrish has joined #openstack-neutron16:51
*** leenheer has joined #openstack-neutron16:52
*** simon-AS559 has quit IRC16:53
*** tflynn has joined #openstack-neutron16:55
*** leenheer has quit IRC16:59
*** gizmoguy_ has quit IRC16:59
*** ygbo has quit IRC16:59
*** rm_work|away is now known as rm_work17:01
*** safchain has quit IRC17:01
*** diegows has quit IRC17:02
*** amaretskiy has quit IRC17:05
*** padkrish has quit IRC17:06
openstackgerritRobert Kukura proposed a change to openstack/neutron: ML2: Driver API changes for hierarchical port binding  https://review.openstack.org/11511017:07
openstackgerritRobert Kukura proposed a change to openstack/neutron: ML2: DB changes for hierarchical port binding  https://review.openstack.org/11612217:07
openstackgerritRobert Kukura proposed a change to openstack/neutron: ML2: Hierarchical port binding  https://review.openstack.org/11620917:07
*** shakamunyi has joined #openstack-neutron17:07
*** rm_work is now known as rm_work|away17:10
*** shakamunyi has quit IRC17:12
*** amuller has quit IRC17:13
*** SumitNaiksatam has quit IRC17:14
*** SumitNaiksatam has joined #openstack-neutron17:14
*** rm_work|away is now known as rm_work17:15
openstackgerritIvar Lazzaro proposed a change to openstack/neutron: Apic drivers enhancements (second approach): Topology  https://review.openstack.org/11678017:17
*** ijw has quit IRC17:17
*** tflynn has quit IRC17:17
*** otherwiseguy has joined #openstack-neutron17:17
*** ijw has joined #openstack-neutron17:18
*** rm_work is now known as rm_work|away17:21
openstackgerritKevin Benton proposed a change to openstack/neutron: Adds external attachment type validators to ML2  https://review.openstack.org/11618717:21
kevinbentonrkukura: can you take a look at https://review.openstack.org/#/c/116187/17:22
kevinbentonrkukura: it was the port binding of physical ports we talked about before17:22
kevinbentons/was/is/g17:22
openstackgerritKevin Benton proposed a change to openstack/neutron: BSN: Bind external ports in ML2 driver  https://review.openstack.org/11618817:24
*** yamamoto has joined #openstack-neutron17:25
*** gizmoguy has joined #openstack-neutron17:28
*** yamamoto has quit IRC17:30
*** thomasem has quit IRC17:32
openstackgerritKevin Benton proposed a change to openstack/neutron: BSN: Bind external ports in ML2 driver  https://review.openstack.org/11618817:32
*** padkrish has joined #openstack-neutron17:32
*** prasoon has quit IRC17:39
*** padkrish has quit IRC17:44
*** simon-AS559 has joined #openstack-neutron17:44
*** simon-AS5591 has quit IRC17:44
openstackgerritA change was merged to openstack/neutron: Remove old policies from policy.json  https://review.openstack.org/11758617:45
*** claudiub has quit IRC17:45
*** simon-AS559 has quit IRC17:45
*** simon-AS5591 has joined #openstack-neutron17:45
*** padkrish has joined #openstack-neutron17:46
*** trinaths has quit IRC17:51
*** trinaths has joined #openstack-neutron17:51
*** thomasem has joined #openstack-neutron17:52
*** devvesa has joined #openstack-neutron17:52
openstackgerritKevin Benton proposed a change to openstack/neutron: Big Switch: Separate L3 functions into L3 service  https://review.openstack.org/11365317:53
*** thomasem has quit IRC17:53
*** gizmoguy has quit IRC17:54
*** thomasem has joined #openstack-neutron17:54
*** padkrish has quit IRC17:56
*** gizmoguy has joined #openstack-neutron17:56
*** bjornar_ has joined #openstack-neutron17:56
*** devvesa has quit IRC17:57
*** rook has joined #openstack-neutron17:57
*** JayJ_ has joined #openstack-neutron18:02
*** tsg has joined #openstack-neutron18:02
*** _cjones_ has quit IRC18:03
*** _cjones_ has joined #openstack-neutron18:04
*** diegows has joined #openstack-neutron18:05
*** karimb has quit IRC18:07
*** Zemeio has joined #openstack-neutron18:08
*** shakamunyi has joined #openstack-neutron18:08
*** _cjones_ has quit IRC18:08
*** mestery_ is now known as mestery18:10
*** dgollub has quit IRC18:12
*** jp_at_hp has quit IRC18:12
*** trinaths has quit IRC18:12
*** shakamunyi has quit IRC18:13
*** Longgee__ has quit IRC18:13
*** yamamoto has joined #openstack-neutron18:15
*** SumitNaiksatam has quit IRC18:16
*** SumitNaiksatam has joined #openstack-neutron18:16
*** yfried_ has joined #openstack-neutron18:17
*** yamamoto has quit IRC18:20
*** rook has quit IRC18:20
*** mitarun has quit IRC18:30
*** linuxgeek_ has joined #openstack-neutron18:30
*** mitarun has joined #openstack-neutron18:31
*** JayJ_ has quit IRC18:32
rkukurakevinbenton: I will as soon as I can - probably this evening18:33
linuxgeek_hi, will these two be merged in juno 3? https://review.openstack.org/#/c/111876/ and https://review.openstack.org/#/c/115575/18:33
*** _cjones_ has joined #openstack-neutron18:35
*** mitarun has quit IRC18:36
*** aix has quit IRC18:36
openstackgerritIvar Lazzaro proposed a change to openstack/neutron: Apic drivers enhancements (second approach): Topology  https://review.openstack.org/11678018:37
*** jlibosva has quit IRC18:37
*** sbfox has quit IRC18:37
*** sbfox has joined #openstack-neutron18:39
openstackgerritKevin Benton proposed a change to openstack/neutron: Big Switch: Bind IVS ports in ML2 driver  https://review.openstack.org/11374918:39
*** zhhuabj has quit IRC18:40
kevinbentonrkukura: ok. thanks18:40
*** JayJ_ has joined #openstack-neutron18:44
*** mlavalle_ has quit IRC18:46
*** mlavalle_ has joined #openstack-neutron18:46
*** SumitNaiksatam has quit IRC18:46
*** SumitNaiksatam has joined #openstack-neutron18:47
*** mlavalle_ has quit IRC18:49
*** mlavalle_ has joined #openstack-neutron18:49
*** zhhuabj has joined #openstack-neutron18:52
*** gizmoguy has quit IRC18:53
kevinbentonmestery: is there a neutron meeting today, or are we on the new alternating schedule?18:55
*** diegows has quit IRC18:55
*** dgollub has joined #openstack-neutron18:56
*** JayJ_ has quit IRC18:56
mlavalle_kevinbenton: we are meeting at 21:00 utc, as normal18:57
kevinbentonmlavalle_: thanks18:57
*** _cjones_ has quit IRC18:58
mlavalle_kevinbenton: np :-)18:58
*** _cjones_ has joined #openstack-neutron18:58
*** dfarrell07 has quit IRC18:59
*** mlavalle_ has quit IRC19:01
*** mlavalle_ has joined #openstack-neutron19:01
*** arosen has joined #openstack-neutron19:02
*** _cjones_ has quit IRC19:03
*** _cjones_ has joined #openstack-neutron19:03
*** marun has quit IRC19:04
*** mlavalle_ has quit IRC19:05
*** mlavalle_ has joined #openstack-neutron19:05
*** padkrish has joined #openstack-neutron19:06
*** diegows has joined #openstack-neutron19:07
*** _cjones_ has quit IRC19:08
*** padkrish has quit IRC19:11
*** dgollub has quit IRC19:11
*** mlavalle_ has quit IRC19:14
*** dgollub has joined #openstack-neutron19:14
*** mlavalle_ has joined #openstack-neutron19:15
*** yamamoto has joined #openstack-neutron19:15
ZZelleSumitNaiksatam, hi19:18
SumitNaiksatamZZelle: hi19:18
ZZelleSumitNaiksatam, one question about FWaaS, what is the meaning of the attribute audited in FirewallPolicy object/table?19:19
*** mlavalle_ has quit IRC19:19
*** JayJ_ has joined #openstack-neutron19:19
*** mlavalle_ has joined #openstack-neutron19:19
SumitNaiksatamZZelle: so some context is required to explain that19:19
*** yamamoto has quit IRC19:20
SumitNaiksatamZZelle: so usually the IT departments have separate security teams and infra/network admin teams19:20
SumitNaiksatamZZelle: it is expected that the security teams “audit” the firewall policy19:20
ZZelleSumitNaiksatam, one of my usual pain19:20
SumitNaiksatamZZelle: :-)19:21
SumitNaiksatamZZelle: the infra team then uses this policy19:21
SumitNaiksatamZZelle: so the security team crafts, say a pci compliant policy19:21
SumitNaiksatamZZelle: it then marks it as audited19:22
ZZelleSumitNaiksatam, ok19:22
ZZelleSumitNaiksatam, so security team set a policy as audited and becomes unaudited on update but non-security peoples?19:22
SumitNaiksatamZZelle: but it does not care who is using it19:22
mesterykevinbenton: There is a neutron meeting today19:22
ZZelles/but/by19:22
SumitNaiksatamZZelle: yeah, so if someone else goes and modifies that policy we un-audit it19:22
SumitNaiksatamZZelle: per the organization workflow, this has to be go back to the security team for auditing19:23
SumitNaiksatamZZelle: the audit used here has nothing to do with audit logs, in case that is the source of confusion19:23
SumitNaiksatamZZelle: this attribute was added per feedback from the operators (who deal with this workflow) and firewall vendors19:24
*** r-daneel has quit IRC19:24
ZZelleSumitNaiksatam, i better understand because based on neutron code audited is not useful19:25
SumitNaiksatamZZelle: its just a boolean19:25
SumitNaiksatamZZelle: as far as neutron code is concerned19:25
SumitNaiksatamZZelle: with some small amount of knowledge on when its set or unset19:26
ZZelleSumitNaiksatam, speaking of audit logs is there any intentions to support LOG action in FWaaS for K or L+ releases?19:26
SumitNaiksatamZZelle: but we dont use it in any other processing19:26
SumitNaiksatamZZelle: there has always been an intention19:26
*** cnesa9 has quit IRC19:26
SumitNaiksatamZZelle: but its become very difficult to get any features in19:27
SumitNaiksatamZZelle: in this release we proposed the “service groups” feature (actually it has been proposed for more than two iterations now)19:27
SumitNaiksatamZZelle: but even that will not get in19:28
SumitNaiksatamZZelle: so intention yes, not sure when19:28
ZZelleSumitNaiksatam, i would be interested in 2 FWaaS features LOG action and rate limits in FW rules19:28
SumitNaiksatamZZelle: sure, good to know19:29
SumitNaiksatamZZelle: rate limits might be a little difficult to implement with the reference implementation19:29
ZZellewaiting for Kilo-specs :)19:29
SumitNaiksatamZZelle: yes, sure please feel free to add the spec19:30
*** roeyc has joined #openstack-neutron19:30
ZZelleSumitNaiksatam, i didn't look after seeing the discussion about service groups, i thought it was not the right time19:30
SumitNaiksatamZZelle: yeah19:31
SumitNaiksatamZZelle: right now the focus on getting the high priority stuff into J319:31
*** _cjones_ has joined #openstack-neutron19:31
*** marun has joined #openstack-neutron19:32
*** drjones has joined #openstack-neutron19:35
*** _cjones_ has quit IRC19:36
*** sgran has quit IRC19:39
*** drjones has quit IRC19:39
ZZelleSumitNaiksatam, after looking at update_firewall use, the lockmode in it seems unrequired (https://review.openstack.org/117022)19:40
*** _cjones_ has joined #openstack-neutron19:40
*** devvesa has joined #openstack-neutron19:41
*** _cjones_ has quit IRC19:45
*** devvesa has quit IRC19:46
*** sambetts has quit IRC19:49
openstackgerritKevin Benton proposed a change to openstack/neutron: Big Switch: Separate L3 functions into L3 service  https://review.openstack.org/11365319:50
*** dbite has quit IRC19:53
*** jprovazn has quit IRC19:58
*** mlavalle_ has quit IRC20:02
*** mlavalle_ has joined #openstack-neutron20:02
*** yamamoto has joined #openstack-neutron20:15
*** yamamoto has quit IRC20:17
*** yamamoto has joined #openstack-neutron20:17
*** sgran has joined #openstack-neutron20:21
*** yamamoto has quit IRC20:22
*** seizadi has joined #openstack-neutron20:24
*** ijw has quit IRC20:24
openstackgerritA change was merged to openstack/neutron: l2pop: Allow network types overridable  https://review.openstack.org/11294720:26
*** cnesa9 has joined #openstack-neutron20:26
*** terryw has joined #openstack-neutron20:29
*** otherwiseguy has quit IRC20:30
*** seizadi has quit IRC20:31
*** salv-orlando has joined #openstack-neutron20:32
*** mlavalle_ has quit IRC20:33
*** mlavalle_ has joined #openstack-neutron20:33
*** a_le has quit IRC20:34
*** mlavalle_ has quit IRC20:34
*** mlavalle_ has joined #openstack-neutron20:34
*** seizadi has joined #openstack-neutron20:36
*** terryw has quit IRC20:41
mlavalle_yfried_: you around?20:43
yfried_mlavalle_: more or less20:43
mlavalle_yfried_: so, all the changes you are making to tempest.scenario.manager.NetworkScenarioTest are contained here: https://review.openstack.org/#/c/111719/?20:45
yfried_mlavalle_: yeah?20:45
mlavalle_yfried_: I intend to migrate the the load balancer basic scenario test to tempest neutron client. I'll rebase it on top of your patchset20:46
yfried_mlavalle_: I was going to do it tomorrow (today).20:47
mlavalle_yfried_: well, I am working with the lbaas v2 guys. So it will serve me as a warmp up if that's opk with you20:48
mlavalle_yfried_: ok with you^^^20:48
*** seizadi has quit IRC20:48
mlavalle_yfried_: the next step will be to translate that test to the new lbaas20:48
yfried_sure. if you have the time. go ahead20:49
yfried_mlavalle_: just add your name to the pad20:50
mlavalle_yfried_: : this pad https://etherpad.openstack.org/p/tempest-client-scenarios?20:51
enikanorov__yfried_: mlavalle_hii folks, could you help me to push https://review.openstack.org/#/c/116581/20:52
enikanorov__?20:52
enikanorov__it's needed to fix some ipv6-related issue in neutron API20:53
yfried_enikanorov__: I'll take a look tomorrow (please ping me in 8 hours)20:53
enikanorov__yfried_: sure20:54
mlavalle_yfried_: is that the etherpad?20:54
yfried_mlavalle_: yes20:54
mlavalle_yfried_: :-)20:54
mlavalle_enikanorov__: yes, of course i'll help20:54
*** nati_ueno has joined #openstack-neutron20:56
*** zhhuabj has quit IRC20:57
*** zhhuabj has joined #openstack-neutron20:58
*** yamamoto has joined #openstack-neutron20:58
*** markmcclain has joined #openstack-neutron20:59
*** emagana has joined #openstack-neutron20:59
*** doude has quit IRC20:59
*** packet has joined #openstack-neutron21:00
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: NSX: Add a foreign key for gateway devices  https://review.openstack.org/9382621:01
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: NSX: Validate gateway device list against DB  https://review.openstack.org/11814821:01
*** gizmoguy has joined #openstack-neutron21:01
*** stenchlarge has joined #openstack-neutron21:01
*** obondarev_ is now known as obondarev21:02
*** networkstatic has joined #openstack-neutron21:02
*** otherwiseguy has joined #openstack-neutron21:04
*** packet has quit IRC21:04
*** packet has joined #openstack-neutron21:04
*** jlibosva has joined #openstack-neutron21:04
*** mspreitz has quit IRC21:06
openstackgerritArvind Somya proposed a change to openstack/neutron: ML2 Type Driver refactor part 3  https://review.openstack.org/11515121:06
*** moha_hunt has joined #openstack-neutron21:07
*** ajo__ has joined #openstack-neutron21:09
*** terryw has joined #openstack-neutron21:10
*** otherwiseguy has quit IRC21:13
openstackgerritA change was merged to openstack/neutron: Remove reference to cisco_cfg_agent.ini from setup.cfg again  https://review.openstack.org/11809221:14
*** pack3t has joined #openstack-neutron21:17
*** ivar-lazzaro has quit IRC21:18
*** amotoki has joined #openstack-neutron21:18
*** packet has quit IRC21:18
*** pack3t is now known as packet21:18
*** terryw has quit IRC21:19
*** otherwiseguy has joined #openstack-neutron21:26
*** bjornar_ has quit IRC21:27
*** a_le has joined #openstack-neutron21:28
*** markmcclain has quit IRC21:28
openstackgerritAaron Rosen proposed a change to openstack/neutron: Replace range with xrange  https://review.openstack.org/11821921:29
*** devvesa has joined #openstack-neutron21:30
openstackgerritAaron Rosen proposed a change to openstack/neutron: Log error for failed update_device|(up/down)  https://review.openstack.org/11470521:34
*** devvesa has quit IRC21:35
rkukuraanyone know how to debug gate-neutron-dsvm-functional failures, as in http://logs.openstack.org/40/118140/1/gate/gate-neutron-dsvm-functional/54fc625/?21:37
marunrkukura: was just wondering the same thing21:37
marunrkukura: The first step is figuring out why the test output is not being logged21:38
*** ijw has joined #openstack-neutron21:38
marunsalv-orlando: any ideas? http://logs.openstack.org/40/118140/1/gate/gate-neutron-dsvm-functional/54fc625/console.html21:38
marunsalv-orlando: the test run is failing but there is no output being saved21:38
*** kakuma has joined #openstack-neutron21:38
salv-orlandomarun: looking21:39
marunsalv-orlando: after failure it looks like it can't find nose or testr results21:39
salv-orlandomarun: perhas because teste did not even start? checking21:40
salv-orlandomarun: what about this? http://logs.openstack.org/40/118140/1/gate/gate-neutron-dsvm-functional/54fc625/console.html#_2014-09-01_20_33_33_84921:40
marunsalv-orlando: forest for the trees :/21:41
rkukurasalv-orlando: That’s the first thing I noticed, but it doesn’t give me any clue what went wrong21:42
marunsalv-orlando: hmmm, did the changes to support full-ext merge?21:42
salv-orlandonope it did not21:42
marunvery curious21:42
salv-orlandowhat does logstash say?21:43
marunlooking21:43
marunsalv-orlando: I look for 'InvocationError' and get nothing for the functional job :/21:44
marunoh, wait21:44
salv-orlandoit started on friday 29/821:45
salv-orlandoand we had 25 hits - always and only on the functional job21:45
marunsalv-orlando: *sigh*21:47
marunmaybe a revert is in order21:47
kevinbentonsalv-orlando: re: the external router IP patch. based on your feedback I imagine this will not make it into Juno21:48
marunsalv-orlando: https://github.com/openstack/neutron/commit/66730877ee8c4389550295c77db88029e3b8e60521:48
*** otherwiseguy has quit IRC21:48
*** otherwiseguy has joined #openstack-neutron21:49
kevinbentonsalv-orlando: https://review.openstack.org/#/c/83664/  What do you think about a separate patch to allow reading the external IP so the VPNaaS people can be unblocked?21:49
*** karimb has joined #openstack-neutron21:49
salv-orlandokevinbenton: I am not putting a block there. I’m just saying that regardless of whether it merges or not - external_gateway_info needs to be reviewed21:49
salv-orlandoif this is holding something important you should ask for raising priority and get an FFE21:49
kevinbentonsalv-orlando: only the read access is holding something important21:50
salv-orlandokevinbenton: I do not distribute those - that’s mestery’s task. I can only advice you ask for one.21:50
kevinbentonsalv-orlando: that’s why it might make sense to separate them21:50
*** mlavalle_ has quit IRC21:51
salv-orlandokevinbenton: ok I do not have the details to judge how important it is. As I said, it’s not a big deal for me if we add yet another sub-attribute there. I just think that external_gateway_info is messy. However, it might be important for you to raise a point about that blueprint re its priority. I can give it another rewier or two before thursday, but another core dev is needed.21:51
nati_uenoI thinks this one is important.21:52
nati_uenovpnaas is blocked21:53
*** mlavalle_ has joined #openstack-neutron21:53
nati_uenoso let me help21:53
rkukuramarun, salv-orlando: Do we know what’s causing these gate-neutron-dsvm-functional failures, or why there are actual test results logged?21:55
kevinbentonnati_ueno: okay. I will address salv-orlando’s latest comments and upload a patch21:55
*** jlibosva has quit IRC21:55
marunrkukura: the test results are not being logged, so no, we don't know why.21:55
kevinbentonnati_ueno: or are you reviewing the current one already?21:55
marunrkukura: I'm trying to figure that out now.21:56
rkukuraI see this has been happening pretty regularly since 8/29: http://logstash.openstack.org/#eyJzZWFyY2giOiJcIkVSUk9SOiBJbnZvY2F0aW9uRXJyb3I6ICcvb3B0L3N0YWNrL25ldy9uZXV0cm9uLy50b3gvZHN2bS1mdW5jdGlvbmFsL2Jpbi9weXRob24gLW0gbmV1dHJvbi5vcGVuc3RhY2suY29tbW9uLmxvY2t1dGlscyBweXRob25cIiIsImZpZWxkcyI6W10sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiNjA0ODAwIiwiZ3JhcGhtb2RlIjoiY291bnQiLCJ0aW1lIjp7InVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTQwOTYwODI4NTgyMn0=21:56
marunrkukura: it's periodic so a recheck might get your change through while I figure out how to fix or whether to turn off the job21:56
nati_uenokevinbenton: I have reviewed current one, and thinking.. I think what Salvatore's comment makes sense for me21:56
rkukuramarun: I’ve been fighting this all day on several different patches.21:57
*** mlavalle_ has quit IRC21:58
marunrkukura: there have been 6 failures today, not exactly a constant21:58
rkukuramarun: Thanks for investigating21:58
marunrkukura: (from the functional job)21:58
marunrkukura: I've had more issues with the full job21:58
marunrkukura: but making it non-voting is probably the next step.21:58
marunrkukura: I didn't realize the test results weren't being logged on failure until now.21:58
*** baoli has quit IRC21:59
salv-orlandomarun: that makes it one of the top 10 gate offenders (I think)21:59
salv-orlandomarun: one question abotu pre-gate hoot.21:59
salv-orlandomeh hook21:59
salv-orlandomarun: does it run devstack-gate as well?21:59
marunsalv-orlando: it does21:59
rkukuramarun: When you see in zuul that a job has a random failure such as this, is there a way to interrupt it and restart the check/verify without waiting for the doomed run to complete?21:59
marunsalv-orlando: and unfortunately we're still waiting on the patches to unstack21:59
marunsalv-orlando: it's making it through devstack though22:00
salv-orlandomarun: seen that.22:00
marunsalv-orlando: given the timing I'm guessing it's the l3 agent test addition that merged on friday22:00
marunsalv-orlando: I'm thinking making it non-voting (again) is the easiest way forward.22:01
marunsalv-orlando: It takes so long to get changes pushed that getting logging output might take a while22:02
*** nati_ueno has quit IRC22:03
*** nati_ueno has joined #openstack-neutron22:04
salv-orlandomarun: the point is that there is no logging output22:05
salv-orlandoin my opinion tox is crashing at startup —> Ran 15 tests in 12.477s22:05
salv-orlandoI think functional tests normally take a lot more that 12 seconds22:05
marunsalv-orlando: I don't think so22:05
marunsalv-orlando: there aren't that many22:06
marunsalv-orlando: I'll check though22:06
salv-orlandomarun: the other hint is that it run 15 tests.22:06
marunsalv-orlando: also correct22:06
salv-orlandoSome test might be calling a sys.exit which quits the test runner22:06
marunwe're just getting started with functional tests22:06
marunI guess we can't rule that out, but without test output it's just guessing22:06
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Ignore unknown l2pop entry removals  https://review.openstack.org/11444322:07
marunsalv-orlando: I've posted a change to make the job non-voting until we figure it out.22:07
marunsalv-orlando: I don't see any infra folks to take action thought22:08
marunthough22:08
openstackgerritMiguel Angel Ajo proposed a change to openstack/neutron: Implements the ProcessMonitor in the dhcp_agent and dnsmasq driver  https://review.openstack.org/11593522:08
*** nati_ueno has quit IRC22:08
*** emagana has quit IRC22:09
salv-orlandomarun: if you ping them they will respond22:10
salv-orlandowell most of them are us based22:10
salv-orlandoand the others are sleeping22:11
salv-orlandoso maybe not now22:11
marunsalv-orlando: I've mentioned them in #openstack-infra22:11
*** ijw has quit IRC22:11
marunalso seeing if I can reproduce locally22:11
marunit's periodic but maybe with repeated runs I can reproduce22:12
salv-orlandomarun: I think there is a relationship between this failure and parallel execution22:12
salv-orlandoit seems the server are starting 4 workers22:12
salv-orlandoyou should to the same22:12
salv-orlandoand by server I mean the upstream gate22:12
marunsalv-orlando: :(22:13
marunsalv-orlando: missing rootwrap filter might be to blame22:14
openstackgerritMiguel Angel Ajo proposed a change to openstack/neutron: Implements the ProcessMonitor in the l3_agent  https://review.openstack.org/11493122:15
marunfalse alarm.  my config is outdated22:15
salv-orlandoI think the l3 agent tests are triggering a sys.exit on the test runner. How that happens it is a mistery for me.22:17
marunsalv-orlando: it doesn't look like passing jobs are saving test results either though :/22:22
salv-orlandomarun: it depends on what results you want. The job you’vee defined saves all the logs as you would have in a tempest run22:23
salv-orlandowhile here I think you’re looking for the subunit log22:23
salv-orlandowhich instead is saved by unit test jobs22:23
salv-orlandoI agree the subunit log should reveal where the test crashes.22:23
salv-orlandoI’ve been looking at these l3 agent tests - is this “gray box” approach something that has been agreed with you?22:24
marunsalv-orlando: Hmmm22:24
marunsalv-orlando: I was one of the approvers22:25
marunsalv-orlando: I guess i need some educating.22:25
salv-orlandoI am looking at the l3 agent tests - they do not exercise the running l3 agent, but they call l3 agent internal functions and then verify that the appropriate configuration (namespace, interfaces, etc) has been performed22:25
salv-orlandoI think it’s fine.22:25
salv-orlandoI just don’t understand why we’re running a full devstack suite? Maybe because other tests are designe differently?22:26
marunsalv-orlando: devstack is only needed to install dependencies22:26
marunsalv-orlando: right now that means a full run22:26
marunsalv-orlando: the next step is only install neutron and unstack right after - patches are in flight for that22:26
salv-orlandomarun: got it.22:27
marunsalv-orlando: and the follow-on will be updating devstack to support installation of dependencies + source tree without starting anything22:27
marunsalv-orlando: the tests are going to be a bit scattershot at first while we figure out what constitutes good tests of system interaction22:28
marunsalv-orlando: some will be low-level (i.e. exercising individual functions), some will be high level (exercising whole agents)22:28
*** moha_hunt has quit IRC22:29
salv-orlandothat’s fine for me. I’ve seen that you have correctly added test-results to your publishers.22:30
marunsalv-orlando: I am clearly ignorant of the possible failure modes, though.22:30
salv-orlandoso you should have detailed testr loggign22:30
marunsalv-orlando: testr results don't seem to show up even on success22:30
marunsalv-orlando: http://logs.openstack.org/65/102465/4/check/check-neutron-dsvm-functional/9b01d7e/console.html22:31
salv-orlandomarun: they are copied only on failures - see macros.yaml22:31
marunsalv-orlando: hmmm22:31
salv-orlandoin config/modules/openstack_project/jenkins_job_builder.config22:31
marunsalv-orlando: so why aren't they showing up in this case?22:31
marunsalv-orlando: is there no way to debug sys.exit()-caused failure?22:31
salv-orlandowell because of this -> http://logs.openstack.org/40/118140/1/gate/gate-neutron-dsvm-functional/54fc625/console.html#_2014-09-01_20_33_51_76822:31
marunsalv-orlando: because that prevents output from being saved?22:31
kevinbentonmestery: can you take a quick look at https://review.openstack.org/#/c/113653/ again? You were ready to +2 before but were waitng for the Big Switch CI22:32
salv-orlandosys.exit are a nightmare22:32
salv-orlandowe had that problem with ml2 in unit tests for a while22:32
kevinbentonraise SystemExit can be caught by the test runner, right?22:32
salv-orlandoyou only saw that the test runner failed but you did not know why and where22:32
marunsalv-orlando: arg. none of the functional tests thus far have gone anywhere near sys.exit.  but the l3 tests are likely exercising something that does22:32
salv-orlandomarun: probably22:33
*** mlavalle_ has joined #openstack-neutron22:33
salv-orlandokevinbenton: I’m pretty sure people have tried that already. If that did not work, I trust there might be a reason, even if I do not know which one it might be. I tend to assume people are not dumb ;)22:33
marunsalv-orlando: we can mock it out22:34
salv-orlandoyou can try that22:34
marunsalv-orlando: there are tests that do just that.  maybe it's time we did one in the base class22:34
kevinbentonsalv-orlando: i don’t understand. do you mean they tried raising SystemExit?22:34
salv-orlandokevinbenton: the problem is that a test can crash the test runner by calling sys.exit22:35
salv-orlandothe testrunner process will quit22:35
kevinbentonseveral calls to sys.exit() in the linux/daemon.py file http://paste.openstack.org/show/104418/22:35
salv-orlandono tests will be executed naymore22:35
kevinbentonsalv-orlando: right, i completely understand that. I meant that I think the test runner can catch the systemExits easier22:35
kevinbentonsalv-orlando: so perhaps we should replace all sys.exits() with raise SystemExit()22:36
salv-orlandokevinbenton: yeah we grepped that before, now we’re trying to understand how the functional tests could exercuse that path22:36
kevinbentonsalv-orlando: ok. i’ll shut up now :-)22:36
salv-orlandokevinbenton: maybe yes, it was done for other bits already. Mocking is an option.22:36
salv-orlandoYou can keep talking no worries… I need to go to bed now anyway22:37
salv-orlandoThis time I won’t let you keeping me up until 3 am!22:37
marunsalv-orlando: I want to go to bed :(22:37
maruninfra wake up and disable voting!22:37
marun(please)22:37
salv-orlandoright it’s 1.40 your time?22:37
marunit's 12:40am my time22:37
maruni'm utc+222:37
salv-orlandoI thought you were in israel22:37
marunthat would be worse :)22:37
marunczech22:38
marunsalv-orlando: so before you go, which is preferable22:38
marunmocking sys.exit or changing all sys.exit calls to raising SystemExit?22:39
salv-orlandomarun: give me 5 minutes to think22:39
kevinbentonhmmm. sys.exit() raises systemexit22:41
kevinbentonhttps://docs.python.org/2/library/sys.html#sys.exit22:41
kevinbentonsecond sentence22:41
kevinbentona super-catch for SystemExit around test cases should work22:42
*** roeyc has quit IRC22:42
kevinbentonnot really super-catch22:42
kevinbentonjust a catch22:42
marunkevinbenton: so catching SystemExit is preferable because it covers both22:44
kevinbentonmy local interpreter corroborates my story22:44
kevinbentonmarun: yes22:44
salv-orlandomarun: there a lot more tests catching SystemExit than tests mocking sys.exit (1 only)22:44
kevinbentonhttp://paste.openstack.org/show/104419/22:44
salv-orlandomarun unit tests do it this way: with testtools.ExpectedException(SystemExit):22:45
marunsalv-orlando: though that will cause an assertion failure if it isn't raised22:46
kevinbentondoesn’t that error if the exception isn’t thrown?22:46
salv-orlandomarun: I have not idea what that method does - not sure if that works like assertRaises22:46
marunsalv-orlando: it does22:47
marunI don't think I have a good way of trapping for SystemExit :/22:47
marunit's much easier to mock sys.exit22:47
marunffs22:49
maruna lot more code raises than calls sys.exit22:49
marunway to make my life difficult :/22:49
marunmaybe I need to replace all those calls22:50
salv-orlandoif you mock it is ok unless.. you’re hiding an error condition where sys.exit should not be called and instead is called22:50
salv-orlandobut in that case you can assert on the mocks22:50
salv-orlandoand have logs22:50
marunsalv-orlando: so add a mock to the base class and rewrite tests that want to test sys.exit to target it?22:52
marunsalv-orlando: and allow a default expectation of 'no calls' to be overridden?22:53
*** emagana has joined #openstack-neutron22:54
*** changbl has quit IRC22:56
salv-orlandomarun: sounds good to me.22:58
*** emagana has quit IRC22:59
marunsalv-orlando: ok, sleep now :)22:59
marunsalv-orlando: thanks for the help22:59
*** padkrish has joined #openstack-neutron23:02
*** packet has quit IRC23:02
*** padkrish has quit IRC23:02
*** dfarrell07 has joined #openstack-neutron23:02
*** padkrish has joined #openstack-neutron23:03
kevinbentonmarun: i found a way that might work23:04
openstackgerritKevin Benton proposed a change to openstack/neutron: Prevent SystemExits when running tests  https://review.openstack.org/11822523:04
kevinbentonmarun: ^^23:04
*** rha has quit IRC23:04
kevinbentonmarun: try it with tox -v -epy27 neutron.tests.unit.bigswitch.test_servermanager.*.test_no_servers23:05
marunkevinbenton: oooh, way better than mocking23:06
kevinbentonmarun: even includes the traceback so you can see where it raised from23:06
kevinbentonmarun: or where sys.exit() was called23:07
marunwe need another core to get this merged asap23:07
kevinbentonmarun: ok. let me remove the fail23:07
kevinbentonmarun: any bug to mention?23:07
marunkevinbenton: oh, right :/23:07
marunkevinbenton: I should file one23:08
kevinbentonmarun: ok. ready to re-upload once you have a bug #23:08
marunsalv-orlando: still around?  how to file bug + categorize elasticsearch failure?23:08
marunkevinbenton: or do you know?23:08
marunHenryG: help? ^23:08
kevinbentonmarun: no, i don’t sadly23:09
kevinbentonWell you can always file a generic bug about exits being uncaught23:10
kevinbentonand we can get the patch merging23:10
kevinbentonwe don’t need the categorization component yet, right?23:10
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Local arp responder for VLAN  https://review.openstack.org/11294923:10
*** seizadi has joined #openstack-neutron23:11
marunkevinbenton: http://docs.openstack.org/infra/elastic-recheck/readme.html#adding-bug-signatures23:11
kevinbentonwell and this won’t fix the actual failure either. It will just expose the thing exiting23:12
*** ZZelle has quit IRC23:12
kevinbentonmarun: i assume the underlying functional test exiting is failing for some reason23:13
*** HenryG has quit IRC23:13
kevinbentonso it might not make sense to link the gate failures to the bug this is fixing23:14
marunkevinbenton: well, related-bug at the least23:14
kevinbentonmarun: yeah23:14
*** dfarrell07 has quit IRC23:15
*** SayajiPatil has quit IRC23:16
marunkevinbenton: almost done23:17
kevinbentonmarun: ok23:17
*** devvesa has joined #openstack-neutron23:19
marunkevinbenton: 136417123:19
marunhttps://bugs.launchpad.net/neutron/+bug/136417123:19
kevinbentonmarun: ok. so i will just be related-bug: #136417123:20
*** simon-AS5591 has quit IRC23:20
marunkevinbenton: sounds good23:20
openstackgerritKevin Benton proposed a change to openstack/neutron: Prevent SystemExits when running tests  https://review.openstack.org/11822523:21
kevinbentonmarun: done23:21
openstackgerritKarthik Natarajan proposed a change to openstack/neutron: Implementation of Brocade Vyatta vRouter L3 Plugin  https://review.openstack.org/10233623:21
kevinbentonmarun: i don’t have a unit test though…23:22
kevinbentonmarun: i could get meta and add a unit test23:22
marunkevinbenton: how would you?23:22
kevinbentonmarun: a test that exits and mark it as an expected failure :-)23:22
*** tflynn has joined #openstack-neutron23:22
marunraise SystemExit and expect AssertionFailure?23:22
marunsure23:22
kevinbentonmarun: where should i put it?23:22
marunneutron/tests/unit/test_system_exit.py23:23
marunor maybe test_base.py23:23
*** devvesa has quit IRC23:23
kevinbentonmarun: i’ll do test_base, not worth a whole new file probably23:24
kevinbentonmarun: well then there will be a new class in the base23:24
kevinbentonmarun: maybe a different file is better23:24
kevinbentonmarun: test_tester.py and we can put other stuff in there later?23:25
kevinbentonmarun: things to test the setup and whatnot23:25
marunkevinbenton: test_tester?23:25
openstackgerritA change was merged to openstack/python-neutronclient: Updated from global requirements  https://review.openstack.org/11406923:25
kevinbentonmarun: thinking of a new name23:25
kevinbentonmarun: that isn’t specifically tied to this particular test23:25
*** tsg has quit IRC23:26
marunkevinbenton: we can always change the name later23:27
*** HenryG has joined #openstack-neutron23:28
marunmestery: around?23:29
*** SayajiPatil has joined #openstack-neutron23:29
marunmestery: we'll need some help getting this patch merged ^23:29
marunrkukura: ^23:29
*** fifieldt has joined #openstack-neutron23:32
*** yamamoto has quit IRC23:33
*** amotoki has quit IRC23:35
kevinbentonmarun: hmm, expectfailure isn’t working correctly here. might just have to go forward23:35
openstackgerritKarthik Natarajan proposed a change to openstack/neutron: Implementation of Brocade Vyatta vRouter L3 Plugin  https://review.openstack.org/10233623:36
marunkevinbenton: you should be able to test anyway...23:37
marunkevinbenton: or are you already trying to assert that check_for_systemexit causes an assertion failure when passed SystemExit?23:37
kevinbentonmarun: yeah23:38
kevinbentonmarun: i think calling self.fail in the handler is causing the test to fail23:38
*** yamamoto has joined #openstack-neutron23:38
kevinbentonmarun: maybe instead I should raise an assertion error instead23:38
marunkevinbenton: so maybe raising assertionfailure will be more testable?23:38
marunkevinbenton: worth a try23:38
*** padkrish has quit IRC23:41
openstackgerritSayaji Patil proposed a change to openstack/neutron: Implements sync mechanism between Neutron and Nuage VSD  https://review.openstack.org/11341823:41
kevinbentonmarun: doesn’t seem to work either way. i think by the time it makes it to that handler, it’s already outside of the expectFailure’s catch23:41
*** padkrish has joined #openstack-neutron23:41
marunthe handler?23:42
kevinbentonmarun: the one from addOnException23:42
marunkevinbenton: yeah, there's no way you can test the addOnException addition23:42
marunkevinbenton: you should be able to test calling check_for_systemexit directly though23:42
marunkevinbenton: better than nothing23:42
kevinbentonmarun: oh i see23:42
kevinbentonmarun: i was trying to test sys.exit directly23:43
lifelesskevinbenton: what about sys.exit do you want to test?23:46
*** rdo has quit IRC23:46
marunlifeless: hooray!23:46
marunlifeless: https://review.openstack.org/#/c/118225/2/neutron/tests/base.py23:46
marunalso,  https://bugs.launchpad.net/neutron/+bug/136417123:47
*** rdo has joined #openstack-neutron23:48
*** emagana has joined #openstack-neutron23:48
lifelessok so run_user should indeed catch SystemExit today23:49
marunlifeless: hmmmm...  so our guessing is wrong...23:49
lifelessthough thats arguably a bug - catching SystemExit is bogus23:50
marunlifeless: any other thoughts as to why the bug would exhibit?23:50
marunlifeless: There isn't any test output that we can look through on the failing jobs23:50
marunlifeless: no output to be found: http://logs.openstack.org/60/115360/4/check/check-neutron-dsvm-functional/366b616/console.html#_2014-09-01_15_51_31_43823:51
*** karimb has quit IRC23:51
marunlifeless: it may be that the job simply isn't configured to leave it?23:51
marunlifeless: test-output is set but maybe there's something else?23:51
lifelessI'm just poking at this quickly23:53
*** emagana has quit IRC23:53
*** ianw has quit IRC23:53
lifelesshttp://paste.ubuntu.com/8210787/23:53
lifelesspython -m testtools.run exit23:54
lifelessruns one test23:54
lifelessdoesn23:54
lifelessdoesn't abort the runner23:54
*** ianw has joined #openstack-neutron23:54
lifelessit (correctly) attaches a traceback23:54
lifelesstesting a handler now23:54
kevinbentonmarun: so should i drop this patch?23:55
*** gildub has joined #openstack-neutron23:55
marunkevinbenton: I guess so :/23:55
lifelesshang a second23:55
lifelesslets figure out whats happening23:55
lifelessrhttp://paste.ubuntu.com/8210826/23:57
lifelessthat does what it looks like it should23:57
kevinbentonit might be worth having independent just to catch when systemexits are thrown. right now if i run without the handler, a test with sys.exit() just passes23:57
lifelessyeah, because testtools is catching it in its guts23:58
kevinbentonso would this handler be good anyway? I don’t think we want tests that run sys.exit() to pass23:58
marunkevinbenton++23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!