*** wanghao_ has quit IRC | 00:43 | |
*** harlowja has quit IRC | 00:48 | |
*** wanghao has joined #openstack-mogan | 00:49 | |
openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 01:05 |
---|---|---|
*** litao__ has joined #openstack-mogan | 01:05 | |
wanghao | morning! | 01:06 |
wanghao | I saw Sean's patch. hahaha | 01:06 |
zhenguo | wanghao: lol | 01:09 |
wanghao | zhenguo: zan | 01:09 |
openstackgerrit | liusheng proposed openstack/mogan master: Remove redundant mock in functional test https://review.openstack.org/501512 | 01:34 |
litao__ | liusheng: do you resolved the bugs in patch 34 in manageable_server part-2? | 01:37 |
liusheng | litao__: not yet, just want want to check, if you have solution, please pick it again | 01:38 |
litao__ | liusheng: ok, I will try | 01:38 |
liusheng | litao__: ok | 01:38 |
openstackgerrit | liusheng proposed openstack/mogan master: Remove redundant mock in functional test https://review.openstack.org/501512 | 01:46 |
openstackgerrit | liusheng proposed openstack/python-moganclient master: Don't need features description in README https://review.openstack.org/501526 | 01:49 |
zhenguo | liusheng: oh, it failed again for mogan docs on RTD | 01:52 |
liusheng | zhenguo: :( | 01:52 |
zhenguo | liusheng: the same error like before | 01:53 |
liusheng | zhenguo: will check | 01:53 |
zhenguo | liusheng: thanks | 01:54 |
openstackgerrit | liusheng proposed openstack/python-moganclient master: Add a more detailed README doc https://review.openstack.org/501526 | 01:57 |
zhenguo | hi all, let's move to #openstack-meeting | 02:00 |
wanghao | ok | 02:00 |
*** litao__ has quit IRC | 02:53 | |
*** litao__ has joined #openstack-mogan | 02:53 | |
openstackgerrit | Merged openstack/mogan master: Use newer location for iso8601 UTC https://review.openstack.org/501480 | 03:16 |
liusheng | zhenguo: you have moved mogan doc to your own repo, I cannot manage it | 03:17 |
openstackgerrit | Merged openstack/mogan-specs master: Add server group support https://review.openstack.org/489541 | 03:19 |
zhenguo | liusheng: hah, | 03:22 |
zhenguo | liusheng: please fee free to remove my repo and add yours | 03:22 |
openstackgerrit | Merged openstack/mogan-specs master: No need flavor and network in managing server https://review.openstack.org/494980 | 03:23 |
liusheng | zhenguo: let me try in a test repo firstly :D | 03:23 |
zhenguo | liusheng: ok | 03:23 |
liusheng | zhenguo: I found some times, the RTD after building, need wait a while, otherwise there maybe some issues | 03:24 |
zhenguo | liusheng: seems yes | 03:25 |
openstackgerrit | ShangXiao proposed openstack/mogan-specs master: Fix the typo and replace http with https for doc links https://review.openstack.org/501547 | 03:32 |
openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add db migration doc https://review.openstack.org/501550 | 03:39 |
openstackgerrit | liusheng proposed openstack/python-moganclient master: Remove the unsupported python 3.4 identifier https://review.openstack.org/501551 | 03:39 |
*** harlowja has joined #openstack-mogan | 04:06 | |
*** dims has quit IRC | 04:40 | |
*** harlowja has quit IRC | 05:11 | |
liusheng | zhenguo: in my testing, sometimes it may fail because missing oslo_policy, but somtimes don't, strange | 06:17 |
zhenguo | liusheng: hah, yes | 06:17 |
liusheng | zhenguo: how about just adding oslo_policy in test-requirements.txt ? | 06:28 |
zhenguo | liusheng: you didn't tried that? | 06:28 |
liusheng | zhenguo: not yet | 06:29 |
liusheng | zhenguo: cannot work ? | 06:29 |
zhenguo | liusheng: you can try on your own repo | 06:29 |
openstackgerrit | Merged openstack/mogan master: Remove redundant mock in functional test https://review.openstack.org/501512 | 06:29 |
zhenguo | liusheng: I remember I told you to try that, hah | 06:29 |
liusheng | zhenguo: oh, seems I have tried before | 06:29 |
liusheng | zhenguo: but another error | 06:29 |
zhenguo | liusheng: yes, seems oslo.cache error | 06:30 |
litao__ | zhenguo: ping | 06:36 |
zhenguo | litao__: pong | 06:36 |
litao__ | zhenguo: I found an question. When I server.create() is executed, the nic object can't be saved in db | 06:51 |
zhenguo | litao__: oh, yes, because there's a foreign key | 06:52 |
litao__ | zhenguo: should i call nic.save() ? | 06:53 |
zhenguo | litao__: no you can't | 06:53 |
litao__ | zhenguo: How to do? | 06:53 |
zhenguo | litao__: no way | 06:53 |
zhenguo | litao__: you need to save server first | 06:54 |
zhenguo | litao__: oh, seems we don't talk about the same thing | 06:55 |
zhenguo | litao__: sorry, liusheng can you explain why here | 06:55 |
litao__ | liusheng: ping | 06:55 |
litao__ | zhenguo: I know why, I should update the the latest the mogan client codes | 06:57 |
zhenguo | litao__: why need that | 06:57 |
zhenguo | litao__: you mean run CLI failed to save db? | 06:57 |
litao__ | zhenguo: I mean I can't get network info from CLI | 06:58 |
zhenguo | litao__: oh, yes, you need to upgrade the client | 06:58 |
litao__ | zhenguo: The network keyword is change to address, and I didn't pull the mogan client codes | 06:59 |
litao__ | zhenguo: yes, It works | 06:59 |
zhenguo | litao__: cool | 06:59 |
litao__ | zhenguo: lol | 07:00 |
liusheng | litao__: still have problem ? :P | 07:02 |
openstackgerrit | Tao Li proposed openstack/mogan master: Manage existing BMs: Part-2 https://review.openstack.org/481544 | 07:03 |
openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Correct db and model inconsistent https://review.openstack.org/501597 | 07:21 |
zhenguo | liusheng: please have a look at this https://review.openstack.org/#/c/501550/ | 07:29 |
zhenguo | liusheng: and with the instructions there, I find many db and model inconsistent https://review.openstack.org/#/c/501597/ | 07:30 |
liusheng | zhenguo: ok, why shaohe -A ? :D | 07:31 |
liusheng | zhenguo: oh | 07:31 |
zhenguo | liusheng: no -A, he just want to wait for another +2 @shaohe_feng | 07:32 |
liusheng | zhenguo: got it, hah | 07:32 |
zhenguo | liusheng: how about this one https://review.openstack.org/#/c/499474/ ? | 07:33 |
* zhenguo brb | 07:33 | |
liusheng | zhenguo: it is better also update the doc | 07:33 |
openstackgerrit | Tao Li proposed openstack/mogan master: Manage existing BMs: Part-2 https://review.openstack.org/481544 | 07:36 |
openstackgerrit | Merged openstack/mogan master: Add db migration doc https://review.openstack.org/501550 | 07:36 |
zhenguo | shaohe_feng: please help to look at this https://review.openstack.org/#/c/501551/ | 07:46 |
zhenguo | liusheng: oh, seems we can't specify port_id when creating a server through CLI | 07:50 |
openstackgerrit | Xinran WANG proposed openstack/mogan master: uncomment check_port_availability https://review.openstack.org/501614 | 07:51 |
openstackgerrit | Xinran WANG proposed openstack/mogan master: Update port['device_id'] when creating server https://review.openstack.org/500668 | 07:53 |
liusheng | zhenguo: I remember ther is a patch added that | 07:53 |
zhenguo | liusheng: got lost? | 07:53 |
zhenguo | liusheng: and there's a port_type still there now | 07:53 |
liusheng | zhenguo: oh, seems yes, we don't support specifying port-id when creating | 07:58 |
zhenguo | liusheng: can you help to add that | 08:00 |
liusheng | zhenguo: sure | 08:00 |
zhenguo | liusheng: thanks | 08:00 |
zhenguo | liusheng: I will add partitions support | 08:00 |
liusheng | zhenguo: np | 08:00 |
liusheng | zhenguo: ok | 08:01 |
litao__ | zhenguo,liusheng: For managing servers , should we use a new resource named manageable server or server? | 08:01 |
liusheng | litao__: where you mean ? | 08:01 |
litao__ | liusheng: In mogan client | 08:02 |
zhenguo | litao__: seems you can follow up wanghao's patch | 08:03 |
litao__ | zhenguo: OK | 08:10 |
litao__ | zhenguo: https://review.openstack.org/#/c/481544/36 pls review this patch | 08:28 |
zhenguo | litao__: ok | 08:28 |
zhenguo | litao__: seems it not pass the gate | 08:29 |
litao__ | zhenguo: yes, I recheck it | 08:29 |
zhenguo | litao__: ok | 08:29 |
litao__ | zhenguo: I can't find why it failed | 08:29 |
openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Add support for specifing patitions when claming a server https://review.openstack.org/501634 | 08:47 |
liusheng | zhenguo: seems our scheduler has been broken :( | 08:53 |
zhenguo | liusheng: why? | 08:53 |
liusheng | zhenguo: not sure maybe relate with the node-uuid-->node-name change | 08:54 |
liusheng | zhenguo: not sure | 08:54 |
openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Correct db and model inconsistent https://review.openstack.org/501597 | 08:54 |
zhenguo | liusheng: oh | 08:54 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: 2017-09-07 16:53:07.081 WARNING mogan.scheduler.client.report [req-1f7d453a-027a-4f28-9d64-94f13e6478e2 None None] Unable to submit allocation for server fa9d68a4-30ce-4927-9461-1028fd | 08:54 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: <head> | 08:54 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: <title>400 Bad Request</title> | 08:54 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: </head> | 08:54 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: <body> | 08:55 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: <h1>400 Bad Request</h1> | 08:55 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: The server could not comply with the request since it is either malformed or otherwise incorrect.<br /><br /> | 08:55 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: JSON does not validate: u'node-0' is not a 'uuid' | 08:55 |
openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 08:55 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: Failed validating 'format' in schema['properties']['allocations']['items']['properties']['resource_provider']['properties']['uuid']: | 08:55 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: {'format': 'uuid', 'type': 'string'} | 08:55 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: On instance['allocations'][0]['resource_provider']['uuid']: | 08:55 |
liusheng | Sep 07 16:53:07 szxbzci0007 mogan-scheduler[18308]: u'node-0' | 08:55 |
zhenguo | liusheng: but this pass the gate 20 mins ago https://review.openstack.org/#/c/500668/ | 08:55 |
liusheng | zhenguo: yes, it can create a server, but cannot create 2ed server | 08:55 |
liusheng | zhenguo: let me check, not sure | 08:56 |
zhenguo | liusheng: oh, you mean why put allocations we need the rp uuid instead of name, right? | 08:57 |
zhenguo | *when | 08:57 |
liusheng | zhenguo: seems yes | 08:57 |
zhenguo | liusheng: need to change the put_allocations method? | 08:58 |
zhenguo | liusheng: and seems we can combine some methods in scheduler/report | 08:58 |
liusheng | zhenguo: maybe it is relate with placement api version, let me check | 08:58 |
zhenguo | liusheng: but we don't bump the API version at all | 08:59 |
zhenguo | liusheng: we use server.node_uuid before, so it works | 08:59 |
zhenguo | liusheng: need to find rp uuid from server now | 08:59 |
liusheng | zhenguo: nova/api/openstack/placement/handlers/allocation.py | 09:00 |
liusheng | zhenguo: ALLOCATION_SCHEMA | 09:00 |
zhenguo | liusheng: yes, I see, it needs rp uuid | 09:01 |
liusheng | zhenguo: yes :( | 09:01 |
zhenguo | liusheng: but we pass server node now | 09:01 |
zhenguo | liusheng: we should change | 09:01 |
zhenguo | liusheng: as they just want rp.uuid instead of rp.name | 09:01 |
liusheng | zhenguo: yes | 09:01 |
zhenguo | liusheng: is that easy to find the uuid from name? | 09:02 |
zhenguo | liusheng: leveraging our cache? | 09:02 |
liusheng | zhenguo: scheduler cannot use the cache | 09:03 |
zhenguo | liusheng: we always put allocations from engine side, right? | 09:03 |
liusheng | zhenguo: not is in scheduler | 09:03 |
liusheng | zhenguo: not sure should we move it to engine | 09:03 |
zhenguo | liusheng: let me check | 09:04 |
zhenguo | liusheng: seems you can find the uuid there, as we got the rp object | 09:05 |
zhenguo | liusheng: filtered_nodes and filtered_affzs_nodes can contain both uuid and name as a workaround | 09:06 |
liusheng | zhenguo: yes, we can, but need to change the process | 09:06 |
zhenguo | liusheng: sigh, it's tricky | 09:10 |
zhenguo | liusheng: maybe revert that patch and just set name on engine side before return to API | 09:11 |
liusheng | zhenguo: sigh, I am afraid that may be some conflicts ? | 09:11 |
openstackgerrit | Merged openstack/mogan master: uncomment check_port_availability https://review.openstack.org/501614 | 09:12 |
zhenguo | liusheng: seems yes | 09:12 |
zhenguo | liusheng: or maybe add a new patch | 09:12 |
zhenguo | liusheng: we don't need to change server.node back to server.node_uuid | 09:12 |
zhenguo | liusheng: just save uuid in db | 09:12 |
liusheng | zhenguo: I am afraid that may cause more inconsistent in the future, how about your first suggestion ? | 09:13 |
liusheng | zhenguo: revert that patch, and convert node_uuid to node_name only in api layer | 09:14 |
zhenguo | liusheng: you can't, as you also can't use cache on API side | 09:14 |
liusheng | zhenguo: call ironic in client side like others ? | 09:15 |
zhenguo | liusheng: hah | 09:15 |
zhenguo | liusheng: so, let's revert it | 09:19 |
liusheng | zhenguo: ok | 09:19 |
openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Revert "Return node(name or uuid) with server instead of node_uuid" https://review.openstack.org/501642 | 09:20 |
zhenguo | liusheng: conflicts happening | 09:21 |
liusheng | zhenguo: hah | 09:21 |
zhenguo | liusheng: I'll be away for a while, if you got time, please help to address the conflicts, thanks | 09:22 |
* zhenguo brb | 09:23 | |
litao__ | zhenguo: passed | 09:27 |
openstackgerrit | liusheng proposed openstack/mogan master: Revert "Return node(name or uuid) with server instead of node_uuid" https://review.openstack.org/501642 | 09:29 |
openstackgerrit | liusheng proposed openstack/mogan master: Revert "Return node(name or uuid) with server instead of node_uuid" https://review.openstack.org/501642 | 09:31 |
zhenguo | liusheng: thanks | 09:35 |
liusheng | zhenguo: np | 09:36 |
zhenguo | litao__: not sure if the revert above will affect you patch | 09:36 |
openstackgerrit | Merged openstack/python-moganclient master: Remove the unsupported python 3.4 identifier https://review.openstack.org/501551 | 09:42 |
zhenguo | litao__: hi, I left some nits inline, will test in my env. | 09:51 |
openstackgerrit | liusheng proposed openstack/python-moganclient master: Correct the network parameter when creating server https://review.openstack.org/501658 | 09:52 |
liusheng | zhenguo: plz help to review above patch if you got time ^ | 09:53 |
zhenguo | liusheng: sure | 09:54 |
liusheng | zhenguo: thanks | 09:54 |
liusheng | zhenguo, wanghao can you check the reply of Xinran in the patch https://review.openstack.org/#/c/500668 | 09:58 |
zhenguo | liusheng: ok | 09:58 |
liusheng | zhenguo: not sure if I can +A, but we should respect any negative opinion. hah | 10:00 |
zhenguo | liusheng: seems wanghao is not online | 10:00 |
liusheng | zhenguo: oh | 10:00 |
zhenguo | liusheng: oh, seems revert will delelte the port again | 10:07 |
* zhenguo brb | 10:33 | |
Xinran | zhenguo, wanghao Thanks for your comments on my patch | 10:59 |
zhenguo | Xinran: seems the port will get deleted during the revert process | 10:59 |
Xinran | zhenguo, yes I see | 11:00 |
zhenguo | Xinran: not sure if we should delete it | 11:00 |
Xinran | zhenguo, not sure why revert will destroy all | 11:00 |
Xinran | zhenguo, I think no ... | 11:01 |
zhenguo | Xinran: so we should handle that during revert | 11:01 |
Xinran | if we pass net_id, will we invoke destroy_network as before? | 11:04 |
Xinran | I think unbind_port and delete_port is enough | 11:05 |
Xinran | and need we a for loop to filter the requested_networks in revert ? | 11:06 |
openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Correct db and model inconsistent https://review.openstack.org/501597 | 11:07 |
zhenguo | Xinran: you mean during revert? | 11:09 |
zhenguo | Xinran: revert will only check the nics object and clean everything | 11:09 |
Xinran | ok, I think we should just destroy the network whick failed to be built, not all | 11:10 |
zhenguo | liusheng: maybe we can land this https://review.openstack.org/#/c/501642/ now | 11:10 |
zhenguo | Xinran: we should remove all | 11:11 |
Xinran | zhenguo, why, can't understand ... | 11:14 |
zhenguo | Xinran: during the revert we will clean all things, otherwise there will be ports left | 11:14 |
zhenguo | Xinran: I mean what we have created during the server creation except the existing port | 11:15 |
Xinran | zhenguo, oh my question is if we should remove all including the sucessfully built network | 11:16 |
zhenguo | Xinran: yes, we just want to remove successfully built network | 11:17 |
liusheng | zhenguo: ok | 11:17 |
Xinran | zhenguo, why don't we just remove the error one ? | 11:19 |
zhenguo | Xinran: in fact, error one doesn't need to be removed, as they may just not created | 11:20 |
zhenguo | Xinran: seems I understand what you are asking | 11:21 |
zhenguo | Xinran: our workflow is a list of execute and reverts | 11:21 |
zhenguo | Xiran: when there's an exception happend in buildnetworks, we will revert one by one, | 11:21 |
zhenguo | Xinran: which means we will remove everything, ports and the server | 11:22 |
Xinran | means total execution failed | 11:22 |
zhenguo | Xinran: yes | 11:22 |
Xinran | zhenguo, hah ok got it | 11:22 |
zhenguo | Xinran: but revert will just start from the point failed | 11:22 |
Xinran | if so, I think we need a for loop in revert | 11:24 |
Xinran | to check every port | 11:24 |
zhenguo | Xinran: seems there's a look in destroy_networks | 11:27 |
zhenguo | Xinran: maybe we need a separated destroy_networks | 11:27 |
zhenguo | liusheng: when deleting a server will we remove the specified port/existing neutron port | 11:27 |
liusheng | zhenguo: not sure, let me try | 11:28 |
zhenguo | liusheng: ok, thanks | 11:28 |
zhenguo | liusheng: are you testing with nova+ironic or single nova | 11:29 |
zhenguo | liusheng: not sure if ironic will get rid of the port | 11:29 |
liusheng | zhenguo: oh, you mean in Nova ? | 11:29 |
zhenguo | liusheng: yes | 11:29 |
liusheng | zhenguo: I don't have a nova+ironic env | 11:30 |
zhenguo | liusheng: ok | 11:30 |
Xinran | zhenguo, you mean server or baremetal server? | 11:30 |
zhenguo | Xinran: mogan server | 11:31 |
Xinran | zhenguo, yes | 11:31 |
Xinran | zhenguo, I just tried | 11:31 |
Xinran | zhenguo, the associated port will be deleted | 11:31 |
liusheng | zhenguo: just asked, if creating a nova server with port specified. after deleting server, the port still exist | 11:31 |
liusheng | zhenguo: if specifying network, it will delete the port | 11:32 |
zhenguo | oh, should we make a change | 11:32 |
liusheng | zhenguo: currently, mogan will delete the port ? | 11:32 |
zhenguo | Xinran: yes, we will delete all | 11:33 |
zhenguo | how can we know it's a existing port when deleting | 11:33 |
Xinran | in Nova there is a preexisting_port which save the existing port before do operation | 11:33 |
zhenguo | save in db? | 11:34 |
Xinran | zhenguo, seems just a variable hah | 11:34 |
zhenguo | but when I want to delete a server, how can I know which port is an existing one | 11:34 |
zhenguo | liusheng: this https://review.openstack.org/#/c/501597/ passed the gate, and fixed a server group policy foreign key error. | 11:47 |
*** litao__ has quit IRC | 11:48 | |
Xinran | zhenguo, https://github.com/openstack/nova/blob/7506ffed5210fc6c67bf89d3b94a0230b3ab5592/nova/network/model.py#L395 | 11:49 |
Xinran | zhenguo, pls see this code | 11:50 |
zhenguo | Xinran: oh, they have such field with VIF | 11:50 |
zhenguo | Xinran: seems we can also add that to our Nic object | 11:50 |
Xinran | zhenguo, yes sure | 11:51 |
zhenguo | Xinran: thanks | 11:51 |
Xinran | zhenguo, but my intern report's deadline is coming, also my final presentation | 11:52 |
zhenguo | Xinran: oh, it's ok, I can help to update the patch | 11:52 |
zhenguo | Xinran: :D | 11:52 |
Xinran | zhenguo, thanks a lot. | 11:52 |
zhenguo | Xinran: np | 11:52 |
Xinran | zhenguo, I will be all time avaible after my presentation | 11:53 |
zhenguo | Xinran: ok | 11:53 |
Xinran | zhenguo, thanks thanks thanks | 11:53 |
zhenguo | Xinran: lol | 11:53 |
*** dims has joined #openstack-mogan | 12:07 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-moganclient master: Updated from global requirements https://review.openstack.org/501358 | 13:42 |
openstackgerrit | Merged openstack/mogan master: Revert "Return node(name or uuid) with server instead of node_uuid" https://review.openstack.org/501642 | 13:46 |
openstackgerrit | Tao Li proposed openstack/mogan master: Manage existing BMs: Part-2 https://review.openstack.org/481544 | 15:25 |
openstackgerrit | Tao Li proposed openstack/python-moganclient master: Add the CLI for server adoption https://review.openstack.org/501777 | 15:30 |
openstackgerrit | Tao Li proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 15:31 |
openstackgerrit | Tao Li proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 16:47 |
*** harlowja has joined #openstack-mogan | 17:19 | |
*** dims has quit IRC | 18:34 | |
*** dims has joined #openstack-mogan | 18:36 | |
*** dims has quit IRC | 18:41 | |
*** dims has joined #openstack-mogan | 18:45 | |
*** wanghao_ has joined #openstack-mogan | 20:54 | |
*** wanghao has quit IRC | 20:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!