*** jrist has quit IRC | 00:24 | |
*** AlexeyAbashkin has joined #openstack-mistral | 00:24 | |
*** AlexeyAbashkin has quit IRC | 00:28 | |
*** itlinux has joined #openstack-mistral | 00:29 | |
*** jrist has joined #openstack-mistral | 00:36 | |
*** mcdoker181818 has quit IRC | 00:49 | |
*** vishwanathj has joined #openstack-mistral | 02:20 | |
*** yangyapeng has quit IRC | 02:47 | |
*** bobh has joined #openstack-mistral | 02:47 | |
*** yangyapeng has joined #openstack-mistral | 02:47 | |
*** bobh has quit IRC | 02:48 | |
*** harlowja has quit IRC | 02:52 | |
*** yangyape_ has joined #openstack-mistral | 03:00 | |
*** yangyapeng has quit IRC | 03:01 | |
*** ykarel|away has joined #openstack-mistral | 03:10 | |
*** AlexeyAbashkin has joined #openstack-mistral | 03:24 | |
*** AlexeyAbashkin has quit IRC | 03:29 | |
*** gkadam has joined #openstack-mistral | 03:39 | |
*** thrash is now known as thrash|g0ne | 03:39 | |
*** ykarel|away has quit IRC | 03:59 | |
*** ykarel has joined #openstack-mistral | 04:21 | |
*** harlowja has joined #openstack-mistral | 04:54 | |
*** kushalAgrawal has joined #openstack-mistral | 05:42 | |
*** gkadam has quit IRC | 05:43 | |
*** gkadam has joined #openstack-mistral | 05:44 | |
*** threestrands has quit IRC | 07:10 | |
*** harlowja has quit IRC | 07:10 | |
*** gkadam has quit IRC | 07:34 | |
*** gkadam has joined #openstack-mistral | 07:34 | |
*** AlexeyAbashkin has joined #openstack-mistral | 07:53 | |
rakhmerov | d0ugal: hi, as far as wiki, yes. We used to use wiki pretty actively for posting some design drafts and other things. But probably we can have a special page in our official docs for that | 08:02 |
---|---|---|
rakhmerov | and we now have spec repo | 08:02 |
rakhmerov | thrash|g0ne: thanks! | 08:02 |
*** akazakov has quit IRC | 08:09 | |
*** yangyape_ has quit IRC | 08:10 | |
*** akazakov has joined #openstack-mistral | 08:12 | |
*** yangyapeng has joined #openstack-mistral | 08:17 | |
*** yangyapeng has quit IRC | 08:27 | |
*** openstackgerrit has joined #openstack-mistral | 08:31 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Explain better combinations of task names and engine commands in docs https://review.openstack.org/545692 | 08:31 |
*** yangyapeng has joined #openstack-mistral | 08:38 | |
*** jpich has joined #openstack-mistral | 08:47 | |
*** yangyape_ has joined #openstack-mistral | 08:49 | |
*** yangyapeng has quit IRC | 08:50 | |
*** shardy has joined #openstack-mistral | 09:09 | |
apetrich | rakhmerov, almost done on the massive review. Sorry that I didn't have the focus yesterday to go through it all | 09:36 |
rakhmerov | it's ok ) | 09:36 |
rakhmerov | thanks a lot! I know it's not easy | 09:36 |
d0ugal | apetrich: I think it looks pretty good fwiw | 09:36 |
d0ugal | but I'd like to test it before it lands | 09:36 |
apetrich | aye | 09:36 |
d0ugal | I started writing a Zaqar notifier | 09:36 |
apetrich | oh neat | 09:36 |
apetrich | it is lgtm | 09:37 |
apetrich | but I will +1 it to let you +2 and +W it if you are going to test it | 09:37 |
d0ugal | rakhmerov: I am trying to figure out how I can get the security context to create a zaqarclient for a zaqar publisher | 09:39 |
d0ugal | rakhmerov: would you happen to know? | 09:39 |
rakhmerov | hah.. good question | 09:43 |
rakhmerov | well, first of all, IMO it should be a publisher, not notifier | 09:43 |
d0ugal | rakhmerov: yeah, I got confused in my first message. | 09:44 |
d0ugal | rakhmerov: this is what I am playing with so far: http://paste.openstack.org/show/678334/ | 09:44 |
d0ugal | Other than lines 29 and 30, it should be really easy :) | 09:44 |
d0ugal | but I can't figure out how to get that information. | 09:45 |
d0ugal | Maybe I can ask Winson | 09:45 |
rakhmerov | yep.. looking | 09:46 |
rakhmerov | ok, seems like it's simply missing | 09:47 |
d0ugal | :) | 09:47 |
rakhmerov | if you look at https://review.openstack.org/#/c/467799/11/mistral/engine/tasks.py line 73 | 09:48 |
rakhmerov | you won't see anything related to security context | 09:48 |
rakhmerov | all info comes from that place | 09:48 |
d0ugal | rakhmerov: right, so I guess I could just pass it at that point | 09:48 |
d0ugal | that should be easy | 09:48 |
rakhmerov | it only has info about the task itself and the event that doesn't include security context | 09:48 |
rakhmerov | yes | 09:48 |
d0ugal | thanks | 09:48 |
d0ugal | I think adding a publisher is a good test of the design :) | 09:49 |
rakhmerov | but maybe the interface of Publisher (and Notifier) should have it explicitly | 09:49 |
rakhmerov | yes, indeed | 09:49 |
rakhmerov | thanks for doing that.. | 09:49 |
rakhmerov | I'm planning to do that as well but later | 09:49 |
d0ugal | It might be nicer to pass it to the init | 09:49 |
rakhmerov | pass what and to what init? | 09:50 |
d0ugal | the context | 09:50 |
rakhmerov | to what init? | 09:50 |
d0ugal | publisher init | 09:51 |
d0ugal | sorry :) | 09:51 |
d0ugal | I am just thinking "out loud" | 09:51 |
rakhmerov | nope, I think it won't work | 09:51 |
d0ugal | true, it changes | 09:51 |
d0ugal | nevermind | 09:51 |
rakhmerov | because same publisher can be reused by multiple threads | 09:51 |
rakhmerov | so I think it should be a part of Notifier and Publisher interface | 09:51 |
rakhmerov | so, the first missing thing.. | 09:52 |
rakhmerov | but I'd still suggest we consider this patch the first step towards the full implementation and let it merge and then add what's missing | 09:52 |
rakhmerov | no? :) | 09:52 |
rakhmerov | (hoping that I didn't say anything stupid) | 09:53 |
d0ugal | No, that seems fine | 09:53 |
rakhmerov | anyway.. up to you ) | 09:53 |
rakhmerov | thanks | 09:53 |
rakhmerov | going for lunch | 09:53 |
d0ugal | I just want to verify that it mostly works and doing something like this requires minimal changes. | 09:53 |
*** d0ugal_ has joined #openstack-mistral | 10:32 | |
*** d0ugal has quit IRC | 10:34 | |
*** d0ugal_ has quit IRC | 10:50 | |
*** d0ugal has joined #openstack-mistral | 10:51 | |
*** gkadam has quit IRC | 11:06 | |
*** gkadam has joined #openstack-mistral | 11:07 | |
*** gkadam has quit IRC | 11:12 | |
*** gkadam has joined #openstack-mistral | 11:12 | |
*** gkadam has quit IRC | 11:18 | |
*** gkadam has joined #openstack-mistral | 11:30 | |
*** gkadam has quit IRC | 12:06 | |
*** oidgar has joined #openstack-mistral | 12:10 | |
*** gkadam has joined #openstack-mistral | 12:22 | |
*** oidgar has quit IRC | 12:30 | |
*** dprince has joined #openstack-mistral | 12:40 | |
*** oidgar has joined #openstack-mistral | 12:45 | |
rakhmerov | ok | 12:46 |
*** thrash|g0ne is now known as thrash | 12:54 | |
*** oidgar has quit IRC | 14:03 | |
*** oidgar has joined #openstack-mistral | 14:14 | |
*** ykarel is now known as ykarel|away | 14:19 | |
*** rbrady has quit IRC | 14:35 | |
*** ykarel|away is now known as ykarel | 14:38 | |
*** rbrady has joined #openstack-mistral | 14:48 | |
*** rbrady has quit IRC | 14:48 | |
*** rbrady has joined #openstack-mistral | 14:48 | |
*** ykarel is now known as ykarel|away | 14:59 | |
*** d0ugal has quit IRC | 14:59 | |
*** d0ugal has joined #openstack-mistral | 15:01 | |
*** itlinux has quit IRC | 15:16 | |
*** thrash is now known as thrash|biab | 15:25 | |
*** ykarel|away has quit IRC | 15:35 | |
*** d0ugal has quit IRC | 15:36 | |
*** d0ugal has joined #openstack-mistral | 15:40 | |
*** thrash|biab is now known as thrash | 15:49 | |
*** d0ugal has quit IRC | 15:52 | |
*** itlinux has joined #openstack-mistral | 16:06 | |
*** d0ugal has joined #openstack-mistral | 16:07 | |
*** d0ugal has quit IRC | 16:17 | |
*** AlexeyAbashkin has quit IRC | 16:26 | |
*** d0ugal has joined #openstack-mistral | 16:35 | |
*** oidgar has quit IRC | 16:54 | |
*** d0ugal has quit IRC | 16:59 | |
*** itlinux has quit IRC | 17:02 | |
*** d0ugal has joined #openstack-mistral | 17:03 | |
*** itlinux has joined #openstack-mistral | 17:04 | |
*** jpich has quit IRC | 17:18 | |
*** harlowja has joined #openstack-mistral | 17:23 | |
*** d0ugal has quit IRC | 17:38 | |
*** dprince has quit IRC | 17:47 | |
*** jtomasek has quit IRC | 17:54 | |
*** AlexeyAbashkin has joined #openstack-mistral | 17:57 | |
*** dprince has joined #openstack-mistral | 18:01 | |
*** AlexeyAbashkin has quit IRC | 18:02 | |
*** openstackgerrit has quit IRC | 18:03 | |
*** oidgar has joined #openstack-mistral | 18:06 | |
*** d0ugal has joined #openstack-mistral | 18:11 | |
*** AlexeyAbashkin has joined #openstack-mistral | 18:13 | |
*** oidgar has quit IRC | 18:15 | |
*** AlexeyAbashkin has quit IRC | 18:17 | |
*** harlowja has quit IRC | 18:23 | |
*** d0ugal has quit IRC | 18:38 | |
*** d0ugal has joined #openstack-mistral | 18:40 | |
*** shardy has quit IRC | 18:43 | |
*** d0ugal has quit IRC | 18:51 | |
*** harlowja has joined #openstack-mistral | 18:55 | |
*** d0ugal_ has joined #openstack-mistral | 18:57 | |
*** harlowja_ has joined #openstack-mistral | 18:59 | |
*** harlowja has quit IRC | 18:59 | |
*** apetrich has quit IRC | 19:12 | |
*** apetrich has joined #openstack-mistral | 19:14 | |
*** openstackgerrit has joined #openstack-mistral | 19:23 | |
openstackgerrit | Toure Dunnon proposed openstack/mistral-extra master: Add Ansible actions to Mistral https://review.openstack.org/514360 | 19:23 |
*** d0ugal_ has quit IRC | 19:45 | |
*** d0ugal_ has joined #openstack-mistral | 19:57 | |
*** d0ugal_ has quit IRC | 20:03 | |
*** d0ugal_ has joined #openstack-mistral | 20:04 | |
*** d0ugal_ has quit IRC | 20:10 | |
*** d0ugal_ has joined #openstack-mistral | 20:14 | |
*** AlexeyAbashkin has joined #openstack-mistral | 20:23 | |
*** AlexeyAbashkin has quit IRC | 20:27 | |
*** d0ugal_ has quit IRC | 20:30 | |
*** d0ugal_ has joined #openstack-mistral | 20:57 | |
*** FL1SK has joined #openstack-mistral | 21:08 | |
*** dprince has quit IRC | 21:09 | |
*** AlexeyAbashkin has joined #openstack-mistral | 21:23 | |
*** AlexeyAbashkin has quit IRC | 21:27 | |
*** kushalAgrawal has quit IRC | 21:33 | |
*** d0ugal_ has quit IRC | 22:03 | |
*** threestrands has joined #openstack-mistral | 22:23 | |
*** itlinux has quit IRC | 22:49 | |
*** openstackgerrit has quit IRC | 23:04 | |
*** AlexeyAbashkin has joined #openstack-mistral | 23:23 | |
*** AlexeyAbashkin has quit IRC | 23:27 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!