| *** catintheroof has joined #openstack-mistral | 00:05 | |
| *** bobh has joined #openstack-mistral | 00:48 | |
| *** chlong has quit IRC | 01:34 | |
| *** catintheroof has quit IRC | 01:40 | |
| *** bobh has quit IRC | 01:48 | |
| *** bobh has joined #openstack-mistral | 02:08 | |
| *** chlong has joined #openstack-mistral | 02:14 | |
| *** thrash is now known as thrash|g0ne | 02:17 | |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Use assertGreater() or assertLess() https://review.openstack.org/413944 | 02:25 |
|---|---|---|
| *** chlong has quit IRC | 02:43 | |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Support i18n for LOG.warning https://review.openstack.org/413965 | 02:53 |
| *** chlong has joined #openstack-mistral | 02:56 | |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Support i18n for LOG.warning https://review.openstack.org/413965 | 02:59 |
| *** bobh has quit IRC | 03:02 | |
| *** chlong has quit IRC | 03:05 | |
| *** bobh has joined #openstack-mistral | 03:16 | |
| openstackgerrit | Jizhaoxuan proposed openstack/python-mistralclient: Use assertGreater() or assertLess() https://review.openstack.org/414398 | 03:24 |
| *** sharatss has quit IRC | 03:38 | |
| *** sharatss has joined #openstack-mistral | 03:39 | |
| openstackgerrit | Jizhaoxuan proposed openstack/python-mistralclient: Support oslo.i18n in mistralclient https://review.openstack.org/414404 | 03:39 |
| *** bobh has quit IRC | 03:47 | |
| *** bobh has joined #openstack-mistral | 04:06 | |
| *** bobh has quit IRC | 04:34 | |
| *** weshay_afk is now known as weshay_pto | 04:57 | |
| *** sharatss has quit IRC | 05:34 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard: Remove django<1.8 from tests https://review.openstack.org/414425 | 05:35 |
| *** sharatss has joined #openstack-mistral | 05:35 | |
| *** ChubbyBreakfast has joined #openstack-mistral | 05:51 | |
| *** ChubbyBreakfast has left #openstack-mistral | 05:52 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Added congress actions into Mistral https://review.openstack.org/414430 | 06:11 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Added congress actions into Mistral https://review.openstack.org/414430 | 07:05 |
| *** sharatss has quit IRC | 07:05 | |
| *** sharatss has joined #openstack-mistral | 07:05 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Adding releasenotes for aodh action support https://review.openstack.org/414449 | 07:07 |
| sharatss | Qiming: hi | 07:32 |
| Qiming | hi | 07:33 |
| sharatss | Qiming: what is the importance of replacing MagicMock with mock? | 07:34 |
| Qiming | MagicMock is sometimes mocking too much so some errors may go undetected, according to my limited knowledge | 07:34 |
| Qiming | when doing unit tests, you don't want such "magics", :) | 07:35 |
| sharatss | Qiming: hahaha yeah.. rakhmerov and I had a discussion on this a few days ago.. if he remembers | 07:35 |
| Qiming | for your reference: https://bugs.launchpad.net/python-openstacksdk/+bug/1475722 | 07:36 |
| openstack | Launchpad bug 1475722 in heat-cfntools "Never use MagicMock" [Undecided,In progress] - Assigned to shizhihui (shizhihui) | 07:36 |
| sharatss | Qiming: i wanted to know if it is important to change it in our project too | 07:36 |
| sharatss | Qiming: coz we have many MagicMocks in our project too | 07:37 |
| Qiming | I believe we did uncovered some subtle bugs when killing MagicMock in SDK | 07:37 |
| Qiming | not sure how big an issue it is in mistral though | 07:37 |
| sharatss | Qiming: ohh.. thanks a lot for the info | 07:38 |
| Qiming | welcome | 07:39 |
| sharatss | i saw this change happening in many projects today | 07:39 |
| sharatss | that made me curious | 07:39 |
| Qiming | okay | 07:46 |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Support i18n for LOG.warning https://review.openstack.org/414498 | 09:03 |
| *** shardy has joined #openstack-mistral | 09:22 | |
| openstackgerrit | Lingxian Kong proposed openstack/mistral-specs: Support openstack context for workflow https://review.openstack.org/414508 | 09:26 |
| openstackgerrit | Jizhaoxuan proposed openstack/python-mistralclient: Support oslo.i18n in mistralclient https://review.openstack.org/414404 | 09:26 |
| rakhmerov | sharatss: hi | 09:38 |
| rakhmerov | all of the tests that you recently added have the same problem | 09:38 |
| rakhmerov | in api/v2/test_tasks | 09:38 |
| rakhmerov | for example, test_put_match_task_name | 09:38 |
| rakhmerov | please fix them asap | 09:39 |
| rakhmerov | it slows down merging patches: http://logs.openstack.org/87/414287/1/gate/gate-mistral-python27-ubuntu-xenial/b41b031/testr_results.html.gz | 09:39 |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Support i18n for LOG.warning https://review.openstack.org/414498 | 09:45 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Fix for failing kombu dsvm gate https://review.openstack.org/414533 | 10:10 |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: Support openstack context for workflow and task - 2 https://review.openstack.org/414059 | 10:11 |
| sharatss | rakhmerov: yea.. thats the reason i wanted to revert those changes | 10:13 |
| rakhmerov | :) | 10:14 |
| rakhmerov | I just didn't realize then that it was a problem of all those tests | 10:14 |
| sharatss | rakhmerov: it might take some time to fix them :( | 10:14 |
| rakhmerov | I know | 10:14 |
| rakhmerov | just please make it your highest priority | 10:14 |
| sharatss | rakhmerov: yes. i will look into them now | 10:15 |
| rakhmerov | thanks | 10:15 |
| kong_ | hi, rakhmerov | 10:17 |
| kong_ | i submitted a spec for multi-region support feature https://review.openstack.org/#/c/414508/ | 10:18 |
| kong_ | i'd rather call it openstack context because we may support other thing besides region name in future | 10:18 |
| kong_ | hope that spec will help you understant what i am thinking | 10:19 |
| rakhmerov | kong_: hi, ok, I'll review shortly | 10:19 |
| rakhmerov | ok :) | 10:19 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Fix failing test cases in test_tasks https://review.openstack.org/414541 | 10:32 |
| sharatss | rakhmerov: ^ | 10:32 |
| rakhmerov | yes | 10:32 |
| rakhmerov | I see | 10:32 |
| rakhmerov | sharatss: it's not the right fix | 10:32 |
| rakhmerov | the problem is a little deeper | 10:33 |
| sharatss | ohh :( | 10:33 |
| rakhmerov | the fact of the matter is: engine component doesn't even start, it's pointless to send messages to it | 10:33 |
| sharatss | rakhmerov: i might need some time then :( | 10:33 |
| rakhmerov | it will be always timeouting | 10:33 |
| rakhmerov | and these tests will be taking a lot of time | 10:34 |
| rakhmerov | sharatss: I didn't say it would be easy :) | 10:34 |
| rakhmerov | but don't be afraid of taking more serious tasks | 10:34 |
| sharatss | rakhmerov: yes. but i am causing the trouble :( | 10:35 |
| rakhmerov | we'll wait, no problem | 10:35 |
| rakhmerov | as an idea: you can probably mock calls to RPC engine client | 10:35 |
| rakhmerov | so that they don't call engine for real and return what we need | 10:36 |
| sharatss | rakhmerov: hmmm.. will try that | 10:37 |
| rakhmerov | ask questions please | 10:37 |
| rakhmerov | we'll help | 10:37 |
| sharatss | rakhmerov: sure | 10:38 |
| sharatss | rakhmerov: can it work if i use rpc.EngineClient instead of db_api | 10:43 |
| rakhmerov | it should, yes | 10:43 |
| rakhmerov | please try | 10:43 |
| sharatss | what about the response code? 200? | 10:44 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Fix failing test cases in test_tasks https://review.openstack.org/414541 | 10:46 |
| openstackgerrit | Renat Akhmerov proposed openstack/python-mistralclient: Add filters to client Python APIs https://review.openstack.org/414553 | 11:44 |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/414287 | 11:51 |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Support i18n for LOG.warning https://review.openstack.org/414498 | 11:58 |
| *** d0ugal has quit IRC | 12:28 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Fix failing test cases in test_tasks https://review.openstack.org/414541 | 12:37 |
| *** d0ugal has joined #openstack-mistral | 12:45 | |
| *** d0ugal has quit IRC | 12:51 | |
| *** bobh has joined #openstack-mistral | 14:01 | |
| *** bobh has quit IRC | 14:01 | |
| *** bobh has joined #openstack-mistral | 14:02 | |
| *** bobh has quit IRC | 14:47 | |
| *** shardy has quit IRC | 17:21 | |
| *** Qiming has quit IRC | 18:53 | |
| *** bobh has joined #openstack-mistral | 19:24 | |
| *** bobh has quit IRC | 20:26 | |
| *** bobh has joined #openstack-mistral | 20:28 | |
| *** bobh has quit IRC | 20:37 | |
| *** bobh has joined #openstack-mistral | 20:43 | |
| *** bobh has quit IRC | 22:00 | |
| *** bobh has joined #openstack-mistral | 22:01 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!