| *** dmellado has quit IRC | 00:29 | |
| *** _gryf_ has joined #openstack-mistral | 00:41 | |
| *** _gryf has quit IRC | 00:45 | |
| *** doriftoshoes has quit IRC | 00:57 | |
| *** dmellado has joined #openstack-mistral | 01:03 | |
| *** doriftoshoes has joined #openstack-mistral | 01:07 | |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: Role based resource access control - get workflows https://review.openstack.org/413791 | 01:12 |
|---|---|---|
| *** dmellado has quit IRC | 01:21 | |
| *** bobh has joined #openstack-mistral | 01:22 | |
| *** dmellado has joined #openstack-mistral | 01:30 | |
| *** bobh has quit IRC | 01:31 | |
| *** bobh has joined #openstack-mistral | 01:34 | |
| *** bobh has quit IRC | 01:40 | |
| *** catintheroof has quit IRC | 01:42 | |
| *** bobh has joined #openstack-mistral | 01:42 | |
| *** bobh has quit IRC | 02:00 | |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: Support openstack context for workflow and task - 1 https://review.openstack.org/407240 | 02:14 |
| *** bobh has joined #openstack-mistral | 02:17 | |
| *** bobh has quit IRC | 02:30 | |
| *** bobh has joined #openstack-mistral | 02:47 | |
| *** bobh has quit IRC | 03:18 | |
| *** bobh has joined #openstack-mistral | 03:21 | |
| *** bobh has quit IRC | 04:11 | |
| *** bobh has joined #openstack-mistral | 04:19 | |
| *** bobh has quit IRC | 04:31 | |
| *** sharatss has joined #openstack-mistral | 04:39 | |
| openstackgerrit | Jeffrey Zhang proposed openstack/mistral-dashboard: Move _50_mistral.py file into enabled folder https://review.openstack.org/413908 | 05:02 |
| openstackgerrit | Jeffrey Zhang proposed openstack/mistral-dashboard: Move _50_mistral.py file into enabled folder https://review.openstack.org/413908 | 05:07 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-dashboard: Move _50_mistral.py file into enabled folder https://review.openstack.org/413908 | 05:34 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-dashboard: Move _50_mistral.py file into enabled folder https://review.openstack.org/413908 | 05:43 |
| openstackgerrit | Jeffrey Zhang proposed openstack/mistral-dashboard: Move _50_mistral.py file into enabled folder https://review.openstack.org/413908 | 06:10 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-dashboard: Move _50_mistral.py file into enabled folder https://review.openstack.org/413908 | 06:37 |
| *** openstackgerrit has quit IRC | 06:48 | |
| *** ist has joined #openstack-mistral | 06:50 | |
| *** openstackgerrit has joined #openstack-mistral | 07:00 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Added congress actions into Mistral https://review.openstack.org/410208 | 07:00 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-dashboard: Move _50_mistral.py file into enabled folder https://review.openstack.org/413908 | 07:09 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-dashboard: Move _50_mistral.py file into enabled folder https://review.openstack.org/413908 | 07:10 |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Use assertGreater() or assertLess() https://review.openstack.org/413944 | 07:23 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Fix doc for missing dashboard config file https://review.openstack.org/413947 | 07:31 |
| rakhmerov | sharatss: hi, did you investigate how to deal with https://review.openstack.org/#/c/411120/ ? | 07:42 |
| rakhmerov | the problem still exists | 07:42 |
| *** _gryf_ is now known as _gryf | 07:45 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Fix doc for missing dashboard config file https://review.openstack.org/413947 | 07:46 |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** openstackgerrit has joined #openstack-mistral | 07:57 | |
| openstackgerrit | Jeffrey Zhang proposed openstack/mistral: Copy _50_mistral.py file from enabled folder https://review.openstack.org/413953 | 07:57 |
| rakhmerov | d0ugal: Dougal, hi | 08:07 |
| rakhmerov | take a look at http://logs.openstack.org/89/412389/1/gate/gate-mistral-python27-ubuntu-xenial/e0a6d8c/testr_results.html.gz | 08:07 |
| rakhmerov | seems like this failure is not related with your time experiments | 08:08 |
| rakhmerov | sharatss: even more urgent thing: http://logs.openstack.org/68/413468/1/gate/gate-mistral-python27-ubuntu-xenial/13298f1/testr_results.html.gz | 08:14 |
| rakhmerov | this is a test that you added recently | 08:14 |
| rakhmerov | please figure out how to fix it | 08:14 |
| rakhmerov | do it asap please | 08:14 |
| openstackgerrit | Merged openstack/mistral: Replace six.iteritems() with .items() https://review.openstack.org/411845 | 08:21 |
| *** sharatss has quit IRC | 08:22 | |
| *** sharatss has joined #openstack-mistral | 08:22 | |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Support i18n for LOG.warning https://review.openstack.org/413965 | 08:22 |
| ist | Hi all! Do you have ever faced following sqlachemy error: | 08:23 |
| ist | TimeoutError: QueuePool limit of size 5 overflow 50 reached, connection timed out, timeout 30 | 08:23 |
| ist | I happens after a couple of days when we run 16 mistral workflows parallel | 08:24 |
| rakhmerov | ist: hi Istvan | 08:25 |
| rakhmerov | yes, there are parameters in config | 08:25 |
| rakhmerov | sec | 08:25 |
| ist | Hello Renat! | 08:25 |
| rakhmerov | :) | 08:25 |
| rakhmerov | how are you? | 08:25 |
| ist | oh so we need to increase the available connection amount? | 08:26 |
| *** shardy has joined #openstack-mistral | 08:26 | |
| rakhmerov | yes | 08:26 |
| ist | fine thanks, this is my last day before my winter holiday, and this problem just appeared in long run tests | 08:27 |
| rakhmerov | http://paste.openstack.org/show/593097/ | 08:27 |
| rakhmerov | this is what I have in my config | 08:27 |
| rakhmerov | sometimes if load is too high Mistral may run out of connections in the pool | 08:27 |
| *** mgershen has joined #openstack-mistral | 08:28 | |
| rakhmerov | you can tweak these params | 08:28 |
| ist | Thanks we going to try it... | 08:28 |
| rakhmerov | you can also read more about these params in oslo.db documentation | 08:28 |
| rakhmerov | ok | 08:28 |
| rakhmerov | sharatss: the problem of this failing test (test_put_current_task_in_error) is that you're trying to use engine | 08:34 |
| rakhmerov | but engine doesn't even start in API tests | 08:34 |
| rakhmerov | that's why we're getting 500 error | 08:34 |
| rakhmerov | so the test is not designed correctly | 08:35 |
| rakhmerov | what confuses me is how come it was able to merge? | 08:35 |
| rakhmerov | d0ugal: ^ FYI too | 08:35 |
| *** ^Gal^ has joined #openstack-mistral | 08:39 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Disable invalid API test till it's fixed https://review.openstack.org/413968 | 08:39 |
| rakhmerov | ddeja, d0ugal, kong_: guys, review and approve https://review.openstack.org/#/c/413968/ asap once it passes. It blocks development | 08:41 |
| rakhmerov | The reason why this test was able to merge is in the order of running tests | 08:42 |
| rakhmerov | it's my hypothesis | 08:42 |
| rakhmerov | it was just lucky because after some other test there was a running engine that was able to serve RPC messages | 08:43 |
| rakhmerov | which is also a bug, it's a different thing | 08:43 |
| *** sharatss has quit IRC | 08:43 | |
| ddeja | rakhmerov: OK | 08:52 |
| d0ugal | Morning | 08:56 |
| rakhmerov | good morning | 09:03 |
| rakhmerov | please approve the patch | 09:03 |
| rakhmerov | unit tests passed for it.. | 09:03 |
| rakhmerov | after that sharatass can figure out how to redesign it | 09:04 |
| ddeja | rakhmerov: you have my +2 ;) | 09:07 |
| rakhmerov | ok | 09:07 |
| d0ugal | Done | 09:07 |
| d0ugal | I don't really like disabling tests | 09:07 |
| d0ugal | rakhmerov: can you open a bug about it so we don't forget? | 09:08 |
| d0ugal | ddeja: lol, I just spotted your comment. | 09:10 |
| ddeja | d0ugal: I always try to have fun while doing my job ;) | 09:27 |
| d0ugal | :-D the only way to do it! | 09:27 |
| *** sharatss has joined #openstack-mistral | 09:30 | |
| *** dkushwaha has joined #openstack-mistral | 09:33 | |
| sharatss | rakhmerov: we shall revert back that change as of now | 09:52 |
| sharatss | rakhmerov: i will find a proper design and commit it back | 09:53 |
| rakhmerov | d0ugal: I agree, I don't like this either | 09:54 |
| rakhmerov | but it's better to do so for now | 09:54 |
| rakhmerov | sharatss: sure, np | 09:54 |
| d0ugal | I'm not sure I agree, but okay :) | 09:54 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Revert "Added test cases for a few possible scenarios" https://review.openstack.org/413996 | 09:54 |
| rakhmerov | agree with what? | 09:55 |
| d0ugal | agree that it is better to disable | 09:55 |
| rakhmerov | ok | 09:55 |
| rakhmerov | it just blocks everything | 09:55 |
| d0ugal | Yeah, I know | 09:56 |
| rakhmerov | fixing may take some time | 09:56 |
| d0ugal | but it hadn't blocked for that long, so looking for a fix may be better | 09:56 |
| d0ugal | I guess it is just different approaches :) | 09:56 |
| d0ugal | Nobody in tripleo would let me disable a test :) | 09:56 |
| sharatss | rakhmerov: d0ugal pls help me with the congress integration patch | 09:56 |
| d0ugal | sharatss: I am not familiar with congress. | 09:58 |
| rakhmerov | d0ugal: different approaches, agree. At this stage of the cycle the speed of development seems to be more important for me. Especially given that our patches take in the best case 3 hours to get merged. If it didn't block the whole development I would be ok to fix it right away | 09:59 |
| rakhmerov | d0ugal: but yes, we should try to avoid it :) | 09:59 |
| d0ugal | 3 hours seems quick! | 09:59 |
| rakhmerov | really???!! :))) | 09:59 |
| rakhmerov | in the best case | 09:59 |
| *** jaosorior has joined #openstack-mistral | 09:59 | |
| d0ugal | lol | 09:59 |
| rakhmerov | sometimes much much longer | 09:59 |
| sharatss | d0ugal: i dont even know what is wrong with that patch :( | 10:02 |
| sharatss | rakhmerov: regarding that horizon dependency check i am yet to investigate | 10:03 |
| sharatss | rakhmerov: our tests are passing in dashboard now. that was my primary concern :) | 10:03 |
| sharatss | i will look into the dependency thing as well | 10:03 |
| d0ugal | sharatss: http://logs.openstack.org/08/410208/6/check/gate-mistral-python27-ubuntu-xenial/6de2c4c/console.html#_2016-12-22_07_08_14_592405 | 10:04 |
| * sharatss santa is dancing right beside me | 10:04 | |
| d0ugal | sharatss: it looks like there might be a small typo somewhere? | 10:04 |
| rakhmerov | https://bugs.launchpad.net/mistral/+bug/1651996 | 10:04 |
| openstack | Launchpad bug 1651996 in Mistral "Fix api.v2.test_tasks.test_put_current_task_in_error " [High,Confirmed] - Assigned to Sharat Sharma (sharat-sharma) | 10:04 |
| d0ugal | Thanks! | 10:05 |
| d0ugal | sharatss: same failure on python3. http://logs.openstack.org/08/410208/6/check/gate-mistral-python35/484e74c/console.html#_2016-12-22_07_05_27_963888 | 10:05 |
| d0ugal | Also, I would quite like a personal dancing santa. | 10:06 |
| d0ugal | oh, cool - there is a new coverage check? | 10:07 |
| rakhmerov | yep ) | 10:07 |
| rakhmerov | btw, I thought our coverage is much worse than it is | 10:08 |
| d0ugal | haha, what is it? | 10:08 |
| rakhmerov | it's 83% | 10:08 |
| d0ugal | I looked a while ago, but forgot | 10:08 |
| d0ugal | Not bad. | 10:08 |
| rakhmerov | on unit tests only | 10:08 |
| rakhmerov | yeah | 10:08 |
| rakhmerov | with functional tests I believe it's close to 90% | 10:08 |
| d0ugal | Will the new check require a certain value? | 10:08 |
| rakhmerov | which is, de facto, the standard | 10:08 |
| rakhmerov | no, but I would like to configure it later so that it fails if it goes lower than 90% | 10:09 |
| rakhmerov | but first we need to reach 90% for unit tests | 10:09 |
| rakhmerov | it's possible | 10:09 |
| d0ugal | Yup | 10:09 |
| rakhmerov | I realized that some of the things that we can test in unit tests are not actually tested | 10:10 |
| rakhmerov | it's all in the report | 10:10 |
| d0ugal | I quite enjoy improving coverage, maybe I can find time to help next year | 10:10 |
| d0ugal | (this is my last day this year! woo!) | 10:10 |
| rakhmerov | sure | 10:11 |
| rakhmerov | the report is very cool | 10:11 |
| rakhmerov | it shows which logical branches are covered and what are not | 10:12 |
| rakhmerov | so that we can see what tests we're missing | 10:12 |
| d0ugal | coverage.py is great. | 10:12 |
| rakhmerov | I walked over it and seems like there's just a lot of corner cases that are not covered | 10:12 |
| rakhmerov | d0ugal: btw, I got a question recently about whether we can also generate a similar report but for functional tests | 10:13 |
| rakhmerov | do you have an idea how to do it? | 10:13 |
| rakhmerov | should be not be a problem I guess but I'm not well familiar with it | 10:14 |
| d0ugal | rakhmerov: it should be easy. do we do it via tox for the unit tests? | 10:14 |
| openstackgerrit | Merged openstack/mistral: Fix version response from root controller https://review.openstack.org/412389 | 10:14 |
| rakhmerov | yes, I believe. I just reused an existing job in CI, I don't know how it works | 10:15 |
| d0ugal | rakhmerov: how do I run the functional tests? | 10:15 |
| rakhmerov | good question :) | 10:15 |
| rakhmerov | there's a the whole setup for that | 10:15 |
| rakhmerov | devstack etc. | 10:15 |
| d0ugal | oh | 10:15 |
| d0ugal | so this would be for the rally tests? | 10:15 |
| rakhmerov | no, for tests that run in devstack-dsvm gate | 10:16 |
| rakhmerov | which are in the package 'tests/functional' in our code base | 10:16 |
| rakhmerov | they use tempest | 10:16 |
| d0ugal | https://github.com/openstack/mistral/blob/master/run_functional_tests.sh | 10:16 |
| d0ugal | hm | 10:17 |
| rakhmerov | not sure that this script is actually used | 10:17 |
| d0ugal | oh | 10:17 |
| d0ugal | haha | 10:17 |
| rakhmerov | yeah :) | 10:17 |
| d0ugal | if it was, it would be easy. | 10:17 |
| d0ugal | https://github.com/openstack/mistral/blob/master/run_functional_tests.sh#L17 | 10:17 |
| d0ugal | nose has support for coverage | 10:17 |
| rakhmerov | ok | 10:17 |
| rakhmerov | good, we need to do it in the NY | 10:18 |
| d0ugal | it is going to be a busy year! | 10:21 |
| rakhmerov | you think so? :) | 10:33 |
| rakhmerov | why? | 10:33 |
| d0ugal | rakhmerov: because there is so much to do in every project I am involved with. | 10:33 |
| rakhmerov | you do something else besides TripleO and Mistral? | 10:34 |
| d0ugal | rakhmerov: no, not really | 10:35 |
| d0ugal | rakhmerov: but TripleO is huge. | 10:35 |
| rakhmerov | ok, I see | 10:35 |
| d0ugal | I need to do a better job of making time for Mistral | 10:36 |
| d0ugal | Hopefully I can balance that better next year. | 10:36 |
| *** gongysh has joined #openstack-mistral | 10:39 | |
| *** ^Gal^ has quit IRC | 10:51 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-dashboard: Remove the dependency on horizon repo https://review.openstack.org/414014 | 10:58 |
| openstackgerrit | Merged openstack/mistral: Disable invalid API test till it's fixed https://review.openstack.org/413968 | 11:10 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add aodh actions to mistral https://review.openstack.org/408684 | 11:12 |
| rakhmerov | d0ugal: ok, hope so | 11:12 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-dashboard: Remove the dependency on horizon repo https://review.openstack.org/414014 | 11:17 |
| *** mgershen has quit IRC | 11:23 | |
| openstackgerrit | Merged openstack/mistral: Make body of std.email optional https://review.openstack.org/413468 | 11:24 |
| sharatss | rakhmerov: https://review.openstack.org/#/c/414014/ | 11:27 |
| sharatss | rakhmerov: can u check with this? | 11:27 |
| rakhmerov | not today, tomorrow | 11:27 |
| sharatss | rakhmerov: sure boss :) | 11:27 |
| rakhmerov | you can check too by installing devstack with mistral plugin ;) | 11:28 |
| rakhmerov | so is this how it's done in other projects? | 11:28 |
| sharatss | rakhmerov: yea.. i checked with murano | 11:28 |
| rakhmerov | ooh, ok | 11:28 |
| rakhmerov | good, thanks a lot, I'll check that tomorrow | 11:29 |
| sharatss | i will check it meanwhile.. your confirmation is a must | 11:29 |
| *** ^Gal^ has joined #openstack-mistral | 11:36 | |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: Support openstack context for workflow and task - 2 https://review.openstack.org/414059 | 11:37 |
| *** sharatss has quit IRC | 11:53 | |
| *** sharatss has joined #openstack-mistral | 11:53 | |
| *** sharatss has quit IRC | 11:54 | |
| *** sharatss has joined #openstack-mistral | 11:54 | |
| *** mgershen has joined #openstack-mistral | 11:56 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add a test for 'with-items' task: count=100, concurrency=10 https://review.openstack.org/413574 | 12:01 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add rally tests for 'join': 100 and 500 parallel tasks https://review.openstack.org/413586 | 12:01 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor 'stress_test' to fit the current layout better https://review.openstack.org/414066 | 12:01 |
| *** gongysh has quit IRC | 12:08 | |
| *** dprince has joined #openstack-mistral | 12:58 | |
| *** mgershen has quit IRC | 13:16 | |
| *** chlong has joined #openstack-mistral | 13:23 | |
| *** ^Gal^ has quit IRC | 13:39 | |
| *** mgershen has joined #openstack-mistral | 13:40 | |
| *** ^Gal^ has joined #openstack-mistral | 13:41 | |
| *** thrash|g0ne is now known as thrash | 13:53 | |
| openstackgerrit | Merged openstack/mistral: Add aodh actions to mistral https://review.openstack.org/408684 | 14:06 |
| *** dkushwaha has quit IRC | 14:10 | |
| *** bobh has joined #openstack-mistral | 14:17 | |
| *** bobh has quit IRC | 14:17 | |
| *** bobh has joined #openstack-mistral | 14:18 | |
| *** ist has quit IRC | 14:23 | |
| openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: Work in progress: action table search https://review.openstack.org/414165 | 14:27 |
| *** bobh has quit IRC | 14:51 | |
| *** bobh has joined #openstack-mistral | 15:33 | |
| *** bobh has quit IRC | 15:35 | |
| rakhmerov | d0ugal: did you have a chance to look at that time issue? | 15:56 |
| rakhmerov | today | 15:56 |
| d0ugal | rakhmerov: only a little bit | 16:01 |
| d0ugal | rakhmerov: I guess I am feeling quite distracted with it being my last day for the year | 16:01 |
| d0ugal | sorry :P | 16:01 |
| rakhmerov | np | 16:02 |
| rakhmerov | :) | 16:02 |
| rakhmerov | seems like it can wait | 16:02 |
| d0ugal | yeah, I guess so | 16:04 |
| d0ugal | since it has been broken for a few weeks :-D | 16:04 |
| *** bobh has joined #openstack-mistral | 16:08 | |
| *** bobh has quit IRC | 16:09 | |
| *** ^Gal^ has quit IRC | 16:50 | |
| *** shardy has quit IRC | 16:51 | |
| *** jaosorior has quit IRC | 17:05 | |
| *** jaosorior has joined #openstack-mistral | 17:05 | |
| *** mgershen has quit IRC | 17:39 | |
| *** weshay is now known as weshay_afk | 17:54 | |
| *** bobh has joined #openstack-mistral | 18:34 | |
| *** bobh has quit IRC | 18:36 | |
| *** bobh has joined #openstack-mistral | 19:20 | |
| *** bobh has quit IRC | 19:57 | |
| *** bobh has joined #openstack-mistral | 20:22 | |
| *** bobh has quit IRC | 20:30 | |
| *** jaosorior has quit IRC | 21:16 | |
| *** toure is now known as toure|gone | 21:58 | |
| *** dprince has quit IRC | 21:59 | |
| *** Kiall has joined #openstack-mistral | 22:13 | |
| *** chlong has quit IRC | 22:34 | |
| *** chlong has joined #openstack-mistral | 22:41 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!