| openstackgerrit | Lingxian Kong proposed openstack/mistral-extra: Add clone vm example https://review.openstack.org/396840 | 00:14 |
|---|---|---|
| *** catintheroof has quit IRC | 00:23 | |
| *** catintheroof has joined #openstack-mistral | 00:24 | |
| *** catintheroof has quit IRC | 00:28 | |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: Support openstack context for workflow and task https://review.openstack.org/407240 | 00:33 |
| *** toure|biab is now known as toure | 00:47 | |
| *** jamielennox is now known as jamielennox|away | 01:07 | |
| *** jamielennox|away is now known as jamielennox | 01:21 | |
| *** Jizhaoxuan has joined #openstack-mistral | 01:42 | |
| *** sharatss has quit IRC | 02:12 | |
| *** thrash is now known as thrash|g0ne | 02:24 | |
| *** liujiong has joined #openstack-mistral | 02:25 | |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: Support openstack context for workflow and task https://review.openstack.org/407240 | 03:55 |
| *** sharatss has joined #openstack-mistral | 04:40 | |
| *** bobh has joined #openstack-mistral | 04:43 | |
| *** bobh has quit IRC | 04:58 | |
| *** zhenguo_ has joined #openstack-mistral | 05:14 | |
| *** zhenguo has quit IRC | 05:15 | |
| *** doriftoshoes has quit IRC | 05:15 | |
| *** zhenguo_ is now known as zhenguo | 05:15 | |
| *** hrybacki has quit IRC | 05:15 | |
| *** jamielennox has quit IRC | 05:16 | |
| *** doriftoshoes has joined #openstack-mistral | 05:18 | |
| *** hrybacki has joined #openstack-mistral | 05:18 | |
| *** jamielennox has joined #openstack-mistral | 05:31 | |
| *** sharatss has quit IRC | 05:35 | |
| *** sharatss has joined #openstack-mistral | 05:35 | |
| *** ist has joined #openstack-mistral | 05:45 | |
| Jizhaoxuan | hello,if somebody has time today,could you please look at https://review.openstack.org/#/c/406740/ ? I'm not sure whether my modification is right or not. | 05:48 |
| *** sharatss has quit IRC | 05:53 | |
| *** jaosorior has joined #openstack-mistral | 06:02 | |
| *** ddeja has quit IRC | 06:14 | |
| *** ddeja has joined #openstack-mistral | 06:14 | |
| *** sharatss has joined #openstack-mistral | 06:20 | |
| sharatss | rakhmerov: hi | 06:20 |
| rakhmerov | hi | 06:20 |
| sharatss | regarding the pythonclient docs | 06:20 |
| sharatss | i dont have much idea about keycloak thing | 06:21 |
| sharatss | rakhmerov: i can document the other two things. | 06:21 |
| rakhmerov | leave keycloak on me | 06:21 |
| sharatss | rakhmerov: so can i just create a empty file for keycloak and add TODO into it? | 06:22 |
| rakhmerov | yes | 06:22 |
| sharatss | rakhmerov: ok.. will commit it by EOD then | 06:22 |
| rakhmerov | thanks, ok | 06:22 |
| *** janki has joined #openstack-mistral | 06:35 | |
| *** jamielennox is now known as jamielennox|away | 07:11 | |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient: Initial commit for python-mistralclient document https://review.openstack.org/404736 | 07:19 |
| *** jaosorior has quit IRC | 07:22 | |
| *** jaosorior has joined #openstack-mistral | 07:23 | |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: change the cron-trigger execution time from localtime to UTC https://review.openstack.org/406740 | 07:28 |
| *** sharatss has quit IRC | 07:39 | |
| *** jpich has joined #openstack-mistral | 07:44 | |
| *** shardy has joined #openstack-mistral | 07:46 | |
| *** mgershen has joined #openstack-mistral | 07:58 | |
| *** mgershen has quit IRC | 08:17 | |
| Jizhaoxuan | hello,everyone.I want to ask you a question: has anyone ever seen this problem: https://bugs.launchpad.net/mistral/+bug/1642908 ? Could we talk about it? | 08:27 |
| openstack | Launchpad bug 1642908 in Mistral "The semantical difference between "on-complete" and "on-success" + "on-error" is not documented" [Medium,Confirmed] - Assigned to jzx (xuange) | 08:27 |
| *** mgershen has joined #openstack-mistral | 08:39 | |
| *** sharatss has joined #openstack-mistral | 08:46 | |
| sharatss | rakhmerov: d0ugal ddeja any updates on the devstack gate for client? almost all the commits are failing :( | 08:47 |
| rakhmerov | ddeja is working on it | 09:18 |
| rakhmerov | Jizhaoxuan: hi, it's not a problem. It's rather a poorly documented aspect | 09:18 |
| rakhmerov | yes, we can talk about it | 09:19 |
| rakhmerov | d0ugal, kong_: can you guys please review https://review.openstack.org/#/c/405961/ and https://review.openstack.org/#/c/407330/ | 09:20 |
| rakhmerov | and we also have a bunch of other patches | 09:20 |
| d0ugal | I was already reviewing 330 | 09:20 |
| d0ugal | I'll look at more later | 09:20 |
| d0ugal | I just look at the list of patches anyway | 09:21 |
| openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: mistral-dashboard:fixed boolean field design bug https://review.openstack.org/407573 | 09:21 |
| rakhmerov | d0ugal: ok | 09:22 |
| Jizhaoxuan | rakhmerov: ok,thank you.I don't know the difference between 'on-complete' and 'on-success'+'on-error',and I tried to find something in codes,but I didn't get a result. | 09:25 |
| rakhmerov | Jizhaoxuan: did you face some problem with that? | 09:26 |
| rakhmerov | or you just wanted to take a close this bug? | 09:26 |
| rakhmerov | I can explain the difference, if you want | 09:26 |
| Jizhaoxuan | I didn't face any problems,I just don't understand why is that. | 09:28 |
| rakhmerov | ok, let me find the place.. | 09:29 |
| Jizhaoxuan | I found 'complete' states include 'success','error' and 'cancelled' in codes. | 09:29 |
| rakhmerov | it's not it.. | 09:30 |
| rakhmerov | https://github.com/openstack/mistral/blob/master/mistral/workflow/direct_workflow.py#L184 | 09:31 |
| Jizhaoxuan | ok,thank you | 09:31 |
| rakhmerov | Jizhaoxuan: this is the place | 09:31 |
| rakhmerov | pay attention also on line 193 | 09:31 |
| rakhmerov | it explicitly uses "on-error" clause | 09:32 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Fix for failing kombu gate https://review.openstack.org/406143 | 09:32 |
| rakhmerov | so the assumption is: if a task failed but we have "on-error" the WF can still continue | 09:32 |
| rakhmerov | because it's treated as "catch" (or "except" in Python) | 09:33 |
| rakhmerov | otherwise the error bubbles up from the task and make the entire WF fail | 09:33 |
| rakhmerov | whereas "on-complete" is only a "finally" which allows you to do some post-failure actions (cleanup etc.) | 09:34 |
| rakhmerov | Jizhaoxuan: or for one specific task it's https://github.com/openstack/mistral/blob/master/mistral/workflow/direct_workflow.py#L181 | 09:34 |
| rakhmerov | there's not use of "on-complete" here | 09:34 |
| rakhmerov | so it doesn't handle an error | 09:35 |
| Jizhaoxuan | thank you very much,I am beginning to understand. | 09:37 |
| *** jpich has quit IRC | 09:37 | |
| ddeja | rakhmerov: I found the source of our gates problem | 09:37 |
| rakhmerov | Jizhaoxuan: np, anytime | 09:38 |
| rakhmerov | ddeja: ok, can you share the details? | 09:38 |
| ddeja | and why they didn't show erlier | 09:38 |
| rakhmerov | isn't it what we discussed yesterday? | 09:38 |
| ddeja | yes, but I also found out why we hit it now | 09:38 |
| rakhmerov | :) | 09:39 |
| ddeja | in mysql 5.5 the mircoseconds were dropped | 09:39 |
| ddeja | but starting mysql 5.6 they got rounded | 09:39 |
| rakhmerov | I'm anxious to know :) | 09:39 |
| ddeja | and when we switch from 14.04 on our gates to 16.04 | 09:39 |
| rakhmerov | so? | 09:39 |
| ddeja | we also switch mysql from 5.5 to 5.7 | 09:39 |
| rakhmerov | ooh | 09:39 |
| rakhmerov | mysql changed | 09:39 |
| rakhmerov | yeah | 09:39 |
| ddeja | and the default behavior switch from 'drop' to 'round' | 09:39 |
| rakhmerov | ooh man... | 09:39 |
| rakhmerov | yeah | 09:40 |
| ddeja | it's this easy | 09:40 |
| rakhmerov | ddeja: awesome | 09:40 |
| rakhmerov | awesome job | 09:40 |
| rakhmerov | let's fix it asap | 09:40 |
| rakhmerov | I got sick of rechecking patches again and again | 09:40 |
| ddeja | rakhmerov: I'm launching the vm with ubuntu 14.04 to make sure it works this way | 09:40 |
| rakhmerov | ok | 09:40 |
| ddeja | and in the same time I'm fixing my patch that drops the fractional seconds | 09:41 |
| rakhmerov | yes | 09:41 |
| rakhmerov | cool | 09:41 |
| rakhmerov | I'm also wondering why it is seen in kombu gate more than in others | 09:42 |
| rakhmerov | do you have an answer? | 09:42 |
| rakhmerov | different version of mysql? | 09:42 |
| rakhmerov | ddeja: ^ | 09:42 |
| ddeja | rakhmerov: well, it also happening a lot now on the regular dsvm in client | 09:44 |
| rakhmerov | true | 09:45 |
| rakhmerov | yes | 09:45 |
| rakhmerov | ok | 09:45 |
| ddeja | but yes, dvsm gate on mistral itself is still on ubunut trusy = 14.04 = mysql 5.5 | 09:46 |
| *** jpich has joined #openstack-mistral | 09:47 | |
| ddeja | rakhmerov: double checked - just take a look http://paste.openstack.org/show/591628/ | 09:53 |
| rakhmerov | haha :)) | 09:56 |
| rakhmerov | very cool | 09:56 |
| rakhmerov | we've seen this before many times but nobody ever got to the root of the problem | 09:56 |
| rakhmerov | :) | 09:56 |
| *** mgershen has quit IRC | 09:59 | |
| ddeja | guys in my office are also amazed why on earth would someone change such behaviour | 10:00 |
| *** dtantsur|afk is now known as dtantsur | 10:03 | |
| rakhmerov | ddeja: quick question | 10:07 |
| rakhmerov | how are these changes related to dates? https://review.openstack.org/#/c/406143/5/mistral/tests/unit/engine/test_reverse_workflow_rerun.py | 10:07 |
| rakhmerov | is it just a refactoring? | 10:08 |
| ddeja | rakhmerov: those tests were relying on the order of action_execution objects | 10:09 |
| ddeja | since we dropped mircosends, the have same time | 10:09 |
| ddeja | so they appear in radnom order | 10:09 |
| rakhmerov | ooh, I see | 10:09 |
| rakhmerov | right | 10:09 |
| ddeja | I hope I found all of these tests.. | 10:10 |
| rakhmerov | kombu and dsvm are still failing on your patch | 10:11 |
| rakhmerov | but seems like the reason is different | 10:11 |
| ddeja | rakhmerov: There are 3 or 4 tests that fails | 10:12 |
| ddeja | in kombu gate | 10:13 |
| rakhmerov | exact same in dsvm | 10:13 |
| ddeja | only one of them was related to date issue | 10:13 |
| ddeja | oh, OK | 10:13 |
| ddeja | but once we merge it, it should unblock the dsvm gate in mistralclient | 10:15 |
| rakhmerov | Yes, ok, take a look at my comment | 10:17 |
| ddeja | rakhmerov: utcnow_without_microseconds seems OK? | 10:19 |
| rakhmerov | :)) | 10:19 |
| rakhmerov | kind of long ) | 10:19 |
| rakhmerov | let me think.. | 10:20 |
| rakhmerov | what about my questions about milliseconds? | 10:20 |
| rakhmerov | do we also need to drop them explicitly? | 10:20 |
| rakhmerov | if yes, we could call it utc_now_seconds or utc_now_sec | 10:21 |
| ddeja | rakhmerov: well, datetime object only have microseconds | 10:22 |
| ddeja | it doesn't store miliseconds | 10:22 |
| rakhmerov | so, microseconds part serves also for milliseconds, right? | 10:22 |
| ddeja | yes | 10:22 |
| rakhmerov | ok | 10:22 |
| ddeja | mircoseconds is a 6-digit number | 10:22 |
| rakhmerov | ok | 10:22 |
| rakhmerov | then let's calls like I proposed | 10:23 |
| rakhmerov | if it's ok with you | 10:23 |
| ddeja | ok | 10:23 |
| ddeja | about the dsvm gate failing | 10:24 |
| ddeja | I guess it is some other thing related to the fact that we switched from trusty to xenial | 10:24 |
| ddeja | since the dsvm on trusty (for patchset no 1) passed | 10:25 |
| *** liujiong has quit IRC | 10:25 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Fix for failing kombu gate https://review.openstack.org/406143 | 10:25 |
| Jizhaoxuan | hello,everyone,if somebody have time today,could you please look at https://review.openstack.org/#/c/406740/ ? I'm not sure whether it is right or not. | 10:35 |
| openstackgerrit | fengchaoyang proposed openstack/mistral: Added gnocchi action pack https://review.openstack.org/408005 | 10:36 |
| ddeja | Jizhaoxuan: looking | 10:39 |
| ddeja | rakhmerov: Today we have integration event in my team, so I'm dropping for today in about 0,5hour | 10:39 |
| rakhmerov | ok | 10:39 |
| Jizhaoxuan | ddeja: thanks! | 10:40 |
| rakhmerov | ddeja: ok, I think you're right on other failures | 10:40 |
| rakhmerov | we'll need to merge your patch asap | 10:40 |
| ddeja | rakhmerov: OK | 10:42 |
| *** jaosorior has quit IRC | 10:42 | |
| rakhmerov | d0ugal, kong_: guys, if you have a few mins please look at https://review.openstack.org/#/c/406143/ | 10:52 |
| rakhmerov | it's pretty urgent, it should unblock our client development | 10:52 |
| *** mgershen has joined #openstack-mistral | 10:54 | |
| *** dtantsur is now known as dtantsur|brb | 10:56 | |
| *** shardy has quit IRC | 10:58 | |
| *** kong_ has quit IRC | 10:58 | |
| *** kong_ has joined #openstack-mistral | 10:59 | |
| rakhmerov | thanks | 11:00 |
| *** thrash|g0ne is now known as thrash | 11:01 | |
| *** EmilienM has left #openstack-mistral | 11:20 | |
| openstackgerrit | Merged openstack/mistral: Handling MistralException in default executor https://review.openstack.org/407330 | 11:25 |
| openstackgerrit | Merged openstack/mistral: Cleanup obvious issues in 'with-items' tests https://review.openstack.org/405961 | 11:26 |
| *** openstackgerrit has quit IRC | 11:32 | |
| *** openstackgerrit has joined #openstack-mistral | 11:50 | |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Modify the function "_get_spec_version(spec_dict)" https://review.openstack.org/404510 | 11:50 |
| *** mgershen has quit IRC | 11:52 | |
| *** catintheroof has joined #openstack-mistral | 11:55 | |
| *** dtantsur|brb is now known as dtantsur | 12:00 | |
| *** mgershen has joined #openstack-mistral | 12:14 | |
| *** Jizhaoxuan has quit IRC | 12:19 | |
| *** catintheroof has quit IRC | 12:32 | |
| *** jaosorior has joined #openstack-mistral | 12:32 | |
| *** catintheroof has joined #openstack-mistral | 12:32 | |
| *** catintheroof has quit IRC | 12:37 | |
| *** mgershen has quit IRC | 12:47 | |
| *** catintheroof has joined #openstack-mistral | 12:54 | |
| openstackgerrit | Merged openstack/mistral: Fix for failing kombu gate https://review.openstack.org/406143 | 12:54 |
| *** brunograz has quit IRC | 12:58 | |
| *** jaosorior has quit IRC | 12:59 | |
| *** mgershen has joined #openstack-mistral | 13:03 | |
| *** bobh has joined #openstack-mistral | 13:05 | |
| *** bobh has quit IRC | 13:05 | |
| *** bobh has joined #openstack-mistral | 13:06 | |
| *** jaosorior has joined #openstack-mistral | 13:10 | |
| *** jpich has quit IRC | 13:11 | |
| *** catinthe_ has joined #openstack-mistral | 13:14 | |
| *** catintheroof has quit IRC | 13:16 | |
| *** bobh has quit IRC | 13:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements https://review.openstack.org/408098 | 13:33 |
| *** jpich has joined #openstack-mistral | 13:58 | |
| *** catintheroof has joined #openstack-mistral | 14:02 | |
| jpich | d0ugal: What's the difference between the actions defined in mappings.json, and the ones that seem to appear "magically" from the setup.cfg file? When is it necessary to update mappings.json? | 14:02 |
| d0ugal | jpich: there isn't really a difference | 14:02 |
| d0ugal | jpich: the mappings.json is just a shortcut for adding actions from every python client | 14:03 |
| d0ugal | otherwise you would need to manually implement each openstack client and each of it's actions | 14:03 |
| d0ugal | so it is semi-automated. | 14:03 |
| jpich | d0ugal: Someone asked me if they needed to update mappings.json after adding a new nova function, but I assume if they update setup.cfg then it'd be enough...? | 14:03 |
| jpich | Oh I see | 14:03 |
| d0ugal | jpich: so, for a new nova function the mapping file needs to be updated. | 14:03 |
| jpich | That makes sense. Thanks! | 14:04 |
| d0ugal | jpich: For example, Dmitry recently added new Ironic actions. https://github.com/openstack/mistral/commit/28e633f851746ebe8c37731fa7f750dfde4190b3 | 14:04 |
| *** catinthe_ has quit IRC | 14:04 | |
| *** dprince has joined #openstack-mistral | 14:14 | |
| *** dprince has quit IRC | 14:38 | |
| *** jaosorior has quit IRC | 14:43 | |
| *** thrash has quit IRC | 14:48 | |
| *** thrash has joined #openstack-mistral | 14:49 | |
| *** thrash has joined #openstack-mistral | 14:49 | |
| *** dprince has joined #openstack-mistral | 14:52 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Support Gnocchi actions in mistral https://review.openstack.org/408156 | 14:56 |
| *** dprince has quit IRC | 15:12 | |
| *** catintheroof has quit IRC | 15:26 | |
| *** catintheroof has joined #openstack-mistral | 15:26 | |
| *** jpich has quit IRC | 15:28 | |
| *** jpich has joined #openstack-mistral | 15:29 | |
| *** ist has quit IRC | 15:30 | |
| *** catintheroof has quit IRC | 15:31 | |
| *** brunograz has joined #openstack-mistral | 15:44 | |
| *** janki has quit IRC | 15:45 | |
| *** catintheroof has joined #openstack-mistral | 15:57 | |
| *** chlong has joined #openstack-mistral | 15:58 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Update the wording in the actions terminology docs https://review.openstack.org/407454 | 16:02 |
| *** pradk has joined #openstack-mistral | 16:04 | |
| *** jpich has quit IRC | 16:17 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Update the wording in the actions terminology docs https://review.openstack.org/407454 | 16:27 |
| *** thrash is now known as thrash|biab | 16:42 | |
| openstackgerrit | Merged openstack/python-mistralclient: Updated tox.ini to pick up requirements from upper constraints https://review.openstack.org/400537 | 16:50 |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/408098 | 16:52 |
| *** Kiall has quit IRC | 16:53 | |
| *** Kiall has joined #openstack-mistral | 16:53 | |
| *** chlong has quit IRC | 16:56 | |
| *** Ephur has joined #openstack-mistral | 17:00 | |
| *** Ephur has quit IRC | 17:02 | |
| *** bobh has joined #openstack-mistral | 17:05 | |
| *** bobh has quit IRC | 17:12 | |
| *** dtantsur is now known as dtantsur|afk | 17:19 | |
| *** chlong has joined #openstack-mistral | 17:30 | |
| openstackgerrit | Merged openstack/python-mistralclient: Make python mistralclient readme better https://review.openstack.org/404249 | 17:34 |
| *** bobh has joined #openstack-mistral | 18:09 | |
| *** bobh has quit IRC | 18:15 | |
| *** thrash|biab is now known as thrash | 18:31 | |
| *** chlong has quit IRC | 18:38 | |
| *** chlong has joined #openstack-mistral | 18:57 | |
| *** bobh has joined #openstack-mistral | 19:11 | |
| *** bobh has quit IRC | 19:15 | |
| *** chlong has quit IRC | 19:36 | |
| *** chlong has joined #openstack-mistral | 20:00 | |
| *** clenimar has quit IRC | 20:01 | |
| *** bobh has joined #openstack-mistral | 20:11 | |
| *** bobh has quit IRC | 20:16 | |
| *** harlowja has quit IRC | 20:41 | |
| *** catintheroof has quit IRC | 21:37 | |
| *** catintheroof has joined #openstack-mistral | 21:38 | |
| *** harlowja has joined #openstack-mistral | 21:41 | |
| *** catintheroof has quit IRC | 21:42 | |
| *** jamielennox|away is now known as jamielennox | 21:49 | |
| *** sharatss has quit IRC | 21:53 | |
| *** sharatss has joined #openstack-mistral | 21:53 | |
| openstackgerrit | Pradeep Kilambi proposed openstack/mistral: Add gnocchi actions to mistral https://review.openstack.org/408327 | 22:02 |
| *** bobh has joined #openstack-mistral | 22:13 | |
| *** bobh has quit IRC | 22:18 | |
| *** sharatss has quit IRC | 22:56 | |
| *** sharatss has joined #openstack-mistral | 22:58 | |
| *** chlong has quit IRC | 23:06 | |
| *** harlowja has quit IRC | 23:16 | |
| *** jamielennox is now known as jamielennox|away | 23:27 | |
| *** jamielennox|away is now known as jamielennox | 23:28 | |
| *** thrash has quit IRC | 23:40 | |
| *** thrash has joined #openstack-mistral | 23:43 | |
| *** thrash has joined #openstack-mistral | 23:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!