Tuesday, 2016-12-06

*** bobh has quit IRC00:02
*** mfisch has joined #openstack-mistral00:16
mfischhi, can anyone tell me the right way to generate config for stable/newton? I see the tox_install.sh but not how to use it properly00:17
*** catintheroof has quit IRC00:25
openstackgerritLingxian Kong proposed openstack/mistral: Support openstack context for workflow and task  https://review.openstack.org/40724000:26
kong_mfisch: try to use 'tox -e genconfig'00:27
*** mfisch has quit IRC00:28
*** thrash is now known as thrash|g0ne01:15
openstackgerritJizhaoxuan proposed openstack/mistral: change the cron-trigger execution time from localtime to UTC  https://review.openstack.org/40674002:06
openstackgerritJizhaoxuan proposed openstack/mistral: Modify the function "_get_spec_version(spec_dict)"  https://review.openstack.org/40451002:12
openstackgerritJizhaoxuan proposed openstack/mistral: Add some transactions in some files  https://review.openstack.org/40669102:43
openstackgerritJizhaoxuan proposed openstack/mistral: Change version '1.0' to '2.0'  https://review.openstack.org/40529202:44
openstackgerritJizhaoxuan proposed openstack/mistral: std.email action requires a smtp_password  https://review.openstack.org/40669402:44
*** Ephur has quit IRC02:44
rakhmerovkong_: hi02:50
kong_rakhmerov: hi02:50
rakhmerovare you back?02:50
rakhmerov:)02:50
kong_rakhmerov: yeah, back to normal02:51
kong_rakhmerov: how's it going?02:51
rakhmerovok, we missed you :)02:51
kong_rakhmerov: miss you too :-)02:51
rakhmerovkong_: overall good, we have a lot of work )02:51
kong_that need to be finished before O release?02:51
rakhmerovkong_: is there anything specific that you'd like to work on?02:51
kong_considering we have a very short cycle02:51
kong_:-)02:51
rakhmerovyes, the cycle is short this time02:52
kong_I just uploaded a patch for supporting region name in workflow02:52
kong_working on that02:52
kong_seems i need to fix the jenkins failure first02:52
rakhmerovooh, I see02:53
kong_other than that, i have no specific requirement for mistral02:53
rakhmerovkong_: in fact, there's a BP for doing this region related work02:53
rakhmerovsec02:53
kong_ooh, i didn't know i am doing duplicate work02:54
rakhmerovhttps://blueprints.launchpad.net/mistral/+spec/mistral-multi-region-support02:54
rakhmerovno, you are not02:54
rakhmerovI believe nobody is working on it now02:54
kong_rakhmerov: ok, cool02:54
kong_i will link that bp02:54
rakhmerovit's assigned to Istvan Imre (my colleage) but I believe he's not actively working on it02:54
rakhmerovalthough he did some related work02:54
rakhmerovhis IRC nick is ist02:55
rakhmerovwe can talk to him once he wakes up (he's in Budapest)02:55
kong_rakhmerov: ok, sure. I think my patch will cover this feature02:55
rakhmerovyep02:55
kong_that's a requirement i am facing02:55
rakhmerovwhich is great because it's been wanted for a long time02:56
rakhmerovyes, it's needed by many people02:56
kong_yeah02:56
rakhmerovgood02:56
kong_rakhmerov: do we have changed the meeting time?02:56
rakhmerovso, you're ready to continue being a release liaison?02:56
kong_rakhmerov: of course, if you think i can continue do that :-)02:56
kong_you are the boss, man02:57
rakhmerovyes, you can )02:57
rakhmerovyes, I need you02:57
kong_honoured02:57
rakhmerovwe did Ocata-1 already and 2.1.2 for the clienet02:57
rakhmerovclient02:57
rakhmerovd0ugal needed something in the client so we decided to release it02:58
kong_i will check the release schedule, and prepare to do the next one02:58
rakhmerovyep02:58
rakhmerovjust FYI, I made a huge patch recently that changed how we launch our components (engine, even_engine, executor)02:59
rakhmerovso we might face some issues with that02:59
kong_rakhmerov: saw that, didn't have a chance to read the code02:59
rakhmerovif we do, I'm ready to react quickly02:59
rakhmerovyeah, that's no problem02:59
rakhmerovI was just fixing the bug related to usage of oslo_service and realized that the whole machinery demands serious refactoring03:00
rakhmerovso did I03:00
rakhmerovkong_: do I need to reassign this multi-region BP to you?03:00
kong_rakhmerov: yeah, maybe there was some misunderstanding of using oslo_service03:00
kong_rakhmerov: sure, feel free to do that03:01
rakhmerovdone03:01
rakhmerovkong_: we also have a problem with the client now03:02
kong_what's that03:02
rakhmerovtrying to fix it but it's not done yet03:03
rakhmerovhttps://review.openstack.org/#/c/406994/203:03
rakhmerovlook at the failing tests03:03
rakhmerovseems like we have to use keystone v3 now03:03
rakhmerovand it's missing domain name03:03
rakhmerovif you know how to fix it please feel free03:03
rakhmerovclient development is now blocked03:04
kong_rakhmerov: ok, will dig it a little bit03:04
kong_rakhmerov: so, is Dawid still working on that?03:04
rakhmerovyeah, ddeja investigated it yesterday a little bit but the sooner we fix it the better03:05
kong_ok03:06
kong_my top priority on mistral now03:06
rakhmerov:)03:06
rakhmerovother than, feel free to take any bugs or talk to me if you want some exciting task03:07
kong_rakhmerov: sure, will do if i have more bandwidth03:08
openstackgerritJizhaoxuan proposed openstack/mistral: cancel comments in 'setup.cfg'  https://review.openstack.org/40729003:12
openstackgerritJizhaoxuan proposed openstack/mistral: change the cron-trigger execution time from localtime to UTC  https://review.openstack.org/40674003:24
openstackgerritLingxian Kong proposed openstack/python-mistralclient: Fix for failing dsvm gate  https://review.openstack.org/40699403:50
rakhmerovkong_: your last patchset passed04:24
rakhmerov:)04:24
rakhmerovdo you think we can merge it in this form?04:24
rakhmerovkong_: so is it because tempest switched to using V3 by default?04:25
*** sharatss has joined #openstack-mistral05:26
openstackgerritRenat Akhmerov proposed openstack/mistral: Handling MistralException in default executor  https://review.openstack.org/40733005:36
sharatssrakhmerov: hi05:42
*** janki has joined #openstack-mistral05:46
openstackgerritzhangdetong proposed openstack/mistral: Fix a syntax error in yaml example  https://review.openstack.org/40733406:11
openstackgerritJizhaoxuan proposed openstack/mistral: Fix a syntax error in yaml example  https://review.openstack.org/40733406:23
rakhmerovsharatss: hi06:31
sharatssrakhmerov: yesterday the meeting was cancelled or did i miss it?06:33
rakhmerovit was cancelled, I sent out an email06:34
sharatssrakhmerov: ok. maybe i am not in that list :(06:34
rakhmerovopenstack-dev06:34
rakhmerovwith tag [mistral] in subject06:34
rakhmerovplease make a subscription06:34
sharatssrakhmerov: ok ok.. i will subscribe now06:35
openstackgerritzhangdetong proposed openstack/mistral: Fix a syntax error in yaml example  https://review.openstack.org/40733406:36
openstackgerritRenat Akhmerov proposed openstack/mistral: Handling MistralException in default executor  https://review.openstack.org/40733006:37
*** Kiall has quit IRC06:56
openstackgerritRenat Akhmerov proposed openstack/mistral: Handling MistralException in default executor  https://review.openstack.org/40733007:22
openstackgerritRenat Akhmerov proposed openstack/mistral: Handling MistralException in default executor  https://review.openstack.org/40733007:43
ddejaoh, thanks kong_ for fixing my patch07:48
* ddeja fells stupid now for previous attepmts...07:49
ddejaI have a meeting starting in 10 minutes that would last for 2 hours07:50
ddejarakhmerov: would you be availabl after that time?07:50
rakhmerovddeja: yes07:50
ddejarakhmerov: great!07:50
*** d0ugal has joined #openstack-mistral07:57
*** d0ugal has joined #openstack-mistral07:57
*** FL1SK has quit IRC08:04
*** sharatss has quit IRC08:06
*** sharatss has joined #openstack-mistral08:06
rakhmerovddeja: so, do you think this is a complete fix for failing devstack gate?08:18
rakhmerovif yes, I'll merge it08:18
ddejarakhmerov: yes, I think so08:30
rakhmerovok08:30
ddejadue to the fact that tempest is not able to use keystone v3...08:31
openstackgerritfengchaoyang proposed openstack/mistral: Fix two errors in YAML example and a error in action doc  https://review.openstack.org/40422908:36
*** Jizhaoxuan has joined #openstack-mistral08:43
*** no-thing_ has joined #openstack-mistral08:58
openstackgerritMerged openstack/python-mistralclient: Fix for failing dsvm gate  https://review.openstack.org/40699409:00
*** shardy has joined #openstack-mistral09:11
openstackgerritRenat Akhmerov proposed openstack/python-mistralclient: Updated from global requirements  https://review.openstack.org/40589309:24
rakhmerovddeja: yes, but why did it work before?09:27
openstackgerritJizhaoxuan proposed openstack/mistral: change the cron-trigger execution time from localtime to UTC  https://review.openstack.org/40674009:28
rakhmerovdoes anyone know why patches in python-mistralclient don't get into 'gate' queue ? Like https://review.openstack.org/#/c/405893/09:39
openstackgerritRenat Akhmerov proposed openstack/python-mistralclient: Filter workflow executions by creating task execution id  https://review.openstack.org/40384409:41
*** shardy is now known as shardy_mtg09:45
*** jpich has joined #openstack-mistral09:50
openstackgerritJizhaoxuan proposed openstack/mistral: modify something in 'dsl_v2.rst'  https://review.openstack.org/40743009:52
*** FL1SK has joined #openstack-mistral10:05
kong_ddeja: you are welcome, i was just trying my luck ;-)10:07
ddejarakhmerov: it looks like there was some change in devstack so it switched the default url to v310:11
ddejai mean, the default value of OS_AUTH_URL was changed10:12
ddejakong_: yup. And you did it in simple and elegant way. I was having some thinking problem when writing my patch... It was like code in C rather than in python...10:12
rakhmerov:)10:21
rakhmerovok10:21
rakhmerovthanks to you both )10:21
openstackgerritMerged openstack/python-mistralclient: Updated from global requirements  https://review.openstack.org/40589310:39
rakhmerovd0ugal: btw, look at https://review.openstack.org/#/c/407330/ once you have a chance10:39
rakhmerovthis fixes the problem you recently reported10:39
rakhmerovwith invalid unicode10:39
d0ugalrakhmerov: I spotted it, and started looking :)10:39
d0ugalThen I got distracted by docs ;)10:39
d0ugalI'll get back to it soon.10:39
rakhmerovnp10:40
rakhmerovit might have an overlap with your https://review.openstack.org/#/c/407005/1/mistral/tests/unit/engine/test_error_result.py10:40
rakhmerovhttps://review.openstack.org/#/c/407005/10:40
rakhmerovbut maybe it's ok to have it too10:40
rakhmerovI believe it can become mostly additional testing for that fix10:40
rakhmerovnot only when unicode is broken but some other cases10:41
openstackgerritMerged openstack/mistral: Fix two errors in YAML example and a error in action doc  https://review.openstack.org/40422910:43
openstackgerritRenat Akhmerov proposed openstack/python-mistralclient: Make python mistralclient readme better  https://review.openstack.org/40424910:43
*** Ephur has joined #openstack-mistral10:47
openstackgerritGal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: added action executions screens  https://review.openstack.org/40118810:49
openstackgerritDougal Matthews proposed openstack/mistral: Update the wording in the actions terminology docs  https://review.openstack.org/40745410:51
*** Ephur has quit IRC10:52
*** dtantsur|afk is now known as dtantsur11:01
ddejahey, rakhmerov, do you have a moment to talk about https://review.openstack.org/#/c/406143/11:10
rakhmerovddeja: yes, let's do11:12
ddejaok, so let me describe what the problem is11:12
rakhmerovok11:13
ddejawhen we create any table using oslo db, it automatically adds column 'created_at'11:13
ddejait has a default value which is set using some internal oslo.utils functions, but basically we can think of it as a datetime.datetime object11:14
ddejawhat is important, the value is set from the python code, not in the db11:14
ddejaok, so let's take a table action_definition_v2, as an example11:15
rakhmerovok11:15
ddejawhen we add new raw to it11:15
ddejathe created_at value is set from the python interpreter as a datetime object11:16
ddejaand then it is passed to the DB11:16
ddejathis tame consist of time up to microseconds11:16
ddejas/tame/time/11:16
rakhmerovyep11:16
ddejaand, if it sqlite/postgres/mysql in version 5.6+ there is no problem11:17
ddeja(ok, there is still some problems even with mysql 5.6+, but it can be handle)11:17
rakhmerovyeah, but if it's mysql < 5.6 then it rounds the value11:17
ddejato be honest, it does same in 5.6+, since you need to provide special flag in SQLalchemy so it stores the microseconds rather than round it11:18
rakhmerovok11:18
ddejaso the problem is: since the time is set from python code, not from the DB11:18
rakhmerovso, what's the solution you are proposing?11:19
ddejaif mysql is used, then user gets different time than is stored in the db11:19
ddejafor now, I see two options11:19
ddeja1) change the default for 'created_up', 'updated_at' so it only uses seconds11:19
ddeja(this is current patch)11:19
ddeja2) change the default, but only if mysql is used11:20
rakhmerovpl11:20
rakhmerovok11:20
ddejato be honest, I don't know which solution is better. Or there may be 3rd one, that is better than those 211:20
rakhmerovlet me think..11:20
rakhmerovso utc.now() give milliseconds, right?11:21
rakhmerovor seconds?11:21
ddejato give you some more info - I've dug into nova code11:21
ddejarakhmerov: microseconds even11:21
ddejaso nova drops the microseconds for instances11:22
rakhmerovyeah, I see11:22
rakhmerovthat's what I thought too11:22
rakhmerovmaybe we simply should do the same11:22
ddejaOK11:22
rakhmerovsecond..11:22
rakhmerovif utils.utcnow() give microseconds then why do you use it for default value?11:23
ddejait's mistral utils, not oslo.utils :)11:23
ddejamaybe I should rename it, it can be confusing11:23
rakhmerovooh, and it gives milliseconds?11:23
rakhmerovor seconds?11:23
rakhmerov:)11:23
ddejait's my implementation, it gives only seconds11:24
rakhmerovooh, I see the file11:24
rakhmerovyes11:24
ddejawhat is most suprising for me, is why it is only happening on kombu gate..11:25
ddejasince the tests that fails is not using even a single RPC call11:25
rakhmerovmaybe it's configured with a different DB?11:25
rakhmerovmysql of different version, no?11:25
ddejahm, maybe... maybe one uses postgres and one mysql..11:26
rakhmerovok11:26
rakhmerovbut the problem still exists anyway11:26
rakhmerovwe know it11:26
ddejayes, it is there11:26
ddejathis change made some unit tests to fail - those which where relaing on order of return from DB11:27
rakhmerovso why did this patch fail now?11:27
rakhmerovtests11:27
ddejaI'm fixing it11:27
ddejarakhmerov: ^11:27
rakhmerovoh, I see11:27
rakhmerovok11:27
ddejaI've run it multiple times on my env, but If there are two elements for which order matters, it may pass 10-15 times before we hit the error11:28
ddejaI'll recheck my patchset a few more times before we can merge it11:28
rakhmerovso on one hand it may be useful to retain microseconds11:28
rakhmerovin cases when it's possible11:29
rakhmerov(not mysql < 5.6)11:29
ddejawell, I'm not sure really11:29
rakhmerovon the other hand I really don't like any kind of special handling11:29
ddejadespite tests, why it should matter for anyone?11:29
rakhmerovjust a precision11:29
ddejaOK11:29
rakhmerovif, for example, I run Mistral under load I may be interested in seeing which action ran first and which second11:30
rakhmerovalthough time precision doesn't really solve this reliably too11:30
*** shardy_mtg has quit IRC11:30
rakhmerovthere always can be time collisions11:30
ddejato be honest, it doesnt give any information11:31
rakhmerovif we simply sort by time11:31
rakhmerovyeah, maybe...11:31
ddejaeven if we keep the microseconds in the DB11:31
rakhmerovhm11:31
ddejathis times was created when the object was firstly initialize11:31
ddejait doesnt say which runs first11:31
rakhmerovtrue11:31
rakhmerovyes, good point11:32
ddejawell, it even doesn't say which was really first in the DB11:32
rakhmerovhm... yes11:32
rakhmerovyeah, I agree. Ordering should not rely on time11:32
ddejain a very rare circumstances, we created A, then create B, then store B then store A11:32
rakhmerovit's rather a logical thing related to a particular workflow11:32
ddejayes11:33
rakhmerovok, then I'd suggest we round it to seconds11:33
ddejaOK11:33
ddejaso I'm getting back to fixing unit tests11:33
rakhmerovso does mysql < 5.6 support milliseconds at least?11:33
rakhmerovif yes we could round to milliseconds11:34
ddejano11:34
rakhmerov:)11:34
rakhmerovok11:34
rakhmerovlet's do seconds11:34
ddejawell, once 14.04 is dropped11:34
ddeja(ubuntu 14.04)11:34
ddejafor ubuntu 16.04 default mysql is 5.711:34
rakhmerovand get as many people involved in reviewing it as possible11:34
ddejabut the problem is that the default precision for columns of type 'datetime' is still only to seconds11:35
rakhmerovI think it's not a big problem to use only seconds11:35
ddejawell, If you have mysql, you already only have seconds11:35
ddejaonly when creating objects you got more precision, but next time you ask for the same object, those mircoseconds are gone11:36
rakhmerovI understand, I just mean internally for those two fields11:36
ddejaok11:36
rakhmerovto make our testing consistent11:36
ddejaOK11:36
ddejaoh, BTW Renat11:36
rakhmerovwhen I work with Mistral myself I don't have any problems with time, it's fine. We just need to deal with tests11:37
rakhmerovyes, what's up?11:37
ddejaNext week I'll be giving a speech called 'Introduction to mistral'11:37
rakhmerovreally? :)11:37
rakhmerovwhere?11:37
ddejaIn Wroclaw, Poland11:37
rakhmerovok :)11:37
rakhmerovsome internal Intel event?11:37
rakhmerovor a public event?11:38
ddejahttps://www.meetup.com/Wroclaw-OpenStack-Meetup/events/235620920/11:38
ddeja(scroll for english version :)11:38
rakhmerovaah, OpenStack meetup11:38
rakhmerovcool11:38
rakhmerovgood luck!11:38
ddejaand would it be possible that you can send me slides that you used in barcelona11:38
ddejaI don't want to use it11:38
ddejabut there was some info I'd like to put into my slides11:39
ddejaand it would be easier to have a slidedeck instead of youtube video ;)11:39
rakhmerovsure, np11:39
ddejaespecially the part with 'who uses mistral'11:39
rakhmerovI'll send em shortly11:39
ddejacool, thanks :)11:39
rakhmerovwhat format would you prefer?11:40
rakhmerovkeynote, pdf, ppt?11:40
ddejapdf11:40
rakhmerovok11:40
ddejathanks a lot!11:41
rakhmerovooh, it's in Google Docs11:42
rakhmerovjust a sec..11:42
rakhmerovI think I can just give you access to it11:42
ddejathat's also OK :)11:42
rakhmerovok, check your email11:43
*** jamielennox is now known as jamielennox|away11:44
rakhmerovddeja: did you get the links?11:44
ddejarakhmerov: yup, I got them, thanks!11:45
rakhmerovnp, ok11:45
*** thrash|g0ne is now known as thrash12:19
rakhmerovddeja, kong_, d0ugal, hparekh: guys, if somebody has time today, could you please look at https://review.openstack.org/#/c/404249/ ?12:30
rakhmerovI don't understand why it keeps failing12:30
rakhmerovddeja: btw, it's something about time too12:30
ddejarakhmerov: let me look12:38
rakhmerovok12:38
ddejarakhmerov: this looks like excactly the problem I have described12:40
rakhmerov:)12:40
ddejabut I need to look on code to be sure12:40
ddejarakhmerov: that's the same problem12:42
ddejalook https://github.com/openstack/python-mistralclient/blob/master/mistralclient/tests/functional/cli/v2/cli_tests_v2.py#L776-L77712:42
ddejait even cutting of what is after the '.'12:43
ddejaI'm wondering why it came out recently... maybe some older mysql version was cutting the microseconds, not rounding12:44
ddejarakhmerov: I can fix tests in client, or we can wait for the patch in mistral12:45
d0ugalddeja: This patch? https://review.openstack.org/#/c/406143/12:54
ddejad0ugal: yup, this one12:56
ddeja(fix on the way)12:56
d0ugalk12:57
*** Jizhaoxuan has quit IRC13:04
openstackgerritDawid Deja proposed openstack/mistral: Fix for failing kombu gate  https://review.openstack.org/40614313:09
openstackgerritDawid Deja proposed openstack/mistral: Fix for failing kombu gate  https://review.openstack.org/40614313:12
*** shardy has joined #openstack-mistral13:22
openstackgerritMerged openstack/mistral-dashboard: mistral-dashboard: added action executions screens  https://review.openstack.org/40118813:28
*** catintheroof has joined #openstack-mistral13:43
*** hrybacki|l4mG3 is now known as hrybacki13:53
*** mfisch has joined #openstack-mistral14:17
*** mfisch has left #openstack-mistral14:17
*** dprince has joined #openstack-mistral14:21
*** soumiyajit has joined #openstack-mistral14:27
*** soumiyajit has quit IRC14:29
*** Ephur has joined #openstack-mistral14:49
*** Ephur has quit IRC14:53
openstackgerritGal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: removed the false check, false is a valid value - and has a matching design  https://review.openstack.org/40757315:50
*** bobh has joined #openstack-mistral15:57
*** lkannan has quit IRC15:59
*** lkannan has joined #openstack-mistral16:00
openstackgerritGal Margalit proposed openstack/mistral-dashboard: mistral-dashboard:fixed boolean field design bug  https://review.openstack.org/40757316:08
*** dprince has quit IRC16:11
*** jpich has quit IRC16:13
*** shardy has quit IRC16:14
*** catinthe_ has joined #openstack-mistral16:14
*** catintheroof has quit IRC16:16
*** catinthe_ has quit IRC16:18
*** no-thing_ has quit IRC16:39
*** Ephur has joined #openstack-mistral17:03
*** catintheroof has joined #openstack-mistral17:03
*** catintheroof has quit IRC17:03
*** catintheroof has joined #openstack-mistral17:04
*** janki has quit IRC17:04
*** dtantsur is now known as dtantsur|afk17:06
*** bobh has quit IRC17:56
*** weshay_ has quit IRC17:58
*** weshay has joined #openstack-mistral17:59
*** Kiall has joined #openstack-mistral18:41
*** weshay has quit IRC18:55
*** bobh has joined #openstack-mistral18:57
*** weshay has joined #openstack-mistral18:58
*** bobh has quit IRC19:01
*** jamielennox|away is now known as jamielennox19:07
*** catinthe_ has joined #openstack-mistral19:14
*** catintheroof has quit IRC19:16
*** AlexeyAbashkin has joined #openstack-mistral19:22
*** AlexeyAbashkin has quit IRC19:23
*** thrash is now known as thrash|biab19:27
*** thrash|biab is now known as thrash19:54
*** bobh has joined #openstack-mistral19:58
*** catintheroof has joined #openstack-mistral20:02
*** bobh has quit IRC20:03
*** catinthe_ has quit IRC20:04
*** bobh has joined #openstack-mistral20:59
*** bobh has quit IRC21:03
*** catintheroof has quit IRC21:06
*** toure is now known as toure|biab21:07
*** chlong has joined #openstack-mistral21:43
*** Ephur has quit IRC22:01
*** chlong has quit IRC22:06
*** chlong has joined #openstack-mistral22:07
*** chlong has quit IRC22:12
*** harlowja has quit IRC22:43
*** harlowja has joined #openstack-mistral22:43
*** jamielennox is now known as jamielennox|away23:05
*** jamielennox|away is now known as jamielennox23:06
*** catintheroof has joined #openstack-mistral23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!