| *** catintheroof has joined #openstack-mistral | 01:05 | |
| *** catintheroof has quit IRC | 01:08 | |
| *** donnalezyty_ has quit IRC | 01:21 | |
| *** jamielennox is now known as jamielennox|away | 01:34 | |
| *** catintheroof has joined #openstack-mistral | 02:24 | |
| *** bobh has joined #openstack-mistral | 02:44 | |
| *** jamielennox|away is now known as jamielennox | 02:54 | |
| *** jamielennox is now known as jamielennox|away | 03:17 | |
| *** jamielennox|away is now known as jamielennox | 03:26 | |
| *** catintheroof has quit IRC | 03:28 | |
| *** catintheroof has joined #openstack-mistral | 03:28 | |
| *** catintheroof has quit IRC | 03:28 | |
| *** catintheroof has joined #openstack-mistral | 03:30 | |
| *** catintheroof has quit IRC | 03:30 | |
| *** catintheroof has joined #openstack-mistral | 03:31 | |
| *** catintheroof has quit IRC | 03:31 | |
| *** jamielennox is now known as jamielennox|away | 03:47 | |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/405008 | 04:11 |
|---|---|---|
| *** Ephur has quit IRC | 04:13 | |
| *** Ephur has joined #openstack-mistral | 04:13 | |
| *** Ephur has quit IRC | 04:14 | |
| *** Ephur has joined #openstack-mistral | 04:14 | |
| *** Ephur has quit IRC | 04:14 | |
| *** Ephur has joined #openstack-mistral | 04:15 | |
| rakhmerov | d0ugal, hprekh: hi, please review https://review.openstack.org/#/c/402392/ | 04:15 |
| rakhmerov | hparekh: ^ | 04:15 |
| *** Ephur has quit IRC | 04:15 | |
| *** bobh has quit IRC | 04:16 | |
| *** Ephur has joined #openstack-mistral | 04:16 | |
| *** Ephur has quit IRC | 04:16 | |
| *** Ephur has joined #openstack-mistral | 04:17 | |
| *** Ephur has quit IRC | 04:17 | |
| *** Ephur has joined #openstack-mistral | 04:18 | |
| *** Ephur has quit IRC | 04:18 | |
| *** Ephur has joined #openstack-mistral | 04:19 | |
| *** Ephur has quit IRC | 04:19 | |
| *** Ephur has joined #openstack-mistral | 04:20 | |
| *** Ephur has quit IRC | 04:20 | |
| *** Ephur has joined #openstack-mistral | 04:20 | |
| *** Ephur has quit IRC | 04:21 | |
| *** Ephur has joined #openstack-mistral | 04:21 | |
| *** Ephur has quit IRC | 04:22 | |
| *** Ephur has joined #openstack-mistral | 04:22 | |
| *** Ephur has quit IRC | 04:22 | |
| *** Ephur has joined #openstack-mistral | 04:23 | |
| *** Ephur has quit IRC | 04:23 | |
| *** Ephur has joined #openstack-mistral | 04:24 | |
| *** Ephur has quit IRC | 04:24 | |
| *** Ephur has joined #openstack-mistral | 04:25 | |
| *** Ephur has quit IRC | 04:25 | |
| *** Ephur has joined #openstack-mistral | 04:26 | |
| *** Ephur has quit IRC | 04:26 | |
| *** Ephur has joined #openstack-mistral | 04:27 | |
| *** Ephur has joined #openstack-mistral | 04:27 | |
| *** Ephur has quit IRC | 04:28 | |
| *** Ephur has joined #openstack-mistral | 04:28 | |
| *** Ephur has quit IRC | 04:29 | |
| *** Ephur has joined #openstack-mistral | 04:29 | |
| *** Ephur has quit IRC | 04:29 | |
| *** Ephur has joined #openstack-mistral | 04:30 | |
| *** Ephur has quit IRC | 04:30 | |
| *** Ephur has joined #openstack-mistral | 04:31 | |
| *** Ephur has quit IRC | 04:31 | |
| *** Ephur has joined #openstack-mistral | 04:32 | |
| *** Ephur has joined #openstack-mistral | 04:33 | |
| *** Ephur has quit IRC | 04:33 | |
| *** jamielennox|away is now known as jamielennox | 04:33 | |
| *** Ephur has joined #openstack-mistral | 04:34 | |
| *** Ephur has quit IRC | 04:34 | |
| *** Ephur has joined #openstack-mistral | 04:34 | |
| *** Ephur has quit IRC | 04:35 | |
| *** Ephur has joined #openstack-mistral | 04:35 | |
| *** Ephur has quit IRC | 04:36 | |
| *** Ephur has joined #openstack-mistral | 04:36 | |
| *** Ephur has quit IRC | 04:37 | |
| *** Ephur has joined #openstack-mistral | 04:37 | |
| *** Ephur has quit IRC | 04:37 | |
| *** Ephur has joined #openstack-mistral | 04:38 | |
| *** Ephur has quit IRC | 04:38 | |
| *** Ephur has joined #openstack-mistral | 04:39 | |
| *** Ephur has quit IRC | 04:39 | |
| *** Ephur has joined #openstack-mistral | 04:40 | |
| *** Ephur has quit IRC | 04:40 | |
| *** sharatss has quit IRC | 04:40 | |
| *** Ephur has joined #openstack-mistral | 04:41 | |
| *** Ephur has quit IRC | 04:41 | |
| *** Ephur has joined #openstack-mistral | 04:42 | |
| *** Ephur has quit IRC | 04:42 | |
| *** Ephur has joined #openstack-mistral | 04:42 | |
| *** Ephur has quit IRC | 04:43 | |
| *** Ephur has joined #openstack-mistral | 04:43 | |
| *** Ephur has quit IRC | 04:44 | |
| *** Ephur has joined #openstack-mistral | 04:44 | |
| *** Ephur has joined #openstack-mistral | 04:45 | |
| *** Ephur has quit IRC | 04:45 | |
| *** Ephur has joined #openstack-mistral | 04:46 | |
| *** Ephur has quit IRC | 04:46 | |
| *** Ephur has joined #openstack-mistral | 04:47 | |
| *** Ephur has quit IRC | 04:47 | |
| *** Ephur has joined #openstack-mistral | 04:48 | |
| *** Ephur has quit IRC | 04:48 | |
| *** Ephur has joined #openstack-mistral | 04:49 | |
| *** Ephur has quit IRC | 04:49 | |
| *** Ephur has joined #openstack-mistral | 04:49 | |
| *** Ephur has quit IRC | 04:50 | |
| *** Ephur has joined #openstack-mistral | 04:51 | |
| *** Ephur has quit IRC | 04:51 | |
| *** Ephur has joined #openstack-mistral | 04:51 | |
| *** Ephur has quit IRC | 04:52 | |
| *** Ephur has joined #openstack-mistral | 04:52 | |
| *** Ephur has quit IRC | 04:52 | |
| *** Ephur has joined #openstack-mistral | 04:53 | |
| *** Ephur has joined #openstack-mistral | 04:54 | |
| *** Ephur has quit IRC | 04:54 | |
| *** Ephur has joined #openstack-mistral | 04:55 | |
| *** Ephur has quit IRC | 04:55 | |
| *** Ephur has joined #openstack-mistral | 04:56 | |
| *** Ephur has quit IRC | 04:56 | |
| *** Ephur has joined #openstack-mistral | 04:57 | |
| *** Ephur has quit IRC | 04:57 | |
| *** Ephur has joined #openstack-mistral | 04:58 | |
| *** Ephur has quit IRC | 04:58 | |
| *** Ephur has joined #openstack-mistral | 04:58 | |
| *** Ephur has quit IRC | 04:59 | |
| *** Ephur has joined #openstack-mistral | 04:59 | |
| *** Ephur has quit IRC | 05:00 | |
| *** Ephur has joined #openstack-mistral | 05:00 | |
| *** Ephur has quit IRC | 05:00 | |
| *** Ephur has joined #openstack-mistral | 05:01 | |
| *** Ephur has quit IRC | 05:01 | |
| *** Ephur has joined #openstack-mistral | 05:02 | |
| *** Ephur has quit IRC | 05:02 | |
| *** Ephur has joined #openstack-mistral | 05:03 | |
| *** Ephur has quit IRC | 05:03 | |
| *** Ephur has joined #openstack-mistral | 05:04 | |
| *** Ephur has quit IRC | 05:04 | |
| *** Ephur has joined #openstack-mistral | 05:04 | |
| *** Ephur has quit IRC | 05:05 | |
| *** Ephur has joined #openstack-mistral | 05:06 | |
| *** Ephur has joined #openstack-mistral | 05:06 | |
| *** Ephur has quit IRC | 05:07 | |
| *** Ephur has joined #openstack-mistral | 05:07 | |
| *** Ephur has joined #openstack-mistral | 05:08 | |
| *** Ephur has quit IRC | 05:08 | |
| *** Ephur has joined #openstack-mistral | 05:09 | |
| *** Ephur has quit IRC | 05:09 | |
| *** Ephur has joined #openstack-mistral | 05:10 | |
| *** Ephur has quit IRC | 05:10 | |
| *** Ephur has joined #openstack-mistral | 05:11 | |
| *** Ephur has quit IRC | 05:11 | |
| *** Ephur has joined #openstack-mistral | 05:12 | |
| *** Ephur has quit IRC | 05:12 | |
| *** Ephur has joined #openstack-mistral | 05:13 | |
| *** Ephur has quit IRC | 05:13 | |
| *** Ephur has joined #openstack-mistral | 05:14 | |
| *** Ephur has joined #openstack-mistral | 05:14 | |
| *** Ephur has quit IRC | 05:15 | |
| *** Ephur has joined #openstack-mistral | 05:15 | |
| *** Ephur has quit IRC | 05:15 | |
| *** Ephur has joined #openstack-mistral | 05:16 | |
| *** Ephur has quit IRC | 05:16 | |
| *** Ephur has joined #openstack-mistral | 05:17 | |
| *** Ephur has quit IRC | 05:17 | |
| *** Ephur has joined #openstack-mistral | 05:18 | |
| *** Ephur has joined #openstack-mistral | 05:19 | |
| *** Ephur has quit IRC | 05:19 | |
| *** Ephur has joined #openstack-mistral | 05:20 | |
| *** Ephur has quit IRC | 05:20 | |
| *** Ephur has joined #openstack-mistral | 05:21 | |
| *** Ephur has quit IRC | 05:21 | |
| *** Ephur has joined #openstack-mistral | 05:21 | |
| *** Ephur has quit IRC | 05:22 | |
| *** Ephur has joined #openstack-mistral | 05:22 | |
| *** Ephur has quit IRC | 05:22 | |
| *** Ephur has joined #openstack-mistral | 05:23 | |
| *** Ephur has quit IRC | 05:23 | |
| *** Ephur has joined #openstack-mistral | 05:24 | |
| *** Ephur has quit IRC | 05:24 | |
| *** Ephur has joined #openstack-mistral | 05:25 | |
| *** Ephur has quit IRC | 05:25 | |
| *** Ephur has joined #openstack-mistral | 05:26 | |
| *** Ephur has quit IRC | 05:26 | |
| *** Ephur has joined #openstack-mistral | 05:27 | |
| *** Ephur has quit IRC | 05:27 | |
| *** Ephur has joined #openstack-mistral | 05:28 | |
| *** Ephur has quit IRC | 05:28 | |
| *** Ephur has joined #openstack-mistral | 05:28 | |
| *** Ephur has quit IRC | 05:29 | |
| *** Ephur has joined #openstack-mistral | 05:29 | |
| *** Ephur has quit IRC | 05:30 | |
| *** Ephur has joined #openstack-mistral | 05:30 | |
| *** Ephur has quit IRC | 05:30 | |
| *** Ephur has joined #openstack-mistral | 05:31 | |
| *** Ephur has quit IRC | 05:31 | |
| *** Ephur has joined #openstack-mistral | 05:32 | |
| *** Ephur has quit IRC | 05:32 | |
| openstackgerrit | Merged openstack/mistral: Bump Ironic API version to 1.22 when creating the Ironic client https://review.openstack.org/404203 | 05:33 |
| *** Ephur has joined #openstack-mistral | 05:33 | |
| *** Ephur has quit IRC | 05:33 | |
| *** Ephur has joined #openstack-mistral | 05:34 | |
| *** Ephur has quit IRC | 05:34 | |
| *** Ephur has joined #openstack-mistral | 05:35 | |
| *** Ephur has quit IRC | 05:35 | |
| *** Ephur has joined #openstack-mistral | 05:35 | |
| *** Ephur has quit IRC | 05:36 | |
| *** Ephur has joined #openstack-mistral | 05:36 | |
| *** Ephur has quit IRC | 05:37 | |
| *** Ephur has joined #openstack-mistral | 05:37 | |
| *** Ephur has quit IRC | 05:38 | |
| *** Ephur has joined #openstack-mistral | 05:38 | |
| *** Ephur has quit IRC | 05:38 | |
| *** Ephur has joined #openstack-mistral | 05:39 | |
| *** Ephur has quit IRC | 05:39 | |
| *** Ephur has joined #openstack-mistral | 05:40 | |
| *** Ephur has quit IRC | 05:40 | |
| *** Ephur has joined #openstack-mistral | 05:41 | |
| *** Ephur has quit IRC | 05:41 | |
| *** Ephur has joined #openstack-mistral | 05:42 | |
| *** Ephur has quit IRC | 05:42 | |
| *** Ephur has joined #openstack-mistral | 05:43 | |
| *** Ephur has quit IRC | 05:43 | |
| *** Ephur has joined #openstack-mistral | 05:44 | |
| *** Ephur has quit IRC | 05:44 | |
| *** Ephur has joined #openstack-mistral | 05:45 | |
| *** Ephur has quit IRC | 05:45 | |
| *** Ephur has joined #openstack-mistral | 05:45 | |
| *** Ephur has quit IRC | 05:45 | |
| *** Ephur has joined #openstack-mistral | 05:46 | |
| *** Ephur has quit IRC | 05:46 | |
| *** Ephur has joined #openstack-mistral | 05:47 | |
| *** Ephur has quit IRC | 05:47 | |
| *** Ephur has joined #openstack-mistral | 05:48 | |
| *** Ephur has quit IRC | 05:48 | |
| *** Ephur has joined #openstack-mistral | 05:49 | |
| *** Ephur has quit IRC | 05:49 | |
| *** Ephur has joined #openstack-mistral | 05:50 | |
| *** Ephur has quit IRC | 05:50 | |
| *** Ephur has joined #openstack-mistral | 05:51 | |
| *** Ephur has quit IRC | 05:51 | |
| *** Ephur has joined #openstack-mistral | 05:51 | |
| *** Ephur has quit IRC | 05:52 | |
| *** Ephur has joined #openstack-mistral | 05:52 | |
| *** Ephur has joined #openstack-mistral | 05:53 | |
| *** Ephur has quit IRC | 05:53 | |
| *** Ephur has joined #openstack-mistral | 05:54 | |
| *** Ephur has quit IRC | 05:54 | |
| *** Ephur has joined #openstack-mistral | 05:55 | |
| *** Ephur has quit IRC | 05:55 | |
| *** janki has joined #openstack-mistral | 05:56 | |
| *** Ephur has joined #openstack-mistral | 05:56 | |
| *** Ephur has quit IRC | 05:56 | |
| *** Ephur has joined #openstack-mistral | 05:57 | |
| *** Ephur has quit IRC | 05:57 | |
| *** Ephur has joined #openstack-mistral | 05:58 | |
| *** Ephur has quit IRC | 05:58 | |
| *** Ephur has joined #openstack-mistral | 05:58 | |
| *** Ephur has quit IRC | 05:59 | |
| *** Ephur has joined #openstack-mistral | 05:59 | |
| *** Ephur has quit IRC | 06:00 | |
| *** Ephur has joined #openstack-mistral | 06:00 | |
| *** Ephur has quit IRC | 06:00 | |
| *** Ephur has joined #openstack-mistral | 06:01 | |
| *** Ephur has joined #openstack-mistral | 06:02 | |
| *** Ephur has quit IRC | 06:02 | |
| *** Ephur has joined #openstack-mistral | 06:03 | |
| *** Ephur has quit IRC | 06:03 | |
| *** Ephur has joined #openstack-mistral | 06:04 | |
| *** Ephur has quit IRC | 06:04 | |
| *** Ephur has joined #openstack-mistral | 06:05 | |
| *** Ephur has quit IRC | 06:05 | |
| *** Ephur has joined #openstack-mistral | 06:06 | |
| *** Ephur has quit IRC | 06:06 | |
| *** Ephur has joined #openstack-mistral | 06:06 | |
| *** Ephur has quit IRC | 06:07 | |
| *** Ephur has joined #openstack-mistral | 06:07 | |
| *** Ephur has quit IRC | 06:08 | |
| *** Ephur has joined #openstack-mistral | 06:08 | |
| *** Ephur has quit IRC | 06:08 | |
| *** Ephur has joined #openstack-mistral | 06:09 | |
| *** Ephur has quit IRC | 06:09 | |
| *** Ephur has joined #openstack-mistral | 06:10 | |
| *** Ephur has quit IRC | 06:10 | |
| *** Ephur has joined #openstack-mistral | 06:11 | |
| *** Ephur has quit IRC | 06:11 | |
| *** Ephur has joined #openstack-mistral | 06:12 | |
| *** Ephur has quit IRC | 06:12 | |
| *** Ephur has joined #openstack-mistral | 06:12 | |
| *** Ephur has quit IRC | 06:13 | |
| *** Ephur has joined #openstack-mistral | 06:13 | |
| *** Ephur has quit IRC | 06:14 | |
| *** Ephur has joined #openstack-mistral | 06:14 | |
| *** Ephur has quit IRC | 06:15 | |
| *** jaosorior has joined #openstack-mistral | 06:19 | |
| *** sharatss has joined #openstack-mistral | 06:28 | |
| *** jaosorior has quit IRC | 07:09 | |
| *** jaosorior has joined #openstack-mistral | 07:10 | |
| d0ugal | yay | 08:08 |
| * d0ugal figured out the regex bug | 08:08 | |
| rakhmerov | d0ugal: really? | 08:12 |
| rakhmerov | can you share? :) | 08:12 |
| d0ugal | rakhmerov: well, I think I did. Just preparing a test | 08:12 |
| rakhmerov | ok ) | 08:12 |
| d0ugal | I didn't understand the regex when I tried to understand it last time | 08:12 |
| rakhmerov | looking forward to see a patch ) | 08:12 |
| rakhmerov | I didn't too | 08:13 |
| d0ugal | I think the regex is attempting to do != "version" | 08:13 |
| d0ugal | but it is wrong | 08:13 |
| rakhmerov | hm.. ok | 08:13 |
| rakhmerov | sharatss: can you also review https://review.openstack.org/#/c/402392/ ? | 08:14 |
| rakhmerov | we just want more reviews because it's a big change | 08:14 |
| *** dtantsur|afk is now known as dtantsur | 08:14 | |
| rakhmerov | I'm also waiting for Hardik but he is not available | 08:14 |
| d0ugal | We can probably merge it if you want | 08:15 |
| d0ugal | and just react quickly to problems ;) | 08:15 |
| d0ugal | rakhmerov: I think you said that version is copied into each workflow/action in a workbook. Do you know where that happens? | 08:26 |
| *** akuznetsova has quit IRC | 08:28 | |
| rakhmerov | d0ugal: let's do it pls | 08:29 |
| *** shardy has joined #openstack-mistral | 08:29 | |
| rakhmerov | I'm ready to react quickly if something is broken | 08:29 |
| d0ugal | Done | 08:32 |
| d0ugal | So, in the schema. This is saying "the version property should match the enum" https://github.com/openstack/mistral/blob/master/mistral/workbook/v2/workbook.py#L44 | 08:32 |
| rakhmerov | ok, thanks | 08:32 |
| d0ugal | and then this is saying, "everything else should match the workflow schema" https://github.com/openstack/mistral/blob/master/mistral/workbook/v2/workbook.py#L45 | 08:32 |
| rakhmerov | yes, everything except schema | 08:33 |
| rakhmerov | sorry | 08:33 |
| rakhmerov | except version | 08:33 |
| d0ugal | ?! in the regex is like a not | 08:33 |
| rakhmerov | honestly, I don't quite understand the question mark in regexp | 08:33 |
| d0ugal | however, the regular expression is wrong as it doesn't match works starting with version | 08:34 |
| d0ugal | rakhmerov: ?! - that is like "not", almost | 08:34 |
| rakhmerov | ok | 08:34 |
| d0ugal | so the regex means it should match anything, except words starting with "version" | 08:34 |
| rakhmerov | aaah | 08:35 |
| rakhmerov | I see | 08:35 |
| d0ugal | I think this should be correct. ^(?!(?:version)$)\w+$ | 08:35 |
| d0ugal | After reading some docs and similar questions online | 08:35 |
| rakhmerov | then we need to somehow make it ignore 'version' if it's not in the first position | 08:35 |
| rakhmerov | kind of | 08:35 |
| rakhmerov | did you test it in some regexp tester? | 08:36 |
| d0ugal | rakhmerov: I have been usning: http://pythex.org/ | 08:36 |
| rakhmerov | yes, me too :) | 08:36 |
| d0ugal | but when I put the new regex in the code I get new errors | 08:38 |
| d0ugal | so I guess I am still missing something | 08:38 |
| *** akuznetsova has joined #openstack-mistral | 08:38 | |
| rakhmerov | d0ugal: https://postimg.org/image/p8pjpfymx/ | 08:41 |
| rakhmerov | it matches only "direct" | 08:41 |
| rakhmerov | that follows after "wf_version: type:" | 08:42 |
| rakhmerov | seems like something is still wrong | 08:42 |
| d0ugal | hrm, interesting. | 08:42 |
| d0ugal | I guess I'll keep trying out things. | 08:42 |
| rakhmerov | ok, sure | 08:43 |
| d0ugal | I hope that it isn't passed the bull document... | 08:43 |
| rakhmerov | d0ugal: are you sure you understand the meaning of '?!' correctly? | 08:46 |
| rakhmerov | I found this: http://www.regular-expressions.info/lookaround.html | 08:46 |
| *** jpich has joined #openstack-mistral | 08:46 | |
| rakhmerov | it's a lookahead thing | 08:46 |
| d0ugal | https://docs.python.org/2/library/re.html#regular-expression-syntax | 08:47 |
| d0ugal | rakhmerov: I decided to opt for the Python docs, because I wasn't sure how similar it would be everywhere | 08:47 |
| rakhmerov | negative lookahead, yes | 08:47 |
| rakhmerov | well, as far as I can see this construct is the same | 08:48 |
| rakhmerov | its semantics | 08:48 |
| d0ugal | sure | 08:48 |
| d0ugal | but the Python docs example seems to match my understanding | 08:48 |
| d0ugal | "For example, Isaac (?!Asimov) will match 'Isaac ' only if it’s not followed by 'Asimov'." | 08:48 |
| * rakhmerov btw, renat loves Asimov very much | 08:49 | |
| d0ugal | ... but I am not sure I understand it. I only found out about it today :-D | 08:49 |
| rakhmerov | hm... | 08:49 |
| rakhmerov | this is hairy | 08:49 |
| d0ugal | yeah, doing this with regex is horrible | 08:50 |
| d0ugal | I am also looking in jsonschema for other options | 08:50 |
| rakhmerov | second, let's try to understand it together.. | 08:50 |
| rakhmerov | again, our regexp is | 08:50 |
| rakhmerov | ^(?!version)\w+$ | 08:50 |
| rakhmerov | ?! means matches if it's not followed by 'version' | 08:51 |
| rakhmerov | in combination with ^ how do we treat it? | 08:52 |
| rakhmerov | ^ = except | 08:52 |
| rakhmerov | ok | 08:52 |
| d0ugal | ^ means start of the string | 08:52 |
| rakhmerov | yes, 'except' is for a case like this [^a-b] | 08:53 |
| d0ugal | ah | 08:54 |
| rakhmerov | which means 'anything except a-b' | 08:54 |
| d0ugal | I didn't know that one | 08:54 |
| rakhmerov | yep | 08:54 |
| rakhmerov | but outside of [] it's a start of the string, right | 08:54 |
| rakhmerov | now, what does $ mean? | 08:54 |
| d0ugal | end of the string | 08:55 |
| rakhmerov | yes, right | 08:55 |
| rakhmerov | aah, then I'm confused about it again | 08:55 |
| rakhmerov | ^(?!version)\w+$ | 08:55 |
| rakhmerov | may be it should be | 08:55 |
| rakhmerov | no, I don't understand.. | 08:56 |
| d0ugal | :) | 08:56 |
| rakhmerov | what confuses me is that (?!version) goes before \w+ | 08:56 |
| d0ugal | yeah, good point. | 08:57 |
| rakhmerov | because in the example with Asimov it's: Isaac (?!Asimov) | 08:57 |
| rakhmerov | which means "matches Isaac only if it's folowed by Asimov" | 08:57 |
| rakhmerov | so what we are matching should go before what's in side (?!..) | 08:58 |
| rakhmerov | right? | 08:58 |
| d0ugal | haha, maybe? | 08:58 |
| d0ugal | I am confused too | 08:58 |
| rakhmerov | so | 08:59 |
| rakhmerov | what we need is: match everything till the end of the string that goes after 'version' | 08:59 |
| rakhmerov | right? | 08:59 |
| rakhmerov | which is in the beginning | 08:59 |
| rakhmerov | I mean 'version' | 08:59 |
| d0ugal | what we need is to match everything that isn't exactly version | 09:00 |
| rakhmerov | why doesn't ^version\w+$ work for us? | 09:00 |
| d0ugal | rakhmerov: because that would match "versiontest" | 09:00 |
| d0ugal | wait | 09:00 |
| d0ugal | umm | 09:00 |
| rakhmerov | yes, sorry | 09:00 |
| d0ugal | let me think | 09:00 |
| rakhmerov | thinking too... | 09:01 |
| d0ugal | we also need to match strings that don't start with version | 09:01 |
| rakhmerov | why is that? | 09:01 |
| d0ugal | because workflows don't need need to have version at the start of their name :P | 09:02 |
| d0ugal | rakhmerov: this regex is matching every valid workflow name | 09:02 |
| d0ugal | the only invalid workflow name is "version" | 09:02 |
| rakhmerov | yes, but why can't we use "version1_wf"? | 09:02 |
| rakhmerov | if version is not in the beginning of the doc that seems to be fine | 09:03 |
| d0ugal | sorry, I'm lost | 09:03 |
| d0ugal | that name should be fine. | 09:03 |
| rakhmerov | ^[\w\W]+$ - that matches everything including 'version' | 09:03 |
| rakhmerov | \W is important, w/o it it doesn't work in the tester | 09:04 |
| rakhmerov | because it should be either a char or a whitespace char | 09:04 |
| rakhmerov | now we need to exclude only 'version' | 09:04 |
| d0ugal | I don't think we allow whitespace at the moment btw | 09:05 |
| rakhmerov | why? | 09:05 |
| rakhmerov | we seem to | 09:05 |
| d0ugal | because the current regex doesn't allow it | 09:05 |
| rakhmerov | yes, and this is confusing too... | 09:05 |
| rakhmerov | ooh, shoot.. | 09:05 |
| d0ugal | you can use it in a workflow probably, but not a workbook | 09:05 |
| rakhmerov | yeah, I mean may be it works slightly differently in real Python | 09:06 |
| rakhmerov | but, anyway, we need to allow it, right | 09:06 |
| d0ugal | do we? I think that should be a different discussion :) | 09:07 |
| d0ugal | We shouldn't change what is allowed when fixing a specific bug imo | 09:07 |
| rakhmerov | well, any examples we usually have contain whitespaces | 09:07 |
| rakhmerov | \r, \n | 09:07 |
| d0ugal | this regex doesn't match the full document | 09:07 |
| d0ugal | it just matches the property | 09:07 |
| rakhmerov | aaah! | 09:08 |
| rakhmerov | right! | 09:08 |
| rakhmerov | ok | 09:08 |
| rakhmerov | then I've been thinking about a different regexp apparently | 09:09 |
| rakhmerov | ok, sorry | 09:09 |
| d0ugal | np | 09:10 |
| d0ugal | A regex to validate just the workflow name against the full document would be very hard :) | 09:10 |
| rakhmerov | then we need a regexp: any char sequence (number, digit etc) except if it's exactly 'version' | 09:10 |
| d0ugal | Yeah | 09:10 |
| rakhmerov | yeah, true | 09:10 |
| sharatss | rakhmerov, reviewd | 09:10 |
| d0ugal | basically, if this is Python we would be doing; if key == "version": enum else: workflow_schema | 09:11 |
| rakhmerov | sharatss: ok | 09:11 |
| rakhmerov | d0ugal: the issue is that the whole document should be validated with json schema | 09:11 |
| d0ugal | rakhmerov: sure, and I assume it is? | 09:12 |
| rakhmerov | yes | 09:12 |
| rakhmerov | should be, in base class | 09:12 |
| rakhmerov | I mean that's why we can't really use regular Python constructs | 09:12 |
| rakhmerov | like 'if' | 09:12 |
| *** sharatss has quit IRC | 09:13 | |
| rakhmerov | yeah, https://github.com/openstack/mistral/blob/master/mistral/workbook/base.py#L180 | 09:13 |
| *** sharatss has joined #openstack-mistral | 09:13 | |
| rakhmerov | so we need a regexp | 09:13 |
| d0ugal | yeah, I am just making sure the goal is clear | 09:14 |
| d0ugal | rakhmerov: but I am not sure we do need regex. I am looking at other jsonschema methods - it has quite a lot of things. | 09:15 |
| d0ugal | actually, I might have something that works | 09:15 |
| rakhmerov | ok | 09:15 |
| d0ugal | oh dear | 09:15 |
| d0ugal | I think I was looking at this totally wrong. | 09:15 |
| d0ugal | LOL | 09:16 |
| d0ugal | The problem isn't just the regex | 09:16 |
| d0ugal | it is the "version" regex | 09:16 |
| d0ugal | the line above is also a regec | 09:16 |
| d0ugal | regex | 09:16 |
| d0ugal | it needs to be ^version& | 09:16 |
| d0ugal | it needs to be ^version$ | 09:16 |
| rakhmerov | :)))) | 09:17 |
| d0ugal | because the regex "version" matches version anywhere. | 09:17 |
| * d0ugal sighs | 09:18 | |
| d0ugal | patch incoming. | 09:18 |
| rakhmerov | but wait | 09:18 |
| rakhmerov | I don't understand again | 09:18 |
| rakhmerov | ^version$ matches 'version' | 09:18 |
| rakhmerov | no? | 09:18 |
| d0ugal | rakhmerov: yeah, but we want that to match version | 09:19 |
| d0ugal | rakhmerov: because that line sets version to be the enum | 09:19 |
| d0ugal | we want that line to *only* match version | 09:19 |
| rakhmerov | so what should be the full regexp? | 09:19 |
| d0ugal | and the other one need to match everything *except* version | 09:19 |
| rakhmerov | for properties | 09:19 |
| d0ugal | rakhmerov: it might be easier if I show you in a sec... | 09:19 |
| rakhmerov | yes, ok | 09:19 |
| rakhmerov | d0ugal: yes, bug "^version$" matches also only 'version' | 09:22 |
| rakhmerov | that's the thing :) | 09:22 |
| d0ugal | that is what we want! | 09:22 |
| d0ugal | lol | 09:23 |
| rakhmerov | but we need *except* | 09:23 |
| rakhmerov | no? | 09:23 |
| d0ugal | not for that line | 09:23 |
| rakhmerov | for which one? | 09:23 |
| d0ugal | hold on, I explained this poorly. | 09:23 |
| rakhmerov | we have two regexpt | 09:23 |
| rakhmerov | 1. version | 09:23 |
| d0ugal | I am trying to write a detailed comment and commit message... but you keep asking questions :P | 09:23 |
| rakhmerov | 2. ^(?!version)\w+$ | 09:23 |
| d0ugal | rakhmerov: this line is wrong. https://github.com/openstack/mistral/blob/master/mistral/workbook/v2/workbook.py#L44 | 09:23 |
| rakhmerov | d0ugal: ooh, sorry | 09:23 |
| rakhmerov | I'll let you finish your comment :) | 09:24 |
| d0ugal | rakhmerov: that line is a regular expression that matches version in anything | 09:24 |
| rakhmerov | I'm impatient | 09:24 |
| rakhmerov | ooh, f..k! | 09:24 |
| rakhmerov | I got it | 09:24 |
| rakhmerov | yes | 09:24 |
| d0ugal | but there is also a bug in the second regular expression | 09:25 |
| rakhmerov | this regexp is invalid | 09:25 |
| rakhmerov | yes | 09:25 |
| rakhmerov | it's clear now | 09:25 |
| d0ugal | because the second one matches "workflow_version" | 09:25 |
| d0ugal | ^ that is wrong | 09:25 |
| d0ugal | just wait, I am writing it up | 09:25 |
| d0ugal | Rushing answers here and confusing things further lol | 09:25 |
| rakhmerov | yes :) | 09:25 |
| rakhmerov | excuse me | 09:25 |
| rakhmerov | I'll go to a meeting ) | 09:25 |
| d0ugal | lol | 09:26 |
| *** dtantsur is now known as dtantsur|bbl | 09:27 | |
| *** sharatss has quit IRC | 09:43 | |
| *** sharatss has joined #openstack-mistral | 09:43 | |
| *** sharatss has quit IRC | 09:44 | |
| *** sharatss has joined #openstack-mistral | 09:44 | |
| *** sharatss has quit IRC | 09:47 | |
| *** sharatss has joined #openstack-mistral | 09:48 | |
| *** _mgershen has quit IRC | 09:50 | |
| *** mgershen has joined #openstack-mistral | 09:52 | |
| *** openstack has joined #openstack-mistral | 10:04 | |
| *** sharatss has joined #openstack-mistral | 10:04 | |
| openstackgerrit | Michal Gershenzon proposed openstack/python-mistralclient: Filter workflow executions by creating task execution id https://review.openstack.org/403844 | 10:06 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Allow "version" to be within workflow names in workbooks https://review.openstack.org/405253 | 10:12 |
| *** Ephur has joined #openstack-mistral | 10:16 | |
| *** Ephur has quit IRC | 10:21 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Allow "version" to be within workflow names in workbooks https://review.openstack.org/405253 | 10:26 |
| *** thrash has quit IRC | 10:39 | |
| *** toure has quit IRC | 10:39 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Allow "version" to be within workflow names in workbooks https://review.openstack.org/405253 | 10:39 |
| d0ugal | rakhmerov: ^ | 10:40 |
| rakhmerov | yep | 10:40 |
| rakhmerov | here | 10:40 |
| rakhmerov | I saw you sent a patch | 10:40 |
| d0ugal | cool | 10:40 |
| d0ugal | I made a few extra improvements as I thought of them | 10:40 |
| *** thrash has joined #openstack-mistral | 10:43 | |
| *** toure has joined #openstack-mistral | 10:43 | |
| ddeja | Hi rakhmerov, did you see this? https://bugs.launchpad.net/mistral/+bug/1644881 | 10:52 |
| openstack | Launchpad bug 1644881 in Mistral "gate-mistral-devstack-dsvm-kombu-nv job failing" [Medium,Confirmed] - Assigned to Sharat Sharma (sharat-sharma) | 10:52 |
| ddeja | (with my additional comments) | 10:53 |
| d0ugal | ddeja: good job. I had spotted that error and had it on my list of things to look into | 10:55 |
| ddeja | the most werid thing is | 10:55 |
| ddeja | that nova/neutron (I checked those 2) don't have this problem | 10:55 |
| ddeja | I'll need to go through their code and see how they avoid this problem | 10:56 |
| rakhmerov | ddeja: I saw the bug but not your additional comments | 10:57 |
| rakhmerov | give me a few | 10:57 |
| *** janki has quit IRC | 10:57 | |
| ddeja | well, there's only one short | 10:57 |
| ddeja | I don't understand why it is only happening on the kombu gate, and not on the regular one | 10:57 |
| ddeja | but I was able to reproduce it on my devstack env using oslo.messaging | 10:58 |
| rakhmerov | ok | 10:58 |
| rakhmerov | my assumption was that something is wrong with how the test itself is designed | 10:59 |
| rakhmerov | some bad time assumptions etc. | 10:59 |
| ddeja | no, the test is totally ok | 10:59 |
| rakhmerov | ok | 10:59 |
| ddeja | BUT from what i found in nova code | 10:59 |
| rakhmerov | ooh, wait | 10:59 |
| ddeja | they have some hacks so they don't hit this problem | 11:00 |
| rakhmerov | the issue is this? 15:09:46.598605 and 15:09:47 | 11:00 |
| rakhmerov | created_at changes somehow? | 11:00 |
| ddeja | so hm, when I have it all figured out, I'll send an email to list - it seems like it's a bug in oslo | 11:00 |
| ddeja | rakhmerov: yes | 11:00 |
| ddeja | mysql is rounding the time to seconds | 11:00 |
| rakhmerov | or it gets coerced somewhere | 11:00 |
| rakhmerov | or represented in a different format | 11:00 |
| rakhmerov | rouding, haha.. | 11:01 |
| rakhmerov | ok, I see | 11:01 |
| ddeja | or oslo is doing it somewhere in it's code, I'm not sure | 11:01 |
| rakhmerov | ddeja: it seems like we saw this long long ago but nobody ever figured this out | 11:01 |
| *** janki has joined #openstack-mistral | 11:01 | |
| ddeja | basically, created_at is a default field added by oslo.db | 11:01 |
| rakhmerov | yes | 11:01 |
| rakhmerov | right | 11:01 |
| ddeja | and it's default value is lambda: datetime.utcnow() | 11:02 |
| ddeja | which returns time with microseconds | 11:02 |
| ddeja | but in the db it is stored with microseconds rounded | 11:02 |
| ddeja | up to 1 second | 11:02 |
| rakhmerov | yes | 11:03 |
| rakhmerov | this gate runs with mysql, right? | 11:03 |
| ddeja | yes | 11:04 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Allow "version" to be within workflow names in workbooks https://review.openstack.org/405253 | 11:05 |
| rakhmerov | ddeja: maybe it's a known problem, we really need to write to ML | 11:05 |
| ddeja | rakhmerov: OK. I'll do it, as soon as I got more knowledge about it | 11:11 |
| *** jaosorior_lunch is now known as jaosorior | 11:25 | |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Change version '1.0' to '2.0' https://review.openstack.org/405292 | 11:50 |
| *** dprince has joined #openstack-mistral | 11:56 | |
| *** dprince has quit IRC | 12:11 | |
| *** aspiers has quit IRC | 12:23 | |
| *** catintheroof has joined #openstack-mistral | 12:25 | |
| *** aspiers has joined #openstack-mistral | 12:35 | |
| *** dprince has joined #openstack-mistral | 12:41 | |
| openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: added action executions screens https://review.openstack.org/401188 | 12:41 |
| *** catintheroof has quit IRC | 12:48 | |
| *** sharatss has quit IRC | 12:55 | |
| *** sharatss has joined #openstack-mistral | 12:56 | |
| *** bobh has joined #openstack-mistral | 12:57 | |
| *** bobh has quit IRC | 12:57 | |
| *** bobh has joined #openstack-mistral | 12:57 | |
| *** jamielennox is now known as jamielennox|away | 13:00 | |
| *** dtantsur|bbl is now known as dtantsur | 13:04 | |
| *** thrash is now known as thrash|appt | 13:08 | |
| *** catintheroof has joined #openstack-mistral | 13:13 | |
| *** catinthe_ has joined #openstack-mistral | 13:18 | |
| *** catintheroof has quit IRC | 13:19 | |
| *** jrist has quit IRC | 13:25 | |
| *** bobh has quit IRC | 13:27 | |
| openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: added action executions screens https://review.openstack.org/401188 | 13:31 |
| *** Ephur has joined #openstack-mistral | 14:18 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Allow "version" to be within workflow names in workbooks https://review.openstack.org/405253 | 14:18 |
| *** jrist has joined #openstack-mistral | 14:21 | |
| *** Ephur has quit IRC | 14:22 | |
| *** thrash|appt is now known as thrash | 14:25 | |
| *** janki has quit IRC | 14:29 | |
| *** bobh has joined #openstack-mistral | 14:39 | |
| *** jaosorior has quit IRC | 15:09 | |
| *** jaosorior has joined #openstack-mistral | 15:09 | |
| *** hrybacki is now known as hrybacki|IAmGE | 15:49 | |
| *** hrybacki|IAmGE is now known as hrybacki|lAmG3 | 15:49 | |
| *** hrybacki|lAmG3 is now known as hrybacki|l4mG3 | 15:51 | |
| openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: added action executions screens https://review.openstack.org/401188 | 15:56 |
| *** jaosorior has quit IRC | 16:30 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Allow "version" to be within workflow names in workbooks https://review.openstack.org/405253 | 16:34 |
| d0ugal | How do I enable the profiler in Mistral? | 16:52 |
| d0ugal | hrm, osprofiler. seems it isn't trivial | 16:55 |
| d0ugal | rbrady: it seems we need to learn how to use osprofiler: http://docs.openstack.org/developer/osprofiler/index.html | 16:55 |
| d0ugal | could be fun | 16:55 |
| * rbrady adds osprofiler to evening reading | 16:56 | |
| *** jpich has quit IRC | 17:07 | |
| mgershen1 | d0ugal: Renat once told me how to do it. Its been a while, but I still have some of the steps: | 17:12 |
| mgershen1 | a. In the server config add this (3 lines): http://paste.openstack.org/show/591163/ | 17:12 |
| mgershen1 | b. also best to change logging settings a little bit. under [DEFAULT] add "log_config_append = wf_trace_logging.conf". This is what the file had: http://paste.openstack.org/show/591165/ | 17:12 |
| mgershen1 | c. and when you run a client command just add “--profile mistral_secret” at the end | 17:12 |
| mgershen1 | d. restart mistral | 17:12 |
| mgershen1 | You should know that the log is hard to read. | 17:12 |
| d0ugal | mgershen1: great, thanks | 17:13 |
| d0ugal | profile logs are rarely pretty :) | 17:14 |
| mgershen1 | d0ugal: yes, but sometimes there are external tools that can help. I heard when using PyCharm there is some support for profiling. | 17:16 |
| d0ugal | oh, cool | 17:16 |
| mgershen1 | let me know if it works :) | 17:17 |
| d0ugal | mgershen1: will do! I might have some time to play with this tomorrow. | 17:17 |
| mgershen1 | cool. good luck! | 17:17 |
| *** dprince has quit IRC | 17:27 | |
| *** rbrady is now known as rbrady-run | 17:33 | |
| *** dtantsur is now known as dtantsur|afk | 17:40 | |
| *** dprince has joined #openstack-mistral | 17:43 | |
| *** chlong has joined #openstack-mistral | 17:45 | |
| *** bobh has quit IRC | 18:20 | |
| *** shardy has quit IRC | 18:34 | |
| *** rbrady-run is now known as rbrady | 18:36 | |
| *** bobh has joined #openstack-mistral | 18:58 | |
| *** bobh has quit IRC | 19:01 | |
| *** bobh has joined #openstack-mistral | 19:01 | |
| *** bobh has quit IRC | 19:06 | |
| *** openstackgerrit has quit IRC | 19:32 | |
| *** openstackgerrit has joined #openstack-mistral | 19:33 | |
| *** openstackgerrit has quit IRC | 19:36 | |
| *** jamielennox|away is now known as jamielennox | 19:53 | |
| *** dprince has quit IRC | 20:16 | |
| *** bobh has joined #openstack-mistral | 20:28 | |
| *** catinthe_ has quit IRC | 20:34 | |
| *** openstack has joined #openstack-mistral | 20:44 | |
| *** toure is now known as toure|gone | 21:04 | |
| *** toure|gone is now known as toure|biab | 21:04 | |
| *** bobh has quit IRC | 21:38 | |
| *** Ephur has joined #openstack-mistral | 21:44 | |
| *** bobh has joined #openstack-mistral | 21:44 | |
| *** jrist has quit IRC | 21:49 | |
| *** bobh has quit IRC | 21:58 | |
| *** thrash is now known as thrash|g0ne | 22:05 | |
| *** DaveTurner has joined #openstack-mistral | 22:30 | |
| *** chlong has quit IRC | 22:50 | |
| *** bobh has joined #openstack-mistral | 22:59 | |
| *** bobh has quit IRC | 23:03 | |
| *** weshay is now known as weshay_pto | 23:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!