| *** thrash is now known as thrash|g0ne | 02:02 | |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Modify the function "_get_spec_version(spec_dict)" https://review.openstack.org/404510 | 03:03 |
|---|---|---|
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Modify the function "_get_spec_version(spec_dict)" https://review.openstack.org/404510 | 04:00 |
| openstackgerrit | fengchaoyang proposed openstack/python-mistralclient: Move json.loads() method to utils.py, and use "with" to deal with file objects https://review.openstack.org/404336 | 04:05 |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Modify the function "_get_spec_version(spec_dict)" https://review.openstack.org/404510 | 04:08 |
| *** bobh has quit IRC | 04:36 | |
| *** hparekh has joined #openstack-mistral | 05:18 | |
| *** catinthe_ has quit IRC | 05:19 | |
| *** catintheroof has joined #openstack-mistral | 05:21 | |
| *** catintheroof has quit IRC | 05:26 | |
| *** bobh has joined #openstack-mistral | 05:36 | |
| *** bobh has quit IRC | 05:41 | |
| *** ist has joined #openstack-mistral | 05:50 | |
| *** jaosorior has joined #openstack-mistral | 06:06 | |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Modify the function "_get_spec_version(spec_dict)" https://review.openstack.org/404510 | 06:07 |
| rakhmerov | ddeja: hi | 06:11 |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Modify import style in code https://review.openstack.org/404562 | 06:22 |
| rakhmerov | ddeja: I left my comments in https://review.openstack.org/#/c/402392/ | 06:40 |
| rakhmerov | thinking how to fix kombu_server | 06:41 |
| sharatss | rakhmerov, https://bugs.launchpad.net/mistral/+bug/1644881 | 06:42 |
| openstack | Launchpad bug 1644881 in Mistral "gate-mistral-devstack-dsvm-kombu-nv job failing" [Undecided,New] - Assigned to Sharat Sharma (sharat-sharma) | 06:42 |
| sharatss | rakhmerov, i had raised a bug for it | 06:42 |
| rakhmerov | ok | 06:42 |
| rakhmerov | ddeja was actually looking at it | 06:43 |
| rakhmerov | talk to him | 06:43 |
| sharatss | rakhmerov, he can continue on it.. no issues :) i wanted to make sure that you know there's a bug against it and it closes after the fix :)) | 06:45 |
| rakhmerov | ok, sure | 06:45 |
| rakhmerov | thanks | 06:45 |
| *** jaosorior has quit IRC | 07:08 | |
| *** jaosorior has joined #openstack-mistral | 07:08 | |
| rakhmerov | ddeja: seems like I need your help with understanding kombu server | 07:12 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Fix launch process of Mistral components https://review.openstack.org/402392 | 07:18 |
| rakhmerov | ddeja: Ok, I sent another patchset, take a look at kombu server. I added another flag (Event instance) to notify when run() method finished | 07:18 |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Modify the function "_get_spec_version(spec_dict)" https://review.openstack.org/404510 | 07:26 |
| *** Ravikiran_K has joined #openstack-mistral | 07:36 | |
| *** bobh has joined #openstack-mistral | 07:38 | |
| openstackgerrit | Jizhaoxuan proposed openstack/mistral: Modify the function "_get_spec_version(spec_dict)" https://review.openstack.org/404510 | 07:42 |
| *** bobh has quit IRC | 07:42 | |
| *** shardy has joined #openstack-mistral | 08:04 | |
| openstackgerrit | Merged openstack/mistral: Modify import style in code https://review.openstack.org/404562 | 08:38 |
| rakhmerov | ddeja, hparekh, d0ugal: guys, could you please review a dashboard patch https://review.openstack.org/#/c/401188/ ? | 08:40 |
| rakhmerov | I know it's not your primary expertise but somebody needs to be reviewing these patches too | 08:40 |
| d0ugal | I've never even used the dashboard :) | 08:40 |
| rakhmerov | I know but.. | 08:40 |
| rakhmerov | we need to be reviewing these patches too | 08:40 |
| d0ugal | Sure, I can try. | 08:40 |
| rakhmerov | we just got ^Gal^ recently for almost full time, he is supposed to make a good progress with our dashboard | 08:41 |
| rakhmerov | let's help him | 08:41 |
| hparekh | rakhmerov: sure I will | 08:43 |
| rakhmerov | thanks | 08:44 |
| ddeja | rakhmerov: Hi | 09:08 |
| rakhmerov | ddeja: hi :) | 09:09 |
| ddeja | about the bug... Im curious why It's happening only on kombu gate, not on regular one... | 09:09 |
| ddeja | I have one idea, but I need to send a patch to check it | 09:09 |
| ddeja | will do it in a minute | 09:10 |
| rakhmerov | ok, sure | 09:10 |
| rakhmerov | and please review my changes again | 09:10 |
| ddeja | yes, sure | 09:11 |
| ddeja | and what question do you have about the kombu server? | 09:12 |
| *** jaosorior is now known as jaosorior_lunch | 09:13 | |
| rakhmerov | ddeja: I already found an answer :) | 09:14 |
| ddeja | oh, cool | 09:21 |
| *** bobh has joined #openstack-mistral | 09:40 | |
| *** bobh has quit IRC | 09:44 | |
| *** ist has quit IRC | 09:46 | |
| ddeja | sharatss: Hi, yes, I'm looking on the bug. I'll reassigne it to me if it's ok with you | 10:01 |
| *** janki has joined #openstack-mistral | 10:07 | |
| *** jaosorior_lunch has quit IRC | 10:19 | |
| *** sharatss has quit IRC | 10:19 | |
| *** sharatss has joined #openstack-mistral | 10:19 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: DO NOT MERGE - TEST https://review.openstack.org/404711 | 10:21 |
| rakhmerov | d0ugal: please review my changes again too | 10:21 |
| rakhmerov | ddeja: finally looking at preconditions spec | 10:21 |
| rakhmerov | :) | 10:21 |
| ddeja | rakhmerov: great | 10:22 |
| rakhmerov | ddeja: general comment that I came up with by now is that I believe we need to start with something simple | 10:22 |
| rakhmerov | w/o trying to pursue all of these things | 10:23 |
| rakhmerov | I believe a couple of things that you mentioned are relatively easy and will be definitely useful for many cases | 10:23 |
| rakhmerov | I'm writing my comments.. | 10:23 |
| ddeja | rakhmerov: OK | 10:24 |
| ddeja | To be honest, the jinja/yaql 'tasks' function may be used in the most cases | 10:24 |
| rakhmerov | wait for my comments :) | 10:25 |
| rakhmerov | I guess just the function is not enough | 10:25 |
| * ddeja should me more patient | 10:25 | |
| *** _gryf_ has joined #openstack-mistral | 10:25 | |
| rakhmerov | no, that's fine :)) | 10:25 |
| rakhmerov | you are patient | 10:25 |
| *** _gryf has quit IRC | 10:25 | |
| *** enykeev has quit IRC | 10:25 | |
| rakhmerov | ok, I left part of my comments | 10:25 |
| rakhmerov | you can take a look | 10:26 |
| ddeja | looking | 10:26 |
| rakhmerov | but I still need to review the rest.. | 10:26 |
| rakhmerov | so, look at my last comment about a simple check and atomicity | 10:26 |
| *** enykeev has joined #openstack-mistral | 10:26 | |
| rakhmerov | I think this shows why 1) it needs to be a special functionality 2) we need to implement it inside Mistral | 10:27 |
| *** jaosorior_lunch has joined #openstack-mistral | 10:31 | |
| ddeja | rakhmerov: Yup, I see. | 10:35 |
| ddeja | I need to think now how to re-write it | 10:35 |
| rakhmerov | yes, we could start with a simple thing, declare it as an experimental feature of workflow language for a while | 10:36 |
| rakhmerov | then we can see if we need to add/change something else | 10:36 |
| rakhmerov | once it's good and battle proven we can remove "experimental" status | 10:37 |
| *** jaosorior_lunch is now known as jaosorior | 10:41 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Fix launch process of Mistral components https://review.openstack.org/402392 | 10:42 |
| rakhmerov | ddeja: I fixed the issue from your last comment in https://review.openstack.org/#/c/402392/ | 10:43 |
| ddeja | that's good | 10:44 |
| ddeja | I don't think there is anything left that I see | 10:44 |
| ddeja | but IMO the more people look at it the better | 10:44 |
| rakhmerov | sure, I 100% agree | 10:48 |
| rakhmerov | it's a big change | 10:48 |
| rakhmerov | we were also discussing if we need to backport it or not into the stable branch | 10:49 |
| rakhmerov | and my opinion: we should not | 10:49 |
| rakhmerov | we need time to see if it's stable enough | 10:49 |
| ddeja | I agree - IMO we should not provide such big changes into stable release | 10:49 |
| rakhmerov | yes | 10:50 |
| ddeja | rakhmerov: oh, and by 'letting another to take a look on it' I mean if we could postopne merge of it till, let's say, end of week? | 10:50 |
| ddeja | so we can have, for example, 3 +2? | 10:51 |
| rakhmerov | no problem, sure | 10:51 |
| rakhmerov | hparekh, d0ugal: guys, as just discussed we'd like to have 3 +2 for https://review.openstack.org/#/c/402392/ | 10:52 |
| rakhmerov | so please review once you have time | 10:52 |
| rakhmerov | sharatss: can you please address the comments in https://review.openstack.org/#/c/399027/ ? | 10:53 |
| rakhmerov | left by Dawid | 10:53 |
| sharatss | rakhmerov, looking at it | 10:55 |
| rakhmerov | ok | 10:55 |
| ddeja | droping for lunch, will be back in an hour | 10:55 |
| rakhmerov | ok | 10:55 |
| *** Ravikiran_K has quit IRC | 10:58 | |
| d0ugal | Sure, I'll try and take a look today | 10:59 |
| *** janki has quit IRC | 11:05 | |
| rakhmerov | thanks | 11:06 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Small changes to docs to comply with openstack document style https://review.openstack.org/399027 | 11:17 |
| *** hparekh has quit IRC | 11:24 | |
| *** thrash|g0ne is now known as thrash | 11:34 | |
| *** szaher has quit IRC | 11:56 | |
| *** ist has joined #openstack-mistral | 12:02 | |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient: Initial commit for python-mistralclient document https://review.openstack.org/404736 | 12:04 |
| *** sharatss has quit IRC | 12:23 | |
| *** sharatss has joined #openstack-mistral | 12:23 | |
| *** catintheroof has joined #openstack-mistral | 12:29 | |
| *** catinthe_ has joined #openstack-mistral | 12:32 | |
| *** catintheroof has quit IRC | 12:34 | |
| *** jrist has joined #openstack-mistral | 12:37 | |
| *** ist has quit IRC | 12:41 | |
| *** _gryf_ is now known as _gryf | 12:41 | |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient: Initial commit for python-mistralclient document https://review.openstack.org/404736 | 12:43 |
| *** ist has joined #openstack-mistral | 13:03 | |
| *** catintheroof has joined #openstack-mistral | 13:12 | |
| *** catinthe_ has quit IRC | 13:16 | |
| *** ist has quit IRC | 13:23 | |
| *** dtantsur|afk is now known as dtantsur | 13:29 | |
| *** ist has joined #openstack-mistral | 13:40 | |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient: Initial commit for python-mistralclient document https://review.openstack.org/404736 | 13:47 |
| *** rbrady-afk is now known as rbrady | 13:48 | |
| dtantsur | morning/afternoon folks! could you please review https://review.openstack.org/#/c/404203/? it's really small but does require more eyes | 13:49 |
| ddeja | dtantsur: looking | 13:53 |
| *** szaher has joined #openstack-mistral | 13:56 | |
| *** hrybacki is now known as hrybacki|mtg | 14:00 | |
| *** shardy has quit IRC | 14:09 | |
| dtantsur | rakhmerov, hey! could you please also jump on the discussion in https://review.openstack.org/#/c/404203/ ? | 14:15 |
| dtantsur | this is about the default microversion we pass to ironic | 14:15 |
| ddeja | dtantsur: | 14:16 |
| ddeja | I think we should talk here | 14:16 |
| dtantsur | sure | 14:16 |
| dtantsur | to add to what I said, this is what nova does: https://github.com/openstack/nova/blob/master/nova/virt/ironic/client_wrapper.py#L37 | 14:16 |
| ddeja | istead of passing another comments on the patchset :) | 14:16 |
| ddeja | let me look | 14:16 |
| dtantsur | nova's example is not exactly the same, of course, because nova knows what exactly it needs from Ironic API | 14:17 |
| ddeja | yes, this is the same what I proposed in the first comment | 14:17 |
| dtantsur | right | 14:17 |
| dtantsur | I like the idea of IRONIC_API_VERSION='1.22', but I don't quite like putting it in mistral.conf (or whatever you use) | 14:18 |
| ddeja | but why not? | 14:18 |
| ddeja | I mean, the possible actions are stored in json file, | 14:18 |
| dtantsur | well, there are two things here: the default we provide and the customization we allow | 14:19 |
| dtantsur | I think the default we provide should not be mid-Liberty. I guess we're in agreement on this one, right? | 14:19 |
| d0ugal | agreed :) | 14:20 |
| dtantsur | Now, I'm not sure it's valuable to allow operators to customize API version, provided that it's users, not operators, who create workflows | 14:20 |
| ddeja | Yes, it it reasonable to use Newton based one | 14:20 |
| ddeja | well, I agree | 14:20 |
| dtantsur | API version is not only about actions: it's also about parameters we can pass and results we receive | 14:20 |
| ddeja | one user may want another version of API than another | 14:20 |
| dtantsur | so in my view two things should happen: 1. we should change the default, 2. we should allow users to change it via API | 14:20 |
| dtantsur | my patch is about #1, while I know d0ugal (or not?) was thinking about #2 | 14:21 |
| ddeja | OK, so making it short, please change your patchset so it is similar to nova, so that we have all defaults at the beggining of the file | 14:21 |
| dtantsur | ack, on it | 14:21 |
| ddeja | and about #2, we defenetily don't have to solve it now | 14:22 |
| *** donnalezyty has joined #openstack-mistral | 14:22 | |
| d0ugal | dtantsur: I was thinking users should be able to change it, to allow flexibility. Changing the default however also makes sense. | 14:22 |
| openstackgerrit | Dmitry Tantsur proposed openstack/mistral: Bump Ironic API version to 1.22 when creating the Ironic client https://review.openstack.org/404203 | 14:23 |
| dtantsur | d0ugal, ddeja, wdyt ^^^ | 14:23 |
| d0ugal | looks good | 14:25 |
| d0ugal | rakhmerov: ^ | 14:31 |
| *** donnalezyty_ has joined #openstack-mistral | 14:34 | |
| *** donnalezyty has quit IRC | 14:34 | |
| ddeja | dtantsur: I give second +2 on it, but I'd like rakhmerov to give +W on it :) | 14:42 |
| *** ist has quit IRC | 14:46 | |
| *** chlong has joined #openstack-mistral | 14:55 | |
| *** jaosorior has quit IRC | 14:57 | |
| *** jaosorior has joined #openstack-mistral | 14:59 | |
| dtantsur | ack, thanks! | 15:01 |
| *** bobh has joined #openstack-mistral | 15:01 | |
| *** hrybacki|mtg is now known as hrybacki | 15:04 | |
| *** shardy has joined #openstack-mistral | 15:05 | |
| *** bobh has quit IRC | 15:06 | |
| *** dprince has joined #openstack-mistral | 15:21 | |
| *** bobh has joined #openstack-mistral | 15:26 | |
| openstackgerrit | Michal Gershenzon proposed openstack/mistral: Yaql Tasks Function https://review.openstack.org/401360 | 15:49 |
| *** jaosorior has quit IRC | 15:58 | |
| *** chlong has quit IRC | 16:03 | |
| *** chlong has joined #openstack-mistral | 16:18 | |
| *** ist has joined #openstack-mistral | 16:36 | |
| *** catintheroof has quit IRC | 17:11 | |
| *** catintheroof has joined #openstack-mistral | 17:12 | |
| *** chlong has quit IRC | 17:21 | |
| *** chlong has joined #openstack-mistral | 17:34 | |
| *** shardy has quit IRC | 17:35 | |
| *** dtantsur is now known as dtantsur|afk | 17:37 | |
| *** ist has quit IRC | 17:39 | |
| *** Ephur has joined #openstack-mistral | 18:04 | |
| *** bobh has quit IRC | 18:19 | |
| openstackgerrit | Michal Gershenzon proposed openstack/python-mistralclient: Filter workflow executions by creating task execution id https://review.openstack.org/403844 | 18:31 |
| *** bobh has joined #openstack-mistral | 19:08 | |
| *** catintheroof has quit IRC | 19:54 | |
| *** catintheroof has joined #openstack-mistral | 20:54 | |
| *** bobh has quit IRC | 20:59 | |
| *** dprince has quit IRC | 21:03 | |
| *** bobh has joined #openstack-mistral | 21:59 | |
| *** jrist has quit IRC | 22:01 | |
| *** jrist has joined #openstack-mistral | 22:02 | |
| *** bobh has quit IRC | 22:04 | |
| *** jrist has quit IRC | 22:07 | |
| *** jrist has joined #openstack-mistral | 22:42 | |
| *** bobh has joined #openstack-mistral | 22:42 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements https://review.openstack.org/405008 | 23:07 |
| *** catintheroof has quit IRC | 23:12 | |
| *** chlong has quit IRC | 23:22 | |
| *** szaher has quit IRC | 23:25 | |
| *** szaher has joined #openstack-mistral | 23:28 | |
| *** bobh has quit IRC | 23:39 | |
| *** bobh has joined #openstack-mistral | 23:39 | |
| *** bobh has quit IRC | 23:44 | |
| *** enykeev has quit IRC | 23:46 | |
| *** enykeev has joined #openstack-mistral | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!