| *** rrecio has quit IRC | 00:06 | |
| *** catintheroof has joined #openstack-mistral | 00:11 | |
| *** gyee has quit IRC | 00:53 | |
| *** catintheroof has quit IRC | 00:54 | |
| *** chlong has quit IRC | 01:11 | |
| *** bobh has joined #openstack-mistral | 02:00 | |
| *** bobh has quit IRC | 02:00 | |
| *** bobh has joined #openstack-mistral | 02:01 | |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/399052 | 02:57 |
|---|---|---|
| *** sharatss has quit IRC | 03:03 | |
| *** sharatss has joined #openstack-mistral | 03:04 | |
| *** bobh has quit IRC | 04:40 | |
| *** vishwanathj has joined #openstack-mistral | 05:05 | |
| *** hparekh has joined #openstack-mistral | 05:15 | |
| *** janki has joined #openstack-mistral | 05:47 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Delete executions only after they are finished https://review.openstack.org/399379 | 06:01 |
| *** jamielennox is now known as jamielennox|away | 06:36 | |
| rakhmerov | d0ugal: hey Dougal | 07:36 |
| rakhmerov | Winson filled his time slots | 07:36 |
| rakhmerov | just FYI | 07:37 |
| *** jaosorior has joined #openstack-mistral | 07:39 | |
| *** jamielennox|away is now known as jamielennox | 08:03 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** vishwana_ has joined #openstack-mistral | 08:03 | |
| *** openstackgerrit has joined #openstack-mistral | 08:03 | |
| *** vishwanathj has quit IRC | 08:05 | |
| rakhmerov | ddeja: hi Dawid | 08:19 |
| rakhmerov | I see that our kombu gate is already active | 08:19 |
| openstackgerrit | Cao Xuan Hoang proposed openstack/mistral: Replace 'assertFalse(a in b)' with 'assertNotIn(a, b)' https://review.openstack.org/399427 | 08:19 |
| rakhmerov | just 1 test is failing | 08:19 |
| rakhmerov | can you look at it? | 08:22 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Make YAQL evaluator catch and wrap all underlying exceptions https://review.openstack.org/399444 | 08:47 |
| *** shardy has joined #openstack-mistral | 08:53 | |
| *** jpich has joined #openstack-mistral | 08:55 | |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient: Replace uuid4() with generate_uuid() from oslo_utils https://review.openstack.org/399448 | 08:56 |
| sharatss | hi everyone! | 09:14 |
| d0ugal | rakhmerov: thanks | 09:18 |
| d0ugal | rakhmerov: I'll send an email about it today | 09:18 |
| rakhmerov | ok | 09:18 |
| rakhmerov | sharatss: hi | 09:18 |
| sharatss | rakhmerov: did u get time to look at the py35 fix | 09:18 |
| sharatss | rakhmerov: i had removed the python warnings. Now its passing | 09:19 |
| d0ugal | This: https://review.openstack.org/398931 | 09:19 |
| sharatss | rakhmerov, d0ugal free? | 09:30 |
| rakhmerov | sharatss: not yet, busy with something else | 09:30 |
| rakhmerov | sharatss: I'll look at it today later | 09:31 |
| sharatss | rakhmerov: ok sure | 09:31 |
| sharatss | hparekh: d0ugal: hi | 09:31 |
| *** shardy has quit IRC | 09:34 | |
| *** aspiers has quit IRC | 09:34 | |
| *** shardy has joined #openstack-mistral | 09:34 | |
| *** aspiers has joined #openstack-mistral | 09:35 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Make YAQL evaluator catch and wrap all underlying exceptions https://review.openstack.org/399474 | 09:38 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Make Jinja evaluator catch and wrap all underlying exceptions https://review.openstack.org/399474 | 09:39 |
| ddeja | rakhmerov: yes, sure | 09:40 |
| rakhmerov | ddeja, d0ugal, hparekh: guys, when you have time please review https://review.openstack.org/#/c/399444/ | 09:49 |
| rakhmerov | I need it backported to stable branch by next Tue | 09:49 |
| *** osunix has joined #openstack-mistral | 09:51 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 09:53 | |
| rakhmerov | hparekh: thanks, that was fast :) | 09:53 |
| *** osunix has quit IRC | 09:55 | |
| hparekh | rakhmerov: :) thanks to you for fixing. | 09:56 |
| rakhmerov | np | 09:56 |
| rakhmerov | hparekh: maybe you can also look at https://review.openstack.org/#/c/399474/? It's exactly the same thing but for jinja | 10:07 |
| hparekh | rakhmerov: left a comment on it | 10:10 |
| rakhmerov | ooh, yes, good catch | 10:11 |
| rakhmerov | copy paste | 10:11 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Make Jinja evaluator catch and wrap all underlying exceptions https://review.openstack.org/399474 | 10:12 |
| rakhmerov | hparekh: fixed it | 10:12 |
| *** sharatss has quit IRC | 10:15 | |
| *** sharatss has joined #openstack-mistral | 10:16 | |
| *** AlexeyAbashkin has quit IRC | 10:16 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Add timestamp at the bottom of every page https://review.openstack.org/397761 | 10:28 |
| openstackgerrit | Istvan Imre proposed openstack/python-mistralclient: Region name related command line arguments are added https://review.openstack.org/386403 | 10:34 |
| *** ist has joined #openstack-mistral | 10:39 | |
| openstackgerrit | Merged openstack/mistral: Replace 'assertFalse(a in b)' with 'assertNotIn(a, b)' https://review.openstack.org/399427 | 10:43 |
| rakhmerov | ist: hi, welcome :) | 10:47 |
| ddeja | rakhmerov: about failing one test in kombu gate | 10:50 |
| ddeja | for now, kombu gate runs same tests as gate-mistral-devstack-dsvm | 10:51 |
| ddeja | it only changes the rpc backend | 10:51 |
| ddeja | but rest is the same | 10:51 |
| ddeja | and i see, thet in this patch, all tests passed https://review.openstack.org/#/c/399427/ | 10:52 |
| rakhmerov | yes | 10:52 |
| rakhmerov | hm... so, some race condition? | 10:52 |
| ddeja | so I guess that failing test is same as in the regular dsvm gate | 10:52 |
| ddeja | which also sometimes fail | 10:52 |
| ddeja | but I'll take a look | 10:53 |
| rakhmerov | as far as I remember, it was a different test | 10:53 |
| ddeja | oh, I found it | 10:53 |
| ddeja | hm, interesting | 10:53 |
| ddeja | testtools.matchers._impl.MismatchError: u'2016-11-17 14:35:02' != u'2016-11-17 14:35:03' | 10:53 |
| rakhmerov | in devstack-dsvm we have usually only one test failing | 10:53 |
| rakhmerov | for action "std.ssh_proxied" | 10:54 |
| rakhmerov | ddeja: I assume it might a test problem itself | 10:54 |
| rakhmerov | if it's related with time comparison the test may not be designed well | 10:54 |
| ddeja | here test_update_action failed | 10:54 |
| rakhmerov | assuming same time for two different things (that can change in between) | 10:55 |
| rakhmerov | yeah, I'm almost sure this is the case | 10:55 |
| ddeja | I'll take a look onto this test and send a patch if I found something suspecious | 10:55 |
| rakhmerov | yes, thanks | 10:55 |
| rakhmerov | bad assumptions about time, please this hypothesis | 10:55 |
| rakhmerov | please check.. | 10:56 |
| ddeja | yes, sure | 10:58 |
| ddeja | rakhmerov: hm... I've looked into tests, | 11:00 |
| ddeja | and there are two options | 11:00 |
| rakhmerov | ok | 11:01 |
| ddeja | a) we are using time comparison in wrong way | 11:01 |
| ddeja | or b) we are chanigng the 'created_at' field while updating the action | 11:01 |
| ddeja | which is wrong, I guess? | 11:01 |
| rakhmerov | hm... | 11:02 |
| rakhmerov | b) might be true | 11:02 |
| ddeja | here's what this test is doing | 11:02 |
| ddeja | it creates action | 11:02 |
| rakhmerov | because I remember that some people were complaining about it | 11:02 |
| ddeja | saves created_at time | 11:02 |
| rakhmerov | yep | 11:02 |
| ddeja | updates actions | 11:02 |
| ddeja | takes created_at time again and comparing those times | 11:02 |
| ddeja | since the tests takes time to complete about 0.2 seconds | 11:03 |
| rakhmerov | bad assumption :), it may take virtually any time | 11:03 |
| ddeja | and the times we are comparing have the accuracy to seconds | 11:03 |
| ddeja | this test usually pass | 11:03 |
| ddeja | but sometimes not | 11:03 |
| rakhmerov | yeah, right | 11:03 |
| rakhmerov | we can't assume any time deltas actually | 11:03 |
| ddeja | yes, sure, I'm just explaining why it usually pass | 11:04 |
| ddeja | :) | 11:04 |
| rakhmerov | oh, I see | 11:04 |
| *** jaosorior is now known as jaosorior_lunch | 11:04 | |
| rakhmerov | ok, this is not a huge problem. As a general comment, I believe we have some other places where we do this | 11:05 |
| rakhmerov | we need to fix it when we have time | 11:05 |
| ddeja | ok | 11:06 |
| ddeja | but, on the other hand | 11:06 |
| ddeja | same problem may occure when we change the regular gate to voting | 11:06 |
| ddeja | and it would slow down our developement | 11:06 |
| rakhmerov | yes | 11:06 |
| ddeja | so hm, since I found this one, I'll try to fix it | 11:07 |
| rakhmerov | currently, we usually see one test failing | 11:07 |
| rakhmerov | for ssh_proxied | 11:07 |
| ddeja | yes | 11:07 |
| rakhmerov | that's why this is my biggest concern | 11:07 |
| rakhmerov | I don't see other tests failing often | 11:07 |
| openstackgerrit | Merged openstack/mistral: Make YAQL evaluator catch and wrap all underlying exceptions https://review.openstack.org/399444 | 11:07 |
| rakhmerov | ddeja: do well do you know project-infra? | 11:07 |
| ddeja | not really | 11:08 |
| ddeja | that was my first patch and it took some time to make it work | 11:08 |
| rakhmerov | ok | 11:09 |
| rakhmerov | I'm just trying to investigate why our gate for postgres disappeared | 11:09 |
| rakhmerov | seems like it happened after this patch: https://github.com/openstack-infra/project-config/commit/67b2522db#diff-b06733bee8372afe7f7e9b9ef86f24e6L5992 | 11:10 |
| rakhmerov | they were doing some refactoring | 11:10 |
| ddeja | rakhmerov: I need to drop, while be back in the hout | 11:11 |
| ddeja | hour* | 11:11 |
| rakhmerov | ok | 11:12 |
| openstackgerrit | Istvan Imre proposed openstack/python-mistralclient: Region name related command line arguments are added https://review.openstack.org/386403 | 11:17 |
| *** sharatss has quit IRC | 11:20 | |
| *** sharatss has joined #openstack-mistral | 11:20 | |
| *** ist is now known as alma | 11:29 | |
| *** alma is now known as ist | 11:29 | |
| *** ist_ has joined #openstack-mistral | 11:40 | |
| *** hparekh has quit IRC | 11:42 | |
| *** jaosorior_lunch is now known as jaosorior | 11:44 | |
| *** janki has quit IRC | 11:46 | |
| *** ist_ has quit IRC | 11:46 | |
| *** ist_ has joined #openstack-mistral | 11:47 | |
| *** ist has quit IRC | 11:48 | |
| *** ist_ is now known as ist | 11:52 | |
| *** bobh has joined #openstack-mistral | 12:48 | |
| *** bobh has quit IRC | 12:48 | |
| *** bobh has joined #openstack-mistral | 12:48 | |
| *** bobh has quit IRC | 12:52 | |
| *** bobh has joined #openstack-mistral | 12:52 | |
| *** bobh has quit IRC | 12:57 | |
| *** bobh has joined #openstack-mistral | 13:13 | |
| *** bobh has quit IRC | 13:24 | |
| *** jaosorior has quit IRC | 13:42 | |
| *** dmellado is now known as dmellado|lunch | 13:50 | |
| *** dmellado|lunch is now known as dmellado | 14:12 | |
| *** chlong has joined #openstack-mistral | 14:53 | |
| *** rrecio has joined #openstack-mistral | 15:55 | |
| *** rrecio has quit IRC | 15:59 | |
| *** bobh has joined #openstack-mistral | 17:16 | |
| *** bobh has quit IRC | 17:16 | |
| *** bobh has joined #openstack-mistral | 17:16 | |
| *** rrecio has joined #openstack-mistral | 17:20 | |
| *** bobh has quit IRC | 17:42 | |
| *** bobh has joined #openstack-mistral | 17:49 | |
| *** bobh has quit IRC | 17:50 | |
| *** bobh has joined #openstack-mistral | 17:51 | |
| *** jpich has quit IRC | 17:53 | |
| *** bobh has quit IRC | 17:54 | |
| *** bobh has joined #openstack-mistral | 17:54 | |
| *** bobh has quit IRC | 17:55 | |
| *** bobh has joined #openstack-mistral | 17:56 | |
| *** bobh has quit IRC | 18:00 | |
| *** bobh has joined #openstack-mistral | 18:35 | |
| *** bobh has quit IRC | 18:38 | |
| *** bobh has joined #openstack-mistral | 18:39 | |
| *** bobh has quit IRC | 18:43 | |
| *** bobh has joined #openstack-mistral | 19:59 | |
| *** bobh has quit IRC | 20:13 | |
| *** chlong has quit IRC | 20:53 | |
| *** clenimar has quit IRC | 20:56 | |
| *** shardy has quit IRC | 20:59 | |
| *** catintheroof has joined #openstack-mistral | 21:31 | |
| *** rrecio has quit IRC | 21:34 | |
| *** rrecio has joined #openstack-mistral | 21:37 | |
| *** rrecio has quit IRC | 21:47 | |
| *** bobh has joined #openstack-mistral | 22:30 | |
| *** akuznetsova has quit IRC | 23:03 | |
| *** igormarnat has quit IRC | 23:04 | |
| *** rakhmerov has quit IRC | 23:04 | |
| *** igormarnat has joined #openstack-mistral | 23:06 | |
| *** rakhmerov has joined #openstack-mistral | 23:08 | |
| *** akuznetsova has joined #openstack-mistral | 23:08 | |
| *** bobh has quit IRC | 23:30 | |
| *** bobh has joined #openstack-mistral | 23:31 | |
| *** bobh has quit IRC | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!