*** ninag has joined #openstack-mistral | 00:00 | |
*** ninag has quit IRC | 00:01 | |
*** toddjohn has quit IRC | 00:02 | |
*** apsarshaik has quit IRC | 00:07 | |
*** gyee has quit IRC | 00:09 | |
*** toddjohn has joined #openstack-mistral | 00:55 | |
*** toddjohn has quit IRC | 01:11 | |
*** harlowja has joined #openstack-mistral | 01:35 | |
*** harlowja has quit IRC | 01:35 | |
*** harlowja has joined #openstack-mistral | 01:36 | |
*** cheneydc has joined #openstack-mistral | 01:40 | |
*** bobh has joined #openstack-mistral | 01:57 | |
*** toddjohn has joined #openstack-mistral | 02:11 | |
*** cheneydc has quit IRC | 02:15 | |
*** toddjohn has quit IRC | 02:16 | |
*** bobh has quit IRC | 02:23 | |
*** bobh has joined #openstack-mistral | 02:35 | |
*** harlowja has quit IRC | 02:46 | |
*** bobh has quit IRC | 02:47 | |
openstackgerrit | hardik proposed openstack/mistral: Allow to use both name and id to access action definitions https://review.openstack.org/325894 | 02:51 |
---|---|---|
openstackgerrit | hardik proposed openstack/mistral: Allow to use both name and id to access action definitions https://review.openstack.org/325894 | 03:09 |
*** toddjohn has joined #openstack-mistral | 03:12 | |
*** toddjohn has quit IRC | 03:17 | |
*** clenimar has quit IRC | 03:28 | |
*** clenimar has joined #openstack-mistral | 03:32 | |
*** clenimar has quit IRC | 04:04 | |
*** Ravikiran_K has joined #openstack-mistral | 04:05 | |
*** clenimar has joined #openstack-mistral | 04:10 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-mistralclient: Updated from global requirements https://review.openstack.org/345152 | 04:10 |
*** toddjohn has joined #openstack-mistral | 04:13 | |
*** toddjohn has quit IRC | 04:18 | |
*** vishwanathj is now known as vishwanathj_zzz | 04:39 | |
*** Ravikiran_K has left #openstack-mistral | 04:49 | |
*** Ravikiran_K has joined #openstack-mistral | 04:52 | |
*** d0ugal has quit IRC | 04:56 | |
*** d0ugal has joined #openstack-mistral | 04:58 | |
*** toddjohn has joined #openstack-mistral | 05:15 | |
*** gyee has joined #openstack-mistral | 05:20 | |
*** toddjohn has quit IRC | 05:20 | |
*** Ravikiran_K has quit IRC | 05:32 | |
*** Ravikiran_K has joined #openstack-mistral | 05:37 | |
*** harlowja has joined #openstack-mistral | 05:39 | |
*** gyee has quit IRC | 05:49 | |
*** Ravikiran_K has quit IRC | 05:56 | |
*** gyee has joined #openstack-mistral | 05:58 | |
*** harlowja has quit IRC | 06:04 | |
*** gyee has quit IRC | 06:05 | |
*** Ravikiran_K has joined #openstack-mistral | 06:16 | |
openstackgerrit | Merged openstack/python-mistralclient: Updated from global requirements https://review.openstack.org/345152 | 06:20 |
rakhmerov | hparekh: hi, here? | 06:23 |
rakhmerov | hparekh: ping me when you have a minute | 06:25 |
hparekh | rakhmerov, hi | 06:28 |
rakhmerov | I left some comments in https://review.openstack.org/#/c/325894/ | 06:29 |
rakhmerov | I want to merge this patch sooner than later | 06:29 |
rakhmerov | so I'm just thinking | 06:29 |
rakhmerov | to me it's OK to merge it now and address later, or you can include additional stuff into it | 06:30 |
rakhmerov | what do you say? | 06:30 |
hparekh | rakhmerov, yeah I have added some TODO in commit message | 06:31 |
hparekh | rakhmerov, I agree with use identifier in load_xxx methods | 06:31 |
rakhmerov | and we need unit tests for DB API | 06:31 |
rakhmerov | DB API changes | 06:31 |
hparekh | rakhmerov, yeah | 06:31 |
rakhmerov | so? your opinion? | 06:31 |
hparekh | rakhmerov, I will add tests and todo items in another patches | 06:32 |
rakhmerov | ok, then I will merge it now | 06:32 |
rakhmerov | it's been on review for too long | 06:32 |
hparekh | rakhmerov, Ok thanks | 06:32 |
hparekh | yes patches are blocked | 06:32 |
rakhmerov | ok, done | 06:33 |
openstackgerrit | Merged openstack/mistral: Allow to use both name and id to access action definitions https://review.openstack.org/325894 | 06:41 |
*** toddjohn has joined #openstack-mistral | 07:16 | |
*** toddjohn has quit IRC | 07:22 | |
*** Ravikiran_K has quit IRC | 07:31 | |
rakhmerov | ddeja: hi | 07:34 |
*** d0ugal has quit IRC | 07:37 | |
*** jpich has joined #openstack-mistral | 07:47 | |
rakhmerov | hparekh: can you also review Dawid's patches pls? They are pretty simple | 07:47 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add the new endpoint /v2/tasks/<id>/workflow_executions https://review.openstack.org/344167 | 07:52 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Move the remainder of REST resources to resources.py https://review.openstack.org/344569 | 07:52 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Move REST resources action, action execution and task to resources.py https://review.openstack.org/344228 | 07:52 |
*** shardy has joined #openstack-mistral | 07:59 | |
rakhmerov | ddeja: I have some questions about the new RPC | 08:01 |
rakhmerov | 1) how does our kombu-based messaging behaves regarding timeouts? What numbers etc. | 08:01 |
rakhmerov | 2) Did you have a chance to do some comparisons with o.m.? | 08:02 |
*** brunograz has joined #openstack-mistral | 08:06 | |
hparekh | rakhmerov, Yeah I will to it today. | 08:10 |
rakhmerov | thanks | 08:10 |
*** Ravikiran_K has joined #openstack-mistral | 08:38 | |
rakhmerov | guys, does anyone know about "WARNING oslo_db.sqlalchemy.utils [-] Id not in sort_keys; is sort_keys unique?" ? | 08:46 |
*** apsarshaik has joined #openstack-mistral | 08:46 | |
rakhmerov | ddeja, hparekh: ^ | 08:46 |
rakhmerov | I don't understand why Id should be in sort keys | 08:48 |
rakhmerov | what's the point? | 08:48 |
rakhmerov | it happens pretty much on any request, for example: mistral task-list <exec_id> | 08:48 |
therve | rakhmerov, You should always have the id in sort keys, so that you don't loop through results | 08:52 |
therve | That makes order stable | 08:52 |
rakhmerov | therve: can you give more details? What loop are you talking about? | 08:52 |
rakhmerov | we're just selecting rows from DB | 08:53 |
rakhmerov | maybe I'm missing something | 08:53 |
*** apsarshaik has quit IRC | 08:53 | |
therve | rakhmerov, If your order is not stable and you use the marker, you can get into a sorting loop because order is different | 08:53 |
therve | Let's say you have obj 1 2 3 4 | 08:53 |
therve | Limit 2 | 08:53 |
rakhmerov | ok | 08:53 |
therve | Your return 1 3 -> marker 3 | 08:53 |
therve | Then you return 2 1 -> oops, you'll get an object you already got | 08:54 |
therve | Having id in the sort keys make sure the order is always the same | 08:54 |
rakhmerov | ooh, you're talking about paginated queries | 08:54 |
rakhmerov | I see now | 08:54 |
therve | Yes | 08:54 |
rakhmerov | yeah, fair enough | 08:54 |
therve | That warning is displayed by the paginated_query helper | 08:54 |
rakhmerov | therve: thanks a lot, this is helpful | 08:54 |
rakhmerov | yep, got it | 08:55 |
therve | You're welcome | 08:55 |
*** apsarshaik has joined #openstack-mistral | 08:55 | |
rakhmerov | therve: just for my info, you're a member of oslo.db? | 08:55 |
therve | rakhmerov, Nope | 08:55 |
rakhmerov | what do you work on? | 08:55 |
rakhmerov | if it's not a secret ) | 08:55 |
therve | Heat mostly :) | 08:55 |
rakhmerov | alright | 08:55 |
rakhmerov | thanks again | 08:55 |
openstackgerrit | Merged openstack/python-mistralclient: Change action-get help to get action info by ID https://review.openstack.org/325921 | 09:05 |
openstackgerrit | Merged openstack/python-mistralclient: Changed argument names as per other python clients https://review.openstack.org/330958 | 09:05 |
rakhmerov | therve: so if both marker and limit are not specified (None) then it's ok to not include id in sort keys, right? | 09:08 |
rakhmerov | it makes sense to include it only if we limit a query set | 09:08 |
*** d0ugal has joined #openstack-mistral | 09:10 | |
therve | rakhmerov, I guess. But then there is no point in using paginated_query? | 09:16 |
therve | You probably always want a limit | 09:16 |
rakhmerov | hm.. | 09:16 |
rakhmerov | agree | 09:16 |
*** toddjohn has joined #openstack-mistral | 09:19 | |
*** d0ugal has quit IRC | 09:22 | |
*** toddjohn has quit IRC | 09:23 | |
*** d0ugal has joined #openstack-mistral | 09:29 | |
*** Ravikiran_K has quit IRC | 09:32 | |
ddeja | rakhmerov: Hi. Sorry for being late today. Anwsering your questions: 1) There is fixed timeout for 180s (it should be changed to conf option). It's the time the sender would wait for response from receiver. | 09:39 |
ddeja | 2) What kind of comparison do you mean? | 09:39 |
ddeja | I'm testing stability, but I don't have any performance tests | 09:40 |
rakhmerov | ddeja: on 1) Please do it as soon as your schedule allows | 09:41 |
rakhmerov | it's important | 09:41 |
rakhmerov | on 2) What works faster now? | 09:41 |
ddeja | well, I'm only testing it on devstack. And it make no difference in such environment | 09:42 |
ddeja | I can do some testing on more 'producton-like' setup in August/September | 09:43 |
ddeja | and maybe there would be some differnce | 09:44 |
rakhmerov | ok | 09:44 |
rakhmerov | most likely I will test it myself soon | 09:44 |
rakhmerov | ok, thanks | 09:44 |
*** apsarshaik has quit IRC | 09:46 | |
*** apsarshaik has joined #openstack-mistral | 09:47 | |
*** d0ugal has quit IRC | 09:56 | |
*** aspiers has quit IRC | 09:58 | |
*** d0ugal has joined #openstack-mistral | 10:02 | |
*** d0ugal has quit IRC | 10:03 | |
*** d0ugal has joined #openstack-mistral | 10:04 | |
*** akuznetsova has quit IRC | 10:07 | |
*** igormarnat has quit IRC | 10:08 | |
*** rakhmerov has quit IRC | 10:09 | |
*** aspiers has joined #openstack-mistral | 10:11 | |
*** akuznetsova has joined #openstack-mistral | 10:16 | |
hparekh | ddeja, I have gone through your patches but think we need more tests. | 10:20 |
*** akuznetsova has quit IRC | 10:20 | |
hparekh | I am talking about three pacthes regarding https://review.openstack.org/#/c/343789/1 | 10:21 |
hparekh | ddeja, Are you planning to add more tests ? | 10:21 |
ddeja | hparekh: well yes. But to test it properly it requiers to run two executors, I don't see if it can be tested using unit-tests | 10:23 |
ddeja | of course, if you see some part that can be tested using only UT I'll write them | 10:25 |
*** akuznetsova has joined #openstack-mistral | 10:26 | |
ddeja | OK, I thought about it for a while and yes, there is a way to test it using mock | 10:26 |
hparekh | ddeja, well yeah. I have no issue to merge it but we have to figure out if we can write tempest test for this or not | 10:27 |
hparekh | ddeja, Also please update the doc and add release note for the same | 10:27 |
*** rakhmerov has joined #openstack-mistral | 10:27 | |
ddeja | hparekh: I would say: we must add tempest test | 10:27 |
ddeja | but for now I'll add some UT, thanks for making me think about that | 10:28 |
ddeja | I've just got an idea how to write some | 10:28 |
ddeja | hparekh: about the docs: will do | 10:28 |
*** rakhmero_ has joined #openstack-mistral | 10:28 | |
hparekh | ddeja, Thanks :) | 10:29 |
*** d0ugal has quit IRC | 10:31 | |
rakhmero_ | ddeja: why is https://review.openstack.org/#/c/343791/ WIP now? | 10:31 |
*** igormarnat has joined #openstack-mistral | 10:33 | |
*** rakhmero_ is now known as rakhmerov_ | 10:33 | |
*** rakhmerov_ has quit IRC | 10:33 | |
*** rakhmero_ has joined #openstack-mistral | 10:34 | |
*** rakhmero_ has quit IRC | 10:34 | |
*** rakhmero_ has joined #openstack-mistral | 10:35 | |
*** jpich has quit IRC | 10:36 | |
openstackgerrit | Merged openstack/mistral: Add param 'safe-rerun' to task https://review.openstack.org/343789 | 10:37 |
openstackgerrit | Merged openstack/mistral: Pass 'safe-rerun' param to RPC layer https://review.openstack.org/343790 | 10:37 |
*** rakhmero_ has quit IRC | 10:39 | |
*** jpich has joined #openstack-mistral | 10:45 | |
ddeja | rakhmerov: due to discussion with hparekh - I'm adding tests to it | 10:49 |
*** aspiers has quit IRC | 10:52 | |
openstackgerrit | hardik proposed openstack/mistral: Added support for SSL connection in mistra-api server https://review.openstack.org/344598 | 11:05 |
*** aspiers has joined #openstack-mistral | 11:08 | |
openstackgerrit | hardik proposed openstack/mistral: Removed instruction 'python setup.py install' from guide https://review.openstack.org/345347 | 11:16 |
*** toddjohn has joined #openstack-mistral | 11:20 | |
openstackgerrit | hardik proposed openstack/python-mistralclient: Removed instruction 'python setup.py install' from README https://review.openstack.org/345351 | 11:24 |
*** toddjohn has quit IRC | 11:25 | |
*** Ravikiran_K has joined #openstack-mistral | 11:32 | |
*** dprince has joined #openstack-mistral | 11:45 | |
Ravikiran_K | Hi.. | 11:48 |
Ravikiran_K | how do we integrate Mistral with Murano? | 11:48 |
*** apsarshaik has quit IRC | 11:51 | |
*** apsarshaik has joined #openstack-mistral | 11:52 | |
*** d0ugal has joined #openstack-mistral | 12:12 | |
*** Ravikiran_K has quit IRC | 12:13 | |
*** apsarshaik has quit IRC | 12:19 | |
*** apsarshaik has joined #openstack-mistral | 12:21 | |
*** toddjohn has joined #openstack-mistral | 12:38 | |
*** bobh has joined #openstack-mistral | 12:43 | |
*** bobh has quit IRC | 13:00 | |
*** jpich has quit IRC | 13:12 | |
*** jpich has joined #openstack-mistral | 13:22 | |
openstackgerrit | Dawid Deja proposed openstack/mistral: Executor fails actions if they are redelivered https://review.openstack.org/343791 | 13:30 |
ddeja | rakhmerov, hparekh: new patches with extra unit tests, rest of the file is the same ^ | 13:33 |
*** rakhmero_ has joined #openstack-mistral | 13:39 | |
*** rakhmero_ is now known as rakhmerov_ | 13:40 | |
*** rakhmerov_ has quit IRC | 13:41 | |
rakhmerov | ddeja: ok | 13:42 |
rakhmerov | sorry, I had issues with my IRC so I may have missed some messages | 13:42 |
*** krotscheck_dcm is now known as krotscheck | 13:50 | |
*** Ravikiran_K has joined #openstack-mistral | 14:01 | |
*** bhaskar has joined #openstack-mistral | 14:04 | |
Ravikiran_K | Hi...i have a question, what is differences between Mistral and Murano? | 14:05 |
*** apsarshaik has quit IRC | 14:06 | |
Ravikiran_K | why Mistral is integrated with Murano? | 14:06 |
Ravikiran_K | i mean how do we use mistral with murano? | 14:07 |
rakhmerov | Ravikiran_K: completely different technologies | 14:07 |
rakhmerov | let me ask you first, what is your understanding of both? | 14:08 |
rakhmerov | from it I'll be able to explain | 14:08 |
rakhmerov | ddeja: here? | 14:08 |
rakhmerov | ddeja: oslo.messaging now switched to just one "transport_url" config option that includes all needed properties instead of individual properties | 14:09 |
rakhmerov | like connection string for DB | 14:09 |
rakhmerov | can we do the same with our Kombu impl? | 14:09 |
rakhmerov | it would be very convenient to switch between oslo and kombu just by changing rpc_backend | 14:10 |
Ravikiran_K | as for as my understanding Murano is a application deployment tool and mistral is a tool which manages workflows | 14:10 |
rakhmerov | Ravikiran_K: absolutely correct | 14:10 |
rakhmerov | if more detailed, Mistral has nothing to do with deployment directly | 14:11 |
rakhmerov | but it can be used for deployment, if needed | 14:11 |
rakhmerov | Mistral is a more generic tool that manages distributed workflows | 14:11 |
rakhmerov | Murano is a specific tool that helps manage complex environment deployments | 14:12 |
rakhmerov | where you can describe packages, dependencies between them etc. and build environments out of these packages | 14:12 |
rakhmerov | the confusion is usually about the term "workflow" | 14:13 |
rakhmerov | Murano also has this term but IMO it's a misleading thing in Murano | 14:13 |
rakhmerov | in Murano they mean a completely different thing by "workflow" | 14:13 |
rakhmerov | in Murano it's basically a script that allows to customize application deployment | 14:14 |
rakhmerov | whereas Mistral manages distributed stateful workflows | 14:15 |
rakhmerov | graph of tasks | 14:15 |
rakhmerov | Ravikiran_K: does that make sense? :) | 14:15 |
rakhmerov | feel free to ask | 14:15 |
Ravikiran_K | rakhmerov: It is more clear to me now, but there are few more questions | 14:17 |
rakhmerov | sure | 14:17 |
Ravikiran_K | mistral is integrated in murano..how do we do deployments with mistral using Murano? | 14:18 |
*** vishwanathj_zzz is now known as vishwanathj | 14:19 | |
rakhmerov | well, basically this integration just allows to run Mistral workflows from Murano PL (programming language) | 14:20 |
rakhmerov | that's it | 14:20 |
rakhmerov | so, for example | 14:20 |
rakhmerov | you can create a Murano application and it's Murano PL module that deploys the app you can say "run this Mistral workflow after the app is deployed" | 14:21 |
rakhmerov | e.g. for monitoring | 14:21 |
rakhmerov | or health checking, or auto-scaling | 14:21 |
rakhmerov | etc. | 14:21 |
rakhmerov | essentially for any life-cycle management or post-installation stuff | 14:22 |
ddeja | rakhmerov: I guess that this should be possible, but first need to check how the oslo url looks like. | 14:25 |
rakhmerov | ddeja: transport_url = rabbit://guest:guest@localhost:5672/ | 14:26 |
Ravikiran_K | rakhmerov: you are amazing. It's clear to me now. I really like the way you explain | 14:26 |
rakhmerov | where "/" at the end means an empty virtual host | 14:26 |
Ravikiran_K | i will keep bugging you if i have any questions :) | 14:27 |
rakhmerov | Ravikiran_K: no problem man ) Come visit us more often | 14:27 |
rakhmerov | sure | 14:27 |
Ravikiran_K | rakhmerov: Thank you | 14:27 |
rakhmerov | ddeja: this works for me, I checked | 14:28 |
openstackgerrit | Jeff Peeler proposed openstack/mistral: Allow external access to cached clients https://review.openstack.org/345069 | 14:28 |
rakhmerov | I guess we can even use some o.m utils to parse options from this kind of string | 14:28 |
ddeja | It seems that this URL have all of required information, I'll submit patch | 14:30 |
rakhmerov | ddeja: yeah, it would be cool | 14:31 |
rakhmerov | thanks | 14:31 |
*** bhaskar has quit IRC | 14:51 | |
*** rrecio has joined #openstack-mistral | 14:52 | |
*** Ravikiran_K has quit IRC | 14:54 | |
*** rrecio_ has joined #openstack-mistral | 14:54 | |
*** rrecio has quit IRC | 14:57 | |
*** d0ugal has quit IRC | 15:02 | |
*** d0ugal has joined #openstack-mistral | 15:05 | |
*** apsarshaik has joined #openstack-mistral | 15:13 | |
*** apsarshaik has quit IRC | 15:17 | |
*** rrecio_ has quit IRC | 15:17 | |
*** apsarshaik has joined #openstack-mistral | 15:17 | |
*** rrecio has joined #openstack-mistral | 15:30 | |
*** FL1SK has quit IRC | 15:37 | |
*** apsarshaik has quit IRC | 15:46 | |
*** apsarshaik has joined #openstack-mistral | 15:46 | |
*** d0ugal has quit IRC | 16:04 | |
*** jpich has quit IRC | 16:32 | |
*** bobh has joined #openstack-mistral | 16:39 | |
*** d0ugal has joined #openstack-mistral | 16:45 | |
*** vishwanathj has quit IRC | 16:47 | |
*** harlowja has joined #openstack-mistral | 17:44 | |
*** clenimar has quit IRC | 17:45 | |
*** FL1SK has joined #openstack-mistral | 17:46 | |
*** clenimar has joined #openstack-mistral | 18:12 | |
*** catintheroof has quit IRC | 18:25 | |
*** harlowja has quit IRC | 18:35 | |
*** harlowja has joined #openstack-mistral | 18:38 | |
*** harlowja has quit IRC | 18:59 | |
*** bobh has quit IRC | 19:00 | |
*** ramishra has quit IRC | 19:36 | |
*** ramishra has joined #openstack-mistral | 19:37 | |
*** vishwanathj has joined #openstack-mistral | 19:37 | |
*** shardy has quit IRC | 19:45 | |
*** apsarshaik has quit IRC | 20:03 | |
*** apsarshaik has joined #openstack-mistral | 20:06 | |
*** shardy has joined #openstack-mistral | 20:12 | |
*** harlowja has joined #openstack-mistral | 20:39 | |
*** dprince has quit IRC | 20:44 | |
*** bobh has joined #openstack-mistral | 21:05 | |
*** tonytan4ever has quit IRC | 21:06 | |
*** tonytan4ever has joined #openstack-mistral | 21:08 | |
*** shardy has quit IRC | 21:39 | |
openstackgerrit | Jeff Peeler proposed openstack/mistral: Allow external access to cached clients https://review.openstack.org/345069 | 21:41 |
*** harlowja has quit IRC | 21:41 | |
*** clenimar has quit IRC | 21:47 | |
*** harlowja has joined #openstack-mistral | 21:48 | |
*** harlowja has quit IRC | 21:48 | |
*** clenimar has joined #openstack-mistral | 22:02 | |
*** bobh has quit IRC | 22:06 | |
*** rrecio has quit IRC | 22:43 | |
*** Kiall has quit IRC | 22:43 | |
*** bobh has joined #openstack-mistral | 23:22 | |
*** bobh has quit IRC | 23:29 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!