*** toddjohn has joined #openstack-mistral | 00:07 | |
*** toddjohn_ has joined #openstack-mistral | 00:29 | |
*** toddjohn has quit IRC | 00:30 | |
*** toddjohn has joined #openstack-mistral | 00:33 | |
*** toddjohn_ has quit IRC | 00:35 | |
*** toddjohn has quit IRC | 00:44 | |
*** toddjohn has joined #openstack-mistral | 00:46 | |
*** toddjohn has quit IRC | 00:51 | |
*** cheneydc has joined #openstack-mistral | 00:57 | |
*** cheneydc has quit IRC | 01:02 | |
*** harlowja has joined #openstack-mistral | 01:37 | |
*** bobh has joined #openstack-mistral | 02:00 | |
*** cheneydc has joined #openstack-mistral | 03:02 | |
*** cheneydc has quit IRC | 03:06 | |
*** bobh has quit IRC | 03:21 | |
*** bobh has joined #openstack-mistral | 03:28 | |
*** bobh has quit IRC | 03:36 | |
openstackgerrit | Merged openstack/mistral: Initialize RPC-related flag when starting API https://review.openstack.org/344152 | 04:27 |
---|---|---|
*** bobh has joined #openstack-mistral | 04:37 | |
*** bobh has quit IRC | 04:42 | |
*** d0ugal has quit IRC | 04:46 | |
*** d0ugal has joined #openstack-mistral | 04:47 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Move REST resources action, action execution and task to resources.py https://review.openstack.org/344228 | 04:51 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Move the remainder of REST resources to resources.py https://review.openstack.org/344569 | 05:26 |
*** d0ugal has quit IRC | 05:58 | |
*** toddjohn has joined #openstack-mistral | 06:06 | |
*** toddjohn has quit IRC | 06:11 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Move the remainder of REST resources to resources.py https://review.openstack.org/344569 | 06:31 |
*** vishwanathj has quit IRC | 06:33 | |
*** bobh has joined #openstack-mistral | 06:39 | |
*** d0ugal has joined #openstack-mistral | 06:42 | |
*** bobh has quit IRC | 06:45 | |
*** d0ugal has quit IRC | 06:51 | |
*** d0ugal has joined #openstack-mistral | 07:08 | |
*** Ravikiran_K has joined #openstack-mistral | 07:12 | |
*** shardy has joined #openstack-mistral | 07:27 | |
*** jpich has joined #openstack-mistral | 07:28 | |
openstackgerrit | hardik proposed openstack/mistral: [WIP] Added support for SSL connection in mistra-api server https://review.openstack.org/344598 | 07:32 |
*** d0ugal has quit IRC | 07:46 | |
ddeja | rakhmerov, kong, hparekh: Can you guys take a look at these in a free time? It's chain of 4 small patches, so not a lot of to review :) thanks in advance https://review.openstack.org/#/c/343788/ | 07:50 |
*** d0ugal has joined #openstack-mistral | 08:05 | |
rakhmerov | ddeja: coincidentally, I'm looking at them now | 09:15 |
rakhmerov | ddeja: pls remove two TODO's in https://review.openstack.org/#/c/343790 | 09:15 |
rakhmerov | I left comments | 09:15 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add the new endpoint /v2/tasks/<id>/workflow_executions https://review.openstack.org/344167 | 09:38 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Move the remainder of REST resources to resources.py https://review.openstack.org/344569 | 09:38 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Move REST resources action, action execution and task to resources.py https://review.openstack.org/344228 | 09:38 |
rakhmerov | ddeja: please also abandon patches that you don't need anymore | 09:39 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Executor fails actions if they are redelivered https://review.openstack.org/343791 | 09:47 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Pass 'safe-rerun' param to RPC layer https://review.openstack.org/343790 | 09:47 |
ddeja | rakhmerov: done | 09:50 |
rakhmerov | ok | 09:52 |
rakhmerov | ddeja: pls look at the last comment from OpenStack Env in https://review.openstack.org/#/c/343790 | 09:55 |
rakhmerov | I'm not sure what this is but probably you need to rebase the sequence | 09:55 |
ddeja | rakhmerov: I'm not sure why. This is the first time I see such comments. But of course, I can rebase them | 09:56 |
rakhmerov | me too, I've never seen this before | 09:57 |
rakhmerov | looks weird | 09:57 |
ddeja | usually Jenkins gives such comments? | 09:57 |
rakhmerov | I didn't see it before, I don't know | 09:57 |
ddeja | hmm, there is problem | 09:58 |
ddeja | git rebase origin | 09:58 |
ddeja | Current branch bp/mistral-task-delivery-model is up to date. | 09:58 |
rakhmerov | it looks like something is wrong with test environment where Jenkins runs a job | 09:58 |
ddeja | yes | 09:58 |
ddeja | and I don't have any -1 on my patch | 09:59 |
rakhmerov | it merges a patch to some temporary branch probably (dunno exactly) and this merge fails | 09:59 |
ddeja | maybe we can wait for jenskins, or try recheck? | 09:59 |
rakhmerov | as if something wasn't atomic in this process and something squeezed in between | 09:59 |
rakhmerov | yeah, try to recheck | 09:59 |
ddeja | done, waiting for Jenkins | 10:01 |
rakhmerov | ok | 10:02 |
rakhmerov | ddeja: I also replied in https://review.openstack.org/#/c/344569/ | 10:02 |
rakhmerov | not sure if you will agree | 10:02 |
rakhmerov | but read it pls | 10:02 |
ddeja | rakhmerov: I've left +1 | 10:06 |
rakhmerov | thanks! ) | 10:07 |
openstackgerrit | hardik proposed openstack/mistral: [WIP] Added support for SSL connection in mistra-api server https://review.openstack.org/344598 | 10:28 |
*** d0ugal has quit IRC | 10:31 | |
rakhmerov | ddeja: one guy is complaining on mitaka branch still | 10:33 |
rakhmerov | with error: | 10:34 |
rakhmerov | File "/usr/local/lib/python2.7/dist-packages/mistral/engine/rpc.py", line 44, in <module> | 10:34 |
rakhmerov | dispatcher.RPCDispatcher.__call__ | 10:34 |
rakhmerov | File "/usr/lib/python2.7/inspect.py", line 816, in getargspec | 10:34 |
rakhmerov | raise TypeError('{!r} is not a Python function'.format(func)) | 10:34 |
rakhmerov | TypeError: <method-wrapper '__call__' of ABCMeta object at 0x2b2bf60> is not a | 10:34 |
rakhmerov | once you find some time could you please check it? | 10:34 |
rakhmerov | I thought we fixed it | 10:34 |
ddeja | rakhmerov: well, this patch is still there | 10:55 |
ddeja | despite we decided to delete it also from mitaka branch | 10:55 |
rakhmerov | what patch? | 10:56 |
rakhmerov | sorry, I may not remember | 10:56 |
rakhmerov | we decided to delete the hack in rpc.py, right? | 10:56 |
ddeja | yes | 10:56 |
rakhmerov | but I don't remember if we actually did this | 10:57 |
ddeja | it looks like we didn't | 10:57 |
rakhmerov | ooh! | 10:57 |
ddeja | we just decided to do so | 10:57 |
rakhmerov | shoot.. | 10:57 |
rakhmerov | can you please take care of this? | 10:57 |
ddeja | yup | 10:58 |
rakhmerov | appreciate | 11:00 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Error handling test: error in 'publish' for a task with 'on-error' https://review.openstack.org/344748 | 11:00 |
*** shardy has quit IRC | 11:18 | |
ddeja | rakhmerov: backport created https://review.openstack.org/#/c/344771/ | 11:39 |
rakhmerov | thanks a lot Dawid | 11:39 |
ddeja | no problem | 11:40 |
ddeja | rakhmerov: about https://review.openstack.org/#/c/344748/1 | 11:45 |
ddeja | I'm not sure if I understand correctly | 11:45 |
rakhmerov | yes | 11:45 |
rakhmerov | ask ) | 11:45 |
ddeja | but task3 wouldn't be run because an error occured during the publish, not in action execution, right? | 11:46 |
rakhmerov | correct | 11:46 |
ddeja | and whole workflows is in error state? | 11:46 |
rakhmerov | I was just investigating something for Nokia and thought this doesn't work correctly | 11:46 |
rakhmerov | and decided to write a test | 11:46 |
ddeja | OK | 11:46 |
rakhmerov | yes, sure | 11:46 |
rakhmerov | because we can't continue the workflow | 11:47 |
rakhmerov | we need to notify that something is wrong | 11:47 |
rakhmerov | drill down from workflow to task | 11:47 |
rakhmerov | and see it's state and state_info | 11:47 |
rakhmerov | then possibly we can fix the environment and re-run from this task | 11:48 |
ddeja | OK, I see | 11:49 |
ddeja | so I have one comment to your Note, but I'm OK with the change | 11:49 |
rakhmerov | I know it can be a little tricky, it's more about conventions we have rather than trying to find what is "right" | 11:49 |
ddeja | yes, I know | 11:50 |
rakhmerov | guys, a small question | 11:51 |
rakhmerov | I'm installing mistral client with "sudo python3 setup.py install" and osc-lib doesn't get installed automatically | 11:51 |
rakhmerov | it gets installed only when I run "sudo pip3 install -r requirements.txt" | 11:52 |
rakhmerov | any guesses why it happens? | 11:52 |
rakhmerov | something is wrong with our setup files? | 11:52 |
rakhmerov | hparekh, ddeja: ^ | 11:54 |
hparekh | rakhmerov, I think setup.py will not install any dependency | 11:57 |
hparekh | if you do pip install . then it will install all dependency | 11:57 |
rakhmerov | hm.. Ok, for some reason I thought it should | 11:58 |
rakhmerov | I probably forgot ) | 11:58 |
rakhmerov | thanks | 11:58 |
rakhmerov | hparekh: then our README file is wrong | 11:59 |
rakhmerov | we need to fix it | 11:59 |
hparekh | rakhmerov, yeah ok I will take care of it :) | 12:00 |
rakhmerov | :) | 12:00 |
rakhmerov | thx | 12:00 |
rakhmerov | I actually misled a couple of people today already ) | 12:00 |
rakhmerov | will have to apologize | 12:01 |
rakhmerov | hparekh: btw, when you'll be fixing README in python-mistralclient make it RST file please | 12:01 |
rakhmerov | it's still .md | 12:01 |
hparekh | rakhmerov, ok sure | 12:02 |
rakhmerov | hah! | 12:02 |
rakhmerov | in mistral repo README tells the same :) | 12:02 |
rakhmerov | just "python setup.py install" | 12:02 |
rakhmerov | oh my gosh.. | 12:02 |
openstackgerrit | hardik proposed openstack/mistral: Allow to use both name and id to access action definitions https://review.openstack.org/325894 | 12:03 |
rakhmerov | there must have been a bunch of people who stumbled on it | 12:03 |
rakhmerov | and decided that Mistral didn't work at all | 12:03 |
*** d0ugal has joined #openstack-mistral | 12:04 | |
rakhmerov | hparekh: and the same in the installation guide ) | 12:05 |
*** dprince has joined #openstack-mistral | 12:07 | |
hparekh | rakhmerov, ok. I fixed https://review.openstack.org/#/c/325894/ and made some changes . I would like you to review mistral/db/v2/sqlalchemy/api.py file specially | 12:07 |
rakhmerov | hparekh: I will do | 12:07 |
rakhmerov | thanks a lot | 12:07 |
hparekh | rakhmerov, No need to mention :) | 12:08 |
rakhmerov | yeah, I know it was the trickiest place ) | 12:08 |
rakhmerov | hparekh: pep8 again failed | 12:22 |
hparekh | rakhmerov, looking | 12:23 |
rakhmerov | ok | 12:23 |
*** rbrady has joined #openstack-mistral | 12:27 | |
*** d0ugal has quit IRC | 13:14 | |
*** d0ugal has joined #openstack-mistral | 13:43 | |
*** toddjohn has joined #openstack-mistral | 13:49 | |
*** tonytan4ever has joined #openstack-mistral | 13:58 | |
*** shardy has joined #openstack-mistral | 14:03 | |
hparekh | rakhmerov, http://logs.openstack.org/94/325894/18/check/gate-mistral-pep8/f4d86fc/console.html#_2016-07-20_12_11_42_354676 it is showing uuidutils is unused | 14:04 |
hparekh | rakhmerov, But it is used in _get_associated_cron_triggers function of mistral/db/v2/sqlalchemy/api.py file | 14:04 |
hparekh | I don't get whu gate is failing it is getting pass in my local environment | 14:05 |
hparekh | I am leaving for today will look into it | 14:05 |
*** bobh has joined #openstack-mistral | 14:18 | |
*** vishwanathj has joined #openstack-mistral | 14:27 | |
*** d0ugal has quit IRC | 14:33 | |
*** shardy is now known as shardy_mtg | 14:35 | |
*** tonytan_brb has joined #openstack-mistral | 14:38 | |
*** jistr is now known as jistr|mtg | 14:39 | |
*** tonytan4ever has quit IRC | 14:40 | |
*** d0ugal has joined #openstack-mistral | 14:41 | |
*** bobh has quit IRC | 14:54 | |
*** shaikapsar has joined #openstack-mistral | 15:08 | |
openstackgerrit | Merged openstack/mistral: Create MistralContext from rpc context in kombu engine https://review.openstack.org/343788 | 15:15 |
*** rrecio has joined #openstack-mistral | 15:24 | |
*** krotscheck is now known as krotscheck_dcm | 15:30 | |
*** apsarshaik has joined #openstack-mistral | 15:32 | |
*** shaikapsar has quit IRC | 15:33 | |
*** dprince has quit IRC | 15:47 | |
*** jistr|mtg is now known as jistr | 15:48 | |
*** dprince has joined #openstack-mistral | 15:51 | |
*** harlowja has quit IRC | 15:52 | |
*** d0ugal has quit IRC | 16:07 | |
*** dprince has quit IRC | 16:27 | |
*** shardy_mtg has quit IRC | 16:27 | |
*** bobh has joined #openstack-mistral | 16:32 | |
*** jpich has quit IRC | 16:35 | |
*** jtomasek has quit IRC | 16:38 | |
*** harlowja has joined #openstack-mistral | 16:40 | |
*** bobh has quit IRC | 16:40 | |
*** vishwanathj has quit IRC | 16:44 | |
*** d0ugal has joined #openstack-mistral | 16:48 | |
openstackgerrit | hardik proposed openstack/mistral: Allow to use both name and id to access action definitions https://review.openstack.org/325894 | 17:30 |
*** jtomasek has joined #openstack-mistral | 17:31 | |
*** apsarshaik has quit IRC | 17:51 | |
*** apsarshaik has joined #openstack-mistral | 17:52 | |
*** dprince has joined #openstack-mistral | 18:02 | |
*** toddjohn has quit IRC | 18:08 | |
*** toddjohn has joined #openstack-mistral | 18:09 | |
*** toddjohn_ has joined #openstack-mistral | 18:10 | |
*** toddjohn has quit IRC | 18:13 | |
*** harlowja has quit IRC | 18:19 | |
*** tonytan_brb is now known as tonytan4ever | 18:22 | |
*** toddjohn_ has quit IRC | 18:36 | |
*** toddjohn has joined #openstack-mistral | 18:37 | |
*** rakhmerov has quit IRC | 18:38 | |
*** akuznetsova has quit IRC | 18:38 | |
*** igormarnat has quit IRC | 18:39 | |
*** kzaitsev_ws has quit IRC | 18:39 | |
*** Ravikiran_K has quit IRC | 18:46 | |
*** vishwanathj has joined #openstack-mistral | 18:52 | |
*** harlowja has joined #openstack-mistral | 19:19 | |
*** ramishra has quit IRC | 19:35 | |
*** harlowja has quit IRC | 19:36 | |
*** ramishra has joined #openstack-mistral | 19:36 | |
*** akuznetsova has joined #openstack-mistral | 19:40 | |
*** rakhmerov has joined #openstack-mistral | 19:41 | |
*** igormarnat has joined #openstack-mistral | 19:46 | |
*** toddjohn has quit IRC | 19:50 | |
*** dprince has quit IRC | 20:13 | |
*** toddjohn has joined #openstack-mistral | 20:24 | |
*** gyee has joined #openstack-mistral | 21:00 | |
*** toddjohn has quit IRC | 21:11 | |
*** gyee has quit IRC | 21:22 | |
*** gyee has joined #openstack-mistral | 21:26 | |
*** apsarshaik has quit IRC | 22:01 | |
openstackgerrit | Jeff Peeler proposed openstack/mistral: Allow external access to cached clients https://review.openstack.org/345069 | 22:01 |
*** apsarshaik has joined #openstack-mistral | 22:03 | |
*** apsarshaik has quit IRC | 22:10 | |
*** apsarshaik has joined #openstack-mistral | 22:11 | |
*** harlowja has joined #openstack-mistral | 22:11 | |
*** harlowja has quit IRC | 22:11 | |
*** catintheroof has joined #openstack-mistral | 22:52 | |
*** harlowja has joined #openstack-mistral | 23:00 | |
*** harlowja has quit IRC | 23:03 | |
*** harlowja has joined #openstack-mistral | 23:07 | |
*** harlowja has quit IRC | 23:12 | |
*** toddjohn has joined #openstack-mistral | 23:31 | |
*** rrecio has quit IRC | 23:32 | |
*** toddjohn has quit IRC | 23:37 | |
*** toddjohn has joined #openstack-mistral | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!