| *** bobh has joined #openstack-mistral | 00:32 | |
| *** toddjohn has joined #openstack-mistral | 00:36 | |
| *** rrecio has joined #openstack-mistral | 00:49 | |
| *** rrecio_ has joined #openstack-mistral | 00:50 | |
| *** toddjohn has quit IRC | 00:50 | |
| *** toddjohn has joined #openstack-mistral | 00:51 | |
| *** rrecio has quit IRC | 00:54 | |
| *** toddjohn has quit IRC | 00:55 | |
| *** cheneydc has joined #openstack-mistral | 01:02 | |
| *** cheneydc has quit IRC | 01:08 | |
| *** rrecio_ has quit IRC | 01:27 | |
| *** bobh has quit IRC | 02:06 | |
| *** bobh has joined #openstack-mistral | 03:07 | |
| *** bobh has quit IRC | 03:12 | |
| *** bobh has joined #openstack-mistral | 04:08 | |
| *** bobh has quit IRC | 04:14 | |
| rakhmerov | reznick_: works | 04:15 |
|---|---|---|
| openstackgerrit | Merged openstack/mistral-extra: Updated from global requirements https://review.openstack.org/339902 | 04:23 |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/339901 | 04:26 |
| rakhmerov | hparekh, nmakhotkin: guys, can you please review https://review.openstack.org/#/c/339401 and https://review.openstack.org/#/c/339413 ? | 04:54 |
| rakhmerov | and other patches too :) | 04:54 |
| rakhmerov | we will be releasing this week so I'd like to ask you to review more actively in the next several days | 04:55 |
| rakhmerov | kong: ^^ including you too | 04:55 |
| *** vishwanathj has joined #openstack-mistral | 05:02 | |
| *** vishwanathj has quit IRC | 05:03 | |
| rakhmerov | ddeja: hi Dawid, how are you? | 05:04 |
| rakhmerov | ddeja: could you pls address few more comments in https://review.openstack.org/#/c/336548/4 ? | 05:04 |
| rakhmerov | so that it really shines :) | 05:05 |
| rakhmerov | akuznetsova, nmakhotkin, kong, hparekh: guys, very simple patch https://review.openstack.org/#/c/339364/, pls review | 05:07 |
| rakhmerov | mflobo: hi Marcos, could you please address some comments in https://review.openstack.org/#/c/325894/? | 05:09 |
| rakhmerov | ideally today | 05:09 |
| rakhmerov | the patch does what's needed but I'd like to polish it a little bit more | 05:09 |
| *** bobh has joined #openstack-mistral | 05:10 | |
| *** bobh has quit IRC | 05:15 | |
| openstackgerrit | Merged openstack/mistral: Add proper error handling for task continuation https://review.openstack.org/339401 | 05:52 |
| *** bobh has joined #openstack-mistral | 06:34 | |
| mflobo | rakhmerov, I'll do it today. Thanks for reviewing! | 06:38 |
| rakhmerov | ok | 06:38 |
| *** bobh has quit IRC | 06:38 | |
| *** Ravikiran_K has joined #openstack-mistral | 06:50 | |
| *** mgershen has joined #openstack-mistral | 07:17 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in RPC layer https://review.openstack.org/336548 | 07:27 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in Engine https://review.openstack.org/339113 | 07:27 |
| ddeja | rakhmerov: Hi, I'm fine, how you doing? | 07:27 |
| rakhmerov | ok too ) | 07:27 |
| ddeja | I've just addresed your comments | 07:27 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in RPC layer https://review.openstack.org/336548 | 07:31 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in Engine https://review.openstack.org/339113 | 07:31 |
| *** bobh has joined #openstack-mistral | 07:35 | |
| openstackgerrit | Merged openstack/mistral: Fix utility print_executions method https://review.openstack.org/339364 | 07:38 |
| *** jpich has joined #openstack-mistral | 07:39 | |
| *** bobh has quit IRC | 07:39 | |
| *** jtomasek has quit IRC | 07:52 | |
| rakhmerov | ddeja: ok, good | 07:53 |
| openstackgerrit | Merged openstack/mistral: Add tests for Kombu driver https://review.openstack.org/330483 | 07:53 |
| *** jistr has quit IRC | 08:06 | |
| *** jistr has joined #openstack-mistral | 08:07 | |
| *** ramishra has joined #openstack-mistral | 08:08 | |
| *** jistr has quit IRC | 08:11 | |
| *** jistr has joined #openstack-mistral | 08:11 | |
| *** shardy has joined #openstack-mistral | 08:14 | |
| rakhmerov | ddeja: I left just one small thing in https://review.openstack.org/#/c/339113/4 | 08:40 |
| rakhmerov | small comment | 08:40 |
| Ravikiran_K | join #Fuel | 08:58 |
| Ravikiran_K | srry wrong window | 08:58 |
| mflobo | rakhmerov, about this comment https://review.openstack.org/#/c/325894/13/mistral/db/v2/sqlalchemy/api.py@218 | 09:04 |
| rakhmerov | Ravikiran_K: ok | 09:05 |
| mflobo | rakhmerov, what you mean is mimic the "get_workflow_definition" implementation in "get_action_definition"? | 09:05 |
| mflobo | int that case, "_get_db_object_by_name_or_id" should desapear I guess | 09:05 |
| rakhmerov | mflobo: they still can be separate methods but using the same internal method. I mean _get_db_object_by_name_or_id() | 09:07 |
| rakhmerov | I just want it to be consistent | 09:08 |
| rakhmerov | having by_name_or_id in the name of internal method is OK I think | 09:08 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in RPC layer https://review.openstack.org/336548 | 09:32 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in Engine https://review.openstack.org/339113 | 09:32 |
| *** bobh has joined #openstack-mistral | 09:35 | |
| *** bobh has quit IRC | 09:40 | |
| *** Ravikiran_K has quit IRC | 09:57 | |
| openstackgerrit | Merged openstack/mistral: Add proper handling for implicit task completion https://review.openstack.org/339413 | 10:04 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral-specs: Fixing typos in Custom API spec https://review.openstack.org/340282 | 10:04 |
| *** bobh has joined #openstack-mistral | 10:36 | |
| *** bobh has quit IRC | 10:41 | |
| rakhmerov | ddeja: when do you think you'll send a patch for DSL changes related to "safe_rerun"? | 11:15 |
| rakhmerov | we'll be closing N-2 milestone this week, it would be great to get this task done till Wed | 11:16 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral-extra: Restructure mistral-extra repo https://review.openstack.org/340334 | 12:09 |
| mflobo | rakhmerov, about this comment https://review.openstack.org/#/c/325894/13/mistral/db/v2/api.py@168 | 12:11 |
| mflobo | "get_action_definition" already exists | 12:11 |
| mflobo | I cannot change "get_action_definition_by_name_or_id" by "get_action_definition" | 12:12 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral-extra: Restructure mistral-extra repo https://review.openstack.org/340334 | 12:12 |
| ddeja | rakhmerov: I'm working on it, I'll send patch today (hopefully before our team meeting) | 12:14 |
| rakhmerov | ok :) | 12:14 |
| rakhmerov | mflobo: why? | 12:14 |
| mflobo | rakhmerov, get_action_definition" already exists... line 164 | 12:15 |
| rakhmerov | mflobo: I think get_action_definition() should fetch object by "name or id", and we can just add a new method get_action_definition_by_name() which will do what get_action_definition() currently does | 12:15 |
| mflobo | rakhmerov, I think I understood | 12:16 |
| rakhmerov | yeah, just feel free to change all that stuff :) | 12:17 |
| rakhmerov | I'm just worried about inconsistencies all the time because if we let people commit then then it'll be very hard to fix it later | 12:17 |
| mflobo | I'm agree | 12:18 |
| rakhmerov | ok | 12:18 |
| rakhmerov | mflobo: feel free to ask anything you need | 12:18 |
| mflobo | rakhmerov, ok, thanks | 12:20 |
| *** dprince has joined #openstack-mistral | 12:53 | |
| openstackgerrit | Marcos Fermín Lobo proposed openstack/mistral: Allow to use both name and id to access action definitions https://review.openstack.org/325894 | 12:54 |
| *** bobh has joined #openstack-mistral | 13:00 | |
| *** rbrady has joined #openstack-mistral | 13:05 | |
| *** toddjohn has joined #openstack-mistral | 13:11 | |
| *** Ravikiran_K has joined #openstack-mistral | 13:39 | |
| *** rbrady has quit IRC | 13:51 | |
| *** vishwanathj has joined #openstack-mistral | 13:52 | |
| *** rbrady has joined #openstack-mistral | 13:55 | |
| *** tonytan4ever has joined #openstack-mistral | 14:07 | |
| openstackgerrit | Marcos Fermín Lobo proposed openstack/mistral: Allow to use both name and id to access action definitions https://review.openstack.org/325894 | 14:43 |
| *** bobh has quit IRC | 14:46 | |
| *** rbrady has quit IRC | 14:56 | |
| openstackgerrit | Shaik Apsar proposed openstack/mistral: Use task result to gather VM details https://review.openstack.org/340421 | 15:00 |
| *** rrecio has joined #openstack-mistral | 15:01 | |
| *** toddjohn has quit IRC | 15:04 | |
| *** rbrady has joined #openstack-mistral | 15:05 | |
| *** toddjohn has joined #openstack-mistral | 15:06 | |
| d0ugal | TripleO, as of today, is actually using Mistral in a couple of places now :) | 15:07 |
| d0ugal | (The work has been going for a while, and a number of changes had merged, but it is now the default and used in all CI runs) | 15:08 |
| ddeja | d0ugal: that's cool! | 15:19 |
| ddeja | You should share on mistral meeting :) | 15:20 |
| d0ugal | ddeja: Good idea :) | 15:24 |
| rbrady | d0ugal: do you happen to know what I would need to do to propose a new github repo for mistral-actions-api ? (e.g. https://github.com/openstack/mistral-actions-api) | 15:27 |
| d0ugal | rbrady: hrm, I've done this before but forget where exactly. I think you want to do it in project-config. It's all automated, so you do it via adding a gerrit review | 15:28 |
| d0ugal | rbrady: I think this is a topic for the meeting today btw. | 15:30 |
| d0ugal | rbrady: http://docs.openstack.org/infra/manual/creators.html | 15:30 |
| *** bobh has joined #openstack-mistral | 15:42 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Enable end user to use both delivery modes https://review.openstack.org/340450 | 15:50 |
| *** seanmurphy has joined #openstack-mistral | 16:01 | |
| *** bobh has quit IRC | 16:07 | |
| *** gyee has joined #openstack-mistral | 16:09 | |
| *** dprince has quit IRC | 16:11 | |
| *** jpich has quit IRC | 16:25 | |
| *** seanmurphy has quit IRC | 16:39 | |
| *** shaikapsar has joined #openstack-mistral | 16:40 | |
| shaikapsar | please review https://review.openstack.org/#/c/340421/ | 16:41 |
| *** toddjohn has quit IRC | 17:04 | |
| *** toddjohn has joined #openstack-mistral | 17:05 | |
| *** dprince has joined #openstack-mistral | 17:08 | |
| *** shaikapsar has quit IRC | 17:13 | |
| *** seanmurphy has joined #openstack-mistral | 17:28 | |
| *** toddjohn has quit IRC | 18:04 | |
| *** toddjohn has joined #openstack-mistral | 18:10 | |
| *** seanmurphy has quit IRC | 18:17 | |
| *** vishwanathj has quit IRC | 18:47 | |
| *** toddjohn has quit IRC | 19:04 | |
| *** toddjohn has joined #openstack-mistral | 19:08 | |
| *** tonytan4ever has quit IRC | 19:10 | |
| *** vishwanathj has joined #openstack-mistral | 19:58 | |
| *** toddjohn_ has joined #openstack-mistral | 20:04 | |
| *** vishwanathj has quit IRC | 20:04 | |
| *** toddjohn has quit IRC | 20:04 | |
| *** vishwanathj has joined #openstack-mistral | 20:05 | |
| *** dprince has quit IRC | 20:51 | |
| *** toddjohn_ has quit IRC | 20:52 | |
| *** toddjohn has joined #openstack-mistral | 20:53 | |
| *** jistr has quit IRC | 21:24 | |
| *** toddjohn has quit IRC | 21:26 | |
| *** toddjohn has joined #openstack-mistral | 21:26 | |
| *** toddjohn has quit IRC | 21:31 | |
| *** shardy has quit IRC | 21:44 | |
| *** vishwanathj has quit IRC | 22:00 | |
| *** toddjohn has joined #openstack-mistral | 22:27 | |
| *** toddjohn has quit IRC | 22:35 | |
| *** rrecio has quit IRC | 23:17 | |
| *** bobh has joined #openstack-mistral | 23:24 | |
| *** toddjohn has joined #openstack-mistral | 23:35 | |
| *** toddjohn has quit IRC | 23:40 | |
| *** bobh has quit IRC | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!