| *** sridhar_ram has joined #openstack-meeting-4 | 00:01 | |
| *** sarob has quit IRC | 00:03 | |
| *** sdake_ has joined #openstack-meeting-4 | 00:03 | |
| *** sridhar_ram1 has quit IRC | 00:03 | |
| *** sdake has quit IRC | 00:07 | |
| *** sarob has joined #openstack-meeting-4 | 00:12 | |
| *** emagana has quit IRC | 00:16 | |
| *** banix has quit IRC | 00:35 | |
| *** banix has joined #openstack-meeting-4 | 00:37 | |
| *** banix has quit IRC | 00:41 | |
| *** markvoelker has joined #openstack-meeting-4 | 00:50 | |
| *** markvoelker has quit IRC | 00:55 | |
| *** bharath has quit IRC | 00:56 | |
| *** bharath has joined #openstack-meeting-4 | 00:56 | |
| *** sarob has quit IRC | 00:57 | |
| *** SumitNaiksatam has joined #openstack-meeting-4 | 00:58 | |
| *** bharath has quit IRC | 01:01 | |
| *** banix has joined #openstack-meeting-4 | 01:05 | |
| *** krtaylor has quit IRC | 01:10 | |
| *** xingchao has joined #openstack-meeting-4 | 01:12 | |
| *** sridhar_ram has quit IRC | 01:13 | |
| *** vishwanathj has joined #openstack-meeting-4 | 01:14 | |
| *** sridhar_ram has joined #openstack-meeting-4 | 01:15 | |
| *** britthouser has quit IRC | 01:25 | |
| *** britthouser has joined #openstack-meeting-4 | 01:27 | |
| *** xingchao has quit IRC | 01:28 | |
| *** igordcard_ has quit IRC | 01:31 | |
| *** sdake_ has quit IRC | 01:40 | |
| *** s3wong has quit IRC | 01:41 | |
| *** sarob has joined #openstack-meeting-4 | 01:42 | |
| *** sarob has quit IRC | 01:46 | |
| *** krtaylor has joined #openstack-meeting-4 | 01:46 | |
| *** markvoelker has joined #openstack-meeting-4 | 01:51 | |
| *** carl_baldwin has joined #openstack-meeting-4 | 01:52 | |
| *** markvoelker has quit IRC | 01:56 | |
| *** sridhar_ram has quit IRC | 01:57 | |
| *** eghobo has quit IRC | 01:57 | |
| *** yamahata has quit IRC | 02:13 | |
| *** carl_baldwin has quit IRC | 02:26 | |
| *** markvoelker has joined #openstack-meeting-4 | 02:52 | |
| *** dannywilson has joined #openstack-meeting-4 | 02:56 | |
| *** markvoelker has quit IRC | 02:56 | |
| *** dims has quit IRC | 02:58 | |
| *** dannywilson has quit IRC | 03:00 | |
| *** sdake has joined #openstack-meeting-4 | 03:02 | |
| *** sdake_ has joined #openstack-meeting-4 | 03:06 | |
| *** dims has joined #openstack-meeting-4 | 03:07 | |
| *** dims_ has joined #openstack-meeting-4 | 03:08 | |
| *** ajmiller_ has joined #openstack-meeting-4 | 03:08 | |
| *** sdake has quit IRC | 03:09 | |
| *** dims has quit IRC | 03:12 | |
| *** ajmiller__ has quit IRC | 03:12 | |
| *** dims_ has quit IRC | 03:20 | |
| *** sdake has joined #openstack-meeting-4 | 03:21 | |
| *** sdake_ has quit IRC | 03:24 | |
| *** eghobo has joined #openstack-meeting-4 | 03:44 | |
| *** fnaval has quit IRC | 03:47 | |
| *** markvoelker has joined #openstack-meeting-4 | 03:53 | |
| *** markvoelker has quit IRC | 03:57 | |
| *** emagana has joined #openstack-meeting-4 | 03:57 | |
| *** banix has quit IRC | 03:59 | |
| *** sdake_ has joined #openstack-meeting-4 | 04:01 | |
| *** ajayaa has joined #openstack-meeting-4 | 04:05 | |
| *** sdake has quit IRC | 04:05 | |
| *** fnaval has joined #openstack-meeting-4 | 04:06 | |
| *** xingchao_ has joined #openstack-meeting-4 | 04:08 | |
| *** xingchao_ has quit IRC | 04:13 | |
| *** amotoki has joined #openstack-meeting-4 | 04:20 | |
| *** watanabe_isao has joined #openstack-meeting-4 | 04:29 | |
| *** bharath has joined #openstack-meeting-4 | 04:42 | |
| *** bharath has quit IRC | 04:46 | |
| *** markvoelker has joined #openstack-meeting-4 | 04:53 | |
| *** markvoelker has quit IRC | 04:58 | |
| *** xingchao_ has joined #openstack-meeting-4 | 05:10 | |
| *** ajayaa has quit IRC | 05:17 | |
| *** xingchao_ has quit IRC | 05:18 | |
| *** bobmel has quit IRC | 05:27 | |
| *** ajayaa has joined #openstack-meeting-4 | 05:30 | |
| *** sarob has joined #openstack-meeting-4 | 05:32 | |
| *** sdake has joined #openstack-meeting-4 | 05:43 | |
| *** sdake_ has quit IRC | 05:46 | |
| *** sarob has quit IRC | 05:47 | |
| *** markvoelker has joined #openstack-meeting-4 | 05:54 | |
| *** markvoelker has quit IRC | 05:58 | |
| *** eghobo_ has joined #openstack-meeting-4 | 06:11 | |
| *** numan has joined #openstack-meeting-4 | 06:14 | |
| *** eghobo has quit IRC | 06:15 | |
| *** xingchao_ has joined #openstack-meeting-4 | 06:18 | |
| *** ibiris_away is now known as ibiris | 06:19 | |
| *** xingchao_ has quit IRC | 06:23 | |
| *** yamahata has joined #openstack-meeting-4 | 06:25 | |
| *** eghobo has joined #openstack-meeting-4 | 06:28 | |
| *** numan has quit IRC | 06:28 | |
| *** kobis has joined #openstack-meeting-4 | 06:28 | |
| *** eghobo_ has quit IRC | 06:30 | |
| *** sarob has joined #openstack-meeting-4 | 06:49 | |
| *** numan has joined #openstack-meeting-4 | 06:53 | |
| *** sarob has quit IRC | 06:54 | |
| *** markvoelker has joined #openstack-meeting-4 | 06:55 | |
| *** markvoelker has quit IRC | 06:59 | |
| *** ibiris is now known as ibiris_away | 07:02 | |
| *** spredzy|afk is now known as spredzy | 07:05 | |
| *** eghobo has quit IRC | 07:08 | |
| *** xingchao_ has joined #openstack-meeting-4 | 07:20 | |
| *** bobmel has joined #openstack-meeting-4 | 07:23 | |
| *** fnaval has quit IRC | 07:24 | |
| *** mmedvede has quit IRC | 07:27 | |
| *** wojdev has joined #openstack-meeting-4 | 07:28 | |
| *** xingchao_ has quit IRC | 07:28 | |
| *** wojdev has quit IRC | 07:29 | |
| *** ibiris_away is now known as ibiris | 07:36 | |
| *** ibiris is now known as ibiris_away | 07:52 | |
| *** markvoelker has joined #openstack-meeting-4 | 07:56 | |
| *** markvoelker has quit IRC | 08:00 | |
| *** nihilifer has joined #openstack-meeting-4 | 08:01 | |
| *** matrohon has joined #openstack-meeting-4 | 08:02 | |
| *** mmedvede has joined #openstack-meeting-4 | 08:03 | |
| *** ibiris_away is now known as ibiris | 08:08 | |
| *** kobis has quit IRC | 08:25 | |
| *** kobis has joined #openstack-meeting-4 | 08:26 | |
| *** nihilifer has left #openstack-meeting-4 | 08:27 | |
| *** yamahata has quit IRC | 08:32 | |
| *** ibiris is now known as ibiris_away | 08:48 | |
| *** markvoelker has joined #openstack-meeting-4 | 08:56 | |
| *** markvoelker has quit IRC | 09:01 | |
| *** rushiagr_away is now known as rushiagr | 09:06 | |
| *** wznoinsk has joined #openstack-meeting-4 | 09:20 | |
| *** watanabe_isao has quit IRC | 09:21 | |
| *** dims has joined #openstack-meeting-4 | 09:29 | |
| *** dims has quit IRC | 09:35 | |
| *** markvoelker has joined #openstack-meeting-4 | 09:57 | |
| *** markvoelker has quit IRC | 10:02 | |
| *** numan has quit IRC | 10:15 | |
| *** xingchao_ has joined #openstack-meeting-4 | 10:35 | |
| *** xingchao_ has quit IRC | 10:43 | |
| *** markvoelker has joined #openstack-meeting-4 | 10:58 | |
| *** praveens has joined #openstack-meeting-4 | 10:59 | |
| *** markvoelker has quit IRC | 11:03 | |
| *** sdake_ has joined #openstack-meeting-4 | 11:03 | |
| *** sdake has quit IRC | 11:07 | |
| *** spredzy is now known as spredzy|afk | 11:16 | |
| *** praveens has quit IRC | 11:16 | |
| *** praveens has joined #openstack-meeting-4 | 11:18 | |
| *** ibiris_away is now known as ibiris | 11:25 | |
| *** amotoki has quit IRC | 11:38 | |
| *** ibiris is now known as ibiris_away | 11:41 | |
| *** numan has joined #openstack-meeting-4 | 11:42 | |
| *** xingchao_ has joined #openstack-meeting-4 | 11:42 | |
| *** xingchao_ has quit IRC | 11:48 | |
| *** ibiris_away is now known as ibiris | 11:56 | |
| *** markvoelker has joined #openstack-meeting-4 | 11:59 | |
| *** spredzy|afk is now known as spredzy | 12:03 | |
| *** markvoelker has quit IRC | 12:03 | |
| *** praveens has left #openstack-meeting-4 | 12:07 | |
| *** kobis has left #openstack-meeting-4 | 12:12 | |
| *** rfolco has joined #openstack-meeting-4 | 12:15 | |
| *** fesp has joined #openstack-meeting-4 | 12:18 | |
| *** fesp has quit IRC | 12:19 | |
| *** dims has joined #openstack-meeting-4 | 12:34 | |
| *** dims has quit IRC | 12:39 | |
| *** numan has quit IRC | 12:48 | |
| *** xingchao_ has joined #openstack-meeting-4 | 12:48 | |
| *** xingchao_ has quit IRC | 12:53 | |
| *** klamath has joined #openstack-meeting-4 | 12:59 | |
| *** klamath has quit IRC | 12:59 | |
| *** markvoelker has joined #openstack-meeting-4 | 12:59 | |
| *** klamath has joined #openstack-meeting-4 | 13:00 | |
| *** sarob has joined #openstack-meeting-4 | 13:01 | |
| *** numan has joined #openstack-meeting-4 | 13:02 | |
| *** markvoelker has quit IRC | 13:04 | |
| *** bknudson has joined #openstack-meeting-4 | 13:06 | |
| *** numan has quit IRC | 13:11 | |
| *** dims has joined #openstack-meeting-4 | 13:11 | |
| *** klamath has quit IRC | 13:15 | |
| *** numan has joined #openstack-meeting-4 | 13:23 | |
| *** ajayaa has quit IRC | 13:31 | |
| *** watanabe_isao has joined #openstack-meeting-4 | 13:32 | |
| *** dims has quit IRC | 13:36 | |
| *** markvoelker has joined #openstack-meeting-4 | 13:37 | |
| *** dims has joined #openstack-meeting-4 | 13:37 | |
| *** rushiagr is now known as rushiagr_away | 13:39 | |
| *** jckasper has joined #openstack-meeting-4 | 13:41 | |
| *** ajayaa has joined #openstack-meeting-4 | 13:48 | |
| *** sarob has quit IRC | 13:50 | |
| *** xingchao_ has joined #openstack-meeting-4 | 13:51 | |
| *** emagana has quit IRC | 13:51 | |
| *** VW_ has joined #openstack-meeting-4 | 13:54 | |
| *** aventerav has joined #openstack-meeting-4 | 13:55 | |
| *** richm has joined #openstack-meeting-4 | 13:57 | |
| *** xingchao_ has quit IRC | 13:59 | |
| *** yamahata has joined #openstack-meeting-4 | 14:02 | |
| *** carl_baldwin has joined #openstack-meeting-4 | 14:02 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:16 | |
| *** rushiagr_away is now known as rushiagr | 14:17 | |
| *** watanabe_isao has quit IRC | 14:28 | |
| *** skolekonov has joined #openstack-meeting-4 | 14:30 | |
| *** carl_baldwin has quit IRC | 14:36 | |
| *** fnaval has joined #openstack-meeting-4 | 14:38 | |
| *** sarob has joined #openstack-meeting-4 | 14:50 | |
| *** sarob has quit IRC | 14:54 | |
| *** gfidente has joined #openstack-meeting-4 | 14:55 | |
| *** mdorman has joined #openstack-meeting-4 | 14:57 | |
| *** numan has quit IRC | 14:57 | |
| *** banix has joined #openstack-meeting-4 | 14:58 | |
| *** xingchao_ has joined #openstack-meeting-4 | 14:58 | |
| crinkle | morning | 14:59 |
|---|---|---|
| mgagne | o/ | 15:00 |
| spredzy | Hola | 15:00 |
| crinkle | #startmeeting puppet-openstack | 15:00 |
| openstack | Meeting started Tue Apr 7 15:00:07 2015 UTC and is due to finish in 60 minutes. The chair is crinkle. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| *** openstack changes topic to " (Meeting topic: puppet-openstack)" | 15:00 | |
| EmilienM | o/ | 15:00 |
| openstack | The meeting name has been set to 'puppet_openstack' | 15:00 |
| crinkle | #topic Review past action items - EmilienM to document sbadia's email in the wiki | 15:00 |
| *** openstack changes topic to "Review past action items - EmilienM to document sbadia's email in the wiki (Meeting topic: puppet-openstack)" | 15:00 | |
| crinkle | EmilienM: completed? | 15:00 |
| gchamoul | o/ | 15:00 |
| EmilienM | yes | 15:00 |
| EmilienM | #link https://wiki.openstack.org/wiki/Puppet/PTL | 15:01 |
| crinkle | great | 15:01 |
| crinkle | #topic Review past action items - mgagne or dvorak runs a new thread on ML about Defaults for new config file parameters | 15:01 |
| *** openstack changes topic to "Review past action items - mgagne or dvorak runs a new thread on ML about Defaults for new config file parameters (Meeting topic: puppet-openstack)" | 15:01 | |
| *** sarob has joined #openstack-meeting-4 | 15:01 | |
| crinkle | I haven't seen this thread yet | 15:01 |
| mgagne | I have not followed up on this action, sorry | 15:01 |
| dvorak | crinkle: I still intend to write something up, probably later this week | 15:01 |
| sbadia | hi | 15:01 |
| mgagne | I will now | 15:01 |
| dvorak | or that :) | 15:02 |
| mgagne | dvorak: or you can do it =) | 15:02 |
| mgagne | haha | 15:02 |
| mfisch | dvorak and I are at a work offsite thing and will be told to close our laptops soon | 15:02 |
| dvorak | either way is ok with me, I won't be able to get to it until the end of the week, feel free to do it before then if you get bored :) | 15:02 |
| *** emagana has joined #openstack-meeting-4 | 15:02 | |
| mgagne | alright | 15:02 |
| crinkle | #action mgagne to start thread on defaults for new config file parameters | 15:03 |
| crinkle | #topic puppet-neutron/L2: Discuss about https://review.openstack.org/#/c/159769 and https://review.openstack.org/#/c/106144 | 15:03 |
| *** openstack changes topic to "puppet-neutron/L2: Discuss about https://review.openstack.org/#/c/159769 and https://review.openstack.org/#/c/106144 (Meeting topic: puppet-openstack)" | 15:03 | |
| crinkle | EmilienM: ? | 15:03 |
| *** sarob has quit IRC | 15:03 | |
| EmilienM | I would like people to see https://review.openstack.org/#/c/159769 and https://review.openstack.org/#/c/106144 - I'm in favor of #2 but we need to agree | 15:03 |
| EmilienM | https://review.openstack.org/#/c/106144 is a really old patch and we should make it land sometimes | 15:04 |
| gchamoul | :D | 15:04 |
| *** xingchao_ has quit IRC | 15:04 | |
| mgagne | EmilienM: I'll try to see if I can get an opinion on that one | 15:05 |
| *** ajayaa has quit IRC | 15:05 | |
| EmilienM | #link https://bugs.launchpad.net/puppet-neutron/+bug/1426080 | 15:05 |
| openstack | Launchpad bug 1426080 in puppet-neutron "neutron agents ml2 linuxbridge class does not modify ml2_conf.ini" [Undecided,In progress] - Assigned to Emilien Macchi (emilienm) | 15:05 |
| EmilienM | #link https://review.openstack.org/#/c/106144 | 15:05 |
| EmilienM | #link https://review.openstack.org/#/c/159769 | 15:05 |
| EmilienM | crinkle: I'm not sure we need more time on this topic, I just need people reviewing it in Gerrit | 15:06 |
| EmilienM | and give feedback | 15:06 |
| crinkle | okay | 15:06 |
| EmilienM | so we can go ahead | 15:06 |
| crinkle | #topic spredzy: creation of a FAQ that would be authoritative in case of doubt. | 15:06 |
| *** openstack changes topic to "spredzy: creation of a FAQ that would be authoritative in case of doubt. (Meeting topic: puppet-openstack)" | 15:06 | |
| crinkle | spredzy: ? | 15:07 |
| spredzy | As I was doing some review I cam across https://review.openstack.org/#/c/169066/ | 15:07 |
| EmilienM | like https://wiki.openstack.org/wiki/Puppet/FAQ ? :-) | 15:07 |
| EmilienM | or something in specs, as a blueprint | 15:07 |
| spredzy | where dvorak and mgagne disagreed, and someone is currently enabling OracleLinux adding option to $::operratingsystem and not using $::osfamily | 15:08 |
| mgagne | I like the idea proposed by spredzy. it's long overdue IMO | 15:08 |
| gchamoul | aha | 15:08 |
| spredzy | so they're all correct patches, but I think we should enforce some of them and have a link where the authoritaive answer is | 15:08 |
| EmilienM | mgagne: specs or wiki? | 15:08 |
| mgagne | none | 15:08 |
| mgagne | I would like to see something in rspec/lint about it | 15:08 |
| *** erikmwilson is now known as Guest190 | 15:08 | |
| *** erikmwilson has joined #openstack-meeting-4 | 15:08 | |
| *** erikmwilson_ has joined #openstack-meeting-4 | 15:08 | |
| spredzy | mgagne, we could have both a wiki and a specific rspec-lint-plugin for a specific rule | 15:09 |
| mgagne | sure | 15:09 |
| mgagne | because if it's in wiki, it won't be automatically enforced | 15:09 |
| spredzy | and we could keep track of it else its hard to put a -1, because its written nowhere how to actually do it | 15:09 |
| *** sarob has joined #openstack-meeting-4 | 15:09 | |
| gchamoul | +1 | 15:10 |
| spredzy | mgagne, right, but if the user wants clearer description a link to a wiki entry might be a good idea | 15:10 |
| mgagne | sure | 15:10 |
| crinkle | this seems less like an FAQ and more like a style guide | 15:10 |
| *** xingchao_ has joined #openstack-meeting-4 | 15:10 | |
| mgagne | yep, whatever it's called | 15:11 |
| crinkle | i think there could also be an FAQ for things that aren't lintable | 15:11 |
| mgagne | we need to structure our style and enforce it otherwise people will enforce whatever they wish depending on the moon's phase | 15:11 |
| Hunner | Such as when to use <||> or not | 15:11 |
| *** sarob has quit IRC | 15:12 | |
| mgagne | anything else on the subject? | 15:12 |
| spredzy | we could in a first phase structure one we would create, let see if everything agrees on it and actually on a second phase implement it | 15:12 |
| spredzy | would that be good w/ everybody ? | 15:12 |
| gchamoul | ack! | 15:12 |
| mgagne | +/ | 15:12 |
| mgagne | +1 | 15:13 |
| EmilienM | +1 | 15:13 |
| sbadia | yep | 15:13 |
| crinkle | sure, spredzy can you take that action item? | 15:13 |
| spredzy | #action spredzy structure w/ the community what exactly will be created and propose a plan on next meeting | 15:13 |
| EmilienM | spredzy: thanks :D | 15:13 |
| spredzy | yw :) | 15:13 |
| spredzy | we can move on | 15:13 |
| crinkle | okay moving on | 15:13 |
| crinkle | #topic gchamoul: Proposition to produce rspec-puppet coverage reports for each openstack puppet modules | 15:14 |
| *** openstack changes topic to "gchamoul: Proposition to produce rspec-puppet coverage reports for each openstack puppet modules (Meeting topic: puppet-openstack)" | 15:14 | |
| crinkle | #link https://review.openstack.org/170712 | 15:14 |
| crinkle | #link https://review.openstack.org/171114 | 15:14 |
| crinkle | gchamoul: ? | 15:14 |
| gchamoul | the goal is to produce a coverage report in the rspec tests | 15:14 |
| mgagne | gchamoul: can you provide more details in the commit about how you can run the tests? I know you can read the source but it would be nice to get a starter guide in the commit message | 15:15 |
| *** sarob has joined #openstack-meeting-4 | 15:15 | |
| gchamoul | mgagne: yes, but we just need to add a line in the spec_helper.rb | 15:15 |
| sbadia | mgagne: tests are run automatically at exit | 15:16 |
| mgagne | gchamoul: oh, it's "only" a report at the end of execution? | 15:16 |
| gchamoul | to be able to get the coverage report! | 15:16 |
| gchamoul | mgagne: look at the end of the log file http://logs.openstack.org/12/170712/2/check/gate-puppet-tempest-puppet-unit-3.7/6dd7751/console.html | 15:16 |
| *** dannywilson has joined #openstack-meeting-4 | 15:17 | |
| gchamoul | you will get the total number of ressources, the tested resources and a list of untested resources | 15:17 |
| mgagne | gchamoul: I ran spec tests on my laptop without the additional coverage you did. I'm not sure someone can easily understand from the output what needs to be done. | 15:18 |
| gchamoul | so for the moment rspec-puppet doesn't filter the ressources coming from the fixture modules | 15:18 |
| EmilienM | oh, I was wondering | 15:18 |
| gchamoul | and we will need this PR https://github.com/rodjek/rspec-puppet/pull/258 | 15:18 |
| EmilienM | but it's still good to have it | 15:18 |
| *** Bjoern__ has joined #openstack-meeting-4 | 15:19 | |
| *** dannywilson has quit IRC | 15:19 | |
| Hunner | Shiny | 15:19 |
| *** dannywilson has joined #openstack-meeting-4 | 15:19 | |
| gchamoul | mgagne: The information about the total number of resouces is interesting (and potentially an indicator of complexity) but the list of untouched resources is the main useful part. These represent both information about what your module is doing, and potential things you might want to test. | 15:19 |
| mgagne | I'm ok with it if we can find a way to enforce it. My point is that due to the "unhelpful" output, until we have 100% coverage, I wouldn't force someone to add coverage. The barrier of entry is high enough (for an operator) that we shouldn't make it even harder for them to contribute | 15:22 |
| EmilienM | +1 for mgagne | 15:23 |
| mgagne | today, I'm sure there is a gazillion uncovered resources and it would be unfair to ask someone to try find which ones HE introduced and test them. The output sucks and is not useful in tracking down WHERE the not-covered resources are. | 15:23 |
| *** sacharya has joined #openstack-meeting-4 | 15:24 | |
| mgagne | that's my take on it | 15:24 |
| crinkle | does the coverage report cause a failure if it's under-covered? | 15:25 |
| gchamoul | crinkle: nope! it's just informative! | 15:25 |
| crinkle | then it doesn't seem harmful to me | 15:25 |
| mgagne | who will enforce it? | 15:25 |
| spredzy | mgagne, we could add it to msync | 15:26 |
| spredzy | the line : at_exit { RSpec::Puppet::Coverage.report! } | 15:26 |
| sbadia | spredzy: +1 | 15:26 |
| mgagne | a core telling someone that somewhere in the console.log is telling the coverage is lower than before? | 15:26 |
| gchamoul | mgagne: what do you mean by who will enforce it ??? | 15:26 |
| spredzy | nothing needs to be enforced, only the output needs to be present | 15:26 |
| mgagne | gchamoul: if it's not automated, it's useless | 15:26 |
| mgagne | spredzy: than to me, it's useless | 15:26 |
| crinkle | but the output isn't useful if we're not doing something with it | 15:26 |
| sbadia | like coverage.io ? :) | 15:26 |
| *** ajmiller_ has quit IRC | 15:27 | |
| spredzy | if this line is present on every project is spec_helper.rb it will provide the information | 15:27 |
| mgagne | crinkle: that | 15:27 |
| crinkle | but what action do we take on the information? | 15:27 |
| mgagne | if it's not enforced, it's noise and wasted effort | 15:27 |
| crinkle | will someon take an action item to increase coverage to 100% on all the modules? because taht seems like a huge undertaking | 15:27 |
| *** krtaylor has quit IRC | 15:28 | |
| spredzy | Once we have those information, we can quantify it and do the actual effort to go toward the 100% | 15:28 |
| spredzy | being able to value what have been done | 15:28 |
| gchamoul | crinkle: I am ok with that! | 15:28 |
| gchamoul | crinkle: I already opened a bugs about the rspec tests | 15:29 |
| crinkle | okay then | 15:29 |
| * crinkle +0 | 15:29 | |
| mgagne | yep, +0 here as I know I won't be able to contribute seriously to the effort | 15:29 |
| mgagne | and I won't force someone else to add coverage | 15:29 |
| gchamoul | when we were updating rspec2->3 with sbadia. I identified some inconsistency within the tests in the modules | 15:29 |
| EmilienM | there are a lot | 15:30 |
| gchamoul | a lot of types/providers are not tested ... | 15:30 |
| Hunner | sbadia: https://github.com/rodjek/rspec-puppet/pull/214 was adding https://coveralls.io/ support | 15:30 |
| gchamoul | for example! | 15:30 |
| sbadia | gchamoul: yep (shared example, distro specific units, …) | 15:30 |
| gchamoul | yes! | 15:30 |
| Hunner | Coverage was JUST added to rspec-puppet and isn't fleshed out much yet... | 15:30 |
| sbadia | Hunner: oh cool, thanks for the link | 15:31 |
| crinkle | if this depends on new features in rspec-puppet then we could be waiting a while | 15:31 |
| EmilienM | AFIK other OpenStack projects don't have 100% coverage (I'm not saying it's good though) | 15:31 |
| Hunner | 100% coverage or bust! ~ | 15:31 |
| EmilienM | I +0 too, I'll be happy to review but I won't help much on sending patches. | 15:32 |
| mgagne | IMO, we have bigger fish to catch with better ROI | 15:32 |
| gchamoul | crinkle: yes for now ... the coverage percentage are irrelevant due to the bad filter on the fixtures | 15:32 |
| crinkle | i think the discussion can be tabled for now if rspec-puppet isn't even ready for this | 15:32 |
| *** matrohon has quit IRC | 15:32 | |
| gchamoul | EmilienM: the goal is not to get 100% | 15:32 |
| EmilienM | gchamoul: can we specify the % ? | 15:33 |
| *** ajmiller has joined #openstack-meeting-4 | 15:33 | |
| Hunner | WRT coverage, are we getting actual failures that having more test coverage would fix? | 15:34 |
| gchamoul | EmilienM: nope, we actually cannot trick it! but I planned to send some PRs in the next days | 15:34 |
| EmilienM | if so, we could adjust our modules with existing coverage | 15:34 |
| EmilienM | mgagne: if you have any suggestion for bigger fish, go ahead | 15:35 |
| EmilienM | tests are never big fishes, but we still need them. | 15:35 |
| mgagne | EmilienM: fixing consistency across our modules. Making sure we have the same common feature baseline across our modules | 15:35 |
| EmilienM | mgagne: that's a big fish too | 15:35 |
| mgagne | with great ROI | 15:35 |
| gchamoul | EmilienM, mgagne: the tool we talked last week as well! | 15:36 |
| EmilienM | mgagne: is that we talked before with spredzy ? | 15:36 |
| mgagne | so people don't contribute one by one those features over several months in each modules but with inconsistency | 15:36 |
| mgagne | yep | 15:36 |
| gchamoul | that tool identifying all new parameters, the deprecated ones ... new default values and so on ... | 15:36 |
| EmilienM | this one also has a good ROI | 15:37 |
| EmilienM | we talked about it last meeting | 15:37 |
| gchamoul | yep! | 15:38 |
| crinkle | is there an action we can take on this topic now, or should we move on? | 15:38 |
| gchamoul | crinkle: once the rspec-puppet coverage feature will be able to give us better infos, I will put that subject on a future agenda | 15:39 |
| gchamoul | again! | 15:39 |
| gchamoul | ok? | 15:39 |
| crinkle | okay | 15:39 |
| EmilienM | I think the tests thing is more for medium-long term | 15:39 |
| EmilienM | in short term we should focus on consistency tools | 15:39 |
| crinkle | #agreed gchamoul to revisit rspec-puppet coverage when new feature is landed in rspec-puppet | 15:40 |
| EmilienM | (ie spredzy's topic is short term) | 15:40 |
| gchamoul | okay | 15:41 |
| EmilienM | gchamoul: are you interested to contribute to this one? | 15:41 |
| EmilienM | the tool we mentioned last week | 15:41 |
| EmilienM | with mgagne | 15:41 |
| gchamoul | yes! | 15:41 |
| gchamoul | I was thinking and dreaming about this tools for a while now :D | 15:42 |
| mgagne | =) | 15:42 |
| EmilienM | #action gchamoul starts working on "Defaults for new config file parameters" tool | 15:42 |
| * spredzy have to leave | 15:42 | |
| EmilienM | gchamoul: sounds good? | 15:42 |
| gchamoul | perfect | 15:42 |
| crinkle | moving on? | 15:43 |
| EmilienM | crinkle: we're all set for this topic I think | 15:43 |
| crinkle | okay | 15:43 |
| crinkle | #topic PTL election | 15:43 |
| *** openstack changes topic to "PTL election (Meeting topic: puppet-openstack)" | 15:43 | |
| crinkle | we received one nomination as far as I saw | 15:43 |
| crinkle | should we leave the nomination period open for another week, or call it? | 15:43 |
| *** banix has quit IRC | 15:44 | |
| mgagne | what's the deadline for openstack projects? | 15:44 |
| mdorman | i vote call it | 15:44 |
| * EmilienM abstains | 15:45 | |
| gchamoul | maybe I am wrong but I don't think we will have more nomination.... | 15:45 |
| gchamoul | so call it! | 15:45 |
| crinkle | mgagne: I'm not sure, we didn't start it in sync with the other projects | 15:45 |
| gchamoul | sbadia, President! :-p | 15:45 |
| mgagne | "Nominations for OpenStack PTLs (Program Technical Leads) are now open | 15:45 |
| mgagne | and will remain open until April 9, 2015 05:59 UTC." | 15:45 |
| sbadia | gchamoul: ? | 15:45 |
| gchamoul | kidding!!!! | 15:45 |
| crinkle | okay, let's leave it open till April 9 then | 15:45 |
| sbadia | agree | 15:46 |
| gchamoul | +1 | 15:46 |
| mgagne | if there is no one else, so be it | 15:46 |
| crinkle | I can send an email at the end of this meeting making a last call for nominations | 15:47 |
| Hunner | EmilienM++ | 15:47 |
| mgagne | +1 | 15:47 |
| gchamoul | +100 | 15:47 |
| crinkle | #agreed PTL nominations to close on April 9 | 15:47 |
| EmilienM | cool | 15:47 |
| Hunner | Wait, we have to have our submission in by then | 15:47 |
| sbadia | thanks crinkle | 15:47 |
| Hunner | Not closing our own electing then | 15:47 |
| crinkle | #actoin crinkle to send email reminding about nominations | 15:47 |
| crinkle | #action crinkle to send email reminding about nominations | 15:47 |
| crinkle | Hunner: right, last call to nominate, not elect | 15:48 |
| crinkle | but if there's only one nominee then we don't have to decide how to elect | 15:48 |
| Hunner | Ooo, nominate not elect. Right | 15:48 |
| crinkle | should we use the rest of the 10 minutes for open discussion, bug triage, or review triage? | 15:49 |
| EmilienM | yes | 15:49 |
| EmilienM | I have something to say | 15:49 |
| crinkle | EmilienM: go for it | 15:50 |
| EmilienM | crinkle: please change the topic :-) | 15:50 |
| crinkle | on i thought you meant on this topic | 15:50 |
| crinkle | #topic open discussion | 15:50 |
| *** openstack changes topic to "open discussion (Meeting topic: puppet-openstack)" | 15:50 | |
| EmilienM | about Summit, I asked for "Open Cloud Ecosystem Collaboration Day" which is a room for a full day. So we will have time and space to work together during a whole day. I did not have a reply yet, but i'll let you know. | 15:50 |
| EmilienM | crinkle: that's it thanks :-) | 15:50 |
| crinkle | thanks EmilienM | 15:50 |
| crinkle | are there bugs or reviews that anyone wants the group to look at? | 15:51 |
| *** Santosh has joined #openstack-meeting-4 | 15:51 | |
| gchamoul | yes https://review.openstack.org/#/c/170486/ :D | 15:51 |
| *** xingchao_ has quit IRC | 15:52 | |
| sbadia | gchamoul: remove whitespaces ? :) | 15:52 |
| crinkle | the whitespace was there already | 15:52 |
| sbadia | indeed… | 15:53 |
| crinkle | thanks mgagne | 15:53 |
| crinkle | others? | 15:53 |
| gchamoul | thx mgagne | 15:53 |
| mgagne | yw | 15:53 |
| gchamoul | oh wait! | 15:53 |
| sbadia | msync ? | 15:54 |
| gchamoul | I would like you to take a look at this one https://review.openstack.org/164125 | 15:54 |
| gchamoul | from spredzy | 15:54 |
| crinkle | gchamoul: looks like you made a comment that hasn't been addressed yet | 15:55 |
| mgagne | wth is that? o_O | 15:55 |
| EmilienM | mgagne: see https://github.com/puppetlabs/modulesync_configs/blob/master/README.md | 15:56 |
| gchamoul | crinkle: I think you are the best person to tale about this :D | 15:56 |
| gchamoul | s/tale/talk/ | 15:56 |
| crinkle | mgagne: is the issue with the whole patch or the rakefile template? | 15:57 |
| gchamoul | mgagne: don't worry. it won't hurt! ;-) | 15:57 |
| mgagne | I don't know what this tool does and where it came from | 15:57 |
| sbadia | haha, mgagne you come from the past ? :p | 15:57 |
| mgagne | yep | 15:57 |
| gchamoul | mgagne: from puppetlabs itself! | 15:57 |
| * mgagne goes back to his cave | 15:57 | |
| EmilienM | ahah | 15:57 |
| sbadia | mgagne: noooo :) | 15:57 |
| EmilienM | 2 min left guys | 15:58 |
| mgagne | I'm not subscribed to the RSS feed of puppetlabs organization on github | 15:58 |
| gchamoul | crinkle: I wanted to see the fix about the puppet-lint filter again! | 15:58 |
| crinkle | it's a tool to synchronize common files across multiple repositories, so that if for example we need to pin a gem across all modules we can do it more easily | 15:58 |
| crinkle | gchamoul: ? | 15:58 |
| crinkle | mgagne: it might be worth having a longer discussion on whether we should be using it here, I'm not convinced we should | 15:59 |
| crinkle | but we need to wrap up the meeting | 15:59 |
| crinkle | #endmeeting | 15:59 |
| *** openstack changes topic to "OpenStack Meetings" | 15:59 | |
| openstack | Meeting ended Tue Apr 7 15:59:09 2015 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:59 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/puppet_openstack/2015/puppet_openstack.2015-04-07-15.00.html | 15:59 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/puppet_openstack/2015/puppet_openstack.2015-04-07-15.00.txt | 15:59 |
| gchamoul | crinkle: we have an issue in puppet-lint ... which doesn't filter the spec/**/* files | 15:59 |
| EmilienM | thanks crinkle | 15:59 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/puppet_openstack/2015/puppet_openstack.2015-04-07-15.00.log.html | 15:59 |
| sbadia | thanks | 15:59 |
| *** emagana has quit IRC | 15:59 | |
| *** gfidente has left #openstack-meeting-4 | 16:00 | |
| *** xingchao_ has joined #openstack-meeting-4 | 16:00 | |
| *** VW_ has quit IRC | 16:01 | |
| *** ivar-lazzaro has joined #openstack-meeting-4 | 16:02 | |
| *** emagana has joined #openstack-meeting-4 | 16:03 | |
| *** VW_ has joined #openstack-meeting-4 | 16:03 | |
| *** eghobo has joined #openstack-meeting-4 | 16:04 | |
| *** SumitNaiksatam has quit IRC | 16:06 | |
| Santosh | hi | 16:07 |
| *** mdorman has left #openstack-meeting-4 | 16:07 | |
| *** Bjoern__ is now known as BjoernT | 16:08 | |
| *** BjoernT has left #openstack-meeting-4 | 16:09 | |
| *** git-harry has left #openstack-meeting-4 | 16:10 | |
| *** banix has joined #openstack-meeting-4 | 16:19 | |
| *** Santosh has quit IRC | 16:52 | |
| *** ajayaa has joined #openstack-meeting-4 | 16:52 | |
| *** krtaylor has joined #openstack-meeting-4 | 16:54 | |
| *** rharwood has joined #openstack-meeting-4 | 16:59 | |
| *** bharath has joined #openstack-meeting-4 | 17:04 | |
| *** sdake_ has quit IRC | 17:08 | |
| *** yamahata has quit IRC | 17:28 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 17:29 | |
| *** VW_ has quit IRC | 17:32 | |
| *** VW_ has joined #openstack-meeting-4 | 17:34 | |
| *** VW_ has quit IRC | 17:35 | |
| *** VW_ has joined #openstack-meeting-4 | 17:35 | |
| *** s3wong has joined #openstack-meeting-4 | 17:36 | |
| *** VW_ has quit IRC | 17:40 | |
| *** bobmel has quit IRC | 17:42 | |
| *** ajmiller_ has joined #openstack-meeting-4 | 17:43 | |
| *** xingchao_ has quit IRC | 17:47 | |
| *** ajmiller has quit IRC | 17:47 | |
| *** VW_ has joined #openstack-meeting-4 | 17:50 | |
| *** sicrano has joined #openstack-meeting-4 | 17:54 | |
| *** sicrano has quit IRC | 17:54 | |
| *** bharath has quit IRC | 17:57 | |
| *** ivar-lazzaro has quit IRC | 17:58 | |
| *** bharath has joined #openstack-meeting-4 | 17:58 | |
| *** yamahata has joined #openstack-meeting-4 | 18:08 | |
| *** sdake has joined #openstack-meeting-4 | 18:10 | |
| *** sdake_ has joined #openstack-meeting-4 | 18:11 | |
| *** sdake has quit IRC | 18:15 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:17 | |
| *** xingchao_ has joined #openstack-meeting-4 | 18:18 | |
| *** xingchao_ has quit IRC | 18:27 | |
| *** eghobo has quit IRC | 18:35 | |
| *** bharath_ has joined #openstack-meeting-4 | 18:36 | |
| *** bharath has quit IRC | 18:37 | |
| *** yamahata has quit IRC | 18:38 | |
| *** ajmiller has joined #openstack-meeting-4 | 18:44 | |
| *** ajmiller_ has quit IRC | 18:44 | |
| *** yamahata has joined #openstack-meeting-4 | 18:44 | |
| *** ibiris is now known as ibiris_away | 18:52 | |
| *** VW_ has quit IRC | 19:02 | |
| *** matrohon has joined #openstack-meeting-4 | 19:02 | |
| *** bharath_ has quit IRC | 19:11 | |
| *** bharath has joined #openstack-meeting-4 | 19:12 | |
| *** VW_ has joined #openstack-meeting-4 | 19:16 | |
| *** igordcard_ has joined #openstack-meeting-4 | 19:19 | |
| *** xingchao_ has joined #openstack-meeting-4 | 19:26 | |
| *** xingchao_ has quit IRC | 19:31 | |
| *** ajayaa_ has joined #openstack-meeting-4 | 19:37 | |
| *** ajayaa has quit IRC | 19:37 | |
| *** sarob has quit IRC | 19:45 | |
| *** aventera_ has joined #openstack-meeting-4 | 19:56 | |
| *** aventerav has quit IRC | 19:56 | |
| *** britthou_ has joined #openstack-meeting-4 | 19:56 | |
| *** britthouser has quit IRC | 19:58 | |
| *** Rockyg has joined #openstack-meeting-4 | 20:06 | |
| *** ajayaa_ has quit IRC | 20:12 | |
| *** xingchao_ has joined #openstack-meeting-4 | 20:28 | |
| *** kobis has joined #openstack-meeting-4 | 20:31 | |
| *** xingchao_ has quit IRC | 20:38 | |
| *** VW_ has quit IRC | 20:41 | |
| *** rushiagr is now known as rushiagr_away | 20:42 | |
| *** igordcard_ has quit IRC | 20:47 | |
| *** eghobo has joined #openstack-meeting-4 | 20:50 | |
| *** wojdev has joined #openstack-meeting-4 | 20:53 | |
| *** ivar-lazzaro has joined #openstack-meeting-4 | 20:54 | |
| *** sdake_ has quit IRC | 20:57 | |
| *** VW_ has joined #openstack-meeting-4 | 20:57 | |
| *** kobis has quit IRC | 21:03 | |
| *** wojdev has quit IRC | 21:05 | |
| *** matrohon has quit IRC | 21:08 | |
| *** wojdev has joined #openstack-meeting-4 | 21:10 | |
| *** rfolco has quit IRC | 21:22 | |
| *** sacharya has quit IRC | 21:31 | |
| *** Rockyg has quit IRC | 21:36 | |
| *** xingchao_ has joined #openstack-meeting-4 | 21:36 | |
| *** banix has quit IRC | 21:40 | |
| *** xingchao_ has quit IRC | 21:41 | |
| *** VW_ has quit IRC | 21:52 | |
| *** jckasper has quit IRC | 22:03 | |
| *** erikmwilson has quit IRC | 22:04 | |
| *** wojdev has quit IRC | 22:07 | |
| *** erikmwilson has joined #openstack-meeting-4 | 22:08 | |
| *** mestery has quit IRC | 22:11 | |
| *** mestery has joined #openstack-meeting-4 | 22:12 | |
| *** igordcard_ has joined #openstack-meeting-4 | 22:21 | |
| *** wojdev has joined #openstack-meeting-4 | 22:21 | |
| *** wojdev has quit IRC | 22:21 | |
| *** erikmwilson has quit IRC | 22:29 | |
| *** dims_ has joined #openstack-meeting-4 | 22:30 | |
| *** dims_ has quit IRC | 22:30 | |
| *** dims_ has joined #openstack-meeting-4 | 22:31 | |
| *** sdake has joined #openstack-meeting-4 | 22:31 | |
| *** bknudson has quit IRC | 22:33 | |
| *** dims has quit IRC | 22:34 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:36 | |
| *** sdake_ has joined #openstack-meeting-4 | 22:37 | |
| *** xingchao_ has joined #openstack-meeting-4 | 22:38 | |
| *** sdake has quit IRC | 22:40 | |
| *** igordcard_ has quit IRC | 22:46 | |
| *** xingchao_ has quit IRC | 22:47 | |
| *** igordcard_ has joined #openstack-meeting-4 | 22:47 | |
| *** bknudson has joined #openstack-meeting-4 | 22:56 | |
| *** bknudson1 has joined #openstack-meeting-4 | 22:58 | |
| *** bknudson has quit IRC | 23:00 | |
| *** jckasper has joined #openstack-meeting-4 | 23:06 | |
| *** igordcard_ has quit IRC | 23:07 | |
| *** aventera_ has quit IRC | 23:09 | |
| *** eghobo has quit IRC | 23:12 | |
| *** eghobo has joined #openstack-meeting-4 | 23:20 | |
| *** jckasper has quit IRC | 23:26 | |
| *** xingchao_ has joined #openstack-meeting-4 | 23:46 | |
| *** bharath has quit IRC | 23:51 | |
| *** xingchao_ has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!