openstackgerrit | pangliye proposed openstack/manila: Add some spaces to pass the check of pep8 https://review.openstack.org/413298 | 00:50 |
---|---|---|
openstackgerrit | Tony Breeds proposed openstack/manila-image-elements: Add Constraints support https://review.openstack.org/413299 | 00:50 |
*** harlowja has joined #openstack-manila | 01:06 | |
openstackgerrit | yunfeng zhou proposed openstack/puppet-manila: add CONTRIBUTING.rst https://review.openstack.org/412918 | 01:17 |
*** harlowja has quit IRC | 01:44 | |
openstackgerrit | Merged openstack/manila-image-elements: Add Constraints support https://review.openstack.org/413299 | 01:53 |
openstackgerrit | yankee proposed openstack/manila: Allow use of <is> True and <is> False with DHSS and snapshot support https://review.openstack.org/413338 | 02:05 |
openstackgerrit | Tony Breeds proposed openstack/python-manilaclient: Add Constraints support https://review.openstack.org/413339 | 02:06 |
*** tuanluong has joined #openstack-manila | 02:31 | |
*** gcb has joined #openstack-manila | 02:35 | |
*** gouthamr has quit IRC | 02:58 | |
*** mtanino has quit IRC | 04:16 | |
*** senk has joined #openstack-manila | 05:25 | |
*** senk has quit IRC | 06:24 | |
*** lpetrut has joined #openstack-manila | 06:43 | |
*** senk has joined #openstack-manila | 07:05 | |
*** pcaruana has joined #openstack-manila | 07:34 | |
*** nherciu has joined #openstack-manila | 07:45 | |
*** openstackgerrit has quit IRC | 07:48 | |
*** lpetrut has quit IRC | 07:51 | |
*** tuanluong has quit IRC | 08:05 | |
*** cfey has quit IRC | 08:16 | |
*** cfey has joined #openstack-manila | 08:23 | |
*** openstackgerrit has joined #openstack-manila | 08:39 | |
openstackgerrit | zhongjun proposed openstack/python-manilaclient: Add share_type filter to pool_list https://review.openstack.org/368528 | 08:39 |
*** dsariel has joined #openstack-manila | 08:40 | |
*** cfey has quit IRC | 08:50 | |
*** akapil has joined #openstack-manila | 09:03 | |
openstackgerrit | zhongjun proposed openstack/manila: Enable IPv6 in manila(allow access) https://review.openstack.org/312321 | 09:07 |
*** dsariel has quit IRC | 09:13 | |
*** cfey has joined #openstack-manila | 09:16 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Grenade] Do not run tempest tests https://review.openstack.org/411796 | 09:18 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DNM] debug 3.0 https://review.openstack.org/410366 | 09:21 |
*** breitz has joined #openstack-manila | 09:22 | |
*** a-pugachev has joined #openstack-manila | 09:25 | |
*** breitz_ has quit IRC | 09:26 | |
*** chlong has quit IRC | 09:34 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 09:49 |
*** ganso has joined #openstack-manila | 09:51 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 09:58 |
*** alyson_ has joined #openstack-manila | 10:03 | |
openstackgerrit | Tina Tang proposed openstack/manila: [Unity driver] VLAN enhancement https://review.openstack.org/410037 | 10:09 |
*** tuanluong has joined #openstack-manila | 10:10 | |
*** lpetrut has joined #openstack-manila | 10:14 | |
*** ociuhandu has quit IRC | 10:14 | |
*** akapil has quit IRC | 10:28 | |
*** akapil has joined #openstack-manila | 10:30 | |
*** ociuhandu has joined #openstack-manila | 10:31 | |
*** tuanluong has quit IRC | 10:34 | |
*** gcb has quit IRC | 10:58 | |
*** dsariel has joined #openstack-manila | 10:59 | |
*** akapil has quit IRC | 11:09 | |
*** arnewiebalck has quit IRC | 11:10 | |
*** gcb has joined #openstack-manila | 11:15 | |
*** akapil has joined #openstack-manila | 11:29 | |
openstackgerrit | Merged openstack/python-manilaclient: Add Python 3.5 classifier and venv https://review.openstack.org/390693 | 11:29 |
*** akapil has quit IRC | 11:34 | |
*** akapil has joined #openstack-manila | 11:34 | |
*** gcb has quit IRC | 11:40 | |
*** gcb has joined #openstack-manila | 11:52 | |
*** tommylik_ has joined #openstack-manila | 12:14 | |
*** tommylik_ has quit IRC | 12:16 | |
*** tommylikehu_ has joined #openstack-manila | 12:16 | |
openstackgerrit | Helen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila https://review.openstack.org/404859 | 12:22 |
*** ociuhandu has quit IRC | 12:39 | |
*** pcaruana has quit IRC | 12:49 | |
*** rraja has joined #openstack-manila | 12:54 | |
openstackgerrit | zhongjun proposed openstack/manila: Trivial fix LOG.exception issues https://review.openstack.org/412688 | 12:58 |
*** ociuhandu has joined #openstack-manila | 13:06 | |
*** gouthamr has joined #openstack-manila | 13:18 | |
*** yankee has joined #openstack-manila | 13:31 | |
*** pcaruana has joined #openstack-manila | 13:32 | |
openstackgerrit | Digvijay Ukirde proposed openstack/manila: Add support for manage/unmanage in GPFS driver https://review.openstack.org/374705 | 13:39 |
*** xinyanzhang has quit IRC | 13:41 | |
*** xinyanzhang has joined #openstack-manila | 13:42 | |
*** xinyanzhang has quit IRC | 13:45 | |
*** xinyanzhang has joined #openstack-manila | 13:45 | |
openstackgerrit | Merged openstack/manila: [Grenade] Do not run tempest tests https://review.openstack.org/411796 | 13:49 |
*** yankee has quit IRC | 13:51 | |
*** xyang1 has joined #openstack-manila | 13:52 | |
*** eharney has joined #openstack-manila | 14:21 | |
*** senk has quit IRC | 14:31 | |
*** senk has joined #openstack-manila | 14:32 | |
*** akapil has quit IRC | 14:35 | |
*** pcaruana has quit IRC | 14:38 | |
*** zengyingzhe_ has joined #openstack-manila | 14:39 | |
*** senk has quit IRC | 14:41 | |
*** senk has joined #openstack-manila | 14:42 | |
*** zengyingzhe has quit IRC | 14:43 | |
*** akapil has joined #openstack-manila | 14:46 | |
*** porrua has joined #openstack-manila | 14:47 | |
*** pcaruana has joined #openstack-manila | 14:51 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add create_share_from_snapshot_support extra spec https://review.openstack.org/356682 | 14:57 |
openstackgerrit | Vitaliy Levitski proposed openstack/manila: Add MapR-FS native driver https://review.openstack.org/350035 | 15:12 |
*** lpetrut has quit IRC | 15:25 | |
vponomaryov | gouthamr: what about client changes https://review.openstack.org/#/c/356683/ ? | 15:28 |
*** lpetrut has joined #openstack-manila | 15:30 | |
*** senk has quit IRC | 15:33 | |
gouthamr | vponomaryov: cknight was looking at them | 15:35 |
*** cknight has joined #openstack-manila | 15:41 | |
*** lpetrut1 has joined #openstack-manila | 15:43 | |
*** lpetrut has quit IRC | 15:44 | |
*** lpetrut1 is now known as lpetrut | 15:44 | |
*** tommylikehu_ has quit IRC | 15:46 | |
*** openstackgerrit_ has joined #openstack-manila | 15:47 | |
*** openstackgerrit_ has quit IRC | 15:49 | |
ganso | cknight: pong | 15:50 |
*** mtanino has joined #openstack-manila | 15:52 | |
*** chlong has joined #openstack-manila | 15:52 | |
*** lpetrut has quit IRC | 15:53 | |
*** nherciu has quit IRC | 15:54 | |
*** akapil has quit IRC | 15:54 | |
*** nherciu has joined #openstack-manila | 15:59 | |
*** a-pugachev has quit IRC | 16:02 | |
*** a-pugachev has joined #openstack-manila | 16:02 | |
*** nherciu_ has joined #openstack-manila | 16:05 | |
*** nherciu has quit IRC | 16:05 | |
*** akapil has joined #openstack-manila | 16:08 | |
cknight | ganso: Hi, Rodrigo. Goutham & I didn't understand your comment here. https://review.openstack.org/#/c/356682/28/contrib/ci/post_test_hook.sh What are you looking for, please? Y'all need this patch as well, so we're trying to get it wrapped up soon. | 16:10 |
openstackgerrit | Vitaliy Levitski proposed openstack/manila: Add MapR-FS native driver https://review.openstack.org/350035 | 16:10 |
*** jcsp has quit IRC | 16:11 | |
*** jcsp has joined #openstack-manila | 16:11 | |
ganso | cknight: I meant to move it to line 238, either using an else or a "define if not defined" | 16:12 |
*** pcaruana has quit IRC | 16:13 | |
*** senk has joined #openstack-manila | 16:14 | |
cknight | ganso: Ok, I wondered if you were looking for an 'else' here. There are other things in this file that would also fit into that else block, so I could add the else only for my addition, or we could do my part and anything else all together in a separate patch. | 16:14 |
*** tommylikehu_ has joined #openstack-manila | 16:15 | |
ganso | cknight: either way is ok, but if you created the else block now, later new changes could use it | 16:16 |
ganso | cknight: I believe the revert and mountable patch will use it | 16:18 |
cknight | ganso: ok, I'll discuss with Goutham and see which he prefers. He's been helping me with this one while I attend to other things. | 16:19 |
ganso | cknight: ok, thanks Clinton! | 16:19 |
cknight | ganso: I assume y'all have been rebasing your mountable snapshots patch on this one. Has it been working for you? | 16:20 |
ganso | cknight: Latest mountable snapshot patch has, with a few workarounds, but it is still based on an older version of your extra_specs patch | 16:21 |
*** lpetrut has joined #openstack-manila | 16:21 | |
ganso | cknight: I will probably rebase on the latest later today or tomorrow to test | 16:22 |
ganso | cknight: I started working on mountable covering for tpsilva this monday | 16:22 |
ganso | cknight: so I am still getting familiar | 16:22 |
cknight | ganso: That should be OK, I haven't made any substantive changes in several weeks. Please let us know how it goes, and we will look to you for one of the +2's. Thanks! | 16:22 |
cknight | ganso: It'd be great to get this merged before Christmas! | 16:23 |
ganso | cknight: my vacation starts this Saturday | 16:23 |
ganso | cknight: I'll be back Jan 5th | 16:24 |
cknight | ganso: Same here | 16:24 |
ganso | cknight: if all my tests pass, I think it will be ready to merge | 16:25 |
* markstur drifts off into a mental vacation | 16:27 | |
*** dsariel has quit IRC | 16:39 | |
markstur | I'll be out from Saturday through Jan 4th. I might be available while I'm out but not sure yet how useful that will be. | 16:41 |
*** eharney has quit IRC | 16:47 | |
*** lseki has joined #openstack-manila | 16:51 | |
*** eharney has joined #openstack-manila | 16:58 | |
*** a-pugachev has quit IRC | 17:00 | |
*** openstackstatus has joined #openstack-manila | 17:00 | |
*** ChanServ sets mode: +v openstackstatus | 17:00 | |
openstackgerrit | Tom Barron proposed openstack/manila: DO NOT MERGE https://review.openstack.org/352606 | 17:00 |
*** openstackstatus has quit IRC | 17:02 | |
*** openstack has quit IRC | 17:02 | |
*** openstack has joined #openstack-manila | 17:06 | |
ganso | gouthamr: ping | 17:15 |
*** a-pugachev has quit IRC | 17:17 | |
*** lpetrut has quit IRC | 17:22 | |
*** senk has quit IRC | 17:23 | |
*** panatl has quit IRC | 17:26 | |
openstackgerrit | Tom Barron proposed openstack/manila: WIP: Remove nova net from service_instance https://review.openstack.org/410449 | 17:36 |
openstackgerrit | Tom Barron proposed openstack/manila: WIP - Remove NovaNetworkPlugin https://review.openstack.org/410450 | 17:36 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DNM] Test 4.0 https://review.openstack.org/413737 | 17:45 |
*** alyson_ has quit IRC | 17:46 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DNM] Test 4.0 https://review.openstack.org/413737 | 17:48 |
*** akapil has quit IRC | 17:50 | |
*** nherciu has joined #openstack-manila | 17:54 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DNM] Test 4.0 https://review.openstack.org/413737 | 17:54 |
*** senk has joined #openstack-manila | 17:55 | |
*** nherciu_ has quit IRC | 17:55 | |
*** mtanino has quit IRC | 17:55 | |
vponomaryov | cknight, ganso: lets just get it merged | 17:56 |
vponomaryov | cknight, ganso: and fix bugs later if any | 17:56 |
ganso | vponomaryov: the same could be said for migration patches :P | 17:56 |
-openstackstatus- NOTICE: Gerrit is being restarted to update its OpenID SSO configuration | 17:58 | |
vponomaryov | ganso: if you are talking about https://review.openstack.org/#/c/406305/ then it does not touch api microversions and db migrations | 17:58 |
vponomaryov | so, we gain more merging the most affecting other commits commit | 17:59 |
vponomaryov | ganso: and you gain too for mountable snapshots feature ) | 18:00 |
vponomaryov | gansO; your turn )) | 18:00 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share Migration Ocata Improvements https://review.openstack.org/406305 | 18:00 |
ganso | vponomaryov: which patch does not touch microversions and db migrations? | 18:02 |
ganso | vponomaryov: my patch does, so does cknight's | 18:02 |
*** senk has quit IRC | 18:04 | |
vponomaryov | ganso: hm, ok, api changed. Not DB. + your one is smaller | 18:04 |
*** ociuhandu has quit IRC | 18:04 | |
*** senk has joined #openstack-manila | 18:05 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DNM] Test 4.0 https://review.openstack.org/413737 | 18:06 |
*** jcsp has quit IRC | 18:09 | |
gouthamr | ganso: pong | 18:12 |
gouthamr | vponomaryov: +1 | 18:12 |
*** jkremer has joined #openstack-manila | 18:12 | |
*** jkremer has quit IRC | 18:13 | |
*** jkremer has joined #openstack-manila | 18:13 | |
*** jkremer has quit IRC | 18:14 | |
ganso | vponomaryov: see, gouthamr agrees that we should merge the migration patches :P | 18:14 |
gouthamr | ganso: lol | 18:14 |
ganso | gouthamr: I am re-reading the access rules spec | 18:15 |
*** jcsp has joined #openstack-manila | 18:15 | |
ganso | gouthamr: I can't find where it is explained how the recovery mode is triggered, besides restarting the service | 18:15 |
*** ociuhandu has joined #openstack-manila | 18:15 | |
ganso | gouthamr: so based on that I assume that there is no more recovery mode based on error-ed rules? | 18:16 |
gouthamr | ganso: yep. there's no recovery mode | 18:17 |
gouthamr | ganso: what sort of recovery are you expecting? | 18:17 |
ganso | gouthamr: if we have rules that are conflicting, and cannot be removed individually, they always error out | 18:17 |
gouthamr | ganso: access-denies should not error out at the driver, ever; unless we genuinely can't deny a rule for a legit reason | 18:18 |
gouthamr | ganso: now, you could have a smaller set of rules errored out than before.... | 18:18 |
ganso | gouthamr: and the only way to fix that is passing add_rules=[] and delete_rules=[] so drivers can clear everything out and reapply... restarting the service looks very brutal way to do trigger that | 18:18 |
ganso | gouthamr: this is the recovery mechanism that was discussed in Tokyo, before we had update_access, there was a use case for this, having to clear all the rules and add them back | 18:19 |
gouthamr | ganso: i wonder what the use case is. if there is a use case, shouldn't there be an API for it? | 18:20 |
*** ociuhandu has quit IRC | 18:20 | |
gouthamr | ganso: which process internally needs a recovery mechanism, today? | 18:20 |
gouthamr | ganso: iirc migration doesn't. | 18:21 |
ganso | gouthamr: only access rules | 18:21 |
ganso | gouthamr: bswartz mentioned that yesterday, that is one of the benefits of update_access, and we would be crippling that | 18:22 |
gouthamr | ganso: hmmm, yes, we don't have any need for it imo. You saw me introduce a "resync" parameter.. but i didn't mention it in the spec because it's going to go away | 18:22 |
ganso | gouthamr: are you saying the updates are not going to run recursively anymore? | 18:24 |
gouthamr | ganso: not sure what you mean by that.. we get a request, we ask for the driver to update rules and while the driver is updating rules, we ignore any further requests.. when the driver returns, we call it again if there's more work to be done. | 18:29 |
ganso | gouthamr: "call it again": that's the resync, isn't it? | 18:29 |
gouthamr | ganso: that's not "resync" - that's just apply the remaining changes... resync would mean to call the driver with no rules in transitional states | 18:30 |
gouthamr | ganso: i.e, just say, these are the rules i'm expecting you to have - and add_rules and delete_rules will be [] | 18:30 |
gouthamr | ganso: like you mentioned before | 18:30 |
ganso | gouthamr: I call that recovery mode lol | 18:31 |
gouthamr | ganso: names. | 18:32 |
gouthamr | ganso: yes, so there's no recovery mode | 18:32 |
*** pcaruana has joined #openstack-manila | 18:34 | |
tbarron | so if there is a use case we could add a resync api that puts all rules in add rules and passes a flag to the driver saying to delete any rules not in add rules. But there is no way for OpenStack to know what the driver has that might ought to be deleted in a resync. | 18:40 |
*** ociuhandu has joined #openstack-manila | 18:41 | |
tbarron | or a driver could return a status to the share manager that says "resync me" to get all the current rules as add-rules | 18:41 |
gouthamr | tbarron: the resync API can actually pass add_rules=[] and delete_rules=[] | 18:47 |
gouthamr | tbarron: currently drivers expect that to "resync" | 18:48 |
gouthamr | tbarron: drivers that don't have a way to mass-commit rules onto the back end.. | 18:48 |
tbarron | gouthamr: yeah, I realized as I wrote that you'd need to pass the deletes that are in flight. | 18:48 |
gouthamr | i'm wondering if it's time to introduce the "resync" API, or just not worry about it until we have a use case. there's no need for it in any current workflow... | 18:49 |
tbarron | gouthamr: YAGNI | 18:50 |
tbarron | gouthamr: and if you do, you'll find out when you do | 18:50 |
gouthamr | tbarron: +1 | 18:50 |
*** nherciu has quit IRC | 19:08 | |
ganso | gouthamr, tbarron: we had motivations to introduce that before, for me it doesn't feel like it won't cause any damage if we remove | 19:10 |
*** rraja has quit IRC | 19:13 | |
*** mtanino has joined #openstack-manila | 19:24 | |
*** gouthamr has quit IRC | 19:39 | |
*** gouthamr has joined #openstack-manila | 20:03 | |
*** senk has quit IRC | 20:03 | |
openstackgerrit | Mark Sturdevant proposed openstack/manila: GPFS KNFS fix deny access to succeed when possible https://review.openstack.org/413762 | 20:07 |
openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Add create_share_from_snapshot_support extra spec https://review.openstack.org/356683 | 20:08 |
*** pcaruana has quit IRC | 20:11 | |
*** senk has joined #openstack-manila | 20:21 | |
openstackgerrit | Mark Sturdevant proposed openstack/manila: GPFS KNFS: Do not reuse ssh prefix in loop https://review.openstack.org/413239 | 20:32 |
*** senk has quit IRC | 20:32 | |
*** lpetrut has joined #openstack-manila | 20:32 | |
openstackgerrit | Mark Sturdevant proposed openstack/manila: GPFS KNFS fix deny access to succeed when possible https://review.openstack.org/413762 | 20:33 |
*** senk has joined #openstack-manila | 20:36 | |
*** chlong has quit IRC | 20:36 | |
*** senk has quit IRC | 20:38 | |
*** chlong has joined #openstack-manila | 20:52 | |
openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Add create_share_from_snapshot_support extra spec https://review.openstack.org/356683 | 20:55 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: NetApp cDOT: Add Intra-vserver migration support https://review.openstack.org/413783 | 20:56 |
*** porrua has quit IRC | 21:07 | |
openstackgerrit | Tom Barron proposed openstack/manila: WIP - Remove NovaNetworkPlugin https://review.openstack.org/410450 | 21:09 |
openstackgerrit | Dirk Mueller proposed openstack/python-manilaclient: Add Constraints support https://review.openstack.org/413339 | 21:51 |
*** cknight has quit IRC | 21:52 | |
*** gouthamr has quit IRC | 21:58 | |
*** lpetrut has quit IRC | 22:01 | |
*** chlong has quit IRC | 22:04 | |
*** ganso has quit IRC | 22:23 | |
*** tommylikehu_ has quit IRC | 22:45 | |
*** tommylikehu_ has joined #openstack-manila | 22:47 | |
*** tommylik_ has joined #openstack-manila | 22:47 | |
*** tommylikehu_ has quit IRC | 22:47 | |
*** gouthamr has joined #openstack-manila | 22:53 | |
*** xyang1 has quit IRC | 22:58 | |
*** lseki has quit IRC | 23:00 | |
*** tommylik_ has quit IRC | 23:03 | |
openstackgerrit | Mark Sturdevant proposed openstack/manila: GPFS KNFS: Do not reuse ssh prefix in loop https://review.openstack.org/413239 | 23:34 |
*** catintheroof has joined #openstack-manila | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!