*** Suyi_ has quit IRC | 00:07 | |
*** yangyapeng has quit IRC | 00:18 | |
*** kaisers has joined #openstack-manila | 00:34 | |
*** kaisers1 has quit IRC | 00:35 | |
*** kaisers_ has joined #openstack-manila | 00:52 | |
*** kaisers_ has quit IRC | 00:56 | |
*** akshai_ has quit IRC | 01:10 | |
*** chlong_ has joined #openstack-manila | 01:14 | |
*** yangyapeng has joined #openstack-manila | 01:30 | |
*** ganso has quit IRC | 01:45 | |
*** chlong_ has quit IRC | 01:49 | |
openstackgerrit | zzxwill proposed openstack/manila: Put all imports from manila.i18n in one line https://review.openstack.org/361099 | 01:53 |
---|---|---|
*** StraubTW has joined #openstack-manila | 02:04 | |
*** chlong_ has joined #openstack-manila | 02:06 | |
*** ociuhandu has joined #openstack-manila | 02:09 | |
*** gouthamr has quit IRC | 02:15 | |
*** martyt has joined #openstack-manila | 02:16 | |
*** martyt has quit IRC | 02:21 | |
*** kaisers_ has joined #openstack-manila | 02:41 | |
*** kaisers_ has quit IRC | 02:45 | |
openstackgerrit | Merged openstack/manila: HPE 3PAR: file share support of AD in devref https://review.openstack.org/366045 | 02:49 |
openstackgerrit | zhongjun proposed openstack/manila: Add share_type filter support to pool_list https://review.openstack.org/365617 | 03:09 |
openstackgerrit | Merged openstack/manila: Updated from global requirements https://review.openstack.org/368110 | 03:09 |
openstackgerrit | Merged openstack/manila: Fix typo in response status code https://review.openstack.org/367731 | 03:09 |
*** jcsp has quit IRC | 03:10 | |
*** StraubTW has quit IRC | 03:13 | |
openstackgerrit | Bin Zhou proposed openstack/manila: Modify use of assertTrue(A in B) https://review.openstack.org/368767 | 03:14 |
*** rhefner has joined #openstack-manila | 03:29 | |
*** dustins has joined #openstack-manila | 03:31 | |
*** senk has joined #openstack-manila | 03:35 | |
*** sticker has joined #openstack-manila | 03:39 | |
*** kaisers_ has joined #openstack-manila | 03:51 | |
*** senk has quit IRC | 04:08 | |
*** netapp has quit IRC | 04:25 | |
*** netapp has joined #openstack-manila | 04:28 | |
*** timcl has quit IRC | 04:39 | |
*** rooneym has quit IRC | 04:49 | |
*** timcl has joined #openstack-manila | 04:52 | |
*** senk has joined #openstack-manila | 05:09 | |
*** amitkqed has quit IRC | 05:16 | |
*** amitkqed has joined #openstack-manila | 05:16 | |
*** ociuhandu has quit IRC | 05:27 | |
*** lpetrut has joined #openstack-manila | 05:31 | |
*** jcsp has joined #openstack-manila | 05:34 | |
*** dsariel has joined #openstack-manila | 05:41 | |
*** senk has quit IRC | 05:55 | |
openstackgerrit | zzxwill proposed openstack/manila: Put all imports from manila.i18n in one line https://review.openstack.org/361099 | 05:55 |
*** nkrinner_afk is now known as nkrinner | 06:00 | |
*** nherciu has joined #openstack-manila | 06:30 | |
*** senk has joined #openstack-manila | 06:30 | |
openstackgerrit | zhongjun proposed openstack/manila: Add share_type filter support to pool_list https://review.openstack.org/365617 | 06:41 |
*** nherciu has quit IRC | 06:44 | |
*** lpetrut has quit IRC | 06:45 | |
*** pcaruana has joined #openstack-manila | 07:02 | |
*** kaisers_ has quit IRC | 07:04 | |
*** lpetrut has joined #openstack-manila | 07:09 | |
*** nherciu has joined #openstack-manila | 07:10 | |
*** akapil has joined #openstack-manila | 07:29 | |
*** nherciu has quit IRC | 07:32 | |
openstackgerrit | zzxwill proposed openstack/manila: Put all imports from manila.i18n in one line https://review.openstack.org/361099 | 07:33 |
*** nherciu has joined #openstack-manila | 07:35 | |
*** lpetrut has quit IRC | 07:35 | |
*** dsariel has quit IRC | 07:46 | |
*** openstackgerrit has quit IRC | 07:48 | |
*** openstackgerrit has joined #openstack-manila | 07:49 | |
*** aovchinnikov has joined #openstack-manila | 07:55 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [docs] Update dev docs for ZFSonLinux share driver https://review.openstack.org/366856 | 08:04 |
*** dsariel has joined #openstack-manila | 08:07 | |
*** tpatzig_ has joined #openstack-manila | 08:18 | |
*** tpatzig has quit IRC | 08:20 | |
*** mkoderer has quit IRC | 08:20 | |
*** mkoderer has joined #openstack-manila | 08:21 | |
*** zigo_ is now known as zigo | 08:34 | |
*** kaisers_ has joined #openstack-manila | 08:52 | |
*** kaisers_ has quit IRC | 08:57 | |
*** lpetrut has joined #openstack-manila | 09:09 | |
*** yangyapeng has quit IRC | 10:17 | |
*** permalac has joined #openstack-manila | 10:17 | |
*** yangyapeng has joined #openstack-manila | 10:18 | |
*** yangyapeng has quit IRC | 10:22 | |
*** tpatzig_ has quit IRC | 10:25 | |
*** mkoderer has quit IRC | 10:25 | |
*** cknight has joined #openstack-manila | 10:40 | |
*** kaisers_ has joined #openstack-manila | 10:41 | |
*** gouthamr_ has joined #openstack-manila | 10:45 | |
*** kaisers_ has quit IRC | 10:46 | |
*** permalac has quit IRC | 10:51 | |
*** rooneym has joined #openstack-manila | 11:01 | |
*** ganso has joined #openstack-manila | 11:20 | |
ganso | gouthamr_: ping | 11:21 |
*** gouthamr_ has quit IRC | 11:25 | |
openstackgerrit | Merged openstack/manila: [ZFSonLinux] Add test coverage for share migration https://review.openstack.org/366833 | 11:49 |
*** nkrinner has quit IRC | 11:58 | |
*** nkrinner has joined #openstack-manila | 12:02 | |
*** dsariel has quit IRC | 12:04 | |
*** nkrinner has quit IRC | 12:09 | |
*** nkrinner has joined #openstack-manila | 12:23 | |
*** jcsp has quit IRC | 12:26 | |
*** dmellado is now known as dmellado|lunch | 12:27 | |
*** dmellado|lunch is now known as dmellado | 12:27 | |
*** kaisers_ has joined #openstack-manila | 12:30 | |
*** permalac has joined #openstack-manila | 12:33 | |
*** kaisers_ has quit IRC | 12:35 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Fix for LV mounting issue in docker containers https://review.openstack.org/353463 | 12:39 |
*** xyang1 has joined #openstack-manila | 12:42 | |
*** StraubTW has joined #openstack-manila | 12:52 | |
openstackgerrit | zzxwill proposed openstack/manila: Put all imports from manila.i18n in one line https://review.openstack.org/361099 | 12:57 |
*** rraja has joined #openstack-manila | 13:02 | |
ganso | bswartz: ping | 13:07 |
*** akapil has quit IRC | 13:09 | |
*** akapil has joined #openstack-manila | 13:11 | |
bswartz | ganso: in a meeting | 13:12 |
cknight | csaba, rraja: Please see question on your GlusterFS bugfix. https://review.openstack.org/#/c/352167/ | 13:13 |
csaba | cknight: thanks for reaching out to us. Yes, it does :) | 13:14 |
cknight | csaba: Thanks. What is the possibility of seeing both Gluster CI runs pass? Can you show that with a dependent patch? | 13:15 |
ganso | bswartz: Hi Ben. When you have some time, there are several patches waiting to be backported. They already got +1s, please take a look: https://review.openstack.org/368007, https://review.openstack.org/364352, https://review.openstack.org/354694, https://review.openstack.org/356167, https://review.openstack.org/354812, https://review.openstack.org/355256, | 13:15 |
ganso | https://review.openstack.org/352668, https://review.openstack.org/328544. | 13:15 |
csaba | cknight: Rodrigo has called for a recheck and the results just has arrived in 10 minutes. both gluster jobs are passing now! | 13:17 |
cknight | csaba: Great, thanks. | 13:17 |
*** jcsp has joined #openstack-manila | 13:18 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix useless statements in unit tests https://review.openstack.org/368065 | 13:21 |
*** yangyapeng has joined #openstack-manila | 13:22 | |
*** eharney has joined #openstack-manila | 13:24 | |
*** akshai has joined #openstack-manila | 13:36 | |
openstackgerrit | Clinton Knight proposed openstack/manila: Fix flaky Neutron port binding unit tests https://review.openstack.org/369462 | 13:38 |
*** akerr has joined #openstack-manila | 13:39 | |
*** vbellur has quit IRC | 13:42 | |
*** gouthamr has joined #openstack-manila | 13:42 | |
gouthamr | ganso: hey! | 13:43 |
*** ociuhandu has joined #openstack-manila | 13:43 | |
ganso | gouthamr: hello Goutham! good morning | 13:47 |
*** erlon has quit IRC | 13:47 | |
ganso | gouthamr: I saw that you changed the bug to "triaged". So I assume it does not make sense to use it in my patch anymore | 13:49 |
ganso | gouthamr: I am unfamiliar with the term "triaged", so I was unsure if it is better to can it or not, since the behavior that was the bug is now the behavior we want | 13:51 |
gouthamr | ganso: Goodmorning! yep.. we 'triaged' the issue and went with a resolution.. however, that bug may be a candidate for "invalid" or "wont fix" | 13:52 |
gouthamr | ganso: i just wanted to leave the notes of our discussion on the bug.. | 13:52 |
ganso | gouthamr: oh, now I get it, like a "trial"... I googled for "triage" and found stuff related to medicine o_O | 13:53 |
gouthamr | ganso: :P probably a derivative.. | 13:54 |
ganso | gouthamr: ok, I am opening a new bug | 13:54 |
ganso | gouthamr: ideally, we should get together and "trial" about the nondisruptive | 13:55 |
ganso | gouthamr: so we can change the code asap | 13:55 |
*** vbellur has joined #openstack-manila | 13:57 | |
*** akshai has quit IRC | 13:58 | |
*** akshai has joined #openstack-manila | 13:59 | |
*** baojg has joined #openstack-manila | 14:01 | |
*** baojg has quit IRC | 14:01 | |
*** baojg has joined #openstack-manila | 14:02 | |
*** baojg has quit IRC | 14:02 | |
*** baojg has joined #openstack-manila | 14:02 | |
*** baojg has quit IRC | 14:03 | |
*** eharney has quit IRC | 14:03 | |
*** baojg has joined #openstack-manila | 14:03 | |
*** baojg has quit IRC | 14:03 | |
*** baojg has joined #openstack-manila | 14:04 | |
*** senk has quit IRC | 14:06 | |
*** kaisers_ has joined #openstack-manila | 14:09 | |
openstackgerrit | zzxwill proposed openstack/manila: Put all imports from manila.i18n in one line https://review.openstack.org/361099 | 14:14 |
*** baojg has quit IRC | 14:14 | |
*** baojg has joined #openstack-manila | 14:16 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Fix for LV mounting issue in docker containers https://review.openstack.org/353463 | 14:18 |
*** kaisers_ has quit IRC | 14:18 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix allow/deny error message and race in migration https://review.openstack.org/365136 | 14:20 |
*** nherciu has quit IRC | 14:23 | |
gouthamr | ganso: yep.. whenever you're free. i think that nondisruptive must be True by default, in line with 'writable' and 'preserve_metadata'.. | 14:25 |
gouthamr | ganso: serves two purposes: 1) people who expect migrations to be nondisruptive all the time can see a failure and react to it, rather than expect no disruption and be unpleasantly surprised. | 14:26 |
gouthamr | ganso: 2) makes for a better user (admin) experience when all three checkboxes are ticked (that result in running only driver assisted migrations) instead of just two of the three flags | 14:27 |
*** kaisers_ has joined #openstack-manila | 14:28 | |
*** aovchinnikov has quit IRC | 14:29 | |
openstackgerrit | Merged openstack/manila: Fix useless statements in unit tests https://review.openstack.org/368065 | 14:29 |
*** baojg has quit IRC | 14:30 | |
openstackgerrit | Merged openstack/manila: [docs] Update dev docs for ZFSonLinux share driver https://review.openstack.org/366856 | 14:30 |
*** kaisers_ has quit IRC | 14:34 | |
*** kaisers_ has joined #openstack-manila | 14:35 | |
*** kaisers__ has joined #openstack-manila | 14:37 | |
*** eharney has joined #openstack-manila | 14:37 | |
*** kaisers_ has quit IRC | 14:38 | |
*** kaisers__ has quit IRC | 14:42 | |
*** kaisers_ has joined #openstack-manila | 14:44 | |
*** vbellur has quit IRC | 14:45 | |
*** nkrinner is now known as nkrinner_afk | 14:48 | |
*** porrua has joined #openstack-manila | 14:55 | |
*** vbellur has joined #openstack-manila | 14:56 | |
*** kaisers_ has quit IRC | 15:02 | |
*** erlon has joined #openstack-manila | 15:04 | |
mkoderer__ | cknight: ping | 15:08 |
cknight | mkoderer__: pong | 15:11 |
cknight | mkoderer__: welcome back | 15:11 |
cknight | mkoderer__: I wasn't sure you were back, so I fixed the unit test issue. Hope that's OK. | 15:12 |
mkoderer__ | cknight: I am still on vacation and don't have time to test ;) - if you delete the mock in time.time does it mean that it runs for some seconds? | 15:12 |
mkoderer__ | cknight: I am back next week actually ;) | 15:12 |
cknight | mkoderer__: No, I made sure of that. Sleep is still mocked. | 15:12 |
mkoderer__ | cknight: ahh ok that fine | 15:13 |
mkoderer__ | cknight: thanks for fixing! | 15:13 |
cknight | mkoderer__: Glad to. Enjoy the rest of your vacation! | 15:13 |
mkoderer__ | thanks! | 15:13 |
*** kaisers_ has joined #openstack-manila | 15:21 | |
*** vbellur has quit IRC | 15:30 | |
*** gouthamr has quit IRC | 15:30 | |
*** vbellur has joined #openstack-manila | 15:30 | |
*** gouthamr has joined #openstack-manila | 15:35 | |
*** akapil has quit IRC | 15:40 | |
ganso | gouthamr: sorry for the delay | 15:45 |
ganso | gouthamr: just got back from lunch | 15:45 |
ganso | gouthamr: my argument is that migration should be expected to always be disruptive, unless in special cases where drivers can migrate non-disruptively | 15:46 |
ganso | gouthamr: it should be exception, not the norm | 15:47 |
*** kaisers_ has quit IRC | 15:48 | |
*** akshai has quit IRC | 15:56 | |
*** lpetrut has quit IRC | 15:58 | |
*** akshai has joined #openstack-manila | 15:59 | |
*** timcl has quit IRC | 16:08 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix allow/deny error message and race in migration https://review.openstack.org/365136 | 16:10 |
*** akshai has quit IRC | 16:19 | |
*** permalac has quit IRC | 16:20 | |
*** akshai has joined #openstack-manila | 16:21 | |
*** akshai has quit IRC | 16:25 | |
*** akshai has joined #openstack-manila | 16:26 | |
*** timcl has joined #openstack-manila | 16:26 | |
*** nherciu has joined #openstack-manila | 16:28 | |
*** alyson_ has joined #openstack-manila | 16:46 | |
openstackgerrit | Merged openstack/manila: Fix flaky Neutron port binding unit tests https://review.openstack.org/369462 | 16:55 |
*** pcaruana has quit IRC | 16:59 | |
*** aovchinnikov has joined #openstack-manila | 17:02 | |
*** dustins has joined #openstack-manila | 17:03 | |
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted now to address current performance problems, but should return to a working state within a few minutes | 17:10 | |
openstackgerrit | Merged openstack/manila: Fix for LV mounting issue in docker containers https://review.openstack.org/353463 | 17:19 |
*** lpetrut has joined #openstack-manila | 17:36 | |
*** Suyi_ has joined #openstack-manila | 17:37 | |
*** akerr has quit IRC | 17:38 | |
*** akerr has joined #openstack-manila | 17:39 | |
gouthamr | ganso: (sorry for the latency) i understand that, but some people might "accidentally" kick off a disruptive migration when they really wanted manila to only migrate if it can be nondisruptive | 17:40 |
*** sandanar has joined #openstack-manila | 17:42 | |
bswartz | gouthamr, tbarron: you've probably seen the answers to my inquiry about string freezes on the stable branches by now | 17:43 |
gouthamr | bswartz: on this thread? http://lists.openstack.org/pipermail/openstack-dev/2016-September/103279.html | 17:44 |
bswartz | yeah | 17:44 |
bswartz | looks like it was my mistake to -1 backports containing translatable strings | 17:45 |
gouthamr | bswartz: if i understand correctly, the stance is important bugfixes can introduce/change existing translatable strings? | 17:45 |
bswartz | no | 17:45 |
bswartz | the theory is that string freeze ENDS after the release is cut | 17:45 |
gouthamr | bswartz: oh! | 17:45 |
gouthamr | bswartz: #TIL. thank you for clarifying. | 17:46 |
bswartz | gouthamr: we wouldn't have reached this conclusion if you hadn't pushed for it. thanks for starting the thread | 17:49 |
gouthamr | bswartz: you're welcome.. | 17:49 |
*** dustins has quit IRC | 17:57 | |
*** senk has joined #openstack-manila | 17:58 | |
*** sandanar has quit IRC | 18:02 | |
*** ociuhandu has quit IRC | 18:07 | |
*** akshai has quit IRC | 18:17 | |
ganso | gouthamr: ping | 18:20 |
gouthamr | ganso: pong | 18:20 |
ganso | gouthamr: I believe the "non-disruptive" default value change will require a microversion | 18:21 |
ganso | gouthamr: it is a bit too late for that :\ | 18:21 |
gouthamr | ganso: it's unreleased yet, and the last API change .. so we can make this a bugfix? | 18:22 |
ganso | gouthamr: no microversion bump? | 18:22 |
gouthamr | ganso: not sure.. i vote no.. because it's still unreleased and we've made no other API changes after 2.22 | 18:23 |
*** david-lyle has quit IRC | 18:23 | |
*** david-lyle has joined #openstack-manila | 18:26 | |
*** dsariel has joined #openstack-manila | 18:32 | |
*** esker has joined #openstack-manila | 18:34 | |
*** pcaruana has joined #openstack-manila | 18:36 | |
*** alyson_ has quit IRC | 18:38 | |
*** alyson_ has joined #openstack-manila | 18:38 | |
*** akshai has joined #openstack-manila | 18:40 | |
*** akshai_ has joined #openstack-manila | 18:41 | |
*** akshai has quit IRC | 18:45 | |
*** akerr has quit IRC | 18:48 | |
*** akerr has joined #openstack-manila | 18:51 | |
bswartz | gouthamr, tpsilva: https://bugs.launchpad.net/manila/+bug/1609841 | 19:00 |
openstack | Launchpad bug 1609841 in Manila "Access allow/deny APIs get stuck due to concurrency" [High,Confirmed] - Assigned to Goutham Pacha Ravi (gouthamr) | 19:00 |
bswartz | I see a bug targeted but I see no fixes | 19:01 |
*** esker has quit IRC | 19:01 | |
*** vbellur has quit IRC | 19:03 | |
bswartz | alyson_: how is https://review.openstack.org/#/c/366310/ going | 19:10 |
bswartz | alyson_: also https://review.openstack.org/#/c/356087/ | 19:12 |
ganso | bswartz: those 2 should be ready tomorrow | 19:12 |
bswartz | ganso: https://review.openstack.org/#/c/366324/ this doesn't need a RC1 target | 19:12 |
bswartz | does it? | 19:12 |
ganso | bswartz: its purpose was to identify bugs | 19:13 |
ganso | bswartz: since we can see that the tests pass without needing to merge, it does not need to merge before RC1 | 19:13 |
*** dustins has joined #openstack-manila | 19:13 | |
bswartz | yeah | 19:13 |
bswartz | generally speaking, increasing test coverage doesn't need a bug/blueprint | 19:13 |
ganso | bswartz: yes, generally speaking, no | 19:15 |
*** aovchinnikov has quit IRC | 19:15 | |
ganso | bswartz: https://review.openstack.org/#/c/365136 | 19:16 |
*** david-lyle has quit IRC | 19:16 | |
*** eharney has quit IRC | 19:16 | |
*** gregsfortytwo has quit IRC | 19:16 | |
*** bhakta has quit IRC | 19:16 | |
*** dsariel has quit IRC | 19:16 | |
*** jcsp has quit IRC | 19:16 | |
*** amitkqed has quit IRC | 19:16 | |
*** hoonetorg has quit IRC | 19:16 | |
*** cknight has quit IRC | 19:17 | |
*** cargonza has quit IRC | 19:17 | |
*** sage_ has quit IRC | 19:17 | |
*** dgonzalez has quit IRC | 19:17 | |
*** madorn has quit IRC | 19:17 | |
*** markstur has quit IRC | 19:17 | |
*** vkmc has quit IRC | 19:17 | |
*** tbarron has quit IRC | 19:17 | |
*** cFouts has quit IRC | 19:17 | |
*** logan- has quit IRC | 19:17 | |
*** porrua has quit IRC | 19:17 | |
*** StraubTW has quit IRC | 19:17 | |
*** rooneym has quit IRC | 19:17 | |
*** zigo has quit IRC | 19:17 | |
*** zhongjun_ has quit IRC | 19:17 | |
*** cfey has quit IRC | 19:17 | |
*** andreaf has quit IRC | 19:17 | |
*** senk has quit IRC | 19:17 | |
*** zengyingzhe has quit IRC | 19:17 | |
*** darrenc has quit IRC | 19:17 | |
*** scottda has quit IRC | 19:17 | |
*** ChanServ has quit IRC | 19:17 | |
*** lpetrut has quit IRC | 19:17 | |
*** nkrinner_afk has quit IRC | 19:17 | |
*** zhugaoxiao has quit IRC | 19:17 | |
*** ameade has quit IRC | 19:17 | |
*** FL1SK has quit IRC | 19:17 | |
*** alyson_ has quit IRC | 19:17 | |
*** yangyapeng has quit IRC | 19:17 | |
*** rraja has quit IRC | 19:17 | |
*** harlowja has quit IRC | 19:17 | |
*** mkoderer__ has quit IRC | 19:17 | |
*** tries_ has quit IRC | 19:17 | |
*** erlon has quit IRC | 19:17 | |
*** ganso has quit IRC | 19:17 | |
*** amit213 has quit IRC | 19:17 | |
*** _laco has quit IRC | 19:17 | |
*** Suyi_ has quit IRC | 19:17 | |
*** nherciu has quit IRC | 19:17 | |
*** rhefner has quit IRC | 19:17 | |
*** MikeG451 has quit IRC | 19:17 | |
*** jseiler_ has quit IRC | 19:17 | |
*** aorourke has quit IRC | 19:18 | |
*** chlong_ has quit IRC | 19:18 | |
*** gouthamr has quit IRC | 19:18 | |
*** netapp has quit IRC | 19:18 | |
*** jay-mehta has quit IRC | 19:18 | |
*** dustins has quit IRC | 19:18 | |
*** pcaruana has quit IRC | 19:18 | |
*** xyang1 has quit IRC | 19:18 | |
*** kaisers has quit IRC | 19:18 | |
*** bswartz has quit IRC | 19:18 | |
*** DuncanT has quit IRC | 19:18 | |
*** furlongm has quit IRC | 19:18 | |
*** kaisers2 has quit IRC | 19:18 | |
*** johnthetubaguy has quit IRC | 19:18 | |
*** timcl has quit IRC | 19:18 | |
*** openstackgerrit has quit IRC | 19:18 | |
*** sticker has quit IRC | 19:18 | |
*** gopenshaw has quit IRC | 19:18 | |
*** csaba has quit IRC | 19:18 | |
*** draynium has quit IRC | 19:18 | |
*** bkreitch has quit IRC | 19:18 | |
*** vponomaryov has quit IRC | 19:18 | |
*** diegows has quit IRC | 19:18 | |
*** draynium has joined #openstack-manila | 19:19 | |
*** johnthetubaguy has joined #openstack-manila | 19:22 | |
*** bhakta has joined #openstack-manila | 19:22 | |
*** gregsfortytwo has joined #openstack-manila | 19:22 | |
*** eharney has joined #openstack-manila | 19:22 | |
*** chlong_ has joined #openstack-manila | 19:22 | |
*** kaisers has joined #openstack-manila | 19:22 | |
*** pcaruana has joined #openstack-manila | 19:22 | |
*** FL1SK has joined #openstack-manila | 19:22 | |
*** ameade has joined #openstack-manila | 19:22 | |
*** zhugaoxiao has joined #openstack-manila | 19:22 | |
*** nkrinner_afk has joined #openstack-manila | 19:22 | |
*** lpetrut has joined #openstack-manila | 19:22 | |
*** jay-mehta has joined #openstack-manila | 19:22 | |
*** bswartz has joined #openstack-manila | 19:22 | |
*** _laco has joined #openstack-manila | 19:22 | |
*** ganso has joined #openstack-manila | 19:22 | |
*** 32NABYQA1 has joined #openstack-manila | 19:22 | |
*** dsariel has joined #openstack-manila | 19:22 | |
*** david-lyle has joined #openstack-manila | 19:22 | |
*** ChanServ has joined #openstack-manila | 19:22 | |
*** netapp has joined #openstack-manila | 19:22 | |
*** gouthamr has joined #openstack-manila | 19:22 | |
*** porrua has joined #openstack-manila | 19:22 | |
*** StraubTW has joined #openstack-manila | 19:22 | |
*** rooneym has joined #openstack-manila | 19:22 | |
*** zigo has joined #openstack-manila | 19:22 | |
*** zhongjun_ has joined #openstack-manila | 19:22 | |
*** cfey has joined #openstack-manila | 19:22 | |
*** andreaf has joined #openstack-manila | 19:22 | |
*** amitkqed has joined #openstack-manila | 19:22 | |
*** Suyi_ has joined #openstack-manila | 19:22 | |
*** nherciu has joined #openstack-manila | 19:22 | |
*** rhefner has joined #openstack-manila | 19:22 | |
*** MikeG451 has joined #openstack-manila | 19:22 | |
*** jseiler_ has joined #openstack-manila | 19:22 | |
*** aorourke has joined #openstack-manila | 19:22 | |
*** furlongm has joined #openstack-manila | 19:22 | |
*** cknight has joined #openstack-manila | 19:22 | |
*** markstur has joined #openstack-manila | 19:22 | |
*** sage_ has joined #openstack-manila | 19:22 | |
*** dgonzalez has joined #openstack-manila | 19:22 | |
*** madorn has joined #openstack-manila | 19:22 | |
*** tbarron has joined #openstack-manila | 19:22 | |
*** vkmc has joined #openstack-manila | 19:22 | |
*** cFouts has joined #openstack-manila | 19:22 | |
*** logan- has joined #openstack-manila | 19:22 | |
*** orwell.freenode.net sets mode: +o ChanServ | 19:22 | |
*** xyang1 has joined #openstack-manila | 19:23 | |
*** timcl has joined #openstack-manila | 19:23 | |
*** openstackgerrit has joined #openstack-manila | 19:23 | |
*** sticker has joined #openstack-manila | 19:23 | |
*** gopenshaw has joined #openstack-manila | 19:23 | |
*** csaba has joined #openstack-manila | 19:23 | |
*** bkreitch has joined #openstack-manila | 19:23 | |
*** vponomaryov has joined #openstack-manila | 19:23 | |
*** diegows has joined #openstack-manila | 19:23 | |
*** hoonetorg has joined #openstack-manila | 19:23 | |
*** jcsp has joined #openstack-manila | 19:23 | |
*** dustins has joined #openstack-manila | 19:23 | |
*** yangyapeng has joined #openstack-manila | 19:23 | |
*** rraja has joined #openstack-manila | 19:23 | |
*** harlowja has joined #openstack-manila | 19:23 | |
*** tries_ has joined #openstack-manila | 19:23 | |
*** mkoderer__ has joined #openstack-manila | 19:23 | |
*** senk has joined #openstack-manila | 19:23 | |
*** zengyingzhe has joined #openstack-manila | 19:23 | |
*** darrenc has joined #openstack-manila | 19:23 | |
*** ameade has quit IRC | 19:24 | |
*** nherciu has quit IRC | 19:27 | |
*** draynium has quit IRC | 19:29 | |
*** draynium has joined #openstack-manila | 19:34 | |
*** porrua has quit IRC | 19:36 | |
*** scottda has joined #openstack-manila | 19:46 | |
*** akshai_ has quit IRC | 19:48 | |
*** lpetrut has quit IRC | 19:51 | |
ganso | bswartz: finally reconnected | 19:55 |
*** dsariel has quit IRC | 19:56 | |
*** erlon has joined #openstack-manila | 19:58 | |
*** DuncanT has joined #openstack-manila | 19:59 | |
*** amit213 has joined #openstack-manila | 19:59 | |
*** eharney has quit IRC | 19:59 | |
*** eharney has joined #openstack-manila | 19:59 | |
*** cargonza has joined #openstack-manila | 20:03 | |
*** rraja has quit IRC | 20:03 | |
*** ameade has joined #openstack-manila | 20:04 | |
ganso | bswartz: so, can we merge that one before RC1? | 20:04 |
bswartz | ganso: you're going to have to recreate the context | 20:08 |
bswartz | the netsplit killed my scrollback and I think I missed the last few lines you wrote | 20:08 |
ganso | bswartz: what merged before the FF had a logic in allow_access intended to allow the admin to mount the share between phase 1 and 2 | 20:09 |
ganso | bswartz: but that logic was broken | 20:09 |
ganso | bswartz: so the patch is fixing the logic, and fixing another concurrency bug | 20:10 |
ganso | bswartz: due to our discussion yesterday, the logic in allow_access is to prevent access now, nlloq | 20:11 |
*** pcaruana has quit IRC | 20:11 | |
ganso | bswartz: s/nlloq/allow | 20:11 |
ganso | bswartz: nevermind that last part, my keyboard messed up | 20:13 |
ganso | bswartz: so, current patch is preventing any access during migration | 20:13 |
*** akerr has quit IRC | 20:15 | |
*** vbellur has joined #openstack-manila | 20:17 | |
*** kaisers_ has joined #openstack-manila | 20:20 | |
*** trinode has joined #openstack-manila | 20:20 | |
*** trinode has quit IRC | 20:24 | |
bswartz | ganso: which current patch? the proposed one or the merged one? | 20:24 |
ganso | bswartz: proposed one | 20:24 |
bswartz | I thought we agreed that change should wait until ocata | 20:25 |
bswartz | you want to make it in newton? | 20:25 |
bswartz | you claimed it was proposed and agreed to at the midcycle so we shouldn't just change it without having the discussion again | 20:26 |
ganso | bswartz: but it is broken | 20:26 |
ganso | bswartz: it needs to be fix either to fully allow access or block it | 20:26 |
bswartz | I thought you had a fix hat makes it not broken | 20:26 |
bswartz | I was okay with your fix | 20:27 |
ganso | bswartz: this is the fix https://review.openstack.org/#/c/365136/ | 20:27 |
bswartz | I was just confused because the fix shrank a lot | 20:27 |
ganso | bswartz: yes, it was allowing admins to mount the share between phase 1 and phase 2 | 20:27 |
bswartz | I'm okay with this | 20:27 |
ganso | bswartz: but yesterday we had the discussion that we wanted to not allow | 20:27 |
bswartz | I haven't had time to properly review the updated change | 20:28 |
ganso | bswartz: so I changed the code to not to | 20:28 |
bswartz | did you see my +2 comment on PS5? | 20:28 |
bswartz | oh | 20:28 |
ganso | bswartz: I did after I pushed PS 6 | 20:29 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Fix Access Rules APIs https://review.openstack.org/369668 | 20:29 |
bswartz | gouthamr: \o/ | 20:29 |
bswartz | ganso: well what would you like to do? | 20:29 |
bswartz | I can't remember who asked for the "verify" feature, but I'm against it | 20:30 |
ganso | bswartz: thing is, that change, up to PS #5, was changing the driver interface and was introducing behavior that we agreed we prefer to not have right now, and maybe add it later in ocata if we find it to be necessary | 20:30 |
ganso | bswartz: up to PS #5 it had the verify feature | 20:30 |
ganso | bswartz: now the verify feature is removed in latest PS | 20:31 |
ganso | bswartz: we just need to merge it to fix broken API message | 20:31 |
bswartz | ganso: so you prefer PS9 to PS5? | 20:32 |
bswartz | if so I'll just review it and provide feedback on the new patch | 20:32 |
ganso | bswartz: we agreed PS 9 is what we want, because we don't want to allow the admin to verify at this moment | 20:32 |
*** esker has joined #openstack-manila | 20:33 | |
ganso | gouthamr: got a question, before digging into the code | 20:33 |
gouthamr | ganso: ask away.. | 20:34 |
ganso | gouthamr: in commit message it says state transitions from new, active, error, etc to deleted. why was this status 'deleted' necessary, I thought that we already had this before when we deny the rules | 20:35 |
*** cknight has quit IRC | 20:35 | |
gouthamr | ganso: when the rules were deleted, they wouldn't update the "state" -> because there was no "state" in the database | 20:35 |
gouthamr | ganso: but with soft_delete, you can ask for a state change.. consistency with the rest of the models | 20:36 |
ganso | gouthamr: deleted = Column(String(36), default='False') | 20:36 |
gouthamr | ganso: yes, the weird thing about having state and not updating it when deleted is realizing that soft deleted rows have statuses that make no sense.. | 20:37 |
ganso | gouthamr: when rules were deleted, before, they were not accounted for anymore | 20:37 |
ganso | gouthamr: oh I mean, you had a deleted = True rule with status 'Active', is that it? | 20:37 |
gouthamr | ganso: yep. that behavior's not changed.. is that line in the commit message confusing? | 20:37 |
gouthamr | ganso: yah | 20:37 |
ganso | gouthamr: thanks, I got it now. | 20:38 |
ganso | gouthamr: no it is not, I was just wondering it that state was attached to any other mechanism | 20:38 |
ganso | gouthamr: it looks better this way | 20:38 |
ganso | gouthamr: *if that state | 20:38 |
gouthamr | ganso: yes | 20:40 |
*** lpetrut has joined #openstack-manila | 20:43 | |
ganso | gouthamr: I gotta go home now, I'll review the patch tonight | 20:46 |
openstackgerrit | Merged openstack/manila: glusterfs: handle new cli XML format https://review.openstack.org/352167 | 20:46 |
gouthamr | ganso: thank you.. | 20:50 |
openstackgerrit | Carlos Camacho proposed openstack/puppet-manila: Test latest puppet-lint https://review.openstack.org/369688 | 21:02 |
*** harlowja has quit IRC | 21:04 | |
*** eharney has quit IRC | 21:14 | |
*** kaisers_ has quit IRC | 21:20 | |
*** lpetrut has quit IRC | 21:21 | |
*** lpetrut has joined #openstack-manila | 21:21 | |
*** amit213 has quit IRC | 21:27 | |
*** erlon has quit IRC | 21:27 | |
*** scottda has quit IRC | 21:27 | |
*** jcsp has quit IRC | 21:27 | |
*** dustins has quit IRC | 21:27 | |
*** yangyapeng has quit IRC | 21:27 | |
*** mkoderer__ has quit IRC | 21:27 | |
*** tries_ has quit IRC | 21:28 | |
*** tries_ has joined #openstack-manila | 21:28 | |
*** tries_ has quit IRC | 21:28 | |
*** tries_ has joined #openstack-manila | 21:28 | |
*** jcsp has joined #openstack-manila | 21:28 | |
*** dustins has joined #openstack-manila | 21:28 | |
*** yangyapeng has joined #openstack-manila | 21:28 | |
*** gouthamr has quit IRC | 21:28 | |
*** mkoderer__ has joined #openstack-manila | 21:29 | |
*** scottda has joined #openstack-manila | 21:34 | |
*** amit213 has joined #openstack-manila | 21:34 | |
*** erlon has joined #openstack-manila | 21:35 | |
*** lpetrut has quit IRC | 21:38 | |
*** gouthamr has joined #openstack-manila | 21:45 | |
*** dustins has quit IRC | 21:54 | |
*** esker has quit IRC | 21:54 | |
*** harlowja has joined #openstack-manila | 22:03 | |
*** xyang1 has quit IRC | 22:03 | |
*** erlon has quit IRC | 22:07 | |
*** ociuhandu has joined #openstack-manila | 22:16 | |
*** rooneym has quit IRC | 22:29 | |
*** dsariel has joined #openstack-manila | 22:33 | |
*** StraubTW has quit IRC | 22:56 | |
*** dsariel has quit IRC | 23:36 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!