| *** haomaiwang has quit IRC | 00:01 | |
| *** haomaiwang has joined #openstack-manila | 00:01 | |
| *** gouthamr has joined #openstack-manila | 00:06 | |
| *** jcsp has joined #openstack-manila | 00:09 | |
| *** tbarron has joined #openstack-manila | 00:17 | |
| *** furlongm has joined #openstack-manila | 00:17 | |
| *** dalgaaf has quit IRC | 00:18 | |
| *** martyturner has quit IRC | 00:22 | |
| *** merooney has joined #openstack-manila | 00:25 | |
| *** akerr has joined #openstack-manila | 00:32 | |
| *** akerr is now known as akerr_away | 00:57 | |
| *** haomaiwang has quit IRC | 01:01 | |
| *** haomaiwang has joined #openstack-manila | 01:01 | |
| *** yangyapeng has joined #openstack-manila | 01:01 | |
| *** yangyapeng has quit IRC | 01:02 | |
| *** yangyapeng has joined #openstack-manila | 01:10 | |
| *** jasonsb has joined #openstack-manila | 01:12 | |
| openstackgerrit | xing-yang proposed openstack/python-manilaclient: CLI for manage/unmanage snapshot https://review.openstack.org/249544 | 01:14 |
|---|---|---|
| *** merooney has quit IRC | 01:15 | |
| openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs/ganesha: add symbolic access-id to export location https://review.openstack.org/286346 | 01:18 |
| *** merooney has joined #openstack-manila | 01:20 | |
| *** akerr_away has quit IRC | 01:22 | |
| *** haomaiwang has quit IRC | 01:26 | |
| *** alkhodos has quit IRC | 01:27 | |
| *** gouthamr_ has joined #openstack-manila | 01:28 | |
| *** gouthamr has quit IRC | 01:30 | |
| openstackgerrit | liucheng proposed openstack/manila: Add QoS description in Huawei https://review.openstack.org/274335 | 01:30 |
| openstackgerrit | Merged openstack/python-manilaclient: Client Support for Manila Share Replication https://review.openstack.org/235448 | 01:51 |
| *** mtanino has quit IRC | 01:55 | |
| *** haomaiwa_ has joined #openstack-manila | 02:07 | |
| *** merooney has quit IRC | 02:08 | |
| *** baojg has joined #openstack-manila | 02:08 | |
| *** a_ta has joined #openstack-manila | 02:12 | |
| *** gouthamr_ has quit IRC | 02:15 | |
| *** a_ta has quit IRC | 02:16 | |
| *** baojg has quit IRC | 02:24 | |
| *** baojg has joined #openstack-manila | 02:26 | |
| *** baojg has quit IRC | 02:26 | |
| *** baojg has joined #openstack-manila | 02:34 | |
| *** houming has joined #openstack-manila | 02:38 | |
| openstackgerrit | zhaohua proposed openstack/manila: Huawei driver code review https://review.openstack.org/285094 | 02:39 |
| *** akerr has joined #openstack-manila | 02:56 | |
| openstackgerrit | xing-yang proposed openstack/python-manilaclient: CLI for manage/unmanage snapshot https://review.openstack.org/249544 | 03:00 |
| *** haomaiwa_ has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-manila | 03:01 | |
| *** a_ta has joined #openstack-manila | 03:13 | |
| *** a_ta has quit IRC | 03:18 | |
| *** cknight has joined #openstack-manila | 03:18 | |
| *** baojg has quit IRC | 03:19 | |
| *** baojg has joined #openstack-manila | 03:21 | |
| *** cknight has quit IRC | 03:36 | |
| *** akerr has quit IRC | 03:40 | |
| *** rhagarty_ has joined #openstack-manila | 03:55 | |
| *** cknight has joined #openstack-manila | 03:56 | |
| *** rhagarty has quit IRC | 03:58 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** cknight has quit IRC | 04:01 | |
| *** haomaiwang has joined #openstack-manila | 04:01 | |
| *** rhagarty_ has quit IRC | 04:02 | |
| *** chlong_ has quit IRC | 04:03 | |
| *** shausy has joined #openstack-manila | 04:03 | |
| *** cknight has joined #openstack-manila | 04:19 | |
| *** haomaiwang has quit IRC | 04:21 | |
| *** haomaiwang has joined #openstack-manila | 04:26 | |
| *** cknight has quit IRC | 04:56 | |
| *** cknight has joined #openstack-manila | 04:57 | |
| *** cknight has quit IRC | 04:57 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-manila | 05:01 | |
| *** shausy has quit IRC | 05:04 | |
| *** nkrinner has joined #openstack-manila | 05:19 | |
| *** baojg has quit IRC | 05:25 | |
| *** baojg has joined #openstack-manila | 05:37 | |
| openstackgerrit | xing-yang proposed openstack/python-manilaclient: CLI for manage/unmanage snapshot https://review.openstack.org/249544 | 05:43 |
| *** haomaiwang has quit IRC | 05:45 | |
| *** haomaiwang has joined #openstack-manila | 05:45 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: LXC/LXD driver https://review.openstack.org/245751 | 05:47 |
| *** esker has quit IRC | 05:49 | |
| *** esker has joined #openstack-manila | 05:50 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-manila | 06:01 | |
| *** baojg has quit IRC | 06:18 | |
| *** baojg has joined #openstack-manila | 06:23 | |
| *** lpetrut has joined #openstack-manila | 06:41 | |
| *** deepakcs has joined #openstack-manila | 06:46 | |
| *** deepakcs has left #openstack-manila | 06:52 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-manila | 07:01 | |
| *** a_ta has joined #openstack-manila | 07:14 | |
| *** lpetrut has quit IRC | 07:17 | |
| *** a_ta has quit IRC | 07:19 | |
| *** esker has quit IRC | 07:50 | |
| *** esker has joined #openstack-manila | 07:54 | |
| *** rraja has joined #openstack-manila | 07:57 | |
| *** haomaiwang has quit IRC | 07:59 | |
| *** haomaiwang has joined #openstack-manila | 07:59 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-manila | 08:01 | |
| openstackgerrit | Ramana Raja proposed openstack/manila: Add Ceph Native driver https://review.openstack.org/270211 | 08:03 |
| *** pcaruana has joined #openstack-manila | 08:09 | |
| openstackgerrit | Ramana Raja proposed openstack/manila: Add Ceph Native driver https://review.openstack.org/270211 | 08:31 |
| *** ociuhandu has quit IRC | 08:31 | |
| *** openstackgerrit has quit IRC | 08:48 | |
| *** openstackgerrit has joined #openstack-manila | 08:48 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-manila | 09:01 | |
| *** baojg has quit IRC | 09:03 | |
| *** baojg has joined #openstack-manila | 09:19 | |
| *** ociuhandu has joined #openstack-manila | 09:35 | |
| *** lpetrut has joined #openstack-manila | 09:36 | |
| *** yangyapeng has quit IRC | 09:40 | |
| *** yangyapeng has joined #openstack-manila | 09:40 | |
| *** a_ta has joined #openstack-manila | 09:55 | |
| openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs.common: move the numreduct function to toplevel https://review.openstack.org/282069 | 09:57 |
| openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs_native: relocate module under glusterfs https://review.openstack.org/280935 | 09:57 |
| openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs-native: use Heketi layout via self-signing https://review.openstack.org/282101 | 09:58 |
| openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs: heketi: Add support for JWT Auth https://review.openstack.org/280486 | 09:58 |
| openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs: introducing Heketi layout https://review.openstack.org/279090 | 09:58 |
| *** ociuhandu has quit IRC | 09:59 | |
| *** a_ta has quit IRC | 10:00 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-manila | 10:01 | |
| *** yangyapeng has quit IRC | 10:23 | |
| -openstackstatus- NOTICE: Gerrit is going to be restarted due to poor performance | 10:36 | |
| *** ChanServ changes topic to "Gerrit is going to be restarted due to poor performance" | 10:36 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: LXC/LXD driver https://review.openstack.org/245751 | 10:37 |
| *** baojg has quit IRC | 10:41 | |
| *** baojg has joined #openstack-manila | 10:41 | |
| *** ChanServ changes topic to "OpenStack Manila Project" | 10:42 | |
| -openstackstatus- NOTICE: gerrit finished restartign | 10:42 | |
| *** haomaiwang has quit IRC | 11:01 | |
| tbarron | vponomaryov: bswartz: see infra patch https://review.openstack.org/286497 and -1 if you odn't think it makes sense | 11:01 |
| *** haomaiwang has joined #openstack-manila | 11:01 | |
| tbarron | vponomaryov: bswartz: I submitted it, and on the face of things it does :) | 11:01 |
| *** chlong_ has joined #openstack-manila | 11:01 | |
| vponomaryov | tbarron: what about update of "run_tests.sh"? | 11:03 |
| tbarron | vponomaryov: I didn't add any patterns in that I didn't see for the other projects. | 11:04 |
| vponomaryov | tbarron: I like this idea | 11:04 |
| tbarron | vponomaryov: so feel free to make a second commit there | 11:05 |
| tbarron | vponomaryov: I was being "careful" not to over-reach given that I don't usually commit to infra | 11:05 |
| tbarron | vponomaryov: or to manila for that mattter :-) | 11:05 |
| tbarron | vponomaryov: similar change for cinder just merged | 11:05 |
| vponomaryov | tbarron: in "Live cinder" you wanted to say "liKe Cinder"? | 11:05 |
| tbarron | vponomaryov: yeah, I'll fix that right now. cinder is only partly alive :-) | 11:06 |
| vponomaryov | )) | 11:06 |
| vponomaryov | then ,please, add mentioned file too | 11:06 |
| vponomaryov | cinder may just no have it | 11:07 |
| *** baojg has quit IRC | 11:07 | |
| tbarron | vponomaryov: will do | 11:07 |
| vponomaryov | tbarron: checked, cinder has this file too | 11:07 |
| vponomaryov | tbarron: but it would be correct to add this file there too | 11:07 |
| vponomaryov | tbarron: thank you | 11:07 |
| tbarron | vponomaryov: nova has it too, but it is irrelevant to dsvm, etc. so I will add it and see what infra folks say | 11:08 |
| vponomaryov | tbarron: "infra folks say:? Remembered this - https://www.youtube.com/watch?v=CuZBfX2mW7s )) | 11:09 |
| tbarron | vponomaryov: that woke me up | 11:15 |
| tbarron | vponomaryov: patch set #2 is up, as you specified | 11:15 |
| vponomaryov | tbarron: ty +1'ed | 11:15 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Add ZFSonLinux share driver https://review.openstack.org/277192 | 11:35 |
| *** esker has quit IRC | 11:40 | |
| *** ociuhandu has joined #openstack-manila | 11:40 | |
| *** esker has joined #openstack-manila | 11:40 | |
| *** tpsilva has joined #openstack-manila | 11:44 | |
| *** houming has quit IRC | 11:45 | |
| rraja | vponomaryov: any idea on when python-manilaclient is going to be tagged for M3? | 11:46 |
| vponomaryov | rraja: answer is - no strict time | 11:49 |
| vponomaryov | rraja: if it is needed then it is done | 11:49 |
| vponomaryov | rraja: if you need it, say it | 11:49 |
| vponomaryov | rraja: but anyway it should be after we have FF | 11:50 |
| vponomaryov | rraja: with support of replication feature, for example | 11:50 |
| rraja | vponomaryov: cool! thanks! i wanted to make sure that adding cephx access type (https://review.openstack.org/#/c/274952/) wouldn't miss the Mitaka boat. we were more concerned about getting the Ceph driver merged first. | 11:52 |
| *** zhonghua-lee has quit IRC | 11:53 | |
| vponomaryov | rraja: you are interested in getting it upstream first | 11:54 |
| vponomaryov | rraja: then asking for tagging )) | 11:54 |
| *** zhonghua-lee has joined #openstack-manila | 11:54 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** a_ta has joined #openstack-manila | 12:01 | |
| *** haomaiwang has joined #openstack-manila | 12:01 | |
| *** a_ta has quit IRC | 12:05 | |
| *** bogdans has joined #openstack-manila | 12:12 | |
| *** bogdans has quit IRC | 12:12 | |
| *** ganso has joined #openstack-manila | 12:15 | |
| ganso | vponomaryov: ping | 12:15 |
| vponomaryov | ganso: hello! )) | 12:16 |
| ganso | vponomaryov: Hello! =) | 12:16 |
| vponomaryov | ganso: have you managed to get some sleep? )0 | 12:16 |
| ganso | vponomaryov: not much :\ | 12:16 |
| vponomaryov | ganso: ok, how I can help you? | 12:17 |
| ganso | vponomaryov: I saw your comment saying that LOG.exception() should receive exceptions as arguments | 12:17 |
| vponomaryov | it can | 12:17 |
| ganso | vponomaryov: Clinton suggested me to do: LOG.exception(_LE("Could not cleanup access rule of share %s."), self.share['id']) in another comment | 12:18 |
| vponomaryov | it "should" be used only when exception exists in trace info | 12:18 |
| vponomaryov | ganso: I would add exception there in addition to such message | 12:18 |
| ganso | vponomaryov: ok, thanks! | 12:19 |
| ganso | vponomaryov: if I add the exception to the message like "foobar message. Error: %s" % e | 12:28 |
| ganso | vponomaryov: wouldn't that "% e " be the same as six.text_type(e) ? | 12:29 |
| vponomaryov | ganso: LOG.exception is designed to show traces as well | 12:29 |
| vponomaryov | ganso: that is why it requries presence of a raised exception | 12:30 |
| vponomaryov | ganso: you cannot call it without trace | 12:30 |
| ganso | vponomaryov: yes, it would show trace if it is invoke inside a catch, it does not need the exception as argument | 12:30 |
| vponomaryov | yes | 12:30 |
| ganso | vponomaryov: so, there should not be a need to include the exception in the LOG.exception() argument | 12:31 |
| ganso | vponomaryov: it is already included in trace | 12:31 |
| vponomaryov | should be so, yes | 12:31 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] do not merge 1 https://review.openstack.org/286558 | 12:47 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] do not merge 2 https://review.openstack.org/286560 | 12:48 |
| *** gouthamr has joined #openstack-manila | 12:58 | |
| *** haomaiwang has quit IRC | 13:01 | |
| *** haomaiwang has joined #openstack-manila | 13:01 | |
| *** timcl has joined #openstack-manila | 13:03 | |
| *** haomaiwang has quit IRC | 13:15 | |
| *** furlongm has quit IRC | 13:16 | |
| *** haomaiwang has joined #openstack-manila | 13:17 | |
| *** furlongm has joined #openstack-manila | 13:21 | |
| *** haomaiwang has quit IRC | 13:22 | |
| *** akerr has joined #openstack-manila | 13:32 | |
| *** furlongm_ has joined #openstack-manila | 13:38 | |
| *** haomaiwang has joined #openstack-manila | 13:40 | |
| *** furlongm has quit IRC | 13:40 | |
| *** haomaiwang has quit IRC | 13:40 | |
| *** haomaiwa_ has joined #openstack-manila | 13:41 | |
| bswartz | who needs code reviews? | 13:57 |
| *** haomaiwa_ has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-manila | 14:01 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: NetApp: Add Replication support in cDOT https://review.openstack.org/275416 | 14:03 |
| *** martyturner has joined #openstack-manila | 14:05 | |
| *** furlongm_ is now known as furlongm | 14:09 | |
| *** baojg has joined #openstack-manila | 14:10 | |
| csaba | bswartz: gluster jobs are unbroken now. People need not feel intimidated now to review gluster* changes :) | 14:10 |
| *** ociuhandu has quit IRC | 14:15 | |
| *** ociuhandu has joined #openstack-manila | 14:16 | |
| *** baojg has quit IRC | 14:21 | |
| gouthamr | ganso: ping | 14:21 |
| *** ociuhandu has quit IRC | 14:21 | |
| ganso | gouthamr: pong | 14:23 |
| gouthamr | hi ganso! Are you still reviewing the replication changeset for cDOT? | 14:24 |
| ganso | gouthamr: I am updating a patch right now, will resume reviewing it going through the unit tests soon | 14:24 |
| *** baojg has joined #openstack-manila | 14:25 | |
| *** furlongm_ has joined #openstack-manila | 14:25 | |
| gouthamr | ganso: sure np, i'll make the changes you suggested in the meanwhile.. | 14:26 |
| *** furlongm has quit IRC | 14:26 | |
| gouthamr | ganso: the RPO thing however, is intentionally left unconfigurable for Mitaka | 14:26 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix NFS helper root squashing in RW access level https://review.openstack.org/286296 | 14:26 |
| ganso | gouthamr: why | 14:26 |
| gouthamr | ganso: the strongest reason being we didn't want the administrator to redefine it; for the sake of performance. we may integrate some logic around that in Newton.. | 14:28 |
| gouthamr | ganso: its harder to deprecate a configuration option once it is out there | 14:29 |
| *** Yogi1 has joined #openstack-manila | 14:29 | |
| ganso | gouthamr: I don't know why you should restrain the administrator for making a change that may be necessary. The admin may want to increase or decrease the value based on his infrastructure | 14:30 |
| gouthamr | ganso: the admin has the option to 'resync'.. | 14:30 |
| bswartz | csaba: :-D | 14:31 |
| *** nkrinner has quit IRC | 14:31 | |
| gouthamr | ganso: since this is a driver-wide option, it needs a better thought atm. | 14:31 |
| ganso | gouthamr: he may want to always resync, and not update his replica based on a schedule, and vice-versa | 14:31 |
| ganso | gouthamr: I don't see the need to configure it per replica as more important as the admin being able to control the schedule for the backend | 14:32 |
| gouthamr | ganso: hmmm, probably for a replication_domain | 14:33 |
| *** eharney has joined #openstack-manila | 14:33 | |
| ganso | gouthamr: in this case, yes | 14:34 |
| gouthamr | ganso: interesting thought. Will think about this / confer with bswartz | 14:34 |
| *** ociuhandu has joined #openstack-manila | 14:34 | |
| gouthamr | ganso: thanks for pointing that out. | 14:35 |
| ganso | gouthamr: np ^^ | 14:35 |
| *** ociuhandu has quit IRC | 14:39 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Implement admin network in generic driver https://review.openstack.org/278699 | 14:41 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Introduced Data Service https://review.openstack.org/244286 | 14:44 |
| *** furlongm_ has quit IRC | 14:44 | |
| *** ociuhandu has joined #openstack-manila | 14:47 | |
| *** furlongm_ has joined #openstack-manila | 14:47 | |
| *** xyang1 has joined #openstack-manila | 14:48 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: LXC/LXD driver https://review.openstack.org/245751 | 14:52 |
| ameade | ganso: posted a comment on the change | 14:57 |
| ameade | ganso: yeah in Newton we want to configure the RPO for replication, but it's not trivial as we will have to manage cron schedules on the backend | 14:58 |
| ameade | ganso: so for now it's just an hour | 14:58 |
| *** baojg has quit IRC | 14:59 | |
| *** a_ta has joined #openstack-manila | 15:00 | |
| openstackgerrit | Alex Meade proposed openstack/manila: NetApp: Add Replication support in cDOT https://review.openstack.org/275416 | 15:00 |
| ameade | ganso: ^ new PS, thanks for the review! | 15:00 |
| *** haomaiwang has quit IRC | 15:01 | |
| *** haomaiwa_ has joined #openstack-manila | 15:01 | |
| *** dustins has joined #openstack-manila | 15:03 | |
| openstackgerrit | Alex Meade proposed openstack/manila: NetApp: Add Replication support in cDOT https://review.openstack.org/275416 | 15:10 |
| *** rhagarty has joined #openstack-manila | 15:18 | |
| *** lpetrut has quit IRC | 15:19 | |
| *** rhagarty_ has joined #openstack-manila | 15:21 | |
| *** rhagarty has quit IRC | 15:24 | |
| *** rhagarty_ has quit IRC | 15:25 | |
| *** merooney has joined #openstack-manila | 15:26 | |
| *** mtanino has joined #openstack-manila | 15:27 | |
| *** dustins_ has joined #openstack-manila | 15:28 | |
| openstackgerrit | Alex Meade proposed openstack/manila: NetApp: Add Replication support in cDOT https://review.openstack.org/275416 | 15:28 |
| *** dustins has quit IRC | 15:29 | |
| ganso | ameade: I see you added ".called" | 15:30 |
| ganso | ameade: no parameter validation? | 15:31 |
| ameade | ganso: only where it makes sense, all the parameters are validated in the positive tests | 15:33 |
| *** esker has quit IRC | 15:43 | |
| *** merooney has quit IRC | 15:43 | |
| *** esker has joined #openstack-manila | 15:44 | |
| vponomaryov | ameade: is it correct that using "get_backend_configuration" in https://review.openstack.org/#/c/275416/14/manila/share/drivers/netapp/dataontap/cluster_mode/data_motion.py you assume that there is duplicated config files on all manila hosts? | 15:44 |
| gouthamr | vponomaryov: yes, that is a requirement for replication in cDOT drivers. it will be documented. | 15:45 |
| ameade | vponomaryov: yeah it's a requirement | 15:45 |
| vponomaryov | ameade: have you considered usage of driver private data and write all required data by each driver? | 15:45 |
| vponomaryov | ameade: before replication operations calls, that could just use it | 15:46 |
| ameade | yeah, what do you do when something changes? admin cant just update driver private data with a new pass or ip | 15:46 |
| bswartz | vponomaryov: that approach makes it impossible to cope with password and IP address changes | 15:46 |
| vponomaryov | why? we have 'ensure' and "do_setup" methods | 15:47 |
| vponomaryov | those could make appropriate updates | 15:47 |
| vponomaryov | without any problems | 15:47 |
| ameade | all that doesnt sound more complicated than having it in the conf? | 15:47 |
| ameade | and how do you get the info in the first place? | 15:47 |
| vponomaryov | in lots of confs | 15:48 |
| vponomaryov | where diff should not sneak in | 15:48 |
| ameade | if I have a large deployment and I am managing all the different confs by hand, I will have bigger problems | 15:48 |
| bswartz | yeah the config files should be generated from puppet or something similar | 15:49 |
| *** Yogi1 has quit IRC | 15:50 | |
| vponomaryov | usage of orchestration does not proof absense of diffs | 15:50 |
| vponomaryov | s/proof/prove/ | 15:51 |
| vponomaryov | actually confs should have diffs | 15:51 |
| vponomaryov | at least in scope of enabled backends | 15:51 |
| bswartz | puppet can handle that kind of thing | 15:52 |
| bswartz | and puppet can keep passwords in sync across all conf files | 15:52 |
| bswartz | It's not clear to me how to admin would even inform manila that the password has changed without putting it in a config file and restarting the service | 15:53 |
| vponomaryov | bswartz: driver can handle it | 15:53 |
| bswartz | fixing up driver private data in do_setup() is only possible when the driver knows the password has changed and has access to the value for the new password | 15:53 |
| vponomaryov | so, it is correct to say: that current implementation requires thing that can be avoided | 15:55 |
| vponomaryov | avoided just changing logic of a driver | 15:55 |
| *** haomaiwa_ has quit IRC | 16:01 | |
| *** haomaiwang has joined #openstack-manila | 16:01 | |
| ganso | bswartz: ping | 16:04 |
| *** merooney has joined #openstack-manila | 16:05 | |
| ameade | vponomaryov: I think it's more accurate to say we are avoiding the complexity | 16:06 |
| ameade | as a deployer, i would prefer to have everythign laid out in the confs | 16:07 |
| *** cknight has joined #openstack-manila | 16:08 | |
| *** Yogi1 has joined #openstack-manila | 16:10 | |
| *** chlong_ has quit IRC | 16:10 | |
| vponomaryov | ameade: it still will be in confs, complexity just changed place, now it is more outside of a driver than could be | 16:12 |
| vponomaryov | ameade: and current solution is good for developer, not deployer | 16:13 |
| ameade | vponomaryov: i dont think it's quite as complex, I prefer it explicitly laid out though | 16:13 |
| ameade | i disagree, i think it's better for both | 16:13 |
| gouthamr | vponomaryov: it is good for a deployer too. | 16:13 |
| gouthamr | vponomaryov: i feel replication_domain having a string value can be misspelt ; but then we decided to do it that way.. i don't see how adding all the replica backends in every conf file in every AZ would be hard.. | 16:14 |
| ameade | I'm not a fan of having a lot of magic going on behind the scenes | 16:15 |
| bswartz | ganso: pong | 16:15 |
| ganso | bswartz: Hello Ben. Do you know by any chance if Clinton tested migration yesterday? | 16:16 |
| ganso | bswartz: oh, cknight has joined now | 16:16 |
| bswartz | ganso: we both tested many things | 16:16 |
| bswartz | but better to ask cknight | 16:16 |
| bswartz | ganso: personally I still have not reviewed migration patches in detail | 16:16 |
| ganso | bswartz: ok. I am addressing markstur concerns right now, and will upload a new patch soon | 16:17 |
| *** Yogi1 has quit IRC | 16:24 | |
| *** dustins_ is now known as dustins | 16:28 | |
| vponomaryov | bswartz: we do not have milestone m-3 for https://launchpad.net/python-manilaclient | 16:29 |
| vponomaryov | bswartz: so, it is unclear do we miss something or not | 16:30 |
| vponomaryov | bswartz: to be writtne/reviewed/merged | 16:30 |
| bswartz | https://review.openstack.org/#/q/is:open+project:openstack/python-manilaclient | 16:31 |
| bswartz | the list is short | 16:31 |
| bswartz | bugs are lower priority, unless they're related to a BP | 16:32 |
| bswartz | I agree there *should* be a milestone on LP, but since there isn't we just have to use gerrit | 16:32 |
| *** absubram has joined #openstack-manila | 16:32 | |
| *** absubram_ has joined #openstack-manila | 16:33 | |
| *** rhagarty has joined #openstack-manila | 16:34 | |
| *** absubram has quit IRC | 16:37 | |
| *** absubram_ is now known as absubram | 16:37 | |
| *** eharney has quit IRC | 16:39 | |
| jcsp | what's going on with changing the definition of update_access()? We're having comments on the cephfs driver review about changing add_rules to not default to None, but it is still that way in master | 16:39 |
| jcsp | it seems weird to be changing our function to have a different prototype to the parent class | 16:39 |
| jcsp | in the expectation of changing the parent class in a later patch | 16:40 |
| *** eharney has joined #openstack-manila | 16:41 | |
| jcsp | (context: https://review.openstack.org/#/c/270211/41/manila/share/drivers/cephfs/cephfs_native.py) | 16:41 |
| *** timcl has quit IRC | 16:41 | |
| jcsp | obviously we can modify this, repush etc if it's really necessary, but it seems really weird | 16:41 |
| tpsilva | jcsp: the parent class will be changed in a later patch, so will be the drivers that are using default to None | 16:42 |
| tpsilva | jcsp: but you can already change your driver to remove that | 16:43 |
| bswartz | tpsilva: where is that later patch? | 16:43 |
| *** timcl has joined #openstack-manila | 16:43 | |
| tpsilva | bswartz: waiting for the drivers to merge | 16:43 |
| tpsilva | bswartz: so we know which drivers need to be changed | 16:43 |
| tpsilva | the bug is already logged on LP, right? | 16:43 |
| bswartz | seems like we could put that patch up, and update it as needed | 16:44 |
| tpsilva | right | 16:44 |
| tpsilva | I can do that | 16:44 |
| ganso | cknight: ping | 16:44 |
| *** Yogi1 has joined #openstack-manila | 16:44 | |
| tpsilva | I'm finishing that previous bugfix on the update_access... I can upload that change after I finish this | 16:44 |
| Yogi1 | vponomaryov cknight bswartz toabctl xyang1 Please review - https://review.openstack.org/#/c/286706/ and let me know if you have any comments. Thanks! | 16:47 |
| ganso | jcsp: I recommend not changing the method signature right now | 16:47 |
| *** dustins has quit IRC | 16:49 | |
| jcsp | ganso: OK, so I have a comment from vponomaryov asking me to change it, could you guys reach a conclusion for me? | 16:50 |
| ganso | jcsp: I replied to the comment | 16:50 |
| ganso | vponomaryov: ping | 16:51 |
| jcsp | ganso: k, thanks | 16:51 |
| vponomaryov | jcsp: my comment is notification that default value being applied will blow up logic of this method | 16:51 |
| vponomaryov | ganso: pong | 16:51 |
| ganso | vponomaryov: why will it blow up? | 16:51 |
| vponomaryov | ganso: because "None" is not expected anymore | 16:52 |
| bswartz | ganso: he iterates over the value without checking for none first | 16:52 |
| ganso | vponomaryov: condition validating None was removed | 16:52 |
| ganso | vponomaryov: because that code will never receive None value for add_rules or delete_rules | 16:52 |
| vponomaryov | ganso: one more reason to change it | 16:53 |
| ganso | vponomaryov: cknight and I talked about that, signatures will be changed to not have default values | 16:53 |
| *** toabctl has quit IRC | 16:53 | |
| ganso | vponomaryov: driver code should be in sync with current signature, changing of signature is unrelated to driver code, will be a separate patch | 16:53 |
| vponomaryov | Yogi1: added couple of comments | 16:54 |
| *** toabctl has joined #openstack-manila | 16:57 | |
| *** Yogi1 has quit IRC | 16:57 | |
| *** haomaiwang has quit IRC | 17:01 | |
| *** haomaiwa_ has joined #openstack-manila | 17:01 | |
| *** pcaruana has quit IRC | 17:07 | |
| *** lpetrut has joined #openstack-manila | 17:07 | |
| *** timcl has quit IRC | 17:09 | |
| vponomaryov | markstur: looks like https://review.openstack.org/#/c/278699/ waits for you | 17:09 |
| markstur | vponomaryov, I'm on it. | 17:10 |
| *** timcl has joined #openstack-manila | 17:24 | |
| *** erlon has joined #openstack-manila | 17:27 | |
| gouthamr | bswartz: ping | 17:28 |
| cknight | ganso: pong | 17:31 |
| *** fthiagogv_ has quit IRC | 17:31 | |
| *** ftgomvier has joined #openstack-manila | 17:32 | |
| ganso | cknight: Hi Clinton. Have you had any success testing migration? | 17:33 |
| cknight | ganso: Haven't gotten back to that yet, sorry. It's on my list for this afternoon. | 17:33 |
| *** ftgomvier is now known as fthiagogv | 17:34 | |
| vponomaryov | csaba, bswartz: is heketi support in glusterfs drivers in list to be merged before FF? | 17:44 |
| vponomaryov | https://blueprints.launchpad.net/manila/+spec/smart-glusterfs-management-with-heketi marked for "liberty" oO | 17:45 |
| *** absubram has quit IRC | 17:48 | |
| *** merooney has quit IRC | 17:49 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: LXC/LXD driver https://review.openstack.org/245751 | 17:55 |
| *** aovchinnikov has joined #openstack-manila | 17:56 | |
| *** merooney has joined #openstack-manila | 17:57 | |
| *** haomaiwa_ has quit IRC | 18:01 | |
| *** haomaiwang has joined #openstack-manila | 18:01 | |
| *** porrua has quit IRC | 18:12 | |
| openstackgerrit | Alex Meade proposed openstack/manila: NetApp: Add Replication support in cDOT https://review.openstack.org/275416 | 18:16 |
| *** openstackgerrit has quit IRC | 18:18 | |
| *** openstackgerrit has joined #openstack-manila | 18:18 | |
| *** a_ta has quit IRC | 18:22 | |
| *** a_ta has joined #openstack-manila | 18:23 | |
| *** JoseMello has joined #openstack-manila | 18:23 | |
| ameade | vponomaryov, cknight, ganso: https://review.openstack.org/#/c/275416/ | 18:28 |
| *** a_ta has quit IRC | 18:28 | |
| *** Yogi1 has joined #openstack-manila | 18:28 | |
| ganso | ameade: some asserts from PS 10 and 13 are still not addressed | 18:35 |
| *** merooney has quit IRC | 18:38 | |
| *** dustins has joined #openstack-manila | 18:38 | |
| bswartz | vponomaryov: that stuff was in by the FPF deadline, at least with initial patchset | 18:38 |
| bswartz | the blueprint was mistakenly targeted to liberty -- that was my fault | 18:38 |
| bswartz | anyone from tegile here? | 18:39 |
| vponomaryov | ganso: lets make ameade happy and merge as it is now? | 18:41 |
| cknight | vponomaryov: no harm in letting NetApp CI vote. I just started that. But otherwise, I think it's good. | 18:42 |
| ganso | vponomaryov: let's wait NetApp CI | 18:42 |
| *** merooney has joined #openstack-manila | 18:44 | |
| *** lpetrut has quit IRC | 18:44 | |
| *** furlongm_ has quit IRC | 18:52 | |
| *** ociuhandu has quit IRC | 18:52 | |
| *** furlongm_ has joined #openstack-manila | 18:54 | |
| dustins | bswartz: ping | 18:54 |
| *** openstack has joined #openstack-manila | 19:17 | |
| ganso | cknight: it is a conflicting rule | 19:17 |
| ganso | cknight: it is eliminating conflict | 19:17 |
| dustins | bswartz: I can try hammering it over on my side too if it'll help | 19:17 |
| ganso | cknight: try adding different rules | 19:17 |
| bswartz | dustins: yes the goal is to find more bugs now that we've found the worst ones and have workarounds for them | 19:18 |
| cknight | ganso: OK, I can try that. | 19:18 |
| dustins | bswartz: Makes sense to me | 19:18 |
| dustins | In the spare cycles I have over here, I'll keep poking at the LVM driver and see what I can do to break it | 19:19 |
| *** openstackgerrit has joined #openstack-manila | 19:20 | |
| *** porrua has quit IRC | 19:22 | |
| *** a_ta has joined #openstack-manila | 19:22 | |
| *** porrua has joined #openstack-manila | 19:23 | |
| cknight | ganso: yes, that worked. a different access rule was preserved. | 19:23 |
| ganso | cknight: great! =D | 19:23 |
| cknight | ganso: I notice that you're recursing the file system not once but 3 times. | 19:24 |
| cknight | ganso: Are you still investigating other ways to do that? | 19:24 |
| ganso | cknight: yes, I talked to bswartz about that yesterday | 19:24 |
| bswartz | we have to do something else | 19:25 |
| bswartz | but maybe not for mitaka | 19:25 |
| ganso | cknight: no, we decided that at this moment we would go with that. But the patch I have downstream will recurse the filesystem 2.5 times | 19:25 |
| *** johnthetubaguy has quit IRC | 19:25 | |
| ganso | cknight: the 3rd time is just folders | 19:25 |
| bswartz | s/folders/directories/ | 19:26 |
| cknight | bswartz: they're manila folders | 19:26 |
| cknight | ganso: I still wish you could preserve an access rule to data_node_access_ip, but that's not a huge issue at present. | 19:27 |
| *** merooney has quit IRC | 19:27 | |
| bswartz | lol | 19:27 |
| ganso | bswartz: lol what's up with saying folders? :P | 19:28 |
| gouthamr | ganso: https://en.wikipedia.org/wiki/Manila_folder | 19:29 |
| *** martyturner has quit IRC | 19:29 | |
| openstackgerrit | Merged openstack/manila: Add share resize support to Oracle ZFSSA driver https://review.openstack.org/273935 | 19:29 |
| ganso | gouthamr: hehe | 19:30 |
| *** lpetrut has quit IRC | 19:30 | |
| *** johnthetubaguy has joined #openstack-manila | 19:31 | |
| ganso | cknight: have you tested with files? | 19:31 |
| cknight | ganso: 1 file | 19:32 |
| *** merooney has joined #openstack-manila | 19:32 | |
| cknight | ganso: That never worked before, so it's a big improvement. | 19:32 |
| ganso | cknight: =D | 19:33 |
| cknight | ganso: It didn't work until I realized you had updated the rootwrap file. | 19:33 |
| openstackgerrit | Merged openstack/manila: glusterfs_native: relocate module under glusterfs https://review.openstack.org/280935 | 19:33 |
| ganso | cknight: oh ya, that was a necessary update | 19:33 |
| openstackgerrit | Merged openstack/manila: glusterfs.common: move the numreduct function to toplevel https://review.openstack.org/282069 | 19:33 |
| *** martyturner has joined #openstack-manila | 19:33 | |
| openstackgerrit | Merged openstack/manila: glusterfs/ganesha: add symbolic access-id to export location https://review.openstack.org/286346 | 19:34 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Move Share Migration code to Data Service https://review.openstack.org/250515 | 19:34 |
| openstackgerrit | Merged openstack/manila: Add ZFSonLinux share driver https://review.openstack.org/277192 | 19:39 |
| openstackgerrit | Merged openstack/manila: Add QoS description in Huawei https://review.openstack.org/274335 | 19:39 |
| *** timcl1 has quit IRC | 19:47 | |
| openstackgerrit | Abhilash Divakaran proposed openstack/manila: Add share driver for Tegile IntelliFlash Arrays https://review.openstack.org/278169 | 19:50 |
| *** david-lyle has quit IRC | 19:59 | |
| *** haomaiwang has quit IRC | 20:01 | |
| *** haomaiwang has joined #openstack-manila | 20:01 | |
| *** merooney has quit IRC | 20:04 | |
| *** martyturner has quit IRC | 20:05 | |
| *** timcl has joined #openstack-manila | 20:05 | |
| gouthamr | ganso: https://review.openstack.org/#/c/275416/ passed in the NetApp CI ; since it's been +1ed by jenkins before, could this be +W? | 20:06 |
| *** divab is now known as abhi | 20:06 | |
| *** martyturner has joined #openstack-manila | 20:07 | |
| ganso | gouthamr: I believe it may still need Jenkins +1 before going to the gate. I may be wrong though | 20:07 |
| *** david-lyle has joined #openstack-manila | 20:09 | |
| *** Yogi1 has quit IRC | 20:11 | |
| gouthamr | ganso: could be.. thanks :) | 20:12 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Implement admin network in generic driver https://review.openstack.org/278699 | 20:12 |
| *** Yogi1 has joined #openstack-manila | 20:13 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Introduced Data Service https://review.openstack.org/244286 | 20:14 |
| *** jasonsb has quit IRC | 20:18 | |
| *** Yogi1 has quit IRC | 20:19 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Move Share Migration code to Data Service https://review.openstack.org/250515 | 20:20 |
| *** xyang1 has quit IRC | 20:21 | |
| ganso | gouthamr: it will need a recheck | 20:28 |
| gouthamr | ganso: yep.. saw a bunch of ConsistencyGroups tests fail .. will recheck when it votes :| | 20:30 |
| openstackgerrit | John Spray proposed openstack/manila: Add Ceph Native driver https://review.openstack.org/270211 | 20:30 |
| bswartz | don't break CGs pls | 20:30 |
| gouthamr | lol | 20:31 |
| *** alejandrito has joined #openstack-manila | 20:38 | |
| *** Yogi1 has joined #openstack-manila | 20:39 | |
| *** merooney has joined #openstack-manila | 20:42 | |
| *** pcaruana has joined #openstack-manila | 20:44 | |
| *** a_ta has quit IRC | 20:44 | |
| *** a_ta has joined #openstack-manila | 20:45 | |
| openstackgerrit | Yogesh proposed openstack/python-manilaclient: Annotate CLI commands for experimental features https://review.openstack.org/286706 | 20:45 |
| Yogi1 | markstur ^^ Updated for your comment | 20:48 |
| *** a_ta has quit IRC | 20:49 | |
| *** Yogi1 has quit IRC | 20:50 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 20:51 |
| *** a_ta has joined #openstack-manila | 20:52 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Move Share Migration code to Data Service https://review.openstack.org/250515 | 20:54 |
| *** merooney has quit IRC | 20:56 | |
| *** haomaiwang has quit IRC | 21:01 | |
| *** haomaiwang has joined #openstack-manila | 21:01 | |
| csaba | vponomaryov: yes I know. Can I change the target? | 21:02 |
| *** david-lyle has quit IRC | 21:08 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila: LXC/LXD driver https://review.openstack.org/245751 | 21:11 |
| *** david-lyle has joined #openstack-manila | 21:17 | |
| *** akerr has quit IRC | 21:25 | |
| *** zhonghua-lee has quit IRC | 21:30 | |
| *** zhonghua-lee has joined #openstack-manila | 21:31 | |
| *** Yogi1 has joined #openstack-manila | 21:32 | |
| *** lpetrut has joined #openstack-manila | 21:44 | |
| *** cknight has quit IRC | 21:45 | |
| *** Yogi1 has quit IRC | 21:49 | |
| *** gouthamr has quit IRC | 21:51 | |
| openstackgerrit | Merged openstack/python-manilaclient: Fix function name https://review.openstack.org/283914 | 21:53 |
| *** timcl has quit IRC | 21:53 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** pcaruana has quit IRC | 22:01 | |
| *** haomaiwang has joined #openstack-manila | 22:01 | |
| *** cknight has joined #openstack-manila | 22:11 | |
| *** cknight has quit IRC | 22:11 | |
| *** cknight has joined #openstack-manila | 22:11 | |
| *** cknight1 has joined #openstack-manila | 22:18 | |
| *** cknight has quit IRC | 22:18 | |
| *** alejandrito has quit IRC | 22:18 | |
| openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Support preferred export locations in Manila CLI https://review.openstack.org/284499 | 22:20 |
| openstackgerrit | Clinton Knight proposed openstack/manila: Update export location retrieval APIs https://review.openstack.org/282070 | 22:21 |
| *** david-lyle has quit IRC | 22:29 | |
| *** gouthamr has joined #openstack-manila | 22:31 | |
| *** gouthamr_ has joined #openstack-manila | 22:35 | |
| *** cknight1 has quit IRC | 22:35 | |
| *** JoseMello has quit IRC | 22:38 | |
| *** ayma has joined #openstack-manila | 22:39 | |
| *** gouthamr has quit IRC | 22:39 | |
| *** a_ta has quit IRC | 22:41 | |
| *** a_ta has joined #openstack-manila | 22:41 | |
| *** cknight has joined #openstack-manila | 22:43 | |
| *** a_ta has quit IRC | 22:46 | |
| *** david-lyle has joined #openstack-manila | 23:00 | |
| *** haomaiwang has quit IRC | 23:01 | |
| *** haomaiwang has joined #openstack-manila | 23:01 | |
| *** lpetrut has quit IRC | 23:06 | |
| openstackgerrit | Merged openstack/manila: Fix NFS helper root squashing in RW access level https://review.openstack.org/286296 | 23:06 |
| *** tpsilva has quit IRC | 23:07 | |
| *** chlong_ has joined #openstack-manila | 23:13 | |
| *** dustins has quit IRC | 23:15 | |
| *** porrua has quit IRC | 23:20 | |
| *** merooney has joined #openstack-manila | 23:30 | |
| *** darrenc is now known as darrenc_afk | 23:33 | |
| openstackgerrit | Merged openstack/manila: Implement admin network in generic driver https://review.openstack.org/278699 | 23:34 |
| *** david-lyle has quit IRC | 23:41 | |
| *** darrenc_afk is now known as darrenc | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!