| openstackgerrit | Merged openstack/neutron-lbaas stable/queens: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646672 | 00:42 |
|---|---|---|
| openstackgerrit | Merged openstack/neutron-lbaas stable/ocata: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646670 | 00:42 |
| openstackgerrit | Merged openstack/neutron-lbaas master: Replace openstack.org git:// URLs with https:// https://review.openstack.org/646669 | 00:45 |
| *** yamamoto has joined #openstack-lbaas | 00:48 | |
| *** yamamoto has quit IRC | 00:51 | |
| *** yamamoto has joined #openstack-lbaas | 00:58 | |
| *** yamamoto has quit IRC | 01:03 | |
| *** openstackgerrit has quit IRC | 01:30 | |
| *** yamamoto has joined #openstack-lbaas | 01:47 | |
| *** abaindur has quit IRC | 01:51 | |
| *** eandersson has joined #openstack-lbaas | 01:52 | |
| *** openstackgerrit has joined #openstack-lbaas | 02:17 | |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/octavia master: [WIP] Add thread support to health manager https://review.openstack.org/651427 | 02:17 |
| eandersson | Super WIP ^ | 02:17 |
| sapd1 | +1 | 02:26 |
| *** hongbin has joined #openstack-lbaas | 02:29 | |
| *** yamamoto has quit IRC | 02:40 | |
| *** yamamoto has joined #openstack-lbaas | 02:41 | |
| *** psachin has joined #openstack-lbaas | 03:01 | |
| *** ricolin has joined #openstack-lbaas | 03:31 | |
| *** HVT has joined #openstack-lbaas | 03:36 | |
| *** hongbin has quit IRC | 03:42 | |
| *** ramishra has joined #openstack-lbaas | 03:44 | |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/octavia master: [WIP] Add thread support to health manager https://review.openstack.org/651427 | 03:48 |
| eandersson | sapd1, rm_work, johnsom etc let me know if you have any feedback etc ^ | 04:05 |
| eandersson | We have been running this for a few weeks internally | 04:05 |
| rm_work | Hmm k I'll look tomorrow or later tonight | 04:06 |
| eandersson | Thanks - not a super important patch | 04:06 |
| eandersson | Just felt like I would try to upstream it | 04:06 |
| *** abaindur has joined #openstack-lbaas | 04:13 | |
| *** abaindur has quit IRC | 04:26 | |
| *** abaindur has joined #openstack-lbaas | 04:26 | |
| *** openstackstatus has quit IRC | 04:35 | |
| *** openstackstatus has joined #openstack-lbaas | 04:36 | |
| *** ChanServ sets mode: +v openstackstatus | 04:36 | |
| *** yamamoto has quit IRC | 04:57 | |
| *** pcaruana has joined #openstack-lbaas | 05:06 | |
| *** yamamoto has joined #openstack-lbaas | 05:07 | |
| *** yamamoto has quit IRC | 05:10 | |
| *** yamamoto has joined #openstack-lbaas | 05:10 | |
| *** ricolin has quit IRC | 05:30 | |
| *** gcheresh has joined #openstack-lbaas | 05:34 | |
| *** gcheresh has quit IRC | 05:39 | |
| rm_work | :D | 05:39 |
| *** yamamoto has quit IRC | 05:49 | |
| *** yamamoto has joined #openstack-lbaas | 05:50 | |
| openstackgerrit | Vishal Manchanda proposed openstack/neutron-lbaas-dashboard master: Fix sphinx-docs job for sphinx >1.7 https://review.openstack.org/650233 | 05:57 |
| *** ccamposr has joined #openstack-lbaas | 05:58 | |
| *** gcheresh has joined #openstack-lbaas | 06:04 | |
| *** vishalmanchanda has joined #openstack-lbaas | 06:04 | |
| *** abaindur has quit IRC | 06:25 | |
| *** yamamoto has quit IRC | 06:26 | |
| *** yamamoto has joined #openstack-lbaas | 06:27 | |
| *** yamamoto has quit IRC | 06:32 | |
| *** yamamoto has joined #openstack-lbaas | 06:38 | |
| *** luksky has joined #openstack-lbaas | 06:45 | |
| *** yamamoto has quit IRC | 06:47 | |
| *** yamamoto has joined #openstack-lbaas | 06:48 | |
| *** rpittau|afk is now known as rpittau | 07:05 | |
| *** ivve has joined #openstack-lbaas | 07:12 | |
| *** ataraday has quit IRC | 07:18 | |
| cgoncalves | eandersson, we just moved off of threads to processes around rocky, heh | 07:31 |
| *** psachin has quit IRC | 07:32 | |
| cgoncalves | eandersson, thanks for the patch! it would be great if you could add more context as to what is the problem you see with processes and why green threads | 07:32 |
| *** pcaruana has quit IRC | 07:34 | |
| *** pcaruana has joined #openstack-lbaas | 07:35 | |
| *** psachin has joined #openstack-lbaas | 07:36 | |
| *** yamamoto has quit IRC | 07:37 | |
| *** yamamoto has joined #openstack-lbaas | 07:38 | |
| *** yamamoto has quit IRC | 07:56 | |
| *** livelace has joined #openstack-lbaas | 07:58 | |
| *** lemko has joined #openstack-lbaas | 08:09 | |
| *** luksky has quit IRC | 08:11 | |
| *** yamamoto has joined #openstack-lbaas | 08:11 | |
| *** yamamoto has quit IRC | 08:22 | |
| *** ricolin has joined #openstack-lbaas | 08:30 | |
| *** luksky has joined #openstack-lbaas | 08:50 | |
| *** yamamoto has joined #openstack-lbaas | 08:54 | |
| *** livelace has quit IRC | 08:59 | |
| *** salmankhan has joined #openstack-lbaas | 09:15 | |
| *** salmankhan has quit IRC | 09:19 | |
| *** salmankhan has joined #openstack-lbaas | 09:19 | |
| openstackgerrit | Merged openstack/octavia stable/queens: Fix the API list performance regression https://review.openstack.org/650909 | 09:24 |
| cgoncalves | Queens 2.0.5 and Rocky 3.0.3 releases proposed: https://review.openstack.org/#/c/651475/ | 09:26 |
| cgoncalves | thank you every one of you for your patches and reviews! | 09:27 |
| *** yamamoto has quit IRC | 09:28 | |
| *** happyhemant has joined #openstack-lbaas | 09:32 | |
| *** livelace has joined #openstack-lbaas | 09:41 | |
| *** rcernin has quit IRC | 09:47 | |
| *** yamamoto has joined #openstack-lbaas | 09:58 | |
| *** yamamoto has quit IRC | 10:01 | |
| *** yamamoto has joined #openstack-lbaas | 10:01 | |
| *** yamamoto has quit IRC | 10:05 | |
| *** yamamoto has joined #openstack-lbaas | 10:44 | |
| *** yamamoto has quit IRC | 10:50 | |
| lxkong | cgoncalves: not sure you are the right person i should ask, but when do we plan to do a new release for python-octaviaclient? | 11:07 |
| *** HVT has left #openstack-lbaas | 11:12 | |
| cgoncalves | lxkong, hi. guessing you're asking because of https://review.openstack.org/#/c/647628/ | 11:13 |
| lxkong | cgoncalves: correct :-) | 11:13 |
| cgoncalves | lxkong, it is merged only in master. how far back would you like to have it? | 11:13 |
| cgoncalves | I mean, in which stable branch? | 11:14 |
| lxkong | ooh, i forgot the client lib also has stable branch | 11:14 |
| lxkong | let me check | 11:14 |
| cgoncalves | if would be great if you could propose the backports | 11:15 |
| lxkong | cgoncalves: we need stable/queens | 11:16 |
| lxkong | queens and rocky both have conflict, if no one is interested, i need to find time to figure out | 11:17 |
| cgoncalves | lxkong, conflicts should be due to added support to new APIs like flavors, amphora configure, etc. should be easy to resolve. let me know if you can do it, otherwise one us can take it | 11:20 |
| lxkong | cgoncalves: i will have a try tomorrow, it's 23:21 for me now | 11:21 |
| cgoncalves | lxkong, sure. thank you! let us know if you need help | 11:21 |
| lxkong | cgoncalves: cheers | 11:22 |
| *** livelace has quit IRC | 11:24 | |
| *** yamamoto has joined #openstack-lbaas | 11:26 | |
| *** sapd1 has quit IRC | 11:29 | |
| *** sapd1 has joined #openstack-lbaas | 11:29 | |
| *** lemko has quit IRC | 11:39 | |
| *** sapd1 has quit IRC | 12:00 | |
| *** sapd1 has joined #openstack-lbaas | 12:02 | |
| *** boden has joined #openstack-lbaas | 12:03 | |
| *** ricolin has quit IRC | 12:50 | |
| *** ricolin has joined #openstack-lbaas | 12:51 | |
| openstackgerrit | Merged openstack/neutron-lbaas-dashboard master: Fix sphinx-docs job for sphinx >1.7 https://review.openstack.org/650233 | 12:54 |
| *** irclogbot_2 has joined #openstack-lbaas | 13:03 | |
| *** altlogbot_3 has joined #openstack-lbaas | 13:07 | |
| *** yamamoto has quit IRC | 13:19 | |
| *** yamamoto has joined #openstack-lbaas | 13:19 | |
| *** chungpht has quit IRC | 13:45 | |
| *** happyhemant is now known as hemant | 13:57 | |
| *** hemant is now known as Guest10361 | 13:57 | |
| *** Guest10361 is now known as happyhemant | 13:58 | |
| *** fnaval has joined #openstack-lbaas | 14:10 | |
| *** openstackgerrit has quit IRC | 14:14 | |
| *** Vorrtex has joined #openstack-lbaas | 14:15 | |
| *** Vorrtex has quit IRC | 14:18 | |
| *** Vorrtex has joined #openstack-lbaas | 14:19 | |
| *** sapd1 has quit IRC | 14:27 | |
| *** sapd1 has joined #openstack-lbaas | 14:27 | |
| *** Vorrtex has quit IRC | 14:33 | |
| *** yamamoto has quit IRC | 14:36 | |
| *** yamamoto has joined #openstack-lbaas | 14:40 | |
| *** yamamoto has quit IRC | 14:41 | |
| *** yamamoto has joined #openstack-lbaas | 14:42 | |
| *** yamamoto has quit IRC | 14:47 | |
| *** openstackgerrit has joined #openstack-lbaas | 14:50 | |
| openstackgerrit | Vishal Manchanda proposed openstack/neutron-lbaas-dashboard master: Drop nodejs4 job https://review.openstack.org/649399 | 14:50 |
| *** luksky has quit IRC | 14:51 | |
| *** ianychoi has quit IRC | 14:56 | |
| *** ccamposr has quit IRC | 14:58 | |
| *** sapd1 has quit IRC | 15:09 | |
| *** sapd1 has joined #openstack-lbaas | 15:09 | |
| *** CBR09 has joined #openstack-lbaas | 15:10 | |
| CBR09 | hi everyone, when I create a loadbalancer, I always get LB in active and offline status, not online | 15:21 |
| CBR09 | I investigated I think my octavia-health-manager didn't receive heartbeat from amphora | 15:22 |
| CBR09 | but when I capture udp packet, I can see heartbeat packet from my amphora | 15:22 |
| cgoncalves | CBR09, hi. check if the amphora is sending the heartbeats out to the health manager on port 5555 (default) protocol UDP | 15:22 |
| cgoncalves | ok. are you capturing that on the amphora port or health manager port? | 15:23 |
| CBR09 | yea I use tcpdump -n udp on my health manager port | 15:23 |
| *** gcheresh has quit IRC | 15:24 | |
| cgoncalves | CBR09, the health manager should be logging income heartbeats. could you please check that? enable debug mode | 15:24 |
| CBR09 | I also check health-manager logs, I don't see any log about receive hearbeat (I enabled debug=true), that why I know my health-manager didn't get packets | 15:26 |
| CBR09 | is there any chance for kernel drop udp packets? | 15:26 |
| cgoncalves | if you say you're seeing packets arriving to the health manager port, unlikely | 15:27 |
| cgoncalves | in any case, check your firewall | 15:27 |
| cgoncalves | UDP :5555 on the health manager port | 15:27 |
| *** ivve has quit IRC | 15:28 | |
| CBR09 | I checked my firewall, everything is open and when I capture heartbeat packet, I think my firewall allow that | 15:29 |
| cgoncalves | weird | 15:30 |
| cgoncalves | any chance you could share with us the health manager logs? | 15:31 |
| CBR09 | my command tcpdump | 15:31 |
| CBR09 | tcpdump -n udp -X -vv | 15:31 |
| CBR09 | https://pastebin.com/eMGUUS5L | 15:32 |
| CBR09 | my packet capture | 15:32 |
| cgoncalves | CBR09, that capture is not on the health manager port, so I wonder if the packets are not indeed being dropped by firewall or so | 15:33 |
| CBR09 | ah I not showing that, when I capture above packets, I just capture on -i interfaces | 15:34 |
| CBR09 | my netstat -suna output | 15:35 |
| CBR09 | Udp: 4760839594 packets received 245908 packets to unknown port received. 6024234678 packet receive errors 10785320512 packets sent 6024234678 receive buffer errors 0 send buffer errors | 15:35 |
| CBR09 | I can see receive buffer errors | 15:35 |
| CBR09 | is there any chance for that?, my kernel drop udp packet | 15:36 |
| cgoncalves | that's a lot of packet errors... | 15:38 |
| cgoncalves | try to send a dummy packet to the HM port from the same host just to see if it it logs something | 15:39 |
| cgoncalves | syslog might also be logging something useful | 15:40 |
| CBR09 | you mean, I fake udp packet to port 5555? | 15:41 |
| cgoncalves | yes | 15:41 |
| cgoncalves | I'd expect HM to receive, log and drop | 15:42 |
| CBR09 | yea, let me try it | 15:47 |
| *** gcheresh has joined #openstack-lbaas | 15:50 | |
| *** yamamoto has joined #openstack-lbaas | 15:50 | |
| *** rpittau is now known as rpittau|afk | 15:53 | |
| openstackgerrit | Merged openstack/neutron-lbaas-dashboard master: Drop nodejs4 job https://review.openstack.org/649399 | 15:55 |
| *** yamamoto has quit IRC | 15:59 | |
| CBR09 | Hi @cgoncalves | 16:00 |
| CBR09 | I send a udp packet | 16:00 |
| CBR09 | and HM logs | 16:00 |
| CBR09 | https://pastebin.com/gQFUf149 | 16:00 |
| cgoncalves | CBR09, yeah so the health manager service is working fine. the problem is the heartbeat packets are being dropped somewhere before reaching to the service | 16:05 |
| CBR09 | yea, I also think that, but I have no idea what drop | 16:06 |
| cgoncalves | CBR09, have you checked syslog? | 16:07 |
| CBR09 | we run centos os, so we don't have syslogs, we just have message | 16:09 |
| cgoncalves | well, that :) | 16:12 |
| CBR09 | it's hard to think how that is possible :)) | 16:13 |
| *** psachin has quit IRC | 16:14 | |
| CBR09 | I've tried capture on HM port 5555 | 16:16 |
| CBR09 | https://pastebin.com/rkS5wBXG | 16:16 |
| CBR09 | I can see udp packet on that port | 16:16 |
| cgoncalves | CBR09, right, but for some reason packets are dropped as you don't see any sign of them being logged in the health manager | 16:26 |
| cgoncalves | check /var/log/message and /var/log/audit/audit.log | 16:27 |
| cgoncalves | do you have SELinux enforcing? | 16:27 |
| openstackgerrit | Merged openstack/neutron-lbaas stable/rocky: Fix proxy extension for neutron RBAC https://review.openstack.org/649049 | 16:28 |
| *** ivve has joined #openstack-lbaas | 16:30 | |
| *** sapd1 has quit IRC | 16:32 | |
| *** sapd1 has joined #openstack-lbaas | 16:32 | |
| *** ramishra has quit IRC | 16:41 | |
| *** altlogbot_3 has quit IRC | 16:46 | |
| *** salmankhan has quit IRC | 16:50 | |
| *** ivve has quit IRC | 16:51 | |
| *** gcheresh has quit IRC | 16:51 | |
| CBR09 | thank @cgoncalves, I will check more :* | 16:55 |
| CBR09 | thank @cgoncalves, I will check more :( | 16:55 |
| CBR09 | thank for your support | 16:55 |
| cgoncalves | CBR09, please let us know if you find what is causing the behavior you're observing | 16:56 |
| CBR09 | @cgoncalves: ah, my health-manager IP and amphora IP is difference | 16:56 |
| CBR09 | is that okay ? | 16:57 |
| CBR09 | my health-manager listen at 10.x.x.x and my amphora on 172.x.x.x | 16:57 |
| eandersson | cgoncalves, it allowed me to push more, with less workers | 17:10 |
| eandersson | This is different from the old implementation though as this combines threads and workers | 17:13 |
| eandersson | It really just gives you a bit more control, as you can use both threads and workers | 17:15 |
| *** sapd1 has quit IRC | 17:29 | |
| *** sapd1 has joined #openstack-lbaas | 17:30 | |
| *** xgerman has joined #openstack-lbaas | 17:33 | |
| *** luksky has joined #openstack-lbaas | 17:47 | |
| *** ricolin has quit IRC | 17:49 | |
| *** CBR09 has quit IRC | 17:49 | |
| *** sapd1 has quit IRC | 18:00 | |
| *** sapd1 has joined #openstack-lbaas | 18:00 | |
| *** gcheresh has joined #openstack-lbaas | 18:05 | |
| *** Vorrtex has joined #openstack-lbaas | 18:09 | |
| *** yamamoto has joined #openstack-lbaas | 18:12 | |
| *** happyhemant has quit IRC | 18:33 | |
| *** gcheresh has quit IRC | 18:37 | |
| *** ivve has joined #openstack-lbaas | 18:38 | |
| *** vishalmanchanda has quit IRC | 18:39 | |
| -openstackstatus- NOTICE: Restarting Gerrit on review.openstack.org to pick up new configuration for the replication plugin | 19:05 | |
| *** yamamoto has quit IRC | 19:23 | |
| *** yamamoto has joined #openstack-lbaas | 19:24 | |
| *** yamamoto has quit IRC | 19:29 | |
| cgoncalves | johnsom, o/ | 20:01 |
| *** ivve has quit IRC | 20:01 | |
| johnsom | o/ | 20:01 |
| cgoncalves | weekly meeting? | 20:02 |
| johnsom | Yeah, sorry, just a sec | 20:02 |
| johnsom | #startmeeting Octavia | 20:03 |
| openstack | Meeting started Wed Apr 10 20:03:16 2019 UTC and is due to finish in 60 minutes. The chair is johnsom. Information about MeetBot at http://wiki.debian.org/MeetBot. | 20:03 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 20:03 |
| *** openstack changes topic to " (Meeting topic: Octavia)" | 20:03 | |
| openstack | The meeting name has been set to 'octavia' | 20:03 |
| johnsom | Ugh, sorry folks. Still getting back in the groove after travel. | 20:03 |
| cgoncalves | hope you enjoyed it :) | 20:04 |
| johnsom | #topic Announcements | 20:04 |
| *** openstack changes topic to "Announcements (Meeting topic: Octavia)" | 20:04 | |
| johnsom | Ha, well, yesterday was a long travel day. | 20:04 |
| rm_work | o/ | 20:05 |
| johnsom | The biggest announcement I have today is: | 20:05 |
| johnsom | #link http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004899.html | 20:05 |
| johnsom | Stein is released! | 20:05 |
| rm_work | woo | 20:05 |
| johnsom | lol, ok, that was a link to message, with a link to a message, with a link to the release. | 20:06 |
| johnsom | #link https://releases.openstack.org/stein/ | 20:06 |
| cgoncalves | awesome! thanks to many of you for your code contributions, reviews and discussions! | 20:06 |
| johnsom | Thank you to the whole team for your efforts on Octavia this cycle! | 20:06 |
| johnsom | We got a lot of good work done. | 20:07 |
| cgoncalves | the Octavia Stein release notes are impressive! | 20:07 |
| cgoncalves | #link https://docs.openstack.org/releasenotes/octavia/stein.html | 20:07 |
| johnsom | Yes! | 20:07 |
| johnsom | You beat me to posting that link. | 20:07 |
| nmagnezi | o/ | 20:07 |
| johnsom | There are also the cycle highlights for the press type people: | 20:08 |
| johnsom | #link https://releases.openstack.org/stein/highlights.html | 20:08 |
| johnsom | Again, thank you all for a successful release. Please raise yourself a toast! | 20:09 |
| *** sapd1 has quit IRC | 20:10 | |
| cgoncalves | https://www.benjerry.co.uk/files/live/sites/uk/files/whats-new/beer-blog.jpg | 20:10 |
| johnsom | Are there any other announcements today? | 20:11 |
| johnsom | Ok, just a heads up, the Summit is coming up in a few weeks. | 20:12 |
| johnsom | Please remember to enter any topic ideas, etc. on the Octavia PTG etherpad: | 20:12 |
| johnsom | #link https://etherpad.openstack.org/p/octavia-train-ptg | 20:13 |
| johnsom | #topic Brief progress reports / bugs needing review | 20:13 |
| *** openstack changes topic to "Brief progress reports / bugs needing review (Meeting topic: Octavia)" | 20:13 | |
| cgoncalves | if someone cannot attend the PTG but would like to participate, please let us know. we may be able to setup a conference system | 20:14 |
| johnsom | Other than traveling, I worked on cleaning up our "unset" story for the client and the API. I'm working through the API making sure that PUT calls with "None/null" are handled correctly and that we have openstack client "unset" actions available. | 20:14 |
| johnsom | Yes, and please still add your topic to the list. We can also do a coordinated IRC time if that works better for folks than attempting a video conference. | 20:15 |
| nmagnezi | yeah, I had some question about one patch related to listener | 20:15 |
| *** sapd1 has joined #openstack-lbaas | 20:16 | |
| johnsom | I also spent some time last week working on a last minute critical bug for the release. My fix ifup patch introduced a bug that could cause the base port IP to not come up. | 20:16 |
| johnsom | nmagnezi Do you want to chat about those in open discussion? | 20:16 |
| nmagnezi | johnsom, sure | 20:16 |
| johnsom | Cool. Any other updates from folks? | 20:17 |
| cgoncalves | progress report from my side is: active-standby tempest test is ready for reviews | 20:17 |
| cgoncalves | #link https://review.openstack.org/#/c/637073/ | 20:17 |
| cgoncalves | as is the spare pool tempest test | 20:17 |
| cgoncalves | #link https://review.openstack.org/#/c/634988/ | 20:17 |
| johnsom | Yay! That Active/Standby likely would have caught the above mentioned bug. | 20:18 |
| cgoncalves | I also did some important backports, namely one about performance contributed by eandersson | 20:18 |
| cgoncalves | #link https://review.openstack.org/#/c/650304/ | 20:18 |
| eandersson | Awesome | 20:19 |
| johnsom | Nice. I think you also have some stable releases up for review to get those out. | 20:19 |
| johnsom | cgoncalves I know there was some talk while I was gone about a client release. Is that in progress or something I should look at? | 20:20 |
| cgoncalves | yes | 20:20 |
| cgoncalves | #link https://review.openstack.org/#/c/651475/ | 20:20 |
| cgoncalves | release Octavia Queens 2.0.5 and Rocky 3.0.3 | 20:20 |
| cgoncalves | johnsom, lxkong is work on the backport tomorrow his time | 20:20 |
| johnsom | Ok, sounds good | 20:21 |
| cgoncalves | (the "yes" was for the stable releases up for review comment) | 20:21 |
| johnsom | I will also mention here, there are a number of tempest plugin patches still open for review. Some relating to flavors, etc. It would be good to get some eyes on those so we have a stronger testing suite. | 20:22 |
| cgoncalves | #link https://review.openstack.org/#/q/project:openstack/octavia-tempest-plugin+status:open | 20:23 |
| johnsom | Any other updates before we move on? (remember, this isn't just for the core team, it's a great time for anyone participating to share with the wider team) | 20:24 |
| johnsom | For the week going forward, | 20:24 |
| johnsom | I have some internal stuff to work on, then probably getting slides started for the Summit and continuing to work on the unset work. | 20:25 |
| rm_work | i'm just looking forward to the PTG, so we can get some discussion in on priorities and roadmap for Train | 20:25 |
| rm_work | and get started on the big rocks there | 20:25 |
| johnsom | Yep! Maybe in a week or so I will start working on a rough schedule for the topics. That is unless rm_work wants to do it. | 20:26 |
| rm_work | go ahead, sounds good :) | 20:26 |
| cgoncalves | lol | 20:26 |
| * johnsom feels like the team all just took a step back | 20:26 | |
| cgoncalves | there is a patch up proposing a fix in our providers support | 20:27 |
| cgoncalves | #link https://review.openstack.org/#/c/648853/ | 20:27 |
| johnsom | Yeah, I need to take a close look at that. We have a wrapper that should be handling any driver issue, so not sure how that would not have been handled. | 20:28 |
| cgoncalves | the OVN team might have been hit by this issue a few weeks ago, too. they work-arounded it by creating the VIP port themselves | 20:28 |
| johnsom | I will also note, the NSX driver in neutron had some release trouble because they were linking directly into Octavia and directly accessing the database. I hope the folks working on that will work with us to make sure they have what they need to be "good provider citizens" and this isn't an issue going forward. | 20:29 |
| cgoncalves | +1 | 20:30 |
| cgoncalves | provider vendors out there listening: please reach out if you need advise/help! | 20:30 |
| johnsom | It didn't look like it was any big design issue, just a few fields or new driver API methods needed. | 20:31 |
| johnsom | #topic New IRC meeting time | 20:31 |
| *** openstack changes topic to "New IRC meeting time (Meeting topic: Octavia)" | 20:31 | |
| johnsom | Ok, so last week we started a doodle poll and sent e-mail to the discuss list about changing the Octavia IRC meeting time. | 20:32 |
| johnsom | #link https://doodle.com/poll/9sxbzfhwirqiyqe8 | 20:33 |
| johnsom | That is/was the link to the doodle poll | 20:33 |
| rm_work | personally i am kinda hoping it doesn't have to change :D | 20:33 |
| johnsom | There was a four way tie, all of which were a new time. | 20:34 |
| *** sapd1 has quit IRC | 20:34 | |
| johnsom | The winning times were on Tuesday or Wednesday, 15:00 or 16:00 UTC. | 20:35 |
| johnsom | We have a choice to make: | 20:35 |
| johnsom | 1: we can do another poll, with only those time slots. | 20:35 |
| johnsom | 2: We can pick the time slot based on the new PTL's choices, which would be 16:00 UTC. | 20:36 |
| johnsom | Personally I think we should just use the 16:00 time slot and pick either Tuesday or Wednesday. | 20:37 |
| *** sapd1 has joined #openstack-lbaas | 20:37 | |
| johnsom | I would lean towards keeping it on Wednesday. | 20:38 |
| cgoncalves | 16:00 UTC works for me. I'd say Wednesday to keep the same week day | 20:38 |
| rm_work | Ok. Hopefully I make it to enough of those :D | 20:39 |
| rm_work | is that... 9am PST? | 20:39 |
| johnsom | Yes | 20:39 |
| johnsom | Any comments/concerns with Wednesdays at 16:00 UTC? | 20:41 |
| rm_work | johnsom: as our community manager, you're going to continue to run the meetings, right? | 20:41 |
| nmagnezi | I preferred the current time. But if that works for everyone I guess that's okay | 20:41 |
| rm_work | nmagnezi: did you do the poll? :D | 20:41 |
| johnsom | rm_work Ummm, technically that is a PTL activity..... | 20:42 |
| nmagnezi | rm_work, I did | 20:42 |
| rm_work | then apparently yes | 20:42 |
| rm_work | johnsom: does it say that somewhere? ;) | 20:42 |
| johnsom | rm_work I have a few weeks to *make* it say so if I need.... grin | 20:43 |
| johnsom | Seriously though, you can delegate that out | 20:43 |
| rm_work | lol | 20:43 |
| johnsom | Ok, so are we good that I should do all the paperwork type stuff to move the time to 16:00 UTC? | 20:44 |
| johnsom | Going once.... | 20:45 |
| johnsom | going twice.... | 20:45 |
| johnsom | Sold! Our new IRC meeting time will be Wednesdays at 16:00 UTC (four hours earlier than our previous time). | 20:45 |
| * rm_work dies | 20:46 | |
| * cgoncalves updates his calendar | 20:47 | |
| johnsom | I will update the OpenStack meetings page, our wiki, and send out an e-mail. | 20:47 |
| *** ivve has joined #openstack-lbaas | 20:48 | |
| johnsom | FYI, I have also opened it so you can see how folks voted now that the poll is done. | 20:48 |
| * nmagnezi looks | 20:49 | |
| johnsom | #topic Open Discussion | 20:49 |
| *** openstack changes topic to "Open Discussion (Meeting topic: Octavia)" | 20:49 | |
| nmagnezi | cgoncalves, you really wanted to change the time. lol | 20:49 |
| cgoncalves | nmagnezi, as you can see, I was open to any time slot proposal! | 20:50 |
| johnsom | nmagnezi I think you had some questions about the listener unset patch? | 20:51 |
| nmagnezi | johnsom, yes | 20:51 |
| nmagnezi | johnsom, wrote it as a comment https://review.openstack.org/#/c/650153/ | 20:52 |
| nmagnezi | just wondering why we reset to default and if we should actually do that, that's all | 20:52 |
| johnsom | Yeah, sorry, I have been traveling and haven't caught up yet. | 20:52 |
| nmagnezi | np | 20:52 |
| nmagnezi | Just asking because another way to look at it, is as some invalid input that you ignore | 20:53 |
| nmagnezi | So as I wrote, the patch itself is fine code-wise. Just wondered about the outcome | 20:53 |
| johnsom | Well, the values that I reset to the default are values that don't make sense with "None" in them. Like a timeout value, you can't really have a None timeout, we have a defined range for those. So I felt an "unset" of a timeout would translate back to the default we have set for those. However, very open for discussion on it. | 20:54 |
| nmagnezi | Fully agree. But aren't this just for updates? | 20:55 |
| nmagnezi | I mean, if you create a new listener and provided nulls I agree that defaults make sense | 20:55 |
| johnsom | Ah, ok, so your question is how do they *not* set a currently set field? I.e. Timeout A is set to 11, where the default is 10 (yes, yes, select numbers chosen). | 20:56 |
| johnsom | So with the PUT API, to *not* update a field, you just don't include that parameter in the JSON document. This is how it works today. | 20:57 |
| nmagnezi | Aha, okay probably I got it wrong by looking at the "Fix listener API handling of None/null updates" topic (no need to change it) | 20:57 |
| johnsom | If you want to update the "name" but not the "timeout A", you would PUT a json with just 'name': 'great' in it and not include the "timeout A" field at all. | 20:58 |
| nmagnezi | I thought this is for updates | 20:58 |
| johnsom | Yes, this is for updates. | 20:58 |
| cgoncalves | yeah, set/unset are PUT API requests | 20:59 |
| johnsom | With this patch, if you do include "timeout A" field, with "null" in it, it will now reset to the default value for that field. | 20:59 |
| johnsom | (FYI, null is JSON for None in python in this case) | 20:59 |
| johnsom | Ok, we are out of time because I was late, sorry. We can continue chatting in the channel. | 21:00 |
| johnsom | #endmeeting | 21:00 |
| *** openstack changes topic to "Discussions for OpenStack Octavia | Train PTG etherpad: https://etherpad.openstack.org/p/octavia-train-ptg" | 21:00 | |
| openstack | Meeting ended Wed Apr 10 21:00:27 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:00 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/octavia/2019/octavia.2019-04-10-20.03.html | 21:00 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/octavia/2019/octavia.2019-04-10-20.03.txt | 21:00 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/octavia/2019/octavia.2019-04-10-20.03.log.html | 21:00 |
| nmagnezi | o/ | 21:00 |
| johnsom | nmagnezi Does that help clarify or am I confusing you more? | 21:01 |
| nmagnezi | haha | 21:01 |
| nmagnezi | I'm thinking maybe I should look at this again | 21:01 |
| nmagnezi | But just to double check | 21:01 |
| johnsom | Ok. I think I also need to update the API reference to call out the null behavior better. I was saving that until the end, but maybe I should do that in each section. | 21:02 |
| nmagnezi | A value fed to an option with None/null will cause it to get reset to default, even if there was come valid value placed in it beforehand, right? | 21:02 |
| johnsom | Right | 21:02 |
| johnsom | If there is a defined default for that field. | 21:02 |
| nmagnezi | right | 21:02 |
| nmagnezi | So my question is | 21:02 |
| johnsom | If our API doesn't have a default for the field, like name, it will go to None. | 21:02 |
| nmagnezi | Why is None/null being handled like that and not the same as any other invalid input? | 21:03 |
| nmagnezi | That's where I said I'm open for discussion so I might change my vote | 21:03 |
| johnsom | Yeah, I like the discussion, it only makes the project better. | 21:04 |
| johnsom | Let's look at one of the timeouts: | 21:05 |
| johnsom | https://github.com/openstack/octavia/blob/master/octavia/api/v2/types/listener.py#L126 | 21:05 |
| johnsom | So in our current code, when you create a listener, we define both a default, and a valid range. | 21:05 |
| johnsom | So, if we create a listener and don't set this field, it gets the default value. But let's say they do set it to 11 (default is 10). | 21:06 |
| johnsom | Then, later, they decide 11 isn't right, and they want to reset it to the default value. They could go look at the API ref, find the default value and set that, or with the patch they can do a PUT (update) with the field set to null. | 21:07 |
| nmagnezi | so we basically look at it as.. a feature? :) | 21:08 |
| johnsom | We don't want to set this field to None for a few reasons: First, None isn't valid for the validation ranges we define in the API ref. Second, we like to keep the "show" commands returning a value that represents what is actually being used in the load balancer. | 21:09 |
| johnsom | Well, It's not quite a feature in that if you set it to null today, we break. It does shove "None" in the field, which then blows up when the config file is rendered. | 21:09 |
| nmagnezi | oh. | 21:10 |
| nmagnezi | So yeah I fully agree on the fact that we need to handle null | 21:10 |
| johnsom | So, right now, before the patch, "null" is .... Who knows what will happen. | 21:10 |
| nmagnezi | It's just that I wanted to know why in the specific way (as opposed to just reject it for example) | 21:10 |
| rm_work | yeah i think default makes sense | 21:10 |
| rm_work | it echoes quotas, in that when you "delete your custom value" it goes back to the default | 21:11 |
| johnsom | That is what I'm trying to fix. Some of our fields work right, some just blindly take None and fail. | 21:11 |
| johnsom | Right, and from the CLI it's pretty intuitive that "unset" of a field restores the default. | 21:11 |
| johnsom | We could just reject nulls on fields that can't be "None". That is a valid option. | 21:12 |
| colin- | hello sorry i'm late | 21:13 |
| johnsom | I just felt this approach was a bit more user friendly in that they don't have to lookup the defaults to reset it. | 21:13 |
| nmagnezi | I don't have a strong opinion here. I fully agree that we should definitely handle null and not take it blindly. It's just that the decision to reset to default was unique :) but maybe it is common and I just didn't notice | 21:13 |
| johnsom | Agreed | 21:13 |
| johnsom | These are "proposed" patches.... grin | 21:14 |
| nmagnezi | haha | 21:14 |
| nmagnezi | Yeah if we do that | 21:14 |
| nmagnezi | we should be consistent | 21:14 |
| *** sapd1 has quit IRC | 21:14 | |
| johnsom | I don't think the API working group has guidance on this. I should probably go double check. | 21:14 |
| johnsom | I think I looked last week, but I'm not 100% sure. | 21:15 |
| nmagnezi | if you find something just write it and I'll catch up my morning | 21:15 |
| nmagnezi | Thanks for the good discussion! | 21:15 |
| johnsom | This is the URL BTW: https://specs.openstack.org/openstack/api-wg/ | 21:15 |
| johnsom | Sure, thanks for asking the questions! Have a good night. | 21:16 |
| nmagnezi | Will re-review the patch tomorrow | 21:16 |
| *** sapd1 has joined #openstack-lbaas | 21:19 | |
| *** fnaval has quit IRC | 21:20 | |
| *** ivve has quit IRC | 21:25 | |
| *** fnaval has joined #openstack-lbaas | 21:29 | |
| *** fnaval has quit IRC | 21:32 | |
| *** fnaval has joined #openstack-lbaas | 21:34 | |
| *** boden has quit IRC | 21:35 | |
| lxkong | johnsom, rm_work, morning, i'm reading the release notes of Octavia Stein. `The Stein release of Octavia adds the driver-agent controller process` i wonder if the driver-agent is necessary? | 21:38 |
| johnsom | lxkong Only if you are using provider drivers other than Octavia. However, at some point in the future, the Octavia provider will also use that. | 21:41 |
| lxkong | johnsom: ok, so we don't need to care about that right now. | 21:42 |
| johnsom | Correct | 21:42 |
| lxkong | johnsom: btw, thanks for the hard work for Stein, I can see there were significant improvements and new features | 21:43 |
| johnsom | lxkong Team effort! | 21:45 |
| *** sapd1 has quit IRC | 21:50 | |
| *** sapd1 has joined #openstack-lbaas | 21:54 | |
| colin- | +1 | 22:02 |
| *** rcernin has joined #openstack-lbaas | 22:06 | |
| *** luksky has quit IRC | 22:17 | |
| *** jiteka1 has quit IRC | 22:22 | |
| *** sapd1 has quit IRC | 22:41 | |
| *** sapd1 has joined #openstack-lbaas | 22:42 | |
| *** sapd1 has quit IRC | 22:55 | |
| *** sapd1 has joined #openstack-lbaas | 22:58 | |
| *** sapd1 has quit IRC | 23:23 | |
| *** sapd1 has joined #openstack-lbaas | 23:24 | |
| *** ianychoi has joined #openstack-lbaas | 23:46 | |
| *** sapd1 has quit IRC | 23:48 | |
| *** sapd1 has joined #openstack-lbaas | 23:50 | |
| *** rcernin has quit IRC | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
