*** fnaval_ has quit IRC | 00:06 | |
*** fnaval has joined #openstack-lbaas | 00:06 | |
openstackgerrit | Joshua Harlow proposed openstack/octavia master: Gather cert rotatation failure/pass after executor is done https://review.openstack.org/477720 | 00:12 |
---|---|---|
openstackgerrit | Joshua Harlow proposed openstack/octavia master: Gather fail/pass after executor is done https://review.openstack.org/477720 | 00:22 |
openstackgerrit | Joshua Harlow proposed openstack/octavia master: Gather fail/pass after executor is done https://review.openstack.org/477720 | 00:24 |
openstackgerrit | Merged openstack/octavia master: Add v2 L7 Policy API section https://review.openstack.org/477174 | 00:37 |
openstackgerrit | Merged openstack/octavia master: Replace the usage of 'admin_manager' with 'os_admin' https://review.openstack.org/477357 | 00:38 |
*** fnaval_ has joined #openstack-lbaas | 00:50 | |
*** fnaval has quit IRC | 00:53 | |
openstackgerrit | Jude Cross proposed openstack/octavia master: Add status tree to V2 API https://review.openstack.org/474390 | 00:53 |
*** JudeC has joined #openstack-lbaas | 00:54 | |
*** fnaval_ has quit IRC | 00:54 | |
*** JudeC has quit IRC | 00:55 | |
*** armax has joined #openstack-lbaas | 01:06 | |
*** aojea has joined #openstack-lbaas | 01:16 | |
*** blogan has quit IRC | 01:17 | |
*** reedip has quit IRC | 01:17 | |
*** aojea has quit IRC | 01:23 | |
*** reedip has joined #openstack-lbaas | 01:30 | |
*** armax has quit IRC | 01:45 | |
rm_work | changing the message a bit on the TLS_TERMINATION disabled thing | 01:46 |
rm_work | it's not informative enough and could be confusing | 01:47 |
rm_work | (not sure if those went through) | 01:47 |
*** leitan has joined #openstack-lbaas | 01:47 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Allow operators to disallow creation of TLS Termination listeners https://review.openstack.org/476701 | 01:47 |
*** JudeC has joined #openstack-lbaas | 01:50 | |
*** leitan has quit IRC | 01:52 | |
*** fnaval has joined #openstack-lbaas | 01:59 | |
eandersson | rm_work, johnsom : Could you take a look at the failing tests due to my lazy change? pretty sure that is nothing, but would be nice to have someone that understands this better take a look | 02:14 |
openstackgerrit | Jude Cross proposed openstack/octavia master: Add statistics to V2 API https://review.openstack.org/474885 | 02:14 |
rm_work | saying we "understand" neutron-lbaas stuff is maybe an overstatement | 02:15 |
rm_work | i pretty much ignore that whole system because it needs to go away ASAP T_T | 02:15 |
eandersson | hehe | 02:15 |
rm_work | but, i'm looking | 02:15 |
eandersson | wish I could just go to pike, but gonna take time | 02:15 |
eandersson | pretty sure the test is failing because there is more information now than before | 02:16 |
*** JudeC has quit IRC | 02:17 | |
rm_work | erm | 02:18 |
rm_work | no | 02:18 |
rm_work | it's failing because it isn't returning listener data | 02:18 |
rm_work | which is honestly probably related to changing model stuff <_< | 02:18 |
eandersson | I assumed that actual is the "actual" data, while "reference" was the example data | 02:19 |
rm_work | might change the order it loads things during processing, causing it to miss newly created stuff? not sure | 02:19 |
rm_work | yes, it is | 02:19 |
rm_work | ah yes, sometimes it is expecting a listener but doesn't see one, and sometimes it sees a listener but isn't expecting one | 02:19 |
rm_work | here it's not expecting a listener, but gets one: http://logs.openstack.org/98/477698/2/check/gate-neutron-lbaasv2-dsvm-api-ubuntu-xenial/fc54f20/console.html#_2017-06-27_00_20_08_900229 | 02:20 |
rm_work | hmm, same here: http://logs.openstack.org/98/477698/2/check/gate-neutron-lbaasv2-dsvm-api-ubuntu-xenial/fc54f20/console.html#_2017-06-27_00_20_08_762021 | 02:20 |
rm_work | hmm yeah guess i read that wrong the first time, can't find the counterexample | 02:21 |
rm_work | so it just lists things it shouldn't | 02:21 |
rm_work | which is ... odd | 02:21 |
eandersson | it's odd, as according to the test it should have a listener | 02:21 |
rm_work | and gets the wrong number of pools back often | 02:21 |
rm_work | erm | 02:21 |
eandersson | I think that is just because it never reaches the delete | 02:21 |
eandersson | because of the assert | 02:21 |
rm_work | I don't THINK these tests are failing on other changes tho, are they? | 02:22 |
eandersson | e.g. in the one you linked it asserts before _delete_pool | 02:22 |
eandersson | nope, dont think sop | 02:22 |
rm_work | https://review.openstack.org/#/c/476333/ passed just earlier | 02:23 |
rm_work | err, nm that was days ago | 02:23 |
eandersson | This is def due to the lazy change | 02:23 |
eandersson | It kinda makes sense I think... previously the field was lazy-loaded, meaning unless it got called, it wouldn't be fetched right? | 02:25 |
eandersson | but now, since it is no longer lazy-loaded, it will always be loaded | 02:25 |
eandersson | This might be why the result from get and create pool is different https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/services/loadbalancer/plugin.py#L682 | 02:31 |
eandersson | Seriously can't wait until I can move over to Octavia :D | 02:33 |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: [WIP] Remove unnecessary lazy-loaded queries https://review.openstack.org/477698 | 02:39 |
*** aojea has joined #openstack-lbaas | 03:09 | |
*** aojea has quit IRC | 03:13 | |
*** gans has joined #openstack-lbaas | 03:24 | |
*** yamamoto has joined #openstack-lbaas | 03:29 | |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: [WIP] Remove unnecessary lazy-loaded queries https://review.openstack.org/477698 | 03:34 |
*** links has joined #openstack-lbaas | 03:42 | |
*** cody-somerville has quit IRC | 03:42 | |
*** cody-somerville has joined #openstack-lbaas | 03:42 | |
openstackgerrit | Merged openstack/neutron-lbaas master: Replace the usage of 'manager' with 'os_primary' https://review.openstack.org/476333 | 03:48 |
*** sticker_ has joined #openstack-lbaas | 03:52 | |
*** sticker has quit IRC | 03:55 | |
*** amotoki_away is now known as amotoki | 04:10 | |
*** krypto has joined #openstack-lbaas | 04:13 | |
*** krypto has joined #openstack-lbaas | 04:13 | |
*** sticker_ is now known as sticker | 04:15 | |
openstackgerrit | Joshua Harlow proposed openstack/octavia master: Gather fail/pass after executor is done https://review.openstack.org/477720 | 04:15 |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: [WIP] Remove unnecessary lazy-loaded queries https://review.openstack.org/477698 | 04:22 |
*** fnaval has quit IRC | 04:42 | |
*** JudeC has joined #openstack-lbaas | 05:00 | |
openstackgerrit | Jude Cross proposed openstack/octavia master: Add status tree to V2 API https://review.openstack.org/474390 | 05:06 |
openstackgerrit | Jude Cross proposed openstack/octavia master: Add statistics to V2 API https://review.openstack.org/474885 | 05:06 |
*** csomerville has joined #openstack-lbaas | 05:10 | |
*** cody-somerville has quit IRC | 05:13 | |
*** m-greene has quit IRC | 05:14 | |
*** m-greene has joined #openstack-lbaas | 05:14 | |
*** JudeC has quit IRC | 05:14 | |
rm_work | johnsom: what is `octavia-wsgi`?? | 05:21 |
*** gcheresh has joined #openstack-lbaas | 05:22 | |
*** oomichi_ has joined #openstack-lbaas | 05:36 | |
*** pck_ has joined #openstack-lbaas | 05:38 | |
*** oomichi has quit IRC | 05:39 | |
*** oomichi_ is now known as oomichi | 05:39 | |
*** pck has quit IRC | 05:39 | |
*** bcafarel has quit IRC | 05:39 | |
*** aojea has joined #openstack-lbaas | 05:39 | |
johnsom | rm_work https://github.com/openstack/octavia/blob/master/setup.cfg#L52 | 05:50 |
johnsom | It is the pbr generated script | 05:50 |
johnsom | It was for the "goal" before the "goal" changed | 05:50 |
johnsom | Catch you tomorrow | 05:53 |
*** rcernin has joined #openstack-lbaas | 05:55 | |
rm_work | hmm k | 05:57 |
rm_work | yeah trying to figure out how to run our app with a real runner | 05:57 |
*** aojea has quit IRC | 06:05 | |
*** armax has joined #openstack-lbaas | 06:06 | |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: [WIP] Remove unnecessary lazy-loaded queries https://review.openstack.org/477698 | 06:19 |
openstackgerrit | Merged openstack/octavia master: No need to do a shutdown(wait=True) when in a context-manager https://review.openstack.org/477063 | 06:22 |
*** rcernin has quit IRC | 06:26 | |
*** rcernin has joined #openstack-lbaas | 06:32 | |
*** kobis has joined #openstack-lbaas | 06:38 | |
*** fnaval has joined #openstack-lbaas | 06:43 | |
*** armax has quit IRC | 06:44 | |
*** fnaval has quit IRC | 06:48 | |
*** tesseract has joined #openstack-lbaas | 06:55 | |
*** gans819 has joined #openstack-lbaas | 07:12 | |
*** gans has quit IRC | 07:13 | |
*** pcaruana has joined #openstack-lbaas | 07:32 | |
*** rstarmer has joined #openstack-lbaas | 07:43 | |
*** sanfern has joined #openstack-lbaas | 07:54 | |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: [WIP] Remove unnecessary lazy-loaded queries https://review.openstack.org/477698 | 07:55 |
openstackgerrit | tuninger proposed openstack/neutron-lbaas master: Add the code for updating the servers statistics based on haproxy stats data. Fixes Bug1699945. https://review.openstack.org/476848 | 08:04 |
*** aojea has joined #openstack-lbaas | 08:05 | |
*** ajo has quit IRC | 08:17 | |
*** ajo has joined #openstack-lbaas | 08:19 | |
*** aojea has quit IRC | 08:28 | |
*** aojea has joined #openstack-lbaas | 08:34 | |
*** sanfern has quit IRC | 08:35 | |
*** sanfern has joined #openstack-lbaas | 08:40 | |
*** fnaval has joined #openstack-lbaas | 08:44 | |
*** fnaval has quit IRC | 08:49 | |
*** yamamoto has quit IRC | 09:23 | |
*** gcheresh_ has joined #openstack-lbaas | 09:27 | |
*** yamamoto has joined #openstack-lbaas | 09:29 | |
*** slaweq has joined #openstack-lbaas | 09:30 | |
*** logan_ has joined #openstack-lbaas | 09:33 | |
*** OGtrilliams has joined #openstack-lbaas | 09:34 | |
*** gcheresh has quit IRC | 09:34 | |
*** reedip has quit IRC | 09:34 | |
*** afranc has quit IRC | 09:34 | |
*** PagliaccisCloud has quit IRC | 09:34 | |
*** logan- has quit IRC | 09:34 | |
*** slaweq__ has quit IRC | 09:35 | |
*** OGtrilliams is now known as PagliaccisCloud | 09:35 | |
*** sanfern has quit IRC | 09:35 | |
*** afranc has joined #openstack-lbaas | 09:35 | |
*** logan_ is now known as logan- | 09:37 | |
*** reedip has joined #openstack-lbaas | 09:40 | |
*** sanfern has joined #openstack-lbaas | 09:41 | |
*** rstarmer has quit IRC | 09:42 | |
*** chlong has joined #openstack-lbaas | 09:46 | |
*** csomerville has quit IRC | 09:51 | |
*** gans819 has quit IRC | 09:56 | |
*** rstarmer has joined #openstack-lbaas | 10:03 | |
openstackgerrit | tuninger proposed openstack/neutron-lbaas master: Add the code for updating the servers statistics based on haproxy stats data. Fixes Bug1699945. https://review.openstack.org/476848 | 10:05 |
*** rstarmer has quit IRC | 10:14 | |
*** fnaval has joined #openstack-lbaas | 10:45 | |
*** amotoki is now known as amotoki_away | 10:46 | |
*** fnaval has quit IRC | 10:49 | |
*** amotoki_away is now known as amotoki | 10:51 | |
*** sanfern has quit IRC | 10:55 | |
*** amotoki is now known as amotoki_away | 11:01 | |
*** chlong_ has joined #openstack-lbaas | 11:04 | |
*** chlong has quit IRC | 11:04 | |
*** aojea has quit IRC | 11:34 | |
*** atoth has joined #openstack-lbaas | 11:41 | |
*** reedip_ has joined #openstack-lbaas | 12:05 | |
*** amotoki_away is now known as amotoki | 12:07 | |
*** krypto has quit IRC | 12:39 | |
*** krypto has joined #openstack-lbaas | 12:40 | |
*** krypto has quit IRC | 12:40 | |
*** krypto has joined #openstack-lbaas | 12:40 | |
*** rstarmer has joined #openstack-lbaas | 12:41 | |
openstackgerrit | tuninger proposed openstack/neutron-lbaas master: Add the code for updating the servers statistics based on haproxy stats data. Fixes Bug1699945. https://review.openstack.org/476848 | 12:41 |
*** sanfern has joined #openstack-lbaas | 12:44 | |
*** krypto has quit IRC | 12:45 | |
*** krypto has joined #openstack-lbaas | 12:45 | |
*** fnaval has joined #openstack-lbaas | 12:46 | |
*** rstarmer has quit IRC | 12:48 | |
*** fnaval has quit IRC | 12:50 | |
*** rstarmer has joined #openstack-lbaas | 12:50 | |
*** rstarmer has quit IRC | 12:57 | |
*** krypto has quit IRC | 13:01 | |
*** krypto has joined #openstack-lbaas | 13:02 | |
*** krypto has quit IRC | 13:03 | |
*** krypto has joined #openstack-lbaas | 13:04 | |
*** krypto has quit IRC | 13:10 | |
*** krypto has joined #openstack-lbaas | 13:10 | |
*** fnaval has joined #openstack-lbaas | 13:26 | |
*** cpuga has joined #openstack-lbaas | 13:33 | |
*** cpuga_ has joined #openstack-lbaas | 13:37 | |
*** cpuga has quit IRC | 13:40 | |
*** leitan has joined #openstack-lbaas | 13:46 | |
*** kobis has quit IRC | 13:58 | |
isantosp | Hi, about octavia lbaas-loadbalancer-create, is there any way to create the loadbalancer without passing the subnet_id? for example passing the subnet as a default parameter? | 14:12 |
*** cpuga_ has quit IRC | 14:18 | |
*** aojea has joined #openstack-lbaas | 14:28 | |
*** sanfern has quit IRC | 14:28 | |
*** dayou has joined #openstack-lbaas | 14:28 | |
*** sanfern has joined #openstack-lbaas | 14:29 | |
*** cpuga has joined #openstack-lbaas | 14:30 | |
*** fnaval has quit IRC | 14:30 | |
johnsom | isantosp One of the three methods is required: https://developer.openstack.org/api-ref/load-balancer/v2/index.html?expanded=create-a-load-balancer-detail | 14:36 |
johnsom | Either pass in a port, a network, or a subnet | 14:36 |
*** fnaval has joined #openstack-lbaas | 14:48 | |
*** gcheresh_ has quit IRC | 14:55 | |
*** reedip_ is now known as reedip_out_of_ar | 15:02 | |
*** rcernin has quit IRC | 15:04 | |
*** links has quit IRC | 15:05 | |
*** kobis has joined #openstack-lbaas | 15:16 | |
*** reedip_out_of_ar has quit IRC | 15:37 | |
*** aojea has quit IRC | 15:37 | |
*** aojea has joined #openstack-lbaas | 15:38 | |
johnsom | FYI, we have a bug in the OSC client: | 15:42 |
johnsom | https://bugs.launchpad.net/octavia/+bug/1700778 | 15:42 |
openstack | Launchpad bug 1700778 in octavia "Octavia OSC plugin is failing to create l7rules" [Critical,Triaged] | 15:42 |
johnsom | I thought we fixed those, but I guess not. | 15:42 |
*** aojea has quit IRC | 15:42 | |
johnsom | Yeah, it looks like we fixed some of them, but not all of them | 15:45 |
*** links has joined #openstack-lbaas | 16:02 | |
*** chlong has joined #openstack-lbaas | 16:05 | |
openstackgerrit | Merged openstack/octavia-tempest-plugin master: Updated from global requirements https://review.openstack.org/477986 | 16:05 |
*** chlong has quit IRC | 16:05 | |
openstackgerrit | Merged openstack/octavia-dashboard master: Updated from global requirements https://review.openstack.org/477985 | 16:07 |
*** pcaruana has quit IRC | 16:09 | |
*** cpuga has quit IRC | 16:24 | |
*** blogan has joined #openstack-lbaas | 16:34 | |
*** gans has joined #openstack-lbaas | 16:35 | |
*** kobis has quit IRC | 16:37 | |
*** tesseract has quit IRC | 16:40 | |
*** reedip has quit IRC | 16:41 | |
*** reedip has joined #openstack-lbaas | 16:43 | |
*** gans has quit IRC | 16:43 | |
*** kobis has joined #openstack-lbaas | 16:46 | |
*** amotoki is now known as amotoki_away | 16:57 | |
*** links has quit IRC | 16:57 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Add v2 L7 Rule API section https://review.openstack.org/478217 | 17:01 |
*** kobis has quit IRC | 17:02 | |
*** JudeC has joined #openstack-lbaas | 17:02 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Add v2 L7 Rule API section https://review.openstack.org/478217 | 17:03 |
*** aojea has joined #openstack-lbaas | 17:08 | |
*** krypto has quit IRC | 17:09 | |
*** krypto has joined #openstack-lbaas | 17:09 | |
*** krypto has quit IRC | 17:09 | |
*** krypto has joined #openstack-lbaas | 17:09 | |
*** sshank has joined #openstack-lbaas | 17:28 | |
*** sshank has quit IRC | 17:39 | |
rm_work | johnsom: ah hmm | 17:40 |
rm_work | johnsom: so do you know how to run our api with a REAL runner like gunicorn? | 17:40 |
rm_work | johnsom: i thought that's what octavia-wsgi did? but it's all like "DO NOT USE FOR PROD" lol | 17:40 |
rm_work | i'm trying to figure out these performance issues | 17:40 |
johnsom | Well, the pbr generated stuff is a bit weak. | 17:41 |
rm_work | i can't repro the 10s+ calls but | 17:41 |
rm_work | our API looks like it can handle about 1 request per second without being slow | 17:41 |
*** aojea has quit IRC | 17:41 | |
johnsom | So, yeah, I need to do the uwsgi stuff anyway, that might help you. | 17:41 |
johnsom | Umm, that does not sound good | 17:41 |
*** aojea has joined #openstack-lbaas | 17:42 | |
*** sshank has joined #openstack-lbaas | 17:42 | |
johnsom | JudeC FYI, did you see the bug I posted about he OSC? | 17:42 |
*** yamamoto has quit IRC | 17:42 | |
*** yamamoto has joined #openstack-lbaas | 17:43 | |
JudeC | Yeah I did thank you. | 17:43 |
JudeC | If I can get time today I might be able to push up a fix for that. | 17:43 |
johnsom | Cool, yeah, I think we missed a few uppers | 17:43 |
JudeC | yeah | 17:43 |
JudeC | I will just remove any of those uppers | 17:44 |
johnsom | Cool. Yeah, it would be nice to get that fixed and push a new release out | 17:44 |
*** cpuga has joined #openstack-lbaas | 17:44 | |
JudeC | they were leftovers from before I did choices... I needed to remove them all :/ | 17:44 |
johnsom | +1 | 17:45 |
johnsom | I finished the l7rule api-ref section. I plan to finish the last section for quota today, then I will get back to the API patches | 17:45 |
*** cpuga_ has joined #openstack-lbaas | 17:45 | |
JudeC | :) | 17:45 |
rm_work | johnsom: https://review.openstack.org/#/c/476701/ just updated the wording | 17:46 |
*** aojea has quit IRC | 17:46 | |
rm_work | xgerman_: you +2'd the patch AFTER https://review.openstack.org/#/c/476690/ :P | 17:46 |
johnsom | Yeah, I have that window open now | 17:46 |
rm_work | johnsom: yeah i think the new wording makes a LOT more sense | 17:47 |
rm_work | it was a little bit like "... but the docs say it is, wut" | 17:47 |
rm_work | xgerman_: https://review.openstack.org/#/c/477709/ easy one | 17:48 |
rm_work | xgerman_: also https://review.openstack.org/#/c/476290/ | 17:48 |
*** cpuga has quit IRC | 17:48 | |
johnsom | I just sent him those like 15 minutes ago | 17:49 |
johnsom | Ha | 17:49 |
xgerman_ | ok, looking… | 17:50 |
*** yamamoto has quit IRC | 17:50 | |
*** links has joined #openstack-lbaas | 17:55 | |
*** fnaval_ has joined #openstack-lbaas | 17:59 | |
*** links has quit IRC | 18:02 | |
*** fnaval has quit IRC | 18:03 | |
rm_work | lol | 18:03 |
*** fnaval_ has quit IRC | 18:06 | |
*** fnaval has joined #openstack-lbaas | 18:07 | |
*** gcheresh_ has joined #openstack-lbaas | 18:16 | |
*** krypto has quit IRC | 18:21 | |
*** cpuga_ has quit IRC | 18:27 | |
*** yamamoto has joined #openstack-lbaas | 18:27 | |
*** cpuga has joined #openstack-lbaas | 18:27 | |
*** sshank has quit IRC | 18:34 | |
*** yamamoto has quit IRC | 18:35 | |
*** cpuga_ has joined #openstack-lbaas | 18:35 | |
johnsom | rm_work I wonder if the way lubosz added this is your issue: https://github.com/openstack/octavia/blob/master/octavia/common/context.py#L36 | 18:38 |
rm_work | maybe | 18:38 |
johnsom | That is going to get called for every request | 18:38 |
*** cpuga has quit IRC | 18:39 | |
rm_work | yeah | 18:39 |
rm_work | probably | 18:39 |
rm_work | we want it to be called ONCE | 18:39 |
johnsom | No, it will, that is the context | 18:39 |
rm_work | right | 18:39 |
johnsom | Well, that part I'm not sure | 18:39 |
rm_work | i mean probably that is my issue | 18:39 |
rm_work | i can move it out | 18:39 |
rm_work | or, crap no i can't | 18:39 |
rm_work | it uses self | 18:39 |
rm_work | ummmmm | 18:39 |
johnsom | I mean, it does need to refresh | 18:42 |
rm_work | <_< | 18:42 |
rm_work | it seems like it's NOT hitting cache | 18:42 |
rm_work | because it's *reloading* right? | 18:42 |
rm_work | is that how you parse the message? | 18:43 |
openstackgerrit | Merged openstack/octavia master: DELETE operations don't actually return data (204) https://review.openstack.org/477709 | 18:43 |
openstackgerrit | Merged openstack/octavia master: Stop provider and flavor API stubs failing calls https://review.openstack.org/476290 | 18:44 |
rm_work | johnsom: yep confirmed, RBAC is ... | 18:48 |
rm_work | johnsom: performance KILLER | 18:48 |
rm_work | went to a non-rbac image (from earlier in the week) | 18:48 |
rm_work | requests are down to .3 seconds no matter what now | 18:48 |
johnsom | Yeah, I think we should not be creating a new one with each request | 18:50 |
*** yamamoto has joined #openstack-lbaas | 18:50 | |
*** yamamoto has quit IRC | 18:50 | |
johnsom | I really wish the oslo config docs were better | 18:51 |
openstackgerrit | boden proposed openstack/neutron-lbaas master: use service type constants from neutron_lib plugins https://review.openstack.org/478236 | 18:52 |
johnsom | rm_work Yeah, looking at nova and designate, they use a global _ENFORCER = None | 18:55 |
rm_work | hmmmm | 18:59 |
rm_work | ok | 18:59 |
rm_work | you going to do it or am I? :P | 19:00 |
johnsom | I can move this around and give it a go | 19:00 |
rm_work | k | 19:00 |
*** aojea has joined #openstack-lbaas | 19:03 | |
*** sshank has joined #openstack-lbaas | 19:20 | |
*** aojea has quit IRC | 19:21 | |
*** aojea has joined #openstack-lbaas | 19:21 | |
*** fnaval_ has joined #openstack-lbaas | 19:22 | |
*** fnaval has quit IRC | 19:23 | |
*** aojea has quit IRC | 19:26 | |
xgerman_ | FYI: Was in a call where they confused Octavia with LBaaS V2 — and of course said they are using Octavia. Our brand is strong! | 19:30 |
johnsom | There can be only one! | 19:31 |
xgerman_ | yep, and I prefer them calling LBaaS in OpenStack Octavia!! | 19:31 |
*** sanfern has quit IRC | 19:41 | |
*** sshank has quit IRC | 19:50 | |
*** yamamoto has joined #openstack-lbaas | 19:51 | |
*** sshank has joined #openstack-lbaas | 19:52 | |
*** aojea has joined #openstack-lbaas | 19:53 | |
*** sshank has quit IRC | 19:53 | |
*** sshank has joined #openstack-lbaas | 19:54 | |
*** yamamoto has quit IRC | 19:59 | |
*** cpuga has joined #openstack-lbaas | 20:13 | |
*** cpuga_ has quit IRC | 20:14 | |
openstackgerrit | Jude Cross proposed openstack/octavia master: Add status tree to V2 API https://review.openstack.org/474390 | 20:16 |
openstackgerrit | Jude Cross proposed openstack/octavia master: Add statistics to V2 API https://review.openstack.org/474885 | 20:16 |
*** cpuga has quit IRC | 20:17 | |
rm_work | johnsom: was pointed at https://review.openstack.org/#/c/469472/ | 20:26 |
rm_work | johnsom: if you haven't already started work, i'll just do it | 20:26 |
johnsom | rm_work I started, but hit scoping issues with the pecan test framework, so... Go for it! | 20:27 |
rm_work | johnsom: ah wut | 20:27 |
rm_work | i would probably hit the same thing? | 20:27 |
rm_work | i assume | 20:27 |
johnsom | Well, I am distracted with an internal meeting, so | 20:28 |
rm_work | lol k | 20:29 |
*** cody-somerville has joined #openstack-lbaas | 20:40 | |
*** cody-somerville has quit IRC | 20:40 | |
*** cody-somerville has joined #openstack-lbaas | 20:40 | |
*** csomerville has joined #openstack-lbaas | 20:41 | |
*** cody-somerville has quit IRC | 20:44 | |
rm_work | johnsom: so the only issue I have is | 20:56 |
rm_work | test_modified_policy_reloads | 20:56 |
rm_work | which .... | 20:56 |
rm_work | now it obviously won't do that | 20:56 |
rm_work | right? | 20:56 |
johnsom | Yeah, that was kind of the question I had | 20:59 |
johnsom | Pretty sure that test came in from nova | 20:59 |
rm_work | i'm gonna... uhh | 21:05 |
rm_work | remove that test | 21:05 |
rm_work | :thumbsup: | 21:05 |
johnsom | Wait, that is calling load_rules so it should be fine and not failing | 21:05 |
rm_work | :ok_hand: | 21:05 |
rm_work | err | 21:05 |
rm_work | hmmmmmmm | 21:06 |
rm_work | then why is it failing | 21:06 |
johnsom | Want to post what you have? | 21:06 |
rm_work | yeah load_rules isn't doing anything | 21:08 |
rm_work | sure one sec | 21:08 |
rm_work | title is a WIP | 21:09 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Fix policy re-load bug https://review.openstack.org/478280 | 21:09 |
rm_work | i'm looking to see if there's a way i can pass like | 21:09 |
rm_work | a lambda or something | 21:09 |
rm_work | so we can still pass the context on the create | 21:09 |
rm_work | but have it still be related to the current context | 21:09 |
rm_work | even when it's global | 21:10 |
rm_work | err, a singleton | 21:10 |
rm_work | there's gotta be a python trick for that | 21:10 |
*** leitan has quit IRC | 21:10 | |
*** leitan has joined #openstack-lbaas | 21:10 | |
*** leitan has quit IRC | 21:14 | |
*** sshank has quit IRC | 21:15 | |
johnsom | So, hmmm, the way I did it that test is passing.... | 21:25 |
rm_work | hmmmmm | 21:25 |
rm_work | how did you do it | 21:25 |
rm_work | but you had other issues? | 21:25 |
johnsom | Yeah, I was just being dumb while watching the meeting | 21:26 |
rm_work | also what is up with: https://github.com/openstack/octavia/blob/master/octavia/common/policy.py#L111-L113 | 21:26 |
johnsom | So, couple of things, we can't change the setup.cfg.... | 21:26 |
rm_work | why not? | 21:26 |
johnsom | That is for a tool set for docs and such, not used for the main code | 21:27 |
rm_work | yeah but we can remove that other function | 21:27 |
rm_work | since it is now essentially the same as the default one | 21:27 |
rm_work | no? | 21:27 |
johnsom | Does the command run? I would expect it would die with config issues | 21:28 |
rm_work | which command | 21:29 |
johnsom | oslopolicy-policy-generator | 21:30 |
rm_work | oh | 21:30 |
rm_work | checking | 21:30 |
johnsom | https://docs.openstack.org/developer/octavia/main/policy.html#merged-file-generation | 21:30 |
rm_work | i'm testing `tox -e genpolicy` | 21:30 |
rm_work | should be informative | 21:30 |
*** sshank has joined #openstack-lbaas | 21:30 | |
rm_work | ? | 21:30 |
rm_work | or different | 21:31 |
johnsom | genpolicy is different | 21:31 |
johnsom | genpolicy just dumps the defaults | 21:31 |
rm_work | ok yeah it looks like you are correct | 21:31 |
rm_work | k... so I can put that back | 21:32 |
rm_work | but what else did you do differently? | 21:32 |
rm_work | that causes the reload test to pass | 21:32 |
johnsom | I am not 100% sure. I don't inject it back in the context, I just updated everything to reference policy | 21:33 |
rm_work | ah | 21:39 |
rm_work | lol | 21:39 |
rm_work | yeah | 21:39 |
rm_work | that might be better | 21:39 |
rm_work | so want to just overwrite my CR | 21:39 |
rm_work | works for me | 21:39 |
rm_work | johnsom: ^^ | 21:42 |
johnsom | Might be easier to just abandon yours | 21:44 |
rm_work | WFM | 21:44 |
rm_work | push yours up whenev | 21:44 |
johnsom | Yeah, let me clean it up and finish running the other tests | 21:44 |
rm_work | i mean taking over a CR is just ... copying in the Change-Id line :P | 21:44 |
rm_work | and leaves less cruft (abandoned patches drive me crazy | 21:45 |
rm_work | ) | 21:45 |
johnsom | That works? Ha, hadn't tried that before | 21:45 |
*** gcheresh_ has quit IRC | 21:47 | |
rm_work | yes that's all gerrit is doing | 21:48 |
rm_work | it isn't magic :P | 21:48 |
rm_work | though I just thought to check preferences, and discovered I can make custom buttons in the top bar, so I made "Octavia" -> "#/q/project:openstack/octavia+status:open" | 21:48 |
rm_work | so now i care less | 21:48 |
*** fnaval_ has quit IRC | 21:48 | |
johnsom | Yeah, I have the same bookmark | 21:49 |
rm_work | xgerman_: https://review.openstack.org/#/c/473570/ | 21:52 |
rm_work | and xgerman_: https://review.openstack.org/#/c/476690/ | 21:52 |
rm_work | also xgerman_: https://review.openstack.org/#/c/476075/ | 21:52 |
xgerman_ | why are we deleting so many files in https://review.openstack.org/#/c/476690/ ? | 21:53 |
xgerman_ | did the other two — will pick that up after my break… | 21:54 |
rm_work | not deleting files | 21:54 |
rm_work | just fixing a lot of lines | 21:54 |
rm_work | the +/- is almost even on most files | 21:54 |
rm_work | had to fix all references to a bunch of config variables to point to a different group | 21:55 |
openstackgerrit | Merged openstack/python-octaviaclient master: Remove old pep8 ignores that are no longer necessary https://review.openstack.org/473570 | 21:55 |
johnsom | Yeah, some much needed cleanup of our [DEFAULT] config block | 21:55 |
rm_work | johnsom: want to fix https://github.com/openstack/octavia/blob/master/octavia/common/policy.py#L111-L113 while you're doing that | 21:55 |
rm_work | that is super dumb | 21:56 |
rm_work | probably an artifact of some copy/paste and changing things and then not reading the whole block again lol | 21:56 |
johnsom | Ha | 21:56 |
johnsom | Yes it is | 21:56 |
johnsom | https://github.com/openstack/nova/blob/master/nova/policy.py#L179 | 21:57 |
johnsom | I guess it makes it more readable... | 21:58 |
*** aojea has quit IRC | 22:01 | |
*** aojea has joined #openstack-lbaas | 22:01 | |
rm_work | <_< | 22:02 |
rm_work | >_> | 22:02 |
johnsom | hahah | 22:03 |
johnsom | I removed the extra assignment | 22:03 |
rm_work | target=credentials, credentials=credentials is also readable | 22:04 |
rm_work | if we want to do that | 22:04 |
*** aojea has quit IRC | 22:05 | |
*** sshank has quit IRC | 22:06 | |
*** sshank has joined #openstack-lbaas | 22:06 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Don't reload the policy for every API request. https://review.openstack.org/478280 | 23:34 |
johnsom | rm_work ^^^ | 23:34 |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Don't reload the policy for every API request. https://review.openstack.org/478280 | 23:36 |
johnsom | Blah, left some commented out lines in there | 23:36 |
*** sshank has quit IRC | 23:43 | |
*** sshank has joined #openstack-lbaas | 23:49 | |
rm_work | yeah i like that better | 23:51 |
rm_work | i was going for the FAST fix | 23:52 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!