Tuesday, 2017-06-27

*** fnaval_ has quit IRC00:06
*** fnaval has joined #openstack-lbaas00:06
openstackgerritJoshua Harlow proposed openstack/octavia master: Gather cert rotatation failure/pass after executor is done  https://review.openstack.org/47772000:12
openstackgerritJoshua Harlow proposed openstack/octavia master: Gather fail/pass after executor is done  https://review.openstack.org/47772000:22
openstackgerritJoshua Harlow proposed openstack/octavia master: Gather fail/pass after executor is done  https://review.openstack.org/47772000:24
openstackgerritMerged openstack/octavia master: Add v2 L7 Policy API section  https://review.openstack.org/47717400:37
openstackgerritMerged openstack/octavia master: Replace the usage of 'admin_manager' with 'os_admin'  https://review.openstack.org/47735700:38
*** fnaval_ has joined #openstack-lbaas00:50
*** fnaval has quit IRC00:53
openstackgerritJude Cross proposed openstack/octavia master: Add status tree to V2 API  https://review.openstack.org/47439000:53
*** JudeC has joined #openstack-lbaas00:54
*** fnaval_ has quit IRC00:54
*** JudeC has quit IRC00:55
*** armax has joined #openstack-lbaas01:06
*** aojea has joined #openstack-lbaas01:16
*** blogan has quit IRC01:17
*** reedip has quit IRC01:17
*** aojea has quit IRC01:23
*** reedip has joined #openstack-lbaas01:30
*** armax has quit IRC01:45
rm_workchanging the message a bit on the TLS_TERMINATION disabled thing01:46
rm_workit's not informative enough and could be confusing01:47
rm_work(not sure if those went through)01:47
*** leitan has joined #openstack-lbaas01:47
openstackgerritAdam Harwell proposed openstack/octavia master: Allow operators to disallow creation of TLS Termination listeners  https://review.openstack.org/47670101:47
*** JudeC has joined #openstack-lbaas01:50
*** leitan has quit IRC01:52
*** fnaval has joined #openstack-lbaas01:59
eanderssonrm_work, johnsom : Could you take a look at the failing tests due to my lazy change? pretty sure that is nothing, but would be nice to have someone that understands this better take a look02:14
openstackgerritJude Cross proposed openstack/octavia master: Add statistics to V2 API  https://review.openstack.org/47488502:14
rm_worksaying we "understand" neutron-lbaas stuff is maybe an overstatement02:15
rm_worki pretty much ignore that whole system because it needs to go away ASAP T_T02:15
eanderssonhehe02:15
rm_workbut, i'm looking02:15
eanderssonwish I could just go to pike, but gonna take time02:15
eanderssonpretty sure the test is failing because there is more information now than before02:16
*** JudeC has quit IRC02:17
rm_workerm02:18
rm_workno02:18
rm_workit's failing because it isn't returning listener data02:18
rm_workwhich is honestly probably related to changing model stuff <_<02:18
eanderssonI assumed that actual is the "actual" data, while "reference" was the example data02:19
rm_workmight change the order it loads things during processing, causing it to miss newly created stuff? not sure02:19
rm_workyes, it is02:19
rm_workah yes, sometimes it is expecting a listener but doesn't see one, and sometimes it sees a listener but isn't expecting one02:19
rm_workhere it's not expecting a listener, but gets one: http://logs.openstack.org/98/477698/2/check/gate-neutron-lbaasv2-dsvm-api-ubuntu-xenial/fc54f20/console.html#_2017-06-27_00_20_08_90022902:20
rm_workhmm, same here: http://logs.openstack.org/98/477698/2/check/gate-neutron-lbaasv2-dsvm-api-ubuntu-xenial/fc54f20/console.html#_2017-06-27_00_20_08_76202102:20
rm_workhmm yeah guess i read that wrong the first time, can't find the counterexample02:21
rm_workso it just lists things it shouldn't02:21
rm_workwhich is ... odd02:21
eanderssonit's odd, as according to the test it should have a listener02:21
rm_workand gets the wrong number of pools back often02:21
rm_workerm02:21
eanderssonI think that is just because it never reaches the delete02:21
eanderssonbecause of the assert02:21
rm_workI don't THINK these tests are failing on other changes tho, are they?02:22
eanderssone.g. in the one you linked it asserts before _delete_pool02:22
eanderssonnope, dont think sop02:22
rm_workhttps://review.openstack.org/#/c/476333/ passed just earlier02:23
rm_workerr, nm that was days ago02:23
eanderssonThis is def due to the lazy change02:23
eanderssonIt kinda makes sense I think... previously the field was lazy-loaded, meaning unless it got called, it wouldn't be fetched right?02:25
eanderssonbut now, since it is no longer lazy-loaded, it will always be loaded02:25
eanderssonThis might be why the result from get and create pool is different https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/services/loadbalancer/plugin.py#L68202:31
eanderssonSeriously can't wait until I can move over to Octavia :D02:33
openstackgerritErik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: [WIP] Remove unnecessary lazy-loaded queries  https://review.openstack.org/47769802:39
*** aojea has joined #openstack-lbaas03:09
*** aojea has quit IRC03:13
*** gans has joined #openstack-lbaas03:24
*** yamamoto has joined #openstack-lbaas03:29
openstackgerritErik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: [WIP] Remove unnecessary lazy-loaded queries  https://review.openstack.org/47769803:34
*** links has joined #openstack-lbaas03:42
*** cody-somerville has quit IRC03:42
*** cody-somerville has joined #openstack-lbaas03:42
openstackgerritMerged openstack/neutron-lbaas master: Replace the usage of 'manager' with 'os_primary'  https://review.openstack.org/47633303:48
*** sticker_ has joined #openstack-lbaas03:52
*** sticker has quit IRC03:55
*** amotoki_away is now known as amotoki04:10
*** krypto has joined #openstack-lbaas04:13
*** krypto has joined #openstack-lbaas04:13
*** sticker_ is now known as sticker04:15
openstackgerritJoshua Harlow proposed openstack/octavia master: Gather fail/pass after executor is done  https://review.openstack.org/47772004:15
openstackgerritErik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: [WIP] Remove unnecessary lazy-loaded queries  https://review.openstack.org/47769804:22
*** fnaval has quit IRC04:42
*** JudeC has joined #openstack-lbaas05:00
openstackgerritJude Cross proposed openstack/octavia master: Add status tree to V2 API  https://review.openstack.org/47439005:06
openstackgerritJude Cross proposed openstack/octavia master: Add statistics to V2 API  https://review.openstack.org/47488505:06
*** csomerville has joined #openstack-lbaas05:10
*** cody-somerville has quit IRC05:13
*** m-greene has quit IRC05:14
*** m-greene has joined #openstack-lbaas05:14
*** JudeC has quit IRC05:14
rm_workjohnsom: what is `octavia-wsgi`??05:21
*** gcheresh has joined #openstack-lbaas05:22
*** oomichi_ has joined #openstack-lbaas05:36
*** pck_ has joined #openstack-lbaas05:38
*** oomichi has quit IRC05:39
*** oomichi_ is now known as oomichi05:39
*** pck has quit IRC05:39
*** bcafarel has quit IRC05:39
*** aojea has joined #openstack-lbaas05:39
johnsomrm_work https://github.com/openstack/octavia/blob/master/setup.cfg#L5205:50
johnsomIt is the pbr generated script05:50
johnsomIt was for the "goal" before the "goal" changed05:50
johnsomCatch you tomorrow05:53
*** rcernin has joined #openstack-lbaas05:55
rm_workhmm k05:57
rm_workyeah trying to figure out how to run our app with a real runner05:57
*** aojea has quit IRC06:05
*** armax has joined #openstack-lbaas06:06
openstackgerritErik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: [WIP] Remove unnecessary lazy-loaded queries  https://review.openstack.org/47769806:19
openstackgerritMerged openstack/octavia master: No need to do a shutdown(wait=True) when in a context-manager  https://review.openstack.org/47706306:22
*** rcernin has quit IRC06:26
*** rcernin has joined #openstack-lbaas06:32
*** kobis has joined #openstack-lbaas06:38
*** fnaval has joined #openstack-lbaas06:43
*** armax has quit IRC06:44
*** fnaval has quit IRC06:48
*** tesseract has joined #openstack-lbaas06:55
*** gans819 has joined #openstack-lbaas07:12
*** gans has quit IRC07:13
*** pcaruana has joined #openstack-lbaas07:32
*** rstarmer has joined #openstack-lbaas07:43
*** sanfern has joined #openstack-lbaas07:54
openstackgerritErik Olof Gunnar Andersson proposed openstack/neutron-lbaas master: [WIP] Remove unnecessary lazy-loaded queries  https://review.openstack.org/47769807:55
openstackgerrittuninger proposed openstack/neutron-lbaas master: Add the code for updating the servers statistics based on haproxy stats data. Fixes Bug1699945.  https://review.openstack.org/47684808:04
*** aojea has joined #openstack-lbaas08:05
*** ajo has quit IRC08:17
*** ajo has joined #openstack-lbaas08:19
*** aojea has quit IRC08:28
*** aojea has joined #openstack-lbaas08:34
*** sanfern has quit IRC08:35
*** sanfern has joined #openstack-lbaas08:40
*** fnaval has joined #openstack-lbaas08:44
*** fnaval has quit IRC08:49
*** yamamoto has quit IRC09:23
*** gcheresh_ has joined #openstack-lbaas09:27
*** yamamoto has joined #openstack-lbaas09:29
*** slaweq has joined #openstack-lbaas09:30
*** logan_ has joined #openstack-lbaas09:33
*** OGtrilliams has joined #openstack-lbaas09:34
*** gcheresh has quit IRC09:34
*** reedip has quit IRC09:34
*** afranc has quit IRC09:34
*** PagliaccisCloud has quit IRC09:34
*** logan- has quit IRC09:34
*** slaweq__ has quit IRC09:35
*** OGtrilliams is now known as PagliaccisCloud09:35
*** sanfern has quit IRC09:35
*** afranc has joined #openstack-lbaas09:35
*** logan_ is now known as logan-09:37
*** reedip has joined #openstack-lbaas09:40
*** sanfern has joined #openstack-lbaas09:41
*** rstarmer has quit IRC09:42
*** chlong has joined #openstack-lbaas09:46
*** csomerville has quit IRC09:51
*** gans819 has quit IRC09:56
*** rstarmer has joined #openstack-lbaas10:03
openstackgerrittuninger proposed openstack/neutron-lbaas master: Add the code for updating the servers statistics based on haproxy stats data. Fixes Bug1699945.  https://review.openstack.org/47684810:05
*** rstarmer has quit IRC10:14
*** fnaval has joined #openstack-lbaas10:45
*** amotoki is now known as amotoki_away10:46
*** fnaval has quit IRC10:49
*** amotoki_away is now known as amotoki10:51
*** sanfern has quit IRC10:55
*** amotoki is now known as amotoki_away11:01
*** chlong_ has joined #openstack-lbaas11:04
*** chlong has quit IRC11:04
*** aojea has quit IRC11:34
*** atoth has joined #openstack-lbaas11:41
*** reedip_ has joined #openstack-lbaas12:05
*** amotoki_away is now known as amotoki12:07
*** krypto has quit IRC12:39
*** krypto has joined #openstack-lbaas12:40
*** krypto has quit IRC12:40
*** krypto has joined #openstack-lbaas12:40
*** rstarmer has joined #openstack-lbaas12:41
openstackgerrittuninger proposed openstack/neutron-lbaas master: Add the code for updating the servers statistics based on haproxy stats data. Fixes Bug1699945.  https://review.openstack.org/47684812:41
*** sanfern has joined #openstack-lbaas12:44
*** krypto has quit IRC12:45
*** krypto has joined #openstack-lbaas12:45
*** fnaval has joined #openstack-lbaas12:46
*** rstarmer has quit IRC12:48
*** fnaval has quit IRC12:50
*** rstarmer has joined #openstack-lbaas12:50
*** rstarmer has quit IRC12:57
*** krypto has quit IRC13:01
*** krypto has joined #openstack-lbaas13:02
*** krypto has quit IRC13:03
*** krypto has joined #openstack-lbaas13:04
*** krypto has quit IRC13:10
*** krypto has joined #openstack-lbaas13:10
*** fnaval has joined #openstack-lbaas13:26
*** cpuga has joined #openstack-lbaas13:33
*** cpuga_ has joined #openstack-lbaas13:37
*** cpuga has quit IRC13:40
*** leitan has joined #openstack-lbaas13:46
*** kobis has quit IRC13:58
isantospHi, about octavia lbaas-loadbalancer-create, is there any way to create the loadbalancer without passing the subnet_id? for example passing the subnet as a default parameter?14:12
*** cpuga_ has quit IRC14:18
*** aojea has joined #openstack-lbaas14:28
*** sanfern has quit IRC14:28
*** dayou has joined #openstack-lbaas14:28
*** sanfern has joined #openstack-lbaas14:29
*** cpuga has joined #openstack-lbaas14:30
*** fnaval has quit IRC14:30
johnsomisantosp One of the three methods is required: https://developer.openstack.org/api-ref/load-balancer/v2/index.html?expanded=create-a-load-balancer-detail14:36
johnsomEither pass in a port, a network, or a subnet14:36
*** fnaval has joined #openstack-lbaas14:48
*** gcheresh_ has quit IRC14:55
*** reedip_ is now known as reedip_out_of_ar15:02
*** rcernin has quit IRC15:04
*** links has quit IRC15:05
*** kobis has joined #openstack-lbaas15:16
*** reedip_out_of_ar has quit IRC15:37
*** aojea has quit IRC15:37
*** aojea has joined #openstack-lbaas15:38
johnsomFYI, we have a bug in the OSC client:15:42
johnsomhttps://bugs.launchpad.net/octavia/+bug/170077815:42
openstackLaunchpad bug 1700778 in octavia "Octavia OSC plugin is failing to create l7rules" [Critical,Triaged]15:42
johnsomI thought we fixed those, but I guess not.15:42
*** aojea has quit IRC15:42
johnsomYeah, it looks like we fixed some of them, but not all of them15:45
*** links has joined #openstack-lbaas16:02
*** chlong has joined #openstack-lbaas16:05
openstackgerritMerged openstack/octavia-tempest-plugin master: Updated from global requirements  https://review.openstack.org/47798616:05
*** chlong has quit IRC16:05
openstackgerritMerged openstack/octavia-dashboard master: Updated from global requirements  https://review.openstack.org/47798516:07
*** pcaruana has quit IRC16:09
*** cpuga has quit IRC16:24
*** blogan has joined #openstack-lbaas16:34
*** gans has joined #openstack-lbaas16:35
*** kobis has quit IRC16:37
*** tesseract has quit IRC16:40
*** reedip has quit IRC16:41
*** reedip has joined #openstack-lbaas16:43
*** gans has quit IRC16:43
*** kobis has joined #openstack-lbaas16:46
*** amotoki is now known as amotoki_away16:57
*** links has quit IRC16:57
openstackgerritMichael Johnson proposed openstack/octavia master: Add v2 L7 Rule API section  https://review.openstack.org/47821717:01
*** kobis has quit IRC17:02
*** JudeC has joined #openstack-lbaas17:02
openstackgerritMichael Johnson proposed openstack/octavia master: Add v2 L7 Rule API section  https://review.openstack.org/47821717:03
*** aojea has joined #openstack-lbaas17:08
*** krypto has quit IRC17:09
*** krypto has joined #openstack-lbaas17:09
*** krypto has quit IRC17:09
*** krypto has joined #openstack-lbaas17:09
*** sshank has joined #openstack-lbaas17:28
*** sshank has quit IRC17:39
rm_workjohnsom: ah hmm17:40
rm_workjohnsom: so do you know how to run our api with a REAL runner like gunicorn?17:40
rm_workjohnsom: i thought that's what octavia-wsgi did? but it's all like "DO NOT USE FOR PROD" lol17:40
rm_worki'm trying to figure out these performance issues17:40
johnsomWell, the pbr generated stuff is a bit weak.17:41
rm_worki can't repro the 10s+ calls but17:41
rm_workour API looks like it can handle about 1 request per second without being slow17:41
*** aojea has quit IRC17:41
johnsomSo, yeah, I need to do the uwsgi stuff anyway, that might help you.17:41
johnsomUmm, that does not sound good17:41
*** aojea has joined #openstack-lbaas17:42
*** sshank has joined #openstack-lbaas17:42
johnsomJudeC FYI, did you see the bug I posted about he OSC?17:42
*** yamamoto has quit IRC17:42
*** yamamoto has joined #openstack-lbaas17:43
JudeCYeah I did thank you.17:43
JudeCIf I can get time today I might be able to push up a fix for that.17:43
johnsomCool, yeah, I think we missed a few uppers17:43
JudeCyeah17:43
JudeCI will just remove any of those uppers17:44
johnsomCool.  Yeah, it would be nice to get that fixed and push a new release out17:44
*** cpuga has joined #openstack-lbaas17:44
JudeCthey were leftovers from before I did choices... I needed to remove them all :/17:44
johnsom+117:45
johnsomI finished the l7rule api-ref section.  I plan to finish the last section for quota today, then I will get back to the API patches17:45
*** cpuga_ has joined #openstack-lbaas17:45
JudeC:)17:45
rm_workjohnsom: https://review.openstack.org/#/c/476701/ just updated the wording17:46
*** aojea has quit IRC17:46
rm_workxgerman_: you +2'd the patch AFTER https://review.openstack.org/#/c/476690/ :P17:46
johnsomYeah, I have that window open now17:46
rm_workjohnsom: yeah i think the new wording makes a LOT more sense17:47
rm_workit was a little bit like "... but the docs say it is, wut"17:47
rm_workxgerman_: https://review.openstack.org/#/c/477709/ easy one17:48
rm_workxgerman_: also https://review.openstack.org/#/c/476290/17:48
*** cpuga has quit IRC17:48
johnsomI just sent him those like 15 minutes ago17:49
johnsomHa17:49
xgerman_ok, looking…17:50
*** yamamoto has quit IRC17:50
*** links has joined #openstack-lbaas17:55
*** fnaval_ has joined #openstack-lbaas17:59
*** links has quit IRC18:02
*** fnaval has quit IRC18:03
rm_worklol18:03
*** fnaval_ has quit IRC18:06
*** fnaval has joined #openstack-lbaas18:07
*** gcheresh_ has joined #openstack-lbaas18:16
*** krypto has quit IRC18:21
*** cpuga_ has quit IRC18:27
*** yamamoto has joined #openstack-lbaas18:27
*** cpuga has joined #openstack-lbaas18:27
*** sshank has quit IRC18:34
*** yamamoto has quit IRC18:35
*** cpuga_ has joined #openstack-lbaas18:35
johnsomrm_work I wonder if the way lubosz added this is your issue: https://github.com/openstack/octavia/blob/master/octavia/common/context.py#L3618:38
rm_workmaybe18:38
johnsomThat is going to get called for every request18:38
*** cpuga has quit IRC18:39
rm_workyeah18:39
rm_workprobably18:39
rm_workwe want it to be called ONCE18:39
johnsomNo, it will, that is the context18:39
rm_workright18:39
johnsomWell, that part I'm not sure18:39
rm_worki mean probably that is my issue18:39
rm_worki can move it out18:39
rm_workor, crap no i can't18:39
rm_workit uses self18:39
rm_workummmmm18:39
johnsomI mean, it does need to refresh18:42
rm_work<_<18:42
rm_workit seems like it's NOT hitting cache18:42
rm_workbecause it's *reloading* right?18:42
rm_workis that how you parse the message?18:43
openstackgerritMerged openstack/octavia master: DELETE operations don't actually return data (204)  https://review.openstack.org/47770918:43
openstackgerritMerged openstack/octavia master: Stop provider and flavor API stubs failing calls  https://review.openstack.org/47629018:44
rm_workjohnsom: yep confirmed, RBAC is ...18:48
rm_workjohnsom: performance KILLER18:48
rm_workwent to a non-rbac image (from earlier in the week)18:48
rm_workrequests are down to .3 seconds no matter what now18:48
johnsomYeah, I think we should not be creating a new one with each request18:50
*** yamamoto has joined #openstack-lbaas18:50
*** yamamoto has quit IRC18:50
johnsomI really wish the oslo config docs were better18:51
openstackgerritboden proposed openstack/neutron-lbaas master: use service type constants from neutron_lib plugins  https://review.openstack.org/47823618:52
johnsomrm_work Yeah, looking at nova and designate, they use a global _ENFORCER = None18:55
rm_workhmmmm18:59
rm_workok18:59
rm_workyou going to do it or am I? :P19:00
johnsomI can move this around and give it a go19:00
rm_workk19:00
*** aojea has joined #openstack-lbaas19:03
*** sshank has joined #openstack-lbaas19:20
*** aojea has quit IRC19:21
*** aojea has joined #openstack-lbaas19:21
*** fnaval_ has joined #openstack-lbaas19:22
*** fnaval has quit IRC19:23
*** aojea has quit IRC19:26
xgerman_FYI: Was in a call where they confused Octavia with LBaaS V2 — and of course said they are using Octavia. Our brand is strong!19:30
johnsomThere can be only one!19:31
xgerman_yep, and I prefer them calling LBaaS in OpenStack Octavia!!19:31
*** sanfern has quit IRC19:41
*** sshank has quit IRC19:50
*** yamamoto has joined #openstack-lbaas19:51
*** sshank has joined #openstack-lbaas19:52
*** aojea has joined #openstack-lbaas19:53
*** sshank has quit IRC19:53
*** sshank has joined #openstack-lbaas19:54
*** yamamoto has quit IRC19:59
*** cpuga has joined #openstack-lbaas20:13
*** cpuga_ has quit IRC20:14
openstackgerritJude Cross proposed openstack/octavia master: Add status tree to V2 API  https://review.openstack.org/47439020:16
openstackgerritJude Cross proposed openstack/octavia master: Add statistics to V2 API  https://review.openstack.org/47488520:16
*** cpuga has quit IRC20:17
rm_workjohnsom: was pointed at https://review.openstack.org/#/c/469472/20:26
rm_workjohnsom: if you haven't already started work, i'll just do it20:26
johnsomrm_work I started, but hit scoping issues with the pecan test framework, so...  Go for it!20:27
rm_workjohnsom: ah wut20:27
rm_worki would probably hit the same thing?20:27
rm_worki assume20:27
johnsomWell, I am distracted with an internal meeting, so20:28
rm_worklol k20:29
*** cody-somerville has joined #openstack-lbaas20:40
*** cody-somerville has quit IRC20:40
*** cody-somerville has joined #openstack-lbaas20:40
*** csomerville has joined #openstack-lbaas20:41
*** cody-somerville has quit IRC20:44
rm_workjohnsom: so the only issue I have is20:56
rm_worktest_modified_policy_reloads20:56
rm_workwhich ....20:56
rm_worknow it obviously won't do that20:56
rm_workright?20:56
johnsomYeah, that was kind of the question I had20:59
johnsomPretty sure that test came in from nova20:59
rm_worki'm gonna... uhh21:05
rm_workremove that test21:05
rm_work:thumbsup:21:05
johnsomWait, that is calling load_rules so it should be fine and not failing21:05
rm_work:ok_hand:21:05
rm_workerr21:05
rm_workhmmmmmmm21:06
rm_workthen why is it failing21:06
johnsomWant to post what you have?21:06
rm_workyeah load_rules isn't doing anything21:08
rm_worksure one sec21:08
rm_worktitle is a WIP21:09
openstackgerritAdam Harwell proposed openstack/octavia master: Fix policy re-load bug  https://review.openstack.org/47828021:09
rm_worki'm looking to see if there's a way i can pass like21:09
rm_worka lambda or something21:09
rm_workso we can still pass the context on the create21:09
rm_workbut have it still be related to the current context21:09
rm_workeven when it's global21:10
rm_workerr, a singleton21:10
rm_workthere's gotta be a python trick for that21:10
*** leitan has quit IRC21:10
*** leitan has joined #openstack-lbaas21:10
*** leitan has quit IRC21:14
*** sshank has quit IRC21:15
johnsomSo, hmmm, the way I did it that test is passing....21:25
rm_workhmmmmm21:25
rm_workhow did you do it21:25
rm_workbut you had other issues?21:25
johnsomYeah, I was just being dumb while watching the meeting21:26
rm_workalso what is up with: https://github.com/openstack/octavia/blob/master/octavia/common/policy.py#L111-L11321:26
johnsomSo, couple of things, we can't change the setup.cfg....21:26
rm_workwhy not?21:26
johnsomThat is for a tool set for docs and such, not used for the main code21:27
rm_workyeah but we can remove that other function21:27
rm_worksince it is now essentially the same as the default one21:27
rm_workno?21:27
johnsomDoes the command run?  I would expect it would die with config issues21:28
rm_workwhich command21:29
johnsomoslopolicy-policy-generator21:30
rm_workoh21:30
rm_workchecking21:30
johnsomhttps://docs.openstack.org/developer/octavia/main/policy.html#merged-file-generation21:30
rm_worki'm testing `tox -e genpolicy`21:30
rm_workshould be informative21:30
*** sshank has joined #openstack-lbaas21:30
rm_work?21:30
rm_workor different21:31
johnsomgenpolicy is different21:31
johnsomgenpolicy just dumps the defaults21:31
rm_workok yeah it looks like you are correct21:31
rm_workk... so I can put that back21:32
rm_workbut what else did you do differently?21:32
rm_workthat causes the reload test to pass21:32
johnsomI am not 100% sure.  I don't inject it back in the context, I just updated everything to reference policy21:33
rm_workah21:39
rm_worklol21:39
rm_workyeah21:39
rm_workthat might be better21:39
rm_workso want to just overwrite my CR21:39
rm_workworks for me21:39
rm_workjohnsom: ^^21:42
johnsomMight be easier to just abandon yours21:44
rm_workWFM21:44
rm_workpush yours up whenev21:44
johnsomYeah, let me clean it up and finish running the other tests21:44
rm_worki mean taking over a CR is just ... copying in the Change-Id line :P21:44
rm_workand leaves less cruft (abandoned patches drive me crazy21:45
rm_work)21:45
johnsomThat works?  Ha, hadn't tried that before21:45
*** gcheresh_ has quit IRC21:47
rm_workyes that's all gerrit is doing21:48
rm_workit isn't magic :P21:48
rm_workthough I just thought to check preferences, and discovered I can make custom buttons in the top bar, so I made "Octavia" -> "#/q/project:openstack/octavia+status:open"21:48
rm_workso now i care less21:48
*** fnaval_ has quit IRC21:48
johnsomYeah, I have the same bookmark21:49
rm_workxgerman_: https://review.openstack.org/#/c/473570/21:52
rm_workand xgerman_: https://review.openstack.org/#/c/476690/21:52
rm_workalso xgerman_: https://review.openstack.org/#/c/476075/21:52
xgerman_why are we deleting so many files in https://review.openstack.org/#/c/476690/ ?21:53
xgerman_did the other two — will pick that up after my break…21:54
rm_worknot deleting files21:54
rm_workjust fixing a lot of lines21:54
rm_workthe +/- is almost even on most files21:54
rm_workhad to fix all references to a bunch of config variables to point to a different group21:55
openstackgerritMerged openstack/python-octaviaclient master: Remove old pep8 ignores that are no longer necessary  https://review.openstack.org/47357021:55
johnsomYeah, some much needed cleanup of our [DEFAULT] config block21:55
rm_workjohnsom: want to fix https://github.com/openstack/octavia/blob/master/octavia/common/policy.py#L111-L113 while you're doing that21:55
rm_workthat is super dumb21:56
rm_workprobably an artifact of some copy/paste and changing things and then not reading the whole block again lol21:56
johnsomHa21:56
johnsomYes it is21:56
johnsomhttps://github.com/openstack/nova/blob/master/nova/policy.py#L17921:57
johnsomI guess it makes it more readable...21:58
*** aojea has quit IRC22:01
*** aojea has joined #openstack-lbaas22:01
rm_work<_<22:02
rm_work>_>22:02
johnsomhahah22:03
johnsomI removed the extra assignment22:03
rm_worktarget=credentials, credentials=credentials is also readable22:04
rm_workif we want to do that22:04
*** aojea has quit IRC22:05
*** sshank has quit IRC22:06
*** sshank has joined #openstack-lbaas22:06
openstackgerritMichael Johnson proposed openstack/octavia master: Don't reload the policy for every API request.  https://review.openstack.org/47828023:34
johnsomrm_work ^^^23:34
openstackgerritMichael Johnson proposed openstack/octavia master: Don't reload the policy for every API request.  https://review.openstack.org/47828023:36
johnsomBlah, left some commented out lines in there23:36
*** sshank has quit IRC23:43
*** sshank has joined #openstack-lbaas23:49
rm_workyeah i like that better23:51
rm_worki was going for the FAST fix23:52

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!