*** ducttape_ has joined #openstack-lbaas | 00:01 | |
*** ducttape_ has quit IRC | 00:06 | |
*** reedip has quit IRC | 00:25 | |
*** catintheroof has quit IRC | 00:34 | |
*** ducttape_ has joined #openstack-lbaas | 00:42 | |
*** sanfern has quit IRC | 00:48 | |
*** ducttape_ has quit IRC | 00:52 | |
*** ducttape_ has joined #openstack-lbaas | 00:52 | |
*** cpuga has joined #openstack-lbaas | 01:06 | |
*** gongysh has joined #openstack-lbaas | 01:15 | |
*** amotoki has joined #openstack-lbaas | 01:46 | |
*** amotoki has quit IRC | 01:58 | |
*** gongysh has quit IRC | 01:59 | |
*** ducttape_ has quit IRC | 02:03 | |
bbbzhao | johnsom, reedip_ , Thank you for discuss. Sorry for late..I really want to work with our team, :). I will update that spec soon. | 02:05 |
---|---|---|
*** ducttape_ has joined #openstack-lbaas | 02:06 | |
bbbzhao | reedip_, the duplicate bug https://bugs.launchpad.net/octavia/+bug/1657089 , this one is the first one RFE bug I reported, as I didn't know lb function will be move to octavia project at that time, sorry for confused. | 02:07 |
openstack | Launchpad bug 1657090 in octavia "duplicate for #1657089 [RFE]Add bandwidth_limit to vip" [Wishlist,In progress] - Assigned to zhaobo (zhaobo6) | 02:07 |
*** ducttape_ has quit IRC | 02:11 | |
*** yamamoto has joined #openstack-lbaas | 02:29 | |
*** reedip has joined #openstack-lbaas | 02:31 | |
*** yamamoto has quit IRC | 02:33 | |
*** sanfern has joined #openstack-lbaas | 02:45 | |
*** gongysh has joined #openstack-lbaas | 02:48 | |
*** aojea has joined #openstack-lbaas | 02:49 | |
*** aojea has quit IRC | 02:54 | |
*** yuanying has quit IRC | 02:55 | |
*** amotoki has joined #openstack-lbaas | 03:00 | |
*** ducttape_ has joined #openstack-lbaas | 03:07 | |
*** links has joined #openstack-lbaas | 03:12 | |
*** ducttape_ has quit IRC | 03:12 | |
*** raginbajin has quit IRC | 03:14 | |
*** raginbajin has joined #openstack-lbaas | 03:21 | |
openstackgerrit | Liang Cui proposed openstack/neutron-lbaas master: add @classmethod for health_monitor https://review.openstack.org/451157 | 03:25 |
openstackgerrit | ZhaoBo proposed openstack/octavia master: Support QoS policy apply on vip port https://review.openstack.org/441912 | 03:36 |
*** fnaval has quit IRC | 03:55 | |
*** fnaval has joined #openstack-lbaas | 03:56 | |
*** fnaval has quit IRC | 04:00 | |
*** reedip has quit IRC | 04:17 | |
*** reedip has joined #openstack-lbaas | 04:19 | |
*** ducttape_ has joined #openstack-lbaas | 04:38 | |
*** yuanying has joined #openstack-lbaas | 04:39 | |
*** ducttape_ has quit IRC | 04:43 | |
openstackgerrit | Ankur proposed openstack/octavia master: Octavia Feature Classification https://review.openstack.org/451177 | 04:51 |
*** gcheresh_ has joined #openstack-lbaas | 04:57 | |
reedip | still working ??? | 05:07 |
*** oomichi has quit IRC | 05:29 | |
*** oomichi has joined #openstack-lbaas | 05:33 | |
*** yamamoto has joined #openstack-lbaas | 05:35 | |
*** rcernin has joined #openstack-lbaas | 05:39 | |
*** yamamoto has quit IRC | 05:40 | |
*** reedip has quit IRC | 05:54 | |
*** fnaval has joined #openstack-lbaas | 05:56 | |
*** fnaval has quit IRC | 06:01 | |
*** reedip has joined #openstack-lbaas | 06:01 | |
*** armax has quit IRC | 06:06 | |
*** ducttape_ has joined #openstack-lbaas | 06:08 | |
*** ducttape_ has quit IRC | 06:12 | |
*** pcaruana has joined #openstack-lbaas | 06:24 | |
*** yamamoto has joined #openstack-lbaas | 06:41 | |
*** yamamoto has quit IRC | 06:47 | |
*** kobis has joined #openstack-lbaas | 06:50 | |
*** kobis has quit IRC | 06:56 | |
*** gongysh has quit IRC | 07:01 | |
*** tesseract has joined #openstack-lbaas | 07:14 | |
*** aojea has joined #openstack-lbaas | 07:20 | |
*** oomichi has quit IRC | 07:29 | |
*** oomichi has joined #openstack-lbaas | 07:33 | |
*** gongysh has joined #openstack-lbaas | 07:35 | |
*** ducttape_ has joined #openstack-lbaas | 07:39 | |
*** aojea_ has joined #openstack-lbaas | 07:41 | |
*** kobis has joined #openstack-lbaas | 07:42 | |
*** yamamoto has joined #openstack-lbaas | 07:43 | |
*** ducttape_ has quit IRC | 07:44 | |
*** aojea has quit IRC | 07:44 | |
*** yamamoto has quit IRC | 07:48 | |
*** cpuga has quit IRC | 07:51 | |
*** fnaval has joined #openstack-lbaas | 07:57 | |
*** fnaval has quit IRC | 08:01 | |
*** krypto has joined #openstack-lbaas | 08:09 | |
*** ducnc has joined #openstack-lbaas | 08:09 | |
*** yuanying has quit IRC | 08:31 | |
*** yamamoto has joined #openstack-lbaas | 08:45 | |
*** yamamoto has quit IRC | 08:50 | |
*** cody-somerville has quit IRC | 09:02 | |
*** gongysh has quit IRC | 09:02 | |
*** cody-somerville has joined #openstack-lbaas | 09:02 | |
*** ducttape_ has joined #openstack-lbaas | 09:09 | |
*** ducttape_ has quit IRC | 09:14 | |
*** blogan has quit IRC | 09:34 | |
*** blogan_ has joined #openstack-lbaas | 09:34 | |
*** reedip has quit IRC | 09:34 | |
*** reedip has joined #openstack-lbaas | 09:37 | |
*** yuanying has joined #openstack-lbaas | 09:39 | |
*** amotoki has quit IRC | 09:40 | |
*** reedip has quit IRC | 09:43 | |
*** yuanying has quit IRC | 09:44 | |
*** yamamoto has joined #openstack-lbaas | 09:46 | |
*** yuanying has joined #openstack-lbaas | 09:47 | |
*** reedip has joined #openstack-lbaas | 09:48 | |
*** yamamoto has quit IRC | 09:52 | |
*** reedip has quit IRC | 10:01 | |
*** krypto has quit IRC | 10:04 | |
*** krypto has joined #openstack-lbaas | 10:04 | |
*** amotoki has joined #openstack-lbaas | 10:16 | |
*** amotoki has quit IRC | 10:17 | |
*** sticker has quit IRC | 10:24 | |
*** oomichi has quit IRC | 10:29 | |
*** amotoki has joined #openstack-lbaas | 10:31 | |
*** oomichi has joined #openstack-lbaas | 10:33 | |
*** krypto has quit IRC | 10:35 | |
*** krypto has joined #openstack-lbaas | 10:35 | |
*** ducttape_ has joined #openstack-lbaas | 10:40 | |
*** amotoki has quit IRC | 10:40 | |
*** ducttape_ has quit IRC | 10:44 | |
*** yamamoto has joined #openstack-lbaas | 10:48 | |
nmagnezi | o/ | 10:51 |
*** yamamoto has quit IRC | 10:54 | |
*** sanfern has quit IRC | 10:55 | |
*** reedip has joined #openstack-lbaas | 10:58 | |
*** yamamoto has joined #openstack-lbaas | 11:09 | |
*** amotoki has joined #openstack-lbaas | 11:11 | |
*** yamamoto has quit IRC | 11:19 | |
*** krypto has quit IRC | 11:30 | |
*** krypto has joined #openstack-lbaas | 11:30 | |
*** cody-somerville has quit IRC | 11:42 | |
*** sanfern has joined #openstack-lbaas | 11:47 | |
*** fnaval has joined #openstack-lbaas | 11:58 | |
*** fnaval has quit IRC | 12:03 | |
*** chlong has quit IRC | 12:05 | |
*** yamamoto has joined #openstack-lbaas | 12:20 | |
*** yamamoto has quit IRC | 12:25 | |
*** ducttape_ has joined #openstack-lbaas | 12:41 | |
*** reedip has quit IRC | 12:52 | |
*** krypto has quit IRC | 12:59 | |
*** krypto has joined #openstack-lbaas | 13:00 | |
*** ducttape_ has quit IRC | 13:13 | |
*** links has quit IRC | 13:20 | |
*** yamamoto has joined #openstack-lbaas | 13:22 | |
*** yamamoto has quit IRC | 13:28 | |
*** catintheroof has joined #openstack-lbaas | 13:30 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia master: Updated from global requirements https://review.openstack.org/451046 | 13:38 |
*** chlong has joined #openstack-lbaas | 13:40 | |
*** catintheroof has quit IRC | 13:41 | |
*** krypto has quit IRC | 13:42 | |
*** krypto has joined #openstack-lbaas | 13:42 | |
*** sticker has joined #openstack-lbaas | 13:45 | |
*** fnaval has joined #openstack-lbaas | 13:58 | |
*** reedip has joined #openstack-lbaas | 14:00 | |
*** ducttape_ has joined #openstack-lbaas | 14:02 | |
*** armax has joined #openstack-lbaas | 14:11 | |
*** armax has quit IRC | 14:15 | |
*** fnaval has quit IRC | 14:15 | |
*** yamamoto has joined #openstack-lbaas | 14:24 | |
*** yamamoto has quit IRC | 14:29 | |
reedip | o/ | 14:32 |
xgerman | o/ | 14:36 |
*** kobis has quit IRC | 14:47 | |
*** blogan_ is now known as blogan | 14:51 | |
*** armax has joined #openstack-lbaas | 14:53 | |
*** fnaval has joined #openstack-lbaas | 14:54 | |
*** amotoki has quit IRC | 14:56 | |
*** cpuga has joined #openstack-lbaas | 15:02 | |
*** rcernin has quit IRC | 15:05 | |
diltram | johnsom: ping | 15:06 |
diltram | https://review.openstack.org/#/c/405922/54/octavia/api/v2/controllers/pool.py@82 | 15:07 |
johnsom | Diltram pong | 15:07 |
diltram | can you take a look into this ^^ link | 15:07 |
diltram | I'm making a review of this code | 15:07 |
diltram | and if I'm right those updates should be done in one session | 15:07 |
nmagnezi | johnsom, someone sent me this today.. maybe we should add it to the lbaas mascot votes http://imgur.com/a/atOLO | 15:08 |
johnsom | Yes | 15:08 |
johnsom | nmagnezi That is funny | 15:09 |
johnsom | Though we already voted and I sent in our vote. | 15:09 |
johnsom | diltram So, it looks like they are sharing the passed in session. What am I missing? | 15:09 |
diltram | but every call has own commit | 15:10 |
diltram | so we can have a situation that we updated load balancer | 15:10 |
diltram | and then different server will try to change listeners | 15:11 |
diltram | but they was not changed | 15:11 |
diltram | so we can change their status back to active | 15:11 |
diltram | do you understand what I'm trying to tell? | 15:12 |
johnsom | Well, we lock out an LB and listener in the database by putting those in pending. I think what you are saying is this is not using a non-autocommit session, so LB could go active while the listeners are still being updated. Correct? | 15:12 |
openstackgerrit | Shashank Kumar Shankar proposed openstack/octavia master: Run Octavia API in a WSGI server https://review.openstack.org/440934 | 15:13 |
diltram | yes | 15:13 |
diltram | and then we can even change their status in different process | 15:13 |
diltram | and this process will overwrite those values for ACTIVE | 15:13 |
diltram | because it's just updating them not verifying anything | 15:13 |
johnsom | Well, another process can't change it while it is not in active | 15:14 |
diltram | well it not suppose to | 15:14 |
johnsom | They are blocked if it is in a PENDING_*, but I can see the race condition here | 15:14 |
diltram | but bugs always exist :P | 15:14 |
diltram | ok | 15:15 |
*** cpuga has quit IRC | 15:15 | |
*** cpuga has joined #openstack-lbaas | 15:16 | |
johnsom | We should wrap both of those at line 119 with a non-autocommit db session, IMO | 15:16 |
diltram | agree | 15:17 |
johnsom | Good catch | 15:17 |
diltram | thx | 15:17 |
rm_work | kk | 15:23 |
rm_work | yeah that was something i had to recently add | 15:23 |
rm_work | so it had not really gone through as much review | 15:23 |
rm_work | so we need to use lock-session there, and not commit till the end, got it | 15:24 |
johnsom | It can be a new session, I don't think it should be tied into the upper session. | 15:25 |
rm_work | k | 15:25 |
rm_work | so just... make a new lock_session there | 15:25 |
rm_work | and that's it? | 15:25 |
*** yamamoto has joined #openstack-lbaas | 15:26 | |
rm_work | hmm | 15:27 |
rm_work | really that should be *anywhere* that uses _reset_lb_and_listener_statuses() right? | 15:28 |
johnsom | Yes, | 15:28 |
johnsom | I think on the lock side we include it in the lock session there. | 15:29 |
rm_work | I mean, we have the lock_session already in post(), I can reuse that right? | 15:29 |
rm_work | oh, hmm maybe not | 15:29 |
johnsom | No, I don't think so | 15:29 |
rm_work | might be post-rollback for that | 15:29 |
johnsom | It should commit by then | 15:30 |
rm_work | actually... | 15:30 |
rm_work | k yeah i see | 15:30 |
rm_work | wait | 15:30 |
johnsom | I purposefully separated the handler code from the initial API code. | 15:30 |
rm_work | what is the condition? | 15:30 |
rm_work | there's nothing after that which can fail, is there? | 15:31 |
*** yamamoto has quit IRC | 15:31 | |
rm_work | adding a lock session there would be ... lock_session -> do that -> commit | 15:31 |
rm_work | which is not useful | 15:31 |
johnsom | At 119? | 15:31 |
rm_work | yes? | 15:31 |
rm_work | i'm trying to figure out how the pool update at 123 is relevant | 15:32 |
openstackgerrit | Merged openstack/octavia master: Updated from global requirements https://review.openstack.org/451046 | 15:32 |
rm_work | it's the only other thing that writes to the session, right? | 15:32 |
johnsom | It would mean all of the updates to the status (LB, listener, and pool in this case) will occur atomicly as one collective. So you don't have a situation where an LB is partially unlocked in the DB and another process grabs it and starts using it. | 15:32 |
rm_work | oh, internally | 15:32 |
rm_work | got it | 15:32 |
johnsom | It's like a split-second possible race conditiion | 15:33 |
rm_work | right, there's multiple *internal* things | 15:33 |
rm_work | I was thinking of it as one function -> one op | 15:33 |
johnsom | Right | 15:33 |
rm_work | can I just put the lock_session inside that function? | 15:34 |
rm_work | so it takes care of all three places? | 15:34 |
rm_work | because it can be a separate lock_session from anything else, right? | 15:34 |
rm_work | or does the pool status update after that also matter for this | 15:34 |
rm_work | ah i'll just be safe and do it outside, including the pool update | 15:36 |
xgerman | +1 better safe then sorry | 15:37 |
rm_work | diltram / johnsom: https://gist.github.com/rm-you/f57fc3bd85235e801025d0fa020a16ad#file-gistfile1-txt-L8-L20 | 15:38 |
rm_work | does that look reasonable? | 15:38 |
rm_work | basically cloning that across to put/delete as well | 15:38 |
diltram | I know | 15:38 |
rm_work | or could I do it better as a context-manager? | 15:38 |
diltram | I had the same filing that we can make some decorator or anything to handle this | 15:39 |
johnsom | Yep, look fine to me | 15:39 |
rm_work | yeah, decorator was a thought | 15:39 |
rm_work | but not sure how to make that work internally on multiple lines | 15:39 |
rm_work | that's what context-managers are for | 15:39 |
diltram | agree :) | 15:39 |
diltram | go for it man :D | 15:40 |
rm_work | lol | 15:40 |
rm_work | k | 15:40 |
reedip | johnsom : any updates on yesterday;s discussion about the diversity tag ??? | 15:45 |
reedip | just curious | 15:46 |
johnsom | They postponed the vote | 15:46 |
*** ducttape_ has quit IRC | 15:46 | |
rm_work | I mean it's just this, right? https://gist.github.com/rm-you/7f13ececa82d7ecf6e7c46387409dc9c | 15:47 |
*** ducttape_ has joined #openstack-lbaas | 15:47 | |
rm_work | johnsom: well, that's good, i was legit worried | 15:47 |
*** ducttape_ has quit IRC | 15:47 | |
johnsom | I am trying to come back with some thoughts on the criteria used. Basically it looks like 56% of the core reviews were from one company, Rackspace. Which has the PTL and two out of four cores, so, kind of expected I would think. | 15:47 |
johnsom | We need rm_work and diltram to step up the reviews and others to step up their reviews to become core... grin | 15:48 |
rm_work | lol | 15:49 |
johnsom | Using their tool these are the results: | 15:50 |
johnsom | https://www.irccloud.com/pastebin/kAQ0AEHz/ | 15:50 |
johnsom | Percentages are "from a single company" | 15:51 |
xgerman | a lot of this stuff is sending up a trial balloon and see who complains. Silence is consent with those guys | 15:52 |
johnsom | So the only metric that doesn't qualify is the "top core review %" | 15:52 |
xgerman | yeah, we should aim for “probabtion” and step up our game | 15:52 |
johnsom | I am trying to think about a way to propose different math, I think it's weighted wrong for small teams. The intent is to have a measure of if the project will die if one company pulls out. | 15:54 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Install DIB from source so depends-on will work https://review.openstack.org/444707 | 15:54 |
xgerman | well, if RAX pulls out there would be some hit… | 15:55 |
johnsom | Yes, there would be some hit, but I don't think it would be dead | 15:56 |
*** ducttape_ has joined #openstack-lbaas | 15:56 | |
rm_work | it's OK, if RAX pulls out, johnsom will find a job with another company to continue being Octavia PTL, right? :P | 15:56 |
*** aojea_ has quit IRC | 15:56 | |
rm_work | we could use you here | 15:57 |
johnsom | Hahaha, well, it's happened once before | 15:57 |
xgerman | rm_work lol | 15:57 |
*** amotoki has joined #openstack-lbaas | 15:57 | |
johnsom | Assuming I don't throw my hands up and go bake bread or something... | 15:57 |
johnsom | Though I don't see that happening any time soon, so... | 15:58 |
xgerman | ther eis some leadership training by a bakery | 15:58 |
*** tesseract has quit IRC | 15:58 | |
rm_work | just watch a lot of Cake Boss | 15:58 |
reedip | johnsom : well , I am trying :D | 15:59 |
johnsom | Ugh, I'm more of a Duff fan myself | 15:59 |
xgerman | http://lists.openstack.org/pipermail/openstack-dev/2017-March/113267.html | 15:59 |
xgerman | all paid for by the foundation | 15:59 |
johnsom | http://www.charmcitycakes.com/ | 16:00 |
reedip | johnsom : whats the criteria for core :D | 16:00 |
xgerman | “reviews in line with other core reviewers” | 16:00 |
johnsom | reedip Good quality reviews at a quantity in line with the other cores per stackalytics | 16:00 |
xgerman | but it’s not about who is core but the # of core reviews in that metric | 16:01 |
johnsom | http://stackalytics.com/report/contribution/octavia-group/90 | 16:01 |
reedip | johnsom and whats the time duration , I mean how long would the results be checked for ? One release ? | 16:02 |
johnsom | reedip Trying to game the system? | 16:02 |
johnsom | We typically look at the 30 day and 90 day charts. Quality is a factor here. Just +1'ing everything will not get you there.... | 16:03 |
reedip | johnsom : as if others arent smart enough ?? :) | 16:03 |
xgerman | afk for a bit | 16:03 |
*** amotoki has quit IRC | 16:03 | |
reedip | johnsom : exactly, thats y the system cant be gamed | 16:03 |
johnsom | Yeah | 16:03 |
reedip | so I guess the +% and Disagreement ratio may also matter | 16:04 |
reedip | IIUC +% should be < 80 | 16:04 |
reedip | I mean its not necessary for one to just +1 everything , as you said :) | 16:04 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Introduce Octavia v2 API for pools https://review.openstack.org/405922 | 16:04 |
rm_work | yeah, 70-80% is ok I think, though it does depend a bit on the quality of the code being pushed up during a cycle :P | 16:06 |
johnsom | Right | 16:06 |
rm_work | I had 90% for a bit because I was pretty much only reviewing johnsom's code... not like before when I was also reviewing a lot of blogan's stuff | 16:06 |
rm_work | ^_^ | 16:06 |
johnsom | Hahaha. | 16:07 |
rm_work | I wonder what mine is right now | 16:07 |
blogan | im sorry | 16:07 |
reedip | hehehe | 16:08 |
rm_work | blogan: no it was good, I needed your reviews to keep my +/- ratio in line | 16:08 |
* johnsom gives blogan a cookie | 16:08 | |
blogan | well, glad i could help and ill happily accept the cookie, even though i know its one them tracking cookies | 16:09 |
blogan | jokes on you though, i just stay home | 16:09 |
reedip | anyways, thanks guys for the information ... will help me to get somewhere :) | 16:12 |
blogan | reedip: glad i could help :) | 16:13 |
reedip | blogan : :=) | 16:13 |
*** krypto has quit IRC | 16:14 | |
*** krypto has joined #openstack-lbaas | 16:15 | |
*** krypto has quit IRC | 16:15 | |
*** krypto has joined #openstack-lbaas | 16:15 | |
*** krypto has quit IRC | 16:15 | |
*** krypto has joined #openstack-lbaas | 16:16 | |
*** krypto has quit IRC | 16:16 | |
*** krypto has joined #openstack-lbaas | 16:16 | |
*** krypto has quit IRC | 16:16 | |
*** krypto has joined #openstack-lbaas | 16:17 | |
*** krypto has quit IRC | 16:17 | |
rm_work | diltram: posting the fix for your other comment now | 16:20 |
rm_work | then should be good again | 16:20 |
rm_work | if that was it :) | 16:20 |
rm_work | diltram / johnsom: up for merging that now and looking at members? | 16:20 |
johnsom | I will take a quick look again | 16:21 |
rm_work | sec, posting one more change as soon as tests finish running | 16:21 |
rm_work | pep8 tests take longer to START than functional tests take to finish, wonder what's up with that | 16:21 |
*** yamamoto has joined #openstack-lbaas | 16:27 | |
johnsom | DIB is now an infra project BTW, it merged yesterday | 16:28 |
*** yamamoto has quit IRC | 16:33 | |
rm_work | ah cool | 16:40 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Introduce Octavia v2 API for pools https://review.openstack.org/405922 | 16:41 |
rm_work | ok there we go, got distracted and tests were finished <_< | 16:41 |
rm_work | oh man, I just found the Michael Johnson that is an Olympic sprinter :P | 16:46 |
rm_work | I'm currently enjoying this page: https://en.wikipedia.org/wiki/Michael_Johnson | 16:46 |
johnsom | Yeah, had to hang up the gold shoes.... | 16:49 |
* johnsom wonders why Adam is stalking him... | 16:51 | |
ankur-gupta-f4 | I remember him. he was a boss | 16:51 |
johnsom | He was | 16:51 |
rm_work | I just saw it in an article about something else | 16:51 |
rm_work | and was like: lolwut | 16:51 |
johnsom | Crazy fast | 16:52 |
ankur-gupta-f4 | johnsom: why you no like feature classification | 16:54 |
openstackgerrit | Merged openstack/neutron-lbaas master: Fix a releasenotes issue with rst markup. https://review.openstack.org/449821 | 16:54 |
johnsom | ankur-gupta-f4 It seems a bit opinionated in it's current form | 16:55 |
ankur-gupta-f4 | yea first iteration. but you see what its getting at right? | 16:55 |
johnsom | But I left comments for the "hard" reasons I -1'd it | 16:55 |
johnsom | Yeah, I see value in knowing which driver supports L7 for example | 16:55 |
ankur-gupta-f4 | or to your point HAproxy has no one working on it. So operators should know that hey, haproxy may not support a lot of features... etc... | 16:56 |
johnsom | Yeah, I think assuming that something marked "immature" is under development might not be accurate. | 16:57 |
ankur-gupta-f4 | but its not labeling the entire driver as immature | 16:57 |
ankur-gupta-f4 | its saying that this driver's support of the QoS feature is immature | 16:58 |
ankur-gupta-f4 | or incomplete | 16:58 |
ankur-gupta-f4 | or something like that | 16:58 |
ankur-gupta-f4 | i forget the working | 16:58 |
ankur-gupta-f4 | wording* | 16:58 |
openstackgerrit | Merged openstack/octavia master: Fix get_all method for v2 LB controller https://review.openstack.org/449822 | 16:59 |
openstackgerrit | Merged openstack/octavia master: Remove unused logging import https://review.openstack.org/449455 | 16:59 |
*** amotoki has joined #openstack-lbaas | 16:59 | |
*** chlong has quit IRC | 17:03 | |
*** amotoki has quit IRC | 17:04 | |
openstackgerrit | Merged openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/451041 | 17:05 |
*** links has joined #openstack-lbaas | 17:07 | |
*** links has quit IRC | 17:19 | |
johnsom | Is anyone fixing the listener patch for the handler exception lock_session issue or should I open a bug? | 17:20 |
johnsom | I guess LB PUT might be impacted as well | 17:21 |
openstackgerrit | Merged openstack/octavia master: change genconfig output-file path https://review.openstack.org/449902 | 17:28 |
*** yamamoto has joined #openstack-lbaas | 17:29 | |
openstackgerrit | German Eichberger proposed openstack/octavia master: [WIP] Adds the ability to failover a load balancer https://review.openstack.org/444347 | 17:32 |
openstackgerrit | Merged openstack/octavia master: Fix some reST field lists in docstrings https://review.openstack.org/450736 | 17:34 |
*** yamamoto has quit IRC | 17:35 | |
openstackgerrit | Merged openstack/octavia master: DIB: drop some dependencies https://review.openstack.org/448657 | 17:35 |
*** ducttape_ has quit IRC | 17:37 | |
*** ducttape_ has joined #openstack-lbaas | 17:38 | |
*** pcaruana has quit IRC | 17:52 | |
*** chlong has joined #openstack-lbaas | 17:58 | |
*** amotoki has joined #openstack-lbaas | 18:00 | |
*** amotoki has quit IRC | 18:05 | |
*** chlong has quit IRC | 18:07 | |
*** ducttape_ has quit IRC | 18:07 | |
*** ducttape_ has joined #openstack-lbaas | 18:09 | |
*** ducttape_ has quit IRC | 18:17 | |
*** chlong has joined #openstack-lbaas | 18:21 | |
*** aojea has joined #openstack-lbaas | 18:24 | |
rm_work | johnsom: you mean like the same thing i just fixed in pools? | 18:26 |
johnsom | Yes | 18:26 |
rm_work | I looked and didn't see where it was broken | 18:26 |
rm_work | which line in listeners? | 18:27 |
johnsom | Oh, ok. I just assumed it had the same code | 18:27 |
rm_work | it doesn't have the status reset thing | 18:27 |
rm_work | ... though I wonder if it SHOULD | 18:27 |
rm_work | that status reset function is something i wrote just for pools | 18:27 |
rm_work | i'm wondering if it DOES need to do a status reset though? :/ | 18:28 |
johnsom | It seems like it would have the same reset on handler failure. | 18:29 |
rm_work | well | 18:29 |
rm_work | it has less objects to deal with | 18:29 |
rm_work | LB would HAVE no parent object, it'd only set *itself* to ERROR | 18:29 |
rm_work | Listener though only sets itself to ERROR, I wonder if it needs to set LB back to ACTIVE? | 18:30 |
rm_work | ... or ERROR? | 18:30 |
rm_work | I'm actually not sure | 18:30 |
*** yamamoto has joined #openstack-lbaas | 18:31 | |
*** chlong has quit IRC | 18:34 | |
openstackgerrit | German Eichberger proposed openstack/octavia master: Adds the ability to failover a load balancer https://review.openstack.org/444347 | 18:34 |
xgerman | ^^ johnsom, rm_work good to go. rm_work I refrained from chnagign the failover flow too much but it should failover far more rapidly now as we have an amphora prepared - not ideal but people who want HA should be running ACTIVE-PASSIVE anyway | 18:36 |
*** yamamoto has quit IRC | 18:36 | |
*** ducttape_ has joined #openstack-lbaas | 18:37 | |
openstackgerrit | Nakul Dahiwade proposed openstack/octavia master: Introduce Octavia v2 API for Members https://review.openstack.org/405932 | 18:40 |
*** ducttape_ has quit IRC | 18:40 | |
*** openstackstatus has joined #openstack-lbaas | 18:44 | |
*** ChanServ sets mode: +v openstackstatus | 18:44 | |
*** chlong has joined #openstack-lbaas | 18:49 | |
rm_work | well i mean | 18:53 |
rm_work | that's also what the spares pool is for :P | 18:53 |
rm_work | but yes, it should definitely work this way | 18:53 |
xgerman | it’s better than before since I will build a spare before deleting the amphora | 18:53 |
rm_work | right but ... spares pool :P | 18:54 |
xgerman | yep, ig we have spares pool I will refarin from that | 18:54 |
rm_work | i mean yeah, same code as before, pick spares pool amp first, then try a build | 18:56 |
rm_work | i was just saying, in my deploy i used spares pool, so it won't be much faster :) | 18:56 |
xgerman | k | 19:00 |
*** amotoki has joined #openstack-lbaas | 19:01 | |
*** amotoki has quit IRC | 19:05 | |
rm_work | though I guess i'll have to kill spares pool when I go active/standby | 19:16 |
xgerman | no, they complement each other | 19:17 |
rm_work | because it doesn't really work for apolocation | 19:17 |
xgerman | hu? | 19:17 |
rm_work | when you are using apolocation | 19:17 |
rm_work | it sends a scheduler hint to nova | 19:17 |
rm_work | based on the existing amp | 19:17 |
rm_work | right? | 19:17 |
rm_work | but if you pull from the spares pool... | 19:18 |
johnsom | Correct | 19:18 |
xgerman | mmh, that should be a bug | 19:18 |
rm_work | might get an amp in the same location as your existing | 19:18 |
rm_work | ahhh sorry, antiaffinityu | 19:18 |
rm_work | wrong term | 19:18 |
xgerman | yep, got it | 19:18 |
johnsom | Spares pool and the anti-affinity setting (optional) don't work well together | 19:18 |
xgerman | well, we should file a bug and fix it ;-) | 19:19 |
rm_work | yeah i guess we could, uhh | 19:19 |
johnsom | I don't know that nova gives us a way to fix it | 19:19 |
rm_work | store the cell info or something in the amp table | 19:19 |
rm_work | and uhh | 19:19 |
rm_work | hope that with enough amps, it is statistically distributed | 19:19 |
johnsom | We do store the server group already | 19:19 |
rm_work | ok | 19:19 |
rm_work | so maybe we could do it manually... | 19:19 |
johnsom | What if we add the instance to the server group nova migrates it? | 19:20 |
xgerman | would it do that for us? | 19:20 |
johnsom | I don't think so | 19:20 |
rm_work | lol | 19:20 |
johnsom | That is kind of what we would be asking for though | 19:21 |
xgerman | well, we can always interrogate the spare amps and picke the one which fits and/or build a new one | 19:21 |
johnsom | Hmm, maybe | 19:23 |
johnsom | Oh, neat, they added "soft-anti-affinity" so it doesn't just fail if there aren't enough hosts. | 19:24 |
johnsom | We should add that option | 19:24 |
xgerman | k | 19:25 |
*** ducttape_ has joined #openstack-lbaas | 19:30 | |
xgerman | johnsom somehow that failover flow ignores the server_group if I am not blind | 19:31 |
*** yamamoto has joined #openstack-lbaas | 19:32 | |
*** openstackgerrit has quit IRC | 19:33 | |
*** ducttape_ has quit IRC | 19:33 | |
*** chlong has quit IRC | 19:34 | |
*** yamamoto has quit IRC | 19:38 | |
rm_work | I THOUGHT it used it... | 19:38 |
xgerman | I can’t see where we bring it into the flow | 19:40 |
*** cpuga_ has joined #openstack-lbaas | 19:46 | |
johnsom | Yeah, it might. We may have skipped that due to the spares issue / what if it can't be filled... | 19:47 |
xgerman | well, I will see if I can straighten things | 19:48 |
*** cpuga has quit IRC | 19:50 | |
rm_work | anyone for +A on https://review.openstack.org/#/c/405922/ ? diltram? xgerman? | 19:52 |
rm_work | diltram: you reviewed already, right? so if I fixed your issue... | 19:52 |
diltram | rm_work: moment | 19:54 |
johnsom | Octavia meeting starting soon on #openstack-meeting-alt | 19:56 |
rm_work | ah yeah, about to be meeting time... | 19:56 |
diltram | rm_work: merged | 19:56 |
rm_work | diltram: sweet! thanks | 19:57 |
rm_work | MEMBERS TIME! | 19:57 |
johnsom | +1 | 19:57 |
rm_work | really want to get done with *everything* by EOW | 19:57 |
rm_work | if possible | 19:57 |
diltram | +1 | 19:57 |
rm_work | though i haven't actually looked at HMs or L7 | 19:57 |
rm_work | ... and I may not be around Thursday/Friday actually T_T at least during normal hours | 19:57 |
diltram | :P | 19:58 |
rm_work | hopefully can review members after the meeting? I'll go through it again right now | 19:59 |
johnsom | HM needs work last I heard | 19:59 |
rm_work | k :/ | 19:59 |
*** amotoki has joined #openstack-lbaas | 20:02 | |
rm_work | hmm i think members may need to be updated per the pools status reset stuff | 20:02 |
rm_work | right? | 20:02 |
*** amotoki has quit IRC | 20:06 | |
*** yamamoto has joined #openstack-lbaas | 20:34 | |
*** yamamoto has quit IRC | 20:40 | |
*** openstackgerrit has joined #openstack-lbaas | 20:41 | |
openstackgerrit | Merged openstack/octavia master: Introduce Octavia v2 API for pools https://review.openstack.org/405922 | 20:41 |
*** gcheresh_ has quit IRC | 20:42 | |
johnsom | Cores, the backport we talked about in the meeting: https://review.openstack.org/#/c/451564/ | 20:56 |
*** amotoki has joined #openstack-lbaas | 21:02 | |
*** amotoki has quit IRC | 21:07 | |
rm_work | working on a members update | 21:08 |
*** ducttape_ has joined #openstack-lbaas | 21:08 | |
*** ducttape_ has quit IRC | 21:21 | |
*** aojea has quit IRC | 21:34 | |
*** yamamoto has joined #openstack-lbaas | 21:36 | |
rm_work | almost done (maybe) | 21:40 |
*** yamamoto has quit IRC | 21:42 | |
*** cpuga has joined #openstack-lbaas | 21:44 | |
*** ducttape_ has joined #openstack-lbaas | 21:44 | |
*** cpuga_ has quit IRC | 21:46 | |
johnsom | diltram Why is lxd gate running for stable/ocata? | 21:48 |
johnsom | rm_work Can you clear your -1 on https://review.openstack.org/#/c/446959/? | 21:49 |
rm_work | removed for now | 21:59 |
rm_work | but still need to look at it further | 21:59 |
rm_work | why didn't my -1 clear on the new patchset? | 21:59 |
johnsom | DIB doesn't do stable branches so we are stuck updating this stuff | 21:59 |
johnsom | Not sure on that | 22:00 |
rm_work | ok that's ... a lot better | 22:01 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Introduce Octavia v2 API for Members https://review.openstack.org/405932 | 22:01 |
rm_work | ^^ | 22:01 |
rm_work | johnsom: yeah but doesn't dib-utils still exist in pypi? | 22:01 |
rm_work | or did they DELETE it? | 22:01 |
johnsom | They don't package | 22:01 |
johnsom | Right? | 22:02 |
johnsom | Before we were git clone the package in | 22:02 |
rm_work | err | 22:02 |
rm_work | ah | 22:02 |
rm_work | hmm maybe? | 22:02 |
rm_work | but it was in our requirements, no? | 22:02 |
rm_work | dib-utils | 22:02 |
rm_work | and we had to switch to disk-image-builder | 22:02 |
rm_work | and also, if it's cloned in, why did this patch even need to exist? https://review.openstack.org/#/c/444707/ | 22:03 |
johnsom | dib-utils wasn't in requirements for newton at least | 22:03 |
*** amotoki has joined #openstack-lbaas | 22:03 | |
johnsom | Yeah , not in ocata either | 22:04 |
johnsom | https://github.com/openstack/octavia/commit/cf9a8c8f779a3542681a4b3ea3274681cec6f682 | 22:07 |
johnsom | That removed the clone | 22:07 |
*** amotoki has quit IRC | 22:08 | |
*** fnaval has quit IRC | 22:13 | |
rm_work | lol thanks | 22:16 |
rm_work | linking me a patch *I wrote* to prove me wrong >_< | 22:16 |
rm_work | that's just cold | 22:16 |
rm_work | so ... we WERE using DIB from master | 22:17 |
rm_work | until that patch? | 22:17 |
rm_work | so why such pushback against just doing the same again? | 22:17 |
rm_work | re: my patch above | 22:17 |
*** yamamoto has joined #openstack-lbaas | 22:38 | |
*** yamamoto has quit IRC | 22:42 | |
johnsom | For me it's about trying to find some way out of this treadmill with DIB changes | 22:45 |
rm_work | yeah... :/ | 22:48 |
johnsom | Ugh, I screwed up that cherry pick anyway.... Ugh | 22:49 |
rm_work | lol | 22:51 |
*** reedip has quit IRC | 22:51 | |
johnsom | Ok, this one for newton seems to pass: https://review.openstack.org/#/c/451586/ | 22:51 |
johnsom | But it didn't actually run any tests... What is this craziness? SKIPPED: LBaaS Extension is not enabled | 22:53 |
*** ducttape_ has quit IRC | 22:57 | |
openstackgerrit | Michael Johnson proposed openstack/neutron-lbaas master: Imported Translations from Zanata https://review.openstack.org/449037 | 22:57 |
*** amotoki has joined #openstack-lbaas | 23:04 | |
*** amotoki has quit IRC | 23:09 | |
*** reedip has joined #openstack-lbaas | 23:26 | |
*** reedip has quit IRC | 23:31 | |
*** yamamoto has joined #openstack-lbaas | 23:39 | |
*** Guest59958 has joined #openstack-lbaas | 23:41 | |
*** yamamoto has quit IRC | 23:44 | |
Guest59958 | Hello, I was wondering if I should remove the extra sections in this blueprint: https://review.openstack.org/#/c/450505/, since it appears to be failing jenkins review, or should I leave them? | 23:44 |
*** reedip has joined #openstack-lbaas | 23:45 | |
johnsom | Guest59958 Hi | 23:49 |
johnsom | Guest59958 This should go under: https://github.com/openstack/octavia/tree/master/specs/version1 as load balancing is no longer a neutron project. | 23:50 |
johnsom | There is also a template that has to be used: https://github.com/openstack/octavia/blob/master/specs/skeleton.rst for that test to pass. | 23:52 |
johnsom | Looking at the spec, there is an extra white space at the top and the lines are too long. The test will fail for those issues as well. | 23:53 |
*** reedip has quit IRC | 23:54 | |
Guest59958 | johnsom: Thanks. Does that mean any code commits would also be made to the Octavia repository rather than neutron-lbaas? | 23:57 |
*** cpuga has quit IRC | 23:58 | |
johnsom | Guest59958 It would be best, but you can still submit them to neutron-lbaas until the Pike-2 milestone when we will feature freeze neutron-lbaas from future feature additions. The load balancing API will be in octavia going forward. | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!