| johnsom | rm_work lol - wow - how did I screw that up.... | 00:00 |
|---|---|---|
| rm_work | I could possibly give you a step by step breakdown? :P | 00:00 |
| johnsom | Ha | 00:00 |
| johnsom | My only worry is now I have some patch on the other branch... ha | 00:01 |
| rm_work | I was hoping you would respond "they're not tricks, they're illusions!" but I guess that would really be my line, since you're Michael <_< | 00:04 |
| johnsom | https://review.openstack.org/#/c/431781 | 00:05 |
| *** beardedeagle has quit IRC | 00:09 | |
| *** gongysh has joined #openstack-lbaas | 00:19 | |
| *** ducttape_ has quit IRC | 00:19 | |
| openstackgerrit | Merged openstack/octavia master: Add common base type for v1 and v2 https://review.openstack.org/423542 | 00:27 |
| openstackgerrit | xurong00037997 proposed openstack/neutron-lbaas master: Use neutron-lib's context module https://review.openstack.org/428592 | 00:31 |
| *** ducttape_ has joined #openstack-lbaas | 00:50 | |
| *** yuanying has quit IRC | 01:12 | |
| *** yuanying has joined #openstack-lbaas | 01:13 | |
| *** amotoki has joined #openstack-lbaas | 01:14 | |
| *** amotoki has quit IRC | 01:17 | |
| *** amotoki has joined #openstack-lbaas | 01:17 | |
| *** amotoki_ has joined #openstack-lbaas | 01:18 | |
| *** gongysh has quit IRC | 01:20 | |
| *** amotoki has quit IRC | 01:21 | |
| *** ducttape_ has quit IRC | 01:22 | |
| *** fnaval has quit IRC | 01:22 | |
| openstackgerrit | xurong00037997 proposed openstack/neutron-lbaas master: Use neutron-lib's context module https://review.openstack.org/428592 | 01:46 |
| openstackgerrit | Li Jingjing proposed openstack/neutron-lbaas master: Trivial-fix:fix typo in .pylintrc https://review.openstack.org/430709 | 02:08 |
| openstackgerrit | ZhaoBo proposed openstack/neutron-lbaas master: Use the new tempest module https://review.openstack.org/431811 | 02:11 |
| *** ducttape_ has joined #openstack-lbaas | 02:15 | |
| *** sanfern has joined #openstack-lbaas | 02:16 | |
| *** anilvenkata has joined #openstack-lbaas | 02:26 | |
| *** ducttape_ has quit IRC | 02:34 | |
| *** harlowja has quit IRC | 02:53 | |
| openstackgerrit | Merged openstack/octavia master: Switch to use test_utils.call_until_true https://review.openstack.org/431706 | 02:54 |
| *** ducttape_ has joined #openstack-lbaas | 03:04 | |
| *** amotoki_ has quit IRC | 03:08 | |
| *** gongysh has joined #openstack-lbaas | 03:10 | |
| *** fnaval has joined #openstack-lbaas | 03:11 | |
| *** amotoki has joined #openstack-lbaas | 03:13 | |
| openstackgerrit | xurong00037997 proposed openstack/neutron-lbaas master: Use neutron-lib's context module https://review.openstack.org/428592 | 03:24 |
| *** ducttape_ has quit IRC | 03:28 | |
| *** ducttape_ has joined #openstack-lbaas | 03:42 | |
| *** links has joined #openstack-lbaas | 03:50 | |
| *** ducttape_ has quit IRC | 03:52 | |
| *** beardedeagle has joined #openstack-lbaas | 04:12 | |
| *** anilvenkata has quit IRC | 04:20 | |
| *** faizy has joined #openstack-lbaas | 04:28 | |
| *** cody-somerville has quit IRC | 04:39 | |
| *** fnaval has quit IRC | 04:42 | |
| *** amotoki has quit IRC | 04:42 | |
| *** ducttape_ has joined #openstack-lbaas | 04:43 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/431891 | 04:48 |
| *** fnaval has joined #openstack-lbaas | 04:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia master: Updated from global requirements https://review.openstack.org/431893 | 04:49 |
| *** fnaval has quit IRC | 04:57 | |
| *** ducttape_ has quit IRC | 05:05 | |
| *** amotoki has joined #openstack-lbaas | 05:22 | |
| *** amotoki has quit IRC | 05:24 | |
| *** amotoki has joined #openstack-lbaas | 05:25 | |
| *** anilvenkata has joined #openstack-lbaas | 05:39 | |
| *** cody-somerville_ has joined #openstack-lbaas | 06:00 | |
| *** armax has quit IRC | 06:15 | |
| *** itsuugo has joined #openstack-lbaas | 06:40 | |
| *** beardedeagle has quit IRC | 06:58 | |
| *** eezhova has joined #openstack-lbaas | 07:03 | |
| *** rcernin has joined #openstack-lbaas | 07:03 | |
| *** ducttape_ has joined #openstack-lbaas | 07:05 | |
| *** ducttape_ has quit IRC | 07:11 | |
| *** faizy has quit IRC | 07:28 | |
| *** pcaruana has joined #openstack-lbaas | 07:30 | |
| *** faizy has joined #openstack-lbaas | 07:31 | |
| *** yamamoto has quit IRC | 07:52 | |
| *** faizy_ has joined #openstack-lbaas | 08:02 | |
| *** eezhova has quit IRC | 08:04 | |
| *** faizy has quit IRC | 08:05 | |
| *** faizy__ has joined #openstack-lbaas | 08:05 | |
| *** faizy_ has quit IRC | 08:09 | |
| *** faizy has joined #openstack-lbaas | 08:09 | |
| *** faizy__ has quit IRC | 08:12 | |
| *** kobis has joined #openstack-lbaas | 08:14 | |
| *** yamamoto has joined #openstack-lbaas | 08:28 | |
| *** eezhova has joined #openstack-lbaas | 08:31 | |
| *** yamamoto_ has joined #openstack-lbaas | 08:36 | |
| *** yamamoto has quit IRC | 08:39 | |
| *** faizy has quit IRC | 08:46 | |
| *** faizy has joined #openstack-lbaas | 08:47 | |
| *** amotoki has quit IRC | 09:01 | |
| *** kobis has quit IRC | 09:02 | |
| *** kobis has joined #openstack-lbaas | 09:07 | |
| *** kobis has quit IRC | 09:08 | |
| *** ducttape_ has joined #openstack-lbaas | 09:08 | |
| *** ducttape_ has quit IRC | 09:13 | |
| *** yamamoto_ has quit IRC | 09:24 | |
| *** jsheeren has joined #openstack-lbaas | 09:30 | |
| *** yamamoto has joined #openstack-lbaas | 09:35 | |
| *** itsuugo has quit IRC | 09:36 | |
| *** faizy_ has joined #openstack-lbaas | 09:42 | |
| *** yamamoto has quit IRC | 09:43 | |
| *** faizy has quit IRC | 09:45 | |
| *** jsheeren has quit IRC | 09:57 | |
| *** ct_ has joined #openstack-lbaas | 10:05 | |
| *** ct_ has quit IRC | 10:06 | |
| *** Guest74963 has joined #openstack-lbaas | 10:13 | |
| *** openstackgerrit has quit IRC | 10:18 | |
| *** ducttape_ has joined #openstack-lbaas | 11:09 | |
| *** Guest74963 has quit IRC | 11:10 | |
| *** ducttape_ has quit IRC | 11:14 | |
| *** faizy_ has quit IRC | 11:20 | |
| *** sanfern has quit IRC | 11:22 | |
| *** sanfern has joined #openstack-lbaas | 11:23 | |
| *** yamamoto has joined #openstack-lbaas | 11:25 | |
| *** yamamoto has quit IRC | 11:29 | |
| *** Alex_Staf has joined #openstack-lbaas | 11:33 | |
| *** kobis has joined #openstack-lbaas | 11:35 | |
| *** tesseract has joined #openstack-lbaas | 11:50 | |
| *** ducttape_ has joined #openstack-lbaas | 12:23 | |
| *** faizy_ has joined #openstack-lbaas | 12:31 | |
| *** Alex_Staf has quit IRC | 12:37 | |
| *** gongysh has quit IRC | 12:37 | |
| *** faizy_ has quit IRC | 12:56 | |
| *** ducttape_ has quit IRC | 13:18 | |
| *** faizy has joined #openstack-lbaas | 13:19 | |
| *** eezhova has quit IRC | 13:53 | |
| *** links has quit IRC | 13:55 | |
| *** ducttape_ has joined #openstack-lbaas | 13:57 | |
| *** eezhova has joined #openstack-lbaas | 13:59 | |
| *** ducttape_ has quit IRC | 14:12 | |
| *** ducttape_ has joined #openstack-lbaas | 14:40 | |
| *** ducttape_ has quit IRC | 14:51 | |
| *** ducttape_ has joined #openstack-lbaas | 14:53 | |
| *** sanfern has quit IRC | 15:06 | |
| *** sanfern has joined #openstack-lbaas | 15:07 | |
| *** faizy_ has joined #openstack-lbaas | 15:14 | |
| *** faizy has quit IRC | 15:17 | |
| *** fnaval has joined #openstack-lbaas | 15:30 | |
| *** cody-somerville has joined #openstack-lbaas | 15:54 | |
| *** csomerville has joined #openstack-lbaas | 15:56 | |
| *** cody-somerville has quit IRC | 16:00 | |
| *** rcernin has quit IRC | 16:06 | |
| *** armax has joined #openstack-lbaas | 16:18 | |
| *** anilvenkata has quit IRC | 16:30 | |
| *** hjensas has quit IRC | 16:44 | |
| *** tesseract has quit IRC | 16:45 | |
| *** pcaruana has quit IRC | 16:53 | |
| *** openstackgerrit has joined #openstack-lbaas | 17:01 | |
| openstackgerrit | Merged openstack/octavia master: Updated from global requirements https://review.openstack.org/431893 | 17:01 |
| *** harlowja has joined #openstack-lbaas | 17:05 | |
| *** harlowja has quit IRC | 17:05 | |
| *** harlowja has joined #openstack-lbaas | 17:05 | |
| openstackgerrit | Nakul Dahiwade proposed openstack/octavia master: Add v2 load balancer type and controllers https://review.openstack.org/423543 | 17:08 |
| *** faizy_ has quit IRC | 17:17 | |
| *** eezhova has quit IRC | 17:22 | |
| openstackgerrit | Merged openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/431891 | 17:34 |
| openstackgerrit | Shashank Kumar Shankar proposed openstack/octavia master: Introduce Octavia v2 API for pools https://review.openstack.org/405922 | 17:35 |
| *** sanfern has quit IRC | 17:45 | |
| *** sanfern has joined #openstack-lbaas | 17:46 | |
| *** sanfern has quit IRC | 17:46 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Fix Octavia v1 API project_id for POST https://review.openstack.org/431207 | 17:58 |
| *** beardedeagle has joined #openstack-lbaas | 18:20 | |
| *** ducttape_ has quit IRC | 18:41 | |
| *** _beardedeagle has joined #openstack-lbaas | 18:55 | |
| *** beardedeagle has quit IRC | 18:55 | |
| *** _beardedeagle has quit IRC | 18:56 | |
| *** beardedeagle has joined #openstack-lbaas | 18:56 | |
| *** ducttape_ has joined #openstack-lbaas | 19:38 | |
| *** eezhova has joined #openstack-lbaas | 19:46 | |
| *** itsuugo has joined #openstack-lbaas | 19:55 | |
| *** csomerville has quit IRC | 20:26 | |
| *** csomerville has joined #openstack-lbaas | 20:36 | |
| *** ducttape_ has quit IRC | 20:53 | |
| *** gNantel has joined #openstack-lbaas | 20:57 | |
| *** ducttape_ has joined #openstack-lbaas | 21:15 | |
| openstackgerrit | Sindhu Devale proposed openstack/octavia master: Octavia v2 API for listeners https://review.openstack.org/424744 | 21:21 |
| *** gNantel has quit IRC | 21:24 | |
| openstackgerrit | Shashank Kumar Shankar proposed openstack/octavia master: Introduce Octavia v2 API for pools https://review.openstack.org/405922 | 21:44 |
| *** csomerville has quit IRC | 21:54 | |
| openstackgerrit | German Eichberger proposed openstack/neutron-lbaas master: [WIP] Octavia Proxy Plugin https://review.openstack.org/418530 | 21:58 |
| rm_work | ^^ so we will use this for ease of testing? :P | 22:02 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Create api-ref for Octavia https://review.openstack.org/432480 | 22:06 |
| *** eezhova has quit IRC | 22:10 | |
| *** ankur-gu_ has joined #openstack-lbaas | 22:30 | |
| rm_work | whoops, realized i missed a bit in the network patch | 22:48 |
| rm_work | err, network_id | 22:48 |
| rm_work | wtf | 22:51 |
| rm_work | https://github.com/openstack/octavia/blob/master/octavia/tests/unit/network/drivers/neutron/test_allowed_address_pairs.py#L286-L290 | 22:53 |
| rm_work | I don't think that test is supposed to be doing that | 22:53 |
| rm_work | Our testing is really making me sad recently | 22:54 |
| rm_work | A ton of this stuff just doesn't test what it's supposed to, so I end up having to spend more time fixing existing tests to work like they should have to begin with than actually writing my own code (or my own additional tests for changes) :( | 22:55 |
| rm_work | But, I can really only blame myself too, because I should have paid more attention to the tests when reviewing to begin with | 22:56 |
| rm_work | I'm sure I +2'd a lot of these | 22:56 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Add network_id to VIP to match neutron-lbaas https://review.openstack.org/429926 | 22:58 |
| *** catintheroof has quit IRC | 23:03 | |
| johnsom | I guess it is checking for a bogus vip being passed in? | 23:03 |
| johnsom | I.e. one with no data | 23:03 |
| rm_work | that's not ... that test at all | 23:04 |
| rm_work | i mean that could BE a test | 23:04 |
| rm_work | but it isn't THAT test | 23:04 |
| *** catintheroof has joined #openstack-lbaas | 23:04 | |
| rm_work | anyway, i'm removing that code because I am removing that check, since we're now validating all that stuff at the API layer like we should have been to begin with, lol | 23:05 |
| johnsom | Well, FYI I am taking one for the team and diving into docs work | 23:05 |
| rm_work | yeah | 23:05 |
| rm_work | thanks for that | 23:05 |
| rm_work | and like I said, i have only myself to blame for not holding people accountable as much as I should have for quality unit tests to begin with | 23:05 |
| rm_work | I am just lamenting | 23:05 |
| johnsom | Yeah, that was early code.... | 23:06 |
| johnsom | (I think) | 23:06 |
| rm_work | and when things "work" functionally I tend to glaze over a bit by the time i get to the test_ section of the reviews T_T | 23:06 |
| rm_work | I wish our tests sorted to the top | 23:06 |
| rm_work | lol | 23:06 |
| johnsom | I figured now was a good time to start the API-REF as I can work on it while I test the patches. The work kind of goes hand in hadn | 23:07 |
| rm_work | yeah so that'll be basically a corrected version of the n-lbaas api ref, right? | 23:07 |
| *** catintheroof has quit IRC | 23:08 | |
| rm_work | I wish it'd just ... generate, based on the types <_< | 23:08 |
| johnsom | Yes, we should come out with api-ref for both v1 (deprecated/experimental) and v2 with V2 having priority in the new api-ref guideline format | 23:08 |
| johnsom | That is my goal at least. Huge bonus: It will be in-tree | 23:09 |
| rm_work | lol | 23:09 |
| *** yamamoto has joined #openstack-lbaas | 23:27 | |
| *** yamamoto has quit IRC | 23:31 | |
| *** beardedeagle has quit IRC | 23:32 | |
| *** kobis has quit IRC | 23:38 | |
| *** cody-somerville_ has quit IRC | 23:48 | |
| *** ducttape_ has quit IRC | 23:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!