| *** ducttape_ has joined #openstack-lbaas | 00:01 | |
| rm_work | yeah, the real issue was just it getting the wrong interface because it only checked for network_id | 00:03 |
|---|---|---|
| rm_work | technically maybe we should actually check the subnet_id instead of the network_id? >_> | 00:04 |
| rm_work | johnsom: is that a +1 until you test it? | 00:05 |
| johnsom | +1 until there are release notes | 00:06 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Fix the amphora failover flow docs diagram https://review.openstack.org/431232 | 00:06 |
| rm_work | ah k | 00:11 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Fix the amphora failover flow docs diagram https://review.openstack.org/431232 | 00:21 |
| johnsom | derp | 00:23 |
| rm_work | ok making a change to the name-length one that you should like | 00:24 |
| *** cody-somerville has quit IRC | 00:26 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Allow a configuration option for random Amphora name https://review.openstack.org/431186 | 00:27 |
| rm_work | how do I make a new release note? | 00:28 |
| rm_work | Is there a command? | 00:28 |
| rm_work | I've seen the files in the past, they look uuid-like | 00:28 |
| johnsom | $ reno new slug-goes-here | 00:28 |
| johnsom | Created new notes file in releasenotes/notes/slug-goes-here-95915aaedd3c48d8.yaml | 00:28 |
| johnsom | http://docs.openstack.org/developer/reno/usage.html | 00:29 |
| rm_work | kk | 00:29 |
| rm_work | does a bugfix need a release note? :/ | 00:30 |
| rm_work | ah I guess "fixes" k | 00:30 |
| johnsom | Only if it was a significant bug or has some impact on someone using/deploying | 00:31 |
| johnsom | In this case it changes behavior/adds functionality so it would be nice to let people know. | 00:32 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Allow to create vip in lb-mgmt-net https://review.openstack.org/431179 | 00:35 |
| rm_work | also possibly pre-caught what could maybe have been a weird bug | 00:36 |
| rm_work | I think | 00:36 |
| rm_work | line 317/318 | 00:36 |
| rm_work | i think that's required now? | 00:36 |
| johnsom | yes, good catch | 00:39 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Add network_id to VIP to match neutron-lbaas https://review.openstack.org/429926 | 00:42 |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Fix Octavia v1 API project_id for POST https://review.openstack.org/431207 | 00:43 |
| johnsom | Ok, I think that is good for review | 00:43 |
| * rm_work looks | 00:44 | |
| johnsom | http://logs.openstack.org/79/431179/2/check/gate-octavia-pep8-ubuntu-xenial/7793524/console.html#_2017-02-09_00_38_54_287668 | 00:47 |
| rm_work | srsly | 01:08 |
| rm_work | FML | 01:08 |
| rm_work | OH GOD it's this mess | 01:11 |
| rm_work | pycharm, which normally chooses the correct indentation, chooses the wrong one for these because the "correct" indentation is also wrong, because it's the same as the next line | 01:11 |
| rm_work | I don't remember how to resolve this >_< | 01:12 |
| johnsom | Just bump it in more | 01:12 |
| rm_work | but then it's at the same indentation as the next logical line | 01:13 |
| rm_work | which is also an error | 01:13 |
| rm_work | ./octavia/network/drivers/neutron/allowed_address_pairs.py:318:5: E129 visually indented line with same indent as next logical line | 01:13 |
| rm_work | fixed_ip.ip_address != amphora.lb_network_ip): | 01:13 |
| johnsom | Right. bump it in more than the next line | 01:13 |
| rm_work | uhh | 01:13 |
| rm_work | but then isn't it wrong again? | 01:13 |
| * rm_work checks | 01:13 | |
| rm_work | ah I guess not | 01:14 |
| rm_work | but i'm fixing it a different way anyway | 01:14 |
| johnsom | Ok. Stepping away for a bit. I will likely be back around later | 01:15 |
| rm_work | kk | 01:16 |
| *** cpuga has quit IRC | 01:17 | |
| *** ducttape_ has quit IRC | 01:22 | |
| rm_work | wow, the test_plug_vip unit test is just... wrong | 01:26 |
| rm_work | lol | 01:26 |
| rm_work | whelp | 01:27 |
| *** beardedeagle has joined #openstack-lbaas | 01:57 | |
| armax | johnsom: I did this | 02:10 |
| armax | https://review.openstack.org/#/c/431251/ | 02:10 |
| armax | no bot cheered | 02:10 |
| johnsom | It must be slacking off | 02:10 |
| johnsom | Or it is not setup for stable somehow | 02:11 |
| armax | oh | 02:11 |
| armax | that might be it | 02:11 |
| armax | actually it is it | 02:12 |
| armax | https://github.com/openstack-infra/project-config/blob/master/gerritbot/channels.yaml#L1112 | 02:12 |
| armax | I never noticed that | 02:13 |
| *** ianychoi has quit IRC | 02:13 | |
| *** ianychoi has joined #openstack-lbaas | 02:13 | |
| johnsom | I will take a look at the patch after dinner | 02:16 |
| rm_work | ugh | 02:17 |
| rm_work | johnsom: so the unit testing for plug_vip in test_allowed_address_pairs is totally useless | 02:18 |
| rm_work | I am starting to rewrite it so I can actually have a test for plugging on same-net | 02:18 |
| rm_work | but | 02:18 |
| rm_work | fff i don't have the mental energy for this right now | 02:18 |
| rm_work | blogan: I am crying on the inside right now https://github.com/openstack/octavia/blame/master/octavia/tests/unit/network/drivers/neutron/test_allowed_address_pairs.py#L250-L284 | 02:20 |
| rm_work | a bunch of the stuff that sets up isn't even called, and we don't test for what should be T_T | 02:20 |
| rm_work | I wonder if people changed it out from under the test and didn't update it because it didn't fail | 02:20 |
| *** kberger has quit IRC | 02:33 | |
| *** kberger has joined #openstack-lbaas | 02:33 | |
| *** ducttape_ has joined #openstack-lbaas | 02:38 | |
| *** cody-somerville_ has quit IRC | 02:39 | |
| *** gongysh has quit IRC | 02:40 | |
| *** gongysh has joined #openstack-lbaas | 02:40 | |
| *** gongysh has quit IRC | 02:45 | |
| *** cody-somerville_ has joined #openstack-lbaas | 02:52 | |
| johnsom | I have made some patches to the AAP driver so maybe I'm guilty | 02:55 |
| *** openstackstatus has quit IRC | 02:58 | |
| *** coreycb has quit IRC | 02:59 | |
| *** openstackstatus has joined #openstack-lbaas | 03:01 | |
| *** ChanServ sets mode: +v openstackstatus | 03:01 | |
| *** coreycb has joined #openstack-lbaas | 03:05 | |
| *** yuanying has quit IRC | 03:05 | |
| *** yuanying has joined #openstack-lbaas | 03:07 | |
| *** beardedeagle has quit IRC | 03:08 | |
| *** yuanying has quit IRC | 03:11 | |
| *** armax has quit IRC | 03:31 | |
| *** links has joined #openstack-lbaas | 03:33 | |
| *** dileepr has quit IRC | 03:39 | |
| *** ducttape_ has quit IRC | 03:44 | |
| *** beardedeagle has joined #openstack-lbaas | 03:44 | |
| *** ducttape_ has joined #openstack-lbaas | 03:44 | |
| *** ducttape_ has quit IRC | 03:56 | |
| *** fnaval has joined #openstack-lbaas | 04:34 | |
| *** beardedeagle has quit IRC | 04:34 | |
| *** faizy has joined #openstack-lbaas | 04:35 | |
| *** amotoki has joined #openstack-lbaas | 04:46 | |
| *** amotoki_ has joined #openstack-lbaas | 04:47 | |
| *** amotoki has quit IRC | 04:51 | |
| *** fnaval has quit IRC | 04:51 | |
| *** fnaval has joined #openstack-lbaas | 04:52 | |
| *** ducttape_ has joined #openstack-lbaas | 04:55 | |
| *** cody-somerville has joined #openstack-lbaas | 05:27 | |
| *** cody-somerville has quit IRC | 05:28 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia master: Fix a bug where ports may not be deleted https://review.openstack.org/431324 | 05:34 |
| *** amotoki has joined #openstack-lbaas | 05:51 | |
| *** amotoki has quit IRC | 05:52 | |
| *** amotoki has joined #openstack-lbaas | 05:52 | |
| *** amotoki_ has quit IRC | 05:54 | |
| *** amotoki_ has joined #openstack-lbaas | 05:56 | |
| *** amotoki has quit IRC | 06:00 | |
| *** ducttape_ has quit IRC | 06:02 | |
| *** yuanying has joined #openstack-lbaas | 06:07 | |
| *** kberger has quit IRC | 06:32 | |
| *** cody-somerville has joined #openstack-lbaas | 06:35 | |
| *** csomerville has joined #openstack-lbaas | 06:42 | |
| *** cody-somerville has quit IRC | 06:45 | |
| *** eezhova has joined #openstack-lbaas | 06:54 | |
| *** kobis has joined #openstack-lbaas | 06:55 | |
| *** rcernin has joined #openstack-lbaas | 07:00 | |
| *** ducttape_ has joined #openstack-lbaas | 07:03 | |
| *** amotoki_ has quit IRC | 07:05 | |
| *** amotoki has joined #openstack-lbaas | 07:05 | |
| *** tesseract has joined #openstack-lbaas | 07:11 | |
| *** yamamoto has quit IRC | 07:17 | |
| *** gongysh has joined #openstack-lbaas | 07:29 | |
| *** pcaruana has joined #openstack-lbaas | 07:36 | |
| *** eezhova has quit IRC | 07:46 | |
| *** yamamoto has joined #openstack-lbaas | 07:53 | |
| *** yamamoto_ has joined #openstack-lbaas | 07:54 | |
| *** hjensas has joined #openstack-lbaas | 07:56 | |
| *** hjensas has quit IRC | 07:56 | |
| *** hjensas has joined #openstack-lbaas | 07:56 | |
| *** yamamoto has quit IRC | 07:57 | |
| *** yamamoto_ has quit IRC | 08:09 | |
| *** faizy has quit IRC | 08:11 | |
| *** faizy has joined #openstack-lbaas | 08:12 | |
| *** eezhova has joined #openstack-lbaas | 08:13 | |
| *** ducttape_ has quit IRC | 08:14 | |
| *** rcernin has quit IRC | 08:50 | |
| *** openstackgerrit has quit IRC | 09:03 | |
| *** rcernin has joined #openstack-lbaas | 09:06 | |
| *** amotoki has quit IRC | 09:11 | |
| *** jsheeren has joined #openstack-lbaas | 09:12 | |
| *** jsheeren has quit IRC | 09:13 | |
| *** jsheeren has joined #openstack-lbaas | 09:13 | |
| *** Alex_Staf has joined #openstack-lbaas | 09:20 | |
| *** openstackgerrit has joined #openstack-lbaas | 09:44 | |
| openstackgerrit | Bernard Cafarelli proposed openstack/octavia master: Use cryptsetup/LUKS for encrypted ramfs https://review.openstack.org/403817 | 09:44 |
| *** dosaboy has joined #openstack-lbaas | 09:58 | |
| *** dosaboy has quit IRC | 09:58 | |
| *** dosaboy has joined #openstack-lbaas | 10:00 | |
| *** anilvenkata has joined #openstack-lbaas | 10:01 | |
| *** ducttape_ has joined #openstack-lbaas | 10:11 | |
| *** faizy has quit IRC | 10:13 | |
| *** faizy has joined #openstack-lbaas | 10:14 | |
| *** ducttape_ has quit IRC | 10:17 | |
| *** kobis has quit IRC | 10:18 | |
| *** Alex_Staf has quit IRC | 10:25 | |
| *** links has quit IRC | 10:27 | |
| *** pcaruana has quit IRC | 10:32 | |
| *** pcaruana has joined #openstack-lbaas | 10:33 | |
| *** yamamoto has joined #openstack-lbaas | 10:35 | |
| *** yuanying has quit IRC | 10:36 | |
| *** itsuugo has joined #openstack-lbaas | 10:39 | |
| *** kobis has joined #openstack-lbaas | 10:39 | |
| *** links has joined #openstack-lbaas | 10:40 | |
| *** Alex_Staf has joined #openstack-lbaas | 11:13 | |
| *** Alex_Staf has quit IRC | 11:35 | |
| *** yamamoto has quit IRC | 11:36 | |
| *** yamamoto has joined #openstack-lbaas | 11:39 | |
| *** gongysh has quit IRC | 11:41 | |
| *** links has quit IRC | 11:55 | |
| *** faizy has quit IRC | 11:59 | |
| *** Alex_Staf has joined #openstack-lbaas | 12:00 | |
| *** links has joined #openstack-lbaas | 12:07 | |
| *** ducttape_ has joined #openstack-lbaas | 12:13 | |
| *** ducttape_ has quit IRC | 12:18 | |
| *** Alex_Staf has quit IRC | 12:34 | |
| *** yamamoto has quit IRC | 12:39 | |
| *** links has quit IRC | 12:50 | |
| *** Alex_Staf has joined #openstack-lbaas | 12:55 | |
| *** ducttape_ has joined #openstack-lbaas | 13:02 | |
| *** faizy has joined #openstack-lbaas | 13:13 | |
| *** ducttape_ has quit IRC | 13:36 | |
| *** kberger has joined #openstack-lbaas | 13:45 | |
| *** gongysh has joined #openstack-lbaas | 13:52 | |
| *** ducttape_ has joined #openstack-lbaas | 14:04 | |
| *** matt-borland has joined #openstack-lbaas | 14:06 | |
| openstackgerrit | Nir Magnezi proposed openstack/octavia master: Auto detect haproxy user_group https://review.openstack.org/429398 | 14:07 |
| openstackgerrit | Nir Magnezi proposed openstack/octavia master: Auto detect haproxy user_group https://review.openstack.org/429398 | 14:09 |
| *** catintheroof has joined #openstack-lbaas | 14:31 | |
| openstackgerrit | Nir Magnezi proposed openstack/octavia master: Adds devstack plugin support for all amp base OS https://review.openstack.org/431576 | 14:40 |
| bcafarel | he I want to try that one ^ | 14:44 |
| *** fnaval has quit IRC | 14:49 | |
| *** ipsecguy has quit IRC | 14:52 | |
| *** anilvenkata has quit IRC | 15:01 | |
| *** fnaval has joined #openstack-lbaas | 15:05 | |
| *** fnaval has quit IRC | 15:06 | |
| *** fnaval has joined #openstack-lbaas | 15:06 | |
| *** jsheeren has quit IRC | 15:10 | |
| *** armax has joined #openstack-lbaas | 16:02 | |
| *** gongysh has quit IRC | 16:13 | |
| johnsom | I think we already have an environment variable for that, but I will test it out to make sure it passes down all the way. | 16:14 |
| *** Alex_Staf has quit IRC | 16:29 | |
| *** rcernin has quit IRC | 16:32 | |
| *** eezhova has quit IRC | 16:43 | |
| *** ankur-gu_ has joined #openstack-lbaas | 16:54 | |
| *** itsuugo has quit IRC | 17:00 | |
| *** catintheroof has quit IRC | 17:06 | |
| *** catintheroof has joined #openstack-lbaas | 17:07 | |
| nmagnezi | o/ | 17:10 |
| *** catintheroof has quit IRC | 17:11 | |
| *** ducttape_ has quit IRC | 17:12 | |
| nmagnezi | johnsom, ack. I saw this only in the diskimage-create script, do I was not aware of any other env variable. but sure if we can reuse i totally agree | 17:12 |
| johnsom | Yeah, all of those should work by being set in localrc | 17:13 |
| johnsom | I'm loading up a devstack right now to test | 17:13 |
| *** kobis has quit IRC | 17:13 | |
| nmagnezi | johnsom, thanks for spending cycles on this :) | 17:15 |
| nmagnezi | johnsom, btw, i updated my other patch to use DISTRO_NAME https://review.openstack.org/#/c/429398/6/elements/haproxy-octavia/post-install.d/20-haproxy-user-group-config | 17:16 |
| nmagnezi | but I still need to test it | 17:16 |
| johnsom | Nice | 17:16 |
| nmagnezi | building a new image locally now | 17:16 |
| nmagnezi | also i need to updates some existing tests | 17:16 |
| nmagnezi | to keep CI happy | 17:16 |
| johnsom | +1 and keep the cores happy | 17:16 |
| nmagnezi | that is always a good idea. | 17:18 |
| *** tesseract has quit IRC | 17:18 | |
| johnsom | Hmm, ok, doesn't look like it is working. I will investigate more and if the existing env doesn't work we will move forward with your change. | 17:21 |
| *** eezhova has joined #openstack-lbaas | 17:24 | |
| *** pcaruana has quit IRC | 17:30 | |
| *** Alex_Staf has joined #openstack-lbaas | 17:30 | |
| *** Alex_Staf has quit IRC | 17:46 | |
| johnsom | nmagnezi Still around? | 17:46 |
| nmagnezi | johnsom, yes | 17:47 |
| nmagnezi | johnsom, just about to spin a devstack to review those api patches | 17:47 |
| nmagnezi | :) | 17:47 |
| johnsom | Cool | 17:47 |
| johnsom | So, you are right with your patch for devstack | 17:47 |
| nmagnezi | johnsom, nice to know :) | 17:47 |
| johnsom | I was wondering, should we do the same for the release ID? I.e. xenial, 7, etc. | 17:47 |
| nmagnezi | johnsom, I can add that if you wish | 17:48 |
| johnsom | I think that would be good. Easier for use to transition to centos 8... grin | 17:48 |
| johnsom | '-d' distribution release id (default on ubuntu: xenial)" | 17:48 |
| nmagnezi | johnsom, it's actually a good idea, we would just need to keep it tidy so we won't feed the script ubuntu version when ppl choose centos or rhel for example | 17:49 |
| johnsom | Then I think that patch is good | 17:49 |
| nmagnezi | johnsom, so I need to submit another patchset, also with the condition i just mentioned. so I'll do my best to get to that today. | 17:51 |
| johnsom | +1 | 17:52 |
| nmagnezi | i just don't want to feed the script with a ubuntu version when not needed. even if it works it might changed in the future | 17:53 |
| johnsom | Yeah, we can do a condition to only add it if it is present | 17:54 |
| *** SumitNaiksatam has joined #openstack-lbaas | 18:02 | |
| *** ducttape_ has joined #openstack-lbaas | 18:04 | |
| *** eezhova has quit IRC | 18:07 | |
| *** catintheroof has joined #openstack-lbaas | 18:26 | |
| *** Alex_Staf has joined #openstack-lbaas | 18:26 | |
| *** csomerville has quit IRC | 18:27 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/octavia master: Switch to use test_utils.call_until_true https://review.openstack.org/431706 | 18:36 |
| rm_work | nmagnezi / johnsom: personally I feel like "even if it works it might changed in the future" is exactly why we SHOULD have a default, so it doesn't get changed out from under us and break all of our stuff like it did before | 18:43 |
| *** ducttape_ has quit IRC | 18:52 | |
| *** eezhova has joined #openstack-lbaas | 18:55 | |
| johnsom | Yeah, I kind of lean the same way. That is why I added those options in the first place | 18:55 |
| nmagnezi | rm_work, i'm not sure i'm following, Adam. for the os flavor we keep the default (ubuntu) with my patch. and I'll just do the same for distribution (xenail if ubuntu, otherwise unset) | 18:56 |
| rm_work | ah so *per OS* you would still pass a default version? | 18:57 |
| rm_work | so for ubuntu we would leave the default as "xenial", not unset? | 18:57 |
| rm_work | the way i read that first was that we would unset all defaults for distro-version | 18:57 |
| *** csomerville has joined #openstack-lbaas | 18:59 | |
| rm_work | "I think we should also expose the release parameter here, | 18:59 |
| rm_work | '-d' distribution release id (default on ubuntu: xenial)" | 18:59 |
| rm_work | Include it only if it is defined vs. setting a default." | 18:59 |
| rm_work | nmagnezi: ^^ | 19:00 |
| *** cody-somerville has joined #openstack-lbaas | 19:02 | |
| *** cody-somerville has quit IRC | 19:02 | |
| *** cody-somerville has joined #openstack-lbaas | 19:02 | |
| *** itsuugo has joined #openstack-lbaas | 19:04 | |
| *** SumitNaiksatam has quit IRC | 19:05 | |
| *** csomerville has quit IRC | 19:05 | |
| *** Alex_Staf has quit IRC | 19:16 | |
| nmagnezi | rm_work, oh, got it now. will do that in the next ps | 19:16 |
| rm_work | nmagnezi: do what? :P | 19:17 |
| rm_work | What you said, or what I said? They are opposite I think 6-6 | 19:18 |
| rm_work | err.... s/6-6/T_T/ | 19:18 |
| *** itsuugo has quit IRC | 19:19 | |
| *** itsuugo has joined #openstack-lbaas | 19:20 | |
| *** itsuugo has quit IRC | 19:24 | |
| *** kobis has joined #openstack-lbaas | 19:24 | |
| rm_work | johnsom: does my patch make more sense when I change it to match the random-name bent? | 19:25 |
| johnsom | I will take a look again. I don't remember where we left that yesterday... | 19:27 |
| *** ducttape_ has joined #openstack-lbaas | 19:34 | |
| rm_work | updated https://review.openstack.org/#/c/431186/ to be more directly applicable, since you were understandably dubious about the conflation of the two issues | 19:34 |
| rm_work | changed the variable name and the help messages to better reflect the purpose | 19:35 |
| rm_work | and reformatted the actual code portion to be simpler | 19:37 |
| *** faizy has quit IRC | 19:39 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Add option to choose an availability_zone for amps https://review.openstack.org/424816 | 19:40 |
| rm_work | ^ just a rebasw | 19:40 |
| rm_work | *rebase | 19:40 |
| *** eezhova has quit IRC | 19:41 | |
| *** beardedeagle has joined #openstack-lbaas | 19:43 | |
| *** eezhova has joined #openstack-lbaas | 19:57 | |
| *** itsuugo has joined #openstack-lbaas | 19:57 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/octavia master: Switch to use test_utils.call_until_true https://review.openstack.org/431706 | 20:11 |
| -openstackstatus- NOTICE: Restarting gerrit due to performance problems | 20:20 | |
| rm_work | johnsom: https://review.openstack.org/#/c/428999/ | 20:27 |
| *** eezhova has quit IRC | 20:31 | |
| *** ankur-gu_ has quit IRC | 20:31 | |
| *** ankur-gu_ has joined #openstack-lbaas | 20:33 | |
| *** harlowja_ has joined #openstack-lbaas | 20:35 | |
| rm_work | johnsom: yep looks like I'll be editing the VRRP templates a bit and making the HM listen to TCP as well, and completing failover event requests <_< | 20:36 |
| rm_work | I wonder if that'll be possible to get upstream | 20:36 |
| *** harlowja has quit IRC | 20:37 | |
| *** kobis has quit IRC | 20:47 | |
| *** ducttape_ has quit IRC | 20:50 | |
| *** ducttape_ has joined #openstack-lbaas | 20:55 | |
| nmagnezi | rm_work, hi, sorry I was afk. so re "do what" I think that adding a distribution flag plus "Include it only if it is defined vs. setting a default." covers it, no? | 21:04 |
| nmagnezi | johnsom, ^^ | 21:04 |
| *** fishbone has quit IRC | 21:22 | |
| rm_work | I'm saying I *want* to set a default per OS | 21:29 |
| rm_work | if someone says ubuntu but doesn't set a specific version, I WANT to have a default of "xenial" | 21:30 |
| rm_work | and similar for centos | 21:30 |
| *** eezhova has joined #openstack-lbaas | 21:30 | |
| johnsom | I think what Nir is saying is with these options we can specify specifically which to use for the gates. The default is in our diskimage-create already. Though currently we are only listing defaults for ubuntu/xenial. centos isn't really default anywhere at this point | 21:38 |
| *** cody-somerville_ has quit IRC | 21:38 | |
| *** ducttape_ has quit IRC | 21:40 | |
| *** beardedeagle has quit IRC | 21:45 | |
| *** beardedeagle has joined #openstack-lbaas | 21:46 | |
| rm_work | kk | 21:49 |
| johnsom | You do make a good point about having defaults in multiple locations. I have added a comment to the patch about that. | 21:52 |
| *** harlowja_ has quit IRC | 21:58 | |
| *** eezhova has quit IRC | 22:00 | |
| *** harlowja has joined #openstack-lbaas | 22:05 | |
| *** ducttape_ has joined #openstack-lbaas | 22:10 | |
| *** matt-borland has quit IRC | 22:25 | |
| *** yamamoto has joined #openstack-lbaas | 22:56 | |
| *** itsuugo has quit IRC | 23:11 | |
| *** itsuugo has joined #openstack-lbaas | 23:11 | |
| *** yuanying has joined #openstack-lbaas | 23:12 | |
| *** itsuugo has quit IRC | 23:16 | |
| rm_work | johnsom: https://review.openstack.org/#/c/428999/ | 23:41 |
| rm_work | johnsom: https://review.openstack.org/#/c/431186/ | 23:42 |
| johnsom | Will have a look | 23:42 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Allow to create vip in lb-mgmt-net https://review.openstack.org/431179 | 23:46 |
| rm_work | fixed the pep8 bug, still working on tests, it's kinda ridiculous | 23:46 |
| rm_work | having to figure out how all this works | 23:46 |
| rm_work | ... which is probably a good thing | 23:46 |
| *** ipsecguy has joined #openstack-lbaas | 23:52 | |
| *** ankur-gu_ has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!