| *** xgerman has quit IRC | 00:00 | |
| ctracey | sbalukoff: updated | 00:03 |
|---|---|---|
| ctracey | Sorry was in a meeting | 00:03 |
| *** crc32 has quit IRC | 00:14 | |
| sbalukoff | ctracey: Sweet! I can add Doug. | 00:21 |
| *** mikedillion has quit IRC | 00:33 | |
| *** sbfox has joined #openstack-lbaas | 00:49 | |
| *** sbalukoff has quit IRC | 01:09 | |
| *** fnaval has quit IRC | 01:26 | |
| *** woodster_ has quit IRC | 01:45 | |
| *** fnaval has joined #openstack-lbaas | 02:25 | |
| *** sbfox has quit IRC | 02:40 | |
| *** sbfox has joined #openstack-lbaas | 03:11 | |
| *** vjay5 has joined #openstack-lbaas | 03:44 | |
| *** amotoki has joined #openstack-lbaas | 03:54 | |
| *** fnaval has quit IRC | 04:47 | |
| openstackgerrit | Brandon Logan proposed a change to stackforge/octavia: Initial migration for database structure https://review.openstack.org/114671 | 04:53 |
| blogan | ping dougwig | 05:01 |
| dougwig | Yo | 05:02 |
| blogan | we're going to probably need the openstack/common modules | 05:02 |
| dougwig | I was thinking that too | 05:03 |
| blogan | would you mind adding that to what you're doing? | 05:03 |
| blogan | i decided not to add the /etc | 05:03 |
| blogan | for the migration | 05:03 |
| blogan | at least not yet | 05:03 |
| dougwig | Sure. And ok | 05:03 |
| blogan | thanks | 05:10 |
| rm_you | man... | 05:10 |
| rm_you | I've started nitpicking my OWN patches that have +2s on them T_T | 05:11 |
| blogan | doesn't bode well for us | 05:11 |
| blogan | (as in, you'll nitpick the shit out of octavia reviews) | 05:11 |
| rm_you | heh | 05:12 |
| rm_you | was just about to look at that one | 05:12 |
| rm_you | that you just updated | 05:12 |
| blogan | that one could probably use some nitpicks and probably some "why do we need this column" or "this column's name is stupid" | 05:12 |
| rm_you | wut | 05:13 |
| rm_you | script_location = %(here)s/alembic_migrations | 05:13 |
| rm_you | does that work? | 05:13 |
| rm_you | %(here)s | 05:13 |
| blogan | yeah its alembic's notation | 05:13 |
| rm_you | crazy | 05:13 |
| blogan | a variable alembic recognizes | 05:13 |
| blogan | see my "Implements" line in the commit message? | 05:14 |
| blogan | oh yeah, updated the launchpad blueprint | 05:14 |
| rm_you | 5 comments and I haven't really gotten to code yet :) | 05:17 |
| blogan | dear god | 05:18 |
| * rm_you puts on his grammar nazi hat | 05:18 | |
| blogan | i didn't mean it as a challenge! | 05:18 |
| rm_you | did this already pass pep8/hacking? | 05:19 |
| blogan | yes | 05:19 |
| rm_you | hmm weird | 05:20 |
| blogan | where? | 05:20 |
| rm_you | thought you were supposed to have two blanks inbetween functions (when not in a class) and anything else | 05:20 |
| rm_you | but there's only one after run_migrations_online | 05:20 |
| rm_you | before you hit the if | 05:20 |
| rm_you | though that should be inside an "if __name__ == 'main': | 05:21 |
| rm_you | I believe | 05:21 |
| blogan | thats auto-created by alembic | 05:21 |
| rm_you | weird, alright | 05:21 |
| blogan | i fixed as much pep8 as I saw, but I'm sure I missed some | 05:21 |
| rm_you | not standard practice, but i guess they know what they're doing? | 05:21 |
| rm_you | errr and i mistyped above, it's if __name__ == "__main__": | 05:22 |
| blogan | however the fact that it passed makes me believe that the hacking rules we copied automatically ignored it | 05:22 |
| rm_you | so "env.py" is generated code? | 05:22 |
| blogan | yep | 05:22 |
| rm_you | you just threw the license on top and called it good? | 05:22 |
| rm_you | k, i'll not nitpick that file then I guess | 05:22 |
| blogan | pretty much | 05:22 |
| rm_you | the blank lines at the end of the multi-line comments are also weird | 05:23 |
| blogan | well fixed some obvious pep8's but that double line there is definitely something that shoulda been caught | 05:23 |
| rm_you | is "initial_create" yours or generated? | 05:24 |
| blogan | no it does run in that file, at least it complains about no license | 05:24 |
| blogan | the name? | 05:24 |
| rm_you | the code in it | 05:25 |
| rm_you | 35dee79d5865_initial_create.py | 05:25 |
| blogan | oh yeah thats mine | 05:25 |
| rm_you | I thought hacking required a blank line at the end of python files >_> | 05:25 |
| blogan | so the README, and that migration are the only 2 that I really did anything in | 05:25 |
| rm_you | i don't even understand anymore | 05:25 |
| rm_you | actually that's just plain PEP8 | 05:26 |
| blogan | you might be right, i think stephen just copied a tox.ini, its possible it had those ignored | 05:26 |
| blogan | yep running flake8 catches those | 05:27 |
| blogan | the no newline | 05:28 |
| blogan | but tox does not | 05:28 |
| rm_you | bad tox.ini i think | 05:28 |
| rm_you | let me look | 05:28 |
| rm_you | I can make a patch :P | 05:28 |
| blogan | nothign sticks out | 05:29 |
| rm_you | commands = flake8 | 05:31 |
| rm_you | doc8 specs doc/source octavia \ | 05:31 |
| rm_you | CONSTITUTION.rst HACKING.rst README.rst ROADMAP.rst | 05:31 |
| blogan | whatever flake8 tox is using is wrong, using the venv tox created and using the flake8 does not catch it | 05:31 |
| rm_you | I think it's only checking those files | 05:31 |
| rm_you | it's supposed to just be | 05:31 |
| blogan | octavia is the directory | 05:31 |
| rm_you | commands = flake8 {posargs} | 05:31 |
| blogan | and its checking that | 05:31 |
| blogan | that is probably right though | 05:32 |
| rm_you | hmm yeah i guess your thing is in that | 05:32 |
| rm_you | checking | 05:32 |
| blogan | you're thats how it should be, but don't think that will solve the problem | 05:32 |
| blogan | tox has flake8 2.1, the flake8 i just installed has 2.2 | 05:35 |
| rm_you | hmm | 05:35 |
| rm_you | still looking | 05:35 |
| blogan | and hacking 0.9 | 05:35 |
| rm_you | hmm | 05:38 |
| blogan | ive got nothing on this | 05:39 |
| rm_you | well it definitely runs on the file... | 05:41 |
| blogan | yep | 05:41 |
| rm_you | maybe I'm just wrong about the rule? | 05:42 |
| rm_you | or it is only Warning level | 05:42 |
| blogan | i don't think so | 05:42 |
| blogan | i do remember it | 05:42 |
| blogan | flake8 2.2 does catch it | 05:42 |
| rm_you | heh yeah pep8 1.5.7 catches it | 05:45 |
| rm_you | pep8 1.5.6 does not | 05:45 |
| blogan | wtf | 05:46 |
| blogan | super minor version change | 05:46 |
| rm_you | https://pypi.python.org/pypi/pep8 | 05:47 |
| rm_you | Changelog | 05:47 |
| rm_you | 1.5.7 (2014-05-29) | 05:47 |
| rm_you | Check the last line even if it does not end with a newline. (Issue #286) | 05:47 |
| rm_you | ok so | 05:48 |
| rm_you | if I go BACKWARDS it also works | 05:48 |
| rm_you | so | 05:48 |
| rm_you | in test-requirements.txt | 05:48 |
| rm_you | change the hacking line to | 05:48 |
| rm_you | hacking>=0.8.0,<0.9 | 05:48 |
| rm_you | and it works | 05:49 |
| blogan | oye | 05:49 |
| blogan | forward on pep8, backward on hacking | 05:49 |
| rm_you | well, I think older hacking pulls in older pep8? | 05:49 |
| rm_you | pep8==1.4.5 | 05:50 |
| rm_you | must not suffer from that bug | 05:50 |
| blogan | oh eyah, that probably makes sense | 05:50 |
| blogan | well | 05:50 |
| rm_you | aaaanywho | 05:50 |
| rm_you | that was a lot of time wasted for nitpicking a single blank line :P | 05:50 |
| blogan | time well spent | 05:50 |
| rm_you | which appears to be the only issue in the entire repo | 05:50 |
| blogan | is it enough of an issue to downgrade the hacking version | 05:51 |
| rm_you | lol no | 05:51 |
| blogan | then when it gets reintroduced, it'll have to be fixed then | 05:52 |
| blogan | anyway | 05:52 |
| blogan | im going to bed | 05:52 |
| rm_you | lol k | 05:52 |
| rm_you | see you tomorrow | 05:53 |
| blogan | see ya | 05:53 |
| rm_you | uhh openstack blueprint lookup got borked? :/ | 05:55 |
| rm_you | https://blueprints.launchpad.net/openstack/?searchtext=client-refactor-models | 05:57 |
| rm_you | is what the CR auto-links to, but it does not find https://blueprints.launchpad.net/python-barbicanclient/+spec/client-refactor-models | 05:57 |
| rm_you | it used to work :( | 05:57 |
| rm_you | they must have broken something when they messed with the gerrit layout stuff recently | 05:58 |
| *** orion_ has joined #openstack-lbaas | 05:59 | |
| *** orion_ has quit IRC | 06:04 | |
| *** vjay5 has quit IRC | 06:27 | |
| *** vjay5 has joined #openstack-lbaas | 06:39 | |
| *** sbalukoff has joined #openstack-lbaas | 07:05 | |
| *** sbalukoff has quit IRC | 07:06 | |
| *** vjay5 has quit IRC | 07:08 | |
| *** sbfox has quit IRC | 07:32 | |
| *** vjay5 has joined #openstack-lbaas | 07:41 | |
| *** vjay5 has quit IRC | 07:48 | |
| *** vjay5 has joined #openstack-lbaas | 08:07 | |
| *** jschwarz has joined #openstack-lbaas | 08:35 | |
| *** jschwarz has quit IRC | 09:01 | |
| *** enikanorov__ has quit IRC | 09:37 | |
| *** enikanorov has joined #openstack-lbaas | 09:43 | |
| *** vjay5 has quit IRC | 09:57 | |
| *** vjay5 has joined #openstack-lbaas | 10:04 | |
| *** woodster_ has joined #openstack-lbaas | 12:18 | |
| *** vjay5 has quit IRC | 12:40 | |
| *** orion_ has joined #openstack-lbaas | 13:59 | |
| *** amotoki has quit IRC | 14:33 | |
| dougwig | morning | 14:50 |
| *** xgerman has joined #openstack-lbaas | 15:08 | |
| *** vjay5 has joined #openstack-lbaas | 15:14 | |
| blogan | morning | 15:22 |
| *** sbfox has joined #openstack-lbaas | 15:24 | |
| blogan | looks like the IRCians are going to lose the vote | 15:30 |
| blogan | its almost like I voted for Ralph Nader, threw my vote away | 15:30 |
| *** samuelbercovici has joined #openstack-lbaas | 15:30 | |
| xgerman | you just ned to run a better campaign :-) | 15:31 |
| *** samuelbercovici has quit IRC | 15:31 | |
| blogan | need some eyes on https://review.openstack.org/#/c/114671/ | 15:33 |
| dougwig | i've been waiting for the object model arguments to firm up. | 15:36 |
| dougwig | (fwiw, btw, a10's model has pools has 1:n on listeners.) | 15:37 |
| dougwig | it's trivial to use that to create 1:n on lb's. not the other way around. | 15:37 |
| blogan | so pools can be shared in a:10s model? | 16:06 |
| blogan | lol a:10 | 16:06 |
| rm_work | yeah because THUNDER | 16:07 |
| rm_work | (who decided to name it A10 THUNDER? :P) | 16:07 |
| dougwig | yes, pools are shared. | 16:20 |
| dougwig | pools, hm, lb/vip are all root objects. listener/vport is owned by an lb. | 16:21 |
| dougwig | if you haven't voted on octavia webex vs IRC, please do so: https://review.openstack.org/#/c/116042/ | 16:21 |
| dougwig | i expect we'll close that vote on monday or tuesday. | 16:21 |
| blogan | its a runaway now | 16:21 |
| dougwig | 7 to 5 is a runaway? | 16:22 |
| dougwig | rm_work: that'd be marketing. and our soft appliances are vThunder. | 16:23 |
| *** fnaval has joined #openstack-lbaas | 16:23 | |
| *** jorgem has joined #openstack-lbaas | 16:27 | |
| blogan | its a runaway! | 16:28 |
| *** openstackgerrit has quit IRC | 16:34 | |
| *** openstackgerrit has joined #openstack-lbaas | 17:30 | |
| *** jschwarz has joined #openstack-lbaas | 17:35 | |
| *** jschwarz has quit IRC | 17:35 | |
| *** sbfox has quit IRC | 17:41 | |
| *** sbfox has joined #openstack-lbaas | 17:44 | |
| *** mestery has joined #openstack-lbaas | 18:16 | |
| *** markmcclain has joined #openstack-lbaas | 18:20 | |
| *** sbfox has quit IRC | 18:43 | |
| *** sbfox has joined #openstack-lbaas | 18:49 | |
| *** fnaval has quit IRC | 19:12 | |
| *** markmcclain has quit IRC | 19:18 | |
| *** mestery has quit IRC | 19:42 | |
| *** vjay5 has quit IRC | 19:51 | |
| *** vjay5 has joined #openstack-lbaas | 20:31 | |
| *** ptoohill has joined #openstack-lbaas | 21:07 | |
| *** crc32 has joined #openstack-lbaas | 21:19 | |
| *** orion__ has joined #openstack-lbaas | 21:31 | |
| *** orion__ has quit IRC | 21:31 | |
| *** orion__ has joined #openstack-lbaas | 21:31 | |
| *** orion_ has quit IRC | 21:33 | |
| *** orion__ has quit IRC | 21:36 | |
| *** jorgem has quit IRC | 22:02 | |
| *** ptoohill has quit IRC | 22:12 | |
| *** vjay6 has joined #openstack-lbaas | 22:41 | |
| *** vjay5 has quit IRC | 22:42 | |
| *** vivek-ebay has joined #openstack-lbaas | 22:50 | |
| *** vivek-ebay has quit IRC | 22:51 | |
| *** crc32 has quit IRC | 23:03 | |
| *** barclaac has joined #openstack-lbaas | 23:41 | |
| *** sbfox has quit IRC | 23:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!