| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: ssh-agent-credentials: Support ignore-missing-credentials param https://review.openstack.org/586554 | 00:42 |
|---|---|---|
| *** larainema has joined #openstack-jjb | 02:00 | |
| *** bkorren has joined #openstack-jjb | 05:12 | |
| *** rakkaus_ has joined #openstack-jjb | 06:36 | |
| *** rakkaus_ has quit IRC | 06:41 | |
| *** rakkaus_ has joined #openstack-jjb | 07:07 | |
| *** hashar has joined #openstack-jjb | 07:23 | |
| *** electrofelix has joined #openstack-jjb | 07:40 | |
| *** electrofelix has quit IRC | 10:12 | |
| *** larainema has quit IRC | 10:17 | |
| *** hashar is now known as hasharAway | 10:22 | |
| *** electrofelix has joined #openstack-jjb | 10:47 | |
| *** bkorren has quit IRC | 13:02 | |
| *** bkorren has joined #openstack-jjb | 13:14 | |
| zxiiro | electrofelix: FYI See this stack of patches: https://review.openstack.org/587227 it fixes the issue I mentioned yesterday. | 13:42 |
| zxiiro | electrofelix: I have a minimal reproducible test in one of the comments in the first patch | 13:43 |
| zxiiro | the "Allow dashes" one | 13:43 |
| zxiiro | electrofelix: I think we're good to go to merge them but wanted to see if you might spot something with them before we go ahead with it. | 13:43 |
| electrofelix | zxiiro: I've a suspicion that we deliberately removed the restriction on only substituting the exact object if '{obj:...}' was applied as a step towards not requiring '{obj:var}' by default | 14:00 |
| zxiiro | electrofelix: I tested a few different combinations of passing variables in with {obj:var} and without, and as far as I can tell it get's the right value. | 14:20 |
| *** bkorren has quit IRC | 14:37 | |
| Liskni_si | electrofelix: I find it really confusing that '{v}' behaves differently than 'x{v}x', but yeah, the 146d285eb92c4a63ef75a99e9a54673c2df46061 patch does seem to deliberately behave like that, even though it's hinted only in the comment, not in docs | 14:53 |
| *** rakkaus_ has quit IRC | 15:42 | |
| *** rakkaus_ has joined #openstack-jjb | 15:56 | |
| *** rakkaus_ has quit IRC | 16:01 | |
| *** electrofelix has quit IRC | 18:07 | |
| *** rakkaus_ has joined #openstack-jjb | 18:52 | |
| *** rakkaus_ has quit IRC | 18:57 | |
| *** bkorren has joined #openstack-jjb | 19:21 | |
| *** rakkaus_ has joined #openstack-jjb | 19:32 | |
| *** rakkaus_ has quit IRC | 19:37 | |
| *** bkorren has quit IRC | 20:57 | |
| *** hasharAway has quit IRC | 23:06 | |
| *** larainema has joined #openstack-jjb | 23:31 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!