| *** bkorren has joined #openstack-jjb | 05:34 | |
| *** hashar has joined #openstack-jjb | 08:02 | |
| *** rakkaus_ has joined #openstack-jjb | 09:38 | |
| *** tanhengyeow has joined #openstack-jjb | 10:31 | |
| *** larainema has quit IRC | 11:27 | |
| *** tanhengyeow has quit IRC | 12:19 | |
| *** tanhengyeow has joined #openstack-jjb | 12:47 | |
| *** bkorren has quit IRC | 13:59 | |
| *** electrofelix has joined #openstack-jjb | 14:00 | |
| zxiiro | tanhengyeow: do you have plans to implement the rest of the Nexus Platform plugin features? | 14:58 |
|---|---|---|
| tanhengyeow | zxiiro: Yup, will be working on it this week | 14:58 |
| tanhengyeow | experimenting with the Nexus Repo one | 14:59 |
| tanhengyeow | are there urgent ones that hold a higher priority? | 14:59 |
| zxiiro | tanhengyeow: cool. I just realized your weekly updates are missing the "What I plan to do next week" section. | 14:59 |
| zxiiro | tanhengyeow: a good weekly update should cover. "What I did last week", "What I got stuck on", "What I plan to do the next week" | 14:59 |
| tanhengyeow | Ah. I always put it in the email itself, maybe I should put it in the docs instead | 15:00 |
| zxiiro | tanhengyeow: that way every week you can go back and see if you met all of your goals from the previous week | 15:00 |
| tanhengyeow | zxiiro: Sounds good, I'll do that :) | 15:02 |
| zxiiro | tanhengyeow: right but your next week's plans are incredibly vague | 15:03 |
| zxiiro | tanhengyeow: if you were planning on working on Nexus IQ the next week why isn't it mentioned in your update? | 15:03 |
| zxiiro | tanhengyeow: at this point in the internship I would expect more exact updates from you. Pasting "Work on updating 1-2 Jenkins plugins" every week in your updates does not give me confidence that you did your "research" that you mentioned a few weeks ago on which plugins need updating | 15:04 |
| tanhengyeow | Ah yes, I should be more explicit | 15:04 |
| zxiiro | tanhengyeow: If you did research then where is the list of plugins you've found that need updates?, map out for the next few weeks a list of which plugins you will be working on. | 15:04 |
| zxiiro | tanhengyeow: why is "Research on more existing Jenkins plugins to update" even still in your list of updates? | 15:05 |
| zxiiro | tanhengyeow: I thought you spent like 20 hrs a few weeks ago doing that? if so I would expect to see a map of all of the plugins you discovered and that that item should no longer even be listed as a weekly task since by that statement you've already done the research. right? | 15:06 |
| zxiiro | tanhengyeow: I'm not sure what instructions your mentor has given you but by the midpoint in the internship I would expect the student to be fully aware of what they are working on week to week. Leaving room for curveballs like the one last week where we had a plugin in urgent need of adding. | 15:07 |
| zxiiro | tanhengyeow: does that sound reasonable to you? | 15:08 |
| tanhengyeow | zxiiro: Yup that sounds reasonable! I think what I can do btr is to keep track of the plugins I've investigated. I've just been doing a trial and error and see which plugins lack support and update them accordingly, probably needs more structure | 15:12 |
| zxiiro | tanhengyeow: I don't know if your mentor is having you track your hours too but imo you should. It's good practice if you ever want to get into contracting work and it allows you to look back and see how much time you've spent on each task. It let's you see how much you've improved by the end of your internship. A task that took you hours to figure out at the beginning might take you 10s of minutes to do by the end. | 15:14 |
| *** rakkaus_ has quit IRC | 15:40 | |
| *** rakkaus_ has joined #openstack-jjb | 15:54 | |
| *** rakkaus_ has quit IRC | 15:59 | |
| *** bkorren has joined #openstack-jjb | 16:11 | |
| zxiiro | electrofelix: FYI I had to revert one of your patches https://review.openstack.org/586735 it breaks one of our projects' JJB so I think it causes a regression somewhere. | 16:30 |
| *** hashar is now known as hasharAway | 17:09 | |
| *** tanhengyeow has quit IRC | 17:48 | |
| electrofelix | zxiiro: can you provide a small sample that shows it occurring? is it possible that you were relying on something not being substituted by accident? | 18:05 |
| *** rakkaus_ has joined #openstack-jjb | 18:28 | |
| *** electrofelix has quit IRC | 18:31 | |
| *** rakkaus_ has quit IRC | 18:58 | |
| Liskni_si | oh, zxiiro replied to my question on https://review.openstack.org/586735 and I didn't receive it via e-mail | 19:18 |
| Liskni_si | why the hell is that? :-/ | 19:18 |
| zxiiro | Liskni_si: email filters maybe? or double check your email notifications here https://review.openstack.org/#/settings/preferences | 19:25 |
| zxiiro | Liskni_si: it should be set to "enabled" | 19:25 |
| Liskni_si | zxiiro: I used to receive e-mails a few ago just fine :-/ | 19:26 |
| Liskni_si | *a few months | 19:26 |
| zxiiro | Liskni_si: you can try asking the admins in #openstack-infra if you think it's an infra issue and not email filters. | 19:31 |
| Liskni_si | zxiiro: maybe I need to tell gerrit that I wish to watch the change? | 19:32 |
| Liskni_si | I'm used to jira/github that subscribes me automatically after commenting | 19:32 |
| *** rakkaus_ has joined #openstack-jjb | 19:32 | |
| zxiiro | Liskni_si: I see you're not listed in "Reviewers" | 19:32 |
| zxiiro | Liskni_si: that's probably why | 19:32 |
| zxiiro | Liskni_si: can you add yourself to the list? | 19:33 |
| Liskni_si | zxiiro: yeah, I can add myself to reviewers | 19:33 |
| zxiiro | Gerrit usually automatically adds you to the "reviewers" list when you comment. I wonder why you're not in this list | 19:33 |
| zxiiro | Liskni_si: maybe it's because you commented after the patch was merged. | 19:34 |
| Liskni_si | I wonder why https://review.openstack.org/#/q/is:watched is empty ... :-/ | 19:34 |
| zxiiro | Liskni_si: let me leave a new comment and you can see if it sends it to you now. | 19:34 |
| zxiiro | Liskni_si: for "is:watched" you need to go here https://review.openstack.org/#/settings/projects and add every project you want to watch | 19:35 |
| Liskni_si | oh! | 19:35 |
| zxiiro | Liskni_si: I left a test message. You should hopefully see an email now on that patch? | 19:36 |
| Liskni_si | zxiiro: yep, e-mail received | 19:36 |
| Liskni_si | zxiiro: can you try commenting out the "# special case of returning the object if the entire string" block? I think it might return an int whereas all the other code paths return string. Seems like this may be the problem. | 19:39 |
| zxiiro | Liskni_si: you mean the entire try: block? | 19:40 |
| Liskni_si | zxiiro: yeah, including the following if. everything up to the first blank line | 19:41 |
| Liskni_si | but that's going to break other things. I should look into it a bit more :-) | 19:44 |
| zxiiro | Liskni_si: that actually breaks us | 19:44 |
| zxiiro | yeah | 19:44 |
| zxiiro | I still haven't had time to track down the exact configuration that causes the issue. | 19:44 |
| zxiiro | but you can reproduce it with this repo https://github.com/opendaylight/releng-builder | 19:44 |
| zxiiro | after cloning it "git submodule init && git submodule update" then run "jenkins-jobs test -r jjb/" | 19:45 |
| zxiiro | we abuse many of JJB's features so we tend to hit bugs with JJB that some smaller projects might not catch. | 19:46 |
| *** bkorren has quit IRC | 19:55 | |
| zxiiro | Liskni_si: oh I figured out how to reproduce | 19:55 |
| zxiiro | Liskni_si: let me get a minimal example going | 19:55 |
| Liskni_si | zxiiro: you're too fast, I just remembered how to run a specific test :-) | 19:55 |
| Liskni_si | but I think I know what test to write | 19:55 |
| *** hasharAway is now known as hashar | 19:59 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Allow dashes in variable key names https://review.openstack.org/587211 | 20:00 |
| zxiiro | Liskni_si: let's continue the discussion in this new patch https://review.openstack.org/587211 | 20:01 |
| zxiiro | Liskni_si: I added my minimal test to reproduce the issue. It looks like it breaks for "macros" have have variable substitutions which have numeric values. | 20:02 |
| Liskni_si | zxiiro: yeah, because the "# special case of returning the object if the entire string" block doesn't check if "{obj:" was actually used | 20:03 |
| Liskni_si | not sure if that's a mistake or intention :-/ | 20:03 |
| Liskni_si | I'm still trying to figure out how to invoke a single fixture using tox :-/ | 20:04 |
| zxiiro | Liskni_si: I have no idea. I always run the whole thing hah | 20:04 |
| *** rakkaus_ has quit IRC | 20:23 | |
| *** hashar has quit IRC | 20:39 | |
| *** rakkaus_ has joined #openstack-jjb | 20:56 | |
| *** rakkaus_ has quit IRC | 21:00 | |
| openstackgerrit | Tomas Janousek proposed openstack-infra/jenkins-job-builder master: Test dashes in variable key names https://review.openstack.org/587226 | 21:02 |
| openstackgerrit | Tomas Janousek proposed openstack-infra/jenkins-job-builder master: Expand variables as objects only if "obj:" is specified https://review.openstack.org/587227 | 21:02 |
| Liskni_si | zxiiro: the second patch should help | 21:03 |
| zxiiro | Liskni_si: that's great! Thanks I'll try it later today. Have free few meetings to take care of | 21:04 |
| Liskni_si | zxiiro: no need to rush, I'll be asleep soon :-) | 21:06 |
| zxiiro | Liskni_si: Have a good night. Thanks for your help with this. | 21:07 |
| openstackgerrit | Tomas Janousek proposed openstack-infra/jenkins-job-builder master: Expand variables as objects only if "obj:" is specified https://review.openstack.org/587227 | 21:54 |
| *** rakkaus_ has joined #openstack-jjb | 22:01 | |
| *** rakkaus_ has quit IRC | 22:44 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!