| *** hashar has joined #openstack-jjb | 07:37 | |
| *** hashar is now known as hasharAway | 14:10 | |
| ssbarnea | zxiiro: where can I find more info about robot-comments? mainly I want to know when these will be available to gerrit *release* (not pre-release) | 16:30 |
|---|---|---|
| zxiiro | ssbarnea: if you're using gerrit 2.14 it's included in core | 16:31 |
| zxiiro | ssbarnea: just edit your gerrit trigger comment commands to include a "--tags ci" or whatever you want to use as your tag | 16:31 |
| zxiiro | ssbarnea: you don't have to install any plugins or anything | 16:31 |
| ssbarnea | 2.13.5 on intranet and 2.14.6 on gerrithub.io | 16:32 |
| zxiiro | cool so yeah that feature should already work on gerrithub.io then. you probably just need to update your comment command to add that tags thing | 16:32 |
| zxiiro | ssbarnea: you good with Java? | 16:33 |
| ssbarnea | i need to test and see the outcomes, the bad part about gerrithub.io is that I never got a reply on it, support ~= 0. | 16:33 |
| ssbarnea | it has good uptime, better than intranet one (oops). | 16:34 |
| zxiiro | ssbarnea: I really want to take this plugin https://gerrit.googlesource.com/plugins/verify-status/+/master/src/main/resources/Documentation/about.md and strip it down to only have the client part where it draws the job summary box. | 16:34 |
| zxiiro | ssbarnea: uptime makes sense to me. typically intranets don't have SLAs like public things do in my experience... | 16:34 |
| ssbarnea | zxiiro: you already have a supporter for your plugin change, i am interested about the same thing. | 16:35 |
| zxiiro | problem is I'm terrible at Java haha | 16:35 |
| ssbarnea | zxiiro: you are not the only one. | 16:36 |
| zxiiro | If I had budget I'd hire zaro_ | 16:36 |
| ssbarnea | maybe it would work with beercoins | 16:36 |
| zxiiro | ssbarnea: oh yeah I don't know if you saw but I reworked the multibranch patch over the weekend. it should be significantly easier to read and manage now. You might want to take another look at it and make sure I didn't break anything major. | 16:37 |
| zxiiro | ssbarnea: I removed a lot of configuration as well that I noticed was not available in the latest version of the plugin | 16:38 |
| ssbarnea | zxiiro: i observed, I am retesting my code now. | 16:41 |
| * zaro_ no a real beer fan | 16:43 | |
| zaro_ | ssbarnea: i know gerrithub guys. need me to pass a question along? | 16:44 |
| ssbarnea | mainly i am interested when we will be able to have nice table with ci job results in normal gerrit, like we have on openstack. | 16:45 |
| ssbarnea | i am using two other gerrit instances which do not seem to have them. | 16:46 |
| zxiiro | ah yeah that's where the stripped down version of that verify-status plugin comes in. | 16:46 |
| zaro_ | openstack implementation is a wacky hack. it's not normal. | 16:46 |
| zaro_ | gerrithub.io is normal, pretty much out of the box with some plugins. | 16:47 |
| zaro_ | the code for openstack hack is in their repo you can do the same | 16:48 |
| zxiiro | ssbarnea: here's the openstack code for that https://github.com/openstack-infra/system-config/blob/master/modules/openstack_project/files/gerrit/hideci.js | 16:48 |
| zxiiro | ssbarnea: it's just a js hack | 16:48 |
| zxiiro | although I found it doesn't work in the latest version of Gerrit | 16:49 |
| ssbarnea | zxiiro: well, even an js jack needs to be enabled *server-side*. I cannot ask users to use greasemonkey scripts. | 16:49 |
| ssbarnea | zxiiro: this would be a good reason to make it part of gerrit. | 16:49 |
| zxiiro | ssbarnea: yes which is why I'm hoping for a gerrit solution | 16:50 |
| zxiiro | I might take a stab at it but my Java skills are poor | 16:50 |
| ssbarnea | cc me on the bug, we need to start with a ticket first. | 16:50 |
| zxiiro | I spent 3 hrs last night just staring at code and tryign to understand it haha | 16:50 |
| zxiiro | ssbarnea: ok let me open one if there isn't one already. | 16:51 |
| *** openstackgerrit has joined #openstack-jjb | 16:51 | |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add multibranch project-type https://review.openstack.org/403940 | 16:51 |
| ssbarnea | zxiiro: one minor fix: 'credentials-id' param must be optional, not mandatory. | 16:52 |
| zxiiro | ssbarnea: really? what's it do when you don't provide one? In my testing it just kept failing. | 16:53 |
| ssbarnea | zxiiro: well, github api works with anonymous but is rate limited, same as auth-one, different limit. | 16:53 |
| zxiiro | ah ok I probably hit the rate limit then. that's why i thought it was required. | 16:54 |
| ssbarnea | zxiiro: so it may fail or not,... likely yes. | 16:54 |
| ssbarnea | let's revote on it and wait for 3x +2 on this patch, before adding workflow. | 16:55 |
| ssbarnea | too much time spent on it and is useless to me without gerrit part, but we will add it. | 16:55 |
| zxiiro | ssbarnea: https://bugs.chromium.org/p/gerrit/issues/detail?id=8537 | 16:57 |
| zxiiro | ssbarnea: agreed. I stripped out the Gerrit part so that we could easily review it separately. | 16:58 |
| ssbarnea | zaro_: waynr : again, same https://review.openstack.org/#/c/403940/ | 16:58 |
| zxiiro | ssbarnea: I think verify is gonna fail on patch set 37 because that made xml changes that weren't updated. | 16:59 |
| ssbarnea | indeed | 17:02 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add multibranch project-type https://review.openstack.org/403940 | 17:30 |
| *** larainema has quit IRC | 17:58 | |
| zxiiro | ssbarnea: I don't think I can cc you on a Gerrit issue. You might have to star the Issue yourself https://bugs.chromium.org/p/gerrit/issues/detail?id=8537 | 18:01 |
| *** ckonstanski has joined #openstack-jjb | 18:51 | |
| ssbarnea | i want to move creating directory message from INFO to DEBUG, when using --config-xml it creates too much spam (one folder per job) | 18:54 |
| ssbarnea | anyone against? | 18:54 |
| *** larainema has joined #openstack-jjb | 19:16 | |
| ssbarnea | zxiiro: multibranch passed. | 19:23 |
| zxiiro | great | 19:24 |
| ssbarnea | zaro_: https://review.openstack.org/#/c/87090/ - already with 2x +2 but wanting another one as we were both involved in fixing it. | 19:27 |
| ssbarnea | does anyone has an idea on how to add a new gate to jjb? one that does not have an existing zuul template? | 19:54 |
| zxiiro | ssbarnea: probably better asked in #openstack-infra I haven't worked with Zuul much myself. | 20:05 |
| ssbarnea | yep. time to learn something new | 20:06 |
| ssbarnea | i find bit awkward not to be able to create a new job just by telling the tox env to use. zuul seems to be good at templating, time to ask there. | 20:06 |
| ssbarnea | zxiiro: another approach to this would be to run "risk" code as part of py27 as additional command, after default one, avoiding the need to create a new gate. | 20:09 |
| ssbarnea | like "run tests with normal reqs, upgrade python-jenkins to master version, run tests again" | 20:09 |
| ssbarnea | i don't know what people think about this approach. | 20:09 |
| zxiiro | ssbarnea: zuul jobs are all templated. I'm sure it's just one line to add somewhere to include the additional tox env. I just don't know which files. | 20:16 |
| zxiiro | ssbarnea: plus we'd get the nice table entry for the new job | 20:16 |
| zxiiro | ssbarnea: if you ask in #openstack-infra I'm sure clark or fungi will point to where pretty quickly | 20:17 |
| ssbarnea | already there, things were moved recently. found: https://github.com/openstack-infra/project-config/blob/master/zuul.d/projects.yaml#L659 | 20:18 |
| ssbarnea | but still not sure what I need to do. | 20:18 |
| zxiiro | Omg is that ever a large file | 20:30 |
| zxiiro | I guess zuul doesn't support multi file like jjb does... | 20:31 |
| *** hasharAway has quit IRC | 23:14 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!