| *** electrofelix has joined #openstack-jjb | 08:36 | |
| *** hashar has joined #openstack-jjb | 09:51 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Add multibranch project-type https://review.openstack.org/403940 | 14:53 |
|---|---|---|
| *** electrofelix has quit IRC | 16:18 | |
| *** ckonstanski has joined #openstack-jjb | 17:22 | |
| *** ckonstanski has quit IRC | 18:45 | |
| *** ckonstanski has joined #openstack-jjb | 18:48 | |
| *** openstackgerrit has quit IRC | 19:04 | |
| *** ckonstanski has quit IRC | 19:23 | |
| *** ckonstanski has joined #openstack-jjb | 19:27 | |
| *** ckonstanski has quit IRC | 21:14 | |
| *** hashar has quit IRC | 21:27 | |
| zxiiro | zaro_: hey. I saw the patch to add a show / hide bot comments button to Gerrit was added https://gerrit-review.googlesource.com/c/gerrit/+/75882 but I don't see any docs on how to use the feature. Any pointers? | 22:28 |
| zaro_ | zxiiro: i beleive that feature was a precurser to tags on comments | 23:39 |
| zaro_ | i think it's used now for something like robot comments https://gerrit-review.googlesource.com/Documentation/config-robot-comments.html | 23:40 |
| zxiiro | zaro_: ah ok wasn't able to find that page. Thanks! | 23:40 |
| zxiiro | zaro_: we figured it out and got it setup. | 23:40 |
| zxiiro | zaro_: What about the Jenkins voting and reporting multiple jobs in a nice table feature you were working on. Did that ever make it into Gerrit official or is it a separate plugin still? | 23:41 |
| zaro_ | it's still a plugin | 23:42 |
| zaro_ | i think you can accomplish the same thing with robot comments though | 23:42 |
| zxiiro | zaro_: ah ok. this is great. Thanks for adding this feature! :) | 23:42 |
| zxiiro | yeah that' what I want to look into doing next | 23:42 |
| zaro_ | basically robot comments, if you're using it, replaced the functionality that my pluging provided | 23:43 |
| zxiiro | I guess the strategy would be to fetch the Robot comment. and then parse it and inject it back into Gerrit DOM as a pretty table? | 23:43 |
| zaro_ | yep, exactly. you would probably need to write a plugin that just does the visualization. | 23:44 |
| zaro_ | my plugin did that but it was written for the old UI. not sure if it was update in any way. | 23:47 |
| zxiiro | zaro_: cool. I'll use your plugin as a starting point then. I'll see if I can extract out only the view part and make a smaller plugin. | 23:49 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!