| waynr | hmm why is the conditional publisher so different from the conditional build step | 00:44 |
|---|---|---|
| waynr | the fact that this https://git.openstack.org/cgit/openstack-infra/jenkins-job-builder/tree/tests/publishers/fixtures/conditional-publisher002.yaml expands into this https://git.openstack.org/cgit/openstack-infra/jenkins-job-builder/tree/tests/publishers/fixtures/conditional-publisher002.xml | 00:48 |
| waynr | is somewhat annoying because it means there is no reason for the conditional-publisher semantics to be so different from the conditional builder | 00:48 |
| waynr | ie, https://docs.openstack.org/infra/jenkins-job-builder/publishers.html#publishers.conditional-publisher vs https://docs.openstack.org/infra/jenkins-job-builder/builders.html#builders.conditional-step | 00:49 |
| waynr | in the conditional builder if you want multiple different conditions each with their own set of "steps" you create multiple to-level "conditional-step" builders | 00:50 |
| waynr | in the conditional publisher however you can have multiple different conditions in a list under a single top-level "conditional-publisher" publisher | 00:51 |
| waynr | just means i need to warp the logic in the MacroRegistry to handle multi-arities that may be present in a given plugin's syntax | 00:52 |
| * waynr grumbles | 00:53 | |
| zxiiro | There's a few plugins like that. I think hindsight is probably whoever designed them where different people or didn't think about how they are related. | 01:16 |
| waynr | yeah that's what i figured | 01:20 |
| waynr | sleep deprivation is making progress slow but i'm working on a fix | 01:21 |
| zxiiro | same here. I've been working late nights over the past few days | 03:51 |
| *** openstackgerrit has quit IRC | 15:35 | |
| waynr | considering going with 530419 at this point | 18:55 |
| *** openstackgerrit has joined #openstack-jjb | 19:08 | |
| openstackgerrit | Wayne Warren proposed openstack-infra/jenkins-job-builder master: Revert "Move macro expansion into YamlParser." https://review.openstack.org/530419 | 19:08 |
| openstackgerrit | Wayne Warren proposed openstack-infra/jenkins-job-builder master: Add tests for inner macro expansion. https://review.openstack.org/530598 | 19:22 |
| waynr | path of least resistance, probably should have done this months ago | 19:29 |
| waynr | i pretty much have the decorator approach working but the whole MacroRegistry thing is kind of pointless in retrospect | 19:32 |
| waynr | particularly in light of all the spaghettic code necessary to support macro expansion from the yaml parser | 19:33 |
| waynr | s/ttic/tti/ | 19:33 |
| zxiiro | waynr: thanks for looking into this. Let's sync up with electrofelix and see if we can get a 2.0 release out the door. | 23:06 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!