| waynr | i'm gonna take a swing at that release blocker bug | 04:39 |
|---|---|---|
| waynr | gonna try to generalize my approach in 503771 by writing a decorator for plugin xml expansion functions that need to expand xml for other plugins | 04:40 |
| waynr | i'll use the conditional step builder test cases i wrote in 503771 to validate the approach works and scan over 530419 to see where the YamlParser object being passed to plugin xml expansion functions was used, write test cases for those plugins, then apply the decorator approach to them | 04:46 |
| waynr | https://storyboard.openstack.org/#!/story/2001399 | 05:26 |
| waynr | i forgot how to get to our etherpad | 05:26 |
| waynr | aha, browser history to the rescue: https://etherpad.openstack.org/p/jjb_api_v2.0 | 05:33 |
| waynr | derp. i sat down to work on this almost two hours ago and finally am writing that decorator function | 07:18 |
| openstackgerrit | Wayne Warren proposed openstack-infra/jenkins-job-builder master: Fix macro expansion in conditional step builder. https://review.openstack.org/503771 | 09:30 |
| openstackgerrit | Wayne Warren proposed openstack-infra/jenkins-job-builder master: Perform inner macro expansion using a decorator. https://review.openstack.org/530530 | 09:30 |
| waynr | since i consider myself a git incrementalist i went ahead and implemented the decorator approach on top of the existing conditional step builder patch | 09:31 |
| waynr | now to take a closer look at 530419 to see where support for inner macro expansion was removed and see if i can apply my decorator-based approach in those cases | 09:33 |
| waynr | oh hmm i must have removed those in an earlier patch than the one 530419 reverts | 09:34 |
| waynr | grep -rn registry.dispach jenkins_jobs/modules | 09:42 |
| waynr | gonna continue working on that tomorrow...or today i guess | 09:43 |
| waynr | shouldn't be too difficult to come up with test cases to validate everywhere "registry.dispatch" was being called previously...kind of annoying that there were no such test cases to begin with but i can see how it happened given that most plugin module tests can safely assume they don't need to validate macro expansion | 09:46 |
| zxiiro | waynr: wow that's great thanks for looking into this. Let me know when it's ready for testing and I can check with our repo. We're a very big user of those macro expansion stuff so we touch quite a few plugins that use it. | 16:04 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!